1 2007-09-28 Brian Warner <warner@lothar.com>
3 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
4 argument, to send email about buildslaves which are disconnected
5 for more than an hour. Closes #64.
6 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
8 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
9 (MailNotifier): add docs for this too
12 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
13 respect branch= queryargs, by restricting the builds displayed to
14 those matching the given branch names
15 * buildbot/status/web/waterfall.py (BuildTopBox): same
17 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
18 fix a test failure by adding .prepath to this fake object
20 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
21 up generation of relative URLs. With luck, this should play with
22 reverse proxies much better now.
23 * buildbot/test/test_webparts.py: new test for most of the subpages
24 * buildbot/test/test_web.py (base_config): add enough of a config
25 to exercise more Waterfall code
27 2007-09-27 Brian Warner <warner@lothar.com>
29 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
30 relative URL to the buildbot welcome page, rather than
32 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
34 * buildbot/status/web/base.py (HtmlResource.title): change the
35 default title of all Buildbot-generated page to "Buildbot"
36 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
37 change the title to include the Builder name
38 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
39 same, and also show the build number
40 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
41 redirect the browser to the Builder page
43 2007-09-26 Brian Warner <warner@lothar.com>
45 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
46 problem with the build links
48 2007-09-25 Brian Warner <warner@lothar.com>
50 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
51 to emit relative URLs instead of using URLPath,
53 * docs/buildbot.texinfo (WebStatus): provide an example
55 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
56 page, shows a simple table with one row per Builder. Still pretty
58 * buildbot/status/web/index.html: reference it
60 * buildbot/status/web/waterfall.py (Spacer): make this *not*
61 inherit from builder.Event, so that show_events=false doesn't hide
62 spacers, since that would make the waterfall weirdly compressed.
64 * buildbot/status/web/waterfall.py (HELP): put the View button in
65 its own section, so it doesn't get visually confused with the
67 (WaterfallStatusResource.body): make the '[help]' links more
68 visually distinct from each other, and add a link to the Welcome
70 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
71 unused buildslaves without exploding
73 * buildbot/status/web/waterfall.py
74 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
75 it gives us absolute paths that break proxies
76 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
77 this, it was giving bad results when the Waterfall is behind a
80 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
81 new 'upgrade-master' command, which will bring an old buildmaster
82 directory up-to-date. Right now the only thing it does is populate
83 public_html/ if it wasn't already there. Still to do: check the
84 other files, add documentation.
85 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
86 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
88 2007-08-13 Brian Warner <warner@lothar.com>
90 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
91 that contains the checkin comments when you hover over the entry
92 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
95 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
98 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
99 page with versions of python, buildbot, and twisted
100 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
101 * buildbot/status/web/index.html: add links to most pages
102 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
104 * buildbot/status/web/robots.txt: put a robots.txt in new installs
105 which discourages robot access to all large dynamically-generated
106 pages. The intention is that the index page and the 'about' page
107 are the only ones which should be crawlable.
108 * buildbot/scripts/runner.py (Maker.public_html): same
110 * setup.py: ship index.html and robots.txt in source distributions
112 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
113 activate automatic reloading of the page (using a meta Refresh:
115 (WaterfallHelp): new page to explain all the nifty query arguments
116 you can use on the Waterfall, along with forms to set them for
117 you. From this page, you can add filters for builder=, branch=,
118 show_events=, as well as turning on reload=.
119 (WaterfallStatusResource.buildGrid): new query args: last_time=,
120 first_time=, show_time=, num_events= . The old show= is still
121 accepted, but the new builder= is preferred. We ignore empty
122 branch= arguments, to make the WaterfallHelp form easier to
124 (WaterfallStatusResource.head): new method to add text to the
126 * buildbot/status/web/base.py (HtmlResource.content): use head()
127 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
128 empty branch= arguments
129 (OneLinePerBuildOneBuilder.body): same
131 2007-08-12 Brian Warner <warner@lothar.com>
133 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
134 new query args: 'last_time' is a timestamp of the top-most event
135 on the display, 'first_time' is a timestamp for the bottom-most
136 event. 'show_time' is the difference between them, and overrides
137 'first_time'. 'num_events' puts an upper limit on the number of
138 timestamps that will be displayed on the left hand edge.
139 (WaterfallStatusResource.body): add a 'next page' link to the
140 bottom, which shows the events that come just after those shown on
141 the current page. This is a first step towards #67, but we need
142 some more controls before we can close that one.
144 * buildbot/buildslave.py (BuildSlave): these are now MultiService
145 instances too, and live as children of the BotMaster. The main
146 advantage of this approach is that BuildSlaves can know when they
147 are being removed (so they can shut off the upcoming
148 when-do-we-email-an-admin-because-we-lost-our-slave timer).
149 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
150 identify which service children are BuildSlaves
151 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
152 Checker updates here, but delegate the rest to..
153 (BotMaster.loadConfig_Slaves): .. here, which looks at the
154 BotMaster's service children to identify the old slaves. I think
155 the previous approach of using master.slaves was broken in the
156 face of config updates that modified BuildSlave instances but did
157 not completely replace them.
158 * docs/buildbot.texinfo (Developer's Appendix): note the change to
159 the Service hierarchy
161 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
162 page (at URL /buildslaves/) to view status of all buildslaves at
163 once, including how long it's been since we last heard from them,
164 and which Builders use them.
166 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
169 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
172 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
173 use the BuildSlave to keep track of the last time we've heard from
174 the buildslave. This is updated upon receipt of any message from
175 any SlaveBuilder (which generally means when RemoteCommands are
176 giving us status updates, as BuildSteps run). In the future this
177 will include slave pings too.
178 * buildbot/process/base.py
179 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
180 * buildbot/process/buildstep.py:
181 (BuildStep.setBuildSlave): accept that reference
182 (BuildStep.runCommand): pass the reference on to the RemoteCommand
183 (RemoteCommand.remote_update): update the timestamp
184 (RemoteCommand.remote_complete): same
185 * buildbot/test/runutils.py (StepTester.makeStep): match the change
186 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
187 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
188 interface to retrieve this timestamp
189 * buildbot/status/builder.py (SlaveStatus): track a copy of the
193 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
195 (OneLinePerBuild.body): use a <ul> instead of <div>s
196 (OneLinePerBuildOneBuilder.body): same
198 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
199 by adding the file's new name to the list of changed files. This
200 ought to be sufficient for things like isFileImportant and trial
201 tests that only exercise tests for files that have been modified.
204 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
205 XMLRPC server to the WebStatus page. This only has two methods
206 right now (getAllBuildsInInterval and getBuild), but we'll be
207 adding more in the future. This server is extracted from the
210 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
211 generateFinishedBuilds, and improve the data displayed.
212 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
213 the per-Build page, add some information like ETA and got_revision
214 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
215 adding a list of recently completed builds
216 * buildbot/status/web/base.py (css_classes): factor this out
218 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
219 new method, to make status display classes easier to write,
220 especially the WebStatus 'one_line_per_build' page.
221 (IBuilderStatus.generateFinishedBuilds): same
222 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
223 (Status.generateFinishedBuilds): implement it
225 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
226 'source' to be a BuildStep instance, since BuildFactory accepts
228 (CPAN.__init__): same
229 (Distutils.__init__): same
230 (Trial.__init__): same
232 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
233 this might raise KeyError
235 2007-08-07 Brian Warner <warner@lothar.com>
237 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
238 'Owner:' field of the view, rather than 'p4logname', since
239 p4logname comes from the buildslave's environment and seems
240 unlikely to ever do the right thing. Thanks to Wade Brainerd for
241 the patch. Closes #40.
243 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
244 which imposes a per-slave limit on how many builds are allowed to
245 run simultaneously. This has a the same scope than the SlaveLock,
246 but is different because max_builds= gives the buildmaster the
247 freedom to assign the build to a different slave, whereas the
248 SlaveLock doesn't get tested until after the build is irrevocably
249 assigned to a slave. Therefore using max_builds= will improve
250 utilization in the presence of multiple buildslaves that are
251 attached to the same Builder. This completes the incorporation of
252 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
253 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
254 any Builder finishes, potentially trigger *all* Builders, since
255 max_builds= may have stalled someone else while waiting for the
257 * buildbot/scripts/sample.cfg: mention max_builds=
258 * buildbot/test/test_run.py (ConcurrencyLimit): test it
259 * docs/buildbot.texinfo (Buildslave Specifiers): document it
261 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
262 inherit from RunMixin do not need to call master.stopService()
263 themselves, since RunMixin.tearDown does that. The double call
264 fails on Twisted-2.0.x, which didn't happen to protect against it.
265 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
267 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
268 from #48, this one to have the BuildSlave objects track
269 SlaveBuilders, so they'll be able to use that knowledge to
270 influence their canStartBuild() response.
271 * buildbot/process/builder.py (SlaveBuilder.attached): call it
272 (SlaveBuilder.detached): same
273 * buildbot/test/test_slaves.py (BuildSlave): test it
275 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
276 the second of Dustin's #48 patches, this one adding a method to
277 the BuildSlave that allows it to decide whether it is willing to
278 participate in a build or not.
279 (SlaveBuilder.isAvailable): use canStartBuild() to decide
281 * buildbot/test/test_run.py (CanStartBuild): test for it
283 * all: incorporate the first of four patches by Dustin Mitchell
284 from ticket #48, working towards improving control over slave
285 concurrency. The first patch is to use a long-lived BuildSlave
286 object per slave, on which other behavior can be added later. I've
287 modified his patch considerably.
288 * buildbot/buildslave.py (BuildSlave): move class out of
289 slave/__init__.py (where it would get loaded by the slave as well
290 as the master, making dependencies trickier), and merge it with
291 BotPerspective. Now these BuildSlave instances are created once in
292 the master.cfg file, and not destroyed until they are either
293 removed from the config file or changed so
294 much (name/password/class changes) that we cannot continue to use
295 the old one. This affects config files: they must use
296 'from buildbot.buildslave import BuildSlave' instead of using
297 'from buildbot.slave import BuildSlave'.
298 * buildbot/master.py: move BotPerspective out
299 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
300 add or remove as necessary, update the rest using data from
302 * buildbot/slave/__init__.py: move BuildSlave out
303 * buildbot/test/test*.py: import BuildSlave from the new place
304 * buildbot/scripts/sample.cfg: update to match
305 * docs/buildbot.texinfo: update to match
306 * buildbot/process/builder.py: update comments to match
308 2007-08-02 Brian Warner <warner@lothar.com>
310 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
311 one-line-per-build pages a bit, add a header, refactor slightly
313 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
314 the TimeOutError timer, patch by Dustin Mitchell.
316 2007-08-01 Brian Warner <warner@lothar.com>
318 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
319 mostly work (branch= is still ignored, we need a useful header)
320 (OneLinePerBuildOneBuilder.body): this too
322 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
323 bring this up-to-date w.r.t. recent refactorings, and fix
324 redirections to bounce the browser to the top page after hitting
325 the 'force' button. This needs to be improved, but at least it now
326 redirects to a valid page.
327 (StatusResourceBuilder.ping): same
328 (StatusResourceBuilder.getChild): same, although I think this code
329 might be dead anyways
331 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
332 a branch= query argument, to filter the display down to builds and
333 changes that involve the given branch. You can add multiple
334 branch= arguments to see multiple branches (using a logical OR).
335 Note that there is no way to include the default branch (i.e.
336 None, i.e. trunk) yet, there is still work to be done to allow for
337 simple+uniform names of branches (i.e. removing the VC-specific
338 details of how branches are implemented, so calling the branch
339 'beta4' even though the SVN checkout step requires
341 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
342 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
343 * buildbot/interfaces.py (IEventSource.eventGenerator): same
344 * docs/buildbot.texinfo (Buildbot Web Resources): document it
346 * all: bring import statements up-to-date: don't import
347 __future__, assume cPickle and cStringIO are always available.
348 Also remove #!/usr/bin/python lines from non-scripts, my editor
349 has been a bit over-enthusiastic about stuffing them into new .py
352 * buildbot/status/web/index.html: put a link to the waterfall page
353 on the index, otherwise first-time users of WebStatus aren't going
354 to see anything very interesting.
356 * buildbot/interfaces.py (IEventSource): document this interface.
357 Thanks to Dustin Mitchell for the patch. Closes #60.
358 * buildbot/status/builder.py (BuilderStatus): same
359 * buildbot/changes/changes.py (ChangeMaster): same
361 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
362 add a query arg of 'show_events=true' to display non-build events,
363 like slaves attaching/detaching and reconfig events, or
364 'show_events=false' to hide them. The default is 'true'.
365 * docs/buildbot.texinfo (Buildbot Web Resources): document it
367 * web-parts: merge in web-parts branch. Lots of changes. The new
368 functionality is to add buildbot.status.html.WebStatus, which is a
369 superset of the Waterfall that adds new status pages and serves
370 regular files from BASEDIR/public_html/ , which is now the preferred
371 place to put robots.txt, buildbot.css, and index.html .
372 * buildbot/scripts/runner.py: the 'create-master' command now
373 creates public_html/ too, and populates it with a couple of
375 * buildbot/status/web: split waterfall code into smaller pieces
377 2007-07-31 Brian Warner <warner@lothar.com>
379 * buildbot/scripts/startup.py (launch): import twistd.run in a
380 different way to hush pyflakes
381 * buildbot/process/builder.py: remove unused import
383 2007-07-30 Brian Warner <warner@lothar.com>
385 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
386 Mitchell: pass SourceStamps around rather than branch/version/etc
387 tuples. Thanks Dustin! Closes #70.
388 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
389 tuple rather than a list, to avoid surprising mutations
390 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
391 * buildbot/status/mail.py (MailNotifier.buildMessage): same
392 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
393 * buildbot/test/test_status.py (Subscription): same
394 * buildbot/test/test_control.py (Force): same
395 * buildbot/test/test_buildreq.py (Request.testMerge): same
397 2007-07-29 Brian Warner <warner@lothar.com>
399 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
400 variable, since it wasn't used and is confusing in the presence of
401 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
404 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
405 the Buildbot home-page link to point at buildbot.net instead of
406 sourceforge, and add a current-version query parameter so we can
407 get some statistics on which versions are in use out there.
409 2007-07-28 Brian Warner <warner@lothar.com>
411 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
412 with c['change_source'], leaving c['sources'] for backwards
413 compatibility (but deprecated), scheduled for removal in 0.8.0
414 * docs/buildbot.texinfo: same
415 * buildbot/test/test_config.py: verify that c['sources'] still works
416 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
417 * buildbot/scripts/sample.cfg: update to match
419 * buildbot/changes/mail.py (MaildirSource): parse with python's
420 stdlib 'email' module, which has been available since python2.2,
421 and drop use of the 'rfc822' module, which has been depreceated
423 * buildbot/test/test_maildir.py: same: use parse_file() not parse
425 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
426 this needs to match the renaming in test/mail/msg*
428 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
431 * buildbot/test/test_mailparse.py: rename sample emails a bit
432 * buildbot/test/mail/msg*: same
434 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
435 parser for the "commit-email.pl" script that is shipped with SVN,
436 written by Justin Mason. Thanks! Closes SF#1072845.
437 * buildbot/test/mail/svn-commit.*: sample messages
438 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
439 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
441 2007-07-27 Brian Warner <warner@lothar.com>
443 * buildbot/changes/mail.py: refactor: move parsing into a method
444 named 'parse', each parser type gets a separate subclass. Remove
445 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
446 to be a simple leading-substring match. Add a warning to the logs
447 if prefix= does not end in a slash, since that's probably a
448 mistake. Fix both places where a prefix= mismatch would skip all
449 subsequent files in the same email, instead of just skipping the
450 one that didn't match.
451 * buildbot/test/test_mailparse.py: match changes
453 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
454 docs on email-based ChangeSources
456 * docs/buildbot.texinfo (Getting Source Code Changes): move all
457 the changesource types up a level, removing the one-entry menu in
460 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
461 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
462 instances instead of tuples. Closes #63.
463 * buildbot/slave/__init__.py (BuildSlave): define marker class
464 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
465 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
466 * buildbot/test/test_*.py: update tests to match
467 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
468 the c['bots'] backwards-compatibility handler works
470 2007-07-26 Brian Warner <warner@lothar.com>
472 * buildbot/changes/hgbuildbot.py (hook): add an in-process
473 Mercurial change-sending hook, contributed by Frederic Leroy.
474 Thanks! Addresses #50.
475 * docs/buildbot.texinfo (MercurialHook): document it
477 * buildbot/changes/hgbuildbot.py: change the way imports are done,
478 to make it compatible with at least hg-0.9.1 and the current 0.9.4
480 2007-07-17 Brian Warner <warner@lothar.com>
482 * buildbot/process/buildstep.py (BuildStep.getLog): add a
483 convenience method to retrieve a log added with
484 addLog()/addCompleteLog()/etc or logfiles= . I should have added
487 2007-07-03 Brian Warner <warner@lothar.com>
489 * buildbot/slave/commands.py (ShellCommand._startCommand): when
490 logging the environment variables, put one variable on each line,
491 rather than having one really long line with all of them. This
492 should make them a bit more readable and not trigger the
493 horizontal scrollbar (when viewing it in a web browser) quite so
494 much. Thanks to Albert Hofkamp for the patch.
496 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
497 WithProperties instance. Thanks to Axel Hecht for the patch.
499 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
500 * docs/buildbot.texinfo (Build Properties): document it
501 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
502 workdir if it didn't already exist.
504 * docs/buildbot.texinfo (Scheduler Types): correct the description
505 of Dependent schedulers. Thanks to Greg Ward for the patch.
507 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
508 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
509 the patch. Closes #49.
511 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
512 0700 before removing it, to deal with situations where a build will
513 leave files around without write permissions and the 'copy' or
514 'clobber' VC checkout modes need to blow away the tree first.
515 Thanks to Steve Milner for the suggestion and the patch (which I
516 mangled horribly). Closes #29.
517 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
520 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
521 an allowReconnect= argument to let callers control whether they
522 want this don't-let-it-reconnect behavior, since some tests care.
523 Factor out the .continueTrying=False lines from those callers.
524 * buildbot/test/test_slaves.py: same
525 * buildbot/test/test_run.py: same
527 2007-07-02 Brian Warner <warner@lothar.com>
529 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
530 slave has been disappeared, don't let it reconnect. This was
531 causing an intermittent failure in test_slaves.py, when the slave
532 that was supposed to be gone managed to come back by the end of
533 the test and affect the count.
534 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
536 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
537 diagnostic messages to track down this problem
538 (Builder.startBuild): same
540 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
541 the slave randomly rather than always taking the first one. Thanks
542 to Pike for the patch. Closes #36.
543 * buildbot/test/test_slaves.py: match the change. to avoid huge
544 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
545 enables/disables the round-robin-ness (enabled by default), and
546 some unit tests disable it.
547 * docs/buildbot.texinfo (Buildmaster Architecture): document it
549 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
550 argument to 'buildmaster_host', to make it more obvious that this
551 points to the buildmaster. Thanks to Bob Proulx for the
553 * buildbot/scripts/runner.py (slaveTAC): same
554 * buildbot/test/test_runner.py (Create.testSlave): match the change
556 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
559 2007-06-17 Brian Warner <warner@lothar.com>
561 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
562 we can round-trip all of our current step classes by calling
563 getStepFactory() and using the results to make a clone of the
566 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
569 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
570 the config file, we're moving to using actual instances instead of
571 the (class, kwargs) 'step specification' tuples. BuildFactory
572 still keeps a list of tuples internally, but when real instances
573 are passed in to addStep(), they are asked for their class and
574 kwargs using the new BuildStep.getStepFactory method. BuildFactory
575 accepts both instances and the tuple form, and converts instances
576 to the tuple form, but the instance form is preferred because it
577 gives the Steps a chance to do argument validation. Closes: #11.
579 * buildbot/process/buildstep.py (BuildStep.__init__): record the
580 factory information necessary to implement getStepFactory. The
581 addFactoryArguments() method can be used to include arguments that
582 aren't passed to the BuildStep base class constructor.
583 (BuildStep.setBuild):
584 (BuildStep.setDefaultWorkdir): new methods to take parameters that
585 are needed for live BuildSteps but not to construct the specification
586 tuples that are stashed in the factory.
588 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
589 'workdir' into new BuildSteps by using methods instead of
590 arguments. This makes the constructor for BuildSteps a lot
593 * buildbot/steps/*.py: update to match this change. Basically this
594 means adding calls to addFactoryArguments() in the __init__
595 methods to capture the arguments that aren't passed through to the
597 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
598 the new workdir (if any) into the RemoteShellCommands arguments.
599 * buildbot/steps/source.py: allow workdir= to be optional,
600 implement setDefaultWorkdir() since we don't inherit from
601 (CVS): finally remove old clobber=/export=/copydir= arguments,
602 in favor of the mode= argument that's been around forever now.
603 * buildbot/steps/transfer.py: remove build= argument
605 * buildbot/test/*.py: update to match, generally by turning all
606 build= arguments into subsequent calls to s.setBuild()
607 * buildbot/test/test_config.py (Factories): verify that we can
608 use either BuildStep instances or class/kwarg tuples in both
609 BuildFactory.addStep and BuildFactory.__init__
611 * docs/buildbot.texinfo (Build Steps): document the new approach,
612 mention compatibility with the old approach, update all examples
613 to use the new style.
615 2007-06-16 Brian Warner <warner@lothar.com>
617 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
618 the LoopingCall, just eat the failure so that we'll poll again
619 next time. This should allow us to tolerate (e.g.) sf.net SVN
620 failures more gracefully. Many thanks to Dustin Mitchell for the
623 2007-05-17 Brian Warner <warner@lothar.com>
625 * buildbot/status/words.py: refactor the IRC status bot into
626 separate 'Contact' and 'Channel' classes. The base Contact class
627 contains the interaction code: commands and responses. The
628 IRCContact subclass (and IrcStatusBot 'Channel') handle the
629 IRC-specific aspects. The plan is to write other subclasses for
630 other IM protocols like AIM and Jabber.
632 2007-04-16 Brian Warner <warner@lothar.com>
634 * CREDITS: update list of contributors. Thank you all!
636 2007-04-13 Brian Warner <warner@lothar.com>
638 * buildbot/status/mail.py (MailNotifier): add the project name to
639 the subject line and message body, to make it easier to
640 distinguish email coming from different buildmasters. Thanks to
641 Benoit Sigoure for the patch.
642 * buildbot/test/test_status.py (Mail): update to match
644 2007-03-24 Brian Warner <warner@lothar.com>
646 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
647 avoid text-conversion problems between DOS/windows and unix.
648 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
650 2007-03-03 Brian Warner <warner@lothar.com>
652 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
653 warning about the use of Waterfall here
655 2007-03-01 Brian Warner <warner@lothar.com>
657 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
659 2007-02-28 Brian Warner <warner@lothar.com>
661 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
662 Lamb to use a more optimal form of 'p4 changes', to reduce server
663 load. He reports that this optimization was added to p4d release
664 2005.2, but it should work in all versions. Closes #27.
665 * buildbot/test/test_p4poller.py: match it
667 2007-02-27 Brian Warner <warner@lothar.com>
669 * buildbot/status/web/*.py: move all web status stuff into a
670 separate directory, in anticipation of splitting it into smaller
671 pieces and adding more files. html.py was getting way too big.
672 * buildbot/status/classic.css: move it too
673 * setup.py: add the new sub-package
674 * buildbot/test/test_web.py: match the changes
675 * MANIFEST.in: handle the move of classic.css
677 2007-02-07 Brian Warner <warner@lothar.com>
679 * contrib/OS-X/*: add some launchd .plist files for automatically
680 starting a buildmaster or buildslave under OS-X (10.4 or later).
681 Thanks to Mark Pauley for these.
683 2007-02-06 Brian Warner <warner@lothar.com>
685 * docs/buildbot.texinfo (Requirements): update requirements to
686 stop claiming compatibility with python-2.2 or twisted-1.3.x .
688 * README: mention python-2.5 and twisted-2.5 compatibility
690 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
692 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
694 * buildbot/status/builder.py: same, by requiring cStringIO
695 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
696 * buildbot/test/test_vc.py: same
697 * buildbot/test/test_web.py:
698 * buildbot/test/test_steps.py: same, remove unused import
700 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
703 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
704 see any Builders that don't have Schedulers to drive them
706 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
707 attributes this uses went away
709 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
710 dialog, to allow you to reset the buildmaster and force
711 connect/disconnect. Correctly handle losing the buildmaster
712 connection (by switching the display to the hexnut, at which point
713 you can use the 'Connect' menu item to reconnect).
715 * buildbot/steps/source.py (Source.start): if we're using a patch,
716 add it as a LogFile to the checkout/update step. This will turn
717 into a link on the waterfall page.
719 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
720 option, to take the patch from a pre-made file rather than
721 generating it from the local tree. Thanks to Robert Helmer for the
722 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
723 * buildbot/scripts/runner.py (TryOptions): add --diff,
724 --patchlevel, and --baserev options
725 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
726 as None, meaning HEAD.
727 * buildbot/sourcestamp.py (SourceStamp): update docstring to
728 indicate that baserev=None means HEAD
729 * docs/buildbot.texinfo (try --diff): document it
731 * buildbot/test/test_steps.py (BuildStep): remove use of
732 reactor.iterate(), although the technique I replaced it with is a
733 gross polling hack that must be cleaned up properly some day. This
734 was the last use of reactor.iterate in the entire tree, yay.
736 2007-02-05 Brian Warner <warner@lothar.com>
738 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
739 is one of the three known values, otherwise we emit some confusing
740 messages later on. Thanks to Grig Gheorghiu for the catch.
742 2007-01-30 Brian Warner <warner@lothar.com>
744 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
745 Hearsum contributed a patch to let BonsaiPoller work with results
746 that contain non-ascii characters. Closes SF#1632641.
748 2007-01-27 Brian Warner <warner@lothar.com>
750 * Makefile (release): produce both .tar.gz and .zip source bundles.
753 2007-01-23 Brian Warner <warner@lothar.com>
755 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
756 * buildbot/changes/monotone.py: same
758 * buildbot/changes/maildir.py: combine several files into one,
759 clean up maildir.py to use Services properly.
760 * buildbot/changes/maildirtwisted.py: remove
761 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
763 * buildbot/changes/mail.py: match the change
764 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
765 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
767 * buildbot/slave/commands.py (command_version): bump to "2.3" to
768 indicate that the buildslave knows about the 'bzr' command
770 2007-01-22 Brian Warner <warner@lothar.com>
772 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
773 'with', it will become a reserved work in python2.6 .
775 * contrib/bb_applet.py: add a simple gnome-panel applet, to
776 display a terse summary of buildbot status.
777 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
778 some icons, small versions of the Blender object that lives in
779 docs/images/icon.blend
781 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
782 * buildbot/slave/commands.py (Bzr): same
783 * buildbot/scripts/tryclient.py (BzrExtractor): same
784 (SourceStampExtractor.dovc): modify this to allow non-zero exit
785 status, since 'bzr diff' does that
786 * buildbot/test/test_vc.py (Bzr): same
787 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
791 2007-01-20 Brian Warner <warner@lothar.com>
793 * contrib/darcs_buildbot.py: tidy up the progress messages
795 2007-01-17 Brian Warner <warner@lothar.com>
797 * contrib/darcs_buildbot.py: enhance to handle multiple patches
798 being pushed at a time. This keeps state in the repository in a
799 small file named .darcs_buildbot-lastchange, but that shouldn't
800 interfere with normal repository operations. Fixes SF#1534049.
801 * buildbot/clients/sendchange.py (Sender): make a single Sender
802 capable of sending Changes with different usernames.
804 2006-12-11 Brian Warner <warner@lothar.com>
806 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
807 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
808 buildbot.changes.mail a long time ago, but I forgot to add the
809 DeprecationWarning until now.
811 * buildbot/process/maxq.py: remove this, the functionality now
812 lives in buildbot.steps.maxq
814 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
815 * buildbot/clients/gtkPanes.py: remove unused import
817 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
818 that was meant to provide a special Reporter to run inside trial
819 and give the buildslave lots of machine-readable status. We never
820 finished this project.
822 * buildbot/changes/bonsaipoller.py: remove unused imports
823 * buildbot/changes/svnpoller.py: same
824 * buildbot/process/builder.py: same
825 * buildbot/process/buildstep.py: same
826 * buildbot/slave/bot.py: hush pyflakes warning
827 * buildbot/status/tests.py: remove unused imports
828 * buildbot/status/tinderbox.py: same
829 * buildbot/steps/python_twisted.py: same
831 * buildbot/process/step.py: remove this file, these names were
832 deprecated in 0.7.5 and are now being removed.
833 * buildbot/process/step_twisted.py: same
834 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
836 * buildbot/twcompat.py: remove the empty file, yay it is gone
838 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
839 tw-2.0.0 and newer have the method we need.
840 (getProcessOutputAndValue): same
841 (which): remove this method, tw-2.0.0 t.p.procutils has it
843 * buildbot/twcompat.py (implements): remove this method
844 * buildbot/*: import implements() from zope.interface directly
846 * buildbot/status/mail.py: stop falling back to importing
847 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
850 * buildbot/twcompat.py (Interface): remove this import
851 * buildbot/*: import Interface from zope.interface directly
853 * buildbot/twcompat.py (providedBy): remove this method
854 * buildbot/*: turn all uses of providedBy(obj, iface) into
855 iface.providedBy(obj)
857 * buildbot/twcompat.py (maybeWait): remove this method, now that
858 we no longer maintain compatibility with Twisted<=1.3.0 .
859 Twisted-2.0.0 and later allow trial methods to return Deferreds
861 * buildbot/test/*: remove all uses of maybeWait
863 * buildbot/__init__.py (version): bump to 0.7.5+ while between
865 * docs/buildbot.texinfo: same
867 2006-12-10 Brian Warner <warner@lothar.com>
869 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
870 * docs/buildbot.texinfo: set version to match
872 2006-12-10 Brian Warner <warner@lothar.com>
874 * README (REQUIREMENTS): update for release
875 * NEWS: update for release
876 * buildbot/slave/commands.py (command_version): mention that this
877 version (2.2) was released with buildbot-0.7.5
879 * buildbot/test/test_config.py (StartService.testStartService):
880 inhibit the usual read-config-on-startup behavior, since otherwise
881 the log.err that gets recorded causes the test to fail
883 * buildbot/status/builder.py (LogFile.finish): forget about all
884 subscribers once the log has finished, since after that point
885 we're never going to use them again. This might help free up some
888 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
889 than the old/deprecated gtk.mainquit()
891 2006-12-09 Brian Warner <warner@lothar.com>
893 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
894 better when we can't open the masterdst file
896 * buildbot/scripts/startup.py (Follower._failure): add missing
897 import statement for BuildSlaveDetectedError
899 * buildbot/steps/transfer.py (FileUpload): cleanup
900 (FileDownload): same. Add tests for slave version, add mode=.
901 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
902 (SlaveFileDownloadCommand): same
903 * buildbot/test/test_transfer.py: enhance tests
904 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
907 2006-12-08 Brian Warner <warner@lothar.com>
909 * buildbot/scripts/runner.py (sendchange): halt the reactor on
910 both success *and* failure. Without this, the 'buildbot
911 sendchange' command would hang if it could not contact the
912 buildmaster or deliver the Change, which would generally cause the
913 user's commit/record/checkin command to hang too. Thanks to
914 Christian Unger for the catch.
916 2006-12-06 Brian Warner <warner@lothar.com>
918 * NEWS: update with items for the next release
920 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
921 whimsical example pulled from a punch-drunk email I sent out late
923 (Transferring Files): document some of the other parameters
924 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
925 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
926 * buildbot/test/test_svnpoller.py: same
927 * buildbot/changes/svnpoller.py (SVNPoller): same
929 2006-11-26 Brian Warner <warner@lothar.com>
931 * docs/buildbot.texinfo (Build Properties): remind users that
932 WithProperties must appear in a command= list, not as a top-level
934 * buildbot/steps/shell.py (ShellCommand.start): and assert that
935 we're sending a list or a single string to the RemoteShellCommand
937 * buildbot/scheduler.py (Nightly): Improve docs slightly.
939 * buildbot/scripts/startup.py (start): skip the whole
940 watch-the-logfile thing under windows, since it needs os.fork()
942 * buildbot/scripts/runner.py (restart): remove the old message
943 that got printed after the buildbot was restarted.. it most cases
944 it didn't get printed at the right time anyways
946 2006-11-25 Brian Warner <warner@lothar.com>
948 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
949 follow twistd.log and print lines until the process has started
950 started properly. For the buildmaster, this means until the config
951 file has been parsed and accepted. For the buildslave, this means
952 until we've connected to the master. We give up after 5 seconds in
953 any case. Helpful error messages and troubleshooting suggestions
954 are printed when we don't see a successful startup. This closes the
955 remainder of SF#1517975.
956 * buildbot/scripts/startup.py: moved app startup code to here
957 * buildbot/scripts/logwatcher.py: utility class to follow log
958 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
959 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
960 so the LogWatcher can tell the difference between a buildmaster
963 2006-11-24 Brian Warner <warner@lothar.com>
965 * docs/examples/twisted_master.cfg: update to match the version
966 in use on twistedmatrix.com
967 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
968 was using before stopped working, but 'irc.freenode.net' works
971 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
974 * buildbot/clients/base.py (TextClient.not_connected): upon
975 UnauthorizedLogin failures, remind the user to connect to the
976 PBListener port instead of the slaveport.
977 (TextClient.disconnected): shut down more quietly
978 * docs/buildbot.texinfo (statuslog): add another reminder
980 * buildbot/scripts/runner.py (Options.subCommands): rename
981 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
982 'sighup' as an alias.
983 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
984 reconfig command to follow twistd.log and print all of the lines
985 from the start of the config-file reload to its completion. This
986 should make it a lot easier to discover bugs in the config file.
987 Use --quiet to disable this behavior. This addresses half of
988 SF#1517975, the other half will be to add this same utility to
989 'buildbot start' and 'buildbot restart'.
990 * docs/buildbot.texinfo (Loading the Config File): same
993 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
994 method, it has been deprecated for a long time. Use
995 IBuilderControl.requestBuild instead.
996 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
997 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
998 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
999 * buildbot/test/test_control.py (Force.testForce): same
1000 * buildbot/test/test_run.py: use requestBuild instead
1002 * buildbot/clients/debug.py: replace 'Force Build' button with
1003 'Request Build' (which just adds one to the queue), add Ping
1004 Builder, add branch/revision fields to Request Build.
1005 * buildbot/clients/debug.glade: same
1006 * buildbot/master.py: update interface to match. This creates an
1007 incompatibility between new debugclients and old buildmasters.
1009 * buildbot/process/builder.py (Builder._attached): delay the call
1010 to maybeStartBuild for a reactor turn, to avoid starting a build
1011 in the middle of a reconfig (say, if the new Builder uses a new
1012 slave which is already connected).
1014 2006-11-23 Brian Warner <warner@lothar.com>
1016 * buildbot/test/test_transfer.py: appease pyflakes
1017 * buildbot/test/test_steps.py: same
1019 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1020 keeps pyflakes from finding undefined names
1022 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1023 Builder no longer induces a disconnect/reconnect cycle. This means
1024 that any builds currently in progress will not be interrupted, and
1025 any builds which are queued in the Builder will not be lost. This
1026 is implemented by having the new Builder extract the state (i.e.
1027 all pending Builds and any desired SlaveBuilders) from the old
1029 (BotPerspective): refactor. The BotPerspective no longer keeps
1030 track of all the Builders that want to use this slave; instead, it
1031 asks the BotMaster each time it needs this list. This removes
1032 addBuilder and removeBuilder. Clean up attached() to acquire all
1033 the slave's information in a more atomic fashion. updateSlave() is
1034 now the way to make sure the slave is using the right set of
1035 Builders: just call it after everything else has been
1037 (BotMaster): refactor, removing addBuilder/removeBuilder and
1038 replacing them with an all-at-once setBuilders() call.
1040 * buildbot/test/test_slaves.py (Reconfig): new test case to
1041 exercise this functionality
1042 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1043 * buildbot/slave/commands.py (WaitCommand): same
1045 * docs/buildbot.texinfo (Loading the Config File): document the
1048 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1049 SlaveBuilder to have its parent Builder changed.
1050 (SlaveBuilder.isAvailable): new method to give access to state,
1051 which is now a private attribute
1052 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1053 the SlaveBuilder about how it is being used. These methods update
1054 its internal state. buildFinished() is now the place that invokes
1055 maybeStartBuild() on its parent Builder.
1056 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1057 new Builder to take over for an old one, transferring state from
1059 (Buider): refactor the way that SlaveBuilders are used to match,
1060 giving them a bit more autonomy.
1061 (Builder.buildFinished): this no longer calls maybeStartBuild():
1062 instead the SlaveBuilder calls it on whoever its parent Builder is
1063 at the time. This way, when an old Builder is replaced by a new
1064 one, and there was a build in progress during the transition, when
1065 that build finishes, it will be the new Builder that is told about
1066 the newly available slave so it can start a new build.
1068 * buildbot/process/base.py (Build.startBuild._release_slave): when
1069 the Build finishes, tell the SlaveBuilder that they've been
1072 * buildbot/status/builder.py (SlaveStatus): add some new setter
1073 methods for use by BotPerspective, to keep some attributes more
1076 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1077 called by the buildmaster.
1078 (Bot.setBuilderList): instead, we locally announce any leftover
1079 directories based upon which Builders we were told about. The
1080 master doesn't really care; it's the local admin who may or may not
1081 wish to delete them.
1084 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1085 to allow use of python2.4 or whatever. This tool still requires
1088 2006-11-19 Brian Warner <warner@lothar.com>
1090 * NEWS (IStatusLog.readlines): more news items
1092 2006-11-18 Brian Warner <warner@lothar.com>
1094 * NEWS: start collecting items for the next release.
1096 2006-11-04 Brian Warner <warner@lothar.com>
1098 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1099 Hearsum. Closes SF#1590310.
1100 * buildbot/test/test_bonsaipoller.py: and tests
1102 * buildbot/status/tinderbox.py
1103 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1104 status when the build results in WARNINGS. Patch from Dave
1105 Liebreich. Closes SF#1587352.
1107 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1108 linux-vs-osx behavior difference w.r.t. reading from files that
1109 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1110 to Mark Rowe for the patch.
1112 2006-10-15 Brian Warner <warner@lothar.com>
1114 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1115 method name was misspelled in the interface definition. Thanks to
1116 Roy Rapoport for the catch.
1118 2006-10-13 Brian Warner <warner@lothar.com>
1120 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1121 to match the great Steps renaming
1123 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1124 Maybe I should run my own unit tests before recording a big
1125 change. Good thing I've got a buildbot to remind me.
1127 2006-10-12 Brian Warner <warner@lothar.com>
1129 * buildbot/steps/transfer.py: rework __init__ and args setup
1130 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1132 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1133 when opening the target file, only catch IOError (to report via
1134 stderr/rc!=0), let the others be reported as normal exceptions
1136 2006-10-08 Brian Warner <warner@lothar.com>
1138 * contrib/svn_watcher.py: fix security holes by using proper argv
1139 arrays and subprocess.Popen() rather than commands.getoutput().
1140 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1141 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1142 probably be removed by the next release.
1145 2006-10-04 Brian Warner <warner@lothar.com>
1147 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1148 initial lines that weren't emitted by pyflakes. When the pyflakes
1149 command is run under a Makefile, 'make' will echo the command it
1150 runs to stdio, and that was getting logged as a "misc" warning.
1151 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1152 * buildbot/test/test_steps.py (testPyFlakes3): another test
1154 2006-10-01 Brian Warner <warner@lothar.com>
1156 * buildbot/status/html.py (HtmlResource.render): if we get a
1157 unicode object from our content() method, encode it into utf-8
1158 like we've been claiming to all along. This allows the comments
1159 and author names from svnpoller.py to be delivered properly.
1161 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1162 de-unicodify filenames before creating the Change, because the
1163 rest of buildbot is unlikely to handle them well. Leave the 'who'
1164 field as a unicode object.. I don't think there's anything that
1165 will break very soon, and it will probably nudge us towards
1166 accepting unicode everywhere sooner or later. Stop using the
1167 "date" field that comes out of SVN, since it is using the
1168 repository's clock (and timezone) and what we care about is the
1169 buildmaster's (otherwise Changes from the future show up later
1170 than the builds they triggered).
1171 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1174 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1175 Suvbersion repository polling ChangeSource. I've hacked it up
1176 considerably: any bugs are entirely my own fault. Thank you
1178 * buildbot/test/test_svnpoller.py: tests for it
1179 * docs/buildbot.texinfo (SvnSource): document it
1181 2006-09-30 Brian Warner <warner@lothar.com>
1183 * buildbot/scheduler.py (Periodic): submit a reason= to the
1184 BuildSet to indicate which Scheduler triggered the build. Thanks
1185 to Mateusz Loskot for the suggestion.
1187 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1189 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1190 changes: set self.loop in __init__, remove unused volatile=
1192 * docs/buildbot.texinfo (.buildbot config directory): add more
1193 docs on the .buildbot/options keys used by "buildbot try"
1194 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1195 (Try.deliverJob): same
1197 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1199 (BonsaiPoller): same
1201 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1202 close the filehandle when we stop watching the file. Before, the
1203 filehandle was only closed when the LogFileWatcher was
1204 garbage-collected, which could be quite a while in the future. If
1205 it was still open by the time the next build started, windows will
1206 refuse to let the new build delete the old build/ directory. Fixes
1207 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1208 #twisted for the catch.
1210 2006-09-29 Brian Warner <warner@lothar.com>
1212 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1215 2006-09-25 Brian Warner <warner@lothar.com>
1217 * setup.py: the new buildbot.steps module wasn't being installed.
1218 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1219 (testmsgs): add the extra stuff from buildbot/test/* so you can
1220 run unit tests on an installed copy of buildbot, not just from
1223 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1224 columns of 'svnlook changed' output contain status information, so
1225 strip [:4] instead of [:6]. Depending upon what the status flags
1226 were, this would sometimes lead to mangled filenames. Thanks to
1227 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1229 * buildbot/steps/source.py (Monotone): initial Monotone support,
1230 contributed by Nathaniel Smith. Still needs docs and tests, but
1231 this code has been in use on the Monotone buildbot for a long
1233 * buildbot/slave/commands.py (Monotone): slave-side support
1234 * buildbot/changes/monotone.py (MonotoneSource): polling change
1237 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1238 contributed a Change Source that polls a Bonsai server (a
1239 kind of web-based viewcvs CGI script).
1241 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1242 Hearsum contributed a status plugin which sends email in the same
1243 format that Tinderbox does: this allows a number of tinderbox
1244 tools to be driven by Buildbot instead. Thanks Ben!
1246 2006-09-24 Brian Warner <warner@lothar.com>
1248 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1249 Thanks to Robert Helmer for the patch.
1251 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1252 BuildStatus about the buildslave name at the *beginning* of the
1253 build, rather than at the end. Thanks to Alexander Lorenz for the
1255 * buildbot/status/html.py (StatusResourceBuild.body): always
1256 include the slavename in the build page, not just when the build
1258 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1259 slavename in the email message
1261 2006-09-21 Brian Warner <warner@lothar.com>
1263 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1265 * docs/examples/glib_master.cfg: same
1266 * docs/examples/hello.cfg: same
1267 * docs/examples/twisted_master.cfg: same, update to current usage
1269 2006-09-19 Brian Warner <warner@lothar.com>
1271 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1272 (PyFlakes.createSummary): make it compatible with python-2.2
1274 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1275 for at least the output-parsing parts of PyFlakes
1277 2006-09-18 Brian Warner <warner@lothar.com>
1279 * buildbot/steps/python.py: oops, fix import of StringIO
1281 2006-09-17 Brian Warner <warner@lothar.com>
1283 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1284 turns out that SVN-1.4.0 doesn't fail to update once you've
1285 replaced a file with a directory, unlike older versions of SVN and
1286 pretty much every other VC tool we support. Since what we really
1287 care about is that the update succeeds anyway, stop checking that
1288 the tree got clobbered and just assert that the build succeeded.
1289 (VCBase.printLogs): add a utility function for debugging
1291 * buildbot/process/step.py: oops, added extra imports by mistake
1293 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1294 rstrip() on the first line coming out of the 'p4 describe'
1295 process, to remove the stray ^M that Wade Brainerd reports seeing
1296 in the 'when' field. Fixes SF#1555985.
1298 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1299 message logged when c['schedulers'] is not right
1300 * buildbot/scheduler.py (Scheduler.__init__): improve error
1301 message when a Scheduler() is created with the wrong arguments
1302 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1303 verify that these error messages are emitted
1305 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1306 The idea is that all the base classes (like BuildStep and
1307 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1308 will be a leftover backwards-compatibility file that only contains
1309 aliases for the steps that were moved out to buildbot.steps.*
1310 * lots: change imports to match
1311 * buildbot/process/step.py: add a DeprecationWarning if it ever
1314 2006-09-12 Brian Warner <warner@lothar.com>
1316 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1317 builderNames= is actually a sequence, since if you happen to give
1318 it a single builder-specification dictionary instead, it won't get
1319 caught by the existing assert. Thanks to Brett Neely for the
1322 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1324 * docs/buildbot.texinfo (Python BuildSteps): document them
1325 (sendchange): include a link to PBChangeSource, since you need one
1327 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1329 * buildbot/steps/dummy.py: same
1331 2006-09-08 Brian Warner <warner@lothar.com>
1333 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1334 BuildStep which lets you transfer files from the master to the
1335 slave or vice versa. Thanks to Albert Hofkamp for the original
1336 patch. Fixes SF#1504631.
1337 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1339 (SlaveFileDownloadCommand): same
1340 * docs/buildbot.texinfo (Transferring Files): document it
1341 * buildbot/test/test_transfer.py: test it
1342 * buildbot/test/runutils.py (StepTester): new utility class for
1343 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1344 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1347 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1348 walk through StatusLogs one line at a time, mostly for the benefit
1349 of ShellCommand.createSummary methods. You can either walk through
1350 STDOUT or STDERR, but the default is STDOUT.
1352 * buildbot/status/builder.py (LogFile.readlines): implement it.
1353 Note that this is not yet memory-efficient, it just pulls the
1354 whole file into RAM and then splits it up with a StringIO.
1355 Eventually this should be a generator that only pulls chunks from
1357 * buildbot/test/test_status.py (Log.testReadlines): test it
1359 * docs/buildbot.texinfo: update to match changes
1360 * buildbot/process/factory.py: stop using old definitions
1361 * buildbot/process/process_twisted.py: same
1362 * buildbot/test/test_*.py: same
1364 * buildbot/process/step_twisted.py: move definition to..
1365 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1366 relative-import mechanisms prevent this from being named 'twisted'
1367 or 'python/twisted' as I would have preferred.
1369 * buildbot/process/maxq.py: move definition to..
1370 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1372 * buildbot/process/step.py: split the user-visible BuildSteps into
1373 separate files, all under buildbot/steps/
1374 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1375 * buildbot/steps/shell.py: this holds ShellCommand and friends
1376 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1378 2006-09-05 Brian Warner <warner@lothar.com>
1380 * lots: run pyflakes, removed a lot of unused imports, changed the
1381 form of some conditional imports to remove false pyflakes
1382 warnings. There are still a number of warnings left, mostly from
1383 imports that are done for their side-effects.
1384 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1387 2006-08-26 Brian Warner <warner@lothar.com>
1389 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1390 compatible with twisted-1.3.0, for some reason I just can't seem
1391 to let go of the past.
1393 2006-08-25 Brian Warner <warner@lothar.com>
1395 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1397 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1398 all logfiles= in startCommand(), rather than in start() . This
1399 makes it easier to have the 'stdio' log come before any secondary
1400 logfiles, which I feel makes the waterfall display more
1402 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1403 from ShellCommand up into LoggingBuildStep
1404 (LoggingBuildStep.__init__): move the handling of logfiles= from
1405 ShellCommand up to LoggingBuildStep, because startCommand is
1406 provided by LoggingBuildStep, whereas start() was specific to
1407 subclasses like ShellCommand and Source. This removes code
1408 duplication in those subclasses.
1409 (ShellCommand.__init__): same
1410 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1411 for a slave that's too old to understand logfiles= into a separate
1412 method, so it can live in ShellCommand. The rest of
1413 setupLogfiles() can live in LoggingBuildStep.
1415 2006-08-24 Brian Warner <warner@lothar.com>
1417 * buildbot/locks.py (BaseLock): you can now configure Locks to
1418 allow multiple simultaneous owners. They still default to
1419 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1421 * docs/buildbot.texinfo (Interlocks): document the new options
1422 * buildbot/test/test_locks.py: add a bunch of new unit tests
1423 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1424 waitUntilMaybeAvailable, not waitUntilAvailable
1425 * buildbot/process/step.py (BuildStep.acquireLocks): same
1426 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1427 the whole lockid in their constructor, not just the name. Also,
1428 keep track of which real locks we've handed out by the full
1429 lockid, not just class+name, otherwise changing just the maxCount=
1430 in the master.cfg file would not actually cause a behavioral
1433 2006-08-23 Brian Warner <warner@lothar.com>
1435 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1437 * docs/buildbot.texinfo: same
1439 2006-08-23 Brian Warner <warner@lothar.com>
1441 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1442 * docs/buildbot.texinfo: set version to match
1443 * NEWS: update for 0.7.4
1444 * buildbot/slave/commands.py (command_version): mention that this
1445 version (2.1) was released with buildbot-0.7.4
1447 2006-08-22 Brian Warner <warner@lothar.com>
1451 * CREDITS: new file, list of people who have helped. Thanks!
1452 * MANIFEST.in: ship it
1454 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1455 new diagrams, the user's manual is more informative than it was.
1456 Start shipping the .html user's manual (and generated .png
1458 * Makefile: update 'release' target to match
1460 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1461 test.. I think the web-parts effort will render it pointless well
1462 before it ever actually starts to work.
1464 2006-08-20 Brian Warner <warner@lothar.com>
1466 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1467 meaning of the prefix= argument. It is now just a string which is
1468 stripped from the beginning of the filename. If prefix= is set but
1469 not found on any given filename, that filename is ignored. If all
1470 filenames in a Change are ignored, the Change is dropped. This is
1471 much simpler than the previous sep= nonsense, and I should have
1472 implemented it this way from the beginning. Effectively resolves
1473 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1474 Gedminas for the catch and suggested fixes.
1475 (ChangePerspective.perspective_addChange): implement the actual
1477 * buildbot/test/test_changes.py (TestChangePerspective): test it
1478 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1479 how to properly use prefix=
1480 * docs/examples/twisted_master.cfg (source): update prefix= by
1481 adding the trailing slash
1484 * docs/examples/twisted_master.cfg: update to actual practice
1486 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1487 update test case to match new link text.. the HREF has both a
1488 class= setting and an enclosing [] pair that I didn't match in the
1491 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1492 list of strings is preferred over a single string with embedded
1494 (ShellCommand.description=): explain that either single strings or
1495 a list of strings is acceptable, and why you might prefer one over
1496 the other. Add an example. Fixes SF#1524659, thanks to Paul
1497 Winkler for the catch.
1498 (Build Steps): update to use f.addStep() rather than using s()
1499 and the constructor list
1501 * buildbot/process/step.py (ShellCommand): accept either a single
1502 string or a list of strings in both description= and
1504 * buildbot/test/test_steps.py (Steps.test_description): test it
1505 * buildbot/test/runutils.py (makeBuildStep): support for that test
1507 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1508 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1509 collecting the files and creating the patch.
1511 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1512 per-step URLs that will be displayed on the waterfall display,
1513 for things like the HTML output of code-coverage tools, when
1514 the results are hosted elsewhere.
1515 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1516 way to retrieve these URLs
1517 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1518 the method to retrieve these URLs. Also provide backwards
1519 compatibility for saved BuildStepStatus instances that didn't have
1521 * buildbot/process/step.py (BuildStep.addURL): method to set these
1522 URLs from within a BuildStep
1523 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1524 (StepBox.getBox): give these external links a distinct CSS class
1525 named "BuildStep external" so a .css file can display them
1528 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1530 * buildbot/test/test_steps.py (Steps): test that we can all the
1531 URLs. Also add a bunch of other tests on methods that can be
1532 called from within BuildSteps
1533 * buildbot/test/runutils.py (makeBuildStep): add utility function
1535 2006-08-13 Brian Warner <warner@lothar.com>
1537 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1539 2006-08-10 Brian Warner <warner@lothar.com>
1541 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1542 index, this one of things like c['sources'] and c['schedulers']
1543 (indices): it looks like my clever idea of putting the @fooindex
1544 commands in between the @node and the @subsection (to make the
1545 HREF anchor jump to slightly above the section title, which works
1546 much better in html) confused texinfo horribly, so I'm moving the
1547 index tags back to be just after the @subsection marker. I also
1548 added extra lines between the @node/@section paragraph and the
1549 index tags, since I think maybe texinfo wants to see these be
1550 separate paragraphs.
1552 * docs/Makefile (images): make sure images get built when
1553 rendering the manual
1554 * docs/images/Makefile: same
1556 * buildbot/scripts/runner.py: rename 'buildbot master' to
1557 'buildbot create-master', and 'buildbot slave' to 'buildbot
1559 * docs/buildbot.texinfo: same
1562 * docs/buildbot.texinfo: reimplement the "useful classes" index
1563 with actual texinfo indices. The .info rendering is a bit
1564 weird-looking but it works well, and the HTML rendering is quite
1565 nice. This also puts the index targets in the regular flow of the
1566 text, which is easier to maintain.
1568 2006-08-06 Brian Warner <warner@lothar.com>
1570 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1571 Kevin Turner to prefer the environ= argument be a list rather than
1572 a string. If it is a list, it will be joined with a platform-local
1573 os.pathsep delimiter, and then prepended to any existing
1574 $PYTHONPATH value. This works better in cross-platform (i.e.
1575 windows buildslaves) environments when you need to push multiple
1576 directories onto the front of the path.
1577 (SlaveShellCommand): documented the new magic
1578 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1579 in a user-visible form
1581 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1582 Turner to prefer lists over strings when creating/running VC
1583 commands during unit tests. This is clearly necessary to survive
1584 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1585 renamed the wq() function to qw() though, since that's how it's
1586 spelled in perl. Eventually I'd prefer all commands to be
1587 specified with lists.
1589 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1590 which are deleted (or not yet created) correctly. Also add
1591 failsafe code to not explode if the file-watching poller doesn't
1592 get started. Thanks to JP Calderone for the catch and the poller
1594 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1596 * buildbot/test/emitlogs.py: same
1598 * NEWS: summarize recent changes
1600 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1601 clause to avoid the "host key mismatch" warning
1603 * buildbot/process/step_twisted.py (Trial.start): if the
1604 buildslave is too old to understand logfiles=, fall back to
1605 running 'cat _trial_temp/test.log' like before.
1606 (Trial.commandComplete): same. this takes advantage of the
1607 LoggingBuildStep refactoring to stall commandComplete long enough
1608 to run a second RemoteShellCommand.
1610 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1611 refactor command-completion handling, to allow methods like
1612 commandComplete/createSummary/evaluateCommand to return Deferreds.
1613 (LoggingBuildStep._commandComplete): delete the refactored method
1614 (ShellCommand.setupLogfiles): if the buildslave is too old to
1615 understand logfiles=, put a warning message both into twistd.log
1616 and into the otherwise empty user-visible LogFiles.
1618 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1619 callers to provide the slave-side logfile name, rather than
1620 forcing it to come from the local name of the LogFile.
1621 (BuildStep.getSlaveName): new method
1623 * buildbot/process/base.py (Build.getSlaveName): new method, so
1624 steps can find out which buildslave they're running on
1626 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1627 to match the s/cvs_ver/command_version/ change
1629 2006-08-05 Brian Warner <warner@lothar.com>
1631 * buildbot/slave/commands.py (command_version): replace the CVS
1632 auto-updated cvs_ver keyword with a manually-updated variable,
1633 since CVS is no longer the master repository. Add a description of
1634 the remote API change starting in this version (2.1), specifically
1635 the fact that SlaveShellCommand now accepts 'initial_stdin',
1636 'keep_stdin_open', and 'logfiles'.
1638 2006-07-31 Brian Warner <warner@lothar.com>
1640 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1641 diagrams to describe how the whole system fits together. The
1642 images themselves are kept in SVG files, with ascii-art versions
1643 in corresponding .txt files. Texinfo knows how to interpolate the
1644 text version into .info files, reference the .png versions from
1645 .html files, and include .eps versions in the .ps format.
1646 * docs/images/Makefile: tools to create .png and .eps
1647 * docs/images/*.svg: created pictures with Inkscape.
1648 * .darcs-boring: ignore the generated .eps and .png files
1650 2006-07-24 Brian Warner <warner@lothar.com>
1652 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1653 Scheduler names, since they cause setServiceParent to explode
1655 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1657 2006-07-20 Brian Warner <warner@lothar.com>
1659 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1660 which runs the buildbot unit tests
1662 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1663 classes that are useful in master.cfg
1665 2006-07-15 Brian Warner <warner@lothar.com>
1667 * Makefile (some-apidocs): new target to build only some epydocs
1669 * setup.py: minor comment.. does the classifiers= argument prevent
1670 the setup.py script from working on python2.2/2.3?
1672 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1675 * buildbot/twcompat.py: fix minor typo in comments
1677 * buildbot/manhole.py: move all Manhole-related code out to this
1678 module. Implement SSH-based manholes (with TwistedConch), and move
1679 to conch's nifty line-editing syntax-coloring REPL shell instead
1680 of the boring non-editing monochromatic (and deprecated) old
1682 * buildbot/master.py: remove all Manhole-related code
1683 (BuildMaster.loadConfig._add): make sure the old manhole is
1684 removed before we add the new one
1685 * docs/buildbot.texinfo (Debug options): document new Manhole options
1687 * buildbot/twcompat.py (_which): fix some epydoc issues
1688 * buildbot/status/html.py (Waterfall.__init__): same
1690 2006-06-29 Brian Warner <warner@lothar.com>
1692 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1693 deprecation warnings under newer Twisteds (by using
1694 zope.interface.Interface instead of old twisted.python.components
1696 * buildbot/slave/interfaces.py: same
1698 2006-06-28 Brian Warner <warner@lothar.com>
1700 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1701 svn commands, so it will fail immediately instead of hanging while
1702 it waits for a username/password to be typed in.
1704 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1705 log message if the step was shut down
1707 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1708 obsolete reference to mktap.
1710 2006-06-20 Brian Warner <warner@lothar.com>
1712 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1713 test to include new 'logfiles' argument sent from master to slave
1715 2006-06-19 Brian Warner <warner@lothar.com>
1717 * buildbot/process/step_twisted.py (Trial): track Progress from
1718 _trial_temp/test.log too
1720 * buildbot/process/step.py (OutputProgressObserver): generalize
1721 the earlier StdioProgressObserver into an OutputProgressObserver
1722 that can track LogFiles other than stdio.
1723 (LoggingBuildStep.__init__): same
1725 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1726 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1727 will fail under windows because of os.sep issues. It might have
1728 worked before if 'cat' was doing cygwin path conversion.
1730 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1731 creation of LogFileWatchers
1732 (ShellCommand._startCommand): and record the files that were
1733 watched in the 'headers' section of the ShellCommand output
1735 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1736 need to actually pass it to the slave if you want it to work.
1737 (ShellCommand): document it a bit
1739 * buildbot/test/test_shell.py: new test to validate LogFiles
1740 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1742 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1743 before printing the last batch of lines, to test that the polling
1744 logic is working properly
1746 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1747 handling, making it possible to track multiple logs for a single
1748 RemoteCommand. The previous single logfile is now known as the
1750 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1751 (RemoteShellCommand.__init__): accept logfiles=
1752 (LoggingBuildStep.startCommand): stdio_log is now one of many
1753 (ShellCommand): added logfiles= argument, as well as a class-level
1754 .logfiles attribute, which will be merged together to figure out
1755 which logfiles should be tracked. The latter maybe be useful for
1756 subclasses of ShellCommand which know they will aways produce
1757 secondary logfiles in the same location.
1759 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1760 and closeStdin() methods, preparing to make it possible to write
1761 to a ShellCommand's stdin at any time, not just at startup. These
1762 writes are buffered if the child process hasn't started yet.
1763 (LogFileWatcher): new helper class to watch arbitrary logfiles
1764 while a ShellCommand runs. This class polls the file every two
1765 seconds, and sends back 10k chunks to the buildmaster.
1766 (ShellCommand): rename stdin= to initialStdin=, and add
1767 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1769 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1770 key of "log" and a value of (logname, data).
1771 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1772 'logfiles' to the master-visible args dictionary.
1773 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1776 * buildbot/test/test_vc.py (Patch.testPatch): same
1779 * buildbot/test/emit.py: write to a logfile in the current
1780 directory. We use this to figure out what was used as a basedir
1781 rather than looking to see which copy of emit.py gets run, so that
1782 we can run the commands from inside _trial_temp rather than inside
1784 * buildbot/test/subdir/emit.py: same
1785 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1786 argument rather than running from buildbot/test/
1787 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1788 rather than using an implicit setUp()
1789 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1790 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1791 of assuming that we're running in buildbot/test/ (and that '.' is
1794 * buildbot/slave/commands.py (Command.doStart): refactor Command
1795 startup/completion a bit: now the SlaveBuilder calls doStart(),
1796 which is not meant for overridding by subclasses, and doStart()
1797 calls start(), which is. Likewise the SlaveBuilder calls
1798 doInterrupt(), and subclasses override interrupt(). This also puts
1799 responsibility for maintaining .running in Command rather than in
1801 (Command.doInterrupt): same
1802 (Command.commandComplete): same, this is called when the deferred
1803 returned by start() completes.
1804 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1805 (SlaveBuilder.remote_interruptCommand): same
1806 (SlaveBuilder.stopCommand): same
1808 2006-06-16 Brian Warner <warner@lothar.com>
1810 * buildbot/test/test_shell.py: new test file to contain everything
1811 relating to ShellCommand
1812 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1813 multiple logfiles in realtime" feature, not yet implemented
1814 * buildbot/test/emitlogs.py: support file for testLogFiles
1815 * docs/buildbot.texinfo (ShellCommand): document the feature
1817 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1819 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1820 for tests which exercise SlaveCommands in isolation.
1822 * buildbot/test/test_slavecommand.py: Move some utilities like
1823 SignalMixin and FakeSlaveBuilder from here ..
1824 * buildbot/test/runutils.py: .. to here, so they can be used by
1825 other test classes too
1826 * buildbot/test/test_vc.py: more SignalMixin refactoring
1827 * buildbot/test/test_control.py: same
1828 * buildbot/test/test_run.py: and some rmtree refactoring
1830 2006-06-15 Brian Warner <warner@lothar.com>
1832 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1833 'testBranch' to match other VC tests and have the tests run in
1834 roughly increasing order of dependency
1836 * buildbot/test/test_steps.py (LogObserver): new test to verify
1837 LogObservers can be created at various times and still get
1838 connected up properly
1840 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1841 to create BuildStepStatus instances that actually work.
1843 * buildbot/process/step.py (LogObserver): add outReceived and
1844 errReceived base methods, to be overridden
1846 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1847 API to take a name instead of a step, reducing the coupling
1848 somewhat. This returns the BuildStepStatus object so it can be
1849 passed to the new Step, instead of jamming it directly into the
1851 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1853 * buildbot/process/base.py (Build.setupBuild): use both methods
1854 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1855 process a bit to match
1857 2006-06-14 Brian Warner <warner@lothar.com>
1859 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1860 docs on writing new LogObserver classes
1861 (Writing New Status Plugins): brief docs on how Status Plugins fit
1864 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1865 implement a LogObserver that counts how many unit tests have been
1867 (Trial.__init__): wire it in
1868 * buildbot/test/test_twisted.py (Counter): unit test for it
1870 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1871 to new cmd.logs['stdio'] scheme
1872 (Trial.commandComplete): same
1873 (BuildDebs.commandComplete): same
1875 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1876 LogFiles, instead of just a single one. The old single logfile is
1877 now called "stdio". LoggedRemoteCommand no longer creates a
1878 LogFile for you (the code to do that was broken anyway). If you
1879 don't create a "stdio" LogFile, then stdout/stderr will be
1881 (LogObserver): implement "LogObservers", which a BuildStep can add
1882 to parse the output of a command in real-time. The primary use is
1883 to provide more useful information to the Progress code, allowing
1884 better ETA estimates.
1885 (LogLineObserver): utility subclass which feeds complete lines to
1886 the parser instead of bytes.
1887 (BuildStep.progressMetrics): this is safer as a tuple
1888 (BuildStep.setProgress): utility method, meant to be called by
1890 (BuildStep.addLogObserver): new method, to be called at any time
1891 during the BuildStep (even before any LogFiles have been created),
1892 to attach (or schedule for eventual attachment) a LogObserver to a
1894 (StdioProgressObserver): new LogObserver which replaces the old
1895 "output" progress gatherer
1896 (LoggingBuildStep.__init__): same
1897 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1898 (LoggingBuildStep._commandComplete): must use logs['stdio']
1899 instead of the old single ".log" attribute.
1900 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1901 functionality, now subsumed into StdioProgressObserver
1902 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1903 log name changed from "output" to "stdio".
1906 * buildbot/interfaces.py (ILogFile): add the Interface used from
1907 the BuildStep towards the LogFile
1908 (ILogObserver): and the one provided by a LogObserver
1909 * buildbot/status/builder.py (LogFile): implement it
1911 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1912 HEADER constants here ..
1913 * buildbot/status/builder.py (STDOUT): .. from here
1915 2006-06-13 Brian Warner <warner@lothar.com>
1917 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1918 compatibility with python2.2, which doesn't have the 'substr in
1920 (TestP4Poller.makeTime): utility function to construct the
1921 timestamp using the same strptime() approach as p4poller does. It
1922 turns out that time.mktime() behaves slightly differently under
1923 python2.2, probably something to do with the DST flag, and that
1924 causes the test to fail under python2.2. (changing the mktime()
1925 arguments to have dst=0 instead of -1 caused it to fail under
1926 python2.3. Go figure.)
1927 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1929 2006-06-12 Brian Warner <warner@lothar.com>
1931 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1932 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1933 contributing such an excellent patch, including docs and unit
1934 tests! This makes it *so* much easier to apply. I had to update
1935 test_vc.py to handle some recent refactorings, but everything else
1936 applied smoothly. The only remaining thing I'd like to fix would
1937 be to remove the hard-wired port 1666 used by p4d, and allow it to
1938 claim any unused port. This would allow two copies of the test
1939 suite to run on the same host at the same time, as well as
1940 allowing the test suite to run while a real (production) p4d was
1941 running on the same host. Oh, and maybe we should add a warning to
1942 step.P4 that gets emitted if the slave is too old to provide the
1943 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1944 * buildbot/slave/commands.py (P4): same
1945 (P4Sync): same, some minor updates
1946 * buildbot/changes/p4poller.py: same
1947 * docs/buildbot.texinfo: same
1948 * buildbot/test/test_p4poller.py: same
1949 * buildbot/test/test_vc.py (P4): same
1951 * setup.py: add Trove classifiers for PyPI
1953 2006-06-08 Brian Warner <warner@allmydata.com>
1955 * buildbot/status/client.py
1956 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1957 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1958 build needs to be IRemote'd separately, rather than IRemote'ing
1959 the whole list at once. I can't wait until newpb's serialization
1960 adapters make this unnecessary.
1962 2006-06-06 Brian Warner <warner@lothar.com>
1964 * buildbot/process/step.py (WithProperties): make this inherit
1965 from ComparableMixin, so that reloading an unchanged config file
1966 doesn't cause us to spuriously reload any Builders which use them.
1967 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1970 2006-06-03 Brian Warner <warner@lothar.com>
1972 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1973 running py2exe on windows, contributed by Mark Hammond. Addresses
1974 SF#1401121, but I think we still need to include
1975 buildbot/scripts/sample.cfg
1976 * setup.py: include buildbot_service.py as a script under windows
1977 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1978 a py2exe application), get the icon/css datafiles from a different
1981 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1982 double-escape the build URL. Thanks to Olivier Bonnet for the
1983 patch. Fixes SF#1452801.
1985 2006-06-02 Brian Warner <warner@lothar.com>
1987 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1988 first six columns of 'svnlook' output, not just the first column,
1989 since property changes appear in the other five. Thanks to Olivier
1990 Bonnet for the patch. Fixes SF#1398174.
1992 2006-06-01 Brian Warner <warner@lothar.com>
1994 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1995 the fake build, so that title= has something to be set to
1997 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1998 attribute of the "Build #NN" link in the yellow start-the-build
1999 box to the build's reason. This means that you get a little
2000 tooltip explaining why the build was done when you hover over the
2001 yellow box. Thanks to Zandr Milewski for the suggestion.
2003 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2004 (Box.setETA): handle ETA=None (by stopping the timer)
2005 (Box.update): make the [soon] text less different than the usual
2006 text, so the rest of the text doesn't flop around so much. It
2007 would be awfully nice to figure out how to center this stuff.
2008 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2010 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2011 by default, so that any ShellCommand which fails marks the overall
2012 build as a failure. I should have done this from the beginning.
2013 Add flunkOnFailure=False to the arguments if you want to turn off
2016 2006-05-30 Brian Warner <warner@lothar.com>
2018 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2019 last-build/current-build/current-step. Show what step is currently
2020 running. Show ETA for both the overall build and the current step.
2021 Update GTK calls to modern non-deprecated forms. There's still a
2022 lot of dead code and debug noise to remove.
2024 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2025 shows up properly in status displays
2027 2006-05-28 Brian Warner <warner@lothar.com>
2029 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2030 build we use to verify that WithProperties works:
2032 ** set flunkOnFailure=True so that build failures get noticed
2033 ** set workdir='.' so that the build succeeds, otherwise it is trying
2034 to touch 'build/something', and 'build/' doesn't exist because
2035 usually that's created by a Source step
2036 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2037 this test somehow triggers, in which the 'touch' process becomes
2038 a zombie and we wait for th etimeout before giving up on it.
2040 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2041 to log the Build results and step logs to the twisted log.
2042 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2043 what went wrong if a build was expected to succeed but didn't.
2045 * buildbot/process/step_twisted.py (Trial): set the default
2046 trialMode to '--reporter=bwverbose', which specifies verbose
2047 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2048 '-to', but those are completely missing in modern Twisteds.
2050 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2051 a localhost-only port, to encourage better security
2053 * docs/buildbot.texinfo (Change Sources): mention
2056 * .darcs-boring: add a Darcs boringfile
2058 * README (REQUIREMENTS): stop claiming compatibility with
2061 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2064 2006-05-27 Brian Warner <warner@lothar.com>
2066 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2067 * docs/buildbot.texinfo: same
2069 2006-05-23 Brian Warner <warner@lothar.com>
2071 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2072 * docs/buildbot.texinfo: set version to match
2073 * NEWS: update for 0.7.3
2075 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2076 give a quick mapping from VC system to possible ChangeSources
2077 (Build Properties): add 'buildername'
2079 * buildbot/process/base.py (Build.setupStatus): oops, set
2080 'buildername' and 'buildnumber' properties
2081 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2084 2006-05-22 Brian Warner <warner@lothar.com>
2086 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2087 property interpolation better
2089 * README (INSTALLATION): remove old '-v' argument from recommended
2092 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2093 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2096 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2097 'svnversion' instead of grepping the output of 'svn info', much
2098 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2099 Bonnet for the suggestion.
2100 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2101 require the WC_PATH argument, so run 'svnversion .' instead.
2103 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2104 aren't supposed to have 'self' in their argument list
2106 2006-05-21 Brian Warner <warner@lothar.com>
2108 * buildbot/process/step.py (ShellCommand.start): make
2109 testInterpolate pass. I was passing the uninterpolated command to
2110 the RemoteShellCommand constructor
2111 (ShellCommand._interpolateProperties): oops, handle non-list
2112 commands (i.e. strings with multiple words separated by spaces in
2113 them) properly, instead of forgetting about them.
2115 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2116 to actually try to use build properties in a real build. This test
2118 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2119 to start and evaluate builds
2121 * buildbot/test/test__versions.py: add a pseudo-test to record
2122 what version of Twisted/Python/Buildbot are running. This should
2123 show up at the beginning of _trial_tmp/test.log, and exists to help
2124 debug other problems.
2126 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2127 a filename to be served as 'robots.txt' to discourage web spiders.
2128 Adapted from a patch by Tobi Vollebregt, thanks!
2129 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2130 (Waterfall.test_waterfall): tweak the way that filenames are put
2131 into the config file, to accomodate windows pathnames better.
2133 * docs/buildbot.texinfo (HTML Waterfall): document it
2135 * buildbot/process/process_twisted.py
2136 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2137 changed the build process. The new setup.py no longer takes the
2139 (FullTwistedBuildFactory.__init__): same
2140 (TwistedReactorsBuildFactory.__init__): same
2142 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2143 be placed in the [hooks] section of the central repository (the
2144 one that everybody pushes changes to).
2146 2006-05-20 Brian Warner <warner@lothar.com>
2148 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2149 .darcs-context file, use binary mode. I think this was causing a
2150 Darcs failure under windows.
2152 2006-05-19 Brian Warner <warner@lothar.com>
2154 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2155 use a timezone string of +0000 and gmtime, since this timestamp is
2156 sent to a buildmaster and %z is broken.
2158 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2159 string and localtime, since this timestamp will only be consumed
2160 locally, and %z is broken.
2162 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2163 gmtime, since this timestamp is returned to the buildmaster, and
2166 2006-05-18 Brian Warner <warner@lothar.com>
2168 * NEWS: update in preparation for next release
2170 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2171 setup-repository and do-we-have-the-vc-tools code into a separate
2172 "helper" class, which sticks around in a single module-level
2173 object. This seems more likely to continue to work in the future
2174 than having it hide in the TestCase and hope that TestCases stick
2175 around for a long time.
2177 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2178 addremove' has been deprecated in recent versions of mercurial, so
2179 use 'hg add' instead
2181 2006-05-07 Brian Warner <warner@lothar.com>
2183 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2184 operating under windows, move the file before opening it, since
2185 you can't rename a file that somebody has open.
2187 * buildbot/process/base.py (Build.setupBuild): if something goes
2188 wrong while creating a Step, log the name and arguments, since the
2189 error message when you get the number of arguments wrong is really
2192 2006-05-06 Brian Warner <warner@lothar.com>
2194 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2195 bugs in twisted-specific code not covered by my unit tests, this
2196 time use 'cmd' argument instead of self.cmd
2198 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2199 fix stupid braino: either use startwith or find()==0, not both.
2200 (TwistedReactorsBuildFactory.__init__): another dumb typo
2202 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2203 mark this test as TODO under windows, since process-killing seems
2204 dodgy there. We'll come back to this later and try to fix it
2207 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2208 and don't include a timezone
2209 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2210 This should avoid the windows-with-verbose-timezone-name problem
2212 (Patch.testPatch): add a test which runs 'patch' with less
2213 overhead than the full VCBase.do_patch sequence, to try to isolate
2214 a windows test failure. This one uses slave.commands.ShellCommand
2215 and 'patch', but none of the VC code.
2217 * buildbot/slave/commands.py (getCommand): use which() to find the
2218 executables for 'cvs', 'svn', etc. This ought to help under
2221 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2222 working directory before starting. If an earlier test failed, the
2223 leftover directory would mistakenly flunk a later test.
2224 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2225 Make sure that we use the right commandlines if which("tla") picks
2226 up "tla.exe" (as it does under windows).
2227 (TlaSupport.do_get): factor out this tla-vs-baz difference
2228 (TlaSupport.vc_create): more tla-vs-baz differences
2230 * buildbot/test/test_slavecommand.py
2231 (ShellBase.testShellMissingCommand): stop trying to assert
2232 anything about the error message: different shells on different
2233 OSes with different languages makes it hard, and it really isn't
2234 that interesting of a thing to test anyway.
2236 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2237 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2238 "Panther"), because it has a bug which flunks a couple tests in
2239 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2240 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2241 able to test that yet.
2243 2006-04-30 Brian Warner <warner@lothar.com>
2245 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2246 make sure child commands emit messages in english, so our regexps
2247 will match. Thanks to Nikaus Giger for identifying the problems.
2248 (VCBase._do_vctest_export_1): mode="export" is not responsible
2249 for setting the "got_revision" property, since in many cases it is
2250 not convenient to determine.
2251 (SVNSupport.capable): when running 'svn --version' to check for
2252 ra_local, we want error messages in english
2253 * buildbot/test/test_slavecommand.py
2254 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2255 to emit the error message in english
2257 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2258 the environment with $LC_ALL="C" so that Commands which need to
2259 parse the output of their child processes can obtain it in
2261 (SVN.parseGotRevision): call "svn info" afterwards instead of
2262 watching the output of the "svn update" or "svn checkout".
2263 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2264 (Arch.parseGotRevision): same
2265 (Bazaar.parseGotRevision): same
2266 (Mercurial.parseGotRevision): same
2268 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2269 $LC_ALL="C" when running commands under 'buildbot try', too
2271 * buildbot/test/__init__.py: remove the global os.environ()
2272 setting, instead we do it just for the tests that run commands and
2273 need to parse their output.
2275 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2276 remove the overly-short .timeout on this test, because non-DNotify
2277 platforms must fall back to polling which happens at 10 second
2278 intervals, so a 5 second timeout would never succeed.
2280 2006-04-24 Brian Warner <warner@lothar.com>
2282 * docs/buildbot.texinfo (Installing the code): update trial
2283 invocation, SF#1469116 by Niklaus Giger.
2284 (Attributes of Changes): updated branch-name examples to be
2285 a bit more realistic, SF#1475240 by Stephen Davis.
2287 * contrib/windows/buildbot2.bat: utility wrapper for windows
2288 developers, contributed by Nick Trout (after a year of neglect..
2289 sorry!). SF#1194231.
2291 * buildbot/test/test_vc.py (*.capable): store the actual VC
2292 binary's pathname in VCS[vcname], so it can be retrieved later
2293 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2294 strip out non-numeric timezone information, specifically the funky
2295 German string that his system produced that confuses CVS.
2296 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2297 allow Darcs tests to work on windows
2298 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2299 procutils.which() everywhere, to allow tryclient to work under
2300 windows. Also from Niklaus Giger, SF#1463394.
2302 * buildbot/twcompat.py (which): move the replacement for a missing
2303 twisted.python.procutils.which from test_vc.py to here, so it can
2304 be used in other places too (specifically tryclient.py)
2306 2006-04-23 Brian Warner <warner@lothar.com>
2308 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2309 bare buildbotURL/projectName line with a proper DIV, along with a
2310 CSS class of "title", from Stefan Seefeld (SF#1461675).
2311 (WaterfallStatusResource.body0): remove the redundant 'table'
2312 class from the table
2313 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2314 to the top-row TR, and class="Activity" to the second-row TR,
2315 rather than putting them in the individual TD nodes.
2317 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2318 'got_revision' build property for all VC systems that implement
2319 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2321 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2322 to determine which revision we actually obtained
2323 (CVS.parseGotRevision): implement this for CVS, which just means
2324 to grab a timestamp. Not ideal, and it depends upon the buildslave
2325 having a clock that is reasonably well syncronized with the server,
2326 but it's better than nothing.
2327 (SVN.parseGotRevision): implement it for SVN, which is accurate
2328 (Darcs.parseGotRevision): same
2329 (Arch.parseGotRevision): same
2330 (Bazaar.parseGotRevision): same
2331 (Mercurial.parseGotRevision): same
2333 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2334 keep a record of all non-stdout/stderr/header/rc status updates,
2335 for the benefit of RemoteCommands that send other useful things,
2337 (Source.commandComplete): put any 'got_revision' status values
2338 into a build property of the same name
2341 * buildbot/process/step_twisted.py (Trial): update to deal with
2342 new ShellCommand refactoring
2344 * docs/buildbot.texinfo (Build Properties): document new feature
2345 that allows BuildSteps to get/set Build-wide properties like which
2346 revision was requested and/or checked out.
2348 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2349 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2350 it. Note that this bumps the persistenceVersion of the saved Build
2351 object, so add the necessary upgrade-old-version logic to include
2352 an empty properties dict.
2354 * buildbot/process/base.py (Build.setProperty): implement it
2355 (Build.getProperty): same
2356 (Build.startBuild): change build startup to set 'branch',
2357 'revision', and 'slavename' properties at the right time
2359 * buildbot/process/step.py (BuildStep.__init__): change setup to
2360 require 'build' argument in a better way
2361 (LoggingBuildStep): split ShellCommand into two pieces, for better
2362 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2363 a single RemoteCommand that sends stdout/stderr status text. It
2364 also provides the usual commandComplete / createSummary /
2365 evaluateCommand / getText methods to be overridden...
2366 (ShellCommand): .. whereas ShellCommand is specifically for
2367 running RemoteShellCommands. Other shell-like BuildSteps (like
2368 Source) can inherit from LoggingBuildStep instead of ShellCommand
2369 (WithProperties): marker class to do build-property interpolation
2370 (Source): inherit from LoggingBuildStep instead of ShellCommand
2373 * buildbot/test/test_properties.py: test new functionality
2375 2006-04-21 Brian Warner <warner@lothar.com>
2377 * buildbot/test/test_vc.py: rename testBranch to
2378 testCheckoutBranch to keep the tests in about the right
2381 2006-04-18 Brian Warner <warner@lothar.com>
2383 * docs/buildbot.texinfo (PBListener): improve cross-references
2384 between PBListener and 'buildbot statusgui', thanks to John Pye
2387 2006-04-17 Brian Warner <warner@lothar.com>
2389 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2390 running under Twisted-1.3.0, otherwise skipped tests are reported
2393 * all: use isinstance() instead of 'type(x) is foo', suggested by
2396 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2397 oops, fix a brain-fade from the other week, when making the
2398 addStep changes. I changed all the __init__ upcalls to use the
2399 wrong superclass name.
2400 (FullTwistedBuildFactory.__init__): same
2401 (TwistedDebsBuildFactory.__init__): same
2402 (TwistedReactorsBuildFactory.__init__): same
2403 (TwistedBuild.isFileImportant): use .startswith for clarity,
2404 thanks to Neal Norwitz for the suggestions.
2406 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2407 changes, then deliver them over PB to a remote buildmaster.
2409 * contrib/svnpoller.py: added script by John Pye to poll a remote
2410 SVN repository (by running 'svn log') from a cronjob, and run
2411 'buildbot sendchange' to deliver the changes to a remote
2413 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2414 modification of svnpoller.py), same purpose, but this one loops
2415 internally (rather than expecting to run from a cronjob) and works
2417 * contrib/README.txt: same
2419 2006-04-11 Brian Warner <warner@lothar.com>
2421 * all: fix a number of incorrect names and missing imports, thanks
2422 to Anthony Baxter for the patch.
2423 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2424 remove unused buggy method.
2425 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2426 comes from shutil, not "shutils"
2427 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2428 (Arch.checkSlaveVersion): same
2429 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2431 * buildbot/process/step_twisted2.py: add some missing imports
2432 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2433 this code used to live in twisted.internet.defer
2435 2006-04-10 Brian Warner <warner@lothar.com>
2437 * buildbot/process/step.py (Mercurial): add Mercurial support
2438 * buildbot/slave/commands.py (Mercurial): same
2439 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2440 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2441 not yet tested, but 'try' support *is* covered
2442 * docs/buildbot.texinfo (Mercurial): document it
2444 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2445 some debugging messages (turned off)
2446 * buildbot/test/test_vc.py: improve debug messages
2448 2006-04-07 Brian Warner <warner@lothar.com>
2450 * buildbot/test/test_vc.py (which): define our own which() in case
2451 we can't import twisted.python.procutils, because procutils doesn't
2452 exist in Twisted-1.3
2454 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2455 of SlaveLocks for performance tests
2457 * docs/examples/twisted_master.cfg: update to match current usage
2459 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2460 password, p4 binary, pollinterval, maximum history to check.
2461 Patch from an anonymous sf.net contributor, SF#1219384.
2462 * buildbot/process/step.py (P4Sync.__init__): add username,
2463 password, and client arguments.
2464 * buildbot/slave/commands.py (P4Sync): same
2466 2006-04-05 Brian Warner <warner@lothar.com>
2468 * buildbot/process/factory.py (BuildFactory.addStep): new method
2469 to add steps to a BuildFactory. Use it instead of f.steps.append,
2470 and you can probably avoid using the s() convenience function.
2471 Patch from Neal Norwitz, sf.net #1412605.
2472 (other): update all factories to use addStep
2473 * buildbot/process/process_twisted.py: update all factories to use
2476 2006-04-03 Brian Warner <warner@lothar.com>
2478 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2479 work under windows too. Adapted from a patch by Niklaus Giger,
2480 addresses SF#1463399.
2482 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2483 spawned commands emit parseable results in english and not some
2484 other language. Patch from Niklaus Giger, SF#1463395.
2486 * README (INSTALLATION): discourage users from running unit tests on
2487 a "network drive", patch from Niklaus Giger, SF#1463394.
2489 2006-03-22 Brian Warner <warner@lothar.com>
2491 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2492 function to turn a repository-relative pathname into a (branch,
2493 branch-relative-filename) tuple. Change this function to handle
2494 the branch naming policy used by your Subversion repository.
2495 Thanks to AllMyData.com for sponsoring this work.
2497 2006-03-16 Brian Warner <warner@lothar.com>
2499 * buildbot/scripts/sample.cfg: add python-mode declaration for
2500 vim. Thanks to John Pye for the patch.
2502 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2503 command line, mention the importance of running 'crontab' as the
2504 buildmaster/buildslave user. Thanks to John Pye for the catch.
2506 2006-03-13 Brian Warner <warner@lothar.com>
2508 * buildbot/status/words.py (IRC): add an optional password=
2509 argument, which will be sent to Nickserv in an IDENTIFY message at
2510 login, to claim the nickname. freenode requires this before the
2511 bot can sent (or reply to) private messages. Thanks to Clement
2512 Stenac for the patch.
2513 * docs/buildbot.texinfo (IRC Bot): document it
2515 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2516 larger than chunkSize. Fixes SF#1349253.
2517 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2518 (Log.testConsumer): update to match new internal chunking behavior
2520 2006-03-12 Brian Warner <warner@lothar.com>
2522 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2524 * buildbot/test/test_maildir.py (MaildirTest): rename the
2525 'timeout' method, as it collides with trial's internals
2527 * buildbot/scripts/runner.py: add 'buildbot restart' command
2528 (stop): don't sys.exit() out of here, otherwise restart can't work
2529 * docs/buildbot.texinfo (Shutdown): document it
2531 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2532 * buildbot/status/html.py (Waterfall.__init__): same
2533 * buildbot/process/builder.py (Builder.startBuild): same
2534 * buildbot/process/base.py (BuildRequest): same
2535 * buildbot/sourcestamp.py (SourceStamp): same
2536 * buildbot/scheduler.py (Nightly): same
2538 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2540 * docs/buildbot.texinfo: same
2542 2006-02-17 Brian Warner <warner@lothar.com>
2544 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2545 * docs/buildbot.texinfo: set version number to match
2546 * NEWS: update for 0.7.2
2548 2006-02-16 Brian Warner <warner@lothar.com>
2550 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2552 2006-02-09 Brian Warner <warner@lothar.com>
2554 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2555 add text to explain per-build branch parameters
2556 * NEWS: mention --umask
2558 2006-02-08 Brian Warner <warner@lothar.com>
2560 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2562 (SlaveOptions.optParameters): add --umask, to make it possible to
2563 make buildslave-generated files (including build products) be
2566 * buildbot/slave/bot.py (BuildSlave.startService): same
2568 2006-01-23 Brian Warner <warner@lothar.com>
2570 * buildbot/status/builder.py: urllib.quote() all URLs that include
2571 Builder names, so that builders can include characters like '/'
2572 and ' ' without completely breaking the resulting HTML. Thanks to
2573 Kevin Turner for the patch.
2574 * buildbot/status/html.py: same
2575 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2577 * NEWS: update in preparation for upcoming release
2579 2006-01-18 Brian Warner <warner@lothar.com>
2581 * docs/examples/twisted_master.cfg: update to match the Twisted
2582 buildbot: remove python2.2, switch to exarkun's buildslaves,
2583 disable the .deb builder until we figure out how to build twisted
2584 .debs from SVN, add some ktrace debugging to the OS-X build
2585 process and remove the qt build, remove threadless builders,
2586 change freebsd builder to use landonf's buildslave.
2588 2006-01-12 Brian Warner <warner@lothar.com>
2590 * buildbot/master.py (Manhole.__init__): let port= be a strports
2591 specification string, but handle a regular int for backwards
2592 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2593 used in master.cfg to limit connections to just the local host.
2594 (BuildMaster.loadConfig): same for c['slavePortnum']
2595 * buildbot/scheduler.py (Try_Userpass.__init__): same
2596 * buildbot/status/client.py (PBListener.__init__): same
2597 * buildbot/status/html.py (Waterfall.__init__): same, for both
2598 http_port and distrib_port. Include backwards-compatibility checks
2599 so distrib_port can be a filename string and still mean unix:/foo
2600 * docs/buildbot.texinfo (Setting the slaveport): document it
2601 (Debug options): same
2602 (HTML Waterfall): same
2605 * buildbot/test/test_config.py (ConfigTest): test it
2607 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2608 slaveport's disownServiceParent deferred to fire before opening
2609 the new one. Fixes an annoying bug in the unit tests.
2611 2006-01-03 Brian Warner <warner@lothar.com>
2613 * buildbot/master.py (BuildMaster): remove the .schedulers
2614 attribute, replacing it with an allSchedulers() method that looks
2615 for all IService children that implement IScheduler. Having only
2616 one parent/child relationship means fewer opportunities for bugs.
2617 (BuildMaster.allSchedulers): new method
2618 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2619 also fix ugly bug that caused any config-file reload to
2620 half-forget about the earlier Schedulers, causing an exception
2621 when a Change arrived and was handed to a half-connected
2622 Scheduler. The exception was in scheduler.py line 54ish:
2623 self.parent.submitBuildSet(bs)
2624 exceptions.AttributeError: 'NoneType' object has no attribute
2626 (BuildMaster.addChange): update to use allSchedulers()
2628 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2629 to work properly with twisted-1.3.0, where you must explicitly
2630 include the __implements__ from parent classes
2631 (BaseScheduler.__repr__): make it easier to distinguish distinct
2633 (BaseUpstreamScheduler.__implements__): same
2635 * buildbot/status/builder.py (Status.getSchedulers): update to
2637 * buildbot/test/test_run.py (Run.testMaster): same
2638 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2639 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2640 make sure Scheduler instances are left alone when an identical
2641 config file is reloaded
2642 (ConfigElements.testSchedulers): make sure Schedulers are properly
2645 * Makefile (TRIALARGS): my local default Twisted version is now
2646 2.1.0, update the trial arguments accordingly
2648 2005-12-22 Brian Warner <warner@lothar.com>
2650 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2653 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2654 addChange in the parent class, although I suspect this should be
2655 fixed better in the future.
2657 2005-11-26 Brian Warner <warner@lothar.com>
2659 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2660 explode when branch==None, thanks to Kevin Turner for the catch
2661 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2664 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2666 * docs/buildbot.texinfo: same
2668 2005-11-26 Brian Warner <warner@lothar.com>
2670 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2671 * docs/buildbot.texinfo: set version number to match
2673 2005-11-26 Brian Warner <warner@lothar.com>
2675 * NEWS: update for 0.7.1
2677 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2678 sure that unsubscribe works even if we never sent an ETA update.
2679 Also, don't explode on duplicate unsubscribe.
2680 (BuildStepStatus.addLog): make the convenience "return self"-added
2681 watcher automatically unsubscribe when the Step finishes.
2682 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2683 (BuildStatus.stepStarted): same auto-unsubscribe
2684 (BuilderStatus.buildStarted): same auto-unsubscribe
2686 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2688 (IStatusReceiver.stepStarted): same
2689 (IStatusReceiver.logStarted): same
2691 * buildbot/test/test_run.py (Status): move the Status test..
2692 * buildbot/test/test_status.py (Subscription): .. to here
2694 2005-11-25 Brian Warner <warner@lothar.com>
2696 * NEWS: more updates
2698 * buildbot/locks.py: fix the problem in which loading a master.cfg
2699 file that changes some Builders (but not all of them) can result
2700 in having multiple copies of the same Lock. Now, the real Locks
2701 are kept in a table inside the BotMaster, and the Builders/Steps
2702 use "LockIDs", which are still instances of MasterLock and
2703 SlaveLock. The real Locks are instances of the new RealMasterLock
2704 and RealSlaveLock classes.
2705 * buildbot/master.py (BotMaster.getLockByID): new method to
2706 convert LockIDs into real Locks.
2707 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2708 into real Locks before building
2709 * buildbot/process/step.py (BuildStep.startStep): same
2710 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2711 exercises the problem
2714 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2715 what Schedulers are available
2717 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2718 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2719 'cron'-style build scheduling at certain times of day, week,
2721 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2723 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2724 handling: treat self.fileIsImportant more as an attribute that
2725 contains a callable than as a method. If the attribute is None,
2726 don't call it and assume all filenames are important. It is still
2727 possible to provide a fileIsImportant method in a subclass,
2729 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2731 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2732 test using AnyBranchScheduler with fileIsImportant=None
2734 2005-11-24 Brian Warner <warner@lothar.com>
2736 * buildbot/test/test_config.py (StartService): don't claim a fixed
2737 port number, instead set slavePort=0 on the first pass, figure out
2738 what port was allocated, then switch to a config file that uses
2741 * buildbot/master.py (BuildMaster.loadConfig): close the old
2742 slaveport before opening the new one, because unit tests might
2743 replace slavePort=0 with the same allocated portnumber, and if we
2744 don't wait for the old port to close first, we get a "port already
2745 in use" error. There is a tiny race condition here, but the only
2746 threat is from other programs that bind (statically) to the same
2747 port number we happened to be allocated, and only if those
2748 programs use SO_REUSEADDR, and only if they get control in between
2751 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2753 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2754 deleted ChangeSources before adding any new ones
2755 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2756 compare_attrs, to make sure that a config-file reload does not
2757 unnecessarily replace an unmodified ChangeSource instance
2758 * buildbot/test/test_config.py (ConfigTest.testSources): update
2760 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2761 mean "don't build anything", and add a warning if it gets used
2762 because it isn't actually useful.
2764 * contrib/svn_buildbot.py: update example usage to match the port
2765 number that gets used by the PBChangeSource
2766 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2768 2005-11-22 Brian Warner <warner@lothar.com>
2770 * NEWS: start collecting items for next release
2772 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2773 revisions are strings
2774 (P4Sync.computeSourceRevision): same
2776 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2777 to the Buildbot's overall status page
2778 (StatusResourceBuilder.body): same
2780 2005-11-15 Brian Warner <warner@lothar.com>
2782 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2783 config-file loading, specifically to make sure old StatusTargets
2784 are finished shutting down before new ones start up (thus
2785 resolving a bug in which changing the Waterfall object would fail
2786 because both new and old instances were claiming the same
2787 listening port). Also load new Schedulers after all the new
2788 Builders are set up, in case they fire off a new build right away.
2789 * buildbot/test/test_config.py (StartService): test it
2791 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2792 the branch name to the mail body
2794 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2795 Without it, a config-file reload fails to update an existing
2797 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2798 username/passwd to compare_attrs, for the same reason
2799 * buildbot/status/html.py (Waterfall): add favicon to
2800 compare_attrs, same reason
2802 2005-11-05 Brian Warner <warner@lothar.com>
2804 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2805 baserev before stuffing it in the jobfile. This resolves problems
2806 under SVN (and probably Arch) where revisions are expressed as
2807 numbers. I'm inclined to use string-based revisions everywhere in
2808 the future, but this fix should be safe for now. Thanks to Steven
2809 Walter for the patch.
2811 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2812 binary mode when opening pickle files, to make windows work
2813 better. Thanks to Dobes Vandermeer for the catch.
2814 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2815 (BuilderStatus.getBuildByNumber): same
2816 (Status.builderAdded): same
2817 * buildbot/master.py (BuildMaster.loadChanges): same
2819 * buildbot/util.py (Swappable): delete unused leftover code
2821 * buildbot/process/step.py (SVN): when building on a non-default
2822 branch, add the word "[branch]" to the VC step's description, so
2823 it is obvious that we're not building the usual stuff. Likewise,
2824 when we are building a specific revision, add the text "rNNN" to
2825 indicate what that revision number is. Thanks to Brad Hards and
2826 Nathaniel Smith for the suggestion.
2827 (Darcs.startVC): same
2828 (Arch.startVC): same
2829 (Bazaar.startVC): same
2831 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2832 typo, caught by Mark Dillavou, closes SF#1216636.
2834 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2835 about a test to add some day
2837 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2838 the 'full-2.3' build, and the 'reactors' build is now run under
2839 python-2.4 because the buildslave no longer has gtk/etc bindings
2840 for earlier versions.
2842 2005-11-03 Brian Warner <warner@lothar.com>
2844 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2845 method, takes an IBuildStatus and rebuilds it. It might make more
2846 sense to add this to IBuildControl instead, but that instance goes
2847 away completely once the build has finished, and resubmitting
2848 builds can take place weeks later.
2849 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2850 * buildbot/status/html.py (StatusResourceBuild): also stash an
2851 IBuilderControl so we can use resubmitBuild.
2852 (StatusResourceBuild.body): render "resubmit" button if we can.
2853 Also add hrefs for each BuildStep
2854 (StatusResourceBuild.rebuild): add action for "resubmit" button
2855 (StatusResourceBuilder.getChild): give it an IBuilderControl
2857 * buildbot/status/builder.py (Status.getURLForThing): change the
2858 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2859 that live as targets of buttons like "stop" and "rebuild" can't
2861 * buildbot/status/builder.py (Status.getURLForThing): same
2862 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2863 (StepBox.getBox): same
2864 * buildbot/test/test_web.py (GetURL): same
2867 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2868 exclusivity checks after Source.__init__ upcall, so misspelled
2869 arguments will be reported more usefully
2870 (Darcs.__init__): same
2872 2005-10-29 Brian Warner <warner@lothar.com>
2874 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2875 builder. Move the Try scheduler off to a separate port.
2877 2005-10-27 Brian Warner <warner@lothar.com>
2879 * buildbot/clients/gtkPanes.py
2880 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2881 to cause the app to crash, now they don't.
2883 * buildbot/clients/debug.py: display the buildmaster's location
2884 in the window's title bar
2886 2005-10-26 Brian Warner <warner@lothar.com>
2888 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2889 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2890 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2892 * buildbot/status/html.py (td): put a single non-breaking space
2893 inside otherwise empty <td> elements, as a workaround for buggy
2894 browsers which would optimize them away (along with any associated
2895 styles, like the kind that create the waterfall grid borders).
2896 Patch from Frerich Raabe.
2898 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2899 argv-list as an argument, defaulting to ["-to"], which is
2900 appropriate for the Trial that comes with Twisted-2.1.0 and
2901 earlier. The Trial in current Twisted SVN wants
2902 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2903 defaults to an empty list.
2904 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2905 match it, now that trialMode= is a list instead of a single string
2907 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2909 * docs/buildbot.texinfo: same
2911 2005-10-24 Brian Warner <warner@lothar.com>
2913 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2914 * docs/buildbot.texinfo: set version number to match
2916 2005-10-24 Brian Warner <warner@lothar.com>
2918 * README: update for 0.7.0
2920 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2922 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2923 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2924 send the branch= argument unless the user really provided one, to
2925 retain compatibility with older buildmasters that don't accept
2927 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2930 * docs/buildbot.texinfo: update lots of stuff
2932 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2933 to the 'buildbot sendchange' command
2934 * buildbot/clients/sendchange.py (Sender.send): same
2935 * buildbot/changes/pb.py (ChangePerspective): same
2936 * buildbot/test/test_changes.py (Sender.testSender): test it
2938 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2939 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2940 for consistency with other BuildStep arguments that use camelCase.
2941 Well, at least more of them use camelCase (like flunkOnWarnings)
2942 than don't.. I wish I'd picked one style and stuck with it
2943 earlier. Annoying, but it's best done before the release, since
2944 these arguments didn't exist at all in 0.6.6 .
2946 * buildbot/test/test_vc.py (SVN.testCheckout): same
2947 (Darcs.testPatch): same
2948 * docs/buildbot.texinfo (SVN): document the change
2949 (Darcs): same, add some build-on-branch docs
2950 * docs/examples/twisted_master.cfg: match change
2952 * buildbot/process/step.py (BuildStep): rename
2953 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2954 how it is normally used.
2955 * buildbot/test/test_steps.py (Version.checkCompare): same
2957 * buildbot/process/step.py (CVS.startVC): refuse to build
2958 update/copy -style builds on a non-default branch with an old
2959 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2960 concern is that it will do a VC 'update' in an existing tree when
2961 it is supposed to be switching branches (and therefore clobbering
2962 the tree to do a full checkout), thus building the wrong source.
2963 This used to be a warning, but I think the confusion it is likely
2964 to cause warrants making it an error.
2965 (SVN.startVC): same, also make mode=export on old slaves an error
2966 (Darcs.startVC): same
2967 (Git.startVC): improve error message for non-Git-enabled slaves
2968 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2969 specific revision is built on a slave that doesn't pay attention
2970 to args['revision'], because for slowly-changing trees it will
2971 probably do the right thing, and because we have no way to tell
2972 whether we're asking it to build the most recent version or not.
2973 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2975 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2976 that 'master' is in host:portnum format, to catch errors sooner
2978 2005-10-23 Brian Warner <warner@lothar.com>
2980 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2981 when creating the list of warning messages, include the line
2982 immediately after each WARNING: line, since that's usually where
2983 the file and line number wind up.
2985 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2990 2005-10-22 Brian Warner <warner@lothar.com>
2992 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2993 patch from Brad Hards
2994 * buildbot/status/classic.css: same
2995 * buildbot/test/test_web.py (Waterfall): match changes
2997 * buildbot/test/test_steps.py (BuildStep.setUp): set
2998 nextBuildNumber so the test passes
2999 * buildbot/test/test_status.py (MyBuilder): same
3001 * buildbot/status/html.py (StatusResourceBuild.body): revision
3002 might be numeric, so stringify it before html-escapifying it
3003 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3004 timer for the upcoming build
3005 * buildbot/status/classic.css: add background-color attributes for
3006 offline/waiting/building classes
3008 * buildbot/status/builder.py (BuildStatus): derive from
3009 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3010 the default (i.e. unknown) .slavename to "???" instead of None,
3011 since even unknown slavenames need to be printed eventually.
3012 (BuilderStatus): also derive from styles.Versioned . More
3013 importantly, determine .nextBuildNumber at creation/unpickling
3014 time by scanning the directory of saved BuildStatus instances and
3015 choosing one larger than the highest-numbered one found. This
3016 should fix the problem where random errors during upgrades cause
3017 the buildbot to forget about earlier builds. .nextBuildNumber is
3018 no longer stored in the pickle.
3019 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3020 at least log the error. Also call Builder.determineNextBuildNumber
3021 once the basedir is set.
3023 * buildbot/master.py (BuildMaster.loadChanges): do
3024 styles.doUpgrade afterwards, in case I decide to make Changes
3025 derived from styles.Versioned some day and forget to make this
3029 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3030 when running under older pythons (<2.3) in which the shlex module
3031 doesn't have a 'split' function.
3033 * buildbot/process/step.py (ShellCommand.start): make
3034 errorMessages= be a list of strings to stuff in the log before the
3035 command actually starts. This makes it easier to flag multiple
3036 warning messages, e.g. when the Source steps have to deal with an
3038 (CVS.startVC): handle slaves that don't handle multiple branches
3039 by switching into 'clobber' mode
3040 (SVN.startVC): same. Also reject branches without base_url
3041 (Darcs.startVC): same. Also reject revision= in older slaves
3042 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3043 (Bazaar.startVC): same, and test for baz separately than for arch
3045 * buildbot/slave/commands.py (cvs_ver): document new features
3047 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3048 (BuildStep.slaveVersionNewEnough): more useful utility method
3049 * buildbot/test/test_steps.py (Version): start testing it
3051 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3052 the 'force' command requires python2.3, for the shlex.split method
3054 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3055 since we don't use it anymore. The Twisted buildbot uses a
3058 2005-10-21 Brian Warner <warner@lothar.com>
3060 * buildbot/process/process_twisted.py: rework all BuildFactory
3061 classes to take a 'source' step as an argument, instead of
3062 building up the SVN instance in the factory.
3063 * docs/examples/twisted_master.cfg: enable build-on-branch by
3064 providing a base_url and default_branch
3066 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3067 control over --branch and --revision, not that they are always
3069 * buildbot/status/html.py (StatusResourceBuilder.force): same
3070 (StatusResourceBuild.body): display SourceStamp components
3072 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3073 IRC 'force' command, so it can be shared with an eventual
3074 command-line-tool 'buildbot force' mode.
3075 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3077 2005-10-20 Brian Warner <warner@lothar.com>
3079 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3081 * docs/examples/twisted_master.cfg: update to use Schedulers
3083 * buildbot/scripts/sample.cfg: update with Schedulers
3085 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3086 method specifically for use by HTML "force build" button and the
3087 IRC "force" command. Raises an immediate error if there are no
3089 (IBuilderControl.requestBuild): make this just submit a build, not
3090 try to check for existing slaves or set up any when-finished
3091 Deferreds or anything.
3092 * buildbot/process/builder.py (BuilderControl): same
3093 * buildbot/status/html.py (StatusResourceBuilder.force): same
3094 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3095 * buildbot/test/test_slaves.py: same
3096 * buildbot/test/test_web.py: same
3098 2005-10-19 Brian Warner <warner@lothar.com>
3100 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3101 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3103 2005-10-18 Brian Warner <warner@lothar.com>
3105 * buildbot/status/html.py: provide 'status' argument to most
3106 StatusResourceFOO objects
3107 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3108 and Logfiles" section to make the Build page into a more-or-less
3109 comprehensive source of status information about the build
3111 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3112 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3114 2005-10-17 Brian Warner <warner@lothar.com>
3116 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3117 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3118 out what to do about other projects: the correct options for
3119 recent Twisteds will not work for older ones.
3121 2005-10-15 Brian Warner <warner@lothar.com>
3123 * buildbot/status/builder.py (Status.getURLForThing): add method
3124 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3125 use this in email/IRC status clients to make them more useful, by
3126 providing the end user with hints on where to learn more about the
3127 object being reported on.
3128 * buildbot/test/test_web.py (GetURL): tests for it
3130 2005-10-14 Brian Warner <warner@lothar.com>
3132 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3133 fix bug resulting from deferredResult changes
3135 2005-10-13 Brian Warner <warner@lothar.com>
3137 * buildbot/test/test_changes.py: remove use of deferredResult
3138 * buildbot/test/test_config.py: same
3139 * buildbot/test/test_control.py: same
3140 * buildbot/test/test_status.py: same
3141 * buildbot/test/test_vc.py: this is the only remaining use, since
3142 it gets used at module level. This needs to be replaced by some
3143 sort of class-level run-once routine.
3145 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3147 * lots: implement multiple slaves per Builder, which means multiple
3148 current builds per Builder. Some highlights:
3149 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3150 of (state,currentBuilds) instead of (state,currentBuild)
3151 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3152 (IBuildStatus.getSlavename): new method, so you can tell which
3153 slave got used. This only gets set when the build completes.
3154 (IBuildRequestStatus.getBuilds): new method
3156 * buildbot/process/builder.py (SlaveBuilder): add a .state
3157 attribute to track things like ATTACHING and IDLE and BUILDING,
3159 (Builder): .. the .slaves attribute here, which has been turned
3160 into a simple list of available slaves. Added a separate
3161 attaching_slaves list to track ones that are not yet ready for
3163 (Builder.fireTestEvent): put off the test-event callback for a
3164 reactor turn, to make tests a bit more consistent.
3165 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3166 ping fails due to an exception. This needs work, I'm worried that
3167 a code error could lead to a constantly re-connecting slave.
3168 Especially since I'm trying to move to a distinct remote_ping
3169 method, separate from the remote_print that we currently use.
3170 (BuilderControl.requestBuild): return a convenience Deferred that
3171 provides an IBuildStatus when the build finishes.
3172 (BuilderControl.ping): ping all connected slaves, only return True
3173 if they all respond.
3175 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3176 reconnect when we shut down.
3178 * buildbot/status/builder.py: implement new methods, convert
3179 one-build-at-a-time methods to handle multiple builds
3180 * buildbot/status/*.py: do the same in all default status targets
3181 * buildbot/status/html.py: report the build's slavename in the
3182 per-Build page, report all buildslaves on the per-Builder page
3184 * buildbot/test/test_run.py: update/create tests
3185 * buildbot/test/test_slaves.py: same
3186 * buildbot/test/test_scheduler.py: remove stale test
3188 * docs/buildbot.texinfo: document the new builder-specification
3189 'slavenames' parameter
3191 2005-10-12 Brian Warner <warner@lothar.com>
3193 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3194 report failure correctly, causing Dependent builds to run when
3195 they shouldn't have.
3196 * buildbot/status/builder.py (BuildSetStatus): same
3197 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3198 (Set.testSuccess): test the both-pass case too
3199 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3200 fix this test: it was ending too early, masking the failure before
3201 (Logger): specialized StatusReceiver to make sure the dependent
3202 builds aren't even started, much less completed.
3204 2005-10-07 Brian Warner <warner@lothar.com>
3206 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3207 bot.SlaveBuilder being disowned in the middle of a build
3209 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3210 this inherit from StatusReceiver. Also upcall in __init__. This
3211 fixes the embarrasing crash when the new buildSetSubmitted method
3212 is invoked and Waterfall/etc don't implement their own.
3213 * buildbot/test/test_run.py: add a TODO note about a test to catch
3214 just this sort of thing.
3216 * buildbot/process/builder.py (Builder.attached): remove the
3217 already-attached warning, this situation is normal. Add some
3218 comments explaining it.
3220 2005-10-02 Brian Warner <warner@lothar.com>
3222 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3223 OverflowError when setting up dnotify, because some 64-bit systems
3224 have problems with signed-vs-unsigned constants and trip up on the
3225 DN_MULTISHOT flag. Patch from Brad Hards.
3227 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3229 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3230 progressMetrics, description, descriptionDone to the 'parms' list,
3231 and make use the 'parms' list from the implementation class
3232 instead of only BuildStep to initialize the parameters. This
3233 allows buildbot.process.factory.s() to initialize all the parms,
3234 not just those defined in directly by BuildStep.
3236 2005-09-03 Brian Warner <warner@lothar.com>
3238 * NEWS: start adding items for the next release
3240 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3241 python2.2 tests, change 'Quick' builder to only use python2.3
3243 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3245 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3246 the "Ping Builder" button if the build control is available; the
3247 user sees an exception otherwise
3249 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3251 2005-09-01 Brian Warner <warner@lothar.com>
3253 * buildbot/interfaces.py (IBuilderStatus.getState): update
3254 signature, point out that 'build' can be None
3255 (IBuildStatus.getETA): point out ETA can be none
3257 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3259 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3261 2005-08-31 Brian Warner <warner@lothar.com>
3263 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3264 update to match correct signature: removed 'eta' argument
3265 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3267 2005-08-30 Brian Warner <warner@lothar.com>
3269 * buildbot/status/builder.py (LogFile): remove the assertion that
3270 blows up when you try to overwrite an existing logfile, instead
3271 just emit a warning. This case gets hit when the buildmaster is
3272 killed and doesn't get a chance to write out the serialized
3273 BuilderStatus object, so the .nextBuildNumber attribute gets out
3276 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3277 the 'buildbot sendchange' arguments, for the Darcs context file
3278 * docs/buildbot.texinfo (sendchange): document it
3280 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3281 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3282 (IStatus.getSchedulers): new method
3283 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3284 (Status.getSchedulers): implement
3285 * buildbot/process/builder.py (Builder): maintain
3286 BuilderStatus.pendingBuilds
3287 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3288 (TryBase.addChange): Try schedulers should ignore Changes
3290 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3291 for 'try' on CVS/SVN
3292 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3294 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3295 report status properly.
3296 (Try.createJob): implement unique buildset IDs
3298 * buildbot/status/client.py (StatusClientPerspective): add a
3299 perspective_getBuildSets method for the benefit of jobdir-style
3301 * docs/buildbot.texinfo (try): more docs
3302 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3305 2005-08-18 Brian Warner <warner@lothar.com>
3307 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3308 actually work. It's functional but still kind of clunky. Also, it
3309 only works with the pb-style.. needs to be made to work with the
3312 * buildbot/status/client.py (RemoteBuildSet): new class
3313 (RemoteBuildRequest): same
3314 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3315 object, not the internal BuildStatus object.
3316 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3317 outside of the usual buildStarted() return value.
3318 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3320 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3321 (Try_Userpass_Perspective.perspective_try): return a remotely
3322 usable BuildSetStatus object
3324 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3325 isStarted()/waitUntilStarted()
3327 2005-08-16 Brian Warner <warner@lothar.com>
3329 * buildbot/status/builder.py: implement IBuildSetStatus and
3330 IBuildRequestStatus, wire them into place.
3331 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3332 methods into the BuildSetStatus object.
3333 * buildbot/interfaces.py: same
3334 (IStatus.getBuildSets): new method to get pending BuildSets
3335 (IStatusReceiver.buildsetSubmitted): new method which hears about
3337 * buildbot/master.py (BuildMaster.submitBuildSet): same
3338 * buildbot/process/base.py (BuildRequest): same, replace
3339 waitUntilStarted with subscribe/unsubscribe
3340 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3341 subscribe instead of waitUntilStarted
3342 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3344 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3346 * buildbot/test/test_buildreq.py: update for new code
3347 * buildbot/test/test_control.py (Force.testRequest): same
3350 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3351 for Darcs to not use the tempfile module, so it works under
3352 python-2.2 too. We really didn't need the full cleverness of that
3353 module, since the slave has exclusive control of its own builddir.
3355 2005-08-15 Brian Warner <warner@lothar.com>
3357 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3358 for CVS trees. It doesn't work for non-trunk branches,
3360 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3363 * Makefile: make it easier to test against python2.2
3365 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3366 tearDown2, so things like Arch can unregister archives as they're
3367 shutting down. The previous subclass-override-tearDown technique
3368 resulted in a nested maybeWait() and test failures under
3371 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3372 where we can (Arch), add a branch= argument to set the branch used
3374 (BazExtractor): extract the branch too
3375 (TlaExtractor): same
3376 * buildbot/scripts/runner.py (TryOptions): add --branch
3377 * docs/buildbot.texinfo (try): document --branch/try_branch
3379 * buildbot/slave/commands.py (Darcs): implement get-revision for
3380 Darcs, so that 'try' will work. This requires the tempfile module
3383 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3384 of revisions, branches, and 'try' in the process.
3386 2005-08-11 Brian Warner <warner@lothar.com>
3388 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3389 this, it got broken at some point in the last few releases
3390 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3391 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3392 specifically the removal of ETA information from the tuple
3394 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3397 * docs/buildbot.texinfo (try): document both --builder and
3398 'try_builders' in .buildbot/options
3399 * buildbot/scripts/runner.py (TryOptions): add --builder,
3400 accumulate the values into opts['builders']
3401 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3402 * buildbot/test/test_runner.py (Try): add some quick tests to make
3403 sure 'buildbot try --options' and .buildbot/options get parsed
3404 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3405 use --builder control
3407 * docs/buildbot.texinfo (try): add --port argument to PB style
3409 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3410 actual SourceStamp. Still need to extract a branch name, somehow.
3411 (Try): finish implementing the try client side, still need a UI
3412 for specifying which builders to use
3413 (Try.getopt): factor our options/config-file reading
3414 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3416 * buildbot/test/test_vc.py: match SourceStampExtractor change
3418 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3419 causes the twisted log to be sent to stderr
3421 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3423 2005-08-10 Brian Warner <warner@lothar.com>
3425 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3426 style is 90% done, still missing status reporting or waiting for
3427 the buildsets to finish, and it is completely untested.
3429 * buildbot/trybuild.py: delete file, move contents to ..
3430 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3431 * buildbot/test/test_vc.py: match the move
3433 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3434 of the TryScheduler, no buildsetID or status-tracking support yet
3435 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3437 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3438 possible to set the basedir after __init__ time, so it is easier
3439 to use as a Service-child of the BuildMaster instance
3441 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3442 that delivers messages to its Service parent instead of requiring
3443 a subclass to be useful. This turns out to be much easier to build
3446 * buildbot/scripts/tryclient.py (createJob): utility code to
3447 create jobfiles, will eventually be used by 'buildbot try'
3449 2005-08-08 Brian Warner <warner@lothar.com>
3451 * docs/buildbot.texinfo (try): add docs on the
3452 as-yet-unimplemented Try scheduler
3454 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3455 * buildbot/test/test_scheduler.py: .. here
3456 (Scheduling.testTryJobdir): add placeholder test for 'try'
3458 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3459 addEntry merging (>=chunkSize) behavior
3460 (Log.testConsumer): update to handle new callLater(0) behavior
3462 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3463 both the MAX_LENGTH bugfix and the resumeProducing hang.
3465 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3466 put off the actual resumeProducing for a moment with
3467 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3468 causes large logfiles to hang midway through.
3470 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3471 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3472 and to improve memory usage when streaming the file out to a web
3474 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3475 make this work cleanly
3477 2005-08-03 Brian Warner <warner@lothar.com>
3479 * buildbot/trybuild.py: new file for 'try' utilities
3480 (getSourceStamp): run in a tree, find out the baserev+patch
3481 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3482 implemented for SVN and Darcs, still working on Arch. I don't know
3483 how to make CVS work yet.
3485 * docs/buildbot.texinfo: document the 'buildbot' command-line
3486 tool, including the not-yet-implemented 'try' feature, and the
3487 in-flux .buildbot/ options directory.
3489 2005-07-20 Brian Warner <warner@lothar.com>
3491 * buildbot/locks.py: added temporary id() numbers to Lock
3492 descriptions, to track down a not-really-sharing-the-Lock bug
3494 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3496 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3497 needed for python2.2 compatibility
3498 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3499 are from the __future__
3501 2005-07-19 Brian Warner <warner@lothar.com>
3503 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3504 message when schedulers use unknown builders
3506 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3507 SlaveLock('name') and MasterLock('name') are distinct
3509 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3510 c['schedulers'] in such a way that we can actually accept
3512 * buildbot/test/test_config.py: check it
3514 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3515 utility method to *all* the Schedulers
3516 (Periodic.listBuilderNames): same
3518 * docs/buildbot.texinfo (Interlocks): update chapter to match
3521 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3522 to make sure that c['sources'], c['schedulers'], and c['status']
3523 are all lists of the appropriate objects, and that the Schedulers
3524 all point to real Builders
3525 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3526 'listBuilderNames' utility method to support this
3527 * buildbot/scheduler.py: implement the utility method
3528 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3530 * docs/buildbot.texinfo: add some @cindex entries
3532 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3533 if it wasn't already set: most tla commands will fail unless one
3535 (Arch.createRepository): and disable bazaar's revision cache, since
3536 they cause test failures (the multiple repositories we create all
3537 interfere with each other through the cache)
3539 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3540 bring it properly up to date with twisted-2.0 test guidelines
3542 * buildbot/master.py (BuildMaster): remove references to old
3543 'interlock' module, this caused a bunch of post-merge test
3545 * buildbot/test/test_config.py: same
3546 * buildbot/process/base.py (Build): same
3548 * buildbot/test/test_slaves.py: stubs for new test case
3550 * buildbot/scheduler.py: add test-case-name tag
3551 * buildbot/test/test_buildreq.py: same
3553 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3554 unnecessary init code
3555 (Bot.remote_setBuilderList): match it
3557 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3559 * buildbot/changes/mail.py (parseSyncmail): update comment
3561 * buildbot/test/test_slavecommand.py: disable Shell tests on
3562 platforms that don't suport IReactorProcess
3564 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3565 all places where we open logfiles. It causes OS-X to open the file
3566 in some weird mode that that prevents us from mixing reads and
3567 writes to the same filehandle, which we depend upon to implement
3568 _generateChunks properly. This change doesn't appear to break
3569 win32, on which "b" and "t" are treated differently but a missing
3570 flag seems to be interpreted as "t".
3572 2005-07-18 Brian Warner <warner@lothar.com>
3574 * buildbot/slave/commands.py (ShellCommand): overhaul
3575 error-handling code, to try and make timeout/interrupt work
3576 properly, and make win32 happier
3577 * buildbot/test/test_slavecommand.py: clean up, stop using
3578 reactor.iterate, add tests for timeout and interrupt
3579 * buildbot/test/sleep.py: utility for a new timeout test
3581 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3582 code from the local-usebranches branch
3584 2005-07-17 Brian Warner <warner@lothar.com>
3586 * buildbot/process/process_twisted.py
3587 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3588 minutes, to match the other twisted BuildFactories, and don't
3589 excuse failures in c/qt/win32 reactors any more.
3591 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3592 'freebsd' builders, since the buildslaves have been unavailable
3595 2005-07-13 Brian Warner <warner@lothar.com>
3597 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3598 build-on-branch feature
3600 * buildbot/process/step.py (Darcs.__init__): add base_url and
3601 default_branch arguments, just like SVN
3602 (Arch.__init__): note that the version= argument is really the
3605 * buildbot/slave/commands.py (SourceBase): keep track of the
3606 repository+branch that was used for the last checkout in
3607 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3608 match, we clobber the directory and perform a fresh checkout
3609 rather than trying to do an in-place update. This should protect
3610 us against trying to get to branch B by doing an update in a tree
3611 obtained from branch A.
3612 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3613 (SVN.setup): same, just the svnurl
3614 (Darcs.setup): same, just the repourl
3615 (Arch.setup): same, arch coordinates (url), version, and
3616 buildconfig. Also pull the buildconfig from the args dictionary,
3617 which we weren't doing before, so the build-config was effectively
3619 (Arch.sourcedirIsUpdateable): don't try to update when we're
3620 moving to a specific revision: arch can't go backwards, so it is
3621 safer to just clobber the tree and checkout a new one at the
3623 (Bazaar.setup): same sourcedata as Arch
3625 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3626 use maybeWait, to work with twisted-1.3.0 and twcompat
3627 (Dependencies.testRun_Pass): same
3629 * buildbot/test/test_vc.py: rearrange, cleanup
3631 * buildbot/twcompat.py: add defer.waitForDeferred and
3632 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3633 can work under twisted-1.3.0 .
3635 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3636 now created at setUp time. This increases the runtime of the test
3637 suite considerably (from 91 seconds to 151), but it removes the
3638 need for an offline tarball, which should solve a problem I've
3639 seen where the test host has a different version of svn than the
3640 tarball build host. The new code also validates that mode=update
3641 really picks up recent commits. This approach will also make it
3642 easier to test out branches, because the code which creates the VC
3643 branches is next to the code which uses them. It will also make it
3644 possible to test some change-notification hooks, by actually
3645 performing a VC commit and watching to see the ChangeSource get
3648 2005-07-12 Brian Warner <warner@lothar.com>
3650 * docs/buildbot.texinfo (SVN): add branches example
3651 * docs/Makefile (buildbot.ps): add target for postscript manual
3653 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3654 * buildbot/test/test_locks.py: same
3656 * buildbot/process/step.py (Darcs): comment about default branches
3658 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3659 c['interlocks'] in the config file, complain if it is present.
3660 Scan all locks in c['builders'] to make sure the Locks they use
3662 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3663 add some tests to check for non-uniquely-named Locks
3664 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3665 since the unique-Lock validation code requires it now
3667 * buildbot/locks.py: fix test-case-name
3669 * buildbot/interlock.py: remove old file
3671 2005-07-11 Brian Warner <warner@lothar.com>
3673 * buildbot/test/test_interlock.py: rename to..
3674 * buildbot/test/test_locks.py: .. something shorter
3676 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3677 versions (after 2.0.1) changed internet.TCPClient to shut down the
3678 connection in stopService. Change the code to handle this
3681 * buildbot/process/base.py (Build): handle whole-Build locks
3682 * buildbot/process/builder.py (Builder.compareToSetup): same
3683 * buildbot/test/test_interlock.py: make tests work
3685 * buildbot/process/step.py (BuildStep.startStep): complain if a
3686 Step tries to claim a lock that's owned by its own Build
3687 (BuildStep.releaseLocks): typo
3689 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3690 file reloads don't replace unchanged Builders
3692 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3693 rewrite to cover new Locks instead of old c['interlocks']
3694 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3698 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3699 start the master and connect the buildslave
3701 * buildbot/process/step.py (FailingDummy.done): finish with a
3702 FAILURE status rather than raising an exception
3704 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3705 stringify a BuildRequest.reason that is None
3707 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3709 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3710 allow scheduler.Dependent to work
3711 * buildbot/buildset.py (BuildSet): set .reason and .results
3713 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3714 slaves, to make the test stop hanging. It still fails, of course,
3715 because I haven't even started to implement Locks.
3717 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3719 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3720 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3721 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3722 (Dependent): new class for downstream build dependencies
3723 * buildbot/test/test_dependencies.py: tests (still failing)
3725 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3727 2005-07-07 Brian Warner <warner@lothar.com>
3729 * buildbot/test/runutils.py (RunMixin): factored this class out..
3730 * buildbot/test/test_run.py: .. from here
3731 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3732 added new buildbot.locks tests (which all hang right now)
3733 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3734 * buildbot/process/step.py: claim/release per-BuildStep locks
3736 * docs/Makefile: add 'buildbot.html' target
3738 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3739 interpreted as "HEAD", so that all VC steps can accept branch=None
3740 and have it mean the "default branch".
3742 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3744 2005-07-07 Brian Warner <warner@lothar.com>
3746 * docs/examples/twisted_master.cfg: update to match current usage
3748 * docs/buildbot.texinfo (System Architecture): comment out the
3749 image, it doesn't exist yet and just screws up the HTML manual.
3751 2005-07-05 Brian Warner <warner@lothar.com>
3753 * debian/.cvsignore: oops, missed one. Removing leftover file.
3755 2005-06-17 Brian Warner <warner@lothar.com>
3757 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3758 changed its output in 1.2.0, don't mistakenly think that the
3759 subversion we find isn't capable of supporting our tests.
3761 * debian/*: remove the debian/ directory and its contents, to make
3762 life easier for the proper Debian maintainer
3764 * Makefile (release): same
3766 2005-06-07 Brian Warner <warner@lothar.com>
3768 * everything: create a distinct SourceStamp class to replace the
3769 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3770 Changed the signature of Source.startVC to include the revision
3771 information (instead of passing it through self.args). Implement
3772 branches for SVN (now only Darcs/Git is missing support). Add more
3775 2005-06-06 Brian Warner <warner@lothar.com>
3777 * everything: rearrange build scheduling. Create a new Scheduler
3778 object (configured in c['schedulers'], which submit BuildSets to a
3779 set of Builders. Builders can now use multiple slaves. Builds can
3780 be run on alternate branches, either requested manually or driven
3781 by changes. This changed some of the Status classes. Interlocks
3782 are out of service until they've been properly split into Locks
3783 and Dependencies. treeStableTimer, isFileImportant, and
3784 periodicBuild have all been moved from the Builder to the
3786 (BuilderStatus.currentBigState): removed the 'waiting' and
3787 'interlocked' states, removed the 'ETA' argument.
3789 2005-05-24 Brian Warner <warner@lothar.com>
3791 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3792 erroneously abandons the connection (in clientConnectionFailed)
3793 for non-UserErrors, which means that if we lose the connection due
3794 to a network problem or a timeout, we'll never try to reconnect.
3795 Fix this by not upcalling to the buggy parent method. Note:
3796 twisted-2.0 fixes this, but the function only has 3 lines so it
3797 makes more sense to copy it than to try and detect the buggyness
3798 of the parent class. Fixes SF#1207588.
3800 * buildbot/changes/changes.py (Change.branch): doh! Add a
3801 class-level attribute to accomodate old Change instances that were
3802 pickled before 0.6.5 (where .branch was added for new Changes).
3803 This fixes the exception that occurs when you try to look at an
3804 old Change (through asHTML).
3806 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3809 2005-05-23 Brian Warner <warner@lothar.com>
3811 * buildbot/__init__.py (version): release 0.6.6
3813 2005-05-23 Brian Warner <warner@lothar.com>
3815 * NEWS: update for 0.6.6 release
3816 * debian/changelog: same
3818 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3819 before starting: this was done by twistd back when we spawned it,
3820 now that we're importing the pieces and running them in the
3821 current process, we have to do it ourselves. This allows
3822 master.cfg to import files from the same directory without
3823 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3824 Stichele for the catch.
3825 (Options.opt_version): Add a --version command (actually, just make
3826 the existing --version command emit Buildbot's version too)
3828 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3829 fix to make this behave like other LogFiles, this time to handle
3830 existing LogFiles on disk. (add the missing .upgrade method)
3831 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3833 2005-05-21 Brian Warner <warner@lothar.com>
3835 * buildbot/test/test_runner.py (Create.testMaster): match the
3836 rawstring change in runner.py:masterTAC
3838 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3839 TwistedWords is installed
3840 * buildbot/test/test_status.py: same, with TwistedMail
3842 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3843 some old, deprecated, and removed config keys). This should enable
3844 you to use the base buildbot functionality with Twisted-2.0.0 when
3845 you don't also have TwistedWeb and TwistedWords installed
3847 2005-05-20 Brian Warner <warner@lothar.com>
3849 * buildbot/scripts/runner.py (run): call sendchange(), not
3850 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3851 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3852 (stop): don't wait for process to die when sending SIGHUP
3853 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3854 directory name gets interpreted, which you don't want
3857 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3860 2005-05-18 Brian Warner <warner@lothar.com>
3862 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3864 2005-05-18 Brian Warner <warner@lothar.com>
3866 * README: update for 0.6.5
3867 * debian/changelog: same
3869 * buildbot/changes/changes.py: rename tag= to branch=, since
3870 that's how we're using it, and my design for the upcoming "build a
3871 specific branch" feature wants it. also, tag= was too CVS-centric
3872 * buildbot/changes/mail.py (parseSyncmail): same
3873 * buildbot/process/base.py (Build.isBranchImportant): same
3874 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3875 * docs/buildbot.texinfo (Attributes of Changes): same
3877 * NEWS: update tag=, update for upcoming release
3879 2005-05-17 Brian Warner <warner@lothar.com>
3881 * buildbot/scripts/runner.py (stop): actually poll once per
3882 second, instead of re-killing the poor daemon once per second.
3883 Sleep briefly (0.1s) before the first poll, since there's a good
3884 chance we can avoid waiting the full second if the daemon shuts
3885 down quickly. Also remove the sys.exit() at the end.
3886 (start): remove the unneighborly sys.exit()
3888 * Makefile: improve permission-setting to not kick Arch so badly
3890 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3891 default --keepalive=600, since it doesn't hurt very much, and it's
3892 a hassle to discover that you need it.
3893 * buildbot/test/test_runner.py (Create.testSlave): test it
3895 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3896 IRC bot about EXCEPTION
3898 * buildbot/status/client.py (PBListener): upcall more correctly
3900 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3901 an exception mark the overall build with EXCEPTION, not SUCCESS
3903 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3905 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3906 * Makefile: update some release-related stuff
3908 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3909 gets called when there isn't actually an active process, just end
3910 the Command instead of blowing up. I don't know how it gets into
3911 this state, but the twisted win32 buildslave will sometimes hang,
3912 and when it shakes its head and comes back, it thinks it's still
3913 running a Command. The next build causes this command to be
3914 interrupted, but the lack of self.process.pid breaks the interrupt
3917 * NEWS: document changes since the last release
3919 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3920 look for Makefile.buildbot instead of a bare Makefile . The
3921 'buildbot start' does not install this file, so you have to
3922 manually copy it if you want to customize startup behavior.
3923 (createMaster): change 'buildbot master' command to create
3924 Makefile.sample instead of Makefile, to create master.cfg.sample
3925 instead of master.cfg (requiring you to copy it before the
3926 buildmaster can be started). Both sample files are kept up to
3927 date, i.e. they are overwritten if they have been changed. The
3928 'buildbot.tac' file is *not* overwritten, but if the new contents
3929 don't match the old, a 'buildbot.tac.new' file is created and the
3930 user is warned. This seems to be a much more sane way to handle
3931 startup files. Also, don't sys.exit(0) when done, so we can run
3932 unit tests against it.
3933 (createSlave): same. Don't overwrite the sample info/ files.
3934 * buildbot/scripts/sample.mk: remove. the contents were pulled
3935 into runner.py, since they need to match the behavior of start()
3939 * docs/buildbot.texinfo (Launching the daemons): document it
3940 * buildbot/test/test_runner.py (Create): test it
3942 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3943 version that can handle string-in-string tests, because otherwise
3944 python-2.2 fails the tests. It'd be tremendous if Trial's test
3945 took two strings under 2.2 too.
3947 * everything: fixed all deprecation warnings when running against
3948 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3949 few that come from Twisted itself). This involved putting most of
3950 the Twisted-version specific code in the new buildbot.twcompat
3951 module, and creating some abstract base classes in
3952 buildbot.changes.base and buildbot.status.base (which might be
3953 useful anyway). __implements__ is a nuisance and requires an ugly
3954 'if' clause everywhere.
3956 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3957 delay before finishing the test: it seems that smtp.sendmail
3958 doesn't hang up on the server, so we must wait a moment so it can
3959 hang up on us. This removes the trial warning about an unclean
3962 2005-05-16 Brian Warner <warner@lothar.com>
3964 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3965 tuple of (delay, repeats).
3966 * buildbot/test/test_vc.py (Retry): test it
3967 * docs/buildbot.texinfo (Source Checkout): document it
3968 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3969 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3970 doVCFull() are handled by re-trying the checkout (after a delay)
3971 some number of times.
3972 (ShellCommand._startCommand): make header lines easier to read
3974 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3976 (WebTest.test_logfile): make sure master gets shut down, silences
3977 some "unclean reactor" test errors
3979 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3980 reactor once after shutdown, something in certain versions of
3981 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3982 fails, svn-trunk is ok.
3984 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3985 second win32 error message
3987 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3988 validating the ETA, so the tests don't fail on slow systems
3990 2005-05-15 Brian Warner <warner@lothar.com>
3992 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3993 the new LogFile class, so upgrading works properly
3994 (LogFileProducer.resumeProducing): survive resumeProducing after
3995 we've exhausted the chunkGenerator
3997 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3999 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4000 (Log.testUpgrade): same
4002 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4003 Builds and logs with a cron job.
4005 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4006 of the old non-offline LogFile, added code to upgrade these to
4007 new-style contents-live-on-disk instances at load time (in a way
4008 that doesn't invalidate the old Build pickles, so upgrading to
4009 0.6.5 is not a one-way operation). Got rid of everything related
4011 (LogFile.__init__): create LogFiles with the parent step status,
4012 the log's name, and a builder-relative filename where it can keep
4013 the contents on disk.
4014 (LogFile.hasContents): new method, clients are advised to call it
4015 before getText or getChunks and friends. If it returns False, the
4016 log's contents have been deleted and getText() will raise an
4018 (LogFile.getChunks): made it a generator
4019 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4020 Consumer (except one that takes chunks instead of strings). This
4021 enables streaming of very large logfiles without storing the whole
4023 (BuildStatus.generateLogfileName): create names like
4024 12-log-compile-output, with a _0 suffix if required to be unique
4025 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4026 or earlier) logfiles into new-style ones
4027 (BuilderStatus): remove everything related to 'stub' builds. There
4028 is now only one build cache, and we don't strip logs from old
4030 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4031 since we no longer fight to keep it in the cache
4033 * buildbot/status/html.py (TextLog.render_GET): use a
4034 ChunkConsumer to stream the log entries efficiently.
4035 (ChunkConsumer): wrapper which consumes chunks and writes
4038 * buildbot/test/test_twisted.py (Parse.testParse): use a
4039 LogFile-like object instead of a real one
4041 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4042 (Log.testMerge3): validate more merge behavior
4043 (Log.testChunks): validate LogFile.getChunks
4044 (Log.testUpgrade): validate old-style LogFile upgrading
4045 (Log.testSubscribe): validate LogFile.subscribe
4046 (Log.testConsumer): validate LogFile.subscribeConsumer
4048 * buildbot/interfaces.py (IStatusLogStub): remove
4049 (IStatusLog.subscribeConsumer): new method
4050 (IStatusLog.hasContents): new method
4051 (IStatusLogConsumer): describes things passed to subscribeConsumer
4053 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4054 the log contents if it does not have any contents.
4055 (StatusResourceBuildStep.body): same
4056 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4058 2005-05-14 Brian Warner <warner@lothar.com>
4060 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4061 timeouts to try and make the windows metabuildslave not hang
4063 2005-05-13 Mike Taylor <bear@code-bear.com>
4065 * buildbot/slave/commands.py (rmdirRecursive): added a check
4066 to ensure the path passed into rmdirRecursive actually exists.
4067 On win32 a non-existant path would generate an exception.
4069 2005-05-13 Brian Warner <warner@lothar.com>
4071 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4072 shutil.rmtree which behaves correctly on windows in the face of
4073 files that you have to chmod before deleting. Thanks to Bear at
4074 the OSAF for the routine.
4075 (SourceBase.doClobber): use rmdirRecursive
4077 2005-05-12 Brian Warner <warner@lothar.com>
4079 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4080 method generate chunks instead of returning a big list. This
4081 allows the same method to be used for both old LogFile and new
4083 (OfflineLogFile.getText): use the generator
4084 (OfflineLogFile.subscribe): same
4085 * buildbot/status/html.py (TextLog.resumeProducing): same
4086 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4088 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4089 point out that OfflineLogFile does not currently work with
4090 html.Waterfall . Fixing this is high-priority.
4092 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4093 apparently windows defaults to using stdout
4095 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4096 better message on failure so I can figure out the win32 problem
4098 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4099 log messages to include more useful copies of the command being
4100 run, the argv array, and the child command's environment.
4101 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4103 2005-05-11 Brian Warner <warner@lothar.com>
4105 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4107 * Makefile: update the deb-snapshot version
4109 * docs/buildbot.texinfo: move all .xhtml docs into a new
4110 .texinfo-format document, adding a lot of material in the process.
4111 This is starting to look like a real user's manual. Removed all
4112 the Lore-related files: *.xhtml, *.css, template.tpl .
4113 * docs/Makefile: simple makefile to run 'makeinfo'
4114 * buildbot/scripts/sample.cfg: rearrange slightly
4115 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4117 2005-05-10 Brian Warner <warner@lothar.com>
4119 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4120 different name for the internal twistw module, handle it.
4122 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4123 * setup.py: .. and stop trying to install it
4125 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4126 'git'), the new linux kernel VC system (http://kernel.org/git/).
4127 Thanks to Brandon Philips for the patch.
4128 * buildbot/slave/commands.py (Git): same
4130 2005-05-06 Brian Warner <warner@lothar.com>
4132 * buildbot/status/builder.py (OfflineLogFile): replace the default
4133 LogFile with a form that appends its new contents to a disk file
4134 as they arrive. The complete log data is never kept in RAM. This
4135 is the first step towards handling very large (100MB+) logfiles
4136 without choking quite so badly. (The other half is
4137 producer/consumer on the HTML pages).
4138 (BuildStepStatus.addLog): use OfflineLogFile by default
4139 (BuildStatus.getLogfileName): helper code to give the
4140 OfflineLogFile a filename to work with
4142 * buildbot/test/test_status.py (Results.testAddResults): update
4143 tests to handle new asserts
4144 * buildbot/test/test_vc.py (Patch.doPatch): same
4145 * buildbot/test/test_steps.py (BuildStep.setUp): same
4147 2005-05-05 Brian Warner <warner@lothar.com>
4149 * buildbot/scripts/runner.py (start): if there is no Makefile,
4150 launch the app by importing twistd's internals and calling run(),
4151 rather than spawning a new twistd process. This stands a much
4152 better chance of working under windows.
4153 (stop): kill the process with os.kill instead of spawning
4154 /bin/kill, again to reduce the number of external programs which
4155 windows might not have in the PATH. Also wait up to 5 seconds for
4156 the process to go away, allowing things like 'buildbot stop;
4157 buildbot start' to be reliable in the face of slow shutdowns.
4159 * buildbot/master.py (Dispatcher.__getstate__): remove old
4160 .tap-related methods
4161 (BuildMaster.__getstate__): same
4163 * buildbot/slave/bot.py (makeService): same
4164 (Options.longdesc): same
4165 * buildbot/scripts/runner.py: copy over some old mktap option text
4167 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4168 'buildbot master' now creates a buildbot.tac file, so there is no
4169 longer a create-instance/save/reload sequence. mktap is dead, long
4171 * buildbot/scripts/sample.mk: use twistd -y, not -f
4172 * buildbot/test/test_config.py: remove mktap-based test
4173 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4174 * README: don't reference mktap
4176 * docs/source.xhtml: document some of the attributes that Changes
4179 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4181 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4182 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4183 * buildbot/changes/changes.py (Change)
4184 * buildbot/changes/mail.py (parseSyncmail)
4185 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4187 * buildbot/process/base.py (Build.isTagImportant)
4191 2005-05-04 Brian Warner <warner@lothar.com>
4193 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4194 connection after sending the change, so that unit tests don't
4195 complain about sockets being left around
4197 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4198 exception in phase=0 rendering
4199 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4201 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4203 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4204 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4205 and configuring builders with tuples.
4206 * buildbot/test/test_config.py: stop testing compatibility with
4207 deprecated config keys
4208 * buildbot/test/test_run.py: same
4210 2005-05-03 Brian Warner <warner@lothar.com>
4212 * contrib/arch_buildbot.py: survive if there are no logfiles
4213 (username): just use a string, os.getlogin isn't reliable
4215 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4216 so 'buildbot sendchange' actually works. The earlier test only
4217 covered the internal (non-reactor-running) form.
4219 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4220 script to notify the buildmaster about changes
4222 * buildbot/scripts/runner.py (sendchange): new command to send a
4223 change to a buildbot.changes.pb.PBChangeSource receiver.
4224 * buildbot/test/test_changes.py (Sender): test it
4226 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4227 after any reading of the config file, not just when we do it in
4228 startService. This makes some tests a bit cleaner.
4230 * buildbot/changes/pb.py: add some log messages
4232 * buildbot/process/base.py (Build.startBuild): fix a bug that
4233 caused an exception when the build terminated in the very first
4235 (Build.stepDone): let steps return a status of EXCEPTION. This
4236 terminates the build right away, and sets the build's overall
4237 status to EXCEPTION too.
4238 * buildbot/process/step.py (BuildStep.failed): return a status of
4239 EXCEPTION when that is what has happened.
4241 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4242 implement this, allowing Arch-based projects to get precise
4243 checkouts instead of always using the latest code
4244 (Bazaar): create variant of Arch to let folks use baz instead of
4245 tla. Requires a new buildslave too.
4246 * buildbot/slave/commands.py (Arch): add 'revision' argument
4247 (Bazaar): create variant of Arch that uses baz instead of tla.
4248 Remove the code that extracts the archive name from the
4249 register-archive output, since baz doesn't provide it, and require
4250 the user provide both the archive name and its location.
4251 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4253 2005-05-02 Brian Warner <warner@lothar.com>
4255 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4256 thanks to Nick Trout.
4258 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4259 deals better with source Makefile coming from a read-only CVS
4260 checkout. Thanks to Nick Trout for the catch.
4262 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4265 2005-04-28 Brian Warner <warner@lothar.com>
4267 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4269 * debian/changelog: update for 0.6.4
4271 2005-04-28 Brian Warner <warner@lothar.com>
4273 * README.w32: add a checklist of steps for getting buildbot
4275 * MANIFEST.in: include it in the tarball
4279 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4280 broken .tap files from 0.6.3 by getting rid of .services,
4281 .namedServices, and .change_svc at load time.
4283 2005-04-27 Brian Warner <warner@lothar.com>
4285 * NEWS: update in preparation for new release
4287 * buildbot/test/test_config.py (Save.testSave): don't pull in
4288 twisted.scripts.twistd, we don't need it and it isn't for windows
4291 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4292 accomodate win32 which can't do atomic-rename
4294 2005-04-27 Brian Warner <warner@lothar.com>
4296 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4297 timeouts to help the slow metabuildbot not flunk them so much
4298 (Disconnect.testBuild3): same
4299 (Disconnect.testBuild4): same
4300 (Disconnect.testInterrupt): same
4302 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4303 setup, it was completely broken for new buildmasters (those which
4304 did not have a 'change.pck' already saved. Thanks to Paul Warren
4305 for catching this (embarrassing!) bug.
4306 (Dispatcher.__getstate__): don't save our registered avatar
4307 factories, since they'll be re-populated when the config file is
4309 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4310 tests (since the real mktap-generated BuildMaster doesn't save
4312 (BuildMaster.__getstate__): don't save any service children,
4313 they'll all be re-populated when the config file is re-read.
4314 * buildbot/test/test_config.py (Save.testSave): test for this
4316 2005-04-26 Brian Warner <warner@lothar.com>
4318 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4319 rendered with Blender.. looks a bit nicer.
4320 * buildbot/docs/images/icon.blend: add the Blender file for it
4322 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4323 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4324 running under windows. This appears to be the best way to allow
4325 BuildSteps to do something normal like 'trial -v buildbot.test' or
4326 'make foo' and still expect it to work. The idea is to make the
4327 BuildSteps look as much like what a developer would type when
4328 compiling or testing the tree by hand. This approach probably has
4329 problems when there are spaces in the arguments, so if you've got
4330 windows buildslaves, you'll need to pay close attention to your
4333 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4334 timezone to the timestamp column.
4335 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4337 * buildbot/scripts/runner.py (loadOptions): do something sane for
4338 windows, I think. We use %APPDATA%/buildbot instead of
4339 ~/.buildbot, but we still search everywhere from the current
4340 directory up to the root for a .buildbot/ subdir. The "is it under
4341 $HOME" security test was replaced with "is it owned by the current
4342 user", which is only performed under posix.
4343 * buildbot/test/test_runner.py (Options.testFindOptions): update
4344 tests to match. The "is it owned by the current user" check is
4345 untested. The test has been re-enabled for windows.
4347 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4348 any "\n" in the expected output with the platform-specific line
4349 separator. Make this separator "\r\n" on PTYs under unix, they
4350 seem to do that and I don't know why
4352 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4353 windows for now, I don't know what ~/.buildbot/ should mean there.
4355 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4356 win32 compatibility, don't use "/tmp"
4357 (Basedir.testChangeBuilddir): remove more unixisms
4359 2005-04-26 Brian Warner <warner@lothar.com>
4361 * buildbot/test/test_control.py (Force.rmtree): python2.2
4362 compatibility, apparently its shutil.rmtree ignore_errors=
4363 argument is ignored.
4364 * buildbot/test/test_run.py (Run.rmtree): same
4365 (RunMixin.setUp): same
4367 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4370 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4371 'substring in string' operator, must use string.find(substr)!=-1
4372 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4373 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4375 * buildbot/scripts/runner.py (loadOptions): add code to search for
4376 ~/.buildbot/, a directory with things like 'options', containing
4377 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4378 the current directory, your $HOME directory, or anywhere
4379 inbetween, as long as you're somewhere inside your home directory.
4380 (debugclient): look in ~/.buildbot/options for master and passwd
4381 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4382 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4384 * buildbot/status/client.py (makeRemote): new approach to making
4385 IRemote(None) be None, which works under Twisted-2.0
4386 * buildbot/test/test_status.py (Client.testAdaptation): test it
4388 * buildbot/status/builder.py (Status.builderAdded): when loading a
4389 pickled BuilderStatus in from disk, set its name after loading.
4390 The config file might have changed its name (but not its
4391 directory) while it wasn't looking.
4393 * buildbot/process/builder.py (Builder.attached): always return a
4394 Deferred, even if the builder was already attached
4395 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4397 2005-04-25 Brian Warner <warner@lothar.com>
4399 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4400 category-related exception when announcing a build has finished
4402 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4403 reference no-longer-existent changemaster.sources
4404 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4406 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4409 2005-04-25 Brian Warner <warner@lothar.com>
4411 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4413 * debian/changelog: update for 0.6.3
4415 2005-04-25 Brian Warner <warner@lothar.com>
4417 * MANIFEST.in: make sure debug.glade is in the tarball
4419 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4421 * NEWS: update for the imminent 0.6.3 release
4423 * buildbot/status/html.py (HtmlResource.content): make the
4424 stylesheet <link> always point at "buildbot.css".
4425 (StatusResource.getChild): map "buildbot.css" to a static.File
4426 containing whatever css= argument was provided to Waterfall()
4427 (Waterfall): provide the "classic" css as the default.
4428 * docs/waterfall.classic.css: move default CSS from here ..
4429 * buildbot/status/classic.css: .. to here
4431 * MANIFEST.in: make sure classic.css is included in the tarball
4432 * setup.py: and that it is installed too, under buildbot/status/
4434 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4435 the module level, because buildbot.tap files from 0.6.2 don't have
4436 it in their attribute dictionary.
4438 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4439 really exists at startup, might save some confusion somewhere.
4441 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4443 * docs/waterfall.classic.css:
4444 add a stylesheet that's almost the same as the "classic"
4447 * buildbot/status/builder.py:
4448 add EXCEPTION as a result - this is a problem for the bot
4449 maintainer, not a build problem for the changers
4450 * buildbot/process/step.py:
4451 use EXCEPTION instead of FAILURE for exceptions
4452 * buildbot/status/html.py:
4453 add build_get_class to get a class out of a build/buildstep
4454 finish naming the classes
4455 split out sourceNames to changeNames and builderNames so we
4456 can style them separately
4457 * docs/config.xhtml:
4458 finish documenting classes as they are right now
4460 * buildbot/status/html.py:
4461 name the classes as we agreed on IRC
4462 * docs/config.xhtml:
4465 * buildbot/status/html.py:
4466 same for cssclass->class_
4468 * buildbot/status/html.py:
4469 as decided on IRC, use class_ for the "class" attribute to not
4470 conflict with the class keyword, and clean up the messy **{} stuff.
4472 * buildbot/status/mail.py:
4473 put back "builders" argument, and fix docstring, because the
4474 code *ignores* builders listed in this argument
4476 * buildbot/process/builder.py:
4477 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4479 * docs/config.xhtml:
4480 describe the category argument for builders
4482 * buildbot/status/builder.py:
4483 Fix a silly bug due to merging
4485 * buildbot/process/builder.py:
4486 remove category from the process Builder ...
4487 * buildbot/status/builder.py:
4488 ... and add it to BuilderStatus instead.
4489 Set category on unpickled builder statuses, they might not have it.
4490 * buildbot/master.py:
4491 include category when doing builderAdded
4492 * buildbot/status/mail.py:
4493 return None instead of self for builders we are not interested in.
4494 * buildbot/test/test_run.py:
4495 fix a bug due to only doing deferredResult on "dummy" waiting
4496 * buildbot/test/test_status.py:
4497 add checks for the Mail IStatusReceiver returning None or self
4499 * buildbot/status/html.py:
4500 fix testsuite by prefixing page title with BuildBot
4502 * buildbot/status/builder.py:
4503 have .category in builder status ...
4504 * buildbot/process/builder.py:
4505 ... and set it from Builder
4506 * buildbot/status/html.py:
4507 make .css a class variable
4508 * buildbot/test/test_status.py:
4509 write more tests to cover our categories stuff ...
4510 * buildbot/status/mail.py:
4511 ... and fix the bug that this uncovered
4513 * buildbot/changes/mail.py:
4514 * buildbot/changes/pb.py:
4515 * buildbot/master.py:
4516 * buildbot/process/base.py:
4517 * buildbot/process/factory.py:
4518 * buildbot/process/interlock.py:
4519 * buildbot/process/step.py:
4520 * buildbot/process/step_twisted.py:
4521 * buildbot/slave/commands.py:
4522 * buildbot/status/builder.py:
4523 * buildbot/status/client.py:
4524 * buildbot/status/html.py:
4525 * buildbot/status/mail.py:
4526 * buildbot/status/progress.py:
4527 * buildbot/test/test_changes.py:
4528 * buildbot/test/test_config.py:
4529 * buildbot/test/test_control.py:
4530 * buildbot/test/test_interlock.py:
4531 * buildbot/test/test_maildir.py:
4532 * buildbot/test/test_mailparse.py:
4533 * buildbot/test/test_run.py:
4534 * buildbot/test/test_slavecommand.py:
4535 * buildbot/test/test_status.py:
4536 * buildbot/test/test_steps.py:
4537 * buildbot/test/test_twisted.py:
4538 * buildbot/test/test_util.py:
4539 * buildbot/test/test_vc.py:
4540 * buildbot/test/test_web.py:
4542 add test-case-name at the top of a whole set of files
4544 * buildbot/status/builder.py:
4545 keep order of addition when getting builder names
4546 * buildbot/status/words.py:
4547 * buildbot/test/test_run.py:
4548 add test for getBuilderNames
4550 * buildbot/process/base.py:
4551 * buildbot/process/step.py:
4552 * buildbot/status/builder.py:
4553 * buildbot/status/html.py:
4554 make buildbot css-able
4555 replace the color code for purple with purple, don't understand
4556 why it wasn't purple to start with
4558 * buildbot/status/words.py:
4559 ok, so it doesn't look like BuilderStatus.remote is still valid.
4560 Use what waterfall uses instead.
4562 * buildbot/interfaces.py:
4563 * buildbot/status/builder.py:
4564 * buildbot/status/html.py:
4565 * buildbot/status/mail.py:
4566 * buildbot/status/words.py:
4567 * buildbot/test/test_run.py:
4568 use categories everywhere and make it be a list. More sensible
4569 for the future. Also make words actually respect this in
4572 * buildbot/interfaces.py:
4573 add category argument to getBuilderNames
4574 * buildbot/process/builder.py:
4575 * buildbot/status/builder.py:
4576 * buildbot/status/html.py:
4577 * buildbot/status/mail.py:
4578 * buildbot/status/words.py:
4579 * buildbot/test/test_run.py:
4580 move from specifying builders by name to specifying the category
4582 * buildbot/status/html.py:
4583 * buildbot/status/words.py:
4584 add "builders=" to __init__ of status clients so they can
4585 limit themselves to the given list of builders to report on
4587 * buildbot/status/html.py: set the title to the product name
4589 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4591 * buildbot/interfaces.py:
4592 * buildbot/status/builder.py:
4593 more documentation. Hm, not sure if ChangeLog entries make sense
4596 2005-04-23 Brian Warner <warner@lothar.com>
4598 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4600 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4602 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4603 the sub-commands that log buildmaster status to stdout and to a
4604 GUI window, respectively.
4606 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4607 functionality is working again, but all the step-status and ETA
4608 stuff is missing. Commented out a lot of code pending more
4611 * buildbot/status/client.py: make sure that IRemote(None) is None
4613 * buildbot/changes/changes.py: import defer, oops
4614 (ChangeMaster): remove the .sources list, rely upon the fact that
4615 MultiServices can be treated as sequences of their children. This
4616 cleans up the add/remove ChangeSource routines a lot, as we keep
4617 exactly one list of the current sources instead of three.
4619 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4620 up an empty ChangeMaster at init time.
4621 (BuildMaster.loadChanges): if there are changes to be had from
4622 disk, replace self.change_svc with the new ones. If not, keep
4623 using the empty ChangeMaster set up in __init__.
4624 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4625 instead of a separate list, makes the code a bit cleaner.
4626 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4627 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4628 Extend the test to make sure we can get rid of the sources when
4631 2005-04-22 Brian Warner <warner@lothar.com>
4633 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4634 and info/host files when making the slave directory
4636 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4637 whendone= argument, just return the Deferred and let the caller do
4638 what they want with it.
4639 (Disconnect.testBuild1): wait for shutdownSlave
4640 (Basedir.testChangeBuilddir): new test to make sure changes to the
4641 builddir actually get propagated to the slave
4643 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4644 explicit method, rather than passing the builddir in __init__ .
4645 Make sure to update self.basedir too, this was broken before.
4646 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4647 builders and for ones that have just had their builddir changed.
4648 (BotFactory): add a class-level .perspective attribute, so
4649 BuildSlave.waitUntilDisconnected won't get upset when the
4650 connection hasn't yet been established
4651 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4652 tests can reach through it to inspect the SlaveBuilders
4654 * buildbot/process/base.py (Build.buildException): explain the
4655 log.err with a log.msg
4656 * buildbot/process/builder.py (Builder.startBuild): same
4657 (Builder._startBuildFailed): improve error message
4659 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4660 occurred because we lost the brand-new connection, retry instead
4661 of giving up. If not, it's probably an authorization failure, and
4662 it makes sense to stop trying. Make sure we log.msg the reason
4663 that we're log.err'ing the failure, otherwise test failures are
4664 really hard to figure out.
4666 * buildbot/master.py: change loadConfig() to return a Deferred
4667 that doesn't fire until the change has been fully implemented.
4668 This means any connected slaves have been updated with the new
4669 builddir. This change makes it easier to test the code which
4670 actually implements this builddir-updating.
4671 (BotPerspective.addBuilder): return Deferred
4672 (BotPerspective.removeBuilder): same
4673 (BotPerspective.attached): same
4674 (BotPerspective._attached): same. finish with remote_print before
4675 starting the getSlaveInfo, instead of doing them in parallel
4676 (BotPerspective.list_done): same
4677 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4678 actually calling slave.disconnect()
4679 (BotMaster.addBuilder): same
4680 (BotMaster.removeBuilder): same
4681 (BuildMaster.loadConfig): same
4682 (BuildMaster.loadConfig_Slaves): same
4683 (BuildMaster.loadConfig_Sources): same
4684 (BuildMaster.loadConfig_Builders): same
4685 (BuildMaster.loadConfig_status): same
4687 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4688 a Deferred that fires when the source is finally removed
4690 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4691 the previous tree on win32, where we have to do it synchronously,
4692 make sure we return a Deferred anyway.
4693 (SourceBase.doCopy): same
4695 * buildbot/scripts/runner.py (statusgui): use the text client for
4696 now, while I rewrite the Gtk one
4697 * buildbot/clients/base.py: strip out old code, leaving just the
4698 basic print-message-on-event functionality. I also remove the
4699 ReconnectingPBClientFactory, but it does at least quit when it
4700 loses the connection instead of going silent
4702 2005-04-21 Brian Warner <warner@lothar.com>
4704 * Makefile: minor tweaks
4706 * NEWS: point out deprecation warnings, new features for
4709 * buildbot/master.py (BuildMaster.loadConfig): emit
4710 DeprecationWarnings for Builders defined with tuples. Rearrange
4711 code to facility removal of deprecated configuration keys in the
4714 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4715 'buildbot' command to put a little Makefile in the target that
4716 helps you re-create the buildbot.tap file, start or stop the
4717 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4718 all the files 0600, since they contain passwords.
4719 (start): if there is a Makefile, and /usr/bin/make exists, use
4720 'make start' in preference to a raw twistd command. This lets
4721 slave admins put things like PYTHONPATH variables in their
4722 Makefiles and have them still work when the slave is started with
4723 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4724 be nice to first try the 'make' command and only fall back to
4725 twistd if it fails. TODO: the Makefile's "start" command does not
4726 add the --reactor=win32 argument when running under windows.
4727 (Options.debugclient, Options.statusgui): add sub-commands to launch
4728 the debug client (formerly in contrib/debugclient.py) and the
4729 Gtk status application (currently broken)
4730 * buildbot/clients/debug.py: move from contrib/debugclient.py
4731 * buildbot/clients/debug.glade: same
4733 * buildbot/test/test_trial.py: remove it. This requires some
4734 functionality out of Twisted that isn't there yet, and until then
4735 having it around just confuses things.
4737 * buildbot/test/test_slavecommand.py (Shell): test both with and
4738 without PTYs, and make sure that command output is properly
4739 interleaved in the with-PTY case. I think the without-PTY test
4740 should pass on windows, where we never use PTYs anyway.
4742 2005-04-20 Brian Warner <warner@lothar.com>
4744 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4746 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4748 * NEWS: start creating entries for the next release
4750 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4752 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4753 (WebTest.test_webPathname): same
4754 (WebTest.test_webPathname_port): same
4755 (WebTest.test_waterfall): use the default favicon rather than
4756 rooting around the filesystem for it. Open the expected-icon file
4757 in binary mode, to make win32 tests happier (thanks to Nick Trout
4759 * buildbot/status/html.py (buildbot_icon): win32 portability
4761 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4762 win32-compatibility fixes from Nick Trout, the "file not found" message
4763 is different under windows
4764 (FakeSlaveBuilder.__init__): clean up setup a bit
4765 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4767 2005-04-19 Brian Warner <warner@lothar.com>
4769 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4770 skip-if-repositories-are-unavailable test to not kill the trial
4771 that comes with Twisted-1.3.0
4773 * setup.py: install buildbot.png icon file when installing code
4775 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4776 environment used by the command, at least on the child side.
4778 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4779 this method needs to be added and implemented because it gets
4780 called under heavy load. I don't quite understand the
4781 producer/consumer API enough to write it.
4782 (StatusResource.getChild): add a resource for /favicon.ico
4783 (Waterfall.__init__): add favicon= argument
4784 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4785 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4786 (WebTest.test_webPathname): same
4787 (WebTest.test_webPathname_port): same
4788 * docs/config.xhtml: mention favicon=
4789 * buildbot/buildbot.png: add a default icon, dorky as it is
4791 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4793 * buildbot/master.py:
4794 * buildbot/process/base.py:
4795 * buildbot/process/builder.py:
4796 * buildbot/process/interlock.py:
4797 * buildbot/status/builder.py:
4798 * buildbot/status/html.py:
4799 * buildbot/status/mail.py:
4800 * buildbot/status/words.py:
4801 new documentation while digging through the code
4803 2005-04-17 Brian Warner <warner@lothar.com>
4805 * general: try to fix file modes on all .py files: a+r, a-x,
4806 but let buildbot/clients/*.py be +x since they're tools
4808 * docs/epyrun (addMod): when an import fails, say why
4810 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4812 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4814 * buildbot/process/base.py:
4815 * buildbot/process/builder.py:
4816 * buildbot/status/builder.py:
4817 new documentation while digging through the code
4819 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4821 * buildbot/changes/changes.py:
4822 * buildbot/changes/p4poller.py:
4823 * buildbot/interfaces.py:
4824 * buildbot/process/base.py:
4825 * buildbot/process/builder.py:
4826 * buildbot/process/step.py:
4827 * buildbot/process/step_twisted.py:
4828 * buildbot/slave/bot.py:
4829 * buildbot/slave/commands.py:
4830 * buildbot/status/builder.py:
4831 fix all docstrings to make epydoc happy. In the process of fixing
4832 some, I also moved pieces of docs, and removed some deprecated
4835 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4837 * buildbot/process/builder.py:
4838 * buildbot/process/interlock.py:
4839 * buildbot/process/process_twisted.py:
4840 * buildbot/process/step.py:
4841 BuildProcess -> Build, as it looks like that's what happened
4842 * buildbot/process/base.py:
4843 * buildbot/process/factory.py:
4846 2005-04-17 Brian Warner <warner@lothar.com>
4848 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4849 update compile command to accomodate the Twisted split.. now
4850 instead of './setup.py build_ext -i', you do './setup.py all
4851 build_ext -i', to run build_ext over all sub-projects.
4852 (FullTwistedBuildFactory): same
4853 (TwistedReactorsBuildFactory): same
4855 * buildbot/status/html.py (TextLog.finished): null out self.req
4856 when we're done, otherwise the reference cycle of TextLog to .req
4857 to .notifications to a Deferred to TextLog.stop keeps them from
4858 being collected, and consumes a huge (610MB on pyramid at last
4859 check) amount of memory.
4861 2005-04-11 Brian Warner <warner@lothar.com>
4863 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4864 normalize the VC-repository location.. makes SVN happier with
4865 certain test environments.
4867 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4868 RemoteShellCommand gets its own .env dictionary, so that code in
4869 start() doesn't mutate the original. I think this should fix the
4870 step_twisted.Trial problem where multiple identical components
4871 kept getting added to PYTHONPATH= over and over again.
4873 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4874 adding epydoc-format docstrings to many classes. Thanks to Thomas
4875 Vander Stichele for the patches.
4876 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4877 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4878 * buildbot/slave/bot.py, commands.py, registry.py: same
4880 2005-04-05 Brian Warner <warner@lothar.com>
4882 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4883 preserve timestamps, helps incremental builds of large trees.
4884 Patch from Rene Rivera.
4886 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4887 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4890 2005-04-03 Brian Warner <warner@lothar.com>
4892 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4893 with one dict, apparently exec has some scoping bugs when used
4894 with both global/local dicts. Thanks to Nathaniel Smith for the
4897 2005-04-02 Brian Warner <warner@lothar.com>
4899 * buildbot/process/step_twisted.py (countFailedTests): the new
4900 trial in Twisted-2.0 emits a slightly different status line than
4901 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4902 mistakenly think the test count is unparseable.
4903 (Trial.start): note that for some reason each build causes another
4904 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4905 be fixed but I'm not sure quite where the problem is.
4907 2005-04-01 Brian Warner <warner@lothar.com>
4909 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4910 deferredResult to avoid hangs/warnings under twisted-2.0
4911 (RunMixin.tearDown): same
4912 (RunMixin.shutdownSlave): same
4913 (Disconnect.testIdle1): same
4914 (Disconnect.testBuild2): same: wait one second after the build
4915 finishes for test to really be done.. this should be cleaned up to
4916 avoid wasting that second. Builder.detach uses a callLater(0),
4917 either that should be done in-line (something else needed that
4918 behavior), or it should return a Deferred that fires when the
4919 builder is really offline.
4920 (Disconnect.testBuild3): same
4921 (Disconnect.testDisappear): same
4923 * buildbot/test/test_web.py: rearrange server-setup and teardown
4924 code to remove unclean-reactor warnings from twisted-2.0
4926 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4927 so the tests don't hang under twisted-2.0
4929 2005-03-31 Brian Warner <warner@lothar.com>
4931 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4932 caused a warning each time the master changed our set of builders
4934 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4935 w32, don't unlink the file unless it already exists. Thanks to
4936 Baptiste Lepilleur for the catch.
4937 (BuilderStatus.saveYourself): same
4939 2005-02-01 Brian Warner <warner@lothar.com>
4941 * buildbot/status/html.py (TextLog.getChild): use a /text child
4942 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4943 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4944 logfile as text/plain (no markup, no headers). This replaces the
4945 previous scheme (which used an ?text=1 argument), and gets us back
4946 to a relative link (which works better when the buildbot lives
4947 behind another web server, such as Apache configured as a reverse
4948 proxy). Thanks to Gerald Combs for spotting the problem.
4950 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4953 2004-12-13 Brian Warner <warner@lothar.com>
4955 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4957 * debian/changelog: update for 0.6.2
4958 * NEWS: finalize for 0.6.2
4960 2004-12-11 Brian Warner <warner@lothar.com>
4962 * NEWS: bring it up to date
4964 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4965 detection code. Require some sign of life from the buildmaster
4966 every BotFactory.keepaliveInterval seconds. Provoke this
4967 indication at BotFactory.keepaliveTimeout seconds before the
4968 deadline by sending a keepalive request. We don't actually care if
4969 that request is answered in a timely fashion, what we care about
4970 is that .activity() is called before the deadline. .activity() is
4971 triggered by any PB message from the master (including an ack to
4972 one of the slave's status-update messages). With this new scheme,
4973 large status messages over slow pipes are OK, as long as any given
4974 message can be sent (and thus acked) within .keepaliveTimeout
4975 seconds (which defaults to 30).
4976 (SlaveBuilder.remote_startCommand): record activity
4977 (SlaveBuilder.ackUpdate): same
4978 (SlaveBuilder.ackComplete): same
4979 (BotFactory.gotPerspective): same
4980 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4982 2004-12-09 Brian Warner <warner@lothar.com>
4984 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4987 * buildbot/process/step_twisted.py (Trial._commandComplete):
4988 update self.cmd when we start the 'cat test.log' transfer. Without
4989 this, we cannot interrupt the correct RemoteCommand when we lose
4992 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4993 trying to tell the slave to stop the command if we're already
4994 inactive, or if we no longer have a .remote
4996 * buildbot/process/builder.py (Builder._detached): don't let an
4997 exception in currentBuild.stopBuild() prevent the builder from
4998 being marked offline
5000 2004-12-07 Brian Warner <warner@lothar.com>
5002 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5003 KeyError that happens when you ask for a non-existent Builder, and
5004 translate it into a UsageError.
5006 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5007 losing the slave in the middle of a remote step is handled too
5009 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5010 be a Failure, so be sure to stringify it before using it as the
5011 contents of the 'interrupt' logfile
5012 (RemoteCommand.interrupt): use stringified 'why' in
5013 remote_interruptCommand too, just in case
5015 2004-12-06 Brian Warner <warner@lothar.com>
5017 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5018 instead of 'tla update', which is more efficient in case we've
5019 missed a couple of patches since the last update.
5021 * debian/changelog: update for previous (0.6.1) release. Obviously
5022 this needs to be handled better.
5024 2004-12-05 Brian Warner <warner@lothar.com>
5026 * NEWS: update for stuff since last release
5028 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5029 match the maybeDeferred change in Dispatcher.requestAvatar
5030 * buildbot/changes/pb.py (ChangePerspective.attached): same
5031 * buildbot/status/client.py (StatusClientPerspective.attached): same
5032 * buildbot/process/builder.py (Builder._attached3): same
5033 * buildbot/pbutil.py (NewCredPerspective.attached): same
5035 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5036 the date to the top-most box, if it is not the same as today's
5039 * docs/slave.xhtml: provide a buildslave setup checklist
5041 * docs/source.xhtml (Arch): correct terminology
5043 2004-12-04 Brian Warner <warner@lothar.com>
5045 * buildbot/test/test_slavecommand.py: use sys.executable instead
5046 of hard-coding 'python' for child commands, might help portability
5048 * docs/examples/twisted_master.cfg: update to current usage
5050 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5051 'stop build' command to the IRC bot
5053 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5054 message that broke PBChangeSource
5056 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5057 (SlaveBuilder): make some attributes class-level, remove the old
5058 "update queue" which existed to support resuming a build after the
5059 master connection was lost. Try to reimplement that feature later.
5060 (SlaveBuilder.stopCommand): clear self.command when the
5061 SlaveCommand finishes, so that we don't try to kill a leftover one
5063 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5066 * buildbot/slave/commands.py (SourceBase): set self.command for
5067 all VC commands, so they can be interrupted.
5069 2004-12-03 Brian Warner <warner@lothar.com>
5071 * buildbot/master.py: clean up slave-handling code, to handle
5072 slave-disconnect and multiple-connect better
5073 (BotPerspective): make these long-lasting, exactly one per bot
5074 listed in the config file.
5075 (BotPerspective.attached): if a slave connects while an existing
5076 one appears to still be connected, disconnect the old one first.
5077 (BotPerspective.disconnect): new method to forcibly disconnect a
5078 buildslave. Use some hacks to empty the transmit buffer quickly to
5079 avoid the long (20-min?) TCP timeout that could occur if the old
5080 slave has dropped off the net.
5081 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5082 own their own SlaveStatus objects. Remove .attached/.detached, add
5083 .addSlave/.removeSlave, treat slaves like Builders (config file
5084 parsing sends deltas to the BotMaster). Inform the slave
5085 instances, i.e. the BotPerspective, about addBuilder and
5087 (BotMaster.getPerspective): turns into a single dict lookup
5088 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5089 which gives BotPerspective.attached a chance to disconnect the old
5091 (BuildMaster.loadConfig): add code (disabled) to validate that all
5092 builders use known slaves (listed in c['bots']). The check won't
5093 work with tuple-specified builders, which are deprecated but not
5094 yet invalid, so the check is disabled for now.
5095 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5096 routine, do the add/changed/removed dance with them like we do
5098 (BuildMaster.loadConfig_Sources): move source-config into a
5099 separate routine too
5101 * buildbot/status/builder.py (Status.getSlave): get the
5102 SlaveStatus object from the BotPerspective, not the BotMaster.
5104 * buildbot/test/test_run.py: bunch of new tests for losing the
5105 buildslave at various points in the build, handling a slave that
5106 connects multiple times, and making sure we can interrupt a
5109 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5110 something other than 'Bot' for the Bot object, to make certain
5111 test cases easier to write.
5112 (BuildSlave.waitUntilDisconnected): utility method for testing
5114 2004-11-30 Brian Warner <warner@lothar.com>
5116 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5118 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5119 argument, return a Deferred that always fires with True or False.
5120 I don't use an errback to indicate 'ping failed' so that callers
5121 are free to ignore the deferred without causing spurious errors in
5123 * buildbot/process/builder.py (BuilderControl.ping): implement it
5125 * buildbot/test/test_run.py (Status.testDisappear): test ping
5126 (Status.disappearSlave): fix it
5128 2004-11-30 Brian Warner <warner@lothar.com>
5130 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5131 (IBuilderControl): add .getBuild(num), only works for the current
5132 build, of course, although it might be interesting to offer
5133 something for builds in the .waiting or .interlocked state.
5135 * buildbot/process/base.py (Build): have .stopBuild just do the
5136 interrupt, then let the build die by itself.
5137 (BuildControl): add .stopBuild, and add a point-event named
5138 'interrupt' just after the build so status viewers can tell that
5140 (BuilderControl): add .getBuild
5142 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5143 stops when you kill it, good for testing
5144 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5145 contains the 'reason' text.
5147 * buildbot/status/html.py: Add Stop Build button, if the build can
5148 still be stopped. Send a Redirect (to the top page) one second
5149 later, hopefully long enough for the interrupt to have an effect.
5150 Move make_row() up to top-level to share it between Stop Build and
5153 * buildbot/slave/commands.py: only kill the child process once
5155 * buildbot/test/test_run.py: add testInterrupt
5157 2004-11-29 Brian Warner <warner@lothar.com>
5159 * buildbot/process/base.py: Refactor command interruption. The
5160 Build is now responsible for noticing that the slave has gone
5161 away: Build.lostRemote() interrupts the current step and makes
5162 sure that no further ones will be started.
5164 * buildbot/process/builder.py: When the initial remote_startBuild
5165 message fails, log it: this usually indicates that the slave has
5166 gone away, but we don't really start paying attention until they
5167 fail to respond to the first step's command.
5169 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5170 slave disconnect. Now sports a new interrupt() method. Error
5171 handling was simplified a lot by chaining deferreds, so
5172 remoteFailed/remoteComplete were merged into a single
5173 remoteComplete method (which can now get a Failure object).
5174 Likewise failed/finished were merged into just _finished.
5175 (BuildStep): Add interrupt(why) method, and if why is a
5176 ConnectionLost Failure then the step is failed with some useful
5179 * buildbot/slave/bot.py: stop the current command when the remote
5180 Step reference is lost, and when the slave is shut down.
5181 (Bot): make it a MultiService, so it can have children. Use
5182 stopService to tell when the slave is shutting down.
5183 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5184 remote_interruptCommand (which asks the current SlaveCommand to
5185 stop but allows it to keep emitting status messages), and
5186 stopCommand (which tells it to shut up and die).
5188 * buildbot/slave/commands.py: make commands interruptible
5189 (ShellCommand.kill): factor out os.kill logic
5190 (Command): factor out setup()
5191 (Command.sendStatus): don't send status if .running is false, this
5192 happens when the command has been halted.
5193 (Command.interrupt): new method, used to tell the command to die
5194 (SlaveShellCommand): implement .interrupt
5195 (DummyCommand): implement .interrupt
5196 (SourceBase, etc): factor out setup(), don't continue substeps if
5199 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5200 so they can be called after finishing
5202 * buildbot/test/test_run.py: new tests for disconnect behavior,
5203 refactor slave-shutdown routines, add different kinds of
5206 2004-11-27 Brian Warner <warner@lothar.com>
5208 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5209 method to express ETA time like "2m45s" instead of "165 seconds"
5211 2004-11-24 Brian Warner <warner@lothar.com>
5213 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5214 archive after the test completes, to avoid cluttering the user's
5215 'tla archives' listing with a bogus entry. Arch doesn't happen to
5216 provide any way to override the use of ~/.arch-params/, so there
5217 isn't a convenient way to avoid touching the setup of the user who
5219 (VC_HTTP.testArchHTTP): same
5221 2004-11-23 Brian Warner <warner@lothar.com>
5223 * buildbot/status/html.py (TextLog): split render() up into
5224 render_HEAD and render_GET. Use a Producer when sending log
5225 chunks, to reduce memory requirements and avoid sending huge
5226 non-Banana-able strings over web.distrib connections. Requires
5227 peeking under the covers of IStatusLog.
5228 (TextLog.resumeProducing): fix the "as text" link, handle client
5229 disconnects that occur while we're still sending old chunks.
5231 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5232 use defer.succeed, not the non-existent defer.success
5233 (LogFile.waitUntilFinished): same
5234 (LogFile.subscribe): don't add watchers to a finished logfile
5236 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5239 2004-11-23 Brian Warner <warner@lothar.com>
5241 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5243 2004-11-23 Brian Warner <warner@lothar.com>
5245 * NEWS: update for the 0.6.1 release
5246 * MANIFEST.in: add new files
5248 * README (INSTALLATION): explain how to enable the extra VC tests
5250 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5251 level to, so old pickled builds can be displayed ok
5253 2004-11-22 Brian Warner <warner@lothar.com>
5255 * NEWS: summarize updates since last release
5257 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5258 Yoz Grahame. Closes SF#1050138.
5260 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5263 * buildbot/process/step_twisted.py (Trial): update docs a bit
5265 * docs/factories.xhtml: fix Trial factory docs to match reality.
5268 * buildbot/process/factory.py (Trial.__init__): add args for
5269 randomly= and recurse=, making them available to instantiators
5270 instead of only to subclassers. Closes: SF#1049759.
5272 2004-11-15 Brian Warner <warner@lothar.com>
5274 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5275 try to teach the Quick factory to use multiple versions of python
5277 2004-11-12 Brian Warner <warner@lothar.com>
5279 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5280 safer w32-compatible approach, and only use it on windows
5281 (BuildStatus.saveYourself): same
5283 2004-11-11 Brian Warner <warner@lothar.com>
5285 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5286 it: one string merge per chunk. There are now separate .entries
5287 and .runEntries lists: when enumerating over all chunks, make sure
5289 * buildbot/test/test_status.py (Log): more tests
5291 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5292 chunks together, up to 10kb per chunk. This ought to cut down on
5293 the CPU-burning overhead of large log files. Thanks to Alexander
5294 Staubo for spotting the problem.
5295 * buildbot/test/test_status.py (Log): tests for same
5297 2004-11-10 Brian Warner <warner@lothar.com>
5299 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5300 header to outbound mail
5301 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5303 2004-11-08 Brian Warner <warner@lothar.com>
5305 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5306 can't do os.rename() onto an existing file, so catch the exception
5307 and unlink the target file first. This introduces a slight window
5308 where the existing file could be lost, but the main failure case
5309 (disk full) should still be handled safely.
5310 (BuildStatus.saveYourself): same
5312 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5313 separator character instead of os.sep, because the filenames being
5314 split here are coming from the VC system, which can have a
5315 different pathname convention than the local host. This should
5316 help a buildmaster running on windows that uses a CVS repository
5317 which runs under unix.
5318 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5320 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5321 when there are no test failures to be parsed
5323 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5324 instead of the unix-specific os.system("cp"), thanks to Elliot
5325 Murphy for this and the other buildbot-vs-windows catches.
5326 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5328 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5329 echo the command as it is run
5331 * setup.py: install sample.mk too, not just sample.cfg
5332 (scripts): install contrib/windows/buildbot.bat on windows
5334 2004-11-07 Brian Warner <warner@lothar.com>
5336 * buildbot/process/builder.py (Builder._detached): clear the
5337 self.currentBuild reference, otherwise the next build will be
5338 skipped because we think the Builder is already in use.
5340 * docs/examples/twisted_master.cfg: update to match current usage
5341 on the Twisted buildbot
5343 2004-10-29 Brian Warner <warner@lothar.com>
5345 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5347 2004-10-28 Brian Warner <warner@lothar.com>
5349 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5350 have separate doVCUpdate/doVCFull methods. Catch an update failure
5351 and respond by clobbering the source directory and re-trying. This
5352 will handle local changes (like replacing a file with a directory)
5353 that will cause CVS and SVN updates to fail.
5354 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5356 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5359 2004-10-19 Brian Warner <warner@lothar.com>
5361 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5363 * buildbot/status/html.py (StatusResourceTestResults): display any
5364 TestResults that the Build might have
5365 (StatusResourceTestResult): and the logs for each TestResult
5366 (StatusResourceBuild): add link from the per-build page
5368 2004-10-15 Brian Warner <warner@lothar.com>
5370 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5371 the 'problems' portion of stdout, add TestResults to our build
5372 * buildbot/test/test_twisted.py (Parse.testParse): test it
5374 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5375 to retrieve a dict of accumulated test results
5376 (ITestResult): define what a single test result can do
5377 * buildbot/status/builder.py (TestResult): implement ITestResult
5378 (BuildStatus.getTestResults): retrieve dict of TestResults
5379 (BuildStatus.addTestResult): add TestResults
5380 * buildbot/test/test_status.py (Results.testAddResults): test it
5382 2004-10-14 Brian Warner <warner@lothar.com>
5384 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5385 instead of os.system("rm -rf") for win32 portability
5387 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5388 SignalMixin instead of starting/stopping the reactor, which is
5389 likely to cause problems with other tests
5391 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5392 self.copyComplete() call. Yoz Grahame makes the catch.
5394 * contrib/windows/buildbot.bat: helper script to deal with path
5395 issues. Thanks to Yoz Grahame.
5397 * buildbot/master.py (BuildMaster.startService): don't register a
5398 SIGHUP handler if the signal module has no SIGHUP attribute.
5399 Apparently win32 does this.
5401 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5403 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5404 test if the reactor can't offer UNIX sockets
5406 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5407 error introduced in the last commit. We really need that
5410 2004-10-12 Brian Warner <warner@lothar.com>
5412 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5413 when describing a maildir source. Thanks to Stephen Davis.
5415 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5418 * buildbot/scripts/runner.py (createMaster): install Makefile too
5419 (start): add --no_save to 'start' command
5420 * buildbot/scripts/sample.mk: simple convenience Makefile with
5421 start/stop/reload targets
5423 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5426 2004-09-30 Brian Warner <warner@lothar.com>
5428 * setup.py: Releasing buildbot-0.6.0
5430 2004-09-30 Brian Warner <warner@lothar.com>
5432 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5433 test_trial.py from the source tarball until support is complete.
5435 * NEWS: update for 0.6.0 release
5436 * buildbot/__init__.py (version): same
5439 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5440 'source' command to tell users where to get the Buildbot source
5442 * docs/examples/*.cfg: update to modern standards
5444 * NEWS: update for release
5446 * buildbot/scripts/runner.py (createMaster): remove the
5447 -shutdown.tap stuff now that it isn't necessary
5449 (start): launch buildbot.tap, not buildbot-shutdown.tap
5452 * buildbot/status/mail.py (Domain): shorten class name
5453 (MailNotifier): if lookup= is a string, pass it to Domain()
5454 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5455 (Mail.testBuild2): test the string-to-Domain shortcut
5456 (Mail.testMail): fix test
5459 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5462 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5463 more attributes on load
5464 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5465 to accomodate the whole waterfall page at once, and the thrashing
5466 results in a lot of unnecessary loads
5467 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5468 (BuilderStatus.saveYourself): same
5469 (BuilderStatus.eventGenerator): stop generating on the first missing
5470 build. We assume that saved builds are deleted oldest-first.
5471 (BuildStepStatus.__getstate__): .progress might not exist
5473 * buildbot/changes/changes.py (ChangeMaster): make it
5474 serializable, in $masterdir/changes.pck
5475 (ChangeMaster.stopService): save on shutdown
5476 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5477 * buildbot/test/test_config.py: load Changes before config file
5480 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5481 "Oh my god, you killed the command" header on a separate line
5483 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5484 skip over corrupted build pickles
5485 (BuilderStatus.getFullBuildByNumber): same
5486 (BuilderStatus.eventGenerator): skip over unavailable builds
5487 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5488 do an atomic rename. This prevents a corrupted pickle when some
5489 internal serialization error occurs.
5490 (BuilderStatus.saveYourself): same
5492 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5493 the timeout for shell commands, it got lost somehow
5495 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5496 run out of build steps, return the rest of the builder events
5498 * buildbot/interfaces.py (IBuilderControl.ping): add method
5500 * buildbot/process/builder.py (BuilderControl.ping): move
5501 slave-ping to BuilderControl, and fix the failure case in the
5502 process (Event.finish() is the verb, Event.finished is the noun).
5504 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5505 through the BuilderControl instead of the BuilderStatus
5506 (EventBox): add adapter for builder.Event, allowing builder events to
5507 be displayed in the waterfall display
5509 * buildbot/master.py (BotMaster.stopService): add a 'master
5510 shutdown' event to the builder's log
5511 (BuildMaster.startService): and a 'master started' on startup
5513 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5514 builder events into the BuildStep event stream
5515 (Status.builderAdded): add a 'builder created' event
5518 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5519 command to announce the completion of a running build
5520 (IrcStatusBot.command_FORCE): announce when the build finishes
5522 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5523 don't evict unfinished builds from the cache: they must stay in
5524 the full-cache until their logfiles have stopped changing. Make
5525 sure the eviction loop terminates if an unfinished build was hit.
5526 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5527 This lets exceptions be dumped in an email status message. Really
5528 we need LogFiles which contain both text and HTML, instead of two
5530 (BuildStatus.__getstate__): handle self.finished=False
5531 (Status.builderAdded): if the pickle is corrupted, abandon the
5532 history and create a new BuilderStatus object.
5534 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5535 self.progress attribute, helped one test which doesn't fully set
5536 up the Build object.
5538 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5539 IStatusLog methods into an Interface that is implemented by "stub"
5540 logs, for which all the actual text chunks are on disk (in the
5541 pickled Build instance). To show the log contents, you must first
5542 adapt the stub log to a full IStatusLog object.
5544 * buildbot/status/builder.py (LogFileStub): create separate stub
5545 log objects, which can be upgraded to a real one if necessary.
5546 (LogFile): make them persistable, and let them stubify themselves
5548 (BuildStepStatus): same
5550 (BuildStatus.saveYourself): save the whole build out to disk
5551 (BuilderStatus): make it persistable
5552 (BuilderStatus.saveYourself): save the builder to disk
5553 (BuilderStatus.addFullBuildToCache): implement two caches which
5554 hold Build objects: a small one which holds full Builds, and a
5555 larger one which holds "stubbed" Builds (ones with their LogFiles
5556 turned into LogFileStubs). This reduces memory usage by the
5557 buildmaster by not keeping more than a few (default is 2) whole
5558 build logs in RAM all the time.
5559 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5561 (BuilderStatus.eventGenerator): rewrite since .builds went away
5562 (BuilderStatus.buildStarted): remove the .builds array. Add the
5563 build to the "full" cache when it starts.
5564 (BuilderStatus._buildFinished): save the build to disk when it
5566 (Status): give it a basedir (same as the BuildMaster's basedir)
5567 where the builder pickles can be saved
5568 (Status.builderAdded): create the BuilderStatus ourselves, by
5569 loading a pickle from disk (or creating a new instance if there
5570 was none on disk). Return the BuilderStatus so the master can glue
5571 it into the new Builder object.
5573 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5574 all BuilderStatuses to save themselves out to disk. This is in
5575 lieu of saving anything important in the main Application pickle
5576 (the -shutdown.tap file).
5577 (BuildMaster.__init__): give Status() a basedir for its files
5578 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5579 to get the BuilderStatus, then give it to the Builder (instead of
5580 doing it the other way around). It's ok if the status announces
5581 the new Builder before it's really ready, as the outside world can
5582 only see the BuilderStatus object anyway (and it is ready before
5583 builderAdded returns). Use the builder's "builddir" (which
5584 normally specifies where the slave will run the builder) as the
5585 master's basedir (for saving serialized builds).
5587 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5588 coerce the logfile to IStatusLog before trying to get the text
5589 chunks out of it. This will pull the full (non-stubified) Build in
5590 from disk if necessary.
5591 (TextLog): fix the adapter registration
5593 * buildbot/test/test_control.py (Force.setUp): create the basedir
5594 * buildbot/test/test_web.py: same
5595 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5596 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5597 * buildbot/test/test_run.py (Run.testMaster): same
5598 (Status.setUp): same
5600 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5602 * buildbot/status/html.py (Waterfall.__init__): store actual
5603 allowForce flag passed in rather than using True for everyone;
5604 make sure setting it to False doesn't cause a NameError
5606 (StatusResourceBuilder.__init__) add the builder name to the page
5608 (StatusResourceBuilder.body) move HTML generation for a name/value
5609 row into a helper method (StatusResourceBuilder.make_row); only
5610 generate the "Force Build" form if allowForce was True and the
5611 slave is connected. Use class attributes in the generated HTML to
5612 spread a little CSS-joy.
5614 2004-09-28 Brian Warner <warner@lothar.com>
5616 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5617 warning-scanner to not ignore things like
5618 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5620 * buildbot/status/html.py (StatusResource.control): add some
5621 class-level values for .control in an attempt to make upgrading
5624 * buildbot/util.py (ComparableMixin): survive missing attributes,
5625 such as when a class is modified and we're comparing old instances
5628 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5629 failure handling, remove a redundant try/except block. Don't
5630 return the full traceback to the IRC channel.
5631 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5632 error messages. Get ETA properly.
5634 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5635 the reason, since (at least) IRC message will have <> in them.
5636 (StatusResourceBuilder.__init__): take an IBuilderControl
5637 (StatusResourceBuilder.force): use the IBuilderControl we get in
5638 the constructor instead of trying to make our own. Catch the
5639 new exceptions and ignore them for now (until we make an
5640 intermediate web page where we could show the error message)
5641 (StatusResource): create with an IControl, use it to give an
5642 IBuilderControl to all children
5643 (Waterfall): take an allowForce= option, pass an IControl object
5644 to StatusResource if it is True
5646 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5648 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5649 catch new exceptions and return string forms
5651 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5652 * buildbot/process/builder.py (Builder.forceBuild): raise them
5653 * buildbot/test/test_control.py (Force.testNoSlave): new test
5654 (Force.testBuilderInUse): same
5657 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5659 * buildbot/test/test_run.py: use IControl
5660 * buildbot/test/test_vc.py: same
5662 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5663 to use IControl. Still offline.
5664 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5666 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5667 who=None so periodic builds don't send out status mail
5668 (Builder.forceBuild): include reason in the log message
5669 (BuilderControl.forceBuild): rename 'name' to 'who'
5671 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5672 'who' parameter, but make it None by default so builds forced by
5673 slave admins don't cause status mail to be sent to anybody
5674 (BotMaster.forceBuild): same. this method is deprecated.
5675 (DebugPerspective.perspective_forceBuild): same, use IControl.
5676 (DebugPerspective.perspective_fakeChange): use IControl..
5677 (Dispatcher.requestAvatar): .. so don't set .changemaster
5679 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5680 parameter to avoid confusion with the name of the builder
5683 * buildbot/status/mail.py: refine comment about needing 2.3
5685 * buildbot/status/html.py: move all imports to the top
5687 * buildbot/test/test_control.py: test new interfaces
5688 * buildbot/test/test_run.py (Status): handle new interfaces
5689 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5691 * buildbot/process/base.py (BuildControl): implement IBuildControl
5692 and its lonely getStatus() method
5694 * buildbot/process/builder.py (BuilderControl): implement
5695 IBuilderControl, obtained by adapting the Builder instance
5696 (Builder.startBuild): return a BuilderControl instead of a
5697 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5698 accomplish the same thing.
5700 * buildbot/master.py: move all import statements to the top
5701 (Control): implement IControl, obtained by adapting the
5702 BuildMaster instance.
5704 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5705 IBuildControl. These are used to force builds. Eventually they
5706 will provide ways to reconfigure the Builders, pause or abandon a
5707 Build, and perhaps control the BuildMaster itself.
5709 2004-09-26 Brian Warner <warner@lothar.com>
5711 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5712 ends up comparing us against something without a .__class__
5714 2004-09-24 Brian Warner <warner@lothar.com>
5716 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5719 * Makefile: add 'deb-snapshot' target, to create a timestamped
5722 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5724 2004-09-23 Brian Warner <warner@lothar.com>
5726 * buildbot/__init__.py (version): move version string here
5727 * setup.py: get version string from buildbot.version
5728 * buildbot/status/html.py (WaterfallStatusResource.body): add
5729 buildbot version to the page footer
5730 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5733 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5734 slaves, let the second know where the first one is coming from
5735 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5736 see our exceptions. It would be nice if there were a way to just
5737 send them the exception type and value, not the full traceback.
5740 * buildbot/status/mail.py (MailNotifier): add a new argument
5741 sendToInterestedUsers=, which can be set to False to disable the
5742 usual send-to-blamelist behavior.
5743 (top): handle python-2.2 which has no email.MIMEMultipart
5744 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5745 (MailNotifier.disownServiceParent): unsubscribe on removal
5747 * buildbot/test/test_status.py (Mail.testBuild2): test it
5750 * buildbot/status/progress.py (Expectations.wavg): tolerate
5751 current=None, which happens when steps start failing badly
5752 * buildbot/test/test_status.py (Progress.testWavg): test for it
5754 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5755 doesn't understand args['revision'], emit a warning instead of
5756 bailing completely. Updating to -rHEAD is probably close enough.
5758 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5760 * buildbot/test/test_status.py: at least import bb.status.client
5761 even if we don't have any test coverage for it yet
5763 * contrib/svn_buildbot.py: don't require python2.3
5764 (main): wait, do require it (for sets.py), but explain how to
5765 make it work under python2.2
5767 2004-09-23 Brian Warner <warner@lothar.com>
5769 * contrib/svn_buildbot.py: include the revision number in the Change
5771 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5772 using util.now() because FreshCVS is a realtime service
5774 * buildbot/status/event.py: delete dead code
5775 * buildbot/process/step.py: don't import dead Event class
5776 * buildbot/process/step_twisted.py: same
5777 * buildbot/status/builder.py: same
5778 * buildbot/status/client.py: same
5780 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5782 * buildbot/changes/changes.py (Change): set .when from an __init__
5783 argument (which defaults to now()), rather than having
5784 ChangeMaster.addChange set it later.
5785 (ChangeMaster.addChange): same
5787 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5788 (parseSyncmail): same. Just use util.now() for now.
5789 (parseBonsaiMail): parse the timestamp field for when=
5791 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5792 instead of setting .when after the fact
5796 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5797 results when the target project uses retrial. Still under
5799 * buildbot/test/test_trial.py: same
5801 2004-09-21 Brian Warner <warner@lothar.com>
5803 * buildbot/status/mail.py (MailNotifier.__init__): include
5804 success/warnings/failure in the Subject line
5805 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5806 use step.logname for the addLogs=True attachment filenames
5807 * buildbot/test/test_status.py (Mail): test Subject lines
5808 (Mail.testLogs): test attachment filenames
5810 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5811 accept a 'who' argument from the debug tool
5812 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5813 * contrib/debug.glade: add text box to set 'who'
5815 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5816 .getBuilderName with .getBuilder().getName(), more flexible
5817 (IStatusLog.getName): logs have short names, but you can prefix
5818 them with log.getStep().getName() to make them more useful
5819 * buildbot/status/builder.py: same
5820 * buildbot/status/client.py: same
5821 * buildbot/status/html.py: same
5822 * buildbot/test/test_run.py (Status.testSlave): same
5823 * buildbot/process/step.py: tweak logfile names
5825 * buildbot/status/mail.py (MailNotifier): add lookup, change
5826 argument to extraRecipients. The notifier is now aimed at sending
5827 mail to the people involved in a particular build, with additional
5828 constant recipients as a secondary function.
5830 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5831 including slow-lookup and failing-lookup. Make sure the blamelist
5832 members are included.
5834 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5835 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5836 (IBuildStatus.getInterestedUsers): new method
5837 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5838 * buildbot/status/client.py (remote_getResponsibleUsers): same
5839 * buildbot/status/html.py (StatusResourceBuild.body): same
5840 * buildbot/test/test_run.py (Status.testSlave): same
5842 2004-09-20 Brian Warner <warner@lothar.com>
5844 * docs/users.xhtml: update concepts
5846 * Makefile: add a convenience makefile, for things like 'make
5847 test'. It is not included in the source tarball.
5849 2004-09-16 Brian Warner <warner@lothar.com>
5851 * NEWS: mention /usr/bin/buildbot, debian/*
5853 * debian/*: add preliminary debian packaging. Many thanks to
5854 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5855 it considerably since it left their hands, I am responsible for
5856 all breakage that's resulted.
5858 * bin/buildbot: create a top-level 'buildbot' command, to be
5859 installed in /usr/bin/buildbot . For now it's just a simple
5860 frontend to mktap/twistd/kill, but eventually it will be the entry
5861 point to the 'try' command and also a status client. It is also
5862 intended to support the upcoming debian-packaging init.d scripts.
5863 * buildbot/scripts/runner.py: the real work is done here
5864 * buildbot/scripts/__init__.py: need this too
5865 * buildbot/scripts/sample.cfg: this is installed in new
5866 buildmaster directories
5867 * setup.py: install new stuff
5869 2004-09-15 Brian Warner <warner@lothar.com>
5871 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5872 'file:' schema (the version shipped with OS-X was built without the
5874 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5875 updates the log-timestamp, to make sure it isn't still running after
5878 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5879 values to the config file.
5880 * docs/examples/hello.cfg: add examples
5881 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5882 * buildbot/status/builder.py (Status.getProjectURL): implement them
5883 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5884 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5885 * buildbot/status/html.py (WaterfallStatusResource): display them
5888 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5889 certain error cases don't suffer a secondary exception.
5890 (top): Skip tests if the corresponding VC tool is not installed.
5892 * buildbot/process/factory.py (Trial): introduce separate
5893 'buildpython' and 'trialpython' lists, since trialpython=[] is
5894 what you want to invoke /usr/bin/python, whereas ./setup.py is
5895 less likely to be executable. Add env= parameter to pass options
5896 to test cases (which is how I usually write tests, I don't know if
5897 anyone else does it this way).
5899 * buildbot/process/step_twisted.py (Trial): handle python=None.
5900 Require 'testpath' be a string, not a list. Fix tests= typo.
5901 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5903 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5904 way to deal with the possibility of removing the disconnect notify
5906 (CVS): add a 'login' parameter to give a password to 'cvs login',
5907 commonly used with pserver methods (where pw="" or pw="guest")
5909 * buildbot/slave/commands.py (SourceBase): move common args
5910 extraction and setup() to __init__, so everything is ready by the
5911 time setup() is called
5912 (CVS.start): call 'cvs login' if a password was supplied
5913 (ShellCommand): special-case PYTHONPATH: prepend the master's
5914 value to any existing slave-local value.
5916 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5917 don't have a remote, mark the builder as Offline. This whole
5918 function should probably go away and be replaced by individual
5920 (Builder.buildFinished): return the results to the build-finished
5921 deferred callback, helps with testing
5923 2004-09-14 Brian Warner <warner@lothar.com>
5925 * buildbot/test/test_vc.py: put all the repositories needed to run
5926 the complete tests into a single small (1.3MB) tarball, so I can
5927 make that tarball available on the buildbot web site. Test HTTP
5928 access (for Arch and Darcs) by spawning a temporary web server
5929 while the test runs.
5931 * docs/users.xhtml: new document, describe Buildbot's limited
5932 understanding of different human users
5934 * buildbot/test/test_vc.py: rearrange test cases a bit
5936 * buildbot/process/step_twisted.py (Trial): handle testpath=
5937 * buildbot/process/factory.py (Trial): update to use step.Trial
5939 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5941 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5942 the overall build text (which gives you 'failed 2 tests' rather
5944 (BuildStepStatus.text2): default to [], not None
5946 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5949 2004-09-12 Brian Warner <warner@lothar.com>
5951 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5952 log the whole exception if it's just an AttributeError (old slave)
5954 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5955 so (e.g.) sub-commands can be run in the right directory.
5956 (ShellCommand.start): accept an optional errorMessage= argument
5957 to make life easier for SVN.start
5958 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5960 (ShellCommand.start): move ['dir'] compatibility hack..
5961 (RemoteShellCommand.start): .. to here so everyone can use it
5963 * buildbot/process/step_twisted.py (Trial): use .workdir
5965 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5966 text displayed when debuild fails completely
5967 (Trial): snarf _trial_temp/test.log from the slave and display it
5969 2004-09-11 Brian Warner <warner@lothar.com>
5971 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5973 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5974 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5976 * buildbot/process/step.py (ShellCommand): call .createSummary
5977 before .evaluateCommand instead of the other way around. This
5978 makes it slightly easier to count warnings and then use that to
5979 set results=WARNINGS
5980 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5982 * buildbot/process/base.py (Build.buildFinished): update status
5983 before doing progress. It's embarrassing for the build to be stuck
5984 in the "building" state when an exceptions occurs elsewhere..
5986 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5987 python2.2 doesn't have 'sum'
5989 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5990 to prevent clients from accidentally sorting it
5992 * buildbot/master.py (Manhole): add username/password
5993 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5994 c['manholePort'], deprecate old usage
5995 * docs/config.xhtml: document c['manhole']
5996 * docs/examples/hello.cfg: show example of using a Manhole
5999 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6000 pretend the slave is up to date
6002 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6003 the module, overlaps with 'log', the local variable
6005 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6007 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6008 new method to let Steps find out the version of their
6009 corresponding SlaveCommand.
6010 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6011 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6012 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6014 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6015 (Arch.startVC): same
6016 (P4Sync.startVC): same
6018 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6019 Deferred so we can catch errors in remote_startCommand
6020 (RemoteShellCommand.start): same
6022 * docs/examples/twisted_master.cfg: update sample config file
6024 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6025 after connectionMade() is called, not before. Close stdin at that
6028 * buildbot/process/process_twisted.py: update to use Trial, clean
6029 up argument passing (move to argv arrays instead of string
6032 * buildbot/process/step_twisted.py (Trial): new step to replace
6033 RunUnitTests, usable by any trial-using project (not just
6034 Twisted). Arguments have changed, see the docstring for details.
6036 * buildbot/process/base.py (Build.startBuild): this now returns a
6037 Deferred. Exceptions that occur during setupBuild are now
6038 caught better and lead to fewer build_status weirdnesses, like
6039 finishing a build that was never started.
6040 (Build.buildFinished): fire the Deferred instead of calling
6041 builder.buildFinished directly. The callback argument is this
6042 Build, everything else can be extracted from it, including the
6043 new build.results attribute.
6044 * buildbot/process/builder.py (Builder.startBuild): same
6045 (Builder.buildFinished): same, extract results from build
6047 * buildbot/process/step.py (ShellCommands): remove dead code
6049 2004-09-08 Brian Warner <warner@lothar.com>
6051 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6052 doesn't try to use the leftover patched workdir
6053 (SourceStamp): test source-stamp computation for CVS and SVN
6055 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6056 patched workdir ('touch .buildbot-patched') so we don't try to
6058 (SourceBase.start): add ['revision'] for all Source steps
6059 (CVS): change args: use ['branch'] for -r, remove ['files']
6060 (CVS.buildVC): fix revision/branch stuff
6061 (SVN): add revision stuff
6063 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6064 kwargs (except 'workdir') to avoid silent spelling errors
6065 (ShellCommand.__init__): same
6066 (Source): new base class for CVS/SVN/etc. Factor out everything
6067 common, add revision computation (perform the checkout with a -D
6068 DATE or -r REVISION that gets exactly the sources described by the
6069 last Change), overridable with step.alwaysUseLatest. Add patch
6070 handling (build.getSourceStamp can trigger the use of a base
6071 revision and a patch).
6072 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6073 * docs/steps.xhtml: update docs
6074 * docs/source.xhtml: mention .checkoutDelay
6075 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6077 * buildbot/process/base.py (Build.setSourceStamp): add a
6078 .sourceStamp attribute to each Build. If set, this indicates that
6079 the build should be done with something other than the most
6080 recent source tree. This will be used to implement "try" builds.
6081 (Build.allChanges): new support method
6082 (Build.lastChangeTime): remove, functionality moved to Source steps
6083 (Build.setupBuild): copy the Step args before adding ['workdir'],
6084 to avoid modifying the BuildFactory (and thus triggering spurious
6088 * buildbot/status/html.py: rename s/commits/changes/
6089 (StatusResourceChanges): same
6090 (CommitBox.getBox): same, update URL
6091 (WaterfallStatusResource): same
6092 (StatusResource.getChild): same
6094 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6095 * contrib/debug.glade: add optional 'revision' to the fakeChange
6097 * buildbot/changes/changes.py (html_tmpl): display .revision
6098 (ChangeMaster.addChange): note .revision in log
6099 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6100 accept a ['revision'] attribute
6102 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6104 * buildbot/master.py (BotMaster.getPerspective): update the
6105 .connected flag in SlaveStatus when it connects
6106 (BotMaster.detach): and when it disconnects
6107 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6108 (BuildMaster.loadConfig_Builders): walk old list correctly
6110 * buildbot/test/test_config.py: fix prefix= usage
6112 2004-09-06 Brian Warner <warner@lothar.com>
6116 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6117 poll a P4 depot looking for recent changes. Thanks to Dave
6118 Peticolas for the contribution. Probably needs some testing after
6121 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6122 requires manual client setup for each buildslave. Rather
6123 experimental. Thanks again to Dave Peticolas.
6124 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6126 * buildbot/changes/changes.py (Change): add a .revision attribute,
6127 which will eventually be used to generate source-stamp values.
6129 * buildbot/process/step.py (RemoteCommand.start): use
6130 notifyOnDisconnect to notice when we lose the slave, then treat it
6131 like an exception. This allows LogFiles to be closed and the build
6132 to be wrapped up normally. Be sure to remove the disconnect
6133 notification when the step completes so we don't accumulate a
6134 bazillion such notifications which will fire weeks later (when the
6135 slave finally disconnects normally). Fixes SF#915807, thanks to
6136 spiv (Andrew Bennetts) for the report.
6137 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6138 really isn't Logged- specific
6139 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6140 header, since it's almost always going to be appended to an
6142 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6143 update test to handle use of notifyOnDisconnect
6145 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6146 don't clear .ETA and .currentBuild when going offline, let the
6147 current build clean up after itself
6149 * buildbot/process/builder.py (Builder.detached): wait a moment
6150 before doing things like stopping the current build, because the
6151 current step will probably notice the disconnect and cleanup the
6153 * buildbot/test/test_run.py (Status.tearDown): update test to
6154 handle asynchronous build-detachment
6156 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6158 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6159 hush a debug message
6161 2004-09-05 Brian Warner <warner@lothar.com>
6163 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6164 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6165 kernels do this: the fcntl module has the F_NOTIFY constant, but
6166 the kernel itself doesn't support the operation. Thanks to Olly
6167 Betts for spotting the problem.
6169 * buildbot/process/step.py (Darcs): new source-checkout command
6170 (Arch): new source-checkout command
6171 (todo_P4): fix constructor syntax, still just a placeholder
6172 * buildbot/test/test_vc.py (VC.testDarcs): test it
6173 (VC.testDarcsHTTP): same, via localhost HTTP
6175 (VC.testArchHTTP): same
6176 * NEWS: mention new features
6178 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6179 which tells the step to stash stdout text locally (in .stdout).
6180 Slave-side Commands can use this to make decisions based upon the
6181 output of the the ShellCommand (not just the exit code).
6182 (Darcs): New source-checkout command
6183 (Arch): New source-checkout command, uses .keepStdout in one place
6184 where it needs to discover the archive's default name.
6186 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6187 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6188 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6190 * buildbot/process/step.py (ShellCommand.describe): add an
6191 alternate .descriptionDone attribute which provides descriptive
6192 text when the step is complete. .description can be ["compiling"],
6193 for use while the step is running, then .descriptionDone can be
6194 ["compile"], used alone when the step succeeds or with "failed" when
6195 it does not. Updated other steps to use the new text.
6196 * buildbot/process/step_twisted.py: same
6197 * buildbot/test/test_run.py: update tests to match
6199 2004-08-30 Brian Warner <warner@lothar.com>
6201 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6202 (CVS.__init__): send 'patch' argument to slave
6203 (CVS.start): don't create the LoggedRemoteCommand until start(),
6204 so we can catch a .patch added after __init__
6205 (SVN.__init__): add 'patch' to SVN too
6208 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6209 argument, to let commands push data into the process' stdin pipe.
6210 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6211 is in use, since closing a PTY doesn't really affect the process
6212 in the right way (in particular, I couldn't run /usr/bin/patch
6214 (SourceBase.doPatch): handle 'patch' argument
6216 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6219 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6220 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6222 * buildbot/master.py (BotPerspective.got_commands): get command
6223 versions from slave, give to each builder
6224 * buildbot/process/builder.py (Builder.attached): stash slave
6225 command versions in .remoteCommands
6227 * docs/steps.xhtml: bring docs in-line with reality
6229 * buildbot/process/step.py (CVS.__init__): more brutal
6230 compatibility code removal
6231 (SVN.__init__): same
6233 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6234 (SlaveShellCommand.start): require ['workdir'] argument, remove
6235 the ['dir'] fallback (compatibility will come later)
6236 (SourceBase): update docs
6237 (SourceBase.start): remove ['directory'] fallback
6240 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6241 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6242 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6244 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6245 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6246 code.. I will figure out 0.5.0-compatibility hooks later)
6248 2004-08-30 Brian Warner <warner@lothar.com>
6250 * buildbot/process/process_twisted.py: rewrite in terms of new
6251 BuildFactory base class. It got significantly shorter. Yay
6254 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6255 work with the new "self.build isn't nailed down until we call
6256 step.start()" scheme: specifically, __init__ is called before the
6257 build has decided on which Changes are going in, so we don't scan
6258 build.allFiles() for .xhtml files until start()
6259 (HLint.commandComplete): use getText(), not getStdout()
6260 (RunUnitTests.start): same: don't use .build until start()
6261 (RunUnitTests.describe): oops, don't report (None) when using
6263 (RunUnitTests.commandComplete): use getText()
6264 (RunUnitTests.createSummary): same
6265 (BuildDebs.commandComplete): same
6267 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6268 set args['command'] until start(), since our BuildStep is allowed
6269 to change their mind up until that point
6270 (TreeSize.commandComplete): use getText(), not getStdout()
6272 * docs/examples/twisted_master.cfg: update to current standards
6274 * docs/factories.xhtml: update
6275 * buildbot/process/factory.py: implement all the common factories
6276 described in the docs. The Trial factory doesn't work yet, and
6277 I've probably broken all the process_twisted.py factories in the
6278 process. There are compatibility classes left in for things like
6279 the old BasicBuildFactory, but subclasses of them are unlikely to
6281 * docs/examples/glib_master.cfg: use new BuildFactories
6282 * docs/examples/hello.cfg: same
6284 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6285 explicit 'workdir' args
6287 * buildbot/process/base.py (BuildFactory): move factories to ..
6288 * buildbot/process/factory.py (BuildFactory): .. here
6289 * buildbot/process/process_twisted.py: handle move
6290 * buildbot/test/test_config.py: same
6291 * buildbot/test/test_run.py: same
6292 * buildbot/test/test_steps.py: same
6293 * buildbot/test/test_vc.py: same
6294 * docs/factories.xhtml: same
6296 * NEWS: mention config changes that require updating master.cfg
6298 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6299 argument to all steps that weren't given one already, pointing at
6300 the "build/" directory.
6302 * docs/examples/hello.cfg: remove explicit 'workdir' args
6304 * docs/factories.xhtml: document standard BuildFactory clases,
6305 including a bunch which are have not yet been written
6307 2004-08-29 Brian Warner <warner@lothar.com>
6309 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6310 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6311 buildbot.status.builder so they aren't quite so internal
6312 * buildbot/process/base.py, buildbot/process/builder.py: same
6313 * buildbot/process/maxq.py, buildbot/process/step.py: same
6314 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6315 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6316 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6318 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6319 to handle new getLogs()-returns-list behavior
6320 (StatusResourceBuildStep.getChild): same
6321 (StepBox.getBox): same
6322 (WaterfallStatusResource.phase0): same
6324 * docs/source.xhtml: document how Buildbot uses version-control
6325 systems (output side: how we get source trees)
6326 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6327 systems (input side: how we learn about Changes)
6329 * buildbot/master.py (Manhole): use ComparableMixin
6330 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6331 * buildbot/changes/mail.py (MaildirSource): same
6332 * buildbot/status/client.py (PBListener): same
6333 * buildbot/status/html.py (Waterfall): same
6334 * buildbot/status/words.py (IRC): same
6336 * NEWS: start describing new features
6338 * buildbot/status/mail.py (MailNotifier): finish implementation.
6339 The message body is still a bit sparse.
6340 * buildbot/test/test_status.py (Mail): test it
6342 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6343 and __hash__ methods I wind up adding everywhere. Specifically
6344 intended to support the buildbot config-file update scheme where
6345 we compare, say, the old list of IStatusTargets against the new
6346 one and don't touch something which shows up on both lists.
6347 * buildbot/test/test_util.py (Compare): test case for it
6349 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6350 return a list instead of a dict
6351 (IBuildStepStatus.getLogs): same. The idea is that steps create
6352 logs with vaguely unique names (although their uniqueness is not
6353 guaranteed). Thus a compilation step should create its sole
6354 logfile with the name 'compile', and contribute it to the
6355 BuildStatus. If a step has two logfiles, try to create them with
6356 different names (like 'test.log' and 'test.summary'), and only
6357 contribute the important ones to the overall BuildStatus.
6358 * buildbot/status/builder.py (Event.getLogs): same
6359 (BuildStepStatus): fix default .text and .results
6360 (BuildStepStatus.addLog): switch to list-like .getLogs()
6361 (BuildStepStatus.stepFinished): same
6362 (BuildStatus.text): fix default .text
6363 (BuildStatus.getLogs): temporary hack to return all logs (from all
6364 child BuildStepStatus objects). Needs to be fixed to only report
6365 the significant ones (as contributed by the steps themselves)
6366 * buildbot/test/test_run.py: handle list-like .getLogs()
6367 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6369 2004-08-28 Brian Warner <warner@lothar.com>
6371 * buildbot/process/builder.py (Builder.attached): serialize the
6372 attachment process, so the attach-watcher isn't called until the
6373 slave is really available. Add detached watchers too, which makes
6376 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6378 * buildbot/test/test_swap.py: remove dead code
6380 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6381 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6382 sort of as if the command being run exited with a -1. There may
6383 still be some holes in this scheme.
6384 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6385 -r option appears before the module list
6386 * buildbot/process/step.py (CVS): add 'revision' argument
6388 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6389 when sending updates or stepComplete messages to the master, since
6390 we don't currently care whether they arrive or not. When we revamp
6391 the master/slave protocol to really resume interrupted builds,
6392 this will need revisiting.
6393 (lostRemote): remove spurious print
6395 * buildbot/master.py (BotPerspective.attached): serialize the
6396 new-builder interrogation process, to make testing easier
6397 (BotMaster.waitUntilBuilderDetached): convenience function
6399 * buildbot/status/builder.py (BuilderStatus): prune old builds
6400 (BuildStatus.pruneSteps): .. and steps
6401 (BuildStepStatus.pruneLogs): .. and logs
6402 (BuilderStatus.getBuild): handle missing builds
6403 * buildbot/status/html.py (StatusResourceBuild.body): display build
6404 status in the per-build page
6405 (BuildBox.getBox): color finished builds in the per-build box
6407 2004-08-27 Brian Warner <warner@lothar.com>
6409 * buildbot/status/mail.py (MailNotifier): new notification class,
6412 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6413 variants of a common base class which handles all the mode= logic
6415 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6417 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6419 2004-08-26 Brian Warner <warner@lothar.com>
6421 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6424 * buildbot/test/test_run.py: update to new Logfile interface, new
6425 buildbot.slave modules
6426 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6428 * MANIFEST.in: new sample config file
6429 * docs/examples/hello.cfg: same
6431 * buildbot/process/step_twisted.py: remove dead import
6433 * buildbot/process/step.py (RemoteCommand.run): catch errors
6435 (RemoteCommand.remote_update): ignore updates that arrive after
6437 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6438 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6439 the responsibilities of the subclass's methods
6440 (BuildStep.failed): catch errors during failure processing
6441 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6442 (CVS): move to a mode= argument (described in docstring), rather
6443 than the ungainly clobber=/export=/copydir= combination.
6444 (SVN): add mode= functionality to SVN too
6445 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6447 * buildbot/process/base.py (Build.startNextStep): catch errors
6448 during s.startStep()
6450 * buildbot/clients/base.py: update to new PB client interface.
6451 gtkPanes is still broken
6453 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6454 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6455 * setup.py: add buildbot.slave module
6456 * buildbot/bb_tap.py: handle move
6457 * buildbot/slave/registry.py: place to register commands, w/versions
6458 * buildbot/slave/bot.py: major simplifications
6459 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6460 instead of a fixed table. Eventually this will make the slave more
6461 extensible. Use 'start' method on the command, not .startCommand.
6462 Fix unsafeTracebacks handling (I think).
6463 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6464 helper class with a .start method that returns a Deferred.
6465 SlaveShellCommand is the form reached by the buildmaster. Commands
6466 which use multiple ShellCommands can just chain them as Deferreds,
6467 with some helper methods in Command (_abandonOnFailure and
6468 _checkAbandoned) to bail on rc!=0.
6469 (CVSCommand): prefer new mode= argument
6470 (SVNFetch): add mode= argument
6472 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6473 put a useful reason string on the build
6475 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6476 core functionality into an IStatusLog object
6477 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6478 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6479 (StatusResourceBuild.body): use proper accessor methods
6480 * buildbot/status/client.py (RemoteLog): PB-access goes here
6481 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6482 which delivers log contents too
6483 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6484 * buildbot/status/event.py: remove old Logfile completely
6486 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6487 subscription interface for IStatusLog subscriptions just like all
6488 other the status subscriptions
6489 (IStatusReceiver.logChunk): method called on subscribers
6491 2004-08-24 Brian Warner <warner@lothar.com>
6493 * buildbot/process/builder.py (Builder._pong): oops, ping response
6494 includes a result (the implicit None returned by remote_print).
6495 Accept it so the _pong method handles the response correctly.
6497 2004-08-06 Brian Warner <warner@lothar.com>
6499 * buildbot/test/test_config.py: update IRC, PBListener tests
6501 * buildbot/status/client.py (StatusClientPerspective): total
6502 rewrite to match new IStatus interfaces. New subscription scheme.
6503 There are still a few optimizations to make (sending down extra
6504 information with event messages so the client doesn't have to do a
6505 round trip). The logfile-retrieval code is probably still broken.
6506 Moved the PB service into its own port, you can no longer share a
6507 TCP socket between a PBListener and, say, the slaveport (this
6508 should be fixed eventually).
6509 * buildbot/clients/base.py (Client): revamp to match. still needs
6510 a lot of work, but basic event reporting works fine. gtkPanes is
6513 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6514 instance talks to a single irc server. Threw out all the old
6515 multi-server handling code. Still need to add back in
6516 builder-control (i.e. "force build")
6518 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6519 more random text to the as-yet-unreachable per-step page
6521 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6522 rename to stepETAUpdate
6523 (BuildStatus.subscribe): add build-wide ETA updates
6524 (BuilderStatus.getState): remove more cruft
6525 (BuilderStatus.getCurrentBuild): remove more cruft
6526 (BuilderStatus.buildStarted): really handle tuple-subscription
6527 * buildbot/test/test_run.py (Status.testSlave): handle the
6528 stepETAUpdate rename
6530 * buildbot/master.py (BuildMaster): don't add a default
6531 StatusClientService. Don't add a default IrcStatusFactory. Both
6532 are now added through c['status'] in the config file. c['irc'] is
6533 accepted for backwards compatibility, the only quirk is you cannot
6534 use c['irc'] to specify IRC servers on ports other than 6667.
6536 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6537 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6538 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6539 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6542 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6543 the buildmaster to re-read its config file
6546 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6547 find out the port our server is running on
6548 (WebTest.test_webPathname_port): same
6550 * buildbot/test/test_config.py (testWebPortnum): test it
6551 (testWebPathname): ditto
6553 * docs/config.xhtml: document new c['status'] configuration option
6555 * buildbot/status/html.py (Waterfall): new top-level class which
6556 can be added to c['status']. This creates the Site as well as the
6557 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6558 reachable as .parent, for everything.
6560 * buildbot/master.py (Manhole): make it a normal service Child
6561 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6562 webPathname. It will eventually replace c['irc'] and the implicit
6563 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6564 in as (deprecated) backward compatibility hooks for now.
6567 * buildbot/process/builder.py (Builder.buildFinished): don't
6568 inform out builder_status about a finished build, as it finds out
6569 through its child BuildStatus object
6571 * buildbot/status/html.py: extensive revamp. Use adapters to make
6572 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6573 have both starting and finishing times and adjust the waterfall
6574 display accordingly, using spacers if necessary. Use SlaveStatus
6575 to get buildslave info.
6576 (StatusResourceBuildStep): new just-one-step resource, used to get
6577 logfiles. No actual href to it yet.
6579 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6580 the time being, until I get the file-naming scheme right
6582 * buildbot/status/builder.py (Event): clean started/finished names
6583 (BuildStatus.isFinished): .finished is not None is the right test
6584 (BuildStatus.buildStarted): track started/finished times ourselves
6585 (BuilderStatus.getSlave): provide access to SlaveStatus object
6586 (BuilderStatus.getLastFinishedBuild): all builds are now in
6587 .builds, even the currently-running one. Accomodate this change.
6588 (BuilderStatus.eventGenerator): new per-builder event generator.
6589 Returns BuildStepStatus and BuildStatus objects, since they can
6590 both be adapted as necessary.
6591 (BuilderStatus.addEvent): clean up started/finished attributes
6592 (BuilderStatus.startBuild,finishBuild): remove dead code
6593 (SlaveStatus): new object to provide ISlaveStatus
6595 * buildbot/process/step.py (ShellCommand.getColor): actually
6596 return the color instead of setting it ourselves
6597 (CVS.__init__): pull .timeout and .workdir options out of
6598 **kwargs, since BuildStep will ignore them. Without this neither
6599 will be sent to the slave correctly.
6600 (SVN.__init__): same
6602 * buildbot/process/builder.py (Builder): move flags to class-level
6604 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6605 SlaveStatus handle that
6607 * buildbot/process/base.py (Build.firstEvent): remove dead code
6608 (Build.stopBuild): bugfix
6610 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6612 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6613 (ChangeMaster.eventGenerator): yield Changes, since there are now
6614 Adapters to turn them into HTML boxes
6616 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6617 (BotPerspective.attached): feed a SlaveStatus object
6618 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6619 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6621 * buildbot/interfaces.py: API additions
6622 (ISlaveStatus): place to get slave status
6624 2004-08-04 Brian Warner <warner@lothar.com>
6626 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6627 the delay finishes, so the step is marked as SUCCESS
6629 * buildbot/test/test_run.py (Status.testSlave): cover more of
6630 IBuildStatus and IBuildStepStatus
6632 * buildbot/status/progress.py (StepProgress): move some flags to
6633 class-level attributes
6634 (StepProgress.remaining): if there are no other progress metrics
6635 to go by, fall back to elapsed time
6636 (StepProgress.setExpectations): take a dict of metrics instead of
6638 (BuildProgress.setExpectationsFrom): pull expectations from the
6639 Expectations, instead of having it push them to the BuildProgress
6640 (Expectations): move some flags to class-level attributes
6641 (Expectations.__init__): copy per-step times from the
6643 (Expectations.expectedBuildTime): new method for per-build ETA
6645 * buildbot/status/event.py (Logfile): move some flags to
6646 class-level attributes
6647 (Logfile.logProgressTo): better method name, let step set the
6648 progress axis name (instead of always being "output")
6650 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6651 times directly, rather than depending upon the (possibly missing)
6652 .progress object. Use 'None' to indicate "not started/finished
6654 (BuildStepStatus.getExpectations): oops, return the full list of
6656 (BuilderStatus._buildFinished): append finished builds to .builds
6658 * buildbot/process/step.py (BuildStep): add separate .useProgress
6659 flag, since empty .progressMetrics[] still implies that time is a
6661 (CVS): set up the cmd in __init__, instead of waiting for start()
6663 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6664 calculation, this will eventually turn into a proper sourceStamp
6665 (Build.setupBuild): tell the Progress to load from the Expectations,
6666 instead of having the Expectations stuff things into the Progress
6667 (Build.buildException): add a build-level errback to make sure the
6668 build's Deferred fires even in case of exceptions
6670 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6672 * buildbot/process/builder.py (Builder.forceBuild): convey the
6673 reason instead of creating a fake Change
6675 * docs/examples/twisted_master.cfg: update to match reality
6677 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6678 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6679 fix or remove broken/breaking tests
6681 * buildbot/status/event.py (Logfile.__len__): remove evil method
6683 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6684 missing .build, for test convenience
6686 * buildbot/process/step_twisted.py: import fixes
6688 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6690 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6691 .statusbag reference
6693 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6694 connection at shutdown, and stop it from reconnecting
6696 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6697 chase down remote-execution bugs
6699 * buildbot/process/step.py: more fixes, remove
6700 BuildStep.setStatus()
6701 * buildbot/status/builder.py: move setStatus() functionality into
6703 * buildbot/status/event.py: minor fixes
6705 2004-08-03 Brian Warner <warner@lothar.com>
6707 * buildbot/process/base.py, buildbot/process/builder.py
6708 * buildbot/process/step.py, buildbot/status/builder.py
6709 * buildbot/status/event.py, buildbot/test/test_run.py:
6710 fix status delivery, get a basic test case working
6711 * buildbot/master.py: finish implementing basic status delivery,
6712 temporarily disable HTML/IRC/PB status sources
6714 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6716 * buildbot/status/progress.py (BuildProgress): remove dead code
6718 * buildbot/interfaces.py
6719 * buildbot/process/base.py, buildbot/process/builder.py
6720 * buildbot/process/step.py, buildbot/process/step_twisted.py
6721 * buildbot/status/builder.py: Complete overhaul of the all
6722 status-delivery code, unifying all types of status clients (HTML,
6723 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6724 look like. This commit is a checkpointing of the work-in-progress:
6725 the input side is mostly done (Builders/Builds sending status
6726 to the BuilderStatus/BuildStatus objects), but the output side has
6727 not yet been started (HTML resources querying BuilderStatus
6728 objects). Things are probably very broken right now and may remain
6729 so for several weeks, I apologize for the disruption.
6731 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6732 HTML as the log's contents. Currently used for exception tracebacks.
6733 * buildbot/status/progress.py: minor spelling changes
6735 2004-08-02 Brian Warner <warner@lothar.com>
6737 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6738 in mozilla. Also added stylesheets copied from Twisted's docs.
6739 Remember that these files are meant to be run through Lore first.
6740 Thanks to Philipp Frauenfelder for the fixes.
6741 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6742 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6743 * docs/template.tpl: added a Lore template
6745 2004-07-29 Brian Warner <warner@lothar.com>
6747 * buildbot/interfaces.py: revamp status delivery. This is the
6748 preview: these are the Interfaces that will be provided by new
6749 Builder code, and to which the current HTML/IRC/PB status
6750 displayers will be adapted.
6752 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6753 on the SlaveBuilder, not the Bot.
6754 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6756 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6757 set .usePTY on the FakeSlaveBuilder
6759 2004-07-25 Brian Warner <warner@lothar.com>
6761 * buildbot/changes/freshcvs.py: add some debug log messages
6762 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6763 disabled 'setFilter' syntax
6764 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6765 don't end with a slash
6767 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6769 * setup.py: bump to 0.5.0+ while between releases
6771 2004-07-23 Brian Warner <warner@lothar.com>
6773 * setup.py (version): Releasing buildbot-0.5.0
6775 2004-07-23 Brian Warner <warner@lothar.com>
6777 * README: update for 0.5.0 release
6779 * NEWS: update for 0.5.0 release
6781 2004-07-22 Brian Warner <warner@lothar.com>
6783 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6784 mktap-time configuration flag (--usepty=1, --usepty=0)
6785 * buildbot/bot.py: same
6787 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6788 an 'info' directory being unwanted
6790 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6791 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6792 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6793 and earlier), use a FreshCVSSourceOldcred instead.
6794 (test): simple test routine: connect to server, print changes
6796 * buildbot/changes/changes.py (Change.getTime): make it possible
6797 to print un-timestamped changes
6799 * buildbot/master.py (makeApp): delete ancient dead code
6800 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6801 * buildbot/test/test_config.py (testFindConfigFile): test it
6803 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6804 instead of win32 one
6807 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6808 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6811 * buildbot/process/base.py (Builder.__init__): change constructor
6812 to accept a dictionary of config data, rather than discrete
6813 name/slave/builddir/factory arguments
6815 * docs/examples/twisted_master.cfg: update to new syntax
6816 * docs/examples/glib_master.cfg: same
6817 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6818 rough tests of the new syntax
6821 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6822 to be an int, which means "run a web.distrib sub-server on a TCP
6823 port". This lets you publish the buildbot status page to a remote
6824 twisted.web server (using distrib.ResourceSubscription). Also
6825 rename the local attributes used to hold these web things so
6826 they're more in touch with reality.
6827 * buildbot/test/test_web.py: test webPortnum and webPathname
6828 * docs/config.xhtml: document this new use of webPathname
6830 * docs/config.xhtml: new document, slightly ahead of reality
6832 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6833 'prefix' handling: treat it as a simple string to check with
6834 .startswith, instead of treating it as a directory. This allows
6835 sub-directories to be used. If you use prefix=, you should give it
6836 a string that starts just below the CVSROOT and ends with a slash.
6837 This prefix will be stripped from all filenames, and filenames
6838 which do not start with it will be ignored.
6840 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6842 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6843 and --exclude (inverse of --include). SVN post-commit hooks
6844 now have total control over which changes get sent to buildbot and which
6847 2004-07-10 Brian Warner <warner@lothar.com>
6849 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6850 test case to match new API
6852 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6853 which crashed HTML display when self.entries=[] (needed to
6854 distinguish between [], which means "no entries yet", and None,
6855 which means "the entries have been swapped out to disk, go fetch
6858 2004-07-04 Brian Warner <warner@lothar.com>
6860 * buildbot/process/step_twisted.py (countFailedTests): Count
6861 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6862 10kb from the end because any import errors are wedged there and
6863 they would make us think the test log was unparseable.
6864 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6866 2004-06-26 Brian Warner <warner@lothar.com>
6868 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6869 delete-*.pyc command into an actual BuildStep, so we can label it
6871 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6872 (FullTwistedBuildFactory): same
6874 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6876 * contrib/fakechange.py: Add an errback when sending the fake
6877 change, so we know it didn't work.
6879 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6881 * buildbot/process/step_twisted.py: Delete *.pyc files before
6882 calling trial, so it doesn't catch any old .pyc files whose .py
6883 files have been moved or deleted.
6885 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6886 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6887 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6888 instead of ["twisted.test"], so that the end result is "trial -R
6891 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6892 regular expression to match filenames that should be ignored when
6893 changed. Also add a --revision parameter that specifies the
6894 revision to examine, which is useful for debugging.
6896 2004-06-25 Brian Warner <warner@lothar.com>
6898 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6899 summary of warnings (like DeprecationWarnings), next to the
6902 2004-05-13 Brian Warner <warner@lothar.com>
6904 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6905 we now have a w32 build slave courtesy of Mike Taylor.
6907 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6908 so broken. Fixed a race condition that tripped up interlocked
6909 builds and caused the status to be stuck at "Interlocked" forever.
6910 The twisted buildbot's one interlocked build just so happened to
6911 never hit this case until recently (the feeding builds both pass
6912 before the interlocked build is attempted.. usually it has to wait
6914 (Builder._pong_failed): fix method signature
6916 * setup.py: bump to 0.4.3+ while between releases
6918 2004-04-30 Brian Warner <warner@lothar.com>
6920 * setup.py (version): Releasing buildbot-0.4.3
6922 2004-04-30 Brian Warner <warner@lothar.com>
6924 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6926 * README: update for 0.4.3 release
6928 * NEWS: update for 0.4.3 release
6930 * buildbot/master.py (BuildMaster.__getstate__): make sure
6931 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6933 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6934 .trial as a class attribute, for upgrade from 0.4.2
6936 * buildbot/changes/changes.py (Change.links): add .links for
6939 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6940 .textWatchers and .htmlWatchers at save time, since they are both
6941 volatile, should allow smooth 0.4.2 upgrade
6943 * buildbot/process/step.py (CVS.finishStatus): catch failed
6944 CVS/SVN commands so we can make the status box red
6946 2004-04-29 Brian Warner <warner@lothar.com>
6948 * buildbot/changes/freshcvs.py
6949 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6950 code to do setFilter(), which tells the freshcvs daemon to not
6951 send us stuff that we're not interested in. I will uncomment it
6952 when a new version of CVSToys is available in which setFilter()
6953 actually works, and I get a chance to test it better.
6955 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6957 * buildbot/master.py (Dispatcher): use a registration scheme
6958 instead of hardwired service names
6959 (BuildMaster): keep track of the Dispatcher to support
6962 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6963 PBChangeSource class instead of having it be an undocumented
6964 internal feature of the ChangeMaster. Split out the code into a
6966 * buildbot/changes/pb.py (PBChangeSource): same
6967 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6969 * docs/{factories|sources|steps}.xhtml: document some pieces
6971 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6972 using FCMaildirSource
6973 (f23osx): update OS-X builder to use python2.3, since the slave
6974 was updated to Panther (10.3.3)
6976 2004-03-21 Brian Warner <warner@lothar.com>
6978 * buildbot/process/process_twisted.py: factor out doCheckout, change
6979 to use SVN instead of CVS
6981 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6982 an SVN subclass easier
6983 (BasicSVN): subclass which uses Subversion instead of CVS
6985 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6987 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6989 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6991 2004-02-25 Brian Warner <warner@lothar.com>
6993 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6994 is now either a list (which is passed to spawnProcess directly) or
6995 a string (which gets passed to /bin/sh -c). This removes the useSH
6996 flag and the ArgslistCommand class. Also send status header at the
6997 start and end of each command, instead of having the master-side
6999 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7000 -r'. Update to use list-based arguments.
7001 (SVNFetch): use list-based arguments, use ['dir'] argument to
7003 * buildbot/test/test_steps.py (Commands): match changes
7005 * buildbot/process/step.py (InternalShellCommand.words): handle
7007 (SVN): inherit from CVS, cleanup
7009 * buildbot/status/event.py (Logfile.content): render in HTML, with
7010 stderr in red and headers (like the name of the command we're
7011 about to run) in blue. Add link to a second URL (url + "?text=1")
7012 to get just stdout/stderr in text/plain without markup. There is
7013 still a problem with .entries=None causing a crash, it seems to occur
7014 when the logfile is read before it is finished.
7016 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7017 timeout to the keepalives, and use it to explicitly do a
7018 loseConnection instead of waiting for TCP to notice the loss. This
7019 ought to clear up the silent-lossage problem.
7020 (unsafeTracebacks): pass exception tracebacks back to the master,
7021 makes it much easier to debug problems
7023 2004-02-23 Brian Warner <warner@lothar.com>
7025 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7026 the whole command to /bin/sh instead of execve [Johan Dahlin]
7027 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7028 '-r HEAD' [Johan Dahlin]
7029 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7031 * buildbot/changes/changes.py (Change): add links= argument, add
7032 asHTML method [Johan Dahlin]. Modified to make a bit more
7033 XHTMLish. Still not sure how to best use links= .
7035 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7036 Change.asHTML to display the change, not asText
7038 * buildbot/status/html.py (StatusResourceBuilder): web button to
7041 * buildbot/test/test_run.py: test to actually start a buildmaster
7044 * MANIFEST.in: bring back accidentally-dropped test helper files
7046 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7047 that require cvstoys if it is not installed
7049 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7050 values of "bin/trial" [Dave Peticolas]
7051 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7052 tests passed" when we didn't happen to run any tests
7054 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7055 flunkOnFailure [Johan Dahlin]
7057 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7058 multiple instances of the same Step class by suffixing "_2", etc,
7059 to the name until it is unique. This name needs to be unique
7060 because it is used as a key in the dictionary that tracks build
7062 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7065 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7067 2004-01-14 Brian Warner <warner@lothar.com>
7069 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7070 kicked from a channel, log it
7072 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7073 something over whatever IRC channels the buildmaster is currently
7074 connected to. Added to try and track down a problem in which the
7075 master thinks it is still connected but the IRCd doesn't see it. I
7076 used a styles.Versioned this time, so hopefully users won't have
7077 to rebuild their .tap files this time.
7078 * contrib/debug.glade: add a "Poke IRC" button
7079 * contrib/debugclient.py: same
7081 * setup.py: bump to 0.4.2+ while between releases
7083 2004-01-08 Brian Warner <warner@lothar.com>
7085 * setup.py (version): Releasing buildbot-0.4.2
7087 2004-01-08 Brian Warner <warner@lothar.com>
7089 * NEWS: update for 0.4.2 release
7091 * README: document how to run the tests, now that they all pass
7093 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7095 * buildbot/process/step.py (CVS): add a global_options= argument,
7096 which lets you set CVS global options for the command like "-r"
7097 for read-only checkout, or "-R" to avoid writing in the
7099 * buildbot/slavecommand.py (CVSCommand): same
7101 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7102 testing easier (it is turned off when testing, to avoid the
7105 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7106 to make it easier to test: break generateStepID() out to a
7107 separate function, only update statusbag if it exists.
7108 (ShellCommands): create useful text for dict-based commands too.
7110 * test/*, buildbot/test/*: move unit tests under the buildbot/
7112 * setup.py (packages): install buildbot.test too
7114 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7115 * buildbot/test/test_steps.py: fix it, tests pass now
7117 2004-01-06 Brian Warner <warner@lothar.com>
7119 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7120 freshcvs mail uses a slightly different syntax for new
7121 directories. Update parser to handle either.
7122 * test/test_mailparse.py (Test1.testMsg9): test for same
7124 2003-12-21 Brian Warner <warner@lothar.com>
7126 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7127 'warnOnWarnings' so that lintian errors mark the build orange
7129 2003-12-17 Brian Warner <warner@lothar.com>
7131 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7132 messages emitted by Bonsai, contributed by Stephen Davis.
7134 * test/*: moved all tests to use trial instead of unittest. Some
7135 still fail (test_steps, test_slavecommand, and test_process).
7137 * setup.py (version): bump to 0.4.1+ while between releases
7139 2003-12-09 Brian Warner <warner@lothar.com>
7141 * setup.py (version): Releasing buildbot-0.4.1
7143 2003-12-09 Brian Warner <warner@lothar.com>
7145 * NEWS: update for 0.4.1 release
7147 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7148 freebsd builder code a little bit
7150 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7151 don't try to compare attributes of different classes
7152 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7153 (MaildirSource.messageReceived): fix Change delivery
7155 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7156 into the config file's namespace before loading it, like the
7157 documentation claims it does
7158 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7159 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7160 daemon comes back online
7162 2003-12-08 Brian Warner <warner@lothar.com>
7164 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7165 so the example will work with online=0 as well
7167 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7168 fix the __implements__ line
7170 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7171 class a twisted.application.service.Service, use startService to
7174 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7175 directory fd instead of simple open(). I'm sure this used to work,
7176 but the current version of python refuses to open directories with
7179 2003-12-05 Brian Warner <warner@lothar.com>
7181 * setup.py (version): bump to 0.4.0+ while between releases
7183 2003-12-05 Brian Warner <warner@lothar.com>
7185 * setup.py (version): Releasing buildbot-0.4.0
7187 2003-12-05 Brian Warner <warner@lothar.com>
7189 * docs/examples/glib_master.cfg: replace old sample scripts with
7190 new-style config files
7191 * MANIFEST.in: include .cfg files in distribution tarball
7193 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7194 implement a dummy method to avoid the exception that occurs when
7195 freshcvs sends this to us.
7197 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7198 removed the method, as it broke reconnection. Apparently
7199 stopFactory is called each time the connection attempt fails. Must
7201 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7202 attribute before serialization, since without stopFactory the
7203 reconnect timer may still be active and they aren't serializable.
7205 * test/test_mailparse.py (ParseTest): test with 'self' argument
7207 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7208 argument, as these "functions" are invoked like methods from class
7209 attributes and therefore always get an instance as the first
7212 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7213 message: thanks to Stephen Davis for the catch
7215 2003-12-04 Brian Warner <warner@lothar.com>
7217 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7218 twisted's standard ReconnectingClientFactory. Handles both oldcred
7219 and newcred connections. Also has a bug-workaround for
7220 ReconnectingClientFactory serializing its connector when it
7223 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7224 pbutil. Replace makeApp stuff with proper newcred/mktap
7225 makeService(). Don't serialize Ephemerals on shutdown.
7227 * buildbot/changes/changes.py (ChangeMaster): make it a
7228 MultiService and add the sources as children, to get startService
7229 and stopService for free. This also gets rid of the .running flag.
7231 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7232 new pbutil, turn into a TCPClient at the same time (to get
7233 startService for free). Two variants exist: FreshCVSSourceOldcred
7234 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7235 yet, but when it does, we'll be ready).
7236 (FreshCVSSource.notify): handle paths which are empty after the
7237 prefix is stripped. This only happens when the top-level (prefix)
7238 directory is added, at the very beginning of a Repository's life.
7240 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7241 Now the only reconnecting code is in the factory where it belongs.
7242 (Builder.unsubscribe): unregister the disconnect callback when we
7243 delete the builder on command from the master (i.e. when the
7244 buildmaster is reconfigured and that builder goes away). This
7245 fixes a multiple-delete exception when the status client is shut
7247 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7250 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7251 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7253 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7255 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7256 a list of globs (ugh). The testdir will be searched for files
7257 named *.tests and run the tests in the order specified in each of
7258 those files. This allows for "dependancies" between tests to be
7261 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7262 argument to pass to run_maxq.py, instead of a glob.
7264 2003-10-17 Brian Warner <warner@lothar.com>
7266 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7267 files that live in the sandbox
7269 2003-10-15 Brian Warner <warner@lothar.com>
7271 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7272 spelling error in "docs" count-warnings output
7273 (HLint.start): stupid thinko meant .xhtml files were ignored
7275 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7276 tests now that cReactor is banished to the sandbox
7278 2003-10-10 Brian Warner <warner@lothar.com>
7280 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7281 scheme: now .xhtml are sources and .html are generated
7283 2003-10-08 Brian Warner <warner@lothar.com>
7285 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7286 we were ignoring the 'randomly' parameter.
7288 2003-10-01 Brian Warner <warner@lothar.com>
7290 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7291 posix, to kill sub-children of aborted slavecommands.
7293 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7294 Clean up initialization: lastBuildStatus remains None until the
7295 first build has been completed.
7297 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7298 None as a lastBuildStatus
7299 * buildbot/clients/gtkPanes.py: same
7301 * buildbot/status/client.py (StatusClientService): keep
7302 BuilderStatus objects in self.statusbags . These objects now live
7303 here in the StatusClientService and are referenced by the Builder
7304 object, rather than the other way around.
7305 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7306 * buildbot/process/base.py (Builder): same
7307 * test/test_config.py (ConfigTest.testBuilders): same
7309 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7310 an existing builder, leave the statusbag alone. This will preserve the
7313 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7314 hook. This will probably go away in favor of a class in upcoming
7317 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7318 serviceName from newcred FreshCVSNotifiee setup
7320 2003-09-29 Brian Warner <warner@lothar.com>
7322 * buildbot/process/process_twisted.py: switch to new reactor
7324 * docs/examples/twisted_master.cfg: same
7326 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7328 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7329 botmaster reference instead of the oldapp service lookup
7331 * buildbot/master.py (BuildMaster.__init__): give the
7332 StatusClientService a reference to the botmaster to make it easier to
7335 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7337 * buildbot/status/html.py (Box.td): escape hreffy things so you
7338 can have spaces in things like builder names
7339 (StatusResourceBuilder.body)
7340 (WaterfallStatusResource.body)
7341 (WaterfallStatusResource.body0): same
7343 2003-09-25 Brian Warner <warner@lothar.com>
7345 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7346 rearrange the builder list when adding or removing builders: keep
7347 them in the order the user requested.
7348 * test/test_config.py (ConfigTest.testBuilders): verify it
7350 * contrib/debug.glade: give the debug window a name
7352 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7353 now wait on multiple interlocks. Fix code relating to that.
7354 (Builder.checkInterlocks): same
7355 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7357 * buildbot/master.py (BuildMaster.loadConfig): move from
7358 deprecated pb.BrokerFactory to new pb.PBServerFactory
7359 * test/test_config.py (ConfigTest.testWebPathname): same
7361 * docs/examples/twisted_master.cfg: fix interlock declaration
7363 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7364 Interlocks to their Builders into interlock.py .
7365 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7367 * test/test_config.py (ConfigTest.testInterlocks): validate
7370 * buildbot/process/base.py (Builder.__init__): better comments
7371 * buildbot/process/interlock.py (Interlock.__repr__): same
7372 (Interlock.deactivate): add .active flag, move the code that
7373 attaches/detaches builders into the Interlock
7375 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7377 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7378 tests using the new run_maxq.py script, and reporting failures by
7381 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7382 tests, reporting their success or failure in a buildbot-friendly
7385 2003-09-24 Brian Warner <warner@lothar.com>
7387 * docs/examples/twisted_master.cfg: example of a new-style config
7388 file. This lives in the buildmaster base directory as
7391 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7392 button to make the master re-read its config file
7394 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7395 buildmaster configuration from a file. This file can be re-read
7396 later, and the buildmaster will update itself to match the new
7397 desired configuration. Also use new Twisted Application class.
7398 * test/Makefile, test/test_config.py: unit tests for same
7400 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7401 FreshCVSSources comparable, to support reload.
7402 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7404 * buildbot/process/base.py (Builder): make them comparable, make
7405 Interlocks easier to attach, to support reload. Handle
7406 re-attachment of remote slaves.
7407 * buildbot/process/interlock.py (Interlock): same
7409 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7410 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7411 buildmaster taps are now constructed with mktap.
7412 * buildbot/status/client.py (StatusClientService): same
7414 * buildbot/status/words.py: move to new Services, add support to
7415 connect to multiple networks, add reload support, allow nickname
7416 to be configured on a per-network basis
7418 2003-09-20 Brian Warner <warner@lothar.com>
7420 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7421 the freebsd builder, now that the machine has been upgraded and no
7422 longer has python2.2
7424 * setup.py (version): bump to 0.3.5+ while between releases
7426 2003-09-19 Brian Warner <warner@lothar.com>
7428 * setup.py (version): Releasing buildbot-0.3.5
7430 2003-09-19 Brian Warner <warner@lothar.com>
7432 * NEWS: add post-0.3.4 notes
7434 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7436 * MANIFEST.in: add contrib/*
7438 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7439 use a remote root now: cvs.twistedmatrix.com
7441 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7443 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7444 compatibility with old servers
7445 (FreshCVSSource.start): and provide a way to use it
7446 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7448 * docs/examples/twisted_master.py (twisted_app): update to new
7450 (twisted_app): listen on new ~buildbot socket
7451 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7453 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7454 to reduce cvs bandwidth (update instead of full checkout)
7456 2003-09-11 Brian Warner <warner@lothar.com>
7458 * contrib/fakechange.py: demo how to connect to the changemaster
7459 port. You can use this technique to submit changes to the
7460 buildmaster from source control systems that offer a hook to run a
7461 script when changes are committed.
7463 * contrib/debugclient.py: tool to connect to the debug port. You
7464 can use it to force builds, submit fake changes, and wiggle the
7467 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7468 'Dispatcher' realm to handle all the different kinds of
7469 connections and Perspectives: buildslaves, the changemaster port,
7470 the debug port, and the status client port. NewCredPerspectives
7471 now have .attached/.detached methods called with the remote 'mind'
7472 reference, much like old perspectives did. All the pb.Services
7473 turned into ordinary app.ApplicationServices .
7474 (DebugService): went away, DebugPerspectives are now created
7475 directly by the Dispatcher.
7476 (makeApp): changed interface a little bit
7478 * buildbot/changes/changes.py: newcred
7479 * buildbot/status/client.py: newcred
7481 * buildbot/clients/base.py: newcred client side changes
7482 * buildbot/bot.py: ditto
7484 * docs/examples/glib_master.py: handle new makeApp() interface
7485 * docs/examples/twisted_master.py: ditto
7487 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7488 base newcred Perspectives on. This should go away once Twisted
7489 itself provides something sensible.
7492 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7494 * contrib/svn_buildbot.py: A program that you can call from your
7495 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7496 when a change in an SVN repository has happened. See the top of
7497 the file for some minimal usage info.
7499 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7501 * buildbot/slavecommand.py (ArglistCommand): Add new
7502 ArglistCommand that takes an argument list rather than a string as
7503 a parameter. Using a st.split() for argv is very bad.
7505 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7506 update to a particular revision rather than always checking out
7507 (still not very smart about it, there may be cases where the
7508 checkout becomes inconsistent).
7510 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7512 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7513 SVN fetch support. It can checkout (not update!) a specified
7514 revision from a specified repository to a specified directory.
7516 * buildbot/status/progress.py (Expectations.update): Fix an
7517 obvious bug (apparently created by the change described in the
7518 previous ChangeLog message) by moving a check to *after* the
7519 variable it checks is defined.
7522 2003-09-08 Brian Warner <warner@lothar.com>
7524 * buildbot/status/progress.py (Expectations.update): hack to catch
7525 an exception TTimo sees: sometimes the update() method seems to
7526 get called before the step has actually finished, so the .stopTime
7527 is not set, so no totalTime() is available and we average None
7528 with the previous value. Catch this and just don't update the
7529 metrics, and emit a log message.
7531 2003-08-24 Brian Warner <warner@lothar.com>
7533 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7534 parameter to set copydir='original' in CVS commands.
7536 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7538 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7539 which tells the command to maintain a separate original-source CVS
7540 workspace. For each build, this workspace will be updated, then
7541 the tree copied into a new workdir. This reduces CVS bandwidth
7542 (from a full checkout to a mere update) while doubling the local
7543 disk usage (to keep two copies of the tree).
7545 2003-08-21 Brian Warner <warner@lothar.com>
7547 * buildbot/status/event.py (Logfile.addEntry): if the master web
7548 server dies while we're serving a page, request.write raises
7549 pb.DeadReferenceError . Catch this and treat it like a
7550 notifyFinish event by dropping the request.
7552 2003-08-18 Brian Warner <warner@lothar.com>
7554 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7555 (instead of blowing up) if a force-build command is given without
7558 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7559 don't blow up if there aren't yet any Changes in the list
7561 2003-08-02 Brian Warner <warner@lothar.com>
7563 * buildbot/bot.py (updateApplication): don't set the .tap name,
7564 since we shouldn't assume we own the whole .tap file
7566 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7567 'mktap buildbot' (without a subcommand) better
7569 2003-07-29 Brian Warner <warner@lothar.com>
7571 * buildbot/status/words.py
7572 (IrcStatusFactory.clientConnectionLost): when we lose the
7573 connection to the IRC server, schedule a reconnection attempt.
7575 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7576 use shutil.rmtree instead of forking off an "rm -rf" command.
7577 rmtree may take a while and will block until it finishes, so we
7578 use "rm -rf" if available.
7580 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7581 freebsd buildslave badly
7583 * setup.py (version): bump to 0.3.4+ while between releases
7585 2003-07-28 Brian Warner <warner@lothar.com>
7587 * setup.py (version): Releasing buildbot-0.3.4
7589 2003-07-28 Brian Warner <warner@lothar.com>
7591 * NEWS: update in preparation for release
7593 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7594 process.signalProcess instead of os.kill, to improve w32
7597 * docs/examples/twisted_master.py (twisted_app): turn off
7598 win32eventreactor: the tests hang the buildslave badly
7600 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7601 failed builds, since usually the failures are consistent
7603 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7604 add compileOpts/compileOpts2 to reactors build
7606 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7607 (twisted_app): use both default and win32eventreactor on w32 build.
7608 Use both default and kqreactor on freebsd build.
7610 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7611 add compileOpts2, which is put after the build_ext argument. w32
7612 needs "-c mingw32" here.
7614 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7615 touch .acqpath, it goes away in recent Twisted releases
7617 * docs/examples/twisted_master.py (twisted_app): use "python" for
7618 the w32 buildslave, not "python2.2"
7620 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7621 the directory exists.. should hush an exception under w32
7623 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7624 ProcessTerminated -provided values for signal and exitCode rather
7625 than parsing the unix status code directly. This should remove one
7626 more roadblock for a w32-hosted buildslave.
7628 * test/test_mailparse.py: add test cases for Syncmail parser
7630 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7631 temporary compatibility import. Note! Start importing
7632 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7634 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7636 2003-07-27 Brian Warner <warner@lothar.com>
7638 * NEWS: started adding new features
7640 * buildbot/changes/mail.py: start work on Syncmail parser, move
7641 mail sources into their own file
7643 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7644 as implementing IChangeSource
7645 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7647 * buildbot/interfaces.py: define the IChangeSource interface
7649 2003-07-26 Brian Warner <warner@lothar.com>
7651 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7653 2003-06-25 Brian Warner <warner@lothar.com>
7655 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7658 2003-06-17 Brian Warner <warner@lothar.com>
7660 * buildbot/status/words.py: clean up method usage to avoid error
7661 in silly IRC command
7662 (IrcStatusBot.emit_status): round off seconds display
7664 * buildbot/process/base.py (Build): delete the timer when saving
7665 to the .tap file, and restore it (if it should still be running)
7666 upon restore. This should fix the "next build in -34 seconds"
7667 messages that result when the master is restarted while builds are
7668 sitting in the .waiting slot. If the time for the build has
7669 already passed, start it very soon (in 1 second).
7671 * buildbot/status/words.py: more silly commands
7673 * README (REQUIREMENTS): add URLs to all required software
7675 * buildbot/status/words.py ('last'): mention results of, and time
7678 2003-05-28 Brian Warner <warner@lothar.com>
7680 * buildbot/status/words.py: add 'last' command
7681 (IrcStatusBot.emit_status): add current-small text to 'status' output
7683 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7684 (twisted_app): remove spaces from OS-X builder name
7686 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7687 * buildbot/status/words.py: IRC bot should actually be useful now
7689 2003-05-23 Brian Warner <warner@lothar.com>
7691 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7692 "slave information" from $(slavedir)/info/* . These files are
7693 maintained by the slave administrator, and describe the
7694 machine/environment that is hosting the slave. Information from
7695 them is put into the "Builder" HTML page. Still need to establish
7696 a set of well-known filenames and meanings for this data: at the
7697 moment, *all* info/* files are sent to the master, but only
7698 'admin' and 'host' are used on that end.
7699 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7700 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7701 * buildbot/master.py (BotPerspective.got_info): ditto
7703 2003-05-22 Brian Warner <warner@lothar.com>
7705 * setup.py (version): bump version to 0.3.3+ while between releases
7707 2003-05-21 Brian Warner <warner@lothar.com>
7709 * setup.py: Releasing buildbot-0.3.3
7711 2003-05-21 Brian Warner <warner@lothar.com>
7713 * NEWS: 0.3.3 news items
7715 * README: describe --keepalive and life behind a NAT box
7717 * buildbot/bot.py (Bot.connected): implement application-level
7718 keepalives to deal with NAT timeouts, turn them on with
7719 --keepalive option or when SO_KEEPALIVE doesn't work.
7721 * buildbot/master.py (BotPerspective): accept keepalives silently
7723 * buildbot/process/base.py (Build.buildException): CopiedFailures
7724 don't carry as much information as local ones, so don't try to
7725 create a big HTMLized version of them.
7727 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7728 log file when step fails due to an exception, such as when the slave
7731 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7732 --testmodule argument instead of grepping for test-case-name tags
7733 ourselves. Remove FindUnitTests code.
7734 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7736 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7738 2003-05-16 Brian Warner <warner@lothar.com>
7740 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7741 argument to allow things like CFLAGS=-O0 to be passed without relying
7742 upon /bin/sh processing on the slave.
7744 * buildbot/process/step.py (InternalShellCommand.start): send
7746 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7747 'split' instead of letting /bin/sh do it. This should also remove
7748 the need for /bin/sh on the buildslave, making it more likely to
7751 * buildbot/status/html.py: html-escape text in blamelist.
7752 Add "force build" button to the Builder page.
7754 * buildbot/process/step_twisted.py (countFailedTests): look at
7755 last 1000 characters for status line, as import errors can put it
7756 before the -200 point.
7758 2003-05-15 Brian Warner <warner@lothar.com>
7760 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7762 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7763 make 'clobber' a parameter, so it is possible to have builds which
7764 do full tests but do a cvs update instead of hammering the CVS
7765 server with a full checkout each build
7767 * buildbot/process/step.py (InternalShellCommand): bump default
7768 timeout to 20 minutes
7770 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7771 the master to trigger a build. Run it via manhole.
7773 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7774 allow slaves to trigger any build that they host, to make life
7775 easier for slave admins who are testing out new build processes
7777 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7778 don't flunk cReactor or qtreactor on failure, since they fail alot
7779 these days. Do warnOnFailure instead.
7781 * buildbot/process/base.py: change Builder.buildable from a list
7782 into a single slot. When we don't have a slave, new builds (once
7783 they make it past the timeout) are now merged into an existing
7784 buildable one instead of being queued. With this change, a slave
7785 which has been away for a while doesn't get pounded with all the
7786 builds it missed, but instead just does a single build.
7788 2003-05-07 Brian Warner <warner@lothar.com>
7790 * setup.py (version): bump version to 0.3.2+ while between releases
7792 2003-05-07 Brian Warner <warner@lothar.com>
7794 * setup.py: Releasing buildbot-0.3.2
7796 2003-05-07 Brian Warner <warner@lothar.com>
7798 * setup.py: fix major packaging error: include subdirectories!
7800 * NEWS: add changes since last release
7802 * README (REQUIREMENTS): update twisted/python dependencies
7804 * buildbot/status/builder.py (Builder.startBuild): change
7805 BuildProcess API: now they should call startBuild/finishBuild
7806 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7807 keeping a list of builds in the statusbag, to support other kinds of
7809 (Builder.addClient): send current-activity-small to new clients
7810 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7813 * buildbot/status/client.py: drop RemoteReferences at shutdown
7815 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7817 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7818 more debug messages for remote status client
7820 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7821 (.stepFailed): only fire the Deferred once, even if both
7822 stepComplete and stepFailed are called. I think this can happen if
7823 an exception occurs at a weird time.
7825 * buildbot/status/words.py: work-in-progress: IRC status delivery
7827 2003-05-05 Brian Warner <warner@lothar.com>
7829 * docs/examples/twisted_master.py (twisted_app): hush internal
7830 python2.3 distutils deprecation warnings
7831 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7832 add compileOpts= argument which inserts extra args before the
7833 "setup.py build_ext" command. This can be used to give -Wignore
7834 warnings, to hush some internal python-2.3 deprecation messages.
7836 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7837 the ['twisted.test'] default test case to make it easier to change
7840 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7841 * buildbot/clients/gtkPanes.py: ditto
7843 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7844 arg to collapse RunUnitTestsRandomly into RunUnitTests
7845 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7846 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7848 * buildbot/status/html.py (StatusResource): shuffle Resources
7849 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7850 would serve the waterfall display, but the internal links were
7851 only valid on the trailing-slash version. The correct behavior is
7852 for the non-slashed one to serve a Redirect to the slashed one.
7853 This only shows up when the buildbot page is hanging off another
7854 server, like a Twisted-Web distributed server.
7856 * buildbot/status/event.py (Event, RemoteEvent): make Events
7857 pb.Cacheable, with RemoteEvent as the cached version. This removes
7858 a lot of explicit send-an-update code.
7859 * buildbot/status/builder.py (Builder): remove send-update code
7860 * buildbot/status/client.py (ClientBuilder): remove send-update
7861 code, and log errors that occur during callRemote (mostly to catch
7862 InsecureJelly exceptions)
7864 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7865 run Lore with the same python used in the rest of the build
7867 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7869 * buildbot/process/step_twisted.py (HLint): accept 'python'
7870 argument. Catch rc!=0 and mark the step as failed. This marks the
7871 build orange ("has warnings").
7872 (RunUnitTestsJelly): move out to step_twisted2.py
7874 * buildbot/util.py (ignoreStaleRefs): add utility function
7876 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7877 don't fake ETA object, it's too hard to get right
7879 2003-05-02 Brian Warner <warner@lothar.com>
7881 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7883 2003-05-01 Brian Warner <warner@lothar.com>
7885 * buildbot/status/html.py (StatusResource.body): oops, I was
7886 missing a <tr>, causing the waterfall page to be misrendered in
7887 everything except Galeon.
7889 2003-04-29 Brian Warner <warner@lothar.com>
7891 * docs/examples/twisted_master.py: make debuild use python-2.2
7892 explicitly, now that Twisted stopped supporting 2.1
7894 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7895 handle tuple results too. I keep forgetting this, which suggests
7896 it needs to be rethought.
7898 * setup.py (setup): bump version to 0.3.1+ while between releases
7900 2003-04-29 Brian Warner <warner@lothar.com>
7902 * setup.py: Releasing buildbot-0.3.1
7904 2003-04-29 Brian Warner <warner@lothar.com>
7906 * README (SUPPORT): add plea to send questions to the mailing list
7908 * NEWS, MANIFEST.in: add description of recent changes
7910 * docs/examples/twisted_master.py: add the code used to create the
7911 Twisted buildmaster, with passwords and such removed out to a
7914 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7915 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7916 buildmasters to not require CVSToys be installed.
7917 * README, docs/examples/glib_master: update to match the change
7919 * buildbot/clients/base.py, buildbot/bot.py,
7920 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7921 ReconnectingPB from CVSToys distribution to remove CVSToys
7922 dependency for build slaves and status clients. Buildmasters which
7923 use FreshCVSSources still require cvstoys be installed, of course.
7925 2003-04-25 Brian Warner <warner@lothar.com>
7927 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7928 runTestsRandomly arg to turn on trial -z
7930 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7931 experimental code to use trial's machine-parseable output to get
7932 more detailed test results. Still has some major issues.
7933 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7936 * buildbot/status/builder.py (Builder.setCurrentBuild):
7937 anticipating moving build history into statusbag, not used yet
7939 * buildbot/status/tests.py: code to centralize test results,
7940 doesn't work quite yet
7942 * buildbot/status/event.py (Event): use hasattr("setName") instead
7943 of isinstance for now.. need better long-term solution
7945 * buildbot/status/html.py: Remove old imports
7947 2003-04-24 Brian Warner <warner@lothar.com>
7949 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7950 ignore changes under doc/fun/ and sandbox/
7952 * buildbot/process/step_twisted.py: update pushEvent and friends.
7954 * buildbot/status/html.py (Box.td): replace event.buildername with
7955 event.parent.getSwappableName(). Needs more thought.
7957 * buildbot/status/builder.py (Builder): Replace pushEvent and
7958 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7959 Tell events they are being pruned with event.delete().
7961 * buildbot/process/base.py (Build): Remove Builder status-handling
7962 methods. s/pushEvent/setCurrentActivity/.
7964 * buildbot/process/step.py (BuildStep): clean up status delivery.
7965 Gouse builder.statusbag methods instead of intermediate builder
7966 methods. s/updateLastEvent/updateCurrentActivity/.
7967 s/finalizeLastEvent/finishCurrentActivity/. Use
7968 addFileToCurrentActivity for summaryFunction.
7970 * buildbot/status/event.py (Logfile): put data in a Swappable when
7972 (Event): add more setter methods. Remove .buildername, use .parent
7973 and getSwappableName instead (needs more thought).
7975 * buildbot/util.py (Swappable):
7976 * test/test_swap.py: don't bother setting filename at __init__
7977 time, do it later. Change setFilename args to take parent first,
7978 since it provides the most significant part of the filename.
7980 2003-04-23 Brian Warner <warner@lothar.com>
7982 * buildbot/status/event.py (Logfile.addEntry): append to previous
7985 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7986 anticipating Swappable
7987 (InternalShellCommand.remoteUpdate): split out various log-adding
7988 methods so subclasses can snarf stdout separately
7990 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7991 in anticipation of Swappable build logs
7992 (Builder.testsFinished): anticipating TestResults, still disabled
7994 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7997 * buildbot/status/event.py (Logfile): add (disabled) support for
7998 Swappable, not ready for use yet
8000 * buildbot/util.py (Swappable): object which is swapped out to
8001 disk after some period of no use.
8002 * test/test_swap.py: test buildbot.utils.Swappable
8004 2003-04-14 Brian Warner <warner@lothar.com>
8006 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8007 periodic-build timer. Set the .periodicBuildTime on a builder
8008 instance to some number of seconds to activate it.
8010 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8012 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8013 a way that survives result tuples
8015 2003-04-12 Brian Warner <warner@lothar.com>
8017 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8018 return a dict instead of a tuple: allow summarizers to provide
8019 multiple summaries if they want
8020 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8021 (debuildSummarizer): summarize lintian warnings/errors
8023 2003-04-10 Brian Warner <warner@lothar.com>
8025 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8027 2003-04-09 Brian Warner <warner@lothar.com>
8029 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8030 empty summaries: happens when the tests fail so hard they don't emit
8031 a parseable summary line.
8033 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8034 Allow summaryFunction to return None to indicate no summary should
8037 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8038 writing to stale HTTP requests: notice when they disconnect and
8039 remove the request from the list. Also add CacheToFile from
8040 moshez, will be used later.
8042 2003-04-08 Brian Warner <warner@lothar.com>
8044 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8045 should be an int, not a list of strings
8047 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8048 if we weren't actually connected
8050 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8051 to show the tail end of the trial text output
8053 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8054 hook to summarize the results of a ShellCommand
8056 2003-04-07 Brian Warner <warner@lothar.com>
8058 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8059 twisted test suite code into a single class.
8060 * buildbot/process/process_twisted.py: same
8062 2003-04-04 Brian Warner <warner@lothar.com>
8064 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8066 * README (SLAVE): document use of mktap to create slave .tap file
8067 (REQUIREMENTS): describe dependencies
8069 * buildbot/bb_tap.py, buildbot/plugins.tml:
8070 * buildbot/bot.py (updateApplication): Add mktap support for creating
8071 buildslave .tap files
8073 2003-03-28 Brian Warner <warner@lothar.com>
8075 * buildbot/process/step.py (InternalShellCommand.finished): handle
8076 new tuple result values (fix embarrasing bug that appeared during
8079 2003-03-27 Brian Warner <warner@lothar.com>
8081 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8084 2003-03-25 Brian Warner <warner@lothar.com>
8086 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8087 to overall build status
8088 * buildbot/clients/base.py (Builder): improve event printing
8089 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8090 instead of generic ShellCommand
8091 (Build): Add .stopBuild, use it when slave is detached
8093 * buildbot/process/step.py (Configure,Test): give the steps their
8094 own names and status strings
8096 * buildbot/status/html.py (StatusResource): add "show" argument,
8097 lets you limit the set of Builders being displayed.
8099 2003-03-20 Brian Warner <warner@lothar.com>
8101 * buildbot/process/basic.py: removed
8103 2003-03-19 Brian Warner <warner@lothar.com>
8105 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8106 turn off process-docs by default
8108 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8109 when displaying build information without anything in allBuilds[]
8111 * buildbot/bot.py (makeApp): really take password from sys.argv
8113 2003-03-18 Brian Warner <warner@lothar.com>
8115 * buildbot/bot.py (buildApp): take password from sys.argv
8117 * README: replace with more useful text
8119 * setup.py: add a real one
8120 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8122 * docs/PyCon-2003/: added sources for PyCon paper.
8124 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8125 now Build objects control the process and Builder only handles
8126 slave stuff and distribution of changes/status. A new BuildFactory
8127 class creates Build objects on demand.
8129 Created ConfigurableBuild which takes a list of steps to run. This
8130 makes it a lot easier to set up a new kind of build and moves us
8131 closer to being able to configure a build from a web page.
8133 * buildbot/process/step_twisted.py, process_twisted.py: move to
8134 new model. A lot of code went away.
8136 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8137 send lots of empty progress messages to the client.
8139 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8141 2003-02-20 Brian Warner <warner@lothar.com>
8143 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8145 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8146 Twisted bug that prevented non-pty processes from working just got
8147 fixed, and the bug that leaks ptys is still being investigated.
8149 * buildbot/process/step.py (CVS): send timeout arg to slave
8151 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8152 builders coming and going
8153 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8154 from CVSToys, handle lost-buildmaster
8156 * buildbot/status/client.py (StatusClientService.removeBuilder):
8157 Clean up status client protocol: send builders (with references)
8158 as they are created, rather than sending a list and requiring the
8159 client to figure out which ones are new.
8160 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8161 attempts to force a build on an unknown builder
8163 2003-02-19 Brian Warner <warner@lothar.com>
8165 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8166 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8167 Twisted stops leaking them.
8168 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8169 builder goes to an idle state.
8171 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8172 I figure out why CVS commands hang without them, and/or I fix the
8173 hung-command timeout
8175 2003-02-16 Brian Warner <warner@lothar.com>
8177 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8178 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8179 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8180 GenerateDocs now that they are prefixed with WARNING:.
8182 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8183 use manual href target instead of request.childLink
8185 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8186 display every second, but update the ETA every 5 seconds (or
8187 whenever) as remote_progress messages arrive.
8190 2003-02-12 Brian Warner <warner@lothar.com>
8192 * *: import current sources from home CVS repository
8196 # add-log-time-format: add-log-iso8601-time-string