1 2006-11-24 Brian Warner <warner@lothar.com>
3 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
4 method, it has been deprecated for a long time. Use
5 IBuilderControl.requestBuild instead.
6 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
7 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
8 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
9 * buildbot/test/test_control.py (Force.testForce): same
10 * buildbot/test/test_run.py: use requestBuild instead
12 * buildbot/clients/debug.py: replace 'Force Build' button with
13 'Request Build' (which just adds one to the queue), add Ping
14 Builder, add branch/revision fields to Request Build.
15 * buildbot/clients/debug.glade: same
16 * buildbot/master.py: update interface to match. This creates an
17 incompatibility between new debugclients and old buildmasters.
19 * buildbot/process/builder.py (Builder._attached): delay the call
20 to maybeStartBuild for a reactor turn, to avoid starting a build
21 in the middle of a reconfig (say, if the new Builder uses a new
22 slave which is already connected).
24 2006-11-23 Brian Warner <warner@lothar.com>
26 * buildbot/test/test_transfer.py: appease pyflakes
27 * buildbot/test/test_steps.py: same
29 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
30 keeps pyflakes from finding undefined names
32 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
33 Builder no longer induces a disconnect/reconnect cycle. This means
34 that any builds currently in progress will not be interrupted, and
35 any builds which are queued in the Builder will not be lost. This
36 is implemented by having the new Builder extract the state (i.e.
37 all pending Builds and any desired SlaveBuilders) from the old
39 (BotPerspective): refactor. The BotPerspective no longer keeps
40 track of all the Builders that want to use this slave; instead, it
41 asks the BotMaster each time it needs this list. This removes
42 addBuilder and removeBuilder. Clean up attached() to acquire all
43 the slave's information in a more atomic fashion. updateSlave() is
44 now the way to make sure the slave is using the right set of
45 Builders: just call it after everything else has been
47 (BotMaster): refactor, removing addBuilder/removeBuilder and
48 replacing them with an all-at-once setBuilders() call.
50 * buildbot/test/test_slaves.py (Reconfig): new test case to
51 exercise this functionality
52 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
53 * buildbot/slave/commands.py (WaitCommand): same
55 * docs/buildbot.texinfo (Loading the Config File): document the
58 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
59 SlaveBuilder to have its parent Builder changed.
60 (SlaveBuilder.isAvailable): new method to give access to state,
61 which is now a private attribute
62 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
63 the SlaveBuilder about how it is being used. These methods update
64 its internal state. buildFinished() is now the place that invokes
65 maybeStartBuild() on its parent Builder.
66 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
67 new Builder to take over for an old one, transferring state from
69 (Buider): refactor the way that SlaveBuilders are used to match,
70 giving them a bit more autonomy.
71 (Builder.buildFinished): this no longer calls maybeStartBuild():
72 instead the SlaveBuilder calls it on whoever its parent Builder is
73 at the time. This way, when an old Builder is replaced by a new
74 one, and there was a build in progress during the transition, when
75 that build finishes, it will be the new Builder that is told about
76 the newly available slave so it can start a new build.
78 * buildbot/process/base.py (Build.startBuild._release_slave): when
79 the Build finishes, tell the SlaveBuilder that they've been
82 * buildbot/status/builder.py (SlaveStatus): add some new setter
83 methods for use by BotPerspective, to keep some attributes more
86 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
87 called by the buildmaster.
88 (Bot.setBuilderList): instead, we locally announce any leftover
89 directories based upon which Builders we were told about. The
90 master doesn't really care; it's the local admin who may or may not
94 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
95 to allow use of python2.4 or whatever. This tool still requires
98 2006-11-19 Brian Warner <warner@lothar.com>
100 * NEWS (IStatusLog.readlines): more news items
102 2006-11-18 Brian Warner <warner@lothar.com>
104 * NEWS: start collecting items for the next release.
106 2006-11-04 Brian Warner <warner@lothar.com>
108 * buildbot/changes/bonsaipoller.py: apply updates from Ben
109 Hearsum. Closes SF#1590310.
110 * buildbot/test/test_bonsaipoller.py: and tests
112 * buildbot/status/tinderbox.py
113 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
114 status when the build results in WARNINGS. Patch from Dave
115 Liebreich. Closes SF#1587352.
117 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
118 linux-vs-osx behavior difference w.r.t. reading from files that
119 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
120 to Mark Rowe for the patch.
122 2006-10-15 Brian Warner <warner@lothar.com>
124 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
125 method name was misspelled in the interface definition. Thanks to
126 Roy Rapoport for the catch.
128 2006-10-13 Brian Warner <warner@lothar.com>
130 * docs/buildbot.texinfo (Adding LogObservers): update sample code
131 to match the great Steps renaming
133 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
134 Maybe I should run my own unit tests before recording a big
135 change. Good thing I've got a buildbot to remind me.
137 2006-10-12 Brian Warner <warner@lothar.com>
139 * buildbot/steps/transfer.py: rework __init__ and args setup
140 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
142 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
143 when opening the target file, only catch IOError (to report via
144 stderr/rc!=0), let the others be reported as normal exceptions
146 2006-10-08 Brian Warner <warner@lothar.com>
148 * contrib/svn_watcher.py: fix security holes by using proper argv
149 arrays and subprocess.Popen() rather than commands.getoutput().
150 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
151 is deprecated in favor of buildbot/changes/svnpoller.py, and will
152 probably be removed by the next release.
155 2006-10-04 Brian Warner <warner@lothar.com>
157 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
158 initial lines that weren't emitted by pyflakes. When the pyflakes
159 command is run under a Makefile, 'make' will echo the command it
160 runs to stdio, and that was getting logged as a "misc" warning.
161 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
162 * buildbot/test/test_steps.py (testPyFlakes3): another test
164 2006-10-01 Brian Warner <warner@lothar.com>
166 * buildbot/status/html.py (HtmlResource.render): if we get a
167 unicode object from our content() method, encode it into utf-8
168 like we've been claiming to all along. This allows the comments
169 and author names from svnpoller.py to be delivered properly.
171 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
172 de-unicodify filenames before creating the Change, because the
173 rest of buildbot is unlikely to handle them well. Leave the 'who'
174 field as a unicode object.. I don't think there's anything that
175 will break very soon, and it will probably nudge us towards
176 accepting unicode everywhere sooner or later. Stop using the
177 "date" field that comes out of SVN, since it is using the
178 repository's clock (and timezone) and what we care about is the
179 buildmaster's (otherwise Changes from the future show up later
180 than the builds they triggered).
181 * buildbot/test/test_svnpoller.py (Everything.test1): match the
184 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
185 Suvbersion repository polling ChangeSource. I've hacked it up
186 considerably: any bugs are entirely my own fault. Thank you
188 * buildbot/test/test_svnpoller.py: tests for it
189 * docs/buildbot.texinfo (SvnSource): document it
191 2006-09-30 Brian Warner <warner@lothar.com>
193 * buildbot/scheduler.py (Periodic): submit a reason= to the
194 BuildSet to indicate which Scheduler triggered the build. Thanks
195 to Mateusz Loskot for the suggestion.
197 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
199 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
200 changes: set self.loop in __init__, remove unused volatile=
202 * docs/buildbot.texinfo (.buildbot config directory): add more
203 docs on the .buildbot/options keys used by "buildbot try"
204 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
205 (Try.deliverJob): same
207 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
211 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
212 close the filehandle when we stop watching the file. Before, the
213 filehandle was only closed when the LogFileWatcher was
214 garbage-collected, which could be quite a while in the future. If
215 it was still open by the time the next build started, windows will
216 refuse to let the new build delete the old build/ directory. Fixes
217 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
218 #twisted for the catch.
220 2006-09-29 Brian Warner <warner@lothar.com>
222 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
225 2006-09-25 Brian Warner <warner@lothar.com>
227 * setup.py: the new buildbot.steps module wasn't being installed.
228 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
229 (testmsgs): add the extra stuff from buildbot/test/* so you can
230 run unit tests on an installed copy of buildbot, not just from
233 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
234 columns of 'svnlook changed' output contain status information, so
235 strip [:4] instead of [:6]. Depending upon what the status flags
236 were, this would sometimes lead to mangled filenames. Thanks to
237 Riccardo Magliocchetti for the patch. Closes SF#1545146.
239 * buildbot/steps/source.py (Monotone): initial Monotone support,
240 contributed by Nathaniel Smith. Still needs docs and tests, but
241 this code has been in use on the Monotone buildbot for a long
243 * buildbot/slave/commands.py (Monotone): slave-side support
244 * buildbot/changes/monotone.py (MonotoneSource): polling change
247 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
248 contributed a Change Source that polls a Bonsai server (a
249 kind of web-based viewcvs CGI script).
251 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
252 Hearsum contributed a status plugin which sends email in the same
253 format that Tinderbox does: this allows a number of tinderbox
254 tools to be driven by Buildbot instead. Thanks Ben!
256 2006-09-24 Brian Warner <warner@lothar.com>
258 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
259 Thanks to Robert Helmer for the patch.
261 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
262 BuildStatus about the buildslave name at the *beginning* of the
263 build, rather than at the end. Thanks to Alexander Lorenz for the
265 * buildbot/status/html.py (StatusResourceBuild.body): always
266 include the slavename in the build page, not just when the build
268 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
269 slavename in the email message
271 2006-09-21 Brian Warner <warner@lothar.com>
273 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
275 * docs/examples/glib_master.cfg: same
276 * docs/examples/hello.cfg: same
277 * docs/examples/twisted_master.cfg: same, update to current usage
279 2006-09-19 Brian Warner <warner@lothar.com>
281 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
282 (PyFlakes.createSummary): make it compatible with python-2.2
284 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
285 for at least the output-parsing parts of PyFlakes
287 2006-09-18 Brian Warner <warner@lothar.com>
289 * buildbot/steps/python.py: oops, fix import of StringIO
291 2006-09-17 Brian Warner <warner@lothar.com>
293 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
294 turns out that SVN-1.4.0 doesn't fail to update once you've
295 replaced a file with a directory, unlike older versions of SVN and
296 pretty much every other VC tool we support. Since what we really
297 care about is that the update succeeds anyway, stop checking that
298 the tree got clobbered and just assert that the build succeeded.
299 (VCBase.printLogs): add a utility function for debugging
301 * buildbot/process/step.py: oops, added extra imports by mistake
303 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
304 rstrip() on the first line coming out of the 'p4 describe'
305 process, to remove the stray ^M that Wade Brainerd reports seeing
306 in the 'when' field. Fixes SF#1555985.
308 * buildbot/master.py (BuildMaster.loadConfig): improve the error
309 message logged when c['schedulers'] is not right
310 * buildbot/scheduler.py (Scheduler.__init__): improve error
311 message when a Scheduler() is created with the wrong arguments
312 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
313 verify that these error messages are emitted
315 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
316 The idea is that all the base classes (like BuildStep and
317 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
318 will be a leftover backwards-compatibility file that only contains
319 aliases for the steps that were moved out to buildbot.steps.*
320 * lots: change imports to match
321 * buildbot/process/step.py: add a DeprecationWarning if it ever
324 2006-09-12 Brian Warner <warner@lothar.com>
326 * buildbot/scheduler.py (Scheduler.__init__): make sure that
327 builderNames= is actually a sequence, since if you happen to give
328 it a single builder-specification dictionary instead, it won't get
329 caught by the existing assert. Thanks to Brett Neely for the
332 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
334 * docs/buildbot.texinfo (Python BuildSteps): document them
335 (sendchange): include a link to PBChangeSource, since you need one
337 * buildbot/steps/shell.py: clean up test-case-name line, remove some
339 * buildbot/steps/dummy.py: same
341 2006-09-08 Brian Warner <warner@lothar.com>
343 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
344 BuildStep which lets you transfer files from the master to the
345 slave or vice versa. Thanks to Albert Hofkamp for the original
346 patch. Fixes SF#1504631.
347 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
349 (SlaveFileDownloadCommand): same
350 * docs/buildbot.texinfo (Transferring Files): document it
351 * buildbot/test/test_transfer.py: test it
352 * buildbot/test/runutils.py (StepTester): new utility class for
353 testing BuildSteps and RemoteCommands without Builds or Bots or PB
354 * buildbot/test/test_steps.py (CheckStepTester): validate that the
357 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
358 walk through StatusLogs one line at a time, mostly for the benefit
359 of ShellCommand.createSummary methods. You can either walk through
360 STDOUT or STDERR, but the default is STDOUT.
362 * buildbot/status/builder.py (LogFile.readlines): implement it.
363 Note that this is not yet memory-efficient, it just pulls the
364 whole file into RAM and then splits it up with a StringIO.
365 Eventually this should be a generator that only pulls chunks from
367 * buildbot/test/test_status.py (Log.testReadlines): test it
369 * docs/buildbot.texinfo: update to match changes
370 * buildbot/process/factory.py: stop using old definitions
371 * buildbot/process/process_twisted.py: same
372 * buildbot/test/test_*.py: same
374 * buildbot/process/step_twisted.py: move definition to..
375 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
376 relative-import mechanisms prevent this from being named 'twisted'
377 or 'python/twisted' as I would have preferred.
379 * buildbot/process/maxq.py: move definition to..
380 * buildbot/steps/maxq.py: .. here, leave a compatibility import
382 * buildbot/process/step.py: split the user-visible BuildSteps into
383 separate files, all under buildbot/steps/
384 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
385 * buildbot/steps/shell.py: this holds ShellCommand and friends
386 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
388 2006-09-05 Brian Warner <warner@lothar.com>
390 * lots: run pyflakes, removed a lot of unused imports, changed the
391 form of some conditional imports to remove false pyflakes
392 warnings. There are still a number of warnings left, mostly from
393 imports that are done for their side-effects.
394 * buildbot/test/test_vc.py: import twisted.python.failure, since it
397 2006-08-26 Brian Warner <warner@lothar.com>
399 * buildbot/test/test_locks.py (Unit.testLater): make the tests
400 compatible with twisted-1.3.0, for some reason I just can't seem
401 to let go of the past.
403 2006-08-25 Brian Warner <warner@lothar.com>
405 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
407 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
408 all logfiles= in startCommand(), rather than in start() . This
409 makes it easier to have the 'stdio' log come before any secondary
410 logfiles, which I feel makes the waterfall display more
412 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
413 from ShellCommand up into LoggingBuildStep
414 (LoggingBuildStep.__init__): move the handling of logfiles= from
415 ShellCommand up to LoggingBuildStep, because startCommand is
416 provided by LoggingBuildStep, whereas start() was specific to
417 subclasses like ShellCommand and Source. This removes code
418 duplication in those subclasses.
419 (ShellCommand.__init__): same
420 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
421 for a slave that's too old to understand logfiles= into a separate
422 method, so it can live in ShellCommand. The rest of
423 setupLogfiles() can live in LoggingBuildStep.
425 2006-08-24 Brian Warner <warner@lothar.com>
427 * buildbot/locks.py (BaseLock): you can now configure Locks to
428 allow multiple simultaneous owners. They still default to
429 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
431 * docs/buildbot.texinfo (Interlocks): document the new options
432 * buildbot/test/test_locks.py: add a bunch of new unit tests
433 * buildbot/process/base.py (Build.acquireLocks): locks now offer
434 waitUntilMaybeAvailable, not waitUntilAvailable
435 * buildbot/process/step.py (BuildStep.acquireLocks): same
436 * buildbot/master.py (BotMaster.getLockByID): real locks now use
437 the whole lockid in their constructor, not just the name. Also,
438 keep track of which real locks we've handed out by the full
439 lockid, not just class+name, otherwise changing just the maxCount=
440 in the master.cfg file would not actually cause a behavioral
443 2006-08-23 Brian Warner <warner@lothar.com>
445 * buildbot/__init__.py (version): bump to 0.7.4+ while between
447 * docs/buildbot.texinfo: same
449 2006-08-23 Brian Warner <warner@lothar.com>
451 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
452 * docs/buildbot.texinfo: set version to match
453 * NEWS: update for 0.7.4
454 * buildbot/slave/commands.py (command_version): mention that this
455 version (2.1) was released with buildbot-0.7.4
457 2006-08-22 Brian Warner <warner@lothar.com>
461 * CREDITS: new file, list of people who have helped. Thanks!
462 * MANIFEST.in: ship it
464 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
465 new diagrams, the user's manual is more informative than it was.
466 Start shipping the .html user's manual (and generated .png
468 * Makefile: update 'release' target to match
470 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
471 test.. I think the web-parts effort will render it pointless well
472 before it ever actually starts to work.
474 2006-08-20 Brian Warner <warner@lothar.com>
476 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
477 meaning of the prefix= argument. It is now just a string which is
478 stripped from the beginning of the filename. If prefix= is set but
479 not found on any given filename, that filename is ignored. If all
480 filenames in a Change are ignored, the Change is dropped. This is
481 much simpler than the previous sep= nonsense, and I should have
482 implemented it this way from the beginning. Effectively resolves
483 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
484 Gedminas for the catch and suggested fixes.
485 (ChangePerspective.perspective_addChange): implement the actual
487 * buildbot/test/test_changes.py (TestChangePerspective): test it
488 * docs/buildbot.texinfo (PBChangeSource): document it, explain
489 how to properly use prefix=
490 * docs/examples/twisted_master.cfg (source): update prefix= by
491 adding the trailing slash
494 * docs/examples/twisted_master.cfg: update to actual practice
496 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
497 update test case to match new link text.. the HREF has both a
498 class= setting and an enclosing [] pair that I didn't match in the
501 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
502 list of strings is preferred over a single string with embedded
504 (ShellCommand.description=): explain that either single strings or
505 a list of strings is acceptable, and why you might prefer one over
506 the other. Add an example. Fixes SF#1524659, thanks to Paul
507 Winkler for the catch.
508 (Build Steps): update to use f.addStep() rather than using s()
509 and the constructor list
511 * buildbot/process/step.py (ShellCommand): accept either a single
512 string or a list of strings in both description= and
514 * buildbot/test/test_steps.py (Steps.test_description): test it
515 * buildbot/test/runutils.py (makeBuildStep): support for that test
517 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
518 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
519 collecting the files and creating the patch.
521 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
522 per-step URLs that will be displayed on the waterfall display,
523 for things like the HTML output of code-coverage tools, when
524 the results are hosted elsewhere.
525 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
526 way to retrieve these URLs
527 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
528 the method to retrieve these URLs. Also provide backwards
529 compatibility for saved BuildStepStatus instances that didn't have
531 * buildbot/process/step.py (BuildStep.addURL): method to set these
532 URLs from within a BuildStep
533 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
534 (StepBox.getBox): give these external links a distinct CSS class
535 named "BuildStep external" so a .css file can display them
538 * buildbot/test/test_web.py (WaterfallSteps): test that we really
540 * buildbot/test/test_steps.py (Steps): test that we can all the
541 URLs. Also add a bunch of other tests on methods that can be
542 called from within BuildSteps
543 * buildbot/test/runutils.py (makeBuildStep): add utility function
545 2006-08-13 Brian Warner <warner@lothar.com>
547 * docs/buildbot.texinfo (BuildStep LogFiles): document them
549 2006-08-10 Brian Warner <warner@lothar.com>
551 * docs/buildbot.texinfo (Index of master.cfg keys): add another
552 index, this one of things like c['sources'] and c['schedulers']
553 (indices): it looks like my clever idea of putting the @fooindex
554 commands in between the @node and the @subsection (to make the
555 HREF anchor jump to slightly above the section title, which works
556 much better in html) confused texinfo horribly, so I'm moving the
557 index tags back to be just after the @subsection marker. I also
558 added extra lines between the @node/@section paragraph and the
559 index tags, since I think maybe texinfo wants to see these be
562 * docs/Makefile (images): make sure images get built when
564 * docs/images/Makefile: same
566 * buildbot/scripts/runner.py: rename 'buildbot master' to
567 'buildbot create-master', and 'buildbot slave' to 'buildbot
569 * docs/buildbot.texinfo: same
572 * docs/buildbot.texinfo: reimplement the "useful classes" index
573 with actual texinfo indices. The .info rendering is a bit
574 weird-looking but it works well, and the HTML rendering is quite
575 nice. This also puts the index targets in the regular flow of the
576 text, which is easier to maintain.
578 2006-08-06 Brian Warner <warner@lothar.com>
580 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
581 Kevin Turner to prefer the environ= argument be a list rather than
582 a string. If it is a list, it will be joined with a platform-local
583 os.pathsep delimiter, and then prepended to any existing
584 $PYTHONPATH value. This works better in cross-platform (i.e.
585 windows buildslaves) environments when you need to push multiple
586 directories onto the front of the path.
587 (SlaveShellCommand): documented the new magic
588 * docs/buildbot.texinfo (ShellCommand): documented the new magic
589 in a user-visible form
591 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
592 Turner to prefer lists over strings when creating/running VC
593 commands during unit tests. This is clearly necessary to survive
594 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
595 renamed the wq() function to qw() though, since that's how it's
596 spelled in perl. Eventually I'd prefer all commands to be
597 specified with lists.
599 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
600 which are deleted (or not yet created) correctly. Also add
601 failsafe code to not explode if the file-watching poller doesn't
602 get started. Thanks to JP Calderone for the catch and the poller
604 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
606 * buildbot/test/emitlogs.py: same
608 * NEWS: summarize recent changes
610 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
611 clause to avoid the "host key mismatch" warning
613 * buildbot/process/step_twisted.py (Trial.start): if the
614 buildslave is too old to understand logfiles=, fall back to
615 running 'cat _trial_temp/test.log' like before.
616 (Trial.commandComplete): same. this takes advantage of the
617 LoggingBuildStep refactoring to stall commandComplete long enough
618 to run a second RemoteShellCommand.
620 * buildbot/process/step.py (LoggingBuildStep.startCommand):
621 refactor command-completion handling, to allow methods like
622 commandComplete/createSummary/evaluateCommand to return Deferreds.
623 (LoggingBuildStep._commandComplete): delete the refactored method
624 (ShellCommand.setupLogfiles): if the buildslave is too old to
625 understand logfiles=, put a warning message both into twistd.log
626 and into the otherwise empty user-visible LogFiles.
628 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
629 callers to provide the slave-side logfile name, rather than
630 forcing it to come from the local name of the LogFile.
631 (BuildStep.getSlaveName): new method
633 * buildbot/process/base.py (Build.getSlaveName): new method, so
634 steps can find out which buildslave they're running on
636 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
637 to match the s/cvs_ver/command_version/ change
639 2006-08-05 Brian Warner <warner@lothar.com>
641 * buildbot/slave/commands.py (command_version): replace the CVS
642 auto-updated cvs_ver keyword with a manually-updated variable,
643 since CVS is no longer the master repository. Add a description of
644 the remote API change starting in this version (2.1), specifically
645 the fact that SlaveShellCommand now accepts 'initial_stdin',
646 'keep_stdin_open', and 'logfiles'.
648 2006-07-31 Brian Warner <warner@lothar.com>
650 * docs/buildbot.texinfo (System Architecture): Finally add lots of
651 diagrams to describe how the whole system fits together. The
652 images themselves are kept in SVG files, with ascii-art versions
653 in corresponding .txt files. Texinfo knows how to interpolate the
654 text version into .info files, reference the .png versions from
655 .html files, and include .eps versions in the .ps format.
656 * docs/images/Makefile: tools to create .png and .eps
657 * docs/images/*.svg: created pictures with Inkscape.
658 * .darcs-boring: ignore the generated .eps and .png files
660 2006-07-24 Brian Warner <warner@lothar.com>
662 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
663 Scheduler names, since they cause setServiceParent to explode
665 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
667 2006-07-20 Brian Warner <warner@lothar.com>
669 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
670 which runs the buildbot unit tests
672 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
673 classes that are useful in master.cfg
675 2006-07-15 Brian Warner <warner@lothar.com>
677 * Makefile (some-apidocs): new target to build only some epydocs
679 * setup.py: minor comment.. does the classifiers= argument prevent
680 the setup.py script from working on python2.2/2.3?
682 * buildbot/scripts/sample.cfg: update manhole example, arrange into
685 * buildbot/twcompat.py: fix minor typo in comments
687 * buildbot/manhole.py: move all Manhole-related code out to this
688 module. Implement SSH-based manholes (with TwistedConch), and move
689 to conch's nifty line-editing syntax-coloring REPL shell instead
690 of the boring non-editing monochromatic (and deprecated) old
692 * buildbot/master.py: remove all Manhole-related code
693 (BuildMaster.loadConfig._add): make sure the old manhole is
694 removed before we add the new one
695 * docs/buildbot.texinfo (Debug options): document new Manhole options
697 * buildbot/twcompat.py (_which): fix some epydoc issues
698 * buildbot/status/html.py (Waterfall.__init__): same
700 2006-06-29 Brian Warner <warner@lothar.com>
702 * buildbot/interfaces.py: get Interface from b.twcompat to hush
703 deprecation warnings under newer Twisteds (by using
704 zope.interface.Interface instead of old twisted.python.components
706 * buildbot/slave/interfaces.py: same
708 2006-06-28 Brian Warner <warner@lothar.com>
710 * buildbot/slave/commands.py (SVN): add --non-interactive to all
711 svn commands, so it will fail immediately instead of hanging while
712 it waits for a username/password to be typed in.
714 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
715 log message if the step was shut down
717 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
718 obsolete reference to mktap.
720 2006-06-20 Brian Warner <warner@lothar.com>
722 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
723 test to include new 'logfiles' argument sent from master to slave
725 2006-06-19 Brian Warner <warner@lothar.com>
727 * buildbot/process/step_twisted.py (Trial): track Progress from
728 _trial_temp/test.log too
730 * buildbot/process/step.py (OutputProgressObserver): generalize
731 the earlier StdioProgressObserver into an OutputProgressObserver
732 that can track LogFiles other than stdio.
733 (LoggingBuildStep.__init__): same
735 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
736 _trial_temp/test.log, not a separate 'cat' command. TODO: this
737 will fail under windows because of os.sep issues. It might have
738 worked before if 'cat' was doing cygwin path conversion.
740 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
741 creation of LogFileWatchers
742 (ShellCommand._startCommand): and record the files that were
743 watched in the 'headers' section of the ShellCommand output
745 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
746 need to actually pass it to the slave if you want it to work.
747 (ShellCommand): document it a bit
749 * buildbot/test/test_shell.py: new test to validate LogFiles
750 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
752 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
753 before printing the last batch of lines, to test that the polling
754 logic is working properly
756 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
757 handling, making it possible to track multiple logs for a single
758 RemoteCommand. The previous single logfile is now known as the
760 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
761 (RemoteShellCommand.__init__): accept logfiles=
762 (LoggingBuildStep.startCommand): stdio_log is now one of many
763 (ShellCommand): added logfiles= argument, as well as a class-level
764 .logfiles attribute, which will be merged together to figure out
765 which logfiles should be tracked. The latter maybe be useful for
766 subclasses of ShellCommand which know they will aways produce
767 secondary logfiles in the same location.
769 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
770 and closeStdin() methods, preparing to make it possible to write
771 to a ShellCommand's stdin at any time, not just at startup. These
772 writes are buffered if the child process hasn't started yet.
773 (LogFileWatcher): new helper class to watch arbitrary logfiles
774 while a ShellCommand runs. This class polls the file every two
775 seconds, and sends back 10k chunks to the buildmaster.
776 (ShellCommand): rename stdin= to initialStdin=, and add
777 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
779 (ShellCommand.addLogfile): LogFile text is sent in updates with a
780 key of "log" and a value of (logname, data).
781 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
782 'logfiles' to the master-visible args dictionary.
783 (SourceBase.doPatch): match s/stdin/initialStdin/ change
786 * buildbot/test/test_vc.py (Patch.testPatch): same
789 * buildbot/test/emit.py: write to a logfile in the current
790 directory. We use this to figure out what was used as a basedir
791 rather than looking to see which copy of emit.py gets run, so that
792 we can run the commands from inside _trial_temp rather than inside
794 * buildbot/test/subdir/emit.py: same
795 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
796 argument rather than running from buildbot/test/
797 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
798 rather than using an implicit setUp()
799 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
800 (ShellBase.testShell1, etc): use explicit path to emit.py instead
801 of assuming that we're running in buildbot/test/ (and that '.' is
804 * buildbot/slave/commands.py (Command.doStart): refactor Command
805 startup/completion a bit: now the SlaveBuilder calls doStart(),
806 which is not meant for overridding by subclasses, and doStart()
807 calls start(), which is. Likewise the SlaveBuilder calls
808 doInterrupt(), and subclasses override interrupt(). This also puts
809 responsibility for maintaining .running in Command rather than in
811 (Command.doInterrupt): same
812 (Command.commandComplete): same, this is called when the deferred
813 returned by start() completes.
814 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
815 (SlaveBuilder.remote_interruptCommand): same
816 (SlaveBuilder.stopCommand): same
818 2006-06-16 Brian Warner <warner@lothar.com>
820 * buildbot/test/test_shell.py: new test file to contain everything
821 relating to ShellCommand
822 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
823 multiple logfiles in realtime" feature, not yet implemented
824 * buildbot/test/emitlogs.py: support file for testLogFiles
825 * docs/buildbot.texinfo (ShellCommand): document the feature
827 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
829 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
830 for tests which exercise SlaveCommands in isolation.
832 * buildbot/test/test_slavecommand.py: Move some utilities like
833 SignalMixin and FakeSlaveBuilder from here ..
834 * buildbot/test/runutils.py: .. to here, so they can be used by
835 other test classes too
836 * buildbot/test/test_vc.py: more SignalMixin refactoring
837 * buildbot/test/test_control.py: same
838 * buildbot/test/test_run.py: and some rmtree refactoring
840 2006-06-15 Brian Warner <warner@lothar.com>
842 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
843 'testBranch' to match other VC tests and have the tests run in
844 roughly increasing order of dependency
846 * buildbot/test/test_steps.py (LogObserver): new test to verify
847 LogObservers can be created at various times and still get
848 connected up properly
850 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
851 to create BuildStepStatus instances that actually work.
853 * buildbot/process/step.py (LogObserver): add outReceived and
854 errReceived base methods, to be overridden
856 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
857 API to take a name instead of a step, reducing the coupling
858 somewhat. This returns the BuildStepStatus object so it can be
859 passed to the new Step, instead of jamming it directly into the
861 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
863 * buildbot/process/base.py (Build.setupBuild): use both methods
864 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
865 process a bit to match
867 2006-06-14 Brian Warner <warner@lothar.com>
869 * docs/buildbot.texinfo (Adding LogObservers): add some limited
870 docs on writing new LogObserver classes
871 (Writing New Status Plugins): brief docs on how Status Plugins fit
874 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
875 implement a LogObserver that counts how many unit tests have been
877 (Trial.__init__): wire it in
878 * buildbot/test/test_twisted.py (Counter): unit test for it
880 * buildbot/process/step_twisted.py (HLint.commandComplete): update
881 to new cmd.logs['stdio'] scheme
882 (Trial.commandComplete): same
883 (BuildDebs.commandComplete): same
885 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
886 LogFiles, instead of just a single one. The old single logfile is
887 now called "stdio". LoggedRemoteCommand no longer creates a
888 LogFile for you (the code to do that was broken anyway). If you
889 don't create a "stdio" LogFile, then stdout/stderr will be
891 (LogObserver): implement "LogObservers", which a BuildStep can add
892 to parse the output of a command in real-time. The primary use is
893 to provide more useful information to the Progress code, allowing
894 better ETA estimates.
895 (LogLineObserver): utility subclass which feeds complete lines to
896 the parser instead of bytes.
897 (BuildStep.progressMetrics): this is safer as a tuple
898 (BuildStep.setProgress): utility method, meant to be called by
900 (BuildStep.addLogObserver): new method, to be called at any time
901 during the BuildStep (even before any LogFiles have been created),
902 to attach (or schedule for eventual attachment) a LogObserver to a
904 (StdioProgressObserver): new LogObserver which replaces the old
905 "output" progress gatherer
906 (LoggingBuildStep.__init__): same
907 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
908 (LoggingBuildStep._commandComplete): must use logs['stdio']
909 instead of the old single ".log" attribute.
910 * buildbot/status/builder.py (LogFile): remove old logProgressTo
911 functionality, now subsumed into StdioProgressObserver
912 * buildbot/test/test_status.py (Subscription._testSlave_2): the
913 log name changed from "output" to "stdio".
916 * buildbot/interfaces.py (ILogFile): add the Interface used from
917 the BuildStep towards the LogFile
918 (ILogObserver): and the one provided by a LogObserver
919 * buildbot/status/builder.py (LogFile): implement it
921 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
922 HEADER constants here ..
923 * buildbot/status/builder.py (STDOUT): .. from here
925 2006-06-13 Brian Warner <warner@lothar.com>
927 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
928 compatibility with python2.2, which doesn't have the 'substr in
930 (TestP4Poller.makeTime): utility function to construct the
931 timestamp using the same strptime() approach as p4poller does. It
932 turns out that time.mktime() behaves slightly differently under
933 python2.2, probably something to do with the DST flag, and that
934 causes the test to fail under python2.2. (changing the mktime()
935 arguments to have dst=0 instead of -1 caused it to fail under
936 python2.3. Go figure.)
937 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
939 2006-06-12 Brian Warner <warner@lothar.com>
941 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
942 proper Perforce (P4) support. Many many thanks to Scott Lamb for
943 contributing such an excellent patch, including docs and unit
944 tests! This makes it *so* much easier to apply. I had to update
945 test_vc.py to handle some recent refactorings, but everything else
946 applied smoothly. The only remaining thing I'd like to fix would
947 be to remove the hard-wired port 1666 used by p4d, and allow it to
948 claim any unused port. This would allow two copies of the test
949 suite to run on the same host at the same time, as well as
950 allowing the test suite to run while a real (production) p4d was
951 running on the same host. Oh, and maybe we should add a warning to
952 step.P4 that gets emitted if the slave is too old to provide the
953 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
954 * buildbot/slave/commands.py (P4): same
955 (P4Sync): same, some minor updates
956 * buildbot/changes/p4poller.py: same
957 * docs/buildbot.texinfo: same
958 * buildbot/test/test_p4poller.py: same
959 * buildbot/test/test_vc.py (P4): same
961 * setup.py: add Trove classifiers for PyPI
963 2006-06-08 Brian Warner <warner@allmydata.com>
965 * buildbot/status/client.py
966 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
967 changing this from getCurrentBuild() to getCurrentBuilds(). Each
968 build needs to be IRemote'd separately, rather than IRemote'ing
969 the whole list at once. I can't wait until newpb's serialization
970 adapters make this unnecessary.
972 2006-06-06 Brian Warner <warner@lothar.com>
974 * buildbot/process/step.py (WithProperties): make this inherit
975 from ComparableMixin, so that reloading an unchanged config file
976 doesn't cause us to spuriously reload any Builders which use them.
977 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
980 2006-06-03 Brian Warner <warner@lothar.com>
982 * contrib/windows/{setup.py, buildbot_service.py}: add support for
983 running py2exe on windows, contributed by Mark Hammond. Addresses
984 SF#1401121, but I think we still need to include
985 buildbot/scripts/sample.cfg
986 * setup.py: include buildbot_service.py as a script under windows
987 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
988 a py2exe application), get the icon/css datafiles from a different
991 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
992 double-escape the build URL. Thanks to Olivier Bonnet for the
993 patch. Fixes SF#1452801.
995 2006-06-02 Brian Warner <warner@lothar.com>
997 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
998 first six columns of 'svnlook' output, not just the first column,
999 since property changes appear in the other five. Thanks to Olivier
1000 Bonnet for the patch. Fixes SF#1398174.
1002 2006-06-01 Brian Warner <warner@lothar.com>
1004 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1005 the fake build, so that title= has something to be set to
1007 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1008 attribute of the "Build #NN" link in the yellow start-the-build
1009 box to the build's reason. This means that you get a little
1010 tooltip explaining why the build was done when you hover over the
1011 yellow box. Thanks to Zandr Milewski for the suggestion.
1013 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1014 (Box.setETA): handle ETA=None (by stopping the timer)
1015 (Box.update): make the [soon] text less different than the usual
1016 text, so the rest of the text doesn't flop around so much. It
1017 would be awfully nice to figure out how to center this stuff.
1018 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1020 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1021 by default, so that any ShellCommand which fails marks the overall
1022 build as a failure. I should have done this from the beginning.
1023 Add flunkOnFailure=False to the arguments if you want to turn off
1026 2006-05-30 Brian Warner <warner@lothar.com>
1028 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1029 last-build/current-build/current-step. Show what step is currently
1030 running. Show ETA for both the overall build and the current step.
1031 Update GTK calls to modern non-deprecated forms. There's still a
1032 lot of dead code and debug noise to remove.
1034 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1035 shows up properly in status displays
1037 2006-05-28 Brian Warner <warner@lothar.com>
1039 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1040 build we use to verify that WithProperties works:
1042 ** set flunkOnFailure=True so that build failures get noticed
1043 ** set workdir='.' so that the build succeeds, otherwise it is trying
1044 to touch 'build/something', and 'build/' doesn't exist because
1045 usually that's created by a Source step
1046 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1047 this test somehow triggers, in which the 'touch' process becomes
1048 a zombie and we wait for th etimeout before giving up on it.
1050 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1051 to log the Build results and step logs to the twisted log.
1052 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1053 what went wrong if a build was expected to succeed but didn't.
1055 * buildbot/process/step_twisted.py (Trial): set the default
1056 trialMode to '--reporter=bwverbose', which specifies verbose
1057 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1058 '-to', but those are completely missing in modern Twisteds.
1060 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1061 a localhost-only port, to encourage better security
1063 * docs/buildbot.texinfo (Change Sources): mention
1066 * .darcs-boring: add a Darcs boringfile
1068 * README (REQUIREMENTS): stop claiming compatibility with
1071 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1074 2006-05-27 Brian Warner <warner@lothar.com>
1076 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1077 * docs/buildbot.texinfo: same
1079 2006-05-23 Brian Warner <warner@lothar.com>
1081 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1082 * docs/buildbot.texinfo: set version to match
1083 * NEWS: update for 0.7.3
1085 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1086 give a quick mapping from VC system to possible ChangeSources
1087 (Build Properties): add 'buildername'
1089 * buildbot/process/base.py (Build.setupStatus): oops, set
1090 'buildername' and 'buildnumber' properties
1091 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1094 2006-05-22 Brian Warner <warner@lothar.com>
1096 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1097 property interpolation better
1099 * README (INSTALLATION): remove old '-v' argument from recommended
1102 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1103 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1106 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1107 'svnversion' instead of grepping the output of 'svn info', much
1108 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1109 Bonnet for the suggestion.
1110 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1111 require the WC_PATH argument, so run 'svnversion .' instead.
1113 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1114 aren't supposed to have 'self' in their argument list
1116 2006-05-21 Brian Warner <warner@lothar.com>
1118 * buildbot/process/step.py (ShellCommand.start): make
1119 testInterpolate pass. I was passing the uninterpolated command to
1120 the RemoteShellCommand constructor
1121 (ShellCommand._interpolateProperties): oops, handle non-list
1122 commands (i.e. strings with multiple words separated by spaces in
1123 them) properly, instead of forgetting about them.
1125 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1126 to actually try to use build properties in a real build. This test
1128 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1129 to start and evaluate builds
1131 * buildbot/test/test__versions.py: add a pseudo-test to record
1132 what version of Twisted/Python/Buildbot are running. This should
1133 show up at the beginning of _trial_tmp/test.log, and exists to help
1134 debug other problems.
1136 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1137 a filename to be served as 'robots.txt' to discourage web spiders.
1138 Adapted from a patch by Tobi Vollebregt, thanks!
1139 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1140 (Waterfall.test_waterfall): tweak the way that filenames are put
1141 into the config file, to accomodate windows pathnames better.
1143 * docs/buildbot.texinfo (HTML Waterfall): document it
1145 * buildbot/process/process_twisted.py
1146 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1147 changed the build process. The new setup.py no longer takes the
1149 (FullTwistedBuildFactory.__init__): same
1150 (TwistedReactorsBuildFactory.__init__): same
1152 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1153 be placed in the [hooks] section of the central repository (the
1154 one that everybody pushes changes to).
1156 2006-05-20 Brian Warner <warner@lothar.com>
1158 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1159 .darcs-context file, use binary mode. I think this was causing a
1160 Darcs failure under windows.
1162 2006-05-19 Brian Warner <warner@lothar.com>
1164 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1165 use a timezone string of +0000 and gmtime, since this timestamp is
1166 sent to a buildmaster and %z is broken.
1168 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1169 string and localtime, since this timestamp will only be consumed
1170 locally, and %z is broken.
1172 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1173 gmtime, since this timestamp is returned to the buildmaster, and
1176 2006-05-18 Brian Warner <warner@lothar.com>
1178 * NEWS: update in preparation for next release
1180 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1181 setup-repository and do-we-have-the-vc-tools code into a separate
1182 "helper" class, which sticks around in a single module-level
1183 object. This seems more likely to continue to work in the future
1184 than having it hide in the TestCase and hope that TestCases stick
1185 around for a long time.
1187 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1188 addremove' has been deprecated in recent versions of mercurial, so
1189 use 'hg add' instead
1191 2006-05-07 Brian Warner <warner@lothar.com>
1193 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1194 operating under windows, move the file before opening it, since
1195 you can't rename a file that somebody has open.
1197 * buildbot/process/base.py (Build.setupBuild): if something goes
1198 wrong while creating a Step, log the name and arguments, since the
1199 error message when you get the number of arguments wrong is really
1202 2006-05-06 Brian Warner <warner@lothar.com>
1204 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1205 bugs in twisted-specific code not covered by my unit tests, this
1206 time use 'cmd' argument instead of self.cmd
1208 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1209 fix stupid braino: either use startwith or find()==0, not both.
1210 (TwistedReactorsBuildFactory.__init__): another dumb typo
1212 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1213 mark this test as TODO under windows, since process-killing seems
1214 dodgy there. We'll come back to this later and try to fix it
1217 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1218 and don't include a timezone
1219 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1220 This should avoid the windows-with-verbose-timezone-name problem
1222 (Patch.testPatch): add a test which runs 'patch' with less
1223 overhead than the full VCBase.do_patch sequence, to try to isolate
1224 a windows test failure. This one uses slave.commands.ShellCommand
1225 and 'patch', but none of the VC code.
1227 * buildbot/slave/commands.py (getCommand): use which() to find the
1228 executables for 'cvs', 'svn', etc. This ought to help under
1231 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1232 working directory before starting. If an earlier test failed, the
1233 leftover directory would mistakenly flunk a later test.
1234 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1235 Make sure that we use the right commandlines if which("tla") picks
1236 up "tla.exe" (as it does under windows).
1237 (TlaSupport.do_get): factor out this tla-vs-baz difference
1238 (TlaSupport.vc_create): more tla-vs-baz differences
1240 * buildbot/test/test_slavecommand.py
1241 (ShellBase.testShellMissingCommand): stop trying to assert
1242 anything about the error message: different shells on different
1243 OSes with different languages makes it hard, and it really isn't
1244 that interesting of a thing to test anyway.
1246 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1247 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1248 "Panther"), because it has a bug which flunks a couple tests in
1249 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1250 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1251 able to test that yet.
1253 2006-04-30 Brian Warner <warner@lothar.com>
1255 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1256 make sure child commands emit messages in english, so our regexps
1257 will match. Thanks to Nikaus Giger for identifying the problems.
1258 (VCBase._do_vctest_export_1): mode="export" is not responsible
1259 for setting the "got_revision" property, since in many cases it is
1260 not convenient to determine.
1261 (SVNSupport.capable): when running 'svn --version' to check for
1262 ra_local, we want error messages in english
1263 * buildbot/test/test_slavecommand.py
1264 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1265 to emit the error message in english
1267 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1268 the environment with $LC_ALL="C" so that Commands which need to
1269 parse the output of their child processes can obtain it in
1271 (SVN.parseGotRevision): call "svn info" afterwards instead of
1272 watching the output of the "svn update" or "svn checkout".
1273 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1274 (Arch.parseGotRevision): same
1275 (Bazaar.parseGotRevision): same
1276 (Mercurial.parseGotRevision): same
1278 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1279 $LC_ALL="C" when running commands under 'buildbot try', too
1281 * buildbot/test/__init__.py: remove the global os.environ()
1282 setting, instead we do it just for the tests that run commands and
1283 need to parse their output.
1285 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1286 remove the overly-short .timeout on this test, because non-DNotify
1287 platforms must fall back to polling which happens at 10 second
1288 intervals, so a 5 second timeout would never succeed.
1290 2006-04-24 Brian Warner <warner@lothar.com>
1292 * docs/buildbot.texinfo (Installing the code): update trial
1293 invocation, SF#1469116 by Niklaus Giger.
1294 (Attributes of Changes): updated branch-name examples to be
1295 a bit more realistic, SF#1475240 by Stephen Davis.
1297 * contrib/windows/buildbot2.bat: utility wrapper for windows
1298 developers, contributed by Nick Trout (after a year of neglect..
1299 sorry!). SF#1194231.
1301 * buildbot/test/test_vc.py (*.capable): store the actual VC
1302 binary's pathname in VCS[vcname], so it can be retrieved later
1303 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1304 strip out non-numeric timezone information, specifically the funky
1305 German string that his system produced that confuses CVS.
1306 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1307 allow Darcs tests to work on windows
1308 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1309 procutils.which() everywhere, to allow tryclient to work under
1310 windows. Also from Niklaus Giger, SF#1463394.
1312 * buildbot/twcompat.py (which): move the replacement for a missing
1313 twisted.python.procutils.which from test_vc.py to here, so it can
1314 be used in other places too (specifically tryclient.py)
1316 2006-04-23 Brian Warner <warner@lothar.com>
1318 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1319 bare buildbotURL/projectName line with a proper DIV, along with a
1320 CSS class of "title", from Stefan Seefeld (SF#1461675).
1321 (WaterfallStatusResource.body0): remove the redundant 'table'
1322 class from the table
1323 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1324 to the top-row TR, and class="Activity" to the second-row TR,
1325 rather than putting them in the individual TD nodes.
1327 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1328 'got_revision' build property for all VC systems that implement
1329 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1331 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1332 to determine which revision we actually obtained
1333 (CVS.parseGotRevision): implement this for CVS, which just means
1334 to grab a timestamp. Not ideal, and it depends upon the buildslave
1335 having a clock that is reasonably well syncronized with the server,
1336 but it's better than nothing.
1337 (SVN.parseGotRevision): implement it for SVN, which is accurate
1338 (Darcs.parseGotRevision): same
1339 (Arch.parseGotRevision): same
1340 (Bazaar.parseGotRevision): same
1341 (Mercurial.parseGotRevision): same
1343 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1344 keep a record of all non-stdout/stderr/header/rc status updates,
1345 for the benefit of RemoteCommands that send other useful things,
1347 (Source.commandComplete): put any 'got_revision' status values
1348 into a build property of the same name
1351 * buildbot/process/step_twisted.py (Trial): update to deal with
1352 new ShellCommand refactoring
1354 * docs/buildbot.texinfo (Build Properties): document new feature
1355 that allows BuildSteps to get/set Build-wide properties like which
1356 revision was requested and/or checked out.
1358 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1359 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1360 it. Note that this bumps the persistenceVersion of the saved Build
1361 object, so add the necessary upgrade-old-version logic to include
1362 an empty properties dict.
1364 * buildbot/process/base.py (Build.setProperty): implement it
1365 (Build.getProperty): same
1366 (Build.startBuild): change build startup to set 'branch',
1367 'revision', and 'slavename' properties at the right time
1369 * buildbot/process/step.py (BuildStep.__init__): change setup to
1370 require 'build' argument in a better way
1371 (LoggingBuildStep): split ShellCommand into two pieces, for better
1372 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1373 a single RemoteCommand that sends stdout/stderr status text. It
1374 also provides the usual commandComplete / createSummary /
1375 evaluateCommand / getText methods to be overridden...
1376 (ShellCommand): .. whereas ShellCommand is specifically for
1377 running RemoteShellCommands. Other shell-like BuildSteps (like
1378 Source) can inherit from LoggingBuildStep instead of ShellCommand
1379 (WithProperties): marker class to do build-property interpolation
1380 (Source): inherit from LoggingBuildStep instead of ShellCommand
1383 * buildbot/test/test_properties.py: test new functionality
1385 2006-04-21 Brian Warner <warner@lothar.com>
1387 * buildbot/test/test_vc.py: rename testBranch to
1388 testCheckoutBranch to keep the tests in about the right
1391 2006-04-18 Brian Warner <warner@lothar.com>
1393 * docs/buildbot.texinfo (PBListener): improve cross-references
1394 between PBListener and 'buildbot statusgui', thanks to John Pye
1397 2006-04-17 Brian Warner <warner@lothar.com>
1399 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1400 running under Twisted-1.3.0, otherwise skipped tests are reported
1403 * all: use isinstance() instead of 'type(x) is foo', suggested by
1406 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1407 oops, fix a brain-fade from the other week, when making the
1408 addStep changes. I changed all the __init__ upcalls to use the
1409 wrong superclass name.
1410 (FullTwistedBuildFactory.__init__): same
1411 (TwistedDebsBuildFactory.__init__): same
1412 (TwistedReactorsBuildFactory.__init__): same
1413 (TwistedBuild.isFileImportant): use .startswith for clarity,
1414 thanks to Neal Norwitz for the suggestions.
1416 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1417 changes, then deliver them over PB to a remote buildmaster.
1419 * contrib/svnpoller.py: added script by John Pye to poll a remote
1420 SVN repository (by running 'svn log') from a cronjob, and run
1421 'buildbot sendchange' to deliver the changes to a remote
1423 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1424 modification of svnpoller.py), same purpose, but this one loops
1425 internally (rather than expecting to run from a cronjob) and works
1427 * contrib/README.txt: same
1429 2006-04-11 Brian Warner <warner@lothar.com>
1431 * all: fix a number of incorrect names and missing imports, thanks
1432 to Anthony Baxter for the patch.
1433 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1434 remove unused buggy method.
1435 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1436 comes from shutil, not "shutils"
1437 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1438 (Arch.checkSlaveVersion): same
1439 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1441 * buildbot/process/step_twisted2.py: add some missing imports
1442 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1443 this code used to live in twisted.internet.defer
1445 2006-04-10 Brian Warner <warner@lothar.com>
1447 * buildbot/process/step.py (Mercurial): add Mercurial support
1448 * buildbot/slave/commands.py (Mercurial): same
1449 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1450 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1451 not yet tested, but 'try' support *is* covered
1452 * docs/buildbot.texinfo (Mercurial): document it
1454 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1455 some debugging messages (turned off)
1456 * buildbot/test/test_vc.py: improve debug messages
1458 2006-04-07 Brian Warner <warner@lothar.com>
1460 * buildbot/test/test_vc.py (which): define our own which() in case
1461 we can't import twisted.python.procutils, because procutils doesn't
1462 exist in Twisted-1.3
1464 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1465 of SlaveLocks for performance tests
1467 * docs/examples/twisted_master.cfg: update to match current usage
1469 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1470 password, p4 binary, pollinterval, maximum history to check.
1471 Patch from an anonymous sf.net contributor, SF#1219384.
1472 * buildbot/process/step.py (P4Sync.__init__): add username,
1473 password, and client arguments.
1474 * buildbot/slave/commands.py (P4Sync): same
1476 2006-04-05 Brian Warner <warner@lothar.com>
1478 * buildbot/process/factory.py (BuildFactory.addStep): new method
1479 to add steps to a BuildFactory. Use it instead of f.steps.append,
1480 and you can probably avoid using the s() convenience function.
1481 Patch from Neal Norwitz, sf.net #1412605.
1482 (other): update all factories to use addStep
1483 * buildbot/process/process_twisted.py: update all factories to use
1486 2006-04-03 Brian Warner <warner@lothar.com>
1488 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1489 work under windows too. Adapted from a patch by Niklaus Giger,
1490 addresses SF#1463399.
1492 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1493 spawned commands emit parseable results in english and not some
1494 other language. Patch from Niklaus Giger, SF#1463395.
1496 * README (INSTALLATION): discourage users from running unit tests on
1497 a "network drive", patch from Niklaus Giger, SF#1463394.
1499 2006-03-22 Brian Warner <warner@lothar.com>
1501 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1502 function to turn a repository-relative pathname into a (branch,
1503 branch-relative-filename) tuple. Change this function to handle
1504 the branch naming policy used by your Subversion repository.
1505 Thanks to AllMyData.com for sponsoring this work.
1507 2006-03-16 Brian Warner <warner@lothar.com>
1509 * buildbot/scripts/sample.cfg: add python-mode declaration for
1510 vim. Thanks to John Pye for the patch.
1512 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1513 command line, mention the importance of running 'crontab' as the
1514 buildmaster/buildslave user. Thanks to John Pye for the catch.
1516 2006-03-13 Brian Warner <warner@lothar.com>
1518 * buildbot/status/words.py (IRC): add an optional password=
1519 argument, which will be sent to Nickserv in an IDENTIFY message at
1520 login, to claim the nickname. freenode requires this before the
1521 bot can sent (or reply to) private messages. Thanks to Clement
1522 Stenac for the patch.
1523 * docs/buildbot.texinfo (IRC Bot): document it
1525 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1526 larger than chunkSize. Fixes SF#1349253.
1527 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1528 (Log.testConsumer): update to match new internal chunking behavior
1530 2006-03-12 Brian Warner <warner@lothar.com>
1532 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1534 * buildbot/test/test_maildir.py (MaildirTest): rename the
1535 'timeout' method, as it collides with trial's internals
1537 * buildbot/scripts/runner.py: add 'buildbot restart' command
1538 (stop): don't sys.exit() out of here, otherwise restart can't work
1539 * docs/buildbot.texinfo (Shutdown): document it
1541 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1542 * buildbot/status/html.py (Waterfall.__init__): same
1543 * buildbot/process/builder.py (Builder.startBuild): same
1544 * buildbot/process/base.py (BuildRequest): same
1545 * buildbot/sourcestamp.py (SourceStamp): same
1546 * buildbot/scheduler.py (Nightly): same
1548 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1550 * docs/buildbot.texinfo: same
1552 2006-02-17 Brian Warner <warner@lothar.com>
1554 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1555 * docs/buildbot.texinfo: set version number to match
1556 * NEWS: update for 0.7.2
1558 2006-02-16 Brian Warner <warner@lothar.com>
1560 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1562 2006-02-09 Brian Warner <warner@lothar.com>
1564 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1565 add text to explain per-build branch parameters
1566 * NEWS: mention --umask
1568 2006-02-08 Brian Warner <warner@lothar.com>
1570 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1572 (SlaveOptions.optParameters): add --umask, to make it possible to
1573 make buildslave-generated files (including build products) be
1576 * buildbot/slave/bot.py (BuildSlave.startService): same
1578 2006-01-23 Brian Warner <warner@lothar.com>
1580 * buildbot/status/builder.py: urllib.quote() all URLs that include
1581 Builder names, so that builders can include characters like '/'
1582 and ' ' without completely breaking the resulting HTML. Thanks to
1583 Kevin Turner for the patch.
1584 * buildbot/status/html.py: same
1585 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1587 * NEWS: update in preparation for upcoming release
1589 2006-01-18 Brian Warner <warner@lothar.com>
1591 * docs/examples/twisted_master.cfg: update to match the Twisted
1592 buildbot: remove python2.2, switch to exarkun's buildslaves,
1593 disable the .deb builder until we figure out how to build twisted
1594 .debs from SVN, add some ktrace debugging to the OS-X build
1595 process and remove the qt build, remove threadless builders,
1596 change freebsd builder to use landonf's buildslave.
1598 2006-01-12 Brian Warner <warner@lothar.com>
1600 * buildbot/master.py (Manhole.__init__): let port= be a strports
1601 specification string, but handle a regular int for backwards
1602 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1603 used in master.cfg to limit connections to just the local host.
1604 (BuildMaster.loadConfig): same for c['slavePortnum']
1605 * buildbot/scheduler.py (Try_Userpass.__init__): same
1606 * buildbot/status/client.py (PBListener.__init__): same
1607 * buildbot/status/html.py (Waterfall.__init__): same, for both
1608 http_port and distrib_port. Include backwards-compatibility checks
1609 so distrib_port can be a filename string and still mean unix:/foo
1610 * docs/buildbot.texinfo (Setting the slaveport): document it
1611 (Debug options): same
1612 (HTML Waterfall): same
1615 * buildbot/test/test_config.py (ConfigTest): test it
1617 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1618 slaveport's disownServiceParent deferred to fire before opening
1619 the new one. Fixes an annoying bug in the unit tests.
1621 2006-01-03 Brian Warner <warner@lothar.com>
1623 * buildbot/master.py (BuildMaster): remove the .schedulers
1624 attribute, replacing it with an allSchedulers() method that looks
1625 for all IService children that implement IScheduler. Having only
1626 one parent/child relationship means fewer opportunities for bugs.
1627 (BuildMaster.allSchedulers): new method
1628 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1629 also fix ugly bug that caused any config-file reload to
1630 half-forget about the earlier Schedulers, causing an exception
1631 when a Change arrived and was handed to a half-connected
1632 Scheduler. The exception was in scheduler.py line 54ish:
1633 self.parent.submitBuildSet(bs)
1634 exceptions.AttributeError: 'NoneType' object has no attribute
1636 (BuildMaster.addChange): update to use allSchedulers()
1638 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1639 to work properly with twisted-1.3.0, where you must explicitly
1640 include the __implements__ from parent classes
1641 (BaseScheduler.__repr__): make it easier to distinguish distinct
1643 (BaseUpstreamScheduler.__implements__): same
1645 * buildbot/status/builder.py (Status.getSchedulers): update to
1647 * buildbot/test/test_run.py (Run.testMaster): same
1648 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1649 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1650 make sure Scheduler instances are left alone when an identical
1651 config file is reloaded
1652 (ConfigElements.testSchedulers): make sure Schedulers are properly
1655 * Makefile (TRIALARGS): my local default Twisted version is now
1656 2.1.0, update the trial arguments accordingly
1658 2005-12-22 Brian Warner <warner@lothar.com>
1660 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1663 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1664 addChange in the parent class, although I suspect this should be
1665 fixed better in the future.
1667 2005-11-26 Brian Warner <warner@lothar.com>
1669 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1670 explode when branch==None, thanks to Kevin Turner for the catch
1671 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1674 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1676 * docs/buildbot.texinfo: same
1678 2005-11-26 Brian Warner <warner@lothar.com>
1680 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1681 * docs/buildbot.texinfo: set version number to match
1683 2005-11-26 Brian Warner <warner@lothar.com>
1685 * NEWS: update for 0.7.1
1687 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1688 sure that unsubscribe works even if we never sent an ETA update.
1689 Also, don't explode on duplicate unsubscribe.
1690 (BuildStepStatus.addLog): make the convenience "return self"-added
1691 watcher automatically unsubscribe when the Step finishes.
1692 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1693 (BuildStatus.stepStarted): same auto-unsubscribe
1694 (BuilderStatus.buildStarted): same auto-unsubscribe
1696 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1698 (IStatusReceiver.stepStarted): same
1699 (IStatusReceiver.logStarted): same
1701 * buildbot/test/test_run.py (Status): move the Status test..
1702 * buildbot/test/test_status.py (Subscription): .. to here
1704 2005-11-25 Brian Warner <warner@lothar.com>
1706 * NEWS: more updates
1708 * buildbot/locks.py: fix the problem in which loading a master.cfg
1709 file that changes some Builders (but not all of them) can result
1710 in having multiple copies of the same Lock. Now, the real Locks
1711 are kept in a table inside the BotMaster, and the Builders/Steps
1712 use "LockIDs", which are still instances of MasterLock and
1713 SlaveLock. The real Locks are instances of the new RealMasterLock
1714 and RealSlaveLock classes.
1715 * buildbot/master.py (BotMaster.getLockByID): new method to
1716 convert LockIDs into real Locks.
1717 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1718 into real Locks before building
1719 * buildbot/process/step.py (BuildStep.startStep): same
1720 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1721 exercises the problem
1724 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1725 what Schedulers are available
1727 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1728 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1729 'cron'-style build scheduling at certain times of day, week,
1731 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1733 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1734 handling: treat self.fileIsImportant more as an attribute that
1735 contains a callable than as a method. If the attribute is None,
1736 don't call it and assume all filenames are important. It is still
1737 possible to provide a fileIsImportant method in a subclass,
1739 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1741 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1742 test using AnyBranchScheduler with fileIsImportant=None
1744 2005-11-24 Brian Warner <warner@lothar.com>
1746 * buildbot/test/test_config.py (StartService): don't claim a fixed
1747 port number, instead set slavePort=0 on the first pass, figure out
1748 what port was allocated, then switch to a config file that uses
1751 * buildbot/master.py (BuildMaster.loadConfig): close the old
1752 slaveport before opening the new one, because unit tests might
1753 replace slavePort=0 with the same allocated portnumber, and if we
1754 don't wait for the old port to close first, we get a "port already
1755 in use" error. There is a tiny race condition here, but the only
1756 threat is from other programs that bind (statically) to the same
1757 port number we happened to be allocated, and only if those
1758 programs use SO_REUSEADDR, and only if they get control in between
1761 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1763 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1764 deleted ChangeSources before adding any new ones
1765 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1766 compare_attrs, to make sure that a config-file reload does not
1767 unnecessarily replace an unmodified ChangeSource instance
1768 * buildbot/test/test_config.py (ConfigTest.testSources): update
1770 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1771 mean "don't build anything", and add a warning if it gets used
1772 because it isn't actually useful.
1774 * contrib/svn_buildbot.py: update example usage to match the port
1775 number that gets used by the PBChangeSource
1776 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1778 2005-11-22 Brian Warner <warner@lothar.com>
1780 * NEWS: start collecting items for next release
1782 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1783 revisions are strings
1784 (P4Sync.computeSourceRevision): same
1786 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1787 to the Buildbot's overall status page
1788 (StatusResourceBuilder.body): same
1790 2005-11-15 Brian Warner <warner@lothar.com>
1792 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1793 config-file loading, specifically to make sure old StatusTargets
1794 are finished shutting down before new ones start up (thus
1795 resolving a bug in which changing the Waterfall object would fail
1796 because both new and old instances were claiming the same
1797 listening port). Also load new Schedulers after all the new
1798 Builders are set up, in case they fire off a new build right away.
1799 * buildbot/test/test_config.py (StartService): test it
1801 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1802 the branch name to the mail body
1804 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1805 Without it, a config-file reload fails to update an existing
1807 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1808 username/passwd to compare_attrs, for the same reason
1809 * buildbot/status/html.py (Waterfall): add favicon to
1810 compare_attrs, same reason
1812 2005-11-05 Brian Warner <warner@lothar.com>
1814 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1815 baserev before stuffing it in the jobfile. This resolves problems
1816 under SVN (and probably Arch) where revisions are expressed as
1817 numbers. I'm inclined to use string-based revisions everywhere in
1818 the future, but this fix should be safe for now. Thanks to Steven
1819 Walter for the patch.
1821 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1822 binary mode when opening pickle files, to make windows work
1823 better. Thanks to Dobes Vandermeer for the catch.
1824 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1825 (BuilderStatus.getBuildByNumber): same
1826 (Status.builderAdded): same
1827 * buildbot/master.py (BuildMaster.loadChanges): same
1829 * buildbot/util.py (Swappable): delete unused leftover code
1831 * buildbot/process/step.py (SVN): when building on a non-default
1832 branch, add the word "[branch]" to the VC step's description, so
1833 it is obvious that we're not building the usual stuff. Likewise,
1834 when we are building a specific revision, add the text "rNNN" to
1835 indicate what that revision number is. Thanks to Brad Hards and
1836 Nathaniel Smith for the suggestion.
1837 (Darcs.startVC): same
1838 (Arch.startVC): same
1839 (Bazaar.startVC): same
1841 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1842 typo, caught by Mark Dillavou, closes SF#1216636.
1844 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1845 about a test to add some day
1847 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1848 the 'full-2.3' build, and the 'reactors' build is now run under
1849 python-2.4 because the buildslave no longer has gtk/etc bindings
1850 for earlier versions.
1852 2005-11-03 Brian Warner <warner@lothar.com>
1854 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1855 method, takes an IBuildStatus and rebuilds it. It might make more
1856 sense to add this to IBuildControl instead, but that instance goes
1857 away completely once the build has finished, and resubmitting
1858 builds can take place weeks later.
1859 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1860 * buildbot/status/html.py (StatusResourceBuild): also stash an
1861 IBuilderControl so we can use resubmitBuild.
1862 (StatusResourceBuild.body): render "resubmit" button if we can.
1863 Also add hrefs for each BuildStep
1864 (StatusResourceBuild.rebuild): add action for "resubmit" button
1865 (StatusResourceBuilder.getChild): give it an IBuilderControl
1867 * buildbot/status/builder.py (Status.getURLForThing): change the
1868 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1869 that live as targets of buttons like "stop" and "rebuild" can't
1871 * buildbot/status/builder.py (Status.getURLForThing): same
1872 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1873 (StepBox.getBox): same
1874 * buildbot/test/test_web.py (GetURL): same
1877 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1878 exclusivity checks after Source.__init__ upcall, so misspelled
1879 arguments will be reported more usefully
1880 (Darcs.__init__): same
1882 2005-10-29 Brian Warner <warner@lothar.com>
1884 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1885 builder. Move the Try scheduler off to a separate port.
1887 2005-10-27 Brian Warner <warner@lothar.com>
1889 * buildbot/clients/gtkPanes.py
1890 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1891 to cause the app to crash, now they don't.
1893 * buildbot/clients/debug.py: display the buildmaster's location
1894 in the window's title bar
1896 2005-10-26 Brian Warner <warner@lothar.com>
1898 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1899 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1900 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1902 * buildbot/status/html.py (td): put a single non-breaking space
1903 inside otherwise empty <td> elements, as a workaround for buggy
1904 browsers which would optimize them away (along with any associated
1905 styles, like the kind that create the waterfall grid borders).
1906 Patch from Frerich Raabe.
1908 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1909 argv-list as an argument, defaulting to ["-to"], which is
1910 appropriate for the Trial that comes with Twisted-2.1.0 and
1911 earlier. The Trial in current Twisted SVN wants
1912 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1913 defaults to an empty list.
1914 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1915 match it, now that trialMode= is a list instead of a single string
1917 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1919 * docs/buildbot.texinfo: same
1921 2005-10-24 Brian Warner <warner@lothar.com>
1923 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1924 * docs/buildbot.texinfo: set version number to match
1926 2005-10-24 Brian Warner <warner@lothar.com>
1928 * README: update for 0.7.0
1930 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1932 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1933 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1934 send the branch= argument unless the user really provided one, to
1935 retain compatibility with older buildmasters that don't accept
1937 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1940 * docs/buildbot.texinfo: update lots of stuff
1942 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1943 to the 'buildbot sendchange' command
1944 * buildbot/clients/sendchange.py (Sender.send): same
1945 * buildbot/changes/pb.py (ChangePerspective): same
1946 * buildbot/test/test_changes.py (Sender.testSender): test it
1948 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1949 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1950 for consistency with other BuildStep arguments that use camelCase.
1951 Well, at least more of them use camelCase (like flunkOnWarnings)
1952 than don't.. I wish I'd picked one style and stuck with it
1953 earlier. Annoying, but it's best done before the release, since
1954 these arguments didn't exist at all in 0.6.6 .
1956 * buildbot/test/test_vc.py (SVN.testCheckout): same
1957 (Darcs.testPatch): same
1958 * docs/buildbot.texinfo (SVN): document the change
1959 (Darcs): same, add some build-on-branch docs
1960 * docs/examples/twisted_master.cfg: match change
1962 * buildbot/process/step.py (BuildStep): rename
1963 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1964 how it is normally used.
1965 * buildbot/test/test_steps.py (Version.checkCompare): same
1967 * buildbot/process/step.py (CVS.startVC): refuse to build
1968 update/copy -style builds on a non-default branch with an old
1969 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1970 concern is that it will do a VC 'update' in an existing tree when
1971 it is supposed to be switching branches (and therefore clobbering
1972 the tree to do a full checkout), thus building the wrong source.
1973 This used to be a warning, but I think the confusion it is likely
1974 to cause warrants making it an error.
1975 (SVN.startVC): same, also make mode=export on old slaves an error
1976 (Darcs.startVC): same
1977 (Git.startVC): improve error message for non-Git-enabled slaves
1978 (Arch.checkSlaveVersion): same. continue to emit a warning when a
1979 specific revision is built on a slave that doesn't pay attention
1980 to args['revision'], because for slowly-changing trees it will
1981 probably do the right thing, and because we have no way to tell
1982 whether we're asking it to build the most recent version or not.
1983 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
1985 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
1986 that 'master' is in host:portnum format, to catch errors sooner
1988 2005-10-23 Brian Warner <warner@lothar.com>
1990 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
1991 when creating the list of warning messages, include the line
1992 immediately after each WARNING: line, since that's usually where
1993 the file and line number wind up.
1995 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2000 2005-10-22 Brian Warner <warner@lothar.com>
2002 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2003 patch from Brad Hards
2004 * buildbot/status/classic.css: same
2005 * buildbot/test/test_web.py (Waterfall): match changes
2007 * buildbot/test/test_steps.py (BuildStep.setUp): set
2008 nextBuildNumber so the test passes
2009 * buildbot/test/test_status.py (MyBuilder): same
2011 * buildbot/status/html.py (StatusResourceBuild.body): revision
2012 might be numeric, so stringify it before html-escapifying it
2013 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2014 timer for the upcoming build
2015 * buildbot/status/classic.css: add background-color attributes for
2016 offline/waiting/building classes
2018 * buildbot/status/builder.py (BuildStatus): derive from
2019 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2020 the default (i.e. unknown) .slavename to "???" instead of None,
2021 since even unknown slavenames need to be printed eventually.
2022 (BuilderStatus): also derive from styles.Versioned . More
2023 importantly, determine .nextBuildNumber at creation/unpickling
2024 time by scanning the directory of saved BuildStatus instances and
2025 choosing one larger than the highest-numbered one found. This
2026 should fix the problem where random errors during upgrades cause
2027 the buildbot to forget about earlier builds. .nextBuildNumber is
2028 no longer stored in the pickle.
2029 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2030 at least log the error. Also call Builder.determineNextBuildNumber
2031 once the basedir is set.
2033 * buildbot/master.py (BuildMaster.loadChanges): do
2034 styles.doUpgrade afterwards, in case I decide to make Changes
2035 derived from styles.Versioned some day and forget to make this
2039 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2040 when running under older pythons (<2.3) in which the shlex module
2041 doesn't have a 'split' function.
2043 * buildbot/process/step.py (ShellCommand.start): make
2044 errorMessages= be a list of strings to stuff in the log before the
2045 command actually starts. This makes it easier to flag multiple
2046 warning messages, e.g. when the Source steps have to deal with an
2048 (CVS.startVC): handle slaves that don't handle multiple branches
2049 by switching into 'clobber' mode
2050 (SVN.startVC): same. Also reject branches without base_url
2051 (Darcs.startVC): same. Also reject revision= in older slaves
2052 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2053 (Bazaar.startVC): same, and test for baz separately than for arch
2055 * buildbot/slave/commands.py (cvs_ver): document new features
2057 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2058 (BuildStep.slaveVersionNewEnough): more useful utility method
2059 * buildbot/test/test_steps.py (Version): start testing it
2061 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2062 the 'force' command requires python2.3, for the shlex.split method
2064 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2065 since we don't use it anymore. The Twisted buildbot uses a
2068 2005-10-21 Brian Warner <warner@lothar.com>
2070 * buildbot/process/process_twisted.py: rework all BuildFactory
2071 classes to take a 'source' step as an argument, instead of
2072 building up the SVN instance in the factory.
2073 * docs/examples/twisted_master.cfg: enable build-on-branch by
2074 providing a base_url and default_branch
2076 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2077 control over --branch and --revision, not that they are always
2079 * buildbot/status/html.py (StatusResourceBuilder.force): same
2080 (StatusResourceBuild.body): display SourceStamp components
2082 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2083 IRC 'force' command, so it can be shared with an eventual
2084 command-line-tool 'buildbot force' mode.
2085 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2087 2005-10-20 Brian Warner <warner@lothar.com>
2089 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2091 * docs/examples/twisted_master.cfg: update to use Schedulers
2093 * buildbot/scripts/sample.cfg: update with Schedulers
2095 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2096 method specifically for use by HTML "force build" button and the
2097 IRC "force" command. Raises an immediate error if there are no
2099 (IBuilderControl.requestBuild): make this just submit a build, not
2100 try to check for existing slaves or set up any when-finished
2101 Deferreds or anything.
2102 * buildbot/process/builder.py (BuilderControl): same
2103 * buildbot/status/html.py (StatusResourceBuilder.force): same
2104 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2105 * buildbot/test/test_slaves.py: same
2106 * buildbot/test/test_web.py: same
2108 2005-10-19 Brian Warner <warner@lothar.com>
2110 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2111 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2113 2005-10-18 Brian Warner <warner@lothar.com>
2115 * buildbot/status/html.py: provide 'status' argument to most
2116 StatusResourceFOO objects
2117 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2118 and Logfiles" section to make the Build page into a more-or-less
2119 comprehensive source of status information about the build
2121 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2122 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2124 2005-10-17 Brian Warner <warner@lothar.com>
2126 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2127 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2128 out what to do about other projects: the correct options for
2129 recent Twisteds will not work for older ones.
2131 2005-10-15 Brian Warner <warner@lothar.com>
2133 * buildbot/status/builder.py (Status.getURLForThing): add method
2134 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2135 use this in email/IRC status clients to make them more useful, by
2136 providing the end user with hints on where to learn more about the
2137 object being reported on.
2138 * buildbot/test/test_web.py (GetURL): tests for it
2140 2005-10-14 Brian Warner <warner@lothar.com>
2142 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2143 fix bug resulting from deferredResult changes
2145 2005-10-13 Brian Warner <warner@lothar.com>
2147 * buildbot/test/test_changes.py: remove use of deferredResult
2148 * buildbot/test/test_config.py: same
2149 * buildbot/test/test_control.py: same
2150 * buildbot/test/test_status.py: same
2151 * buildbot/test/test_vc.py: this is the only remaining use, since
2152 it gets used at module level. This needs to be replaced by some
2153 sort of class-level run-once routine.
2155 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2157 * lots: implement multiple slaves per Builder, which means multiple
2158 current builds per Builder. Some highlights:
2159 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2160 of (state,currentBuilds) instead of (state,currentBuild)
2161 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2162 (IBuildStatus.getSlavename): new method, so you can tell which
2163 slave got used. This only gets set when the build completes.
2164 (IBuildRequestStatus.getBuilds): new method
2166 * buildbot/process/builder.py (SlaveBuilder): add a .state
2167 attribute to track things like ATTACHING and IDLE and BUILDING,
2169 (Builder): .. the .slaves attribute here, which has been turned
2170 into a simple list of available slaves. Added a separate
2171 attaching_slaves list to track ones that are not yet ready for
2173 (Builder.fireTestEvent): put off the test-event callback for a
2174 reactor turn, to make tests a bit more consistent.
2175 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2176 ping fails due to an exception. This needs work, I'm worried that
2177 a code error could lead to a constantly re-connecting slave.
2178 Especially since I'm trying to move to a distinct remote_ping
2179 method, separate from the remote_print that we currently use.
2180 (BuilderControl.requestBuild): return a convenience Deferred that
2181 provides an IBuildStatus when the build finishes.
2182 (BuilderControl.ping): ping all connected slaves, only return True
2183 if they all respond.
2185 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2186 reconnect when we shut down.
2188 * buildbot/status/builder.py: implement new methods, convert
2189 one-build-at-a-time methods to handle multiple builds
2190 * buildbot/status/*.py: do the same in all default status targets
2191 * buildbot/status/html.py: report the build's slavename in the
2192 per-Build page, report all buildslaves on the per-Builder page
2194 * buildbot/test/test_run.py: update/create tests
2195 * buildbot/test/test_slaves.py: same
2196 * buildbot/test/test_scheduler.py: remove stale test
2198 * docs/buildbot.texinfo: document the new builder-specification
2199 'slavenames' parameter
2201 2005-10-12 Brian Warner <warner@lothar.com>
2203 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2204 report failure correctly, causing Dependent builds to run when
2205 they shouldn't have.
2206 * buildbot/status/builder.py (BuildSetStatus): same
2207 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2208 (Set.testSuccess): test the both-pass case too
2209 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2210 fix this test: it was ending too early, masking the failure before
2211 (Logger): specialized StatusReceiver to make sure the dependent
2212 builds aren't even started, much less completed.
2214 2005-10-07 Brian Warner <warner@lothar.com>
2216 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2217 bot.SlaveBuilder being disowned in the middle of a build
2219 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2220 this inherit from StatusReceiver. Also upcall in __init__. This
2221 fixes the embarrasing crash when the new buildSetSubmitted method
2222 is invoked and Waterfall/etc don't implement their own.
2223 * buildbot/test/test_run.py: add a TODO note about a test to catch
2224 just this sort of thing.
2226 * buildbot/process/builder.py (Builder.attached): remove the
2227 already-attached warning, this situation is normal. Add some
2228 comments explaining it.
2230 2005-10-02 Brian Warner <warner@lothar.com>
2232 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2233 OverflowError when setting up dnotify, because some 64-bit systems
2234 have problems with signed-vs-unsigned constants and trip up on the
2235 DN_MULTISHOT flag. Patch from Brad Hards.
2237 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2239 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2240 progressMetrics, description, descriptionDone to the 'parms' list,
2241 and make use the 'parms' list from the implementation class
2242 instead of only BuildStep to initialize the parameters. This
2243 allows buildbot.process.factory.s() to initialize all the parms,
2244 not just those defined in directly by BuildStep.
2246 2005-09-03 Brian Warner <warner@lothar.com>
2248 * NEWS: start adding items for the next release
2250 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2251 python2.2 tests, change 'Quick' builder to only use python2.3
2253 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2255 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2256 the "Ping Builder" button if the build control is available; the
2257 user sees an exception otherwise
2259 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2261 2005-09-01 Brian Warner <warner@lothar.com>
2263 * buildbot/interfaces.py (IBuilderStatus.getState): update
2264 signature, point out that 'build' can be None
2265 (IBuildStatus.getETA): point out ETA can be none
2267 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2269 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2271 2005-08-31 Brian Warner <warner@lothar.com>
2273 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2274 update to match correct signature: removed 'eta' argument
2275 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2277 2005-08-30 Brian Warner <warner@lothar.com>
2279 * buildbot/status/builder.py (LogFile): remove the assertion that
2280 blows up when you try to overwrite an existing logfile, instead
2281 just emit a warning. This case gets hit when the buildmaster is
2282 killed and doesn't get a chance to write out the serialized
2283 BuilderStatus object, so the .nextBuildNumber attribute gets out
2286 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2287 the 'buildbot sendchange' arguments, for the Darcs context file
2288 * docs/buildbot.texinfo (sendchange): document it
2290 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2291 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2292 (IStatus.getSchedulers): new method
2293 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2294 (Status.getSchedulers): implement
2295 * buildbot/process/builder.py (Builder): maintain
2296 BuilderStatus.pendingBuilds
2297 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2298 (TryBase.addChange): Try schedulers should ignore Changes
2300 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2301 for 'try' on CVS/SVN
2302 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2304 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2305 report status properly.
2306 (Try.createJob): implement unique buildset IDs
2308 * buildbot/status/client.py (StatusClientPerspective): add a
2309 perspective_getBuildSets method for the benefit of jobdir-style
2311 * docs/buildbot.texinfo (try): more docs
2312 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2315 2005-08-18 Brian Warner <warner@lothar.com>
2317 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2318 actually work. It's functional but still kind of clunky. Also, it
2319 only works with the pb-style.. needs to be made to work with the
2322 * buildbot/status/client.py (RemoteBuildSet): new class
2323 (RemoteBuildRequest): same
2324 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2325 object, not the internal BuildStatus object.
2326 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2327 outside of the usual buildStarted() return value.
2328 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2330 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2331 (Try_Userpass_Perspective.perspective_try): return a remotely
2332 usable BuildSetStatus object
2334 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2335 isStarted()/waitUntilStarted()
2337 2005-08-16 Brian Warner <warner@lothar.com>
2339 * buildbot/status/builder.py: implement IBuildSetStatus and
2340 IBuildRequestStatus, wire them into place.
2341 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2342 methods into the BuildSetStatus object.
2343 * buildbot/interfaces.py: same
2344 (IStatus.getBuildSets): new method to get pending BuildSets
2345 (IStatusReceiver.buildsetSubmitted): new method which hears about
2347 * buildbot/master.py (BuildMaster.submitBuildSet): same
2348 * buildbot/process/base.py (BuildRequest): same, replace
2349 waitUntilStarted with subscribe/unsubscribe
2350 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2351 subscribe instead of waitUntilStarted
2352 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2354 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2356 * buildbot/test/test_buildreq.py: update for new code
2357 * buildbot/test/test_control.py (Force.testRequest): same
2360 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2361 for Darcs to not use the tempfile module, so it works under
2362 python-2.2 too. We really didn't need the full cleverness of that
2363 module, since the slave has exclusive control of its own builddir.
2365 2005-08-15 Brian Warner <warner@lothar.com>
2367 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2368 for CVS trees. It doesn't work for non-trunk branches,
2370 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2373 * Makefile: make it easier to test against python2.2
2375 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2376 tearDown2, so things like Arch can unregister archives as they're
2377 shutting down. The previous subclass-override-tearDown technique
2378 resulted in a nested maybeWait() and test failures under
2381 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2382 where we can (Arch), add a branch= argument to set the branch used
2384 (BazExtractor): extract the branch too
2385 (TlaExtractor): same
2386 * buildbot/scripts/runner.py (TryOptions): add --branch
2387 * docs/buildbot.texinfo (try): document --branch/try_branch
2389 * buildbot/slave/commands.py (Darcs): implement get-revision for
2390 Darcs, so that 'try' will work. This requires the tempfile module
2393 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2394 of revisions, branches, and 'try' in the process.
2396 2005-08-11 Brian Warner <warner@lothar.com>
2398 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2399 this, it got broken at some point in the last few releases
2400 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2401 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2402 specifically the removal of ETA information from the tuple
2404 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2407 * docs/buildbot.texinfo (try): document both --builder and
2408 'try_builders' in .buildbot/options
2409 * buildbot/scripts/runner.py (TryOptions): add --builder,
2410 accumulate the values into opts['builders']
2411 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2412 * buildbot/test/test_runner.py (Try): add some quick tests to make
2413 sure 'buildbot try --options' and .buildbot/options get parsed
2414 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2415 use --builder control
2417 * docs/buildbot.texinfo (try): add --port argument to PB style
2419 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2420 actual SourceStamp. Still need to extract a branch name, somehow.
2421 (Try): finish implementing the try client side, still need a UI
2422 for specifying which builders to use
2423 (Try.getopt): factor our options/config-file reading
2424 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2426 * buildbot/test/test_vc.py: match SourceStampExtractor change
2428 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2429 causes the twisted log to be sent to stderr
2431 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2433 2005-08-10 Brian Warner <warner@lothar.com>
2435 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2436 style is 90% done, still missing status reporting or waiting for
2437 the buildsets to finish, and it is completely untested.
2439 * buildbot/trybuild.py: delete file, move contents to ..
2440 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2441 * buildbot/test/test_vc.py: match the move
2443 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2444 of the TryScheduler, no buildsetID or status-tracking support yet
2445 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2447 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2448 possible to set the basedir after __init__ time, so it is easier
2449 to use as a Service-child of the BuildMaster instance
2451 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2452 that delivers messages to its Service parent instead of requiring
2453 a subclass to be useful. This turns out to be much easier to build
2456 * buildbot/scripts/tryclient.py (createJob): utility code to
2457 create jobfiles, will eventually be used by 'buildbot try'
2459 2005-08-08 Brian Warner <warner@lothar.com>
2461 * docs/buildbot.texinfo (try): add docs on the
2462 as-yet-unimplemented Try scheduler
2464 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2465 * buildbot/test/test_scheduler.py: .. here
2466 (Scheduling.testTryJobdir): add placeholder test for 'try'
2468 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2469 addEntry merging (>=chunkSize) behavior
2470 (Log.testConsumer): update to handle new callLater(0) behavior
2472 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2473 both the MAX_LENGTH bugfix and the resumeProducing hang.
2475 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2476 put off the actual resumeProducing for a moment with
2477 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2478 causes large logfiles to hang midway through.
2480 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2481 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2482 and to improve memory usage when streaming the file out to a web
2484 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2485 make this work cleanly
2487 2005-08-03 Brian Warner <warner@lothar.com>
2489 * buildbot/trybuild.py: new file for 'try' utilities
2490 (getSourceStamp): run in a tree, find out the baserev+patch
2491 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2492 implemented for SVN and Darcs, still working on Arch. I don't know
2493 how to make CVS work yet.
2495 * docs/buildbot.texinfo: document the 'buildbot' command-line
2496 tool, including the not-yet-implemented 'try' feature, and the
2497 in-flux .buildbot/ options directory.
2499 2005-07-20 Brian Warner <warner@lothar.com>
2501 * buildbot/locks.py: added temporary id() numbers to Lock
2502 descriptions, to track down a not-really-sharing-the-Lock bug
2504 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2506 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2507 needed for python2.2 compatibility
2508 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2509 are from the __future__
2511 2005-07-19 Brian Warner <warner@lothar.com>
2513 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2514 message when schedulers use unknown builders
2516 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2517 SlaveLock('name') and MasterLock('name') are distinct
2519 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2520 c['schedulers'] in such a way that we can actually accept
2522 * buildbot/test/test_config.py: check it
2524 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2525 utility method to *all* the Schedulers
2526 (Periodic.listBuilderNames): same
2528 * docs/buildbot.texinfo (Interlocks): update chapter to match
2531 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2532 to make sure that c['sources'], c['schedulers'], and c['status']
2533 are all lists of the appropriate objects, and that the Schedulers
2534 all point to real Builders
2535 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2536 'listBuilderNames' utility method to support this
2537 * buildbot/scheduler.py: implement the utility method
2538 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2540 * docs/buildbot.texinfo: add some @cindex entries
2542 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2543 if it wasn't already set: most tla commands will fail unless one
2545 (Arch.createRepository): and disable bazaar's revision cache, since
2546 they cause test failures (the multiple repositories we create all
2547 interfere with each other through the cache)
2549 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2550 bring it properly up to date with twisted-2.0 test guidelines
2552 * buildbot/master.py (BuildMaster): remove references to old
2553 'interlock' module, this caused a bunch of post-merge test
2555 * buildbot/test/test_config.py: same
2556 * buildbot/process/base.py (Build): same
2558 * buildbot/test/test_slaves.py: stubs for new test case
2560 * buildbot/scheduler.py: add test-case-name tag
2561 * buildbot/test/test_buildreq.py: same
2563 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2564 unnecessary init code
2565 (Bot.remote_setBuilderList): match it
2567 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2569 * buildbot/changes/mail.py (parseSyncmail): update comment
2571 * buildbot/test/test_slavecommand.py: disable Shell tests on
2572 platforms that don't suport IReactorProcess
2574 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2575 all places where we open logfiles. It causes OS-X to open the file
2576 in some weird mode that that prevents us from mixing reads and
2577 writes to the same filehandle, which we depend upon to implement
2578 _generateChunks properly. This change doesn't appear to break
2579 win32, on which "b" and "t" are treated differently but a missing
2580 flag seems to be interpreted as "t".
2582 2005-07-18 Brian Warner <warner@lothar.com>
2584 * buildbot/slave/commands.py (ShellCommand): overhaul
2585 error-handling code, to try and make timeout/interrupt work
2586 properly, and make win32 happier
2587 * buildbot/test/test_slavecommand.py: clean up, stop using
2588 reactor.iterate, add tests for timeout and interrupt
2589 * buildbot/test/sleep.py: utility for a new timeout test
2591 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2592 code from the local-usebranches branch
2594 2005-07-17 Brian Warner <warner@lothar.com>
2596 * buildbot/process/process_twisted.py
2597 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2598 minutes, to match the other twisted BuildFactories, and don't
2599 excuse failures in c/qt/win32 reactors any more.
2601 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2602 'freebsd' builders, since the buildslaves have been unavailable
2605 2005-07-13 Brian Warner <warner@lothar.com>
2607 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2608 build-on-branch feature
2610 * buildbot/process/step.py (Darcs.__init__): add base_url and
2611 default_branch arguments, just like SVN
2612 (Arch.__init__): note that the version= argument is really the
2615 * buildbot/slave/commands.py (SourceBase): keep track of the
2616 repository+branch that was used for the last checkout in
2617 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2618 match, we clobber the directory and perform a fresh checkout
2619 rather than trying to do an in-place update. This should protect
2620 us against trying to get to branch B by doing an update in a tree
2621 obtained from branch A.
2622 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2623 (SVN.setup): same, just the svnurl
2624 (Darcs.setup): same, just the repourl
2625 (Arch.setup): same, arch coordinates (url), version, and
2626 buildconfig. Also pull the buildconfig from the args dictionary,
2627 which we weren't doing before, so the build-config was effectively
2629 (Arch.sourcedirIsUpdateable): don't try to update when we're
2630 moving to a specific revision: arch can't go backwards, so it is
2631 safer to just clobber the tree and checkout a new one at the
2633 (Bazaar.setup): same sourcedata as Arch
2635 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2636 use maybeWait, to work with twisted-1.3.0 and twcompat
2637 (Dependencies.testRun_Pass): same
2639 * buildbot/test/test_vc.py: rearrange, cleanup
2641 * buildbot/twcompat.py: add defer.waitForDeferred and
2642 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2643 can work under twisted-1.3.0 .
2645 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2646 now created at setUp time. This increases the runtime of the test
2647 suite considerably (from 91 seconds to 151), but it removes the
2648 need for an offline tarball, which should solve a problem I've
2649 seen where the test host has a different version of svn than the
2650 tarball build host. The new code also validates that mode=update
2651 really picks up recent commits. This approach will also make it
2652 easier to test out branches, because the code which creates the VC
2653 branches is next to the code which uses them. It will also make it
2654 possible to test some change-notification hooks, by actually
2655 performing a VC commit and watching to see the ChangeSource get
2658 2005-07-12 Brian Warner <warner@lothar.com>
2660 * docs/buildbot.texinfo (SVN): add branches example
2661 * docs/Makefile (buildbot.ps): add target for postscript manual
2663 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2664 * buildbot/test/test_locks.py: same
2666 * buildbot/process/step.py (Darcs): comment about default branches
2668 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2669 c['interlocks'] in the config file, complain if it is present.
2670 Scan all locks in c['builders'] to make sure the Locks they use
2672 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2673 add some tests to check for non-uniquely-named Locks
2674 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2675 since the unique-Lock validation code requires it now
2677 * buildbot/locks.py: fix test-case-name
2679 * buildbot/interlock.py: remove old file
2681 2005-07-11 Brian Warner <warner@lothar.com>
2683 * buildbot/test/test_interlock.py: rename to..
2684 * buildbot/test/test_locks.py: .. something shorter
2686 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2687 versions (after 2.0.1) changed internet.TCPClient to shut down the
2688 connection in stopService. Change the code to handle this
2691 * buildbot/process/base.py (Build): handle whole-Build locks
2692 * buildbot/process/builder.py (Builder.compareToSetup): same
2693 * buildbot/test/test_interlock.py: make tests work
2695 * buildbot/process/step.py (BuildStep.startStep): complain if a
2696 Step tries to claim a lock that's owned by its own Build
2697 (BuildStep.releaseLocks): typo
2699 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2700 file reloads don't replace unchanged Builders
2702 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2703 rewrite to cover new Locks instead of old c['interlocks']
2704 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2708 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2709 start the master and connect the buildslave
2711 * buildbot/process/step.py (FailingDummy.done): finish with a
2712 FAILURE status rather than raising an exception
2714 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2715 stringify a BuildRequest.reason that is None
2717 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2719 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2720 allow scheduler.Dependent to work
2721 * buildbot/buildset.py (BuildSet): set .reason and .results
2723 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2724 slaves, to make the test stop hanging. It still fails, of course,
2725 because I haven't even started to implement Locks.
2727 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2729 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2730 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2731 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2732 (Dependent): new class for downstream build dependencies
2733 * buildbot/test/test_dependencies.py: tests (still failing)
2735 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2737 2005-07-07 Brian Warner <warner@lothar.com>
2739 * buildbot/test/runutils.py (RunMixin): factored this class out..
2740 * buildbot/test/test_run.py: .. from here
2741 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2742 added new buildbot.locks tests (which all hang right now)
2743 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2744 * buildbot/process/step.py: claim/release per-BuildStep locks
2746 * docs/Makefile: add 'buildbot.html' target
2748 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2749 interpreted as "HEAD", so that all VC steps can accept branch=None
2750 and have it mean the "default branch".
2752 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2754 2005-07-07 Brian Warner <warner@lothar.com>
2756 * docs/examples/twisted_master.cfg: update to match current usage
2758 * docs/buildbot.texinfo (System Architecture): comment out the
2759 image, it doesn't exist yet and just screws up the HTML manual.
2761 2005-07-05 Brian Warner <warner@lothar.com>
2763 * debian/.cvsignore: oops, missed one. Removing leftover file.
2765 2005-06-17 Brian Warner <warner@lothar.com>
2767 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2768 changed its output in 1.2.0, don't mistakenly think that the
2769 subversion we find isn't capable of supporting our tests.
2771 * debian/*: remove the debian/ directory and its contents, to make
2772 life easier for the proper Debian maintainer
2774 * Makefile (release): same
2776 2005-06-07 Brian Warner <warner@lothar.com>
2778 * everything: create a distinct SourceStamp class to replace the
2779 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2780 Changed the signature of Source.startVC to include the revision
2781 information (instead of passing it through self.args). Implement
2782 branches for SVN (now only Darcs/Git is missing support). Add more
2785 2005-06-06 Brian Warner <warner@lothar.com>
2787 * everything: rearrange build scheduling. Create a new Scheduler
2788 object (configured in c['schedulers'], which submit BuildSets to a
2789 set of Builders. Builders can now use multiple slaves. Builds can
2790 be run on alternate branches, either requested manually or driven
2791 by changes. This changed some of the Status classes. Interlocks
2792 are out of service until they've been properly split into Locks
2793 and Dependencies. treeStableTimer, isFileImportant, and
2794 periodicBuild have all been moved from the Builder to the
2796 (BuilderStatus.currentBigState): removed the 'waiting' and
2797 'interlocked' states, removed the 'ETA' argument.
2799 2005-05-24 Brian Warner <warner@lothar.com>
2801 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2802 erroneously abandons the connection (in clientConnectionFailed)
2803 for non-UserErrors, which means that if we lose the connection due
2804 to a network problem or a timeout, we'll never try to reconnect.
2805 Fix this by not upcalling to the buggy parent method. Note:
2806 twisted-2.0 fixes this, but the function only has 3 lines so it
2807 makes more sense to copy it than to try and detect the buggyness
2808 of the parent class. Fixes SF#1207588.
2810 * buildbot/changes/changes.py (Change.branch): doh! Add a
2811 class-level attribute to accomodate old Change instances that were
2812 pickled before 0.6.5 (where .branch was added for new Changes).
2813 This fixes the exception that occurs when you try to look at an
2814 old Change (through asHTML).
2816 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2819 2005-05-23 Brian Warner <warner@lothar.com>
2821 * buildbot/__init__.py (version): release 0.6.6
2823 2005-05-23 Brian Warner <warner@lothar.com>
2825 * NEWS: update for 0.6.6 release
2826 * debian/changelog: same
2828 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2829 before starting: this was done by twistd back when we spawned it,
2830 now that we're importing the pieces and running them in the
2831 current process, we have to do it ourselves. This allows
2832 master.cfg to import files from the same directory without
2833 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2834 Stichele for the catch.
2835 (Options.opt_version): Add a --version command (actually, just make
2836 the existing --version command emit Buildbot's version too)
2838 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2839 fix to make this behave like other LogFiles, this time to handle
2840 existing LogFiles on disk. (add the missing .upgrade method)
2841 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2843 2005-05-21 Brian Warner <warner@lothar.com>
2845 * buildbot/test/test_runner.py (Create.testMaster): match the
2846 rawstring change in runner.py:masterTAC
2848 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2849 TwistedWords is installed
2850 * buildbot/test/test_status.py: same, with TwistedMail
2852 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2853 some old, deprecated, and removed config keys). This should enable
2854 you to use the base buildbot functionality with Twisted-2.0.0 when
2855 you don't also have TwistedWeb and TwistedWords installed
2857 2005-05-20 Brian Warner <warner@lothar.com>
2859 * buildbot/scripts/runner.py (run): call sendchange(), not
2860 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2861 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2862 (stop): don't wait for process to die when sending SIGHUP
2863 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2864 directory name gets interpreted, which you don't want
2867 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2870 2005-05-18 Brian Warner <warner@lothar.com>
2872 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2874 2005-05-18 Brian Warner <warner@lothar.com>
2876 * README: update for 0.6.5
2877 * debian/changelog: same
2879 * buildbot/changes/changes.py: rename tag= to branch=, since
2880 that's how we're using it, and my design for the upcoming "build a
2881 specific branch" feature wants it. also, tag= was too CVS-centric
2882 * buildbot/changes/mail.py (parseSyncmail): same
2883 * buildbot/process/base.py (Build.isBranchImportant): same
2884 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2885 * docs/buildbot.texinfo (Attributes of Changes): same
2887 * NEWS: update tag=, update for upcoming release
2889 2005-05-17 Brian Warner <warner@lothar.com>
2891 * buildbot/scripts/runner.py (stop): actually poll once per
2892 second, instead of re-killing the poor daemon once per second.
2893 Sleep briefly (0.1s) before the first poll, since there's a good
2894 chance we can avoid waiting the full second if the daemon shuts
2895 down quickly. Also remove the sys.exit() at the end.
2896 (start): remove the unneighborly sys.exit()
2898 * Makefile: improve permission-setting to not kick Arch so badly
2900 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2901 default --keepalive=600, since it doesn't hurt very much, and it's
2902 a hassle to discover that you need it.
2903 * buildbot/test/test_runner.py (Create.testSlave): test it
2905 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2906 IRC bot about EXCEPTION
2908 * buildbot/status/client.py (PBListener): upcall more correctly
2910 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2911 an exception mark the overall build with EXCEPTION, not SUCCESS
2913 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2915 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2916 * Makefile: update some release-related stuff
2918 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2919 gets called when there isn't actually an active process, just end
2920 the Command instead of blowing up. I don't know how it gets into
2921 this state, but the twisted win32 buildslave will sometimes hang,
2922 and when it shakes its head and comes back, it thinks it's still
2923 running a Command. The next build causes this command to be
2924 interrupted, but the lack of self.process.pid breaks the interrupt
2927 * NEWS: document changes since the last release
2929 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2930 look for Makefile.buildbot instead of a bare Makefile . The
2931 'buildbot start' does not install this file, so you have to
2932 manually copy it if you want to customize startup behavior.
2933 (createMaster): change 'buildbot master' command to create
2934 Makefile.sample instead of Makefile, to create master.cfg.sample
2935 instead of master.cfg (requiring you to copy it before the
2936 buildmaster can be started). Both sample files are kept up to
2937 date, i.e. they are overwritten if they have been changed. The
2938 'buildbot.tac' file is *not* overwritten, but if the new contents
2939 don't match the old, a 'buildbot.tac.new' file is created and the
2940 user is warned. This seems to be a much more sane way to handle
2941 startup files. Also, don't sys.exit(0) when done, so we can run
2942 unit tests against it.
2943 (createSlave): same. Don't overwrite the sample info/ files.
2944 * buildbot/scripts/sample.mk: remove. the contents were pulled
2945 into runner.py, since they need to match the behavior of start()
2949 * docs/buildbot.texinfo (Launching the daemons): document it
2950 * buildbot/test/test_runner.py (Create): test it
2952 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2953 version that can handle string-in-string tests, because otherwise
2954 python-2.2 fails the tests. It'd be tremendous if Trial's test
2955 took two strings under 2.2 too.
2957 * everything: fixed all deprecation warnings when running against
2958 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2959 few that come from Twisted itself). This involved putting most of
2960 the Twisted-version specific code in the new buildbot.twcompat
2961 module, and creating some abstract base classes in
2962 buildbot.changes.base and buildbot.status.base (which might be
2963 useful anyway). __implements__ is a nuisance and requires an ugly
2964 'if' clause everywhere.
2966 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2967 delay before finishing the test: it seems that smtp.sendmail
2968 doesn't hang up on the server, so we must wait a moment so it can
2969 hang up on us. This removes the trial warning about an unclean
2972 2005-05-16 Brian Warner <warner@lothar.com>
2974 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2975 tuple of (delay, repeats).
2976 * buildbot/test/test_vc.py (Retry): test it
2977 * docs/buildbot.texinfo (Source Checkout): document it
2978 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
2979 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
2980 doVCFull() are handled by re-trying the checkout (after a delay)
2981 some number of times.
2982 (ShellCommand._startCommand): make header lines easier to read
2984 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
2986 (WebTest.test_logfile): make sure master gets shut down, silences
2987 some "unclean reactor" test errors
2989 * buildbot/test/test_changes.py (Sender.tearDown): spin the
2990 reactor once after shutdown, something in certain versions of
2991 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
2992 fails, svn-trunk is ok.
2994 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
2995 second win32 error message
2997 * buildbot/test/test_run.py (Status.testSlave): be smarter about
2998 validating the ETA, so the tests don't fail on slow systems
3000 2005-05-15 Brian Warner <warner@lothar.com>
3002 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3003 the new LogFile class, so upgrading works properly
3004 (LogFileProducer.resumeProducing): survive resumeProducing after
3005 we've exhausted the chunkGenerator
3007 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3009 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3010 (Log.testUpgrade): same
3012 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3013 Builds and logs with a cron job.
3015 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3016 of the old non-offline LogFile, added code to upgrade these to
3017 new-style contents-live-on-disk instances at load time (in a way
3018 that doesn't invalidate the old Build pickles, so upgrading to
3019 0.6.5 is not a one-way operation). Got rid of everything related
3021 (LogFile.__init__): create LogFiles with the parent step status,
3022 the log's name, and a builder-relative filename where it can keep
3023 the contents on disk.
3024 (LogFile.hasContents): new method, clients are advised to call it
3025 before getText or getChunks and friends. If it returns False, the
3026 log's contents have been deleted and getText() will raise an
3028 (LogFile.getChunks): made it a generator
3029 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3030 Consumer (except one that takes chunks instead of strings). This
3031 enables streaming of very large logfiles without storing the whole
3033 (BuildStatus.generateLogfileName): create names like
3034 12-log-compile-output, with a _0 suffix if required to be unique
3035 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3036 or earlier) logfiles into new-style ones
3037 (BuilderStatus): remove everything related to 'stub' builds. There
3038 is now only one build cache, and we don't strip logs from old
3040 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3041 since we no longer fight to keep it in the cache
3043 * buildbot/status/html.py (TextLog.render_GET): use a
3044 ChunkConsumer to stream the log entries efficiently.
3045 (ChunkConsumer): wrapper which consumes chunks and writes
3048 * buildbot/test/test_twisted.py (Parse.testParse): use a
3049 LogFile-like object instead of a real one
3051 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3052 (Log.testMerge3): validate more merge behavior
3053 (Log.testChunks): validate LogFile.getChunks
3054 (Log.testUpgrade): validate old-style LogFile upgrading
3055 (Log.testSubscribe): validate LogFile.subscribe
3056 (Log.testConsumer): validate LogFile.subscribeConsumer
3058 * buildbot/interfaces.py (IStatusLogStub): remove
3059 (IStatusLog.subscribeConsumer): new method
3060 (IStatusLog.hasContents): new method
3061 (IStatusLogConsumer): describes things passed to subscribeConsumer
3063 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3064 the log contents if it does not have any contents.
3065 (StatusResourceBuildStep.body): same
3066 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3068 2005-05-14 Brian Warner <warner@lothar.com>
3070 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3071 timeouts to try and make the windows metabuildslave not hang
3073 2005-05-13 Mike Taylor <bear@code-bear.com>
3075 * buildbot/slave/commands.py (rmdirRecursive): added a check
3076 to ensure the path passed into rmdirRecursive actually exists.
3077 On win32 a non-existant path would generate an exception.
3079 2005-05-13 Brian Warner <warner@lothar.com>
3081 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3082 shutil.rmtree which behaves correctly on windows in the face of
3083 files that you have to chmod before deleting. Thanks to Bear at
3084 the OSAF for the routine.
3085 (SourceBase.doClobber): use rmdirRecursive
3087 2005-05-12 Brian Warner <warner@lothar.com>
3089 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3090 method generate chunks instead of returning a big list. This
3091 allows the same method to be used for both old LogFile and new
3093 (OfflineLogFile.getText): use the generator
3094 (OfflineLogFile.subscribe): same
3095 * buildbot/status/html.py (TextLog.resumeProducing): same
3096 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3098 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3099 point out that OfflineLogFile does not currently work with
3100 html.Waterfall . Fixing this is high-priority.
3102 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3103 apparently windows defaults to using stdout
3105 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3106 better message on failure so I can figure out the win32 problem
3108 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3109 log messages to include more useful copies of the command being
3110 run, the argv array, and the child command's environment.
3111 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3113 2005-05-11 Brian Warner <warner@lothar.com>
3115 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3117 * Makefile: update the deb-snapshot version
3119 * docs/buildbot.texinfo: move all .xhtml docs into a new
3120 .texinfo-format document, adding a lot of material in the process.
3121 This is starting to look like a real user's manual. Removed all
3122 the Lore-related files: *.xhtml, *.css, template.tpl .
3123 * docs/Makefile: simple makefile to run 'makeinfo'
3124 * buildbot/scripts/sample.cfg: rearrange slightly
3125 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3127 2005-05-10 Brian Warner <warner@lothar.com>
3129 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3130 different name for the internal twistw module, handle it.
3132 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3133 * setup.py: .. and stop trying to install it
3135 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3136 'git'), the new linux kernel VC system (http://kernel.org/git/).
3137 Thanks to Brandon Philips for the patch.
3138 * buildbot/slave/commands.py (Git): same
3140 2005-05-06 Brian Warner <warner@lothar.com>
3142 * buildbot/status/builder.py (OfflineLogFile): replace the default
3143 LogFile with a form that appends its new contents to a disk file
3144 as they arrive. The complete log data is never kept in RAM. This
3145 is the first step towards handling very large (100MB+) logfiles
3146 without choking quite so badly. (The other half is
3147 producer/consumer on the HTML pages).
3148 (BuildStepStatus.addLog): use OfflineLogFile by default
3149 (BuildStatus.getLogfileName): helper code to give the
3150 OfflineLogFile a filename to work with
3152 * buildbot/test/test_status.py (Results.testAddResults): update
3153 tests to handle new asserts
3154 * buildbot/test/test_vc.py (Patch.doPatch): same
3155 * buildbot/test/test_steps.py (BuildStep.setUp): same
3157 2005-05-05 Brian Warner <warner@lothar.com>
3159 * buildbot/scripts/runner.py (start): if there is no Makefile,
3160 launch the app by importing twistd's internals and calling run(),
3161 rather than spawning a new twistd process. This stands a much
3162 better chance of working under windows.
3163 (stop): kill the process with os.kill instead of spawning
3164 /bin/kill, again to reduce the number of external programs which
3165 windows might not have in the PATH. Also wait up to 5 seconds for
3166 the process to go away, allowing things like 'buildbot stop;
3167 buildbot start' to be reliable in the face of slow shutdowns.
3169 * buildbot/master.py (Dispatcher.__getstate__): remove old
3170 .tap-related methods
3171 (BuildMaster.__getstate__): same
3173 * buildbot/slave/bot.py (makeService): same
3174 (Options.longdesc): same
3175 * buildbot/scripts/runner.py: copy over some old mktap option text
3177 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3178 'buildbot master' now creates a buildbot.tac file, so there is no
3179 longer a create-instance/save/reload sequence. mktap is dead, long
3181 * buildbot/scripts/sample.mk: use twistd -y, not -f
3182 * buildbot/test/test_config.py: remove mktap-based test
3183 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3184 * README: don't reference mktap
3186 * docs/source.xhtml: document some of the attributes that Changes
3189 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3191 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3192 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3193 * buildbot/changes/changes.py (Change)
3194 * buildbot/changes/mail.py (parseSyncmail)
3195 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3197 * buildbot/process/base.py (Build.isTagImportant)
3201 2005-05-04 Brian Warner <warner@lothar.com>
3203 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3204 connection after sending the change, so that unit tests don't
3205 complain about sockets being left around
3207 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3208 exception in phase=0 rendering
3209 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3211 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3213 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3214 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3215 and configuring builders with tuples.
3216 * buildbot/test/test_config.py: stop testing compatibility with
3217 deprecated config keys
3218 * buildbot/test/test_run.py: same
3220 2005-05-03 Brian Warner <warner@lothar.com>
3222 * contrib/arch_buildbot.py: survive if there are no logfiles
3223 (username): just use a string, os.getlogin isn't reliable
3225 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3226 so 'buildbot sendchange' actually works. The earlier test only
3227 covered the internal (non-reactor-running) form.
3229 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3230 script to notify the buildmaster about changes
3232 * buildbot/scripts/runner.py (sendchange): new command to send a
3233 change to a buildbot.changes.pb.PBChangeSource receiver.
3234 * buildbot/test/test_changes.py (Sender): test it
3236 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3237 after any reading of the config file, not just when we do it in
3238 startService. This makes some tests a bit cleaner.
3240 * buildbot/changes/pb.py: add some log messages
3242 * buildbot/process/base.py (Build.startBuild): fix a bug that
3243 caused an exception when the build terminated in the very first
3245 (Build.stepDone): let steps return a status of EXCEPTION. This
3246 terminates the build right away, and sets the build's overall
3247 status to EXCEPTION too.
3248 * buildbot/process/step.py (BuildStep.failed): return a status of
3249 EXCEPTION when that is what has happened.
3251 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3252 implement this, allowing Arch-based projects to get precise
3253 checkouts instead of always using the latest code
3254 (Bazaar): create variant of Arch to let folks use baz instead of
3255 tla. Requires a new buildslave too.
3256 * buildbot/slave/commands.py (Arch): add 'revision' argument
3257 (Bazaar): create variant of Arch that uses baz instead of tla.
3258 Remove the code that extracts the archive name from the
3259 register-archive output, since baz doesn't provide it, and require
3260 the user provide both the archive name and its location.
3261 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3263 2005-05-02 Brian Warner <warner@lothar.com>
3265 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3266 thanks to Nick Trout.
3268 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3269 deals better with source Makefile coming from a read-only CVS
3270 checkout. Thanks to Nick Trout for the catch.
3272 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3275 2005-04-28 Brian Warner <warner@lothar.com>
3277 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3279 * debian/changelog: update for 0.6.4
3281 2005-04-28 Brian Warner <warner@lothar.com>
3283 * README.w32: add a checklist of steps for getting buildbot
3285 * MANIFEST.in: include it in the tarball
3289 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3290 broken .tap files from 0.6.3 by getting rid of .services,
3291 .namedServices, and .change_svc at load time.
3293 2005-04-27 Brian Warner <warner@lothar.com>
3295 * NEWS: update in preparation for new release
3297 * buildbot/test/test_config.py (Save.testSave): don't pull in
3298 twisted.scripts.twistd, we don't need it and it isn't for windows
3301 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3302 accomodate win32 which can't do atomic-rename
3304 2005-04-27 Brian Warner <warner@lothar.com>
3306 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3307 timeouts to help the slow metabuildbot not flunk them so much
3308 (Disconnect.testBuild3): same
3309 (Disconnect.testBuild4): same
3310 (Disconnect.testInterrupt): same
3312 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3313 setup, it was completely broken for new buildmasters (those which
3314 did not have a 'change.pck' already saved. Thanks to Paul Warren
3315 for catching this (embarrassing!) bug.
3316 (Dispatcher.__getstate__): don't save our registered avatar
3317 factories, since they'll be re-populated when the config file is
3319 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3320 tests (since the real mktap-generated BuildMaster doesn't save
3322 (BuildMaster.__getstate__): don't save any service children,
3323 they'll all be re-populated when the config file is re-read.
3324 * buildbot/test/test_config.py (Save.testSave): test for this
3326 2005-04-26 Brian Warner <warner@lothar.com>
3328 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3329 rendered with Blender.. looks a bit nicer.
3330 * buildbot/docs/images/icon.blend: add the Blender file for it
3332 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3333 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3334 running under windows. This appears to be the best way to allow
3335 BuildSteps to do something normal like 'trial -v buildbot.test' or
3336 'make foo' and still expect it to work. The idea is to make the
3337 BuildSteps look as much like what a developer would type when
3338 compiling or testing the tree by hand. This approach probably has
3339 problems when there are spaces in the arguments, so if you've got
3340 windows buildslaves, you'll need to pay close attention to your
3343 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3344 timezone to the timestamp column.
3345 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3347 * buildbot/scripts/runner.py (loadOptions): do something sane for
3348 windows, I think. We use %APPDATA%/buildbot instead of
3349 ~/.buildbot, but we still search everywhere from the current
3350 directory up to the root for a .buildbot/ subdir. The "is it under
3351 $HOME" security test was replaced with "is it owned by the current
3352 user", which is only performed under posix.
3353 * buildbot/test/test_runner.py (Options.testFindOptions): update
3354 tests to match. The "is it owned by the current user" check is
3355 untested. The test has been re-enabled for windows.
3357 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3358 any "\n" in the expected output with the platform-specific line
3359 separator. Make this separator "\r\n" on PTYs under unix, they
3360 seem to do that and I don't know why
3362 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3363 windows for now, I don't know what ~/.buildbot/ should mean there.
3365 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3366 win32 compatibility, don't use "/tmp"
3367 (Basedir.testChangeBuilddir): remove more unixisms
3369 2005-04-26 Brian Warner <warner@lothar.com>
3371 * buildbot/test/test_control.py (Force.rmtree): python2.2
3372 compatibility, apparently its shutil.rmtree ignore_errors=
3373 argument is ignored.
3374 * buildbot/test/test_run.py (Run.rmtree): same
3375 (RunMixin.setUp): same
3377 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3380 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3381 'substring in string' operator, must use string.find(substr)!=-1
3382 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3383 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3385 * buildbot/scripts/runner.py (loadOptions): add code to search for
3386 ~/.buildbot/, a directory with things like 'options', containing
3387 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3388 the current directory, your $HOME directory, or anywhere
3389 inbetween, as long as you're somewhere inside your home directory.
3390 (debugclient): look in ~/.buildbot/options for master and passwd
3391 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3392 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3394 * buildbot/status/client.py (makeRemote): new approach to making
3395 IRemote(None) be None, which works under Twisted-2.0
3396 * buildbot/test/test_status.py (Client.testAdaptation): test it
3398 * buildbot/status/builder.py (Status.builderAdded): when loading a
3399 pickled BuilderStatus in from disk, set its name after loading.
3400 The config file might have changed its name (but not its
3401 directory) while it wasn't looking.
3403 * buildbot/process/builder.py (Builder.attached): always return a
3404 Deferred, even if the builder was already attached
3405 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3407 2005-04-25 Brian Warner <warner@lothar.com>
3409 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3410 category-related exception when announcing a build has finished
3412 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3413 reference no-longer-existent changemaster.sources
3414 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3416 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3419 2005-04-25 Brian Warner <warner@lothar.com>
3421 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3423 * debian/changelog: update for 0.6.3
3425 2005-04-25 Brian Warner <warner@lothar.com>
3427 * MANIFEST.in: make sure debug.glade is in the tarball
3429 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3431 * NEWS: update for the imminent 0.6.3 release
3433 * buildbot/status/html.py (HtmlResource.content): make the
3434 stylesheet <link> always point at "buildbot.css".
3435 (StatusResource.getChild): map "buildbot.css" to a static.File
3436 containing whatever css= argument was provided to Waterfall()
3437 (Waterfall): provide the "classic" css as the default.
3438 * docs/waterfall.classic.css: move default CSS from here ..
3439 * buildbot/status/classic.css: .. to here
3441 * MANIFEST.in: make sure classic.css is included in the tarball
3442 * setup.py: and that it is installed too, under buildbot/status/
3444 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3445 the module level, because buildbot.tap files from 0.6.2 don't have
3446 it in their attribute dictionary.
3448 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3449 really exists at startup, might save some confusion somewhere.
3451 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3453 * docs/waterfall.classic.css:
3454 add a stylesheet that's almost the same as the "classic"
3457 * buildbot/status/builder.py:
3458 add EXCEPTION as a result - this is a problem for the bot
3459 maintainer, not a build problem for the changers
3460 * buildbot/process/step.py:
3461 use EXCEPTION instead of FAILURE for exceptions
3462 * buildbot/status/html.py:
3463 add build_get_class to get a class out of a build/buildstep
3464 finish naming the classes
3465 split out sourceNames to changeNames and builderNames so we
3466 can style them separately
3467 * docs/config.xhtml:
3468 finish documenting classes as they are right now
3470 * buildbot/status/html.py:
3471 name the classes as we agreed on IRC
3472 * docs/config.xhtml:
3475 * buildbot/status/html.py:
3476 same for cssclass->class_
3478 * buildbot/status/html.py:
3479 as decided on IRC, use class_ for the "class" attribute to not
3480 conflict with the class keyword, and clean up the messy **{} stuff.
3482 * buildbot/status/mail.py:
3483 put back "builders" argument, and fix docstring, because the
3484 code *ignores* builders listed in this argument
3486 * buildbot/process/builder.py:
3487 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3489 * docs/config.xhtml:
3490 describe the category argument for builders
3492 * buildbot/status/builder.py:
3493 Fix a silly bug due to merging
3495 * buildbot/process/builder.py:
3496 remove category from the process Builder ...
3497 * buildbot/status/builder.py:
3498 ... and add it to BuilderStatus instead.
3499 Set category on unpickled builder statuses, they might not have it.
3500 * buildbot/master.py:
3501 include category when doing builderAdded
3502 * buildbot/status/mail.py:
3503 return None instead of self for builders we are not interested in.
3504 * buildbot/test/test_run.py:
3505 fix a bug due to only doing deferredResult on "dummy" waiting
3506 * buildbot/test/test_status.py:
3507 add checks for the Mail IStatusReceiver returning None or self
3509 * buildbot/status/html.py:
3510 fix testsuite by prefixing page title with BuildBot
3512 * buildbot/status/builder.py:
3513 have .category in builder status ...
3514 * buildbot/process/builder.py:
3515 ... and set it from Builder
3516 * buildbot/status/html.py:
3517 make .css a class variable
3518 * buildbot/test/test_status.py:
3519 write more tests to cover our categories stuff ...
3520 * buildbot/status/mail.py:
3521 ... and fix the bug that this uncovered
3523 * buildbot/changes/mail.py:
3524 * buildbot/changes/pb.py:
3525 * buildbot/master.py:
3526 * buildbot/process/base.py:
3527 * buildbot/process/factory.py:
3528 * buildbot/process/interlock.py:
3529 * buildbot/process/step.py:
3530 * buildbot/process/step_twisted.py:
3531 * buildbot/slave/commands.py:
3532 * buildbot/status/builder.py:
3533 * buildbot/status/client.py:
3534 * buildbot/status/html.py:
3535 * buildbot/status/mail.py:
3536 * buildbot/status/progress.py:
3537 * buildbot/test/test_changes.py:
3538 * buildbot/test/test_config.py:
3539 * buildbot/test/test_control.py:
3540 * buildbot/test/test_interlock.py:
3541 * buildbot/test/test_maildir.py:
3542 * buildbot/test/test_mailparse.py:
3543 * buildbot/test/test_run.py:
3544 * buildbot/test/test_slavecommand.py:
3545 * buildbot/test/test_status.py:
3546 * buildbot/test/test_steps.py:
3547 * buildbot/test/test_twisted.py:
3548 * buildbot/test/test_util.py:
3549 * buildbot/test/test_vc.py:
3550 * buildbot/test/test_web.py:
3552 add test-case-name at the top of a whole set of files
3554 * buildbot/status/builder.py:
3555 keep order of addition when getting builder names
3556 * buildbot/status/words.py:
3557 * buildbot/test/test_run.py:
3558 add test for getBuilderNames
3560 * buildbot/process/base.py:
3561 * buildbot/process/step.py:
3562 * buildbot/status/builder.py:
3563 * buildbot/status/html.py:
3564 make buildbot css-able
3565 replace the color code for purple with purple, don't understand
3566 why it wasn't purple to start with
3568 * buildbot/status/words.py:
3569 ok, so it doesn't look like BuilderStatus.remote is still valid.
3570 Use what waterfall uses instead.
3572 * buildbot/interfaces.py:
3573 * buildbot/status/builder.py:
3574 * buildbot/status/html.py:
3575 * buildbot/status/mail.py:
3576 * buildbot/status/words.py:
3577 * buildbot/test/test_run.py:
3578 use categories everywhere and make it be a list. More sensible
3579 for the future. Also make words actually respect this in
3582 * buildbot/interfaces.py:
3583 add category argument to getBuilderNames
3584 * buildbot/process/builder.py:
3585 * buildbot/status/builder.py:
3586 * buildbot/status/html.py:
3587 * buildbot/status/mail.py:
3588 * buildbot/status/words.py:
3589 * buildbot/test/test_run.py:
3590 move from specifying builders by name to specifying the category
3592 * buildbot/status/html.py:
3593 * buildbot/status/words.py:
3594 add "builders=" to __init__ of status clients so they can
3595 limit themselves to the given list of builders to report on
3597 * buildbot/status/html.py: set the title to the product name
3599 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3601 * buildbot/interfaces.py:
3602 * buildbot/status/builder.py:
3603 more documentation. Hm, not sure if ChangeLog entries make sense
3606 2005-04-23 Brian Warner <warner@lothar.com>
3608 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3610 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3612 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3613 the sub-commands that log buildmaster status to stdout and to a
3614 GUI window, respectively.
3616 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3617 functionality is working again, but all the step-status and ETA
3618 stuff is missing. Commented out a lot of code pending more
3621 * buildbot/status/client.py: make sure that IRemote(None) is None
3623 * buildbot/changes/changes.py: import defer, oops
3624 (ChangeMaster): remove the .sources list, rely upon the fact that
3625 MultiServices can be treated as sequences of their children. This
3626 cleans up the add/remove ChangeSource routines a lot, as we keep
3627 exactly one list of the current sources instead of three.
3629 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3630 up an empty ChangeMaster at init time.
3631 (BuildMaster.loadChanges): if there are changes to be had from
3632 disk, replace self.change_svc with the new ones. If not, keep
3633 using the empty ChangeMaster set up in __init__.
3634 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3635 instead of a separate list, makes the code a bit cleaner.
3636 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3637 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3638 Extend the test to make sure we can get rid of the sources when
3641 2005-04-22 Brian Warner <warner@lothar.com>
3643 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3644 and info/host files when making the slave directory
3646 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3647 whendone= argument, just return the Deferred and let the caller do
3648 what they want with it.
3649 (Disconnect.testBuild1): wait for shutdownSlave
3650 (Basedir.testChangeBuilddir): new test to make sure changes to the
3651 builddir actually get propagated to the slave
3653 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3654 explicit method, rather than passing the builddir in __init__ .
3655 Make sure to update self.basedir too, this was broken before.
3656 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3657 builders and for ones that have just had their builddir changed.
3658 (BotFactory): add a class-level .perspective attribute, so
3659 BuildSlave.waitUntilDisconnected won't get upset when the
3660 connection hasn't yet been established
3661 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3662 tests can reach through it to inspect the SlaveBuilders
3664 * buildbot/process/base.py (Build.buildException): explain the
3665 log.err with a log.msg
3666 * buildbot/process/builder.py (Builder.startBuild): same
3667 (Builder._startBuildFailed): improve error message
3669 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3670 occurred because we lost the brand-new connection, retry instead
3671 of giving up. If not, it's probably an authorization failure, and
3672 it makes sense to stop trying. Make sure we log.msg the reason
3673 that we're log.err'ing the failure, otherwise test failures are
3674 really hard to figure out.
3676 * buildbot/master.py: change loadConfig() to return a Deferred
3677 that doesn't fire until the change has been fully implemented.
3678 This means any connected slaves have been updated with the new
3679 builddir. This change makes it easier to test the code which
3680 actually implements this builddir-updating.
3681 (BotPerspective.addBuilder): return Deferred
3682 (BotPerspective.removeBuilder): same
3683 (BotPerspective.attached): same
3684 (BotPerspective._attached): same. finish with remote_print before
3685 starting the getSlaveInfo, instead of doing them in parallel
3686 (BotPerspective.list_done): same
3687 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3688 actually calling slave.disconnect()
3689 (BotMaster.addBuilder): same
3690 (BotMaster.removeBuilder): same
3691 (BuildMaster.loadConfig): same
3692 (BuildMaster.loadConfig_Slaves): same
3693 (BuildMaster.loadConfig_Sources): same
3694 (BuildMaster.loadConfig_Builders): same
3695 (BuildMaster.loadConfig_status): same
3697 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3698 a Deferred that fires when the source is finally removed
3700 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3701 the previous tree on win32, where we have to do it synchronously,
3702 make sure we return a Deferred anyway.
3703 (SourceBase.doCopy): same
3705 * buildbot/scripts/runner.py (statusgui): use the text client for
3706 now, while I rewrite the Gtk one
3707 * buildbot/clients/base.py: strip out old code, leaving just the
3708 basic print-message-on-event functionality. I also remove the
3709 ReconnectingPBClientFactory, but it does at least quit when it
3710 loses the connection instead of going silent
3712 2005-04-21 Brian Warner <warner@lothar.com>
3714 * Makefile: minor tweaks
3716 * NEWS: point out deprecation warnings, new features for
3719 * buildbot/master.py (BuildMaster.loadConfig): emit
3720 DeprecationWarnings for Builders defined with tuples. Rearrange
3721 code to facility removal of deprecated configuration keys in the
3724 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3725 'buildbot' command to put a little Makefile in the target that
3726 helps you re-create the buildbot.tap file, start or stop the
3727 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3728 all the files 0600, since they contain passwords.
3729 (start): if there is a Makefile, and /usr/bin/make exists, use
3730 'make start' in preference to a raw twistd command. This lets
3731 slave admins put things like PYTHONPATH variables in their
3732 Makefiles and have them still work when the slave is started with
3733 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3734 be nice to first try the 'make' command and only fall back to
3735 twistd if it fails. TODO: the Makefile's "start" command does not
3736 add the --reactor=win32 argument when running under windows.
3737 (Options.debugclient, Options.statusgui): add sub-commands to launch
3738 the debug client (formerly in contrib/debugclient.py) and the
3739 Gtk status application (currently broken)
3740 * buildbot/clients/debug.py: move from contrib/debugclient.py
3741 * buildbot/clients/debug.glade: same
3743 * buildbot/test/test_trial.py: remove it. This requires some
3744 functionality out of Twisted that isn't there yet, and until then
3745 having it around just confuses things.
3747 * buildbot/test/test_slavecommand.py (Shell): test both with and
3748 without PTYs, and make sure that command output is properly
3749 interleaved in the with-PTY case. I think the without-PTY test
3750 should pass on windows, where we never use PTYs anyway.
3752 2005-04-20 Brian Warner <warner@lothar.com>
3754 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3756 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3758 * NEWS: start creating entries for the next release
3760 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3762 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3763 (WebTest.test_webPathname): same
3764 (WebTest.test_webPathname_port): same
3765 (WebTest.test_waterfall): use the default favicon rather than
3766 rooting around the filesystem for it. Open the expected-icon file
3767 in binary mode, to make win32 tests happier (thanks to Nick Trout
3769 * buildbot/status/html.py (buildbot_icon): win32 portability
3771 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3772 win32-compatibility fixes from Nick Trout, the "file not found" message
3773 is different under windows
3774 (FakeSlaveBuilder.__init__): clean up setup a bit
3775 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3777 2005-04-19 Brian Warner <warner@lothar.com>
3779 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3780 skip-if-repositories-are-unavailable test to not kill the trial
3781 that comes with Twisted-1.3.0
3783 * setup.py: install buildbot.png icon file when installing code
3785 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3786 environment used by the command, at least on the child side.
3788 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3789 this method needs to be added and implemented because it gets
3790 called under heavy load. I don't quite understand the
3791 producer/consumer API enough to write it.
3792 (StatusResource.getChild): add a resource for /favicon.ico
3793 (Waterfall.__init__): add favicon= argument
3794 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3795 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3796 (WebTest.test_webPathname): same
3797 (WebTest.test_webPathname_port): same
3798 * docs/config.xhtml: mention favicon=
3799 * buildbot/buildbot.png: add a default icon, dorky as it is
3801 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3803 * buildbot/master.py:
3804 * buildbot/process/base.py:
3805 * buildbot/process/builder.py:
3806 * buildbot/process/interlock.py:
3807 * buildbot/status/builder.py:
3808 * buildbot/status/html.py:
3809 * buildbot/status/mail.py:
3810 * buildbot/status/words.py:
3811 new documentation while digging through the code
3813 2005-04-17 Brian Warner <warner@lothar.com>
3815 * general: try to fix file modes on all .py files: a+r, a-x,
3816 but let buildbot/clients/*.py be +x since they're tools
3818 * docs/epyrun (addMod): when an import fails, say why
3820 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3822 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3824 * buildbot/process/base.py:
3825 * buildbot/process/builder.py:
3826 * buildbot/status/builder.py:
3827 new documentation while digging through the code
3829 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3831 * buildbot/changes/changes.py:
3832 * buildbot/changes/p4poller.py:
3833 * buildbot/interfaces.py:
3834 * buildbot/process/base.py:
3835 * buildbot/process/builder.py:
3836 * buildbot/process/step.py:
3837 * buildbot/process/step_twisted.py:
3838 * buildbot/slave/bot.py:
3839 * buildbot/slave/commands.py:
3840 * buildbot/status/builder.py:
3841 fix all docstrings to make epydoc happy. In the process of fixing
3842 some, I also moved pieces of docs, and removed some deprecated
3845 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3847 * buildbot/process/builder.py:
3848 * buildbot/process/interlock.py:
3849 * buildbot/process/process_twisted.py:
3850 * buildbot/process/step.py:
3851 BuildProcess -> Build, as it looks like that's what happened
3852 * buildbot/process/base.py:
3853 * buildbot/process/factory.py:
3856 2005-04-17 Brian Warner <warner@lothar.com>
3858 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3859 update compile command to accomodate the Twisted split.. now
3860 instead of './setup.py build_ext -i', you do './setup.py all
3861 build_ext -i', to run build_ext over all sub-projects.
3862 (FullTwistedBuildFactory): same
3863 (TwistedReactorsBuildFactory): same
3865 * buildbot/status/html.py (TextLog.finished): null out self.req
3866 when we're done, otherwise the reference cycle of TextLog to .req
3867 to .notifications to a Deferred to TextLog.stop keeps them from
3868 being collected, and consumes a huge (610MB on pyramid at last
3869 check) amount of memory.
3871 2005-04-11 Brian Warner <warner@lothar.com>
3873 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3874 normalize the VC-repository location.. makes SVN happier with
3875 certain test environments.
3877 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3878 RemoteShellCommand gets its own .env dictionary, so that code in
3879 start() doesn't mutate the original. I think this should fix the
3880 step_twisted.Trial problem where multiple identical components
3881 kept getting added to PYTHONPATH= over and over again.
3883 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3884 adding epydoc-format docstrings to many classes. Thanks to Thomas
3885 Vander Stichele for the patches.
3886 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3887 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3888 * buildbot/slave/bot.py, commands.py, registry.py: same
3890 2005-04-05 Brian Warner <warner@lothar.com>
3892 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3893 preserve timestamps, helps incremental builds of large trees.
3894 Patch from Rene Rivera.
3896 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3897 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3900 2005-04-03 Brian Warner <warner@lothar.com>
3902 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3903 with one dict, apparently exec has some scoping bugs when used
3904 with both global/local dicts. Thanks to Nathaniel Smith for the
3907 2005-04-02 Brian Warner <warner@lothar.com>
3909 * buildbot/process/step_twisted.py (countFailedTests): the new
3910 trial in Twisted-2.0 emits a slightly different status line than
3911 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3912 mistakenly think the test count is unparseable.
3913 (Trial.start): note that for some reason each build causes another
3914 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3915 be fixed but I'm not sure quite where the problem is.
3917 2005-04-01 Brian Warner <warner@lothar.com>
3919 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3920 deferredResult to avoid hangs/warnings under twisted-2.0
3921 (RunMixin.tearDown): same
3922 (RunMixin.shutdownSlave): same
3923 (Disconnect.testIdle1): same
3924 (Disconnect.testBuild2): same: wait one second after the build
3925 finishes for test to really be done.. this should be cleaned up to
3926 avoid wasting that second. Builder.detach uses a callLater(0),
3927 either that should be done in-line (something else needed that
3928 behavior), or it should return a Deferred that fires when the
3929 builder is really offline.
3930 (Disconnect.testBuild3): same
3931 (Disconnect.testDisappear): same
3933 * buildbot/test/test_web.py: rearrange server-setup and teardown
3934 code to remove unclean-reactor warnings from twisted-2.0
3936 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3937 so the tests don't hang under twisted-2.0
3939 2005-03-31 Brian Warner <warner@lothar.com>
3941 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3942 caused a warning each time the master changed our set of builders
3944 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3945 w32, don't unlink the file unless it already exists. Thanks to
3946 Baptiste Lepilleur for the catch.
3947 (BuilderStatus.saveYourself): same
3949 2005-02-01 Brian Warner <warner@lothar.com>
3951 * buildbot/status/html.py (TextLog.getChild): use a /text child
3952 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3953 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3954 logfile as text/plain (no markup, no headers). This replaces the
3955 previous scheme (which used an ?text=1 argument), and gets us back
3956 to a relative link (which works better when the buildbot lives
3957 behind another web server, such as Apache configured as a reverse
3958 proxy). Thanks to Gerald Combs for spotting the problem.
3960 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3963 2004-12-13 Brian Warner <warner@lothar.com>
3965 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3967 * debian/changelog: update for 0.6.2
3968 * NEWS: finalize for 0.6.2
3970 2004-12-11 Brian Warner <warner@lothar.com>
3972 * NEWS: bring it up to date
3974 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3975 detection code. Require some sign of life from the buildmaster
3976 every BotFactory.keepaliveInterval seconds. Provoke this
3977 indication at BotFactory.keepaliveTimeout seconds before the
3978 deadline by sending a keepalive request. We don't actually care if
3979 that request is answered in a timely fashion, what we care about
3980 is that .activity() is called before the deadline. .activity() is
3981 triggered by any PB message from the master (including an ack to
3982 one of the slave's status-update messages). With this new scheme,
3983 large status messages over slow pipes are OK, as long as any given
3984 message can be sent (and thus acked) within .keepaliveTimeout
3985 seconds (which defaults to 30).
3986 (SlaveBuilder.remote_startCommand): record activity
3987 (SlaveBuilder.ackUpdate): same
3988 (SlaveBuilder.ackComplete): same
3989 (BotFactory.gotPerspective): same
3990 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
3992 2004-12-09 Brian Warner <warner@lothar.com>
3994 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
3997 * buildbot/process/step_twisted.py (Trial._commandComplete):
3998 update self.cmd when we start the 'cat test.log' transfer. Without
3999 this, we cannot interrupt the correct RemoteCommand when we lose
4002 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4003 trying to tell the slave to stop the command if we're already
4004 inactive, or if we no longer have a .remote
4006 * buildbot/process/builder.py (Builder._detached): don't let an
4007 exception in currentBuild.stopBuild() prevent the builder from
4008 being marked offline
4010 2004-12-07 Brian Warner <warner@lothar.com>
4012 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4013 KeyError that happens when you ask for a non-existent Builder, and
4014 translate it into a UsageError.
4016 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4017 losing the slave in the middle of a remote step is handled too
4019 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4020 be a Failure, so be sure to stringify it before using it as the
4021 contents of the 'interrupt' logfile
4022 (RemoteCommand.interrupt): use stringified 'why' in
4023 remote_interruptCommand too, just in case
4025 2004-12-06 Brian Warner <warner@lothar.com>
4027 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4028 instead of 'tla update', which is more efficient in case we've
4029 missed a couple of patches since the last update.
4031 * debian/changelog: update for previous (0.6.1) release. Obviously
4032 this needs to be handled better.
4034 2004-12-05 Brian Warner <warner@lothar.com>
4036 * NEWS: update for stuff since last release
4038 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4039 match the maybeDeferred change in Dispatcher.requestAvatar
4040 * buildbot/changes/pb.py (ChangePerspective.attached): same
4041 * buildbot/status/client.py (StatusClientPerspective.attached): same
4042 * buildbot/process/builder.py (Builder._attached3): same
4043 * buildbot/pbutil.py (NewCredPerspective.attached): same
4045 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4046 the date to the top-most box, if it is not the same as today's
4049 * docs/slave.xhtml: provide a buildslave setup checklist
4051 * docs/source.xhtml (Arch): correct terminology
4053 2004-12-04 Brian Warner <warner@lothar.com>
4055 * buildbot/test/test_slavecommand.py: use sys.executable instead
4056 of hard-coding 'python' for child commands, might help portability
4058 * docs/examples/twisted_master.cfg: update to current usage
4060 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4061 'stop build' command to the IRC bot
4063 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4064 message that broke PBChangeSource
4066 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4067 (SlaveBuilder): make some attributes class-level, remove the old
4068 "update queue" which existed to support resuming a build after the
4069 master connection was lost. Try to reimplement that feature later.
4070 (SlaveBuilder.stopCommand): clear self.command when the
4071 SlaveCommand finishes, so that we don't try to kill a leftover one
4073 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4076 * buildbot/slave/commands.py (SourceBase): set self.command for
4077 all VC commands, so they can be interrupted.
4079 2004-12-03 Brian Warner <warner@lothar.com>
4081 * buildbot/master.py: clean up slave-handling code, to handle
4082 slave-disconnect and multiple-connect better
4083 (BotPerspective): make these long-lasting, exactly one per bot
4084 listed in the config file.
4085 (BotPerspective.attached): if a slave connects while an existing
4086 one appears to still be connected, disconnect the old one first.
4087 (BotPerspective.disconnect): new method to forcibly disconnect a
4088 buildslave. Use some hacks to empty the transmit buffer quickly to
4089 avoid the long (20-min?) TCP timeout that could occur if the old
4090 slave has dropped off the net.
4091 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4092 own their own SlaveStatus objects. Remove .attached/.detached, add
4093 .addSlave/.removeSlave, treat slaves like Builders (config file
4094 parsing sends deltas to the BotMaster). Inform the slave
4095 instances, i.e. the BotPerspective, about addBuilder and
4097 (BotMaster.getPerspective): turns into a single dict lookup
4098 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4099 which gives BotPerspective.attached a chance to disconnect the old
4101 (BuildMaster.loadConfig): add code (disabled) to validate that all
4102 builders use known slaves (listed in c['bots']). The check won't
4103 work with tuple-specified builders, which are deprecated but not
4104 yet invalid, so the check is disabled for now.
4105 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4106 routine, do the add/changed/removed dance with them like we do
4108 (BuildMaster.loadConfig_Sources): move source-config into a
4109 separate routine too
4111 * buildbot/status/builder.py (Status.getSlave): get the
4112 SlaveStatus object from the BotPerspective, not the BotMaster.
4114 * buildbot/test/test_run.py: bunch of new tests for losing the
4115 buildslave at various points in the build, handling a slave that
4116 connects multiple times, and making sure we can interrupt a
4119 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4120 something other than 'Bot' for the Bot object, to make certain
4121 test cases easier to write.
4122 (BuildSlave.waitUntilDisconnected): utility method for testing
4124 2004-11-30 Brian Warner <warner@lothar.com>
4126 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4128 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4129 argument, return a Deferred that always fires with True or False.
4130 I don't use an errback to indicate 'ping failed' so that callers
4131 are free to ignore the deferred without causing spurious errors in
4133 * buildbot/process/builder.py (BuilderControl.ping): implement it
4135 * buildbot/test/test_run.py (Status.testDisappear): test ping
4136 (Status.disappearSlave): fix it
4138 2004-11-30 Brian Warner <warner@lothar.com>
4140 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4141 (IBuilderControl): add .getBuild(num), only works for the current
4142 build, of course, although it might be interesting to offer
4143 something for builds in the .waiting or .interlocked state.
4145 * buildbot/process/base.py (Build): have .stopBuild just do the
4146 interrupt, then let the build die by itself.
4147 (BuildControl): add .stopBuild, and add a point-event named
4148 'interrupt' just after the build so status viewers can tell that
4150 (BuilderControl): add .getBuild
4152 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4153 stops when you kill it, good for testing
4154 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4155 contains the 'reason' text.
4157 * buildbot/status/html.py: Add Stop Build button, if the build can
4158 still be stopped. Send a Redirect (to the top page) one second
4159 later, hopefully long enough for the interrupt to have an effect.
4160 Move make_row() up to top-level to share it between Stop Build and
4163 * buildbot/slave/commands.py: only kill the child process once
4165 * buildbot/test/test_run.py: add testInterrupt
4167 2004-11-29 Brian Warner <warner@lothar.com>
4169 * buildbot/process/base.py: Refactor command interruption. The
4170 Build is now responsible for noticing that the slave has gone
4171 away: Build.lostRemote() interrupts the current step and makes
4172 sure that no further ones will be started.
4174 * buildbot/process/builder.py: When the initial remote_startBuild
4175 message fails, log it: this usually indicates that the slave has
4176 gone away, but we don't really start paying attention until they
4177 fail to respond to the first step's command.
4179 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4180 slave disconnect. Now sports a new interrupt() method. Error
4181 handling was simplified a lot by chaining deferreds, so
4182 remoteFailed/remoteComplete were merged into a single
4183 remoteComplete method (which can now get a Failure object).
4184 Likewise failed/finished were merged into just _finished.
4185 (BuildStep): Add interrupt(why) method, and if why is a
4186 ConnectionLost Failure then the step is failed with some useful
4189 * buildbot/slave/bot.py: stop the current command when the remote
4190 Step reference is lost, and when the slave is shut down.
4191 (Bot): make it a MultiService, so it can have children. Use
4192 stopService to tell when the slave is shutting down.
4193 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4194 remote_interruptCommand (which asks the current SlaveCommand to
4195 stop but allows it to keep emitting status messages), and
4196 stopCommand (which tells it to shut up and die).
4198 * buildbot/slave/commands.py: make commands interruptible
4199 (ShellCommand.kill): factor out os.kill logic
4200 (Command): factor out setup()
4201 (Command.sendStatus): don't send status if .running is false, this
4202 happens when the command has been halted.
4203 (Command.interrupt): new method, used to tell the command to die
4204 (SlaveShellCommand): implement .interrupt
4205 (DummyCommand): implement .interrupt
4206 (SourceBase, etc): factor out setup(), don't continue substeps if
4209 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4210 so they can be called after finishing
4212 * buildbot/test/test_run.py: new tests for disconnect behavior,
4213 refactor slave-shutdown routines, add different kinds of
4216 2004-11-27 Brian Warner <warner@lothar.com>
4218 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4219 method to express ETA time like "2m45s" instead of "165 seconds"
4221 2004-11-24 Brian Warner <warner@lothar.com>
4223 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4224 archive after the test completes, to avoid cluttering the user's
4225 'tla archives' listing with a bogus entry. Arch doesn't happen to
4226 provide any way to override the use of ~/.arch-params/, so there
4227 isn't a convenient way to avoid touching the setup of the user who
4229 (VC_HTTP.testArchHTTP): same
4231 2004-11-23 Brian Warner <warner@lothar.com>
4233 * buildbot/status/html.py (TextLog): split render() up into
4234 render_HEAD and render_GET. Use a Producer when sending log
4235 chunks, to reduce memory requirements and avoid sending huge
4236 non-Banana-able strings over web.distrib connections. Requires
4237 peeking under the covers of IStatusLog.
4238 (TextLog.resumeProducing): fix the "as text" link, handle client
4239 disconnects that occur while we're still sending old chunks.
4241 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4242 use defer.succeed, not the non-existent defer.success
4243 (LogFile.waitUntilFinished): same
4244 (LogFile.subscribe): don't add watchers to a finished logfile
4246 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4249 2004-11-23 Brian Warner <warner@lothar.com>
4251 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4253 2004-11-23 Brian Warner <warner@lothar.com>
4255 * NEWS: update for the 0.6.1 release
4256 * MANIFEST.in: add new files
4258 * README (INSTALLATION): explain how to enable the extra VC tests
4260 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4261 level to, so old pickled builds can be displayed ok
4263 2004-11-22 Brian Warner <warner@lothar.com>
4265 * NEWS: summarize updates since last release
4267 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4268 Yoz Grahame. Closes SF#1050138.
4270 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4273 * buildbot/process/step_twisted.py (Trial): update docs a bit
4275 * docs/factories.xhtml: fix Trial factory docs to match reality.
4278 * buildbot/process/factory.py (Trial.__init__): add args for
4279 randomly= and recurse=, making them available to instantiators
4280 instead of only to subclassers. Closes: SF#1049759.
4282 2004-11-15 Brian Warner <warner@lothar.com>
4284 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4285 try to teach the Quick factory to use multiple versions of python
4287 2004-11-12 Brian Warner <warner@lothar.com>
4289 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4290 safer w32-compatible approach, and only use it on windows
4291 (BuildStatus.saveYourself): same
4293 2004-11-11 Brian Warner <warner@lothar.com>
4295 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4296 it: one string merge per chunk. There are now separate .entries
4297 and .runEntries lists: when enumerating over all chunks, make sure
4299 * buildbot/test/test_status.py (Log): more tests
4301 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4302 chunks together, up to 10kb per chunk. This ought to cut down on
4303 the CPU-burning overhead of large log files. Thanks to Alexander
4304 Staubo for spotting the problem.
4305 * buildbot/test/test_status.py (Log): tests for same
4307 2004-11-10 Brian Warner <warner@lothar.com>
4309 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4310 header to outbound mail
4311 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4313 2004-11-08 Brian Warner <warner@lothar.com>
4315 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4316 can't do os.rename() onto an existing file, so catch the exception
4317 and unlink the target file first. This introduces a slight window
4318 where the existing file could be lost, but the main failure case
4319 (disk full) should still be handled safely.
4320 (BuildStatus.saveYourself): same
4322 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4323 separator character instead of os.sep, because the filenames being
4324 split here are coming from the VC system, which can have a
4325 different pathname convention than the local host. This should
4326 help a buildmaster running on windows that uses a CVS repository
4327 which runs under unix.
4328 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4330 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4331 when there are no test failures to be parsed
4333 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4334 instead of the unix-specific os.system("cp"), thanks to Elliot
4335 Murphy for this and the other buildbot-vs-windows catches.
4336 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4338 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4339 echo the command as it is run
4341 * setup.py: install sample.mk too, not just sample.cfg
4342 (scripts): install contrib/windows/buildbot.bat on windows
4344 2004-11-07 Brian Warner <warner@lothar.com>
4346 * buildbot/process/builder.py (Builder._detached): clear the
4347 self.currentBuild reference, otherwise the next build will be
4348 skipped because we think the Builder is already in use.
4350 * docs/examples/twisted_master.cfg: update to match current usage
4351 on the Twisted buildbot
4353 2004-10-29 Brian Warner <warner@lothar.com>
4355 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4357 2004-10-28 Brian Warner <warner@lothar.com>
4359 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4360 have separate doVCUpdate/doVCFull methods. Catch an update failure
4361 and respond by clobbering the source directory and re-trying. This
4362 will handle local changes (like replacing a file with a directory)
4363 that will cause CVS and SVN updates to fail.
4364 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4366 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4369 2004-10-19 Brian Warner <warner@lothar.com>
4371 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4373 * buildbot/status/html.py (StatusResourceTestResults): display any
4374 TestResults that the Build might have
4375 (StatusResourceTestResult): and the logs for each TestResult
4376 (StatusResourceBuild): add link from the per-build page
4378 2004-10-15 Brian Warner <warner@lothar.com>
4380 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4381 the 'problems' portion of stdout, add TestResults to our build
4382 * buildbot/test/test_twisted.py (Parse.testParse): test it
4384 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4385 to retrieve a dict of accumulated test results
4386 (ITestResult): define what a single test result can do
4387 * buildbot/status/builder.py (TestResult): implement ITestResult
4388 (BuildStatus.getTestResults): retrieve dict of TestResults
4389 (BuildStatus.addTestResult): add TestResults
4390 * buildbot/test/test_status.py (Results.testAddResults): test it
4392 2004-10-14 Brian Warner <warner@lothar.com>
4394 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4395 instead of os.system("rm -rf") for win32 portability
4397 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4398 SignalMixin instead of starting/stopping the reactor, which is
4399 likely to cause problems with other tests
4401 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4402 self.copyComplete() call. Yoz Grahame makes the catch.
4404 * contrib/windows/buildbot.bat: helper script to deal with path
4405 issues. Thanks to Yoz Grahame.
4407 * buildbot/master.py (BuildMaster.startService): don't register a
4408 SIGHUP handler if the signal module has no SIGHUP attribute.
4409 Apparently win32 does this.
4411 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4413 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4414 test if the reactor can't offer UNIX sockets
4416 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4417 error introduced in the last commit. We really need that
4420 2004-10-12 Brian Warner <warner@lothar.com>
4422 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4423 when describing a maildir source. Thanks to Stephen Davis.
4425 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4428 * buildbot/scripts/runner.py (createMaster): install Makefile too
4429 (start): add --no_save to 'start' command
4430 * buildbot/scripts/sample.mk: simple convenience Makefile with
4431 start/stop/reload targets
4433 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4436 2004-09-30 Brian Warner <warner@lothar.com>
4438 * setup.py: Releasing buildbot-0.6.0
4440 2004-09-30 Brian Warner <warner@lothar.com>
4442 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4443 test_trial.py from the source tarball until support is complete.
4445 * NEWS: update for 0.6.0 release
4446 * buildbot/__init__.py (version): same
4449 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4450 'source' command to tell users where to get the Buildbot source
4452 * docs/examples/*.cfg: update to modern standards
4454 * NEWS: update for release
4456 * buildbot/scripts/runner.py (createMaster): remove the
4457 -shutdown.tap stuff now that it isn't necessary
4459 (start): launch buildbot.tap, not buildbot-shutdown.tap
4462 * buildbot/status/mail.py (Domain): shorten class name
4463 (MailNotifier): if lookup= is a string, pass it to Domain()
4464 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4465 (Mail.testBuild2): test the string-to-Domain shortcut
4466 (Mail.testMail): fix test
4469 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4472 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4473 more attributes on load
4474 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4475 to accomodate the whole waterfall page at once, and the thrashing
4476 results in a lot of unnecessary loads
4477 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4478 (BuilderStatus.saveYourself): same
4479 (BuilderStatus.eventGenerator): stop generating on the first missing
4480 build. We assume that saved builds are deleted oldest-first.
4481 (BuildStepStatus.__getstate__): .progress might not exist
4483 * buildbot/changes/changes.py (ChangeMaster): make it
4484 serializable, in $masterdir/changes.pck
4485 (ChangeMaster.stopService): save on shutdown
4486 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4487 * buildbot/test/test_config.py: load Changes before config file
4490 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4491 "Oh my god, you killed the command" header on a separate line
4493 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4494 skip over corrupted build pickles
4495 (BuilderStatus.getFullBuildByNumber): same
4496 (BuilderStatus.eventGenerator): skip over unavailable builds
4497 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4498 do an atomic rename. This prevents a corrupted pickle when some
4499 internal serialization error occurs.
4500 (BuilderStatus.saveYourself): same
4502 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4503 the timeout for shell commands, it got lost somehow
4505 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4506 run out of build steps, return the rest of the builder events
4508 * buildbot/interfaces.py (IBuilderControl.ping): add method
4510 * buildbot/process/builder.py (BuilderControl.ping): move
4511 slave-ping to BuilderControl, and fix the failure case in the
4512 process (Event.finish() is the verb, Event.finished is the noun).
4514 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4515 through the BuilderControl instead of the BuilderStatus
4516 (EventBox): add adapter for builder.Event, allowing builder events to
4517 be displayed in the waterfall display
4519 * buildbot/master.py (BotMaster.stopService): add a 'master
4520 shutdown' event to the builder's log
4521 (BuildMaster.startService): and a 'master started' on startup
4523 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4524 builder events into the BuildStep event stream
4525 (Status.builderAdded): add a 'builder created' event
4528 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4529 command to announce the completion of a running build
4530 (IrcStatusBot.command_FORCE): announce when the build finishes
4532 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4533 don't evict unfinished builds from the cache: they must stay in
4534 the full-cache until their logfiles have stopped changing. Make
4535 sure the eviction loop terminates if an unfinished build was hit.
4536 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4537 This lets exceptions be dumped in an email status message. Really
4538 we need LogFiles which contain both text and HTML, instead of two
4540 (BuildStatus.__getstate__): handle self.finished=False
4541 (Status.builderAdded): if the pickle is corrupted, abandon the
4542 history and create a new BuilderStatus object.
4544 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4545 self.progress attribute, helped one test which doesn't fully set
4546 up the Build object.
4548 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4549 IStatusLog methods into an Interface that is implemented by "stub"
4550 logs, for which all the actual text chunks are on disk (in the
4551 pickled Build instance). To show the log contents, you must first
4552 adapt the stub log to a full IStatusLog object.
4554 * buildbot/status/builder.py (LogFileStub): create separate stub
4555 log objects, which can be upgraded to a real one if necessary.
4556 (LogFile): make them persistable, and let them stubify themselves
4558 (BuildStepStatus): same
4560 (BuildStatus.saveYourself): save the whole build out to disk
4561 (BuilderStatus): make it persistable
4562 (BuilderStatus.saveYourself): save the builder to disk
4563 (BuilderStatus.addFullBuildToCache): implement two caches which
4564 hold Build objects: a small one which holds full Builds, and a
4565 larger one which holds "stubbed" Builds (ones with their LogFiles
4566 turned into LogFileStubs). This reduces memory usage by the
4567 buildmaster by not keeping more than a few (default is 2) whole
4568 build logs in RAM all the time.
4569 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4571 (BuilderStatus.eventGenerator): rewrite since .builds went away
4572 (BuilderStatus.buildStarted): remove the .builds array. Add the
4573 build to the "full" cache when it starts.
4574 (BuilderStatus._buildFinished): save the build to disk when it
4576 (Status): give it a basedir (same as the BuildMaster's basedir)
4577 where the builder pickles can be saved
4578 (Status.builderAdded): create the BuilderStatus ourselves, by
4579 loading a pickle from disk (or creating a new instance if there
4580 was none on disk). Return the BuilderStatus so the master can glue
4581 it into the new Builder object.
4583 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4584 all BuilderStatuses to save themselves out to disk. This is in
4585 lieu of saving anything important in the main Application pickle
4586 (the -shutdown.tap file).
4587 (BuildMaster.__init__): give Status() a basedir for its files
4588 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4589 to get the BuilderStatus, then give it to the Builder (instead of
4590 doing it the other way around). It's ok if the status announces
4591 the new Builder before it's really ready, as the outside world can
4592 only see the BuilderStatus object anyway (and it is ready before
4593 builderAdded returns). Use the builder's "builddir" (which
4594 normally specifies where the slave will run the builder) as the
4595 master's basedir (for saving serialized builds).
4597 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4598 coerce the logfile to IStatusLog before trying to get the text
4599 chunks out of it. This will pull the full (non-stubified) Build in
4600 from disk if necessary.
4601 (TextLog): fix the adapter registration
4603 * buildbot/test/test_control.py (Force.setUp): create the basedir
4604 * buildbot/test/test_web.py: same
4605 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4606 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4607 * buildbot/test/test_run.py (Run.testMaster): same
4608 (Status.setUp): same
4610 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4612 * buildbot/status/html.py (Waterfall.__init__): store actual
4613 allowForce flag passed in rather than using True for everyone;
4614 make sure setting it to False doesn't cause a NameError
4616 (StatusResourceBuilder.__init__) add the builder name to the page
4618 (StatusResourceBuilder.body) move HTML generation for a name/value
4619 row into a helper method (StatusResourceBuilder.make_row); only
4620 generate the "Force Build" form if allowForce was True and the
4621 slave is connected. Use class attributes in the generated HTML to
4622 spread a little CSS-joy.
4624 2004-09-28 Brian Warner <warner@lothar.com>
4626 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4627 warning-scanner to not ignore things like
4628 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4630 * buildbot/status/html.py (StatusResource.control): add some
4631 class-level values for .control in an attempt to make upgrading
4634 * buildbot/util.py (ComparableMixin): survive missing attributes,
4635 such as when a class is modified and we're comparing old instances
4638 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4639 failure handling, remove a redundant try/except block. Don't
4640 return the full traceback to the IRC channel.
4641 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4642 error messages. Get ETA properly.
4644 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4645 the reason, since (at least) IRC message will have <> in them.
4646 (StatusResourceBuilder.__init__): take an IBuilderControl
4647 (StatusResourceBuilder.force): use the IBuilderControl we get in
4648 the constructor instead of trying to make our own. Catch the
4649 new exceptions and ignore them for now (until we make an
4650 intermediate web page where we could show the error message)
4651 (StatusResource): create with an IControl, use it to give an
4652 IBuilderControl to all children
4653 (Waterfall): take an allowForce= option, pass an IControl object
4654 to StatusResource if it is True
4656 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4658 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4659 catch new exceptions and return string forms
4661 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4662 * buildbot/process/builder.py (Builder.forceBuild): raise them
4663 * buildbot/test/test_control.py (Force.testNoSlave): new test
4664 (Force.testBuilderInUse): same
4667 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4669 * buildbot/test/test_run.py: use IControl
4670 * buildbot/test/test_vc.py: same
4672 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4673 to use IControl. Still offline.
4674 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4676 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4677 who=None so periodic builds don't send out status mail
4678 (Builder.forceBuild): include reason in the log message
4679 (BuilderControl.forceBuild): rename 'name' to 'who'
4681 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4682 'who' parameter, but make it None by default so builds forced by
4683 slave admins don't cause status mail to be sent to anybody
4684 (BotMaster.forceBuild): same. this method is deprecated.
4685 (DebugPerspective.perspective_forceBuild): same, use IControl.
4686 (DebugPerspective.perspective_fakeChange): use IControl..
4687 (Dispatcher.requestAvatar): .. so don't set .changemaster
4689 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4690 parameter to avoid confusion with the name of the builder
4693 * buildbot/status/mail.py: refine comment about needing 2.3
4695 * buildbot/status/html.py: move all imports to the top
4697 * buildbot/test/test_control.py: test new interfaces
4698 * buildbot/test/test_run.py (Status): handle new interfaces
4699 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4701 * buildbot/process/base.py (BuildControl): implement IBuildControl
4702 and its lonely getStatus() method
4704 * buildbot/process/builder.py (BuilderControl): implement
4705 IBuilderControl, obtained by adapting the Builder instance
4706 (Builder.startBuild): return a BuilderControl instead of a
4707 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4708 accomplish the same thing.
4710 * buildbot/master.py: move all import statements to the top
4711 (Control): implement IControl, obtained by adapting the
4712 BuildMaster instance.
4714 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4715 IBuildControl. These are used to force builds. Eventually they
4716 will provide ways to reconfigure the Builders, pause or abandon a
4717 Build, and perhaps control the BuildMaster itself.
4719 2004-09-26 Brian Warner <warner@lothar.com>
4721 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4722 ends up comparing us against something without a .__class__
4724 2004-09-24 Brian Warner <warner@lothar.com>
4726 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4729 * Makefile: add 'deb-snapshot' target, to create a timestamped
4732 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4734 2004-09-23 Brian Warner <warner@lothar.com>
4736 * buildbot/__init__.py (version): move version string here
4737 * setup.py: get version string from buildbot.version
4738 * buildbot/status/html.py (WaterfallStatusResource.body): add
4739 buildbot version to the page footer
4740 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4743 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4744 slaves, let the second know where the first one is coming from
4745 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4746 see our exceptions. It would be nice if there were a way to just
4747 send them the exception type and value, not the full traceback.
4750 * buildbot/status/mail.py (MailNotifier): add a new argument
4751 sendToInterestedUsers=, which can be set to False to disable the
4752 usual send-to-blamelist behavior.
4753 (top): handle python-2.2 which has no email.MIMEMultipart
4754 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4755 (MailNotifier.disownServiceParent): unsubscribe on removal
4757 * buildbot/test/test_status.py (Mail.testBuild2): test it
4760 * buildbot/status/progress.py (Expectations.wavg): tolerate
4761 current=None, which happens when steps start failing badly
4762 * buildbot/test/test_status.py (Progress.testWavg): test for it
4764 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4765 doesn't understand args['revision'], emit a warning instead of
4766 bailing completely. Updating to -rHEAD is probably close enough.
4768 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4770 * buildbot/test/test_status.py: at least import bb.status.client
4771 even if we don't have any test coverage for it yet
4773 * contrib/svn_buildbot.py: don't require python2.3
4774 (main): wait, do require it (for sets.py), but explain how to
4775 make it work under python2.2
4777 2004-09-23 Brian Warner <warner@lothar.com>
4779 * contrib/svn_buildbot.py: include the revision number in the Change
4781 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4782 using util.now() because FreshCVS is a realtime service
4784 * buildbot/status/event.py: delete dead code
4785 * buildbot/process/step.py: don't import dead Event class
4786 * buildbot/process/step_twisted.py: same
4787 * buildbot/status/builder.py: same
4788 * buildbot/status/client.py: same
4790 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4792 * buildbot/changes/changes.py (Change): set .when from an __init__
4793 argument (which defaults to now()), rather than having
4794 ChangeMaster.addChange set it later.
4795 (ChangeMaster.addChange): same
4797 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4798 (parseSyncmail): same. Just use util.now() for now.
4799 (parseBonsaiMail): parse the timestamp field for when=
4801 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4802 instead of setting .when after the fact
4806 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4807 results when the target project uses retrial. Still under
4809 * buildbot/test/test_trial.py: same
4811 2004-09-21 Brian Warner <warner@lothar.com>
4813 * buildbot/status/mail.py (MailNotifier.__init__): include
4814 success/warnings/failure in the Subject line
4815 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4816 use step.logname for the addLogs=True attachment filenames
4817 * buildbot/test/test_status.py (Mail): test Subject lines
4818 (Mail.testLogs): test attachment filenames
4820 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4821 accept a 'who' argument from the debug tool
4822 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4823 * contrib/debug.glade: add text box to set 'who'
4825 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4826 .getBuilderName with .getBuilder().getName(), more flexible
4827 (IStatusLog.getName): logs have short names, but you can prefix
4828 them with log.getStep().getName() to make them more useful
4829 * buildbot/status/builder.py: same
4830 * buildbot/status/client.py: same
4831 * buildbot/status/html.py: same
4832 * buildbot/test/test_run.py (Status.testSlave): same
4833 * buildbot/process/step.py: tweak logfile names
4835 * buildbot/status/mail.py (MailNotifier): add lookup, change
4836 argument to extraRecipients. The notifier is now aimed at sending
4837 mail to the people involved in a particular build, with additional
4838 constant recipients as a secondary function.
4840 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4841 including slow-lookup and failing-lookup. Make sure the blamelist
4842 members are included.
4844 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4845 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4846 (IBuildStatus.getInterestedUsers): new method
4847 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4848 * buildbot/status/client.py (remote_getResponsibleUsers): same
4849 * buildbot/status/html.py (StatusResourceBuild.body): same
4850 * buildbot/test/test_run.py (Status.testSlave): same
4852 2004-09-20 Brian Warner <warner@lothar.com>
4854 * docs/users.xhtml: update concepts
4856 * Makefile: add a convenience makefile, for things like 'make
4857 test'. It is not included in the source tarball.
4859 2004-09-16 Brian Warner <warner@lothar.com>
4861 * NEWS: mention /usr/bin/buildbot, debian/*
4863 * debian/*: add preliminary debian packaging. Many thanks to
4864 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4865 it considerably since it left their hands, I am responsible for
4866 all breakage that's resulted.
4868 * bin/buildbot: create a top-level 'buildbot' command, to be
4869 installed in /usr/bin/buildbot . For now it's just a simple
4870 frontend to mktap/twistd/kill, but eventually it will be the entry
4871 point to the 'try' command and also a status client. It is also
4872 intended to support the upcoming debian-packaging init.d scripts.
4873 * buildbot/scripts/runner.py: the real work is done here
4874 * buildbot/scripts/__init__.py: need this too
4875 * buildbot/scripts/sample.cfg: this is installed in new
4876 buildmaster directories
4877 * setup.py: install new stuff
4879 2004-09-15 Brian Warner <warner@lothar.com>
4881 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4882 'file:' schema (the version shipped with OS-X was built without the
4884 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4885 updates the log-timestamp, to make sure it isn't still running after
4888 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4889 values to the config file.
4890 * docs/examples/hello.cfg: add examples
4891 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4892 * buildbot/status/builder.py (Status.getProjectURL): implement them
4893 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4894 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4895 * buildbot/status/html.py (WaterfallStatusResource): display them
4898 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4899 certain error cases don't suffer a secondary exception.
4900 (top): Skip tests if the corresponding VC tool is not installed.
4902 * buildbot/process/factory.py (Trial): introduce separate
4903 'buildpython' and 'trialpython' lists, since trialpython=[] is
4904 what you want to invoke /usr/bin/python, whereas ./setup.py is
4905 less likely to be executable. Add env= parameter to pass options
4906 to test cases (which is how I usually write tests, I don't know if
4907 anyone else does it this way).
4909 * buildbot/process/step_twisted.py (Trial): handle python=None.
4910 Require 'testpath' be a string, not a list. Fix tests= typo.
4911 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4913 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4914 way to deal with the possibility of removing the disconnect notify
4916 (CVS): add a 'login' parameter to give a password to 'cvs login',
4917 commonly used with pserver methods (where pw="" or pw="guest")
4919 * buildbot/slave/commands.py (SourceBase): move common args
4920 extraction and setup() to __init__, so everything is ready by the
4921 time setup() is called
4922 (CVS.start): call 'cvs login' if a password was supplied
4923 (ShellCommand): special-case PYTHONPATH: prepend the master's
4924 value to any existing slave-local value.
4926 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4927 don't have a remote, mark the builder as Offline. This whole
4928 function should probably go away and be replaced by individual
4930 (Builder.buildFinished): return the results to the build-finished
4931 deferred callback, helps with testing
4933 2004-09-14 Brian Warner <warner@lothar.com>
4935 * buildbot/test/test_vc.py: put all the repositories needed to run
4936 the complete tests into a single small (1.3MB) tarball, so I can
4937 make that tarball available on the buildbot web site. Test HTTP
4938 access (for Arch and Darcs) by spawning a temporary web server
4939 while the test runs.
4941 * docs/users.xhtml: new document, describe Buildbot's limited
4942 understanding of different human users
4944 * buildbot/test/test_vc.py: rearrange test cases a bit
4946 * buildbot/process/step_twisted.py (Trial): handle testpath=
4947 * buildbot/process/factory.py (Trial): update to use step.Trial
4949 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4951 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4952 the overall build text (which gives you 'failed 2 tests' rather
4954 (BuildStepStatus.text2): default to [], not None
4956 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4959 2004-09-12 Brian Warner <warner@lothar.com>
4961 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4962 log the whole exception if it's just an AttributeError (old slave)
4964 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4965 so (e.g.) sub-commands can be run in the right directory.
4966 (ShellCommand.start): accept an optional errorMessage= argument
4967 to make life easier for SVN.start
4968 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4970 (ShellCommand.start): move ['dir'] compatibility hack..
4971 (RemoteShellCommand.start): .. to here so everyone can use it
4973 * buildbot/process/step_twisted.py (Trial): use .workdir
4975 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4976 text displayed when debuild fails completely
4977 (Trial): snarf _trial_temp/test.log from the slave and display it
4979 2004-09-11 Brian Warner <warner@lothar.com>
4981 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
4983 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
4984 set to 'twisted', so --recurse can find twisted/web/test/*, etc
4986 * buildbot/process/step.py (ShellCommand): call .createSummary
4987 before .evaluateCommand instead of the other way around. This
4988 makes it slightly easier to count warnings and then use that to
4989 set results=WARNINGS
4990 * buildbot/process/step_twisted.py: cosmetic, swap the methods
4992 * buildbot/process/base.py (Build.buildFinished): update status
4993 before doing progress. It's embarrassing for the build to be stuck
4994 in the "building" state when an exceptions occurs elsewhere..
4996 * buildbot/status/progress.py (Expectations.expectedBuildTime):
4997 python2.2 doesn't have 'sum'
4999 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5000 to prevent clients from accidentally sorting it
5002 * buildbot/master.py (Manhole): add username/password
5003 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5004 c['manholePort'], deprecate old usage
5005 * docs/config.xhtml: document c['manhole']
5006 * docs/examples/hello.cfg: show example of using a Manhole
5009 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5010 pretend the slave is up to date
5012 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5013 the module, overlaps with 'log', the local variable
5015 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5017 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5018 new method to let Steps find out the version of their
5019 corresponding SlaveCommand.
5020 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5021 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5022 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5024 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5025 (Arch.startVC): same
5026 (P4Sync.startVC): same
5028 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5029 Deferred so we can catch errors in remote_startCommand
5030 (RemoteShellCommand.start): same
5032 * docs/examples/twisted_master.cfg: update sample config file
5034 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5035 after connectionMade() is called, not before. Close stdin at that
5038 * buildbot/process/process_twisted.py: update to use Trial, clean
5039 up argument passing (move to argv arrays instead of string
5042 * buildbot/process/step_twisted.py (Trial): new step to replace
5043 RunUnitTests, usable by any trial-using project (not just
5044 Twisted). Arguments have changed, see the docstring for details.
5046 * buildbot/process/base.py (Build.startBuild): this now returns a
5047 Deferred. Exceptions that occur during setupBuild are now
5048 caught better and lead to fewer build_status weirdnesses, like
5049 finishing a build that was never started.
5050 (Build.buildFinished): fire the Deferred instead of calling
5051 builder.buildFinished directly. The callback argument is this
5052 Build, everything else can be extracted from it, including the
5053 new build.results attribute.
5054 * buildbot/process/builder.py (Builder.startBuild): same
5055 (Builder.buildFinished): same, extract results from build
5057 * buildbot/process/step.py (ShellCommands): remove dead code
5059 2004-09-08 Brian Warner <warner@lothar.com>
5061 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5062 doesn't try to use the leftover patched workdir
5063 (SourceStamp): test source-stamp computation for CVS and SVN
5065 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5066 patched workdir ('touch .buildbot-patched') so we don't try to
5068 (SourceBase.start): add ['revision'] for all Source steps
5069 (CVS): change args: use ['branch'] for -r, remove ['files']
5070 (CVS.buildVC): fix revision/branch stuff
5071 (SVN): add revision stuff
5073 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5074 kwargs (except 'workdir') to avoid silent spelling errors
5075 (ShellCommand.__init__): same
5076 (Source): new base class for CVS/SVN/etc. Factor out everything
5077 common, add revision computation (perform the checkout with a -D
5078 DATE or -r REVISION that gets exactly the sources described by the
5079 last Change), overridable with step.alwaysUseLatest. Add patch
5080 handling (build.getSourceStamp can trigger the use of a base
5081 revision and a patch).
5082 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5083 * docs/steps.xhtml: update docs
5084 * docs/source.xhtml: mention .checkoutDelay
5085 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5087 * buildbot/process/base.py (Build.setSourceStamp): add a
5088 .sourceStamp attribute to each Build. If set, this indicates that
5089 the build should be done with something other than the most
5090 recent source tree. This will be used to implement "try" builds.
5091 (Build.allChanges): new support method
5092 (Build.lastChangeTime): remove, functionality moved to Source steps
5093 (Build.setupBuild): copy the Step args before adding ['workdir'],
5094 to avoid modifying the BuildFactory (and thus triggering spurious
5098 * buildbot/status/html.py: rename s/commits/changes/
5099 (StatusResourceChanges): same
5100 (CommitBox.getBox): same, update URL
5101 (WaterfallStatusResource): same
5102 (StatusResource.getChild): same
5104 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5105 * contrib/debug.glade: add optional 'revision' to the fakeChange
5107 * buildbot/changes/changes.py (html_tmpl): display .revision
5108 (ChangeMaster.addChange): note .revision in log
5109 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5110 accept a ['revision'] attribute
5112 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5114 * buildbot/master.py (BotMaster.getPerspective): update the
5115 .connected flag in SlaveStatus when it connects
5116 (BotMaster.detach): and when it disconnects
5117 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5118 (BuildMaster.loadConfig_Builders): walk old list correctly
5120 * buildbot/test/test_config.py: fix prefix= usage
5122 2004-09-06 Brian Warner <warner@lothar.com>
5126 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5127 poll a P4 depot looking for recent changes. Thanks to Dave
5128 Peticolas for the contribution. Probably needs some testing after
5131 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5132 requires manual client setup for each buildslave. Rather
5133 experimental. Thanks again to Dave Peticolas.
5134 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5136 * buildbot/changes/changes.py (Change): add a .revision attribute,
5137 which will eventually be used to generate source-stamp values.
5139 * buildbot/process/step.py (RemoteCommand.start): use
5140 notifyOnDisconnect to notice when we lose the slave, then treat it
5141 like an exception. This allows LogFiles to be closed and the build
5142 to be wrapped up normally. Be sure to remove the disconnect
5143 notification when the step completes so we don't accumulate a
5144 bazillion such notifications which will fire weeks later (when the
5145 slave finally disconnects normally). Fixes SF#915807, thanks to
5146 spiv (Andrew Bennetts) for the report.
5147 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5148 really isn't Logged- specific
5149 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5150 header, since it's almost always going to be appended to an
5152 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5153 update test to handle use of notifyOnDisconnect
5155 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5156 don't clear .ETA and .currentBuild when going offline, let the
5157 current build clean up after itself
5159 * buildbot/process/builder.py (Builder.detached): wait a moment
5160 before doing things like stopping the current build, because the
5161 current step will probably notice the disconnect and cleanup the
5163 * buildbot/test/test_run.py (Status.tearDown): update test to
5164 handle asynchronous build-detachment
5166 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5168 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5169 hush a debug message
5171 2004-09-05 Brian Warner <warner@lothar.com>
5173 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5174 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5175 kernels do this: the fcntl module has the F_NOTIFY constant, but
5176 the kernel itself doesn't support the operation. Thanks to Olly
5177 Betts for spotting the problem.
5179 * buildbot/process/step.py (Darcs): new source-checkout command
5180 (Arch): new source-checkout command
5181 (todo_P4): fix constructor syntax, still just a placeholder
5182 * buildbot/test/test_vc.py (VC.testDarcs): test it
5183 (VC.testDarcsHTTP): same, via localhost HTTP
5185 (VC.testArchHTTP): same
5186 * NEWS: mention new features
5188 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5189 which tells the step to stash stdout text locally (in .stdout).
5190 Slave-side Commands can use this to make decisions based upon the
5191 output of the the ShellCommand (not just the exit code).
5192 (Darcs): New source-checkout command
5193 (Arch): New source-checkout command, uses .keepStdout in one place
5194 where it needs to discover the archive's default name.
5196 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5197 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5198 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5200 * buildbot/process/step.py (ShellCommand.describe): add an
5201 alternate .descriptionDone attribute which provides descriptive
5202 text when the step is complete. .description can be ["compiling"],
5203 for use while the step is running, then .descriptionDone can be
5204 ["compile"], used alone when the step succeeds or with "failed" when
5205 it does not. Updated other steps to use the new text.
5206 * buildbot/process/step_twisted.py: same
5207 * buildbot/test/test_run.py: update tests to match
5209 2004-08-30 Brian Warner <warner@lothar.com>
5211 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5212 (CVS.__init__): send 'patch' argument to slave
5213 (CVS.start): don't create the LoggedRemoteCommand until start(),
5214 so we can catch a .patch added after __init__
5215 (SVN.__init__): add 'patch' to SVN too
5218 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5219 argument, to let commands push data into the process' stdin pipe.
5220 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5221 is in use, since closing a PTY doesn't really affect the process
5222 in the right way (in particular, I couldn't run /usr/bin/patch
5224 (SourceBase.doPatch): handle 'patch' argument
5226 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5229 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5230 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5232 * buildbot/master.py (BotPerspective.got_commands): get command
5233 versions from slave, give to each builder
5234 * buildbot/process/builder.py (Builder.attached): stash slave
5235 command versions in .remoteCommands
5237 * docs/steps.xhtml: bring docs in-line with reality
5239 * buildbot/process/step.py (CVS.__init__): more brutal
5240 compatibility code removal
5241 (SVN.__init__): same
5243 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5244 (SlaveShellCommand.start): require ['workdir'] argument, remove
5245 the ['dir'] fallback (compatibility will come later)
5246 (SourceBase): update docs
5247 (SourceBase.start): remove ['directory'] fallback
5250 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5251 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5252 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5254 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5255 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5256 code.. I will figure out 0.5.0-compatibility hooks later)
5258 2004-08-30 Brian Warner <warner@lothar.com>
5260 * buildbot/process/process_twisted.py: rewrite in terms of new
5261 BuildFactory base class. It got significantly shorter. Yay
5264 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5265 work with the new "self.build isn't nailed down until we call
5266 step.start()" scheme: specifically, __init__ is called before the
5267 build has decided on which Changes are going in, so we don't scan
5268 build.allFiles() for .xhtml files until start()
5269 (HLint.commandComplete): use getText(), not getStdout()
5270 (RunUnitTests.start): same: don't use .build until start()
5271 (RunUnitTests.describe): oops, don't report (None) when using
5273 (RunUnitTests.commandComplete): use getText()
5274 (RunUnitTests.createSummary): same
5275 (BuildDebs.commandComplete): same
5277 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5278 set args['command'] until start(), since our BuildStep is allowed
5279 to change their mind up until that point
5280 (TreeSize.commandComplete): use getText(), not getStdout()
5282 * docs/examples/twisted_master.cfg: update to current standards
5284 * docs/factories.xhtml: update
5285 * buildbot/process/factory.py: implement all the common factories
5286 described in the docs. The Trial factory doesn't work yet, and
5287 I've probably broken all the process_twisted.py factories in the
5288 process. There are compatibility classes left in for things like
5289 the old BasicBuildFactory, but subclasses of them are unlikely to
5291 * docs/examples/glib_master.cfg: use new BuildFactories
5292 * docs/examples/hello.cfg: same
5294 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5295 explicit 'workdir' args
5297 * buildbot/process/base.py (BuildFactory): move factories to ..
5298 * buildbot/process/factory.py (BuildFactory): .. here
5299 * buildbot/process/process_twisted.py: handle move
5300 * buildbot/test/test_config.py: same
5301 * buildbot/test/test_run.py: same
5302 * buildbot/test/test_steps.py: same
5303 * buildbot/test/test_vc.py: same
5304 * docs/factories.xhtml: same
5306 * NEWS: mention config changes that require updating master.cfg
5308 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5309 argument to all steps that weren't given one already, pointing at
5310 the "build/" directory.
5312 * docs/examples/hello.cfg: remove explicit 'workdir' args
5314 * docs/factories.xhtml: document standard BuildFactory clases,
5315 including a bunch which are have not yet been written
5317 2004-08-29 Brian Warner <warner@lothar.com>
5319 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5320 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5321 buildbot.status.builder so they aren't quite so internal
5322 * buildbot/process/base.py, buildbot/process/builder.py: same
5323 * buildbot/process/maxq.py, buildbot/process/step.py: same
5324 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5325 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5326 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5328 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5329 to handle new getLogs()-returns-list behavior
5330 (StatusResourceBuildStep.getChild): same
5331 (StepBox.getBox): same
5332 (WaterfallStatusResource.phase0): same
5334 * docs/source.xhtml: document how Buildbot uses version-control
5335 systems (output side: how we get source trees)
5336 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5337 systems (input side: how we learn about Changes)
5339 * buildbot/master.py (Manhole): use ComparableMixin
5340 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5341 * buildbot/changes/mail.py (MaildirSource): same
5342 * buildbot/status/client.py (PBListener): same
5343 * buildbot/status/html.py (Waterfall): same
5344 * buildbot/status/words.py (IRC): same
5346 * NEWS: start describing new features
5348 * buildbot/status/mail.py (MailNotifier): finish implementation.
5349 The message body is still a bit sparse.
5350 * buildbot/test/test_status.py (Mail): test it
5352 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5353 and __hash__ methods I wind up adding everywhere. Specifically
5354 intended to support the buildbot config-file update scheme where
5355 we compare, say, the old list of IStatusTargets against the new
5356 one and don't touch something which shows up on both lists.
5357 * buildbot/test/test_util.py (Compare): test case for it
5359 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5360 return a list instead of a dict
5361 (IBuildStepStatus.getLogs): same. The idea is that steps create
5362 logs with vaguely unique names (although their uniqueness is not
5363 guaranteed). Thus a compilation step should create its sole
5364 logfile with the name 'compile', and contribute it to the
5365 BuildStatus. If a step has two logfiles, try to create them with
5366 different names (like 'test.log' and 'test.summary'), and only
5367 contribute the important ones to the overall BuildStatus.
5368 * buildbot/status/builder.py (Event.getLogs): same
5369 (BuildStepStatus): fix default .text and .results
5370 (BuildStepStatus.addLog): switch to list-like .getLogs()
5371 (BuildStepStatus.stepFinished): same
5372 (BuildStatus.text): fix default .text
5373 (BuildStatus.getLogs): temporary hack to return all logs (from all
5374 child BuildStepStatus objects). Needs to be fixed to only report
5375 the significant ones (as contributed by the steps themselves)
5376 * buildbot/test/test_run.py: handle list-like .getLogs()
5377 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5379 2004-08-28 Brian Warner <warner@lothar.com>
5381 * buildbot/process/builder.py (Builder.attached): serialize the
5382 attachment process, so the attach-watcher isn't called until the
5383 slave is really available. Add detached watchers too, which makes
5386 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5388 * buildbot/test/test_swap.py: remove dead code
5390 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5391 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5392 sort of as if the command being run exited with a -1. There may
5393 still be some holes in this scheme.
5394 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5395 -r option appears before the module list
5396 * buildbot/process/step.py (CVS): add 'revision' argument
5398 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5399 when sending updates or stepComplete messages to the master, since
5400 we don't currently care whether they arrive or not. When we revamp
5401 the master/slave protocol to really resume interrupted builds,
5402 this will need revisiting.
5403 (lostRemote): remove spurious print
5405 * buildbot/master.py (BotPerspective.attached): serialize the
5406 new-builder interrogation process, to make testing easier
5407 (BotMaster.waitUntilBuilderDetached): convenience function
5409 * buildbot/status/builder.py (BuilderStatus): prune old builds
5410 (BuildStatus.pruneSteps): .. and steps
5411 (BuildStepStatus.pruneLogs): .. and logs
5412 (BuilderStatus.getBuild): handle missing builds
5413 * buildbot/status/html.py (StatusResourceBuild.body): display build
5414 status in the per-build page
5415 (BuildBox.getBox): color finished builds in the per-build box
5417 2004-08-27 Brian Warner <warner@lothar.com>
5419 * buildbot/status/mail.py (MailNotifier): new notification class,
5422 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5423 variants of a common base class which handles all the mode= logic
5425 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5427 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5429 2004-08-26 Brian Warner <warner@lothar.com>
5431 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5434 * buildbot/test/test_run.py: update to new Logfile interface, new
5435 buildbot.slave modules
5436 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5438 * MANIFEST.in: new sample config file
5439 * docs/examples/hello.cfg: same
5441 * buildbot/process/step_twisted.py: remove dead import
5443 * buildbot/process/step.py (RemoteCommand.run): catch errors
5445 (RemoteCommand.remote_update): ignore updates that arrive after
5447 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5448 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5449 the responsibilities of the subclass's methods
5450 (BuildStep.failed): catch errors during failure processing
5451 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5452 (CVS): move to a mode= argument (described in docstring), rather
5453 than the ungainly clobber=/export=/copydir= combination.
5454 (SVN): add mode= functionality to SVN too
5455 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5457 * buildbot/process/base.py (Build.startNextStep): catch errors
5458 during s.startStep()
5460 * buildbot/clients/base.py: update to new PB client interface.
5461 gtkPanes is still broken
5463 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5464 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5465 * setup.py: add buildbot.slave module
5466 * buildbot/bb_tap.py: handle move
5467 * buildbot/slave/registry.py: place to register commands, w/versions
5468 * buildbot/slave/bot.py: major simplifications
5469 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5470 instead of a fixed table. Eventually this will make the slave more
5471 extensible. Use 'start' method on the command, not .startCommand.
5472 Fix unsafeTracebacks handling (I think).
5473 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5474 helper class with a .start method that returns a Deferred.
5475 SlaveShellCommand is the form reached by the buildmaster. Commands
5476 which use multiple ShellCommands can just chain them as Deferreds,
5477 with some helper methods in Command (_abandonOnFailure and
5478 _checkAbandoned) to bail on rc!=0.
5479 (CVSCommand): prefer new mode= argument
5480 (SVNFetch): add mode= argument
5482 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5483 put a useful reason string on the build
5485 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5486 core functionality into an IStatusLog object
5487 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5488 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5489 (StatusResourceBuild.body): use proper accessor methods
5490 * buildbot/status/client.py (RemoteLog): PB-access goes here
5491 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5492 which delivers log contents too
5493 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5494 * buildbot/status/event.py: remove old Logfile completely
5496 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5497 subscription interface for IStatusLog subscriptions just like all
5498 other the status subscriptions
5499 (IStatusReceiver.logChunk): method called on subscribers
5501 2004-08-24 Brian Warner <warner@lothar.com>
5503 * buildbot/process/builder.py (Builder._pong): oops, ping response
5504 includes a result (the implicit None returned by remote_print).
5505 Accept it so the _pong method handles the response correctly.
5507 2004-08-06 Brian Warner <warner@lothar.com>
5509 * buildbot/test/test_config.py: update IRC, PBListener tests
5511 * buildbot/status/client.py (StatusClientPerspective): total
5512 rewrite to match new IStatus interfaces. New subscription scheme.
5513 There are still a few optimizations to make (sending down extra
5514 information with event messages so the client doesn't have to do a
5515 round trip). The logfile-retrieval code is probably still broken.
5516 Moved the PB service into its own port, you can no longer share a
5517 TCP socket between a PBListener and, say, the slaveport (this
5518 should be fixed eventually).
5519 * buildbot/clients/base.py (Client): revamp to match. still needs
5520 a lot of work, but basic event reporting works fine. gtkPanes is
5523 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5524 instance talks to a single irc server. Threw out all the old
5525 multi-server handling code. Still need to add back in
5526 builder-control (i.e. "force build")
5528 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5529 more random text to the as-yet-unreachable per-step page
5531 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5532 rename to stepETAUpdate
5533 (BuildStatus.subscribe): add build-wide ETA updates
5534 (BuilderStatus.getState): remove more cruft
5535 (BuilderStatus.getCurrentBuild): remove more cruft
5536 (BuilderStatus.buildStarted): really handle tuple-subscription
5537 * buildbot/test/test_run.py (Status.testSlave): handle the
5538 stepETAUpdate rename
5540 * buildbot/master.py (BuildMaster): don't add a default
5541 StatusClientService. Don't add a default IrcStatusFactory. Both
5542 are now added through c['status'] in the config file. c['irc'] is
5543 accepted for backwards compatibility, the only quirk is you cannot
5544 use c['irc'] to specify IRC servers on ports other than 6667.
5546 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5547 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5548 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5549 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5552 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5553 the buildmaster to re-read its config file
5556 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5557 find out the port our server is running on
5558 (WebTest.test_webPathname_port): same
5560 * buildbot/test/test_config.py (testWebPortnum): test it
5561 (testWebPathname): ditto
5563 * docs/config.xhtml: document new c['status'] configuration option
5565 * buildbot/status/html.py (Waterfall): new top-level class which
5566 can be added to c['status']. This creates the Site as well as the
5567 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5568 reachable as .parent, for everything.
5570 * buildbot/master.py (Manhole): make it a normal service Child
5571 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5572 webPathname. It will eventually replace c['irc'] and the implicit
5573 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5574 in as (deprecated) backward compatibility hooks for now.
5577 * buildbot/process/builder.py (Builder.buildFinished): don't
5578 inform out builder_status about a finished build, as it finds out
5579 through its child BuildStatus object
5581 * buildbot/status/html.py: extensive revamp. Use adapters to make
5582 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5583 have both starting and finishing times and adjust the waterfall
5584 display accordingly, using spacers if necessary. Use SlaveStatus
5585 to get buildslave info.
5586 (StatusResourceBuildStep): new just-one-step resource, used to get
5587 logfiles. No actual href to it yet.
5589 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5590 the time being, until I get the file-naming scheme right
5592 * buildbot/status/builder.py (Event): clean started/finished names
5593 (BuildStatus.isFinished): .finished is not None is the right test
5594 (BuildStatus.buildStarted): track started/finished times ourselves
5595 (BuilderStatus.getSlave): provide access to SlaveStatus object
5596 (BuilderStatus.getLastFinishedBuild): all builds are now in
5597 .builds, even the currently-running one. Accomodate this change.
5598 (BuilderStatus.eventGenerator): new per-builder event generator.
5599 Returns BuildStepStatus and BuildStatus objects, since they can
5600 both be adapted as necessary.
5601 (BuilderStatus.addEvent): clean up started/finished attributes
5602 (BuilderStatus.startBuild,finishBuild): remove dead code
5603 (SlaveStatus): new object to provide ISlaveStatus
5605 * buildbot/process/step.py (ShellCommand.getColor): actually
5606 return the color instead of setting it ourselves
5607 (CVS.__init__): pull .timeout and .workdir options out of
5608 **kwargs, since BuildStep will ignore them. Without this neither
5609 will be sent to the slave correctly.
5610 (SVN.__init__): same
5612 * buildbot/process/builder.py (Builder): move flags to class-level
5614 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5615 SlaveStatus handle that
5617 * buildbot/process/base.py (Build.firstEvent): remove dead code
5618 (Build.stopBuild): bugfix
5620 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5622 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5623 (ChangeMaster.eventGenerator): yield Changes, since there are now
5624 Adapters to turn them into HTML boxes
5626 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5627 (BotPerspective.attached): feed a SlaveStatus object
5628 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5629 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5631 * buildbot/interfaces.py: API additions
5632 (ISlaveStatus): place to get slave status
5634 2004-08-04 Brian Warner <warner@lothar.com>
5636 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5637 the delay finishes, so the step is marked as SUCCESS
5639 * buildbot/test/test_run.py (Status.testSlave): cover more of
5640 IBuildStatus and IBuildStepStatus
5642 * buildbot/status/progress.py (StepProgress): move some flags to
5643 class-level attributes
5644 (StepProgress.remaining): if there are no other progress metrics
5645 to go by, fall back to elapsed time
5646 (StepProgress.setExpectations): take a dict of metrics instead of
5648 (BuildProgress.setExpectationsFrom): pull expectations from the
5649 Expectations, instead of having it push them to the BuildProgress
5650 (Expectations): move some flags to class-level attributes
5651 (Expectations.__init__): copy per-step times from the
5653 (Expectations.expectedBuildTime): new method for per-build ETA
5655 * buildbot/status/event.py (Logfile): move some flags to
5656 class-level attributes
5657 (Logfile.logProgressTo): better method name, let step set the
5658 progress axis name (instead of always being "output")
5660 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5661 times directly, rather than depending upon the (possibly missing)
5662 .progress object. Use 'None' to indicate "not started/finished
5664 (BuildStepStatus.getExpectations): oops, return the full list of
5666 (BuilderStatus._buildFinished): append finished builds to .builds
5668 * buildbot/process/step.py (BuildStep): add separate .useProgress
5669 flag, since empty .progressMetrics[] still implies that time is a
5671 (CVS): set up the cmd in __init__, instead of waiting for start()
5673 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5674 calculation, this will eventually turn into a proper sourceStamp
5675 (Build.setupBuild): tell the Progress to load from the Expectations,
5676 instead of having the Expectations stuff things into the Progress
5677 (Build.buildException): add a build-level errback to make sure the
5678 build's Deferred fires even in case of exceptions
5680 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5682 * buildbot/process/builder.py (Builder.forceBuild): convey the
5683 reason instead of creating a fake Change
5685 * docs/examples/twisted_master.cfg: update to match reality
5687 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5688 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5689 fix or remove broken/breaking tests
5691 * buildbot/status/event.py (Logfile.__len__): remove evil method
5693 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5694 missing .build, for test convenience
5696 * buildbot/process/step_twisted.py: import fixes
5698 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5700 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5701 .statusbag reference
5703 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5704 connection at shutdown, and stop it from reconnecting
5706 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5707 chase down remote-execution bugs
5709 * buildbot/process/step.py: more fixes, remove
5710 BuildStep.setStatus()
5711 * buildbot/status/builder.py: move setStatus() functionality into
5713 * buildbot/status/event.py: minor fixes
5715 2004-08-03 Brian Warner <warner@lothar.com>
5717 * buildbot/process/base.py, buildbot/process/builder.py
5718 * buildbot/process/step.py, buildbot/status/builder.py
5719 * buildbot/status/event.py, buildbot/test/test_run.py:
5720 fix status delivery, get a basic test case working
5721 * buildbot/master.py: finish implementing basic status delivery,
5722 temporarily disable HTML/IRC/PB status sources
5724 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5726 * buildbot/status/progress.py (BuildProgress): remove dead code
5728 * buildbot/interfaces.py
5729 * buildbot/process/base.py, buildbot/process/builder.py
5730 * buildbot/process/step.py, buildbot/process/step_twisted.py
5731 * buildbot/status/builder.py: Complete overhaul of the all
5732 status-delivery code, unifying all types of status clients (HTML,
5733 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5734 look like. This commit is a checkpointing of the work-in-progress:
5735 the input side is mostly done (Builders/Builds sending status
5736 to the BuilderStatus/BuildStatus objects), but the output side has
5737 not yet been started (HTML resources querying BuilderStatus
5738 objects). Things are probably very broken right now and may remain
5739 so for several weeks, I apologize for the disruption.
5741 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5742 HTML as the log's contents. Currently used for exception tracebacks.
5743 * buildbot/status/progress.py: minor spelling changes
5745 2004-08-02 Brian Warner <warner@lothar.com>
5747 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5748 in mozilla. Also added stylesheets copied from Twisted's docs.
5749 Remember that these files are meant to be run through Lore first.
5750 Thanks to Philipp Frauenfelder for the fixes.
5751 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5752 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5753 * docs/template.tpl: added a Lore template
5755 2004-07-29 Brian Warner <warner@lothar.com>
5757 * buildbot/interfaces.py: revamp status delivery. This is the
5758 preview: these are the Interfaces that will be provided by new
5759 Builder code, and to which the current HTML/IRC/PB status
5760 displayers will be adapted.
5762 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5763 on the SlaveBuilder, not the Bot.
5764 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5766 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5767 set .usePTY on the FakeSlaveBuilder
5769 2004-07-25 Brian Warner <warner@lothar.com>
5771 * buildbot/changes/freshcvs.py: add some debug log messages
5772 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5773 disabled 'setFilter' syntax
5774 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5775 don't end with a slash
5777 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5779 * setup.py: bump to 0.5.0+ while between releases
5781 2004-07-23 Brian Warner <warner@lothar.com>
5783 * setup.py (version): Releasing buildbot-0.5.0
5785 2004-07-23 Brian Warner <warner@lothar.com>
5787 * README: update for 0.5.0 release
5789 * NEWS: update for 0.5.0 release
5791 2004-07-22 Brian Warner <warner@lothar.com>
5793 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5794 mktap-time configuration flag (--usepty=1, --usepty=0)
5795 * buildbot/bot.py: same
5797 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5798 an 'info' directory being unwanted
5800 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5801 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5802 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5803 and earlier), use a FreshCVSSourceOldcred instead.
5804 (test): simple test routine: connect to server, print changes
5806 * buildbot/changes/changes.py (Change.getTime): make it possible
5807 to print un-timestamped changes
5809 * buildbot/master.py (makeApp): delete ancient dead code
5810 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5811 * buildbot/test/test_config.py (testFindConfigFile): test it
5813 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5814 instead of win32 one
5817 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5818 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5821 * buildbot/process/base.py (Builder.__init__): change constructor
5822 to accept a dictionary of config data, rather than discrete
5823 name/slave/builddir/factory arguments
5825 * docs/examples/twisted_master.cfg: update to new syntax
5826 * docs/examples/glib_master.cfg: same
5827 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5828 rough tests of the new syntax
5831 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5832 to be an int, which means "run a web.distrib sub-server on a TCP
5833 port". This lets you publish the buildbot status page to a remote
5834 twisted.web server (using distrib.ResourceSubscription). Also
5835 rename the local attributes used to hold these web things so
5836 they're more in touch with reality.
5837 * buildbot/test/test_web.py: test webPortnum and webPathname
5838 * docs/config.xhtml: document this new use of webPathname
5840 * docs/config.xhtml: new document, slightly ahead of reality
5842 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5843 'prefix' handling: treat it as a simple string to check with
5844 .startswith, instead of treating it as a directory. This allows
5845 sub-directories to be used. If you use prefix=, you should give it
5846 a string that starts just below the CVSROOT and ends with a slash.
5847 This prefix will be stripped from all filenames, and filenames
5848 which do not start with it will be ignored.
5850 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5852 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5853 and --exclude (inverse of --include). SVN post-commit hooks
5854 now have total control over which changes get sent to buildbot and which
5857 2004-07-10 Brian Warner <warner@lothar.com>
5859 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5860 test case to match new API
5862 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5863 which crashed HTML display when self.entries=[] (needed to
5864 distinguish between [], which means "no entries yet", and None,
5865 which means "the entries have been swapped out to disk, go fetch
5868 2004-07-04 Brian Warner <warner@lothar.com>
5870 * buildbot/process/step_twisted.py (countFailedTests): Count
5871 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5872 10kb from the end because any import errors are wedged there and
5873 they would make us think the test log was unparseable.
5874 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5876 2004-06-26 Brian Warner <warner@lothar.com>
5878 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5879 delete-*.pyc command into an actual BuildStep, so we can label it
5881 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5882 (FullTwistedBuildFactory): same
5884 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5886 * contrib/fakechange.py: Add an errback when sending the fake
5887 change, so we know it didn't work.
5889 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5891 * buildbot/process/step_twisted.py: Delete *.pyc files before
5892 calling trial, so it doesn't catch any old .pyc files whose .py
5893 files have been moved or deleted.
5895 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5896 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5897 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5898 instead of ["twisted.test"], so that the end result is "trial -R
5901 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5902 regular expression to match filenames that should be ignored when
5903 changed. Also add a --revision parameter that specifies the
5904 revision to examine, which is useful for debugging.
5906 2004-06-25 Brian Warner <warner@lothar.com>
5908 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5909 summary of warnings (like DeprecationWarnings), next to the
5912 2004-05-13 Brian Warner <warner@lothar.com>
5914 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5915 we now have a w32 build slave courtesy of Mike Taylor.
5917 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5918 so broken. Fixed a race condition that tripped up interlocked
5919 builds and caused the status to be stuck at "Interlocked" forever.
5920 The twisted buildbot's one interlocked build just so happened to
5921 never hit this case until recently (the feeding builds both pass
5922 before the interlocked build is attempted.. usually it has to wait
5924 (Builder._pong_failed): fix method signature
5926 * setup.py: bump to 0.4.3+ while between releases
5928 2004-04-30 Brian Warner <warner@lothar.com>
5930 * setup.py (version): Releasing buildbot-0.4.3
5932 2004-04-30 Brian Warner <warner@lothar.com>
5934 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5936 * README: update for 0.4.3 release
5938 * NEWS: update for 0.4.3 release
5940 * buildbot/master.py (BuildMaster.__getstate__): make sure
5941 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5943 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5944 .trial as a class attribute, for upgrade from 0.4.2
5946 * buildbot/changes/changes.py (Change.links): add .links for
5949 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5950 .textWatchers and .htmlWatchers at save time, since they are both
5951 volatile, should allow smooth 0.4.2 upgrade
5953 * buildbot/process/step.py (CVS.finishStatus): catch failed
5954 CVS/SVN commands so we can make the status box red
5956 2004-04-29 Brian Warner <warner@lothar.com>
5958 * buildbot/changes/freshcvs.py
5959 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5960 code to do setFilter(), which tells the freshcvs daemon to not
5961 send us stuff that we're not interested in. I will uncomment it
5962 when a new version of CVSToys is available in which setFilter()
5963 actually works, and I get a chance to test it better.
5965 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5967 * buildbot/master.py (Dispatcher): use a registration scheme
5968 instead of hardwired service names
5969 (BuildMaster): keep track of the Dispatcher to support
5972 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5973 PBChangeSource class instead of having it be an undocumented
5974 internal feature of the ChangeMaster. Split out the code into a
5976 * buildbot/changes/pb.py (PBChangeSource): same
5977 * buildbot/test/test_changes.py: a few tests for PBChangeSource
5979 * docs/{factories|sources|steps}.xhtml: document some pieces
5981 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
5982 using FCMaildirSource
5983 (f23osx): update OS-X builder to use python2.3, since the slave
5984 was updated to Panther (10.3.3)
5986 2004-03-21 Brian Warner <warner@lothar.com>
5988 * buildbot/process/process_twisted.py: factor out doCheckout, change
5989 to use SVN instead of CVS
5991 * buildbot/process/base.py (BasicBuildFactory): refactor to make
5992 an SVN subclass easier
5993 (BasicSVN): subclass which uses Subversion instead of CVS
5995 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
5997 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
5999 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6001 2004-02-25 Brian Warner <warner@lothar.com>
6003 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6004 is now either a list (which is passed to spawnProcess directly) or
6005 a string (which gets passed to /bin/sh -c). This removes the useSH
6006 flag and the ArgslistCommand class. Also send status header at the
6007 start and end of each command, instead of having the master-side
6009 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6010 -r'. Update to use list-based arguments.
6011 (SVNFetch): use list-based arguments, use ['dir'] argument to
6013 * buildbot/test/test_steps.py (Commands): match changes
6015 * buildbot/process/step.py (InternalShellCommand.words): handle
6017 (SVN): inherit from CVS, cleanup
6019 * buildbot/status/event.py (Logfile.content): render in HTML, with
6020 stderr in red and headers (like the name of the command we're
6021 about to run) in blue. Add link to a second URL (url + "?text=1")
6022 to get just stdout/stderr in text/plain without markup. There is
6023 still a problem with .entries=None causing a crash, it seems to occur
6024 when the logfile is read before it is finished.
6026 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6027 timeout to the keepalives, and use it to explicitly do a
6028 loseConnection instead of waiting for TCP to notice the loss. This
6029 ought to clear up the silent-lossage problem.
6030 (unsafeTracebacks): pass exception tracebacks back to the master,
6031 makes it much easier to debug problems
6033 2004-02-23 Brian Warner <warner@lothar.com>
6035 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6036 the whole command to /bin/sh instead of execve [Johan Dahlin]
6037 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6038 '-r HEAD' [Johan Dahlin]
6039 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6041 * buildbot/changes/changes.py (Change): add links= argument, add
6042 asHTML method [Johan Dahlin]. Modified to make a bit more
6043 XHTMLish. Still not sure how to best use links= .
6045 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6046 Change.asHTML to display the change, not asText
6048 * buildbot/status/html.py (StatusResourceBuilder): web button to
6051 * buildbot/test/test_run.py: test to actually start a buildmaster
6054 * MANIFEST.in: bring back accidentally-dropped test helper files
6056 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6057 that require cvstoys if it is not installed
6059 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6060 values of "bin/trial" [Dave Peticolas]
6061 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6062 tests passed" when we didn't happen to run any tests
6064 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6065 flunkOnFailure [Johan Dahlin]
6067 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6068 multiple instances of the same Step class by suffixing "_2", etc,
6069 to the name until it is unique. This name needs to be unique
6070 because it is used as a key in the dictionary that tracks build
6072 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6075 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6077 2004-01-14 Brian Warner <warner@lothar.com>
6079 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6080 kicked from a channel, log it
6082 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6083 something over whatever IRC channels the buildmaster is currently
6084 connected to. Added to try and track down a problem in which the
6085 master thinks it is still connected but the IRCd doesn't see it. I
6086 used a styles.Versioned this time, so hopefully users won't have
6087 to rebuild their .tap files this time.
6088 * contrib/debug.glade: add a "Poke IRC" button
6089 * contrib/debugclient.py: same
6091 * setup.py: bump to 0.4.2+ while between releases
6093 2004-01-08 Brian Warner <warner@lothar.com>
6095 * setup.py (version): Releasing buildbot-0.4.2
6097 2004-01-08 Brian Warner <warner@lothar.com>
6099 * NEWS: update for 0.4.2 release
6101 * README: document how to run the tests, now that they all pass
6103 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6105 * buildbot/process/step.py (CVS): add a global_options= argument,
6106 which lets you set CVS global options for the command like "-r"
6107 for read-only checkout, or "-R" to avoid writing in the
6109 * buildbot/slavecommand.py (CVSCommand): same
6111 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6112 testing easier (it is turned off when testing, to avoid the
6115 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6116 to make it easier to test: break generateStepID() out to a
6117 separate function, only update statusbag if it exists.
6118 (ShellCommands): create useful text for dict-based commands too.
6120 * test/*, buildbot/test/*: move unit tests under the buildbot/
6122 * setup.py (packages): install buildbot.test too
6124 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6125 * buildbot/test/test_steps.py: fix it, tests pass now
6127 2004-01-06 Brian Warner <warner@lothar.com>
6129 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6130 freshcvs mail uses a slightly different syntax for new
6131 directories. Update parser to handle either.
6132 * test/test_mailparse.py (Test1.testMsg9): test for same
6134 2003-12-21 Brian Warner <warner@lothar.com>
6136 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6137 'warnOnWarnings' so that lintian errors mark the build orange
6139 2003-12-17 Brian Warner <warner@lothar.com>
6141 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6142 messages emitted by Bonsai, contributed by Stephen Davis.
6144 * test/*: moved all tests to use trial instead of unittest. Some
6145 still fail (test_steps, test_slavecommand, and test_process).
6147 * setup.py (version): bump to 0.4.1+ while between releases
6149 2003-12-09 Brian Warner <warner@lothar.com>
6151 * setup.py (version): Releasing buildbot-0.4.1
6153 2003-12-09 Brian Warner <warner@lothar.com>
6155 * NEWS: update for 0.4.1 release
6157 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6158 freebsd builder code a little bit
6160 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6161 don't try to compare attributes of different classes
6162 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6163 (MaildirSource.messageReceived): fix Change delivery
6165 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6166 into the config file's namespace before loading it, like the
6167 documentation claims it does
6168 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6169 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6170 daemon comes back online
6172 2003-12-08 Brian Warner <warner@lothar.com>
6174 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6175 so the example will work with online=0 as well
6177 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6178 fix the __implements__ line
6180 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6181 class a twisted.application.service.Service, use startService to
6184 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6185 directory fd instead of simple open(). I'm sure this used to work,
6186 but the current version of python refuses to open directories with
6189 2003-12-05 Brian Warner <warner@lothar.com>
6191 * setup.py (version): bump to 0.4.0+ while between releases
6193 2003-12-05 Brian Warner <warner@lothar.com>
6195 * setup.py (version): Releasing buildbot-0.4.0
6197 2003-12-05 Brian Warner <warner@lothar.com>
6199 * docs/examples/glib_master.cfg: replace old sample scripts with
6200 new-style config files
6201 * MANIFEST.in: include .cfg files in distribution tarball
6203 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6204 implement a dummy method to avoid the exception that occurs when
6205 freshcvs sends this to us.
6207 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6208 removed the method, as it broke reconnection. Apparently
6209 stopFactory is called each time the connection attempt fails. Must
6211 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6212 attribute before serialization, since without stopFactory the
6213 reconnect timer may still be active and they aren't serializable.
6215 * test/test_mailparse.py (ParseTest): test with 'self' argument
6217 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6218 argument, as these "functions" are invoked like methods from class
6219 attributes and therefore always get an instance as the first
6222 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6223 message: thanks to Stephen Davis for the catch
6225 2003-12-04 Brian Warner <warner@lothar.com>
6227 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6228 twisted's standard ReconnectingClientFactory. Handles both oldcred
6229 and newcred connections. Also has a bug-workaround for
6230 ReconnectingClientFactory serializing its connector when it
6233 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6234 pbutil. Replace makeApp stuff with proper newcred/mktap
6235 makeService(). Don't serialize Ephemerals on shutdown.
6237 * buildbot/changes/changes.py (ChangeMaster): make it a
6238 MultiService and add the sources as children, to get startService
6239 and stopService for free. This also gets rid of the .running flag.
6241 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6242 new pbutil, turn into a TCPClient at the same time (to get
6243 startService for free). Two variants exist: FreshCVSSourceOldcred
6244 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6245 yet, but when it does, we'll be ready).
6246 (FreshCVSSource.notify): handle paths which are empty after the
6247 prefix is stripped. This only happens when the top-level (prefix)
6248 directory is added, at the very beginning of a Repository's life.
6250 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6251 Now the only reconnecting code is in the factory where it belongs.
6252 (Builder.unsubscribe): unregister the disconnect callback when we
6253 delete the builder on command from the master (i.e. when the
6254 buildmaster is reconfigured and that builder goes away). This
6255 fixes a multiple-delete exception when the status client is shut
6257 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6260 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6261 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6263 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6265 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6266 a list of globs (ugh). The testdir will be searched for files
6267 named *.tests and run the tests in the order specified in each of
6268 those files. This allows for "dependancies" between tests to be
6271 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6272 argument to pass to run_maxq.py, instead of a glob.
6274 2003-10-17 Brian Warner <warner@lothar.com>
6276 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6277 files that live in the sandbox
6279 2003-10-15 Brian Warner <warner@lothar.com>
6281 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6282 spelling error in "docs" count-warnings output
6283 (HLint.start): stupid thinko meant .xhtml files were ignored
6285 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6286 tests now that cReactor is banished to the sandbox
6288 2003-10-10 Brian Warner <warner@lothar.com>
6290 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6291 scheme: now .xhtml are sources and .html are generated
6293 2003-10-08 Brian Warner <warner@lothar.com>
6295 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6296 we were ignoring the 'randomly' parameter.
6298 2003-10-01 Brian Warner <warner@lothar.com>
6300 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6301 posix, to kill sub-children of aborted slavecommands.
6303 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6304 Clean up initialization: lastBuildStatus remains None until the
6305 first build has been completed.
6307 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6308 None as a lastBuildStatus
6309 * buildbot/clients/gtkPanes.py: same
6311 * buildbot/status/client.py (StatusClientService): keep
6312 BuilderStatus objects in self.statusbags . These objects now live
6313 here in the StatusClientService and are referenced by the Builder
6314 object, rather than the other way around.
6315 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6316 * buildbot/process/base.py (Builder): same
6317 * test/test_config.py (ConfigTest.testBuilders): same
6319 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6320 an existing builder, leave the statusbag alone. This will preserve the
6323 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6324 hook. This will probably go away in favor of a class in upcoming
6327 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6328 serviceName from newcred FreshCVSNotifiee setup
6330 2003-09-29 Brian Warner <warner@lothar.com>
6332 * buildbot/process/process_twisted.py: switch to new reactor
6334 * docs/examples/twisted_master.cfg: same
6336 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6338 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6339 botmaster reference instead of the oldapp service lookup
6341 * buildbot/master.py (BuildMaster.__init__): give the
6342 StatusClientService a reference to the botmaster to make it easier to
6345 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6347 * buildbot/status/html.py (Box.td): escape hreffy things so you
6348 can have spaces in things like builder names
6349 (StatusResourceBuilder.body)
6350 (WaterfallStatusResource.body)
6351 (WaterfallStatusResource.body0): same
6353 2003-09-25 Brian Warner <warner@lothar.com>
6355 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6356 rearrange the builder list when adding or removing builders: keep
6357 them in the order the user requested.
6358 * test/test_config.py (ConfigTest.testBuilders): verify it
6360 * contrib/debug.glade: give the debug window a name
6362 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6363 now wait on multiple interlocks. Fix code relating to that.
6364 (Builder.checkInterlocks): same
6365 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6367 * buildbot/master.py (BuildMaster.loadConfig): move from
6368 deprecated pb.BrokerFactory to new pb.PBServerFactory
6369 * test/test_config.py (ConfigTest.testWebPathname): same
6371 * docs/examples/twisted_master.cfg: fix interlock declaration
6373 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6374 Interlocks to their Builders into interlock.py .
6375 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6377 * test/test_config.py (ConfigTest.testInterlocks): validate
6380 * buildbot/process/base.py (Builder.__init__): better comments
6381 * buildbot/process/interlock.py (Interlock.__repr__): same
6382 (Interlock.deactivate): add .active flag, move the code that
6383 attaches/detaches builders into the Interlock
6385 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6387 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6388 tests using the new run_maxq.py script, and reporting failures by
6391 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6392 tests, reporting their success or failure in a buildbot-friendly
6395 2003-09-24 Brian Warner <warner@lothar.com>
6397 * docs/examples/twisted_master.cfg: example of a new-style config
6398 file. This lives in the buildmaster base directory as
6401 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6402 button to make the master re-read its config file
6404 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6405 buildmaster configuration from a file. This file can be re-read
6406 later, and the buildmaster will update itself to match the new
6407 desired configuration. Also use new Twisted Application class.
6408 * test/Makefile, test/test_config.py: unit tests for same
6410 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6411 FreshCVSSources comparable, to support reload.
6412 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6414 * buildbot/process/base.py (Builder): make them comparable, make
6415 Interlocks easier to attach, to support reload. Handle
6416 re-attachment of remote slaves.
6417 * buildbot/process/interlock.py (Interlock): same
6419 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6420 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6421 buildmaster taps are now constructed with mktap.
6422 * buildbot/status/client.py (StatusClientService): same
6424 * buildbot/status/words.py: move to new Services, add support to
6425 connect to multiple networks, add reload support, allow nickname
6426 to be configured on a per-network basis
6428 2003-09-20 Brian Warner <warner@lothar.com>
6430 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6431 the freebsd builder, now that the machine has been upgraded and no
6432 longer has python2.2
6434 * setup.py (version): bump to 0.3.5+ while between releases
6436 2003-09-19 Brian Warner <warner@lothar.com>
6438 * setup.py (version): Releasing buildbot-0.3.5
6440 2003-09-19 Brian Warner <warner@lothar.com>
6442 * NEWS: add post-0.3.4 notes
6444 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6446 * MANIFEST.in: add contrib/*
6448 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6449 use a remote root now: cvs.twistedmatrix.com
6451 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6453 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6454 compatibility with old servers
6455 (FreshCVSSource.start): and provide a way to use it
6456 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6458 * docs/examples/twisted_master.py (twisted_app): update to new
6460 (twisted_app): listen on new ~buildbot socket
6461 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6463 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6464 to reduce cvs bandwidth (update instead of full checkout)
6466 2003-09-11 Brian Warner <warner@lothar.com>
6468 * contrib/fakechange.py: demo how to connect to the changemaster
6469 port. You can use this technique to submit changes to the
6470 buildmaster from source control systems that offer a hook to run a
6471 script when changes are committed.
6473 * contrib/debugclient.py: tool to connect to the debug port. You
6474 can use it to force builds, submit fake changes, and wiggle the
6477 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6478 'Dispatcher' realm to handle all the different kinds of
6479 connections and Perspectives: buildslaves, the changemaster port,
6480 the debug port, and the status client port. NewCredPerspectives
6481 now have .attached/.detached methods called with the remote 'mind'
6482 reference, much like old perspectives did. All the pb.Services
6483 turned into ordinary app.ApplicationServices .
6484 (DebugService): went away, DebugPerspectives are now created
6485 directly by the Dispatcher.
6486 (makeApp): changed interface a little bit
6488 * buildbot/changes/changes.py: newcred
6489 * buildbot/status/client.py: newcred
6491 * buildbot/clients/base.py: newcred client side changes
6492 * buildbot/bot.py: ditto
6494 * docs/examples/glib_master.py: handle new makeApp() interface
6495 * docs/examples/twisted_master.py: ditto
6497 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6498 base newcred Perspectives on. This should go away once Twisted
6499 itself provides something sensible.
6502 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6504 * contrib/svn_buildbot.py: A program that you can call from your
6505 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6506 when a change in an SVN repository has happened. See the top of
6507 the file for some minimal usage info.
6509 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6511 * buildbot/slavecommand.py (ArglistCommand): Add new
6512 ArglistCommand that takes an argument list rather than a string as
6513 a parameter. Using a st.split() for argv is very bad.
6515 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6516 update to a particular revision rather than always checking out
6517 (still not very smart about it, there may be cases where the
6518 checkout becomes inconsistent).
6520 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6522 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6523 SVN fetch support. It can checkout (not update!) a specified
6524 revision from a specified repository to a specified directory.
6526 * buildbot/status/progress.py (Expectations.update): Fix an
6527 obvious bug (apparently created by the change described in the
6528 previous ChangeLog message) by moving a check to *after* the
6529 variable it checks is defined.
6532 2003-09-08 Brian Warner <warner@lothar.com>
6534 * buildbot/status/progress.py (Expectations.update): hack to catch
6535 an exception TTimo sees: sometimes the update() method seems to
6536 get called before the step has actually finished, so the .stopTime
6537 is not set, so no totalTime() is available and we average None
6538 with the previous value. Catch this and just don't update the
6539 metrics, and emit a log message.
6541 2003-08-24 Brian Warner <warner@lothar.com>
6543 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6544 parameter to set copydir='original' in CVS commands.
6546 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6548 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6549 which tells the command to maintain a separate original-source CVS
6550 workspace. For each build, this workspace will be updated, then
6551 the tree copied into a new workdir. This reduces CVS bandwidth
6552 (from a full checkout to a mere update) while doubling the local
6553 disk usage (to keep two copies of the tree).
6555 2003-08-21 Brian Warner <warner@lothar.com>
6557 * buildbot/status/event.py (Logfile.addEntry): if the master web
6558 server dies while we're serving a page, request.write raises
6559 pb.DeadReferenceError . Catch this and treat it like a
6560 notifyFinish event by dropping the request.
6562 2003-08-18 Brian Warner <warner@lothar.com>
6564 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6565 (instead of blowing up) if a force-build command is given without
6568 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6569 don't blow up if there aren't yet any Changes in the list
6571 2003-08-02 Brian Warner <warner@lothar.com>
6573 * buildbot/bot.py (updateApplication): don't set the .tap name,
6574 since we shouldn't assume we own the whole .tap file
6576 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6577 'mktap buildbot' (without a subcommand) better
6579 2003-07-29 Brian Warner <warner@lothar.com>
6581 * buildbot/status/words.py
6582 (IrcStatusFactory.clientConnectionLost): when we lose the
6583 connection to the IRC server, schedule a reconnection attempt.
6585 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6586 use shutil.rmtree instead of forking off an "rm -rf" command.
6587 rmtree may take a while and will block until it finishes, so we
6588 use "rm -rf" if available.
6590 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6591 freebsd buildslave badly
6593 * setup.py (version): bump to 0.3.4+ while between releases
6595 2003-07-28 Brian Warner <warner@lothar.com>
6597 * setup.py (version): Releasing buildbot-0.3.4
6599 2003-07-28 Brian Warner <warner@lothar.com>
6601 * NEWS: update in preparation for release
6603 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6604 process.signalProcess instead of os.kill, to improve w32
6607 * docs/examples/twisted_master.py (twisted_app): turn off
6608 win32eventreactor: the tests hang the buildslave badly
6610 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6611 failed builds, since usually the failures are consistent
6613 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6614 add compileOpts/compileOpts2 to reactors build
6616 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6617 (twisted_app): use both default and win32eventreactor on w32 build.
6618 Use both default and kqreactor on freebsd build.
6620 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6621 add compileOpts2, which is put after the build_ext argument. w32
6622 needs "-c mingw32" here.
6624 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6625 touch .acqpath, it goes away in recent Twisted releases
6627 * docs/examples/twisted_master.py (twisted_app): use "python" for
6628 the w32 buildslave, not "python2.2"
6630 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6631 the directory exists.. should hush an exception under w32
6633 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6634 ProcessTerminated -provided values for signal and exitCode rather
6635 than parsing the unix status code directly. This should remove one
6636 more roadblock for a w32-hosted buildslave.
6638 * test/test_mailparse.py: add test cases for Syncmail parser
6640 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6641 temporary compatibility import. Note! Start importing
6642 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6644 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6646 2003-07-27 Brian Warner <warner@lothar.com>
6648 * NEWS: started adding new features
6650 * buildbot/changes/mail.py: start work on Syncmail parser, move
6651 mail sources into their own file
6653 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6654 as implementing IChangeSource
6655 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6657 * buildbot/interfaces.py: define the IChangeSource interface
6659 2003-07-26 Brian Warner <warner@lothar.com>
6661 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6663 2003-06-25 Brian Warner <warner@lothar.com>
6665 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6668 2003-06-17 Brian Warner <warner@lothar.com>
6670 * buildbot/status/words.py: clean up method usage to avoid error
6671 in silly IRC command
6672 (IrcStatusBot.emit_status): round off seconds display
6674 * buildbot/process/base.py (Build): delete the timer when saving
6675 to the .tap file, and restore it (if it should still be running)
6676 upon restore. This should fix the "next build in -34 seconds"
6677 messages that result when the master is restarted while builds are
6678 sitting in the .waiting slot. If the time for the build has
6679 already passed, start it very soon (in 1 second).
6681 * buildbot/status/words.py: more silly commands
6683 * README (REQUIREMENTS): add URLs to all required software
6685 * buildbot/status/words.py ('last'): mention results of, and time
6688 2003-05-28 Brian Warner <warner@lothar.com>
6690 * buildbot/status/words.py: add 'last' command
6691 (IrcStatusBot.emit_status): add current-small text to 'status' output
6693 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6694 (twisted_app): remove spaces from OS-X builder name
6696 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6697 * buildbot/status/words.py: IRC bot should actually be useful now
6699 2003-05-23 Brian Warner <warner@lothar.com>
6701 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6702 "slave information" from $(slavedir)/info/* . These files are
6703 maintained by the slave administrator, and describe the
6704 machine/environment that is hosting the slave. Information from
6705 them is put into the "Builder" HTML page. Still need to establish
6706 a set of well-known filenames and meanings for this data: at the
6707 moment, *all* info/* files are sent to the master, but only
6708 'admin' and 'host' are used on that end.
6709 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6710 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6711 * buildbot/master.py (BotPerspective.got_info): ditto
6713 2003-05-22 Brian Warner <warner@lothar.com>
6715 * setup.py (version): bump version to 0.3.3+ while between releases
6717 2003-05-21 Brian Warner <warner@lothar.com>
6719 * setup.py: Releasing buildbot-0.3.3
6721 2003-05-21 Brian Warner <warner@lothar.com>
6723 * NEWS: 0.3.3 news items
6725 * README: describe --keepalive and life behind a NAT box
6727 * buildbot/bot.py (Bot.connected): implement application-level
6728 keepalives to deal with NAT timeouts, turn them on with
6729 --keepalive option or when SO_KEEPALIVE doesn't work.
6731 * buildbot/master.py (BotPerspective): accept keepalives silently
6733 * buildbot/process/base.py (Build.buildException): CopiedFailures
6734 don't carry as much information as local ones, so don't try to
6735 create a big HTMLized version of them.
6737 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6738 log file when step fails due to an exception, such as when the slave
6741 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6742 --testmodule argument instead of grepping for test-case-name tags
6743 ourselves. Remove FindUnitTests code.
6744 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6746 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6748 2003-05-16 Brian Warner <warner@lothar.com>
6750 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6751 argument to allow things like CFLAGS=-O0 to be passed without relying
6752 upon /bin/sh processing on the slave.
6754 * buildbot/process/step.py (InternalShellCommand.start): send
6756 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6757 'split' instead of letting /bin/sh do it. This should also remove
6758 the need for /bin/sh on the buildslave, making it more likely to
6761 * buildbot/status/html.py: html-escape text in blamelist.
6762 Add "force build" button to the Builder page.
6764 * buildbot/process/step_twisted.py (countFailedTests): look at
6765 last 1000 characters for status line, as import errors can put it
6766 before the -200 point.
6768 2003-05-15 Brian Warner <warner@lothar.com>
6770 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6772 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6773 make 'clobber' a parameter, so it is possible to have builds which
6774 do full tests but do a cvs update instead of hammering the CVS
6775 server with a full checkout each build
6777 * buildbot/process/step.py (InternalShellCommand): bump default
6778 timeout to 20 minutes
6780 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6781 the master to trigger a build. Run it via manhole.
6783 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6784 allow slaves to trigger any build that they host, to make life
6785 easier for slave admins who are testing out new build processes
6787 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6788 don't flunk cReactor or qtreactor on failure, since they fail alot
6789 these days. Do warnOnFailure instead.
6791 * buildbot/process/base.py: change Builder.buildable from a list
6792 into a single slot. When we don't have a slave, new builds (once
6793 they make it past the timeout) are now merged into an existing
6794 buildable one instead of being queued. With this change, a slave
6795 which has been away for a while doesn't get pounded with all the
6796 builds it missed, but instead just does a single build.
6798 2003-05-07 Brian Warner <warner@lothar.com>
6800 * setup.py (version): bump version to 0.3.2+ while between releases
6802 2003-05-07 Brian Warner <warner@lothar.com>
6804 * setup.py: Releasing buildbot-0.3.2
6806 2003-05-07 Brian Warner <warner@lothar.com>
6808 * setup.py: fix major packaging error: include subdirectories!
6810 * NEWS: add changes since last release
6812 * README (REQUIREMENTS): update twisted/python dependencies
6814 * buildbot/status/builder.py (Builder.startBuild): change
6815 BuildProcess API: now they should call startBuild/finishBuild
6816 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6817 keeping a list of builds in the statusbag, to support other kinds of
6819 (Builder.addClient): send current-activity-small to new clients
6820 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6823 * buildbot/status/client.py: drop RemoteReferences at shutdown
6825 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6827 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6828 more debug messages for remote status client
6830 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6831 (.stepFailed): only fire the Deferred once, even if both
6832 stepComplete and stepFailed are called. I think this can happen if
6833 an exception occurs at a weird time.
6835 * buildbot/status/words.py: work-in-progress: IRC status delivery
6837 2003-05-05 Brian Warner <warner@lothar.com>
6839 * docs/examples/twisted_master.py (twisted_app): hush internal
6840 python2.3 distutils deprecation warnings
6841 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6842 add compileOpts= argument which inserts extra args before the
6843 "setup.py build_ext" command. This can be used to give -Wignore
6844 warnings, to hush some internal python-2.3 deprecation messages.
6846 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6847 the ['twisted.test'] default test case to make it easier to change
6850 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6851 * buildbot/clients/gtkPanes.py: ditto
6853 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6854 arg to collapse RunUnitTestsRandomly into RunUnitTests
6855 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6856 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6858 * buildbot/status/html.py (StatusResource): shuffle Resources
6859 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6860 would serve the waterfall display, but the internal links were
6861 only valid on the trailing-slash version. The correct behavior is
6862 for the non-slashed one to serve a Redirect to the slashed one.
6863 This only shows up when the buildbot page is hanging off another
6864 server, like a Twisted-Web distributed server.
6866 * buildbot/status/event.py (Event, RemoteEvent): make Events
6867 pb.Cacheable, with RemoteEvent as the cached version. This removes
6868 a lot of explicit send-an-update code.
6869 * buildbot/status/builder.py (Builder): remove send-update code
6870 * buildbot/status/client.py (ClientBuilder): remove send-update
6871 code, and log errors that occur during callRemote (mostly to catch
6872 InsecureJelly exceptions)
6874 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6875 run Lore with the same python used in the rest of the build
6877 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6879 * buildbot/process/step_twisted.py (HLint): accept 'python'
6880 argument. Catch rc!=0 and mark the step as failed. This marks the
6881 build orange ("has warnings").
6882 (RunUnitTestsJelly): move out to step_twisted2.py
6884 * buildbot/util.py (ignoreStaleRefs): add utility function
6886 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6887 don't fake ETA object, it's too hard to get right
6889 2003-05-02 Brian Warner <warner@lothar.com>
6891 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6893 2003-05-01 Brian Warner <warner@lothar.com>
6895 * buildbot/status/html.py (StatusResource.body): oops, I was
6896 missing a <tr>, causing the waterfall page to be misrendered in
6897 everything except Galeon.
6899 2003-04-29 Brian Warner <warner@lothar.com>
6901 * docs/examples/twisted_master.py: make debuild use python-2.2
6902 explicitly, now that Twisted stopped supporting 2.1
6904 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6905 handle tuple results too. I keep forgetting this, which suggests
6906 it needs to be rethought.
6908 * setup.py (setup): bump version to 0.3.1+ while between releases
6910 2003-04-29 Brian Warner <warner@lothar.com>
6912 * setup.py: Releasing buildbot-0.3.1
6914 2003-04-29 Brian Warner <warner@lothar.com>
6916 * README (SUPPORT): add plea to send questions to the mailing list
6918 * NEWS, MANIFEST.in: add description of recent changes
6920 * docs/examples/twisted_master.py: add the code used to create the
6921 Twisted buildmaster, with passwords and such removed out to a
6924 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6925 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6926 buildmasters to not require CVSToys be installed.
6927 * README, docs/examples/glib_master: update to match the change
6929 * buildbot/clients/base.py, buildbot/bot.py,
6930 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6931 ReconnectingPB from CVSToys distribution to remove CVSToys
6932 dependency for build slaves and status clients. Buildmasters which
6933 use FreshCVSSources still require cvstoys be installed, of course.
6935 2003-04-25 Brian Warner <warner@lothar.com>
6937 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6938 runTestsRandomly arg to turn on trial -z
6940 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6941 experimental code to use trial's machine-parseable output to get
6942 more detailed test results. Still has some major issues.
6943 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6946 * buildbot/status/builder.py (Builder.setCurrentBuild):
6947 anticipating moving build history into statusbag, not used yet
6949 * buildbot/status/tests.py: code to centralize test results,
6950 doesn't work quite yet
6952 * buildbot/status/event.py (Event): use hasattr("setName") instead
6953 of isinstance for now.. need better long-term solution
6955 * buildbot/status/html.py: Remove old imports
6957 2003-04-24 Brian Warner <warner@lothar.com>
6959 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6960 ignore changes under doc/fun/ and sandbox/
6962 * buildbot/process/step_twisted.py: update pushEvent and friends.
6964 * buildbot/status/html.py (Box.td): replace event.buildername with
6965 event.parent.getSwappableName(). Needs more thought.
6967 * buildbot/status/builder.py (Builder): Replace pushEvent and
6968 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6969 Tell events they are being pruned with event.delete().
6971 * buildbot/process/base.py (Build): Remove Builder status-handling
6972 methods. s/pushEvent/setCurrentActivity/.
6974 * buildbot/process/step.py (BuildStep): clean up status delivery.
6975 Gouse builder.statusbag methods instead of intermediate builder
6976 methods. s/updateLastEvent/updateCurrentActivity/.
6977 s/finalizeLastEvent/finishCurrentActivity/. Use
6978 addFileToCurrentActivity for summaryFunction.
6980 * buildbot/status/event.py (Logfile): put data in a Swappable when
6982 (Event): add more setter methods. Remove .buildername, use .parent
6983 and getSwappableName instead (needs more thought).
6985 * buildbot/util.py (Swappable):
6986 * test/test_swap.py: don't bother setting filename at __init__
6987 time, do it later. Change setFilename args to take parent first,
6988 since it provides the most significant part of the filename.
6990 2003-04-23 Brian Warner <warner@lothar.com>
6992 * buildbot/status/event.py (Logfile.addEntry): append to previous
6995 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
6996 anticipating Swappable
6997 (InternalShellCommand.remoteUpdate): split out various log-adding
6998 methods so subclasses can snarf stdout separately
7000 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7001 in anticipation of Swappable build logs
7002 (Builder.testsFinished): anticipating TestResults, still disabled
7004 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7007 * buildbot/status/event.py (Logfile): add (disabled) support for
7008 Swappable, not ready for use yet
7010 * buildbot/util.py (Swappable): object which is swapped out to
7011 disk after some period of no use.
7012 * test/test_swap.py: test buildbot.utils.Swappable
7014 2003-04-14 Brian Warner <warner@lothar.com>
7016 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7017 periodic-build timer. Set the .periodicBuildTime on a builder
7018 instance to some number of seconds to activate it.
7020 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7022 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7023 a way that survives result tuples
7025 2003-04-12 Brian Warner <warner@lothar.com>
7027 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7028 return a dict instead of a tuple: allow summarizers to provide
7029 multiple summaries if they want
7030 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7031 (debuildSummarizer): summarize lintian warnings/errors
7033 2003-04-10 Brian Warner <warner@lothar.com>
7035 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7037 2003-04-09 Brian Warner <warner@lothar.com>
7039 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7040 empty summaries: happens when the tests fail so hard they don't emit
7041 a parseable summary line.
7043 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7044 Allow summaryFunction to return None to indicate no summary should
7047 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7048 writing to stale HTTP requests: notice when they disconnect and
7049 remove the request from the list. Also add CacheToFile from
7050 moshez, will be used later.
7052 2003-04-08 Brian Warner <warner@lothar.com>
7054 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7055 should be an int, not a list of strings
7057 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7058 if we weren't actually connected
7060 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7061 to show the tail end of the trial text output
7063 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7064 hook to summarize the results of a ShellCommand
7066 2003-04-07 Brian Warner <warner@lothar.com>
7068 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7069 twisted test suite code into a single class.
7070 * buildbot/process/process_twisted.py: same
7072 2003-04-04 Brian Warner <warner@lothar.com>
7074 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7076 * README (SLAVE): document use of mktap to create slave .tap file
7077 (REQUIREMENTS): describe dependencies
7079 * buildbot/bb_tap.py, buildbot/plugins.tml:
7080 * buildbot/bot.py (updateApplication): Add mktap support for creating
7081 buildslave .tap files
7083 2003-03-28 Brian Warner <warner@lothar.com>
7085 * buildbot/process/step.py (InternalShellCommand.finished): handle
7086 new tuple result values (fix embarrasing bug that appeared during
7089 2003-03-27 Brian Warner <warner@lothar.com>
7091 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7094 2003-03-25 Brian Warner <warner@lothar.com>
7096 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7097 to overall build status
7098 * buildbot/clients/base.py (Builder): improve event printing
7099 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7100 instead of generic ShellCommand
7101 (Build): Add .stopBuild, use it when slave is detached
7103 * buildbot/process/step.py (Configure,Test): give the steps their
7104 own names and status strings
7106 * buildbot/status/html.py (StatusResource): add "show" argument,
7107 lets you limit the set of Builders being displayed.
7109 2003-03-20 Brian Warner <warner@lothar.com>
7111 * buildbot/process/basic.py: removed
7113 2003-03-19 Brian Warner <warner@lothar.com>
7115 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7116 turn off process-docs by default
7118 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7119 when displaying build information without anything in allBuilds[]
7121 * buildbot/bot.py (makeApp): really take password from sys.argv
7123 2003-03-18 Brian Warner <warner@lothar.com>
7125 * buildbot/bot.py (buildApp): take password from sys.argv
7127 * README: replace with more useful text
7129 * setup.py: add a real one
7130 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7132 * docs/PyCon-2003/: added sources for PyCon paper.
7134 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7135 now Build objects control the process and Builder only handles
7136 slave stuff and distribution of changes/status. A new BuildFactory
7137 class creates Build objects on demand.
7139 Created ConfigurableBuild which takes a list of steps to run. This
7140 makes it a lot easier to set up a new kind of build and moves us
7141 closer to being able to configure a build from a web page.
7143 * buildbot/process/step_twisted.py, process_twisted.py: move to
7144 new model. A lot of code went away.
7146 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7147 send lots of empty progress messages to the client.
7149 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7151 2003-02-20 Brian Warner <warner@lothar.com>
7153 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7155 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7156 Twisted bug that prevented non-pty processes from working just got
7157 fixed, and the bug that leaks ptys is still being investigated.
7159 * buildbot/process/step.py (CVS): send timeout arg to slave
7161 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7162 builders coming and going
7163 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7164 from CVSToys, handle lost-buildmaster
7166 * buildbot/status/client.py (StatusClientService.removeBuilder):
7167 Clean up status client protocol: send builders (with references)
7168 as they are created, rather than sending a list and requiring the
7169 client to figure out which ones are new.
7170 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7171 attempts to force a build on an unknown builder
7173 2003-02-19 Brian Warner <warner@lothar.com>
7175 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7176 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7177 Twisted stops leaking them.
7178 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7179 builder goes to an idle state.
7181 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7182 I figure out why CVS commands hang without them, and/or I fix the
7183 hung-command timeout
7185 2003-02-16 Brian Warner <warner@lothar.com>
7187 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7188 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7189 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7190 GenerateDocs now that they are prefixed with WARNING:.
7192 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7193 use manual href target instead of request.childLink
7195 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7196 display every second, but update the ETA every 5 seconds (or
7197 whenever) as remote_progress messages arrive.
7200 2003-02-12 Brian Warner <warner@lothar.com>
7202 * *: import current sources from home CVS repository
7206 # add-log-time-format: add-log-iso8601-time-string