1 2006-12-10 Brian Warner <warner@lothar.com>
3 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
4 * docs/buildbot.texinfo: set version to match
6 2006-12-10 Brian Warner <warner@lothar.com>
8 * README (REQUIREMENTS): update for release
9 * NEWS: update for release
10 * buildbot/slave/commands.py (command_version): mention that this
11 version (2.2) was released with buildbot-0.7.5
13 * buildbot/test/test_config.py (StartService.testStartService):
14 inhibit the usual read-config-on-startup behavior, since otherwise
15 the log.err that gets recorded causes the test to fail
17 * buildbot/status/builder.py (LogFile.finish): forget about all
18 subscribers once the log has finished, since after that point
19 we're never going to use them again. This might help free up some
22 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
23 than the old/deprecated gtk.mainquit()
25 2006-12-09 Brian Warner <warner@lothar.com>
27 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
28 better when we can't open the masterdst file
30 * buildbot/scripts/startup.py (Follower._failure): add missing
31 import statement for BuildSlaveDetectedError
33 * buildbot/steps/transfer.py (FileUpload): cleanup
34 (FileDownload): same. Add tests for slave version, add mode=.
35 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
36 (SlaveFileDownloadCommand): same
37 * buildbot/test/test_transfer.py: enhance tests
38 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
41 2006-12-08 Brian Warner <warner@lothar.com>
43 * buildbot/scripts/runner.py (sendchange): halt the reactor on
44 both success *and* failure. Without this, the 'buildbot
45 sendchange' command would hang if it could not contact the
46 buildmaster or deliver the Change, which would generally cause the
47 user's commit/record/checkin command to hang too. Thanks to
48 Christian Unger for the catch.
50 2006-12-06 Brian Warner <warner@lothar.com>
52 * NEWS: update with items for the next release
54 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
55 whimsical example pulled from a punch-drunk email I sent out late
57 (Transferring Files): document some of the other parameters
58 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
59 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
60 * buildbot/test/test_svnpoller.py: same
61 * buildbot/changes/svnpoller.py (SVNPoller): same
63 2006-11-26 Brian Warner <warner@lothar.com>
65 * docs/buildbot.texinfo (Build Properties): remind users that
66 WithProperties must appear in a command= list, not as a top-level
68 * buildbot/steps/shell.py (ShellCommand.start): and assert that
69 we're sending a list or a single string to the RemoteShellCommand
71 * buildbot/scheduler.py (Nightly): Improve docs slightly.
73 * buildbot/scripts/startup.py (start): skip the whole
74 watch-the-logfile thing under windows, since it needs os.fork()
76 * buildbot/scripts/runner.py (restart): remove the old message
77 that got printed after the buildbot was restarted.. it most cases
78 it didn't get printed at the right time anyways
80 2006-11-25 Brian Warner <warner@lothar.com>
82 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
83 follow twistd.log and print lines until the process has started
84 started properly. For the buildmaster, this means until the config
85 file has been parsed and accepted. For the buildslave, this means
86 until we've connected to the master. We give up after 5 seconds in
87 any case. Helpful error messages and troubleshooting suggestions
88 are printed when we don't see a successful startup. This closes the
89 remainder of SF#1517975.
90 * buildbot/scripts/startup.py: moved app startup code to here
91 * buildbot/scripts/logwatcher.py: utility class to follow log
92 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
93 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
94 so the LogWatcher can tell the difference between a buildmaster
97 2006-11-24 Brian Warner <warner@lothar.com>
99 * docs/examples/twisted_master.cfg: update to match the version
100 in use on twistedmatrix.com
101 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
102 was using before stopped working, but 'irc.freenode.net' works
105 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
108 * buildbot/clients/base.py (TextClient.not_connected): upon
109 UnauthorizedLogin failures, remind the user to connect to the
110 PBListener port instead of the slaveport.
111 (TextClient.disconnected): shut down more quietly
112 * docs/buildbot.texinfo (statuslog): add another reminder
114 * buildbot/scripts/runner.py (Options.subCommands): rename
115 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
116 'sighup' as an alias.
117 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
118 reconfig command to follow twistd.log and print all of the lines
119 from the start of the config-file reload to its completion. This
120 should make it a lot easier to discover bugs in the config file.
121 Use --quiet to disable this behavior. This addresses half of
122 SF#1517975, the other half will be to add this same utility to
123 'buildbot start' and 'buildbot restart'.
124 * docs/buildbot.texinfo (Loading the Config File): same
127 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
128 method, it has been deprecated for a long time. Use
129 IBuilderControl.requestBuild instead.
130 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
131 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
132 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
133 * buildbot/test/test_control.py (Force.testForce): same
134 * buildbot/test/test_run.py: use requestBuild instead
136 * buildbot/clients/debug.py: replace 'Force Build' button with
137 'Request Build' (which just adds one to the queue), add Ping
138 Builder, add branch/revision fields to Request Build.
139 * buildbot/clients/debug.glade: same
140 * buildbot/master.py: update interface to match. This creates an
141 incompatibility between new debugclients and old buildmasters.
143 * buildbot/process/builder.py (Builder._attached): delay the call
144 to maybeStartBuild for a reactor turn, to avoid starting a build
145 in the middle of a reconfig (say, if the new Builder uses a new
146 slave which is already connected).
148 2006-11-23 Brian Warner <warner@lothar.com>
150 * buildbot/test/test_transfer.py: appease pyflakes
151 * buildbot/test/test_steps.py: same
153 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
154 keeps pyflakes from finding undefined names
156 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
157 Builder no longer induces a disconnect/reconnect cycle. This means
158 that any builds currently in progress will not be interrupted, and
159 any builds which are queued in the Builder will not be lost. This
160 is implemented by having the new Builder extract the state (i.e.
161 all pending Builds and any desired SlaveBuilders) from the old
163 (BotPerspective): refactor. The BotPerspective no longer keeps
164 track of all the Builders that want to use this slave; instead, it
165 asks the BotMaster each time it needs this list. This removes
166 addBuilder and removeBuilder. Clean up attached() to acquire all
167 the slave's information in a more atomic fashion. updateSlave() is
168 now the way to make sure the slave is using the right set of
169 Builders: just call it after everything else has been
171 (BotMaster): refactor, removing addBuilder/removeBuilder and
172 replacing them with an all-at-once setBuilders() call.
174 * buildbot/test/test_slaves.py (Reconfig): new test case to
175 exercise this functionality
176 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
177 * buildbot/slave/commands.py (WaitCommand): same
179 * docs/buildbot.texinfo (Loading the Config File): document the
182 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
183 SlaveBuilder to have its parent Builder changed.
184 (SlaveBuilder.isAvailable): new method to give access to state,
185 which is now a private attribute
186 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
187 the SlaveBuilder about how it is being used. These methods update
188 its internal state. buildFinished() is now the place that invokes
189 maybeStartBuild() on its parent Builder.
190 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
191 new Builder to take over for an old one, transferring state from
193 (Buider): refactor the way that SlaveBuilders are used to match,
194 giving them a bit more autonomy.
195 (Builder.buildFinished): this no longer calls maybeStartBuild():
196 instead the SlaveBuilder calls it on whoever its parent Builder is
197 at the time. This way, when an old Builder is replaced by a new
198 one, and there was a build in progress during the transition, when
199 that build finishes, it will be the new Builder that is told about
200 the newly available slave so it can start a new build.
202 * buildbot/process/base.py (Build.startBuild._release_slave): when
203 the Build finishes, tell the SlaveBuilder that they've been
206 * buildbot/status/builder.py (SlaveStatus): add some new setter
207 methods for use by BotPerspective, to keep some attributes more
210 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
211 called by the buildmaster.
212 (Bot.setBuilderList): instead, we locally announce any leftover
213 directories based upon which Builders we were told about. The
214 master doesn't really care; it's the local admin who may or may not
218 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
219 to allow use of python2.4 or whatever. This tool still requires
222 2006-11-19 Brian Warner <warner@lothar.com>
224 * NEWS (IStatusLog.readlines): more news items
226 2006-11-18 Brian Warner <warner@lothar.com>
228 * NEWS: start collecting items for the next release.
230 2006-11-04 Brian Warner <warner@lothar.com>
232 * buildbot/changes/bonsaipoller.py: apply updates from Ben
233 Hearsum. Closes SF#1590310.
234 * buildbot/test/test_bonsaipoller.py: and tests
236 * buildbot/status/tinderbox.py
237 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
238 status when the build results in WARNINGS. Patch from Dave
239 Liebreich. Closes SF#1587352.
241 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
242 linux-vs-osx behavior difference w.r.t. reading from files that
243 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
244 to Mark Rowe for the patch.
246 2006-10-15 Brian Warner <warner@lothar.com>
248 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
249 method name was misspelled in the interface definition. Thanks to
250 Roy Rapoport for the catch.
252 2006-10-13 Brian Warner <warner@lothar.com>
254 * docs/buildbot.texinfo (Adding LogObservers): update sample code
255 to match the great Steps renaming
257 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
258 Maybe I should run my own unit tests before recording a big
259 change. Good thing I've got a buildbot to remind me.
261 2006-10-12 Brian Warner <warner@lothar.com>
263 * buildbot/steps/transfer.py: rework __init__ and args setup
264 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
266 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
267 when opening the target file, only catch IOError (to report via
268 stderr/rc!=0), let the others be reported as normal exceptions
270 2006-10-08 Brian Warner <warner@lothar.com>
272 * contrib/svn_watcher.py: fix security holes by using proper argv
273 arrays and subprocess.Popen() rather than commands.getoutput().
274 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
275 is deprecated in favor of buildbot/changes/svnpoller.py, and will
276 probably be removed by the next release.
279 2006-10-04 Brian Warner <warner@lothar.com>
281 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
282 initial lines that weren't emitted by pyflakes. When the pyflakes
283 command is run under a Makefile, 'make' will echo the command it
284 runs to stdio, and that was getting logged as a "misc" warning.
285 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
286 * buildbot/test/test_steps.py (testPyFlakes3): another test
288 2006-10-01 Brian Warner <warner@lothar.com>
290 * buildbot/status/html.py (HtmlResource.render): if we get a
291 unicode object from our content() method, encode it into utf-8
292 like we've been claiming to all along. This allows the comments
293 and author names from svnpoller.py to be delivered properly.
295 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
296 de-unicodify filenames before creating the Change, because the
297 rest of buildbot is unlikely to handle them well. Leave the 'who'
298 field as a unicode object.. I don't think there's anything that
299 will break very soon, and it will probably nudge us towards
300 accepting unicode everywhere sooner or later. Stop using the
301 "date" field that comes out of SVN, since it is using the
302 repository's clock (and timezone) and what we care about is the
303 buildmaster's (otherwise Changes from the future show up later
304 than the builds they triggered).
305 * buildbot/test/test_svnpoller.py (Everything.test1): match the
308 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
309 Suvbersion repository polling ChangeSource. I've hacked it up
310 considerably: any bugs are entirely my own fault. Thank you
312 * buildbot/test/test_svnpoller.py: tests for it
313 * docs/buildbot.texinfo (SvnSource): document it
315 2006-09-30 Brian Warner <warner@lothar.com>
317 * buildbot/scheduler.py (Periodic): submit a reason= to the
318 BuildSet to indicate which Scheduler triggered the build. Thanks
319 to Mateusz Loskot for the suggestion.
321 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
323 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
324 changes: set self.loop in __init__, remove unused volatile=
326 * docs/buildbot.texinfo (.buildbot config directory): add more
327 docs on the .buildbot/options keys used by "buildbot try"
328 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
329 (Try.deliverJob): same
331 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
335 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
336 close the filehandle when we stop watching the file. Before, the
337 filehandle was only closed when the LogFileWatcher was
338 garbage-collected, which could be quite a while in the future. If
339 it was still open by the time the next build started, windows will
340 refuse to let the new build delete the old build/ directory. Fixes
341 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
342 #twisted for the catch.
344 2006-09-29 Brian Warner <warner@lothar.com>
346 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
349 2006-09-25 Brian Warner <warner@lothar.com>
351 * setup.py: the new buildbot.steps module wasn't being installed.
352 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
353 (testmsgs): add the extra stuff from buildbot/test/* so you can
354 run unit tests on an installed copy of buildbot, not just from
357 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
358 columns of 'svnlook changed' output contain status information, so
359 strip [:4] instead of [:6]. Depending upon what the status flags
360 were, this would sometimes lead to mangled filenames. Thanks to
361 Riccardo Magliocchetti for the patch. Closes SF#1545146.
363 * buildbot/steps/source.py (Monotone): initial Monotone support,
364 contributed by Nathaniel Smith. Still needs docs and tests, but
365 this code has been in use on the Monotone buildbot for a long
367 * buildbot/slave/commands.py (Monotone): slave-side support
368 * buildbot/changes/monotone.py (MonotoneSource): polling change
371 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
372 contributed a Change Source that polls a Bonsai server (a
373 kind of web-based viewcvs CGI script).
375 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
376 Hearsum contributed a status plugin which sends email in the same
377 format that Tinderbox does: this allows a number of tinderbox
378 tools to be driven by Buildbot instead. Thanks Ben!
380 2006-09-24 Brian Warner <warner@lothar.com>
382 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
383 Thanks to Robert Helmer for the patch.
385 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
386 BuildStatus about the buildslave name at the *beginning* of the
387 build, rather than at the end. Thanks to Alexander Lorenz for the
389 * buildbot/status/html.py (StatusResourceBuild.body): always
390 include the slavename in the build page, not just when the build
392 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
393 slavename in the email message
395 2006-09-21 Brian Warner <warner@lothar.com>
397 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
399 * docs/examples/glib_master.cfg: same
400 * docs/examples/hello.cfg: same
401 * docs/examples/twisted_master.cfg: same, update to current usage
403 2006-09-19 Brian Warner <warner@lothar.com>
405 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
406 (PyFlakes.createSummary): make it compatible with python-2.2
408 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
409 for at least the output-parsing parts of PyFlakes
411 2006-09-18 Brian Warner <warner@lothar.com>
413 * buildbot/steps/python.py: oops, fix import of StringIO
415 2006-09-17 Brian Warner <warner@lothar.com>
417 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
418 turns out that SVN-1.4.0 doesn't fail to update once you've
419 replaced a file with a directory, unlike older versions of SVN and
420 pretty much every other VC tool we support. Since what we really
421 care about is that the update succeeds anyway, stop checking that
422 the tree got clobbered and just assert that the build succeeded.
423 (VCBase.printLogs): add a utility function for debugging
425 * buildbot/process/step.py: oops, added extra imports by mistake
427 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
428 rstrip() on the first line coming out of the 'p4 describe'
429 process, to remove the stray ^M that Wade Brainerd reports seeing
430 in the 'when' field. Fixes SF#1555985.
432 * buildbot/master.py (BuildMaster.loadConfig): improve the error
433 message logged when c['schedulers'] is not right
434 * buildbot/scheduler.py (Scheduler.__init__): improve error
435 message when a Scheduler() is created with the wrong arguments
436 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
437 verify that these error messages are emitted
439 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
440 The idea is that all the base classes (like BuildStep and
441 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
442 will be a leftover backwards-compatibility file that only contains
443 aliases for the steps that were moved out to buildbot.steps.*
444 * lots: change imports to match
445 * buildbot/process/step.py: add a DeprecationWarning if it ever
448 2006-09-12 Brian Warner <warner@lothar.com>
450 * buildbot/scheduler.py (Scheduler.__init__): make sure that
451 builderNames= is actually a sequence, since if you happen to give
452 it a single builder-specification dictionary instead, it won't get
453 caught by the existing assert. Thanks to Brett Neely for the
456 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
458 * docs/buildbot.texinfo (Python BuildSteps): document them
459 (sendchange): include a link to PBChangeSource, since you need one
461 * buildbot/steps/shell.py: clean up test-case-name line, remove some
463 * buildbot/steps/dummy.py: same
465 2006-09-08 Brian Warner <warner@lothar.com>
467 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
468 BuildStep which lets you transfer files from the master to the
469 slave or vice versa. Thanks to Albert Hofkamp for the original
470 patch. Fixes SF#1504631.
471 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
473 (SlaveFileDownloadCommand): same
474 * docs/buildbot.texinfo (Transferring Files): document it
475 * buildbot/test/test_transfer.py: test it
476 * buildbot/test/runutils.py (StepTester): new utility class for
477 testing BuildSteps and RemoteCommands without Builds or Bots or PB
478 * buildbot/test/test_steps.py (CheckStepTester): validate that the
481 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
482 walk through StatusLogs one line at a time, mostly for the benefit
483 of ShellCommand.createSummary methods. You can either walk through
484 STDOUT or STDERR, but the default is STDOUT.
486 * buildbot/status/builder.py (LogFile.readlines): implement it.
487 Note that this is not yet memory-efficient, it just pulls the
488 whole file into RAM and then splits it up with a StringIO.
489 Eventually this should be a generator that only pulls chunks from
491 * buildbot/test/test_status.py (Log.testReadlines): test it
493 * docs/buildbot.texinfo: update to match changes
494 * buildbot/process/factory.py: stop using old definitions
495 * buildbot/process/process_twisted.py: same
496 * buildbot/test/test_*.py: same
498 * buildbot/process/step_twisted.py: move definition to..
499 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
500 relative-import mechanisms prevent this from being named 'twisted'
501 or 'python/twisted' as I would have preferred.
503 * buildbot/process/maxq.py: move definition to..
504 * buildbot/steps/maxq.py: .. here, leave a compatibility import
506 * buildbot/process/step.py: split the user-visible BuildSteps into
507 separate files, all under buildbot/steps/
508 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
509 * buildbot/steps/shell.py: this holds ShellCommand and friends
510 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
512 2006-09-05 Brian Warner <warner@lothar.com>
514 * lots: run pyflakes, removed a lot of unused imports, changed the
515 form of some conditional imports to remove false pyflakes
516 warnings. There are still a number of warnings left, mostly from
517 imports that are done for their side-effects.
518 * buildbot/test/test_vc.py: import twisted.python.failure, since it
521 2006-08-26 Brian Warner <warner@lothar.com>
523 * buildbot/test/test_locks.py (Unit.testLater): make the tests
524 compatible with twisted-1.3.0, for some reason I just can't seem
525 to let go of the past.
527 2006-08-25 Brian Warner <warner@lothar.com>
529 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
531 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
532 all logfiles= in startCommand(), rather than in start() . This
533 makes it easier to have the 'stdio' log come before any secondary
534 logfiles, which I feel makes the waterfall display more
536 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
537 from ShellCommand up into LoggingBuildStep
538 (LoggingBuildStep.__init__): move the handling of logfiles= from
539 ShellCommand up to LoggingBuildStep, because startCommand is
540 provided by LoggingBuildStep, whereas start() was specific to
541 subclasses like ShellCommand and Source. This removes code
542 duplication in those subclasses.
543 (ShellCommand.__init__): same
544 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
545 for a slave that's too old to understand logfiles= into a separate
546 method, so it can live in ShellCommand. The rest of
547 setupLogfiles() can live in LoggingBuildStep.
549 2006-08-24 Brian Warner <warner@lothar.com>
551 * buildbot/locks.py (BaseLock): you can now configure Locks to
552 allow multiple simultaneous owners. They still default to
553 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
555 * docs/buildbot.texinfo (Interlocks): document the new options
556 * buildbot/test/test_locks.py: add a bunch of new unit tests
557 * buildbot/process/base.py (Build.acquireLocks): locks now offer
558 waitUntilMaybeAvailable, not waitUntilAvailable
559 * buildbot/process/step.py (BuildStep.acquireLocks): same
560 * buildbot/master.py (BotMaster.getLockByID): real locks now use
561 the whole lockid in their constructor, not just the name. Also,
562 keep track of which real locks we've handed out by the full
563 lockid, not just class+name, otherwise changing just the maxCount=
564 in the master.cfg file would not actually cause a behavioral
567 2006-08-23 Brian Warner <warner@lothar.com>
569 * buildbot/__init__.py (version): bump to 0.7.4+ while between
571 * docs/buildbot.texinfo: same
573 2006-08-23 Brian Warner <warner@lothar.com>
575 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
576 * docs/buildbot.texinfo: set version to match
577 * NEWS: update for 0.7.4
578 * buildbot/slave/commands.py (command_version): mention that this
579 version (2.1) was released with buildbot-0.7.4
581 2006-08-22 Brian Warner <warner@lothar.com>
585 * CREDITS: new file, list of people who have helped. Thanks!
586 * MANIFEST.in: ship it
588 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
589 new diagrams, the user's manual is more informative than it was.
590 Start shipping the .html user's manual (and generated .png
592 * Makefile: update 'release' target to match
594 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
595 test.. I think the web-parts effort will render it pointless well
596 before it ever actually starts to work.
598 2006-08-20 Brian Warner <warner@lothar.com>
600 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
601 meaning of the prefix= argument. It is now just a string which is
602 stripped from the beginning of the filename. If prefix= is set but
603 not found on any given filename, that filename is ignored. If all
604 filenames in a Change are ignored, the Change is dropped. This is
605 much simpler than the previous sep= nonsense, and I should have
606 implemented it this way from the beginning. Effectively resolves
607 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
608 Gedminas for the catch and suggested fixes.
609 (ChangePerspective.perspective_addChange): implement the actual
611 * buildbot/test/test_changes.py (TestChangePerspective): test it
612 * docs/buildbot.texinfo (PBChangeSource): document it, explain
613 how to properly use prefix=
614 * docs/examples/twisted_master.cfg (source): update prefix= by
615 adding the trailing slash
618 * docs/examples/twisted_master.cfg: update to actual practice
620 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
621 update test case to match new link text.. the HREF has both a
622 class= setting and an enclosing [] pair that I didn't match in the
625 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
626 list of strings is preferred over a single string with embedded
628 (ShellCommand.description=): explain that either single strings or
629 a list of strings is acceptable, and why you might prefer one over
630 the other. Add an example. Fixes SF#1524659, thanks to Paul
631 Winkler for the catch.
632 (Build Steps): update to use f.addStep() rather than using s()
633 and the constructor list
635 * buildbot/process/step.py (ShellCommand): accept either a single
636 string or a list of strings in both description= and
638 * buildbot/test/test_steps.py (Steps.test_description): test it
639 * buildbot/test/runutils.py (makeBuildStep): support for that test
641 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
642 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
643 collecting the files and creating the patch.
645 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
646 per-step URLs that will be displayed on the waterfall display,
647 for things like the HTML output of code-coverage tools, when
648 the results are hosted elsewhere.
649 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
650 way to retrieve these URLs
651 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
652 the method to retrieve these URLs. Also provide backwards
653 compatibility for saved BuildStepStatus instances that didn't have
655 * buildbot/process/step.py (BuildStep.addURL): method to set these
656 URLs from within a BuildStep
657 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
658 (StepBox.getBox): give these external links a distinct CSS class
659 named "BuildStep external" so a .css file can display them
662 * buildbot/test/test_web.py (WaterfallSteps): test that we really
664 * buildbot/test/test_steps.py (Steps): test that we can all the
665 URLs. Also add a bunch of other tests on methods that can be
666 called from within BuildSteps
667 * buildbot/test/runutils.py (makeBuildStep): add utility function
669 2006-08-13 Brian Warner <warner@lothar.com>
671 * docs/buildbot.texinfo (BuildStep LogFiles): document them
673 2006-08-10 Brian Warner <warner@lothar.com>
675 * docs/buildbot.texinfo (Index of master.cfg keys): add another
676 index, this one of things like c['sources'] and c['schedulers']
677 (indices): it looks like my clever idea of putting the @fooindex
678 commands in between the @node and the @subsection (to make the
679 HREF anchor jump to slightly above the section title, which works
680 much better in html) confused texinfo horribly, so I'm moving the
681 index tags back to be just after the @subsection marker. I also
682 added extra lines between the @node/@section paragraph and the
683 index tags, since I think maybe texinfo wants to see these be
686 * docs/Makefile (images): make sure images get built when
688 * docs/images/Makefile: same
690 * buildbot/scripts/runner.py: rename 'buildbot master' to
691 'buildbot create-master', and 'buildbot slave' to 'buildbot
693 * docs/buildbot.texinfo: same
696 * docs/buildbot.texinfo: reimplement the "useful classes" index
697 with actual texinfo indices. The .info rendering is a bit
698 weird-looking but it works well, and the HTML rendering is quite
699 nice. This also puts the index targets in the regular flow of the
700 text, which is easier to maintain.
702 2006-08-06 Brian Warner <warner@lothar.com>
704 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
705 Kevin Turner to prefer the environ= argument be a list rather than
706 a string. If it is a list, it will be joined with a platform-local
707 os.pathsep delimiter, and then prepended to any existing
708 $PYTHONPATH value. This works better in cross-platform (i.e.
709 windows buildslaves) environments when you need to push multiple
710 directories onto the front of the path.
711 (SlaveShellCommand): documented the new magic
712 * docs/buildbot.texinfo (ShellCommand): documented the new magic
713 in a user-visible form
715 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
716 Turner to prefer lists over strings when creating/running VC
717 commands during unit tests. This is clearly necessary to survive
718 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
719 renamed the wq() function to qw() though, since that's how it's
720 spelled in perl. Eventually I'd prefer all commands to be
721 specified with lists.
723 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
724 which are deleted (or not yet created) correctly. Also add
725 failsafe code to not explode if the file-watching poller doesn't
726 get started. Thanks to JP Calderone for the catch and the poller
728 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
730 * buildbot/test/emitlogs.py: same
732 * NEWS: summarize recent changes
734 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
735 clause to avoid the "host key mismatch" warning
737 * buildbot/process/step_twisted.py (Trial.start): if the
738 buildslave is too old to understand logfiles=, fall back to
739 running 'cat _trial_temp/test.log' like before.
740 (Trial.commandComplete): same. this takes advantage of the
741 LoggingBuildStep refactoring to stall commandComplete long enough
742 to run a second RemoteShellCommand.
744 * buildbot/process/step.py (LoggingBuildStep.startCommand):
745 refactor command-completion handling, to allow methods like
746 commandComplete/createSummary/evaluateCommand to return Deferreds.
747 (LoggingBuildStep._commandComplete): delete the refactored method
748 (ShellCommand.setupLogfiles): if the buildslave is too old to
749 understand logfiles=, put a warning message both into twistd.log
750 and into the otherwise empty user-visible LogFiles.
752 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
753 callers to provide the slave-side logfile name, rather than
754 forcing it to come from the local name of the LogFile.
755 (BuildStep.getSlaveName): new method
757 * buildbot/process/base.py (Build.getSlaveName): new method, so
758 steps can find out which buildslave they're running on
760 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
761 to match the s/cvs_ver/command_version/ change
763 2006-08-05 Brian Warner <warner@lothar.com>
765 * buildbot/slave/commands.py (command_version): replace the CVS
766 auto-updated cvs_ver keyword with a manually-updated variable,
767 since CVS is no longer the master repository. Add a description of
768 the remote API change starting in this version (2.1), specifically
769 the fact that SlaveShellCommand now accepts 'initial_stdin',
770 'keep_stdin_open', and 'logfiles'.
772 2006-07-31 Brian Warner <warner@lothar.com>
774 * docs/buildbot.texinfo (System Architecture): Finally add lots of
775 diagrams to describe how the whole system fits together. The
776 images themselves are kept in SVG files, with ascii-art versions
777 in corresponding .txt files. Texinfo knows how to interpolate the
778 text version into .info files, reference the .png versions from
779 .html files, and include .eps versions in the .ps format.
780 * docs/images/Makefile: tools to create .png and .eps
781 * docs/images/*.svg: created pictures with Inkscape.
782 * .darcs-boring: ignore the generated .eps and .png files
784 2006-07-24 Brian Warner <warner@lothar.com>
786 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
787 Scheduler names, since they cause setServiceParent to explode
789 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
791 2006-07-20 Brian Warner <warner@lothar.com>
793 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
794 which runs the buildbot unit tests
796 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
797 classes that are useful in master.cfg
799 2006-07-15 Brian Warner <warner@lothar.com>
801 * Makefile (some-apidocs): new target to build only some epydocs
803 * setup.py: minor comment.. does the classifiers= argument prevent
804 the setup.py script from working on python2.2/2.3?
806 * buildbot/scripts/sample.cfg: update manhole example, arrange into
809 * buildbot/twcompat.py: fix minor typo in comments
811 * buildbot/manhole.py: move all Manhole-related code out to this
812 module. Implement SSH-based manholes (with TwistedConch), and move
813 to conch's nifty line-editing syntax-coloring REPL shell instead
814 of the boring non-editing monochromatic (and deprecated) old
816 * buildbot/master.py: remove all Manhole-related code
817 (BuildMaster.loadConfig._add): make sure the old manhole is
818 removed before we add the new one
819 * docs/buildbot.texinfo (Debug options): document new Manhole options
821 * buildbot/twcompat.py (_which): fix some epydoc issues
822 * buildbot/status/html.py (Waterfall.__init__): same
824 2006-06-29 Brian Warner <warner@lothar.com>
826 * buildbot/interfaces.py: get Interface from b.twcompat to hush
827 deprecation warnings under newer Twisteds (by using
828 zope.interface.Interface instead of old twisted.python.components
830 * buildbot/slave/interfaces.py: same
832 2006-06-28 Brian Warner <warner@lothar.com>
834 * buildbot/slave/commands.py (SVN): add --non-interactive to all
835 svn commands, so it will fail immediately instead of hanging while
836 it waits for a username/password to be typed in.
838 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
839 log message if the step was shut down
841 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
842 obsolete reference to mktap.
844 2006-06-20 Brian Warner <warner@lothar.com>
846 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
847 test to include new 'logfiles' argument sent from master to slave
849 2006-06-19 Brian Warner <warner@lothar.com>
851 * buildbot/process/step_twisted.py (Trial): track Progress from
852 _trial_temp/test.log too
854 * buildbot/process/step.py (OutputProgressObserver): generalize
855 the earlier StdioProgressObserver into an OutputProgressObserver
856 that can track LogFiles other than stdio.
857 (LoggingBuildStep.__init__): same
859 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
860 _trial_temp/test.log, not a separate 'cat' command. TODO: this
861 will fail under windows because of os.sep issues. It might have
862 worked before if 'cat' was doing cygwin path conversion.
864 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
865 creation of LogFileWatchers
866 (ShellCommand._startCommand): and record the files that were
867 watched in the 'headers' section of the ShellCommand output
869 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
870 need to actually pass it to the slave if you want it to work.
871 (ShellCommand): document it a bit
873 * buildbot/test/test_shell.py: new test to validate LogFiles
874 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
876 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
877 before printing the last batch of lines, to test that the polling
878 logic is working properly
880 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
881 handling, making it possible to track multiple logs for a single
882 RemoteCommand. The previous single logfile is now known as the
884 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
885 (RemoteShellCommand.__init__): accept logfiles=
886 (LoggingBuildStep.startCommand): stdio_log is now one of many
887 (ShellCommand): added logfiles= argument, as well as a class-level
888 .logfiles attribute, which will be merged together to figure out
889 which logfiles should be tracked. The latter maybe be useful for
890 subclasses of ShellCommand which know they will aways produce
891 secondary logfiles in the same location.
893 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
894 and closeStdin() methods, preparing to make it possible to write
895 to a ShellCommand's stdin at any time, not just at startup. These
896 writes are buffered if the child process hasn't started yet.
897 (LogFileWatcher): new helper class to watch arbitrary logfiles
898 while a ShellCommand runs. This class polls the file every two
899 seconds, and sends back 10k chunks to the buildmaster.
900 (ShellCommand): rename stdin= to initialStdin=, and add
901 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
903 (ShellCommand.addLogfile): LogFile text is sent in updates with a
904 key of "log" and a value of (logname, data).
905 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
906 'logfiles' to the master-visible args dictionary.
907 (SourceBase.doPatch): match s/stdin/initialStdin/ change
910 * buildbot/test/test_vc.py (Patch.testPatch): same
913 * buildbot/test/emit.py: write to a logfile in the current
914 directory. We use this to figure out what was used as a basedir
915 rather than looking to see which copy of emit.py gets run, so that
916 we can run the commands from inside _trial_temp rather than inside
918 * buildbot/test/subdir/emit.py: same
919 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
920 argument rather than running from buildbot/test/
921 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
922 rather than using an implicit setUp()
923 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
924 (ShellBase.testShell1, etc): use explicit path to emit.py instead
925 of assuming that we're running in buildbot/test/ (and that '.' is
928 * buildbot/slave/commands.py (Command.doStart): refactor Command
929 startup/completion a bit: now the SlaveBuilder calls doStart(),
930 which is not meant for overridding by subclasses, and doStart()
931 calls start(), which is. Likewise the SlaveBuilder calls
932 doInterrupt(), and subclasses override interrupt(). This also puts
933 responsibility for maintaining .running in Command rather than in
935 (Command.doInterrupt): same
936 (Command.commandComplete): same, this is called when the deferred
937 returned by start() completes.
938 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
939 (SlaveBuilder.remote_interruptCommand): same
940 (SlaveBuilder.stopCommand): same
942 2006-06-16 Brian Warner <warner@lothar.com>
944 * buildbot/test/test_shell.py: new test file to contain everything
945 relating to ShellCommand
946 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
947 multiple logfiles in realtime" feature, not yet implemented
948 * buildbot/test/emitlogs.py: support file for testLogFiles
949 * docs/buildbot.texinfo (ShellCommand): document the feature
951 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
953 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
954 for tests which exercise SlaveCommands in isolation.
956 * buildbot/test/test_slavecommand.py: Move some utilities like
957 SignalMixin and FakeSlaveBuilder from here ..
958 * buildbot/test/runutils.py: .. to here, so they can be used by
959 other test classes too
960 * buildbot/test/test_vc.py: more SignalMixin refactoring
961 * buildbot/test/test_control.py: same
962 * buildbot/test/test_run.py: and some rmtree refactoring
964 2006-06-15 Brian Warner <warner@lothar.com>
966 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
967 'testBranch' to match other VC tests and have the tests run in
968 roughly increasing order of dependency
970 * buildbot/test/test_steps.py (LogObserver): new test to verify
971 LogObservers can be created at various times and still get
972 connected up properly
974 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
975 to create BuildStepStatus instances that actually work.
977 * buildbot/process/step.py (LogObserver): add outReceived and
978 errReceived base methods, to be overridden
980 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
981 API to take a name instead of a step, reducing the coupling
982 somewhat. This returns the BuildStepStatus object so it can be
983 passed to the new Step, instead of jamming it directly into the
985 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
987 * buildbot/process/base.py (Build.setupBuild): use both methods
988 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
989 process a bit to match
991 2006-06-14 Brian Warner <warner@lothar.com>
993 * docs/buildbot.texinfo (Adding LogObservers): add some limited
994 docs on writing new LogObserver classes
995 (Writing New Status Plugins): brief docs on how Status Plugins fit
998 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
999 implement a LogObserver that counts how many unit tests have been
1001 (Trial.__init__): wire it in
1002 * buildbot/test/test_twisted.py (Counter): unit test for it
1004 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1005 to new cmd.logs['stdio'] scheme
1006 (Trial.commandComplete): same
1007 (BuildDebs.commandComplete): same
1009 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1010 LogFiles, instead of just a single one. The old single logfile is
1011 now called "stdio". LoggedRemoteCommand no longer creates a
1012 LogFile for you (the code to do that was broken anyway). If you
1013 don't create a "stdio" LogFile, then stdout/stderr will be
1015 (LogObserver): implement "LogObservers", which a BuildStep can add
1016 to parse the output of a command in real-time. The primary use is
1017 to provide more useful information to the Progress code, allowing
1018 better ETA estimates.
1019 (LogLineObserver): utility subclass which feeds complete lines to
1020 the parser instead of bytes.
1021 (BuildStep.progressMetrics): this is safer as a tuple
1022 (BuildStep.setProgress): utility method, meant to be called by
1024 (BuildStep.addLogObserver): new method, to be called at any time
1025 during the BuildStep (even before any LogFiles have been created),
1026 to attach (or schedule for eventual attachment) a LogObserver to a
1028 (StdioProgressObserver): new LogObserver which replaces the old
1029 "output" progress gatherer
1030 (LoggingBuildStep.__init__): same
1031 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1032 (LoggingBuildStep._commandComplete): must use logs['stdio']
1033 instead of the old single ".log" attribute.
1034 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1035 functionality, now subsumed into StdioProgressObserver
1036 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1037 log name changed from "output" to "stdio".
1040 * buildbot/interfaces.py (ILogFile): add the Interface used from
1041 the BuildStep towards the LogFile
1042 (ILogObserver): and the one provided by a LogObserver
1043 * buildbot/status/builder.py (LogFile): implement it
1045 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1046 HEADER constants here ..
1047 * buildbot/status/builder.py (STDOUT): .. from here
1049 2006-06-13 Brian Warner <warner@lothar.com>
1051 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1052 compatibility with python2.2, which doesn't have the 'substr in
1054 (TestP4Poller.makeTime): utility function to construct the
1055 timestamp using the same strptime() approach as p4poller does. It
1056 turns out that time.mktime() behaves slightly differently under
1057 python2.2, probably something to do with the DST flag, and that
1058 causes the test to fail under python2.2. (changing the mktime()
1059 arguments to have dst=0 instead of -1 caused it to fail under
1060 python2.3. Go figure.)
1061 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1063 2006-06-12 Brian Warner <warner@lothar.com>
1065 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1066 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1067 contributing such an excellent patch, including docs and unit
1068 tests! This makes it *so* much easier to apply. I had to update
1069 test_vc.py to handle some recent refactorings, but everything else
1070 applied smoothly. The only remaining thing I'd like to fix would
1071 be to remove the hard-wired port 1666 used by p4d, and allow it to
1072 claim any unused port. This would allow two copies of the test
1073 suite to run on the same host at the same time, as well as
1074 allowing the test suite to run while a real (production) p4d was
1075 running on the same host. Oh, and maybe we should add a warning to
1076 step.P4 that gets emitted if the slave is too old to provide the
1077 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1078 * buildbot/slave/commands.py (P4): same
1079 (P4Sync): same, some minor updates
1080 * buildbot/changes/p4poller.py: same
1081 * docs/buildbot.texinfo: same
1082 * buildbot/test/test_p4poller.py: same
1083 * buildbot/test/test_vc.py (P4): same
1085 * setup.py: add Trove classifiers for PyPI
1087 2006-06-08 Brian Warner <warner@allmydata.com>
1089 * buildbot/status/client.py
1090 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1091 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1092 build needs to be IRemote'd separately, rather than IRemote'ing
1093 the whole list at once. I can't wait until newpb's serialization
1094 adapters make this unnecessary.
1096 2006-06-06 Brian Warner <warner@lothar.com>
1098 * buildbot/process/step.py (WithProperties): make this inherit
1099 from ComparableMixin, so that reloading an unchanged config file
1100 doesn't cause us to spuriously reload any Builders which use them.
1101 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1104 2006-06-03 Brian Warner <warner@lothar.com>
1106 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1107 running py2exe on windows, contributed by Mark Hammond. Addresses
1108 SF#1401121, but I think we still need to include
1109 buildbot/scripts/sample.cfg
1110 * setup.py: include buildbot_service.py as a script under windows
1111 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1112 a py2exe application), get the icon/css datafiles from a different
1115 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1116 double-escape the build URL. Thanks to Olivier Bonnet for the
1117 patch. Fixes SF#1452801.
1119 2006-06-02 Brian Warner <warner@lothar.com>
1121 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1122 first six columns of 'svnlook' output, not just the first column,
1123 since property changes appear in the other five. Thanks to Olivier
1124 Bonnet for the patch. Fixes SF#1398174.
1126 2006-06-01 Brian Warner <warner@lothar.com>
1128 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1129 the fake build, so that title= has something to be set to
1131 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1132 attribute of the "Build #NN" link in the yellow start-the-build
1133 box to the build's reason. This means that you get a little
1134 tooltip explaining why the build was done when you hover over the
1135 yellow box. Thanks to Zandr Milewski for the suggestion.
1137 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1138 (Box.setETA): handle ETA=None (by stopping the timer)
1139 (Box.update): make the [soon] text less different than the usual
1140 text, so the rest of the text doesn't flop around so much. It
1141 would be awfully nice to figure out how to center this stuff.
1142 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1144 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1145 by default, so that any ShellCommand which fails marks the overall
1146 build as a failure. I should have done this from the beginning.
1147 Add flunkOnFailure=False to the arguments if you want to turn off
1150 2006-05-30 Brian Warner <warner@lothar.com>
1152 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1153 last-build/current-build/current-step. Show what step is currently
1154 running. Show ETA for both the overall build and the current step.
1155 Update GTK calls to modern non-deprecated forms. There's still a
1156 lot of dead code and debug noise to remove.
1158 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1159 shows up properly in status displays
1161 2006-05-28 Brian Warner <warner@lothar.com>
1163 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1164 build we use to verify that WithProperties works:
1166 ** set flunkOnFailure=True so that build failures get noticed
1167 ** set workdir='.' so that the build succeeds, otherwise it is trying
1168 to touch 'build/something', and 'build/' doesn't exist because
1169 usually that's created by a Source step
1170 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1171 this test somehow triggers, in which the 'touch' process becomes
1172 a zombie and we wait for th etimeout before giving up on it.
1174 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1175 to log the Build results and step logs to the twisted log.
1176 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1177 what went wrong if a build was expected to succeed but didn't.
1179 * buildbot/process/step_twisted.py (Trial): set the default
1180 trialMode to '--reporter=bwverbose', which specifies verbose
1181 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1182 '-to', but those are completely missing in modern Twisteds.
1184 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1185 a localhost-only port, to encourage better security
1187 * docs/buildbot.texinfo (Change Sources): mention
1190 * .darcs-boring: add a Darcs boringfile
1192 * README (REQUIREMENTS): stop claiming compatibility with
1195 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1198 2006-05-27 Brian Warner <warner@lothar.com>
1200 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1201 * docs/buildbot.texinfo: same
1203 2006-05-23 Brian Warner <warner@lothar.com>
1205 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1206 * docs/buildbot.texinfo: set version to match
1207 * NEWS: update for 0.7.3
1209 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1210 give a quick mapping from VC system to possible ChangeSources
1211 (Build Properties): add 'buildername'
1213 * buildbot/process/base.py (Build.setupStatus): oops, set
1214 'buildername' and 'buildnumber' properties
1215 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1218 2006-05-22 Brian Warner <warner@lothar.com>
1220 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1221 property interpolation better
1223 * README (INSTALLATION): remove old '-v' argument from recommended
1226 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1227 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1230 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1231 'svnversion' instead of grepping the output of 'svn info', much
1232 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1233 Bonnet for the suggestion.
1234 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1235 require the WC_PATH argument, so run 'svnversion .' instead.
1237 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1238 aren't supposed to have 'self' in their argument list
1240 2006-05-21 Brian Warner <warner@lothar.com>
1242 * buildbot/process/step.py (ShellCommand.start): make
1243 testInterpolate pass. I was passing the uninterpolated command to
1244 the RemoteShellCommand constructor
1245 (ShellCommand._interpolateProperties): oops, handle non-list
1246 commands (i.e. strings with multiple words separated by spaces in
1247 them) properly, instead of forgetting about them.
1249 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1250 to actually try to use build properties in a real build. This test
1252 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1253 to start and evaluate builds
1255 * buildbot/test/test__versions.py: add a pseudo-test to record
1256 what version of Twisted/Python/Buildbot are running. This should
1257 show up at the beginning of _trial_tmp/test.log, and exists to help
1258 debug other problems.
1260 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1261 a filename to be served as 'robots.txt' to discourage web spiders.
1262 Adapted from a patch by Tobi Vollebregt, thanks!
1263 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1264 (Waterfall.test_waterfall): tweak the way that filenames are put
1265 into the config file, to accomodate windows pathnames better.
1267 * docs/buildbot.texinfo (HTML Waterfall): document it
1269 * buildbot/process/process_twisted.py
1270 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1271 changed the build process. The new setup.py no longer takes the
1273 (FullTwistedBuildFactory.__init__): same
1274 (TwistedReactorsBuildFactory.__init__): same
1276 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1277 be placed in the [hooks] section of the central repository (the
1278 one that everybody pushes changes to).
1280 2006-05-20 Brian Warner <warner@lothar.com>
1282 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1283 .darcs-context file, use binary mode. I think this was causing a
1284 Darcs failure under windows.
1286 2006-05-19 Brian Warner <warner@lothar.com>
1288 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1289 use a timezone string of +0000 and gmtime, since this timestamp is
1290 sent to a buildmaster and %z is broken.
1292 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1293 string and localtime, since this timestamp will only be consumed
1294 locally, and %z is broken.
1296 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1297 gmtime, since this timestamp is returned to the buildmaster, and
1300 2006-05-18 Brian Warner <warner@lothar.com>
1302 * NEWS: update in preparation for next release
1304 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1305 setup-repository and do-we-have-the-vc-tools code into a separate
1306 "helper" class, which sticks around in a single module-level
1307 object. This seems more likely to continue to work in the future
1308 than having it hide in the TestCase and hope that TestCases stick
1309 around for a long time.
1311 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1312 addremove' has been deprecated in recent versions of mercurial, so
1313 use 'hg add' instead
1315 2006-05-07 Brian Warner <warner@lothar.com>
1317 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1318 operating under windows, move the file before opening it, since
1319 you can't rename a file that somebody has open.
1321 * buildbot/process/base.py (Build.setupBuild): if something goes
1322 wrong while creating a Step, log the name and arguments, since the
1323 error message when you get the number of arguments wrong is really
1326 2006-05-06 Brian Warner <warner@lothar.com>
1328 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1329 bugs in twisted-specific code not covered by my unit tests, this
1330 time use 'cmd' argument instead of self.cmd
1332 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1333 fix stupid braino: either use startwith or find()==0, not both.
1334 (TwistedReactorsBuildFactory.__init__): another dumb typo
1336 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1337 mark this test as TODO under windows, since process-killing seems
1338 dodgy there. We'll come back to this later and try to fix it
1341 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1342 and don't include a timezone
1343 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1344 This should avoid the windows-with-verbose-timezone-name problem
1346 (Patch.testPatch): add a test which runs 'patch' with less
1347 overhead than the full VCBase.do_patch sequence, to try to isolate
1348 a windows test failure. This one uses slave.commands.ShellCommand
1349 and 'patch', but none of the VC code.
1351 * buildbot/slave/commands.py (getCommand): use which() to find the
1352 executables for 'cvs', 'svn', etc. This ought to help under
1355 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1356 working directory before starting. If an earlier test failed, the
1357 leftover directory would mistakenly flunk a later test.
1358 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1359 Make sure that we use the right commandlines if which("tla") picks
1360 up "tla.exe" (as it does under windows).
1361 (TlaSupport.do_get): factor out this tla-vs-baz difference
1362 (TlaSupport.vc_create): more tla-vs-baz differences
1364 * buildbot/test/test_slavecommand.py
1365 (ShellBase.testShellMissingCommand): stop trying to assert
1366 anything about the error message: different shells on different
1367 OSes with different languages makes it hard, and it really isn't
1368 that interesting of a thing to test anyway.
1370 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1371 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1372 "Panther"), because it has a bug which flunks a couple tests in
1373 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1374 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1375 able to test that yet.
1377 2006-04-30 Brian Warner <warner@lothar.com>
1379 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1380 make sure child commands emit messages in english, so our regexps
1381 will match. Thanks to Nikaus Giger for identifying the problems.
1382 (VCBase._do_vctest_export_1): mode="export" is not responsible
1383 for setting the "got_revision" property, since in many cases it is
1384 not convenient to determine.
1385 (SVNSupport.capable): when running 'svn --version' to check for
1386 ra_local, we want error messages in english
1387 * buildbot/test/test_slavecommand.py
1388 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1389 to emit the error message in english
1391 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1392 the environment with $LC_ALL="C" so that Commands which need to
1393 parse the output of their child processes can obtain it in
1395 (SVN.parseGotRevision): call "svn info" afterwards instead of
1396 watching the output of the "svn update" or "svn checkout".
1397 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1398 (Arch.parseGotRevision): same
1399 (Bazaar.parseGotRevision): same
1400 (Mercurial.parseGotRevision): same
1402 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1403 $LC_ALL="C" when running commands under 'buildbot try', too
1405 * buildbot/test/__init__.py: remove the global os.environ()
1406 setting, instead we do it just for the tests that run commands and
1407 need to parse their output.
1409 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1410 remove the overly-short .timeout on this test, because non-DNotify
1411 platforms must fall back to polling which happens at 10 second
1412 intervals, so a 5 second timeout would never succeed.
1414 2006-04-24 Brian Warner <warner@lothar.com>
1416 * docs/buildbot.texinfo (Installing the code): update trial
1417 invocation, SF#1469116 by Niklaus Giger.
1418 (Attributes of Changes): updated branch-name examples to be
1419 a bit more realistic, SF#1475240 by Stephen Davis.
1421 * contrib/windows/buildbot2.bat: utility wrapper for windows
1422 developers, contributed by Nick Trout (after a year of neglect..
1423 sorry!). SF#1194231.
1425 * buildbot/test/test_vc.py (*.capable): store the actual VC
1426 binary's pathname in VCS[vcname], so it can be retrieved later
1427 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1428 strip out non-numeric timezone information, specifically the funky
1429 German string that his system produced that confuses CVS.
1430 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1431 allow Darcs tests to work on windows
1432 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1433 procutils.which() everywhere, to allow tryclient to work under
1434 windows. Also from Niklaus Giger, SF#1463394.
1436 * buildbot/twcompat.py (which): move the replacement for a missing
1437 twisted.python.procutils.which from test_vc.py to here, so it can
1438 be used in other places too (specifically tryclient.py)
1440 2006-04-23 Brian Warner <warner@lothar.com>
1442 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1443 bare buildbotURL/projectName line with a proper DIV, along with a
1444 CSS class of "title", from Stefan Seefeld (SF#1461675).
1445 (WaterfallStatusResource.body0): remove the redundant 'table'
1446 class from the table
1447 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1448 to the top-row TR, and class="Activity" to the second-row TR,
1449 rather than putting them in the individual TD nodes.
1451 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1452 'got_revision' build property for all VC systems that implement
1453 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1455 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1456 to determine which revision we actually obtained
1457 (CVS.parseGotRevision): implement this for CVS, which just means
1458 to grab a timestamp. Not ideal, and it depends upon the buildslave
1459 having a clock that is reasonably well syncronized with the server,
1460 but it's better than nothing.
1461 (SVN.parseGotRevision): implement it for SVN, which is accurate
1462 (Darcs.parseGotRevision): same
1463 (Arch.parseGotRevision): same
1464 (Bazaar.parseGotRevision): same
1465 (Mercurial.parseGotRevision): same
1467 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1468 keep a record of all non-stdout/stderr/header/rc status updates,
1469 for the benefit of RemoteCommands that send other useful things,
1471 (Source.commandComplete): put any 'got_revision' status values
1472 into a build property of the same name
1475 * buildbot/process/step_twisted.py (Trial): update to deal with
1476 new ShellCommand refactoring
1478 * docs/buildbot.texinfo (Build Properties): document new feature
1479 that allows BuildSteps to get/set Build-wide properties like which
1480 revision was requested and/or checked out.
1482 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1483 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1484 it. Note that this bumps the persistenceVersion of the saved Build
1485 object, so add the necessary upgrade-old-version logic to include
1486 an empty properties dict.
1488 * buildbot/process/base.py (Build.setProperty): implement it
1489 (Build.getProperty): same
1490 (Build.startBuild): change build startup to set 'branch',
1491 'revision', and 'slavename' properties at the right time
1493 * buildbot/process/step.py (BuildStep.__init__): change setup to
1494 require 'build' argument in a better way
1495 (LoggingBuildStep): split ShellCommand into two pieces, for better
1496 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1497 a single RemoteCommand that sends stdout/stderr status text. It
1498 also provides the usual commandComplete / createSummary /
1499 evaluateCommand / getText methods to be overridden...
1500 (ShellCommand): .. whereas ShellCommand is specifically for
1501 running RemoteShellCommands. Other shell-like BuildSteps (like
1502 Source) can inherit from LoggingBuildStep instead of ShellCommand
1503 (WithProperties): marker class to do build-property interpolation
1504 (Source): inherit from LoggingBuildStep instead of ShellCommand
1507 * buildbot/test/test_properties.py: test new functionality
1509 2006-04-21 Brian Warner <warner@lothar.com>
1511 * buildbot/test/test_vc.py: rename testBranch to
1512 testCheckoutBranch to keep the tests in about the right
1515 2006-04-18 Brian Warner <warner@lothar.com>
1517 * docs/buildbot.texinfo (PBListener): improve cross-references
1518 between PBListener and 'buildbot statusgui', thanks to John Pye
1521 2006-04-17 Brian Warner <warner@lothar.com>
1523 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1524 running under Twisted-1.3.0, otherwise skipped tests are reported
1527 * all: use isinstance() instead of 'type(x) is foo', suggested by
1530 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1531 oops, fix a brain-fade from the other week, when making the
1532 addStep changes. I changed all the __init__ upcalls to use the
1533 wrong superclass name.
1534 (FullTwistedBuildFactory.__init__): same
1535 (TwistedDebsBuildFactory.__init__): same
1536 (TwistedReactorsBuildFactory.__init__): same
1537 (TwistedBuild.isFileImportant): use .startswith for clarity,
1538 thanks to Neal Norwitz for the suggestions.
1540 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1541 changes, then deliver them over PB to a remote buildmaster.
1543 * contrib/svnpoller.py: added script by John Pye to poll a remote
1544 SVN repository (by running 'svn log') from a cronjob, and run
1545 'buildbot sendchange' to deliver the changes to a remote
1547 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1548 modification of svnpoller.py), same purpose, but this one loops
1549 internally (rather than expecting to run from a cronjob) and works
1551 * contrib/README.txt: same
1553 2006-04-11 Brian Warner <warner@lothar.com>
1555 * all: fix a number of incorrect names and missing imports, thanks
1556 to Anthony Baxter for the patch.
1557 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1558 remove unused buggy method.
1559 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1560 comes from shutil, not "shutils"
1561 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1562 (Arch.checkSlaveVersion): same
1563 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1565 * buildbot/process/step_twisted2.py: add some missing imports
1566 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1567 this code used to live in twisted.internet.defer
1569 2006-04-10 Brian Warner <warner@lothar.com>
1571 * buildbot/process/step.py (Mercurial): add Mercurial support
1572 * buildbot/slave/commands.py (Mercurial): same
1573 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1574 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1575 not yet tested, but 'try' support *is* covered
1576 * docs/buildbot.texinfo (Mercurial): document it
1578 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1579 some debugging messages (turned off)
1580 * buildbot/test/test_vc.py: improve debug messages
1582 2006-04-07 Brian Warner <warner@lothar.com>
1584 * buildbot/test/test_vc.py (which): define our own which() in case
1585 we can't import twisted.python.procutils, because procutils doesn't
1586 exist in Twisted-1.3
1588 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1589 of SlaveLocks for performance tests
1591 * docs/examples/twisted_master.cfg: update to match current usage
1593 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1594 password, p4 binary, pollinterval, maximum history to check.
1595 Patch from an anonymous sf.net contributor, SF#1219384.
1596 * buildbot/process/step.py (P4Sync.__init__): add username,
1597 password, and client arguments.
1598 * buildbot/slave/commands.py (P4Sync): same
1600 2006-04-05 Brian Warner <warner@lothar.com>
1602 * buildbot/process/factory.py (BuildFactory.addStep): new method
1603 to add steps to a BuildFactory. Use it instead of f.steps.append,
1604 and you can probably avoid using the s() convenience function.
1605 Patch from Neal Norwitz, sf.net #1412605.
1606 (other): update all factories to use addStep
1607 * buildbot/process/process_twisted.py: update all factories to use
1610 2006-04-03 Brian Warner <warner@lothar.com>
1612 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1613 work under windows too. Adapted from a patch by Niklaus Giger,
1614 addresses SF#1463399.
1616 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1617 spawned commands emit parseable results in english and not some
1618 other language. Patch from Niklaus Giger, SF#1463395.
1620 * README (INSTALLATION): discourage users from running unit tests on
1621 a "network drive", patch from Niklaus Giger, SF#1463394.
1623 2006-03-22 Brian Warner <warner@lothar.com>
1625 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1626 function to turn a repository-relative pathname into a (branch,
1627 branch-relative-filename) tuple. Change this function to handle
1628 the branch naming policy used by your Subversion repository.
1629 Thanks to AllMyData.com for sponsoring this work.
1631 2006-03-16 Brian Warner <warner@lothar.com>
1633 * buildbot/scripts/sample.cfg: add python-mode declaration for
1634 vim. Thanks to John Pye for the patch.
1636 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1637 command line, mention the importance of running 'crontab' as the
1638 buildmaster/buildslave user. Thanks to John Pye for the catch.
1640 2006-03-13 Brian Warner <warner@lothar.com>
1642 * buildbot/status/words.py (IRC): add an optional password=
1643 argument, which will be sent to Nickserv in an IDENTIFY message at
1644 login, to claim the nickname. freenode requires this before the
1645 bot can sent (or reply to) private messages. Thanks to Clement
1646 Stenac for the patch.
1647 * docs/buildbot.texinfo (IRC Bot): document it
1649 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1650 larger than chunkSize. Fixes SF#1349253.
1651 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1652 (Log.testConsumer): update to match new internal chunking behavior
1654 2006-03-12 Brian Warner <warner@lothar.com>
1656 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1658 * buildbot/test/test_maildir.py (MaildirTest): rename the
1659 'timeout' method, as it collides with trial's internals
1661 * buildbot/scripts/runner.py: add 'buildbot restart' command
1662 (stop): don't sys.exit() out of here, otherwise restart can't work
1663 * docs/buildbot.texinfo (Shutdown): document it
1665 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1666 * buildbot/status/html.py (Waterfall.__init__): same
1667 * buildbot/process/builder.py (Builder.startBuild): same
1668 * buildbot/process/base.py (BuildRequest): same
1669 * buildbot/sourcestamp.py (SourceStamp): same
1670 * buildbot/scheduler.py (Nightly): same
1672 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1674 * docs/buildbot.texinfo: same
1676 2006-02-17 Brian Warner <warner@lothar.com>
1678 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1679 * docs/buildbot.texinfo: set version number to match
1680 * NEWS: update for 0.7.2
1682 2006-02-16 Brian Warner <warner@lothar.com>
1684 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1686 2006-02-09 Brian Warner <warner@lothar.com>
1688 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1689 add text to explain per-build branch parameters
1690 * NEWS: mention --umask
1692 2006-02-08 Brian Warner <warner@lothar.com>
1694 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1696 (SlaveOptions.optParameters): add --umask, to make it possible to
1697 make buildslave-generated files (including build products) be
1700 * buildbot/slave/bot.py (BuildSlave.startService): same
1702 2006-01-23 Brian Warner <warner@lothar.com>
1704 * buildbot/status/builder.py: urllib.quote() all URLs that include
1705 Builder names, so that builders can include characters like '/'
1706 and ' ' without completely breaking the resulting HTML. Thanks to
1707 Kevin Turner for the patch.
1708 * buildbot/status/html.py: same
1709 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1711 * NEWS: update in preparation for upcoming release
1713 2006-01-18 Brian Warner <warner@lothar.com>
1715 * docs/examples/twisted_master.cfg: update to match the Twisted
1716 buildbot: remove python2.2, switch to exarkun's buildslaves,
1717 disable the .deb builder until we figure out how to build twisted
1718 .debs from SVN, add some ktrace debugging to the OS-X build
1719 process and remove the qt build, remove threadless builders,
1720 change freebsd builder to use landonf's buildslave.
1722 2006-01-12 Brian Warner <warner@lothar.com>
1724 * buildbot/master.py (Manhole.__init__): let port= be a strports
1725 specification string, but handle a regular int for backwards
1726 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1727 used in master.cfg to limit connections to just the local host.
1728 (BuildMaster.loadConfig): same for c['slavePortnum']
1729 * buildbot/scheduler.py (Try_Userpass.__init__): same
1730 * buildbot/status/client.py (PBListener.__init__): same
1731 * buildbot/status/html.py (Waterfall.__init__): same, for both
1732 http_port and distrib_port. Include backwards-compatibility checks
1733 so distrib_port can be a filename string and still mean unix:/foo
1734 * docs/buildbot.texinfo (Setting the slaveport): document it
1735 (Debug options): same
1736 (HTML Waterfall): same
1739 * buildbot/test/test_config.py (ConfigTest): test it
1741 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1742 slaveport's disownServiceParent deferred to fire before opening
1743 the new one. Fixes an annoying bug in the unit tests.
1745 2006-01-03 Brian Warner <warner@lothar.com>
1747 * buildbot/master.py (BuildMaster): remove the .schedulers
1748 attribute, replacing it with an allSchedulers() method that looks
1749 for all IService children that implement IScheduler. Having only
1750 one parent/child relationship means fewer opportunities for bugs.
1751 (BuildMaster.allSchedulers): new method
1752 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1753 also fix ugly bug that caused any config-file reload to
1754 half-forget about the earlier Schedulers, causing an exception
1755 when a Change arrived and was handed to a half-connected
1756 Scheduler. The exception was in scheduler.py line 54ish:
1757 self.parent.submitBuildSet(bs)
1758 exceptions.AttributeError: 'NoneType' object has no attribute
1760 (BuildMaster.addChange): update to use allSchedulers()
1762 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1763 to work properly with twisted-1.3.0, where you must explicitly
1764 include the __implements__ from parent classes
1765 (BaseScheduler.__repr__): make it easier to distinguish distinct
1767 (BaseUpstreamScheduler.__implements__): same
1769 * buildbot/status/builder.py (Status.getSchedulers): update to
1771 * buildbot/test/test_run.py (Run.testMaster): same
1772 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1773 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1774 make sure Scheduler instances are left alone when an identical
1775 config file is reloaded
1776 (ConfigElements.testSchedulers): make sure Schedulers are properly
1779 * Makefile (TRIALARGS): my local default Twisted version is now
1780 2.1.0, update the trial arguments accordingly
1782 2005-12-22 Brian Warner <warner@lothar.com>
1784 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1787 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1788 addChange in the parent class, although I suspect this should be
1789 fixed better in the future.
1791 2005-11-26 Brian Warner <warner@lothar.com>
1793 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1794 explode when branch==None, thanks to Kevin Turner for the catch
1795 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1798 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1800 * docs/buildbot.texinfo: same
1802 2005-11-26 Brian Warner <warner@lothar.com>
1804 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1805 * docs/buildbot.texinfo: set version number to match
1807 2005-11-26 Brian Warner <warner@lothar.com>
1809 * NEWS: update for 0.7.1
1811 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1812 sure that unsubscribe works even if we never sent an ETA update.
1813 Also, don't explode on duplicate unsubscribe.
1814 (BuildStepStatus.addLog): make the convenience "return self"-added
1815 watcher automatically unsubscribe when the Step finishes.
1816 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1817 (BuildStatus.stepStarted): same auto-unsubscribe
1818 (BuilderStatus.buildStarted): same auto-unsubscribe
1820 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1822 (IStatusReceiver.stepStarted): same
1823 (IStatusReceiver.logStarted): same
1825 * buildbot/test/test_run.py (Status): move the Status test..
1826 * buildbot/test/test_status.py (Subscription): .. to here
1828 2005-11-25 Brian Warner <warner@lothar.com>
1830 * NEWS: more updates
1832 * buildbot/locks.py: fix the problem in which loading a master.cfg
1833 file that changes some Builders (but not all of them) can result
1834 in having multiple copies of the same Lock. Now, the real Locks
1835 are kept in a table inside the BotMaster, and the Builders/Steps
1836 use "LockIDs", which are still instances of MasterLock and
1837 SlaveLock. The real Locks are instances of the new RealMasterLock
1838 and RealSlaveLock classes.
1839 * buildbot/master.py (BotMaster.getLockByID): new method to
1840 convert LockIDs into real Locks.
1841 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1842 into real Locks before building
1843 * buildbot/process/step.py (BuildStep.startStep): same
1844 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1845 exercises the problem
1848 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1849 what Schedulers are available
1851 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1852 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1853 'cron'-style build scheduling at certain times of day, week,
1855 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1857 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1858 handling: treat self.fileIsImportant more as an attribute that
1859 contains a callable than as a method. If the attribute is None,
1860 don't call it and assume all filenames are important. It is still
1861 possible to provide a fileIsImportant method in a subclass,
1863 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1865 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1866 test using AnyBranchScheduler with fileIsImportant=None
1868 2005-11-24 Brian Warner <warner@lothar.com>
1870 * buildbot/test/test_config.py (StartService): don't claim a fixed
1871 port number, instead set slavePort=0 on the first pass, figure out
1872 what port was allocated, then switch to a config file that uses
1875 * buildbot/master.py (BuildMaster.loadConfig): close the old
1876 slaveport before opening the new one, because unit tests might
1877 replace slavePort=0 with the same allocated portnumber, and if we
1878 don't wait for the old port to close first, we get a "port already
1879 in use" error. There is a tiny race condition here, but the only
1880 threat is from other programs that bind (statically) to the same
1881 port number we happened to be allocated, and only if those
1882 programs use SO_REUSEADDR, and only if they get control in between
1885 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1887 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1888 deleted ChangeSources before adding any new ones
1889 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1890 compare_attrs, to make sure that a config-file reload does not
1891 unnecessarily replace an unmodified ChangeSource instance
1892 * buildbot/test/test_config.py (ConfigTest.testSources): update
1894 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1895 mean "don't build anything", and add a warning if it gets used
1896 because it isn't actually useful.
1898 * contrib/svn_buildbot.py: update example usage to match the port
1899 number that gets used by the PBChangeSource
1900 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1902 2005-11-22 Brian Warner <warner@lothar.com>
1904 * NEWS: start collecting items for next release
1906 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1907 revisions are strings
1908 (P4Sync.computeSourceRevision): same
1910 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1911 to the Buildbot's overall status page
1912 (StatusResourceBuilder.body): same
1914 2005-11-15 Brian Warner <warner@lothar.com>
1916 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1917 config-file loading, specifically to make sure old StatusTargets
1918 are finished shutting down before new ones start up (thus
1919 resolving a bug in which changing the Waterfall object would fail
1920 because both new and old instances were claiming the same
1921 listening port). Also load new Schedulers after all the new
1922 Builders are set up, in case they fire off a new build right away.
1923 * buildbot/test/test_config.py (StartService): test it
1925 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1926 the branch name to the mail body
1928 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1929 Without it, a config-file reload fails to update an existing
1931 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1932 username/passwd to compare_attrs, for the same reason
1933 * buildbot/status/html.py (Waterfall): add favicon to
1934 compare_attrs, same reason
1936 2005-11-05 Brian Warner <warner@lothar.com>
1938 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1939 baserev before stuffing it in the jobfile. This resolves problems
1940 under SVN (and probably Arch) where revisions are expressed as
1941 numbers. I'm inclined to use string-based revisions everywhere in
1942 the future, but this fix should be safe for now. Thanks to Steven
1943 Walter for the patch.
1945 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1946 binary mode when opening pickle files, to make windows work
1947 better. Thanks to Dobes Vandermeer for the catch.
1948 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1949 (BuilderStatus.getBuildByNumber): same
1950 (Status.builderAdded): same
1951 * buildbot/master.py (BuildMaster.loadChanges): same
1953 * buildbot/util.py (Swappable): delete unused leftover code
1955 * buildbot/process/step.py (SVN): when building on a non-default
1956 branch, add the word "[branch]" to the VC step's description, so
1957 it is obvious that we're not building the usual stuff. Likewise,
1958 when we are building a specific revision, add the text "rNNN" to
1959 indicate what that revision number is. Thanks to Brad Hards and
1960 Nathaniel Smith for the suggestion.
1961 (Darcs.startVC): same
1962 (Arch.startVC): same
1963 (Bazaar.startVC): same
1965 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1966 typo, caught by Mark Dillavou, closes SF#1216636.
1968 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1969 about a test to add some day
1971 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1972 the 'full-2.3' build, and the 'reactors' build is now run under
1973 python-2.4 because the buildslave no longer has gtk/etc bindings
1974 for earlier versions.
1976 2005-11-03 Brian Warner <warner@lothar.com>
1978 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1979 method, takes an IBuildStatus and rebuilds it. It might make more
1980 sense to add this to IBuildControl instead, but that instance goes
1981 away completely once the build has finished, and resubmitting
1982 builds can take place weeks later.
1983 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1984 * buildbot/status/html.py (StatusResourceBuild): also stash an
1985 IBuilderControl so we can use resubmitBuild.
1986 (StatusResourceBuild.body): render "resubmit" button if we can.
1987 Also add hrefs for each BuildStep
1988 (StatusResourceBuild.rebuild): add action for "resubmit" button
1989 (StatusResourceBuilder.getChild): give it an IBuilderControl
1991 * buildbot/status/builder.py (Status.getURLForThing): change the
1992 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1993 that live as targets of buttons like "stop" and "rebuild" can't
1995 * buildbot/status/builder.py (Status.getURLForThing): same
1996 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1997 (StepBox.getBox): same
1998 * buildbot/test/test_web.py (GetURL): same
2001 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2002 exclusivity checks after Source.__init__ upcall, so misspelled
2003 arguments will be reported more usefully
2004 (Darcs.__init__): same
2006 2005-10-29 Brian Warner <warner@lothar.com>
2008 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2009 builder. Move the Try scheduler off to a separate port.
2011 2005-10-27 Brian Warner <warner@lothar.com>
2013 * buildbot/clients/gtkPanes.py
2014 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2015 to cause the app to crash, now they don't.
2017 * buildbot/clients/debug.py: display the buildmaster's location
2018 in the window's title bar
2020 2005-10-26 Brian Warner <warner@lothar.com>
2022 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2023 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2024 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2026 * buildbot/status/html.py (td): put a single non-breaking space
2027 inside otherwise empty <td> elements, as a workaround for buggy
2028 browsers which would optimize them away (along with any associated
2029 styles, like the kind that create the waterfall grid borders).
2030 Patch from Frerich Raabe.
2032 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2033 argv-list as an argument, defaulting to ["-to"], which is
2034 appropriate for the Trial that comes with Twisted-2.1.0 and
2035 earlier. The Trial in current Twisted SVN wants
2036 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2037 defaults to an empty list.
2038 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2039 match it, now that trialMode= is a list instead of a single string
2041 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2043 * docs/buildbot.texinfo: same
2045 2005-10-24 Brian Warner <warner@lothar.com>
2047 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2048 * docs/buildbot.texinfo: set version number to match
2050 2005-10-24 Brian Warner <warner@lothar.com>
2052 * README: update for 0.7.0
2054 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2056 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2057 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2058 send the branch= argument unless the user really provided one, to
2059 retain compatibility with older buildmasters that don't accept
2061 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2064 * docs/buildbot.texinfo: update lots of stuff
2066 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2067 to the 'buildbot sendchange' command
2068 * buildbot/clients/sendchange.py (Sender.send): same
2069 * buildbot/changes/pb.py (ChangePerspective): same
2070 * buildbot/test/test_changes.py (Sender.testSender): test it
2072 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2073 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2074 for consistency with other BuildStep arguments that use camelCase.
2075 Well, at least more of them use camelCase (like flunkOnWarnings)
2076 than don't.. I wish I'd picked one style and stuck with it
2077 earlier. Annoying, but it's best done before the release, since
2078 these arguments didn't exist at all in 0.6.6 .
2080 * buildbot/test/test_vc.py (SVN.testCheckout): same
2081 (Darcs.testPatch): same
2082 * docs/buildbot.texinfo (SVN): document the change
2083 (Darcs): same, add some build-on-branch docs
2084 * docs/examples/twisted_master.cfg: match change
2086 * buildbot/process/step.py (BuildStep): rename
2087 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2088 how it is normally used.
2089 * buildbot/test/test_steps.py (Version.checkCompare): same
2091 * buildbot/process/step.py (CVS.startVC): refuse to build
2092 update/copy -style builds on a non-default branch with an old
2093 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2094 concern is that it will do a VC 'update' in an existing tree when
2095 it is supposed to be switching branches (and therefore clobbering
2096 the tree to do a full checkout), thus building the wrong source.
2097 This used to be a warning, but I think the confusion it is likely
2098 to cause warrants making it an error.
2099 (SVN.startVC): same, also make mode=export on old slaves an error
2100 (Darcs.startVC): same
2101 (Git.startVC): improve error message for non-Git-enabled slaves
2102 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2103 specific revision is built on a slave that doesn't pay attention
2104 to args['revision'], because for slowly-changing trees it will
2105 probably do the right thing, and because we have no way to tell
2106 whether we're asking it to build the most recent version or not.
2107 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2109 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2110 that 'master' is in host:portnum format, to catch errors sooner
2112 2005-10-23 Brian Warner <warner@lothar.com>
2114 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2115 when creating the list of warning messages, include the line
2116 immediately after each WARNING: line, since that's usually where
2117 the file and line number wind up.
2119 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2124 2005-10-22 Brian Warner <warner@lothar.com>
2126 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2127 patch from Brad Hards
2128 * buildbot/status/classic.css: same
2129 * buildbot/test/test_web.py (Waterfall): match changes
2131 * buildbot/test/test_steps.py (BuildStep.setUp): set
2132 nextBuildNumber so the test passes
2133 * buildbot/test/test_status.py (MyBuilder): same
2135 * buildbot/status/html.py (StatusResourceBuild.body): revision
2136 might be numeric, so stringify it before html-escapifying it
2137 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2138 timer for the upcoming build
2139 * buildbot/status/classic.css: add background-color attributes for
2140 offline/waiting/building classes
2142 * buildbot/status/builder.py (BuildStatus): derive from
2143 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2144 the default (i.e. unknown) .slavename to "???" instead of None,
2145 since even unknown slavenames need to be printed eventually.
2146 (BuilderStatus): also derive from styles.Versioned . More
2147 importantly, determine .nextBuildNumber at creation/unpickling
2148 time by scanning the directory of saved BuildStatus instances and
2149 choosing one larger than the highest-numbered one found. This
2150 should fix the problem where random errors during upgrades cause
2151 the buildbot to forget about earlier builds. .nextBuildNumber is
2152 no longer stored in the pickle.
2153 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2154 at least log the error. Also call Builder.determineNextBuildNumber
2155 once the basedir is set.
2157 * buildbot/master.py (BuildMaster.loadChanges): do
2158 styles.doUpgrade afterwards, in case I decide to make Changes
2159 derived from styles.Versioned some day and forget to make this
2163 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2164 when running under older pythons (<2.3) in which the shlex module
2165 doesn't have a 'split' function.
2167 * buildbot/process/step.py (ShellCommand.start): make
2168 errorMessages= be a list of strings to stuff in the log before the
2169 command actually starts. This makes it easier to flag multiple
2170 warning messages, e.g. when the Source steps have to deal with an
2172 (CVS.startVC): handle slaves that don't handle multiple branches
2173 by switching into 'clobber' mode
2174 (SVN.startVC): same. Also reject branches without base_url
2175 (Darcs.startVC): same. Also reject revision= in older slaves
2176 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2177 (Bazaar.startVC): same, and test for baz separately than for arch
2179 * buildbot/slave/commands.py (cvs_ver): document new features
2181 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2182 (BuildStep.slaveVersionNewEnough): more useful utility method
2183 * buildbot/test/test_steps.py (Version): start testing it
2185 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2186 the 'force' command requires python2.3, for the shlex.split method
2188 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2189 since we don't use it anymore. The Twisted buildbot uses a
2192 2005-10-21 Brian Warner <warner@lothar.com>
2194 * buildbot/process/process_twisted.py: rework all BuildFactory
2195 classes to take a 'source' step as an argument, instead of
2196 building up the SVN instance in the factory.
2197 * docs/examples/twisted_master.cfg: enable build-on-branch by
2198 providing a base_url and default_branch
2200 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2201 control over --branch and --revision, not that they are always
2203 * buildbot/status/html.py (StatusResourceBuilder.force): same
2204 (StatusResourceBuild.body): display SourceStamp components
2206 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2207 IRC 'force' command, so it can be shared with an eventual
2208 command-line-tool 'buildbot force' mode.
2209 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2211 2005-10-20 Brian Warner <warner@lothar.com>
2213 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2215 * docs/examples/twisted_master.cfg: update to use Schedulers
2217 * buildbot/scripts/sample.cfg: update with Schedulers
2219 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2220 method specifically for use by HTML "force build" button and the
2221 IRC "force" command. Raises an immediate error if there are no
2223 (IBuilderControl.requestBuild): make this just submit a build, not
2224 try to check for existing slaves or set up any when-finished
2225 Deferreds or anything.
2226 * buildbot/process/builder.py (BuilderControl): same
2227 * buildbot/status/html.py (StatusResourceBuilder.force): same
2228 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2229 * buildbot/test/test_slaves.py: same
2230 * buildbot/test/test_web.py: same
2232 2005-10-19 Brian Warner <warner@lothar.com>
2234 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2235 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2237 2005-10-18 Brian Warner <warner@lothar.com>
2239 * buildbot/status/html.py: provide 'status' argument to most
2240 StatusResourceFOO objects
2241 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2242 and Logfiles" section to make the Build page into a more-or-less
2243 comprehensive source of status information about the build
2245 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2246 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2248 2005-10-17 Brian Warner <warner@lothar.com>
2250 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2251 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2252 out what to do about other projects: the correct options for
2253 recent Twisteds will not work for older ones.
2255 2005-10-15 Brian Warner <warner@lothar.com>
2257 * buildbot/status/builder.py (Status.getURLForThing): add method
2258 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2259 use this in email/IRC status clients to make them more useful, by
2260 providing the end user with hints on where to learn more about the
2261 object being reported on.
2262 * buildbot/test/test_web.py (GetURL): tests for it
2264 2005-10-14 Brian Warner <warner@lothar.com>
2266 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2267 fix bug resulting from deferredResult changes
2269 2005-10-13 Brian Warner <warner@lothar.com>
2271 * buildbot/test/test_changes.py: remove use of deferredResult
2272 * buildbot/test/test_config.py: same
2273 * buildbot/test/test_control.py: same
2274 * buildbot/test/test_status.py: same
2275 * buildbot/test/test_vc.py: this is the only remaining use, since
2276 it gets used at module level. This needs to be replaced by some
2277 sort of class-level run-once routine.
2279 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2281 * lots: implement multiple slaves per Builder, which means multiple
2282 current builds per Builder. Some highlights:
2283 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2284 of (state,currentBuilds) instead of (state,currentBuild)
2285 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2286 (IBuildStatus.getSlavename): new method, so you can tell which
2287 slave got used. This only gets set when the build completes.
2288 (IBuildRequestStatus.getBuilds): new method
2290 * buildbot/process/builder.py (SlaveBuilder): add a .state
2291 attribute to track things like ATTACHING and IDLE and BUILDING,
2293 (Builder): .. the .slaves attribute here, which has been turned
2294 into a simple list of available slaves. Added a separate
2295 attaching_slaves list to track ones that are not yet ready for
2297 (Builder.fireTestEvent): put off the test-event callback for a
2298 reactor turn, to make tests a bit more consistent.
2299 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2300 ping fails due to an exception. This needs work, I'm worried that
2301 a code error could lead to a constantly re-connecting slave.
2302 Especially since I'm trying to move to a distinct remote_ping
2303 method, separate from the remote_print that we currently use.
2304 (BuilderControl.requestBuild): return a convenience Deferred that
2305 provides an IBuildStatus when the build finishes.
2306 (BuilderControl.ping): ping all connected slaves, only return True
2307 if they all respond.
2309 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2310 reconnect when we shut down.
2312 * buildbot/status/builder.py: implement new methods, convert
2313 one-build-at-a-time methods to handle multiple builds
2314 * buildbot/status/*.py: do the same in all default status targets
2315 * buildbot/status/html.py: report the build's slavename in the
2316 per-Build page, report all buildslaves on the per-Builder page
2318 * buildbot/test/test_run.py: update/create tests
2319 * buildbot/test/test_slaves.py: same
2320 * buildbot/test/test_scheduler.py: remove stale test
2322 * docs/buildbot.texinfo: document the new builder-specification
2323 'slavenames' parameter
2325 2005-10-12 Brian Warner <warner@lothar.com>
2327 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2328 report failure correctly, causing Dependent builds to run when
2329 they shouldn't have.
2330 * buildbot/status/builder.py (BuildSetStatus): same
2331 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2332 (Set.testSuccess): test the both-pass case too
2333 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2334 fix this test: it was ending too early, masking the failure before
2335 (Logger): specialized StatusReceiver to make sure the dependent
2336 builds aren't even started, much less completed.
2338 2005-10-07 Brian Warner <warner@lothar.com>
2340 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2341 bot.SlaveBuilder being disowned in the middle of a build
2343 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2344 this inherit from StatusReceiver. Also upcall in __init__. This
2345 fixes the embarrasing crash when the new buildSetSubmitted method
2346 is invoked and Waterfall/etc don't implement their own.
2347 * buildbot/test/test_run.py: add a TODO note about a test to catch
2348 just this sort of thing.
2350 * buildbot/process/builder.py (Builder.attached): remove the
2351 already-attached warning, this situation is normal. Add some
2352 comments explaining it.
2354 2005-10-02 Brian Warner <warner@lothar.com>
2356 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2357 OverflowError when setting up dnotify, because some 64-bit systems
2358 have problems with signed-vs-unsigned constants and trip up on the
2359 DN_MULTISHOT flag. Patch from Brad Hards.
2361 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2363 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2364 progressMetrics, description, descriptionDone to the 'parms' list,
2365 and make use the 'parms' list from the implementation class
2366 instead of only BuildStep to initialize the parameters. This
2367 allows buildbot.process.factory.s() to initialize all the parms,
2368 not just those defined in directly by BuildStep.
2370 2005-09-03 Brian Warner <warner@lothar.com>
2372 * NEWS: start adding items for the next release
2374 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2375 python2.2 tests, change 'Quick' builder to only use python2.3
2377 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2379 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2380 the "Ping Builder" button if the build control is available; the
2381 user sees an exception otherwise
2383 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2385 2005-09-01 Brian Warner <warner@lothar.com>
2387 * buildbot/interfaces.py (IBuilderStatus.getState): update
2388 signature, point out that 'build' can be None
2389 (IBuildStatus.getETA): point out ETA can be none
2391 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2393 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2395 2005-08-31 Brian Warner <warner@lothar.com>
2397 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2398 update to match correct signature: removed 'eta' argument
2399 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2401 2005-08-30 Brian Warner <warner@lothar.com>
2403 * buildbot/status/builder.py (LogFile): remove the assertion that
2404 blows up when you try to overwrite an existing logfile, instead
2405 just emit a warning. This case gets hit when the buildmaster is
2406 killed and doesn't get a chance to write out the serialized
2407 BuilderStatus object, so the .nextBuildNumber attribute gets out
2410 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2411 the 'buildbot sendchange' arguments, for the Darcs context file
2412 * docs/buildbot.texinfo (sendchange): document it
2414 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2415 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2416 (IStatus.getSchedulers): new method
2417 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2418 (Status.getSchedulers): implement
2419 * buildbot/process/builder.py (Builder): maintain
2420 BuilderStatus.pendingBuilds
2421 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2422 (TryBase.addChange): Try schedulers should ignore Changes
2424 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2425 for 'try' on CVS/SVN
2426 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2428 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2429 report status properly.
2430 (Try.createJob): implement unique buildset IDs
2432 * buildbot/status/client.py (StatusClientPerspective): add a
2433 perspective_getBuildSets method for the benefit of jobdir-style
2435 * docs/buildbot.texinfo (try): more docs
2436 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2439 2005-08-18 Brian Warner <warner@lothar.com>
2441 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2442 actually work. It's functional but still kind of clunky. Also, it
2443 only works with the pb-style.. needs to be made to work with the
2446 * buildbot/status/client.py (RemoteBuildSet): new class
2447 (RemoteBuildRequest): same
2448 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2449 object, not the internal BuildStatus object.
2450 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2451 outside of the usual buildStarted() return value.
2452 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2454 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2455 (Try_Userpass_Perspective.perspective_try): return a remotely
2456 usable BuildSetStatus object
2458 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2459 isStarted()/waitUntilStarted()
2461 2005-08-16 Brian Warner <warner@lothar.com>
2463 * buildbot/status/builder.py: implement IBuildSetStatus and
2464 IBuildRequestStatus, wire them into place.
2465 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2466 methods into the BuildSetStatus object.
2467 * buildbot/interfaces.py: same
2468 (IStatus.getBuildSets): new method to get pending BuildSets
2469 (IStatusReceiver.buildsetSubmitted): new method which hears about
2471 * buildbot/master.py (BuildMaster.submitBuildSet): same
2472 * buildbot/process/base.py (BuildRequest): same, replace
2473 waitUntilStarted with subscribe/unsubscribe
2474 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2475 subscribe instead of waitUntilStarted
2476 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2478 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2480 * buildbot/test/test_buildreq.py: update for new code
2481 * buildbot/test/test_control.py (Force.testRequest): same
2484 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2485 for Darcs to not use the tempfile module, so it works under
2486 python-2.2 too. We really didn't need the full cleverness of that
2487 module, since the slave has exclusive control of its own builddir.
2489 2005-08-15 Brian Warner <warner@lothar.com>
2491 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2492 for CVS trees. It doesn't work for non-trunk branches,
2494 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2497 * Makefile: make it easier to test against python2.2
2499 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2500 tearDown2, so things like Arch can unregister archives as they're
2501 shutting down. The previous subclass-override-tearDown technique
2502 resulted in a nested maybeWait() and test failures under
2505 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2506 where we can (Arch), add a branch= argument to set the branch used
2508 (BazExtractor): extract the branch too
2509 (TlaExtractor): same
2510 * buildbot/scripts/runner.py (TryOptions): add --branch
2511 * docs/buildbot.texinfo (try): document --branch/try_branch
2513 * buildbot/slave/commands.py (Darcs): implement get-revision for
2514 Darcs, so that 'try' will work. This requires the tempfile module
2517 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2518 of revisions, branches, and 'try' in the process.
2520 2005-08-11 Brian Warner <warner@lothar.com>
2522 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2523 this, it got broken at some point in the last few releases
2524 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2525 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2526 specifically the removal of ETA information from the tuple
2528 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2531 * docs/buildbot.texinfo (try): document both --builder and
2532 'try_builders' in .buildbot/options
2533 * buildbot/scripts/runner.py (TryOptions): add --builder,
2534 accumulate the values into opts['builders']
2535 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2536 * buildbot/test/test_runner.py (Try): add some quick tests to make
2537 sure 'buildbot try --options' and .buildbot/options get parsed
2538 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2539 use --builder control
2541 * docs/buildbot.texinfo (try): add --port argument to PB style
2543 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2544 actual SourceStamp. Still need to extract a branch name, somehow.
2545 (Try): finish implementing the try client side, still need a UI
2546 for specifying which builders to use
2547 (Try.getopt): factor our options/config-file reading
2548 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2550 * buildbot/test/test_vc.py: match SourceStampExtractor change
2552 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2553 causes the twisted log to be sent to stderr
2555 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2557 2005-08-10 Brian Warner <warner@lothar.com>
2559 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2560 style is 90% done, still missing status reporting or waiting for
2561 the buildsets to finish, and it is completely untested.
2563 * buildbot/trybuild.py: delete file, move contents to ..
2564 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2565 * buildbot/test/test_vc.py: match the move
2567 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2568 of the TryScheduler, no buildsetID or status-tracking support yet
2569 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2571 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2572 possible to set the basedir after __init__ time, so it is easier
2573 to use as a Service-child of the BuildMaster instance
2575 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2576 that delivers messages to its Service parent instead of requiring
2577 a subclass to be useful. This turns out to be much easier to build
2580 * buildbot/scripts/tryclient.py (createJob): utility code to
2581 create jobfiles, will eventually be used by 'buildbot try'
2583 2005-08-08 Brian Warner <warner@lothar.com>
2585 * docs/buildbot.texinfo (try): add docs on the
2586 as-yet-unimplemented Try scheduler
2588 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2589 * buildbot/test/test_scheduler.py: .. here
2590 (Scheduling.testTryJobdir): add placeholder test for 'try'
2592 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2593 addEntry merging (>=chunkSize) behavior
2594 (Log.testConsumer): update to handle new callLater(0) behavior
2596 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2597 both the MAX_LENGTH bugfix and the resumeProducing hang.
2599 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2600 put off the actual resumeProducing for a moment with
2601 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2602 causes large logfiles to hang midway through.
2604 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2605 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2606 and to improve memory usage when streaming the file out to a web
2608 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2609 make this work cleanly
2611 2005-08-03 Brian Warner <warner@lothar.com>
2613 * buildbot/trybuild.py: new file for 'try' utilities
2614 (getSourceStamp): run in a tree, find out the baserev+patch
2615 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2616 implemented for SVN and Darcs, still working on Arch. I don't know
2617 how to make CVS work yet.
2619 * docs/buildbot.texinfo: document the 'buildbot' command-line
2620 tool, including the not-yet-implemented 'try' feature, and the
2621 in-flux .buildbot/ options directory.
2623 2005-07-20 Brian Warner <warner@lothar.com>
2625 * buildbot/locks.py: added temporary id() numbers to Lock
2626 descriptions, to track down a not-really-sharing-the-Lock bug
2628 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2630 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2631 needed for python2.2 compatibility
2632 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2633 are from the __future__
2635 2005-07-19 Brian Warner <warner@lothar.com>
2637 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2638 message when schedulers use unknown builders
2640 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2641 SlaveLock('name') and MasterLock('name') are distinct
2643 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2644 c['schedulers'] in such a way that we can actually accept
2646 * buildbot/test/test_config.py: check it
2648 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2649 utility method to *all* the Schedulers
2650 (Periodic.listBuilderNames): same
2652 * docs/buildbot.texinfo (Interlocks): update chapter to match
2655 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2656 to make sure that c['sources'], c['schedulers'], and c['status']
2657 are all lists of the appropriate objects, and that the Schedulers
2658 all point to real Builders
2659 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2660 'listBuilderNames' utility method to support this
2661 * buildbot/scheduler.py: implement the utility method
2662 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2664 * docs/buildbot.texinfo: add some @cindex entries
2666 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2667 if it wasn't already set: most tla commands will fail unless one
2669 (Arch.createRepository): and disable bazaar's revision cache, since
2670 they cause test failures (the multiple repositories we create all
2671 interfere with each other through the cache)
2673 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2674 bring it properly up to date with twisted-2.0 test guidelines
2676 * buildbot/master.py (BuildMaster): remove references to old
2677 'interlock' module, this caused a bunch of post-merge test
2679 * buildbot/test/test_config.py: same
2680 * buildbot/process/base.py (Build): same
2682 * buildbot/test/test_slaves.py: stubs for new test case
2684 * buildbot/scheduler.py: add test-case-name tag
2685 * buildbot/test/test_buildreq.py: same
2687 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2688 unnecessary init code
2689 (Bot.remote_setBuilderList): match it
2691 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2693 * buildbot/changes/mail.py (parseSyncmail): update comment
2695 * buildbot/test/test_slavecommand.py: disable Shell tests on
2696 platforms that don't suport IReactorProcess
2698 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2699 all places where we open logfiles. It causes OS-X to open the file
2700 in some weird mode that that prevents us from mixing reads and
2701 writes to the same filehandle, which we depend upon to implement
2702 _generateChunks properly. This change doesn't appear to break
2703 win32, on which "b" and "t" are treated differently but a missing
2704 flag seems to be interpreted as "t".
2706 2005-07-18 Brian Warner <warner@lothar.com>
2708 * buildbot/slave/commands.py (ShellCommand): overhaul
2709 error-handling code, to try and make timeout/interrupt work
2710 properly, and make win32 happier
2711 * buildbot/test/test_slavecommand.py: clean up, stop using
2712 reactor.iterate, add tests for timeout and interrupt
2713 * buildbot/test/sleep.py: utility for a new timeout test
2715 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2716 code from the local-usebranches branch
2718 2005-07-17 Brian Warner <warner@lothar.com>
2720 * buildbot/process/process_twisted.py
2721 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2722 minutes, to match the other twisted BuildFactories, and don't
2723 excuse failures in c/qt/win32 reactors any more.
2725 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2726 'freebsd' builders, since the buildslaves have been unavailable
2729 2005-07-13 Brian Warner <warner@lothar.com>
2731 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2732 build-on-branch feature
2734 * buildbot/process/step.py (Darcs.__init__): add base_url and
2735 default_branch arguments, just like SVN
2736 (Arch.__init__): note that the version= argument is really the
2739 * buildbot/slave/commands.py (SourceBase): keep track of the
2740 repository+branch that was used for the last checkout in
2741 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2742 match, we clobber the directory and perform a fresh checkout
2743 rather than trying to do an in-place update. This should protect
2744 us against trying to get to branch B by doing an update in a tree
2745 obtained from branch A.
2746 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2747 (SVN.setup): same, just the svnurl
2748 (Darcs.setup): same, just the repourl
2749 (Arch.setup): same, arch coordinates (url), version, and
2750 buildconfig. Also pull the buildconfig from the args dictionary,
2751 which we weren't doing before, so the build-config was effectively
2753 (Arch.sourcedirIsUpdateable): don't try to update when we're
2754 moving to a specific revision: arch can't go backwards, so it is
2755 safer to just clobber the tree and checkout a new one at the
2757 (Bazaar.setup): same sourcedata as Arch
2759 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2760 use maybeWait, to work with twisted-1.3.0 and twcompat
2761 (Dependencies.testRun_Pass): same
2763 * buildbot/test/test_vc.py: rearrange, cleanup
2765 * buildbot/twcompat.py: add defer.waitForDeferred and
2766 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2767 can work under twisted-1.3.0 .
2769 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2770 now created at setUp time. This increases the runtime of the test
2771 suite considerably (from 91 seconds to 151), but it removes the
2772 need for an offline tarball, which should solve a problem I've
2773 seen where the test host has a different version of svn than the
2774 tarball build host. The new code also validates that mode=update
2775 really picks up recent commits. This approach will also make it
2776 easier to test out branches, because the code which creates the VC
2777 branches is next to the code which uses them. It will also make it
2778 possible to test some change-notification hooks, by actually
2779 performing a VC commit and watching to see the ChangeSource get
2782 2005-07-12 Brian Warner <warner@lothar.com>
2784 * docs/buildbot.texinfo (SVN): add branches example
2785 * docs/Makefile (buildbot.ps): add target for postscript manual
2787 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2788 * buildbot/test/test_locks.py: same
2790 * buildbot/process/step.py (Darcs): comment about default branches
2792 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2793 c['interlocks'] in the config file, complain if it is present.
2794 Scan all locks in c['builders'] to make sure the Locks they use
2796 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2797 add some tests to check for non-uniquely-named Locks
2798 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2799 since the unique-Lock validation code requires it now
2801 * buildbot/locks.py: fix test-case-name
2803 * buildbot/interlock.py: remove old file
2805 2005-07-11 Brian Warner <warner@lothar.com>
2807 * buildbot/test/test_interlock.py: rename to..
2808 * buildbot/test/test_locks.py: .. something shorter
2810 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2811 versions (after 2.0.1) changed internet.TCPClient to shut down the
2812 connection in stopService. Change the code to handle this
2815 * buildbot/process/base.py (Build): handle whole-Build locks
2816 * buildbot/process/builder.py (Builder.compareToSetup): same
2817 * buildbot/test/test_interlock.py: make tests work
2819 * buildbot/process/step.py (BuildStep.startStep): complain if a
2820 Step tries to claim a lock that's owned by its own Build
2821 (BuildStep.releaseLocks): typo
2823 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2824 file reloads don't replace unchanged Builders
2826 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2827 rewrite to cover new Locks instead of old c['interlocks']
2828 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2832 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2833 start the master and connect the buildslave
2835 * buildbot/process/step.py (FailingDummy.done): finish with a
2836 FAILURE status rather than raising an exception
2838 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2839 stringify a BuildRequest.reason that is None
2841 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2843 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2844 allow scheduler.Dependent to work
2845 * buildbot/buildset.py (BuildSet): set .reason and .results
2847 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2848 slaves, to make the test stop hanging. It still fails, of course,
2849 because I haven't even started to implement Locks.
2851 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2853 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2854 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2855 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2856 (Dependent): new class for downstream build dependencies
2857 * buildbot/test/test_dependencies.py: tests (still failing)
2859 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2861 2005-07-07 Brian Warner <warner@lothar.com>
2863 * buildbot/test/runutils.py (RunMixin): factored this class out..
2864 * buildbot/test/test_run.py: .. from here
2865 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2866 added new buildbot.locks tests (which all hang right now)
2867 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2868 * buildbot/process/step.py: claim/release per-BuildStep locks
2870 * docs/Makefile: add 'buildbot.html' target
2872 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2873 interpreted as "HEAD", so that all VC steps can accept branch=None
2874 and have it mean the "default branch".
2876 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2878 2005-07-07 Brian Warner <warner@lothar.com>
2880 * docs/examples/twisted_master.cfg: update to match current usage
2882 * docs/buildbot.texinfo (System Architecture): comment out the
2883 image, it doesn't exist yet and just screws up the HTML manual.
2885 2005-07-05 Brian Warner <warner@lothar.com>
2887 * debian/.cvsignore: oops, missed one. Removing leftover file.
2889 2005-06-17 Brian Warner <warner@lothar.com>
2891 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2892 changed its output in 1.2.0, don't mistakenly think that the
2893 subversion we find isn't capable of supporting our tests.
2895 * debian/*: remove the debian/ directory and its contents, to make
2896 life easier for the proper Debian maintainer
2898 * Makefile (release): same
2900 2005-06-07 Brian Warner <warner@lothar.com>
2902 * everything: create a distinct SourceStamp class to replace the
2903 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2904 Changed the signature of Source.startVC to include the revision
2905 information (instead of passing it through self.args). Implement
2906 branches for SVN (now only Darcs/Git is missing support). Add more
2909 2005-06-06 Brian Warner <warner@lothar.com>
2911 * everything: rearrange build scheduling. Create a new Scheduler
2912 object (configured in c['schedulers'], which submit BuildSets to a
2913 set of Builders. Builders can now use multiple slaves. Builds can
2914 be run on alternate branches, either requested manually or driven
2915 by changes. This changed some of the Status classes. Interlocks
2916 are out of service until they've been properly split into Locks
2917 and Dependencies. treeStableTimer, isFileImportant, and
2918 periodicBuild have all been moved from the Builder to the
2920 (BuilderStatus.currentBigState): removed the 'waiting' and
2921 'interlocked' states, removed the 'ETA' argument.
2923 2005-05-24 Brian Warner <warner@lothar.com>
2925 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2926 erroneously abandons the connection (in clientConnectionFailed)
2927 for non-UserErrors, which means that if we lose the connection due
2928 to a network problem or a timeout, we'll never try to reconnect.
2929 Fix this by not upcalling to the buggy parent method. Note:
2930 twisted-2.0 fixes this, but the function only has 3 lines so it
2931 makes more sense to copy it than to try and detect the buggyness
2932 of the parent class. Fixes SF#1207588.
2934 * buildbot/changes/changes.py (Change.branch): doh! Add a
2935 class-level attribute to accomodate old Change instances that were
2936 pickled before 0.6.5 (where .branch was added for new Changes).
2937 This fixes the exception that occurs when you try to look at an
2938 old Change (through asHTML).
2940 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2943 2005-05-23 Brian Warner <warner@lothar.com>
2945 * buildbot/__init__.py (version): release 0.6.6
2947 2005-05-23 Brian Warner <warner@lothar.com>
2949 * NEWS: update for 0.6.6 release
2950 * debian/changelog: same
2952 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2953 before starting: this was done by twistd back when we spawned it,
2954 now that we're importing the pieces and running them in the
2955 current process, we have to do it ourselves. This allows
2956 master.cfg to import files from the same directory without
2957 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2958 Stichele for the catch.
2959 (Options.opt_version): Add a --version command (actually, just make
2960 the existing --version command emit Buildbot's version too)
2962 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2963 fix to make this behave like other LogFiles, this time to handle
2964 existing LogFiles on disk. (add the missing .upgrade method)
2965 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2967 2005-05-21 Brian Warner <warner@lothar.com>
2969 * buildbot/test/test_runner.py (Create.testMaster): match the
2970 rawstring change in runner.py:masterTAC
2972 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2973 TwistedWords is installed
2974 * buildbot/test/test_status.py: same, with TwistedMail
2976 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2977 some old, deprecated, and removed config keys). This should enable
2978 you to use the base buildbot functionality with Twisted-2.0.0 when
2979 you don't also have TwistedWeb and TwistedWords installed
2981 2005-05-20 Brian Warner <warner@lothar.com>
2983 * buildbot/scripts/runner.py (run): call sendchange(), not
2984 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2985 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2986 (stop): don't wait for process to die when sending SIGHUP
2987 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2988 directory name gets interpreted, which you don't want
2991 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2994 2005-05-18 Brian Warner <warner@lothar.com>
2996 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2998 2005-05-18 Brian Warner <warner@lothar.com>
3000 * README: update for 0.6.5
3001 * debian/changelog: same
3003 * buildbot/changes/changes.py: rename tag= to branch=, since
3004 that's how we're using it, and my design for the upcoming "build a
3005 specific branch" feature wants it. also, tag= was too CVS-centric
3006 * buildbot/changes/mail.py (parseSyncmail): same
3007 * buildbot/process/base.py (Build.isBranchImportant): same
3008 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3009 * docs/buildbot.texinfo (Attributes of Changes): same
3011 * NEWS: update tag=, update for upcoming release
3013 2005-05-17 Brian Warner <warner@lothar.com>
3015 * buildbot/scripts/runner.py (stop): actually poll once per
3016 second, instead of re-killing the poor daemon once per second.
3017 Sleep briefly (0.1s) before the first poll, since there's a good
3018 chance we can avoid waiting the full second if the daemon shuts
3019 down quickly. Also remove the sys.exit() at the end.
3020 (start): remove the unneighborly sys.exit()
3022 * Makefile: improve permission-setting to not kick Arch so badly
3024 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3025 default --keepalive=600, since it doesn't hurt very much, and it's
3026 a hassle to discover that you need it.
3027 * buildbot/test/test_runner.py (Create.testSlave): test it
3029 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3030 IRC bot about EXCEPTION
3032 * buildbot/status/client.py (PBListener): upcall more correctly
3034 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3035 an exception mark the overall build with EXCEPTION, not SUCCESS
3037 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3039 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3040 * Makefile: update some release-related stuff
3042 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3043 gets called when there isn't actually an active process, just end
3044 the Command instead of blowing up. I don't know how it gets into
3045 this state, but the twisted win32 buildslave will sometimes hang,
3046 and when it shakes its head and comes back, it thinks it's still
3047 running a Command. The next build causes this command to be
3048 interrupted, but the lack of self.process.pid breaks the interrupt
3051 * NEWS: document changes since the last release
3053 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3054 look for Makefile.buildbot instead of a bare Makefile . The
3055 'buildbot start' does not install this file, so you have to
3056 manually copy it if you want to customize startup behavior.
3057 (createMaster): change 'buildbot master' command to create
3058 Makefile.sample instead of Makefile, to create master.cfg.sample
3059 instead of master.cfg (requiring you to copy it before the
3060 buildmaster can be started). Both sample files are kept up to
3061 date, i.e. they are overwritten if they have been changed. The
3062 'buildbot.tac' file is *not* overwritten, but if the new contents
3063 don't match the old, a 'buildbot.tac.new' file is created and the
3064 user is warned. This seems to be a much more sane way to handle
3065 startup files. Also, don't sys.exit(0) when done, so we can run
3066 unit tests against it.
3067 (createSlave): same. Don't overwrite the sample info/ files.
3068 * buildbot/scripts/sample.mk: remove. the contents were pulled
3069 into runner.py, since they need to match the behavior of start()
3073 * docs/buildbot.texinfo (Launching the daemons): document it
3074 * buildbot/test/test_runner.py (Create): test it
3076 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3077 version that can handle string-in-string tests, because otherwise
3078 python-2.2 fails the tests. It'd be tremendous if Trial's test
3079 took two strings under 2.2 too.
3081 * everything: fixed all deprecation warnings when running against
3082 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3083 few that come from Twisted itself). This involved putting most of
3084 the Twisted-version specific code in the new buildbot.twcompat
3085 module, and creating some abstract base classes in
3086 buildbot.changes.base and buildbot.status.base (which might be
3087 useful anyway). __implements__ is a nuisance and requires an ugly
3088 'if' clause everywhere.
3090 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3091 delay before finishing the test: it seems that smtp.sendmail
3092 doesn't hang up on the server, so we must wait a moment so it can
3093 hang up on us. This removes the trial warning about an unclean
3096 2005-05-16 Brian Warner <warner@lothar.com>
3098 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3099 tuple of (delay, repeats).
3100 * buildbot/test/test_vc.py (Retry): test it
3101 * docs/buildbot.texinfo (Source Checkout): document it
3102 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3103 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3104 doVCFull() are handled by re-trying the checkout (after a delay)
3105 some number of times.
3106 (ShellCommand._startCommand): make header lines easier to read
3108 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3110 (WebTest.test_logfile): make sure master gets shut down, silences
3111 some "unclean reactor" test errors
3113 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3114 reactor once after shutdown, something in certain versions of
3115 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3116 fails, svn-trunk is ok.
3118 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3119 second win32 error message
3121 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3122 validating the ETA, so the tests don't fail on slow systems
3124 2005-05-15 Brian Warner <warner@lothar.com>
3126 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3127 the new LogFile class, so upgrading works properly
3128 (LogFileProducer.resumeProducing): survive resumeProducing after
3129 we've exhausted the chunkGenerator
3131 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3133 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3134 (Log.testUpgrade): same
3136 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3137 Builds and logs with a cron job.
3139 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3140 of the old non-offline LogFile, added code to upgrade these to
3141 new-style contents-live-on-disk instances at load time (in a way
3142 that doesn't invalidate the old Build pickles, so upgrading to
3143 0.6.5 is not a one-way operation). Got rid of everything related
3145 (LogFile.__init__): create LogFiles with the parent step status,
3146 the log's name, and a builder-relative filename where it can keep
3147 the contents on disk.
3148 (LogFile.hasContents): new method, clients are advised to call it
3149 before getText or getChunks and friends. If it returns False, the
3150 log's contents have been deleted and getText() will raise an
3152 (LogFile.getChunks): made it a generator
3153 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3154 Consumer (except one that takes chunks instead of strings). This
3155 enables streaming of very large logfiles without storing the whole
3157 (BuildStatus.generateLogfileName): create names like
3158 12-log-compile-output, with a _0 suffix if required to be unique
3159 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3160 or earlier) logfiles into new-style ones
3161 (BuilderStatus): remove everything related to 'stub' builds. There
3162 is now only one build cache, and we don't strip logs from old
3164 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3165 since we no longer fight to keep it in the cache
3167 * buildbot/status/html.py (TextLog.render_GET): use a
3168 ChunkConsumer to stream the log entries efficiently.
3169 (ChunkConsumer): wrapper which consumes chunks and writes
3172 * buildbot/test/test_twisted.py (Parse.testParse): use a
3173 LogFile-like object instead of a real one
3175 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3176 (Log.testMerge3): validate more merge behavior
3177 (Log.testChunks): validate LogFile.getChunks
3178 (Log.testUpgrade): validate old-style LogFile upgrading
3179 (Log.testSubscribe): validate LogFile.subscribe
3180 (Log.testConsumer): validate LogFile.subscribeConsumer
3182 * buildbot/interfaces.py (IStatusLogStub): remove
3183 (IStatusLog.subscribeConsumer): new method
3184 (IStatusLog.hasContents): new method
3185 (IStatusLogConsumer): describes things passed to subscribeConsumer
3187 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3188 the log contents if it does not have any contents.
3189 (StatusResourceBuildStep.body): same
3190 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3192 2005-05-14 Brian Warner <warner@lothar.com>
3194 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3195 timeouts to try and make the windows metabuildslave not hang
3197 2005-05-13 Mike Taylor <bear@code-bear.com>
3199 * buildbot/slave/commands.py (rmdirRecursive): added a check
3200 to ensure the path passed into rmdirRecursive actually exists.
3201 On win32 a non-existant path would generate an exception.
3203 2005-05-13 Brian Warner <warner@lothar.com>
3205 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3206 shutil.rmtree which behaves correctly on windows in the face of
3207 files that you have to chmod before deleting. Thanks to Bear at
3208 the OSAF for the routine.
3209 (SourceBase.doClobber): use rmdirRecursive
3211 2005-05-12 Brian Warner <warner@lothar.com>
3213 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3214 method generate chunks instead of returning a big list. This
3215 allows the same method to be used for both old LogFile and new
3217 (OfflineLogFile.getText): use the generator
3218 (OfflineLogFile.subscribe): same
3219 * buildbot/status/html.py (TextLog.resumeProducing): same
3220 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3222 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3223 point out that OfflineLogFile does not currently work with
3224 html.Waterfall . Fixing this is high-priority.
3226 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3227 apparently windows defaults to using stdout
3229 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3230 better message on failure so I can figure out the win32 problem
3232 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3233 log messages to include more useful copies of the command being
3234 run, the argv array, and the child command's environment.
3235 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3237 2005-05-11 Brian Warner <warner@lothar.com>
3239 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3241 * Makefile: update the deb-snapshot version
3243 * docs/buildbot.texinfo: move all .xhtml docs into a new
3244 .texinfo-format document, adding a lot of material in the process.
3245 This is starting to look like a real user's manual. Removed all
3246 the Lore-related files: *.xhtml, *.css, template.tpl .
3247 * docs/Makefile: simple makefile to run 'makeinfo'
3248 * buildbot/scripts/sample.cfg: rearrange slightly
3249 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3251 2005-05-10 Brian Warner <warner@lothar.com>
3253 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3254 different name for the internal twistw module, handle it.
3256 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3257 * setup.py: .. and stop trying to install it
3259 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3260 'git'), the new linux kernel VC system (http://kernel.org/git/).
3261 Thanks to Brandon Philips for the patch.
3262 * buildbot/slave/commands.py (Git): same
3264 2005-05-06 Brian Warner <warner@lothar.com>
3266 * buildbot/status/builder.py (OfflineLogFile): replace the default
3267 LogFile with a form that appends its new contents to a disk file
3268 as they arrive. The complete log data is never kept in RAM. This
3269 is the first step towards handling very large (100MB+) logfiles
3270 without choking quite so badly. (The other half is
3271 producer/consumer on the HTML pages).
3272 (BuildStepStatus.addLog): use OfflineLogFile by default
3273 (BuildStatus.getLogfileName): helper code to give the
3274 OfflineLogFile a filename to work with
3276 * buildbot/test/test_status.py (Results.testAddResults): update
3277 tests to handle new asserts
3278 * buildbot/test/test_vc.py (Patch.doPatch): same
3279 * buildbot/test/test_steps.py (BuildStep.setUp): same
3281 2005-05-05 Brian Warner <warner@lothar.com>
3283 * buildbot/scripts/runner.py (start): if there is no Makefile,
3284 launch the app by importing twistd's internals and calling run(),
3285 rather than spawning a new twistd process. This stands a much
3286 better chance of working under windows.
3287 (stop): kill the process with os.kill instead of spawning
3288 /bin/kill, again to reduce the number of external programs which
3289 windows might not have in the PATH. Also wait up to 5 seconds for
3290 the process to go away, allowing things like 'buildbot stop;
3291 buildbot start' to be reliable in the face of slow shutdowns.
3293 * buildbot/master.py (Dispatcher.__getstate__): remove old
3294 .tap-related methods
3295 (BuildMaster.__getstate__): same
3297 * buildbot/slave/bot.py (makeService): same
3298 (Options.longdesc): same
3299 * buildbot/scripts/runner.py: copy over some old mktap option text
3301 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3302 'buildbot master' now creates a buildbot.tac file, so there is no
3303 longer a create-instance/save/reload sequence. mktap is dead, long
3305 * buildbot/scripts/sample.mk: use twistd -y, not -f
3306 * buildbot/test/test_config.py: remove mktap-based test
3307 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3308 * README: don't reference mktap
3310 * docs/source.xhtml: document some of the attributes that Changes
3313 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3315 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3316 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3317 * buildbot/changes/changes.py (Change)
3318 * buildbot/changes/mail.py (parseSyncmail)
3319 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3321 * buildbot/process/base.py (Build.isTagImportant)
3325 2005-05-04 Brian Warner <warner@lothar.com>
3327 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3328 connection after sending the change, so that unit tests don't
3329 complain about sockets being left around
3331 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3332 exception in phase=0 rendering
3333 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3335 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3337 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3338 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3339 and configuring builders with tuples.
3340 * buildbot/test/test_config.py: stop testing compatibility with
3341 deprecated config keys
3342 * buildbot/test/test_run.py: same
3344 2005-05-03 Brian Warner <warner@lothar.com>
3346 * contrib/arch_buildbot.py: survive if there are no logfiles
3347 (username): just use a string, os.getlogin isn't reliable
3349 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3350 so 'buildbot sendchange' actually works. The earlier test only
3351 covered the internal (non-reactor-running) form.
3353 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3354 script to notify the buildmaster about changes
3356 * buildbot/scripts/runner.py (sendchange): new command to send a
3357 change to a buildbot.changes.pb.PBChangeSource receiver.
3358 * buildbot/test/test_changes.py (Sender): test it
3360 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3361 after any reading of the config file, not just when we do it in
3362 startService. This makes some tests a bit cleaner.
3364 * buildbot/changes/pb.py: add some log messages
3366 * buildbot/process/base.py (Build.startBuild): fix a bug that
3367 caused an exception when the build terminated in the very first
3369 (Build.stepDone): let steps return a status of EXCEPTION. This
3370 terminates the build right away, and sets the build's overall
3371 status to EXCEPTION too.
3372 * buildbot/process/step.py (BuildStep.failed): return a status of
3373 EXCEPTION when that is what has happened.
3375 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3376 implement this, allowing Arch-based projects to get precise
3377 checkouts instead of always using the latest code
3378 (Bazaar): create variant of Arch to let folks use baz instead of
3379 tla. Requires a new buildslave too.
3380 * buildbot/slave/commands.py (Arch): add 'revision' argument
3381 (Bazaar): create variant of Arch that uses baz instead of tla.
3382 Remove the code that extracts the archive name from the
3383 register-archive output, since baz doesn't provide it, and require
3384 the user provide both the archive name and its location.
3385 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3387 2005-05-02 Brian Warner <warner@lothar.com>
3389 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3390 thanks to Nick Trout.
3392 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3393 deals better with source Makefile coming from a read-only CVS
3394 checkout. Thanks to Nick Trout for the catch.
3396 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3399 2005-04-28 Brian Warner <warner@lothar.com>
3401 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3403 * debian/changelog: update for 0.6.4
3405 2005-04-28 Brian Warner <warner@lothar.com>
3407 * README.w32: add a checklist of steps for getting buildbot
3409 * MANIFEST.in: include it in the tarball
3413 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3414 broken .tap files from 0.6.3 by getting rid of .services,
3415 .namedServices, and .change_svc at load time.
3417 2005-04-27 Brian Warner <warner@lothar.com>
3419 * NEWS: update in preparation for new release
3421 * buildbot/test/test_config.py (Save.testSave): don't pull in
3422 twisted.scripts.twistd, we don't need it and it isn't for windows
3425 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3426 accomodate win32 which can't do atomic-rename
3428 2005-04-27 Brian Warner <warner@lothar.com>
3430 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3431 timeouts to help the slow metabuildbot not flunk them so much
3432 (Disconnect.testBuild3): same
3433 (Disconnect.testBuild4): same
3434 (Disconnect.testInterrupt): same
3436 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3437 setup, it was completely broken for new buildmasters (those which
3438 did not have a 'change.pck' already saved. Thanks to Paul Warren
3439 for catching this (embarrassing!) bug.
3440 (Dispatcher.__getstate__): don't save our registered avatar
3441 factories, since they'll be re-populated when the config file is
3443 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3444 tests (since the real mktap-generated BuildMaster doesn't save
3446 (BuildMaster.__getstate__): don't save any service children,
3447 they'll all be re-populated when the config file is re-read.
3448 * buildbot/test/test_config.py (Save.testSave): test for this
3450 2005-04-26 Brian Warner <warner@lothar.com>
3452 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3453 rendered with Blender.. looks a bit nicer.
3454 * buildbot/docs/images/icon.blend: add the Blender file for it
3456 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3457 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3458 running under windows. This appears to be the best way to allow
3459 BuildSteps to do something normal like 'trial -v buildbot.test' or
3460 'make foo' and still expect it to work. The idea is to make the
3461 BuildSteps look as much like what a developer would type when
3462 compiling or testing the tree by hand. This approach probably has
3463 problems when there are spaces in the arguments, so if you've got
3464 windows buildslaves, you'll need to pay close attention to your
3467 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3468 timezone to the timestamp column.
3469 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3471 * buildbot/scripts/runner.py (loadOptions): do something sane for
3472 windows, I think. We use %APPDATA%/buildbot instead of
3473 ~/.buildbot, but we still search everywhere from the current
3474 directory up to the root for a .buildbot/ subdir. The "is it under
3475 $HOME" security test was replaced with "is it owned by the current
3476 user", which is only performed under posix.
3477 * buildbot/test/test_runner.py (Options.testFindOptions): update
3478 tests to match. The "is it owned by the current user" check is
3479 untested. The test has been re-enabled for windows.
3481 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3482 any "\n" in the expected output with the platform-specific line
3483 separator. Make this separator "\r\n" on PTYs under unix, they
3484 seem to do that and I don't know why
3486 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3487 windows for now, I don't know what ~/.buildbot/ should mean there.
3489 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3490 win32 compatibility, don't use "/tmp"
3491 (Basedir.testChangeBuilddir): remove more unixisms
3493 2005-04-26 Brian Warner <warner@lothar.com>
3495 * buildbot/test/test_control.py (Force.rmtree): python2.2
3496 compatibility, apparently its shutil.rmtree ignore_errors=
3497 argument is ignored.
3498 * buildbot/test/test_run.py (Run.rmtree): same
3499 (RunMixin.setUp): same
3501 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3504 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3505 'substring in string' operator, must use string.find(substr)!=-1
3506 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3507 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3509 * buildbot/scripts/runner.py (loadOptions): add code to search for
3510 ~/.buildbot/, a directory with things like 'options', containing
3511 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3512 the current directory, your $HOME directory, or anywhere
3513 inbetween, as long as you're somewhere inside your home directory.
3514 (debugclient): look in ~/.buildbot/options for master and passwd
3515 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3516 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3518 * buildbot/status/client.py (makeRemote): new approach to making
3519 IRemote(None) be None, which works under Twisted-2.0
3520 * buildbot/test/test_status.py (Client.testAdaptation): test it
3522 * buildbot/status/builder.py (Status.builderAdded): when loading a
3523 pickled BuilderStatus in from disk, set its name after loading.
3524 The config file might have changed its name (but not its
3525 directory) while it wasn't looking.
3527 * buildbot/process/builder.py (Builder.attached): always return a
3528 Deferred, even if the builder was already attached
3529 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3531 2005-04-25 Brian Warner <warner@lothar.com>
3533 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3534 category-related exception when announcing a build has finished
3536 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3537 reference no-longer-existent changemaster.sources
3538 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3540 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3543 2005-04-25 Brian Warner <warner@lothar.com>
3545 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3547 * debian/changelog: update for 0.6.3
3549 2005-04-25 Brian Warner <warner@lothar.com>
3551 * MANIFEST.in: make sure debug.glade is in the tarball
3553 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3555 * NEWS: update for the imminent 0.6.3 release
3557 * buildbot/status/html.py (HtmlResource.content): make the
3558 stylesheet <link> always point at "buildbot.css".
3559 (StatusResource.getChild): map "buildbot.css" to a static.File
3560 containing whatever css= argument was provided to Waterfall()
3561 (Waterfall): provide the "classic" css as the default.
3562 * docs/waterfall.classic.css: move default CSS from here ..
3563 * buildbot/status/classic.css: .. to here
3565 * MANIFEST.in: make sure classic.css is included in the tarball
3566 * setup.py: and that it is installed too, under buildbot/status/
3568 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3569 the module level, because buildbot.tap files from 0.6.2 don't have
3570 it in their attribute dictionary.
3572 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3573 really exists at startup, might save some confusion somewhere.
3575 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3577 * docs/waterfall.classic.css:
3578 add a stylesheet that's almost the same as the "classic"
3581 * buildbot/status/builder.py:
3582 add EXCEPTION as a result - this is a problem for the bot
3583 maintainer, not a build problem for the changers
3584 * buildbot/process/step.py:
3585 use EXCEPTION instead of FAILURE for exceptions
3586 * buildbot/status/html.py:
3587 add build_get_class to get a class out of a build/buildstep
3588 finish naming the classes
3589 split out sourceNames to changeNames and builderNames so we
3590 can style them separately
3591 * docs/config.xhtml:
3592 finish documenting classes as they are right now
3594 * buildbot/status/html.py:
3595 name the classes as we agreed on IRC
3596 * docs/config.xhtml:
3599 * buildbot/status/html.py:
3600 same for cssclass->class_
3602 * buildbot/status/html.py:
3603 as decided on IRC, use class_ for the "class" attribute to not
3604 conflict with the class keyword, and clean up the messy **{} stuff.
3606 * buildbot/status/mail.py:
3607 put back "builders" argument, and fix docstring, because the
3608 code *ignores* builders listed in this argument
3610 * buildbot/process/builder.py:
3611 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3613 * docs/config.xhtml:
3614 describe the category argument for builders
3616 * buildbot/status/builder.py:
3617 Fix a silly bug due to merging
3619 * buildbot/process/builder.py:
3620 remove category from the process Builder ...
3621 * buildbot/status/builder.py:
3622 ... and add it to BuilderStatus instead.
3623 Set category on unpickled builder statuses, they might not have it.
3624 * buildbot/master.py:
3625 include category when doing builderAdded
3626 * buildbot/status/mail.py:
3627 return None instead of self for builders we are not interested in.
3628 * buildbot/test/test_run.py:
3629 fix a bug due to only doing deferredResult on "dummy" waiting
3630 * buildbot/test/test_status.py:
3631 add checks for the Mail IStatusReceiver returning None or self
3633 * buildbot/status/html.py:
3634 fix testsuite by prefixing page title with BuildBot
3636 * buildbot/status/builder.py:
3637 have .category in builder status ...
3638 * buildbot/process/builder.py:
3639 ... and set it from Builder
3640 * buildbot/status/html.py:
3641 make .css a class variable
3642 * buildbot/test/test_status.py:
3643 write more tests to cover our categories stuff ...
3644 * buildbot/status/mail.py:
3645 ... and fix the bug that this uncovered
3647 * buildbot/changes/mail.py:
3648 * buildbot/changes/pb.py:
3649 * buildbot/master.py:
3650 * buildbot/process/base.py:
3651 * buildbot/process/factory.py:
3652 * buildbot/process/interlock.py:
3653 * buildbot/process/step.py:
3654 * buildbot/process/step_twisted.py:
3655 * buildbot/slave/commands.py:
3656 * buildbot/status/builder.py:
3657 * buildbot/status/client.py:
3658 * buildbot/status/html.py:
3659 * buildbot/status/mail.py:
3660 * buildbot/status/progress.py:
3661 * buildbot/test/test_changes.py:
3662 * buildbot/test/test_config.py:
3663 * buildbot/test/test_control.py:
3664 * buildbot/test/test_interlock.py:
3665 * buildbot/test/test_maildir.py:
3666 * buildbot/test/test_mailparse.py:
3667 * buildbot/test/test_run.py:
3668 * buildbot/test/test_slavecommand.py:
3669 * buildbot/test/test_status.py:
3670 * buildbot/test/test_steps.py:
3671 * buildbot/test/test_twisted.py:
3672 * buildbot/test/test_util.py:
3673 * buildbot/test/test_vc.py:
3674 * buildbot/test/test_web.py:
3676 add test-case-name at the top of a whole set of files
3678 * buildbot/status/builder.py:
3679 keep order of addition when getting builder names
3680 * buildbot/status/words.py:
3681 * buildbot/test/test_run.py:
3682 add test for getBuilderNames
3684 * buildbot/process/base.py:
3685 * buildbot/process/step.py:
3686 * buildbot/status/builder.py:
3687 * buildbot/status/html.py:
3688 make buildbot css-able
3689 replace the color code for purple with purple, don't understand
3690 why it wasn't purple to start with
3692 * buildbot/status/words.py:
3693 ok, so it doesn't look like BuilderStatus.remote is still valid.
3694 Use what waterfall uses instead.
3696 * buildbot/interfaces.py:
3697 * buildbot/status/builder.py:
3698 * buildbot/status/html.py:
3699 * buildbot/status/mail.py:
3700 * buildbot/status/words.py:
3701 * buildbot/test/test_run.py:
3702 use categories everywhere and make it be a list. More sensible
3703 for the future. Also make words actually respect this in
3706 * buildbot/interfaces.py:
3707 add category argument to getBuilderNames
3708 * buildbot/process/builder.py:
3709 * buildbot/status/builder.py:
3710 * buildbot/status/html.py:
3711 * buildbot/status/mail.py:
3712 * buildbot/status/words.py:
3713 * buildbot/test/test_run.py:
3714 move from specifying builders by name to specifying the category
3716 * buildbot/status/html.py:
3717 * buildbot/status/words.py:
3718 add "builders=" to __init__ of status clients so they can
3719 limit themselves to the given list of builders to report on
3721 * buildbot/status/html.py: set the title to the product name
3723 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3725 * buildbot/interfaces.py:
3726 * buildbot/status/builder.py:
3727 more documentation. Hm, not sure if ChangeLog entries make sense
3730 2005-04-23 Brian Warner <warner@lothar.com>
3732 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3734 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3736 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3737 the sub-commands that log buildmaster status to stdout and to a
3738 GUI window, respectively.
3740 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3741 functionality is working again, but all the step-status and ETA
3742 stuff is missing. Commented out a lot of code pending more
3745 * buildbot/status/client.py: make sure that IRemote(None) is None
3747 * buildbot/changes/changes.py: import defer, oops
3748 (ChangeMaster): remove the .sources list, rely upon the fact that
3749 MultiServices can be treated as sequences of their children. This
3750 cleans up the add/remove ChangeSource routines a lot, as we keep
3751 exactly one list of the current sources instead of three.
3753 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3754 up an empty ChangeMaster at init time.
3755 (BuildMaster.loadChanges): if there are changes to be had from
3756 disk, replace self.change_svc with the new ones. If not, keep
3757 using the empty ChangeMaster set up in __init__.
3758 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3759 instead of a separate list, makes the code a bit cleaner.
3760 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3761 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3762 Extend the test to make sure we can get rid of the sources when
3765 2005-04-22 Brian Warner <warner@lothar.com>
3767 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3768 and info/host files when making the slave directory
3770 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3771 whendone= argument, just return the Deferred and let the caller do
3772 what they want with it.
3773 (Disconnect.testBuild1): wait for shutdownSlave
3774 (Basedir.testChangeBuilddir): new test to make sure changes to the
3775 builddir actually get propagated to the slave
3777 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3778 explicit method, rather than passing the builddir in __init__ .
3779 Make sure to update self.basedir too, this was broken before.
3780 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3781 builders and for ones that have just had their builddir changed.
3782 (BotFactory): add a class-level .perspective attribute, so
3783 BuildSlave.waitUntilDisconnected won't get upset when the
3784 connection hasn't yet been established
3785 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3786 tests can reach through it to inspect the SlaveBuilders
3788 * buildbot/process/base.py (Build.buildException): explain the
3789 log.err with a log.msg
3790 * buildbot/process/builder.py (Builder.startBuild): same
3791 (Builder._startBuildFailed): improve error message
3793 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3794 occurred because we lost the brand-new connection, retry instead
3795 of giving up. If not, it's probably an authorization failure, and
3796 it makes sense to stop trying. Make sure we log.msg the reason
3797 that we're log.err'ing the failure, otherwise test failures are
3798 really hard to figure out.
3800 * buildbot/master.py: change loadConfig() to return a Deferred
3801 that doesn't fire until the change has been fully implemented.
3802 This means any connected slaves have been updated with the new
3803 builddir. This change makes it easier to test the code which
3804 actually implements this builddir-updating.
3805 (BotPerspective.addBuilder): return Deferred
3806 (BotPerspective.removeBuilder): same
3807 (BotPerspective.attached): same
3808 (BotPerspective._attached): same. finish with remote_print before
3809 starting the getSlaveInfo, instead of doing them in parallel
3810 (BotPerspective.list_done): same
3811 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3812 actually calling slave.disconnect()
3813 (BotMaster.addBuilder): same
3814 (BotMaster.removeBuilder): same
3815 (BuildMaster.loadConfig): same
3816 (BuildMaster.loadConfig_Slaves): same
3817 (BuildMaster.loadConfig_Sources): same
3818 (BuildMaster.loadConfig_Builders): same
3819 (BuildMaster.loadConfig_status): same
3821 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3822 a Deferred that fires when the source is finally removed
3824 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3825 the previous tree on win32, where we have to do it synchronously,
3826 make sure we return a Deferred anyway.
3827 (SourceBase.doCopy): same
3829 * buildbot/scripts/runner.py (statusgui): use the text client for
3830 now, while I rewrite the Gtk one
3831 * buildbot/clients/base.py: strip out old code, leaving just the
3832 basic print-message-on-event functionality. I also remove the
3833 ReconnectingPBClientFactory, but it does at least quit when it
3834 loses the connection instead of going silent
3836 2005-04-21 Brian Warner <warner@lothar.com>
3838 * Makefile: minor tweaks
3840 * NEWS: point out deprecation warnings, new features for
3843 * buildbot/master.py (BuildMaster.loadConfig): emit
3844 DeprecationWarnings for Builders defined with tuples. Rearrange
3845 code to facility removal of deprecated configuration keys in the
3848 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3849 'buildbot' command to put a little Makefile in the target that
3850 helps you re-create the buildbot.tap file, start or stop the
3851 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3852 all the files 0600, since they contain passwords.
3853 (start): if there is a Makefile, and /usr/bin/make exists, use
3854 'make start' in preference to a raw twistd command. This lets
3855 slave admins put things like PYTHONPATH variables in their
3856 Makefiles and have them still work when the slave is started with
3857 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3858 be nice to first try the 'make' command and only fall back to
3859 twistd if it fails. TODO: the Makefile's "start" command does not
3860 add the --reactor=win32 argument when running under windows.
3861 (Options.debugclient, Options.statusgui): add sub-commands to launch
3862 the debug client (formerly in contrib/debugclient.py) and the
3863 Gtk status application (currently broken)
3864 * buildbot/clients/debug.py: move from contrib/debugclient.py
3865 * buildbot/clients/debug.glade: same
3867 * buildbot/test/test_trial.py: remove it. This requires some
3868 functionality out of Twisted that isn't there yet, and until then
3869 having it around just confuses things.
3871 * buildbot/test/test_slavecommand.py (Shell): test both with and
3872 without PTYs, and make sure that command output is properly
3873 interleaved in the with-PTY case. I think the without-PTY test
3874 should pass on windows, where we never use PTYs anyway.
3876 2005-04-20 Brian Warner <warner@lothar.com>
3878 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3880 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3882 * NEWS: start creating entries for the next release
3884 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3886 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3887 (WebTest.test_webPathname): same
3888 (WebTest.test_webPathname_port): same
3889 (WebTest.test_waterfall): use the default favicon rather than
3890 rooting around the filesystem for it. Open the expected-icon file
3891 in binary mode, to make win32 tests happier (thanks to Nick Trout
3893 * buildbot/status/html.py (buildbot_icon): win32 portability
3895 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3896 win32-compatibility fixes from Nick Trout, the "file not found" message
3897 is different under windows
3898 (FakeSlaveBuilder.__init__): clean up setup a bit
3899 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3901 2005-04-19 Brian Warner <warner@lothar.com>
3903 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3904 skip-if-repositories-are-unavailable test to not kill the trial
3905 that comes with Twisted-1.3.0
3907 * setup.py: install buildbot.png icon file when installing code
3909 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3910 environment used by the command, at least on the child side.
3912 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3913 this method needs to be added and implemented because it gets
3914 called under heavy load. I don't quite understand the
3915 producer/consumer API enough to write it.
3916 (StatusResource.getChild): add a resource for /favicon.ico
3917 (Waterfall.__init__): add favicon= argument
3918 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3919 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3920 (WebTest.test_webPathname): same
3921 (WebTest.test_webPathname_port): same
3922 * docs/config.xhtml: mention favicon=
3923 * buildbot/buildbot.png: add a default icon, dorky as it is
3925 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3927 * buildbot/master.py:
3928 * buildbot/process/base.py:
3929 * buildbot/process/builder.py:
3930 * buildbot/process/interlock.py:
3931 * buildbot/status/builder.py:
3932 * buildbot/status/html.py:
3933 * buildbot/status/mail.py:
3934 * buildbot/status/words.py:
3935 new documentation while digging through the code
3937 2005-04-17 Brian Warner <warner@lothar.com>
3939 * general: try to fix file modes on all .py files: a+r, a-x,
3940 but let buildbot/clients/*.py be +x since they're tools
3942 * docs/epyrun (addMod): when an import fails, say why
3944 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3946 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3948 * buildbot/process/base.py:
3949 * buildbot/process/builder.py:
3950 * buildbot/status/builder.py:
3951 new documentation while digging through the code
3953 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3955 * buildbot/changes/changes.py:
3956 * buildbot/changes/p4poller.py:
3957 * buildbot/interfaces.py:
3958 * buildbot/process/base.py:
3959 * buildbot/process/builder.py:
3960 * buildbot/process/step.py:
3961 * buildbot/process/step_twisted.py:
3962 * buildbot/slave/bot.py:
3963 * buildbot/slave/commands.py:
3964 * buildbot/status/builder.py:
3965 fix all docstrings to make epydoc happy. In the process of fixing
3966 some, I also moved pieces of docs, and removed some deprecated
3969 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3971 * buildbot/process/builder.py:
3972 * buildbot/process/interlock.py:
3973 * buildbot/process/process_twisted.py:
3974 * buildbot/process/step.py:
3975 BuildProcess -> Build, as it looks like that's what happened
3976 * buildbot/process/base.py:
3977 * buildbot/process/factory.py:
3980 2005-04-17 Brian Warner <warner@lothar.com>
3982 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3983 update compile command to accomodate the Twisted split.. now
3984 instead of './setup.py build_ext -i', you do './setup.py all
3985 build_ext -i', to run build_ext over all sub-projects.
3986 (FullTwistedBuildFactory): same
3987 (TwistedReactorsBuildFactory): same
3989 * buildbot/status/html.py (TextLog.finished): null out self.req
3990 when we're done, otherwise the reference cycle of TextLog to .req
3991 to .notifications to a Deferred to TextLog.stop keeps them from
3992 being collected, and consumes a huge (610MB on pyramid at last
3993 check) amount of memory.
3995 2005-04-11 Brian Warner <warner@lothar.com>
3997 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3998 normalize the VC-repository location.. makes SVN happier with
3999 certain test environments.
4001 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4002 RemoteShellCommand gets its own .env dictionary, so that code in
4003 start() doesn't mutate the original. I think this should fix the
4004 step_twisted.Trial problem where multiple identical components
4005 kept getting added to PYTHONPATH= over and over again.
4007 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4008 adding epydoc-format docstrings to many classes. Thanks to Thomas
4009 Vander Stichele for the patches.
4010 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4011 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4012 * buildbot/slave/bot.py, commands.py, registry.py: same
4014 2005-04-05 Brian Warner <warner@lothar.com>
4016 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4017 preserve timestamps, helps incremental builds of large trees.
4018 Patch from Rene Rivera.
4020 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4021 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4024 2005-04-03 Brian Warner <warner@lothar.com>
4026 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4027 with one dict, apparently exec has some scoping bugs when used
4028 with both global/local dicts. Thanks to Nathaniel Smith for the
4031 2005-04-02 Brian Warner <warner@lothar.com>
4033 * buildbot/process/step_twisted.py (countFailedTests): the new
4034 trial in Twisted-2.0 emits a slightly different status line than
4035 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4036 mistakenly think the test count is unparseable.
4037 (Trial.start): note that for some reason each build causes another
4038 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4039 be fixed but I'm not sure quite where the problem is.
4041 2005-04-01 Brian Warner <warner@lothar.com>
4043 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4044 deferredResult to avoid hangs/warnings under twisted-2.0
4045 (RunMixin.tearDown): same
4046 (RunMixin.shutdownSlave): same
4047 (Disconnect.testIdle1): same
4048 (Disconnect.testBuild2): same: wait one second after the build
4049 finishes for test to really be done.. this should be cleaned up to
4050 avoid wasting that second. Builder.detach uses a callLater(0),
4051 either that should be done in-line (something else needed that
4052 behavior), or it should return a Deferred that fires when the
4053 builder is really offline.
4054 (Disconnect.testBuild3): same
4055 (Disconnect.testDisappear): same
4057 * buildbot/test/test_web.py: rearrange server-setup and teardown
4058 code to remove unclean-reactor warnings from twisted-2.0
4060 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4061 so the tests don't hang under twisted-2.0
4063 2005-03-31 Brian Warner <warner@lothar.com>
4065 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4066 caused a warning each time the master changed our set of builders
4068 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4069 w32, don't unlink the file unless it already exists. Thanks to
4070 Baptiste Lepilleur for the catch.
4071 (BuilderStatus.saveYourself): same
4073 2005-02-01 Brian Warner <warner@lothar.com>
4075 * buildbot/status/html.py (TextLog.getChild): use a /text child
4076 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4077 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4078 logfile as text/plain (no markup, no headers). This replaces the
4079 previous scheme (which used an ?text=1 argument), and gets us back
4080 to a relative link (which works better when the buildbot lives
4081 behind another web server, such as Apache configured as a reverse
4082 proxy). Thanks to Gerald Combs for spotting the problem.
4084 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4087 2004-12-13 Brian Warner <warner@lothar.com>
4089 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4091 * debian/changelog: update for 0.6.2
4092 * NEWS: finalize for 0.6.2
4094 2004-12-11 Brian Warner <warner@lothar.com>
4096 * NEWS: bring it up to date
4098 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4099 detection code. Require some sign of life from the buildmaster
4100 every BotFactory.keepaliveInterval seconds. Provoke this
4101 indication at BotFactory.keepaliveTimeout seconds before the
4102 deadline by sending a keepalive request. We don't actually care if
4103 that request is answered in a timely fashion, what we care about
4104 is that .activity() is called before the deadline. .activity() is
4105 triggered by any PB message from the master (including an ack to
4106 one of the slave's status-update messages). With this new scheme,
4107 large status messages over slow pipes are OK, as long as any given
4108 message can be sent (and thus acked) within .keepaliveTimeout
4109 seconds (which defaults to 30).
4110 (SlaveBuilder.remote_startCommand): record activity
4111 (SlaveBuilder.ackUpdate): same
4112 (SlaveBuilder.ackComplete): same
4113 (BotFactory.gotPerspective): same
4114 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4116 2004-12-09 Brian Warner <warner@lothar.com>
4118 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4121 * buildbot/process/step_twisted.py (Trial._commandComplete):
4122 update self.cmd when we start the 'cat test.log' transfer. Without
4123 this, we cannot interrupt the correct RemoteCommand when we lose
4126 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4127 trying to tell the slave to stop the command if we're already
4128 inactive, or if we no longer have a .remote
4130 * buildbot/process/builder.py (Builder._detached): don't let an
4131 exception in currentBuild.stopBuild() prevent the builder from
4132 being marked offline
4134 2004-12-07 Brian Warner <warner@lothar.com>
4136 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4137 KeyError that happens when you ask for a non-existent Builder, and
4138 translate it into a UsageError.
4140 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4141 losing the slave in the middle of a remote step is handled too
4143 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4144 be a Failure, so be sure to stringify it before using it as the
4145 contents of the 'interrupt' logfile
4146 (RemoteCommand.interrupt): use stringified 'why' in
4147 remote_interruptCommand too, just in case
4149 2004-12-06 Brian Warner <warner@lothar.com>
4151 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4152 instead of 'tla update', which is more efficient in case we've
4153 missed a couple of patches since the last update.
4155 * debian/changelog: update for previous (0.6.1) release. Obviously
4156 this needs to be handled better.
4158 2004-12-05 Brian Warner <warner@lothar.com>
4160 * NEWS: update for stuff since last release
4162 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4163 match the maybeDeferred change in Dispatcher.requestAvatar
4164 * buildbot/changes/pb.py (ChangePerspective.attached): same
4165 * buildbot/status/client.py (StatusClientPerspective.attached): same
4166 * buildbot/process/builder.py (Builder._attached3): same
4167 * buildbot/pbutil.py (NewCredPerspective.attached): same
4169 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4170 the date to the top-most box, if it is not the same as today's
4173 * docs/slave.xhtml: provide a buildslave setup checklist
4175 * docs/source.xhtml (Arch): correct terminology
4177 2004-12-04 Brian Warner <warner@lothar.com>
4179 * buildbot/test/test_slavecommand.py: use sys.executable instead
4180 of hard-coding 'python' for child commands, might help portability
4182 * docs/examples/twisted_master.cfg: update to current usage
4184 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4185 'stop build' command to the IRC bot
4187 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4188 message that broke PBChangeSource
4190 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4191 (SlaveBuilder): make some attributes class-level, remove the old
4192 "update queue" which existed to support resuming a build after the
4193 master connection was lost. Try to reimplement that feature later.
4194 (SlaveBuilder.stopCommand): clear self.command when the
4195 SlaveCommand finishes, so that we don't try to kill a leftover one
4197 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4200 * buildbot/slave/commands.py (SourceBase): set self.command for
4201 all VC commands, so they can be interrupted.
4203 2004-12-03 Brian Warner <warner@lothar.com>
4205 * buildbot/master.py: clean up slave-handling code, to handle
4206 slave-disconnect and multiple-connect better
4207 (BotPerspective): make these long-lasting, exactly one per bot
4208 listed in the config file.
4209 (BotPerspective.attached): if a slave connects while an existing
4210 one appears to still be connected, disconnect the old one first.
4211 (BotPerspective.disconnect): new method to forcibly disconnect a
4212 buildslave. Use some hacks to empty the transmit buffer quickly to
4213 avoid the long (20-min?) TCP timeout that could occur if the old
4214 slave has dropped off the net.
4215 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4216 own their own SlaveStatus objects. Remove .attached/.detached, add
4217 .addSlave/.removeSlave, treat slaves like Builders (config file
4218 parsing sends deltas to the BotMaster). Inform the slave
4219 instances, i.e. the BotPerspective, about addBuilder and
4221 (BotMaster.getPerspective): turns into a single dict lookup
4222 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4223 which gives BotPerspective.attached a chance to disconnect the old
4225 (BuildMaster.loadConfig): add code (disabled) to validate that all
4226 builders use known slaves (listed in c['bots']). The check won't
4227 work with tuple-specified builders, which are deprecated but not
4228 yet invalid, so the check is disabled for now.
4229 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4230 routine, do the add/changed/removed dance with them like we do
4232 (BuildMaster.loadConfig_Sources): move source-config into a
4233 separate routine too
4235 * buildbot/status/builder.py (Status.getSlave): get the
4236 SlaveStatus object from the BotPerspective, not the BotMaster.
4238 * buildbot/test/test_run.py: bunch of new tests for losing the
4239 buildslave at various points in the build, handling a slave that
4240 connects multiple times, and making sure we can interrupt a
4243 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4244 something other than 'Bot' for the Bot object, to make certain
4245 test cases easier to write.
4246 (BuildSlave.waitUntilDisconnected): utility method for testing
4248 2004-11-30 Brian Warner <warner@lothar.com>
4250 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4252 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4253 argument, return a Deferred that always fires with True or False.
4254 I don't use an errback to indicate 'ping failed' so that callers
4255 are free to ignore the deferred without causing spurious errors in
4257 * buildbot/process/builder.py (BuilderControl.ping): implement it
4259 * buildbot/test/test_run.py (Status.testDisappear): test ping
4260 (Status.disappearSlave): fix it
4262 2004-11-30 Brian Warner <warner@lothar.com>
4264 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4265 (IBuilderControl): add .getBuild(num), only works for the current
4266 build, of course, although it might be interesting to offer
4267 something for builds in the .waiting or .interlocked state.
4269 * buildbot/process/base.py (Build): have .stopBuild just do the
4270 interrupt, then let the build die by itself.
4271 (BuildControl): add .stopBuild, and add a point-event named
4272 'interrupt' just after the build so status viewers can tell that
4274 (BuilderControl): add .getBuild
4276 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4277 stops when you kill it, good for testing
4278 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4279 contains the 'reason' text.
4281 * buildbot/status/html.py: Add Stop Build button, if the build can
4282 still be stopped. Send a Redirect (to the top page) one second
4283 later, hopefully long enough for the interrupt to have an effect.
4284 Move make_row() up to top-level to share it between Stop Build and
4287 * buildbot/slave/commands.py: only kill the child process once
4289 * buildbot/test/test_run.py: add testInterrupt
4291 2004-11-29 Brian Warner <warner@lothar.com>
4293 * buildbot/process/base.py: Refactor command interruption. The
4294 Build is now responsible for noticing that the slave has gone
4295 away: Build.lostRemote() interrupts the current step and makes
4296 sure that no further ones will be started.
4298 * buildbot/process/builder.py: When the initial remote_startBuild
4299 message fails, log it: this usually indicates that the slave has
4300 gone away, but we don't really start paying attention until they
4301 fail to respond to the first step's command.
4303 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4304 slave disconnect. Now sports a new interrupt() method. Error
4305 handling was simplified a lot by chaining deferreds, so
4306 remoteFailed/remoteComplete were merged into a single
4307 remoteComplete method (which can now get a Failure object).
4308 Likewise failed/finished were merged into just _finished.
4309 (BuildStep): Add interrupt(why) method, and if why is a
4310 ConnectionLost Failure then the step is failed with some useful
4313 * buildbot/slave/bot.py: stop the current command when the remote
4314 Step reference is lost, and when the slave is shut down.
4315 (Bot): make it a MultiService, so it can have children. Use
4316 stopService to tell when the slave is shutting down.
4317 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4318 remote_interruptCommand (which asks the current SlaveCommand to
4319 stop but allows it to keep emitting status messages), and
4320 stopCommand (which tells it to shut up and die).
4322 * buildbot/slave/commands.py: make commands interruptible
4323 (ShellCommand.kill): factor out os.kill logic
4324 (Command): factor out setup()
4325 (Command.sendStatus): don't send status if .running is false, this
4326 happens when the command has been halted.
4327 (Command.interrupt): new method, used to tell the command to die
4328 (SlaveShellCommand): implement .interrupt
4329 (DummyCommand): implement .interrupt
4330 (SourceBase, etc): factor out setup(), don't continue substeps if
4333 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4334 so they can be called after finishing
4336 * buildbot/test/test_run.py: new tests for disconnect behavior,
4337 refactor slave-shutdown routines, add different kinds of
4340 2004-11-27 Brian Warner <warner@lothar.com>
4342 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4343 method to express ETA time like "2m45s" instead of "165 seconds"
4345 2004-11-24 Brian Warner <warner@lothar.com>
4347 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4348 archive after the test completes, to avoid cluttering the user's
4349 'tla archives' listing with a bogus entry. Arch doesn't happen to
4350 provide any way to override the use of ~/.arch-params/, so there
4351 isn't a convenient way to avoid touching the setup of the user who
4353 (VC_HTTP.testArchHTTP): same
4355 2004-11-23 Brian Warner <warner@lothar.com>
4357 * buildbot/status/html.py (TextLog): split render() up into
4358 render_HEAD and render_GET. Use a Producer when sending log
4359 chunks, to reduce memory requirements and avoid sending huge
4360 non-Banana-able strings over web.distrib connections. Requires
4361 peeking under the covers of IStatusLog.
4362 (TextLog.resumeProducing): fix the "as text" link, handle client
4363 disconnects that occur while we're still sending old chunks.
4365 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4366 use defer.succeed, not the non-existent defer.success
4367 (LogFile.waitUntilFinished): same
4368 (LogFile.subscribe): don't add watchers to a finished logfile
4370 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4373 2004-11-23 Brian Warner <warner@lothar.com>
4375 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4377 2004-11-23 Brian Warner <warner@lothar.com>
4379 * NEWS: update for the 0.6.1 release
4380 * MANIFEST.in: add new files
4382 * README (INSTALLATION): explain how to enable the extra VC tests
4384 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4385 level to, so old pickled builds can be displayed ok
4387 2004-11-22 Brian Warner <warner@lothar.com>
4389 * NEWS: summarize updates since last release
4391 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4392 Yoz Grahame. Closes SF#1050138.
4394 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4397 * buildbot/process/step_twisted.py (Trial): update docs a bit
4399 * docs/factories.xhtml: fix Trial factory docs to match reality.
4402 * buildbot/process/factory.py (Trial.__init__): add args for
4403 randomly= and recurse=, making them available to instantiators
4404 instead of only to subclassers. Closes: SF#1049759.
4406 2004-11-15 Brian Warner <warner@lothar.com>
4408 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4409 try to teach the Quick factory to use multiple versions of python
4411 2004-11-12 Brian Warner <warner@lothar.com>
4413 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4414 safer w32-compatible approach, and only use it on windows
4415 (BuildStatus.saveYourself): same
4417 2004-11-11 Brian Warner <warner@lothar.com>
4419 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4420 it: one string merge per chunk. There are now separate .entries
4421 and .runEntries lists: when enumerating over all chunks, make sure
4423 * buildbot/test/test_status.py (Log): more tests
4425 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4426 chunks together, up to 10kb per chunk. This ought to cut down on
4427 the CPU-burning overhead of large log files. Thanks to Alexander
4428 Staubo for spotting the problem.
4429 * buildbot/test/test_status.py (Log): tests for same
4431 2004-11-10 Brian Warner <warner@lothar.com>
4433 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4434 header to outbound mail
4435 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4437 2004-11-08 Brian Warner <warner@lothar.com>
4439 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4440 can't do os.rename() onto an existing file, so catch the exception
4441 and unlink the target file first. This introduces a slight window
4442 where the existing file could be lost, but the main failure case
4443 (disk full) should still be handled safely.
4444 (BuildStatus.saveYourself): same
4446 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4447 separator character instead of os.sep, because the filenames being
4448 split here are coming from the VC system, which can have a
4449 different pathname convention than the local host. This should
4450 help a buildmaster running on windows that uses a CVS repository
4451 which runs under unix.
4452 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4454 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4455 when there are no test failures to be parsed
4457 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4458 instead of the unix-specific os.system("cp"), thanks to Elliot
4459 Murphy for this and the other buildbot-vs-windows catches.
4460 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4462 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4463 echo the command as it is run
4465 * setup.py: install sample.mk too, not just sample.cfg
4466 (scripts): install contrib/windows/buildbot.bat on windows
4468 2004-11-07 Brian Warner <warner@lothar.com>
4470 * buildbot/process/builder.py (Builder._detached): clear the
4471 self.currentBuild reference, otherwise the next build will be
4472 skipped because we think the Builder is already in use.
4474 * docs/examples/twisted_master.cfg: update to match current usage
4475 on the Twisted buildbot
4477 2004-10-29 Brian Warner <warner@lothar.com>
4479 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4481 2004-10-28 Brian Warner <warner@lothar.com>
4483 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4484 have separate doVCUpdate/doVCFull methods. Catch an update failure
4485 and respond by clobbering the source directory and re-trying. This
4486 will handle local changes (like replacing a file with a directory)
4487 that will cause CVS and SVN updates to fail.
4488 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4490 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4493 2004-10-19 Brian Warner <warner@lothar.com>
4495 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4497 * buildbot/status/html.py (StatusResourceTestResults): display any
4498 TestResults that the Build might have
4499 (StatusResourceTestResult): and the logs for each TestResult
4500 (StatusResourceBuild): add link from the per-build page
4502 2004-10-15 Brian Warner <warner@lothar.com>
4504 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4505 the 'problems' portion of stdout, add TestResults to our build
4506 * buildbot/test/test_twisted.py (Parse.testParse): test it
4508 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4509 to retrieve a dict of accumulated test results
4510 (ITestResult): define what a single test result can do
4511 * buildbot/status/builder.py (TestResult): implement ITestResult
4512 (BuildStatus.getTestResults): retrieve dict of TestResults
4513 (BuildStatus.addTestResult): add TestResults
4514 * buildbot/test/test_status.py (Results.testAddResults): test it
4516 2004-10-14 Brian Warner <warner@lothar.com>
4518 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4519 instead of os.system("rm -rf") for win32 portability
4521 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4522 SignalMixin instead of starting/stopping the reactor, which is
4523 likely to cause problems with other tests
4525 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4526 self.copyComplete() call. Yoz Grahame makes the catch.
4528 * contrib/windows/buildbot.bat: helper script to deal with path
4529 issues. Thanks to Yoz Grahame.
4531 * buildbot/master.py (BuildMaster.startService): don't register a
4532 SIGHUP handler if the signal module has no SIGHUP attribute.
4533 Apparently win32 does this.
4535 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4537 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4538 test if the reactor can't offer UNIX sockets
4540 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4541 error introduced in the last commit. We really need that
4544 2004-10-12 Brian Warner <warner@lothar.com>
4546 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4547 when describing a maildir source. Thanks to Stephen Davis.
4549 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4552 * buildbot/scripts/runner.py (createMaster): install Makefile too
4553 (start): add --no_save to 'start' command
4554 * buildbot/scripts/sample.mk: simple convenience Makefile with
4555 start/stop/reload targets
4557 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4560 2004-09-30 Brian Warner <warner@lothar.com>
4562 * setup.py: Releasing buildbot-0.6.0
4564 2004-09-30 Brian Warner <warner@lothar.com>
4566 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4567 test_trial.py from the source tarball until support is complete.
4569 * NEWS: update for 0.6.0 release
4570 * buildbot/__init__.py (version): same
4573 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4574 'source' command to tell users where to get the Buildbot source
4576 * docs/examples/*.cfg: update to modern standards
4578 * NEWS: update for release
4580 * buildbot/scripts/runner.py (createMaster): remove the
4581 -shutdown.tap stuff now that it isn't necessary
4583 (start): launch buildbot.tap, not buildbot-shutdown.tap
4586 * buildbot/status/mail.py (Domain): shorten class name
4587 (MailNotifier): if lookup= is a string, pass it to Domain()
4588 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4589 (Mail.testBuild2): test the string-to-Domain shortcut
4590 (Mail.testMail): fix test
4593 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4596 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4597 more attributes on load
4598 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4599 to accomodate the whole waterfall page at once, and the thrashing
4600 results in a lot of unnecessary loads
4601 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4602 (BuilderStatus.saveYourself): same
4603 (BuilderStatus.eventGenerator): stop generating on the first missing
4604 build. We assume that saved builds are deleted oldest-first.
4605 (BuildStepStatus.__getstate__): .progress might not exist
4607 * buildbot/changes/changes.py (ChangeMaster): make it
4608 serializable, in $masterdir/changes.pck
4609 (ChangeMaster.stopService): save on shutdown
4610 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4611 * buildbot/test/test_config.py: load Changes before config file
4614 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4615 "Oh my god, you killed the command" header on a separate line
4617 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4618 skip over corrupted build pickles
4619 (BuilderStatus.getFullBuildByNumber): same
4620 (BuilderStatus.eventGenerator): skip over unavailable builds
4621 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4622 do an atomic rename. This prevents a corrupted pickle when some
4623 internal serialization error occurs.
4624 (BuilderStatus.saveYourself): same
4626 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4627 the timeout for shell commands, it got lost somehow
4629 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4630 run out of build steps, return the rest of the builder events
4632 * buildbot/interfaces.py (IBuilderControl.ping): add method
4634 * buildbot/process/builder.py (BuilderControl.ping): move
4635 slave-ping to BuilderControl, and fix the failure case in the
4636 process (Event.finish() is the verb, Event.finished is the noun).
4638 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4639 through the BuilderControl instead of the BuilderStatus
4640 (EventBox): add adapter for builder.Event, allowing builder events to
4641 be displayed in the waterfall display
4643 * buildbot/master.py (BotMaster.stopService): add a 'master
4644 shutdown' event to the builder's log
4645 (BuildMaster.startService): and a 'master started' on startup
4647 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4648 builder events into the BuildStep event stream
4649 (Status.builderAdded): add a 'builder created' event
4652 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4653 command to announce the completion of a running build
4654 (IrcStatusBot.command_FORCE): announce when the build finishes
4656 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4657 don't evict unfinished builds from the cache: they must stay in
4658 the full-cache until their logfiles have stopped changing. Make
4659 sure the eviction loop terminates if an unfinished build was hit.
4660 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4661 This lets exceptions be dumped in an email status message. Really
4662 we need LogFiles which contain both text and HTML, instead of two
4664 (BuildStatus.__getstate__): handle self.finished=False
4665 (Status.builderAdded): if the pickle is corrupted, abandon the
4666 history and create a new BuilderStatus object.
4668 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4669 self.progress attribute, helped one test which doesn't fully set
4670 up the Build object.
4672 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4673 IStatusLog methods into an Interface that is implemented by "stub"
4674 logs, for which all the actual text chunks are on disk (in the
4675 pickled Build instance). To show the log contents, you must first
4676 adapt the stub log to a full IStatusLog object.
4678 * buildbot/status/builder.py (LogFileStub): create separate stub
4679 log objects, which can be upgraded to a real one if necessary.
4680 (LogFile): make them persistable, and let them stubify themselves
4682 (BuildStepStatus): same
4684 (BuildStatus.saveYourself): save the whole build out to disk
4685 (BuilderStatus): make it persistable
4686 (BuilderStatus.saveYourself): save the builder to disk
4687 (BuilderStatus.addFullBuildToCache): implement two caches which
4688 hold Build objects: a small one which holds full Builds, and a
4689 larger one which holds "stubbed" Builds (ones with their LogFiles
4690 turned into LogFileStubs). This reduces memory usage by the
4691 buildmaster by not keeping more than a few (default is 2) whole
4692 build logs in RAM all the time.
4693 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4695 (BuilderStatus.eventGenerator): rewrite since .builds went away
4696 (BuilderStatus.buildStarted): remove the .builds array. Add the
4697 build to the "full" cache when it starts.
4698 (BuilderStatus._buildFinished): save the build to disk when it
4700 (Status): give it a basedir (same as the BuildMaster's basedir)
4701 where the builder pickles can be saved
4702 (Status.builderAdded): create the BuilderStatus ourselves, by
4703 loading a pickle from disk (or creating a new instance if there
4704 was none on disk). Return the BuilderStatus so the master can glue
4705 it into the new Builder object.
4707 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4708 all BuilderStatuses to save themselves out to disk. This is in
4709 lieu of saving anything important in the main Application pickle
4710 (the -shutdown.tap file).
4711 (BuildMaster.__init__): give Status() a basedir for its files
4712 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4713 to get the BuilderStatus, then give it to the Builder (instead of
4714 doing it the other way around). It's ok if the status announces
4715 the new Builder before it's really ready, as the outside world can
4716 only see the BuilderStatus object anyway (and it is ready before
4717 builderAdded returns). Use the builder's "builddir" (which
4718 normally specifies where the slave will run the builder) as the
4719 master's basedir (for saving serialized builds).
4721 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4722 coerce the logfile to IStatusLog before trying to get the text
4723 chunks out of it. This will pull the full (non-stubified) Build in
4724 from disk if necessary.
4725 (TextLog): fix the adapter registration
4727 * buildbot/test/test_control.py (Force.setUp): create the basedir
4728 * buildbot/test/test_web.py: same
4729 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4730 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4731 * buildbot/test/test_run.py (Run.testMaster): same
4732 (Status.setUp): same
4734 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4736 * buildbot/status/html.py (Waterfall.__init__): store actual
4737 allowForce flag passed in rather than using True for everyone;
4738 make sure setting it to False doesn't cause a NameError
4740 (StatusResourceBuilder.__init__) add the builder name to the page
4742 (StatusResourceBuilder.body) move HTML generation for a name/value
4743 row into a helper method (StatusResourceBuilder.make_row); only
4744 generate the "Force Build" form if allowForce was True and the
4745 slave is connected. Use class attributes in the generated HTML to
4746 spread a little CSS-joy.
4748 2004-09-28 Brian Warner <warner@lothar.com>
4750 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4751 warning-scanner to not ignore things like
4752 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4754 * buildbot/status/html.py (StatusResource.control): add some
4755 class-level values for .control in an attempt to make upgrading
4758 * buildbot/util.py (ComparableMixin): survive missing attributes,
4759 such as when a class is modified and we're comparing old instances
4762 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4763 failure handling, remove a redundant try/except block. Don't
4764 return the full traceback to the IRC channel.
4765 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4766 error messages. Get ETA properly.
4768 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4769 the reason, since (at least) IRC message will have <> in them.
4770 (StatusResourceBuilder.__init__): take an IBuilderControl
4771 (StatusResourceBuilder.force): use the IBuilderControl we get in
4772 the constructor instead of trying to make our own. Catch the
4773 new exceptions and ignore them for now (until we make an
4774 intermediate web page where we could show the error message)
4775 (StatusResource): create with an IControl, use it to give an
4776 IBuilderControl to all children
4777 (Waterfall): take an allowForce= option, pass an IControl object
4778 to StatusResource if it is True
4780 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4782 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4783 catch new exceptions and return string forms
4785 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4786 * buildbot/process/builder.py (Builder.forceBuild): raise them
4787 * buildbot/test/test_control.py (Force.testNoSlave): new test
4788 (Force.testBuilderInUse): same
4791 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4793 * buildbot/test/test_run.py: use IControl
4794 * buildbot/test/test_vc.py: same
4796 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4797 to use IControl. Still offline.
4798 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4800 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4801 who=None so periodic builds don't send out status mail
4802 (Builder.forceBuild): include reason in the log message
4803 (BuilderControl.forceBuild): rename 'name' to 'who'
4805 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4806 'who' parameter, but make it None by default so builds forced by
4807 slave admins don't cause status mail to be sent to anybody
4808 (BotMaster.forceBuild): same. this method is deprecated.
4809 (DebugPerspective.perspective_forceBuild): same, use IControl.
4810 (DebugPerspective.perspective_fakeChange): use IControl..
4811 (Dispatcher.requestAvatar): .. so don't set .changemaster
4813 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4814 parameter to avoid confusion with the name of the builder
4817 * buildbot/status/mail.py: refine comment about needing 2.3
4819 * buildbot/status/html.py: move all imports to the top
4821 * buildbot/test/test_control.py: test new interfaces
4822 * buildbot/test/test_run.py (Status): handle new interfaces
4823 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4825 * buildbot/process/base.py (BuildControl): implement IBuildControl
4826 and its lonely getStatus() method
4828 * buildbot/process/builder.py (BuilderControl): implement
4829 IBuilderControl, obtained by adapting the Builder instance
4830 (Builder.startBuild): return a BuilderControl instead of a
4831 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4832 accomplish the same thing.
4834 * buildbot/master.py: move all import statements to the top
4835 (Control): implement IControl, obtained by adapting the
4836 BuildMaster instance.
4838 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4839 IBuildControl. These are used to force builds. Eventually they
4840 will provide ways to reconfigure the Builders, pause or abandon a
4841 Build, and perhaps control the BuildMaster itself.
4843 2004-09-26 Brian Warner <warner@lothar.com>
4845 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4846 ends up comparing us against something without a .__class__
4848 2004-09-24 Brian Warner <warner@lothar.com>
4850 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4853 * Makefile: add 'deb-snapshot' target, to create a timestamped
4856 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4858 2004-09-23 Brian Warner <warner@lothar.com>
4860 * buildbot/__init__.py (version): move version string here
4861 * setup.py: get version string from buildbot.version
4862 * buildbot/status/html.py (WaterfallStatusResource.body): add
4863 buildbot version to the page footer
4864 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4867 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4868 slaves, let the second know where the first one is coming from
4869 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4870 see our exceptions. It would be nice if there were a way to just
4871 send them the exception type and value, not the full traceback.
4874 * buildbot/status/mail.py (MailNotifier): add a new argument
4875 sendToInterestedUsers=, which can be set to False to disable the
4876 usual send-to-blamelist behavior.
4877 (top): handle python-2.2 which has no email.MIMEMultipart
4878 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4879 (MailNotifier.disownServiceParent): unsubscribe on removal
4881 * buildbot/test/test_status.py (Mail.testBuild2): test it
4884 * buildbot/status/progress.py (Expectations.wavg): tolerate
4885 current=None, which happens when steps start failing badly
4886 * buildbot/test/test_status.py (Progress.testWavg): test for it
4888 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4889 doesn't understand args['revision'], emit a warning instead of
4890 bailing completely. Updating to -rHEAD is probably close enough.
4892 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4894 * buildbot/test/test_status.py: at least import bb.status.client
4895 even if we don't have any test coverage for it yet
4897 * contrib/svn_buildbot.py: don't require python2.3
4898 (main): wait, do require it (for sets.py), but explain how to
4899 make it work under python2.2
4901 2004-09-23 Brian Warner <warner@lothar.com>
4903 * contrib/svn_buildbot.py: include the revision number in the Change
4905 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4906 using util.now() because FreshCVS is a realtime service
4908 * buildbot/status/event.py: delete dead code
4909 * buildbot/process/step.py: don't import dead Event class
4910 * buildbot/process/step_twisted.py: same
4911 * buildbot/status/builder.py: same
4912 * buildbot/status/client.py: same
4914 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4916 * buildbot/changes/changes.py (Change): set .when from an __init__
4917 argument (which defaults to now()), rather than having
4918 ChangeMaster.addChange set it later.
4919 (ChangeMaster.addChange): same
4921 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4922 (parseSyncmail): same. Just use util.now() for now.
4923 (parseBonsaiMail): parse the timestamp field for when=
4925 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4926 instead of setting .when after the fact
4930 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4931 results when the target project uses retrial. Still under
4933 * buildbot/test/test_trial.py: same
4935 2004-09-21 Brian Warner <warner@lothar.com>
4937 * buildbot/status/mail.py (MailNotifier.__init__): include
4938 success/warnings/failure in the Subject line
4939 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4940 use step.logname for the addLogs=True attachment filenames
4941 * buildbot/test/test_status.py (Mail): test Subject lines
4942 (Mail.testLogs): test attachment filenames
4944 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4945 accept a 'who' argument from the debug tool
4946 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4947 * contrib/debug.glade: add text box to set 'who'
4949 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4950 .getBuilderName with .getBuilder().getName(), more flexible
4951 (IStatusLog.getName): logs have short names, but you can prefix
4952 them with log.getStep().getName() to make them more useful
4953 * buildbot/status/builder.py: same
4954 * buildbot/status/client.py: same
4955 * buildbot/status/html.py: same
4956 * buildbot/test/test_run.py (Status.testSlave): same
4957 * buildbot/process/step.py: tweak logfile names
4959 * buildbot/status/mail.py (MailNotifier): add lookup, change
4960 argument to extraRecipients. The notifier is now aimed at sending
4961 mail to the people involved in a particular build, with additional
4962 constant recipients as a secondary function.
4964 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4965 including slow-lookup and failing-lookup. Make sure the blamelist
4966 members are included.
4968 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4969 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4970 (IBuildStatus.getInterestedUsers): new method
4971 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4972 * buildbot/status/client.py (remote_getResponsibleUsers): same
4973 * buildbot/status/html.py (StatusResourceBuild.body): same
4974 * buildbot/test/test_run.py (Status.testSlave): same
4976 2004-09-20 Brian Warner <warner@lothar.com>
4978 * docs/users.xhtml: update concepts
4980 * Makefile: add a convenience makefile, for things like 'make
4981 test'. It is not included in the source tarball.
4983 2004-09-16 Brian Warner <warner@lothar.com>
4985 * NEWS: mention /usr/bin/buildbot, debian/*
4987 * debian/*: add preliminary debian packaging. Many thanks to
4988 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4989 it considerably since it left their hands, I am responsible for
4990 all breakage that's resulted.
4992 * bin/buildbot: create a top-level 'buildbot' command, to be
4993 installed in /usr/bin/buildbot . For now it's just a simple
4994 frontend to mktap/twistd/kill, but eventually it will be the entry
4995 point to the 'try' command and also a status client. It is also
4996 intended to support the upcoming debian-packaging init.d scripts.
4997 * buildbot/scripts/runner.py: the real work is done here
4998 * buildbot/scripts/__init__.py: need this too
4999 * buildbot/scripts/sample.cfg: this is installed in new
5000 buildmaster directories
5001 * setup.py: install new stuff
5003 2004-09-15 Brian Warner <warner@lothar.com>
5005 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5006 'file:' schema (the version shipped with OS-X was built without the
5008 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5009 updates the log-timestamp, to make sure it isn't still running after
5012 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5013 values to the config file.
5014 * docs/examples/hello.cfg: add examples
5015 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5016 * buildbot/status/builder.py (Status.getProjectURL): implement them
5017 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5018 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5019 * buildbot/status/html.py (WaterfallStatusResource): display them
5022 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5023 certain error cases don't suffer a secondary exception.
5024 (top): Skip tests if the corresponding VC tool is not installed.
5026 * buildbot/process/factory.py (Trial): introduce separate
5027 'buildpython' and 'trialpython' lists, since trialpython=[] is
5028 what you want to invoke /usr/bin/python, whereas ./setup.py is
5029 less likely to be executable. Add env= parameter to pass options
5030 to test cases (which is how I usually write tests, I don't know if
5031 anyone else does it this way).
5033 * buildbot/process/step_twisted.py (Trial): handle python=None.
5034 Require 'testpath' be a string, not a list. Fix tests= typo.
5035 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5037 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5038 way to deal with the possibility of removing the disconnect notify
5040 (CVS): add a 'login' parameter to give a password to 'cvs login',
5041 commonly used with pserver methods (where pw="" or pw="guest")
5043 * buildbot/slave/commands.py (SourceBase): move common args
5044 extraction and setup() to __init__, so everything is ready by the
5045 time setup() is called
5046 (CVS.start): call 'cvs login' if a password was supplied
5047 (ShellCommand): special-case PYTHONPATH: prepend the master's
5048 value to any existing slave-local value.
5050 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5051 don't have a remote, mark the builder as Offline. This whole
5052 function should probably go away and be replaced by individual
5054 (Builder.buildFinished): return the results to the build-finished
5055 deferred callback, helps with testing
5057 2004-09-14 Brian Warner <warner@lothar.com>
5059 * buildbot/test/test_vc.py: put all the repositories needed to run
5060 the complete tests into a single small (1.3MB) tarball, so I can
5061 make that tarball available on the buildbot web site. Test HTTP
5062 access (for Arch and Darcs) by spawning a temporary web server
5063 while the test runs.
5065 * docs/users.xhtml: new document, describe Buildbot's limited
5066 understanding of different human users
5068 * buildbot/test/test_vc.py: rearrange test cases a bit
5070 * buildbot/process/step_twisted.py (Trial): handle testpath=
5071 * buildbot/process/factory.py (Trial): update to use step.Trial
5073 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5075 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5076 the overall build text (which gives you 'failed 2 tests' rather
5078 (BuildStepStatus.text2): default to [], not None
5080 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5083 2004-09-12 Brian Warner <warner@lothar.com>
5085 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5086 log the whole exception if it's just an AttributeError (old slave)
5088 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5089 so (e.g.) sub-commands can be run in the right directory.
5090 (ShellCommand.start): accept an optional errorMessage= argument
5091 to make life easier for SVN.start
5092 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5094 (ShellCommand.start): move ['dir'] compatibility hack..
5095 (RemoteShellCommand.start): .. to here so everyone can use it
5097 * buildbot/process/step_twisted.py (Trial): use .workdir
5099 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5100 text displayed when debuild fails completely
5101 (Trial): snarf _trial_temp/test.log from the slave and display it
5103 2004-09-11 Brian Warner <warner@lothar.com>
5105 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5107 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5108 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5110 * buildbot/process/step.py (ShellCommand): call .createSummary
5111 before .evaluateCommand instead of the other way around. This
5112 makes it slightly easier to count warnings and then use that to
5113 set results=WARNINGS
5114 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5116 * buildbot/process/base.py (Build.buildFinished): update status
5117 before doing progress. It's embarrassing for the build to be stuck
5118 in the "building" state when an exceptions occurs elsewhere..
5120 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5121 python2.2 doesn't have 'sum'
5123 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5124 to prevent clients from accidentally sorting it
5126 * buildbot/master.py (Manhole): add username/password
5127 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5128 c['manholePort'], deprecate old usage
5129 * docs/config.xhtml: document c['manhole']
5130 * docs/examples/hello.cfg: show example of using a Manhole
5133 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5134 pretend the slave is up to date
5136 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5137 the module, overlaps with 'log', the local variable
5139 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5141 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5142 new method to let Steps find out the version of their
5143 corresponding SlaveCommand.
5144 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5145 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5146 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5148 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5149 (Arch.startVC): same
5150 (P4Sync.startVC): same
5152 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5153 Deferred so we can catch errors in remote_startCommand
5154 (RemoteShellCommand.start): same
5156 * docs/examples/twisted_master.cfg: update sample config file
5158 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5159 after connectionMade() is called, not before. Close stdin at that
5162 * buildbot/process/process_twisted.py: update to use Trial, clean
5163 up argument passing (move to argv arrays instead of string
5166 * buildbot/process/step_twisted.py (Trial): new step to replace
5167 RunUnitTests, usable by any trial-using project (not just
5168 Twisted). Arguments have changed, see the docstring for details.
5170 * buildbot/process/base.py (Build.startBuild): this now returns a
5171 Deferred. Exceptions that occur during setupBuild are now
5172 caught better and lead to fewer build_status weirdnesses, like
5173 finishing a build that was never started.
5174 (Build.buildFinished): fire the Deferred instead of calling
5175 builder.buildFinished directly. The callback argument is this
5176 Build, everything else can be extracted from it, including the
5177 new build.results attribute.
5178 * buildbot/process/builder.py (Builder.startBuild): same
5179 (Builder.buildFinished): same, extract results from build
5181 * buildbot/process/step.py (ShellCommands): remove dead code
5183 2004-09-08 Brian Warner <warner@lothar.com>
5185 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5186 doesn't try to use the leftover patched workdir
5187 (SourceStamp): test source-stamp computation for CVS and SVN
5189 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5190 patched workdir ('touch .buildbot-patched') so we don't try to
5192 (SourceBase.start): add ['revision'] for all Source steps
5193 (CVS): change args: use ['branch'] for -r, remove ['files']
5194 (CVS.buildVC): fix revision/branch stuff
5195 (SVN): add revision stuff
5197 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5198 kwargs (except 'workdir') to avoid silent spelling errors
5199 (ShellCommand.__init__): same
5200 (Source): new base class for CVS/SVN/etc. Factor out everything
5201 common, add revision computation (perform the checkout with a -D
5202 DATE or -r REVISION that gets exactly the sources described by the
5203 last Change), overridable with step.alwaysUseLatest. Add patch
5204 handling (build.getSourceStamp can trigger the use of a base
5205 revision and a patch).
5206 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5207 * docs/steps.xhtml: update docs
5208 * docs/source.xhtml: mention .checkoutDelay
5209 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5211 * buildbot/process/base.py (Build.setSourceStamp): add a
5212 .sourceStamp attribute to each Build. If set, this indicates that
5213 the build should be done with something other than the most
5214 recent source tree. This will be used to implement "try" builds.
5215 (Build.allChanges): new support method
5216 (Build.lastChangeTime): remove, functionality moved to Source steps
5217 (Build.setupBuild): copy the Step args before adding ['workdir'],
5218 to avoid modifying the BuildFactory (and thus triggering spurious
5222 * buildbot/status/html.py: rename s/commits/changes/
5223 (StatusResourceChanges): same
5224 (CommitBox.getBox): same, update URL
5225 (WaterfallStatusResource): same
5226 (StatusResource.getChild): same
5228 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5229 * contrib/debug.glade: add optional 'revision' to the fakeChange
5231 * buildbot/changes/changes.py (html_tmpl): display .revision
5232 (ChangeMaster.addChange): note .revision in log
5233 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5234 accept a ['revision'] attribute
5236 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5238 * buildbot/master.py (BotMaster.getPerspective): update the
5239 .connected flag in SlaveStatus when it connects
5240 (BotMaster.detach): and when it disconnects
5241 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5242 (BuildMaster.loadConfig_Builders): walk old list correctly
5244 * buildbot/test/test_config.py: fix prefix= usage
5246 2004-09-06 Brian Warner <warner@lothar.com>
5250 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5251 poll a P4 depot looking for recent changes. Thanks to Dave
5252 Peticolas for the contribution. Probably needs some testing after
5255 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5256 requires manual client setup for each buildslave. Rather
5257 experimental. Thanks again to Dave Peticolas.
5258 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5260 * buildbot/changes/changes.py (Change): add a .revision attribute,
5261 which will eventually be used to generate source-stamp values.
5263 * buildbot/process/step.py (RemoteCommand.start): use
5264 notifyOnDisconnect to notice when we lose the slave, then treat it
5265 like an exception. This allows LogFiles to be closed and the build
5266 to be wrapped up normally. Be sure to remove the disconnect
5267 notification when the step completes so we don't accumulate a
5268 bazillion such notifications which will fire weeks later (when the
5269 slave finally disconnects normally). Fixes SF#915807, thanks to
5270 spiv (Andrew Bennetts) for the report.
5271 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5272 really isn't Logged- specific
5273 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5274 header, since it's almost always going to be appended to an
5276 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5277 update test to handle use of notifyOnDisconnect
5279 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5280 don't clear .ETA and .currentBuild when going offline, let the
5281 current build clean up after itself
5283 * buildbot/process/builder.py (Builder.detached): wait a moment
5284 before doing things like stopping the current build, because the
5285 current step will probably notice the disconnect and cleanup the
5287 * buildbot/test/test_run.py (Status.tearDown): update test to
5288 handle asynchronous build-detachment
5290 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5292 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5293 hush a debug message
5295 2004-09-05 Brian Warner <warner@lothar.com>
5297 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5298 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5299 kernels do this: the fcntl module has the F_NOTIFY constant, but
5300 the kernel itself doesn't support the operation. Thanks to Olly
5301 Betts for spotting the problem.
5303 * buildbot/process/step.py (Darcs): new source-checkout command
5304 (Arch): new source-checkout command
5305 (todo_P4): fix constructor syntax, still just a placeholder
5306 * buildbot/test/test_vc.py (VC.testDarcs): test it
5307 (VC.testDarcsHTTP): same, via localhost HTTP
5309 (VC.testArchHTTP): same
5310 * NEWS: mention new features
5312 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5313 which tells the step to stash stdout text locally (in .stdout).
5314 Slave-side Commands can use this to make decisions based upon the
5315 output of the the ShellCommand (not just the exit code).
5316 (Darcs): New source-checkout command
5317 (Arch): New source-checkout command, uses .keepStdout in one place
5318 where it needs to discover the archive's default name.
5320 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5321 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5322 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5324 * buildbot/process/step.py (ShellCommand.describe): add an
5325 alternate .descriptionDone attribute which provides descriptive
5326 text when the step is complete. .description can be ["compiling"],
5327 for use while the step is running, then .descriptionDone can be
5328 ["compile"], used alone when the step succeeds or with "failed" when
5329 it does not. Updated other steps to use the new text.
5330 * buildbot/process/step_twisted.py: same
5331 * buildbot/test/test_run.py: update tests to match
5333 2004-08-30 Brian Warner <warner@lothar.com>
5335 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5336 (CVS.__init__): send 'patch' argument to slave
5337 (CVS.start): don't create the LoggedRemoteCommand until start(),
5338 so we can catch a .patch added after __init__
5339 (SVN.__init__): add 'patch' to SVN too
5342 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5343 argument, to let commands push data into the process' stdin pipe.
5344 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5345 is in use, since closing a PTY doesn't really affect the process
5346 in the right way (in particular, I couldn't run /usr/bin/patch
5348 (SourceBase.doPatch): handle 'patch' argument
5350 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5353 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5354 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5356 * buildbot/master.py (BotPerspective.got_commands): get command
5357 versions from slave, give to each builder
5358 * buildbot/process/builder.py (Builder.attached): stash slave
5359 command versions in .remoteCommands
5361 * docs/steps.xhtml: bring docs in-line with reality
5363 * buildbot/process/step.py (CVS.__init__): more brutal
5364 compatibility code removal
5365 (SVN.__init__): same
5367 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5368 (SlaveShellCommand.start): require ['workdir'] argument, remove
5369 the ['dir'] fallback (compatibility will come later)
5370 (SourceBase): update docs
5371 (SourceBase.start): remove ['directory'] fallback
5374 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5375 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5376 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5378 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5379 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5380 code.. I will figure out 0.5.0-compatibility hooks later)
5382 2004-08-30 Brian Warner <warner@lothar.com>
5384 * buildbot/process/process_twisted.py: rewrite in terms of new
5385 BuildFactory base class. It got significantly shorter. Yay
5388 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5389 work with the new "self.build isn't nailed down until we call
5390 step.start()" scheme: specifically, __init__ is called before the
5391 build has decided on which Changes are going in, so we don't scan
5392 build.allFiles() for .xhtml files until start()
5393 (HLint.commandComplete): use getText(), not getStdout()
5394 (RunUnitTests.start): same: don't use .build until start()
5395 (RunUnitTests.describe): oops, don't report (None) when using
5397 (RunUnitTests.commandComplete): use getText()
5398 (RunUnitTests.createSummary): same
5399 (BuildDebs.commandComplete): same
5401 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5402 set args['command'] until start(), since our BuildStep is allowed
5403 to change their mind up until that point
5404 (TreeSize.commandComplete): use getText(), not getStdout()
5406 * docs/examples/twisted_master.cfg: update to current standards
5408 * docs/factories.xhtml: update
5409 * buildbot/process/factory.py: implement all the common factories
5410 described in the docs. The Trial factory doesn't work yet, and
5411 I've probably broken all the process_twisted.py factories in the
5412 process. There are compatibility classes left in for things like
5413 the old BasicBuildFactory, but subclasses of them are unlikely to
5415 * docs/examples/glib_master.cfg: use new BuildFactories
5416 * docs/examples/hello.cfg: same
5418 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5419 explicit 'workdir' args
5421 * buildbot/process/base.py (BuildFactory): move factories to ..
5422 * buildbot/process/factory.py (BuildFactory): .. here
5423 * buildbot/process/process_twisted.py: handle move
5424 * buildbot/test/test_config.py: same
5425 * buildbot/test/test_run.py: same
5426 * buildbot/test/test_steps.py: same
5427 * buildbot/test/test_vc.py: same
5428 * docs/factories.xhtml: same
5430 * NEWS: mention config changes that require updating master.cfg
5432 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5433 argument to all steps that weren't given one already, pointing at
5434 the "build/" directory.
5436 * docs/examples/hello.cfg: remove explicit 'workdir' args
5438 * docs/factories.xhtml: document standard BuildFactory clases,
5439 including a bunch which are have not yet been written
5441 2004-08-29 Brian Warner <warner@lothar.com>
5443 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5444 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5445 buildbot.status.builder so they aren't quite so internal
5446 * buildbot/process/base.py, buildbot/process/builder.py: same
5447 * buildbot/process/maxq.py, buildbot/process/step.py: same
5448 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5449 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5450 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5452 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5453 to handle new getLogs()-returns-list behavior
5454 (StatusResourceBuildStep.getChild): same
5455 (StepBox.getBox): same
5456 (WaterfallStatusResource.phase0): same
5458 * docs/source.xhtml: document how Buildbot uses version-control
5459 systems (output side: how we get source trees)
5460 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5461 systems (input side: how we learn about Changes)
5463 * buildbot/master.py (Manhole): use ComparableMixin
5464 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5465 * buildbot/changes/mail.py (MaildirSource): same
5466 * buildbot/status/client.py (PBListener): same
5467 * buildbot/status/html.py (Waterfall): same
5468 * buildbot/status/words.py (IRC): same
5470 * NEWS: start describing new features
5472 * buildbot/status/mail.py (MailNotifier): finish implementation.
5473 The message body is still a bit sparse.
5474 * buildbot/test/test_status.py (Mail): test it
5476 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5477 and __hash__ methods I wind up adding everywhere. Specifically
5478 intended to support the buildbot config-file update scheme where
5479 we compare, say, the old list of IStatusTargets against the new
5480 one and don't touch something which shows up on both lists.
5481 * buildbot/test/test_util.py (Compare): test case for it
5483 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5484 return a list instead of a dict
5485 (IBuildStepStatus.getLogs): same. The idea is that steps create
5486 logs with vaguely unique names (although their uniqueness is not
5487 guaranteed). Thus a compilation step should create its sole
5488 logfile with the name 'compile', and contribute it to the
5489 BuildStatus. If a step has two logfiles, try to create them with
5490 different names (like 'test.log' and 'test.summary'), and only
5491 contribute the important ones to the overall BuildStatus.
5492 * buildbot/status/builder.py (Event.getLogs): same
5493 (BuildStepStatus): fix default .text and .results
5494 (BuildStepStatus.addLog): switch to list-like .getLogs()
5495 (BuildStepStatus.stepFinished): same
5496 (BuildStatus.text): fix default .text
5497 (BuildStatus.getLogs): temporary hack to return all logs (from all
5498 child BuildStepStatus objects). Needs to be fixed to only report
5499 the significant ones (as contributed by the steps themselves)
5500 * buildbot/test/test_run.py: handle list-like .getLogs()
5501 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5503 2004-08-28 Brian Warner <warner@lothar.com>
5505 * buildbot/process/builder.py (Builder.attached): serialize the
5506 attachment process, so the attach-watcher isn't called until the
5507 slave is really available. Add detached watchers too, which makes
5510 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5512 * buildbot/test/test_swap.py: remove dead code
5514 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5515 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5516 sort of as if the command being run exited with a -1. There may
5517 still be some holes in this scheme.
5518 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5519 -r option appears before the module list
5520 * buildbot/process/step.py (CVS): add 'revision' argument
5522 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5523 when sending updates or stepComplete messages to the master, since
5524 we don't currently care whether they arrive or not. When we revamp
5525 the master/slave protocol to really resume interrupted builds,
5526 this will need revisiting.
5527 (lostRemote): remove spurious print
5529 * buildbot/master.py (BotPerspective.attached): serialize the
5530 new-builder interrogation process, to make testing easier
5531 (BotMaster.waitUntilBuilderDetached): convenience function
5533 * buildbot/status/builder.py (BuilderStatus): prune old builds
5534 (BuildStatus.pruneSteps): .. and steps
5535 (BuildStepStatus.pruneLogs): .. and logs
5536 (BuilderStatus.getBuild): handle missing builds
5537 * buildbot/status/html.py (StatusResourceBuild.body): display build
5538 status in the per-build page
5539 (BuildBox.getBox): color finished builds in the per-build box
5541 2004-08-27 Brian Warner <warner@lothar.com>
5543 * buildbot/status/mail.py (MailNotifier): new notification class,
5546 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5547 variants of a common base class which handles all the mode= logic
5549 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5551 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5553 2004-08-26 Brian Warner <warner@lothar.com>
5555 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5558 * buildbot/test/test_run.py: update to new Logfile interface, new
5559 buildbot.slave modules
5560 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5562 * MANIFEST.in: new sample config file
5563 * docs/examples/hello.cfg: same
5565 * buildbot/process/step_twisted.py: remove dead import
5567 * buildbot/process/step.py (RemoteCommand.run): catch errors
5569 (RemoteCommand.remote_update): ignore updates that arrive after
5571 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5572 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5573 the responsibilities of the subclass's methods
5574 (BuildStep.failed): catch errors during failure processing
5575 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5576 (CVS): move to a mode= argument (described in docstring), rather
5577 than the ungainly clobber=/export=/copydir= combination.
5578 (SVN): add mode= functionality to SVN too
5579 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5581 * buildbot/process/base.py (Build.startNextStep): catch errors
5582 during s.startStep()
5584 * buildbot/clients/base.py: update to new PB client interface.
5585 gtkPanes is still broken
5587 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5588 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5589 * setup.py: add buildbot.slave module
5590 * buildbot/bb_tap.py: handle move
5591 * buildbot/slave/registry.py: place to register commands, w/versions
5592 * buildbot/slave/bot.py: major simplifications
5593 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5594 instead of a fixed table. Eventually this will make the slave more
5595 extensible. Use 'start' method on the command, not .startCommand.
5596 Fix unsafeTracebacks handling (I think).
5597 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5598 helper class with a .start method that returns a Deferred.
5599 SlaveShellCommand is the form reached by the buildmaster. Commands
5600 which use multiple ShellCommands can just chain them as Deferreds,
5601 with some helper methods in Command (_abandonOnFailure and
5602 _checkAbandoned) to bail on rc!=0.
5603 (CVSCommand): prefer new mode= argument
5604 (SVNFetch): add mode= argument
5606 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5607 put a useful reason string on the build
5609 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5610 core functionality into an IStatusLog object
5611 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5612 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5613 (StatusResourceBuild.body): use proper accessor methods
5614 * buildbot/status/client.py (RemoteLog): PB-access goes here
5615 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5616 which delivers log contents too
5617 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5618 * buildbot/status/event.py: remove old Logfile completely
5620 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5621 subscription interface for IStatusLog subscriptions just like all
5622 other the status subscriptions
5623 (IStatusReceiver.logChunk): method called on subscribers
5625 2004-08-24 Brian Warner <warner@lothar.com>
5627 * buildbot/process/builder.py (Builder._pong): oops, ping response
5628 includes a result (the implicit None returned by remote_print).
5629 Accept it so the _pong method handles the response correctly.
5631 2004-08-06 Brian Warner <warner@lothar.com>
5633 * buildbot/test/test_config.py: update IRC, PBListener tests
5635 * buildbot/status/client.py (StatusClientPerspective): total
5636 rewrite to match new IStatus interfaces. New subscription scheme.
5637 There are still a few optimizations to make (sending down extra
5638 information with event messages so the client doesn't have to do a
5639 round trip). The logfile-retrieval code is probably still broken.
5640 Moved the PB service into its own port, you can no longer share a
5641 TCP socket between a PBListener and, say, the slaveport (this
5642 should be fixed eventually).
5643 * buildbot/clients/base.py (Client): revamp to match. still needs
5644 a lot of work, but basic event reporting works fine. gtkPanes is
5647 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5648 instance talks to a single irc server. Threw out all the old
5649 multi-server handling code. Still need to add back in
5650 builder-control (i.e. "force build")
5652 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5653 more random text to the as-yet-unreachable per-step page
5655 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5656 rename to stepETAUpdate
5657 (BuildStatus.subscribe): add build-wide ETA updates
5658 (BuilderStatus.getState): remove more cruft
5659 (BuilderStatus.getCurrentBuild): remove more cruft
5660 (BuilderStatus.buildStarted): really handle tuple-subscription
5661 * buildbot/test/test_run.py (Status.testSlave): handle the
5662 stepETAUpdate rename
5664 * buildbot/master.py (BuildMaster): don't add a default
5665 StatusClientService. Don't add a default IrcStatusFactory. Both
5666 are now added through c['status'] in the config file. c['irc'] is
5667 accepted for backwards compatibility, the only quirk is you cannot
5668 use c['irc'] to specify IRC servers on ports other than 6667.
5670 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5671 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5672 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5673 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5676 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5677 the buildmaster to re-read its config file
5680 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5681 find out the port our server is running on
5682 (WebTest.test_webPathname_port): same
5684 * buildbot/test/test_config.py (testWebPortnum): test it
5685 (testWebPathname): ditto
5687 * docs/config.xhtml: document new c['status'] configuration option
5689 * buildbot/status/html.py (Waterfall): new top-level class which
5690 can be added to c['status']. This creates the Site as well as the
5691 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5692 reachable as .parent, for everything.
5694 * buildbot/master.py (Manhole): make it a normal service Child
5695 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5696 webPathname. It will eventually replace c['irc'] and the implicit
5697 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5698 in as (deprecated) backward compatibility hooks for now.
5701 * buildbot/process/builder.py (Builder.buildFinished): don't
5702 inform out builder_status about a finished build, as it finds out
5703 through its child BuildStatus object
5705 * buildbot/status/html.py: extensive revamp. Use adapters to make
5706 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5707 have both starting and finishing times and adjust the waterfall
5708 display accordingly, using spacers if necessary. Use SlaveStatus
5709 to get buildslave info.
5710 (StatusResourceBuildStep): new just-one-step resource, used to get
5711 logfiles. No actual href to it yet.
5713 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5714 the time being, until I get the file-naming scheme right
5716 * buildbot/status/builder.py (Event): clean started/finished names
5717 (BuildStatus.isFinished): .finished is not None is the right test
5718 (BuildStatus.buildStarted): track started/finished times ourselves
5719 (BuilderStatus.getSlave): provide access to SlaveStatus object
5720 (BuilderStatus.getLastFinishedBuild): all builds are now in
5721 .builds, even the currently-running one. Accomodate this change.
5722 (BuilderStatus.eventGenerator): new per-builder event generator.
5723 Returns BuildStepStatus and BuildStatus objects, since they can
5724 both be adapted as necessary.
5725 (BuilderStatus.addEvent): clean up started/finished attributes
5726 (BuilderStatus.startBuild,finishBuild): remove dead code
5727 (SlaveStatus): new object to provide ISlaveStatus
5729 * buildbot/process/step.py (ShellCommand.getColor): actually
5730 return the color instead of setting it ourselves
5731 (CVS.__init__): pull .timeout and .workdir options out of
5732 **kwargs, since BuildStep will ignore them. Without this neither
5733 will be sent to the slave correctly.
5734 (SVN.__init__): same
5736 * buildbot/process/builder.py (Builder): move flags to class-level
5738 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5739 SlaveStatus handle that
5741 * buildbot/process/base.py (Build.firstEvent): remove dead code
5742 (Build.stopBuild): bugfix
5744 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5746 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5747 (ChangeMaster.eventGenerator): yield Changes, since there are now
5748 Adapters to turn them into HTML boxes
5750 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5751 (BotPerspective.attached): feed a SlaveStatus object
5752 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5753 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5755 * buildbot/interfaces.py: API additions
5756 (ISlaveStatus): place to get slave status
5758 2004-08-04 Brian Warner <warner@lothar.com>
5760 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5761 the delay finishes, so the step is marked as SUCCESS
5763 * buildbot/test/test_run.py (Status.testSlave): cover more of
5764 IBuildStatus and IBuildStepStatus
5766 * buildbot/status/progress.py (StepProgress): move some flags to
5767 class-level attributes
5768 (StepProgress.remaining): if there are no other progress metrics
5769 to go by, fall back to elapsed time
5770 (StepProgress.setExpectations): take a dict of metrics instead of
5772 (BuildProgress.setExpectationsFrom): pull expectations from the
5773 Expectations, instead of having it push them to the BuildProgress
5774 (Expectations): move some flags to class-level attributes
5775 (Expectations.__init__): copy per-step times from the
5777 (Expectations.expectedBuildTime): new method for per-build ETA
5779 * buildbot/status/event.py (Logfile): move some flags to
5780 class-level attributes
5781 (Logfile.logProgressTo): better method name, let step set the
5782 progress axis name (instead of always being "output")
5784 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5785 times directly, rather than depending upon the (possibly missing)
5786 .progress object. Use 'None' to indicate "not started/finished
5788 (BuildStepStatus.getExpectations): oops, return the full list of
5790 (BuilderStatus._buildFinished): append finished builds to .builds
5792 * buildbot/process/step.py (BuildStep): add separate .useProgress
5793 flag, since empty .progressMetrics[] still implies that time is a
5795 (CVS): set up the cmd in __init__, instead of waiting for start()
5797 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5798 calculation, this will eventually turn into a proper sourceStamp
5799 (Build.setupBuild): tell the Progress to load from the Expectations,
5800 instead of having the Expectations stuff things into the Progress
5801 (Build.buildException): add a build-level errback to make sure the
5802 build's Deferred fires even in case of exceptions
5804 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5806 * buildbot/process/builder.py (Builder.forceBuild): convey the
5807 reason instead of creating a fake Change
5809 * docs/examples/twisted_master.cfg: update to match reality
5811 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5812 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5813 fix or remove broken/breaking tests
5815 * buildbot/status/event.py (Logfile.__len__): remove evil method
5817 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5818 missing .build, for test convenience
5820 * buildbot/process/step_twisted.py: import fixes
5822 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5824 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5825 .statusbag reference
5827 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5828 connection at shutdown, and stop it from reconnecting
5830 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5831 chase down remote-execution bugs
5833 * buildbot/process/step.py: more fixes, remove
5834 BuildStep.setStatus()
5835 * buildbot/status/builder.py: move setStatus() functionality into
5837 * buildbot/status/event.py: minor fixes
5839 2004-08-03 Brian Warner <warner@lothar.com>
5841 * buildbot/process/base.py, buildbot/process/builder.py
5842 * buildbot/process/step.py, buildbot/status/builder.py
5843 * buildbot/status/event.py, buildbot/test/test_run.py:
5844 fix status delivery, get a basic test case working
5845 * buildbot/master.py: finish implementing basic status delivery,
5846 temporarily disable HTML/IRC/PB status sources
5848 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5850 * buildbot/status/progress.py (BuildProgress): remove dead code
5852 * buildbot/interfaces.py
5853 * buildbot/process/base.py, buildbot/process/builder.py
5854 * buildbot/process/step.py, buildbot/process/step_twisted.py
5855 * buildbot/status/builder.py: Complete overhaul of the all
5856 status-delivery code, unifying all types of status clients (HTML,
5857 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5858 look like. This commit is a checkpointing of the work-in-progress:
5859 the input side is mostly done (Builders/Builds sending status
5860 to the BuilderStatus/BuildStatus objects), but the output side has
5861 not yet been started (HTML resources querying BuilderStatus
5862 objects). Things are probably very broken right now and may remain
5863 so for several weeks, I apologize for the disruption.
5865 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5866 HTML as the log's contents. Currently used for exception tracebacks.
5867 * buildbot/status/progress.py: minor spelling changes
5869 2004-08-02 Brian Warner <warner@lothar.com>
5871 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5872 in mozilla. Also added stylesheets copied from Twisted's docs.
5873 Remember that these files are meant to be run through Lore first.
5874 Thanks to Philipp Frauenfelder for the fixes.
5875 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5876 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5877 * docs/template.tpl: added a Lore template
5879 2004-07-29 Brian Warner <warner@lothar.com>
5881 * buildbot/interfaces.py: revamp status delivery. This is the
5882 preview: these are the Interfaces that will be provided by new
5883 Builder code, and to which the current HTML/IRC/PB status
5884 displayers will be adapted.
5886 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5887 on the SlaveBuilder, not the Bot.
5888 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5890 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5891 set .usePTY on the FakeSlaveBuilder
5893 2004-07-25 Brian Warner <warner@lothar.com>
5895 * buildbot/changes/freshcvs.py: add some debug log messages
5896 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5897 disabled 'setFilter' syntax
5898 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5899 don't end with a slash
5901 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5903 * setup.py: bump to 0.5.0+ while between releases
5905 2004-07-23 Brian Warner <warner@lothar.com>
5907 * setup.py (version): Releasing buildbot-0.5.0
5909 2004-07-23 Brian Warner <warner@lothar.com>
5911 * README: update for 0.5.0 release
5913 * NEWS: update for 0.5.0 release
5915 2004-07-22 Brian Warner <warner@lothar.com>
5917 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5918 mktap-time configuration flag (--usepty=1, --usepty=0)
5919 * buildbot/bot.py: same
5921 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5922 an 'info' directory being unwanted
5924 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5925 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5926 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5927 and earlier), use a FreshCVSSourceOldcred instead.
5928 (test): simple test routine: connect to server, print changes
5930 * buildbot/changes/changes.py (Change.getTime): make it possible
5931 to print un-timestamped changes
5933 * buildbot/master.py (makeApp): delete ancient dead code
5934 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5935 * buildbot/test/test_config.py (testFindConfigFile): test it
5937 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5938 instead of win32 one
5941 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5942 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5945 * buildbot/process/base.py (Builder.__init__): change constructor
5946 to accept a dictionary of config data, rather than discrete
5947 name/slave/builddir/factory arguments
5949 * docs/examples/twisted_master.cfg: update to new syntax
5950 * docs/examples/glib_master.cfg: same
5951 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5952 rough tests of the new syntax
5955 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5956 to be an int, which means "run a web.distrib sub-server on a TCP
5957 port". This lets you publish the buildbot status page to a remote
5958 twisted.web server (using distrib.ResourceSubscription). Also
5959 rename the local attributes used to hold these web things so
5960 they're more in touch with reality.
5961 * buildbot/test/test_web.py: test webPortnum and webPathname
5962 * docs/config.xhtml: document this new use of webPathname
5964 * docs/config.xhtml: new document, slightly ahead of reality
5966 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5967 'prefix' handling: treat it as a simple string to check with
5968 .startswith, instead of treating it as a directory. This allows
5969 sub-directories to be used. If you use prefix=, you should give it
5970 a string that starts just below the CVSROOT and ends with a slash.
5971 This prefix will be stripped from all filenames, and filenames
5972 which do not start with it will be ignored.
5974 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5976 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5977 and --exclude (inverse of --include). SVN post-commit hooks
5978 now have total control over which changes get sent to buildbot and which
5981 2004-07-10 Brian Warner <warner@lothar.com>
5983 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5984 test case to match new API
5986 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5987 which crashed HTML display when self.entries=[] (needed to
5988 distinguish between [], which means "no entries yet", and None,
5989 which means "the entries have been swapped out to disk, go fetch
5992 2004-07-04 Brian Warner <warner@lothar.com>
5994 * buildbot/process/step_twisted.py (countFailedTests): Count
5995 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5996 10kb from the end because any import errors are wedged there and
5997 they would make us think the test log was unparseable.
5998 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6000 2004-06-26 Brian Warner <warner@lothar.com>
6002 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6003 delete-*.pyc command into an actual BuildStep, so we can label it
6005 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6006 (FullTwistedBuildFactory): same
6008 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6010 * contrib/fakechange.py: Add an errback when sending the fake
6011 change, so we know it didn't work.
6013 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6015 * buildbot/process/step_twisted.py: Delete *.pyc files before
6016 calling trial, so it doesn't catch any old .pyc files whose .py
6017 files have been moved or deleted.
6019 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6020 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6021 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6022 instead of ["twisted.test"], so that the end result is "trial -R
6025 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6026 regular expression to match filenames that should be ignored when
6027 changed. Also add a --revision parameter that specifies the
6028 revision to examine, which is useful for debugging.
6030 2004-06-25 Brian Warner <warner@lothar.com>
6032 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6033 summary of warnings (like DeprecationWarnings), next to the
6036 2004-05-13 Brian Warner <warner@lothar.com>
6038 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6039 we now have a w32 build slave courtesy of Mike Taylor.
6041 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6042 so broken. Fixed a race condition that tripped up interlocked
6043 builds and caused the status to be stuck at "Interlocked" forever.
6044 The twisted buildbot's one interlocked build just so happened to
6045 never hit this case until recently (the feeding builds both pass
6046 before the interlocked build is attempted.. usually it has to wait
6048 (Builder._pong_failed): fix method signature
6050 * setup.py: bump to 0.4.3+ while between releases
6052 2004-04-30 Brian Warner <warner@lothar.com>
6054 * setup.py (version): Releasing buildbot-0.4.3
6056 2004-04-30 Brian Warner <warner@lothar.com>
6058 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6060 * README: update for 0.4.3 release
6062 * NEWS: update for 0.4.3 release
6064 * buildbot/master.py (BuildMaster.__getstate__): make sure
6065 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6067 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6068 .trial as a class attribute, for upgrade from 0.4.2
6070 * buildbot/changes/changes.py (Change.links): add .links for
6073 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6074 .textWatchers and .htmlWatchers at save time, since they are both
6075 volatile, should allow smooth 0.4.2 upgrade
6077 * buildbot/process/step.py (CVS.finishStatus): catch failed
6078 CVS/SVN commands so we can make the status box red
6080 2004-04-29 Brian Warner <warner@lothar.com>
6082 * buildbot/changes/freshcvs.py
6083 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6084 code to do setFilter(), which tells the freshcvs daemon to not
6085 send us stuff that we're not interested in. I will uncomment it
6086 when a new version of CVSToys is available in which setFilter()
6087 actually works, and I get a chance to test it better.
6089 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6091 * buildbot/master.py (Dispatcher): use a registration scheme
6092 instead of hardwired service names
6093 (BuildMaster): keep track of the Dispatcher to support
6096 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6097 PBChangeSource class instead of having it be an undocumented
6098 internal feature of the ChangeMaster. Split out the code into a
6100 * buildbot/changes/pb.py (PBChangeSource): same
6101 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6103 * docs/{factories|sources|steps}.xhtml: document some pieces
6105 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6106 using FCMaildirSource
6107 (f23osx): update OS-X builder to use python2.3, since the slave
6108 was updated to Panther (10.3.3)
6110 2004-03-21 Brian Warner <warner@lothar.com>
6112 * buildbot/process/process_twisted.py: factor out doCheckout, change
6113 to use SVN instead of CVS
6115 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6116 an SVN subclass easier
6117 (BasicSVN): subclass which uses Subversion instead of CVS
6119 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6121 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6123 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6125 2004-02-25 Brian Warner <warner@lothar.com>
6127 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6128 is now either a list (which is passed to spawnProcess directly) or
6129 a string (which gets passed to /bin/sh -c). This removes the useSH
6130 flag and the ArgslistCommand class. Also send status header at the
6131 start and end of each command, instead of having the master-side
6133 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6134 -r'. Update to use list-based arguments.
6135 (SVNFetch): use list-based arguments, use ['dir'] argument to
6137 * buildbot/test/test_steps.py (Commands): match changes
6139 * buildbot/process/step.py (InternalShellCommand.words): handle
6141 (SVN): inherit from CVS, cleanup
6143 * buildbot/status/event.py (Logfile.content): render in HTML, with
6144 stderr in red and headers (like the name of the command we're
6145 about to run) in blue. Add link to a second URL (url + "?text=1")
6146 to get just stdout/stderr in text/plain without markup. There is
6147 still a problem with .entries=None causing a crash, it seems to occur
6148 when the logfile is read before it is finished.
6150 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6151 timeout to the keepalives, and use it to explicitly do a
6152 loseConnection instead of waiting for TCP to notice the loss. This
6153 ought to clear up the silent-lossage problem.
6154 (unsafeTracebacks): pass exception tracebacks back to the master,
6155 makes it much easier to debug problems
6157 2004-02-23 Brian Warner <warner@lothar.com>
6159 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6160 the whole command to /bin/sh instead of execve [Johan Dahlin]
6161 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6162 '-r HEAD' [Johan Dahlin]
6163 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6165 * buildbot/changes/changes.py (Change): add links= argument, add
6166 asHTML method [Johan Dahlin]. Modified to make a bit more
6167 XHTMLish. Still not sure how to best use links= .
6169 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6170 Change.asHTML to display the change, not asText
6172 * buildbot/status/html.py (StatusResourceBuilder): web button to
6175 * buildbot/test/test_run.py: test to actually start a buildmaster
6178 * MANIFEST.in: bring back accidentally-dropped test helper files
6180 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6181 that require cvstoys if it is not installed
6183 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6184 values of "bin/trial" [Dave Peticolas]
6185 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6186 tests passed" when we didn't happen to run any tests
6188 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6189 flunkOnFailure [Johan Dahlin]
6191 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6192 multiple instances of the same Step class by suffixing "_2", etc,
6193 to the name until it is unique. This name needs to be unique
6194 because it is used as a key in the dictionary that tracks build
6196 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6199 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6201 2004-01-14 Brian Warner <warner@lothar.com>
6203 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6204 kicked from a channel, log it
6206 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6207 something over whatever IRC channels the buildmaster is currently
6208 connected to. Added to try and track down a problem in which the
6209 master thinks it is still connected but the IRCd doesn't see it. I
6210 used a styles.Versioned this time, so hopefully users won't have
6211 to rebuild their .tap files this time.
6212 * contrib/debug.glade: add a "Poke IRC" button
6213 * contrib/debugclient.py: same
6215 * setup.py: bump to 0.4.2+ while between releases
6217 2004-01-08 Brian Warner <warner@lothar.com>
6219 * setup.py (version): Releasing buildbot-0.4.2
6221 2004-01-08 Brian Warner <warner@lothar.com>
6223 * NEWS: update for 0.4.2 release
6225 * README: document how to run the tests, now that they all pass
6227 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6229 * buildbot/process/step.py (CVS): add a global_options= argument,
6230 which lets you set CVS global options for the command like "-r"
6231 for read-only checkout, or "-R" to avoid writing in the
6233 * buildbot/slavecommand.py (CVSCommand): same
6235 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6236 testing easier (it is turned off when testing, to avoid the
6239 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6240 to make it easier to test: break generateStepID() out to a
6241 separate function, only update statusbag if it exists.
6242 (ShellCommands): create useful text for dict-based commands too.
6244 * test/*, buildbot/test/*: move unit tests under the buildbot/
6246 * setup.py (packages): install buildbot.test too
6248 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6249 * buildbot/test/test_steps.py: fix it, tests pass now
6251 2004-01-06 Brian Warner <warner@lothar.com>
6253 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6254 freshcvs mail uses a slightly different syntax for new
6255 directories. Update parser to handle either.
6256 * test/test_mailparse.py (Test1.testMsg9): test for same
6258 2003-12-21 Brian Warner <warner@lothar.com>
6260 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6261 'warnOnWarnings' so that lintian errors mark the build orange
6263 2003-12-17 Brian Warner <warner@lothar.com>
6265 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6266 messages emitted by Bonsai, contributed by Stephen Davis.
6268 * test/*: moved all tests to use trial instead of unittest. Some
6269 still fail (test_steps, test_slavecommand, and test_process).
6271 * setup.py (version): bump to 0.4.1+ while between releases
6273 2003-12-09 Brian Warner <warner@lothar.com>
6275 * setup.py (version): Releasing buildbot-0.4.1
6277 2003-12-09 Brian Warner <warner@lothar.com>
6279 * NEWS: update for 0.4.1 release
6281 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6282 freebsd builder code a little bit
6284 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6285 don't try to compare attributes of different classes
6286 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6287 (MaildirSource.messageReceived): fix Change delivery
6289 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6290 into the config file's namespace before loading it, like the
6291 documentation claims it does
6292 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6293 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6294 daemon comes back online
6296 2003-12-08 Brian Warner <warner@lothar.com>
6298 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6299 so the example will work with online=0 as well
6301 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6302 fix the __implements__ line
6304 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6305 class a twisted.application.service.Service, use startService to
6308 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6309 directory fd instead of simple open(). I'm sure this used to work,
6310 but the current version of python refuses to open directories with
6313 2003-12-05 Brian Warner <warner@lothar.com>
6315 * setup.py (version): bump to 0.4.0+ while between releases
6317 2003-12-05 Brian Warner <warner@lothar.com>
6319 * setup.py (version): Releasing buildbot-0.4.0
6321 2003-12-05 Brian Warner <warner@lothar.com>
6323 * docs/examples/glib_master.cfg: replace old sample scripts with
6324 new-style config files
6325 * MANIFEST.in: include .cfg files in distribution tarball
6327 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6328 implement a dummy method to avoid the exception that occurs when
6329 freshcvs sends this to us.
6331 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6332 removed the method, as it broke reconnection. Apparently
6333 stopFactory is called each time the connection attempt fails. Must
6335 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6336 attribute before serialization, since without stopFactory the
6337 reconnect timer may still be active and they aren't serializable.
6339 * test/test_mailparse.py (ParseTest): test with 'self' argument
6341 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6342 argument, as these "functions" are invoked like methods from class
6343 attributes and therefore always get an instance as the first
6346 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6347 message: thanks to Stephen Davis for the catch
6349 2003-12-04 Brian Warner <warner@lothar.com>
6351 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6352 twisted's standard ReconnectingClientFactory. Handles both oldcred
6353 and newcred connections. Also has a bug-workaround for
6354 ReconnectingClientFactory serializing its connector when it
6357 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6358 pbutil. Replace makeApp stuff with proper newcred/mktap
6359 makeService(). Don't serialize Ephemerals on shutdown.
6361 * buildbot/changes/changes.py (ChangeMaster): make it a
6362 MultiService and add the sources as children, to get startService
6363 and stopService for free. This also gets rid of the .running flag.
6365 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6366 new pbutil, turn into a TCPClient at the same time (to get
6367 startService for free). Two variants exist: FreshCVSSourceOldcred
6368 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6369 yet, but when it does, we'll be ready).
6370 (FreshCVSSource.notify): handle paths which are empty after the
6371 prefix is stripped. This only happens when the top-level (prefix)
6372 directory is added, at the very beginning of a Repository's life.
6374 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6375 Now the only reconnecting code is in the factory where it belongs.
6376 (Builder.unsubscribe): unregister the disconnect callback when we
6377 delete the builder on command from the master (i.e. when the
6378 buildmaster is reconfigured and that builder goes away). This
6379 fixes a multiple-delete exception when the status client is shut
6381 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6384 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6385 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6387 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6389 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6390 a list of globs (ugh). The testdir will be searched for files
6391 named *.tests and run the tests in the order specified in each of
6392 those files. This allows for "dependancies" between tests to be
6395 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6396 argument to pass to run_maxq.py, instead of a glob.
6398 2003-10-17 Brian Warner <warner@lothar.com>
6400 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6401 files that live in the sandbox
6403 2003-10-15 Brian Warner <warner@lothar.com>
6405 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6406 spelling error in "docs" count-warnings output
6407 (HLint.start): stupid thinko meant .xhtml files were ignored
6409 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6410 tests now that cReactor is banished to the sandbox
6412 2003-10-10 Brian Warner <warner@lothar.com>
6414 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6415 scheme: now .xhtml are sources and .html are generated
6417 2003-10-08 Brian Warner <warner@lothar.com>
6419 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6420 we were ignoring the 'randomly' parameter.
6422 2003-10-01 Brian Warner <warner@lothar.com>
6424 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6425 posix, to kill sub-children of aborted slavecommands.
6427 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6428 Clean up initialization: lastBuildStatus remains None until the
6429 first build has been completed.
6431 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6432 None as a lastBuildStatus
6433 * buildbot/clients/gtkPanes.py: same
6435 * buildbot/status/client.py (StatusClientService): keep
6436 BuilderStatus objects in self.statusbags . These objects now live
6437 here in the StatusClientService and are referenced by the Builder
6438 object, rather than the other way around.
6439 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6440 * buildbot/process/base.py (Builder): same
6441 * test/test_config.py (ConfigTest.testBuilders): same
6443 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6444 an existing builder, leave the statusbag alone. This will preserve the
6447 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6448 hook. This will probably go away in favor of a class in upcoming
6451 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6452 serviceName from newcred FreshCVSNotifiee setup
6454 2003-09-29 Brian Warner <warner@lothar.com>
6456 * buildbot/process/process_twisted.py: switch to new reactor
6458 * docs/examples/twisted_master.cfg: same
6460 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6462 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6463 botmaster reference instead of the oldapp service lookup
6465 * buildbot/master.py (BuildMaster.__init__): give the
6466 StatusClientService a reference to the botmaster to make it easier to
6469 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6471 * buildbot/status/html.py (Box.td): escape hreffy things so you
6472 can have spaces in things like builder names
6473 (StatusResourceBuilder.body)
6474 (WaterfallStatusResource.body)
6475 (WaterfallStatusResource.body0): same
6477 2003-09-25 Brian Warner <warner@lothar.com>
6479 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6480 rearrange the builder list when adding or removing builders: keep
6481 them in the order the user requested.
6482 * test/test_config.py (ConfigTest.testBuilders): verify it
6484 * contrib/debug.glade: give the debug window a name
6486 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6487 now wait on multiple interlocks. Fix code relating to that.
6488 (Builder.checkInterlocks): same
6489 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6491 * buildbot/master.py (BuildMaster.loadConfig): move from
6492 deprecated pb.BrokerFactory to new pb.PBServerFactory
6493 * test/test_config.py (ConfigTest.testWebPathname): same
6495 * docs/examples/twisted_master.cfg: fix interlock declaration
6497 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6498 Interlocks to their Builders into interlock.py .
6499 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6501 * test/test_config.py (ConfigTest.testInterlocks): validate
6504 * buildbot/process/base.py (Builder.__init__): better comments
6505 * buildbot/process/interlock.py (Interlock.__repr__): same
6506 (Interlock.deactivate): add .active flag, move the code that
6507 attaches/detaches builders into the Interlock
6509 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6511 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6512 tests using the new run_maxq.py script, and reporting failures by
6515 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6516 tests, reporting their success or failure in a buildbot-friendly
6519 2003-09-24 Brian Warner <warner@lothar.com>
6521 * docs/examples/twisted_master.cfg: example of a new-style config
6522 file. This lives in the buildmaster base directory as
6525 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6526 button to make the master re-read its config file
6528 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6529 buildmaster configuration from a file. This file can be re-read
6530 later, and the buildmaster will update itself to match the new
6531 desired configuration. Also use new Twisted Application class.
6532 * test/Makefile, test/test_config.py: unit tests for same
6534 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6535 FreshCVSSources comparable, to support reload.
6536 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6538 * buildbot/process/base.py (Builder): make them comparable, make
6539 Interlocks easier to attach, to support reload. Handle
6540 re-attachment of remote slaves.
6541 * buildbot/process/interlock.py (Interlock): same
6543 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6544 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6545 buildmaster taps are now constructed with mktap.
6546 * buildbot/status/client.py (StatusClientService): same
6548 * buildbot/status/words.py: move to new Services, add support to
6549 connect to multiple networks, add reload support, allow nickname
6550 to be configured on a per-network basis
6552 2003-09-20 Brian Warner <warner@lothar.com>
6554 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6555 the freebsd builder, now that the machine has been upgraded and no
6556 longer has python2.2
6558 * setup.py (version): bump to 0.3.5+ while between releases
6560 2003-09-19 Brian Warner <warner@lothar.com>
6562 * setup.py (version): Releasing buildbot-0.3.5
6564 2003-09-19 Brian Warner <warner@lothar.com>
6566 * NEWS: add post-0.3.4 notes
6568 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6570 * MANIFEST.in: add contrib/*
6572 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6573 use a remote root now: cvs.twistedmatrix.com
6575 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6577 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6578 compatibility with old servers
6579 (FreshCVSSource.start): and provide a way to use it
6580 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6582 * docs/examples/twisted_master.py (twisted_app): update to new
6584 (twisted_app): listen on new ~buildbot socket
6585 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6587 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6588 to reduce cvs bandwidth (update instead of full checkout)
6590 2003-09-11 Brian Warner <warner@lothar.com>
6592 * contrib/fakechange.py: demo how to connect to the changemaster
6593 port. You can use this technique to submit changes to the
6594 buildmaster from source control systems that offer a hook to run a
6595 script when changes are committed.
6597 * contrib/debugclient.py: tool to connect to the debug port. You
6598 can use it to force builds, submit fake changes, and wiggle the
6601 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6602 'Dispatcher' realm to handle all the different kinds of
6603 connections and Perspectives: buildslaves, the changemaster port,
6604 the debug port, and the status client port. NewCredPerspectives
6605 now have .attached/.detached methods called with the remote 'mind'
6606 reference, much like old perspectives did. All the pb.Services
6607 turned into ordinary app.ApplicationServices .
6608 (DebugService): went away, DebugPerspectives are now created
6609 directly by the Dispatcher.
6610 (makeApp): changed interface a little bit
6612 * buildbot/changes/changes.py: newcred
6613 * buildbot/status/client.py: newcred
6615 * buildbot/clients/base.py: newcred client side changes
6616 * buildbot/bot.py: ditto
6618 * docs/examples/glib_master.py: handle new makeApp() interface
6619 * docs/examples/twisted_master.py: ditto
6621 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6622 base newcred Perspectives on. This should go away once Twisted
6623 itself provides something sensible.
6626 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6628 * contrib/svn_buildbot.py: A program that you can call from your
6629 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6630 when a change in an SVN repository has happened. See the top of
6631 the file for some minimal usage info.
6633 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6635 * buildbot/slavecommand.py (ArglistCommand): Add new
6636 ArglistCommand that takes an argument list rather than a string as
6637 a parameter. Using a st.split() for argv is very bad.
6639 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6640 update to a particular revision rather than always checking out
6641 (still not very smart about it, there may be cases where the
6642 checkout becomes inconsistent).
6644 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6646 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6647 SVN fetch support. It can checkout (not update!) a specified
6648 revision from a specified repository to a specified directory.
6650 * buildbot/status/progress.py (Expectations.update): Fix an
6651 obvious bug (apparently created by the change described in the
6652 previous ChangeLog message) by moving a check to *after* the
6653 variable it checks is defined.
6656 2003-09-08 Brian Warner <warner@lothar.com>
6658 * buildbot/status/progress.py (Expectations.update): hack to catch
6659 an exception TTimo sees: sometimes the update() method seems to
6660 get called before the step has actually finished, so the .stopTime
6661 is not set, so no totalTime() is available and we average None
6662 with the previous value. Catch this and just don't update the
6663 metrics, and emit a log message.
6665 2003-08-24 Brian Warner <warner@lothar.com>
6667 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6668 parameter to set copydir='original' in CVS commands.
6670 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6672 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6673 which tells the command to maintain a separate original-source CVS
6674 workspace. For each build, this workspace will be updated, then
6675 the tree copied into a new workdir. This reduces CVS bandwidth
6676 (from a full checkout to a mere update) while doubling the local
6677 disk usage (to keep two copies of the tree).
6679 2003-08-21 Brian Warner <warner@lothar.com>
6681 * buildbot/status/event.py (Logfile.addEntry): if the master web
6682 server dies while we're serving a page, request.write raises
6683 pb.DeadReferenceError . Catch this and treat it like a
6684 notifyFinish event by dropping the request.
6686 2003-08-18 Brian Warner <warner@lothar.com>
6688 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6689 (instead of blowing up) if a force-build command is given without
6692 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6693 don't blow up if there aren't yet any Changes in the list
6695 2003-08-02 Brian Warner <warner@lothar.com>
6697 * buildbot/bot.py (updateApplication): don't set the .tap name,
6698 since we shouldn't assume we own the whole .tap file
6700 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6701 'mktap buildbot' (without a subcommand) better
6703 2003-07-29 Brian Warner <warner@lothar.com>
6705 * buildbot/status/words.py
6706 (IrcStatusFactory.clientConnectionLost): when we lose the
6707 connection to the IRC server, schedule a reconnection attempt.
6709 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6710 use shutil.rmtree instead of forking off an "rm -rf" command.
6711 rmtree may take a while and will block until it finishes, so we
6712 use "rm -rf" if available.
6714 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6715 freebsd buildslave badly
6717 * setup.py (version): bump to 0.3.4+ while between releases
6719 2003-07-28 Brian Warner <warner@lothar.com>
6721 * setup.py (version): Releasing buildbot-0.3.4
6723 2003-07-28 Brian Warner <warner@lothar.com>
6725 * NEWS: update in preparation for release
6727 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6728 process.signalProcess instead of os.kill, to improve w32
6731 * docs/examples/twisted_master.py (twisted_app): turn off
6732 win32eventreactor: the tests hang the buildslave badly
6734 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6735 failed builds, since usually the failures are consistent
6737 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6738 add compileOpts/compileOpts2 to reactors build
6740 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6741 (twisted_app): use both default and win32eventreactor on w32 build.
6742 Use both default and kqreactor on freebsd build.
6744 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6745 add compileOpts2, which is put after the build_ext argument. w32
6746 needs "-c mingw32" here.
6748 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6749 touch .acqpath, it goes away in recent Twisted releases
6751 * docs/examples/twisted_master.py (twisted_app): use "python" for
6752 the w32 buildslave, not "python2.2"
6754 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6755 the directory exists.. should hush an exception under w32
6757 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6758 ProcessTerminated -provided values for signal and exitCode rather
6759 than parsing the unix status code directly. This should remove one
6760 more roadblock for a w32-hosted buildslave.
6762 * test/test_mailparse.py: add test cases for Syncmail parser
6764 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6765 temporary compatibility import. Note! Start importing
6766 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6768 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6770 2003-07-27 Brian Warner <warner@lothar.com>
6772 * NEWS: started adding new features
6774 * buildbot/changes/mail.py: start work on Syncmail parser, move
6775 mail sources into their own file
6777 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6778 as implementing IChangeSource
6779 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6781 * buildbot/interfaces.py: define the IChangeSource interface
6783 2003-07-26 Brian Warner <warner@lothar.com>
6785 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6787 2003-06-25 Brian Warner <warner@lothar.com>
6789 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6792 2003-06-17 Brian Warner <warner@lothar.com>
6794 * buildbot/status/words.py: clean up method usage to avoid error
6795 in silly IRC command
6796 (IrcStatusBot.emit_status): round off seconds display
6798 * buildbot/process/base.py (Build): delete the timer when saving
6799 to the .tap file, and restore it (if it should still be running)
6800 upon restore. This should fix the "next build in -34 seconds"
6801 messages that result when the master is restarted while builds are
6802 sitting in the .waiting slot. If the time for the build has
6803 already passed, start it very soon (in 1 second).
6805 * buildbot/status/words.py: more silly commands
6807 * README (REQUIREMENTS): add URLs to all required software
6809 * buildbot/status/words.py ('last'): mention results of, and time
6812 2003-05-28 Brian Warner <warner@lothar.com>
6814 * buildbot/status/words.py: add 'last' command
6815 (IrcStatusBot.emit_status): add current-small text to 'status' output
6817 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6818 (twisted_app): remove spaces from OS-X builder name
6820 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6821 * buildbot/status/words.py: IRC bot should actually be useful now
6823 2003-05-23 Brian Warner <warner@lothar.com>
6825 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6826 "slave information" from $(slavedir)/info/* . These files are
6827 maintained by the slave administrator, and describe the
6828 machine/environment that is hosting the slave. Information from
6829 them is put into the "Builder" HTML page. Still need to establish
6830 a set of well-known filenames and meanings for this data: at the
6831 moment, *all* info/* files are sent to the master, but only
6832 'admin' and 'host' are used on that end.
6833 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6834 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6835 * buildbot/master.py (BotPerspective.got_info): ditto
6837 2003-05-22 Brian Warner <warner@lothar.com>
6839 * setup.py (version): bump version to 0.3.3+ while between releases
6841 2003-05-21 Brian Warner <warner@lothar.com>
6843 * setup.py: Releasing buildbot-0.3.3
6845 2003-05-21 Brian Warner <warner@lothar.com>
6847 * NEWS: 0.3.3 news items
6849 * README: describe --keepalive and life behind a NAT box
6851 * buildbot/bot.py (Bot.connected): implement application-level
6852 keepalives to deal with NAT timeouts, turn them on with
6853 --keepalive option or when SO_KEEPALIVE doesn't work.
6855 * buildbot/master.py (BotPerspective): accept keepalives silently
6857 * buildbot/process/base.py (Build.buildException): CopiedFailures
6858 don't carry as much information as local ones, so don't try to
6859 create a big HTMLized version of them.
6861 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6862 log file when step fails due to an exception, such as when the slave
6865 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6866 --testmodule argument instead of grepping for test-case-name tags
6867 ourselves. Remove FindUnitTests code.
6868 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6870 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6872 2003-05-16 Brian Warner <warner@lothar.com>
6874 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6875 argument to allow things like CFLAGS=-O0 to be passed without relying
6876 upon /bin/sh processing on the slave.
6878 * buildbot/process/step.py (InternalShellCommand.start): send
6880 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6881 'split' instead of letting /bin/sh do it. This should also remove
6882 the need for /bin/sh on the buildslave, making it more likely to
6885 * buildbot/status/html.py: html-escape text in blamelist.
6886 Add "force build" button to the Builder page.
6888 * buildbot/process/step_twisted.py (countFailedTests): look at
6889 last 1000 characters for status line, as import errors can put it
6890 before the -200 point.
6892 2003-05-15 Brian Warner <warner@lothar.com>
6894 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6896 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6897 make 'clobber' a parameter, so it is possible to have builds which
6898 do full tests but do a cvs update instead of hammering the CVS
6899 server with a full checkout each build
6901 * buildbot/process/step.py (InternalShellCommand): bump default
6902 timeout to 20 minutes
6904 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6905 the master to trigger a build. Run it via manhole.
6907 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6908 allow slaves to trigger any build that they host, to make life
6909 easier for slave admins who are testing out new build processes
6911 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6912 don't flunk cReactor or qtreactor on failure, since they fail alot
6913 these days. Do warnOnFailure instead.
6915 * buildbot/process/base.py: change Builder.buildable from a list
6916 into a single slot. When we don't have a slave, new builds (once
6917 they make it past the timeout) are now merged into an existing
6918 buildable one instead of being queued. With this change, a slave
6919 which has been away for a while doesn't get pounded with all the
6920 builds it missed, but instead just does a single build.
6922 2003-05-07 Brian Warner <warner@lothar.com>
6924 * setup.py (version): bump version to 0.3.2+ while between releases
6926 2003-05-07 Brian Warner <warner@lothar.com>
6928 * setup.py: Releasing buildbot-0.3.2
6930 2003-05-07 Brian Warner <warner@lothar.com>
6932 * setup.py: fix major packaging error: include subdirectories!
6934 * NEWS: add changes since last release
6936 * README (REQUIREMENTS): update twisted/python dependencies
6938 * buildbot/status/builder.py (Builder.startBuild): change
6939 BuildProcess API: now they should call startBuild/finishBuild
6940 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6941 keeping a list of builds in the statusbag, to support other kinds of
6943 (Builder.addClient): send current-activity-small to new clients
6944 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6947 * buildbot/status/client.py: drop RemoteReferences at shutdown
6949 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6951 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6952 more debug messages for remote status client
6954 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6955 (.stepFailed): only fire the Deferred once, even if both
6956 stepComplete and stepFailed are called. I think this can happen if
6957 an exception occurs at a weird time.
6959 * buildbot/status/words.py: work-in-progress: IRC status delivery
6961 2003-05-05 Brian Warner <warner@lothar.com>
6963 * docs/examples/twisted_master.py (twisted_app): hush internal
6964 python2.3 distutils deprecation warnings
6965 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6966 add compileOpts= argument which inserts extra args before the
6967 "setup.py build_ext" command. This can be used to give -Wignore
6968 warnings, to hush some internal python-2.3 deprecation messages.
6970 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6971 the ['twisted.test'] default test case to make it easier to change
6974 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6975 * buildbot/clients/gtkPanes.py: ditto
6977 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6978 arg to collapse RunUnitTestsRandomly into RunUnitTests
6979 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6980 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6982 * buildbot/status/html.py (StatusResource): shuffle Resources
6983 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6984 would serve the waterfall display, but the internal links were
6985 only valid on the trailing-slash version. The correct behavior is
6986 for the non-slashed one to serve a Redirect to the slashed one.
6987 This only shows up when the buildbot page is hanging off another
6988 server, like a Twisted-Web distributed server.
6990 * buildbot/status/event.py (Event, RemoteEvent): make Events
6991 pb.Cacheable, with RemoteEvent as the cached version. This removes
6992 a lot of explicit send-an-update code.
6993 * buildbot/status/builder.py (Builder): remove send-update code
6994 * buildbot/status/client.py (ClientBuilder): remove send-update
6995 code, and log errors that occur during callRemote (mostly to catch
6996 InsecureJelly exceptions)
6998 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6999 run Lore with the same python used in the rest of the build
7001 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7003 * buildbot/process/step_twisted.py (HLint): accept 'python'
7004 argument. Catch rc!=0 and mark the step as failed. This marks the
7005 build orange ("has warnings").
7006 (RunUnitTestsJelly): move out to step_twisted2.py
7008 * buildbot/util.py (ignoreStaleRefs): add utility function
7010 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7011 don't fake ETA object, it's too hard to get right
7013 2003-05-02 Brian Warner <warner@lothar.com>
7015 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7017 2003-05-01 Brian Warner <warner@lothar.com>
7019 * buildbot/status/html.py (StatusResource.body): oops, I was
7020 missing a <tr>, causing the waterfall page to be misrendered in
7021 everything except Galeon.
7023 2003-04-29 Brian Warner <warner@lothar.com>
7025 * docs/examples/twisted_master.py: make debuild use python-2.2
7026 explicitly, now that Twisted stopped supporting 2.1
7028 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7029 handle tuple results too. I keep forgetting this, which suggests
7030 it needs to be rethought.
7032 * setup.py (setup): bump version to 0.3.1+ while between releases
7034 2003-04-29 Brian Warner <warner@lothar.com>
7036 * setup.py: Releasing buildbot-0.3.1
7038 2003-04-29 Brian Warner <warner@lothar.com>
7040 * README (SUPPORT): add plea to send questions to the mailing list
7042 * NEWS, MANIFEST.in: add description of recent changes
7044 * docs/examples/twisted_master.py: add the code used to create the
7045 Twisted buildmaster, with passwords and such removed out to a
7048 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7049 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7050 buildmasters to not require CVSToys be installed.
7051 * README, docs/examples/glib_master: update to match the change
7053 * buildbot/clients/base.py, buildbot/bot.py,
7054 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7055 ReconnectingPB from CVSToys distribution to remove CVSToys
7056 dependency for build slaves and status clients. Buildmasters which
7057 use FreshCVSSources still require cvstoys be installed, of course.
7059 2003-04-25 Brian Warner <warner@lothar.com>
7061 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7062 runTestsRandomly arg to turn on trial -z
7064 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7065 experimental code to use trial's machine-parseable output to get
7066 more detailed test results. Still has some major issues.
7067 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7070 * buildbot/status/builder.py (Builder.setCurrentBuild):
7071 anticipating moving build history into statusbag, not used yet
7073 * buildbot/status/tests.py: code to centralize test results,
7074 doesn't work quite yet
7076 * buildbot/status/event.py (Event): use hasattr("setName") instead
7077 of isinstance for now.. need better long-term solution
7079 * buildbot/status/html.py: Remove old imports
7081 2003-04-24 Brian Warner <warner@lothar.com>
7083 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7084 ignore changes under doc/fun/ and sandbox/
7086 * buildbot/process/step_twisted.py: update pushEvent and friends.
7088 * buildbot/status/html.py (Box.td): replace event.buildername with
7089 event.parent.getSwappableName(). Needs more thought.
7091 * buildbot/status/builder.py (Builder): Replace pushEvent and
7092 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7093 Tell events they are being pruned with event.delete().
7095 * buildbot/process/base.py (Build): Remove Builder status-handling
7096 methods. s/pushEvent/setCurrentActivity/.
7098 * buildbot/process/step.py (BuildStep): clean up status delivery.
7099 Gouse builder.statusbag methods instead of intermediate builder
7100 methods. s/updateLastEvent/updateCurrentActivity/.
7101 s/finalizeLastEvent/finishCurrentActivity/. Use
7102 addFileToCurrentActivity for summaryFunction.
7104 * buildbot/status/event.py (Logfile): put data in a Swappable when
7106 (Event): add more setter methods. Remove .buildername, use .parent
7107 and getSwappableName instead (needs more thought).
7109 * buildbot/util.py (Swappable):
7110 * test/test_swap.py: don't bother setting filename at __init__
7111 time, do it later. Change setFilename args to take parent first,
7112 since it provides the most significant part of the filename.
7114 2003-04-23 Brian Warner <warner@lothar.com>
7116 * buildbot/status/event.py (Logfile.addEntry): append to previous
7119 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7120 anticipating Swappable
7121 (InternalShellCommand.remoteUpdate): split out various log-adding
7122 methods so subclasses can snarf stdout separately
7124 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7125 in anticipation of Swappable build logs
7126 (Builder.testsFinished): anticipating TestResults, still disabled
7128 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7131 * buildbot/status/event.py (Logfile): add (disabled) support for
7132 Swappable, not ready for use yet
7134 * buildbot/util.py (Swappable): object which is swapped out to
7135 disk after some period of no use.
7136 * test/test_swap.py: test buildbot.utils.Swappable
7138 2003-04-14 Brian Warner <warner@lothar.com>
7140 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7141 periodic-build timer. Set the .periodicBuildTime on a builder
7142 instance to some number of seconds to activate it.
7144 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7146 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7147 a way that survives result tuples
7149 2003-04-12 Brian Warner <warner@lothar.com>
7151 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7152 return a dict instead of a tuple: allow summarizers to provide
7153 multiple summaries if they want
7154 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7155 (debuildSummarizer): summarize lintian warnings/errors
7157 2003-04-10 Brian Warner <warner@lothar.com>
7159 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7161 2003-04-09 Brian Warner <warner@lothar.com>
7163 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7164 empty summaries: happens when the tests fail so hard they don't emit
7165 a parseable summary line.
7167 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7168 Allow summaryFunction to return None to indicate no summary should
7171 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7172 writing to stale HTTP requests: notice when they disconnect and
7173 remove the request from the list. Also add CacheToFile from
7174 moshez, will be used later.
7176 2003-04-08 Brian Warner <warner@lothar.com>
7178 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7179 should be an int, not a list of strings
7181 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7182 if we weren't actually connected
7184 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7185 to show the tail end of the trial text output
7187 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7188 hook to summarize the results of a ShellCommand
7190 2003-04-07 Brian Warner <warner@lothar.com>
7192 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7193 twisted test suite code into a single class.
7194 * buildbot/process/process_twisted.py: same
7196 2003-04-04 Brian Warner <warner@lothar.com>
7198 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7200 * README (SLAVE): document use of mktap to create slave .tap file
7201 (REQUIREMENTS): describe dependencies
7203 * buildbot/bb_tap.py, buildbot/plugins.tml:
7204 * buildbot/bot.py (updateApplication): Add mktap support for creating
7205 buildslave .tap files
7207 2003-03-28 Brian Warner <warner@lothar.com>
7209 * buildbot/process/step.py (InternalShellCommand.finished): handle
7210 new tuple result values (fix embarrasing bug that appeared during
7213 2003-03-27 Brian Warner <warner@lothar.com>
7215 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7218 2003-03-25 Brian Warner <warner@lothar.com>
7220 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7221 to overall build status
7222 * buildbot/clients/base.py (Builder): improve event printing
7223 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7224 instead of generic ShellCommand
7225 (Build): Add .stopBuild, use it when slave is detached
7227 * buildbot/process/step.py (Configure,Test): give the steps their
7228 own names and status strings
7230 * buildbot/status/html.py (StatusResource): add "show" argument,
7231 lets you limit the set of Builders being displayed.
7233 2003-03-20 Brian Warner <warner@lothar.com>
7235 * buildbot/process/basic.py: removed
7237 2003-03-19 Brian Warner <warner@lothar.com>
7239 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7240 turn off process-docs by default
7242 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7243 when displaying build information without anything in allBuilds[]
7245 * buildbot/bot.py (makeApp): really take password from sys.argv
7247 2003-03-18 Brian Warner <warner@lothar.com>
7249 * buildbot/bot.py (buildApp): take password from sys.argv
7251 * README: replace with more useful text
7253 * setup.py: add a real one
7254 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7256 * docs/PyCon-2003/: added sources for PyCon paper.
7258 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7259 now Build objects control the process and Builder only handles
7260 slave stuff and distribution of changes/status. A new BuildFactory
7261 class creates Build objects on demand.
7263 Created ConfigurableBuild which takes a list of steps to run. This
7264 makes it a lot easier to set up a new kind of build and moves us
7265 closer to being able to configure a build from a web page.
7267 * buildbot/process/step_twisted.py, process_twisted.py: move to
7268 new model. A lot of code went away.
7270 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7271 send lots of empty progress messages to the client.
7273 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7275 2003-02-20 Brian Warner <warner@lothar.com>
7277 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7279 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7280 Twisted bug that prevented non-pty processes from working just got
7281 fixed, and the bug that leaks ptys is still being investigated.
7283 * buildbot/process/step.py (CVS): send timeout arg to slave
7285 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7286 builders coming and going
7287 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7288 from CVSToys, handle lost-buildmaster
7290 * buildbot/status/client.py (StatusClientService.removeBuilder):
7291 Clean up status client protocol: send builders (with references)
7292 as they are created, rather than sending a list and requiring the
7293 client to figure out which ones are new.
7294 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7295 attempts to force a build on an unknown builder
7297 2003-02-19 Brian Warner <warner@lothar.com>
7299 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7300 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7301 Twisted stops leaking them.
7302 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7303 builder goes to an idle state.
7305 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7306 I figure out why CVS commands hang without them, and/or I fix the
7307 hung-command timeout
7309 2003-02-16 Brian Warner <warner@lothar.com>
7311 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7312 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7313 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7314 GenerateDocs now that they are prefixed with WARNING:.
7316 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7317 use manual href target instead of request.childLink
7319 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7320 display every second, but update the ETA every 5 seconds (or
7321 whenever) as remote_progress messages arrive.
7324 2003-02-12 Brian Warner <warner@lothar.com>
7326 * *: import current sources from home CVS repository
7330 # add-log-time-format: add-log-iso8601-time-string