1 2006-11-24 Brian Warner <warner@lothar.com>
3 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
6 * buildbot/clients/base.py (TextClient.not_connected): upon
7 UnauthorizedLogin failures, remind the user to connect to the
8 PBListener port instead of the slaveport.
9 (TextClient.disconnected): shut down more quietly
10 * docs/buildbot.texinfo (statuslog): add another reminder
12 * buildbot/scripts/runner.py (Options.subCommands): rename
13 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
15 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
16 reconfig command to follow twistd.log and print all of the lines
17 from the start of the config-file reload to its completion. This
18 should make it a lot easier to discover bugs in the config file.
19 Use --quiet to disable this behavior. This addresses half of
20 SF#1517975, the other half will be to add this same utility to
21 'buildbot start' and 'buildbot restart'.
22 * docs/buildbot.texinfo (Loading the Config File): same
25 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
26 method, it has been deprecated for a long time. Use
27 IBuilderControl.requestBuild instead.
28 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
29 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
30 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
31 * buildbot/test/test_control.py (Force.testForce): same
32 * buildbot/test/test_run.py: use requestBuild instead
34 * buildbot/clients/debug.py: replace 'Force Build' button with
35 'Request Build' (which just adds one to the queue), add Ping
36 Builder, add branch/revision fields to Request Build.
37 * buildbot/clients/debug.glade: same
38 * buildbot/master.py: update interface to match. This creates an
39 incompatibility between new debugclients and old buildmasters.
41 * buildbot/process/builder.py (Builder._attached): delay the call
42 to maybeStartBuild for a reactor turn, to avoid starting a build
43 in the middle of a reconfig (say, if the new Builder uses a new
44 slave which is already connected).
46 2006-11-23 Brian Warner <warner@lothar.com>
48 * buildbot/test/test_transfer.py: appease pyflakes
49 * buildbot/test/test_steps.py: same
51 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
52 keeps pyflakes from finding undefined names
54 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
55 Builder no longer induces a disconnect/reconnect cycle. This means
56 that any builds currently in progress will not be interrupted, and
57 any builds which are queued in the Builder will not be lost. This
58 is implemented by having the new Builder extract the state (i.e.
59 all pending Builds and any desired SlaveBuilders) from the old
61 (BotPerspective): refactor. The BotPerspective no longer keeps
62 track of all the Builders that want to use this slave; instead, it
63 asks the BotMaster each time it needs this list. This removes
64 addBuilder and removeBuilder. Clean up attached() to acquire all
65 the slave's information in a more atomic fashion. updateSlave() is
66 now the way to make sure the slave is using the right set of
67 Builders: just call it after everything else has been
69 (BotMaster): refactor, removing addBuilder/removeBuilder and
70 replacing them with an all-at-once setBuilders() call.
72 * buildbot/test/test_slaves.py (Reconfig): new test case to
73 exercise this functionality
74 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
75 * buildbot/slave/commands.py (WaitCommand): same
77 * docs/buildbot.texinfo (Loading the Config File): document the
80 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
81 SlaveBuilder to have its parent Builder changed.
82 (SlaveBuilder.isAvailable): new method to give access to state,
83 which is now a private attribute
84 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
85 the SlaveBuilder about how it is being used. These methods update
86 its internal state. buildFinished() is now the place that invokes
87 maybeStartBuild() on its parent Builder.
88 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
89 new Builder to take over for an old one, transferring state from
91 (Buider): refactor the way that SlaveBuilders are used to match,
92 giving them a bit more autonomy.
93 (Builder.buildFinished): this no longer calls maybeStartBuild():
94 instead the SlaveBuilder calls it on whoever its parent Builder is
95 at the time. This way, when an old Builder is replaced by a new
96 one, and there was a build in progress during the transition, when
97 that build finishes, it will be the new Builder that is told about
98 the newly available slave so it can start a new build.
100 * buildbot/process/base.py (Build.startBuild._release_slave): when
101 the Build finishes, tell the SlaveBuilder that they've been
104 * buildbot/status/builder.py (SlaveStatus): add some new setter
105 methods for use by BotPerspective, to keep some attributes more
108 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
109 called by the buildmaster.
110 (Bot.setBuilderList): instead, we locally announce any leftover
111 directories based upon which Builders we were told about. The
112 master doesn't really care; it's the local admin who may or may not
116 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
117 to allow use of python2.4 or whatever. This tool still requires
120 2006-11-19 Brian Warner <warner@lothar.com>
122 * NEWS (IStatusLog.readlines): more news items
124 2006-11-18 Brian Warner <warner@lothar.com>
126 * NEWS: start collecting items for the next release.
128 2006-11-04 Brian Warner <warner@lothar.com>
130 * buildbot/changes/bonsaipoller.py: apply updates from Ben
131 Hearsum. Closes SF#1590310.
132 * buildbot/test/test_bonsaipoller.py: and tests
134 * buildbot/status/tinderbox.py
135 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
136 status when the build results in WARNINGS. Patch from Dave
137 Liebreich. Closes SF#1587352.
139 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
140 linux-vs-osx behavior difference w.r.t. reading from files that
141 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
142 to Mark Rowe for the patch.
144 2006-10-15 Brian Warner <warner@lothar.com>
146 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
147 method name was misspelled in the interface definition. Thanks to
148 Roy Rapoport for the catch.
150 2006-10-13 Brian Warner <warner@lothar.com>
152 * docs/buildbot.texinfo (Adding LogObservers): update sample code
153 to match the great Steps renaming
155 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
156 Maybe I should run my own unit tests before recording a big
157 change. Good thing I've got a buildbot to remind me.
159 2006-10-12 Brian Warner <warner@lothar.com>
161 * buildbot/steps/transfer.py: rework __init__ and args setup
162 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
164 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
165 when opening the target file, only catch IOError (to report via
166 stderr/rc!=0), let the others be reported as normal exceptions
168 2006-10-08 Brian Warner <warner@lothar.com>
170 * contrib/svn_watcher.py: fix security holes by using proper argv
171 arrays and subprocess.Popen() rather than commands.getoutput().
172 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
173 is deprecated in favor of buildbot/changes/svnpoller.py, and will
174 probably be removed by the next release.
177 2006-10-04 Brian Warner <warner@lothar.com>
179 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
180 initial lines that weren't emitted by pyflakes. When the pyflakes
181 command is run under a Makefile, 'make' will echo the command it
182 runs to stdio, and that was getting logged as a "misc" warning.
183 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
184 * buildbot/test/test_steps.py (testPyFlakes3): another test
186 2006-10-01 Brian Warner <warner@lothar.com>
188 * buildbot/status/html.py (HtmlResource.render): if we get a
189 unicode object from our content() method, encode it into utf-8
190 like we've been claiming to all along. This allows the comments
191 and author names from svnpoller.py to be delivered properly.
193 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
194 de-unicodify filenames before creating the Change, because the
195 rest of buildbot is unlikely to handle them well. Leave the 'who'
196 field as a unicode object.. I don't think there's anything that
197 will break very soon, and it will probably nudge us towards
198 accepting unicode everywhere sooner or later. Stop using the
199 "date" field that comes out of SVN, since it is using the
200 repository's clock (and timezone) and what we care about is the
201 buildmaster's (otherwise Changes from the future show up later
202 than the builds they triggered).
203 * buildbot/test/test_svnpoller.py (Everything.test1): match the
206 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
207 Suvbersion repository polling ChangeSource. I've hacked it up
208 considerably: any bugs are entirely my own fault. Thank you
210 * buildbot/test/test_svnpoller.py: tests for it
211 * docs/buildbot.texinfo (SvnSource): document it
213 2006-09-30 Brian Warner <warner@lothar.com>
215 * buildbot/scheduler.py (Periodic): submit a reason= to the
216 BuildSet to indicate which Scheduler triggered the build. Thanks
217 to Mateusz Loskot for the suggestion.
219 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
221 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
222 changes: set self.loop in __init__, remove unused volatile=
224 * docs/buildbot.texinfo (.buildbot config directory): add more
225 docs on the .buildbot/options keys used by "buildbot try"
226 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
227 (Try.deliverJob): same
229 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
233 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
234 close the filehandle when we stop watching the file. Before, the
235 filehandle was only closed when the LogFileWatcher was
236 garbage-collected, which could be quite a while in the future. If
237 it was still open by the time the next build started, windows will
238 refuse to let the new build delete the old build/ directory. Fixes
239 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
240 #twisted for the catch.
242 2006-09-29 Brian Warner <warner@lothar.com>
244 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
247 2006-09-25 Brian Warner <warner@lothar.com>
249 * setup.py: the new buildbot.steps module wasn't being installed.
250 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
251 (testmsgs): add the extra stuff from buildbot/test/* so you can
252 run unit tests on an installed copy of buildbot, not just from
255 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
256 columns of 'svnlook changed' output contain status information, so
257 strip [:4] instead of [:6]. Depending upon what the status flags
258 were, this would sometimes lead to mangled filenames. Thanks to
259 Riccardo Magliocchetti for the patch. Closes SF#1545146.
261 * buildbot/steps/source.py (Monotone): initial Monotone support,
262 contributed by Nathaniel Smith. Still needs docs and tests, but
263 this code has been in use on the Monotone buildbot for a long
265 * buildbot/slave/commands.py (Monotone): slave-side support
266 * buildbot/changes/monotone.py (MonotoneSource): polling change
269 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
270 contributed a Change Source that polls a Bonsai server (a
271 kind of web-based viewcvs CGI script).
273 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
274 Hearsum contributed a status plugin which sends email in the same
275 format that Tinderbox does: this allows a number of tinderbox
276 tools to be driven by Buildbot instead. Thanks Ben!
278 2006-09-24 Brian Warner <warner@lothar.com>
280 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
281 Thanks to Robert Helmer for the patch.
283 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
284 BuildStatus about the buildslave name at the *beginning* of the
285 build, rather than at the end. Thanks to Alexander Lorenz for the
287 * buildbot/status/html.py (StatusResourceBuild.body): always
288 include the slavename in the build page, not just when the build
290 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
291 slavename in the email message
293 2006-09-21 Brian Warner <warner@lothar.com>
295 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
297 * docs/examples/glib_master.cfg: same
298 * docs/examples/hello.cfg: same
299 * docs/examples/twisted_master.cfg: same, update to current usage
301 2006-09-19 Brian Warner <warner@lothar.com>
303 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
304 (PyFlakes.createSummary): make it compatible with python-2.2
306 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
307 for at least the output-parsing parts of PyFlakes
309 2006-09-18 Brian Warner <warner@lothar.com>
311 * buildbot/steps/python.py: oops, fix import of StringIO
313 2006-09-17 Brian Warner <warner@lothar.com>
315 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
316 turns out that SVN-1.4.0 doesn't fail to update once you've
317 replaced a file with a directory, unlike older versions of SVN and
318 pretty much every other VC tool we support. Since what we really
319 care about is that the update succeeds anyway, stop checking that
320 the tree got clobbered and just assert that the build succeeded.
321 (VCBase.printLogs): add a utility function for debugging
323 * buildbot/process/step.py: oops, added extra imports by mistake
325 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
326 rstrip() on the first line coming out of the 'p4 describe'
327 process, to remove the stray ^M that Wade Brainerd reports seeing
328 in the 'when' field. Fixes SF#1555985.
330 * buildbot/master.py (BuildMaster.loadConfig): improve the error
331 message logged when c['schedulers'] is not right
332 * buildbot/scheduler.py (Scheduler.__init__): improve error
333 message when a Scheduler() is created with the wrong arguments
334 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
335 verify that these error messages are emitted
337 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
338 The idea is that all the base classes (like BuildStep and
339 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
340 will be a leftover backwards-compatibility file that only contains
341 aliases for the steps that were moved out to buildbot.steps.*
342 * lots: change imports to match
343 * buildbot/process/step.py: add a DeprecationWarning if it ever
346 2006-09-12 Brian Warner <warner@lothar.com>
348 * buildbot/scheduler.py (Scheduler.__init__): make sure that
349 builderNames= is actually a sequence, since if you happen to give
350 it a single builder-specification dictionary instead, it won't get
351 caught by the existing assert. Thanks to Brett Neely for the
354 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
356 * docs/buildbot.texinfo (Python BuildSteps): document them
357 (sendchange): include a link to PBChangeSource, since you need one
359 * buildbot/steps/shell.py: clean up test-case-name line, remove some
361 * buildbot/steps/dummy.py: same
363 2006-09-08 Brian Warner <warner@lothar.com>
365 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
366 BuildStep which lets you transfer files from the master to the
367 slave or vice versa. Thanks to Albert Hofkamp for the original
368 patch. Fixes SF#1504631.
369 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
371 (SlaveFileDownloadCommand): same
372 * docs/buildbot.texinfo (Transferring Files): document it
373 * buildbot/test/test_transfer.py: test it
374 * buildbot/test/runutils.py (StepTester): new utility class for
375 testing BuildSteps and RemoteCommands without Builds or Bots or PB
376 * buildbot/test/test_steps.py (CheckStepTester): validate that the
379 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
380 walk through StatusLogs one line at a time, mostly for the benefit
381 of ShellCommand.createSummary methods. You can either walk through
382 STDOUT or STDERR, but the default is STDOUT.
384 * buildbot/status/builder.py (LogFile.readlines): implement it.
385 Note that this is not yet memory-efficient, it just pulls the
386 whole file into RAM and then splits it up with a StringIO.
387 Eventually this should be a generator that only pulls chunks from
389 * buildbot/test/test_status.py (Log.testReadlines): test it
391 * docs/buildbot.texinfo: update to match changes
392 * buildbot/process/factory.py: stop using old definitions
393 * buildbot/process/process_twisted.py: same
394 * buildbot/test/test_*.py: same
396 * buildbot/process/step_twisted.py: move definition to..
397 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
398 relative-import mechanisms prevent this from being named 'twisted'
399 or 'python/twisted' as I would have preferred.
401 * buildbot/process/maxq.py: move definition to..
402 * buildbot/steps/maxq.py: .. here, leave a compatibility import
404 * buildbot/process/step.py: split the user-visible BuildSteps into
405 separate files, all under buildbot/steps/
406 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
407 * buildbot/steps/shell.py: this holds ShellCommand and friends
408 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
410 2006-09-05 Brian Warner <warner@lothar.com>
412 * lots: run pyflakes, removed a lot of unused imports, changed the
413 form of some conditional imports to remove false pyflakes
414 warnings. There are still a number of warnings left, mostly from
415 imports that are done for their side-effects.
416 * buildbot/test/test_vc.py: import twisted.python.failure, since it
419 2006-08-26 Brian Warner <warner@lothar.com>
421 * buildbot/test/test_locks.py (Unit.testLater): make the tests
422 compatible with twisted-1.3.0, for some reason I just can't seem
423 to let go of the past.
425 2006-08-25 Brian Warner <warner@lothar.com>
427 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
429 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
430 all logfiles= in startCommand(), rather than in start() . This
431 makes it easier to have the 'stdio' log come before any secondary
432 logfiles, which I feel makes the waterfall display more
434 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
435 from ShellCommand up into LoggingBuildStep
436 (LoggingBuildStep.__init__): move the handling of logfiles= from
437 ShellCommand up to LoggingBuildStep, because startCommand is
438 provided by LoggingBuildStep, whereas start() was specific to
439 subclasses like ShellCommand and Source. This removes code
440 duplication in those subclasses.
441 (ShellCommand.__init__): same
442 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
443 for a slave that's too old to understand logfiles= into a separate
444 method, so it can live in ShellCommand. The rest of
445 setupLogfiles() can live in LoggingBuildStep.
447 2006-08-24 Brian Warner <warner@lothar.com>
449 * buildbot/locks.py (BaseLock): you can now configure Locks to
450 allow multiple simultaneous owners. They still default to
451 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
453 * docs/buildbot.texinfo (Interlocks): document the new options
454 * buildbot/test/test_locks.py: add a bunch of new unit tests
455 * buildbot/process/base.py (Build.acquireLocks): locks now offer
456 waitUntilMaybeAvailable, not waitUntilAvailable
457 * buildbot/process/step.py (BuildStep.acquireLocks): same
458 * buildbot/master.py (BotMaster.getLockByID): real locks now use
459 the whole lockid in their constructor, not just the name. Also,
460 keep track of which real locks we've handed out by the full
461 lockid, not just class+name, otherwise changing just the maxCount=
462 in the master.cfg file would not actually cause a behavioral
465 2006-08-23 Brian Warner <warner@lothar.com>
467 * buildbot/__init__.py (version): bump to 0.7.4+ while between
469 * docs/buildbot.texinfo: same
471 2006-08-23 Brian Warner <warner@lothar.com>
473 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
474 * docs/buildbot.texinfo: set version to match
475 * NEWS: update for 0.7.4
476 * buildbot/slave/commands.py (command_version): mention that this
477 version (2.1) was released with buildbot-0.7.4
479 2006-08-22 Brian Warner <warner@lothar.com>
483 * CREDITS: new file, list of people who have helped. Thanks!
484 * MANIFEST.in: ship it
486 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
487 new diagrams, the user's manual is more informative than it was.
488 Start shipping the .html user's manual (and generated .png
490 * Makefile: update 'release' target to match
492 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
493 test.. I think the web-parts effort will render it pointless well
494 before it ever actually starts to work.
496 2006-08-20 Brian Warner <warner@lothar.com>
498 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
499 meaning of the prefix= argument. It is now just a string which is
500 stripped from the beginning of the filename. If prefix= is set but
501 not found on any given filename, that filename is ignored. If all
502 filenames in a Change are ignored, the Change is dropped. This is
503 much simpler than the previous sep= nonsense, and I should have
504 implemented it this way from the beginning. Effectively resolves
505 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
506 Gedminas for the catch and suggested fixes.
507 (ChangePerspective.perspective_addChange): implement the actual
509 * buildbot/test/test_changes.py (TestChangePerspective): test it
510 * docs/buildbot.texinfo (PBChangeSource): document it, explain
511 how to properly use prefix=
512 * docs/examples/twisted_master.cfg (source): update prefix= by
513 adding the trailing slash
516 * docs/examples/twisted_master.cfg: update to actual practice
518 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
519 update test case to match new link text.. the HREF has both a
520 class= setting and an enclosing [] pair that I didn't match in the
523 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
524 list of strings is preferred over a single string with embedded
526 (ShellCommand.description=): explain that either single strings or
527 a list of strings is acceptable, and why you might prefer one over
528 the other. Add an example. Fixes SF#1524659, thanks to Paul
529 Winkler for the catch.
530 (Build Steps): update to use f.addStep() rather than using s()
531 and the constructor list
533 * buildbot/process/step.py (ShellCommand): accept either a single
534 string or a list of strings in both description= and
536 * buildbot/test/test_steps.py (Steps.test_description): test it
537 * buildbot/test/runutils.py (makeBuildStep): support for that test
539 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
540 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
541 collecting the files and creating the patch.
543 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
544 per-step URLs that will be displayed on the waterfall display,
545 for things like the HTML output of code-coverage tools, when
546 the results are hosted elsewhere.
547 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
548 way to retrieve these URLs
549 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
550 the method to retrieve these URLs. Also provide backwards
551 compatibility for saved BuildStepStatus instances that didn't have
553 * buildbot/process/step.py (BuildStep.addURL): method to set these
554 URLs from within a BuildStep
555 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
556 (StepBox.getBox): give these external links a distinct CSS class
557 named "BuildStep external" so a .css file can display them
560 * buildbot/test/test_web.py (WaterfallSteps): test that we really
562 * buildbot/test/test_steps.py (Steps): test that we can all the
563 URLs. Also add a bunch of other tests on methods that can be
564 called from within BuildSteps
565 * buildbot/test/runutils.py (makeBuildStep): add utility function
567 2006-08-13 Brian Warner <warner@lothar.com>
569 * docs/buildbot.texinfo (BuildStep LogFiles): document them
571 2006-08-10 Brian Warner <warner@lothar.com>
573 * docs/buildbot.texinfo (Index of master.cfg keys): add another
574 index, this one of things like c['sources'] and c['schedulers']
575 (indices): it looks like my clever idea of putting the @fooindex
576 commands in between the @node and the @subsection (to make the
577 HREF anchor jump to slightly above the section title, which works
578 much better in html) confused texinfo horribly, so I'm moving the
579 index tags back to be just after the @subsection marker. I also
580 added extra lines between the @node/@section paragraph and the
581 index tags, since I think maybe texinfo wants to see these be
584 * docs/Makefile (images): make sure images get built when
586 * docs/images/Makefile: same
588 * buildbot/scripts/runner.py: rename 'buildbot master' to
589 'buildbot create-master', and 'buildbot slave' to 'buildbot
591 * docs/buildbot.texinfo: same
594 * docs/buildbot.texinfo: reimplement the "useful classes" index
595 with actual texinfo indices. The .info rendering is a bit
596 weird-looking but it works well, and the HTML rendering is quite
597 nice. This also puts the index targets in the regular flow of the
598 text, which is easier to maintain.
600 2006-08-06 Brian Warner <warner@lothar.com>
602 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
603 Kevin Turner to prefer the environ= argument be a list rather than
604 a string. If it is a list, it will be joined with a platform-local
605 os.pathsep delimiter, and then prepended to any existing
606 $PYTHONPATH value. This works better in cross-platform (i.e.
607 windows buildslaves) environments when you need to push multiple
608 directories onto the front of the path.
609 (SlaveShellCommand): documented the new magic
610 * docs/buildbot.texinfo (ShellCommand): documented the new magic
611 in a user-visible form
613 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
614 Turner to prefer lists over strings when creating/running VC
615 commands during unit tests. This is clearly necessary to survive
616 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
617 renamed the wq() function to qw() though, since that's how it's
618 spelled in perl. Eventually I'd prefer all commands to be
619 specified with lists.
621 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
622 which are deleted (or not yet created) correctly. Also add
623 failsafe code to not explode if the file-watching poller doesn't
624 get started. Thanks to JP Calderone for the catch and the poller
626 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
628 * buildbot/test/emitlogs.py: same
630 * NEWS: summarize recent changes
632 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
633 clause to avoid the "host key mismatch" warning
635 * buildbot/process/step_twisted.py (Trial.start): if the
636 buildslave is too old to understand logfiles=, fall back to
637 running 'cat _trial_temp/test.log' like before.
638 (Trial.commandComplete): same. this takes advantage of the
639 LoggingBuildStep refactoring to stall commandComplete long enough
640 to run a second RemoteShellCommand.
642 * buildbot/process/step.py (LoggingBuildStep.startCommand):
643 refactor command-completion handling, to allow methods like
644 commandComplete/createSummary/evaluateCommand to return Deferreds.
645 (LoggingBuildStep._commandComplete): delete the refactored method
646 (ShellCommand.setupLogfiles): if the buildslave is too old to
647 understand logfiles=, put a warning message both into twistd.log
648 and into the otherwise empty user-visible LogFiles.
650 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
651 callers to provide the slave-side logfile name, rather than
652 forcing it to come from the local name of the LogFile.
653 (BuildStep.getSlaveName): new method
655 * buildbot/process/base.py (Build.getSlaveName): new method, so
656 steps can find out which buildslave they're running on
658 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
659 to match the s/cvs_ver/command_version/ change
661 2006-08-05 Brian Warner <warner@lothar.com>
663 * buildbot/slave/commands.py (command_version): replace the CVS
664 auto-updated cvs_ver keyword with a manually-updated variable,
665 since CVS is no longer the master repository. Add a description of
666 the remote API change starting in this version (2.1), specifically
667 the fact that SlaveShellCommand now accepts 'initial_stdin',
668 'keep_stdin_open', and 'logfiles'.
670 2006-07-31 Brian Warner <warner@lothar.com>
672 * docs/buildbot.texinfo (System Architecture): Finally add lots of
673 diagrams to describe how the whole system fits together. The
674 images themselves are kept in SVG files, with ascii-art versions
675 in corresponding .txt files. Texinfo knows how to interpolate the
676 text version into .info files, reference the .png versions from
677 .html files, and include .eps versions in the .ps format.
678 * docs/images/Makefile: tools to create .png and .eps
679 * docs/images/*.svg: created pictures with Inkscape.
680 * .darcs-boring: ignore the generated .eps and .png files
682 2006-07-24 Brian Warner <warner@lothar.com>
684 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
685 Scheduler names, since they cause setServiceParent to explode
687 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
689 2006-07-20 Brian Warner <warner@lothar.com>
691 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
692 which runs the buildbot unit tests
694 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
695 classes that are useful in master.cfg
697 2006-07-15 Brian Warner <warner@lothar.com>
699 * Makefile (some-apidocs): new target to build only some epydocs
701 * setup.py: minor comment.. does the classifiers= argument prevent
702 the setup.py script from working on python2.2/2.3?
704 * buildbot/scripts/sample.cfg: update manhole example, arrange into
707 * buildbot/twcompat.py: fix minor typo in comments
709 * buildbot/manhole.py: move all Manhole-related code out to this
710 module. Implement SSH-based manholes (with TwistedConch), and move
711 to conch's nifty line-editing syntax-coloring REPL shell instead
712 of the boring non-editing monochromatic (and deprecated) old
714 * buildbot/master.py: remove all Manhole-related code
715 (BuildMaster.loadConfig._add): make sure the old manhole is
716 removed before we add the new one
717 * docs/buildbot.texinfo (Debug options): document new Manhole options
719 * buildbot/twcompat.py (_which): fix some epydoc issues
720 * buildbot/status/html.py (Waterfall.__init__): same
722 2006-06-29 Brian Warner <warner@lothar.com>
724 * buildbot/interfaces.py: get Interface from b.twcompat to hush
725 deprecation warnings under newer Twisteds (by using
726 zope.interface.Interface instead of old twisted.python.components
728 * buildbot/slave/interfaces.py: same
730 2006-06-28 Brian Warner <warner@lothar.com>
732 * buildbot/slave/commands.py (SVN): add --non-interactive to all
733 svn commands, so it will fail immediately instead of hanging while
734 it waits for a username/password to be typed in.
736 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
737 log message if the step was shut down
739 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
740 obsolete reference to mktap.
742 2006-06-20 Brian Warner <warner@lothar.com>
744 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
745 test to include new 'logfiles' argument sent from master to slave
747 2006-06-19 Brian Warner <warner@lothar.com>
749 * buildbot/process/step_twisted.py (Trial): track Progress from
750 _trial_temp/test.log too
752 * buildbot/process/step.py (OutputProgressObserver): generalize
753 the earlier StdioProgressObserver into an OutputProgressObserver
754 that can track LogFiles other than stdio.
755 (LoggingBuildStep.__init__): same
757 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
758 _trial_temp/test.log, not a separate 'cat' command. TODO: this
759 will fail under windows because of os.sep issues. It might have
760 worked before if 'cat' was doing cygwin path conversion.
762 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
763 creation of LogFileWatchers
764 (ShellCommand._startCommand): and record the files that were
765 watched in the 'headers' section of the ShellCommand output
767 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
768 need to actually pass it to the slave if you want it to work.
769 (ShellCommand): document it a bit
771 * buildbot/test/test_shell.py: new test to validate LogFiles
772 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
774 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
775 before printing the last batch of lines, to test that the polling
776 logic is working properly
778 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
779 handling, making it possible to track multiple logs for a single
780 RemoteCommand. The previous single logfile is now known as the
782 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
783 (RemoteShellCommand.__init__): accept logfiles=
784 (LoggingBuildStep.startCommand): stdio_log is now one of many
785 (ShellCommand): added logfiles= argument, as well as a class-level
786 .logfiles attribute, which will be merged together to figure out
787 which logfiles should be tracked. The latter maybe be useful for
788 subclasses of ShellCommand which know they will aways produce
789 secondary logfiles in the same location.
791 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
792 and closeStdin() methods, preparing to make it possible to write
793 to a ShellCommand's stdin at any time, not just at startup. These
794 writes are buffered if the child process hasn't started yet.
795 (LogFileWatcher): new helper class to watch arbitrary logfiles
796 while a ShellCommand runs. This class polls the file every two
797 seconds, and sends back 10k chunks to the buildmaster.
798 (ShellCommand): rename stdin= to initialStdin=, and add
799 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
801 (ShellCommand.addLogfile): LogFile text is sent in updates with a
802 key of "log" and a value of (logname, data).
803 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
804 'logfiles' to the master-visible args dictionary.
805 (SourceBase.doPatch): match s/stdin/initialStdin/ change
808 * buildbot/test/test_vc.py (Patch.testPatch): same
811 * buildbot/test/emit.py: write to a logfile in the current
812 directory. We use this to figure out what was used as a basedir
813 rather than looking to see which copy of emit.py gets run, so that
814 we can run the commands from inside _trial_temp rather than inside
816 * buildbot/test/subdir/emit.py: same
817 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
818 argument rather than running from buildbot/test/
819 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
820 rather than using an implicit setUp()
821 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
822 (ShellBase.testShell1, etc): use explicit path to emit.py instead
823 of assuming that we're running in buildbot/test/ (and that '.' is
826 * buildbot/slave/commands.py (Command.doStart): refactor Command
827 startup/completion a bit: now the SlaveBuilder calls doStart(),
828 which is not meant for overridding by subclasses, and doStart()
829 calls start(), which is. Likewise the SlaveBuilder calls
830 doInterrupt(), and subclasses override interrupt(). This also puts
831 responsibility for maintaining .running in Command rather than in
833 (Command.doInterrupt): same
834 (Command.commandComplete): same, this is called when the deferred
835 returned by start() completes.
836 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
837 (SlaveBuilder.remote_interruptCommand): same
838 (SlaveBuilder.stopCommand): same
840 2006-06-16 Brian Warner <warner@lothar.com>
842 * buildbot/test/test_shell.py: new test file to contain everything
843 relating to ShellCommand
844 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
845 multiple logfiles in realtime" feature, not yet implemented
846 * buildbot/test/emitlogs.py: support file for testLogFiles
847 * docs/buildbot.texinfo (ShellCommand): document the feature
849 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
851 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
852 for tests which exercise SlaveCommands in isolation.
854 * buildbot/test/test_slavecommand.py: Move some utilities like
855 SignalMixin and FakeSlaveBuilder from here ..
856 * buildbot/test/runutils.py: .. to here, so they can be used by
857 other test classes too
858 * buildbot/test/test_vc.py: more SignalMixin refactoring
859 * buildbot/test/test_control.py: same
860 * buildbot/test/test_run.py: and some rmtree refactoring
862 2006-06-15 Brian Warner <warner@lothar.com>
864 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
865 'testBranch' to match other VC tests and have the tests run in
866 roughly increasing order of dependency
868 * buildbot/test/test_steps.py (LogObserver): new test to verify
869 LogObservers can be created at various times and still get
870 connected up properly
872 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
873 to create BuildStepStatus instances that actually work.
875 * buildbot/process/step.py (LogObserver): add outReceived and
876 errReceived base methods, to be overridden
878 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
879 API to take a name instead of a step, reducing the coupling
880 somewhat. This returns the BuildStepStatus object so it can be
881 passed to the new Step, instead of jamming it directly into the
883 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
885 * buildbot/process/base.py (Build.setupBuild): use both methods
886 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
887 process a bit to match
889 2006-06-14 Brian Warner <warner@lothar.com>
891 * docs/buildbot.texinfo (Adding LogObservers): add some limited
892 docs on writing new LogObserver classes
893 (Writing New Status Plugins): brief docs on how Status Plugins fit
896 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
897 implement a LogObserver that counts how many unit tests have been
899 (Trial.__init__): wire it in
900 * buildbot/test/test_twisted.py (Counter): unit test for it
902 * buildbot/process/step_twisted.py (HLint.commandComplete): update
903 to new cmd.logs['stdio'] scheme
904 (Trial.commandComplete): same
905 (BuildDebs.commandComplete): same
907 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
908 LogFiles, instead of just a single one. The old single logfile is
909 now called "stdio". LoggedRemoteCommand no longer creates a
910 LogFile for you (the code to do that was broken anyway). If you
911 don't create a "stdio" LogFile, then stdout/stderr will be
913 (LogObserver): implement "LogObservers", which a BuildStep can add
914 to parse the output of a command in real-time. The primary use is
915 to provide more useful information to the Progress code, allowing
916 better ETA estimates.
917 (LogLineObserver): utility subclass which feeds complete lines to
918 the parser instead of bytes.
919 (BuildStep.progressMetrics): this is safer as a tuple
920 (BuildStep.setProgress): utility method, meant to be called by
922 (BuildStep.addLogObserver): new method, to be called at any time
923 during the BuildStep (even before any LogFiles have been created),
924 to attach (or schedule for eventual attachment) a LogObserver to a
926 (StdioProgressObserver): new LogObserver which replaces the old
927 "output" progress gatherer
928 (LoggingBuildStep.__init__): same
929 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
930 (LoggingBuildStep._commandComplete): must use logs['stdio']
931 instead of the old single ".log" attribute.
932 * buildbot/status/builder.py (LogFile): remove old logProgressTo
933 functionality, now subsumed into StdioProgressObserver
934 * buildbot/test/test_status.py (Subscription._testSlave_2): the
935 log name changed from "output" to "stdio".
938 * buildbot/interfaces.py (ILogFile): add the Interface used from
939 the BuildStep towards the LogFile
940 (ILogObserver): and the one provided by a LogObserver
941 * buildbot/status/builder.py (LogFile): implement it
943 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
944 HEADER constants here ..
945 * buildbot/status/builder.py (STDOUT): .. from here
947 2006-06-13 Brian Warner <warner@lothar.com>
949 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
950 compatibility with python2.2, which doesn't have the 'substr in
952 (TestP4Poller.makeTime): utility function to construct the
953 timestamp using the same strptime() approach as p4poller does. It
954 turns out that time.mktime() behaves slightly differently under
955 python2.2, probably something to do with the DST flag, and that
956 causes the test to fail under python2.2. (changing the mktime()
957 arguments to have dst=0 instead of -1 caused it to fail under
958 python2.3. Go figure.)
959 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
961 2006-06-12 Brian Warner <warner@lothar.com>
963 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
964 proper Perforce (P4) support. Many many thanks to Scott Lamb for
965 contributing such an excellent patch, including docs and unit
966 tests! This makes it *so* much easier to apply. I had to update
967 test_vc.py to handle some recent refactorings, but everything else
968 applied smoothly. The only remaining thing I'd like to fix would
969 be to remove the hard-wired port 1666 used by p4d, and allow it to
970 claim any unused port. This would allow two copies of the test
971 suite to run on the same host at the same time, as well as
972 allowing the test suite to run while a real (production) p4d was
973 running on the same host. Oh, and maybe we should add a warning to
974 step.P4 that gets emitted if the slave is too old to provide the
975 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
976 * buildbot/slave/commands.py (P4): same
977 (P4Sync): same, some minor updates
978 * buildbot/changes/p4poller.py: same
979 * docs/buildbot.texinfo: same
980 * buildbot/test/test_p4poller.py: same
981 * buildbot/test/test_vc.py (P4): same
983 * setup.py: add Trove classifiers for PyPI
985 2006-06-08 Brian Warner <warner@allmydata.com>
987 * buildbot/status/client.py
988 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
989 changing this from getCurrentBuild() to getCurrentBuilds(). Each
990 build needs to be IRemote'd separately, rather than IRemote'ing
991 the whole list at once. I can't wait until newpb's serialization
992 adapters make this unnecessary.
994 2006-06-06 Brian Warner <warner@lothar.com>
996 * buildbot/process/step.py (WithProperties): make this inherit
997 from ComparableMixin, so that reloading an unchanged config file
998 doesn't cause us to spuriously reload any Builders which use them.
999 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1002 2006-06-03 Brian Warner <warner@lothar.com>
1004 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1005 running py2exe on windows, contributed by Mark Hammond. Addresses
1006 SF#1401121, but I think we still need to include
1007 buildbot/scripts/sample.cfg
1008 * setup.py: include buildbot_service.py as a script under windows
1009 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1010 a py2exe application), get the icon/css datafiles from a different
1013 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1014 double-escape the build URL. Thanks to Olivier Bonnet for the
1015 patch. Fixes SF#1452801.
1017 2006-06-02 Brian Warner <warner@lothar.com>
1019 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1020 first six columns of 'svnlook' output, not just the first column,
1021 since property changes appear in the other five. Thanks to Olivier
1022 Bonnet for the patch. Fixes SF#1398174.
1024 2006-06-01 Brian Warner <warner@lothar.com>
1026 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1027 the fake build, so that title= has something to be set to
1029 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1030 attribute of the "Build #NN" link in the yellow start-the-build
1031 box to the build's reason. This means that you get a little
1032 tooltip explaining why the build was done when you hover over the
1033 yellow box. Thanks to Zandr Milewski for the suggestion.
1035 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1036 (Box.setETA): handle ETA=None (by stopping the timer)
1037 (Box.update): make the [soon] text less different than the usual
1038 text, so the rest of the text doesn't flop around so much. It
1039 would be awfully nice to figure out how to center this stuff.
1040 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1042 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1043 by default, so that any ShellCommand which fails marks the overall
1044 build as a failure. I should have done this from the beginning.
1045 Add flunkOnFailure=False to the arguments if you want to turn off
1048 2006-05-30 Brian Warner <warner@lothar.com>
1050 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1051 last-build/current-build/current-step. Show what step is currently
1052 running. Show ETA for both the overall build and the current step.
1053 Update GTK calls to modern non-deprecated forms. There's still a
1054 lot of dead code and debug noise to remove.
1056 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1057 shows up properly in status displays
1059 2006-05-28 Brian Warner <warner@lothar.com>
1061 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1062 build we use to verify that WithProperties works:
1064 ** set flunkOnFailure=True so that build failures get noticed
1065 ** set workdir='.' so that the build succeeds, otherwise it is trying
1066 to touch 'build/something', and 'build/' doesn't exist because
1067 usually that's created by a Source step
1068 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1069 this test somehow triggers, in which the 'touch' process becomes
1070 a zombie and we wait for th etimeout before giving up on it.
1072 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1073 to log the Build results and step logs to the twisted log.
1074 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1075 what went wrong if a build was expected to succeed but didn't.
1077 * buildbot/process/step_twisted.py (Trial): set the default
1078 trialMode to '--reporter=bwverbose', which specifies verbose
1079 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1080 '-to', but those are completely missing in modern Twisteds.
1082 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1083 a localhost-only port, to encourage better security
1085 * docs/buildbot.texinfo (Change Sources): mention
1088 * .darcs-boring: add a Darcs boringfile
1090 * README (REQUIREMENTS): stop claiming compatibility with
1093 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1096 2006-05-27 Brian Warner <warner@lothar.com>
1098 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1099 * docs/buildbot.texinfo: same
1101 2006-05-23 Brian Warner <warner@lothar.com>
1103 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1104 * docs/buildbot.texinfo: set version to match
1105 * NEWS: update for 0.7.3
1107 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1108 give a quick mapping from VC system to possible ChangeSources
1109 (Build Properties): add 'buildername'
1111 * buildbot/process/base.py (Build.setupStatus): oops, set
1112 'buildername' and 'buildnumber' properties
1113 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1116 2006-05-22 Brian Warner <warner@lothar.com>
1118 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1119 property interpolation better
1121 * README (INSTALLATION): remove old '-v' argument from recommended
1124 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1125 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1128 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1129 'svnversion' instead of grepping the output of 'svn info', much
1130 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1131 Bonnet for the suggestion.
1132 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1133 require the WC_PATH argument, so run 'svnversion .' instead.
1135 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1136 aren't supposed to have 'self' in their argument list
1138 2006-05-21 Brian Warner <warner@lothar.com>
1140 * buildbot/process/step.py (ShellCommand.start): make
1141 testInterpolate pass. I was passing the uninterpolated command to
1142 the RemoteShellCommand constructor
1143 (ShellCommand._interpolateProperties): oops, handle non-list
1144 commands (i.e. strings with multiple words separated by spaces in
1145 them) properly, instead of forgetting about them.
1147 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1148 to actually try to use build properties in a real build. This test
1150 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1151 to start and evaluate builds
1153 * buildbot/test/test__versions.py: add a pseudo-test to record
1154 what version of Twisted/Python/Buildbot are running. This should
1155 show up at the beginning of _trial_tmp/test.log, and exists to help
1156 debug other problems.
1158 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1159 a filename to be served as 'robots.txt' to discourage web spiders.
1160 Adapted from a patch by Tobi Vollebregt, thanks!
1161 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1162 (Waterfall.test_waterfall): tweak the way that filenames are put
1163 into the config file, to accomodate windows pathnames better.
1165 * docs/buildbot.texinfo (HTML Waterfall): document it
1167 * buildbot/process/process_twisted.py
1168 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1169 changed the build process. The new setup.py no longer takes the
1171 (FullTwistedBuildFactory.__init__): same
1172 (TwistedReactorsBuildFactory.__init__): same
1174 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1175 be placed in the [hooks] section of the central repository (the
1176 one that everybody pushes changes to).
1178 2006-05-20 Brian Warner <warner@lothar.com>
1180 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1181 .darcs-context file, use binary mode. I think this was causing a
1182 Darcs failure under windows.
1184 2006-05-19 Brian Warner <warner@lothar.com>
1186 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1187 use a timezone string of +0000 and gmtime, since this timestamp is
1188 sent to a buildmaster and %z is broken.
1190 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1191 string and localtime, since this timestamp will only be consumed
1192 locally, and %z is broken.
1194 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1195 gmtime, since this timestamp is returned to the buildmaster, and
1198 2006-05-18 Brian Warner <warner@lothar.com>
1200 * NEWS: update in preparation for next release
1202 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1203 setup-repository and do-we-have-the-vc-tools code into a separate
1204 "helper" class, which sticks around in a single module-level
1205 object. This seems more likely to continue to work in the future
1206 than having it hide in the TestCase and hope that TestCases stick
1207 around for a long time.
1209 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1210 addremove' has been deprecated in recent versions of mercurial, so
1211 use 'hg add' instead
1213 2006-05-07 Brian Warner <warner@lothar.com>
1215 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1216 operating under windows, move the file before opening it, since
1217 you can't rename a file that somebody has open.
1219 * buildbot/process/base.py (Build.setupBuild): if something goes
1220 wrong while creating a Step, log the name and arguments, since the
1221 error message when you get the number of arguments wrong is really
1224 2006-05-06 Brian Warner <warner@lothar.com>
1226 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1227 bugs in twisted-specific code not covered by my unit tests, this
1228 time use 'cmd' argument instead of self.cmd
1230 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1231 fix stupid braino: either use startwith or find()==0, not both.
1232 (TwistedReactorsBuildFactory.__init__): another dumb typo
1234 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1235 mark this test as TODO under windows, since process-killing seems
1236 dodgy there. We'll come back to this later and try to fix it
1239 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1240 and don't include a timezone
1241 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1242 This should avoid the windows-with-verbose-timezone-name problem
1244 (Patch.testPatch): add a test which runs 'patch' with less
1245 overhead than the full VCBase.do_patch sequence, to try to isolate
1246 a windows test failure. This one uses slave.commands.ShellCommand
1247 and 'patch', but none of the VC code.
1249 * buildbot/slave/commands.py (getCommand): use which() to find the
1250 executables for 'cvs', 'svn', etc. This ought to help under
1253 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1254 working directory before starting. If an earlier test failed, the
1255 leftover directory would mistakenly flunk a later test.
1256 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1257 Make sure that we use the right commandlines if which("tla") picks
1258 up "tla.exe" (as it does under windows).
1259 (TlaSupport.do_get): factor out this tla-vs-baz difference
1260 (TlaSupport.vc_create): more tla-vs-baz differences
1262 * buildbot/test/test_slavecommand.py
1263 (ShellBase.testShellMissingCommand): stop trying to assert
1264 anything about the error message: different shells on different
1265 OSes with different languages makes it hard, and it really isn't
1266 that interesting of a thing to test anyway.
1268 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1269 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1270 "Panther"), because it has a bug which flunks a couple tests in
1271 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1272 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1273 able to test that yet.
1275 2006-04-30 Brian Warner <warner@lothar.com>
1277 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1278 make sure child commands emit messages in english, so our regexps
1279 will match. Thanks to Nikaus Giger for identifying the problems.
1280 (VCBase._do_vctest_export_1): mode="export" is not responsible
1281 for setting the "got_revision" property, since in many cases it is
1282 not convenient to determine.
1283 (SVNSupport.capable): when running 'svn --version' to check for
1284 ra_local, we want error messages in english
1285 * buildbot/test/test_slavecommand.py
1286 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1287 to emit the error message in english
1289 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1290 the environment with $LC_ALL="C" so that Commands which need to
1291 parse the output of their child processes can obtain it in
1293 (SVN.parseGotRevision): call "svn info" afterwards instead of
1294 watching the output of the "svn update" or "svn checkout".
1295 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1296 (Arch.parseGotRevision): same
1297 (Bazaar.parseGotRevision): same
1298 (Mercurial.parseGotRevision): same
1300 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1301 $LC_ALL="C" when running commands under 'buildbot try', too
1303 * buildbot/test/__init__.py: remove the global os.environ()
1304 setting, instead we do it just for the tests that run commands and
1305 need to parse their output.
1307 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1308 remove the overly-short .timeout on this test, because non-DNotify
1309 platforms must fall back to polling which happens at 10 second
1310 intervals, so a 5 second timeout would never succeed.
1312 2006-04-24 Brian Warner <warner@lothar.com>
1314 * docs/buildbot.texinfo (Installing the code): update trial
1315 invocation, SF#1469116 by Niklaus Giger.
1316 (Attributes of Changes): updated branch-name examples to be
1317 a bit more realistic, SF#1475240 by Stephen Davis.
1319 * contrib/windows/buildbot2.bat: utility wrapper for windows
1320 developers, contributed by Nick Trout (after a year of neglect..
1321 sorry!). SF#1194231.
1323 * buildbot/test/test_vc.py (*.capable): store the actual VC
1324 binary's pathname in VCS[vcname], so it can be retrieved later
1325 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1326 strip out non-numeric timezone information, specifically the funky
1327 German string that his system produced that confuses CVS.
1328 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1329 allow Darcs tests to work on windows
1330 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1331 procutils.which() everywhere, to allow tryclient to work under
1332 windows. Also from Niklaus Giger, SF#1463394.
1334 * buildbot/twcompat.py (which): move the replacement for a missing
1335 twisted.python.procutils.which from test_vc.py to here, so it can
1336 be used in other places too (specifically tryclient.py)
1338 2006-04-23 Brian Warner <warner@lothar.com>
1340 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1341 bare buildbotURL/projectName line with a proper DIV, along with a
1342 CSS class of "title", from Stefan Seefeld (SF#1461675).
1343 (WaterfallStatusResource.body0): remove the redundant 'table'
1344 class from the table
1345 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1346 to the top-row TR, and class="Activity" to the second-row TR,
1347 rather than putting them in the individual TD nodes.
1349 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1350 'got_revision' build property for all VC systems that implement
1351 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1353 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1354 to determine which revision we actually obtained
1355 (CVS.parseGotRevision): implement this for CVS, which just means
1356 to grab a timestamp. Not ideal, and it depends upon the buildslave
1357 having a clock that is reasonably well syncronized with the server,
1358 but it's better than nothing.
1359 (SVN.parseGotRevision): implement it for SVN, which is accurate
1360 (Darcs.parseGotRevision): same
1361 (Arch.parseGotRevision): same
1362 (Bazaar.parseGotRevision): same
1363 (Mercurial.parseGotRevision): same
1365 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1366 keep a record of all non-stdout/stderr/header/rc status updates,
1367 for the benefit of RemoteCommands that send other useful things,
1369 (Source.commandComplete): put any 'got_revision' status values
1370 into a build property of the same name
1373 * buildbot/process/step_twisted.py (Trial): update to deal with
1374 new ShellCommand refactoring
1376 * docs/buildbot.texinfo (Build Properties): document new feature
1377 that allows BuildSteps to get/set Build-wide properties like which
1378 revision was requested and/or checked out.
1380 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1381 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1382 it. Note that this bumps the persistenceVersion of the saved Build
1383 object, so add the necessary upgrade-old-version logic to include
1384 an empty properties dict.
1386 * buildbot/process/base.py (Build.setProperty): implement it
1387 (Build.getProperty): same
1388 (Build.startBuild): change build startup to set 'branch',
1389 'revision', and 'slavename' properties at the right time
1391 * buildbot/process/step.py (BuildStep.__init__): change setup to
1392 require 'build' argument in a better way
1393 (LoggingBuildStep): split ShellCommand into two pieces, for better
1394 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1395 a single RemoteCommand that sends stdout/stderr status text. It
1396 also provides the usual commandComplete / createSummary /
1397 evaluateCommand / getText methods to be overridden...
1398 (ShellCommand): .. whereas ShellCommand is specifically for
1399 running RemoteShellCommands. Other shell-like BuildSteps (like
1400 Source) can inherit from LoggingBuildStep instead of ShellCommand
1401 (WithProperties): marker class to do build-property interpolation
1402 (Source): inherit from LoggingBuildStep instead of ShellCommand
1405 * buildbot/test/test_properties.py: test new functionality
1407 2006-04-21 Brian Warner <warner@lothar.com>
1409 * buildbot/test/test_vc.py: rename testBranch to
1410 testCheckoutBranch to keep the tests in about the right
1413 2006-04-18 Brian Warner <warner@lothar.com>
1415 * docs/buildbot.texinfo (PBListener): improve cross-references
1416 between PBListener and 'buildbot statusgui', thanks to John Pye
1419 2006-04-17 Brian Warner <warner@lothar.com>
1421 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1422 running under Twisted-1.3.0, otherwise skipped tests are reported
1425 * all: use isinstance() instead of 'type(x) is foo', suggested by
1428 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1429 oops, fix a brain-fade from the other week, when making the
1430 addStep changes. I changed all the __init__ upcalls to use the
1431 wrong superclass name.
1432 (FullTwistedBuildFactory.__init__): same
1433 (TwistedDebsBuildFactory.__init__): same
1434 (TwistedReactorsBuildFactory.__init__): same
1435 (TwistedBuild.isFileImportant): use .startswith for clarity,
1436 thanks to Neal Norwitz for the suggestions.
1438 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1439 changes, then deliver them over PB to a remote buildmaster.
1441 * contrib/svnpoller.py: added script by John Pye to poll a remote
1442 SVN repository (by running 'svn log') from a cronjob, and run
1443 'buildbot sendchange' to deliver the changes to a remote
1445 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1446 modification of svnpoller.py), same purpose, but this one loops
1447 internally (rather than expecting to run from a cronjob) and works
1449 * contrib/README.txt: same
1451 2006-04-11 Brian Warner <warner@lothar.com>
1453 * all: fix a number of incorrect names and missing imports, thanks
1454 to Anthony Baxter for the patch.
1455 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1456 remove unused buggy method.
1457 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1458 comes from shutil, not "shutils"
1459 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1460 (Arch.checkSlaveVersion): same
1461 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1463 * buildbot/process/step_twisted2.py: add some missing imports
1464 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1465 this code used to live in twisted.internet.defer
1467 2006-04-10 Brian Warner <warner@lothar.com>
1469 * buildbot/process/step.py (Mercurial): add Mercurial support
1470 * buildbot/slave/commands.py (Mercurial): same
1471 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1472 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1473 not yet tested, but 'try' support *is* covered
1474 * docs/buildbot.texinfo (Mercurial): document it
1476 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1477 some debugging messages (turned off)
1478 * buildbot/test/test_vc.py: improve debug messages
1480 2006-04-07 Brian Warner <warner@lothar.com>
1482 * buildbot/test/test_vc.py (which): define our own which() in case
1483 we can't import twisted.python.procutils, because procutils doesn't
1484 exist in Twisted-1.3
1486 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1487 of SlaveLocks for performance tests
1489 * docs/examples/twisted_master.cfg: update to match current usage
1491 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1492 password, p4 binary, pollinterval, maximum history to check.
1493 Patch from an anonymous sf.net contributor, SF#1219384.
1494 * buildbot/process/step.py (P4Sync.__init__): add username,
1495 password, and client arguments.
1496 * buildbot/slave/commands.py (P4Sync): same
1498 2006-04-05 Brian Warner <warner@lothar.com>
1500 * buildbot/process/factory.py (BuildFactory.addStep): new method
1501 to add steps to a BuildFactory. Use it instead of f.steps.append,
1502 and you can probably avoid using the s() convenience function.
1503 Patch from Neal Norwitz, sf.net #1412605.
1504 (other): update all factories to use addStep
1505 * buildbot/process/process_twisted.py: update all factories to use
1508 2006-04-03 Brian Warner <warner@lothar.com>
1510 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1511 work under windows too. Adapted from a patch by Niklaus Giger,
1512 addresses SF#1463399.
1514 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1515 spawned commands emit parseable results in english and not some
1516 other language. Patch from Niklaus Giger, SF#1463395.
1518 * README (INSTALLATION): discourage users from running unit tests on
1519 a "network drive", patch from Niklaus Giger, SF#1463394.
1521 2006-03-22 Brian Warner <warner@lothar.com>
1523 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1524 function to turn a repository-relative pathname into a (branch,
1525 branch-relative-filename) tuple. Change this function to handle
1526 the branch naming policy used by your Subversion repository.
1527 Thanks to AllMyData.com for sponsoring this work.
1529 2006-03-16 Brian Warner <warner@lothar.com>
1531 * buildbot/scripts/sample.cfg: add python-mode declaration for
1532 vim. Thanks to John Pye for the patch.
1534 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1535 command line, mention the importance of running 'crontab' as the
1536 buildmaster/buildslave user. Thanks to John Pye for the catch.
1538 2006-03-13 Brian Warner <warner@lothar.com>
1540 * buildbot/status/words.py (IRC): add an optional password=
1541 argument, which will be sent to Nickserv in an IDENTIFY message at
1542 login, to claim the nickname. freenode requires this before the
1543 bot can sent (or reply to) private messages. Thanks to Clement
1544 Stenac for the patch.
1545 * docs/buildbot.texinfo (IRC Bot): document it
1547 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1548 larger than chunkSize. Fixes SF#1349253.
1549 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1550 (Log.testConsumer): update to match new internal chunking behavior
1552 2006-03-12 Brian Warner <warner@lothar.com>
1554 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1556 * buildbot/test/test_maildir.py (MaildirTest): rename the
1557 'timeout' method, as it collides with trial's internals
1559 * buildbot/scripts/runner.py: add 'buildbot restart' command
1560 (stop): don't sys.exit() out of here, otherwise restart can't work
1561 * docs/buildbot.texinfo (Shutdown): document it
1563 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1564 * buildbot/status/html.py (Waterfall.__init__): same
1565 * buildbot/process/builder.py (Builder.startBuild): same
1566 * buildbot/process/base.py (BuildRequest): same
1567 * buildbot/sourcestamp.py (SourceStamp): same
1568 * buildbot/scheduler.py (Nightly): same
1570 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1572 * docs/buildbot.texinfo: same
1574 2006-02-17 Brian Warner <warner@lothar.com>
1576 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1577 * docs/buildbot.texinfo: set version number to match
1578 * NEWS: update for 0.7.2
1580 2006-02-16 Brian Warner <warner@lothar.com>
1582 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1584 2006-02-09 Brian Warner <warner@lothar.com>
1586 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1587 add text to explain per-build branch parameters
1588 * NEWS: mention --umask
1590 2006-02-08 Brian Warner <warner@lothar.com>
1592 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1594 (SlaveOptions.optParameters): add --umask, to make it possible to
1595 make buildslave-generated files (including build products) be
1598 * buildbot/slave/bot.py (BuildSlave.startService): same
1600 2006-01-23 Brian Warner <warner@lothar.com>
1602 * buildbot/status/builder.py: urllib.quote() all URLs that include
1603 Builder names, so that builders can include characters like '/'
1604 and ' ' without completely breaking the resulting HTML. Thanks to
1605 Kevin Turner for the patch.
1606 * buildbot/status/html.py: same
1607 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1609 * NEWS: update in preparation for upcoming release
1611 2006-01-18 Brian Warner <warner@lothar.com>
1613 * docs/examples/twisted_master.cfg: update to match the Twisted
1614 buildbot: remove python2.2, switch to exarkun's buildslaves,
1615 disable the .deb builder until we figure out how to build twisted
1616 .debs from SVN, add some ktrace debugging to the OS-X build
1617 process and remove the qt build, remove threadless builders,
1618 change freebsd builder to use landonf's buildslave.
1620 2006-01-12 Brian Warner <warner@lothar.com>
1622 * buildbot/master.py (Manhole.__init__): let port= be a strports
1623 specification string, but handle a regular int for backwards
1624 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1625 used in master.cfg to limit connections to just the local host.
1626 (BuildMaster.loadConfig): same for c['slavePortnum']
1627 * buildbot/scheduler.py (Try_Userpass.__init__): same
1628 * buildbot/status/client.py (PBListener.__init__): same
1629 * buildbot/status/html.py (Waterfall.__init__): same, for both
1630 http_port and distrib_port. Include backwards-compatibility checks
1631 so distrib_port can be a filename string and still mean unix:/foo
1632 * docs/buildbot.texinfo (Setting the slaveport): document it
1633 (Debug options): same
1634 (HTML Waterfall): same
1637 * buildbot/test/test_config.py (ConfigTest): test it
1639 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1640 slaveport's disownServiceParent deferred to fire before opening
1641 the new one. Fixes an annoying bug in the unit tests.
1643 2006-01-03 Brian Warner <warner@lothar.com>
1645 * buildbot/master.py (BuildMaster): remove the .schedulers
1646 attribute, replacing it with an allSchedulers() method that looks
1647 for all IService children that implement IScheduler. Having only
1648 one parent/child relationship means fewer opportunities for bugs.
1649 (BuildMaster.allSchedulers): new method
1650 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1651 also fix ugly bug that caused any config-file reload to
1652 half-forget about the earlier Schedulers, causing an exception
1653 when a Change arrived and was handed to a half-connected
1654 Scheduler. The exception was in scheduler.py line 54ish:
1655 self.parent.submitBuildSet(bs)
1656 exceptions.AttributeError: 'NoneType' object has no attribute
1658 (BuildMaster.addChange): update to use allSchedulers()
1660 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1661 to work properly with twisted-1.3.0, where you must explicitly
1662 include the __implements__ from parent classes
1663 (BaseScheduler.__repr__): make it easier to distinguish distinct
1665 (BaseUpstreamScheduler.__implements__): same
1667 * buildbot/status/builder.py (Status.getSchedulers): update to
1669 * buildbot/test/test_run.py (Run.testMaster): same
1670 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1671 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1672 make sure Scheduler instances are left alone when an identical
1673 config file is reloaded
1674 (ConfigElements.testSchedulers): make sure Schedulers are properly
1677 * Makefile (TRIALARGS): my local default Twisted version is now
1678 2.1.0, update the trial arguments accordingly
1680 2005-12-22 Brian Warner <warner@lothar.com>
1682 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1685 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1686 addChange in the parent class, although I suspect this should be
1687 fixed better in the future.
1689 2005-11-26 Brian Warner <warner@lothar.com>
1691 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1692 explode when branch==None, thanks to Kevin Turner for the catch
1693 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1696 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1698 * docs/buildbot.texinfo: same
1700 2005-11-26 Brian Warner <warner@lothar.com>
1702 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1703 * docs/buildbot.texinfo: set version number to match
1705 2005-11-26 Brian Warner <warner@lothar.com>
1707 * NEWS: update for 0.7.1
1709 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1710 sure that unsubscribe works even if we never sent an ETA update.
1711 Also, don't explode on duplicate unsubscribe.
1712 (BuildStepStatus.addLog): make the convenience "return self"-added
1713 watcher automatically unsubscribe when the Step finishes.
1714 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1715 (BuildStatus.stepStarted): same auto-unsubscribe
1716 (BuilderStatus.buildStarted): same auto-unsubscribe
1718 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1720 (IStatusReceiver.stepStarted): same
1721 (IStatusReceiver.logStarted): same
1723 * buildbot/test/test_run.py (Status): move the Status test..
1724 * buildbot/test/test_status.py (Subscription): .. to here
1726 2005-11-25 Brian Warner <warner@lothar.com>
1728 * NEWS: more updates
1730 * buildbot/locks.py: fix the problem in which loading a master.cfg
1731 file that changes some Builders (but not all of them) can result
1732 in having multiple copies of the same Lock. Now, the real Locks
1733 are kept in a table inside the BotMaster, and the Builders/Steps
1734 use "LockIDs", which are still instances of MasterLock and
1735 SlaveLock. The real Locks are instances of the new RealMasterLock
1736 and RealSlaveLock classes.
1737 * buildbot/master.py (BotMaster.getLockByID): new method to
1738 convert LockIDs into real Locks.
1739 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1740 into real Locks before building
1741 * buildbot/process/step.py (BuildStep.startStep): same
1742 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1743 exercises the problem
1746 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1747 what Schedulers are available
1749 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1750 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1751 'cron'-style build scheduling at certain times of day, week,
1753 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1755 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1756 handling: treat self.fileIsImportant more as an attribute that
1757 contains a callable than as a method. If the attribute is None,
1758 don't call it and assume all filenames are important. It is still
1759 possible to provide a fileIsImportant method in a subclass,
1761 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1763 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1764 test using AnyBranchScheduler with fileIsImportant=None
1766 2005-11-24 Brian Warner <warner@lothar.com>
1768 * buildbot/test/test_config.py (StartService): don't claim a fixed
1769 port number, instead set slavePort=0 on the first pass, figure out
1770 what port was allocated, then switch to a config file that uses
1773 * buildbot/master.py (BuildMaster.loadConfig): close the old
1774 slaveport before opening the new one, because unit tests might
1775 replace slavePort=0 with the same allocated portnumber, and if we
1776 don't wait for the old port to close first, we get a "port already
1777 in use" error. There is a tiny race condition here, but the only
1778 threat is from other programs that bind (statically) to the same
1779 port number we happened to be allocated, and only if those
1780 programs use SO_REUSEADDR, and only if they get control in between
1783 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1785 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1786 deleted ChangeSources before adding any new ones
1787 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1788 compare_attrs, to make sure that a config-file reload does not
1789 unnecessarily replace an unmodified ChangeSource instance
1790 * buildbot/test/test_config.py (ConfigTest.testSources): update
1792 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1793 mean "don't build anything", and add a warning if it gets used
1794 because it isn't actually useful.
1796 * contrib/svn_buildbot.py: update example usage to match the port
1797 number that gets used by the PBChangeSource
1798 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1800 2005-11-22 Brian Warner <warner@lothar.com>
1802 * NEWS: start collecting items for next release
1804 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1805 revisions are strings
1806 (P4Sync.computeSourceRevision): same
1808 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1809 to the Buildbot's overall status page
1810 (StatusResourceBuilder.body): same
1812 2005-11-15 Brian Warner <warner@lothar.com>
1814 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1815 config-file loading, specifically to make sure old StatusTargets
1816 are finished shutting down before new ones start up (thus
1817 resolving a bug in which changing the Waterfall object would fail
1818 because both new and old instances were claiming the same
1819 listening port). Also load new Schedulers after all the new
1820 Builders are set up, in case they fire off a new build right away.
1821 * buildbot/test/test_config.py (StartService): test it
1823 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1824 the branch name to the mail body
1826 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1827 Without it, a config-file reload fails to update an existing
1829 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1830 username/passwd to compare_attrs, for the same reason
1831 * buildbot/status/html.py (Waterfall): add favicon to
1832 compare_attrs, same reason
1834 2005-11-05 Brian Warner <warner@lothar.com>
1836 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1837 baserev before stuffing it in the jobfile. This resolves problems
1838 under SVN (and probably Arch) where revisions are expressed as
1839 numbers. I'm inclined to use string-based revisions everywhere in
1840 the future, but this fix should be safe for now. Thanks to Steven
1841 Walter for the patch.
1843 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1844 binary mode when opening pickle files, to make windows work
1845 better. Thanks to Dobes Vandermeer for the catch.
1846 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1847 (BuilderStatus.getBuildByNumber): same
1848 (Status.builderAdded): same
1849 * buildbot/master.py (BuildMaster.loadChanges): same
1851 * buildbot/util.py (Swappable): delete unused leftover code
1853 * buildbot/process/step.py (SVN): when building on a non-default
1854 branch, add the word "[branch]" to the VC step's description, so
1855 it is obvious that we're not building the usual stuff. Likewise,
1856 when we are building a specific revision, add the text "rNNN" to
1857 indicate what that revision number is. Thanks to Brad Hards and
1858 Nathaniel Smith for the suggestion.
1859 (Darcs.startVC): same
1860 (Arch.startVC): same
1861 (Bazaar.startVC): same
1863 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1864 typo, caught by Mark Dillavou, closes SF#1216636.
1866 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1867 about a test to add some day
1869 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1870 the 'full-2.3' build, and the 'reactors' build is now run under
1871 python-2.4 because the buildslave no longer has gtk/etc bindings
1872 for earlier versions.
1874 2005-11-03 Brian Warner <warner@lothar.com>
1876 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1877 method, takes an IBuildStatus and rebuilds it. It might make more
1878 sense to add this to IBuildControl instead, but that instance goes
1879 away completely once the build has finished, and resubmitting
1880 builds can take place weeks later.
1881 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1882 * buildbot/status/html.py (StatusResourceBuild): also stash an
1883 IBuilderControl so we can use resubmitBuild.
1884 (StatusResourceBuild.body): render "resubmit" button if we can.
1885 Also add hrefs for each BuildStep
1886 (StatusResourceBuild.rebuild): add action for "resubmit" button
1887 (StatusResourceBuilder.getChild): give it an IBuilderControl
1889 * buildbot/status/builder.py (Status.getURLForThing): change the
1890 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1891 that live as targets of buttons like "stop" and "rebuild" can't
1893 * buildbot/status/builder.py (Status.getURLForThing): same
1894 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1895 (StepBox.getBox): same
1896 * buildbot/test/test_web.py (GetURL): same
1899 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1900 exclusivity checks after Source.__init__ upcall, so misspelled
1901 arguments will be reported more usefully
1902 (Darcs.__init__): same
1904 2005-10-29 Brian Warner <warner@lothar.com>
1906 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1907 builder. Move the Try scheduler off to a separate port.
1909 2005-10-27 Brian Warner <warner@lothar.com>
1911 * buildbot/clients/gtkPanes.py
1912 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1913 to cause the app to crash, now they don't.
1915 * buildbot/clients/debug.py: display the buildmaster's location
1916 in the window's title bar
1918 2005-10-26 Brian Warner <warner@lothar.com>
1920 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1921 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1922 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1924 * buildbot/status/html.py (td): put a single non-breaking space
1925 inside otherwise empty <td> elements, as a workaround for buggy
1926 browsers which would optimize them away (along with any associated
1927 styles, like the kind that create the waterfall grid borders).
1928 Patch from Frerich Raabe.
1930 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1931 argv-list as an argument, defaulting to ["-to"], which is
1932 appropriate for the Trial that comes with Twisted-2.1.0 and
1933 earlier. The Trial in current Twisted SVN wants
1934 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1935 defaults to an empty list.
1936 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1937 match it, now that trialMode= is a list instead of a single string
1939 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1941 * docs/buildbot.texinfo: same
1943 2005-10-24 Brian Warner <warner@lothar.com>
1945 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1946 * docs/buildbot.texinfo: set version number to match
1948 2005-10-24 Brian Warner <warner@lothar.com>
1950 * README: update for 0.7.0
1952 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1954 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1955 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1956 send the branch= argument unless the user really provided one, to
1957 retain compatibility with older buildmasters that don't accept
1959 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1962 * docs/buildbot.texinfo: update lots of stuff
1964 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1965 to the 'buildbot sendchange' command
1966 * buildbot/clients/sendchange.py (Sender.send): same
1967 * buildbot/changes/pb.py (ChangePerspective): same
1968 * buildbot/test/test_changes.py (Sender.testSender): test it
1970 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1971 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1972 for consistency with other BuildStep arguments that use camelCase.
1973 Well, at least more of them use camelCase (like flunkOnWarnings)
1974 than don't.. I wish I'd picked one style and stuck with it
1975 earlier. Annoying, but it's best done before the release, since
1976 these arguments didn't exist at all in 0.6.6 .
1978 * buildbot/test/test_vc.py (SVN.testCheckout): same
1979 (Darcs.testPatch): same
1980 * docs/buildbot.texinfo (SVN): document the change
1981 (Darcs): same, add some build-on-branch docs
1982 * docs/examples/twisted_master.cfg: match change
1984 * buildbot/process/step.py (BuildStep): rename
1985 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1986 how it is normally used.
1987 * buildbot/test/test_steps.py (Version.checkCompare): same
1989 * buildbot/process/step.py (CVS.startVC): refuse to build
1990 update/copy -style builds on a non-default branch with an old
1991 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1992 concern is that it will do a VC 'update' in an existing tree when
1993 it is supposed to be switching branches (and therefore clobbering
1994 the tree to do a full checkout), thus building the wrong source.
1995 This used to be a warning, but I think the confusion it is likely
1996 to cause warrants making it an error.
1997 (SVN.startVC): same, also make mode=export on old slaves an error
1998 (Darcs.startVC): same
1999 (Git.startVC): improve error message for non-Git-enabled slaves
2000 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2001 specific revision is built on a slave that doesn't pay attention
2002 to args['revision'], because for slowly-changing trees it will
2003 probably do the right thing, and because we have no way to tell
2004 whether we're asking it to build the most recent version or not.
2005 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2007 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2008 that 'master' is in host:portnum format, to catch errors sooner
2010 2005-10-23 Brian Warner <warner@lothar.com>
2012 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2013 when creating the list of warning messages, include the line
2014 immediately after each WARNING: line, since that's usually where
2015 the file and line number wind up.
2017 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2022 2005-10-22 Brian Warner <warner@lothar.com>
2024 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2025 patch from Brad Hards
2026 * buildbot/status/classic.css: same
2027 * buildbot/test/test_web.py (Waterfall): match changes
2029 * buildbot/test/test_steps.py (BuildStep.setUp): set
2030 nextBuildNumber so the test passes
2031 * buildbot/test/test_status.py (MyBuilder): same
2033 * buildbot/status/html.py (StatusResourceBuild.body): revision
2034 might be numeric, so stringify it before html-escapifying it
2035 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2036 timer for the upcoming build
2037 * buildbot/status/classic.css: add background-color attributes for
2038 offline/waiting/building classes
2040 * buildbot/status/builder.py (BuildStatus): derive from
2041 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2042 the default (i.e. unknown) .slavename to "???" instead of None,
2043 since even unknown slavenames need to be printed eventually.
2044 (BuilderStatus): also derive from styles.Versioned . More
2045 importantly, determine .nextBuildNumber at creation/unpickling
2046 time by scanning the directory of saved BuildStatus instances and
2047 choosing one larger than the highest-numbered one found. This
2048 should fix the problem where random errors during upgrades cause
2049 the buildbot to forget about earlier builds. .nextBuildNumber is
2050 no longer stored in the pickle.
2051 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2052 at least log the error. Also call Builder.determineNextBuildNumber
2053 once the basedir is set.
2055 * buildbot/master.py (BuildMaster.loadChanges): do
2056 styles.doUpgrade afterwards, in case I decide to make Changes
2057 derived from styles.Versioned some day and forget to make this
2061 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2062 when running under older pythons (<2.3) in which the shlex module
2063 doesn't have a 'split' function.
2065 * buildbot/process/step.py (ShellCommand.start): make
2066 errorMessages= be a list of strings to stuff in the log before the
2067 command actually starts. This makes it easier to flag multiple
2068 warning messages, e.g. when the Source steps have to deal with an
2070 (CVS.startVC): handle slaves that don't handle multiple branches
2071 by switching into 'clobber' mode
2072 (SVN.startVC): same. Also reject branches without base_url
2073 (Darcs.startVC): same. Also reject revision= in older slaves
2074 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2075 (Bazaar.startVC): same, and test for baz separately than for arch
2077 * buildbot/slave/commands.py (cvs_ver): document new features
2079 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2080 (BuildStep.slaveVersionNewEnough): more useful utility method
2081 * buildbot/test/test_steps.py (Version): start testing it
2083 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2084 the 'force' command requires python2.3, for the shlex.split method
2086 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2087 since we don't use it anymore. The Twisted buildbot uses a
2090 2005-10-21 Brian Warner <warner@lothar.com>
2092 * buildbot/process/process_twisted.py: rework all BuildFactory
2093 classes to take a 'source' step as an argument, instead of
2094 building up the SVN instance in the factory.
2095 * docs/examples/twisted_master.cfg: enable build-on-branch by
2096 providing a base_url and default_branch
2098 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2099 control over --branch and --revision, not that they are always
2101 * buildbot/status/html.py (StatusResourceBuilder.force): same
2102 (StatusResourceBuild.body): display SourceStamp components
2104 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2105 IRC 'force' command, so it can be shared with an eventual
2106 command-line-tool 'buildbot force' mode.
2107 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2109 2005-10-20 Brian Warner <warner@lothar.com>
2111 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2113 * docs/examples/twisted_master.cfg: update to use Schedulers
2115 * buildbot/scripts/sample.cfg: update with Schedulers
2117 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2118 method specifically for use by HTML "force build" button and the
2119 IRC "force" command. Raises an immediate error if there are no
2121 (IBuilderControl.requestBuild): make this just submit a build, not
2122 try to check for existing slaves or set up any when-finished
2123 Deferreds or anything.
2124 * buildbot/process/builder.py (BuilderControl): same
2125 * buildbot/status/html.py (StatusResourceBuilder.force): same
2126 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2127 * buildbot/test/test_slaves.py: same
2128 * buildbot/test/test_web.py: same
2130 2005-10-19 Brian Warner <warner@lothar.com>
2132 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2133 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2135 2005-10-18 Brian Warner <warner@lothar.com>
2137 * buildbot/status/html.py: provide 'status' argument to most
2138 StatusResourceFOO objects
2139 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2140 and Logfiles" section to make the Build page into a more-or-less
2141 comprehensive source of status information about the build
2143 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2144 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2146 2005-10-17 Brian Warner <warner@lothar.com>
2148 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2149 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2150 out what to do about other projects: the correct options for
2151 recent Twisteds will not work for older ones.
2153 2005-10-15 Brian Warner <warner@lothar.com>
2155 * buildbot/status/builder.py (Status.getURLForThing): add method
2156 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2157 use this in email/IRC status clients to make them more useful, by
2158 providing the end user with hints on where to learn more about the
2159 object being reported on.
2160 * buildbot/test/test_web.py (GetURL): tests for it
2162 2005-10-14 Brian Warner <warner@lothar.com>
2164 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2165 fix bug resulting from deferredResult changes
2167 2005-10-13 Brian Warner <warner@lothar.com>
2169 * buildbot/test/test_changes.py: remove use of deferredResult
2170 * buildbot/test/test_config.py: same
2171 * buildbot/test/test_control.py: same
2172 * buildbot/test/test_status.py: same
2173 * buildbot/test/test_vc.py: this is the only remaining use, since
2174 it gets used at module level. This needs to be replaced by some
2175 sort of class-level run-once routine.
2177 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2179 * lots: implement multiple slaves per Builder, which means multiple
2180 current builds per Builder. Some highlights:
2181 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2182 of (state,currentBuilds) instead of (state,currentBuild)
2183 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2184 (IBuildStatus.getSlavename): new method, so you can tell which
2185 slave got used. This only gets set when the build completes.
2186 (IBuildRequestStatus.getBuilds): new method
2188 * buildbot/process/builder.py (SlaveBuilder): add a .state
2189 attribute to track things like ATTACHING and IDLE and BUILDING,
2191 (Builder): .. the .slaves attribute here, which has been turned
2192 into a simple list of available slaves. Added a separate
2193 attaching_slaves list to track ones that are not yet ready for
2195 (Builder.fireTestEvent): put off the test-event callback for a
2196 reactor turn, to make tests a bit more consistent.
2197 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2198 ping fails due to an exception. This needs work, I'm worried that
2199 a code error could lead to a constantly re-connecting slave.
2200 Especially since I'm trying to move to a distinct remote_ping
2201 method, separate from the remote_print that we currently use.
2202 (BuilderControl.requestBuild): return a convenience Deferred that
2203 provides an IBuildStatus when the build finishes.
2204 (BuilderControl.ping): ping all connected slaves, only return True
2205 if they all respond.
2207 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2208 reconnect when we shut down.
2210 * buildbot/status/builder.py: implement new methods, convert
2211 one-build-at-a-time methods to handle multiple builds
2212 * buildbot/status/*.py: do the same in all default status targets
2213 * buildbot/status/html.py: report the build's slavename in the
2214 per-Build page, report all buildslaves on the per-Builder page
2216 * buildbot/test/test_run.py: update/create tests
2217 * buildbot/test/test_slaves.py: same
2218 * buildbot/test/test_scheduler.py: remove stale test
2220 * docs/buildbot.texinfo: document the new builder-specification
2221 'slavenames' parameter
2223 2005-10-12 Brian Warner <warner@lothar.com>
2225 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2226 report failure correctly, causing Dependent builds to run when
2227 they shouldn't have.
2228 * buildbot/status/builder.py (BuildSetStatus): same
2229 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2230 (Set.testSuccess): test the both-pass case too
2231 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2232 fix this test: it was ending too early, masking the failure before
2233 (Logger): specialized StatusReceiver to make sure the dependent
2234 builds aren't even started, much less completed.
2236 2005-10-07 Brian Warner <warner@lothar.com>
2238 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2239 bot.SlaveBuilder being disowned in the middle of a build
2241 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2242 this inherit from StatusReceiver. Also upcall in __init__. This
2243 fixes the embarrasing crash when the new buildSetSubmitted method
2244 is invoked and Waterfall/etc don't implement their own.
2245 * buildbot/test/test_run.py: add a TODO note about a test to catch
2246 just this sort of thing.
2248 * buildbot/process/builder.py (Builder.attached): remove the
2249 already-attached warning, this situation is normal. Add some
2250 comments explaining it.
2252 2005-10-02 Brian Warner <warner@lothar.com>
2254 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2255 OverflowError when setting up dnotify, because some 64-bit systems
2256 have problems with signed-vs-unsigned constants and trip up on the
2257 DN_MULTISHOT flag. Patch from Brad Hards.
2259 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2261 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2262 progressMetrics, description, descriptionDone to the 'parms' list,
2263 and make use the 'parms' list from the implementation class
2264 instead of only BuildStep to initialize the parameters. This
2265 allows buildbot.process.factory.s() to initialize all the parms,
2266 not just those defined in directly by BuildStep.
2268 2005-09-03 Brian Warner <warner@lothar.com>
2270 * NEWS: start adding items for the next release
2272 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2273 python2.2 tests, change 'Quick' builder to only use python2.3
2275 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2277 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2278 the "Ping Builder" button if the build control is available; the
2279 user sees an exception otherwise
2281 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2283 2005-09-01 Brian Warner <warner@lothar.com>
2285 * buildbot/interfaces.py (IBuilderStatus.getState): update
2286 signature, point out that 'build' can be None
2287 (IBuildStatus.getETA): point out ETA can be none
2289 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2291 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2293 2005-08-31 Brian Warner <warner@lothar.com>
2295 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2296 update to match correct signature: removed 'eta' argument
2297 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2299 2005-08-30 Brian Warner <warner@lothar.com>
2301 * buildbot/status/builder.py (LogFile): remove the assertion that
2302 blows up when you try to overwrite an existing logfile, instead
2303 just emit a warning. This case gets hit when the buildmaster is
2304 killed and doesn't get a chance to write out the serialized
2305 BuilderStatus object, so the .nextBuildNumber attribute gets out
2308 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2309 the 'buildbot sendchange' arguments, for the Darcs context file
2310 * docs/buildbot.texinfo (sendchange): document it
2312 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2313 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2314 (IStatus.getSchedulers): new method
2315 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2316 (Status.getSchedulers): implement
2317 * buildbot/process/builder.py (Builder): maintain
2318 BuilderStatus.pendingBuilds
2319 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2320 (TryBase.addChange): Try schedulers should ignore Changes
2322 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2323 for 'try' on CVS/SVN
2324 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2326 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2327 report status properly.
2328 (Try.createJob): implement unique buildset IDs
2330 * buildbot/status/client.py (StatusClientPerspective): add a
2331 perspective_getBuildSets method for the benefit of jobdir-style
2333 * docs/buildbot.texinfo (try): more docs
2334 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2337 2005-08-18 Brian Warner <warner@lothar.com>
2339 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2340 actually work. It's functional but still kind of clunky. Also, it
2341 only works with the pb-style.. needs to be made to work with the
2344 * buildbot/status/client.py (RemoteBuildSet): new class
2345 (RemoteBuildRequest): same
2346 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2347 object, not the internal BuildStatus object.
2348 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2349 outside of the usual buildStarted() return value.
2350 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2352 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2353 (Try_Userpass_Perspective.perspective_try): return a remotely
2354 usable BuildSetStatus object
2356 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2357 isStarted()/waitUntilStarted()
2359 2005-08-16 Brian Warner <warner@lothar.com>
2361 * buildbot/status/builder.py: implement IBuildSetStatus and
2362 IBuildRequestStatus, wire them into place.
2363 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2364 methods into the BuildSetStatus object.
2365 * buildbot/interfaces.py: same
2366 (IStatus.getBuildSets): new method to get pending BuildSets
2367 (IStatusReceiver.buildsetSubmitted): new method which hears about
2369 * buildbot/master.py (BuildMaster.submitBuildSet): same
2370 * buildbot/process/base.py (BuildRequest): same, replace
2371 waitUntilStarted with subscribe/unsubscribe
2372 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2373 subscribe instead of waitUntilStarted
2374 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2376 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2378 * buildbot/test/test_buildreq.py: update for new code
2379 * buildbot/test/test_control.py (Force.testRequest): same
2382 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2383 for Darcs to not use the tempfile module, so it works under
2384 python-2.2 too. We really didn't need the full cleverness of that
2385 module, since the slave has exclusive control of its own builddir.
2387 2005-08-15 Brian Warner <warner@lothar.com>
2389 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2390 for CVS trees. It doesn't work for non-trunk branches,
2392 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2395 * Makefile: make it easier to test against python2.2
2397 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2398 tearDown2, so things like Arch can unregister archives as they're
2399 shutting down. The previous subclass-override-tearDown technique
2400 resulted in a nested maybeWait() and test failures under
2403 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2404 where we can (Arch), add a branch= argument to set the branch used
2406 (BazExtractor): extract the branch too
2407 (TlaExtractor): same
2408 * buildbot/scripts/runner.py (TryOptions): add --branch
2409 * docs/buildbot.texinfo (try): document --branch/try_branch
2411 * buildbot/slave/commands.py (Darcs): implement get-revision for
2412 Darcs, so that 'try' will work. This requires the tempfile module
2415 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2416 of revisions, branches, and 'try' in the process.
2418 2005-08-11 Brian Warner <warner@lothar.com>
2420 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2421 this, it got broken at some point in the last few releases
2422 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2423 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2424 specifically the removal of ETA information from the tuple
2426 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2429 * docs/buildbot.texinfo (try): document both --builder and
2430 'try_builders' in .buildbot/options
2431 * buildbot/scripts/runner.py (TryOptions): add --builder,
2432 accumulate the values into opts['builders']
2433 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2434 * buildbot/test/test_runner.py (Try): add some quick tests to make
2435 sure 'buildbot try --options' and .buildbot/options get parsed
2436 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2437 use --builder control
2439 * docs/buildbot.texinfo (try): add --port argument to PB style
2441 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2442 actual SourceStamp. Still need to extract a branch name, somehow.
2443 (Try): finish implementing the try client side, still need a UI
2444 for specifying which builders to use
2445 (Try.getopt): factor our options/config-file reading
2446 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2448 * buildbot/test/test_vc.py: match SourceStampExtractor change
2450 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2451 causes the twisted log to be sent to stderr
2453 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2455 2005-08-10 Brian Warner <warner@lothar.com>
2457 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2458 style is 90% done, still missing status reporting or waiting for
2459 the buildsets to finish, and it is completely untested.
2461 * buildbot/trybuild.py: delete file, move contents to ..
2462 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2463 * buildbot/test/test_vc.py: match the move
2465 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2466 of the TryScheduler, no buildsetID or status-tracking support yet
2467 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2469 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2470 possible to set the basedir after __init__ time, so it is easier
2471 to use as a Service-child of the BuildMaster instance
2473 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2474 that delivers messages to its Service parent instead of requiring
2475 a subclass to be useful. This turns out to be much easier to build
2478 * buildbot/scripts/tryclient.py (createJob): utility code to
2479 create jobfiles, will eventually be used by 'buildbot try'
2481 2005-08-08 Brian Warner <warner@lothar.com>
2483 * docs/buildbot.texinfo (try): add docs on the
2484 as-yet-unimplemented Try scheduler
2486 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2487 * buildbot/test/test_scheduler.py: .. here
2488 (Scheduling.testTryJobdir): add placeholder test for 'try'
2490 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2491 addEntry merging (>=chunkSize) behavior
2492 (Log.testConsumer): update to handle new callLater(0) behavior
2494 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2495 both the MAX_LENGTH bugfix and the resumeProducing hang.
2497 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2498 put off the actual resumeProducing for a moment with
2499 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2500 causes large logfiles to hang midway through.
2502 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2503 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2504 and to improve memory usage when streaming the file out to a web
2506 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2507 make this work cleanly
2509 2005-08-03 Brian Warner <warner@lothar.com>
2511 * buildbot/trybuild.py: new file for 'try' utilities
2512 (getSourceStamp): run in a tree, find out the baserev+patch
2513 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2514 implemented for SVN and Darcs, still working on Arch. I don't know
2515 how to make CVS work yet.
2517 * docs/buildbot.texinfo: document the 'buildbot' command-line
2518 tool, including the not-yet-implemented 'try' feature, and the
2519 in-flux .buildbot/ options directory.
2521 2005-07-20 Brian Warner <warner@lothar.com>
2523 * buildbot/locks.py: added temporary id() numbers to Lock
2524 descriptions, to track down a not-really-sharing-the-Lock bug
2526 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2528 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2529 needed for python2.2 compatibility
2530 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2531 are from the __future__
2533 2005-07-19 Brian Warner <warner@lothar.com>
2535 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2536 message when schedulers use unknown builders
2538 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2539 SlaveLock('name') and MasterLock('name') are distinct
2541 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2542 c['schedulers'] in such a way that we can actually accept
2544 * buildbot/test/test_config.py: check it
2546 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2547 utility method to *all* the Schedulers
2548 (Periodic.listBuilderNames): same
2550 * docs/buildbot.texinfo (Interlocks): update chapter to match
2553 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2554 to make sure that c['sources'], c['schedulers'], and c['status']
2555 are all lists of the appropriate objects, and that the Schedulers
2556 all point to real Builders
2557 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2558 'listBuilderNames' utility method to support this
2559 * buildbot/scheduler.py: implement the utility method
2560 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2562 * docs/buildbot.texinfo: add some @cindex entries
2564 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2565 if it wasn't already set: most tla commands will fail unless one
2567 (Arch.createRepository): and disable bazaar's revision cache, since
2568 they cause test failures (the multiple repositories we create all
2569 interfere with each other through the cache)
2571 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2572 bring it properly up to date with twisted-2.0 test guidelines
2574 * buildbot/master.py (BuildMaster): remove references to old
2575 'interlock' module, this caused a bunch of post-merge test
2577 * buildbot/test/test_config.py: same
2578 * buildbot/process/base.py (Build): same
2580 * buildbot/test/test_slaves.py: stubs for new test case
2582 * buildbot/scheduler.py: add test-case-name tag
2583 * buildbot/test/test_buildreq.py: same
2585 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2586 unnecessary init code
2587 (Bot.remote_setBuilderList): match it
2589 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2591 * buildbot/changes/mail.py (parseSyncmail): update comment
2593 * buildbot/test/test_slavecommand.py: disable Shell tests on
2594 platforms that don't suport IReactorProcess
2596 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2597 all places where we open logfiles. It causes OS-X to open the file
2598 in some weird mode that that prevents us from mixing reads and
2599 writes to the same filehandle, which we depend upon to implement
2600 _generateChunks properly. This change doesn't appear to break
2601 win32, on which "b" and "t" are treated differently but a missing
2602 flag seems to be interpreted as "t".
2604 2005-07-18 Brian Warner <warner@lothar.com>
2606 * buildbot/slave/commands.py (ShellCommand): overhaul
2607 error-handling code, to try and make timeout/interrupt work
2608 properly, and make win32 happier
2609 * buildbot/test/test_slavecommand.py: clean up, stop using
2610 reactor.iterate, add tests for timeout and interrupt
2611 * buildbot/test/sleep.py: utility for a new timeout test
2613 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2614 code from the local-usebranches branch
2616 2005-07-17 Brian Warner <warner@lothar.com>
2618 * buildbot/process/process_twisted.py
2619 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2620 minutes, to match the other twisted BuildFactories, and don't
2621 excuse failures in c/qt/win32 reactors any more.
2623 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2624 'freebsd' builders, since the buildslaves have been unavailable
2627 2005-07-13 Brian Warner <warner@lothar.com>
2629 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2630 build-on-branch feature
2632 * buildbot/process/step.py (Darcs.__init__): add base_url and
2633 default_branch arguments, just like SVN
2634 (Arch.__init__): note that the version= argument is really the
2637 * buildbot/slave/commands.py (SourceBase): keep track of the
2638 repository+branch that was used for the last checkout in
2639 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2640 match, we clobber the directory and perform a fresh checkout
2641 rather than trying to do an in-place update. This should protect
2642 us against trying to get to branch B by doing an update in a tree
2643 obtained from branch A.
2644 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2645 (SVN.setup): same, just the svnurl
2646 (Darcs.setup): same, just the repourl
2647 (Arch.setup): same, arch coordinates (url), version, and
2648 buildconfig. Also pull the buildconfig from the args dictionary,
2649 which we weren't doing before, so the build-config was effectively
2651 (Arch.sourcedirIsUpdateable): don't try to update when we're
2652 moving to a specific revision: arch can't go backwards, so it is
2653 safer to just clobber the tree and checkout a new one at the
2655 (Bazaar.setup): same sourcedata as Arch
2657 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2658 use maybeWait, to work with twisted-1.3.0 and twcompat
2659 (Dependencies.testRun_Pass): same
2661 * buildbot/test/test_vc.py: rearrange, cleanup
2663 * buildbot/twcompat.py: add defer.waitForDeferred and
2664 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2665 can work under twisted-1.3.0 .
2667 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2668 now created at setUp time. This increases the runtime of the test
2669 suite considerably (from 91 seconds to 151), but it removes the
2670 need for an offline tarball, which should solve a problem I've
2671 seen where the test host has a different version of svn than the
2672 tarball build host. The new code also validates that mode=update
2673 really picks up recent commits. This approach will also make it
2674 easier to test out branches, because the code which creates the VC
2675 branches is next to the code which uses them. It will also make it
2676 possible to test some change-notification hooks, by actually
2677 performing a VC commit and watching to see the ChangeSource get
2680 2005-07-12 Brian Warner <warner@lothar.com>
2682 * docs/buildbot.texinfo (SVN): add branches example
2683 * docs/Makefile (buildbot.ps): add target for postscript manual
2685 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2686 * buildbot/test/test_locks.py: same
2688 * buildbot/process/step.py (Darcs): comment about default branches
2690 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2691 c['interlocks'] in the config file, complain if it is present.
2692 Scan all locks in c['builders'] to make sure the Locks they use
2694 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2695 add some tests to check for non-uniquely-named Locks
2696 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2697 since the unique-Lock validation code requires it now
2699 * buildbot/locks.py: fix test-case-name
2701 * buildbot/interlock.py: remove old file
2703 2005-07-11 Brian Warner <warner@lothar.com>
2705 * buildbot/test/test_interlock.py: rename to..
2706 * buildbot/test/test_locks.py: .. something shorter
2708 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2709 versions (after 2.0.1) changed internet.TCPClient to shut down the
2710 connection in stopService. Change the code to handle this
2713 * buildbot/process/base.py (Build): handle whole-Build locks
2714 * buildbot/process/builder.py (Builder.compareToSetup): same
2715 * buildbot/test/test_interlock.py: make tests work
2717 * buildbot/process/step.py (BuildStep.startStep): complain if a
2718 Step tries to claim a lock that's owned by its own Build
2719 (BuildStep.releaseLocks): typo
2721 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2722 file reloads don't replace unchanged Builders
2724 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2725 rewrite to cover new Locks instead of old c['interlocks']
2726 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2730 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2731 start the master and connect the buildslave
2733 * buildbot/process/step.py (FailingDummy.done): finish with a
2734 FAILURE status rather than raising an exception
2736 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2737 stringify a BuildRequest.reason that is None
2739 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2741 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2742 allow scheduler.Dependent to work
2743 * buildbot/buildset.py (BuildSet): set .reason and .results
2745 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2746 slaves, to make the test stop hanging. It still fails, of course,
2747 because I haven't even started to implement Locks.
2749 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2751 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2752 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2753 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2754 (Dependent): new class for downstream build dependencies
2755 * buildbot/test/test_dependencies.py: tests (still failing)
2757 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2759 2005-07-07 Brian Warner <warner@lothar.com>
2761 * buildbot/test/runutils.py (RunMixin): factored this class out..
2762 * buildbot/test/test_run.py: .. from here
2763 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2764 added new buildbot.locks tests (which all hang right now)
2765 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2766 * buildbot/process/step.py: claim/release per-BuildStep locks
2768 * docs/Makefile: add 'buildbot.html' target
2770 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2771 interpreted as "HEAD", so that all VC steps can accept branch=None
2772 and have it mean the "default branch".
2774 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2776 2005-07-07 Brian Warner <warner@lothar.com>
2778 * docs/examples/twisted_master.cfg: update to match current usage
2780 * docs/buildbot.texinfo (System Architecture): comment out the
2781 image, it doesn't exist yet and just screws up the HTML manual.
2783 2005-07-05 Brian Warner <warner@lothar.com>
2785 * debian/.cvsignore: oops, missed one. Removing leftover file.
2787 2005-06-17 Brian Warner <warner@lothar.com>
2789 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2790 changed its output in 1.2.0, don't mistakenly think that the
2791 subversion we find isn't capable of supporting our tests.
2793 * debian/*: remove the debian/ directory and its contents, to make
2794 life easier for the proper Debian maintainer
2796 * Makefile (release): same
2798 2005-06-07 Brian Warner <warner@lothar.com>
2800 * everything: create a distinct SourceStamp class to replace the
2801 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2802 Changed the signature of Source.startVC to include the revision
2803 information (instead of passing it through self.args). Implement
2804 branches for SVN (now only Darcs/Git is missing support). Add more
2807 2005-06-06 Brian Warner <warner@lothar.com>
2809 * everything: rearrange build scheduling. Create a new Scheduler
2810 object (configured in c['schedulers'], which submit BuildSets to a
2811 set of Builders. Builders can now use multiple slaves. Builds can
2812 be run on alternate branches, either requested manually or driven
2813 by changes. This changed some of the Status classes. Interlocks
2814 are out of service until they've been properly split into Locks
2815 and Dependencies. treeStableTimer, isFileImportant, and
2816 periodicBuild have all been moved from the Builder to the
2818 (BuilderStatus.currentBigState): removed the 'waiting' and
2819 'interlocked' states, removed the 'ETA' argument.
2821 2005-05-24 Brian Warner <warner@lothar.com>
2823 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2824 erroneously abandons the connection (in clientConnectionFailed)
2825 for non-UserErrors, which means that if we lose the connection due
2826 to a network problem or a timeout, we'll never try to reconnect.
2827 Fix this by not upcalling to the buggy parent method. Note:
2828 twisted-2.0 fixes this, but the function only has 3 lines so it
2829 makes more sense to copy it than to try and detect the buggyness
2830 of the parent class. Fixes SF#1207588.
2832 * buildbot/changes/changes.py (Change.branch): doh! Add a
2833 class-level attribute to accomodate old Change instances that were
2834 pickled before 0.6.5 (where .branch was added for new Changes).
2835 This fixes the exception that occurs when you try to look at an
2836 old Change (through asHTML).
2838 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2841 2005-05-23 Brian Warner <warner@lothar.com>
2843 * buildbot/__init__.py (version): release 0.6.6
2845 2005-05-23 Brian Warner <warner@lothar.com>
2847 * NEWS: update for 0.6.6 release
2848 * debian/changelog: same
2850 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2851 before starting: this was done by twistd back when we spawned it,
2852 now that we're importing the pieces and running them in the
2853 current process, we have to do it ourselves. This allows
2854 master.cfg to import files from the same directory without
2855 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2856 Stichele for the catch.
2857 (Options.opt_version): Add a --version command (actually, just make
2858 the existing --version command emit Buildbot's version too)
2860 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2861 fix to make this behave like other LogFiles, this time to handle
2862 existing LogFiles on disk. (add the missing .upgrade method)
2863 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2865 2005-05-21 Brian Warner <warner@lothar.com>
2867 * buildbot/test/test_runner.py (Create.testMaster): match the
2868 rawstring change in runner.py:masterTAC
2870 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2871 TwistedWords is installed
2872 * buildbot/test/test_status.py: same, with TwistedMail
2874 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2875 some old, deprecated, and removed config keys). This should enable
2876 you to use the base buildbot functionality with Twisted-2.0.0 when
2877 you don't also have TwistedWeb and TwistedWords installed
2879 2005-05-20 Brian Warner <warner@lothar.com>
2881 * buildbot/scripts/runner.py (run): call sendchange(), not
2882 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2883 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2884 (stop): don't wait for process to die when sending SIGHUP
2885 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2886 directory name gets interpreted, which you don't want
2889 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2892 2005-05-18 Brian Warner <warner@lothar.com>
2894 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2896 2005-05-18 Brian Warner <warner@lothar.com>
2898 * README: update for 0.6.5
2899 * debian/changelog: same
2901 * buildbot/changes/changes.py: rename tag= to branch=, since
2902 that's how we're using it, and my design for the upcoming "build a
2903 specific branch" feature wants it. also, tag= was too CVS-centric
2904 * buildbot/changes/mail.py (parseSyncmail): same
2905 * buildbot/process/base.py (Build.isBranchImportant): same
2906 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2907 * docs/buildbot.texinfo (Attributes of Changes): same
2909 * NEWS: update tag=, update for upcoming release
2911 2005-05-17 Brian Warner <warner@lothar.com>
2913 * buildbot/scripts/runner.py (stop): actually poll once per
2914 second, instead of re-killing the poor daemon once per second.
2915 Sleep briefly (0.1s) before the first poll, since there's a good
2916 chance we can avoid waiting the full second if the daemon shuts
2917 down quickly. Also remove the sys.exit() at the end.
2918 (start): remove the unneighborly sys.exit()
2920 * Makefile: improve permission-setting to not kick Arch so badly
2922 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2923 default --keepalive=600, since it doesn't hurt very much, and it's
2924 a hassle to discover that you need it.
2925 * buildbot/test/test_runner.py (Create.testSlave): test it
2927 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2928 IRC bot about EXCEPTION
2930 * buildbot/status/client.py (PBListener): upcall more correctly
2932 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2933 an exception mark the overall build with EXCEPTION, not SUCCESS
2935 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2937 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2938 * Makefile: update some release-related stuff
2940 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2941 gets called when there isn't actually an active process, just end
2942 the Command instead of blowing up. I don't know how it gets into
2943 this state, but the twisted win32 buildslave will sometimes hang,
2944 and when it shakes its head and comes back, it thinks it's still
2945 running a Command. The next build causes this command to be
2946 interrupted, but the lack of self.process.pid breaks the interrupt
2949 * NEWS: document changes since the last release
2951 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2952 look for Makefile.buildbot instead of a bare Makefile . The
2953 'buildbot start' does not install this file, so you have to
2954 manually copy it if you want to customize startup behavior.
2955 (createMaster): change 'buildbot master' command to create
2956 Makefile.sample instead of Makefile, to create master.cfg.sample
2957 instead of master.cfg (requiring you to copy it before the
2958 buildmaster can be started). Both sample files are kept up to
2959 date, i.e. they are overwritten if they have been changed. The
2960 'buildbot.tac' file is *not* overwritten, but if the new contents
2961 don't match the old, a 'buildbot.tac.new' file is created and the
2962 user is warned. This seems to be a much more sane way to handle
2963 startup files. Also, don't sys.exit(0) when done, so we can run
2964 unit tests against it.
2965 (createSlave): same. Don't overwrite the sample info/ files.
2966 * buildbot/scripts/sample.mk: remove. the contents were pulled
2967 into runner.py, since they need to match the behavior of start()
2971 * docs/buildbot.texinfo (Launching the daemons): document it
2972 * buildbot/test/test_runner.py (Create): test it
2974 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2975 version that can handle string-in-string tests, because otherwise
2976 python-2.2 fails the tests. It'd be tremendous if Trial's test
2977 took two strings under 2.2 too.
2979 * everything: fixed all deprecation warnings when running against
2980 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2981 few that come from Twisted itself). This involved putting most of
2982 the Twisted-version specific code in the new buildbot.twcompat
2983 module, and creating some abstract base classes in
2984 buildbot.changes.base and buildbot.status.base (which might be
2985 useful anyway). __implements__ is a nuisance and requires an ugly
2986 'if' clause everywhere.
2988 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2989 delay before finishing the test: it seems that smtp.sendmail
2990 doesn't hang up on the server, so we must wait a moment so it can
2991 hang up on us. This removes the trial warning about an unclean
2994 2005-05-16 Brian Warner <warner@lothar.com>
2996 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2997 tuple of (delay, repeats).
2998 * buildbot/test/test_vc.py (Retry): test it
2999 * docs/buildbot.texinfo (Source Checkout): document it
3000 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3001 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3002 doVCFull() are handled by re-trying the checkout (after a delay)
3003 some number of times.
3004 (ShellCommand._startCommand): make header lines easier to read
3006 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3008 (WebTest.test_logfile): make sure master gets shut down, silences
3009 some "unclean reactor" test errors
3011 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3012 reactor once after shutdown, something in certain versions of
3013 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3014 fails, svn-trunk is ok.
3016 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3017 second win32 error message
3019 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3020 validating the ETA, so the tests don't fail on slow systems
3022 2005-05-15 Brian Warner <warner@lothar.com>
3024 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3025 the new LogFile class, so upgrading works properly
3026 (LogFileProducer.resumeProducing): survive resumeProducing after
3027 we've exhausted the chunkGenerator
3029 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3031 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3032 (Log.testUpgrade): same
3034 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3035 Builds and logs with a cron job.
3037 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3038 of the old non-offline LogFile, added code to upgrade these to
3039 new-style contents-live-on-disk instances at load time (in a way
3040 that doesn't invalidate the old Build pickles, so upgrading to
3041 0.6.5 is not a one-way operation). Got rid of everything related
3043 (LogFile.__init__): create LogFiles with the parent step status,
3044 the log's name, and a builder-relative filename where it can keep
3045 the contents on disk.
3046 (LogFile.hasContents): new method, clients are advised to call it
3047 before getText or getChunks and friends. If it returns False, the
3048 log's contents have been deleted and getText() will raise an
3050 (LogFile.getChunks): made it a generator
3051 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3052 Consumer (except one that takes chunks instead of strings). This
3053 enables streaming of very large logfiles without storing the whole
3055 (BuildStatus.generateLogfileName): create names like
3056 12-log-compile-output, with a _0 suffix if required to be unique
3057 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3058 or earlier) logfiles into new-style ones
3059 (BuilderStatus): remove everything related to 'stub' builds. There
3060 is now only one build cache, and we don't strip logs from old
3062 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3063 since we no longer fight to keep it in the cache
3065 * buildbot/status/html.py (TextLog.render_GET): use a
3066 ChunkConsumer to stream the log entries efficiently.
3067 (ChunkConsumer): wrapper which consumes chunks and writes
3070 * buildbot/test/test_twisted.py (Parse.testParse): use a
3071 LogFile-like object instead of a real one
3073 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3074 (Log.testMerge3): validate more merge behavior
3075 (Log.testChunks): validate LogFile.getChunks
3076 (Log.testUpgrade): validate old-style LogFile upgrading
3077 (Log.testSubscribe): validate LogFile.subscribe
3078 (Log.testConsumer): validate LogFile.subscribeConsumer
3080 * buildbot/interfaces.py (IStatusLogStub): remove
3081 (IStatusLog.subscribeConsumer): new method
3082 (IStatusLog.hasContents): new method
3083 (IStatusLogConsumer): describes things passed to subscribeConsumer
3085 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3086 the log contents if it does not have any contents.
3087 (StatusResourceBuildStep.body): same
3088 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3090 2005-05-14 Brian Warner <warner@lothar.com>
3092 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3093 timeouts to try and make the windows metabuildslave not hang
3095 2005-05-13 Mike Taylor <bear@code-bear.com>
3097 * buildbot/slave/commands.py (rmdirRecursive): added a check
3098 to ensure the path passed into rmdirRecursive actually exists.
3099 On win32 a non-existant path would generate an exception.
3101 2005-05-13 Brian Warner <warner@lothar.com>
3103 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3104 shutil.rmtree which behaves correctly on windows in the face of
3105 files that you have to chmod before deleting. Thanks to Bear at
3106 the OSAF for the routine.
3107 (SourceBase.doClobber): use rmdirRecursive
3109 2005-05-12 Brian Warner <warner@lothar.com>
3111 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3112 method generate chunks instead of returning a big list. This
3113 allows the same method to be used for both old LogFile and new
3115 (OfflineLogFile.getText): use the generator
3116 (OfflineLogFile.subscribe): same
3117 * buildbot/status/html.py (TextLog.resumeProducing): same
3118 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3120 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3121 point out that OfflineLogFile does not currently work with
3122 html.Waterfall . Fixing this is high-priority.
3124 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3125 apparently windows defaults to using stdout
3127 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3128 better message on failure so I can figure out the win32 problem
3130 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3131 log messages to include more useful copies of the command being
3132 run, the argv array, and the child command's environment.
3133 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3135 2005-05-11 Brian Warner <warner@lothar.com>
3137 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3139 * Makefile: update the deb-snapshot version
3141 * docs/buildbot.texinfo: move all .xhtml docs into a new
3142 .texinfo-format document, adding a lot of material in the process.
3143 This is starting to look like a real user's manual. Removed all
3144 the Lore-related files: *.xhtml, *.css, template.tpl .
3145 * docs/Makefile: simple makefile to run 'makeinfo'
3146 * buildbot/scripts/sample.cfg: rearrange slightly
3147 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3149 2005-05-10 Brian Warner <warner@lothar.com>
3151 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3152 different name for the internal twistw module, handle it.
3154 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3155 * setup.py: .. and stop trying to install it
3157 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3158 'git'), the new linux kernel VC system (http://kernel.org/git/).
3159 Thanks to Brandon Philips for the patch.
3160 * buildbot/slave/commands.py (Git): same
3162 2005-05-06 Brian Warner <warner@lothar.com>
3164 * buildbot/status/builder.py (OfflineLogFile): replace the default
3165 LogFile with a form that appends its new contents to a disk file
3166 as they arrive. The complete log data is never kept in RAM. This
3167 is the first step towards handling very large (100MB+) logfiles
3168 without choking quite so badly. (The other half is
3169 producer/consumer on the HTML pages).
3170 (BuildStepStatus.addLog): use OfflineLogFile by default
3171 (BuildStatus.getLogfileName): helper code to give the
3172 OfflineLogFile a filename to work with
3174 * buildbot/test/test_status.py (Results.testAddResults): update
3175 tests to handle new asserts
3176 * buildbot/test/test_vc.py (Patch.doPatch): same
3177 * buildbot/test/test_steps.py (BuildStep.setUp): same
3179 2005-05-05 Brian Warner <warner@lothar.com>
3181 * buildbot/scripts/runner.py (start): if there is no Makefile,
3182 launch the app by importing twistd's internals and calling run(),
3183 rather than spawning a new twistd process. This stands a much
3184 better chance of working under windows.
3185 (stop): kill the process with os.kill instead of spawning
3186 /bin/kill, again to reduce the number of external programs which
3187 windows might not have in the PATH. Also wait up to 5 seconds for
3188 the process to go away, allowing things like 'buildbot stop;
3189 buildbot start' to be reliable in the face of slow shutdowns.
3191 * buildbot/master.py (Dispatcher.__getstate__): remove old
3192 .tap-related methods
3193 (BuildMaster.__getstate__): same
3195 * buildbot/slave/bot.py (makeService): same
3196 (Options.longdesc): same
3197 * buildbot/scripts/runner.py: copy over some old mktap option text
3199 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3200 'buildbot master' now creates a buildbot.tac file, so there is no
3201 longer a create-instance/save/reload sequence. mktap is dead, long
3203 * buildbot/scripts/sample.mk: use twistd -y, not -f
3204 * buildbot/test/test_config.py: remove mktap-based test
3205 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3206 * README: don't reference mktap
3208 * docs/source.xhtml: document some of the attributes that Changes
3211 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3213 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3214 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3215 * buildbot/changes/changes.py (Change)
3216 * buildbot/changes/mail.py (parseSyncmail)
3217 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3219 * buildbot/process/base.py (Build.isTagImportant)
3223 2005-05-04 Brian Warner <warner@lothar.com>
3225 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3226 connection after sending the change, so that unit tests don't
3227 complain about sockets being left around
3229 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3230 exception in phase=0 rendering
3231 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3233 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3235 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3236 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3237 and configuring builders with tuples.
3238 * buildbot/test/test_config.py: stop testing compatibility with
3239 deprecated config keys
3240 * buildbot/test/test_run.py: same
3242 2005-05-03 Brian Warner <warner@lothar.com>
3244 * contrib/arch_buildbot.py: survive if there are no logfiles
3245 (username): just use a string, os.getlogin isn't reliable
3247 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3248 so 'buildbot sendchange' actually works. The earlier test only
3249 covered the internal (non-reactor-running) form.
3251 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3252 script to notify the buildmaster about changes
3254 * buildbot/scripts/runner.py (sendchange): new command to send a
3255 change to a buildbot.changes.pb.PBChangeSource receiver.
3256 * buildbot/test/test_changes.py (Sender): test it
3258 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3259 after any reading of the config file, not just when we do it in
3260 startService. This makes some tests a bit cleaner.
3262 * buildbot/changes/pb.py: add some log messages
3264 * buildbot/process/base.py (Build.startBuild): fix a bug that
3265 caused an exception when the build terminated in the very first
3267 (Build.stepDone): let steps return a status of EXCEPTION. This
3268 terminates the build right away, and sets the build's overall
3269 status to EXCEPTION too.
3270 * buildbot/process/step.py (BuildStep.failed): return a status of
3271 EXCEPTION when that is what has happened.
3273 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3274 implement this, allowing Arch-based projects to get precise
3275 checkouts instead of always using the latest code
3276 (Bazaar): create variant of Arch to let folks use baz instead of
3277 tla. Requires a new buildslave too.
3278 * buildbot/slave/commands.py (Arch): add 'revision' argument
3279 (Bazaar): create variant of Arch that uses baz instead of tla.
3280 Remove the code that extracts the archive name from the
3281 register-archive output, since baz doesn't provide it, and require
3282 the user provide both the archive name and its location.
3283 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3285 2005-05-02 Brian Warner <warner@lothar.com>
3287 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3288 thanks to Nick Trout.
3290 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3291 deals better with source Makefile coming from a read-only CVS
3292 checkout. Thanks to Nick Trout for the catch.
3294 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3297 2005-04-28 Brian Warner <warner@lothar.com>
3299 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3301 * debian/changelog: update for 0.6.4
3303 2005-04-28 Brian Warner <warner@lothar.com>
3305 * README.w32: add a checklist of steps for getting buildbot
3307 * MANIFEST.in: include it in the tarball
3311 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3312 broken .tap files from 0.6.3 by getting rid of .services,
3313 .namedServices, and .change_svc at load time.
3315 2005-04-27 Brian Warner <warner@lothar.com>
3317 * NEWS: update in preparation for new release
3319 * buildbot/test/test_config.py (Save.testSave): don't pull in
3320 twisted.scripts.twistd, we don't need it and it isn't for windows
3323 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3324 accomodate win32 which can't do atomic-rename
3326 2005-04-27 Brian Warner <warner@lothar.com>
3328 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3329 timeouts to help the slow metabuildbot not flunk them so much
3330 (Disconnect.testBuild3): same
3331 (Disconnect.testBuild4): same
3332 (Disconnect.testInterrupt): same
3334 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3335 setup, it was completely broken for new buildmasters (those which
3336 did not have a 'change.pck' already saved. Thanks to Paul Warren
3337 for catching this (embarrassing!) bug.
3338 (Dispatcher.__getstate__): don't save our registered avatar
3339 factories, since they'll be re-populated when the config file is
3341 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3342 tests (since the real mktap-generated BuildMaster doesn't save
3344 (BuildMaster.__getstate__): don't save any service children,
3345 they'll all be re-populated when the config file is re-read.
3346 * buildbot/test/test_config.py (Save.testSave): test for this
3348 2005-04-26 Brian Warner <warner@lothar.com>
3350 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3351 rendered with Blender.. looks a bit nicer.
3352 * buildbot/docs/images/icon.blend: add the Blender file for it
3354 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3355 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3356 running under windows. This appears to be the best way to allow
3357 BuildSteps to do something normal like 'trial -v buildbot.test' or
3358 'make foo' and still expect it to work. The idea is to make the
3359 BuildSteps look as much like what a developer would type when
3360 compiling or testing the tree by hand. This approach probably has
3361 problems when there are spaces in the arguments, so if you've got
3362 windows buildslaves, you'll need to pay close attention to your
3365 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3366 timezone to the timestamp column.
3367 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3369 * buildbot/scripts/runner.py (loadOptions): do something sane for
3370 windows, I think. We use %APPDATA%/buildbot instead of
3371 ~/.buildbot, but we still search everywhere from the current
3372 directory up to the root for a .buildbot/ subdir. The "is it under
3373 $HOME" security test was replaced with "is it owned by the current
3374 user", which is only performed under posix.
3375 * buildbot/test/test_runner.py (Options.testFindOptions): update
3376 tests to match. The "is it owned by the current user" check is
3377 untested. The test has been re-enabled for windows.
3379 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3380 any "\n" in the expected output with the platform-specific line
3381 separator. Make this separator "\r\n" on PTYs under unix, they
3382 seem to do that and I don't know why
3384 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3385 windows for now, I don't know what ~/.buildbot/ should mean there.
3387 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3388 win32 compatibility, don't use "/tmp"
3389 (Basedir.testChangeBuilddir): remove more unixisms
3391 2005-04-26 Brian Warner <warner@lothar.com>
3393 * buildbot/test/test_control.py (Force.rmtree): python2.2
3394 compatibility, apparently its shutil.rmtree ignore_errors=
3395 argument is ignored.
3396 * buildbot/test/test_run.py (Run.rmtree): same
3397 (RunMixin.setUp): same
3399 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3402 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3403 'substring in string' operator, must use string.find(substr)!=-1
3404 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3405 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3407 * buildbot/scripts/runner.py (loadOptions): add code to search for
3408 ~/.buildbot/, a directory with things like 'options', containing
3409 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3410 the current directory, your $HOME directory, or anywhere
3411 inbetween, as long as you're somewhere inside your home directory.
3412 (debugclient): look in ~/.buildbot/options for master and passwd
3413 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3414 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3416 * buildbot/status/client.py (makeRemote): new approach to making
3417 IRemote(None) be None, which works under Twisted-2.0
3418 * buildbot/test/test_status.py (Client.testAdaptation): test it
3420 * buildbot/status/builder.py (Status.builderAdded): when loading a
3421 pickled BuilderStatus in from disk, set its name after loading.
3422 The config file might have changed its name (but not its
3423 directory) while it wasn't looking.
3425 * buildbot/process/builder.py (Builder.attached): always return a
3426 Deferred, even if the builder was already attached
3427 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3429 2005-04-25 Brian Warner <warner@lothar.com>
3431 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3432 category-related exception when announcing a build has finished
3434 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3435 reference no-longer-existent changemaster.sources
3436 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3438 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3441 2005-04-25 Brian Warner <warner@lothar.com>
3443 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3445 * debian/changelog: update for 0.6.3
3447 2005-04-25 Brian Warner <warner@lothar.com>
3449 * MANIFEST.in: make sure debug.glade is in the tarball
3451 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3453 * NEWS: update for the imminent 0.6.3 release
3455 * buildbot/status/html.py (HtmlResource.content): make the
3456 stylesheet <link> always point at "buildbot.css".
3457 (StatusResource.getChild): map "buildbot.css" to a static.File
3458 containing whatever css= argument was provided to Waterfall()
3459 (Waterfall): provide the "classic" css as the default.
3460 * docs/waterfall.classic.css: move default CSS from here ..
3461 * buildbot/status/classic.css: .. to here
3463 * MANIFEST.in: make sure classic.css is included in the tarball
3464 * setup.py: and that it is installed too, under buildbot/status/
3466 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3467 the module level, because buildbot.tap files from 0.6.2 don't have
3468 it in their attribute dictionary.
3470 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3471 really exists at startup, might save some confusion somewhere.
3473 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3475 * docs/waterfall.classic.css:
3476 add a stylesheet that's almost the same as the "classic"
3479 * buildbot/status/builder.py:
3480 add EXCEPTION as a result - this is a problem for the bot
3481 maintainer, not a build problem for the changers
3482 * buildbot/process/step.py:
3483 use EXCEPTION instead of FAILURE for exceptions
3484 * buildbot/status/html.py:
3485 add build_get_class to get a class out of a build/buildstep
3486 finish naming the classes
3487 split out sourceNames to changeNames and builderNames so we
3488 can style them separately
3489 * docs/config.xhtml:
3490 finish documenting classes as they are right now
3492 * buildbot/status/html.py:
3493 name the classes as we agreed on IRC
3494 * docs/config.xhtml:
3497 * buildbot/status/html.py:
3498 same for cssclass->class_
3500 * buildbot/status/html.py:
3501 as decided on IRC, use class_ for the "class" attribute to not
3502 conflict with the class keyword, and clean up the messy **{} stuff.
3504 * buildbot/status/mail.py:
3505 put back "builders" argument, and fix docstring, because the
3506 code *ignores* builders listed in this argument
3508 * buildbot/process/builder.py:
3509 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3511 * docs/config.xhtml:
3512 describe the category argument for builders
3514 * buildbot/status/builder.py:
3515 Fix a silly bug due to merging
3517 * buildbot/process/builder.py:
3518 remove category from the process Builder ...
3519 * buildbot/status/builder.py:
3520 ... and add it to BuilderStatus instead.
3521 Set category on unpickled builder statuses, they might not have it.
3522 * buildbot/master.py:
3523 include category when doing builderAdded
3524 * buildbot/status/mail.py:
3525 return None instead of self for builders we are not interested in.
3526 * buildbot/test/test_run.py:
3527 fix a bug due to only doing deferredResult on "dummy" waiting
3528 * buildbot/test/test_status.py:
3529 add checks for the Mail IStatusReceiver returning None or self
3531 * buildbot/status/html.py:
3532 fix testsuite by prefixing page title with BuildBot
3534 * buildbot/status/builder.py:
3535 have .category in builder status ...
3536 * buildbot/process/builder.py:
3537 ... and set it from Builder
3538 * buildbot/status/html.py:
3539 make .css a class variable
3540 * buildbot/test/test_status.py:
3541 write more tests to cover our categories stuff ...
3542 * buildbot/status/mail.py:
3543 ... and fix the bug that this uncovered
3545 * buildbot/changes/mail.py:
3546 * buildbot/changes/pb.py:
3547 * buildbot/master.py:
3548 * buildbot/process/base.py:
3549 * buildbot/process/factory.py:
3550 * buildbot/process/interlock.py:
3551 * buildbot/process/step.py:
3552 * buildbot/process/step_twisted.py:
3553 * buildbot/slave/commands.py:
3554 * buildbot/status/builder.py:
3555 * buildbot/status/client.py:
3556 * buildbot/status/html.py:
3557 * buildbot/status/mail.py:
3558 * buildbot/status/progress.py:
3559 * buildbot/test/test_changes.py:
3560 * buildbot/test/test_config.py:
3561 * buildbot/test/test_control.py:
3562 * buildbot/test/test_interlock.py:
3563 * buildbot/test/test_maildir.py:
3564 * buildbot/test/test_mailparse.py:
3565 * buildbot/test/test_run.py:
3566 * buildbot/test/test_slavecommand.py:
3567 * buildbot/test/test_status.py:
3568 * buildbot/test/test_steps.py:
3569 * buildbot/test/test_twisted.py:
3570 * buildbot/test/test_util.py:
3571 * buildbot/test/test_vc.py:
3572 * buildbot/test/test_web.py:
3574 add test-case-name at the top of a whole set of files
3576 * buildbot/status/builder.py:
3577 keep order of addition when getting builder names
3578 * buildbot/status/words.py:
3579 * buildbot/test/test_run.py:
3580 add test for getBuilderNames
3582 * buildbot/process/base.py:
3583 * buildbot/process/step.py:
3584 * buildbot/status/builder.py:
3585 * buildbot/status/html.py:
3586 make buildbot css-able
3587 replace the color code for purple with purple, don't understand
3588 why it wasn't purple to start with
3590 * buildbot/status/words.py:
3591 ok, so it doesn't look like BuilderStatus.remote is still valid.
3592 Use what waterfall uses instead.
3594 * buildbot/interfaces.py:
3595 * buildbot/status/builder.py:
3596 * buildbot/status/html.py:
3597 * buildbot/status/mail.py:
3598 * buildbot/status/words.py:
3599 * buildbot/test/test_run.py:
3600 use categories everywhere and make it be a list. More sensible
3601 for the future. Also make words actually respect this in
3604 * buildbot/interfaces.py:
3605 add category argument to getBuilderNames
3606 * buildbot/process/builder.py:
3607 * buildbot/status/builder.py:
3608 * buildbot/status/html.py:
3609 * buildbot/status/mail.py:
3610 * buildbot/status/words.py:
3611 * buildbot/test/test_run.py:
3612 move from specifying builders by name to specifying the category
3614 * buildbot/status/html.py:
3615 * buildbot/status/words.py:
3616 add "builders=" to __init__ of status clients so they can
3617 limit themselves to the given list of builders to report on
3619 * buildbot/status/html.py: set the title to the product name
3621 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3623 * buildbot/interfaces.py:
3624 * buildbot/status/builder.py:
3625 more documentation. Hm, not sure if ChangeLog entries make sense
3628 2005-04-23 Brian Warner <warner@lothar.com>
3630 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3632 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3634 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3635 the sub-commands that log buildmaster status to stdout and to a
3636 GUI window, respectively.
3638 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3639 functionality is working again, but all the step-status and ETA
3640 stuff is missing. Commented out a lot of code pending more
3643 * buildbot/status/client.py: make sure that IRemote(None) is None
3645 * buildbot/changes/changes.py: import defer, oops
3646 (ChangeMaster): remove the .sources list, rely upon the fact that
3647 MultiServices can be treated as sequences of their children. This
3648 cleans up the add/remove ChangeSource routines a lot, as we keep
3649 exactly one list of the current sources instead of three.
3651 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3652 up an empty ChangeMaster at init time.
3653 (BuildMaster.loadChanges): if there are changes to be had from
3654 disk, replace self.change_svc with the new ones. If not, keep
3655 using the empty ChangeMaster set up in __init__.
3656 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3657 instead of a separate list, makes the code a bit cleaner.
3658 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3659 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3660 Extend the test to make sure we can get rid of the sources when
3663 2005-04-22 Brian Warner <warner@lothar.com>
3665 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3666 and info/host files when making the slave directory
3668 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3669 whendone= argument, just return the Deferred and let the caller do
3670 what they want with it.
3671 (Disconnect.testBuild1): wait for shutdownSlave
3672 (Basedir.testChangeBuilddir): new test to make sure changes to the
3673 builddir actually get propagated to the slave
3675 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3676 explicit method, rather than passing the builddir in __init__ .
3677 Make sure to update self.basedir too, this was broken before.
3678 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3679 builders and for ones that have just had their builddir changed.
3680 (BotFactory): add a class-level .perspective attribute, so
3681 BuildSlave.waitUntilDisconnected won't get upset when the
3682 connection hasn't yet been established
3683 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3684 tests can reach through it to inspect the SlaveBuilders
3686 * buildbot/process/base.py (Build.buildException): explain the
3687 log.err with a log.msg
3688 * buildbot/process/builder.py (Builder.startBuild): same
3689 (Builder._startBuildFailed): improve error message
3691 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3692 occurred because we lost the brand-new connection, retry instead
3693 of giving up. If not, it's probably an authorization failure, and
3694 it makes sense to stop trying. Make sure we log.msg the reason
3695 that we're log.err'ing the failure, otherwise test failures are
3696 really hard to figure out.
3698 * buildbot/master.py: change loadConfig() to return a Deferred
3699 that doesn't fire until the change has been fully implemented.
3700 This means any connected slaves have been updated with the new
3701 builddir. This change makes it easier to test the code which
3702 actually implements this builddir-updating.
3703 (BotPerspective.addBuilder): return Deferred
3704 (BotPerspective.removeBuilder): same
3705 (BotPerspective.attached): same
3706 (BotPerspective._attached): same. finish with remote_print before
3707 starting the getSlaveInfo, instead of doing them in parallel
3708 (BotPerspective.list_done): same
3709 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3710 actually calling slave.disconnect()
3711 (BotMaster.addBuilder): same
3712 (BotMaster.removeBuilder): same
3713 (BuildMaster.loadConfig): same
3714 (BuildMaster.loadConfig_Slaves): same
3715 (BuildMaster.loadConfig_Sources): same
3716 (BuildMaster.loadConfig_Builders): same
3717 (BuildMaster.loadConfig_status): same
3719 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3720 a Deferred that fires when the source is finally removed
3722 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3723 the previous tree on win32, where we have to do it synchronously,
3724 make sure we return a Deferred anyway.
3725 (SourceBase.doCopy): same
3727 * buildbot/scripts/runner.py (statusgui): use the text client for
3728 now, while I rewrite the Gtk one
3729 * buildbot/clients/base.py: strip out old code, leaving just the
3730 basic print-message-on-event functionality. I also remove the
3731 ReconnectingPBClientFactory, but it does at least quit when it
3732 loses the connection instead of going silent
3734 2005-04-21 Brian Warner <warner@lothar.com>
3736 * Makefile: minor tweaks
3738 * NEWS: point out deprecation warnings, new features for
3741 * buildbot/master.py (BuildMaster.loadConfig): emit
3742 DeprecationWarnings for Builders defined with tuples. Rearrange
3743 code to facility removal of deprecated configuration keys in the
3746 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3747 'buildbot' command to put a little Makefile in the target that
3748 helps you re-create the buildbot.tap file, start or stop the
3749 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3750 all the files 0600, since they contain passwords.
3751 (start): if there is a Makefile, and /usr/bin/make exists, use
3752 'make start' in preference to a raw twistd command. This lets
3753 slave admins put things like PYTHONPATH variables in their
3754 Makefiles and have them still work when the slave is started with
3755 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3756 be nice to first try the 'make' command and only fall back to
3757 twistd if it fails. TODO: the Makefile's "start" command does not
3758 add the --reactor=win32 argument when running under windows.
3759 (Options.debugclient, Options.statusgui): add sub-commands to launch
3760 the debug client (formerly in contrib/debugclient.py) and the
3761 Gtk status application (currently broken)
3762 * buildbot/clients/debug.py: move from contrib/debugclient.py
3763 * buildbot/clients/debug.glade: same
3765 * buildbot/test/test_trial.py: remove it. This requires some
3766 functionality out of Twisted that isn't there yet, and until then
3767 having it around just confuses things.
3769 * buildbot/test/test_slavecommand.py (Shell): test both with and
3770 without PTYs, and make sure that command output is properly
3771 interleaved in the with-PTY case. I think the without-PTY test
3772 should pass on windows, where we never use PTYs anyway.
3774 2005-04-20 Brian Warner <warner@lothar.com>
3776 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3778 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3780 * NEWS: start creating entries for the next release
3782 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3784 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3785 (WebTest.test_webPathname): same
3786 (WebTest.test_webPathname_port): same
3787 (WebTest.test_waterfall): use the default favicon rather than
3788 rooting around the filesystem for it. Open the expected-icon file
3789 in binary mode, to make win32 tests happier (thanks to Nick Trout
3791 * buildbot/status/html.py (buildbot_icon): win32 portability
3793 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3794 win32-compatibility fixes from Nick Trout, the "file not found" message
3795 is different under windows
3796 (FakeSlaveBuilder.__init__): clean up setup a bit
3797 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3799 2005-04-19 Brian Warner <warner@lothar.com>
3801 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3802 skip-if-repositories-are-unavailable test to not kill the trial
3803 that comes with Twisted-1.3.0
3805 * setup.py: install buildbot.png icon file when installing code
3807 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3808 environment used by the command, at least on the child side.
3810 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3811 this method needs to be added and implemented because it gets
3812 called under heavy load. I don't quite understand the
3813 producer/consumer API enough to write it.
3814 (StatusResource.getChild): add a resource for /favicon.ico
3815 (Waterfall.__init__): add favicon= argument
3816 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3817 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3818 (WebTest.test_webPathname): same
3819 (WebTest.test_webPathname_port): same
3820 * docs/config.xhtml: mention favicon=
3821 * buildbot/buildbot.png: add a default icon, dorky as it is
3823 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3825 * buildbot/master.py:
3826 * buildbot/process/base.py:
3827 * buildbot/process/builder.py:
3828 * buildbot/process/interlock.py:
3829 * buildbot/status/builder.py:
3830 * buildbot/status/html.py:
3831 * buildbot/status/mail.py:
3832 * buildbot/status/words.py:
3833 new documentation while digging through the code
3835 2005-04-17 Brian Warner <warner@lothar.com>
3837 * general: try to fix file modes on all .py files: a+r, a-x,
3838 but let buildbot/clients/*.py be +x since they're tools
3840 * docs/epyrun (addMod): when an import fails, say why
3842 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3844 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3846 * buildbot/process/base.py:
3847 * buildbot/process/builder.py:
3848 * buildbot/status/builder.py:
3849 new documentation while digging through the code
3851 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3853 * buildbot/changes/changes.py:
3854 * buildbot/changes/p4poller.py:
3855 * buildbot/interfaces.py:
3856 * buildbot/process/base.py:
3857 * buildbot/process/builder.py:
3858 * buildbot/process/step.py:
3859 * buildbot/process/step_twisted.py:
3860 * buildbot/slave/bot.py:
3861 * buildbot/slave/commands.py:
3862 * buildbot/status/builder.py:
3863 fix all docstrings to make epydoc happy. In the process of fixing
3864 some, I also moved pieces of docs, and removed some deprecated
3867 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3869 * buildbot/process/builder.py:
3870 * buildbot/process/interlock.py:
3871 * buildbot/process/process_twisted.py:
3872 * buildbot/process/step.py:
3873 BuildProcess -> Build, as it looks like that's what happened
3874 * buildbot/process/base.py:
3875 * buildbot/process/factory.py:
3878 2005-04-17 Brian Warner <warner@lothar.com>
3880 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3881 update compile command to accomodate the Twisted split.. now
3882 instead of './setup.py build_ext -i', you do './setup.py all
3883 build_ext -i', to run build_ext over all sub-projects.
3884 (FullTwistedBuildFactory): same
3885 (TwistedReactorsBuildFactory): same
3887 * buildbot/status/html.py (TextLog.finished): null out self.req
3888 when we're done, otherwise the reference cycle of TextLog to .req
3889 to .notifications to a Deferred to TextLog.stop keeps them from
3890 being collected, and consumes a huge (610MB on pyramid at last
3891 check) amount of memory.
3893 2005-04-11 Brian Warner <warner@lothar.com>
3895 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3896 normalize the VC-repository location.. makes SVN happier with
3897 certain test environments.
3899 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3900 RemoteShellCommand gets its own .env dictionary, so that code in
3901 start() doesn't mutate the original. I think this should fix the
3902 step_twisted.Trial problem where multiple identical components
3903 kept getting added to PYTHONPATH= over and over again.
3905 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3906 adding epydoc-format docstrings to many classes. Thanks to Thomas
3907 Vander Stichele for the patches.
3908 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3909 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3910 * buildbot/slave/bot.py, commands.py, registry.py: same
3912 2005-04-05 Brian Warner <warner@lothar.com>
3914 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3915 preserve timestamps, helps incremental builds of large trees.
3916 Patch from Rene Rivera.
3918 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3919 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3922 2005-04-03 Brian Warner <warner@lothar.com>
3924 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3925 with one dict, apparently exec has some scoping bugs when used
3926 with both global/local dicts. Thanks to Nathaniel Smith for the
3929 2005-04-02 Brian Warner <warner@lothar.com>
3931 * buildbot/process/step_twisted.py (countFailedTests): the new
3932 trial in Twisted-2.0 emits a slightly different status line than
3933 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3934 mistakenly think the test count is unparseable.
3935 (Trial.start): note that for some reason each build causes another
3936 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3937 be fixed but I'm not sure quite where the problem is.
3939 2005-04-01 Brian Warner <warner@lothar.com>
3941 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3942 deferredResult to avoid hangs/warnings under twisted-2.0
3943 (RunMixin.tearDown): same
3944 (RunMixin.shutdownSlave): same
3945 (Disconnect.testIdle1): same
3946 (Disconnect.testBuild2): same: wait one second after the build
3947 finishes for test to really be done.. this should be cleaned up to
3948 avoid wasting that second. Builder.detach uses a callLater(0),
3949 either that should be done in-line (something else needed that
3950 behavior), or it should return a Deferred that fires when the
3951 builder is really offline.
3952 (Disconnect.testBuild3): same
3953 (Disconnect.testDisappear): same
3955 * buildbot/test/test_web.py: rearrange server-setup and teardown
3956 code to remove unclean-reactor warnings from twisted-2.0
3958 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3959 so the tests don't hang under twisted-2.0
3961 2005-03-31 Brian Warner <warner@lothar.com>
3963 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3964 caused a warning each time the master changed our set of builders
3966 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3967 w32, don't unlink the file unless it already exists. Thanks to
3968 Baptiste Lepilleur for the catch.
3969 (BuilderStatus.saveYourself): same
3971 2005-02-01 Brian Warner <warner@lothar.com>
3973 * buildbot/status/html.py (TextLog.getChild): use a /text child
3974 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3975 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3976 logfile as text/plain (no markup, no headers). This replaces the
3977 previous scheme (which used an ?text=1 argument), and gets us back
3978 to a relative link (which works better when the buildbot lives
3979 behind another web server, such as Apache configured as a reverse
3980 proxy). Thanks to Gerald Combs for spotting the problem.
3982 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3985 2004-12-13 Brian Warner <warner@lothar.com>
3987 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3989 * debian/changelog: update for 0.6.2
3990 * NEWS: finalize for 0.6.2
3992 2004-12-11 Brian Warner <warner@lothar.com>
3994 * NEWS: bring it up to date
3996 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3997 detection code. Require some sign of life from the buildmaster
3998 every BotFactory.keepaliveInterval seconds. Provoke this
3999 indication at BotFactory.keepaliveTimeout seconds before the
4000 deadline by sending a keepalive request. We don't actually care if
4001 that request is answered in a timely fashion, what we care about
4002 is that .activity() is called before the deadline. .activity() is
4003 triggered by any PB message from the master (including an ack to
4004 one of the slave's status-update messages). With this new scheme,
4005 large status messages over slow pipes are OK, as long as any given
4006 message can be sent (and thus acked) within .keepaliveTimeout
4007 seconds (which defaults to 30).
4008 (SlaveBuilder.remote_startCommand): record activity
4009 (SlaveBuilder.ackUpdate): same
4010 (SlaveBuilder.ackComplete): same
4011 (BotFactory.gotPerspective): same
4012 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4014 2004-12-09 Brian Warner <warner@lothar.com>
4016 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4019 * buildbot/process/step_twisted.py (Trial._commandComplete):
4020 update self.cmd when we start the 'cat test.log' transfer. Without
4021 this, we cannot interrupt the correct RemoteCommand when we lose
4024 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4025 trying to tell the slave to stop the command if we're already
4026 inactive, or if we no longer have a .remote
4028 * buildbot/process/builder.py (Builder._detached): don't let an
4029 exception in currentBuild.stopBuild() prevent the builder from
4030 being marked offline
4032 2004-12-07 Brian Warner <warner@lothar.com>
4034 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4035 KeyError that happens when you ask for a non-existent Builder, and
4036 translate it into a UsageError.
4038 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4039 losing the slave in the middle of a remote step is handled too
4041 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4042 be a Failure, so be sure to stringify it before using it as the
4043 contents of the 'interrupt' logfile
4044 (RemoteCommand.interrupt): use stringified 'why' in
4045 remote_interruptCommand too, just in case
4047 2004-12-06 Brian Warner <warner@lothar.com>
4049 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4050 instead of 'tla update', which is more efficient in case we've
4051 missed a couple of patches since the last update.
4053 * debian/changelog: update for previous (0.6.1) release. Obviously
4054 this needs to be handled better.
4056 2004-12-05 Brian Warner <warner@lothar.com>
4058 * NEWS: update for stuff since last release
4060 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4061 match the maybeDeferred change in Dispatcher.requestAvatar
4062 * buildbot/changes/pb.py (ChangePerspective.attached): same
4063 * buildbot/status/client.py (StatusClientPerspective.attached): same
4064 * buildbot/process/builder.py (Builder._attached3): same
4065 * buildbot/pbutil.py (NewCredPerspective.attached): same
4067 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4068 the date to the top-most box, if it is not the same as today's
4071 * docs/slave.xhtml: provide a buildslave setup checklist
4073 * docs/source.xhtml (Arch): correct terminology
4075 2004-12-04 Brian Warner <warner@lothar.com>
4077 * buildbot/test/test_slavecommand.py: use sys.executable instead
4078 of hard-coding 'python' for child commands, might help portability
4080 * docs/examples/twisted_master.cfg: update to current usage
4082 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4083 'stop build' command to the IRC bot
4085 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4086 message that broke PBChangeSource
4088 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4089 (SlaveBuilder): make some attributes class-level, remove the old
4090 "update queue" which existed to support resuming a build after the
4091 master connection was lost. Try to reimplement that feature later.
4092 (SlaveBuilder.stopCommand): clear self.command when the
4093 SlaveCommand finishes, so that we don't try to kill a leftover one
4095 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4098 * buildbot/slave/commands.py (SourceBase): set self.command for
4099 all VC commands, so they can be interrupted.
4101 2004-12-03 Brian Warner <warner@lothar.com>
4103 * buildbot/master.py: clean up slave-handling code, to handle
4104 slave-disconnect and multiple-connect better
4105 (BotPerspective): make these long-lasting, exactly one per bot
4106 listed in the config file.
4107 (BotPerspective.attached): if a slave connects while an existing
4108 one appears to still be connected, disconnect the old one first.
4109 (BotPerspective.disconnect): new method to forcibly disconnect a
4110 buildslave. Use some hacks to empty the transmit buffer quickly to
4111 avoid the long (20-min?) TCP timeout that could occur if the old
4112 slave has dropped off the net.
4113 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4114 own their own SlaveStatus objects. Remove .attached/.detached, add
4115 .addSlave/.removeSlave, treat slaves like Builders (config file
4116 parsing sends deltas to the BotMaster). Inform the slave
4117 instances, i.e. the BotPerspective, about addBuilder and
4119 (BotMaster.getPerspective): turns into a single dict lookup
4120 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4121 which gives BotPerspective.attached a chance to disconnect the old
4123 (BuildMaster.loadConfig): add code (disabled) to validate that all
4124 builders use known slaves (listed in c['bots']). The check won't
4125 work with tuple-specified builders, which are deprecated but not
4126 yet invalid, so the check is disabled for now.
4127 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4128 routine, do the add/changed/removed dance with them like we do
4130 (BuildMaster.loadConfig_Sources): move source-config into a
4131 separate routine too
4133 * buildbot/status/builder.py (Status.getSlave): get the
4134 SlaveStatus object from the BotPerspective, not the BotMaster.
4136 * buildbot/test/test_run.py: bunch of new tests for losing the
4137 buildslave at various points in the build, handling a slave that
4138 connects multiple times, and making sure we can interrupt a
4141 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4142 something other than 'Bot' for the Bot object, to make certain
4143 test cases easier to write.
4144 (BuildSlave.waitUntilDisconnected): utility method for testing
4146 2004-11-30 Brian Warner <warner@lothar.com>
4148 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4150 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4151 argument, return a Deferred that always fires with True or False.
4152 I don't use an errback to indicate 'ping failed' so that callers
4153 are free to ignore the deferred without causing spurious errors in
4155 * buildbot/process/builder.py (BuilderControl.ping): implement it
4157 * buildbot/test/test_run.py (Status.testDisappear): test ping
4158 (Status.disappearSlave): fix it
4160 2004-11-30 Brian Warner <warner@lothar.com>
4162 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4163 (IBuilderControl): add .getBuild(num), only works for the current
4164 build, of course, although it might be interesting to offer
4165 something for builds in the .waiting or .interlocked state.
4167 * buildbot/process/base.py (Build): have .stopBuild just do the
4168 interrupt, then let the build die by itself.
4169 (BuildControl): add .stopBuild, and add a point-event named
4170 'interrupt' just after the build so status viewers can tell that
4172 (BuilderControl): add .getBuild
4174 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4175 stops when you kill it, good for testing
4176 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4177 contains the 'reason' text.
4179 * buildbot/status/html.py: Add Stop Build button, if the build can
4180 still be stopped. Send a Redirect (to the top page) one second
4181 later, hopefully long enough for the interrupt to have an effect.
4182 Move make_row() up to top-level to share it between Stop Build and
4185 * buildbot/slave/commands.py: only kill the child process once
4187 * buildbot/test/test_run.py: add testInterrupt
4189 2004-11-29 Brian Warner <warner@lothar.com>
4191 * buildbot/process/base.py: Refactor command interruption. The
4192 Build is now responsible for noticing that the slave has gone
4193 away: Build.lostRemote() interrupts the current step and makes
4194 sure that no further ones will be started.
4196 * buildbot/process/builder.py: When the initial remote_startBuild
4197 message fails, log it: this usually indicates that the slave has
4198 gone away, but we don't really start paying attention until they
4199 fail to respond to the first step's command.
4201 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4202 slave disconnect. Now sports a new interrupt() method. Error
4203 handling was simplified a lot by chaining deferreds, so
4204 remoteFailed/remoteComplete were merged into a single
4205 remoteComplete method (which can now get a Failure object).
4206 Likewise failed/finished were merged into just _finished.
4207 (BuildStep): Add interrupt(why) method, and if why is a
4208 ConnectionLost Failure then the step is failed with some useful
4211 * buildbot/slave/bot.py: stop the current command when the remote
4212 Step reference is lost, and when the slave is shut down.
4213 (Bot): make it a MultiService, so it can have children. Use
4214 stopService to tell when the slave is shutting down.
4215 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4216 remote_interruptCommand (which asks the current SlaveCommand to
4217 stop but allows it to keep emitting status messages), and
4218 stopCommand (which tells it to shut up and die).
4220 * buildbot/slave/commands.py: make commands interruptible
4221 (ShellCommand.kill): factor out os.kill logic
4222 (Command): factor out setup()
4223 (Command.sendStatus): don't send status if .running is false, this
4224 happens when the command has been halted.
4225 (Command.interrupt): new method, used to tell the command to die
4226 (SlaveShellCommand): implement .interrupt
4227 (DummyCommand): implement .interrupt
4228 (SourceBase, etc): factor out setup(), don't continue substeps if
4231 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4232 so they can be called after finishing
4234 * buildbot/test/test_run.py: new tests for disconnect behavior,
4235 refactor slave-shutdown routines, add different kinds of
4238 2004-11-27 Brian Warner <warner@lothar.com>
4240 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4241 method to express ETA time like "2m45s" instead of "165 seconds"
4243 2004-11-24 Brian Warner <warner@lothar.com>
4245 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4246 archive after the test completes, to avoid cluttering the user's
4247 'tla archives' listing with a bogus entry. Arch doesn't happen to
4248 provide any way to override the use of ~/.arch-params/, so there
4249 isn't a convenient way to avoid touching the setup of the user who
4251 (VC_HTTP.testArchHTTP): same
4253 2004-11-23 Brian Warner <warner@lothar.com>
4255 * buildbot/status/html.py (TextLog): split render() up into
4256 render_HEAD and render_GET. Use a Producer when sending log
4257 chunks, to reduce memory requirements and avoid sending huge
4258 non-Banana-able strings over web.distrib connections. Requires
4259 peeking under the covers of IStatusLog.
4260 (TextLog.resumeProducing): fix the "as text" link, handle client
4261 disconnects that occur while we're still sending old chunks.
4263 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4264 use defer.succeed, not the non-existent defer.success
4265 (LogFile.waitUntilFinished): same
4266 (LogFile.subscribe): don't add watchers to a finished logfile
4268 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4271 2004-11-23 Brian Warner <warner@lothar.com>
4273 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4275 2004-11-23 Brian Warner <warner@lothar.com>
4277 * NEWS: update for the 0.6.1 release
4278 * MANIFEST.in: add new files
4280 * README (INSTALLATION): explain how to enable the extra VC tests
4282 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4283 level to, so old pickled builds can be displayed ok
4285 2004-11-22 Brian Warner <warner@lothar.com>
4287 * NEWS: summarize updates since last release
4289 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4290 Yoz Grahame. Closes SF#1050138.
4292 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4295 * buildbot/process/step_twisted.py (Trial): update docs a bit
4297 * docs/factories.xhtml: fix Trial factory docs to match reality.
4300 * buildbot/process/factory.py (Trial.__init__): add args for
4301 randomly= and recurse=, making them available to instantiators
4302 instead of only to subclassers. Closes: SF#1049759.
4304 2004-11-15 Brian Warner <warner@lothar.com>
4306 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4307 try to teach the Quick factory to use multiple versions of python
4309 2004-11-12 Brian Warner <warner@lothar.com>
4311 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4312 safer w32-compatible approach, and only use it on windows
4313 (BuildStatus.saveYourself): same
4315 2004-11-11 Brian Warner <warner@lothar.com>
4317 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4318 it: one string merge per chunk. There are now separate .entries
4319 and .runEntries lists: when enumerating over all chunks, make sure
4321 * buildbot/test/test_status.py (Log): more tests
4323 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4324 chunks together, up to 10kb per chunk. This ought to cut down on
4325 the CPU-burning overhead of large log files. Thanks to Alexander
4326 Staubo for spotting the problem.
4327 * buildbot/test/test_status.py (Log): tests for same
4329 2004-11-10 Brian Warner <warner@lothar.com>
4331 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4332 header to outbound mail
4333 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4335 2004-11-08 Brian Warner <warner@lothar.com>
4337 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4338 can't do os.rename() onto an existing file, so catch the exception
4339 and unlink the target file first. This introduces a slight window
4340 where the existing file could be lost, but the main failure case
4341 (disk full) should still be handled safely.
4342 (BuildStatus.saveYourself): same
4344 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4345 separator character instead of os.sep, because the filenames being
4346 split here are coming from the VC system, which can have a
4347 different pathname convention than the local host. This should
4348 help a buildmaster running on windows that uses a CVS repository
4349 which runs under unix.
4350 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4352 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4353 when there are no test failures to be parsed
4355 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4356 instead of the unix-specific os.system("cp"), thanks to Elliot
4357 Murphy for this and the other buildbot-vs-windows catches.
4358 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4360 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4361 echo the command as it is run
4363 * setup.py: install sample.mk too, not just sample.cfg
4364 (scripts): install contrib/windows/buildbot.bat on windows
4366 2004-11-07 Brian Warner <warner@lothar.com>
4368 * buildbot/process/builder.py (Builder._detached): clear the
4369 self.currentBuild reference, otherwise the next build will be
4370 skipped because we think the Builder is already in use.
4372 * docs/examples/twisted_master.cfg: update to match current usage
4373 on the Twisted buildbot
4375 2004-10-29 Brian Warner <warner@lothar.com>
4377 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4379 2004-10-28 Brian Warner <warner@lothar.com>
4381 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4382 have separate doVCUpdate/doVCFull methods. Catch an update failure
4383 and respond by clobbering the source directory and re-trying. This
4384 will handle local changes (like replacing a file with a directory)
4385 that will cause CVS and SVN updates to fail.
4386 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4388 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4391 2004-10-19 Brian Warner <warner@lothar.com>
4393 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4395 * buildbot/status/html.py (StatusResourceTestResults): display any
4396 TestResults that the Build might have
4397 (StatusResourceTestResult): and the logs for each TestResult
4398 (StatusResourceBuild): add link from the per-build page
4400 2004-10-15 Brian Warner <warner@lothar.com>
4402 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4403 the 'problems' portion of stdout, add TestResults to our build
4404 * buildbot/test/test_twisted.py (Parse.testParse): test it
4406 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4407 to retrieve a dict of accumulated test results
4408 (ITestResult): define what a single test result can do
4409 * buildbot/status/builder.py (TestResult): implement ITestResult
4410 (BuildStatus.getTestResults): retrieve dict of TestResults
4411 (BuildStatus.addTestResult): add TestResults
4412 * buildbot/test/test_status.py (Results.testAddResults): test it
4414 2004-10-14 Brian Warner <warner@lothar.com>
4416 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4417 instead of os.system("rm -rf") for win32 portability
4419 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4420 SignalMixin instead of starting/stopping the reactor, which is
4421 likely to cause problems with other tests
4423 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4424 self.copyComplete() call. Yoz Grahame makes the catch.
4426 * contrib/windows/buildbot.bat: helper script to deal with path
4427 issues. Thanks to Yoz Grahame.
4429 * buildbot/master.py (BuildMaster.startService): don't register a
4430 SIGHUP handler if the signal module has no SIGHUP attribute.
4431 Apparently win32 does this.
4433 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4435 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4436 test if the reactor can't offer UNIX sockets
4438 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4439 error introduced in the last commit. We really need that
4442 2004-10-12 Brian Warner <warner@lothar.com>
4444 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4445 when describing a maildir source. Thanks to Stephen Davis.
4447 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4450 * buildbot/scripts/runner.py (createMaster): install Makefile too
4451 (start): add --no_save to 'start' command
4452 * buildbot/scripts/sample.mk: simple convenience Makefile with
4453 start/stop/reload targets
4455 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4458 2004-09-30 Brian Warner <warner@lothar.com>
4460 * setup.py: Releasing buildbot-0.6.0
4462 2004-09-30 Brian Warner <warner@lothar.com>
4464 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4465 test_trial.py from the source tarball until support is complete.
4467 * NEWS: update for 0.6.0 release
4468 * buildbot/__init__.py (version): same
4471 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4472 'source' command to tell users where to get the Buildbot source
4474 * docs/examples/*.cfg: update to modern standards
4476 * NEWS: update for release
4478 * buildbot/scripts/runner.py (createMaster): remove the
4479 -shutdown.tap stuff now that it isn't necessary
4481 (start): launch buildbot.tap, not buildbot-shutdown.tap
4484 * buildbot/status/mail.py (Domain): shorten class name
4485 (MailNotifier): if lookup= is a string, pass it to Domain()
4486 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4487 (Mail.testBuild2): test the string-to-Domain shortcut
4488 (Mail.testMail): fix test
4491 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4494 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4495 more attributes on load
4496 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4497 to accomodate the whole waterfall page at once, and the thrashing
4498 results in a lot of unnecessary loads
4499 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4500 (BuilderStatus.saveYourself): same
4501 (BuilderStatus.eventGenerator): stop generating on the first missing
4502 build. We assume that saved builds are deleted oldest-first.
4503 (BuildStepStatus.__getstate__): .progress might not exist
4505 * buildbot/changes/changes.py (ChangeMaster): make it
4506 serializable, in $masterdir/changes.pck
4507 (ChangeMaster.stopService): save on shutdown
4508 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4509 * buildbot/test/test_config.py: load Changes before config file
4512 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4513 "Oh my god, you killed the command" header on a separate line
4515 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4516 skip over corrupted build pickles
4517 (BuilderStatus.getFullBuildByNumber): same
4518 (BuilderStatus.eventGenerator): skip over unavailable builds
4519 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4520 do an atomic rename. This prevents a corrupted pickle when some
4521 internal serialization error occurs.
4522 (BuilderStatus.saveYourself): same
4524 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4525 the timeout for shell commands, it got lost somehow
4527 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4528 run out of build steps, return the rest of the builder events
4530 * buildbot/interfaces.py (IBuilderControl.ping): add method
4532 * buildbot/process/builder.py (BuilderControl.ping): move
4533 slave-ping to BuilderControl, and fix the failure case in the
4534 process (Event.finish() is the verb, Event.finished is the noun).
4536 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4537 through the BuilderControl instead of the BuilderStatus
4538 (EventBox): add adapter for builder.Event, allowing builder events to
4539 be displayed in the waterfall display
4541 * buildbot/master.py (BotMaster.stopService): add a 'master
4542 shutdown' event to the builder's log
4543 (BuildMaster.startService): and a 'master started' on startup
4545 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4546 builder events into the BuildStep event stream
4547 (Status.builderAdded): add a 'builder created' event
4550 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4551 command to announce the completion of a running build
4552 (IrcStatusBot.command_FORCE): announce when the build finishes
4554 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4555 don't evict unfinished builds from the cache: they must stay in
4556 the full-cache until their logfiles have stopped changing. Make
4557 sure the eviction loop terminates if an unfinished build was hit.
4558 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4559 This lets exceptions be dumped in an email status message. Really
4560 we need LogFiles which contain both text and HTML, instead of two
4562 (BuildStatus.__getstate__): handle self.finished=False
4563 (Status.builderAdded): if the pickle is corrupted, abandon the
4564 history and create a new BuilderStatus object.
4566 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4567 self.progress attribute, helped one test which doesn't fully set
4568 up the Build object.
4570 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4571 IStatusLog methods into an Interface that is implemented by "stub"
4572 logs, for which all the actual text chunks are on disk (in the
4573 pickled Build instance). To show the log contents, you must first
4574 adapt the stub log to a full IStatusLog object.
4576 * buildbot/status/builder.py (LogFileStub): create separate stub
4577 log objects, which can be upgraded to a real one if necessary.
4578 (LogFile): make them persistable, and let them stubify themselves
4580 (BuildStepStatus): same
4582 (BuildStatus.saveYourself): save the whole build out to disk
4583 (BuilderStatus): make it persistable
4584 (BuilderStatus.saveYourself): save the builder to disk
4585 (BuilderStatus.addFullBuildToCache): implement two caches which
4586 hold Build objects: a small one which holds full Builds, and a
4587 larger one which holds "stubbed" Builds (ones with their LogFiles
4588 turned into LogFileStubs). This reduces memory usage by the
4589 buildmaster by not keeping more than a few (default is 2) whole
4590 build logs in RAM all the time.
4591 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4593 (BuilderStatus.eventGenerator): rewrite since .builds went away
4594 (BuilderStatus.buildStarted): remove the .builds array. Add the
4595 build to the "full" cache when it starts.
4596 (BuilderStatus._buildFinished): save the build to disk when it
4598 (Status): give it a basedir (same as the BuildMaster's basedir)
4599 where the builder pickles can be saved
4600 (Status.builderAdded): create the BuilderStatus ourselves, by
4601 loading a pickle from disk (or creating a new instance if there
4602 was none on disk). Return the BuilderStatus so the master can glue
4603 it into the new Builder object.
4605 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4606 all BuilderStatuses to save themselves out to disk. This is in
4607 lieu of saving anything important in the main Application pickle
4608 (the -shutdown.tap file).
4609 (BuildMaster.__init__): give Status() a basedir for its files
4610 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4611 to get the BuilderStatus, then give it to the Builder (instead of
4612 doing it the other way around). It's ok if the status announces
4613 the new Builder before it's really ready, as the outside world can
4614 only see the BuilderStatus object anyway (and it is ready before
4615 builderAdded returns). Use the builder's "builddir" (which
4616 normally specifies where the slave will run the builder) as the
4617 master's basedir (for saving serialized builds).
4619 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4620 coerce the logfile to IStatusLog before trying to get the text
4621 chunks out of it. This will pull the full (non-stubified) Build in
4622 from disk if necessary.
4623 (TextLog): fix the adapter registration
4625 * buildbot/test/test_control.py (Force.setUp): create the basedir
4626 * buildbot/test/test_web.py: same
4627 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4628 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4629 * buildbot/test/test_run.py (Run.testMaster): same
4630 (Status.setUp): same
4632 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4634 * buildbot/status/html.py (Waterfall.__init__): store actual
4635 allowForce flag passed in rather than using True for everyone;
4636 make sure setting it to False doesn't cause a NameError
4638 (StatusResourceBuilder.__init__) add the builder name to the page
4640 (StatusResourceBuilder.body) move HTML generation for a name/value
4641 row into a helper method (StatusResourceBuilder.make_row); only
4642 generate the "Force Build" form if allowForce was True and the
4643 slave is connected. Use class attributes in the generated HTML to
4644 spread a little CSS-joy.
4646 2004-09-28 Brian Warner <warner@lothar.com>
4648 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4649 warning-scanner to not ignore things like
4650 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4652 * buildbot/status/html.py (StatusResource.control): add some
4653 class-level values for .control in an attempt to make upgrading
4656 * buildbot/util.py (ComparableMixin): survive missing attributes,
4657 such as when a class is modified and we're comparing old instances
4660 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4661 failure handling, remove a redundant try/except block. Don't
4662 return the full traceback to the IRC channel.
4663 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4664 error messages. Get ETA properly.
4666 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4667 the reason, since (at least) IRC message will have <> in them.
4668 (StatusResourceBuilder.__init__): take an IBuilderControl
4669 (StatusResourceBuilder.force): use the IBuilderControl we get in
4670 the constructor instead of trying to make our own. Catch the
4671 new exceptions and ignore them for now (until we make an
4672 intermediate web page where we could show the error message)
4673 (StatusResource): create with an IControl, use it to give an
4674 IBuilderControl to all children
4675 (Waterfall): take an allowForce= option, pass an IControl object
4676 to StatusResource if it is True
4678 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4680 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4681 catch new exceptions and return string forms
4683 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4684 * buildbot/process/builder.py (Builder.forceBuild): raise them
4685 * buildbot/test/test_control.py (Force.testNoSlave): new test
4686 (Force.testBuilderInUse): same
4689 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4691 * buildbot/test/test_run.py: use IControl
4692 * buildbot/test/test_vc.py: same
4694 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4695 to use IControl. Still offline.
4696 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4698 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4699 who=None so periodic builds don't send out status mail
4700 (Builder.forceBuild): include reason in the log message
4701 (BuilderControl.forceBuild): rename 'name' to 'who'
4703 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4704 'who' parameter, but make it None by default so builds forced by
4705 slave admins don't cause status mail to be sent to anybody
4706 (BotMaster.forceBuild): same. this method is deprecated.
4707 (DebugPerspective.perspective_forceBuild): same, use IControl.
4708 (DebugPerspective.perspective_fakeChange): use IControl..
4709 (Dispatcher.requestAvatar): .. so don't set .changemaster
4711 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4712 parameter to avoid confusion with the name of the builder
4715 * buildbot/status/mail.py: refine comment about needing 2.3
4717 * buildbot/status/html.py: move all imports to the top
4719 * buildbot/test/test_control.py: test new interfaces
4720 * buildbot/test/test_run.py (Status): handle new interfaces
4721 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4723 * buildbot/process/base.py (BuildControl): implement IBuildControl
4724 and its lonely getStatus() method
4726 * buildbot/process/builder.py (BuilderControl): implement
4727 IBuilderControl, obtained by adapting the Builder instance
4728 (Builder.startBuild): return a BuilderControl instead of a
4729 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4730 accomplish the same thing.
4732 * buildbot/master.py: move all import statements to the top
4733 (Control): implement IControl, obtained by adapting the
4734 BuildMaster instance.
4736 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4737 IBuildControl. These are used to force builds. Eventually they
4738 will provide ways to reconfigure the Builders, pause or abandon a
4739 Build, and perhaps control the BuildMaster itself.
4741 2004-09-26 Brian Warner <warner@lothar.com>
4743 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4744 ends up comparing us against something without a .__class__
4746 2004-09-24 Brian Warner <warner@lothar.com>
4748 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4751 * Makefile: add 'deb-snapshot' target, to create a timestamped
4754 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4756 2004-09-23 Brian Warner <warner@lothar.com>
4758 * buildbot/__init__.py (version): move version string here
4759 * setup.py: get version string from buildbot.version
4760 * buildbot/status/html.py (WaterfallStatusResource.body): add
4761 buildbot version to the page footer
4762 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4765 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4766 slaves, let the second know where the first one is coming from
4767 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4768 see our exceptions. It would be nice if there were a way to just
4769 send them the exception type and value, not the full traceback.
4772 * buildbot/status/mail.py (MailNotifier): add a new argument
4773 sendToInterestedUsers=, which can be set to False to disable the
4774 usual send-to-blamelist behavior.
4775 (top): handle python-2.2 which has no email.MIMEMultipart
4776 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4777 (MailNotifier.disownServiceParent): unsubscribe on removal
4779 * buildbot/test/test_status.py (Mail.testBuild2): test it
4782 * buildbot/status/progress.py (Expectations.wavg): tolerate
4783 current=None, which happens when steps start failing badly
4784 * buildbot/test/test_status.py (Progress.testWavg): test for it
4786 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4787 doesn't understand args['revision'], emit a warning instead of
4788 bailing completely. Updating to -rHEAD is probably close enough.
4790 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4792 * buildbot/test/test_status.py: at least import bb.status.client
4793 even if we don't have any test coverage for it yet
4795 * contrib/svn_buildbot.py: don't require python2.3
4796 (main): wait, do require it (for sets.py), but explain how to
4797 make it work under python2.2
4799 2004-09-23 Brian Warner <warner@lothar.com>
4801 * contrib/svn_buildbot.py: include the revision number in the Change
4803 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4804 using util.now() because FreshCVS is a realtime service
4806 * buildbot/status/event.py: delete dead code
4807 * buildbot/process/step.py: don't import dead Event class
4808 * buildbot/process/step_twisted.py: same
4809 * buildbot/status/builder.py: same
4810 * buildbot/status/client.py: same
4812 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4814 * buildbot/changes/changes.py (Change): set .when from an __init__
4815 argument (which defaults to now()), rather than having
4816 ChangeMaster.addChange set it later.
4817 (ChangeMaster.addChange): same
4819 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4820 (parseSyncmail): same. Just use util.now() for now.
4821 (parseBonsaiMail): parse the timestamp field for when=
4823 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4824 instead of setting .when after the fact
4828 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4829 results when the target project uses retrial. Still under
4831 * buildbot/test/test_trial.py: same
4833 2004-09-21 Brian Warner <warner@lothar.com>
4835 * buildbot/status/mail.py (MailNotifier.__init__): include
4836 success/warnings/failure in the Subject line
4837 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4838 use step.logname for the addLogs=True attachment filenames
4839 * buildbot/test/test_status.py (Mail): test Subject lines
4840 (Mail.testLogs): test attachment filenames
4842 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4843 accept a 'who' argument from the debug tool
4844 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4845 * contrib/debug.glade: add text box to set 'who'
4847 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4848 .getBuilderName with .getBuilder().getName(), more flexible
4849 (IStatusLog.getName): logs have short names, but you can prefix
4850 them with log.getStep().getName() to make them more useful
4851 * buildbot/status/builder.py: same
4852 * buildbot/status/client.py: same
4853 * buildbot/status/html.py: same
4854 * buildbot/test/test_run.py (Status.testSlave): same
4855 * buildbot/process/step.py: tweak logfile names
4857 * buildbot/status/mail.py (MailNotifier): add lookup, change
4858 argument to extraRecipients. The notifier is now aimed at sending
4859 mail to the people involved in a particular build, with additional
4860 constant recipients as a secondary function.
4862 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4863 including slow-lookup and failing-lookup. Make sure the blamelist
4864 members are included.
4866 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4867 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4868 (IBuildStatus.getInterestedUsers): new method
4869 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4870 * buildbot/status/client.py (remote_getResponsibleUsers): same
4871 * buildbot/status/html.py (StatusResourceBuild.body): same
4872 * buildbot/test/test_run.py (Status.testSlave): same
4874 2004-09-20 Brian Warner <warner@lothar.com>
4876 * docs/users.xhtml: update concepts
4878 * Makefile: add a convenience makefile, for things like 'make
4879 test'. It is not included in the source tarball.
4881 2004-09-16 Brian Warner <warner@lothar.com>
4883 * NEWS: mention /usr/bin/buildbot, debian/*
4885 * debian/*: add preliminary debian packaging. Many thanks to
4886 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4887 it considerably since it left their hands, I am responsible for
4888 all breakage that's resulted.
4890 * bin/buildbot: create a top-level 'buildbot' command, to be
4891 installed in /usr/bin/buildbot . For now it's just a simple
4892 frontend to mktap/twistd/kill, but eventually it will be the entry
4893 point to the 'try' command and also a status client. It is also
4894 intended to support the upcoming debian-packaging init.d scripts.
4895 * buildbot/scripts/runner.py: the real work is done here
4896 * buildbot/scripts/__init__.py: need this too
4897 * buildbot/scripts/sample.cfg: this is installed in new
4898 buildmaster directories
4899 * setup.py: install new stuff
4901 2004-09-15 Brian Warner <warner@lothar.com>
4903 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4904 'file:' schema (the version shipped with OS-X was built without the
4906 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4907 updates the log-timestamp, to make sure it isn't still running after
4910 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4911 values to the config file.
4912 * docs/examples/hello.cfg: add examples
4913 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4914 * buildbot/status/builder.py (Status.getProjectURL): implement them
4915 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4916 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4917 * buildbot/status/html.py (WaterfallStatusResource): display them
4920 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4921 certain error cases don't suffer a secondary exception.
4922 (top): Skip tests if the corresponding VC tool is not installed.
4924 * buildbot/process/factory.py (Trial): introduce separate
4925 'buildpython' and 'trialpython' lists, since trialpython=[] is
4926 what you want to invoke /usr/bin/python, whereas ./setup.py is
4927 less likely to be executable. Add env= parameter to pass options
4928 to test cases (which is how I usually write tests, I don't know if
4929 anyone else does it this way).
4931 * buildbot/process/step_twisted.py (Trial): handle python=None.
4932 Require 'testpath' be a string, not a list. Fix tests= typo.
4933 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4935 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4936 way to deal with the possibility of removing the disconnect notify
4938 (CVS): add a 'login' parameter to give a password to 'cvs login',
4939 commonly used with pserver methods (where pw="" or pw="guest")
4941 * buildbot/slave/commands.py (SourceBase): move common args
4942 extraction and setup() to __init__, so everything is ready by the
4943 time setup() is called
4944 (CVS.start): call 'cvs login' if a password was supplied
4945 (ShellCommand): special-case PYTHONPATH: prepend the master's
4946 value to any existing slave-local value.
4948 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4949 don't have a remote, mark the builder as Offline. This whole
4950 function should probably go away and be replaced by individual
4952 (Builder.buildFinished): return the results to the build-finished
4953 deferred callback, helps with testing
4955 2004-09-14 Brian Warner <warner@lothar.com>
4957 * buildbot/test/test_vc.py: put all the repositories needed to run
4958 the complete tests into a single small (1.3MB) tarball, so I can
4959 make that tarball available on the buildbot web site. Test HTTP
4960 access (for Arch and Darcs) by spawning a temporary web server
4961 while the test runs.
4963 * docs/users.xhtml: new document, describe Buildbot's limited
4964 understanding of different human users
4966 * buildbot/test/test_vc.py: rearrange test cases a bit
4968 * buildbot/process/step_twisted.py (Trial): handle testpath=
4969 * buildbot/process/factory.py (Trial): update to use step.Trial
4971 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4973 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4974 the overall build text (which gives you 'failed 2 tests' rather
4976 (BuildStepStatus.text2): default to [], not None
4978 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4981 2004-09-12 Brian Warner <warner@lothar.com>
4983 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4984 log the whole exception if it's just an AttributeError (old slave)
4986 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4987 so (e.g.) sub-commands can be run in the right directory.
4988 (ShellCommand.start): accept an optional errorMessage= argument
4989 to make life easier for SVN.start
4990 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4992 (ShellCommand.start): move ['dir'] compatibility hack..
4993 (RemoteShellCommand.start): .. to here so everyone can use it
4995 * buildbot/process/step_twisted.py (Trial): use .workdir
4997 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4998 text displayed when debuild fails completely
4999 (Trial): snarf _trial_temp/test.log from the slave and display it
5001 2004-09-11 Brian Warner <warner@lothar.com>
5003 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5005 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5006 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5008 * buildbot/process/step.py (ShellCommand): call .createSummary
5009 before .evaluateCommand instead of the other way around. This
5010 makes it slightly easier to count warnings and then use that to
5011 set results=WARNINGS
5012 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5014 * buildbot/process/base.py (Build.buildFinished): update status
5015 before doing progress. It's embarrassing for the build to be stuck
5016 in the "building" state when an exceptions occurs elsewhere..
5018 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5019 python2.2 doesn't have 'sum'
5021 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5022 to prevent clients from accidentally sorting it
5024 * buildbot/master.py (Manhole): add username/password
5025 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5026 c['manholePort'], deprecate old usage
5027 * docs/config.xhtml: document c['manhole']
5028 * docs/examples/hello.cfg: show example of using a Manhole
5031 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5032 pretend the slave is up to date
5034 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5035 the module, overlaps with 'log', the local variable
5037 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5039 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5040 new method to let Steps find out the version of their
5041 corresponding SlaveCommand.
5042 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5043 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5044 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5046 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5047 (Arch.startVC): same
5048 (P4Sync.startVC): same
5050 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5051 Deferred so we can catch errors in remote_startCommand
5052 (RemoteShellCommand.start): same
5054 * docs/examples/twisted_master.cfg: update sample config file
5056 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5057 after connectionMade() is called, not before. Close stdin at that
5060 * buildbot/process/process_twisted.py: update to use Trial, clean
5061 up argument passing (move to argv arrays instead of string
5064 * buildbot/process/step_twisted.py (Trial): new step to replace
5065 RunUnitTests, usable by any trial-using project (not just
5066 Twisted). Arguments have changed, see the docstring for details.
5068 * buildbot/process/base.py (Build.startBuild): this now returns a
5069 Deferred. Exceptions that occur during setupBuild are now
5070 caught better and lead to fewer build_status weirdnesses, like
5071 finishing a build that was never started.
5072 (Build.buildFinished): fire the Deferred instead of calling
5073 builder.buildFinished directly. The callback argument is this
5074 Build, everything else can be extracted from it, including the
5075 new build.results attribute.
5076 * buildbot/process/builder.py (Builder.startBuild): same
5077 (Builder.buildFinished): same, extract results from build
5079 * buildbot/process/step.py (ShellCommands): remove dead code
5081 2004-09-08 Brian Warner <warner@lothar.com>
5083 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5084 doesn't try to use the leftover patched workdir
5085 (SourceStamp): test source-stamp computation for CVS and SVN
5087 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5088 patched workdir ('touch .buildbot-patched') so we don't try to
5090 (SourceBase.start): add ['revision'] for all Source steps
5091 (CVS): change args: use ['branch'] for -r, remove ['files']
5092 (CVS.buildVC): fix revision/branch stuff
5093 (SVN): add revision stuff
5095 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5096 kwargs (except 'workdir') to avoid silent spelling errors
5097 (ShellCommand.__init__): same
5098 (Source): new base class for CVS/SVN/etc. Factor out everything
5099 common, add revision computation (perform the checkout with a -D
5100 DATE or -r REVISION that gets exactly the sources described by the
5101 last Change), overridable with step.alwaysUseLatest. Add patch
5102 handling (build.getSourceStamp can trigger the use of a base
5103 revision and a patch).
5104 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5105 * docs/steps.xhtml: update docs
5106 * docs/source.xhtml: mention .checkoutDelay
5107 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5109 * buildbot/process/base.py (Build.setSourceStamp): add a
5110 .sourceStamp attribute to each Build. If set, this indicates that
5111 the build should be done with something other than the most
5112 recent source tree. This will be used to implement "try" builds.
5113 (Build.allChanges): new support method
5114 (Build.lastChangeTime): remove, functionality moved to Source steps
5115 (Build.setupBuild): copy the Step args before adding ['workdir'],
5116 to avoid modifying the BuildFactory (and thus triggering spurious
5120 * buildbot/status/html.py: rename s/commits/changes/
5121 (StatusResourceChanges): same
5122 (CommitBox.getBox): same, update URL
5123 (WaterfallStatusResource): same
5124 (StatusResource.getChild): same
5126 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5127 * contrib/debug.glade: add optional 'revision' to the fakeChange
5129 * buildbot/changes/changes.py (html_tmpl): display .revision
5130 (ChangeMaster.addChange): note .revision in log
5131 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5132 accept a ['revision'] attribute
5134 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5136 * buildbot/master.py (BotMaster.getPerspective): update the
5137 .connected flag in SlaveStatus when it connects
5138 (BotMaster.detach): and when it disconnects
5139 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5140 (BuildMaster.loadConfig_Builders): walk old list correctly
5142 * buildbot/test/test_config.py: fix prefix= usage
5144 2004-09-06 Brian Warner <warner@lothar.com>
5148 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5149 poll a P4 depot looking for recent changes. Thanks to Dave
5150 Peticolas for the contribution. Probably needs some testing after
5153 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5154 requires manual client setup for each buildslave. Rather
5155 experimental. Thanks again to Dave Peticolas.
5156 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5158 * buildbot/changes/changes.py (Change): add a .revision attribute,
5159 which will eventually be used to generate source-stamp values.
5161 * buildbot/process/step.py (RemoteCommand.start): use
5162 notifyOnDisconnect to notice when we lose the slave, then treat it
5163 like an exception. This allows LogFiles to be closed and the build
5164 to be wrapped up normally. Be sure to remove the disconnect
5165 notification when the step completes so we don't accumulate a
5166 bazillion such notifications which will fire weeks later (when the
5167 slave finally disconnects normally). Fixes SF#915807, thanks to
5168 spiv (Andrew Bennetts) for the report.
5169 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5170 really isn't Logged- specific
5171 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5172 header, since it's almost always going to be appended to an
5174 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5175 update test to handle use of notifyOnDisconnect
5177 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5178 don't clear .ETA and .currentBuild when going offline, let the
5179 current build clean up after itself
5181 * buildbot/process/builder.py (Builder.detached): wait a moment
5182 before doing things like stopping the current build, because the
5183 current step will probably notice the disconnect and cleanup the
5185 * buildbot/test/test_run.py (Status.tearDown): update test to
5186 handle asynchronous build-detachment
5188 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5190 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5191 hush a debug message
5193 2004-09-05 Brian Warner <warner@lothar.com>
5195 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5196 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5197 kernels do this: the fcntl module has the F_NOTIFY constant, but
5198 the kernel itself doesn't support the operation. Thanks to Olly
5199 Betts for spotting the problem.
5201 * buildbot/process/step.py (Darcs): new source-checkout command
5202 (Arch): new source-checkout command
5203 (todo_P4): fix constructor syntax, still just a placeholder
5204 * buildbot/test/test_vc.py (VC.testDarcs): test it
5205 (VC.testDarcsHTTP): same, via localhost HTTP
5207 (VC.testArchHTTP): same
5208 * NEWS: mention new features
5210 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5211 which tells the step to stash stdout text locally (in .stdout).
5212 Slave-side Commands can use this to make decisions based upon the
5213 output of the the ShellCommand (not just the exit code).
5214 (Darcs): New source-checkout command
5215 (Arch): New source-checkout command, uses .keepStdout in one place
5216 where it needs to discover the archive's default name.
5218 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5219 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5220 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5222 * buildbot/process/step.py (ShellCommand.describe): add an
5223 alternate .descriptionDone attribute which provides descriptive
5224 text when the step is complete. .description can be ["compiling"],
5225 for use while the step is running, then .descriptionDone can be
5226 ["compile"], used alone when the step succeeds or with "failed" when
5227 it does not. Updated other steps to use the new text.
5228 * buildbot/process/step_twisted.py: same
5229 * buildbot/test/test_run.py: update tests to match
5231 2004-08-30 Brian Warner <warner@lothar.com>
5233 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5234 (CVS.__init__): send 'patch' argument to slave
5235 (CVS.start): don't create the LoggedRemoteCommand until start(),
5236 so we can catch a .patch added after __init__
5237 (SVN.__init__): add 'patch' to SVN too
5240 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5241 argument, to let commands push data into the process' stdin pipe.
5242 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5243 is in use, since closing a PTY doesn't really affect the process
5244 in the right way (in particular, I couldn't run /usr/bin/patch
5246 (SourceBase.doPatch): handle 'patch' argument
5248 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5251 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5252 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5254 * buildbot/master.py (BotPerspective.got_commands): get command
5255 versions from slave, give to each builder
5256 * buildbot/process/builder.py (Builder.attached): stash slave
5257 command versions in .remoteCommands
5259 * docs/steps.xhtml: bring docs in-line with reality
5261 * buildbot/process/step.py (CVS.__init__): more brutal
5262 compatibility code removal
5263 (SVN.__init__): same
5265 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5266 (SlaveShellCommand.start): require ['workdir'] argument, remove
5267 the ['dir'] fallback (compatibility will come later)
5268 (SourceBase): update docs
5269 (SourceBase.start): remove ['directory'] fallback
5272 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5273 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5274 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5276 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5277 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5278 code.. I will figure out 0.5.0-compatibility hooks later)
5280 2004-08-30 Brian Warner <warner@lothar.com>
5282 * buildbot/process/process_twisted.py: rewrite in terms of new
5283 BuildFactory base class. It got significantly shorter. Yay
5286 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5287 work with the new "self.build isn't nailed down until we call
5288 step.start()" scheme: specifically, __init__ is called before the
5289 build has decided on which Changes are going in, so we don't scan
5290 build.allFiles() for .xhtml files until start()
5291 (HLint.commandComplete): use getText(), not getStdout()
5292 (RunUnitTests.start): same: don't use .build until start()
5293 (RunUnitTests.describe): oops, don't report (None) when using
5295 (RunUnitTests.commandComplete): use getText()
5296 (RunUnitTests.createSummary): same
5297 (BuildDebs.commandComplete): same
5299 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5300 set args['command'] until start(), since our BuildStep is allowed
5301 to change their mind up until that point
5302 (TreeSize.commandComplete): use getText(), not getStdout()
5304 * docs/examples/twisted_master.cfg: update to current standards
5306 * docs/factories.xhtml: update
5307 * buildbot/process/factory.py: implement all the common factories
5308 described in the docs. The Trial factory doesn't work yet, and
5309 I've probably broken all the process_twisted.py factories in the
5310 process. There are compatibility classes left in for things like
5311 the old BasicBuildFactory, but subclasses of them are unlikely to
5313 * docs/examples/glib_master.cfg: use new BuildFactories
5314 * docs/examples/hello.cfg: same
5316 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5317 explicit 'workdir' args
5319 * buildbot/process/base.py (BuildFactory): move factories to ..
5320 * buildbot/process/factory.py (BuildFactory): .. here
5321 * buildbot/process/process_twisted.py: handle move
5322 * buildbot/test/test_config.py: same
5323 * buildbot/test/test_run.py: same
5324 * buildbot/test/test_steps.py: same
5325 * buildbot/test/test_vc.py: same
5326 * docs/factories.xhtml: same
5328 * NEWS: mention config changes that require updating master.cfg
5330 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5331 argument to all steps that weren't given one already, pointing at
5332 the "build/" directory.
5334 * docs/examples/hello.cfg: remove explicit 'workdir' args
5336 * docs/factories.xhtml: document standard BuildFactory clases,
5337 including a bunch which are have not yet been written
5339 2004-08-29 Brian Warner <warner@lothar.com>
5341 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5342 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5343 buildbot.status.builder so they aren't quite so internal
5344 * buildbot/process/base.py, buildbot/process/builder.py: same
5345 * buildbot/process/maxq.py, buildbot/process/step.py: same
5346 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5347 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5348 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5350 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5351 to handle new getLogs()-returns-list behavior
5352 (StatusResourceBuildStep.getChild): same
5353 (StepBox.getBox): same
5354 (WaterfallStatusResource.phase0): same
5356 * docs/source.xhtml: document how Buildbot uses version-control
5357 systems (output side: how we get source trees)
5358 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5359 systems (input side: how we learn about Changes)
5361 * buildbot/master.py (Manhole): use ComparableMixin
5362 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5363 * buildbot/changes/mail.py (MaildirSource): same
5364 * buildbot/status/client.py (PBListener): same
5365 * buildbot/status/html.py (Waterfall): same
5366 * buildbot/status/words.py (IRC): same
5368 * NEWS: start describing new features
5370 * buildbot/status/mail.py (MailNotifier): finish implementation.
5371 The message body is still a bit sparse.
5372 * buildbot/test/test_status.py (Mail): test it
5374 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5375 and __hash__ methods I wind up adding everywhere. Specifically
5376 intended to support the buildbot config-file update scheme where
5377 we compare, say, the old list of IStatusTargets against the new
5378 one and don't touch something which shows up on both lists.
5379 * buildbot/test/test_util.py (Compare): test case for it
5381 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5382 return a list instead of a dict
5383 (IBuildStepStatus.getLogs): same. The idea is that steps create
5384 logs with vaguely unique names (although their uniqueness is not
5385 guaranteed). Thus a compilation step should create its sole
5386 logfile with the name 'compile', and contribute it to the
5387 BuildStatus. If a step has two logfiles, try to create them with
5388 different names (like 'test.log' and 'test.summary'), and only
5389 contribute the important ones to the overall BuildStatus.
5390 * buildbot/status/builder.py (Event.getLogs): same
5391 (BuildStepStatus): fix default .text and .results
5392 (BuildStepStatus.addLog): switch to list-like .getLogs()
5393 (BuildStepStatus.stepFinished): same
5394 (BuildStatus.text): fix default .text
5395 (BuildStatus.getLogs): temporary hack to return all logs (from all
5396 child BuildStepStatus objects). Needs to be fixed to only report
5397 the significant ones (as contributed by the steps themselves)
5398 * buildbot/test/test_run.py: handle list-like .getLogs()
5399 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5401 2004-08-28 Brian Warner <warner@lothar.com>
5403 * buildbot/process/builder.py (Builder.attached): serialize the
5404 attachment process, so the attach-watcher isn't called until the
5405 slave is really available. Add detached watchers too, which makes
5408 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5410 * buildbot/test/test_swap.py: remove dead code
5412 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5413 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5414 sort of as if the command being run exited with a -1. There may
5415 still be some holes in this scheme.
5416 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5417 -r option appears before the module list
5418 * buildbot/process/step.py (CVS): add 'revision' argument
5420 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5421 when sending updates or stepComplete messages to the master, since
5422 we don't currently care whether they arrive or not. When we revamp
5423 the master/slave protocol to really resume interrupted builds,
5424 this will need revisiting.
5425 (lostRemote): remove spurious print
5427 * buildbot/master.py (BotPerspective.attached): serialize the
5428 new-builder interrogation process, to make testing easier
5429 (BotMaster.waitUntilBuilderDetached): convenience function
5431 * buildbot/status/builder.py (BuilderStatus): prune old builds
5432 (BuildStatus.pruneSteps): .. and steps
5433 (BuildStepStatus.pruneLogs): .. and logs
5434 (BuilderStatus.getBuild): handle missing builds
5435 * buildbot/status/html.py (StatusResourceBuild.body): display build
5436 status in the per-build page
5437 (BuildBox.getBox): color finished builds in the per-build box
5439 2004-08-27 Brian Warner <warner@lothar.com>
5441 * buildbot/status/mail.py (MailNotifier): new notification class,
5444 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5445 variants of a common base class which handles all the mode= logic
5447 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5449 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5451 2004-08-26 Brian Warner <warner@lothar.com>
5453 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5456 * buildbot/test/test_run.py: update to new Logfile interface, new
5457 buildbot.slave modules
5458 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5460 * MANIFEST.in: new sample config file
5461 * docs/examples/hello.cfg: same
5463 * buildbot/process/step_twisted.py: remove dead import
5465 * buildbot/process/step.py (RemoteCommand.run): catch errors
5467 (RemoteCommand.remote_update): ignore updates that arrive after
5469 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5470 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5471 the responsibilities of the subclass's methods
5472 (BuildStep.failed): catch errors during failure processing
5473 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5474 (CVS): move to a mode= argument (described in docstring), rather
5475 than the ungainly clobber=/export=/copydir= combination.
5476 (SVN): add mode= functionality to SVN too
5477 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5479 * buildbot/process/base.py (Build.startNextStep): catch errors
5480 during s.startStep()
5482 * buildbot/clients/base.py: update to new PB client interface.
5483 gtkPanes is still broken
5485 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5486 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5487 * setup.py: add buildbot.slave module
5488 * buildbot/bb_tap.py: handle move
5489 * buildbot/slave/registry.py: place to register commands, w/versions
5490 * buildbot/slave/bot.py: major simplifications
5491 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5492 instead of a fixed table. Eventually this will make the slave more
5493 extensible. Use 'start' method on the command, not .startCommand.
5494 Fix unsafeTracebacks handling (I think).
5495 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5496 helper class with a .start method that returns a Deferred.
5497 SlaveShellCommand is the form reached by the buildmaster. Commands
5498 which use multiple ShellCommands can just chain them as Deferreds,
5499 with some helper methods in Command (_abandonOnFailure and
5500 _checkAbandoned) to bail on rc!=0.
5501 (CVSCommand): prefer new mode= argument
5502 (SVNFetch): add mode= argument
5504 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5505 put a useful reason string on the build
5507 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5508 core functionality into an IStatusLog object
5509 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5510 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5511 (StatusResourceBuild.body): use proper accessor methods
5512 * buildbot/status/client.py (RemoteLog): PB-access goes here
5513 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5514 which delivers log contents too
5515 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5516 * buildbot/status/event.py: remove old Logfile completely
5518 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5519 subscription interface for IStatusLog subscriptions just like all
5520 other the status subscriptions
5521 (IStatusReceiver.logChunk): method called on subscribers
5523 2004-08-24 Brian Warner <warner@lothar.com>
5525 * buildbot/process/builder.py (Builder._pong): oops, ping response
5526 includes a result (the implicit None returned by remote_print).
5527 Accept it so the _pong method handles the response correctly.
5529 2004-08-06 Brian Warner <warner@lothar.com>
5531 * buildbot/test/test_config.py: update IRC, PBListener tests
5533 * buildbot/status/client.py (StatusClientPerspective): total
5534 rewrite to match new IStatus interfaces. New subscription scheme.
5535 There are still a few optimizations to make (sending down extra
5536 information with event messages so the client doesn't have to do a
5537 round trip). The logfile-retrieval code is probably still broken.
5538 Moved the PB service into its own port, you can no longer share a
5539 TCP socket between a PBListener and, say, the slaveport (this
5540 should be fixed eventually).
5541 * buildbot/clients/base.py (Client): revamp to match. still needs
5542 a lot of work, but basic event reporting works fine. gtkPanes is
5545 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5546 instance talks to a single irc server. Threw out all the old
5547 multi-server handling code. Still need to add back in
5548 builder-control (i.e. "force build")
5550 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5551 more random text to the as-yet-unreachable per-step page
5553 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5554 rename to stepETAUpdate
5555 (BuildStatus.subscribe): add build-wide ETA updates
5556 (BuilderStatus.getState): remove more cruft
5557 (BuilderStatus.getCurrentBuild): remove more cruft
5558 (BuilderStatus.buildStarted): really handle tuple-subscription
5559 * buildbot/test/test_run.py (Status.testSlave): handle the
5560 stepETAUpdate rename
5562 * buildbot/master.py (BuildMaster): don't add a default
5563 StatusClientService. Don't add a default IrcStatusFactory. Both
5564 are now added through c['status'] in the config file. c['irc'] is
5565 accepted for backwards compatibility, the only quirk is you cannot
5566 use c['irc'] to specify IRC servers on ports other than 6667.
5568 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5569 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5570 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5571 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5574 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5575 the buildmaster to re-read its config file
5578 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5579 find out the port our server is running on
5580 (WebTest.test_webPathname_port): same
5582 * buildbot/test/test_config.py (testWebPortnum): test it
5583 (testWebPathname): ditto
5585 * docs/config.xhtml: document new c['status'] configuration option
5587 * buildbot/status/html.py (Waterfall): new top-level class which
5588 can be added to c['status']. This creates the Site as well as the
5589 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5590 reachable as .parent, for everything.
5592 * buildbot/master.py (Manhole): make it a normal service Child
5593 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5594 webPathname. It will eventually replace c['irc'] and the implicit
5595 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5596 in as (deprecated) backward compatibility hooks for now.
5599 * buildbot/process/builder.py (Builder.buildFinished): don't
5600 inform out builder_status about a finished build, as it finds out
5601 through its child BuildStatus object
5603 * buildbot/status/html.py: extensive revamp. Use adapters to make
5604 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5605 have both starting and finishing times and adjust the waterfall
5606 display accordingly, using spacers if necessary. Use SlaveStatus
5607 to get buildslave info.
5608 (StatusResourceBuildStep): new just-one-step resource, used to get
5609 logfiles. No actual href to it yet.
5611 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5612 the time being, until I get the file-naming scheme right
5614 * buildbot/status/builder.py (Event): clean started/finished names
5615 (BuildStatus.isFinished): .finished is not None is the right test
5616 (BuildStatus.buildStarted): track started/finished times ourselves
5617 (BuilderStatus.getSlave): provide access to SlaveStatus object
5618 (BuilderStatus.getLastFinishedBuild): all builds are now in
5619 .builds, even the currently-running one. Accomodate this change.
5620 (BuilderStatus.eventGenerator): new per-builder event generator.
5621 Returns BuildStepStatus and BuildStatus objects, since they can
5622 both be adapted as necessary.
5623 (BuilderStatus.addEvent): clean up started/finished attributes
5624 (BuilderStatus.startBuild,finishBuild): remove dead code
5625 (SlaveStatus): new object to provide ISlaveStatus
5627 * buildbot/process/step.py (ShellCommand.getColor): actually
5628 return the color instead of setting it ourselves
5629 (CVS.__init__): pull .timeout and .workdir options out of
5630 **kwargs, since BuildStep will ignore them. Without this neither
5631 will be sent to the slave correctly.
5632 (SVN.__init__): same
5634 * buildbot/process/builder.py (Builder): move flags to class-level
5636 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5637 SlaveStatus handle that
5639 * buildbot/process/base.py (Build.firstEvent): remove dead code
5640 (Build.stopBuild): bugfix
5642 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5644 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5645 (ChangeMaster.eventGenerator): yield Changes, since there are now
5646 Adapters to turn them into HTML boxes
5648 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5649 (BotPerspective.attached): feed a SlaveStatus object
5650 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5651 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5653 * buildbot/interfaces.py: API additions
5654 (ISlaveStatus): place to get slave status
5656 2004-08-04 Brian Warner <warner@lothar.com>
5658 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5659 the delay finishes, so the step is marked as SUCCESS
5661 * buildbot/test/test_run.py (Status.testSlave): cover more of
5662 IBuildStatus and IBuildStepStatus
5664 * buildbot/status/progress.py (StepProgress): move some flags to
5665 class-level attributes
5666 (StepProgress.remaining): if there are no other progress metrics
5667 to go by, fall back to elapsed time
5668 (StepProgress.setExpectations): take a dict of metrics instead of
5670 (BuildProgress.setExpectationsFrom): pull expectations from the
5671 Expectations, instead of having it push them to the BuildProgress
5672 (Expectations): move some flags to class-level attributes
5673 (Expectations.__init__): copy per-step times from the
5675 (Expectations.expectedBuildTime): new method for per-build ETA
5677 * buildbot/status/event.py (Logfile): move some flags to
5678 class-level attributes
5679 (Logfile.logProgressTo): better method name, let step set the
5680 progress axis name (instead of always being "output")
5682 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5683 times directly, rather than depending upon the (possibly missing)
5684 .progress object. Use 'None' to indicate "not started/finished
5686 (BuildStepStatus.getExpectations): oops, return the full list of
5688 (BuilderStatus._buildFinished): append finished builds to .builds
5690 * buildbot/process/step.py (BuildStep): add separate .useProgress
5691 flag, since empty .progressMetrics[] still implies that time is a
5693 (CVS): set up the cmd in __init__, instead of waiting for start()
5695 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5696 calculation, this will eventually turn into a proper sourceStamp
5697 (Build.setupBuild): tell the Progress to load from the Expectations,
5698 instead of having the Expectations stuff things into the Progress
5699 (Build.buildException): add a build-level errback to make sure the
5700 build's Deferred fires even in case of exceptions
5702 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5704 * buildbot/process/builder.py (Builder.forceBuild): convey the
5705 reason instead of creating a fake Change
5707 * docs/examples/twisted_master.cfg: update to match reality
5709 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5710 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5711 fix or remove broken/breaking tests
5713 * buildbot/status/event.py (Logfile.__len__): remove evil method
5715 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5716 missing .build, for test convenience
5718 * buildbot/process/step_twisted.py: import fixes
5720 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5722 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5723 .statusbag reference
5725 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5726 connection at shutdown, and stop it from reconnecting
5728 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5729 chase down remote-execution bugs
5731 * buildbot/process/step.py: more fixes, remove
5732 BuildStep.setStatus()
5733 * buildbot/status/builder.py: move setStatus() functionality into
5735 * buildbot/status/event.py: minor fixes
5737 2004-08-03 Brian Warner <warner@lothar.com>
5739 * buildbot/process/base.py, buildbot/process/builder.py
5740 * buildbot/process/step.py, buildbot/status/builder.py
5741 * buildbot/status/event.py, buildbot/test/test_run.py:
5742 fix status delivery, get a basic test case working
5743 * buildbot/master.py: finish implementing basic status delivery,
5744 temporarily disable HTML/IRC/PB status sources
5746 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5748 * buildbot/status/progress.py (BuildProgress): remove dead code
5750 * buildbot/interfaces.py
5751 * buildbot/process/base.py, buildbot/process/builder.py
5752 * buildbot/process/step.py, buildbot/process/step_twisted.py
5753 * buildbot/status/builder.py: Complete overhaul of the all
5754 status-delivery code, unifying all types of status clients (HTML,
5755 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5756 look like. This commit is a checkpointing of the work-in-progress:
5757 the input side is mostly done (Builders/Builds sending status
5758 to the BuilderStatus/BuildStatus objects), but the output side has
5759 not yet been started (HTML resources querying BuilderStatus
5760 objects). Things are probably very broken right now and may remain
5761 so for several weeks, I apologize for the disruption.
5763 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5764 HTML as the log's contents. Currently used for exception tracebacks.
5765 * buildbot/status/progress.py: minor spelling changes
5767 2004-08-02 Brian Warner <warner@lothar.com>
5769 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5770 in mozilla. Also added stylesheets copied from Twisted's docs.
5771 Remember that these files are meant to be run through Lore first.
5772 Thanks to Philipp Frauenfelder for the fixes.
5773 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5774 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5775 * docs/template.tpl: added a Lore template
5777 2004-07-29 Brian Warner <warner@lothar.com>
5779 * buildbot/interfaces.py: revamp status delivery. This is the
5780 preview: these are the Interfaces that will be provided by new
5781 Builder code, and to which the current HTML/IRC/PB status
5782 displayers will be adapted.
5784 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5785 on the SlaveBuilder, not the Bot.
5786 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5788 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5789 set .usePTY on the FakeSlaveBuilder
5791 2004-07-25 Brian Warner <warner@lothar.com>
5793 * buildbot/changes/freshcvs.py: add some debug log messages
5794 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5795 disabled 'setFilter' syntax
5796 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5797 don't end with a slash
5799 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5801 * setup.py: bump to 0.5.0+ while between releases
5803 2004-07-23 Brian Warner <warner@lothar.com>
5805 * setup.py (version): Releasing buildbot-0.5.0
5807 2004-07-23 Brian Warner <warner@lothar.com>
5809 * README: update for 0.5.0 release
5811 * NEWS: update for 0.5.0 release
5813 2004-07-22 Brian Warner <warner@lothar.com>
5815 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5816 mktap-time configuration flag (--usepty=1, --usepty=0)
5817 * buildbot/bot.py: same
5819 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5820 an 'info' directory being unwanted
5822 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5823 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5824 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5825 and earlier), use a FreshCVSSourceOldcred instead.
5826 (test): simple test routine: connect to server, print changes
5828 * buildbot/changes/changes.py (Change.getTime): make it possible
5829 to print un-timestamped changes
5831 * buildbot/master.py (makeApp): delete ancient dead code
5832 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5833 * buildbot/test/test_config.py (testFindConfigFile): test it
5835 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5836 instead of win32 one
5839 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5840 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5843 * buildbot/process/base.py (Builder.__init__): change constructor
5844 to accept a dictionary of config data, rather than discrete
5845 name/slave/builddir/factory arguments
5847 * docs/examples/twisted_master.cfg: update to new syntax
5848 * docs/examples/glib_master.cfg: same
5849 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5850 rough tests of the new syntax
5853 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5854 to be an int, which means "run a web.distrib sub-server on a TCP
5855 port". This lets you publish the buildbot status page to a remote
5856 twisted.web server (using distrib.ResourceSubscription). Also
5857 rename the local attributes used to hold these web things so
5858 they're more in touch with reality.
5859 * buildbot/test/test_web.py: test webPortnum and webPathname
5860 * docs/config.xhtml: document this new use of webPathname
5862 * docs/config.xhtml: new document, slightly ahead of reality
5864 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5865 'prefix' handling: treat it as a simple string to check with
5866 .startswith, instead of treating it as a directory. This allows
5867 sub-directories to be used. If you use prefix=, you should give it
5868 a string that starts just below the CVSROOT and ends with a slash.
5869 This prefix will be stripped from all filenames, and filenames
5870 which do not start with it will be ignored.
5872 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5874 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5875 and --exclude (inverse of --include). SVN post-commit hooks
5876 now have total control over which changes get sent to buildbot and which
5879 2004-07-10 Brian Warner <warner@lothar.com>
5881 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5882 test case to match new API
5884 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5885 which crashed HTML display when self.entries=[] (needed to
5886 distinguish between [], which means "no entries yet", and None,
5887 which means "the entries have been swapped out to disk, go fetch
5890 2004-07-04 Brian Warner <warner@lothar.com>
5892 * buildbot/process/step_twisted.py (countFailedTests): Count
5893 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5894 10kb from the end because any import errors are wedged there and
5895 they would make us think the test log was unparseable.
5896 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5898 2004-06-26 Brian Warner <warner@lothar.com>
5900 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5901 delete-*.pyc command into an actual BuildStep, so we can label it
5903 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5904 (FullTwistedBuildFactory): same
5906 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5908 * contrib/fakechange.py: Add an errback when sending the fake
5909 change, so we know it didn't work.
5911 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5913 * buildbot/process/step_twisted.py: Delete *.pyc files before
5914 calling trial, so it doesn't catch any old .pyc files whose .py
5915 files have been moved or deleted.
5917 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5918 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5919 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5920 instead of ["twisted.test"], so that the end result is "trial -R
5923 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5924 regular expression to match filenames that should be ignored when
5925 changed. Also add a --revision parameter that specifies the
5926 revision to examine, which is useful for debugging.
5928 2004-06-25 Brian Warner <warner@lothar.com>
5930 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5931 summary of warnings (like DeprecationWarnings), next to the
5934 2004-05-13 Brian Warner <warner@lothar.com>
5936 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5937 we now have a w32 build slave courtesy of Mike Taylor.
5939 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5940 so broken. Fixed a race condition that tripped up interlocked
5941 builds and caused the status to be stuck at "Interlocked" forever.
5942 The twisted buildbot's one interlocked build just so happened to
5943 never hit this case until recently (the feeding builds both pass
5944 before the interlocked build is attempted.. usually it has to wait
5946 (Builder._pong_failed): fix method signature
5948 * setup.py: bump to 0.4.3+ while between releases
5950 2004-04-30 Brian Warner <warner@lothar.com>
5952 * setup.py (version): Releasing buildbot-0.4.3
5954 2004-04-30 Brian Warner <warner@lothar.com>
5956 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5958 * README: update for 0.4.3 release
5960 * NEWS: update for 0.4.3 release
5962 * buildbot/master.py (BuildMaster.__getstate__): make sure
5963 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5965 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5966 .trial as a class attribute, for upgrade from 0.4.2
5968 * buildbot/changes/changes.py (Change.links): add .links for
5971 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5972 .textWatchers and .htmlWatchers at save time, since they are both
5973 volatile, should allow smooth 0.4.2 upgrade
5975 * buildbot/process/step.py (CVS.finishStatus): catch failed
5976 CVS/SVN commands so we can make the status box red
5978 2004-04-29 Brian Warner <warner@lothar.com>
5980 * buildbot/changes/freshcvs.py
5981 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5982 code to do setFilter(), which tells the freshcvs daemon to not
5983 send us stuff that we're not interested in. I will uncomment it
5984 when a new version of CVSToys is available in which setFilter()
5985 actually works, and I get a chance to test it better.
5987 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5989 * buildbot/master.py (Dispatcher): use a registration scheme
5990 instead of hardwired service names
5991 (BuildMaster): keep track of the Dispatcher to support
5994 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5995 PBChangeSource class instead of having it be an undocumented
5996 internal feature of the ChangeMaster. Split out the code into a
5998 * buildbot/changes/pb.py (PBChangeSource): same
5999 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6001 * docs/{factories|sources|steps}.xhtml: document some pieces
6003 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6004 using FCMaildirSource
6005 (f23osx): update OS-X builder to use python2.3, since the slave
6006 was updated to Panther (10.3.3)
6008 2004-03-21 Brian Warner <warner@lothar.com>
6010 * buildbot/process/process_twisted.py: factor out doCheckout, change
6011 to use SVN instead of CVS
6013 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6014 an SVN subclass easier
6015 (BasicSVN): subclass which uses Subversion instead of CVS
6017 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6019 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6021 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6023 2004-02-25 Brian Warner <warner@lothar.com>
6025 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6026 is now either a list (which is passed to spawnProcess directly) or
6027 a string (which gets passed to /bin/sh -c). This removes the useSH
6028 flag and the ArgslistCommand class. Also send status header at the
6029 start and end of each command, instead of having the master-side
6031 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6032 -r'. Update to use list-based arguments.
6033 (SVNFetch): use list-based arguments, use ['dir'] argument to
6035 * buildbot/test/test_steps.py (Commands): match changes
6037 * buildbot/process/step.py (InternalShellCommand.words): handle
6039 (SVN): inherit from CVS, cleanup
6041 * buildbot/status/event.py (Logfile.content): render in HTML, with
6042 stderr in red and headers (like the name of the command we're
6043 about to run) in blue. Add link to a second URL (url + "?text=1")
6044 to get just stdout/stderr in text/plain without markup. There is
6045 still a problem with .entries=None causing a crash, it seems to occur
6046 when the logfile is read before it is finished.
6048 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6049 timeout to the keepalives, and use it to explicitly do a
6050 loseConnection instead of waiting for TCP to notice the loss. This
6051 ought to clear up the silent-lossage problem.
6052 (unsafeTracebacks): pass exception tracebacks back to the master,
6053 makes it much easier to debug problems
6055 2004-02-23 Brian Warner <warner@lothar.com>
6057 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6058 the whole command to /bin/sh instead of execve [Johan Dahlin]
6059 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6060 '-r HEAD' [Johan Dahlin]
6061 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6063 * buildbot/changes/changes.py (Change): add links= argument, add
6064 asHTML method [Johan Dahlin]. Modified to make a bit more
6065 XHTMLish. Still not sure how to best use links= .
6067 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6068 Change.asHTML to display the change, not asText
6070 * buildbot/status/html.py (StatusResourceBuilder): web button to
6073 * buildbot/test/test_run.py: test to actually start a buildmaster
6076 * MANIFEST.in: bring back accidentally-dropped test helper files
6078 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6079 that require cvstoys if it is not installed
6081 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6082 values of "bin/trial" [Dave Peticolas]
6083 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6084 tests passed" when we didn't happen to run any tests
6086 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6087 flunkOnFailure [Johan Dahlin]
6089 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6090 multiple instances of the same Step class by suffixing "_2", etc,
6091 to the name until it is unique. This name needs to be unique
6092 because it is used as a key in the dictionary that tracks build
6094 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6097 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6099 2004-01-14 Brian Warner <warner@lothar.com>
6101 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6102 kicked from a channel, log it
6104 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6105 something over whatever IRC channels the buildmaster is currently
6106 connected to. Added to try and track down a problem in which the
6107 master thinks it is still connected but the IRCd doesn't see it. I
6108 used a styles.Versioned this time, so hopefully users won't have
6109 to rebuild their .tap files this time.
6110 * contrib/debug.glade: add a "Poke IRC" button
6111 * contrib/debugclient.py: same
6113 * setup.py: bump to 0.4.2+ while between releases
6115 2004-01-08 Brian Warner <warner@lothar.com>
6117 * setup.py (version): Releasing buildbot-0.4.2
6119 2004-01-08 Brian Warner <warner@lothar.com>
6121 * NEWS: update for 0.4.2 release
6123 * README: document how to run the tests, now that they all pass
6125 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6127 * buildbot/process/step.py (CVS): add a global_options= argument,
6128 which lets you set CVS global options for the command like "-r"
6129 for read-only checkout, or "-R" to avoid writing in the
6131 * buildbot/slavecommand.py (CVSCommand): same
6133 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6134 testing easier (it is turned off when testing, to avoid the
6137 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6138 to make it easier to test: break generateStepID() out to a
6139 separate function, only update statusbag if it exists.
6140 (ShellCommands): create useful text for dict-based commands too.
6142 * test/*, buildbot/test/*: move unit tests under the buildbot/
6144 * setup.py (packages): install buildbot.test too
6146 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6147 * buildbot/test/test_steps.py: fix it, tests pass now
6149 2004-01-06 Brian Warner <warner@lothar.com>
6151 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6152 freshcvs mail uses a slightly different syntax for new
6153 directories. Update parser to handle either.
6154 * test/test_mailparse.py (Test1.testMsg9): test for same
6156 2003-12-21 Brian Warner <warner@lothar.com>
6158 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6159 'warnOnWarnings' so that lintian errors mark the build orange
6161 2003-12-17 Brian Warner <warner@lothar.com>
6163 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6164 messages emitted by Bonsai, contributed by Stephen Davis.
6166 * test/*: moved all tests to use trial instead of unittest. Some
6167 still fail (test_steps, test_slavecommand, and test_process).
6169 * setup.py (version): bump to 0.4.1+ while between releases
6171 2003-12-09 Brian Warner <warner@lothar.com>
6173 * setup.py (version): Releasing buildbot-0.4.1
6175 2003-12-09 Brian Warner <warner@lothar.com>
6177 * NEWS: update for 0.4.1 release
6179 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6180 freebsd builder code a little bit
6182 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6183 don't try to compare attributes of different classes
6184 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6185 (MaildirSource.messageReceived): fix Change delivery
6187 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6188 into the config file's namespace before loading it, like the
6189 documentation claims it does
6190 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6191 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6192 daemon comes back online
6194 2003-12-08 Brian Warner <warner@lothar.com>
6196 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6197 so the example will work with online=0 as well
6199 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6200 fix the __implements__ line
6202 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6203 class a twisted.application.service.Service, use startService to
6206 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6207 directory fd instead of simple open(). I'm sure this used to work,
6208 but the current version of python refuses to open directories with
6211 2003-12-05 Brian Warner <warner@lothar.com>
6213 * setup.py (version): bump to 0.4.0+ while between releases
6215 2003-12-05 Brian Warner <warner@lothar.com>
6217 * setup.py (version): Releasing buildbot-0.4.0
6219 2003-12-05 Brian Warner <warner@lothar.com>
6221 * docs/examples/glib_master.cfg: replace old sample scripts with
6222 new-style config files
6223 * MANIFEST.in: include .cfg files in distribution tarball
6225 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6226 implement a dummy method to avoid the exception that occurs when
6227 freshcvs sends this to us.
6229 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6230 removed the method, as it broke reconnection. Apparently
6231 stopFactory is called each time the connection attempt fails. Must
6233 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6234 attribute before serialization, since without stopFactory the
6235 reconnect timer may still be active and they aren't serializable.
6237 * test/test_mailparse.py (ParseTest): test with 'self' argument
6239 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6240 argument, as these "functions" are invoked like methods from class
6241 attributes and therefore always get an instance as the first
6244 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6245 message: thanks to Stephen Davis for the catch
6247 2003-12-04 Brian Warner <warner@lothar.com>
6249 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6250 twisted's standard ReconnectingClientFactory. Handles both oldcred
6251 and newcred connections. Also has a bug-workaround for
6252 ReconnectingClientFactory serializing its connector when it
6255 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6256 pbutil. Replace makeApp stuff with proper newcred/mktap
6257 makeService(). Don't serialize Ephemerals on shutdown.
6259 * buildbot/changes/changes.py (ChangeMaster): make it a
6260 MultiService and add the sources as children, to get startService
6261 and stopService for free. This also gets rid of the .running flag.
6263 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6264 new pbutil, turn into a TCPClient at the same time (to get
6265 startService for free). Two variants exist: FreshCVSSourceOldcred
6266 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6267 yet, but when it does, we'll be ready).
6268 (FreshCVSSource.notify): handle paths which are empty after the
6269 prefix is stripped. This only happens when the top-level (prefix)
6270 directory is added, at the very beginning of a Repository's life.
6272 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6273 Now the only reconnecting code is in the factory where it belongs.
6274 (Builder.unsubscribe): unregister the disconnect callback when we
6275 delete the builder on command from the master (i.e. when the
6276 buildmaster is reconfigured and that builder goes away). This
6277 fixes a multiple-delete exception when the status client is shut
6279 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6282 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6283 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6285 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6287 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6288 a list of globs (ugh). The testdir will be searched for files
6289 named *.tests and run the tests in the order specified in each of
6290 those files. This allows for "dependancies" between tests to be
6293 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6294 argument to pass to run_maxq.py, instead of a glob.
6296 2003-10-17 Brian Warner <warner@lothar.com>
6298 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6299 files that live in the sandbox
6301 2003-10-15 Brian Warner <warner@lothar.com>
6303 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6304 spelling error in "docs" count-warnings output
6305 (HLint.start): stupid thinko meant .xhtml files were ignored
6307 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6308 tests now that cReactor is banished to the sandbox
6310 2003-10-10 Brian Warner <warner@lothar.com>
6312 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6313 scheme: now .xhtml are sources and .html are generated
6315 2003-10-08 Brian Warner <warner@lothar.com>
6317 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6318 we were ignoring the 'randomly' parameter.
6320 2003-10-01 Brian Warner <warner@lothar.com>
6322 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6323 posix, to kill sub-children of aborted slavecommands.
6325 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6326 Clean up initialization: lastBuildStatus remains None until the
6327 first build has been completed.
6329 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6330 None as a lastBuildStatus
6331 * buildbot/clients/gtkPanes.py: same
6333 * buildbot/status/client.py (StatusClientService): keep
6334 BuilderStatus objects in self.statusbags . These objects now live
6335 here in the StatusClientService and are referenced by the Builder
6336 object, rather than the other way around.
6337 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6338 * buildbot/process/base.py (Builder): same
6339 * test/test_config.py (ConfigTest.testBuilders): same
6341 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6342 an existing builder, leave the statusbag alone. This will preserve the
6345 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6346 hook. This will probably go away in favor of a class in upcoming
6349 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6350 serviceName from newcred FreshCVSNotifiee setup
6352 2003-09-29 Brian Warner <warner@lothar.com>
6354 * buildbot/process/process_twisted.py: switch to new reactor
6356 * docs/examples/twisted_master.cfg: same
6358 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6360 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6361 botmaster reference instead of the oldapp service lookup
6363 * buildbot/master.py (BuildMaster.__init__): give the
6364 StatusClientService a reference to the botmaster to make it easier to
6367 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6369 * buildbot/status/html.py (Box.td): escape hreffy things so you
6370 can have spaces in things like builder names
6371 (StatusResourceBuilder.body)
6372 (WaterfallStatusResource.body)
6373 (WaterfallStatusResource.body0): same
6375 2003-09-25 Brian Warner <warner@lothar.com>
6377 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6378 rearrange the builder list when adding or removing builders: keep
6379 them in the order the user requested.
6380 * test/test_config.py (ConfigTest.testBuilders): verify it
6382 * contrib/debug.glade: give the debug window a name
6384 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6385 now wait on multiple interlocks. Fix code relating to that.
6386 (Builder.checkInterlocks): same
6387 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6389 * buildbot/master.py (BuildMaster.loadConfig): move from
6390 deprecated pb.BrokerFactory to new pb.PBServerFactory
6391 * test/test_config.py (ConfigTest.testWebPathname): same
6393 * docs/examples/twisted_master.cfg: fix interlock declaration
6395 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6396 Interlocks to their Builders into interlock.py .
6397 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6399 * test/test_config.py (ConfigTest.testInterlocks): validate
6402 * buildbot/process/base.py (Builder.__init__): better comments
6403 * buildbot/process/interlock.py (Interlock.__repr__): same
6404 (Interlock.deactivate): add .active flag, move the code that
6405 attaches/detaches builders into the Interlock
6407 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6409 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6410 tests using the new run_maxq.py script, and reporting failures by
6413 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6414 tests, reporting their success or failure in a buildbot-friendly
6417 2003-09-24 Brian Warner <warner@lothar.com>
6419 * docs/examples/twisted_master.cfg: example of a new-style config
6420 file. This lives in the buildmaster base directory as
6423 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6424 button to make the master re-read its config file
6426 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6427 buildmaster configuration from a file. This file can be re-read
6428 later, and the buildmaster will update itself to match the new
6429 desired configuration. Also use new Twisted Application class.
6430 * test/Makefile, test/test_config.py: unit tests for same
6432 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6433 FreshCVSSources comparable, to support reload.
6434 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6436 * buildbot/process/base.py (Builder): make them comparable, make
6437 Interlocks easier to attach, to support reload. Handle
6438 re-attachment of remote slaves.
6439 * buildbot/process/interlock.py (Interlock): same
6441 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6442 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6443 buildmaster taps are now constructed with mktap.
6444 * buildbot/status/client.py (StatusClientService): same
6446 * buildbot/status/words.py: move to new Services, add support to
6447 connect to multiple networks, add reload support, allow nickname
6448 to be configured on a per-network basis
6450 2003-09-20 Brian Warner <warner@lothar.com>
6452 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6453 the freebsd builder, now that the machine has been upgraded and no
6454 longer has python2.2
6456 * setup.py (version): bump to 0.3.5+ while between releases
6458 2003-09-19 Brian Warner <warner@lothar.com>
6460 * setup.py (version): Releasing buildbot-0.3.5
6462 2003-09-19 Brian Warner <warner@lothar.com>
6464 * NEWS: add post-0.3.4 notes
6466 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6468 * MANIFEST.in: add contrib/*
6470 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6471 use a remote root now: cvs.twistedmatrix.com
6473 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6475 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6476 compatibility with old servers
6477 (FreshCVSSource.start): and provide a way to use it
6478 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6480 * docs/examples/twisted_master.py (twisted_app): update to new
6482 (twisted_app): listen on new ~buildbot socket
6483 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6485 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6486 to reduce cvs bandwidth (update instead of full checkout)
6488 2003-09-11 Brian Warner <warner@lothar.com>
6490 * contrib/fakechange.py: demo how to connect to the changemaster
6491 port. You can use this technique to submit changes to the
6492 buildmaster from source control systems that offer a hook to run a
6493 script when changes are committed.
6495 * contrib/debugclient.py: tool to connect to the debug port. You
6496 can use it to force builds, submit fake changes, and wiggle the
6499 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6500 'Dispatcher' realm to handle all the different kinds of
6501 connections and Perspectives: buildslaves, the changemaster port,
6502 the debug port, and the status client port. NewCredPerspectives
6503 now have .attached/.detached methods called with the remote 'mind'
6504 reference, much like old perspectives did. All the pb.Services
6505 turned into ordinary app.ApplicationServices .
6506 (DebugService): went away, DebugPerspectives are now created
6507 directly by the Dispatcher.
6508 (makeApp): changed interface a little bit
6510 * buildbot/changes/changes.py: newcred
6511 * buildbot/status/client.py: newcred
6513 * buildbot/clients/base.py: newcred client side changes
6514 * buildbot/bot.py: ditto
6516 * docs/examples/glib_master.py: handle new makeApp() interface
6517 * docs/examples/twisted_master.py: ditto
6519 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6520 base newcred Perspectives on. This should go away once Twisted
6521 itself provides something sensible.
6524 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6526 * contrib/svn_buildbot.py: A program that you can call from your
6527 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6528 when a change in an SVN repository has happened. See the top of
6529 the file for some minimal usage info.
6531 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6533 * buildbot/slavecommand.py (ArglistCommand): Add new
6534 ArglistCommand that takes an argument list rather than a string as
6535 a parameter. Using a st.split() for argv is very bad.
6537 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6538 update to a particular revision rather than always checking out
6539 (still not very smart about it, there may be cases where the
6540 checkout becomes inconsistent).
6542 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6544 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6545 SVN fetch support. It can checkout (not update!) a specified
6546 revision from a specified repository to a specified directory.
6548 * buildbot/status/progress.py (Expectations.update): Fix an
6549 obvious bug (apparently created by the change described in the
6550 previous ChangeLog message) by moving a check to *after* the
6551 variable it checks is defined.
6554 2003-09-08 Brian Warner <warner@lothar.com>
6556 * buildbot/status/progress.py (Expectations.update): hack to catch
6557 an exception TTimo sees: sometimes the update() method seems to
6558 get called before the step has actually finished, so the .stopTime
6559 is not set, so no totalTime() is available and we average None
6560 with the previous value. Catch this and just don't update the
6561 metrics, and emit a log message.
6563 2003-08-24 Brian Warner <warner@lothar.com>
6565 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6566 parameter to set copydir='original' in CVS commands.
6568 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6570 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6571 which tells the command to maintain a separate original-source CVS
6572 workspace. For each build, this workspace will be updated, then
6573 the tree copied into a new workdir. This reduces CVS bandwidth
6574 (from a full checkout to a mere update) while doubling the local
6575 disk usage (to keep two copies of the tree).
6577 2003-08-21 Brian Warner <warner@lothar.com>
6579 * buildbot/status/event.py (Logfile.addEntry): if the master web
6580 server dies while we're serving a page, request.write raises
6581 pb.DeadReferenceError . Catch this and treat it like a
6582 notifyFinish event by dropping the request.
6584 2003-08-18 Brian Warner <warner@lothar.com>
6586 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6587 (instead of blowing up) if a force-build command is given without
6590 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6591 don't blow up if there aren't yet any Changes in the list
6593 2003-08-02 Brian Warner <warner@lothar.com>
6595 * buildbot/bot.py (updateApplication): don't set the .tap name,
6596 since we shouldn't assume we own the whole .tap file
6598 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6599 'mktap buildbot' (without a subcommand) better
6601 2003-07-29 Brian Warner <warner@lothar.com>
6603 * buildbot/status/words.py
6604 (IrcStatusFactory.clientConnectionLost): when we lose the
6605 connection to the IRC server, schedule a reconnection attempt.
6607 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6608 use shutil.rmtree instead of forking off an "rm -rf" command.
6609 rmtree may take a while and will block until it finishes, so we
6610 use "rm -rf" if available.
6612 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6613 freebsd buildslave badly
6615 * setup.py (version): bump to 0.3.4+ while between releases
6617 2003-07-28 Brian Warner <warner@lothar.com>
6619 * setup.py (version): Releasing buildbot-0.3.4
6621 2003-07-28 Brian Warner <warner@lothar.com>
6623 * NEWS: update in preparation for release
6625 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6626 process.signalProcess instead of os.kill, to improve w32
6629 * docs/examples/twisted_master.py (twisted_app): turn off
6630 win32eventreactor: the tests hang the buildslave badly
6632 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6633 failed builds, since usually the failures are consistent
6635 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6636 add compileOpts/compileOpts2 to reactors build
6638 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6639 (twisted_app): use both default and win32eventreactor on w32 build.
6640 Use both default and kqreactor on freebsd build.
6642 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6643 add compileOpts2, which is put after the build_ext argument. w32
6644 needs "-c mingw32" here.
6646 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6647 touch .acqpath, it goes away in recent Twisted releases
6649 * docs/examples/twisted_master.py (twisted_app): use "python" for
6650 the w32 buildslave, not "python2.2"
6652 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6653 the directory exists.. should hush an exception under w32
6655 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6656 ProcessTerminated -provided values for signal and exitCode rather
6657 than parsing the unix status code directly. This should remove one
6658 more roadblock for a w32-hosted buildslave.
6660 * test/test_mailparse.py: add test cases for Syncmail parser
6662 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6663 temporary compatibility import. Note! Start importing
6664 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6666 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6668 2003-07-27 Brian Warner <warner@lothar.com>
6670 * NEWS: started adding new features
6672 * buildbot/changes/mail.py: start work on Syncmail parser, move
6673 mail sources into their own file
6675 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6676 as implementing IChangeSource
6677 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6679 * buildbot/interfaces.py: define the IChangeSource interface
6681 2003-07-26 Brian Warner <warner@lothar.com>
6683 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6685 2003-06-25 Brian Warner <warner@lothar.com>
6687 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6690 2003-06-17 Brian Warner <warner@lothar.com>
6692 * buildbot/status/words.py: clean up method usage to avoid error
6693 in silly IRC command
6694 (IrcStatusBot.emit_status): round off seconds display
6696 * buildbot/process/base.py (Build): delete the timer when saving
6697 to the .tap file, and restore it (if it should still be running)
6698 upon restore. This should fix the "next build in -34 seconds"
6699 messages that result when the master is restarted while builds are
6700 sitting in the .waiting slot. If the time for the build has
6701 already passed, start it very soon (in 1 second).
6703 * buildbot/status/words.py: more silly commands
6705 * README (REQUIREMENTS): add URLs to all required software
6707 * buildbot/status/words.py ('last'): mention results of, and time
6710 2003-05-28 Brian Warner <warner@lothar.com>
6712 * buildbot/status/words.py: add 'last' command
6713 (IrcStatusBot.emit_status): add current-small text to 'status' output
6715 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6716 (twisted_app): remove spaces from OS-X builder name
6718 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6719 * buildbot/status/words.py: IRC bot should actually be useful now
6721 2003-05-23 Brian Warner <warner@lothar.com>
6723 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6724 "slave information" from $(slavedir)/info/* . These files are
6725 maintained by the slave administrator, and describe the
6726 machine/environment that is hosting the slave. Information from
6727 them is put into the "Builder" HTML page. Still need to establish
6728 a set of well-known filenames and meanings for this data: at the
6729 moment, *all* info/* files are sent to the master, but only
6730 'admin' and 'host' are used on that end.
6731 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6732 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6733 * buildbot/master.py (BotPerspective.got_info): ditto
6735 2003-05-22 Brian Warner <warner@lothar.com>
6737 * setup.py (version): bump version to 0.3.3+ while between releases
6739 2003-05-21 Brian Warner <warner@lothar.com>
6741 * setup.py: Releasing buildbot-0.3.3
6743 2003-05-21 Brian Warner <warner@lothar.com>
6745 * NEWS: 0.3.3 news items
6747 * README: describe --keepalive and life behind a NAT box
6749 * buildbot/bot.py (Bot.connected): implement application-level
6750 keepalives to deal with NAT timeouts, turn them on with
6751 --keepalive option or when SO_KEEPALIVE doesn't work.
6753 * buildbot/master.py (BotPerspective): accept keepalives silently
6755 * buildbot/process/base.py (Build.buildException): CopiedFailures
6756 don't carry as much information as local ones, so don't try to
6757 create a big HTMLized version of them.
6759 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6760 log file when step fails due to an exception, such as when the slave
6763 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6764 --testmodule argument instead of grepping for test-case-name tags
6765 ourselves. Remove FindUnitTests code.
6766 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6768 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6770 2003-05-16 Brian Warner <warner@lothar.com>
6772 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6773 argument to allow things like CFLAGS=-O0 to be passed without relying
6774 upon /bin/sh processing on the slave.
6776 * buildbot/process/step.py (InternalShellCommand.start): send
6778 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6779 'split' instead of letting /bin/sh do it. This should also remove
6780 the need for /bin/sh on the buildslave, making it more likely to
6783 * buildbot/status/html.py: html-escape text in blamelist.
6784 Add "force build" button to the Builder page.
6786 * buildbot/process/step_twisted.py (countFailedTests): look at
6787 last 1000 characters for status line, as import errors can put it
6788 before the -200 point.
6790 2003-05-15 Brian Warner <warner@lothar.com>
6792 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6794 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6795 make 'clobber' a parameter, so it is possible to have builds which
6796 do full tests but do a cvs update instead of hammering the CVS
6797 server with a full checkout each build
6799 * buildbot/process/step.py (InternalShellCommand): bump default
6800 timeout to 20 minutes
6802 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6803 the master to trigger a build. Run it via manhole.
6805 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6806 allow slaves to trigger any build that they host, to make life
6807 easier for slave admins who are testing out new build processes
6809 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6810 don't flunk cReactor or qtreactor on failure, since they fail alot
6811 these days. Do warnOnFailure instead.
6813 * buildbot/process/base.py: change Builder.buildable from a list
6814 into a single slot. When we don't have a slave, new builds (once
6815 they make it past the timeout) are now merged into an existing
6816 buildable one instead of being queued. With this change, a slave
6817 which has been away for a while doesn't get pounded with all the
6818 builds it missed, but instead just does a single build.
6820 2003-05-07 Brian Warner <warner@lothar.com>
6822 * setup.py (version): bump version to 0.3.2+ while between releases
6824 2003-05-07 Brian Warner <warner@lothar.com>
6826 * setup.py: Releasing buildbot-0.3.2
6828 2003-05-07 Brian Warner <warner@lothar.com>
6830 * setup.py: fix major packaging error: include subdirectories!
6832 * NEWS: add changes since last release
6834 * README (REQUIREMENTS): update twisted/python dependencies
6836 * buildbot/status/builder.py (Builder.startBuild): change
6837 BuildProcess API: now they should call startBuild/finishBuild
6838 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6839 keeping a list of builds in the statusbag, to support other kinds of
6841 (Builder.addClient): send current-activity-small to new clients
6842 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6845 * buildbot/status/client.py: drop RemoteReferences at shutdown
6847 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6849 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6850 more debug messages for remote status client
6852 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6853 (.stepFailed): only fire the Deferred once, even if both
6854 stepComplete and stepFailed are called. I think this can happen if
6855 an exception occurs at a weird time.
6857 * buildbot/status/words.py: work-in-progress: IRC status delivery
6859 2003-05-05 Brian Warner <warner@lothar.com>
6861 * docs/examples/twisted_master.py (twisted_app): hush internal
6862 python2.3 distutils deprecation warnings
6863 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6864 add compileOpts= argument which inserts extra args before the
6865 "setup.py build_ext" command. This can be used to give -Wignore
6866 warnings, to hush some internal python-2.3 deprecation messages.
6868 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6869 the ['twisted.test'] default test case to make it easier to change
6872 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6873 * buildbot/clients/gtkPanes.py: ditto
6875 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6876 arg to collapse RunUnitTestsRandomly into RunUnitTests
6877 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6878 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6880 * buildbot/status/html.py (StatusResource): shuffle Resources
6881 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6882 would serve the waterfall display, but the internal links were
6883 only valid on the trailing-slash version. The correct behavior is
6884 for the non-slashed one to serve a Redirect to the slashed one.
6885 This only shows up when the buildbot page is hanging off another
6886 server, like a Twisted-Web distributed server.
6888 * buildbot/status/event.py (Event, RemoteEvent): make Events
6889 pb.Cacheable, with RemoteEvent as the cached version. This removes
6890 a lot of explicit send-an-update code.
6891 * buildbot/status/builder.py (Builder): remove send-update code
6892 * buildbot/status/client.py (ClientBuilder): remove send-update
6893 code, and log errors that occur during callRemote (mostly to catch
6894 InsecureJelly exceptions)
6896 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6897 run Lore with the same python used in the rest of the build
6899 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6901 * buildbot/process/step_twisted.py (HLint): accept 'python'
6902 argument. Catch rc!=0 and mark the step as failed. This marks the
6903 build orange ("has warnings").
6904 (RunUnitTestsJelly): move out to step_twisted2.py
6906 * buildbot/util.py (ignoreStaleRefs): add utility function
6908 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6909 don't fake ETA object, it's too hard to get right
6911 2003-05-02 Brian Warner <warner@lothar.com>
6913 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6915 2003-05-01 Brian Warner <warner@lothar.com>
6917 * buildbot/status/html.py (StatusResource.body): oops, I was
6918 missing a <tr>, causing the waterfall page to be misrendered in
6919 everything except Galeon.
6921 2003-04-29 Brian Warner <warner@lothar.com>
6923 * docs/examples/twisted_master.py: make debuild use python-2.2
6924 explicitly, now that Twisted stopped supporting 2.1
6926 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6927 handle tuple results too. I keep forgetting this, which suggests
6928 it needs to be rethought.
6930 * setup.py (setup): bump version to 0.3.1+ while between releases
6932 2003-04-29 Brian Warner <warner@lothar.com>
6934 * setup.py: Releasing buildbot-0.3.1
6936 2003-04-29 Brian Warner <warner@lothar.com>
6938 * README (SUPPORT): add plea to send questions to the mailing list
6940 * NEWS, MANIFEST.in: add description of recent changes
6942 * docs/examples/twisted_master.py: add the code used to create the
6943 Twisted buildmaster, with passwords and such removed out to a
6946 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6947 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6948 buildmasters to not require CVSToys be installed.
6949 * README, docs/examples/glib_master: update to match the change
6951 * buildbot/clients/base.py, buildbot/bot.py,
6952 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6953 ReconnectingPB from CVSToys distribution to remove CVSToys
6954 dependency for build slaves and status clients. Buildmasters which
6955 use FreshCVSSources still require cvstoys be installed, of course.
6957 2003-04-25 Brian Warner <warner@lothar.com>
6959 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6960 runTestsRandomly arg to turn on trial -z
6962 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6963 experimental code to use trial's machine-parseable output to get
6964 more detailed test results. Still has some major issues.
6965 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6968 * buildbot/status/builder.py (Builder.setCurrentBuild):
6969 anticipating moving build history into statusbag, not used yet
6971 * buildbot/status/tests.py: code to centralize test results,
6972 doesn't work quite yet
6974 * buildbot/status/event.py (Event): use hasattr("setName") instead
6975 of isinstance for now.. need better long-term solution
6977 * buildbot/status/html.py: Remove old imports
6979 2003-04-24 Brian Warner <warner@lothar.com>
6981 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6982 ignore changes under doc/fun/ and sandbox/
6984 * buildbot/process/step_twisted.py: update pushEvent and friends.
6986 * buildbot/status/html.py (Box.td): replace event.buildername with
6987 event.parent.getSwappableName(). Needs more thought.
6989 * buildbot/status/builder.py (Builder): Replace pushEvent and
6990 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6991 Tell events they are being pruned with event.delete().
6993 * buildbot/process/base.py (Build): Remove Builder status-handling
6994 methods. s/pushEvent/setCurrentActivity/.
6996 * buildbot/process/step.py (BuildStep): clean up status delivery.
6997 Gouse builder.statusbag methods instead of intermediate builder
6998 methods. s/updateLastEvent/updateCurrentActivity/.
6999 s/finalizeLastEvent/finishCurrentActivity/. Use
7000 addFileToCurrentActivity for summaryFunction.
7002 * buildbot/status/event.py (Logfile): put data in a Swappable when
7004 (Event): add more setter methods. Remove .buildername, use .parent
7005 and getSwappableName instead (needs more thought).
7007 * buildbot/util.py (Swappable):
7008 * test/test_swap.py: don't bother setting filename at __init__
7009 time, do it later. Change setFilename args to take parent first,
7010 since it provides the most significant part of the filename.
7012 2003-04-23 Brian Warner <warner@lothar.com>
7014 * buildbot/status/event.py (Logfile.addEntry): append to previous
7017 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7018 anticipating Swappable
7019 (InternalShellCommand.remoteUpdate): split out various log-adding
7020 methods so subclasses can snarf stdout separately
7022 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7023 in anticipation of Swappable build logs
7024 (Builder.testsFinished): anticipating TestResults, still disabled
7026 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7029 * buildbot/status/event.py (Logfile): add (disabled) support for
7030 Swappable, not ready for use yet
7032 * buildbot/util.py (Swappable): object which is swapped out to
7033 disk after some period of no use.
7034 * test/test_swap.py: test buildbot.utils.Swappable
7036 2003-04-14 Brian Warner <warner@lothar.com>
7038 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7039 periodic-build timer. Set the .periodicBuildTime on a builder
7040 instance to some number of seconds to activate it.
7042 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7044 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7045 a way that survives result tuples
7047 2003-04-12 Brian Warner <warner@lothar.com>
7049 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7050 return a dict instead of a tuple: allow summarizers to provide
7051 multiple summaries if they want
7052 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7053 (debuildSummarizer): summarize lintian warnings/errors
7055 2003-04-10 Brian Warner <warner@lothar.com>
7057 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7059 2003-04-09 Brian Warner <warner@lothar.com>
7061 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7062 empty summaries: happens when the tests fail so hard they don't emit
7063 a parseable summary line.
7065 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7066 Allow summaryFunction to return None to indicate no summary should
7069 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7070 writing to stale HTTP requests: notice when they disconnect and
7071 remove the request from the list. Also add CacheToFile from
7072 moshez, will be used later.
7074 2003-04-08 Brian Warner <warner@lothar.com>
7076 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7077 should be an int, not a list of strings
7079 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7080 if we weren't actually connected
7082 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7083 to show the tail end of the trial text output
7085 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7086 hook to summarize the results of a ShellCommand
7088 2003-04-07 Brian Warner <warner@lothar.com>
7090 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7091 twisted test suite code into a single class.
7092 * buildbot/process/process_twisted.py: same
7094 2003-04-04 Brian Warner <warner@lothar.com>
7096 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7098 * README (SLAVE): document use of mktap to create slave .tap file
7099 (REQUIREMENTS): describe dependencies
7101 * buildbot/bb_tap.py, buildbot/plugins.tml:
7102 * buildbot/bot.py (updateApplication): Add mktap support for creating
7103 buildslave .tap files
7105 2003-03-28 Brian Warner <warner@lothar.com>
7107 * buildbot/process/step.py (InternalShellCommand.finished): handle
7108 new tuple result values (fix embarrasing bug that appeared during
7111 2003-03-27 Brian Warner <warner@lothar.com>
7113 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7116 2003-03-25 Brian Warner <warner@lothar.com>
7118 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7119 to overall build status
7120 * buildbot/clients/base.py (Builder): improve event printing
7121 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7122 instead of generic ShellCommand
7123 (Build): Add .stopBuild, use it when slave is detached
7125 * buildbot/process/step.py (Configure,Test): give the steps their
7126 own names and status strings
7128 * buildbot/status/html.py (StatusResource): add "show" argument,
7129 lets you limit the set of Builders being displayed.
7131 2003-03-20 Brian Warner <warner@lothar.com>
7133 * buildbot/process/basic.py: removed
7135 2003-03-19 Brian Warner <warner@lothar.com>
7137 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7138 turn off process-docs by default
7140 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7141 when displaying build information without anything in allBuilds[]
7143 * buildbot/bot.py (makeApp): really take password from sys.argv
7145 2003-03-18 Brian Warner <warner@lothar.com>
7147 * buildbot/bot.py (buildApp): take password from sys.argv
7149 * README: replace with more useful text
7151 * setup.py: add a real one
7152 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7154 * docs/PyCon-2003/: added sources for PyCon paper.
7156 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7157 now Build objects control the process and Builder only handles
7158 slave stuff and distribution of changes/status. A new BuildFactory
7159 class creates Build objects on demand.
7161 Created ConfigurableBuild which takes a list of steps to run. This
7162 makes it a lot easier to set up a new kind of build and moves us
7163 closer to being able to configure a build from a web page.
7165 * buildbot/process/step_twisted.py, process_twisted.py: move to
7166 new model. A lot of code went away.
7168 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7169 send lots of empty progress messages to the client.
7171 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7173 2003-02-20 Brian Warner <warner@lothar.com>
7175 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7177 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7178 Twisted bug that prevented non-pty processes from working just got
7179 fixed, and the bug that leaks ptys is still being investigated.
7181 * buildbot/process/step.py (CVS): send timeout arg to slave
7183 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7184 builders coming and going
7185 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7186 from CVSToys, handle lost-buildmaster
7188 * buildbot/status/client.py (StatusClientService.removeBuilder):
7189 Clean up status client protocol: send builders (with references)
7190 as they are created, rather than sending a list and requiring the
7191 client to figure out which ones are new.
7192 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7193 attempts to force a build on an unknown builder
7195 2003-02-19 Brian Warner <warner@lothar.com>
7197 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7198 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7199 Twisted stops leaking them.
7200 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7201 builder goes to an idle state.
7203 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7204 I figure out why CVS commands hang without them, and/or I fix the
7205 hung-command timeout
7207 2003-02-16 Brian Warner <warner@lothar.com>
7209 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7210 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7211 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7212 GenerateDocs now that they are prefixed with WARNING:.
7214 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7215 use manual href target instead of request.childLink
7217 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7218 display every second, but update the ETA every 5 seconds (or
7219 whenever) as remote_progress messages arrive.
7222 2003-02-12 Brian Warner <warner@lothar.com>
7224 * *: import current sources from home CVS repository
7228 # add-log-time-format: add-log-iso8601-time-string