test/functional/bipdersig-p2p.py

   1 #!/usr/bin/env python3
   2 # Copyright (c) 2015-2016 The Bitcoin Core developers
   3 # Distributed under the MIT software license, see the accompanying
   4 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
   5 """Test BIP66 (DER SIG).
   6
   7 Test that the DERSIG soft-fork activates at (regtest) height 1251.
   8 """
   9
  10 from test_framework.test_framework import BitcoinTestFramework
  11 from test_framework.util import *
  12 from test_framework.mininode import *
  13 from test_framework.blocktools import create_coinbase, create_block
  14 from test_framework.script import CScript
  15 from io import BytesIO
  16
  17 DERSIG_HEIGHT = 1251
  18
  19 # Reject codes that we might receive in this test
  20 REJECT_INVALID = 16
  21 REJECT_OBSOLETE = 17
  22 REJECT_NONSTANDARD = 64
  23
  24 # A canonical signature consists of:
  25 # <30> <total len> <02> <len R> <R> <02> <len S> <S> <hashtype>
  26 def unDERify(tx):
  27     """
  28     Make the signature in vin 0 of a tx non-DER-compliant,
  29     by adding padding after the S-value.
  30     """
  31     scriptSig = CScript(tx.vin[0].scriptSig)
  32     newscript = []
  33     for i in scriptSig:
  34         if (len(newscript) == 0):
  35             newscript.append(i[0:-1] + b'\0' + i[-1:])
  36         else:
  37             newscript.append(i)
  38     tx.vin[0].scriptSig = CScript(newscript)
  39
  40 def create_transaction(node, coinbase, to_address, amount):
  41     from_txid = node.getblock(coinbase)['tx'][0]
  42     inputs = [{ "txid" : from_txid, "vout" : 0}]
  43     outputs = { to_address : amount }
  44     rawtx = node.createrawtransaction(inputs, outputs)
  45     signresult = node.signrawtransaction(rawtx)
  46     tx = CTransaction()
  47     tx.deserialize(BytesIO(hex_str_to_bytes(signresult['hex'])))
  48     return tx
  49
  50 class BIP66Test(BitcoinTestFramework):
  51
  52     def __init__(self):
  53         super().__init__()
  54         self.num_nodes = 1
  55         self.extra_args = [['-promiscuousmempoolflags=1', '-whitelist=127.0.0.1']]
  56         self.setup_clean_chain = True
  57
  58     def run_test(self):
  59         node0 = NodeConnCB()
  60         connections = []
  61         connections.append(NodeConn('127.0.0.1', p2p_port(0), self.nodes[0], node0))
  62         node0.add_connection(connections[0])
  63         NetworkThread().start() # Start up network handling in another thread
  64
  65         # wait_for_verack ensures that the P2P connection is fully up.
  66         node0.wait_for_verack()
  67
  68         self.log.info("Mining %d blocks", DERSIG_HEIGHT - 2)
  69         self.coinbase_blocks = self.nodes[0].generate(DERSIG_HEIGHT - 2)
  70         self.nodeaddress = self.nodes[0].getnewaddress()
  71
  72         self.log.info("Test that a transaction with non-DER signature can still appear in a block")
  73
  74         spendtx = create_transaction(self.nodes[0], self.coinbase_blocks[0],
  75                 self.nodeaddress, 1.0)
  76         unDERify(spendtx)
  77         spendtx.rehash()
  78
  79         tip = self.nodes[0].getbestblockhash()
  80         block_time = self.nodes[0].getblockheader(tip)['mediantime'] + 1
  81         block = create_block(int(tip, 16), create_coinbase(DERSIG_HEIGHT - 1), block_time)
  82         block.nVersion = 2
  83         block.vtx.append(spendtx)
  84         block.hashMerkleRoot = block.calc_merkle_root()
  85         block.rehash()
  86         block.solve()
  87
  88         node0.send_and_ping(msg_block(block))
  89         assert_equal(self.nodes[0].getbestblockhash(), block.hash)
  90
  91         self.log.info("Test that blocks must now be at least version 3")
  92         tip = block.sha256
  93         block_time += 1
  94         block = create_block(tip, create_coinbase(DERSIG_HEIGHT), block_time)
  95         block.nVersion = 2
  96         block.rehash()
  97         block.solve()
  98         node0.send_and_ping(msg_block(block))
  99         assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
 100
 101         wait_until(lambda: "reject" in node0.last_message.keys(), lock=mininode_lock)
 102         with mininode_lock:
 103             assert_equal(node0.last_message["reject"].code, REJECT_OBSOLETE)
 104             assert_equal(node0.last_message["reject"].reason, b'bad-version(0x00000002)')
 105             assert_equal(node0.last_message["reject"].data, block.sha256)
 106             del node0.last_message["reject"]
 107
 108         self.log.info("Test that transactions with non-DER signatures cannot appear in a block")
 109         block.nVersion = 3
 110
 111         spendtx = create_transaction(self.nodes[0], self.coinbase_blocks[1],
 112                 self.nodeaddress, 1.0)
 113         unDERify(spendtx)
 114         spendtx.rehash()
 115
 116         # First we show that this tx is valid except for DERSIG by getting it
 117         # accepted to the mempool (which we can achieve with
 118         # -promiscuousmempoolflags).
 119         node0.send_and_ping(msg_tx(spendtx))
 120         assert spendtx.hash in self.nodes[0].getrawmempool()
 121
 122         # Now we verify that a block with this transaction is invalid.
 123         block.vtx.append(spendtx)
 124         block.hashMerkleRoot = block.calc_merkle_root()
 125         block.rehash()
 126         block.solve()
 127
 128         node0.send_and_ping(msg_block(block))
 129         assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
 130
 131         wait_until(lambda: "reject" in node0.last_message.keys(), lock=mininode_lock)
 132         with mininode_lock:
 133             # We can receive different reject messages depending on whether
 134             # bitcoind is running with multiple script check threads. If script
 135             # check threads are not in use, then transaction script validation
 136             # happens sequentially, and bitcoind produces more specific reject
 137             # reasons.
 138             assert node0.last_message["reject"].code in [REJECT_INVALID, REJECT_NONSTANDARD]
 139             assert_equal(node0.last_message["reject"].data, block.sha256)
 140             if node0.last_message["reject"].code == REJECT_INVALID:
 141                 # Generic rejection when a block is invalid
 142                 assert_equal(node0.last_message["reject"].reason, b'block-validation-failed')
 143             else:
 144                 assert b'Non-canonical DER signature' in node0.last_message["reject"].reason
 145
 146         self.log.info("Test that a version 3 block with a DERSIG-compliant transaction is accepted")
 147         block.vtx[1] = create_transaction(self.nodes[0],
 148                 self.coinbase_blocks[1], self.nodeaddress, 1.0)
 149         block.hashMerkleRoot = block.calc_merkle_root()
 150         block.rehash()
 151         block.solve()
 152
 153         node0.send_and_ping(msg_block(block))
 154         assert_equal(int(self.nodes[0].getbestblockhash(), 16), block.sha256)
 155
 156 if __name__ == '__main__':
 157     BIP66Test().main()