Automatic date update in version.in
[binutils-gdb.git] / gdb / ChangeLog-2019
blobe6b55bb9f0e0199be9bd90a27e3bc72b27bdc58d
1 2019-12-30  Tom Tromey  <tom@tromey.com>
3         * tui/tui-win.c (tui_border_mode_translate)
4         (tui_border_kind_translate_vline, tui_border_kind_translate_hline)
5         (tui_border_kind_translate_ulcorner)
6         (tui_border_kind_translate_urcorner)
7         (tui_border_kind_translate_llcorner)
8         (tui_border_kind_translate_lrcorner, tui_active_border_mode)
9         (tui_border_mode, tui_border_kind): Now static.
11 2019-12-30  Tom Tromey  <tom@tromey.com>
13         * tui/tui-interp.c (tui_start_enabled): Now bool.
14         (_initialize_tui_interp): Update.
15         * tui/tui-hooks.c (tui_refreshing_registers): Now bool.
16         (tui_register_changed)
17         (tui_refresh_frame_and_register_information): Update.
18         * tui/tui-win.c (tui_update_variables): Return bool.
19         * tui/tui-win.h (tui_update_variables): Return bool.
20         * tui/tui.c (tui_get_command_dimension): Return bool.
21         * tui/tui.h (tui_get_command_dimension): Return bool.
23 2019-12-29  Bernd Edlinger  <bernd.edlinger@hotmail.de>
25         * buildsym.c (buildsym_compunit::record_line): Do no longer ignore
26         line 65535.
28 2019-12-27  Tom Tromey  <tom@tromey.com>
30         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
31         commented-out code.
32         * tui/tui.c: Remove #if 0 code.
34 2019-12-27  Tom Tromey  <tom@tromey.com>
36         * cli/cli-cmds.c (print_disassembly): Reorder "if".
38 2019-12-27  Tom Tromey  <tom@tromey.com>
40         * tui/tui.c (tui_active): Now bool.
41         (tui_finish_init): Likewise.
42         (tui_enable): Update.
43         (tui_disable): Update.
44         (tui_is_window_visible): Update.
45         * tui/tui.h (tui_active): Now bool.
47 2019-12-27  Tom Tromey  <tom@tromey.com>
49         * tui/tui-source.c (tui_source_window::maybe_update): Update.
50         * tui/tui-regs.c (tui_data_window::display_registers_from):
51         Update.
52         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
53         * tui/tui-data.h (struct tui_gen_win_info) <viewport_height>:
54         Remove.
55         * tui/tui-command.c (tui_cmd_window::resize): Update.
57 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
59         * ada-lang.c (ada_decode_symbol): Update.
60         * buildsym.c (add_symbol_to_list): Update.
61         * coffread.c (process_coff_symbol): Update.
62         * ctfread.c (ctf_add_enum_member_cb): Update.
63         (new_symbol): Update.
64         (ctf_add_var_cb): Update.
65         * dwarf2read.c (fixup_go_packaging): Update.
66         (dwarf2_compute_name): Update.
67         (new_symbol): Update.
68         * jit.c (finalize_symtab): Update.
69         * language.c (language_alloc_type_symbol): Update.
70         * mdebugread.c (new_symbol): Update.
71         * minsyms.c (minimal_symbol_reader::record_full): Update.
72         (minimal_symbol_reader::install): Update.
73         * psymtab.c (print_partial_symbols): Update.
74         (psymbol_hash): Update.
75         (psymbol_compare): Update.
76         (add_psymbol_to_bcache): Update.
77         (maintenance_check_psymtabs): Update.
78         * stabsread.c (define_symbol): Update.
79         * symtab.c (symbol_set_names): Rename to...
80         (general_symbol_info::compute_and_set_names): ...this.
81         (general_symbol_info::natural_name): Update.
82         (general_symbol_info::search_name): Update.
83         (fixup_section): Update.
84         * symtab.h (struct general_symbol_info) <name>: Rename to...
85         <m_name>: ...this.
86         <compute_and_set_names>: Rename from...
87         (symbol_set_names): ...this.
88         (SYMBOL_SET_NAMES): Remove.
89         (struct symbol) <ctor>: Update.
91 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
93         * NEWS: Mention that multithreaded symbol loading is now on by
94         default.
96 2019-12-26  Ruslan Kabatsayev  <b7.10110111@gmail.com>
98         * dwarf2read.c (is_valid_DW_AT_defaulted)
99         (is_valid_DW_AT_calling_convention_for_type)
100         (is_valid_DW_AT_calling_convention_for_subroutine): Fix printing
101         ULONGEST variables on x86-32.
103 2019-12-21  George Barrett  <bob@bob131.so>
105         * solib-svr4.c (svr4_handle_solib_event): Add fallback link
106         namespace test for when the debug struct isn't available.
108 2019-12-21  Eli Zaretskii  <eliz@gnu.org>
110         * top.c (print_gdb_configuration): Print "--with-xxhash" or
111         "--without-xxhash" according to HAVE_LIBXXHASH.
113 2019-12-20  Weimin Pan  <weimin.pan@oracle.com>
114         * ctfread.c (ctf_file_key): Change type to objfile_key.
115         (struct ctf_context): Remove typedef.
116         (get_objfile_text_range): Use ANOFFSET to get text base.
118 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
120         * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
121         New function.
122         (read_subroutine_type): Validate the parsed
123         DW_AT_calling_convention value before assigning it to a
124         subroutine's calling_convention attribute.
125         * gdbtypes.h (struct func_type) <calling_convention>: Use
126         an enum bitfield as its type, instead of plain unsigned.
128 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
130         PR gdb/25054
131         * infcall.c (call_function_by_hand_dummy): Update the argument-
132         passing section for call-by-value parameters.
133         (struct destructor_info): New struct.
134         (call_destructors): New auxiliary function.
136 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
138         * gnu-v3-abi.c (enum definition_style): New enum type.
139         (get_def_style): New function.
140         (is_user_provided_def): New function.
141         (is_implicit_def): New function.
142         (is_copy_or_move_constructor_type): New function.
143         (is_copy_constructor_type): New function.
144         (is_move_constructor_type): New function.
145         (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
146         for a given type.
148 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
150         * language.h (struct language_pass_by_ref_info): New struct.
151         (struct language_defn)<la_pass_by_reference>: Change the signature
152         to return a language_pass_by_ref_info instead of an int.
153         (language_pass_by_reference): Ditto.
154         (default_pass_by_reference): Ditto.
155         Adjust the users listed below.
156         * arch-utils.c (default_return_in_first_hidden_param_p):
157         Update.
158         * cp-abi.c (cp_pass_by_reference): Update.
159         * cp-abi.h (cp_pass_by_reference): Update declaration.
160         (struct cp_abi_ops)<pass_by_reference>: Update.
161         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
162         * infcall.c (call_function_by_hand_dummy): Update.
163         * language.c (language_pass_by_reference): Update.
164         (default_pass_by_reference): Update.
165         * tic6x-tdep.c (tic6x_return_value): Update.
167 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
169         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
170         and DW_AT_deleted attributes of a function.
171         (read_structure_type): Read the DW_AT_calling_convention attribute
172         of a type.
173         (is_valid_DW_AT_defaulted): New function.
174         (is_valid_DW_AT_calling_convention_for_type): New function.
175         * gdbtypes.h: Include dwarf2.h.
176         (struct fn_field)<defaulted>: New field to store the
177         DW_AT_defaulted attribute.
178         (struct fn_field)<is_deleted>: New field to store the
179         DW_AT_deleted attribute.
180         (struct cplus_struct_type)<calling_convention>: New field to store
181         the DW_AT_calling_convention attribute.
182         (TYPE_FN_FIELD_DEFAULTED): New macro.
183         (TYPE_FN_FIELD_DELETED): New macro.
184         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
185         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
186         to the .h file.
187         (print_cplus_stuff): Likewise.
189 2019-12-20  Tom Tromey  <tom@tromey.com>
191         * tui/tui.c (tui_show_source): Remove.
192         * tui/tui.h (tui_show_source): Don't declare.
193         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
194         tui_show_source.
196 2019-12-20  Tom Tromey  <tom@tromey.com>
198         * tui/tui-stack.h (tui_show_frame_info): Return bool.
199         * tui/tui-stack.c (tui_show_frame_info): Return bool.
200         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
201         Update.
203 2019-12-20  Tom Tromey  <tom@tromey.com>
205         PR tui/18932:
206         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
207         Rename parameters.  Handle the not-from-stack-frame case.
208         (from_stack, from_source_symtab): New globals.
209         (tui_before_prompt, tui_normal_stop): Update.
210         (tui_context_changed, tui_symtab_changed): New functions.
211         (tui_attach_detach_observers): Attach new observers.
213 2019-12-20  Tom Tromey  <tom@tromey.com>
215         * source.c (struct current_source_location) <set, symtab, line>:
216         New methods.
217         <m_symtab, m_line>: Rename.  Now private.
218         (get_current_source_symtab_and_line)
219         (set_default_source_symtab_and_line)
220         (set_current_source_symtab_and_line)
221         (clear_current_source_symtab_and_line, select_source_symtab)
222         (info_source_command, print_source_lines_base)
223         (info_line_command, search_command_helper): Update.
224         * observable.h (current_source_symtab_and_line_changed): Declare
225         observable.
226         * observable.c (current_source_symtab_and_line_changed): Define
227         observable.
229 2019-12-20  Tom Tromey  <tom@tromey.com>
231         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
232         (tui_before_prompt, tui_normal_stop): Update.
234 2019-12-20  Tom Tromey  <tom@tromey.com>
236         * tui/tui-winsource.c
237         (tui_source_window_base::update_source_window_as_is): Don't call
238         set_current_source_symtab_and_line.
240 2019-12-20  Tom Tromey  <tom@tromey.com>
242         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
243         Take a symtab_and_line.
244         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
245         symtab_and_line.
246         (tui_show_frame_info): Update.
248 2019-12-20  Tom Tromey  <tom@tromey.com>
250         * tui/tui-stack.c (tui_show_frame_info): Don't call
251         update_exec_info.
253 2019-12-20  Tom Tromey  <tom@tromey.com>
255         * tui/tui.c (tui_enable): Call tui_display_main.
257 2019-12-20  Tom Tromey  <tom@tromey.com>
259         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
260         get_current_source_symtab_and_line, and main_name.
262 2019-12-20  Tom Tromey  <tom@tromey.com>
264         * tui/tui.c (tui_show_source): Update.
265         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
266         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
267         a symtab_symbol_info, not a separate symtab and line.  Simplify.
269 2019-12-20  Tom Tromey  <tom@tromey.com>
271         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
272         Simplify.
274 2019-12-20  Tom Tromey  <tom@tromey.com>
276         * tui/tui-winsource.h (struct tui_source_window_base)
277         <set_contents, update_source_window_as_is, update_source_window>:
278         Take a sal, not a separate symtab and tui_line_or_address.
279         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
280         (tui_source_window_base::update_source_window_as_is): Take a sal,
281         not a separate symtab and tui_line_or_address.
282         (tui_update_source_windows_with_addr)
283         (tui_update_source_windows_with_line)
284         (tui_source_window_base::rerender)
285         (tui_source_window_base::refill): Update.
286         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
287         a sal, not a separate symtab and tui_line_or_address.
288         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
289         not a separate symtab and tui_line_or_address.
290         (tui_source_window::maybe_update): Update.
291         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
292         a sal, not a separate symtab and tui_line_or_address.
293         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
294         not a separate symtab and tui_line_or_address.
295         (tui_disasm_window::do_scroll_vertical)
296         (tui_disasm_window::maybe_update): Update.
298 2019-12-20  Tom Tromey  <tom@tromey.com>
300         * tui/tui-winsource.c (tui_source_window_base::refill): Use
301         start_line_or_addr.
302         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
303         start_line_or_addr.
304         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
305         start_line_or_addr.
307 2019-12-20  Tom Tromey  <tom@tromey.com>
309         * tui/tui-winsource.h (struct tui_source_window_base)
310         <set_contents>: Return bool.
311         * tui/tui-winsource.c
312         (tui_source_window_base::update_source_window_as_is): Update.
313         * tui/tui-source.h (struct tui_source_window) <set_contents>:
314         Return bool.
315         * tui/tui-source.c (tui_source_window::set_contents): Return
316         bool.  Simplify.
317         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
318         Return bool.
319         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
320         bool.
322 2019-12-20  Tom Tromey  <tom@tromey.com>
324         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
325         (tui_update_source_windows_with_line): Call update_source_window.
326         * tui/tui-source.h (struct tui_source_window)
327         <show_symtab_source>: Don't declare.
328         * tui/tui-source.c (tui_source_window::show_symtab_source):
329         Remove.
331 2019-12-20  Tom Tromey  <tom@tromey.com>
333         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
334         update_source_window directly.
335         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
336         * tui/tui-disasm.c (tui_show_disassem): Remove.
338 2019-12-20  Tom Tromey  <tom@tromey.com>
340         * tui/tui-winsource.c
341         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
342         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
344 2019-12-20  Tom Tromey  <tom@tromey.com>
346         * tui/tui-winsource.h (struct tui_source_window_base)
347         <maybe_update>: Remove line_no and addr parameters.
348         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
349         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
350         Update.
351         * tui/tui-source.c (tui_source_window::maybe_update): Remove
352         line_no and addr parameters.
353         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
354         Update.
355         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
356         line_no and addr parameters.
358 2019-12-20  Tom Tromey  <tom@tromey.com>
360         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
361         (tui_source_window_base::update_breakpoint_info): Remove asserts.
363 2019-12-20  Tom Tromey  <tom@tromey.com>
365         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
366         tui_show_disassem.
367         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
368         declare.
369         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
371 2019-12-20  Tom Tromey  <tom@tromey.com>
373         * tui/tui.h (tui_show_source): Remove parameters.
374         * tui/tui.c (tui_show_source): Remove parameters.
375         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
377 2019-12-20  Tom Tromey  <tom@tromey.com>
379         * tui/tui.c (tui_show_source): Update.
380         * tui/tui-winsource.c (tui_display_main): Update.
381         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
382         to symtab.
383         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
384         to symtab.
385         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
387 2019-12-20  Tom Tromey  <tom@tromey.com>
389         PR tui/23619:
390         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
391         (tui_redisplay_readline): Use rl_display_prompt.
392         (tui_prep_terminal): Update.
394 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
396         * configure: Regenerate.
397         * configure.ac: Quote variable arguments of test.
398         * gdbsupport/common.m4: Likewise.
400 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
402         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
403         2 to pow ().
405 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
407         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
408         log10 to double to fix Solaris 11 with gcc 5.5.
410 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
412         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
413         "sun" to "saddr_un".
415 2019-12-19  Tom Tromey  <tromey@adacore.com>
417         * ui-out.h (enum class field_kind): Fix comment.
419 2019-12-11  Tom Tromey  <tromey@adacore.com>
421         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
423 2019-12-18  Tom Tromey  <tromey@adacore.com>
425         PR build/25268:
426         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
427         type on macOS.  Add comment.
429 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
431         * c-lang.c (c_get_string, asm_language_defn): Remove space
432         before tab.
434 2019-12-18  Tom Tromey  <tromey@adacore.com>
436         PR build/25250:
437         * ui-out.c (ui_out::vmessage): Update.
438         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
439         Rename.
440         (string_field): Update.
441         (signed_field): Update.
443 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
445         * top.c (print_gdb_configuration): Adjust indentation.
447 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
449         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
451 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
453         * tui/tui-layout.h (class tui_layout_base): Add virtual
454         destructor.
456 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
458         * infcmd.c (prepare_one_step): Step over skipped inline functions.
459         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
460         (process_event_stop_test): Keep stepping over skipped inline functions.
462 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
464         * jit.c (struct gdb_block) <next>: Remove field.
465         (struct gdb_symtab) <~gdb_symtab>: Remove.
466         <blocks>: Change type to std::forward_list<gdb_block>.
467         (compare_block): Remove.
468         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
469         block at the beginning, don't mind about sorting.
470         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
471         before using it.
473 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
475         * jit.c (struct gdb_block): Add constructor, initialize
476         real_block and next fields.
477         <name>: Change type to gdb::unique_xmalloc_ptr.
478         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
479         (jit_block_open_impl): Allocate gdb_block with new.
480         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
482 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
484         * jit.c: Include forward_list.
485         (struct gdb_symtab) <next>: Remove field.
486         (struct gdb_object) <symtabs>: Change type to
487         std::forward_list<gdb_symtab>.
488         (jit_object_open_impl): Allocate gdb_object with new.
489         (jit_symtab_open_impl): Adjust to std::forward_list.
490         (finalize_symtab): Don't delete symtab.
491         (jit_object_close_impl):  Adjust to std::forward_list.  Free
492         gdb_object with delete.
494 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
496         * jit.c (struct gdb_symtab): Add constructor, destructor,
497         initialize fields.
498         <linetable>: Change type to unique_xmalloc_ptr.
499         <file_name>: Change type to std::string.
500         (jit_symtab_open_impl): Allocate gdb_symtab with new.
501         (jit_symtab_line_mapping_add_impl): Adjust.
502         (finalize_symtab): Adjust, call delete on stab.
504 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
506         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
508 2019-12-16  Tom Tromey  <tromey@adacore.com>
510         * windows-nat.c (windows_nat_target::attach): Update.
511         * remote.c (extended_remote_target::attach): Update.
512         * procfs.c (procfs_target::attach): Update.
513         * nto-procfs.c (nto_procfs_target::attach): Update.
514         (nto_procfs_target::create_inferior): Update.
515         * inf-ptrace.c (inf_ptrace_target::attach): Update.
516         * gnu-nat.c (gnu_nat_target::attach): Update.
517         (gnu_nat_target::detach): Update.
518         * darwin-nat.c (darwin_nat_target::attach): Update.
519         * corefile.c (get_exec_file): Constify result.  Remove extraneous
520         return.
521         * bsd-kvm.c (bsd_kvm_target_open): Update.
522         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
524 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
526         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
527         (we no longer need to include time.h before pathmax.h)
529 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
531         * ada-exp.y (write_ambiguous_var): Update.
532         * coffread.c (process_coff_symbol): Update.
533         * ctfread.c (ctf_add_enum_member_cb): Update.
534         (new_symbol): Update.
535         * dwarf2read.c (fixup_go_packaging): Update.
536         (new_symbol): Update.
537         * language.c (language_alloc_type_symbol): Update.
538         * mdebugread.c (new_symbol): Update.
539         * minsyms.c (minimal_symbol_reader::record_full): Update.
540         * psymtab.c (add_psymbol_to_bcache): Update.
541         * stabsread.c (define_symbol): Update.
542         (read_enum_type): Update.
543         * symtab.c (symbol_set_language): Make this a member function...
544         (general_symbol_info::set_language): ... here.
545         * symtab.h (struct general_symbol_info) <set_language>: New function.
546         (SYMBOL_SET_LANGUAGE): Remove.
547         (symbol_set_language): Remove.
549 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
551         * ada-lang.c (ada_add_block_symbols): Update.
552         (ada_collect_symbol_completion_matches): Update.
553         * ax-gdb.c (gen_expr): Update.
554         * block.c (block_lookup_symbol): Update.
555         (block_lookup_symbol_primary): Update.
556         (block_find_symbol): Update.
557         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
558         * dbxread.c (process_one_symbol): Update.
559         * dictionary.c (insert_symbol_hashed): Update.
560         (collate_pending_symbols_by_language): Update.
561         (mdict_add_symbol): Update.
562         * dwarf-index-write.c (write_psymbols): Update.
563         * dwarf2read.c (fixup_go_packaging): Update.
564         * findvar.c (read_var_value): Update.
565         * ft32-tdep.c (ft32_skip_prologue): Update.
566         * go-lang.c (go_symbol_package_name): Update.
567         * language.h (scoped_switch_to_sym_language_if_auto::
568         scoped_switch_to_sym_language_if_auto): Update.
569         * linespec.c (find_method): Update.
570         (find_label_symbols_in_block): Update.
571         * mdebugread.c (parse_symbol): Update.
572         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
573         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
574         (minimal_symbol_reader::install): Update.
575         * moxie-tdep.c (moxie_skip_prologue): Update.
576         * parse.c (parse_exp_in_context): Update.
577         * psymtab.c (psymbol_name_matches): Update.
578         (match_partial_symbol): Update.
579         (lookup_partial_symbol): Update.
580         (psymbol_hash): Update.
581         (psymbol_compare): Update.
582         * python/py-framefilter.c (extract_sym): Update.
583         (py_print_single_arg): Update.
584         * stabsread.c (define_symbol): Update.
585         * stack.c (print_frame_arg): Update.
586         (find_frame_funname): Update.
587         (info_frame_command_core): Update.
588         * symfile.c (set_initial_language): Update.
589         * symtab.c (symbol_set_demangled_name): Update.
590         (symbol_get_demangled_name): Update.
591         (symbol_set_language): Update.
592         (symbol_find_demangled_name): Update.
593         (symbol_set_names): Update.
594         (general_symbol_info::natural_name): Update.
595         (general_symbol_info::demangled_name): Update.
596         (general_symbol_info::search_name): Update.
597         (symbol_matches_search_name): Update.
598         (eq_symbol_entry): Update.
599         (iterate_over_symbols): Update.
600         (completion_list_add_symbol): Update.
601         (completion_list_add_msymbol): Update.
602         (completion_list_add_fields): Update.
603         * symtab.h (struct general_symbol_info) <language>: New function.
604         <language>: Rename to...
605         <m_language>: ...this.
606         (SYMBOL_LANGUAGE): Remove.
607         (MSYMBOL_LANGUAGE): Remove.
608         (struct symbol) <ctor>: Update.
609         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
611 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
613         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
614         set the language of sym.
615         * language.c (language_alloc_type_symbol): Likewise.
617 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
619         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
620         PR gdb/23613
621         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
622         * corelow.c: Include 'gdbsupport/pathstuff.h'.
623         (core_target_open): Use 'gdb_abspath'.
624         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
625         'current_directory == NULL' case.
626         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
627         explain what happens when 'current_directory' is NULL.
628         * go32-nat.c (go32_nat_target::wait): Check if
629         'current_directory' is NULL before call to 'chdir'.
630         * source.c (add_path): Use 'gdb_abspath'.
631         * top.c: Include 'gdbsupport/pathstuff.h'.
632         (init_history): Use 'gdb_abspath'.
633         (set_history_filename): Likewise.
634         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
635         (tfile_target_open): Use 'gdb_abspath'.
637 2019-12-13  Tom Tromey  <tromey@adacore.com>
639         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
640         warning or error.
642 2019-12-13  Tom Tromey  <tromey@adacore.com>
644         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
646 2019-12-13  Tom Tromey  <tromey@adacore.com>
648         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
650 2019-12-13  Tom Tromey  <tromey@adacore.com>
652         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
654 2019-12-13  Tom Tromey  <tromey@adacore.com>
656         * gdbsupport/common-utils.c (string_printf, string_vprintf)
657         (string_vappendf): Add ARI comment.
659 2019-12-13  Tom Tromey  <tromey@adacore.com>
661         * contrib/ari/gdb_ari.sh: Remove "fix" call for
662         floatformat_to_double.
663         * target-float.c (host_float_ops<T>::from_target): Add ARI
664         comment.
666 2019-12-13  Tom Tromey  <tromey@adacore.com>
668         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
669         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
670         ARI marker to abort.
671         * event-top.c (handle_sigsegv): Add ARI marker to abort.
673 2019-12-13  Tom Tromey  <tromey@adacore.com>
675         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
677 2019-12-13  Tom Tromey  <tromey@adacore.com>
679         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
681 2019-12-13  Tom Tromey  <tromey@adacore.com>
683         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
684         checks.
686 2019-12-13  Tom Tromey  <tromey@adacore.com>
688         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
689         end>: No longer "const".
691 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
693         * jit.c: Fix indentation, replace spaces with tabs where
694         applicable.
696 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
698         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
700 2019-12-12  Tom Tromey  <tom@tromey.com>
702         * objfiles.h (struct objfile) <partial_symtabs>: Now a
703         unique_ptr.
705 2019-12-12  Tom Tromey  <tom@tromey.com>
707         * progspace.h (objfile_list): New typedef.
708         (class unwrapping_objfile_iterator)
709         (struct unwrapping_objfile_range): Newl
710         (struct program_space) <objfiles_range>: Change type.
711         <objfiles>: Change return type.
712         <add_objfile>: Change type of "objfile" parameter.
713         <objfiles_list>: Now a list of shared_ptr.
714         * progspace.c (program_space::add_objfile): Change type of
715         "objfile".  Update.
716         (program_space::remove_objfile): Update.
717         * objfiles.h (struct objfile) <~objfile>: Make public.
718         * objfiles.c (objfile::make): Update.
719         (objfile::unlink): Don't call delete.
721 2019-12-12  Tom Tromey  <tom@tromey.com>
723         * symfile.c (symbol_file_clear): Update.
724         * progspace.h (struct program_space) <free_all_objfiles>: Declare
725         method.
726         * progspace.c (program_space::free_all_objfiles): New method.
727         * objfiles.h (free_all_objfiles): Don't declare.
728         * objfiles.c (free_all_objfiles): Move to program_space.
730 2019-12-12  Tom Tromey  <tom@tromey.com>
732         * progspace.c (program_space::add_objfile)
733         (program_space::remove_objfile): Update.
734         (program_space::multi_objfile_p): Remove.
735         * objfiles.h (struct objfile) <next>: Remove.
736         * objfiles.c (objfile::objfile): Update.
737         (put_objfile_before): Update.
738         (unlink_objfile): Update.
739         * progspace.h (object_files): Remove.
740         (struct program_space) <objfiles_head>: Remove.
741         <objfiles_list>: New member.
742         <objfiles_range, objfiles_safe_range>: Change type.
743         (objfiles): Change return type.
744         (objfiles_safe): Update.
745         (multi_objfile_p): Rewrite and inline.
746         (object_files): Remove macro.
748 2019-12-12  Tom Tromey  <tom@tromey.com>
750         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
751         second constructor.
752         (basic_safe_range): New class.
754 2019-12-12  Tom Tromey  <tom@tromey.com>
756         * progspace.c (program_space::multi_objfile_p): New method.
757         * printcmd.c (info_symbol_command): Update.
758         * maint.c (maintenance_translate_address): Update.
759         * objfiles.h (MULTI_OBJFILE_P): Remove.
760         * progspace.h (struct program_space) <multi_objfile_p>: New
761         method.
763 2019-12-12  Tom Tromey  <tom@tromey.com>
765         * progspace.h (struct program_space) <remove_objfile>: Declare.
766         * progspace.c (program_space::remove_objfile): New method.
767         * objfiles.c (unlink_objfile): Remove.
768         (objfile::unlink): Call remove_objfile.
769         (objfile): Don't call unlink_objfile.
771 2019-12-12  Tom Tromey  <tom@tromey.com>
773         * progspace.h (struct program_space) <add_objfile>: Declare
774         method.
775         * progspace.c (program_space::add_objfile): New method.
776         * objfiles.c (~objfile): Don't unlink objfile.
777         (put_objfile_before): Remove.
778         (add_separate_debug_objfile): Don't call put_objfile_before.
779         (objfile::make): Call add_objfile.  Set new_objfiles_available on
780         the per-program-space data.
782 2019-12-12  Tom Tromey  <tom@tromey.com>
784         * symfile.c (syms_from_objfile_1): Use objfile_up.
785         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
786         method.
787         (reread_symbols): Use objfile_up.
788         * solib.c (update_solib_list, reload_shared_libraries_1): Call
789         unlink method.
790         * objfiles.h (struct objfile) <~objfile>: Now private.
791         <unlink>: New method.
792         (struct objfile_deleter): New.
793         (objfile_up): New typedef.
794         * objfiles.c (objfile::unlink): New method.
795         (free_objfile_separate_debug, free_all_objfiles)
796         (objfile_purge_solibs): Use it.
797         * jit.c (jit_unregister_code): Remove.
798         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
799         objfile.
800         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
801         objfile.
802         * compile/compile-object-load.c (compile_object_load): Use
803         objfile_up.
805 2019-12-12  Tom Tromey  <tom@tromey.com>
807         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
808         objfile::make.
809         * objfiles.h (struct objjfile) <make>: No longer inline.
810         (add_separate_debug_objfile): Don't declare.
811         * objfiles.c (add_separate_debug_objfile): Now static.
812         (objfile::make): Move from objfiles.h.  Call
813         add_separate_debug_objfile.  Add "parent" parameter.
815 2019-12-12  Tom Tromey  <tom@tromey.com>
817         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
818         * objfiles.h (struct objfile): Make constructor private.
819         <make>: New static method.
820         * jit.c (jit_object_close_impl): Update.
822 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
824         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
825         gdb::byte_vector.
827 2019-12-12  Tom Tromey  <tromey@adacore.com>
829         * xml-support.c (xml_fetch_content_from_file): Don't call
830         malloc_failure.
831         * utils.h (class gdb_argv): Remove malloc_failure comment.
832         * utils.c (gdb_argv::reset): Don't call malloc_failure.
834 2019-12-12  Tom Tromey  <tromey@adacore.com>
836         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
837         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
838         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
839         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
840         * riscv-ravenscar-thread.c: New file.
841         * riscv-ravenscar-thread.h: New file.
842         * riscv-tdep.c (riscv_gdbarch_init): Call
843         register_riscv_ravenscar_ops.
845 2019-12-12  Tom Tromey  <tromey@adacore.com>
847         * gdbsupport/thread-pool.c (set_thread_name): Use
848         ATTRIBUTE_UNUSED.
850 2019-12-12  Luis Machado  <luis.machado@linaro.org>
852         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
853         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
854         macros.
856 2019-12-11  Tom Tromey  <tom@tromey.com>
858         * tui/tui-win.c (tui_set_win_height_command): Call
859         tui_adjust_window_height.
860         (tui_adjust_win_heights, new_height_ok): Remove.
861         * tui/tui-layout.h (tui_adjust_window_height): Declare.
862         * tui/tui-layout.c (tui_adjust_window_height): New function.
864 2019-12-11  Tom Tromey  <tom@tromey.com>
866         * tui/tui-win.c (tui_resize_all): Remove code, call
867         tui_apply_current_layout.
869 2019-12-11  Tom Tromey  <tom@tromey.com>
871         * tui/tui-layout.h (tui_apply_current_layout): Declare.
872         * tui/tui-layout.c (standard_layouts, applied_layout): New
873         globals.
874         (tui_apply_current_layout): New function.
875         (show_layout): Set applied_layout.  Call
876         tui_apply_current_layout.
877         (show_source_command, show_disasm_command)
878         (show_source_disasm_command, show_data)
879         (show_source_or_disasm_and_command): Remove.
880         (initialize_layouts): New function.
881         (_initialize_tui_layout): Call initialize_layouts.
883 2019-12-11  Tom Tromey  <tom@tromey.com>
885         * tui/tui-layout.h (class tui_layout_base)
886         (class tui_layout_window, class tui_layout_split): New.
887         * tui/tui-layout.c (tui_get_window_by_name)
888         (tui_layout_window::clone, tui_layout_window::apply)
889         (tui_layout_window::get_sizes, tui_layout_window::add_split)
890         (tui_layout_split::add_window, tui_layout_split::clone)
891         (tui_layout_split::get_sizes)
892         (tui_layout_split::set_weights_from_heights)
893         (tui_layout_split::adjust_size, tui_layout_split::apply): New
894         functions.
895         (tui_layout_split::add_split, tui_layout_split::add_split)
896         (tui_layout_split::set_weights_from_heights)
897         (tui_layout_split::set_weights_from_heights): New functions.
899 2019-12-11  Tom Tromey  <tom@tromey.com>
901         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
902         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
903         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
904         * tui/tui-data.h (struct tui_point): Remove.
905         (struct tui_gen_win_info) <origin>: Remove.
906         <x, y>: New fields.
907         * tui/tui-command.c (tui_cmd_window::resize): Update.
909 2019-12-11  Tom Tromey  <tom@tromey.com>
911         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
912         Implement.
913         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
914         Implement.
915         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
916         method.
917         (struct tui_win_info) <min_height>: Implement.
919 2019-12-11  Tom Tromey  <tom@tromey.com>
921         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
922         (struct tui_win_info) <can_box>: Update.
924 2019-12-11  Tom Tromey  <tom@tromey.com>
926         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
927         method.
928         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
929         method.
930         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
931         method.
932         (struct tui_win_info) <max_height>: Now override.
934 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
936         * NEWS: Create a new section for the next release branch.
937         Rename the section of the current branch, now that it has
938         been cut.
940 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
942         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
943         * version.in: Bump version to 10.0.50.DATE-git.
945 2019-12-11  Tom Tromey  <tromey@adacore.com>
947         PR build/25268:
948         * gdbsupport/thread-pool.c (set_thread_name): New function.
949         (thread_pool::set_thread_count): Don't call pthread_setname_np.
950         (thread_pool::thread_function): Call set_thread_name.
952 2019-12-11  Tom Tromey  <tromey@adacore.com>
954         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
955         bfd_get_signed_8.
957 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
959         * NEWS: Document -raw-values option and the related setting commands.
960         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
961         only set it on when /r is given.
962         * valprint.c (value_print_option_defs): New element raw-values.
963         * Makefile.in: Add the new file.
965 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
967         * gdbsupport/safe-strerror.c: Supress the unused function warning
968         for select_strerror_r.
970 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
972         * config.in: Regenerate.
973         * configure: Regenerate.
974         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
975         safe_strerror instead of strerror.
976         * gdbsupport/common.m4: Don't check for strerror.
977         * gdbsupport/safe-strerror.c: Support both the glibc version
978         of strerror_r and the XSI version.
980 2019-12-10  Tom Tromey  <tromey@adacore.com>
982         * ada-typeprint.c (print_choices): Use a single "?".
983         (print_variant_part): Print "?" if the discriminant name
984         is not known.
986 2019-12-10  George Barrett  <bob@bob131.so>
988         Fix scripted probe breakpoints.
989         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
990         declaration forward.
991         (breakpoint_ops_for_event_location_type)
992         (breakpoint_ops_for_event_location): Add function definitions.
993         (break_command_1, trace_command): Use
994         breakpoint_ops_for_event_location.
995         * breakpoint.h (breakpoint_ops_for_event_location): Add function
996         declarations.
997         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
998         breakpoint_ops_for_event_location.
999         * python/py-breakpoint.c (bppy_init): Use
1000         breakpoint_ops_for_event_location.
1002 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1004         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
1005         when ranking an lvalue argument for an rvalue parameter.
1007 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
1009         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
1010         template argument for scoped_restore_tmpl from bool to int.
1012 2019-12-07  Keith Seitz  <keiths@redhat.com>
1014         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
1015         (build_id_to_debug_bfd): Make static, rewriting to use
1016         build_id_to_bfd_suffix.
1017         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
1018         adding `suffix' parameter. Append SUFFIX to file names
1019         when searching for matching files.
1020         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
1021         (build_id_to_exec_bfd): Likewise.
1022         * build-id.h (build_id_to_debug_bfd): Clarify that function
1023         searches for BFD of debug info file.
1024         (build_id_to_exec_bfd): Declare.
1025         * corelow.c: Include build-id.h.
1026         (locate_exec_from_corefile_build_id): New function.
1027         (core_target_open): If no executable BFD is found,
1028         search for a core file BFD using build-id.
1030 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
1032         * bcache.c: Put in namespace gdb.
1033         * bcache.h: Likewise.
1034         * gdbtypes.c (check_types_worklist): Update.
1035         (types_deeply_equal): Update.
1036         * macrotab.c (struct macro_table) <bcache>: Update.
1037         (new_macro_table): Update.
1038         * macrotab.h (struct bcache): Put this forward declaration
1039         inside namespace gdb.
1040         (new_macro_table): Update.
1041         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
1042         Update.
1043         <macro_cache>: Update.
1044         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
1046 2019-12-06  Tom de Vries  <tdevries@suse.de>
1048         PR symtab/24971
1049         * block.c (best_symbol, better_symbol): New function.
1050         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
1051         decl.
1053 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1055         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
1056         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
1057         for ranking see-through reference cases.
1059 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1060         * stack.c (faas_command): Check a command is provided.
1061         * thread.c (taas_command, tfaas_command): Likewise.
1063 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064         * inferior.c (prune_inferiors):  Only call delete_inferior,
1065         Do not modify the inferior list.
1067 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
1069         * c-exp.y: Update calls to lookup_typename,
1070         lookup_signed_typename and lookup_unsigned_typename.
1071         * c-lang.c (evaluate_subexp_c): Likewise.
1072         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
1073         Likewise.
1074         * eval.c (binop_promote): Likewise.
1075         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
1076         (lookup_unsigned_typename): Likewise.
1077         (lookup_signed_typename): Likewise.
1078         * gdbtypes.h (lookup_unsigned_typename): Likewise.
1079         (lookup_signed_typename): Likewise.
1080         (lookup_typename): Likewise.
1081         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
1082         lookup_typename, lookup_signed_typename,
1083         lookup_unsigned_typename.
1084         * m2-exp.y: Likewise.
1085         * printcmd.c (printf_wide_c_string): Likewise.
1086         (ui_printf): Likewise.
1087         * python/py-type.c (typy_lookup_typename): Likewise.
1088         * python/py-xmethods.c (python_xmethod_worker::invoke):
1089         Likewise.
1090         * rust-exp.y: Likewise.
1092 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
1094         * configure.nat (obsd64): Add missing files x86-nat.o and
1095         nat/x86-dregs.o.
1097 2019-12-04  Tom Tromey  <tom@tromey.com>
1099         * valprint.c (val_print_string): Use metadata_style.
1100         * go-valprint.c (print_go_string): Use metadata style.
1101         * p-valprint.c (pascal_object_print_static_field): Use metadata
1102         style.
1103         * cp-valprint.c (cp_print_static_field): Use metadata style.
1105 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1106             Chris January  <chris.january@arm.com>
1108         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1109         tokens.
1110         (typebase): New patterns for complex, single/double precision, and
1111         single/double complex.
1112         (f77_keywords): Change token for complex keyword, and add single,
1113         double, and precision keywords.
1115 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1117         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1118         "info io_registers".
1120 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1122         * regcache.c (cooked_read_test): Initialize thread list of
1123         mock_inferior.
1125 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1127         * aarch64-linux-tdep.c: Remove includes.
1129 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1131         * aarch64-tdep.c: Remove includes.
1133 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
1135         * filtered-iterator.h (filtered_iterator) <operator==,
1136         operator!=>: Compare wrapped iterators, not wrapped pointers.
1137         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1138         unittests/filtered_iterator-selftests.c.
1139         * unittests/filtered_iterator-selftests.c: New file.
1141 2019-12-04  Tom Tromey  <tromey@adacore.com>
1143         * gdbtypes.c (create_range_type): Inherit endianity
1144         from base type.
1146 2019-12-04  Tom Tromey  <tromey@adacore.com>
1148         * ada-lang.c (decode_constrained_packed_array)
1149         (ada_value_assign, value_assign_to_component): Update.
1150         * dwarf2loc.c (rw_pieced_value, access_memory)
1151         (dwarf2_compile_expr_to_ax): Update.
1152         * dwarf2read.c (dwarf2_add_field): Update.
1153         * eval.c (evaluate_subexp_standard): Update.
1154         * gdbarch.c, gdbarch.h: Rebuild.
1155         * gdbarch.sh (bits_big_endian): Remove.
1156         * gdbtypes.h (union field_location): Update comment.
1157         * target-descriptions.c (make_gdb_type): Update.
1158         * valarith.c (value_bit_index): Update.
1159         * value.c (struct value) <bitpos>: Update comment.
1160         (unpack_bits_as_long, modify_field): Update.
1161         * value.h (value_bitpos): Update comment.
1163 2019-12-04  Tom Tromey  <tromey@adacore.com>
1165         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1166         endian-ness.
1168 2019-12-04  Tom Tromey  <tromey@adacore.com>
1170         * dwarf2read.c (dwarf2_init_float_type)
1171         (dwarf2_init_complex_target_type): Add byte_order parameter.
1172         (read_base_type): Compute byte order earlier.
1173         * gdbtypes.c (init_float_type): Add byte_order parameter.
1174         * gdbtypes.h (init_float_type): Add byte_order parameter.
1176 2019-12-04  Tom Tromey  <tromey@adacore.com>
1178         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1180 2019-12-04  Tom Tromey  <tromey@adacore.com>
1182         * dwarf2read.c (process_structure_scope): Initialize
1183         "discr_offset".
1185 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1187         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1188         add it into the search spec.
1189         (parse_max_results_option): New function.
1190         (mi_info_functions_or_variables): Parse -max-results flag and pass
1191         it to mi_symbol_info.
1192         (mi_cmd_symbol_info_modules): Likewise.
1193         (mi_cmd_symbol_info_types): Likewise.
1194         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1195         return type to bool, change result container into a set, and don't
1196         add new results if we have enough already.
1197         (global_symbol_searcher::add_matching_msymbols): Change return
1198         type to bool, and don't add new results if we have enough already.
1199         (sort_search_symbols_remove_dups): Delete.
1200         (global_symbol_searcher::search): Early exit from search loop when
1201         we have enough results.  Use a std::set to collect the results
1202         from calling add_matching_symbols.
1203         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1204         member function.
1205         (global_symbol_searcher) <m_max_search_results>: New member
1206         variable.
1207         (global_symbol_searcher) <add_matching_symbols>: Update header
1208         comment and change return type to bool.
1209         (global_symbol_searcher) <add_matching_msymbols>: Update header
1210         comment and change return type to bool.
1212 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1214         * symtab.c (symbol_search::compare_search_syms): Update header
1215         comment.
1216         (global_symbol_searcher::is_suitable_msymbol): New function.
1217         (global_symbol_searcher::expand_symtabs): New function.
1218         (global_symbol_searcher::add_matching_symbols): New function.
1219         (global_symbol_searcher::add_matching_msymbols): New function.
1220         (global_symbol_searcher::search): Move most of the content
1221         into the new functions above, and call them as needed.
1222         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1223         function.
1224         (global_symbol_searcher) <add_matching_symbols>: New member
1225         function.
1226         (global_symbol_searcher) <add_matching_msymbols>: New member
1227         function.
1228         (global_symbol_searcher) <is_suitable_msymbol>: New member
1229         function.
1231 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1233         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1234         -symbol-info-module-variables entries.
1235         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1236         (mi_cmd_symbol_info_module_variables): Declare.
1237         * mi/mi-symbol-cmds.c
1238         (module_symbol_search_iterator): New typedef.
1239         (output_module_symbols_in_single_module_and_file): New function.
1240         (output_module_symbols_in_single_module): New function.
1241         (mi_info_module_functions_or_variables): New function.
1242         (mi_cmd_symbol_info_module_functions): New function.
1243         (mi_cmd_symbol_info_module_variables): New function.
1244         * NEWS: Mention new MI command.
1246 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1248         * bcache.c (hash): Remove.
1249         (hash_continue): Remove.
1250         * bcache.h (hash): Remove.
1251         (hash_continue): Remove.
1252         (struct bcache) <ctor>: Update.
1253         * psymtab.c (psymbol_hash): Update.
1254         * stabsread.c (hashname): Update.
1255         * utils.h (fast_hash): Add an argument for a start value,
1256         defaulting to zero.
1258 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1260         (destroy_block_symbol_cache): New function.
1261         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1262         (resize_symbol_cache): Likewise.
1264 2019-12-02  Tom Tromey  <tom@tromey.com>
1266         * unittests/tui-selftests.c (run_tests): Make conditional.
1267         (_initialize_tui_selftest): Make conditional.
1269 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1271         * aix-thread.c (debug_aix_thread): Change type to bool.
1273 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1275         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1277 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1279         * dwarf2read.c (read_tag_string_type): Read the fields required to
1280         make a dynamic string, and possibly create a dynamic range for the
1281         string.
1282         (attr_to_dynamic_prop): Setup is_reference based on the type of
1283         attribute being processed.
1284         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1285         (resolve_dynamic_array): Rename to...
1286         (resolve_dynamic_array_or_string): ...this, update header comment,
1287         and accept TYPE_CODE_STRING.
1288         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1290 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1292         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1293         of its implementation from...
1294         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1295         the new function.
1297 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1299         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1300         create a range with stride where appropriate.
1301         * f-valprint.c: Include 'gdbarch.h'.
1302         (f77_print_array_1): Take the stride into account when walking the
1303         array.  Also convert the stride into addressable units.
1304         * gdbtypes.c (create_range_type): Initialise the stride to
1305         constant zero.
1306         (create_range_type_with_stride): New function, initialise the
1307         range as normal, and then setup the stride.
1308         (has_static_range): Include the stride here.  Also change the
1309         return type to bool.
1310         (create_array_type_with_stride): Consider the range stride if the
1311         array isn't given its own stride.
1312         (resolve_dynamic_range): Resolve the stride if needed.
1313         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1314         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1315         (TYPE_BIT_STRIDE): Define.
1316         (TYPE_ARRAY_BIT_STRIDE): Define.
1317         (create_range_type_with_stride): Declare.
1318         * valarith.c (value_subscripted_rvalue): Take range stride into
1319         account when walking the array.
1321 2019-12-01  Tom Tromey  <tom@tromey.com>
1323         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1324         specially.
1326 2019-12-01  Tom Tromey  <tom@tromey.com>
1328         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1329         \0.
1330         * unittests/tui-selftests.c: New file.
1331         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1333 2019-12-01  Tom Tromey  <tom@tromey.com>
1335         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1337 2019-12-01  Tom Tromey  <tom@tromey.com>
1339         * NEWS: Document new settings.
1340         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1341         * tui/tui-win.c (_initialize_tui_win): Add border style
1342         observers.
1343         * tui/tui-io.h (tui_apply_style): Declare.
1344         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1345         longer static.
1346         (apply_ansi_escape, tui_set_reverse_mode): Update.
1347         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1348         Add "skip_intensity" parameter.
1349         <changed>: New member.
1350         <do_set_value>: Declare.
1351         (tui_border_style, tui_active_border_style): Declare.
1352         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1353         globals.
1354         (cli_style_option): Initialize "changed".
1355         (cli_style_option::do_set_value): New function.
1356         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1357         parameter.  Update.
1358         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1359         (_initialize_cli_style): Update.  Create TUI border style
1360         commands.
1362 2019-12-01  Tom Tromey  <tom@tromey.com>
1364         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1365         parameter.
1366         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1367         parameter.
1368         * tui/tui-win.h (compact_source): Declare.
1369         * tui/tui-win.c (compact_source): New global.
1370         (tui_set_compact_source, tui_show_compact_source): New functions.
1371         (_initialize_tui_win): Add "compact-source" setting.
1372         * tui/tui-source.c (tui_source_window::set_contents): Handle
1373         compact_source setting.
1374         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1375         * NEWS: Document new setting.
1377 2019-11-30  Tom Tromey  <tom@tromey.com>
1379         * dwarf2read.c (dwarf2_add_field): Include field offset when
1380         computing variant part length.
1382 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1383         * NEWS:  Mention define-prefix.  Tell that command names can now
1384         contain a . character.
1386 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1388         * command.h (valid_cmd_char_p): Declare.
1389         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1390         the check of valid command char.
1391         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1392         valid_cmd_char_p.
1393         * cli/cli-script.c (validate_comname): Likewise.
1394         * completer.c (gdb_completer_command_word_break_characters):
1395         Do not remove . from the word break char, update comments.
1396         (complete_line_internal_1): Use valid_cmd_char_p.
1397         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1398         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1400 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1402         * cli/cli-script.c (do_define_command): Ensure a redefined
1403         prefix command is kept as a prefix command.
1404         (define_prefix_command): New function.
1405         (show_user_1): Report user defined prefixes.
1406         (_initialize_cli_script):  Create the new 'define-prefix' command.
1407         Add completers for 'define' and 'document'.
1408         * top.c (execute_command):  If command is a user-defined prefix only
1409         command, report the list of commands for this prefix command.
1411 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1413         * valops.c (find_oload_champ): Improve debug output.
1415 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1417         * valops.c (find_oload_champ): Print part of debug messages
1418         before the badness vector is std::move'd.
1420 2019-11-28  Tom Tromey  <tom@tromey.com>
1422         * value.c (creal_internal_fn): Fix comment.
1424 2019-11-28  Tom Tromey  <tom@tromey.com>
1426         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1427         flag_bound_evaluated>: Now unsigned.
1429 2019-11-28  Tom Tromey  <tom@tromey.com>
1431         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1432         declare.
1434 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1436         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1437         debug output.
1438         * jit.c (jit_unregister_code): Add debug print to match
1439         `jit_register_code`.
1441 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1443         * NEWS: Mention the new multithreaded symbol loading.
1445 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1447         * maint.c (n_worker_threads): Default to 0.
1448         (worker_threads_disabled): New function.
1449         * maint.h (worker_threads_disabled): New function.
1450         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1451         here if worker_threads_disabled () is true.
1452         (minimal_symbol_reader::install): Skip all threading if
1453         worker_threads_disabled () is true.
1455 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1457         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1458         hash code if possible.
1459         (add_minsym_to_demangled_hash_table): Likewise.
1460         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1461         on the background thread.
1462         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1463         Add these fields.
1465 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1467         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1468         of the mangled name on the background thread.
1469         * symtab.c (symbol_set_names): Allow passing in the hash of the
1470         linkage_name.
1471         * symtab.h (symbol_set_names): Likewise.
1473 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1475         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1476         physnames are computed for inherited DIEs.
1478 2019-11-27  Tom Tromey  <tromey@adacore.com>
1480         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1481         backslashes.
1482         * cp-support.c: Remove unnecessary backslashes.
1484 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1486         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1487         with sym->set_linkage_name.
1488         * coffread.c (coff_read_enum_type): Likewise.
1489         * mdebugread.c (parse_symbol): Likewise.
1490         * stabsread.c (patch_block_stabs): Likewise.
1491         (define_symbol): Likewise.
1492         (read_enum_type): Likewise.
1493         (common_block_end): Likewise.
1494         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1495         function.
1496         (SYMBOL_SET_LINKAGE_NAME): Remove.
1497         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1498         with sym->set_linkage_name.
1500 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1502         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1503         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1504         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1505         * NEWS: Mention new MI command.
1507 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1509         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1510         '-symbol-info-types', and '-symbol-info-variables'.
1511         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1512         (mi_cmd_symbol_info_types): Declare.
1513         (mi_cmd_symbol_info_variables): Declare.
1514         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1515         (output_debug_symbol): New function.
1516         (output_nondebug_symbol): New function.
1517         (mi_symbol_info): New function.
1518         (mi_info_functions_or_variables): New function.
1519         (mi_cmd_symbol_info_functions): New function.
1520         (mi_cmd_symbol_info_types): New function.
1521         (mi_cmd_symbol_info_variables): New function.
1522         * NEWS: Mention new commands.
1524 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1526         * symtab.c (symbol_to_info_string): New function, most content
1527         moved from print_symbol_info, but updated to return a std::string.
1528         (print_symbol_info): Update to use symbol_to_info_string and print
1529         returned string.
1530         * symtab.h (symbol_to_info_string): Declare new function.
1532 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1534         * python/python.c (gdbpy_rbreak): Convert to using
1535         global_symbol_searcher.
1536         * symtab.c (file_matches): Convert return type to bool, change
1537         file list to std::vector, update header comment.
1538         (search_symbols): Rename to...
1539         (global_symbol_searcher::search): ...this and update now its
1540         a member function of global_symbol_searcher.  Take account of the
1541         changes to file_matches.
1542         (symtab_symbol_info): Convert to using global_symbol_searcher.
1543         (rbreak_command): Likewise.
1544         (search_module_symbols): Likewise.
1545         * symtab.h (enum symbol_search): Update comment.
1546         (search_symbols): Remove declaration.
1547         (class global_symbol_searcher): New class.
1549 2019-11-26  Tom Tromey  <tromey@adacore.com>
1551         * cp-support.c (_initialize_cp_support): Conditionally initialize
1552         gdb_demangle_attempt_core_dump.
1554 2019-11-26  Tom Tromey  <tom@tromey.com>
1556         * python/py-function.c (fnpy_init): Update.
1557         * value.h (add_internal_function): Adjust declaration.
1558         * value.c (function_destroyer): Remove.
1559         (do_add_internal_function): Don't set destroyer or copy name.
1560         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1561         Set name_allocated.
1562         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1563         (cmdpy_init): Set name_allocated.
1564         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1565         member.
1566         (~cmd_list_element): Free "name" if needed.
1568 2019-11-26  Tom Tromey  <tom@tromey.com>
1570         * value.h (add_internal_function): Add new overload.  Move
1571         documentation from value.h.
1572         * value.c (do_add_internal_function): New function.
1573         (add_internal_function): Use it.  Add new overload.
1574         (function_destroyer): Don't free doc.
1575         * python/py-function.c (fnpy_init): Update.
1577 2019-11-26  Tom Tromey  <tom@tromey.com>
1579         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1580         (cmdpy_init): Set "doc_allocated".
1582 2019-11-26  Tom Tromey  <tom@tromey.com>
1584         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1585         name of worker thread.
1586         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1587         pthread_setname_np.
1588         * configure, config.in: Rebuild.
1590 2019-11-26  Tom Tromey  <tom@tromey.com>
1592         * python/python.c (class gdbpy_gil): New.
1593         (struct gdbpy_event): Add constructor, destructor, operator().
1594         (gdbpy_post_event): Use run_on_main_thread.
1595         (gdbpy_initialize_events): Remove.
1596         (do_start_initialization): Update.
1598 2019-11-26  Tom Tromey  <tom@tromey.com>
1600         * NEWS: Add entry.
1601         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1602         commands.  Call update_thread_pool_size.
1603         (update_thread_pool_size, maintenance_set_worker_threads): New
1604         functions.
1605         (n_worker_threads): New global.
1607 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1608             Tom Tromey  <tom@tromey.com>
1610         * minsyms.c (minimal_symbol_reader::install): Use
1611         parallel_for_each.
1612         * gdbsupport/parallel-for.h: New file.
1613         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1615 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1616             Tom Tromey  <tom@tromey.com>
1618         * gdbsupport/thread-pool.h: New file.
1619         * gdbsupport/thread-pool.c: New file.
1620         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1621         (HFILES_NO_SRCDIR): Add thread-pool.h.
1623 2019-11-26  Tom Tromey  <tom@tromey.com>
1625         * event-top.h (thread_local_segv_handler): Declare.
1626         * event-top.c (thread_local_segv_handler): New global.
1627         (install_handle_sigsegv, handle_sigsegv): New functions.
1628         (async_init_signals): Install SIGSEGV handler.
1629         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1630         thread-local.
1631         (report_failed_demangle): New function.
1632         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1633         handler-setting code, instead use segv_handler.  Run warning code
1634         on main thread.
1636 2019-11-26  Tom Tromey  <tom@tromey.com>
1638         * run-on-main-thread.c: New file.
1639         * run-on-main-thread.h: New file.
1640         * unittests/main-thread-selftests.c: New file.
1641         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1642         main-thread-selftests.c.
1643         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1644         (COMMON_SFILES): Add run-on-main-thread.c.
1646 2019-11-26  Tom Tromey  <tom@tromey.com>
1648         * main.c (setup_alternate_signal_stack): Remove.
1649         (captured_main_1): Use gdb::alternate_signal_stack.
1650         * gdbsupport/alt-stack.h: New file.
1652 2019-11-26  Tom Tromey  <tom@tromey.com>
1654         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1655         Remove comment.
1656         (save_original_signals_state, restore_original_signals_state): Use
1657         gdb_sigmask.
1658         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1659         (_initialize_linux_nat): Use gdb_sigmask.
1660         * guile/guile.c (_initialize_guile): Use block_signals.
1661         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1662         * gdbsupport/gdb-sigmask.h: New file.
1663         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1664         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1665         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1666         pthread_sigmask.
1667         * configure, config.in: Rebuild.
1668         * gdbsupport/block-signals.h: New file.
1670 2019-11-26  Tom Tromey  <tom@tromey.com>
1672         * acinclude.m4: Include ax_pthread.m4.
1673         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1674         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1675         (CLIBS): Use PTHREAD_LIBS.
1676         (aclocal_m4_deps): Add ax_pthread.m4.
1677         * config.in, configure: Rebuild.
1678         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1680 2019-11-26  Tom Tromey  <tom@tromey.com>
1682         * symtab.h (struct minimal_symbol) <name_set>: New member.
1683         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1684         Don't call symbol_set_names.
1685         (minimal_symbol_reader::install): Call symbol_set_names.
1687 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1690         restore_active_ext_lang, as GIL is needed for (indirectly)
1691         called PyOS_InterruptOccurred.
1693 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1695         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1696         definition.
1698 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1700         * remote-sim.c (simulator_command): Make static, remove
1701         declaration.
1703 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1705         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1706         static.
1707         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1708         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1709         (main): Likewise.
1710         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1711         (main): Likewise.
1712         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1713         (main): Likewise.
1714         * unittests/basic_string_view/element_access/char/1.cc (test01):
1715         Likewise.
1716         (main): Likewise.
1717         * unittests/basic_string_view/element_access/char/empty.cc (main):
1718         Likewise.
1719         * unittests/basic_string_view/element_access/char/front_back.cc
1720         (test01): Likewise.
1721         (main): Likewise.
1722         * unittests/basic_string_view/inserters/char/2.cc (test05):
1723         Likewise.
1724         (main): Likewise.
1725         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1726         (test01): Likewise.
1727         (main): Likewise.
1728         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1729         (test01): Likewise.
1730         (main): Likewise.
1731         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1732         Likewise.
1733         * unittests/basic_string_view/operations/compare/char/1.cc
1734         (test01): Likewise.
1735         (main): Likewise.
1736         * unittests/basic_string_view/operations/compare/char/13650.cc
1737         (test01): Likewise.
1738         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1739         Likewise.
1740         (main): Likewise.
1741         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1742         Likewise.
1743         (main): Likewise.
1744         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1745         Likewise.
1746         (main): Likewise.
1747         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1748         Likewise.
1749         (main): Likewise.
1750         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1751         Likewise.
1752         (main): Likewise.
1753         * unittests/basic_string_view/operations/find/char/4.cc (main):
1754         Likewise.
1755         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1756         Likewise.
1757         (main): Likewise.
1758         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1759         Likewise.
1760         (main): Likewise.
1761         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1762         Likewise.
1763         (main): Likewise.
1764         * unittests/basic_string_view/operations/substr/char/1.cc
1765         (test01): Likewise.
1766         (main): Likewise.
1767         * unittests/basic_string_view/operators/char/2.cc (main):
1768         Likewise.
1769         * unittests/optional/assignment/1.cc (test): Likewise.
1770         * unittests/optional/assignment/2.cc (test): Likewise.
1771         * unittests/optional/assignment/3.cc (test): Likewise.
1772         * unittests/optional/assignment/4.cc (test): Likewise.
1773         * unittests/optional/assignment/5.cc (test): Likewise.
1774         * unittests/optional/assignment/6.cc (test): Likewise.
1775         * unittests/optional/assignment/7.cc (test): Likewise.
1776         * unittests/optional/cons/copy.cc (test): Likewise.
1777         * unittests/optional/cons/default.cc (test): Likewise.
1778         * unittests/optional/cons/move.cc (test): Likewise.
1779         * unittests/optional/cons/value.cc (test): Likewise.
1780         * unittests/optional/in_place.cc (test): Likewise.
1781         * unittests/optional/observers/1.cc (test): Likewise.
1782         * unittests/optional/observers/2.cc (test): Likewise.
1784 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1786         * tui-win.h (tui_set_var_cmd): Remove.
1787         * tui-win.c (tui_set_var_cmd): Make static.
1789 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1791         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1792         rbreak_command_wrapper): Remove.
1793         * symtab.c (rbreak_command_wrapper): Remove.
1795 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1797         * inferior.h (info_terminal_command): Remove declaration.
1798         * inflow.c (info_terminal_command): Make static.
1800 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1802         * inferior.c (exit_inferior_silent): Remove.
1804 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1806         * dictionary.c (dict_empty, mdict_empty): Remove.
1807         * dictionary.c (mdict_empty): Remove.
1809 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1811          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1812          (arc_insn_get_memory_offset): Likewise.
1813          (arc_insn_dump): Likewise.
1814          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1815          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1816          * dictionary.c (dict_iterator_next): Likewise.
1817          (dict_iter_match_first): Likewise.
1818          (dict_iter_match_next): Likewise.
1819          * f-lang.c (evaluate_subexp_f): Likewise.
1820          * hppa-tdep.c (hppa_read_pc): Likewise.
1821          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1822          * parse.c (write_exp_elt_msym): Likewise.
1823          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1824          * remote.c (remote_packet_size): Likewise.
1825          (remote_notif_stop_parse): Likewise.
1826          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1827          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1828          * source.c (prepare_path_for_appending): Likewise.
1829          * sparc64-linux-tdep.c
1830          (sparc64_linux_handle_segmentation_fault); Likewise.
1831          * stack.c (frame_selection_by_function_completer): Likewise.
1833 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1835         * completer.c (set_gdb_completion_word_break_characters):
1836         Remove.
1838 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1840         * dwarf-index-write.c: Include dwarf-index-write.h.
1841         * mi/mi-interp.c: Include mi/mi-interp.h.
1843 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1845         * aarch32-tdep.c: Include aarch32-tdep.h.
1846         * aarch32-tdep.h: Forward-declare struct target_desc.
1848 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1850         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1851         strerror.
1852         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1853         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1855 2019-11-25  Tom de Vries  <tdevries@suse.de>
1857         * contrib/words.sh: Add -c option.
1859 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1861         * solib.c (solib_find_1): Change int to bool.
1862         (exec_file_find): Change int to bool.
1863         (solib_find): Change int to bool.
1864         (solib_read_symbols): Change int to bool.
1865         (solib_used): Change int to bool.
1866         (solib_add): Change int to bool.
1867         (info_sharedlibrary_command): Change int to bool.
1868         (solib_contains_address_p): Change int to bool.
1869         (solib_keep_data_in_core): Change int to bool.
1870         (in_solib_dynsym_resolve_code): Change int to bool.
1871         (reload_shared_libraries_1): Change int to bool.
1872         (gdb_sysroot_changed): Change int to bool.
1873         * solib.h (solib_read_symbols): Change int to bool.
1874         (solib_contains_address_p): Change int to bool.
1875         (solib_keep_data_in_core): Change int to bool.
1876         (in_solib_dynsym_resolve_code): Change int to bool.
1877         (libpthread_name_p): Change int to bool.
1879 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1881         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1882         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1883         (remote_packet_max_chars): New static global.
1884         (show_remote_packet_max_chars): New function.
1885         (remote_target::putpkt_binary): Adjust to use new
1886         remote_packet_max_chars option.
1887         (remote_target::getpkt_or_notif_sane_1): Likewise.
1888         (_initialize_remote): Register new remote-packet-max-chars option.
1890 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1892         * m68k-linux-nat.c: Include gdbarch.h.
1894 2019-11-24  Tom Tromey  <tom@tromey.com>
1896         * symfile.c (read_symbols): Update.
1897         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1898         bool.
1899         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1900         (psym_lookup_symbol, psym_find_last_source_symtab)
1901         (psym_forget_cached_source_info, psym_print_stats)
1902         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1903         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1904         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1905         (psym_find_compunit_symtab_by_address)
1906         (maintenance_print_psymbols, maintenance_info_psymtabs)
1907         (maintenance_check_psymtabs): Update.
1908         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1909         bool.
1911 2019-11-22  Tom Tromey  <tom@tromey.com>
1913         * observable.h: Update comments.
1915 2019-11-22  Tom Tromey  <tromey@adacore.com>
1917         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1918         (print_ada_task_info): Don't try to fetch thread id if task is not
1919         alive.
1921 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1923         * ada-exp.y: Update.
1924         * ada-lang.c (sort_choices): Update.
1925         (ada_print_symbol_signature): Update.
1926         (resolve_subexp): Update.
1927         (ada_parse_renaming): Update.
1928         (ada_read_renaming_var_value): Update.
1929         (lesseq_defined_than): Update.
1930         (remove_extra_symbols): Update.
1931         (remove_irrelevant_renamings): Update.
1932         (ada_add_block_symbols): Update.
1933         (ada_collect_symbol_completion_matches): Update.
1934         (ada_is_renaming_symbol): Update.
1935         (aggregate_assign_from_choices): Update.
1936         (ada_evaluate_subexp): Update.
1937         (ada_has_this_exception_support): Update.
1938         (ada_is_non_standard_exception_sym): Update.
1939         (ada_add_exceptions_from_frame): Update.
1940         (ada_add_global_exceptions): Update.
1941         (ada_print_subexp): Update.
1942         * ax-gdb.c (gen_var_ref): Update.
1943         (gen_maybe_namespace_elt): Update.
1944         (gen_expr_for_cast): Update.
1945         (gen_expr): Update.
1946         * block.h: Update.
1947         * blockframe.c (find_pc_partial_function): Update.
1948         * breakpoint.c (print_breakpoint_location): Update.
1949         (update_static_tracepoint): Update.
1950         * btrace.c (ftrace_print_function_name): Update.
1951         (ftrace_function_switched): Update.
1952         * buildsym.c (find_symbol_in_list): Update.
1953         * c-exp.y: Update.
1954         * c-typeprint.c (c_print_typedef): Update.
1955         (c_type_print_template_args): Update.
1956         * cli/cli-cmds.c (edit_command): Update.
1957         (list_command): Update.
1958         (print_sal_location): Update.
1959         * coffread.c (patch_opaque_types): Update.
1960         (process_coff_symbol): Update.
1961         (coff_read_enum_type): Update.
1962         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1963         (convert_one_symbol): Update.
1964         (hash_symname): Update.
1965         (eq_symname): Update.
1966         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1967         * compile/compile-cplus-types.c (debug_print_scope): Update.
1968         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1969         * compile/compile-object-load.c (get_out_value_type): Update.
1970         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1971         (search_symbol_list): Update.
1972         (cp_lookup_symbol_imports_or_template): Update.
1973         * cp-support.c (overload_list_add_symbol): Update.
1974         * ctfread.c (psymtab_to_symtab): Update.
1975         * dbxread.c (cp_set_block_scope): Update.
1976         * dictionary.c (iter_match_first_hashed): Update.
1977         (iter_match_next_hashed): Update.
1978         (insert_symbol_hashed): Update.
1979         (iter_match_next_linear): Update.
1980         * dictionary.h: Update.
1981         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1982         (locexpr_describe_location_piece): Update.
1983         (locexpr_describe_location_1): Update.
1984         (locexpr_generate_c_location): Update.
1985         (loclist_describe_location): Update.
1986         (loclist_generate_c_location): Update.
1987         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1988         (read_func_scope): Update.
1989         (process_enumeration_scope): Update.
1990         (new_symbol): Update.
1991         (dwarf2_const_value): Update.
1992         (dwarf2_symbol_mark_computed): Update.
1993         * eval.c (evaluate_funcall): Update.
1994         (evaluate_subexp_standard): Update.
1995         * expprint.c (print_subexp_standard): Update.
1996         (dump_subexp_body_standard): Update.
1997         * f-valprint.c (info_common_command_for_block): Update.
1998         * findvar.c (get_hosting_frame): Update.
1999         (default_read_var_value): Update.
2000         * go-lang.c (go_symbol_package_name): Update.
2001         * guile/scm-block.c (bkscm_print_block_smob): Update.
2002         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
2003         (gdbscm_symbol_name): Update.
2004         (gdbscm_symbol_linkage_name): Update.
2005         (gdbscm_symbol_print_name): Update.
2006         * infcall.c (get_function_name): Update.
2007         * infcmd.c (jump_command): Update.
2008         (finish_command): Update.
2009         * infrun.c (insert_exception_resume_breakpoint): Update.
2010         * linespec.c (canonicalize_linespec): Update.
2011         (create_sals_line_offset): Update.
2012         (convert_linespec_to_sals): Update.
2013         (complete_label): Update.
2014         (find_label_symbols_in_block): Update.
2015         * m2-typeprint.c (m2_print_typedef): Update.
2016         * mdebugread.c (mdebug_reg_to_regnum): Update.
2017         (parse_symbol): Update.
2018         (mylookup_symbol): Update.
2019         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2020         (list_args_or_locals): Update.
2021         * objc-lang.c (compare_selectors): Update.
2022         (info_selectors_command): Update.
2023         (compare_classes): Update.
2024         (info_classes_command): Update.
2025         (find_imps): Update.
2026         * p-typeprint.c (pascal_print_typedef): Update.
2027         * printcmd.c (build_address_symbolic): Update.
2028         (info_address_command): Update.
2029         (print_variable_and_value): Update.
2030         * python/py-framefilter.c (extract_sym): Update.
2031         (py_print_single_arg): Update.
2032         * python/py-symbol.c (sympy_str): Update.
2033         (sympy_get_name): Update.
2034         (sympy_get_linkage_name): Update.
2035         * python/python.c (gdbpy_rbreak): Update.
2036         * record-btrace.c (btrace_get_bfun_name): Update.
2037         (btrace_call_history): Update.
2038         * rust-lang.c (rust_print_typedef): Update.
2039         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
2040         * stabsread.c (stab_reg_to_regnum): Update.
2041         (define_symbol): Update.
2042         (read_enum_type): Update.
2043         (common_block_end): Update.
2044         (cleanup_undefined_types_1): Update.
2045         (scan_file_globals): Update.
2046         * stack.c (print_frame_arg): Update.
2047         (print_frame_args): Update.
2048         (find_frame_funname): Update.
2049         (info_frame_command_core): Update.
2050         (iterate_over_block_locals): Update.
2051         (print_block_frame_labels): Update.
2052         (do_print_variable_and_value): Update.
2053         (iterate_over_block_arg_vars): Update.
2054         (return_command): Update.
2055         * symmisc.c (dump_symtab_1): Update.
2056         (print_symbol): Update.
2057         * symtab.c (eq_symbol_entry): Update.
2058         (symbol_cache_dump): Update.
2059         (lookup_language_this): Update.
2060         (find_pc_sect_line): Update.
2061         (skip_prologue_sal): Update.
2062         (symbol_search::compare_search_syms): Update.
2063         (treg_matches_sym_type_name): Update.
2064         (search_symbols): Update.
2065         (print_symbol_info): Update.
2066         (rbreak_command): Update.
2067         (completion_list_add_symbol): Update.
2068         (find_gnu_ifunc): Update.
2069         (get_symbol_address): Update.
2070         (search_module_symbols): Update.
2071         (info_module_subcommand): Update.
2072         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
2073         (SYMBOL_LINKAGE_NAME): Remove.
2074         (SYMBOL_DEMANGLED_NAME): Remove.
2075         (SYMBOL_PRINT_NAME): Remove.
2076         (SYMBOL_SEARCH_NAME): Remove.
2077         * tracepoint.c (set_traceframe_context): Update.
2078         (validate_actionline): Update.
2079         (collection_list::collect_symbol): Update.
2080         (encode_actions_1): Update.
2081         (info_scope_command): Update.
2082         (print_one_static_tracepoint_marker): Update.
2083         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
2084         * valops.c (address_of_variable): Update.
2085         (find_overload_match): Update.
2086         (find_oload_champ): Update.
2088 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2090         * ada-lang.c (ada_lookup_simple_minsym): Update.
2091         (ada_collect_symbol_completion_matches): Update.
2092         * ada-tasks.c (read_atcb): Update.
2093         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
2094         (amd64_windows_skip_trampoline_code): Update.
2095         * arm-tdep.c (skip_prologue_function): Update.
2096         (arm_skip_stack_protector): Update.
2097         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
2098         (arm_wince_skip_main_prologue): Update.
2099         * ax-gdb.c (gen_expr): Update.
2100         * block.c (call_site_for_pc): Update.
2101         * blockframe.c (find_pc_partial_function): Update.
2102         * breakpoint.c (set_breakpoint_location_function): Update.
2103         * btrace.c (ftrace_print_function_name): Update.
2104         (ftrace_function_switched): Update.
2105         * c-valprint.c (print_unpacked_pointer): Update.
2106         * coffread.c (coff_symfile_read): Update.
2107         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2108         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2109         * dwarf-index-write.c (write_psymbols): Update.
2110         * dwarf2loc.c (call_site_to_target_addr): Update.
2111         (func_verify_no_selftailcall): Update.
2112         (tailcall_dump): Update.
2113         (call_site_find_chain_1): Update.
2114         (dwarf_expr_reg_to_entry_parameter): Update.
2115         * elfread.c (elf_gnu_ifunc_record_cache): Update.
2116         * eval.c (evaluate_funcall): Update.
2117         (evaluate_subexp_standard): Update.
2118         (evaluate_subexp_for_sizeof): Update.
2119         * expprint.c (print_subexp_standard): Update.
2120         (dump_subexp_body_standard): Update.
2121         * frame.c (get_prev_frame_always_1): Update.
2122         * frv-tdep.c (frv_skip_main_prologue): Update.
2123         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2124         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2125         (gnuv3_get_typename_from_type_info): Update.
2126         (gnuv3_skip_trampoline): Update.
2127         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2128         * i386-tdep.c (i386_skip_main_prologue): Update.
2129         (i386_pe_skip_trampoline_code): Update.
2130         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2131         * infcall.c (get_function_name): Update.
2132         * linespec.c (minsym_found): Update.
2133         * linux-fork.c (info_checkpoints_command): Update.
2134         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2135         (m32c_m16c_pointer_to_address): Update.
2136         * maint.c (maintenance_translate_address): Update.
2137         * minsyms.c (add_minsym_to_hash_table): Update.
2138         (add_minsym_to_demangled_hash_table): Update.
2139         (lookup_minimal_symbol_mangled): Update.
2140         (lookup_minimal_symbol_demangled): Update.
2141         (lookup_minimal_symbol_linkage): Update.
2142         (lookup_minimal_symbol_text): Update.
2143         (lookup_minimal_symbol_by_pc_name): Update.
2144         (minimal_symbol_is_less_than): Update.
2145         (compact_minimal_symbols): Update.
2146         (build_minimal_symbol_hash_tables): Update.
2147         (find_solib_trampoline_target): Update.
2148         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2149         (mips_skip_pic_trampoline_code): Update.
2150         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2151         * objc-lang.c (info_selectors_command): Update.
2152         (info_classes_command): Update.
2153         (find_methods): Update.
2154         (find_imps): Update.
2155         * p-valprint.c (pascal_val_print): Update.
2156         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2157         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2158         * printcmd.c (build_address_symbolic): Update.
2159         (info_symbol_command): Update.
2160         * psymtab.c (psymbol_name_matches): Update.
2161         (match_partial_symbol): Update.
2162         (lookup_partial_symbol): Update.
2163         (print_partial_symbols): Update.
2164         (sort_pst_symbols): Update.
2165         (maintenance_check_psymtabs): Update.
2166         * python/py-framefilter.c (py_print_frame): Update.
2167         * python/python.c (gdbpy_rbreak): Update.
2168         * record-btrace.c (btrace_get_bfun_name): Update.
2169         (btrace_call_history): Update.
2170         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2171         (rs6000_skip_trampoline_code): Update.
2172         * sol-thread.c (info_cb): Update.
2173         * stabsread.c (scan_file_globals): Update.
2174         * stack.c (find_frame_funname): Update.
2175         (info_frame_command_core): Update.
2176         * symmisc.c (dump_msymbols): Update.
2177         * symtab.c (symbol_natural_name): Rename to..,
2178         (general_symbol_info::natural_name): ...this.
2179         (symbol_demangled_name): Rename to...
2180         (general_symbol_info::demangled_name): ...this.
2181         (symbol_search_name): Rename to...
2182         (general_symbol_info::search_name): ...this.
2183         (symbol_matches_search_name): Update.
2184         (find_pc_sect_line): Update.
2185         (skip_prologue_sal): Update.
2186         (search_symbols): Update.
2187         (print_msymbol_info): Update.
2188         (rbreak_command): Update.
2189         (completion_list_add_msymbol): Update.
2190         (completion_list_objc_symbol): Update.
2191         (get_msymbol_address): Update.
2192         * symtab.h (struct general_symbol_info): Add member functions
2193         natural_name (), linkage_name (), print_name (), demangled_name (),
2194         and search_name ().
2195         (SYMBOL_NATURAL_NAME): Update.
2196         (symbol_natural_name): Move to a member function on general_symbol_info.
2197         (SYMBOL_DEMANGLED_NAME): Update.
2198         (symbol_demangled_name): Move to a member function on
2199         general_symbol_info.
2200         (SYMBOL_SEARCH_NAME): Update.
2201         (symbol_search_name): Move to a member function on general_symbol_info.
2202         (MSYMBOL_NATURAL_NAME): Remove.
2203         (MSYMBOL_LINKAGE_NAME): Remove.
2204         (MSYMBOL_PRINT_NAME): Remove.
2205         (MSYMBOL_DEMANGLED_NAME): Remove.
2206         (MSYMBOL_SEARCH_NAME): Remove.
2207         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2209 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2211         * symtab.c (create_demangled_names_hash): Use per_bfd->
2212         minimal_symbol_count for computing the initial size, if greater
2213         than our default size.
2215 2019-11-22  Tom de Vries  <tdevries@suse.de>
2217         * contrib/words.sh: Improve words extraction.
2219 2019-11-22  Tom de Vries  <tdevries@suse.de>
2221         * contrib/words.sh: Combine sed invocations.
2223 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2225         * Makefile.in: Update.
2226         * demangle.c: Rename to...
2227         * gdb-demangle.c: ..this.
2228         (is_cplus_marker): Change return type to bool.
2229         (_initialize_demangler): Rename to...
2230         (_initialize_gdb_demangle): ...this.
2231         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2232         * symtab.h (demangle): Remove declaration; instead include
2233         gdb-demangle.h.
2235 2019-11-21  Tom Tromey  <tromey@adacore.com>
2237         * gdbsupport/format.c (format_pieces): Parse %I64d.
2238         * unittests/format_pieces-selftests.c (test_windows_formats): New
2239         function.
2240         (run_tests): Call it.
2242 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2244         Byte reverse display of variables with DW_END_big, DW_END_little
2245         (DW_AT_endianity) dwarf attributes if different than the native
2246         byte order.
2247         * ada-lang.c (ada_value_binop):
2248         Use type_byte_order instead of gdbarch_byte_order.
2249         * ada-valprint.c (printstr):
2250         (ada_val_print_string):
2251         * ada-lang.c (value_pointer):
2252         (ada_value_binop):
2253         Use type_byte_order instead of gdbarch_byte_order.
2254         * c-lang.c (c_get_string):
2255         Use type_byte_order instead of gdbarch_byte_order.
2256         * c-valprint.c (c_val_print_array):
2257         Use type_byte_order instead of gdbarch_byte_order.
2258         * cp-valprint.c (cp_print_class_member):
2259         Use type_byte_order instead of gdbarch_byte_order.
2260         * dwarf2loc.c (rw_pieced_value):
2261         Use type_byte_order instead of gdbarch_byte_order.
2262         * dwarf2read.c (read_base_type): Handle DW_END_big,
2263         DW_END_little
2264         * f-lang.c (f_get_encoding):
2265         Use type_byte_order instead of gdbarch_byte_order.
2266         * findvar.c (default_read_var_value):
2267         Use type_byte_order instead of gdbarch_byte_order.
2268         * gdbtypes.c (check_types_equal):
2269         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2270         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2271         and TYPE_ENDIANITY_LITTLE if set.
2272         (type_byte_order): new function.
2273         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2274         (struct main_type) <flag_endianity_not_default>:
2275         New field.
2276         (type_byte_order): New function.
2277         * infcmd.c (default_print_one_register_info):
2278         Use type_byte_order instead of gdbarch_byte_order.
2279         * p-lang.c (pascal_printstr):
2280         Use type_byte_order instead of gdbarch_byte_order.
2281         * p-valprint.c (pascal_val_print):
2282         Use type_byte_order instead of gdbarch_byte_order.
2283         * printcmd.c (print_scalar_formatted):
2284         Use type_byte_order instead of gdbarch_byte_order.
2285         * solib-darwin.c (darwin_current_sos):
2286         Use type_byte_order instead of gdbarch_byte_order.
2287         * solib-svr4.c (solib_svr4_r_ldsomap):
2288         Use type_byte_order instead of gdbarch_byte_order.
2289         * stap-probe.c (stap_modify_semaphore):
2290         Use type_byte_order instead of gdbarch_byte_order.
2291         * target-float.c (target_float_same_format_p):
2292         Use type_byte_order instead of gdbarch_byte_order.
2293         * valarith.c (scalar_binop):
2294         (value_bit_index):
2295         Use type_byte_order instead of gdbarch_byte_order.
2296         * valops.c (value_cast):
2297         Use type_byte_order instead of gdbarch_byte_order.
2298         * valprint.c (generic_emit_char):
2299         (generic_printstr):
2300         (val_print_string):
2301         Use type_byte_order instead of gdbarch_byte_order.
2302         * value.c (unpack_long):
2303         (unpack_bits_as_long):
2304         (unpack_value_bitfield):
2305         (modify_field):
2306         (pack_long):
2307         (pack_unsigned_long):
2308         Use type_byte_order instead of gdbarch_byte_order.
2309         * findvar.c (unsigned_pointer_to_address):
2310         (signed_pointer_to_address):
2311         (unsigned_address_to_pointer):
2312         (address_to_signed_pointer):
2313         (default_read_var_value):
2314         (default_value_from_register):
2315         Use type_byte_order instead of gdbarch_byte_order.
2316         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2317         Use type_byte_order instead of gdbarch_byte_order.
2318         * riscv-tdep.c (riscv_print_one_register_info):
2319         Use type_byte_order instead of gdbarch_byte_order.
2321 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2323         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2324         (current_ui_gdb_stdin_ptr): Likewise.
2325         (current_ui_gdb_stderr_ptr): Likewise.
2326         (current_ui_gdb_stdlog_ptr): Likewise.
2327         (current_ui_current_uiout_ptr): Likewise.
2328         (gen_ret_current_ui_field_ptr): Remove.
2330 2019-11-21  Tom de Vries  <tdevries@suse.de>
2332         PR gdb/24956
2333         * cli/cli-script.c (execute_control_command): Only switch to
2334         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2336 2019-11-19  Tom Tromey  <tom@tromey.com>
2338         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2339         Now static.  Change type of "name".
2340         (tui_set_win_height_command): Don't copy "arg".
2341         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2342         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2344 2019-11-19  Ali Tamur <tamur@google.com>
2346         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2347         "if (attr != nullptr)".
2348         (dwarf2_find_base_address): Likewise.
2349         (dwarf2_build_include_psymtabs): Likewise.
2350         (read_cutu_die_from_dwo): Likewise.
2351         (read_func_scope): Likewise.
2352         (read_call_site_scope): Likewise.
2353         (dwarf2_get_pc_bounds): Likewise.
2354         (dwarf2_record_block_ranges): Likewise.
2355         (dwarf2_add_field): Likewise.
2356         (dwarf2_add_member_fn): Likewise.
2357         (read_structure_type): Likewise.
2358         (read_enumeration_type): Likewise.
2359         (read_array_type): Likewise.
2360         (read_array_order): Likewise.
2361         (read_set_type): Likewise.
2362         (read_common_block): Likewise.
2363         (read_tag_reference_type): Likewise.
2364         (read_tag_string_type): Likewise.
2365         (read_subroutine_type): Likewise.
2366         (read_base_type): Likewise.
2367         (read_subrange_type): Likewise.
2368         (new_symbol): Likewise.
2369         (prepare_one_comp_unit): Likewise.
2371 2019-11-19  Tom Tromey  <tromey@adacore.com>
2373         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2374         result in error when DebugActiveProcess fails.
2376 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2377             Pedro Alves  <palves@redhat.com>
2379         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2380         * target.c (target_stack::push): Call 'unpush' if there's a
2381         target on top of the stack.
2383 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2385         * python/py-block.c (blpy_dealloc): Call tp_free.
2386         (blpy_block_syms_dealloc): Likewise.
2387         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2388         * python/py-inferior.c (infpy_dealloc): Likewise.
2389         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2390         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2391         * python/py-symbol.c (sympy_dealloc): Likewise.
2392         * python/py-symtab.c (stpy_dealloc): Likewise.
2393         * python/py-type.c (typy_iterator_dealloc): Likewise.
2395 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2397         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2398         constructor instead of using a class initializer.
2400 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2402         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2403         * configure: Regenerate.
2404         * configure.ac: Don't source common.host.
2405         * gdbsupport/common.host: Remove.
2406         * gdbsupport/mingw-strerror.c: Remove.
2407         * gdbsupport/posix-strerror.c: Rename to...
2408         * gdbsupport/safe-strerror.c: ...this.
2410 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2412         * maint.c (scoped_command_stats::print_time): Use localtime_r
2413         instead of localtime (provided through gnulib if necessary).
2414         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2415         of ctime.
2417 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2419         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2420         avoid compile errors.
2422 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2424         * config.in: Regenerate.
2425         * configure: Regenerate.
2426         * gdbsupport/common.m4: No longer check for strerror_r.
2427         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2428         POSIX version of strerror_r, now that gnulib provides it if
2429         necessary.
2431 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2433         * README (`configure' options): Update.
2435 2019-11-14  Tom Tromey  <tromey@adacore.com>
2437         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2438         expected type for the RHS if the LHS is a convenience variable.
2440 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2442         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2443         Provide explicit default and copy constructor.
2445 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2447         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2448         only call Py_INCREF (newbp) in the bppy_pending_object case.
2450 2019-11-13  Tom Tromey  <tromey@adacore.com>
2452         PR build/25182:
2453         * psympriv.h (partial_symbol): Remove static assert.
2454         * symtab.h (general_symbol_info, symbol): Remove static assert.
2456 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2458         * gdbsupport/format.c (format_pieces::format_pieces): Support
2459         printf 'z' size modifier.
2460         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2461         * printcmd.c (ui_printf):  Handle size_t_arg.
2462         * ui-out.c (ui_out::vmessage): Likewise.
2463         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2464         function.
2465         (run_tests): Call test_format_int_sizes.
2467 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2469         * ada-exp.y (write_ambiguous_var): Update.
2470         * buildsym.c (add_symbol_to_list): Update.
2471         * dwarf2read.c (read_variable): Update.
2472         (new_symbol): Update.
2473         * jit.c (finalize_symtab): Update.
2474         * language.c (language_alloc_type_symbol): Update.
2475         * symtab.c (fixup_symbol_section): Update.
2476         (initialize_objfile_symbol_1): Move code to...
2477         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2478         (allocate_symbol): Update.
2479         (allocate_template_symbol): Update.
2480         (get_symbol_address): Update.
2481         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2482         of having as a field, and add a constructor.
2483         (SYMBOL_VALUE): Update.
2484         (SYMBOL_VALUE_ADDRESS): Update.
2485         (SET_SYMBOL_VALUE_ADDRESS): Update.
2486         (SYMBOL_VALUE_BYTES): Update.
2487         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2488         (SYMBOL_BLOCK_VALUE): Update.
2489         (SYMBOL_VALUE_CHAIN): Update.
2490         (SYMBOL_LANGUAGE): Update.
2491         (SYMBOL_SECTION): Update.
2492         (SYMBOL_OBJ_SECTION): Update.
2493         (SYMBOL_SET_LANGUAGE): Update.
2494         (SYMBOL_SET_LINKAGE_NAME): Update.
2495         (SYMBOL_SET_NAMES): Update.
2496         (SYMBOL_NATURAL_NAME): Update.
2497         (SYMBOL_LINKAGE_NAME): Update.
2498         (SYMBOL_DEMANGLED_NAME): Update.
2499         (SYMBOL_SEARCH_NAME): Update.
2500         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2501         (struct symbol): Update.
2502         (struct template_symbol): Update.
2503         (struct rust_vtable_symbol): Update.
2504         * xcoffread.c (SYMBOL_DUP): Update.
2506 2019-11-12  Tom Tromey  <tom@tromey.com>
2508         * tui/tui-layout.c (show_layout): Set current_layout.
2509         (show_source_disasm_command, show_data)
2510         (show_source_or_disasm_and_command): Don't set current_layout.
2512 2019-11-12  Tom Tromey  <tom@tromey.com>
2514         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2516 2019-11-12  Tom Tromey  <tom@tromey.com>
2518         * tui/tui-win.c (resize_message): New global.
2519         (show_tui_resize_message): New function.
2520         (tui_async_resize_screen): Print message if requested.
2521         (_initialize_tui_win): Add tui-resize-message setting.
2522         * NEWS: Add entry for new commands.
2524 2019-11-11  Tom Tromey  <tom@tromey.com>
2526         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2527         functions.
2529 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2531         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2533 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2535         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2536         function.
2537         * python/python-internal.h (gdbpy_lookup_static_symbols):
2538         Declare new function.
2539         * python/python.c (python_GdbMethods): Add
2540         gdb.lookup_static_symbols method.
2541         * NEWS: Mention gdb.lookup_static_symbols.
2543 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2545         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2546         static block of current object file first.  Also fix typo in
2547         header comment.
2549 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2551         * stack.c (set_last_displayed_sal): Delete.
2552         (last_displayed_sal_valid): Delete.
2553         (last_displayed_pspace): Delete.
2554         (last_displayed_addr): Delete.
2555         (last_displayed_symtab): Delete.
2556         (last_displayed_line): Delete.
2557         (class last_displayed_symtab_info_type): New.
2558         (last_displayed_symtab_info): New static global variable.
2559         (print_frame_info): Call methods on last_displayed_symtab_info.
2560         (clear_last_displayed_sal): Update header comment, and make use of
2561         last_displayed_symtab_info.
2562         (last_displayed_sal_is_valid): Likewise.
2563         (get_last_displayed_pspace): Likewise.
2564         (get_last_displayed_addr): Likewise.
2565         (get_last_displayed_symtab): Likewise.
2566         (get_last_displayed_line): Likewise.
2567         (get_last_displayed_sal): Likewise.
2568         * stack.h (clear_last_displayed_sal): Update header comment.
2569         (last_displayed_sal_is_valid): Likewise.
2570         (get_last_displayed_pspace): Likewise.
2571         (get_last_displayed_addr): Likewise.
2572         (get_last_displayed_symtab): Likewise.
2573         (get_last_displayed_line): Likewise.
2574         (get_last_displayed_sal): Likewise.
2576 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2578         * stack.c (frame_show_address): Convert return type to bool.
2579         * stack.h (frame_show_address): Likewise, and update header
2580         comment.
2582 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2584         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2585         * unittests/vec-utils-selftests.c: New file.
2586         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2588 2019-11-10  Tom Tromey  <tom@tromey.com>
2590         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2591         (tui_highlight_win): Likewise.
2592         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2593         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2594         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2595         Don't set can_highlight.
2597 2019-11-10  Tom Tromey  <tom@tromey.com>
2599         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2600         Remove unused declaration.
2602 2019-11-08  Tom Tromey  <tromey@adacore.com>
2604         * top.c (read_command_file): Update.
2605         (command_line_input): Make return type const.
2606         * python/py-gdb-readline.c: Update.
2607         * linespec.c (decode_line_2): Update.
2608         * defs.h (command_line_input): Make return type const.
2609         * cli/cli-script.c (read_next_line): Make return type const.
2610         * ada-lang.c (get_selections): Update.
2612 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2614         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2615         * mi/mi-main.c (output_cores): Likewise.
2616         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2617         (linux_xfer_osdata_modules): Likewise.
2618         * remote.c (register_remote_support_xml): Likewise.
2619         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2620         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2622 2019-11-06  Tom Tromey  <tom@tromey.com>
2624         * tui/tui-interp.c: Don't include readline.h.
2625         * tui/tui-hooks.c: Don't include readline.h.
2626         * symmisc.c: Include tilde.h, not readline.h.
2627         * symfile.c: Include tilde.h, not readline.h.
2628         * source.c: Include tilde.h, not readline.h.
2629         * solib.c: Include tilde.h, not readline.h.
2630         * psymtab.c: Include tilde.h, not readline.h.
2631         * exec.c: Include tilde.h, not readline.h.
2632         * corelow.c: Include tilde.h, not readline.h.
2633         * cli/cli-dump.c: Include tilde.h, not readline.h.
2634         * cli/cli-cmds.c: Don't include readline.h.
2636 2019-11-05  Tom Tromey  <tom@tromey.com>
2638         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2639         (tui_disassemble): Set addr_size.
2640         (tui_disasm_window::set_contents): Use addr_size.
2642 2019-11-05  Tom Tromey  <tom@tromey.com>
2644         * rust-lang.c (rust_language_defn): Update.
2645         * python/py-value.c (valpy_string): Call c_get_string.
2646         * p-lang.c (pascal_language_defn): Update.
2647         * opencl-lang.c (opencl_language_defn): Update.
2648         * objc-lang.c (objc_language_defn): Update.
2649         * m2-lang.c (m2_language_defn): Update.
2650         * language.c (unknown_language_defn, auto_language_defn): Update.
2651         (default_get_string): Remove.
2652         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2653         * go-lang.c (go_language_defn): Update.
2654         * f-lang.c (f_language_defn): Update.
2655         * d-lang.c (d_language_defn): Update.
2656         * c-lang.c (c_language_defn, cplus_language_defn)
2657         (asm_language_defn, minimal_language_defn): Update.
2658         * ada-lang.c (ada_language_defn): Update.
2659         * language.h (struct language_defn) <la_get_string>: Remove.
2660         (LA_GET_STRING): Remove.
2661         (default_get_string): Don't declare.
2663 2019-11-05  Tom Tromey  <tom@tromey.com>
2665         * tui/tui-source.h (struct tui_source_window): Inline
2666         constructor.  Remove destructor.
2667         <style_changed, m_observable>: Move to superclass.
2668         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2669         (struct tui_source_window_base): Move private members to end.
2670         <style_changed, m_observable>: Move from tui_source_window.
2671         * tui/tui-winsource.c (tui_copy_source_line): Move from
2672         tui-source.c.  Rename from copy_source_line.  Add special handling
2673         for negative line number.
2674         (tui_source_window_base::style_changed): Move from
2675         tui_source_window.
2676         (tui_source_window_base): Register observer.
2677         (~tui_source_window_base): New.
2678         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2679         rename.
2680         (tui_source_window::set_contents): Use tui_copy_source_line.
2681         (tui_source_window::tui_source_window): Move to tui-source.h.
2682         (tui_source_window::~tui_source_window): Remove.
2683         (tui_source_window::style_changed): Move to superclass.
2684         * tui/tui-disasm.c (tui_disassemble): Create string file with
2685         styling, when possible.  Add "addr_size" parameter.
2686         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2687         Don't compute maximum size.
2688         (len_without_escapes): New function
2690 2019-11-05  Tom Tromey  <tom@tromey.com>
2692         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2693         std::string.
2694         * tui/tui-winsource.c (tui_show_source_line): Update.
2695         * tui/tui-source.c (tui_source_window::set_contents): Update.
2696         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2698 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2700         * symtab.h (gdb_static_assert): Put && operator at the beginning
2701         of the line instead of the end.
2703 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2705         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2706         and sizeof (symbol).
2707         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2709 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2711         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2712         * configure.host: Mark *-*-solaris2.10* obsolete.
2713         * configure.tgt: Mark Solaris < 11 obsolete.
2714         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2715         Update target triplet.
2717 2019-11-01  Tom Tromey  <tromey@adacore.com>
2719         * utils.c (print_sys_errmsg): Simplify.
2721 2019-11-01  Tom Tromey  <tromey@adacore.com>
2723         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2725 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2727         * configure: Regenerate.
2728         * configure.ac: Remove check for strerror_r.
2729         * gdbsupport/common.m4: Check for strerror_r.
2731 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2733         PR gdb/25124
2735         * arm-tdep.c (arm_per_objfile): Rename to ...
2736         (arm_per_bfd): ... this.
2737         (arm_objfile_data_key): Rename to ...
2738         (arm_bfd_data_key): ... this.
2739         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2740         data.
2741         (arm_record_special_symbol): Likewise.
2743 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2745         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2746         end.
2747         * c-typeprint.c (c_print_typedef): Likewise.
2748         * f-typeprint.c (f_print_typedef): Likewise.
2749         * m2-typeprint.c (m2_print_typedef): Likewise.
2750         * p-typeprint.c (pascal_print_typedef): Likewise.
2751         * rust-lang.c (rust_print_typedef): Likewise.
2752         * symtab.c (print_symbol_info): Print a newline after calling
2753         typedef_print.
2755 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2757         * symtab.c (info_module_cmdlist): New variable.
2758         (info_module_command): New function.
2759         (search_module_symbols): New function.
2760         (info_module_subcommand): New function.
2761         (struct info_modules_var_func_options): New struct.
2762         (info_modules_var_func_options_defs): New variable.
2763         (make_info_modules_var_func_options_def_group): New function.
2764         (info_module_functions_command): New function.
2765         (info_module_variables_command): New function.
2766         (info_module_var_func_command_completer): New function.
2767         (_initialize_symtab): Register new 'info module functions' and
2768         'info module variables' commands.
2769         * symtab.h (typedef symbol_search_in_module): New typedef.
2770         (search_module_symbols): Declare new function.
2771         * NEWS: Mention new commands.
2773 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2775         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2776         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2777         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2778         MODULES_DOMAIN.
2779         (scan_partial_symbols): Only create partial module symbols for non
2780         declarations.
2781         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2782         and MODULES_DOMAIN.
2783         * symtab.c (search_domain_name): Likewise.
2784         (search_symbols): Likewise.
2785         (print_symbol_info): Likewise.
2786         (symtab_symbol_info): Likewise.
2787         (info_modules_command): New function.
2788         (_initialize_symtab): Register 'info modules' command.
2789         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2790         * NEWS: Mention new 'info modules' command.
2792 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2794         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2795         and $_gdb_maint_setting_str.
2797 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2799         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2800         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2801         (str_value_from_setting, gdb_setting_str_internal_fn)
2802         (gdb_maint_setting_str_internal_fn): New functions.
2803         (_initialize_cli_cmds): Define the new convenience functions.
2804         * cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2805         * cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2807 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2809         * agent.c (set_can_use_agent): When the setting is turned on,
2810         look up agent symbols if we don't have them yet.
2811         (agent_new_objfile): Don't look up agent symbols when the agent
2812         setting is off.
2814 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2816         * config.in: Regenerate.
2818 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2820         * configure: Regenerate.
2821         * configure.ac: Check for strerror_r.
2822         * gdbsupport/common-utils.h (safe_strerror): Change return value
2823         to const char * and document that this function is now threadsafe.
2824         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2825         thread_local and call strerror_r, if available.
2826         * utils.c (perror_string): Update.
2827         (print_sys_errmsg): Update.
2829 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2831         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2832         objfile_key.
2833         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2834         objfile to fetch per-bfd data.
2835         (arm_find_exidx_entry): Likewise.
2837 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2839         * gdbsupport/agent.c (debug_agent): Change type to bool.
2840         (use_agent): Likewise.
2841         (all_agent_symbols_look_up): Likewise.
2842         (agent_loaded_p): Change return value to bool.
2843         (agent_look_up_symbols): Update.
2844         (agent_capability_check): Change return value to bool.
2845         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2846         (debug_agent): Change type to bool.
2847         (use_agent): Likewise.
2848         (agent_capability_check): Change return value to bool.
2850 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2852         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2853         (build_minimal_symbol_hash_tables): Code to clear the table moved
2854         to clear_minimal_symbol_hash_tables.
2855         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2856         when needed.
2858 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2860         * infcmd.c: Remove includes.
2861         * infrun.c: Remove includes.
2863 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2865         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2866         (grow_vect): Remove declaration.
2867         (ada_type_of_array): Remove declaration.
2868         (ada_update_initial_language): Remove declaration.
2869         (ada_fold_name): Remove declaration.
2870         (ada_fill_in_ada_prototype): Remove declaration.
2871         (user_select_syms): Remove declaration.
2872         (get_selections): Remove declaration.
2873         (ada_tag_type): Remove declaration.
2874         (ada_value_tag): Remove declaration.
2875         (ada_is_others_clause): Remove declaration.
2876         (ada_in_variant): Remove declaration.
2877         (ada_value_struct_elt): Remove declaration.
2878         (ada_attribute_name): Remove declaration.
2879         (ada_system_address_type): Remove declaration.
2880         * ada-lang.c (ada_watch_location_expression): Make static.
2881         (GROW_VECT): Move here from ada-lang.h.
2882         (grow_vect): Make static.
2883         (ada_update_initial_language): Make static.
2884         (ada_fold_name): Make static.
2885         (ada_type_of_array): Make static.
2886         (encoded_ordered_before): Move up.
2887         (sort_choices): Move up.
2888         (print_signatures): Move up.
2889         (ada_print_symbol_signature): Move up.
2890         (get_selections): Move up and make static.
2891         (user_select_syms): Move up and make static.
2892         (ada_value_struct_elt): Move up and make static.
2893         (ada_tag_type): Make static.
2894         (ada_value_tag): Make static.
2895         (ada_is_others_clause): Make static.
2896         (ada_in_variant): Make static.
2897         (ada_attribute_name): Make static.
2899 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2901         * ada-lang.c: Remove includes.
2902         * ada-typeprint.c: Remove includes.
2903         * ada-valprint.c: Remove includes.
2905 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2907         * addrmap.c: Add static assertions of type size, moved from
2908         _initialize_addrmap.
2909         (_initialize_addrmap): Remove.
2911 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2913         * coffread.c (record_minimal_symbol): Update.
2914         (process_coff_symbol): Update.
2915         * dbxread.c (read_dbx_symtab): Update.
2916         * dwarf2read.c (add_partial_symbol): Update.
2917         (fixup_go_packaging): Update.
2918         (load_partial_dies): Update.
2919         (new_symbol): Update.
2920         * elfread.c (record_minimal_symbol): Change signature to use
2921         gdb::string_view instead of name+len.
2922         (elf_symtab_read): Update.
2923         (elf_rel_plt_read): Update.
2924         * mdebugread.c (parse_partial_symbols): Update.
2925         (handle_psymbol_enumerators): Update.
2926         (new_symbol): Update.
2927         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2928         to use gdb::string_view instead of name+len.
2929         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2930         * psympriv.h (add_psymbol_to_list): Likewise.
2931         * psymtab.c (add_psymbol_to_bcache): Likewise.
2932         (add_psymbol_to_list): Likewise.
2933         * stabsread.c (define_symbol): Update.
2934         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2935         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2936         (symbol_set_names): Likewise.
2937         * xcoffread.c (scan_xcoff_symtab): Update.
2939 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2941         * symtab.h (symbol_set_names): Document that copy_name must be
2942         set to true for non-nullterminated strings.
2943         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2944         linkage_name if the entry was not found and we need to demangle.
2946 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2948         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2949         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2950         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2951         * gdbsupport/gdb_binary_search.h: New file.
2953 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2955         * NEWS: Mention new --with-system-gdbinit-dir option.
2956         * config.in: Regenerate.
2957         * configure: Regenerate.
2958         * configure.ac: Add new option --with-system-gdbinit-dir.
2959         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2960         for a ".gdb" suffix.
2961         * main.c (get_init_files): Change system_gdbinit argument to
2962         a vector and return the files in SYSTEM_GDBINIT_DIR in
2963         addition to SYSTEM_GDBINIT.
2964         (captured_main_1): Update.
2965         (print_gdb_help): Update.
2966         * top.c (print_gdb_configuration): Also print the value of
2967         SYSTEM_GDBINIT_DIR.
2969 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2971         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2972         that takes gdb::string_view arguments.
2974 2019-10-26  Tom de Vries  <tdevries@suse.de>
2976         * aarch64-linux-tdep.c: Fix typos in comments.
2977         * aarch64-tdep.c: Same.
2978         * ada-lang.c: Same.
2979         * amd64-nat.c: Same.
2980         * arc-tdep.c: Same.
2981         * arch/aarch64-insn.c: Same.
2982         * block.c: Same.
2983         * breakpoint.h: Same.
2984         * btrace.h: Same.
2985         * c-varobj.c: Same.
2986         * cli/cli-decode.c: Same.
2987         * cli/cli-script.c: Same.
2988         * cli/cli-utils.h: Same.
2989         * coff-pe-read.c: Same.
2990         * coffread.c: Same.
2991         * compile/compile-cplus-symbols.c: Same.
2992         * compile/compile-object-run.c: Same.
2993         * completer.c: Same.
2994         * corelow.c: Same.
2995         * cp-support.c: Same.
2996         * demangle.c: Same.
2997         * dwarf-index-write.c: Same.
2998         * dwarf2-frame.c: Same.
2999         * dwarf2-frame.h: Same.
3000         * eval.c: Same.
3001         * frame-base.h: Same.
3002         * frame.h: Same.
3003         * gdbcmd.h: Same.
3004         * gdbtypes.h: Same.
3005         * gnu-nat.c: Same.
3006         * guile/scm-objfile.c: Same.
3007         * i386-tdep.c: Same.
3008         * i386-tdep.h: Same.
3009         * infcall.c: Same.
3010         * infcall.h: Same.
3011         * linux-nat.c: Same.
3012         * m68k-tdep.c: Same.
3013         * macroexp.c: Same.
3014         * memattr.c: Same.
3015         * mi/mi-cmd-disas.c: Same.
3016         * mi/mi-getopt.h: Same.
3017         * mi/mi-main.c: Same.
3018         * minsyms.c: Same.
3019         * nat/aarch64-sve-linux-sigcontext.h: Same.
3020         * objfiles.h: Same.
3021         * ppc-linux-nat.c: Same.
3022         * ppc-linux-tdep.c: Same.
3023         * ppc-tdep.h: Same.
3024         * progspace.h: Same.
3025         * prologue-value.h: Same.
3026         * python/py-evtregistry.c: Same.
3027         * python/py-instruction.h: Same.
3028         * record-btrace.c: Same.
3029         * record-full.c: Same.
3030         * remote.c: Same.
3031         * rs6000-tdep.c: Same.
3032         * ser-tcp.c: Same.
3033         * sol-thread.c: Same.
3034         * sparc-sol2-tdep.c: Same.
3035         * sparc64-tdep.c: Same.
3036         * stabsread.c: Same.
3037         * symfile.c: Same.
3038         * symtab.h: Same.
3039         * target.c: Same.
3040         * tracepoint.c: Same.
3041         * tui/tui-data.h: Same.
3042         * tui/tui-io.c: Same.
3043         * tui/tui-win.c: Same.
3044         * tui/tui.c: Same.
3045         * unittests/rsp-low-selftests.c: Same.
3046         * user-regs.h: Same.
3047         * utils.c: Same.
3048         * utils.h: Same.
3049         * valarith.c: Same.
3050         * valops.c: Same.
3051         * valprint.c: Same.
3052         * valprint.h: Same.
3053         * value.c: Same.
3054         * value.h: Same.
3055         * varobj.c: Same.
3056         * x86-nat.h: Same.
3057         * xtensa-tdep.c: Same.
3059 2019-10-25  Ali Tamur <tamur@google.com>
3061         * charset.c (find_charset_names): Reflect API change.
3063 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
3065         * symtab.c (struct demangled_name_entry): Change demangled name
3066         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
3067         part of the struct anymore.
3068         (symbol_set_names): No longer obstack allocate + copy the demangled
3069         name, just store the allocated name from bfd.
3071 2019-10-25  Tom Tromey  <tromey@adacore.com>
3073         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
3074         (bsearch_cie_cmp, add_cie): Remove.
3075         (find_cie): Reimplement.
3076         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
3077         (dwarf2_build_frame_info): Update.
3079 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
3081         PR gdb/25126
3082         * symfile.c (reread_symbols): Call forget_cached_source_info to
3083         clear the stale source cache.
3085 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
3087         * configure: Regenerate.
3088         * configure.ac: Remove code that sets python_has_threads.
3090 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
3092         * config.in: Regenerate.
3093         * configure: Regenerate.
3094         * configure.ac: Remove the code that uses sed to get the python
3095         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
3097 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3099         * python/py-progspace.c (pspy_block_for_pc): Return None for all
3100         error paths.
3102 2019-10-23  Tom Tromey  <tom@tromey.com>
3104         * arc-tdep.c: Remove ".." from include.
3105         * frv-tdep.c: Remove ".." from include.
3106         * lm32-tdep.c: Remove ".." from include.
3107         * microblaze-tdep.c: Remove ".." from include.
3108         * or1k-tdep.h: Remove ".." from include.
3109         * s12z-tdep.c: Remove ".." from include.
3110         * Makefile.in (OPCODES_CFLAGS): Add comment.
3111         (TOP_CFLAGS): New variable.
3112         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3114 2019-10-23  Tom Tromey  <tom@tromey.com>
3116         * Makefile.in (READLINE_DIR): Update.
3118 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3120         * infcall.c (call_function_by_hand_dummy): Fix the function
3121         comment.  And extract out a code section into...
3122         (reserve_stack_space): ...this new function.
3124 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3126         * infcall.c (value_arg_coerce): Remove an unused parameter.
3127         (call_function_by_hand_dummy): Update the call to
3128         'value_arg_coerce'.
3130 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3132         * infcall.c (call_function_by_hand_dummy): Refactor.
3134 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3136         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3138 2019-10-23  Tom Tromey  <tom@tromey.com>
3140         * configure: Rebuild.
3141         * configure.ac: Don't check for sigprocmask.
3142         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3144 2019-10-23  Tom Tromey  <tom@tromey.com>
3146         * configure: Rebuild.
3147         * acinclude.m4: Use m4_include, not sinclude.
3149 2019-10-23  Tom de Vries  <tdevries@suse.de>
3151         PR breakpoints/24687
3152         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3154 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3156         * symtab.c (struct demangled_name_entry) <language>: Change from
3157         bitfield to regular variable.
3159 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3161         * symtab.c (struct demangled_name_entry): Add a constructor.
3162         (free_demangled_name_entry): New function to call the destructor
3163         for demangled_name_entry.
3164         (create_demangled_names_hash): Pass free_demangled_name_entry to
3165         htab_create_alloc.
3166         (symbol_set_names): Call placement new for demangled_name_entry.
3167         * utils.c: No longer include xxhash.h here, now that fast_hash
3168         is inlined in the header.
3169         * utils.h: Instead, include it here.
3171 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3173         * Makefile.in: Link with libxxhash.
3174         * config.in: Regenerate.
3175         * configure: Regenerate.
3176         * configure.ac: Search for libxxhash.
3177         * utils.c (fast_hash): Use xxhash if present.
3179 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3181         * utils.h (fast_hash): New function.
3182         * symtab.c (hash_demangled_name_entry): Call new function
3183         fast_hash.
3185 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3187         * symtab.c (struct demangled_name_entry): Change type of mangled
3188         to gdb::string_view. Also adds a constructor that takes the
3189         mangled name.
3190         (hash_demangled_name_entry): Update.
3191         (eq_demangled_name_entry): Update.
3192         (free_demangled_name_entry): New function to call the destructor
3193         now that this is not a POD anymore.
3194         (create_demangled_names_hash): Pass free_demangled_name_entry to
3195         htab_create_alloc.
3196         (symbol_set_names): Update.
3198 2019-10-21  Ali Tamur  <tamu@google.com>
3200         * dwarf2read.c (dir_index): Change type.
3201         (file_name_index): Likewise.
3202         (line_header::include_dir_at): Change comment and implementation on
3203         whether it is DWARF 5.
3204         (line_header::is_valid_file_index): New function.
3205         (line_header::file_name_at): Change comment and implementation on
3206         whether it is DWARF 5.
3207         (line_header::file_names): Change to private field renamed as
3208         m_file_names and introduce a new accessor method.
3209         (line_header::file_names_size): New method.
3210         (line_header::include_dirs): Change to private field and rename as
3211         m_include_dirs.
3212         (dw2_get_file_names_reader): Define local var at a smaller scope and
3213         reflect API change.
3214         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3215         (process_structure_scope): Likewise.
3216         (line_header::add_include_dir): Change message and reflect renaming.
3217         (line_header::add_file_name): Likewise.
3218         (read_formatted_entries): Handle DW_FORM_data16.
3219         (dwarf_decode_line_header): Fix line header length calculation.
3220         (psymtab_include_file_name): Change comment and API.
3221         (lnp_state_machine::m_file): Update comment and reflect type change.
3222         (lnp_state_machine::record_line): Reflect type change.
3223         (dwarf_decode_lines): Reflect API change.
3224         (file_file_name): Likewise.
3225         (file_full_name): Likewise.
3227 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3229         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3231 2019-10-21  Tom Tromey  <tom@tromey.com>
3233         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3235 2019-10-21  Tom Tromey  <tom@tromey.com>
3237         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3238         NM_H.   Use AC_CONFIG_LINKS.
3239         * configure: Rebuild.
3240         * Makefile.in (NM_H): New variable.
3241         (generated_files): Add NM_H.  Remove gcore.
3242         (nm.h, stamp-nmh): New targets.
3244 2019-10-20  Tom Tromey  <tom@tromey.com>
3246         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3247         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3248         obsolete comment.
3249         (put_objfile_before): Now static.
3251 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3253         * gdbsupport/common-utils.h (startswith): Change return type to
3254         bool.
3256 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3258         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3259         * breakpoint.c (bp_locations_compare): Rename to...
3260         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3261         (update_global_location_list): Use std::sort instead of qsort.
3262         * buildsym.c (compare_line_numbers): Rename to...
3263         (lte_is_less_than): ...this, and change to std::sort semantics.
3264         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3265         instead of qsort.
3266         * disasm.c (compare_lines): Rename to...
3267         (line_is_less_than): ...this, and change to std::sort semantics.
3268         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3269         of qsort.
3270         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3271         (fde_is_less_than): ...this, and change to std::sort semantics.
3272         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3273         * mdebugread.c (compare_blocks):
3274         (block_is_less_than): ...this, and change to std::sort semantics.
3275         (sort_blocks): Call std::sort instead of qsort.
3276         * objfiles.c (qsort_cmp): Rename to...
3277         (sort_cmp): ...this, and change to std::sort semantics.
3278         (update_section_map): Call std::sort instead of qsort.
3279         * remote.c (compare_pnums): Remove.
3280         (map_regcache_remote_table): Call std::sort instead of qsort.
3281         * utils.c (compare_positive_ints): Remove.
3282         * utils.h (compare_positive_ints): Remove.
3283         * xcoffread.c (compare_lte): Remove.
3284         (arrange_linetable): Call std::sort instead of qsort.
3286 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3288         * symfile.c (init_entry_point_info): Fix typo.
3289         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3291 2019-10-18  Tom de Vries  <tdevries@suse.de>
3293         * aarch64-tdep.c: Fix typos in comments.
3294         * ada-lang.c: Same.
3295         * ada-tasks.c: Same.
3296         * alpha-tdep.c: Same.
3297         * alpha-tdep.h: Same.
3298         * amd64-nat.c: Same.
3299         * amd64-windows-tdep.c: Same.
3300         * arc-tdep.c: Same.
3301         * arc-tdep.h: Same.
3302         * arch-utils.c: Same.
3303         * arm-nbsd-tdep.c: Same.
3304         * arm-tdep.c: Same.
3305         * ax-gdb.c: Same.
3306         * blockframe.c: Same.
3307         * btrace.c: Same.
3308         * c-varobj.c: Same.
3309         * coff-pe-read.c: Same.
3310         * coffread.c: Same.
3311         * cris-tdep.c: Same.
3312         * darwin-nat.c: Same.
3313         * dbxread.c: Same.
3314         * dcache.c: Same.
3315         * disasm.c: Same.
3316         * dtrace-probe.c: Same.
3317         * dwarf-index-write.c: Same.
3318         * dwarf2-frame-tailcall.c: Same.
3319         * dwarf2-frame.c: Same.
3320         * dwarf2read.c: Same.
3321         * eval.c: Same.
3322         * exceptions.c: Same.
3323         * fbsd-tdep.c: Same.
3324         * findvar.c: Same.
3325         * frame.c: Same.
3326         * frv-tdep.c: Same.
3327         * gnu-v3-abi.c: Same.
3328         * go32-nat.c: Same.
3329         * h8300-tdep.c: Same.
3330         * hppa-tdep.c: Same.
3331         * i386-linux-tdep.c: Same.
3332         * i386-tdep.c: Same.
3333         * ia64-libunwind-tdep.c: Same.
3334         * ia64-tdep.c: Same.
3335         * infcmd.c: Same.
3336         * infrun.c: Same.
3337         * linespec.c: Same.
3338         * linux-nat.c: Same.
3339         * linux-thread-db.c: Same.
3340         * machoread.c: Same.
3341         * mdebugread.c: Same.
3342         * mep-tdep.c: Same.
3343         * mn10300-tdep.c: Same.
3344         * namespace.c: Same.
3345         * objfiles.c: Same.
3346         * opencl-lang.c: Same.
3347         * or1k-tdep.c: Same.
3348         * osabi.c: Same.
3349         * ppc-linux-nat.c: Same.
3350         * ppc-linux-tdep.c: Same.
3351         * ppc-sysv-tdep.c: Same.
3352         * printcmd.c: Same.
3353         * procfs.c: Same.
3354         * record-btrace.c: Same.
3355         * record-full.c: Same.
3356         * remote-fileio.c: Same.
3357         * remote.c: Same.
3358         * rs6000-tdep.c: Same.
3359         * s12z-tdep.c: Same.
3360         * score-tdep.c: Same.
3361         * ser-base.c: Same.
3362         * ser-go32.c: Same.
3363         * skip.c: Same.
3364         * sol-thread.c: Same.
3365         * solib-svr4.c: Same.
3366         * solib.c: Same.
3367         * source.c: Same.
3368         * sparc-nat.c: Same.
3369         * sparc-sol2-tdep.c: Same.
3370         * sparc-tdep.c: Same.
3371         * sparc64-tdep.c: Same.
3372         * stabsread.c: Same.
3373         * stack.c: Same.
3374         * symfile.c: Same.
3375         * symtab.c: Same.
3376         * target-descriptions.c: Same.
3377         * target-float.c: Same.
3378         * thread.c: Same.
3379         * utils.c: Same.
3380         * valops.c: Same.
3381         * valprint.c: Same.
3382         * value.c: Same.
3383         * varobj.c: Same.
3384         * windows-nat.c: Same.
3385         * xcoffread.c: Same.
3386         * xstormy16-tdep.c: Same.
3387         * xtensa-tdep.c: Same.
3389 2019-10-17  Tom Tromey  <tromey@adacore.com>
3391         * configure: Rebuild.
3392         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3393         in AC_CONFIG_FILES invocation.
3394         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3395         new-style config.status invocation.
3397 2019-10-17  Tom de Vries  <tdevries@suse.de>
3399         * arm-nbsd-nat.c: Fix typos in comments.
3400         * arm-tdep.c: Same.
3401         * darwin-nat-info.c: Same.
3402         * dwarf2read.c: Same.
3403         * elfread.c: Same.
3404         * event-top.c: Same.
3405         * findvar.c: Same.
3406         * gdbtypes.c: Same.
3407         * hppa-tdep.c: Same.
3408         * i386-tdep.c: Same.
3409         * jit.c: Same.
3410         * main.c: Same.
3411         * mdebugread.c: Same.
3412         * moxie-tdep.c: Same.
3413         * nto-procfs.c: Same.
3414         * osabi.c: Same.
3415         * ppc-linux-tdep.c: Same.
3416         * remote.c: Same.
3417         * riscv-tdep.c: Same.
3418         * s390-tdep.c: Same.
3419         * sh-tdep.c: Same.
3420         * sparc-linux-tdep.c: Same.
3421         * sparc-nat.c: Same.
3422         * stack.c: Same.
3423         * target-descriptions.c: Same.
3424         * top.c: Same.
3425         * varobj.c: Same.
3427 2019-10-16  Tom Tromey  <tom@tromey.com>
3429         * objfiles.h (struct objfile) <original_name>: Now const.
3431 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3433         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3434         pass on to sigsetjmp's second argument.
3435         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3437 2019-10-16  Keith Seitz  <keiths@redhat.com>
3439         PR gdb/23567
3440         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3441         sections whose size is greater than the file size.
3443 2019-10-16  Jim Wilson  <jimw@sifive.com>
3445         * riscv-tdep.c (riscv_gcc_target_options): New.
3446         (riscv_gnu_triplet_regexp): New.
3447         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3448         set_gdbarch_gnu_triplet_regexp.
3450 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3452         * Makefile.in: Add xml-builtin.h.
3453         * features/feature_to_c.sh: Add an include for xml-builtin.h
3454         to ensure that the compiler checks that the types match.
3455         * xml-builtin.h: New file.
3456         * xml-support.c (fetch_xml_builtin): Add missing const.
3457         * xml-support.h: Remove declaration of xml_builtins.
3459 2019-10-16  Tom de Vries  <tdevries@suse.de>
3461         PR tdep/25096
3462         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3463         (amd64_classify_aggregate): ... here.
3464         (amd64_classify_aggregate_field): Handled fiels of nested structs
3465         recursively.
3467 2019-10-16  Tom de Vries  <tdevries@suse.de>
3469         PR tdep/24104
3470         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3471         that handles 'theclass'.
3473 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3475         * linespec.c (decode_digits_ordinary): Update comment.
3476         * make-target-delegates: No longer need to handle VEC case.
3477         * memrange.c (normalize_mem_ranges): Update comment.
3478         * namespace.c (add_using_directive): Update comment.
3479         * objc-lang.c (uniquify_strings): Update comment.
3480         * ppc-linux-nat.c (struct thread_points): Update comment.
3481         * probe.h (find_probes_in_objfile): Update comment.
3482         * target.h (enum flash_preserve_mode): Update comment.
3483         * varobj.c (varobj_restrict_range): Update comment.
3484         * varobj.h (varobj_list_children): Update comment.
3486 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3488         * Makefile.in: Remove references to vec.h and vec.c.
3489         * aarch64-tdep.c: No longer include vec.h.
3490         * ada-lang.c: Likewise.
3491         * ada-lang.h: Likewise.
3492         * arm-tdep.c: Likewise.
3493         * ax.h: Likewise.
3494         * breakpoint.h: Likewise.
3495         * charset.c: Likewise.
3496         * cp-support.h: Likewise.
3497         * dtrace-probe.c: Likewise.
3498         * dwarf2read.c: Likewise.
3499         * extension.h: Likewise.
3500         * gdb_bfd.c: Likewise.
3501         * gdbsupport/gdb_vecs.h: Likewise.
3502         * gdbsupport/vec.c: Remove.
3503         * gdbsupport/vec.h: Remove.
3504         * gdbthread.h: Likewise.
3505         * guile/scm-type.c: Likewise.
3506         * inline-frame.c: Likewise.
3507         * machoread.c: Likewise.
3508         * memattr.c: Likewise.
3509         * memrange.h: Likewise.
3510         * namespace.h: Likewise.
3511         * nat/linux-btrace.h: Likewise.
3512         * osdata.c: Likewise.
3513         * parser-defs.h: Likewise.
3514         * progspace.h: Likewise.
3515         * python/py-type.c: Likewise.
3516         * record-btrace.c: Likewise.
3517         * rust-exp.y: Likewise.
3518         * solib-target.c: Likewise.
3519         * stap-probe.c: Likewise.
3520         * target-descriptions.c: Likewise.
3521         * target-memory.c: Likewise.
3522         * target.h: Likewise.
3523         * varobj.c: Likewise.
3524         * varobj.h: Likewise.
3525         * xml-support.h: Likewise.
3527 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3529         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3530         Update for new std::vector based implementation.
3531         (process_psymtab_comp_unit_reader): Likewise.
3532         (scan_partial_symbols): Likewise.
3533         (recursively_compute_inclusions): Likewise.
3534         (compute_compunit_symtab_includes): Likewise.
3535         (process_imported_unit_die): Likewise.
3536         (queue_and_load_dwo_tu): Likewise.
3537         (follow_die_sig_1): Likewise.
3538         * dwarf2read.h: Remove DEF_VEC_P.
3539         (typedef dwarf2_per_cu_ptr): Remove.
3540         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3541         function.
3542         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3543         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3544         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3545         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3546         std::vector.
3548 2019-10-15  Tom Tromey  <tromey@adacore.com>
3550         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3551         TID.
3553 2019-10-15  Tom Tromey  <tromey@adacore.com>
3555         * windows-nat.c (windows_nat_target::fetch_registers)
3556         (windows_nat_target::store_registers): Rename "pid" to "tid".
3558 2019-10-15  Tom Tromey  <tromey@adacore.com>
3560         * gdbarch.h, gdbarch.c: Rebuild.
3561         * gdbarch.sh (gcc_target_options): Change return type to
3562         std::string.
3563         * compile/compile.c (get_args): Update.
3564         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3565         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3566         std::string.
3567         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3568         std::string.
3569         * arch-utils.c (default_gcc_target_options): Return std::string.
3570         * arch-utils.h (default_gcc_target_options): Return std::string.
3571         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3573 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3575         * breakpoint.c (breakpoint_chain): Make static.
3576         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3577         of accessing breakpoint_chain.
3579 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3581         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3582         to a gdb::function_view and return value to bool.
3583         * breakpoint.h (iterate_over_breakpoints): Likewise.
3584         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3585         (pop_dummy_frame): Update.
3586         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3587         (gdbscm_breakpoints): Update.
3588         * python/py-breakpoint.c (build_bp_list): Update.
3589         (gdbpy_breakpoints): Update.
3590         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3591         Update.
3592         (bpfinishpy_handle_stop): Update.
3593         (bpfinishpy_handle_exit): Update.
3594         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3595         (svr4_update_solib_event_breakpoints): Update.
3597 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3599         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3600         when unwrapping single-field structs.
3602 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3604         * dwarf2read.c: Remove includes.
3606 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3608         * ui-out.c (ui_out::call_do_message): Silence
3609         -Wformat-nonliteral warning.
3611 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3613         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3614         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3615         include: readline/tilde.h.
3617 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3619         * remote.c (remote_target::get_trace_status): Remove declaration of
3620         trace_regblock_size.
3622 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3624         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3625         (show_user): Remove declaration of cmdlist.
3626         * cli/cli-cmds.h (max_user_call_depth): Declare.
3627         * cli/cli-script.c (execute_user_command): Remove declaration
3628         of max_user_call_depth.
3630 2019-10-11  Jim Wilson  <jimw@sifive.com>
3632         * gdbsupport/print-utils.h (pulongest): Fix comment.
3633         (plongest): Likewise.
3634         (phex): Add missing comment, mention leading zeros.
3635         (phex_nz): Add mention of no leading zeros to comment.
3637         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3638         plongest instead of unsigned long long cast.
3640 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3642         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3643         for external_editor_command and gdbtk_test.
3645 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3647         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3648         * varobj.c (varobjdebug): Move comment to...
3649         * varobj.h (varobjdebug): ...here, and declare.
3651 2019-10-09  Tom Tromey  <tom@tromey.com>
3653         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3654         erase_data_content.
3656 2019-10-09  Tom Tromey  <tom@tromey.com>
3658         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3659         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3660         * tui/tui-command.c (tui_cmd_window::resize)
3661         (tui_refresh_cmd_win): Update.
3662         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3663         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3664         * tui/tui-data.c (~tui_gen_win_info): Remove.
3665         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3666         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3667         (tui_redisplay_readline, tui_mld_flush)
3668         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3669         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3670         (tui_data_window::erase_data_content)
3671         (tui_data_item_window::rerender)
3672         (tui_data_item_window::refresh_window): Update.
3673         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3674         (box_win, tui_gen_win_info::make_window)
3675         (tui_gen_win_info::make_visible): Update.
3676         (tui_delete_win): Remove.
3677         * tui/tui-winsource.c
3678         (tui_source_window_base::do_erase_source_content): Update.
3679         (tui_show_source_line, tui_source_window_base::update_tab_width)
3680         (tui_source_window_base::update_exec_info): Update.
3681         * tui/tui-data.h (struct curses_deleter): New.
3682         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3683         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3685 2019-10-09  Tom Tromey  <tom@tromey.com>
3687         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3689 2019-10-09  Tom Tromey  <tom@tromey.com>
3691         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3692         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3694 2019-10-09  Tom Tromey  <tom@tromey.com>
3696         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3697         window height directly.
3698         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3699         declare.
3700         * tui/tui-layout.c (tui_default_win_height): Remove.
3701         (tui_default_win_viewport_height): Remove.
3703 2019-10-09  Tom Tromey  <tom@tromey.com>
3705         * tui/tui.h: Remove comments.
3707 2019-10-09  Tom de Vries  <tdevries@suse.de>
3709         * python/lib/gdb/printer/bound_registers.py: Use
3710         '^builtin_type_bound128' as regexp argument for
3711         add_builtin_pretty_printer.
3713 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3715         * guile/guile.c (guile_extension_script_ops): Remove forward
3716         declaration and mark as static.
3717         (guile_script_ops): Likewise.
3718         (extension_language_guile): Move further down in the file so
3719         it can reference the definitions for guile_{extension_,}script_ops.
3721 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3723         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3724         except SORTL, DFLTCC, and KDSA.
3726 2019-10-08  Tom Tromey  <tromey@adacore.com>
3728         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3729         (struct safe_symbol_file_add_args): Remove.
3731 2019-10-08  Tom Tromey  <tromey@adacore.com>
3733         * windows-nat.c: Don't include buildsym-legacy.h.
3735 2019-10-08  Tom Tromey  <tromey@adacore.com>
3737         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3739 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3741         * gdbtypes.c (overload_debug): Move comment to header.
3742         * gdbtypes.h (overload_debug): Declare.
3743         * valops.c: Remove declaration of overload_debug, instead
3744         include gdbtypes.h.
3746 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3748         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3749         through _().
3750         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3751         move comment...
3752         * language.h (lang_frame_mismatch_warn): ... here. Also add
3753         declaration.
3754         * top.c (lang_frame_mismatch_warn): Remove declaration.
3755         (check_frame_language_change): Pass lang_frame_mismatch_warn
3756         through _().
3758 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3760         * c-lang.h (vtbl_ptr_name): Declare.
3761         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3762         it from the header.
3763         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3765 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3767         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3768         gdb_static_assert.
3770 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3772         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3773         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3774         * ctfread.c: New file.
3775         * ctfread.h: New file.
3776         * elfread.c: Include ctfread.h.
3777         (struct elfinfo text_p): New member ctfsect.
3778         (elf_locate_sections): Mark CTF section.
3779         (elf_symfile_read): Call elfctf_build_psymtabs.
3780         * Makefile.in (LIBCTF): Add.
3781         (CLIBS): Use it.
3782         (CDEPS): Likewise.
3783         (DIST): Add ctfread.c.
3785 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3787         * ctfread.c (struct nextfield): Renamed to ...
3788         (struct ctf_nextfield): ... this.
3789         (struct field_info): Renamed to ...
3790         (strut ctf_field_info): ... this.
3791         (attach_fields_to_type): Update for renamed structures.
3792         (ctf_add_member_cb): Likewise.
3793         (ctf_add_enum_member_cb): Likewise.
3794         (process_struct_members): Likewise.
3795         (process_enum_type): Likewise.
3797 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3799         * tracectf.h: Rename, was ctf.h.
3800         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3801         * tracefile.c: Likewise.
3802         * tracepoint.c: Remove unused include ctf.h.
3803         * mi/mi-main.c: Likewise.
3804         * Makefile.in Replace ctf.c with tracectf.c.
3806 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3808         * version.in: Change version number to "9.0.50.DATE-git".
3810 2019-10-03  Tom Tromey  <tom@tromey.com>
3812         PR rust/24976:
3813         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3815 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3817         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3818         cp_search_name_hash.
3819         * NEWS: Add entry about nested function support.
3821 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3822             Andrew Burgess  <andrew.burgess@embecosm.com>
3824         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3825         for nested static variables when searchin VAR_DOMAIN.
3826         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3827         global scope, update comment.
3828         (add_partial_subprogram): Call add_partial_subprogram recursively
3829         for nested subroutines when processinng Fortran.
3830         (load_partial_dies): Process the child entities of a subprogram
3831         when processing Fortran.
3832         (partial_die_parent_scope): Handle building scope
3833         for Fortran nested functions.
3834         (process_die): Record that nested functions have a scope.
3835         (new_symbol): Always record Fortran subprograms on the global
3836         symbol list.
3837         (determine_prefix): How to build the prefix for Fortran
3838         subprograms.
3840 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3842         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3843         have just sent the thread a SIGSTOP and are waiting for it to
3844         arrive.
3846 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3848         * btrace.c (btrace_add_pc): Remove whitespace before the template
3849         parameter in 'std::vector <...>'.
3850         (parse_xml_btrace_block): Likewise.
3851         (btrace_maint_decode_pt): Likewise.
3852         (btrace_maint_update_packets): Likewise.
3853         (btrace_maint_print_packets): Likewise.
3854         * btrace.h (struct btrace_maint_info): Likewise.
3855         * dwarf2read.c (struct type_unit_group): Likewise.
3856         (build_type_psymtabs_reader): Likewise.
3857         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3858         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3859         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3861 2019-10-03  Tom de Vries  <tdevries@suse.de>
3863         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3864         the first line of the help text for set/show style metadata.
3866 2019-10-02  Tom Tromey  <tromey@adacore.com>
3868         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3869         * gdbsupport/common-inferior.c: New file.
3870         * infcmd.c (startup_with_shell): Don't define.
3871         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3872         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3873         * inferior.h (startup_with_shell): Don't declare.
3875 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3877         * gdbsupport/gdb_assert.h: Include errors.h.
3878         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3880 2019-10-02  Tom Tromey  <tromey@adacore.com>
3882         * NEWS: Add $_ada_exception entry.
3883         * ada-lang.c (struct ada_catchpoint): Add constructor.
3884         <m_kind>: New member.
3885         (allocate_location_exception, re_set_exception): Remove
3886         "ex" parameter.
3887         (should_stop_exception): Compute $_ada_exception.
3888         (check_status_exception, print_it_exception)
3889         (print_one_exception, print_mention_exception): Remove
3890         "ex" parameter.
3891         (allocate_location_catch_exception, re_set_catch_exception)
3892         (check_status_exception, print_it_catch_exception)
3893         (print_one_catch_exception, print_mention_catch_exception)
3894         (print_recreate_catch_exception)
3895         (allocate_location_catch_exception_unhandled)
3896         (re_set_catch_exception_unhandled)
3897         (check_status_exception, print_it_catch_exception_unhandled)
3898         (print_one_catch_exception_unhandled)
3899         (print_mention_catch_exception_unhandled)
3900         (print_recreate_catch_exception_unhandled)
3901         (allocate_location_catch_assert, re_set_catch_assert)
3902         (check_status_assert, print_it_catch_assert)
3903         (print_one_catch_assert, print_mention_catch_assert)
3904         (print_recreate_catch_assert)
3905         (allocate_location_catch_handlers, re_set_catch_handlers)
3906         (check_status_handlers, print_it_catch_handlers)
3907         (print_one_catch_handlers, print_mention_catch_handlers)
3908         (print_recreate_catch_handlers): Remove.
3909         (create_ada_exception_catchpoint): Update.
3910         (initialize_ada_catchpoint_ops): Update.
3912 2019-10-02  Tom Tromey  <tromey@adacore.com>
3914         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3915         (create_excep_cond_exprs): Simplify exception string computation.
3916         (ada_exception_catchpoint_cond_string): Likewise.
3918 2019-10-02  Tom Tromey  <tromey@adacore.com>
3920         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3921         * ada-lang.c (lesseq_defined_than): Handle
3922         LOC_STATIC.
3923         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3924         parameter.
3925         (dwarf2_has_info): Likewise.
3926         (new_symbol): Set maybe_copied on symbol when
3927         appropriate.
3928         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3929         parameter.
3930         <can_copy>: New member.
3931         * elfread.c (record_minimal_symbol): Set maybe_copied
3932         on symbol when appropriate.
3933         (elf_symfile_read): Update call to dwarf2_has_info.
3934         * minsyms.c (lookup_minimal_symbol_linkage): New
3935         function.
3936         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3937         * symtab.c (get_symbol_address, get_msymbol_address):
3938         New functions.
3939         * symtab.h (get_symbol_address, get_msymbol_address):
3940         Declare.
3941         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3942         maybe_copied.
3943         (struct symbol, struct minimal_symbol) <maybe_copied>:
3944         New member.
3946 2019-10-02  Tom Tromey  <tromey@adacore.com>
3948         * source.c (struct current_source_location): New.
3949         (current_source_key): New global.
3950         (current_source_symtab, current_source_line)
3951         (current_source_pspace): Remove.
3952         (get_source_location): New function.
3953         (get_current_source_symtab_and_line)
3954         (set_default_source_symtab_and_line)
3955         (set_current_source_symtab_and_line)
3956         (clear_current_source_symtab_and_line, select_source_symtab)
3957         (info_source_command, print_source_lines_base)
3958         (info_line_command, search_command_helper, _initialize_source):
3959         Update.
3961 2019-10-02  Tom Tromey  <tromey@adacore.com>
3963         * source.c (select_source_symtab): Don't call
3964         decode_line_with_current_source.
3966 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3968         * symtab.c (lookup_global_symbol): Search global block.
3970 2019-10-02  Tom Tromey  <tromey@adacore.com>
3972         * coffread.c (process_coff_symbol): Update.
3973         * dwarf2read.c (var_decode_location, new_symbol): Update.
3974         * mdebugread.c (parse_symbol): Update.
3975         * objfiles.c (relocate_one_symbol): Update.
3976         * stabsread.c (define_symbol, fix_common_block)
3977         (scan_file_globals): Update.
3978         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3979         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3980         * xcoffread.c (process_xcoff_symbol): Update.
3982 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3984         * MAINTAINERS: Update my email address.
3986 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3988         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3989         std::vector.
3990         (build_type_psymtabs_reader): Update for std::vector.
3991         (build_type_psymtab_dependencies): Likewise.
3992         * dwarf2read.h: Remove use of DEF_VEC_P.
3993         (typedef sig_type_ptr): Delete.
3995 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3997         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3998         to std::vector.
3999         (btrace_maint_decode_pt): Likewise, and move allocation of the
4000         vector outside of the loop.
4001         (btrace_maint_update_packets): Update to handle change from VEC to
4002         std::vector.
4003         (btrace_maint_print_packets): Likewise.
4004         (maint_info_btrace_cmd): Likewise.
4005         * btrace.h: Remove use of DEF_VEC_O.
4006         (typedef btrace_pt_packet_s): Delete.
4007         (struct btrace_maint_info) <packets>: Change fromm VEC to
4008         std::vector.
4009         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
4011 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4013         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
4014         make accesses into the vector constant references.
4015         (btrace_add_pc): Update for std::vector.
4016         (btrace_stitch_bts): Likewise.
4017         (parse_xml_btrace_block): Likewise.
4018         (btrace_maint_update_packets): Likewise.
4019         (btrace_maint_print_packets): Likewise.
4020         (maint_info_btrace_cmd): Likewise.
4021         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
4022         std::vector.
4023         (btrace_data::empty): Likewise.
4024         (btrace_data_append): Likewise.
4025         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
4026         (typedef btrace_block_s): Delete.
4027         (struct btrace_block): Add constructor.
4028         (struct btrace_data_bts) <blocks>: Change to std::vector.
4029         * nat/linux-btrace.c (perf_event_read_bts): Update for
4030         std::vector.
4031         (linux_read_bts): Likewise.
4033 2019-10-01  Tom Tromey  <tom@tromey.com>
4035         * cli/cli-logging.c (show_logging_filename): Use styled_string.
4037 2019-10-01  Tom Tromey  <tom@tromey.com>
4039         * stack.c (print_frame, info_frame_command_core): Use
4040         styled_string.
4041         * linux-thread-db.c (try_thread_db_load_1)
4042         (try_thread_db_load_from_pdir_1): Use styled_string.
4043         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
4044         (auto_load_section_scripts, info_auto_load_local_gdbinit)
4045         (maybe_print_unsupported_script_warning)
4046         (maybe_print_script_not_found_warning): Use styled_string.
4047         * ada-lang.c (user_select_syms): Use styled_string.
4049 2019-10-01  Tom Tromey  <tom@tromey.com>
4051         * p-lang.c (pascal_printstr): Use metadata style.
4052         * value.c (show_convenience): Use metadata style.
4053         * valprint.c (valprint_check_validity, val_print_optimized_out)
4054         (val_print_not_saved, val_print_unavailable)
4055         (val_print_invalid_address, generic_val_print, val_print)
4056         (value_check_printable, val_print_array_elements): Use metadata
4057         style.
4058         * ui-out.h (class ui_out) <field_fmt>: New overload.
4059         <do_field_fmt>: Add style parameter.
4060         * ui-out.c (ui_out::field_fmt): New overload.
4061         * typeprint.c (type_print_unknown_return_type)
4062         (val_print_not_allocated, val_print_not_associated): Use metadata
4063         style.
4064         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
4065         parameter.
4066         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
4067         * tracepoint.c (tvariables_info_1): Use metadata style.
4068         * stack.c (print_frame_arg, print_frame_info, print_frame)
4069         (info_frame_command_core): Use metadata style.
4070         * skip.c (info_skip_command): Use metadata style.
4071         * rust-lang.c (rust_print_enum): Use metadata style.
4072         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4073         metadata style.
4074         * python/py-framefilter.c (py_print_single_arg): Use metadata
4075         style.
4076         * printcmd.c (do_one_display, print_variable_and_value): Use
4077         metadata style.
4078         * p-valprint.c (pascal_val_print)
4079         (pascal_object_print_value_fields): Use metadata style.
4080         * p-typeprint.c (pascal_type_print_base): Use metadata style.
4081         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
4082         parameter.
4083         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
4084         * m2-valprint.c (m2_print_long_set): Use metadata style.
4085         * m2-typeprint.c (m2_print_type): Use metadata style.
4086         * infcmd.c (print_return_value_1): Use metadata style.
4087         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
4088         * f-valprint.c (info_common_command_for_block): Use metadata
4089         style.
4090         * f-typeprint.c (f_type_print_base): Use metadata style.
4091         * expprint.c (print_subexp_standard): Use metadata style.
4092         * cp-valprint.c (cp_print_value_fields): Use metadata style.
4093         * cli/cli-style.h (class cli_style_option): Add constructor.
4094         (metadata_style): Declare.
4095         * cli/cli-style.c (metadata_style): New global.
4096         (_initialize_cli_style): Register metadata style.
4097         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
4098         parameter.
4099         * cli-out.c (cli_ui_out::do_field_fmt): Update.
4100         * c-typeprint.c (c_type_print_base_struct_union)
4101         (c_type_print_base_1): Use metadata style.
4102         * breakpoint.c (watchpoint_value_print)
4103         (print_one_breakpoint_location): Use metadata style.
4104         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4105         style.
4106         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4107         style.
4108         * ada-valprint.c (val_print_packed_array_elements, printstr)
4109         (print_field_values, ada_val_print_ref, ada_val_print): Use
4110         metadata style.
4111         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4112         style.
4113         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4114         style.
4115         * ada-lang.c (user_select_syms): Use metadata style.
4117 2019-10-01  Tom Tromey  <tom@tromey.com>
4119         * cli/cli-cmds.c (pwd_command): Style output.
4121 2019-10-01  Pedro Alves  <palves@redhat.com>
4122             Tom Tromey  <tom@tromey.com>
4124         * symtab.c (print_symbol_info): Use %ps.
4125         (print_msymbol_info): Use %ps.
4126         * symfile.c (symbol_file_add_with_addrs): Use %ps.
4127         * printcmd.c (print_variable_and_value): Use %ps.
4128         * macrocmd.c (show_pp_source_pos): Use %ps.
4129         * infrun.c (print_exited_reason): Use ui_out::message.
4130         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4131         (describe_other_breakpoints): Use ui_out::message and new
4132         formats.
4133         (say_where): Use new formats.
4134         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4135         and new formats.
4137 2019-10-01  Pedro Alves  <palves@redhat.com>
4138             Tom Tromey  <tom@tromey.com>
4140         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4141         (test_gdb_formats): New function.
4142         (run_tests): Call it.
4143         (test_format_specifier): Update.
4144         * utils.h (fputs_filtered): Update comment.
4145         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4146         (fputs_styled_unfiltered): Declare.
4147         * utils.c (fputs_styled_unfiltered): New function.
4148         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4149         (vfprintf_filtered): Update.
4150         (vfprintf_unfiltered, vprintf_filtered): Update.
4151         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4152         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4153         disallow_ui_out_field>: New constants.
4154         (enum class field_kind): New.
4155         (struct base_field_s, struct signed_field_s): New.
4156         (signed_field): New function.
4157         (struct string_field_s): New.
4158         (string_field): New function.
4159         (struct styled_string_s): New.
4160         (styled_string): New function.
4161         (class ui_out) <message>: Add comment.
4162         <vmessage, call_do_message>: New methods.
4163         <do_message>: Add style parameter.
4164         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4165         methods.
4166         (ui_out::message): Rewrite.
4167         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4168         parameter.
4169         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4170         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4171         gdb_extensions parameter.
4172         (class format_piece): Add parameter to constructor.
4173         (n_int_args): New field.
4174         * gdbsupport/format.c (format_pieces::format_pieces): Add
4175         gdb_extensions parameter.  Handle '*'.
4176         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4177         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4178         vfprintf_styled_no_gdbfmt.
4179         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4180         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4181         unfiltered output.
4182         * ui-style.h (struct ui_file_style) <ptr>: New method.
4184 2019-10-01  Tom Tromey  <tom@tromey.com>
4186         * unittests/format_pieces-selftests.c: Update.  Add final format.
4187         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4188         empty literal pieces.
4190 2019-10-01  Tom Tromey  <tom@tromey.com>
4192         * ui-out.h (enum class ui_out_style_kind): Remove.
4193         (class ui_out) <field_string, field_stsream, do_field_string>:
4194         Change type of "style".
4195         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4196         (ui_out::field_string): Update.
4197         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4198         of "style".
4199         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4200         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4201         * stack.c (print_frame_arg, print_frame_info, print_frame):
4202         Update.
4203         * source.c (print_source_lines_base): Update.
4204         * solib.c (info_sharedlibrary_command): Update.
4205         * skip.c (info_skip_command): Update.
4206         * record-btrace.c (btrace_call_history_src_line)
4207         (btrace_call_history): Update.
4208         * python/py-framefilter.c (py_print_frame): Update.
4209         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4210         "style".
4211         * mi/mi-out.c (mi_ui_out::do_table_header)
4212         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4213         (mi_ui_out::do_field_string): Update.
4214         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4215         Update.
4216         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4217         "style".
4218         * cli-out.c (cli_ui_out::do_table_header)
4219         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4220         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4221         (cli_ui_out::do_field_fmt): Update.
4222         * breakpoint.c (print_breakpoint_location): Update.
4223         (update_static_tracepoint): Update.
4225 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4227         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4228         conversion of gdb_datadir.
4229         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4230         remove not needed c_str ().
4232 2019-09-30  Ali Tamur <tamur@google.com>
4234         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4235         (dwarf2_string_attr): Likewise.
4237 2019-09-30  Ali Tamur <tamur@google.com>
4239         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4240         (process_full_type_unit): Likewise.
4241         (dump_die_shallow): Likewise.
4242         (cu_debug_loc_section): Likewise.
4244 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4246         * minsyms.c (compare_minimal_symbols): Rename to...
4247         (minimal_symbol_is_less_than): ...this, and adjust to STL
4248         conventions (return bool, take arguments as references)
4249         (minimal_symbol_reader::install): Call std::sort instead
4250         of qsort.
4252 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4254         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4255         hash and why.
4256         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4257         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4259 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4261         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4262         * psympriv.h (add_psymbol_to_list): Move comment here and update
4263         it.
4265 2019-09-29  Tom de Vries  <tdevries@suse.de>
4267         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4268         Use $tmpdir/$(basename "$output_file").dwz instead of
4269         "${output_file}.dwz".
4271 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4273         PR gdb/25045
4274         * hppa-linux-nat.c: Include gdbarch.h.
4276 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4278         * blockframe.c (find_pc_partial_function): Change return type to bool.
4279         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4280         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4281         (stub_gnu_ifunc_resolve_name): Likewise.
4282         * symtab.c (compare_filenames_for_search): Likewise.
4283         (compare_glob_filenames_for_search): Likewise.
4284         (matching_obj_sections): Likewise.
4285         (symbol_matches_domain): Likewise.
4286         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4287         (find_line_pc): Change return type to bool.
4288         (find_line_pc_range): Likewise.
4289         (producer_is_realview): Likewise.
4290         * symtab.h (symbol_matches_domain): Likewise.
4291         (find_pc_partial_function): Likewise.
4292         (find_pc_line_pc_range): Likewise.
4293         (in_gnu_ifunc_stub): Likewise.
4294         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4295         (find_line_pc): Likewise.
4296         (find_line_pc_range): Likewise.
4297         (matching_obj_sections): Likewise.
4298         (find_line_symtab): Change out parameter to bool.
4299         (producer_is_realview): Change return type to bool.
4300         (compare_filenames_for_search): Likewise.
4301         (compare_glob_filenames_for_search): Likewise.
4303 2019-09-26  Tom Tromey  <tom@tromey.com>
4305         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4306         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4307         * gdb_usleep.h: Remove.
4308         * gdb_usleep.c: Remove.
4309         * utils.c: Don't include gdb_usleep.h.
4311 2019-09-26  Tom Tromey  <tromey@adacore.com>
4313         * python/py-type.c (type_to_type_object): Call check_typedef
4314         for stub types.
4316 2019-09-26  Tom Tromey  <tom@tromey.com>
4318         * utils.h (initialize_utils): Don't declare.
4319         * top.c (gdb_init): Don't call initialize_utils.
4320         * utils.c (initialize_utils): Remove.  Move contents...
4321         (_initialize_utils): ... here.
4323 2019-09-25  Tom Tromey  <tom@tromey.com>
4325         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4326         * utils.h (make_hex_string): Don't declare.
4327         * utils.c (make_hex_string): Remove.
4329 2019-09-24  Tom de Vries  <tdevries@suse.de>
4331         PR gdb/23815
4332         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4333         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4335 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4337         * NEWS: Mention new simulator port for PRU.
4339 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4341         * ada-exp.y (write_object_remaining): Update.
4342         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4343         and eliminate the static buffer.
4344         (ada_decode_symbol): Update.
4345         (ada_la_decode): Update.
4346         (ada_sniff_from_mangled_name): Update.
4347         (is_valid_name_for_wild_match): Update.
4348         (ada_lookup_name_info::matches): Update and simplify.
4349         (name_matches_regex): Update.
4350         (ada_add_global_exceptions): Update.
4351         * ada-lang.h (ada_decode): Update signature.
4352         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4353         * dwarf-index-write.c (debug_names::insert): Update.
4355 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4357         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4358         formatting.
4360 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4362         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4363         Change "nonzero" to "true" in documentation.
4365 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4367         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4368         (_initialize_darwin_solib): Don't set
4369         darwin_so_ops.lookup_lib_global_symbol.
4370         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4371         set_gdbarch_iterate_over_objfiles_in_search_order.
4372         (elf_lookup_lib_symbol): Rename to...
4373         (svr4_iterate_over_objfiles_in_search_order): this, and update
4374         to iterate semantics.
4375         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4376         * solib.c (solib_global_lookup): Remove.
4377         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4378         (solib_global_lookup): Remove.
4379         * symtab.c (lookup_global_or_static_symbol): Remove call to
4380         solib_global_lookup.
4382 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4384         * NEWS: Move entries about default MI version now being
4385         version 3, and about the GDB/MI fix for multi-location
4386         breakpoints to the "since GDB 8.3" section.
4388 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4390         GDB 8.3.1 released.
4392 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4394         * NEWS: Mention that Cell/B.E. debugging support was removed.
4395         * MAINTAINERS: Remove spu target.
4397         * config/djgpp/fnchange.lst: Remove entries for removed files.
4399         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4400         spu-multiarch.o, and spu-tdep.o.
4401         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4402         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4403         spu-multiarch.c, and spu-tdep.c.
4404         * spu-linux-nat.c: Remove file.
4405         * spu-multiarch.c: Remove file.
4406         * spu-tdep.c: Remove file.
4407         * spu-tdep.h: Remove file.
4408         * solib-spu.c: Remove file.
4409         * solib-spu.h: Remove file.
4411         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4412         * configure.nat (spu-linux): Remove.
4413         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4414         solib-multiarch.o from gdb_target_obs.
4415         (spu*-*-*): Remove.
4417         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4418         feature flag.
4419         (ppc_linux_no_features): Update.
4420         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4421         Cell/B.E. support.
4422         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4423         (tdesc_powerpc_cell64l): Likewise.
4424         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4425         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4426         Cell/B.E. support.
4427         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4428         Do not include "features/rs6000/powerpc-cell32l.c" or
4429         "features/rs6000/powerpc-cell64l.c".
4430         (ppc_linux_spu_section): Remove.
4431         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4432         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4433         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4434         (ppc_linux_spe_context_lookup): Remove.
4435         (ppc_linux_spe_context_inferior_created): Remove.
4436         (ppc_linux_spe_context_solib_loaded): Remove.
4437         (ppc_linux_spe_context_solib_unloaded): Remove.
4438         (ppc_linux_spe_context): Remove.
4439         (struct ppu2spu_cache): Remove.
4440         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4441         (struct ppu2spu_data): Remove.
4442         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4443         ppu2spu_unwind): Remove.
4444         (ppc_linux_init_abi): Remove Cell/B.E. support.
4445         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4447         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4448         (rs6000/powerpc-cell64l-expedite): Likewise
4449         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4450         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4451         rs6000/powerpc-cell64l.xml.
4452         * features/rs6000/powerpc-cell32l.xml: Remove.
4453         * features/rs6000/powerpc-cell64l.xml: Likewise.
4454         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4455         * features/rs6000/powerpc-cell64l.c: Likewise.
4456         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4457         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4458         * regformats/reg-spu.dat: Remove.
4460         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4461         * corelow.c (struct spuid_list): Remove.
4462         (add_to_spuid_list): Remove.
4463         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4464         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4465         (remote_protocol_features): Remove associated entries.
4466         (_initialize_remote): No longer initialize them.
4467         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4468         * linux-nat.c (SPUFS_MAGIC): Remove.
4469         (linux_proc_xfer_spu): Remove.
4470         (spu_enumerate_spu_ids): Remove.
4471         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4472         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4473         (linux_make_corefile_notes): No longer call it.
4475         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4476         (cooked_write_test): Likewise.
4478 2019-09-20  Tom Tromey  <tom@tromey.com>
4480         * NEWS: Mention case-sensitivity of TUI commands.
4481         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4482         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4483         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4485 2019-09-20  Tom Tromey  <tom@tromey.com>
4487         * tui/tui-source.c (tui_source_window::set_contents): Use
4488         make_unique_xstrdup.
4489         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4490         make_unique_xstrdup.
4492 2019-09-20  Tom Tromey  <tom@tromey.com>
4494         * tui/tui-data.c: Remove separator comments.
4495         * tui/tui-layout.c: Remove separator comments.
4496         * tui/tui-win.c: Remove separator comments.
4497         * tui/tui-wingeneral.c: Remove separator comments.
4499 2019-09-20  Tom Tromey  <tom@tromey.com>
4501         * tui/tui.h (strcat_to_buf): Don't declare.
4502         * tui/tui.c (strcat_to_buf): Remove.
4504 2019-09-20  Tom Tromey  <tom@tromey.com>
4506         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4507         from "fullname".
4508         * tui/tui-source.c (tui_source_window::set_contents)
4509         (tui_source_window::location_matches_p)
4510         (tui_source_window::maybe_update): Update.
4512 2019-09-20  Tom Tromey  <tom@tromey.com>
4514         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4515         Update.
4516         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4517         prefix.
4518         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4519         (tui_data_window::line_from_reg_element_no)
4520         (tui_data_window::first_reg_element_no_inline)
4521         (tui_data_window::show_registers)
4522         (tui_data_window::show_register_group)
4523         (tui_data_window::display_registers_from)
4524         (tui_data_window::display_registers_from_line)
4525         (tui_data_window::first_data_item_displayed)
4526         (tui_data_window::delete_data_content_windows)
4527         (tui_data_window::erase_data_content)
4528         (tui_data_window::do_scroll_vertical)
4529         (tui_data_window::refresh_window)
4530         (tui_data_window::check_register_values): Update.
4532 2019-09-20  Tom Tromey  <tom@tromey.com>
4534         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4535         (struct tui_locator_window) <full_name, proc_name>: Now
4536         std::string.
4537         * tui/tui-stack.c (tui_locator_window::make_status_line)
4538         (tui_locator_window::set_locator_fullname)
4539         (tui_locator_window::set_locator_info): Update.
4540         * tui/tui-source.c (tui_source_window::set_contents)
4541         (tui_source_window::showing_source_p): Update.
4543 2019-09-20  Tom Tromey  <tom@tromey.com>
4545         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4546         Don't call tui_locator_win_info_ptr.
4548 2019-09-20  Tom Tromey  <tom@tromey.com>
4550         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4552 2019-09-20  Tom Tromey  <tom@tromey.com>
4554         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4555         height for locator.
4556         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4557         * tui/tui-layout.c (show_source_disasm_command, show_data)
4558         (show_source_or_disasm_and_command): Use 1 as height for locator.
4560 2019-09-20  Tom Tromey  <tom@tromey.com>
4562         * tui/tui.c (tui_enable): Update.
4563         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4564         Update.
4565         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4566         Update.
4567         * tui/tui-data.c (win_resized): Now bool.
4568         (tui_win_resized): Return bool.
4569         (tui_set_win_resized_to): Accept a bool.
4571 2019-09-20  Tom Tromey  <tom@tromey.com>
4573         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4574         Change type of "refresh_values_only".
4575         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4576         type of "refresh_values_only".
4578 2019-09-20  Tom Tromey  <tom@tromey.com>
4580         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4581         std::string.
4582         (tui_disassemble): Add "pos" parameter.
4583         (tui_disasm_window::set_contents): Simplify.
4585 2019-09-20  Tom Tromey  <tom@tromey.com>
4587         * tui/tui-winsource.h (struct tui_source_window_base)
4588         <show_source_content>: Now private.
4589         * tui/tui-winsource.c
4590         (tui_source_window_base::show_source_content): Don't handle empty
4591         content case.
4593 2019-09-20  Tom Tromey  <tom@tromey.com>
4595         * tui/tui-layout.c (show_source_disasm_command)
4596         (show_source_or_disasm_and_command): Don't call
4597         show_source_content.
4599 2019-09-20  Tom Tromey  <tom@tromey.com>
4601         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4602         Declare.
4603         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4604         from tui_make_status_line.
4605         (tui_locator_window::rerender): Update.
4607 2019-09-20  Tom Tromey  <tom@tromey.com>
4609         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4610         (tui_locator_window::rerender): Update.
4612 2019-09-20  Tom Tromey  <tom@tromey.com>
4614         * tui/tui-winsource.h (struct tui_source_window_base)
4615         <~tui_source_window_base>: Don't declare.
4616         <fullname>: Remove.
4617         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4618         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4619         member.
4620         * tui/tui-source.c (tui_source_window::set_contents): Update.
4621         (tui_source_window::location_matches_p)
4622         (tui_source_window::maybe_update): Update.
4624 2019-09-20  Tom Tromey  <tom@tromey.com>
4626         * tui/tui-winsource.h (~tui_source_element): Remove.
4627         (tui_source_element): Update.
4628         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4629         * tui/tui-winsource.c (tui_show_source_line): Update.
4630         * tui/tui-source.c (tui_source_window::set_contents): Update.
4631         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4633 2019-09-20  Tom Tromey  <tom@tromey.com>
4635         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4636         declare.
4637         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4638         tui_clear_source_windows_detail.
4639         * tui/tui-winsource.h (struct tui_source_window_base)
4640         <clear_detail>: Don't declare.
4641         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4642         Remove.
4643         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4645 2019-09-20  Tom Tromey  <tromey@adacore.com>
4647         PR ada/24919:
4648         * block.c (contained_in): Fix final return value.
4650 2019-09-20  Alan Modra  <amodra@gmail.com>
4652         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4653         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4654         (read_indirect_string_from_dwz): Use bfd accessor.
4655         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4656         * machoread.c (macho_symfile_read_all_oso): Likewise.
4657         * solib.c (solib_bfd_open): Likewise.
4659 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4661         * eval.c: Move declaration of overload_resolution to...
4662         * value.h: ...here.
4664 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4666         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4667         * arm-linux-tdep.c: Likewise.
4668         * arm-nbsd-nat.c: Likewise.
4669         * arm-tdep.h: Declare arm_apcs_32.
4670         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4672 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4674         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4675         * dwarf2read.h: Declare dwarf_always_disassemble.
4677 2019-09-19  Tom de Vries  <tdevries@suse.de>
4679         PR gdb/25009
4680         * source-cache.c (source_cache::ensure): Catch exception thrown during
4681         construction of the highlighter.
4683 2019-09-18  Alan Modra  <amodra@gmail.com>
4685         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4686         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4687         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4688         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4689         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4690         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4691         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4692         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4693         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4694         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4695         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4696         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4697         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4698         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4699         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4700         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4701         * mi/mi-interp.c: Update throughout for bfd section macro and
4702         function changes.
4703         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4704         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4706 2019-09-18  Tom Tromey  <tom@tromey.com>
4708         * NEWS: Add entry.
4709         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4710         call rl_initialize.
4711         (tui_enable): Do not call rl_initialize.
4713 2019-09-18  Christian Groessler  <chris@groessler.org>
4715         * alpha-linux-nat.c: Include gdbarch.h.
4717 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4719         * ui-file.c: Include cli/cli-style.h.
4720         (term_cli_styling): Remove cli_styling declaration.
4722 2019-09-18  Alan Modra  <amodra@gmail.com>
4724         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4725         to bfd_asymbol_section.
4727 2019-09-18  Alan Modra  <amodra@gmail.com>
4729         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4730         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4731         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4733 2019-09-18  Alan Modra  <amodra@gmail.com>
4735         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4736         * spu-linux-nat.c (spu_bfd_open): Likewise.
4738 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4740         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4741         to bool to match definition in dwarf2read.c.
4743 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4745         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4746         (print_signatures): Likewise.
4747         (trust_pad_over_xvs): Likewise.
4748         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4749         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4750         * arm-linux-nat.c (arm_apcs_32): Likewise.
4751         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4752         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4753         * arm-tdep.c (arm_debug): Likewise.
4754         (arm_apcs_32): Likewise.
4755         * auto-load.c (debug_auto_load): Likewise.
4756         (auto_load_gdb_scripts): Likewise.
4757         (global_auto_load): Likewise.
4758         (auto_load_local_gdbinit): Likewise.
4759         (auto_load_local_gdbinit_loaded): Likewise.
4760         * auto-load.h (global_auto_load): Likewise.
4761         (auto_load_local_gdbinit): Likewise.
4762         (auto_load_local_gdbinit_loaded): Likewise.
4763         * breakpoint.c (disconnected_dprintf): Likewise.
4764         (breakpoint_proceeded): Likewise.
4765         (automatic_hardware_breakpoints): Likewise.
4766         (always_inserted_mode): Likewise.
4767         (target_exact_watchpoints): Likewise.
4768         (_initialize_breakpoint): Update.
4769         * breakpoint.h (target_exact_watchpoints): Change to bool.
4770         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4771         * cli/cli-cmds.c (trace_commands): Likewise.
4772         * cli/cli-cmds.h (trace_commands): Likewise.
4773         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4774         to bool*.
4775         * cli/cli-logging.c (logging_overwrite): Change to bool.
4776         (logging_redirect): Likewise.
4777         (debug_redirect): Likewise.
4778         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4779         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4780         to bool.
4781         <boolean_option_def>: Update.
4782         (struct flag_option_def): Change default type of Context to bool
4783         from int.
4784         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4785         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4786         (get_setshow_command_value_string): Likewise.
4787         * cli/cli-style.c (cli_styling): Change to bool.
4788         (source_styling): Likewise.
4789         * cli/cli-style.h (source_styling): Likewise.
4790         (cli_styling): Likewise.
4791         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4792         to bool.
4793         * command.h (var_types): Update comment.
4794         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4795         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4796         bool.
4797         (debug_compile_cplus_scopes): Likewise.
4798         * compile/compile-internal.h (compile_debug): Likewise.
4799         * compile/compile.c (compile_debug): Likewise.
4800         (struct compile_options) <raw>: Likewise.
4801         * cp-support.c (catch_demangler_crashes): Likewise.
4802         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4803         (usr_cmd_cris_dwarf2_cfi): Likewise.
4804         * csky-tdep.c (csky_debug): Likewise.
4805         * darwin-nat.c (enable_mach_exceptions): Likewise.
4806         * dcache.c (dcache_enabled_p): Likewise.
4807         * defs.h (info_verbose): Likewise.
4808         * demangle.c (demangle): Likewise.
4809         (asm_demangle): Likewise.
4810         * dwarf-index-cache.c (debug_index_cache): Likewise.
4811         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4812         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4813         * dwarf2read.c (check_physname): Likewise.
4814         (use_deprecated_index_sections): Likewise.
4815         (dwarf_always_disassemble): Likewise.
4816         * eval.c (overload_resolution): Likewise.
4817         * event-top.c (set_editing_cmd_var): Likewise.
4818         (exec_done_display_p): Likewise.
4819         * event-top.h (set_editing_cmd_var): Likewise.
4820         (exec_done_display_p): Likewise.
4821         * exec.c (write_files): Likewise.
4822         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4823         (debug_fbsd_nat): Likewise.
4824         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4825         Likewise.
4826         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4827         <backtrace_past_entry> Likewise.
4828         * gdb-demangle.h (demangle): Likewise.
4829         (asm_demangle): Likewise.
4830         * gdb_bfd.c (bfd_sharing): Likewise.
4831         * gdbcore.h (write_files): Likewise.
4832         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4833         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4834         * gdbthread.h (print_thread_events): Likewise.
4835         * gdbtypes.c (opaque_type_resolution): Likewise.
4836         (strict_type_checking): Likewise.
4837         * gnu-nat.c (gnu_debug_flag): Likewise.
4838         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4839         * guile/scm-param.c (pascm_variable): Add boolval.
4840         (add_setshow_generic): Update.
4841         (pascm_param_value): Update.
4842         (pascm_set_param_value_x): Update.
4843         * hppa-tdep.c (hppa_debug): Change to bool..
4844         * infcall.c (may_call_functions_p): Likewise.
4845         (coerce_float_to_double_p): Likewise.
4846         (unwind_on_signal_p): Likewise.
4847         (unwind_on_terminating_exception_p): Likewise.
4848         * infcmd.c (startup_with_shell): Likewise.
4849         * inferior.c (print_inferior_events): Likewise.
4850         * inferior.h (startup_with_shell): Likewise.
4851         (print_inferior_events): Likewise.
4852         * infrun.c (step_stop_if_no_debug): Likewise.
4853         (detach_fork): Likewise.
4854         (debug_displaced): Likewise.
4855         (disable_randomization): Likewise.
4856         (non_stop): Likewise.
4857         (non_stop_1): Likewise.
4858         (observer_mode): Likewise.
4859         (observer_mode_1): Likewise.
4860         (set_observer_mode): Update.
4861         (sched_multi): Change to bool.
4862         * infrun.h (debug_displaced): Likewise.
4863         (sched_multi): Likewise.
4864         (step_stop_if_no_debug): Likewise.
4865         (non_stop): Likewise.
4866         (disable_randomization): Likewise.
4867         * linux-tdep.c (use_coredump_filter): Likewise.
4868         (dump_excluded_mappings): Likewise.
4869         * linux-thread-db.c (auto_load_thread_db): Likewise.
4870         (check_thread_db_on_load): Likewise.
4871         * main.c (captured_main_1): Update.
4872         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4873         xx2_opt, boolean_opt>: Change to bool.
4874         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4875         * maint.c (maintenance_profile_p): Likewise.
4876         (per_command_time): Likewise.
4877         (per_command_space): Likewise.
4878         (per_command_symtab): Likewise.
4879         * memattr.c (inaccessible_by_default): Likewise.
4880         * mi/mi-main.c (mi_async): Likewise.
4881         (mi_async_1): Likewise.
4882         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4883         * nat/fork-inferior.h (startup_with_shell): Likewise.
4884         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4885         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4886         * nios2-tdep.c (nios2_debug): Likewise.
4887         * or1k-tdep.c (or1k_debug): Likewise.
4888         * parse.c (parser_debug): Likewise.
4889         * parser-defs.h (parser_debug): Likewise.
4890         * printcmd.c (print_symbol_filename): Likewise.
4891         * proc-api.c (procfs_trace): Likewise.
4892         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4893         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4894         (set_parameter_value): Update.
4895         (add_setshow_generic): Update.
4896         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4897         to bool*.
4898         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4899         int*.
4900         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4901         * record-btrace.c (record_btrace_target::store_registers): Update.
4902         * record-full.c (record_full_memory_query): Change to bool.
4903         (record_full_stop_at_limit): Likewise.
4904         * record-full.h (record_full_memory_query): Likewise.
4905         * remote-notif.c (notif_debug): Likewise.
4906         * remote-notif.h (notif_debug): Likewise.
4907         * remote.c (use_range_stepping): Likewise.
4908         (interrupt_on_connect): Likewise.
4909         (remote_break): Likewise.
4910         * ser-tcp.c (tcp_auto_retry): Likewise.
4911         * ser-unix.c (serial_hwflow): Likewise.
4912         * skip.c (debug_skip): Likewise.
4913         * solib-aix.c (solib_aix_debug): Likewise.
4914         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4915         (spu_auto_flush_cache_p): Likewise.
4916         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4917         Likewise.
4918         (struct info_print_options) <quiet>: Likewise.
4919         * symfile-debug.c (debug_symfile): Likewise.
4920         * symfile.c (auto_solib_add): Likewise.
4921         (separate_debug_file_debug): Likewise.
4922         * symfile.h (auto_solib_add): Likewise.
4923         (separate_debug_file_debug): Likewise.
4924         * symtab.c (basenames_may_differ): Likewise.
4925         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4926         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4927         (struct info_types_options) <quiet>: Likewise.
4928         * symtab.h (demangle): Likewise.
4929         (basenames_may_differ): Likewise.
4930         * target-dcache.c (stack_cache_enabled_1): Likewise.
4931         (code_cache_enabled_1): Likewise.
4932         * target.c (trust_readonly): Likewise.
4933         (may_write_registers): Likewise.
4934         (may_write_memory): Likewise.
4935         (may_insert_breakpoints): Likewise.
4936         (may_insert_tracepoints): Likewise.
4937         (may_insert_fast_tracepoints): Likewise.
4938         (may_stop): Likewise.
4939         (auto_connect_native_target): Likewise.
4940         (target_stop_and_wait): Update.
4941         (target_async_permitted): Change to bool.
4942         (target_async_permitted_1): Likewise.
4943         (may_write_registers_1): Likewise.
4944         (may_write_memory_1): Likewise.
4945         (may_insert_breakpoints_1): Likewise.
4946         (may_insert_tracepoints_1): Likewise.
4947         (may_insert_fast_tracepoints_1): Likewise.
4948         (may_stop_1): Likewise.
4949         * target.h (target_async_permitted): Likewise.
4950         (may_write_registers): Likewise.
4951         (may_write_memory): Likewise.
4952         (may_insert_breakpoints): Likewise.
4953         (may_insert_tracepoints): Likewise.
4954         (may_insert_fast_tracepoints): Likewise.
4955         (may_stop): Likewise.
4956         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4957         (make_thread_apply_all_options_def_group): Change argument from int*
4958         to bool*.
4959         (thread_apply_all_command): Update.
4960         (print_thread_events): Change to bool.
4961         * top.c (confirm): Likewise.
4962         (command_editing_p): Likewise.
4963         (history_expansion_p): Likewise.
4964         (write_history_p): Likewise.
4965         (info_verbose): Likewise.
4966         * top.h (confirm): Likewise.
4967         (history_expansion_p): Likewise.
4968         * tracepoint.c (disconnected_tracing): Likewise.
4969         (circular_trace_buffer): Likewise.
4970         * typeprint.c (print_methods): Likewise.
4971         (print_typedefs): Likewise.
4972         * utils.c (debug_timestamp): Likewise.
4973         (sevenbit_strings): Likewise.
4974         (pagination_enabled): Likewise.
4975         * utils.h (sevenbit_strings): Likewise.
4976         (pagination_enabled): Likewise.
4977         * valops.c (overload_resolution): Likewise.
4978         * valprint.h (struct value_print_options) <prettyformat_arrays,
4979         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4980         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4981         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4982         Likewise.
4983         * windows-nat.c (new_console): Likewise.
4984         (cygwin_exceptions): Likewise.
4985         (new_group): Likewise.
4986         (debug_exec): Likewise.
4987         (debug_events): Likewise.
4988         (debug_memory): Likewise.
4989         (debug_exceptions): Likewise.
4990         (useshell): Likewise.
4991         * windows-tdep.c (maint_display_all_tib): Likewise.
4992         * xml-support.c (debug_xml): Likewise.
4994 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4996         * source.c (prepare_path_for_appending): New function.
4997         (openp): Make use of new function.
4998         (find_and_open_source): Search for the compilation directory and
4999         source file as a relative path beneath the directory search path.
5001 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5003         * source-cache.c (source_cache::get_line_charpos): Catch
5004         exceptions and return false, this matches the behaviour documented
5005         in the header file.
5007 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
5009         * ada-tasks.c (info_task): Remove quoting of the task's name.
5011 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
5013         * symfile.c (auto_solib_add): Replace comment with a reference
5014         to the header file.
5016 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
5018         * NEWS: Mention that gdb can now be compiled with Python 3
5019         on Windows.
5021 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5023         * maint.c (maint_print_section_data::maint_print_section_data):
5024         Force use of 'float log10 (float)' by casting the argument to
5025         float.
5027 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5029         * maint.c: Add 'cmath' include.
5030         (struct maint_print_section_data): New structure.
5031         (print_section_index): New function.
5032         (print_bfd_section_info): Add header comment, small whitespace
5033         cleanup, and update to call new print_section_index function.
5034         (print_objfile_section_info): Likewise.
5035         (maint_obj_section_from_bfd_section): New function.
5036         (print_bfd_section_info_maybe_relocated): New function.
5037         (maintenance_info_sections): Add header comment, always use
5038         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
5040 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5042         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
5043         inner scope, add check that the objfile has psymtabs before
5044         checking psymtabs_addrmap.
5045         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
5047 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5049         * NEWS: Announce that Ada task names are now shown at more places,
5050         and between quotes (except in info task output).
5051         * ada-tasks.c (task_to_str): New function.
5052         (display_current_task_id): Call task_to_str.
5053         (task_command_1): Likewise.
5054         (print_ada_task_info): In non-mi mode, Properly align headers and data
5055         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
5057 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5059         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
5060         prstatus.pr_lwp.pr_info instead of making it up.
5062 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5064         * auto-load.c (auto_load_expand_dir_vars): Update.
5065         * defs.h (gdb_datadir): Change to std::string.
5066         (python_libdir): Likewise.
5067         (relocate_gdb_directory): Change return type to std::string.
5068         * guile/guile.c (gdbscm_data_directory): Update.
5069         (initialize_scheme_side): Update.
5070         * jit.c (jit_reader_dir): Change to std::string.
5071         (jit_reader_load_command): Update.
5072         * main.c (gdb_datadir): Change to std::string.
5073         (python_libdir): Likewise.
5074         (set_gdb_data_directory): Update.
5075         (relocate_path): Change to return std::string.
5076         (relocate_gdb_directory): Change to return std::string.
5077         (relocate_gdbinit_path_maybe_in_datadir): Update.
5078         (captured_main_1): Update.
5079         * python/python.c (do_start_initialization): Update.
5080         * top.c (show_gdb_datadir): Update.
5081         * xml-syscall.c (xml_init_syscalls_info): Update.
5082         (init_syscalls_info): Update.
5084 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5086         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
5087         out of get_init_files.
5088         (get_init_files): Update.
5090 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5092         * main.c (get_init_files): Change to use std::string.
5093         (captured_main_1): Update.
5094         (print_gdb_help): Update.
5096 2019-09-11  Ali Tamur  <tamur@google.com>
5098         * target-float.c (host_float_ops<T>::to_longest): Update
5099         implementation.
5101 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5103         * dbxread.c (read_dbx_symtab): Update.
5104         * dwarf2read.c (load_partial_dies): Update.
5105         * mdebugread.c (parse_partial_symbols): Update.
5106         (handle_psymbol_enumerators): Update.
5107         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5108         * psymtab.c (add_psymbol_to_bcache): Likewise.
5109         (add_psymbol_to_list): Likewise.
5110         * symtab.c (symbol_set_names): Likewise.
5111         * symtab.h (symbol_set_names): Likewise.
5112         * xcoffread.c (scan_xcoff_symtab): Update.
5114 2019-09-11  Tom Tromey  <tom@tromey.com>
5116         * symfile-mem.c (symbol_file_add_from_memory): Use
5117         bfd_set_filename.
5118         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5119         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5121 2019-09-10  Tom Tromey  <tromey@adacore.com>
5123         * dwarf-index-write.c (write_psymbols): Extend error message.
5124         (debug_names::insert): Add Ada code.
5125         (debug_names::write_psymbols): Remove Ada check.
5126         (debug_names) <m_string_obstack>: New member.
5127         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5128         (gdb_index_symbol_name_matcher::matches): Remove.
5129         (mapped_index_base::find_name_components_bounds): Add "lang"
5130         parameter.
5131         (mapped_index_base::build_name_components): Also split names
5132         according to Ada syntax.
5133         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
5134         type of "match_callback".
5135         (check_match, check_find_bounds_finds)
5136         (dw2_expand_symtabs_matching): Update.
5137         (dw2_debug_names_iterator): Add new constructor.
5138         (dw2_debug_names_map_matching_symbols): New function.
5139         (dw2_debug_names_expand_symtabs_matching): Update.
5140         (dwarf2_debug_names_functions): Use
5141         dw2_debug_names_map_matching_symbols.
5143 2019-09-10  Tom Tromey  <tromey@adacore.com>
5145         * dwarf2read.c (dw2_get_file_names_reader): Add the
5146         CU's file name to the results.
5148 2019-09-10  Tom Tromey  <tromey@adacore.com>
5150         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5151         map_matching_symbols.  Update.
5152         * dwarf2read.c (dw2_map_matching_symbols): Update.
5153         * psymtab.c (match_partial_symbol): Change type; update.
5154         (psym_map_matching_symbols): Likewise.
5155         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5156         type; update.
5157         * symfile.h (struct quick_symbol_functions)
5158         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5159         Remove "match".
5161 2019-09-10  Tom Tromey  <tromey@adacore.com>
5163         * psymtab.c (map_block): Remove.
5164         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5165         * symtab.c (iterate_over_symbols_terminated): New function.
5166         * symtab.c (iterate_over_symbols_terminated): Declare.
5168 2019-09-10  Tom Tromey  <tromey@adacore.com>
5170         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5171         * language.h (struct language_defn) <la_iterate_over_symbols>:
5172         Return bool.
5173         * symtab.c (iterate_over_symbols): Return bool.
5174         * symtab.h (iterate_over_symbols): Return bool.
5176 2019-09-10  Tom Tromey  <tromey@adacore.com>
5178         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5179         (add_nonlocal_symbols): Update.
5180         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5181         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5182         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5183         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5184         Change type of "callback".  Remove "data".
5187 2019-09-09  Ali Tamur  <tamur@google.com>
5189         * dwarf2read.c (comp_unit_head): Update comment.                     
5190         (dwarf2_dwo_name): New function declaration.                             
5191         (dwarf_unit_type_name): New function declaration.                        
5192         (read_comp_unit_head): Add support for new compilation units,            
5193         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.    
5194         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id         
5195         (currently named as "signature") in their header. Also clarify error     
5196         messages.                                                                
5197         (lookup_dwo_id): New function. Returns the dwo id of the given           
5198         compile unit.                                                            
5199         (lookup_dwo_unit): Use the new lookup_dwo_id function.                   
5200         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id 
5201         functions.                                                               
5202         (create_dwo_cu_reader): Use the added lookup_dwo_id function.            
5203         (dwarf2_dwo_name): Get the dwo name if present.                          
5204         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic   
5205         purposes.
5207 2019-09-09  Tom Tromey  <tom@tromey.com>
5209         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5211 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5213         * python/python.c (do_start_initialization): Make progname_copy static,
5214         to avoid a leak report.
5216 2019-09-08  Tom Tromey  <tom@tromey.com>
5218         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5220 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5222         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5223         Change type to gdb::optional<block_enum>.
5224         (dw2_symtab_iter_init): Change block_index parameter type
5225         to gdb::optional<block_enum>.
5226         (dw2_lookup_symbol): Change block_index parameter
5227         type to block_enum.c
5228         (dw2_debug_names_lookup_symbol): Likewise.
5229         * psymtab.c (psym_lookup_symbol): Likewise.
5230         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5231         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5232         Likewise.
5234 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5236         * defs.h (relocate_gdb_directory): Change int to bool in
5237         signature and rename flag to relocatable.
5238         * main.c (relocate_path): Likewise.
5239         (relocate_gdb_directory): Likewise.
5241 2019-09-06  Alan Modra  <amodra@gmail.com>
5243         * coffread.c (coff_symfile_read): Constify filename variable.
5244         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5245         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5246         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5247         * solib.c (reload_shared_libraries_1): Likewise.
5248         * symfile.c (reread_symbols): Likewise.
5249         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5250         * solib-darwin.c (darwin_bfd_open): Likewise.
5251         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5253 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5255         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5256         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5258 2019-09-03  Tom Tromey  <tromey@adacore.com>
5260         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5261         types.
5262         (has_negatives): Unbias a range type bound.
5263         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5264         * gdbtypes.c (operator==): Handle new field.
5265         (create_range_type): Add "bias" parameter.
5266         (create_static_range_type, resolve_dynamic_range): Update.
5267         * gdbtypes.h (struct range_bounds) <bias>: New member.
5268         (create_range_type): Add bias parameter.
5269         * printcmd.c (print_scalar_formatted): Unbias range types.
5270         * value.c (unpack_long): Unbias range types.
5271         (pack_long): Bias range types.
5273 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5275         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5276         probe arguments.
5278 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5280         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5281         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5282         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5283         (compile_probe_arg): Likewise.
5284         * probe.h (get_argument_count): Likewise.
5285         * solib-svr4.c (solib_event_probe_action): Likewise.
5286         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5288 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5290         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5291         code to here...
5292         (svr4_create_solib_event_breakpoints): ...from here.
5294 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5296         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5297         suffix from warning message.
5299 2019-08-30  Tom Tromey  <tom@tromey.com>
5301         * tui/tui-winsource.h (struct tui_source_window_base)
5302         <refresh_all>: Don't declare.
5303         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5304         Remove.
5305         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5306         tui_show_locator_content.
5307         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5308         declare.
5309         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5310         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5311         declare.
5313 2019-08-30  Tom Tromey  <tom@tromey.com>
5315         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5317 2019-08-30  Tom Tromey  <tom@tromey.com>
5319         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5320         Remove unnecessary forward declarations.
5322 2019-08-30  Tom Tromey  <tom@tromey.com>
5324         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5325         rerender.
5326         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5327         tui_show_locator_content.
5329 2019-08-30  Tom Tromey  <tom@tromey.com>
5331         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5332         (tui_locator_window::rerender): Rewrite using body of previous
5333         tui_show_locator_content.
5335 2019-08-30  Tom Tromey  <tom@tromey.com>
5337         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5338         set_locator_fullname>: New methods.
5339         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5340         Rename from tui_set_locator_fullname.
5341         (tui_locator_window::set_locator_info): Rename from
5342         tui_set_locator_info.  Return bool.
5343         (tui_update_locator_fullname, tui_show_frame_info): Update.
5345 2019-08-30  Tom Tromey  <tom@tromey.com>
5347         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5349 2019-08-30  Tom Tromey  <tom@tromey.com>
5351         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5352         call touchwin.
5354 2019-08-30  Tom Tromey  <tom@tromey.com>
5356         * tui/tui-wingeneral.c (box_win): Assume win_info and
5357         win_info->handle cannot be NULL.
5359 2019-08-30  Tom Tromey  <tom@tromey.com>
5361         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5362         refresh_window>: Declare.
5363         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5364         resize.
5365         (tui_data_item_window::rerender): Rename from
5366         tui_display_register.
5367         (tui_data_item_window::refresh_window): New method.
5368         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5369         no-op.
5371 2019-08-30  Tom Tromey  <tom@tromey.com>
5373         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5374         regs_column_count, current_group>: Move later.  Now private.
5375         <get_current_group>: New method.
5376         * tui/tui-regs.c (tui_reg_command): Update.
5377         * tui/tui-layout.c (tui_set_layout): Update.
5379 2019-08-30  Tom Tromey  <tom@tromey.com>
5381         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5382         (tui_data_window::rerender): Don't call
5383         check_and_display_highlight_if_needed.
5384         (tui_data_window::refresh_all): Remove call to
5385         erase_data_content.
5387 2019-08-30  Tom Tromey  <tom@tromey.com>
5389         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5390         (tui_data_window::display_registers_from)
5391         (tui_data_window::display_reg_element_at_line)
5392         (tui_data_window::display_registers_from_line): Remove checks of
5393         "empty".
5395 2019-08-30  Tom Tromey  <tom@tromey.com>
5397         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5398         Don't declare.
5399         * tui/tui-regs.c (tui_data_window::show_registers): Call
5400         rerender.
5401         (tui_data_window::rerender): Rename from display_all_data.
5402         (tui_data_window::rerender): Remove old implementation.
5404 2019-08-30  Tom Tromey  <tom@tromey.com>
5406         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5407         text.
5408         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5410 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5411             Sergio Durigan Junior  <sergiodj@redhat.com>
5413         PR win32/24284
5414         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5416 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5418         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5419         when searching for types.
5421 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5423         * f-lang.c (f_language_defn): Use f_print_typedef.
5424         * f-lang.h (f_print_typedef): Declare.
5425         * f-typeprint.c (f_print_typedef): Define.
5427 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5429         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5431 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5433         * cli/cli-utils.c (info_print_options_defs): Delete.
5434         (make_info_print_options_def_group): Delete.
5435         (extract_info_print_options): Delete.
5436         (info_print_command_completer): Delete.
5437         (info_print_args_help): Add extra parameter, and optionally
5438         include text about -n flag.
5439         * cli/cli-utils.h (struct info_print_options): Delete.
5440         (extract_info_print_options): Delete declaration.
5441         (info_print_command_completer): Delete declaration.
5442         (info_print_args_help): Add extra parameter, extend header
5443         comment.
5444         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5445         search_symbols.
5446         * stack.c (struct info_print_options): New type.
5447         (info_print_options_defs): New file scoped variable.
5448         (make_info_print_options_def_group): New static function.
5449         (info_print_command_completer): New static function.
5450         (info_locals_command): Update to use new local functions.
5451         (info_args_command): Likewise.
5452         (_initialize_stack): Add extra parameter to calls to
5453         info_print_args_help.
5454         * symtab.c (search_symbols): Add extra parameter, use this to
5455         possibly excluse non-debug symbols.
5456         (symtab_symbol_info): Add extra parameter, which is passed on to
5457         search_symbols.
5458         (struct info_print_options): New type.
5459         (info_print_options_defs): New file scoped variable.
5460         (make_info_print_options_def_group): New static function.
5461         (info_print_command_completer): New static function.
5462         (info_variables_command): Update to use local functions, and pass
5463         extra parameter through to symtab_symbol_info.
5464         (info_functions_command): Likewise.
5465         (info_types_command): Pass additional argument through to
5466         symtab_symbol_info.
5467         (rbreak_command): Pass extra argument to search_symbols.
5468         (_initialize_symtab): Add extra arguments for calls to
5469         info_print_args_help, and update help text for 'info variables',
5470         'whereis', and 'info functions' commands.
5471         * symtab.h (search_symbols): Add extra argument to declaration.
5472         * NEWS: Mention new flags.
5474 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5476         * symtab.c (lookup_static_symbol): Call the new function (and move
5477         it down to be next to lookup_global_symbol).
5478         (struct global_sym_lookup_data): Add block_enum member and rename to...
5479         (struct global_or_static_sym_lookup_data): ...this.
5480         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5481         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5482         (lookup_symbol_global_or_static_iterator_cb): ...this.
5483         (lookup_global_or_static_symbol): New function.
5484         (lookup_global_symbol): Call new function.
5486 2019-08-26  Tom de Vries  <tdevries@suse.de>
5488         PR c++/24852
5489         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5490         when pc_probe.prob == NULL.
5492 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5494         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5495         variable symbol_linkage to symbol_linkage_.
5497 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5499         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5500         represent whether the symbol is static, dynamic, or we don't
5501         know.
5503 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5505         * rx-tdep.c (rx_register_names): New.
5506         (rx_register_name): Delete.
5507         (rx_psw_type): Delete.
5508         (rx_fpsw_type): Delete.
5509         (rx_register_type): Delete.
5510         (rx_gdbarch_init): Convert target-descriptions.
5511         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5512         * features/Makefile: Add rx.xml.
5513         * features/rx.xml: New.
5514         * features/rx.c: Generated.
5515         * NEWS: Mention target description support.
5517 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5519         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5520         *slot_ptr.
5522 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5524         * configure.ac: Don't check for 'dlfcn.h' (moved to
5525         gdbsupport/common.m4).
5526         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5527         'gdbsupport/'.
5528         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5529         * compile/compile-c-support.c: Include
5530         'gdbsupport/gdb-dlfcn.h'.
5531         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5532         * gdb-dlfcn.c: Move to...
5533         * gdbsupport/gdb-dlfcn.c: ... here.
5534         * gdb-dlfcn.h: Move to...
5535         * gdbsupport/gdb-dlfcn.h: ... here.
5537 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5539         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5540         the offset field signed.
5542 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5544         * python/lib/gdb/__init__.py (_execute_file): New function.
5545         * python/python.c (python_run_simple_file): Call gdb._execute_file
5546         on Windows.
5548 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5550         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5551         all uses as this was never set to anything but a zero value.
5553 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5555         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5557 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5559         * tui/tui-data.h (tui_gen_win_info): Add an =default
5560         move constructor, required by some GCC versions.
5562 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5564         * go32-nat.c (go32_sysinfo): Add hygon_p.
5566 2019-08-20  Tom Tromey  <tom@tromey.com>
5568         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5569         line_from_reg_element_no, first_reg_element_no_inline,
5570         display_all_data, delete_data_content_windows,
5571         erase_data_content>: Now private.
5573 2019-08-20  Tom Tromey  <tom@tromey.com>
5575         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5576         (tui_unhighlight_win, tui_highlight_win)
5577         (tui_win_info::make_window): Update.
5578         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5580 2019-08-20  Tom Tromey  <tom@tromey.com>
5582         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5583         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5584         (MAX_PID_WIDTH): Move to tui-stack.c.
5585         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5586         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5587         (MAX_PID_WIDTH): Move from tui-data.h.
5589 2019-08-20  Tom Tromey  <tom@tromey.com>
5591         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5592         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5593         (box_win): Update.
5594         (tui_gen_win_info::make_window): Rename from tui_make_window.
5595         (tui_win_info::make_window): New method.
5596         (tui_gen_win_info::make_visible): Update.
5597         * tui/tui-source.c (tui_source_window::set_contents): Update.
5598         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5599         (tui_data_window::display_registers_from): Update.
5600         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5601         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5602         Declare.
5603         <can_box>: Remove.
5604         <title>: Remove.
5605         (struct tui_win_info) <make_window>: Declare.
5606         <can_box>: Now virtual.
5607         <title>: New member.
5608         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5609         * tui/tui-command.c (tui_cmd_window::resize): Update.
5611 2019-08-20  Tom Tromey  <tom@tromey.com>
5613         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5614         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5615         (tui_data_window::check_register_values): Update.
5617 2019-08-20  Tom Tromey  <tom@tromey.com>
5619         * tui/tui-regs.h (struct tui_data_window): Use
5620         DISABLE_COPY_AND_ASSIGN.
5621         <regs_content>: Change type, removing unique_ptr.
5622         <tui_data_window>: Add move constructor.
5623         * tui/tui-regs.c (tui_data_window::show_registers)
5624         (tui_data_window::show_register_group)
5625         (tui_data_window::display_registers_from)
5626         (tui_data_window::display_registers_from)
5627         (tui_data_window::first_data_item_displayed)
5628         (tui_data_window::delete_data_content_windows)
5629         (tui_data_window::rerender, tui_data_window::refresh_window)
5630         (tui_data_window::check_register_values): Update.
5632 2019-08-20  Tom Tromey  <tom@tromey.com>
5634         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5635         show_register_group>: Declare.
5636         (tui_show_register_group): Don't declare.
5637         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5638         tui_show_registers.
5639         (tui_data_window::show_register_group): Rename from
5640         tui_show_register_group.
5641         (tui_data_window::check_register_values, tui_reg_command):
5642         Update.
5643         * tui/tui-layout.c (tui_set_layout): Update.
5645 2019-08-20  Tom Tromey  <tom@tromey.com>
5647         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5648         Declare.
5649         (tui_check_register_values): Don't declare.
5650         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5651         from tui_check_register_values.
5652         * tui/tui-hooks.c (tui_register_changed): Update.
5654 2019-08-20  Tom Tromey  <tom@tromey.com>
5656         * tui/tui-regs.c (tui_reg_layout): Move later.
5657         (tui_show_registers): Don't enable TUI mode or change layout.
5659 2019-08-20  Tom Tromey  <tom@tromey.com>
5661         * tui/tui-regs.h (struct tui_data_item_window)
5662         <~tui_data_item_window>: Remove.
5663         <content>: Now a unique_xmalloc_ptr.
5664         * tui/tui-regs.c (tui_register_format): Return a
5665         unique_xmalloc_ptr.
5666         (tui_get_register): Update.
5667         (~tui_data_item_window): Remove.
5668         (tui_data_window::display_registers_from, tui_display_register):
5669         Update.
5670         * tui/tui-io.h (tui_expand_tabs): Update.
5671         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5672         Remove "col" parameter.
5674 2019-08-20  Tom Tromey  <tom@tromey.com>
5676         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5677         field.
5678         * tui/tui-regs.c (~tui_data_item_window): Update.
5680 2019-08-20  Tom Tromey  <tom@tromey.com>
5682         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5683         earlier.
5685 2019-08-20  Tom Tromey  <tom@tromey.com>
5687         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5689 2019-08-20  Tom Tromey  <tom@tromey.com>
5691         * tui/tui-source.h (struct tui_source_window): Update.
5692         * tui/tui-regs.c (tui_show_registers): Update.
5693         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5694         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5695         (NO_REGS_STRING): Remove defines.
5697 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5699         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5700         unnecessary thread walk if remote doesn't support the packet.
5702 2019-08-19  Tom Tromey  <tromey@adacore.com>
5704         * python/py-value.c (value_has_field): Fix indentation.
5706 2019-08-19  Tom Tromey  <tromey@adacore.com>
5708         * printcmd.c (do_one_display, info_display_command): Update.
5709         * block.h (contained_in): Return bool.  Add allow_nested
5710         parameter.
5711         * block.c (contained_in): Return bool.  Add allow_nested
5712         parameter.
5714 2019-08-19  Tom Tromey  <tom@tromey.com>
5716         * configure: Rebuild.
5717         * configure.ac: Disallow the combination of -static-libstdc++ and
5718         source highlight.
5719         * source-cache.c (get_language_name): Handle rust.
5720         (source_cache::get_source_lines): Ignore highlighting exceptions.
5722 2019-08-16  Tom Tromey  <tom@tromey.com>
5724         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5725         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5726         (struct tui_source_window_base) <make_visible, refresh_window,
5727         resize>: Remove methods.
5728         <execution_info>: Remove field.
5729         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5730         (tui_show_source_line, tui_source_window_base)
5731         (~tui_source_window_base): Update.
5732         (tui_source_window_base::resize)
5733         (tui_source_window_base::make_visible)
5734         (tui_source_window_base::refresh_window): Remove.
5735         (tui_source_window_base::update_exec_info): Update.
5736         * tui/tui-source.c (tui_source_window::set_contents): Update.
5737         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5739 2019-08-16  Tom Tromey  <tom@tromey.com>
5741         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5742         deprecated_query_hook.
5744 2019-08-16  Tom Tromey  <tom@tromey.com>
5746         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5747         (tui_update_source_windows_with_line): Update.
5748         * tui/tui-source.h (struct tui_source_window)
5749         <show_symtab_source>: Declare.
5750         (tui_show_symtab_source): Don't declare.
5751         * tui/tui-source.c (tui_show_symtab_source): Rename from
5752         tui_show_symtab_source.
5754 2019-08-16  Tom Tromey  <tom@tromey.com>
5756         * tui/tui-winsource.h (struct tui_source_window_base)
5757         <set_contents>: Declare.
5758         * tui/tui-winsource.c
5759         (tui_source_window_base::update_source_window_as_is): Update.
5760         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5761         Declare.
5762         (tui_set_source_content): Don't declare.
5763         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5764         tui_set_source_content.
5765         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5766         Declare.
5767         (tui_set_disassem_content): Don't declare.
5768         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5769         tui_set_disassem_content.
5771 2019-08-16  Tom Tromey  <tom@tromey.com>
5773         * tui/tui-winsource.h (struct tui_source_window_base)
5774         <update_breakpoint_info>: Declare.
5775         (tui_update_breakpoint_info): Don't declare.
5776         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5777         (tui_update_all_breakpoint_info): Update.
5778         (tui_source_window_base::update_breakpoint_info): Rename from
5779         tui_update_breakpoint_info.
5780         (tui_source_window_base::update_exec_info): Update.
5782 2019-08-16  Tom Tromey  <tom@tromey.com>
5784         * tui/tui-winsource.h (struct tui_source_window_base)
5785         <update_source_window>: Declare.
5786         (tui_update_source_window): Don't declare.
5787         * tui/tui-winsource.c
5788         (tui_source_window_base::update_source_window): Rename from
5789         tui_update_source_window.
5790         (tui_source_window_base::rerender): Update.
5791         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5792         * tui/tui-disasm.c (tui_show_disassem)
5793         (tui_show_disassem_and_update_source)
5794         (tui_disasm_window::maybe_update): Update.
5796 2019-08-16  Tom Tromey  <tom@tromey.com>
5798         * tui/tui-winsource.h (struct tui_source_window_base)
5799         <update_source_window_as_is>: Declare.
5800         (tui_update_source_window_as_is): Don't declare.
5801         * tui/tui-winsource.c (tui_update_source_window): Update
5802         (tui_source_window_base::update_source_window_as_is): Rename from
5803         tui_update_source_window_as_is.
5804         (tui_source_window_base::refill): Update.
5805         * tui/tui-source.c (tui_show_symtab_source): Update.
5806         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5807         Update.
5809 2019-08-16  Tom Tromey  <tom@tromey.com>
5811         * tui/tui-winsource.h (tui_update_source_window)
5812         (tui_update_source_window_as_is): Remove "noerror" parameter.
5813         * tui/tui-winsource.c (tui_update_source_window)
5814         (tui_update_source_window_as_is): Remove "noerror" parameter.
5815         (tui_update_source_windows_with_addr)
5816         (tui_update_source_windows_with_line)
5817         (tui_source_window_base::rerender)
5818         (tui_source_window_base::refill): Update.
5819         * tui/tui-source.h (tui_set_source_content)
5820         (tui_show_symtab_source): Remove "noerror" parameter.
5821         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5822         parameter.
5823         (tui_show_symtab_source): Likewise.
5824         (tui_source_window::maybe_update): Update.
5825         * tui/tui-disasm.c (tui_show_disassem)
5826         (tui_show_disassem_and_update_source)
5827         (tui_disasm_window::do_scroll_vertical)
5828         (tui_disasm_window::maybe_update): Update.
5830 2019-08-16  Tom Tromey  <tom@tromey.com>
5832         * tui/tui.c (tui_is_window_visible): Update.
5833         * tui/tui-wingeneral.c (tui_make_window)
5834         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5835         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5836         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5837         (tui_set_win_height_command, parse_scrolling_args): Update.
5838         * tui/tui-source.c (tui_source_window::style_changed): Update.
5839         * tui/tui-regs.c (tui_show_registers)
5840         (tui_data_window::first_data_item_displayed)
5841         (tui_data_window::delete_data_content_windows)
5842         (tui_check_register_values, tui_reg_command): Update.
5843         * tui/tui-disasm.c (tui_show_disassem): Update.
5844         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5845         method.
5846         <is_visible>: Remove field.
5847         * tui/tui-data.c (tui_next_win, tui_prev_win)
5848         (tui_delete_invisible_windows): Update.
5850 2019-08-16  Tom Tromey  <tom@tromey.com>
5852         * tui/tui-winsource.h (struct tui_source_window_base)
5853         <m_has_locator>: Remove.
5854         * tui/tui-layout.c (show_source_disasm_command, show_data)
5855         (show_source_or_disasm_and_command): Update.
5857 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5859         * NEWS (Other MI changes): New subsection.
5860         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5861         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5862         * arch-utils.c (default_get_pc_address_flags): New function.
5863         * arch-utils.h (default_get_pc_address_flags): New declaration.
5864         * gdbarch.sh: Add get_pc_address_flags.
5865         * gdbarch.c: Regenerate.
5866         * gdbarch.h: Likewise.
5867         * stack.c (print_pc): New function.
5868         (print_frame_info) (print_frame): Call print_pc.
5870 2019-08-16  Tom de Vries  <tdevries@suse.de>
5872         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5873         print_objfile_section_info.
5875 2019-08-15  Tom Tromey  <tom@tromey.com>
5877         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5878         calling update_cmdwin_start_line.
5879         * tui/tui-winsource.h (struct tui_source_window_base)
5880         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5881         <rerender>: Declare.
5882         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5883         Call rerender.
5884         (tui_source_window_base::set_new_height): Remove.
5885         (tui_source_window_base::rerender): Rename from
5886         do_make_visible_with_new_height.
5887         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5888         resize method.
5889         (tui_win_info::make_invisible_and_set_new_height)
5890         (tui_win_info::make_visible_with_new_height): Remove.
5891         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5892         Declare.
5893         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5894         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5895         do_make_visible_with_new_height>: Don't declare.
5896         <rerender>: Declare.
5897         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5898         set_new_height.
5899         (tui_data_window::do_make_visible_with_new_height): Remove.
5900         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5901         call tui_show_locator_content.
5902         (tui_gen_win_info::resize): Call rerender.
5903         (show_source_or_disasm_and_command): Don't call
5904         tui_show_locator_content.
5905         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5906         method.
5907         (struct tui_win_info) <rerender>: Declare.
5908         <set_new_height, make_invisible_and_set_new_height,
5909         make_visible_with_new_height>: Don't declare.
5910         * tui/tui-data.c (tui_win_list::rerender): New method.
5911         * tui/tui-command.h (struct tui_cmd_window)
5912         <do_make_visible_with_new_height>: Don't declare.
5913         * tui/tui-command.c
5914         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5916 2019-08-15  Tom Tromey  <tromey@adacore.com>
5918         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5919         * ada-lang.c (ada_enum_name): Likewise.
5921 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5923         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5924         leading underscore.
5925         (GdbOutputErrorFile): Likewise.
5926         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5927         accordingly.
5928         (execute_unwinders): Rename to have a leading underscore.
5929         (auto_load_packages): Likewise.
5930         (global scope): Adjust call to auto_load_packages accordingly.
5931         (GdbSetPythonDirectory): Likewise.
5932         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5933         instead of execute_unwinders.
5935 2019-08-15  Tom Tromey  <tom@tromey.com>
5937         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5938         (show_data): Don't change window visibility.
5939         (tui_gen_win_info::resize): Remove special case for command
5940         window.  Use wresize, when available.
5941         (show_source_or_disasm_and_command): Don't change window
5942         visibility.
5943         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5944         <make_visible>: New method.
5945         * tui/tui-command.c (tui_cmd_window::resize): New method.
5947 2019-08-15  Tom Tromey  <tom@tromey.com>
5949         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5950         (struct tui_source_windows): New.
5951         * tui/tui-winsource.c (tui_display_main): Update.
5952         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5953         (new_height_ok, parse_scrolling_args): Update.
5954         * tui/tui-layout.c (show_layout, show_data): Update.
5955         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5956         (tui_add_to_source_windows): Don't declare.
5957         * tui/tui-data.c (source_windows, tui_source_windows)
5958         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5960 2019-08-15  Tom Tromey  <tom@tromey.com>
5962         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5963         Rename from reset.
5964         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5965         * tui/tui-layout.c (show_source_disasm_command, show_data):
5966         Update.
5967         (tui_gen_win_info::resize): Rename.
5968         (show_source_or_disasm_and_command): Update.
5969         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5970         reset.
5972 2019-08-15  Tom Tromey  <tom@tromey.com>
5974         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5975         * tui/tui-interp.c (tui_interp::init): Don't call
5976         tui_initialize_static_data.
5977         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5979 2019-08-15  Tom Tromey  <tom@tromey.com>
5981         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5982         examine tui_win_list.
5984 2019-08-15  Tom Tromey  <tom@tromey.com>
5986         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5987         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5988         tui_clear_source_content.
5989         (tui_clear_source_content): Remove.
5990         (tui_source_window_base::do_erase_source_content): Hoist call to
5991         content.clear().
5992         * tui/tui-stack.c (tui_show_frame_info): Don't call
5993         tui_clear_source_content.
5995 2019-08-15  Tom Tromey  <tom@tromey.com>
5997         * tui/tui-winsource.h (struct tui_source_window_base)
5998         <do_erase_source_content>: New method.
5999         <erase_source_content>: New method.
6000         (tui_erase_source_content): Don't declare.
6001         * tui/tui-winsource.c (tui_clear_source_content): Update.
6002         (tui_source_window_base::do_erase_source_content): Rename from
6003         tui_erase_source_content.
6004         (tui_source_window_base::show_source_content): Update.
6005         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6006         * tui/tui-source.h (struct tui_source_window)
6007         <erase_source_content>: New method.
6008         * tui/tui-disasm.h (struct tui_disasm_window)
6009         <erase_source_content>: New method.
6011 2019-08-15  Tom Tromey  <tom@tromey.com>
6013         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
6014         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
6015         constructor.
6016         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
6017         * tui/tui-source.c (tui_set_source_content): Update.
6018         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6020 2019-08-15  Tom Tromey  <tom@tromey.com>
6022         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
6023         * tui/tui-winsource.c (tui_line_is_displayed): Move to
6024         tui-source.c.
6025         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
6026         Declare.
6027         * tui/tui-source.c (tui_source_window::line_is_displayed): New
6028         method.
6029         (tui_source_window::maybe_update): Update.
6031 2019-08-15  Tom Tromey  <tom@tromey.com>
6033         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
6034         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
6035         tui-disasm.c.
6036         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
6037         Declare.
6038         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
6039         method.
6040         (tui_disasm_window::maybe_update): Update.
6042 2019-08-15  Tom Tromey  <tom@tromey.com>
6044         * tui/tui-winsource.h (struct tui_source_window_base)
6045         <maybe_update>: Declare.
6046         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
6047         method.
6048         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
6049         Declare.
6050         * tui/tui-source.c (tui_source_window::maybe_update): New method.
6051         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
6052         Declare.
6053         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
6055 2019-08-15  Tom Tromey  <tom@tromey.com>
6057         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
6059 2019-08-15  Tom Tromey  <tom@tromey.com>
6061         * tui/tui-wingeneral.c: Include tui-stack.h.
6062         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
6063         (struct tui_locator_window): Move from tui-data.h.
6064         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
6065         (tui_initialize_static_data): Move from tui-data.c.
6066         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
6067         (struct tui_locator_window): Move to tui-stack.c.
6068         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
6069         (tui_initialize_static_data): Move to tui-stack.c.
6071 2019-08-15  Tom Tromey  <tom@tromey.com>
6073         * tui/tui-layout.c (show_source_disasm_command)
6074         (show_source_or_disasm_and_command): Use make_visible method, not
6075         tui_make_window.
6076         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
6077         Remove.
6079 2019-08-15  Tom Tromey  <tom@tromey.com>
6081         * tui/tui-wingeneral.h (tui_make_window): Update.
6082         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
6083         parameter.
6084         (tui_gen_win_info::make_visible): Update.
6085         * tui/tui-regs.c (tui_data_window::display_registers_from):
6086         Update.
6087         * tui/tui-layout.c (show_source_disasm_command)
6088         (show_source_or_disasm_and_command): Update.
6089         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
6090         (enum tui_box): Remove.
6091         (struct tui_win_info) <can_box>: New method.
6092         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
6093         method.
6095 2019-08-15  Tom de Vries  <tdevries@suse.de>
6097         * linux-nat-trad.c: Include gdbarch.h.
6099 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
6101         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6102         register sizes.
6104 2019-08-14  Tom Tromey  <tromey@adacore.com>
6106         * darwin-nat.c: Include gdbarch.h.
6107         * darwin-nat-info.c: Include gdbarch.h.
6109 2019-08-13  Tom Tromey  <tom@tromey.com>
6111         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6112         Remove.
6113         * tui/tui-data.c (tui_initialize_static_data): Update.
6115 2019-08-13  Tom Tromey  <tom@tromey.com>
6117         * tui/tui-winsource.h (struct tui_exec_info_window)
6118         <~tui_exec_info_window, maybe_allocate_content, get_content,
6119         m_content>: Remove.
6120         (struct tui_source_window_base) <set_exec_info_content,
6121         show_exec_info_content>: Don't declare.
6122         * tui/tui-winsource.c
6123         (tui_exec_info_window::maybe_allocate_content): Remove.
6124         (tui_source_window_base::update_exec_info): Rename from
6125         set_exec_info_content.
6126         (tui_source_window_base::show_exec_info_content)
6127         (tui_source_window_base::update_exec_info): Remove.
6129 2019-08-13  Tom Tromey  <tom@tromey.com>
6131         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6132         declare.
6133         * tui/tui-winsource.c (tui_update_source_window_as_is)
6134         (tui_update_source_windows_with_addr, tui_erase_source_content):
6135         Update.
6136         (tui_clear_exec_info_content): Remove.
6138 2019-08-13  Tom Tromey  <tom@tromey.com>
6140         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6141         declare.
6142         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6143         call tui_erase_exec_info_content.
6144         (tui_clear_exec_info_content): Rename from
6145         tui_erase_exec_info_content.
6146         (tui_clear_exec_info_content): Delete.
6148 2019-08-13  Tom Tromey  <tom@tromey.com>
6150         * tui/tui-winsource.h (struct tui_source_window_base)
6151         <show_exec_info_content>: Declare.
6152         (tui_show_exec_info_content): Don't declare.
6153         * tui/tui-winsource.c
6154         (tui_source_window_base::show_exec_info_content): Rename from
6155         tui_show_exec_info_content.
6156         (tui_source_window_base::update_exec_info): Update.
6158 2019-08-13  Tom Tromey  <tom@tromey.com>
6160         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6161         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6162         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6163         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6164         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6165         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6166         ... here.
6168 2019-08-13  Tom Tromey  <tom@tromey.com>
6170         * tui/tui-winsource.h (struct tui_source_window_base)
6171         <update_exec_info>: Declare.
6172         (tui_update_exec_info): Don't declare.
6173         * tui/tui-winsource.c (tui_update_source_window_as_is)
6174         (tui_source_window_base::refresh_all)
6175         (tui_update_all_breakpoint_info): Update.
6176         (tui_source_window_base::update_exec_info): Rename from
6177         tui_update_exec_info.
6178         * tui/tui-stack.c (tui_show_frame_info): Update.
6180 2019-08-13  Tom Tromey  <tom@tromey.com>
6182         * tui/tui-winsource.h (struct tui_source_window_base)
6183         <set_exec_info_content>: Declare.
6184         (tui_set_exec_info_content): Don't declare.
6185         * tui/tui-winsource.c
6186         (tui_source_window_base::set_exec_info_content): Rename from
6187         tui_set_exec_info_content.
6188         (tui_update_exec_info): Update.
6190 2019-08-13  Tom Tromey  <tom@tromey.com>
6192         * tui/tui-winsource.h (struct tui_source_window_base)
6193         <show_source_content>: Declare.
6194         (tui_show_source_content): Don't declare.
6195         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6196         (tui_source_window_base::show_source_content): Rename from
6197         tui_show_source_content.
6198         (tui_source_window_base::refresh_all): Update.
6199         * tui/tui-layout.c (show_source_disasm_command)
6200         (show_source_or_disasm_and_command): Update.
6202 2019-08-13  Tom Tromey  <tom@tromey.com>
6204         * tui/tui-winsource.c (tui_erase_source_content)
6205         (tui_show_source_content, tui_source_window_base::refresh_all):
6206         Update.
6207         * tui/tui-wingeneral.h
6208         (tui_check_and_display_highlight_if_needed): Don't declare.
6209         * tui/tui-wingeneral.c
6210         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6211         check_and_display_highlight_if_needed.
6212         * tui/tui-win.c (tui_rehighlight_all)
6213         (tui_win_info::make_visible_with_new_height): Update.
6214         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6215         (tui_data_window::erase_data_content)
6216         (tui_data_window::display_all_data): Update.
6217         * tui/tui-data.h (struct tui_win_info)
6218         <check_and_display_highlight_if_needed>: Declare.
6220 2019-08-13  Tom Tromey  <tom@tromey.com>
6222         * tui/tui-win.c (tui_resize_all): Call
6223         tui_delete_invisible_windows.
6224         * tui/tui-layout.c (show_layout): Call
6225         tui_delete_invisible_windows.
6226         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6227         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6229 2019-08-13  Tom Tromey  <tom@tromey.com>
6231         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6232         tui_add_win_to_layout.
6234 2019-08-13  Tom Tromey  <tom@tromey.com>
6236         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6237         * tui/tui-layout.c (tui_default_win_height): Now static.
6239 2019-08-13  Tom Tromey  <tom@tromey.com>
6241         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6242         single switch.
6243         (show_source_disasm_command, show_source_or_disasm_and_command):
6244         Don't check current layout.
6246 2019-08-13  Tom Tromey  <tom@tromey.com>
6248         * tui/tui-wingeneral.c (make_all_visible): Remove.
6249         (tui_make_all_invisible): Simplify.
6250         * tui/tui-layout.c (tui_make_all_invisible): Move from
6251         tui-wingeneral.c; simplify.
6252         (show_layout): Hoist call to tui_make_all_invisible.
6253         (show_data): Don't call tui_make_all_invisible.
6255 2019-08-13  Tom Tromey  <tom@tromey.com>
6257         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6258         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6260 2019-08-13  Tom Tromey  <tom@tromey.com>
6262         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6263         tui-data.c.
6264         (show_source_disasm_command, show_data)
6265         (show_source_or_disasm_and_command): Don't use
6266         tui_set_current_layout_to.
6267         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6268         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6269         tui-layout.c.
6270         (tui_set_current_layout_to): Remove.
6272 2019-08-13  Tom Tromey  <tom@tromey.com>
6274         * tui/tui-layout.c (tui_set_layout): Update.
6275         * tui/tui-data.h (struct tui_layout_def): Remove.
6276         (tui_layout_def): Don't declare.
6277         * tui/tui-data.c (layout_def): Remove.
6278         (tui_layout_def): Remove.
6280 2019-08-13  Tom Tromey  <tom@tromey.com>
6282         * tui/tui-winsource.h (struct tui_source_window_base)
6283         <clear_detail>: No longer "override".
6284         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6285         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6286         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6287         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6288         Remove.
6289         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6291 2019-08-13  Tom Tromey  <tromey@adacore.com>
6293         * tracepoint.c: Don't include readline.h or history.h.
6295 2019-08-12  Tom Tromey  <tom@tromey.com>
6297         * configure: Rebuild.
6298         * configure.ac: Check for readline 7.
6299         * NEWS: Mention readline 7 requirement.
6300         * README: Update.
6302 2019-08-12  Tom Tromey  <tom@tromey.com>
6304         * mingw-hdep.c (gdb_select): Remove readline hack.
6306 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6308         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6309         when the function fails.
6311 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6313         * s390-tdep.c (s390_type_align): New function.
6314         (s390_gdbarch_init): Set it as type_align gdbarch method.
6316 2019-08-09  Tom de Vries  <tdevries@suse.de>
6318         PR gdb/24591
6319         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6320         pc_low with relocation offset.
6322 2019-08-07  Tom Tromey  <tromey@adacore.com>
6324         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6325         (print_frame_args): Update.
6326         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6327         Update.
6328         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6329         * frame.h (struct frame_arg): Add initializers.
6330         <error>: Now a unique_xmalloc_ptr.
6332 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6334         * NEWS: Expand the Pointer Authentication entry.
6335         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6336         (aarch64_frame_unmask_lr): ... to this.
6337         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6338         Call aarch64_frame_unmask_lr.
6339         * frame.c (struct frame_info): Add "masked" variable.
6340         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6341         (fprint_frame): Check for masked pc.
6342         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6343         declarations.
6344         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6345         * stack.c (print_frame): Check for masked pc.
6347 2019-08-06  Tom Tromey  <tom@tromey.com>
6349         * stabsread.c (patch_block_stabs, read_one_struct_field)
6350         (read_enum_type): Use obstack_strndup.
6351         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6352         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6353         * dwarf2read.c (guess_full_die_structure_name)
6354         (anonymous_struct_prefix): Use obstack_strndup.
6355         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6356         * c-exp.y (yylex): Use obstack_strndup.
6357         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6358         (write_var_or_type): Use obstack_strndup.
6360 2019-08-06  Tom Tromey  <tom@tromey.com>
6362         * symfile.c (reread_symbols): Use obstack_strdup.
6363         * stabsread.c (read_type): Use obstack_strdup.
6364         * gdb_obstack.h (obstack_strdup): New overload.
6365         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6366         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6367         (dwarf2_canonicalize_name): Use obstack_strdup.
6368         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6369         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6370         Use obstack_strdup.
6372 2019-08-06  Tom Tromey  <tom@tromey.com>
6374         * gdb_obstack.h (obstack_strdup): Define.
6375         * gdb_obstack.c (obstack_strdup): Don't define.
6377 2019-08-06  Tom Tromey  <tom@tromey.com>
6379         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6380         obstack_strdup.
6381         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6382         obstack_strdup.
6383         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6384         * stabsread.c (common_block_start): Use obstack_strdup.
6385         * objfiles.c (set_objfile_main_name, objfile): Use
6386         obstack_strdup.
6387         * namespace.c (add_using_directive): Use obstack_strdup.
6388         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6389         * jit.c (finalize_symtab): Use obstack_strdup.
6390         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6391         (guess_partial_die_structure_name, partial_die_info::fixup)
6392         (dwarf2_name): Use obstack_strdup.
6393         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6394         obstack_strdup.
6395         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6396         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6397         obstack_strdup.
6398         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6400 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6402         * unittests/help-doc-selftests.c: New file.
6403         * Makefile.in: Add the new file.
6405 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6407         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6408         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6409         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6410         the trailing '.' is not output, and the first character is uppercased.
6411         (print_help_for_command): Update call to print_doc_line.
6412         (print_doc_of_command): Likewise.
6413         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6414         * cli/cli-option.c (append_indented_doc): Do not append newline.
6415         (build_help_option): Append newline after first appended_indented_doc
6416         only if a second call is done.
6417         (build_help): Append 2 new lines before each option, except the first
6418         one.
6419         * compile/compile.c (_initialize_compile): Add new lines after
6420         %OPTIONS%, when not at the end of the help.
6421         Change help doc or code
6422         producing the help doc to respect the invariants.
6423         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6424         Also removed the new line after 'Options:', as all other commands
6425         do not put an empty line between 'Options:' and the first option.
6426         * printcmd.c (_initialize_printcmd): Likewise.
6427         * stack.c (_initialize_stack): Likewise.
6428         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6429         incorrectly telling COMMAND is optional.
6430         * ada-lang.c (_initialize_ada_language): Change help doc or code
6431         producing the help doc to respect the invariants.
6432         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6433         * breakpoint.c (_initialize_breakpoint): Likewise.
6434         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6435         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6436         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6437         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6438         _initialize_cli_style): Likewise.
6439         * corelow.c (core_target_info): Likewise.
6440         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6441         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6442         * filesystem.c (_initialize_filesystem): Likewise.
6443         * frame.c (_initialize_frame): Likewise.
6444         * gnu-nat.c (add_task_commands): Likewise.
6445         * infcall.c (_initialize_infcall): Likewise.
6446         * infcmd.c (_initialize_infcmd): Likewise.
6447         * interps.c (_initialize_interpreter): Likewise.
6448         * language.c (_initialize_language): Likewise.
6449         * linux-fork.c (_initialize_linux_fork): Likewise.
6450         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6451         * maint.c (_initialize_maint_cmds): Likewise.
6452         * memattr.c (_initialize_mem): Likewise.
6453         * printcmd.c (_initialize_printcmd): Likewise.
6454         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6455         _RegEx): Likewise.
6456         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6457         * record-btrace.c (_initialize_record_btrace): Likewise.
6458         * record-full.c (_initialize_record_full): Likewise.
6459         * record.c (_initialize_record): Likewise.
6460         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6461         * regcache.c (_initialize_regcache): Likewise.
6462         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6463         _initialize_remote): Likewise.
6464         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6465         * serial.c (_initialize_serial): Likewise.
6466         * skip.c (_initialize_step_skip): Likewise.
6467         * source.c (_initialize_source): Likewise.
6468         * stack.c (_initialize_stack): Likewise.
6469         * symfile.c (_initialize_symfile): Likewise.
6470         * symtab.c (_initialize_symtab): Likewise.
6471         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6472         * top.c (init_main): Likewise.
6473         * tracefile-tfile.c (tfile_target_info): Likewise.
6474         * tracepoint.c (_initialize_tracepoint): Likewise.
6475         * tui/tui-win.c (_initialize_tui_win): Likewise.
6476         * utils.c (add_internal_problem_command): Likewise.
6477         * valprint.c (value_print_option_defs): Likewise.
6479 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6481         PR build/24886
6482         * configure.ac: Drop enable-libmcheck support.
6483         * configure, config.in: Rebuild.
6484         * libmcheck.m4: Remove.
6485         * acinclude.m4: Don't include it.
6486         * Makefile.in: Don't distribute it.
6487         * top.c (print_gdb_configuration): Don't mention it.
6489 2019-08-06  Tom Tromey  <tom@tromey.com>
6491         * utils.c (set_output_style): Sometimes pass stream to
6492         emit_style_escape.
6493         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6494         * record-btrace.c (btrace_insn_history): Update.
6495         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6496         method.
6497         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6498         Update initializers.
6499         <m_uiout>: New field.
6500         <m_di>: Move lower.
6501         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6502         Remove "uiout" parameter.
6503         (dump_insns): Update.
6504         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6505         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6507 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6509         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6510         (error_in_psymtab_expansion): Likewise.
6511         (lookup_symbol_via_quick_fns): Likewise.
6512         (basic_lookup_transparent_type_quick): Likewise.
6513         (basic_lookup_transparent_type_1): Likewise.
6515 2019-08-06  Tom Tromey  <tromey@adacore.com>
6517         * source.c (last_source_error): Now bool.
6518         (print_source_lines_base): Make "noprint" bool.  Only open
6519         source file when last_source_visited changes.
6521 2019-08-06  Tom Tromey  <tromey@adacore.com>
6523         * annotate.c (annotate_source_line): Use g_source_cache.
6524         * source-cache.c (source_cache::get_plain_source_lines): Change
6525         parameters.  Populate m_offset_cache.
6526         (source_cache::ensure): New method.
6527         (source_cache::get_line_charpos): New method.
6528         (extract_lines): Move lower.  Change parameters.
6529         (source_cache::get_source_lines): Move lower.
6530         * source-cache.h (class source_cache): Update comment.
6531         <get_line_charpos>: New method.
6532         <get_source_lines>: Update comment.
6533         <clear>: Clear m_offset_cache.
6534         <get_plain_source_lines>: Change parameters.
6535         <ensure>: New method
6536         <m_offset_cache>: New member.
6537         * source.c (forget_cached_source_info_for_objfile): Update.
6538         (info_source_command): Use g_source_cache.
6539         (find_source_lines, open_source_file_with_line_charpos): Remove.
6540         (print_source_lines_base, search_command_helper): Use g_source_cache.
6541         * source.h (open_source_file_with_line_charpos): Don't declare.
6542         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6543         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6544         Use g_source_cache.
6546 2019-08-06  Tom Tromey  <tromey@adacore.com>
6548         * source-cache.c (source_cache::get_plain_source_lines):
6549         Remove "first_line" and "last_line" parameters.
6550         (source_cache::get_source_lines): Cache plain text.
6551         * source-cache.h (class source_cache)
6552         <get_plain_source_lines>: Update.
6554 2019-08-06  Tom Tromey  <tromey@adacore.com>
6556         * source-cache.c (extract_lines): No longer a method.
6557         Changed type of parameter.  Include final newline.
6558         (selftests::extract_lines_test): New function.
6559         (_initialize_source_cache): Likewise.
6560         * source-cache.h (class source_cache)
6561         <extract_lines>: Don't declare.
6563 2019-08-06  Tom Tromey  <tromey@adacore.com>
6565         * breakpoint.c (init_breakpoint_sal): Update.
6566         (breakpoint): Update.
6567         * breakpoint.h (struct breakpoint) <filter>: Now a
6568         unique_xmalloc_ptr.
6570 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6572         * NEWS: Mention dictionary access on blocks.
6573         * python/py-block.c (blpy_getitem): New function.
6574         (block_object_as_mapping): New struct.
6575         (block_object_type): Use new struct for tp_as_mapping field.
6577 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6579         * objfiles.h (objfile): Add a comment describing partial symbols.
6581 2019-08-05  Tom Tromey  <tromey@adacore.com>
6583         * compile/compile.c (_initialize_compile): Use _(), not N_().
6584         * thread.c (_initialize_thread): Use _(), not N_().
6585         * stack.c (_initialize_stack): Use _(), not N_().
6586         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6588 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6590         * dwarf2read.c (struct dw2_symtab_iterator):
6591         <want_specific_block>: Remove.
6592         <block_index>: Change type to gdb::optional.
6593         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6594         change type of BLOCK_INDEX parameter to gdb::optional.
6595         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6596         (dw2_lookup_symbol): Don't pass argument for
6597         WANT_SPECIFIC_BLOCK.
6598         (dw2_expand_symtabs_for_function): Don't pass argument for
6599         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6600         (class dw2_debug_names_iterator)
6601         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6602         parameter, change BLOCK_INDEX type to gdb::optional.
6603         <m_want_specific_block>: Remove.
6604         <m_block_index>: Change type to gdb::optional.
6605         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6606         gdb::optional.  Re-write in function of gdb::optional.
6607         (dw2_debug_names_lookup_symbol): Don't pass argument for
6608         WANT_SPECIFIC_BLOCK.
6609         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6610         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6611         BLOCK_INDEX.
6613 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6615         * NEWS: Mention changes to "info sources" command.
6617 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6619         * symtab.c (filename_partial_match_opts): New struct type.
6620         (struct output_source_filename_data): New members
6621         regexp, c_regexp, partial_match.
6622         (output_source_filename): Use new members to decide to print file.
6623         (info_sources_option_defs): New variable.
6624         (make_info_sources_options_def_group, print_info_sources_header,
6625         info_sources_command_completer):
6626         New functions.
6627         (info_sources_command): Read new optional arguments.
6628         (_initialize_symtab): Update info sources help.
6630 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6632         * ada-lang.c (exception_support_info_v0): Renamed from...
6633         (default_exception_support_info): ... this.  Create new
6634         definition for v1.
6635         (ada_has_this_exception_support): Look up catch_handlers_sym.
6636         (ada_exception_support_info_sniffer): Try v0 after default.
6638 2019-08-01  Tom Tromey  <tromey@adacore.com>
6640         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6641         gdbarch.h.
6643 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6645         * s12z-tdep.c: Fix include path for s12z-opc.h.
6647 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6649         * NEWS: Require GNU make 3.82.
6651 2019-07-16  Tom Tromey  <tom@tromey.com>
6653         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6654         declare.
6656 2019-07-30  Tom Tromey  <tromey@adacore.com>
6658         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6660 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6662         * printcmd.c (print_address_symbolic): Print negative offsets.
6663         (build_address_symbolic): Force signed arithmetic when computing
6664         offset.
6666 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6668         PR/24474: Add a function to lookup static variables.
6669         * NEWS: Mention this new function.
6670         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6671         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6672         * python/python.c (python_GdbMethods): Add new function.
6674 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6676         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6677         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6678         (objfpy_lookup_static_symbol): New function.
6679         (objfile_object_methods): Add new functions.
6681 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6683         * NEWS: Mention 'set|show print frame-info'.  Mention new
6684         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6685         backtrace argument.  Mention that python frame filtering code
6686         is now consistent with what 'backtrace' command prints.
6688 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6690         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6691         comments.
6692         (print_frame_info_auto, print_frame_info_source_line,
6693         print_frame_info_location, print_frame_info_source_and_location,
6694         print_frame_info_location_and_address, print_frame_info_short_location):
6695         New declarations.
6696         (struct frame_print_options): New member print_frame_info.
6697         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6698         * stack.h (get_user_print_what_frame_info): New declaration.
6699         (frame_show_address): New declaration.
6700         * stack.c (print_frame_arguments_choices): New value 'presence'.
6701         (print_frame_info_auto, print_frame_info_source_line,
6702         print_frame_info_location, print_frame_info_source_and_location,
6703         print_frame_info_location_and_address, print_frame_info_short_location,
6704         print_frame_info_choices, print_frame_info_print_what): New definitions.
6705         (print_frame_args): Only print dots for args if print frame-arguments
6706         is 'presence'.
6707         (frame_print_option_defs): New element for "frame-info".
6708         (get_user_print_what_frame_info): New function.
6709         (frame_show_address): Make non static.  Move comment to stack.h.
6710         (print_frame_info_to_print_what): New function.
6711         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6712         to decide what to print.
6713         (backtrace_command_1): Handle the new print_frame_arguments_presence
6714         value.
6715         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6716         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6717         (py_print_frame): In non-mi mode, use LOCATION as default for
6718         print_what, similarly to frame information printed directly by
6719         backtrace command. Handle frame-info user option in non MI mode.
6721 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6723         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6724         Add case for debugging 32-bit target on 64-bit host.  Revise
6725         comment.
6727 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6729         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6730         instead of find_function_entry_range_from_pc.
6732 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6734         * stack.c (find_frame_funname): Remove code which preferred
6735         minsym over symtab sym in "certain pathological cases".
6737         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6738         parameter.  Change type of "do_demangle" to bool.
6739         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6740         Pass suitable "prefer_sym_over_minsym" flag to
6741         build_address_symbolic().  Don't output "+" for negative offsets.
6742         * printcmd.c (print_address_symbolic): Update invocation of
6743         build_address_symbolic to include a "prefer_sym_over_minsym"
6744         flag.
6745         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6746         Restrict cases in which use of minimal symbol is preferred to that
6747         of a found symbol.  Update comments.
6749         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6750         for entry pc when entry pc is out of range for that FDE.
6752 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6754         PR gdb/24839:
6755         * obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6756         type.
6758 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6760         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6761         this function's Python signature.
6764 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6766         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6767         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6768         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6769         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6770         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6773 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6775         * h8300-tdep.c (h8300_register_name_common): New.
6776         h8300_register_name): Use h8300_register_name_common.
6777         (h8300s_register_name): Likewise.
6778         (h8300sx_register_name): Likewise.
6779         (h8300h_register_nam): New.
6780         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6783 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6785         * arm-tdep.c (arm_skip_cmse_entry): New function.
6786         (arm_is_sgstubs_section): New function.
6787         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6789 2019-07-22  Tom Tromey  <tom@tromey.com>
6791         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6792         Don't self-assign.
6794 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6796         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6797         type_print.
6799 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6801         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6802         so that GDB doesn't match any msymbols when searching in the
6803         TYPES_DOMAIN.
6804         (print_symbol_info): Print using typedef_print or type_print based
6805         on the type of the symbol.  Add updated FIXME comment moved from...
6806         (_initialize_symtab): ... move and update FIXME comment to above.
6808 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6810         * NEWS: Mention adding -q option to "info types".
6811         * symtab.c (struct info_types_options): New struct.
6812         (info_types_options_defs): New variable.
6813         (make_info_types_options_def_group): New function.
6814         (info_types_command): Use gdb::option framework to parse options.
6815         (info_types_command_completer): New function.
6816         (_initialize_symtab): Extend the help text on "info types" and
6817         register command completer.
6819 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6821         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6822         (lookup_symbol_in_objfile): Change int to block_enum and add a
6823         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6825 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6827         * MAINTAINERS (Write After Approval): Add self.
6829 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6831         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6832         instruction to the dummy code region.
6834 2019-07-19  Tom Tromey  <tromey@adacore.com>
6836         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6837         (ARGSUSED, PARAMS, __func__): Remove rules.
6839 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6841         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6842         * features/arm/arm-with-iwmmxt.c: Remove.
6843         * features/arm/arm-with-iwmmxt.xml: Remove.
6844         * features/arm/arm-with-m-fpa-layout.c: Remove.
6845         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6846         * features/arm/arm-with-m-vfp-d16.c: Remove.
6847         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6848         * features/arm/arm-with-m.c: Remove.
6849         * features/arm/arm-with-m.xml: Remove.
6850         * features/arm/arm-with-neon.c: Remove.
6851         * features/arm/arm-with-neon.xml: Remove.
6852         * features/arm/arm-with-vfpv2.c: Remove.
6853         * features/arm/arm-with-vfpv2.xml: Remove.
6854         * features/arm/arm-with-vfpv3.c: Remove.
6855         * features/arm/arm-with-vfpv3.xml: Remove.
6857 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6859         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6861 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6863         * arch/aarch32.c (aarch32_create_target_description): Create
6864         target descriptions using features.
6865         * arch/arm.c (arm_create_target_description)
6866         (arm_create_mprofile_target_description): Likewise.
6867         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6869 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6871         * Makefile.in: Add new files.
6872         * aarch32-tdep.c: New file.
6873         * aarch32-tdep.h: New file.
6874         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6875         Call aarch32_read_description.
6876         * arch/aarch32.c: New file.
6877         * arch/aarch32.h: New file.
6878         * arch/arm.c (arm_create_target_description)
6879         (arm_create_mprofile_target_description): New function.
6880         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6881         (arm_create_target_description)
6882         (arm_create_mprofile_target_description): New declaration.
6883         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6884         read_description functions.
6885         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6886         Likewise.
6887         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6888         * arm-tdep.c (tdesc_arm_list): New variable.
6889         (arm_register_g_packet_guesses): Call create description functions.
6890         (arm_read_description) (arm_read_mprofile_description): New
6891         function.
6892         * arm-tdep.h (arm_read_description)
6893         (arm_read_mprofile_description): Add declaration.
6894         * configure.tgt: Add new files.
6896 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6898         * top.c (new_ui_command): Open specified terminal just once.
6900 2019-07-18  Tom Tromey  <tromey@adacore.com>
6902         * symtab.c (main_name): Constify return type.
6903         * symfile.c (set_initial_language): Update.
6904         * symtab.h (main_name): Constify return type.
6906 2019-07-17  Tom Tromey  <tom@tromey.com>
6908         * tui/tui-winsource.c (tui_update_source_window)
6909         (tui_update_source_window_as_is)
6910         (tui_update_source_windows_with_line): Remove return.
6911         * tui/tui-disasm.c (tui_show_disassem)
6912         (tui_show_disassem_and_update_source): Remove return.
6913         * tui/tui.c (tui_reset): Remove return.
6914         * tui/tui-wingeneral.c
6915         (tui_check_and_display_highlight_if_needed): Remove return.
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6919         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6921 2019-07-17  Tom Tromey  <tom@tromey.com>
6923         * tui/tui-winsource.h (struct tui_exec_info_window)
6924         (struct tui_source_window_base): Move from tui-data.h.
6925         * tui/tui-winsource.c: Move many method definitions from
6926         elsewhere.  Remove "structuring" comments.
6927         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6928         (tui_source_window_base::refresh_window): Move to
6929         tui-winsource.c.
6930         * tui/tui-win.c (tui_source_window_base::refresh_all)
6931         (tui_source_window_base::update_tab_width)
6932         (tui_source_window_base::set_new_height)
6933         (tui_source_window_base::do_make_visible_with_new_height): Move to
6934         tui-winsource.c.
6935         * tui/tui-source.h: Update.
6936         * tui/tui-source.c (tui_source_window_base::reset): Move to
6937         tui-winsource.c.
6938         * tui/tui-disasm.h: Update.
6939         * tui/tui-data.h (struct tui_exec_info_window): Move to
6940         tui-winsource.h.
6941         (struct tui_source_window_base): Likewise.
6942         * tui/tui-data.c (tui_source_window_base::clear_detail)
6943         (tui_source_window_base, ~tui_source_window_base): Move to
6944         tui-winsource.c.
6946 2019-07-17  Tom Tromey  <tom@tromey.com>
6948         * tui/tui-win.c (tui_resize_all)
6949         (tui_source_window_base::update_tab_width)
6950         (tui_adjust_win_heights): Update.
6951         (tui_win_info::make_invisible_and_set_new_height): Rename from
6952         make_invisible_and_set_new_height.
6953         * tui/tui-data.h (struct tui_win_info)
6954         <make_invisible_and_set_new_height>: New method.
6956 2019-07-17  Tom Tromey  <tom@tromey.com>
6958         * tui/tui.c: Update.
6959         * tui/tui-source.h (struct tui_source_window): Move from
6960         tui-data.h.
6961         * tui/tui-layout.c: Update.
6962         * tui/tui-disasm.c: Update.
6963         * tui/tui-data.h (struct tui_source_window): Move to
6964         tui-source.h.
6966 2019-07-17  Tom Tromey  <tom@tromey.com>
6968         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6969         tui-data.h.
6970         * tui/tui-data.h (struct tui_disasm_window): Move to
6971         tui-disasm.h.
6973 2019-07-17  Tom Tromey  <tom@tromey.com>
6975         * tui/tui-regs.h (struct tui_data_item_window): Move from
6976         tui-data.h.
6977         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6978         * tui/tui-data.h (struct tui_data_item_window): Move to
6979         tui-regs.h.
6980         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6982 2019-07-17  Tom Tromey  <tom@tromey.com>
6984         * tui/tui.c: Update.
6985         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6986         (tui_cmd_window::max_height): Move to tui-command.c.
6987         * tui/tui-layout.c: Update.
6988         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6989         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6990         tui-command.c.
6991         * tui/tui-command.h (struct tui_cmd_window): Move from
6992         tui-data.h.
6993         * tui/tui-command.c: Remove "structuring" comments.
6994         (tui_cmd_window::clear_detail)
6995         (tui_cmd_window::do_make_visible_with_new_height)
6996         (tui_cmd_window::max_height): Move from elsewhere.
6998 2019-07-17  Tom Tromey  <tom@tromey.com>
7000         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
7001         Now static.
7002         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
7003         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
7005 2019-07-17  Tom Tromey  <tom@tromey.com>
7007         * tui/tui.c: Update.
7008         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
7009         tui-regs.c.
7010         * tui/tui-windata.h: Remove file.
7011         * tui/tui-windata.c: Remove file.
7012         * tui/tui-win.c (tui_data_window::set_new_height)
7013         (tui_data_window::do_make_visible_with_new_height): Move to
7014         tui-regs.c.
7015         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
7016         * tui/tui-regs.c: Remove "structuring" comments.
7017         (tui_data_window::first_data_item_displayed)
7018         (tui_data_window::delete_data_content_windows)
7019         (tui_data_window::erase_data_content)
7020         (tui_data_window::display_all_data)
7021         (tui_data_window::refresh_all)
7022         (tui_data_window::do_scroll_vertical)
7023         (tui_data_window::clear_detail, tui_data_window::set_new_height)
7024         (tui_data_window::do_make_visible_with_new_height)
7025         (tui_data_window::refresh_window): Move from elsewhere.
7026         (_initialize_tui_regs): Move to end of file.
7027         * tui/tui-layout.c: Update.
7028         * tui/tui-hooks.c: Update.
7029         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
7030         * tui/tui-data.c (tui_data_window::clear_detail): Move to
7031         tui-regs.c.
7032         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
7034 2019-07-17  Tom Tromey  <tom@tromey.com>
7036         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
7037         seen.
7039 2019-07-17  Tom Tromey  <tom@tromey.com>
7041         * tui/tui-win.c (tui_source_window_base::set_new_height)
7042         (tui_source_window_base::do_make_visible_with_new_height): Use
7043         m_has_locator field directly.
7044         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
7045         method.
7046         (struct tui_source_window_base) <has_locator>: Likewise.
7048 2019-07-17  Tom Tromey  <tom@tromey.com>
7050         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
7051         Don't declare.
7052         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
7053         Remove.
7054         * tui/tui-win.c (tui_source_window_base::set_new_height)
7055         (tui_source_window_base::set_new_height)
7056         (make_invisible_and_set_new_height)
7057         (tui_source_window_base::do_make_visible_with_new_height)
7058         (tui_source_window_base::do_make_visible_with_new_height):
7059         Update.
7060         * tui/tui-layout.c (show_source_disasm_command, show_data)
7061         (show_source_or_disasm_and_command): Update.
7062         * tui/tui-layout.c (show_layout): Update.
7064 2019-07-17  Tom Tromey  <tom@tromey.com>
7066         * tui/tui-layout.c (make_data_window): Remove.
7067         (show_data): Unify creation and re-initialization cases.
7069 2019-07-17  Tom Tromey  <tom@tromey.com>
7071         * tui/tui-layout.c (make_source_window, make_disasm_window):
7072         Remove.
7073         (show_data): Unify creation and re-initialization cases.
7075 2019-07-17  Tom Tromey  <tom@tromey.com>
7077         * tui/tui-layout.c (make_command_window): Remove.
7078         (show_source_disasm_command, show_source_or_disasm_and_command):
7079         Unify creation and re-initialization cases.
7081 2019-07-17  Tom Tromey  <tom@tromey.com>
7083         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
7084         creation and re-initialization cases.
7086 2019-07-17  Tom Tromey  <tom@tromey.com>
7088         * tui/tui-regs.c (tui_get_register): Return void.
7090 2019-07-17  Tom Tromey  <tom@tromey.com>
7092         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
7093         Simplify.
7095 2019-07-17  Tom Tromey  <tom@tromey.com>
7097         * tui/tui-layout.c (show_source_disasm_command): Simplify window
7098         resetting.
7100 2019-07-17  Tom Tromey  <tom@tromey.com>
7102         * tui/tui.h (tui_set_layout_by_name): Don't declare.
7103         * tui/tui-regs.c (tui_reg_layout): New function.
7104         (tui_show_registers, tui_reg_command): Use it.
7105         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7106         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
7107         parameters.
7108         (tui_layout_command): Remove.
7110 2019-07-17  Tom Tromey  <tom@tromey.com>
7112         * tui/tui-layout.h (tui/tui-layout): Return void.
7113         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
7115 2019-07-17  Tom Tromey  <tom@tromey.com>
7117         * tui/tui-layout.c (show_source_disasm_command, show_data):
7118         Update.
7119         (reset_locator): Remove.
7120         (show_source_or_disasm_and_command): Update.
7122 2019-07-17  Tom Tromey  <tom@tromey.com>
7124         * tui/tui-source.c (tui_source_window_base::reset): Remove
7125         win_type parameter.
7126         * tui/tui-layout.c (make_command_window, make_source_window)
7127         (make_disasm_window, make_data_window)
7128         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7129         (reset_locator, show_source_or_disasm_and_command): Update.
7130         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7131         win_type parameter.
7132         (struct tui_source_window_base) <reset>: Likewise.
7134 2019-07-17  Tom Tromey  <tom@tromey.com>
7136         * tui/tui-layout.c (show_source_disasm_command): Use
7137         reset_locator.
7138         (reset_locator): New function.
7139         (init_and_make_win): Remove.
7140         (show_source_or_disasm_and_command): Use reset_locator.
7142 2019-07-17  Tom Tromey  <tom@tromey.com>
7144         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7145         condition.
7146         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7147         Remove condition.
7148         * tui/tui-source.c (tui_source_window_base::reset): New method.
7149         * tui/tui-layout.c (make_command_window): Don't call
7150         init_and_make_win.
7151         (make_source_window, make_disasm_window): Don't call
7152         make_source_or_disasm_window.
7153         (make_data_window): Don't call init_and_make_win.  Change calling
7154         convention.
7155         (show_source_disasm_command, show_data): Simplify.
7156         (make_source_or_disasm_window): Remove.
7157         (show_source_or_disasm_and_command): Simplify.
7158         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7159         (struct tui_source_window_base) <reset>: Likewise.
7160         <execution_info>: Remove initializer.
7161         * tui/tui-data.c (tui_source_window_base): Initialize
7162         execution_info.
7164 2019-07-17  Tom Tromey  <tom@tromey.com>
7166         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7167         variable.
7169 2019-07-17  Tom Tromey  <tom@tromey.com>
7171         * tui/tui.c (tui_rl_other_window): Update.
7172         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7173         superclass method first.  Always iterate over regs_content.
7174         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7175         method.
7176         * tui/tui-win.c (tui_set_focus_command): Update.
7178 2019-07-17  Tom Tromey  <tom@tromey.com>
7180         * tui/tui-win.c (tui_set_focus_command): Rename from
7181         tui_set_focus.  Call tui_enable.
7182         (tui_set_focus_command): Remove.
7184 2019-07-17  Tom Tromey  <tom@tromey.com>
7186         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7187         refresh_window.
7188         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7189         touchwin.
7190         (tui_data_window::refresh_window): Call refresh_window on data
7191         items.  Always call superclass refresh_window.
7192         (tui_win_info::refresh): Remove.
7193         (tui_source_window_base::refresh_window): Update.
7194         (tui_refresh_all): Update.
7195         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7196         refresh_window.
7197         (show_source_or_disasm_and_command): Likewise.
7198         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7199         (struct tui_source_window_base) <refresh>: Likewise.
7201 2019-07-17  Tom Tromey  <tom@tromey.com>
7203         * tui/tui-winsource.c (tui_clear_source_content)
7204         (tui_show_source_content): Update.
7205         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7206         whether content is empty.
7207         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7208         Remove.
7210 2019-07-17  Tom Tromey  <tom@tromey.com>
7212         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7213         window's contents.
7214         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7215         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7217 2019-07-17  Tom Tromey  <tom@tromey.com>
7219         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7220         (struct tui_data_item_window): Update.
7222 2019-07-17  Tom Tromey  <tom@tromey.com>
7224         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7225         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7226         defines.
7228 2019-07-17  Tom Tromey  <tom@tromey.com>
7230         * tui/tui-winsource.h (tui_erase_source_content)
7231         (tui_clear_source_content): Remove "display_prompt" parameter.
7232         * tui/tui-winsource.c (tui_update_source_window_as_is)
7233         (tui_update_source_windows_with_addr): Update.
7234         (tui_clear_source_content): Remove "display_prompt" parameter.
7235         (tui_erase_source_content): Likewise.  Simplify.
7236         (tui_show_source_content): Update.
7237         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7238         * tui/tui-stack.c (tui_show_frame_info): Update.
7239         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7240         Remove defines.
7242 2019-07-17  Tom Tromey  <tom@tromey.com>
7244         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7245         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7246         parameter.
7247         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7248         parameter.
7250 2019-07-17  Tom Tromey  <tom@tromey.com>
7252         * tui/tui-winsource.c (tui_clear_source_content)
7253         (tui_show_source_content, tui_show_exec_info_content)
7254         (tui_clear_exec_info_content): Update.
7255         * tui/tui-stack.c (tui_show_locator_content): Update.
7256         (tui_show_frame_info): Update.
7257         * tui/tui-source.h (tui_source_window): Don't declare.
7258         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7259         from tui_source_is_displayed.
7260         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7261         Remove field.
7262         (struct tui_source_window_base) <content_in_use>: New field.  Now
7263         bool.
7264         (struct tui_source_window) <showing_source_p>: New method.
7265         (TUI_SRC_WIN): Change cast.
7266         * tui/tui-data.c (tui_initialize_static_data): Update.
7268 2019-07-17  Tom Tromey  <tom@tromey.com>
7270         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7271         location_matches_p.
7272         * tui/tui-source.c (tui_source_window::location_matches_p): New
7273         method.
7274         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7275         method.
7276         * tui/tui-data.h (struct tui_source_window_base)
7277         <location_matches_p>: New method.
7278         (struct tui_source_window, struct tui_disasm_window)
7279         <location_matches_p>: Likewise.
7281 2019-07-17  Tom Tromey  <tom@tromey.com>
7283         * tui/tui-win.c (tui_set_win_height_command): Rename from
7284         tui_set_win_height.
7285         (tui_set_win_height_command): Remove.
7287 2019-07-17  Tom Tromey  <tom@tromey.com>
7289         * tui/tui-source.c (tui_source_window): New constructor.  Add
7290         observer.
7291         (~tui_source_window): New destructor.
7292         (tui_source_window::style_changed): New method.
7293         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7294         (tui_attach_detach_observers): Update.
7295         * tui/tui-data.h (struct tui_source_window): Make constructor not
7296         inline.  Add destructor.
7297         (struct tui_source_window) <style_changed>: New method.
7298         <m_observable>: New member.
7300 2019-07-17  Tom Tromey  <tom@tromey.com>
7302         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7303         * tui/tui-win.c (tui_resize_all): Fix typo.
7305 2019-07-17  Tom Tromey  <tom@tromey.com>
7307         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7308         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7309         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7310         * tui/tui-win.c (window_name_completer): Use foreach.
7311         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7312         (update_tab_width): Likewise.
7313         * tui/tui-layout.c (show_layout): Update.
7314         * tui/tui-data.h (class tui_window_iterator): New.
7315         (struct all_tui_windows): New.
7316         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7318 2019-07-17  Tom Tromey  <tom@tromey.com>
7320         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7321         parameter.  Don't reference globals.
7322         (tui_reg_command): Update.
7324 2019-07-17  Tom Tromey  <tom@tromey.com>
7326         * tui/tui-regs.c (tui_show_registers): Simplify.
7328 2019-07-17  Tom Tromey  <tom@tromey.com>
7330         * tui/tui-regs.c (tui_show_registers): Update.
7331         (tui_show_register_group): Add win_info parameter.
7333 2019-07-17  Tom Tromey  <tom@tromey.com>
7335         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7336         Rename from tui_display_reg_element_at_line.
7337         (tui_data_window::display_registers_from_line): Update.
7338         * tui/tui-data.h (struct tui_data_window)
7339         <display_reg_element_at_line>: New method.
7341 2019-07-17  Tom Tromey  <tom@tromey.com>
7343         * tui/tui-regs.h (tui_display_registers_from)
7344         (tui_display_registers_from_line): Don't declare.
7345         * tui/tui-windata.c (tui_data_window::display_all_data)
7346         (tui_data_window::refresh_all)
7347         (tui_data_window::do_scroll_vertical): Update.
7348         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7349         from tui_display_registers_from.
7350         (tui_display_reg_element_at_line): Update.
7351         (tui_data_window::display_registers_from_line): Rename from
7352         tui_display_registers_from_line.
7353         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7354         display_registers_from_line>: New methods.
7356 2019-07-17  Tom Tromey  <tom@tromey.com>
7358         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7359         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7360         from tui_erase_data_content.
7361         (tui_data_window::display_all_data)
7362         (tui_data_window::refresh_all)
7363         (tui_data_window::do_scroll_vertical): Update.
7364         * tui/tui-regs.c (tui_show_registers): Update.
7365         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7366         New method.
7368 2019-07-17  Tom Tromey  <tom@tromey.com>
7370         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7371         declare.
7372         * tui/tui-windata.c
7373         (tui_data_window::delete_data_content_windows): Rename from
7374         tui_delete_data_content_windows.
7375         (tui_data_window::display_all_data)
7376         (tui_data_window::do_scroll_vertical): Update.
7377         * tui/tui-data.h (struct tui_data_window)
7378         <delete_data_content_windows>: New method.
7380 2019-07-17  Tom Tromey  <tom@tromey.com>
7382         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7383         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7385 2019-07-17  Tom Tromey  <tom@tromey.com>
7387         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7388         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7389         from tui_display_all_data.
7390         * tui/tui-win.c
7391         (tui_data_window::do_make_visible_with_new_height): Update.
7392         * tui/tui-regs.c (tui_show_registers): Update.
7393         * tui/tui-layout.c (tui_set_layout): Update.
7394         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7395         method.
7397 2019-07-17  Tom Tromey  <tom@tromey.com>
7399         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7400         * tui/tui-windata.c (tui_display_data_from): Remove.
7401         (tui_data_window::refresh_all): Update.
7403 2019-07-17  Tom Tromey  <tom@tromey.com>
7405         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7406         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7407         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7408         tui_display_registers_from_line.
7409         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7410         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7411         "force_display" parameter.
7413 2019-07-17  Tom Tromey  <tom@tromey.com>
7415         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7416         declare.
7417         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7418         Rename from tui_first_reg_element_no_inline.
7419         (tui_display_reg_element_at_line)
7420         (tui_display_registers_from_line): Update.
7421         * tui/tui-data.h (struct tui_data_window)
7422         <first_reg_element_no_inline>: New method.
7424 2019-07-17  Tom Tromey  <tom@tromey.com>
7426         * tui/tui-windata.c (tui_display_data_from)
7427         (tui_data_window::do_scroll_vertical): Update.
7428         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7429         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7430         Rename from tui_line_from_reg_element_no.
7431         (tui_display_registers_from_line): Update.
7432         * tui/tui-data.h (struct tui_data_window)
7433         <line_from_reg_element_no>: New method.
7435 2019-07-17  Tom Tromey  <tom@tromey.com>
7437         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7438         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7439         tui_last_regs_line_no.
7440         (tui_display_reg_element_at_line)
7441         (tui_display_registers_from_line): Update.
7442         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7443         method.
7445 2019-07-17  Tom Tromey  <tom@tromey.com>
7447         PR tui/24722:
7448         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7449         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7450         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7451         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7452         (tui_update_breakpoint_info): Likewise.
7453         * tui/tui-hooks.c (tui_event_create_breakpoint)
7454         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7455         Update.
7457 2019-07-17  Tom Tromey  <tom@tromey.com>
7459         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7461 2019-07-17  Tom Tromey  <tom@tromey.com>
7463         * tui/tui-winsource.c (tui_update_source_window_as_is)
7464         (tui_update_source_windows_with_addr): Update.
7465         * tui/tui-source.h (tui_set_source_content)
7466         (tui_show_symtab_source): Add "win_info" parameter.
7467         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7468         parameter.
7469         (tui_show_symtab_source): Likewise.
7471 2019-07-17  Tom Tromey  <tom@tromey.com>
7473         * tui/tui-wingeneral.c
7474         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7476 2019-07-17  Tom Tromey  <tom@tromey.com>
7478         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7479         (struct tui_cmd_window) <can_scroll>: New method.
7480         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7481         method.
7483 2019-07-17  Tom Tromey  <tromey@adacore.com>
7485         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7486         do_field_signed>: Rename.  Change type of "value".
7487         * ui-out.c (ui_out::field_signed): Rename from field_int.
7488         Change type of "value".
7489         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7490         type of "value".
7491         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7492         do_field_int.  Change type of "value".
7493         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7494         do_field_int.  Change type of "value".
7495         * tracepoint.c (trace_status_mi, tfind_1)
7496         (print_one_static_tracepoint_marker): Update.
7497         * thread.c (print_thread_info_1, print_selected_thread_frame):
7498         Update.
7499         * stack.c (print_frame, print_frame_info): Update.
7500         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7501         Update.
7502         * source.c (print_source_lines_base): Update.
7503         * skip.c (info_skip_command): Update.
7504         * record-btrace.c (btrace_ui_out_decode_error)
7505         (btrace_call_history_src_line): Update.
7506         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7507         Update.
7508         * progspace.c (print_program_space): Update.
7509         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7510         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7511         do_field_int.  Change type of "value".
7512         * mi/mi-out.c (mi_ui_out::do_table_begin)
7513         (mi_ui_out::do_table_header): Update.
7514         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7515         type of "value".
7516         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7517         (mi_cmd_data_list_changed_registers, output_register)
7518         (mi_cmd_data_read_memory, mi_load_progress)
7519         (mi_cmd_trace_frame_collected): Update.
7520         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7521         Update.
7522         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7523         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7524         (mi_cmd_var_list_children, varobj_update_one): Update.
7525         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7526         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7527         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7528         * inferior.c (print_inferior): Update.
7529         * gdb_bfd.c (print_one_bfd): Update.
7530         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7531         Update.
7532         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7533         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7534         do_field_int.  Change type of "value".
7535         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7536         do_field_int.  Change type of "value".
7537         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7538         (print_one_breakpoint_location, print_it_catch_fork)
7539         (print_one_catch_fork, print_it_catch_vfork)
7540         (print_one_catch_vfork, print_it_catch_solib)
7541         (print_it_catch_exec, print_it_ranged_breakpoint)
7542         (print_mention_watchpoint, print_mention_masked_watchpoint)
7543         (bkpt_print_it, update_static_tracepoint): Update.
7544         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7545         * break-catch-syscall.c (print_it_catch_syscall): Update.
7546         * ada-tasks.c (print_ada_task_info): Update.
7547         * ada-lang.c (print_it_exception, print_mention_exception):
7548         Update.
7550 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7552         PR breakpoints/24541
7553         * gdbarch.c: Regenerate.
7554         * gdbarch.h: Regenerate.
7555         * gdbarch.sh: Adjust return type and parameter types for
7556         'stap_adjust_register'.
7557         (i386_stap_adjust_register): Adjust signature and return new
7558         register name.
7559         * stap-probe.c (stap_parse_register_operand): Adjust use of
7560         'gdbarch_stap_adjust_register'.
7562 2019-07-17  Tom Tromey  <tromey@adacore.com>
7564         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7565         declare VEC.
7566         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7567         std::vector.
7568         (struct s390_process_info): Add initializers.
7569         (s390_add_process): Use new.
7570         (s390_linux_nat_target::low_forget_process): Use delete.
7571         (s390_linux_nat_target::low_new_fork)
7572         (s390_linux_nat_target::stopped_by_watchpoint)
7573         (s390_linux_nat_target::low_prepare_to_resume)
7574         (s390_linux_nat_target::insert_watchpoint)
7575         (s390_linux_nat_target::insert_hw_breakpoint)
7576         (s390_linux_nat_target::remove_watchpoint)
7577         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7579 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7581         * aarch64-fbsd-nat.c: Include regcache.h.
7582         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7583         argument.
7584         (aarch64_fbsd_nat_target::fetch_registers)
7585         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7586         variable.
7587         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7589 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7591         * fbsd-nat.c: Include gdbarch.h.
7593 2019-07-15  Tom Tromey  <tromey@adacore.com>
7595         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7597 2019-07-15  Tom Tromey  <tromey@adacore.com>
7599         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7600         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7601         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7602         * cli-out.c (cli_ui_out::do_field_int): New method.
7603         * ui-out.c (ui_out::field_unsigned): New method.
7604         * symfile.c (generic_load): Use field_unsigned.
7605         (print_transfer_performance): Likewise.
7606         * record-btrace.c (ui_out_field_uint): Remove.
7607         (btrace_call_history_insn_range, btrace_call_history): Use
7608         field_unsigned.
7609         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7610         field_unsigned.
7611         * ui-out.h (class ui_out) <field_unsigned>: New method.
7612         <do_field_unsigned>: Likewise.
7614 2019-07-15  Tom Tromey  <tromey@adacore.com>
7616         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7617         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7618         * target.c (flash_erase_command): Use field_string.
7619         * infrun.c (print_signal_received_reason): Use field_string.
7620         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7621         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7622         field_string.
7623         * ada-tasks.c (print_ada_task_info): Use field_string.
7625 2019-07-15  Tom Tromey  <tromey@adacore.com>
7627         * target.c (flash_erase_command): Use field_core_addr.
7628         * symfile.c (generic_load): Use field_core_addr.
7629         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7630         Use field_core_addr.
7631         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7632         field_core_addr.
7634 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7636         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7637         value if its desired type is smaller than a CORE_ADDR and signed.
7639 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7641         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7642         of changes to field names, and use new is_reference field to
7643         decide if a property is a reference or not.
7644         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7645         field.
7646         (struct dwarf2_property_baton): Update header comment, rename
7647         'referenced_type' to 'property_type' and update comments.
7648         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7649         default property type, store in property baton, update to take
7650         accound of renamed field.
7651         (read_func_scope): Update call to attr_to_dynamic_prop.
7652         (read_array_type): Likewise.
7653         (dwarf2_per_cu_addr_sized_int_type): New function.
7654         (read_subrange_index_type): Move type finding code to
7655         dwarf2_per_cu_addr_sized_int_type.
7656         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7657         (dwarf2_per_cu_addr_type): New function.
7658         (set_die_type): Update calls to attr_to_dynamic_prop.
7660 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7662         * dwarf2read.c (read_subrange_index_type): New function.
7663         (read_subrange_type): Move code into new function and call it.
7664         * gdbtypes.c (create_range_type): Add some asserts.
7666 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7668         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7669         update return statements.
7670         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7671         declaration, and update comment to match.
7672         * gdbtypes.c (resolve_dynamic_array): Update call to
7673         dwarf2_evaluate_property to match new return type.
7675 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7677         * valarith.c (value_subscripted_rvalue): Change lowerbound
7678         parameter type from int to LONGEST.
7679         * value.h (value_subscripted_rvalue): Likewise in declaration.
7681 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7683         * cli/cli-utils.c (info_print_command_completer): New function.
7684         * cli/cli-utils.h: Add 'completer.h' include, and forward
7685         declaration for 'struct cmd_list_element'.
7686         (info_print_command_completer): Declare.
7687         * stack.c (_initialize_stack): Add completer for 'info locals' and
7688         'info args'.
7689         * symtab.c (_initialize_symtab): Add completer for 'info
7690         variables' and 'info functions'.
7691         * NEWS: Mention completion for additional info commands.
7693 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7695         * cli/cli-utils.c (extract_info_print_args): Delete.
7696         (extract_arg_maybe_quoted): Delete.
7697         (info_print_options_defs): New variable.
7698         (make_info_print_options_def_group): New function.
7699         (extract_info_print_options): Define new function.
7700         * cli/cli-utils.h (extract_info_print_args): Delete.
7701         (struct info_print_options): New structure.
7702         (extract_info_print_options): Declare new function.
7703         * stack.c (info_locals_command): Update to use new
7704         extract_info_print_options, also add a header comment.
7705         (info_args_command): Likewise.
7706         * symtab.c (info_variables_command): Likewise.
7707         (info_functions_command): Likewise.
7709 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7711         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7712         to extract string arguments.
7713         * common/common-utils.c (extract_string_maybe_quoted): New function.
7714         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7716 2019-07-11  Tom Tromey  <tromey@adacore.com>
7718         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7719         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7720         * top.h (gdbinit): Don't declare.
7721         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7722         into...
7723         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7724         * top.c (gdb_init): Don't call init_cli_cmds.
7725         (gdbinit): Remove.
7726         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7728 2019-07-11  Tom Tromey  <tromey@adacore.com>
7730         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7731         after it has been moved.
7733 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7735         * valops.c (value_must_coerce_to_target): Change return type to
7736         bool.
7737         * value.h (value_must_coerce_to_target): Likewise.
7739 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7741         * breakpoint.c (is_hardware_watchpoint): Remove
7742         forward-declaration.
7743         (is_masked_watchpoint): Change return type to bool.
7744         (is_tracepoint): Likewise.
7745         (is_breakpoint): Likewise.
7746         (is_hardware_watchpoint): Likewise.
7747         (is_watchpoint): Likewise.
7748         (is_no_memory_software_watchpoint): Likewise.
7749         (is_catchpoint): Likewise.
7750         (breakpoint_1): Make FILTER parameter's return type bool.
7751         is_masked_watchpoint): Change return type to bool.
7752         (save_breakpoints): Make FILTER parameter's return type bool.
7753         * breakpoint.h (is_breakpoint): Change return type to bool.
7754         (is_watchpoint): Likewise.
7755         (is_catchpoint): Likewise.
7756         (is_tracepoint): Likewise.
7758 2019-07-10  Tom Tromey  <tom@tromey.com>
7760         * defs.h: Don't include gdbarch.h.
7761         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7762         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7763         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7764         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7765         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7766         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7767         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7768         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7769         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7770         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7771         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7772         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7773         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7774         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7775         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7776         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7777         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7778         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7779         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7780         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7781         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7782         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7783         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7784         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7785         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7786         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7787         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7789 2019-07-10  Tom Tromey  <tromey@adacore.com>
7791         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7792         * breakpoint.c (init_ada_exception_breakpoint): Register as
7793         bp_catchpoint.
7794         (print_one_breakpoint_location, print_one_breakpoint): Use
7795         is_ada_exception_catchpoint.
7796         * ada-lang.c (class ada_catchpoint_location): Pass
7797         bp_loc_software_breakpoint to bp_location constructor.
7798         (is_ada_exception_catchpoint): New function.
7800 2019-07-10  Tom Tromey  <tromey@adacore.com>
7802         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7803         VEC.
7804         (struct arm_exidx_entry): New method operator<.
7805         (struct arm_exidx_data) <section_maps>: Change type.
7806         (arm_exidx_data_free): Remove.
7807         (arm_exidx_data_key): Change type.  Move lower.
7808         (arm_exidx_new_objfile): Update.
7809         (arm_compare_exidx_entries): Remove.
7810         (arm_find_exidx_entry, _initialize_arm_tdep)
7812 2019-07-10  Tom Tromey  <tromey@adacore.com>
7814         * solib-spu.c (ocl_program_data_key): Change type.
7815         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7816         Update.
7818 2019-07-10  Tom Tromey  <tromey@adacore.com>
7820         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7821         (struct solib_aix_inferior_data) <library_list>: Change type.
7822         (solib_aix_inferior_data_handle): Change type.
7823         (get_solib_aix_inferior_data): Update.
7824         (solib_aix_free_library_list): Remove.
7825         (library_list_start_library): Update.
7826         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7827         return type.
7828         (solib_aix_get_library_list)
7829         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7830         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7832 2019-07-10  Tom Tromey  <tromey@adacore.com>
7834         * solib-dsbt.c (struct dsbt_info): Add initializers.
7835         (solib_dsbt_pspace_data): Change type.
7836         (dsbt_pspace_data_cleanup): Remove.
7837         (get_dsbt_info, _initialize_dsbt_solib): Update.
7839 2019-07-10  Tom Tromey  <tromey@adacore.com>
7841         * spu-tdep.c (spu_overlay_data): Change type.
7842         (spu_get_overlay_table, spu_overlay_new_objfile)
7843         (_initialize_spu_tdep): Update.
7845 2019-07-10  Tom Tromey  <tromey@adacore.com>
7847         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7848         destructor.
7849         (dbx_objfile_data_key): Change type and declare later.
7850         (DBX_SYMFILE_INFO): Rewrite.
7851         * dbxread.c (dbx_objfile_data_key): Change type.
7852         (dbx_symfile_init): Update.
7853         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7854         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7855         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7857 2019-07-10  Tom Tromey  <tromey@adacore.com>
7859         * jit.c (jit_program_space_key): Change type.  Move lower.
7860         (get_jit_program_space_data): Update.
7861         (jit_program_space_data_cleanup): Remove.
7862         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7863         Update.
7864         (struct jit_program_space_data): Add initializers.
7866 2019-07-10  Tom Tromey  <tromey@adacore.com>
7868         * solib-darwin.c (struct darwin_info): Add initializers.
7869         (solib_darwin_pspace_data): Change type.
7870         (darwin_pspace_data_cleanup): Remove.
7871         (get_darwin_info, _initialize_darwin_solib): Update.
7873 2019-07-10  Tom Tromey  <tromey@adacore.com>
7875         * remote-sim.c (struct sim_inferior_data): Add initializers,
7876         constructor, and destructor.
7877         (sim_inferior_data_key): Change type.  Move lower.
7878         (check_for_duplicate_sim_descriptor): Update.
7879         (get_sim_inferior_data): Use new.  Update.
7880         (~sim_inferior_data_cleanup): Rename from
7881         sim_inferior_data_cleanup.  Simplify.
7882         (gdbsim_close_inferior, simulator_command)
7883         (sim_command_completer, _initialize_remote_sim): Update.
7884         (next_pid, INITIAL_PID): Move earlier.
7886 2019-07-10  Tom Tromey  <tromey@adacore.com>
7888         * python/python-internal.h (create_thread_object): Return
7889         gdbpy_ref.
7890         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7891         * python/py-inferior.c (struct threadlist_entry): Add
7892         constructor.
7893         <thread_obj>: Now a gdbpy_ref.
7894         (thread_to_thread_object): Update.
7895         (add_thread_object): Use new.
7896         (delete_thread_object): Use delete.
7897         (infpy_threads): Update.
7898         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7899         GIL.
7901 2019-07-10  Tom Tromey  <tromey@adacore.com>
7903         * valops.c (value_cast): Specialize error message for Ada.
7905 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7907         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7909 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7911         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7912         bpstat_should_step): Return bool, adjust comments.
7913         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7914         bpstat_should_step): Likewise.
7916 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7918         * features/Makefile: Use feature target descriptions for Arm.
7919         * features/arm/arm-core.c: Generate new file.
7920         * features/arm/arm-fpa.c: Likewise.
7921         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7922         * features/arm/arm-m-profile.c: Likewise.
7923         * features/arm/arm-vfpv2.c: Likewise.
7924         * features/arm/arm-vfpv3.c: Likewise.
7925         * features/arm/xscale-iwmmxt.c: Likewise.
7926         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7928 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7930         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7931         ptrace earlier.
7933 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7935         * features/aarch64-pauth.c: Regenerate.
7937 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7939         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7940         bool.
7941         (bpstat_what): Use false instead of 0.
7943 2019-07-09  Pedro Alves  <palves@redhat.com>
7945         * break-catch-throw.c (is_exception_catchpoint): New.
7946         * breakpoint.c (print_one_breakpoint_location): New parameter
7947         'raw_loc'.  Handle it.  Use
7948         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7949         looking at the breakpoint's type.
7950         (print_one_breakpoint): If handling "maint info breakpoints", also
7951         print locations of exception catchpoints.
7952         * breakpoint.h (is_exception_catchpoint): Declare.
7954 2019-07-09  Pedro Alves  <palves@redhat.com>
7956         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7957         "addr" field.
7958         (allocate_location_exception_catchpoint): New.
7959         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7960         (initialize_throw_catchpoint_ops): Install
7961         allocate_location_exception_catchpoint as allocate_location
7962         method.
7963         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7964         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7965         bp_loc_other.
7966         (breakpoint_address_is_meaningful): Delete.
7967         (bl_address_is_meaningful): New.
7968         (breakpoint_locations_match): Adjust comment.
7969         (bp_location_from_bp_type): New, factored out of...
7970         (bp_location::bp_location(breakpoint *)): ... this.
7971         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7972         factored out of...
7973         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7974         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7975         breakpoint_address_is_meaningful.
7976         (bp_locations_compare): Adjust comment.
7977         (update_global_location_list): Use bl_address_is_meaningful
7978         instead of breakpoint_address_is_meaningful.
7979         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7980         explicit.
7981         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7982         * python/py-breakpoint.c (bppy_get_location): No longer check
7983         whether location is null.
7985 2019-07-09  Pedro Alves  <palves@redhat.com>
7987         PR c++/15468
7988         * breakpoint.c (print_one_breakpoint_location): Remove
7989         single-location assert.
7991 2019-07-09  Tom Tromey  <tom@tromey.com>
7993         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7994         * configure: Rebuild.
7995         * configure.ac: Change common to gdbsupport.
7996         * gdbsupport: Rename from common.
7997         * acinclude.m4: Change common to gdbsupport.
7998         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7999         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
8000         gdbsupport.
8001         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
8002         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
8003         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
8004         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
8005         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
8006         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
8007         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
8008         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
8009         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
8010         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
8011         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
8012         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
8013         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
8014         coff-pe-read.c, command.h, compile/compile-c-support.c,
8015         compile/compile-c.h, compile/compile-cplus-symbols.c,
8016         compile/compile-cplus-types.c, compile/compile-cplus.h,
8017         compile/compile-loc2c.c, compile/compile.c, completer.c,
8018         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
8019         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
8020         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
8021         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
8022         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
8023         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
8024         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
8025         features/aarch64-core.c, features/aarch64-fpu.c,
8026         features/aarch64-pauth.c, features/aarch64-sve.c,
8027         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
8028         features/i386/32bit-core.c, features/i386/32bit-linux.c,
8029         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
8030         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
8031         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
8032         features/i386/64bit-core.c, features/i386/64bit-linux.c,
8033         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
8034         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
8035         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
8036         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
8037         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
8038         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
8039         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
8040         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
8041         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
8042         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
8043         go32-nat.c, guile/guile.c, guile/scm-ports.c,
8044         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
8045         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
8046         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
8047         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
8048         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
8049         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
8050         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
8051         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
8052         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
8053         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
8054         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
8055         minsyms.c, mips-linux-tdep.c, namespace.h,
8056         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
8057         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
8058         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
8059         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
8060         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
8061         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
8062         nat/linux-waitpid.c, nat/mips-linux-watch.c,
8063         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
8064         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
8065         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
8066         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
8067         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
8068         procfs.c, producer.c, progspace.h, psymtab.h,
8069         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
8070         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
8071         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
8072         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
8073         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
8074         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
8075         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
8076         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
8077         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
8078         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
8079         target-memory.c, target.c, target.h, target/waitstatus.c,
8080         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
8081         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
8082         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
8083         unittests/array-view-selftests.c,
8084         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
8085         unittests/common-utils-selftests.c,
8086         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
8087         unittests/format_pieces-selftests.c,
8088         unittests/function-view-selftests.c,
8089         unittests/lookup_name_info-selftests.c,
8090         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
8091         unittests/mkdir-recursive-selftests.c,
8092         unittests/observable-selftests.c,
8093         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
8094         unittests/parse-connection-spec-selftests.c,
8095         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
8096         unittests/scoped_fd-selftests.c,
8097         unittests/scoped_mmap-selftests.c,
8098         unittests/scoped_restore-selftests.c,
8099         unittests/string_view-selftests.c, unittests/style-selftests.c,
8100         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
8101         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8102         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8103         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8104         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8105         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8107 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8109         * linespec.c (decode_digits_list_mode): Set explicit_line to a
8110         bool value.
8111         (decode_digits_ordinary): Set explicit_line field in sal.
8112         * symtab.c (skip_prologue_sal): Don't skip prologue for a
8113         symtab_and_line that was set on an explicit line number in
8114         assembler code.  Do always update the recorded symtab and line if
8115         we do skip the prologue.
8117 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8119         * breakpoint.c (set_breakpoint_location_function): Remove
8120         explicit_loc parameter.
8121         (momentary_breakpoint_from_master): Update call to
8122         set_breakpoint_location_function.
8123         (add_location_to_breakpoint): Likewise.
8125 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8127         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8128         required features based on default bfd type when no specific bfd
8129         is present.
8131 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8133         * NEWS: Mention that GDB printf and eval commands can now print
8134         C-style and Ada-style convenience var strings without
8135         calling the inferior.
8136         * printcmd.c (printf_c_string): Locally print GDB internal var
8137         instead of transiting via the inferior.
8138         (printf_wide_c_string): Likewise.
8140 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8142         PR breakpoints/25011
8143         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8145 2019-07-04  Tom Tromey  <tom@tromey.com>
8147         PR tui/24724:
8148         * tui/tui-winsource.c (tui_clear_source_content): Update.
8149         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8150         (tui_update_breakpoint_info): Update.
8151         (tui_set_exec_info_content): Update.
8152         * tui/tui-source.c (tui_set_source_content_nil): Update.
8153         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8154         has_break.
8155         * tui/tui-data.h (enum tui_bp_flag): New.
8156         (tui_bp_flags): New enum flags type.
8157         (struct tui_source_element) <break_mode>: Change type.  Rename
8158         from has_break.
8159         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8160         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8161         constants.
8162         * tui/tui-winsource.h: Fix comment.
8164 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8166         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8167         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8168         (store_fpregs_to_thread)
8169         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8170         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8171         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8172         (IWMMXT_REGS_SIZE): Add define.
8173         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8174         (fetch_vfp_regs, store_vfp_regs)
8175         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8176         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8178 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8180         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8181         defines.
8182         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8183         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8184         (ARM_INT_REGISTER_SIZE): ...to this.
8185         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8186         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8187         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8188         (arm_linux_collect_gregset, supply_nwfpe_register)
8189         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8190         defines.
8191         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8192         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8193         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8194         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8195         (arm_return_in_memory, arm_store_return_value)
8196         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8197         (arm_record_ld_st_multiple): Likewise.
8198         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8199         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8201 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8203         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8204         AARCH64_DISPLACED_MODIFIED_INSNS.
8205         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8206         (aarch64_displaced_step_copy_insn): Likewise.
8207         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8208         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8209         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8210         ARM_DISPLACED_MODIFIED_INSNS.
8211         * arm-tdep.c (arm_gdbarch_init): Likewise.
8212         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8213         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8214         (struct arm_displaced_step_closure): Use
8215         ARM_DISPLACED_MODIFIED_INSNS.
8217 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8219         * features/Makefile: Remove unused xml files.
8220         * features/aarch64.xml: Remove.
8221         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8222         * features/i386/amd64-avx-avx512.xml: Remove.
8223         * features/i386/amd64-avx-linux.xml: Remove.
8224         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8225         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8226         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8227         * features/i386/amd64-avx-mpx.xml: Remove.
8228         * features/i386/amd64-avx.xml: Remove.
8229         * features/i386/amd64-linux.xml: Remove.
8230         * features/i386/amd64-mpx-linux.xml: Remove.
8231         * features/i386/amd64-mpx.xml: Remove.
8232         * features/i386/amd64.xml: Remove.
8233         * features/i386/i386-avx-avx512-linux.xml: Remove.
8234         * features/i386/i386-avx-avx512.xml: Remove.
8235         * features/i386/i386-avx-linux.xml: Remove.
8236         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8237         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8238         * features/i386/i386-avx-mpx-linux.xml: Remove.
8239         * features/i386/i386-avx-mpx.xml: Remove.
8240         * features/i386/i386-avx.xml: Remove.
8241         * features/i386/i386-linux.xml: Remove.
8242         * features/i386/i386-mmx-linux.xml: Remove.
8243         * features/i386/i386-mmx.xml: Remove.
8244         * features/i386/i386-mpx-linux.xml: Remove.
8245         * features/i386/i386-mpx.xml: Remove.
8246         * features/i386/i386.xml: Remove.
8247         * features/i386/x32-avx-avx512-linux.xml: Remove.
8248         * features/i386/x32-avx-linux.xml: Remove.
8249         * features/i386/x32-linux.xml: Remove.
8251 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8253         * regformats/aarch64.dat: Remove.
8254         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8255         * regformats/i386/amd64-avx-linux.dat: Remove.
8256         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8257         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8258         * regformats/i386/amd64-linux.dat: Remove.
8259         * regformats/i386/amd64-mpx-linux.dat: Remove.
8260         * regformats/i386/amd64.dat: Remove.
8261         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8262         * regformats/i386/i386-avx-linux.dat: Remove.
8263         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8264         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8265         * regformats/i386/i386-linux.dat: Remove.
8266         * regformats/i386/i386-mmx-linux.dat: Remove.
8267         * regformats/i386/i386-mpx-linux.dat: Remove.
8268         * regformats/i386/i386.dat: Remove.
8269         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8270         * regformats/i386/x32-avx-linux.dat: Remove.
8271         * regformats/i386/x32-linux.dat: Remove.
8273 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8275         * aarch64-tdep.c: Remove xml self tests.
8276         * amd64-linux-tdep.c: Likewise.
8277         * amd64-tdep.c: Likewise.
8278         * i386-linux-tdep.c: Likewise.
8279         * i386-tdep.c: Likewise.
8281 2019-07-03  Pedro Alves  <palves@redhat.com>
8283         PR cli/24732
8284         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8285         (pipe_cmd_option_defs): New.
8286         (make_pipe_cmd_options_def_group): New.
8287         (pipe_command): Use gdb::option::process_options.
8288         (pipe_command_completer): New function.
8289         (_initialize_cli_cmds): Install completer for "pipe" command.
8291 2019-07-03  Pedro Alves  <palves@redhat.com>
8293         * cli/cli-option.c (union option_value) <string>: New field.
8294         (struct option_def_and_value): Add ctor, move ctor, dtor and
8295         use DISABLE_COPY_AND_ASSIGN.
8296         (option_def_and_value::clear_value): New.
8297         (parse_option, save_option_value_in_ctx, get_val_type_str)
8298         (add_setshow_cmds_for_options): Handle var_string.
8299         * cli-option.h (union option_def::var_address) <string>: New
8300         field.
8301         (struct string_option_def): New.
8302         * maint-test-options.c (struct test_options_opts): Add default
8303         ctor and use DISABLE_COPY_AND_ASSIGN.
8304         <string_opt>: New field.
8305         (test_options_opts::~test_options_opts): New.
8306         (test_options_opts::dump): Also dump "-string".
8307         (test_options_option_defs): Install "string.
8309 2019-07-03  Pedro Alves  <palves@redhat.com>
8311         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8312         option_value with a null enumeration.
8313         (complete_options): Save the option values in the context.
8314         (save_option_value_in_ctx): New, factored out from ...
8315         (process_options): ... here.
8316         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8317         of the function.
8318         * maint-test-options.c (test_options_opts::dump): New, factored
8319         out from ...
8320         (maintenance_test_options_command_mode): ... here.
8321         (maintenance_test_options_command_completion_result): Delete.
8322         (maintenance_test_options_command_completion_text): Update
8323         comment.
8324         (maintenance_show_test_options_completion_result): Change
8325         prototype.  Just print
8326         maintenance_test_options_command_completion_text.
8327         (save_completion_result): New.
8328         (maintenance_test_options_completer_mode): Pass options context to
8329         complete_options, and then save a dump.
8330         (_initialize_maint_test_options): Use add_cmd to install "maint
8331         show test-options-completion-result".
8333 2019-07-03  Pedro Alves  <palves@redhat.com>
8335         * NEWS (New commands): Mention "with" and "maint with".
8336         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8337         (with_command, with_command_completer): New.
8338         (pipe_command): Adjust to new repeat_previous
8339         interface.
8340         (_initialize_cli_cmds): Install the "with" command and its "w"
8341         alias.
8342         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8343         declarations.
8344         * cli/cli-setshow.c (parse_cli_var_uinteger)
8345         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8346         argument strings for all var_types.
8347         (get_setshow_command_value_string): New, factored out from ...
8348         (do_show_command): ... this.
8349         * cli/cli-setshow.h: Include <string>.
8350         (get_setshow_command_value_string): Declare.
8351         * command.h (repeat_previous): Now returns const char *.  Adjust
8352         comment.
8353         * maint.c: Include "cli/cli-cmds.h".
8354         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8355         (_initialize_maint_cmds): Register the "maintenance with" command.
8356         * top.c (repeat_previous): Move bits from pipe_command here:
8357         Return the saved command line, if any; error out if there's no
8358         command to relaunch.
8360 2019-07-03  Pedro Alves  <palves@redhat.com>
8362         * NEWS (New commands): Mention "maint set/show test-settings"
8363         instead of "maint test-settings".
8364         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8365         (maintenance_test_settings_set_list): Rename to ...
8366         (maintenance_set_test_settings_list): ... this.
8367         (maintenance_test_settings_show_list): Rename to  ...
8368         (maintenance_show_test_settings_list): ... this.
8369         (maintenance_test_settings_cmd): Delete.
8370         (maintenance_test_settings_set_cmd): ...
8371         (maintenance_set_test_settings_cmd): ... this.
8372         (maintenance_test_settings_show_cmd): ...
8373         (maintenance_show_test_settings_cmd): ... this.
8374         (maintenance_test_settings_show_value_cmd):
8375         (maintenance_show_test_settings_value_cmd): ... this.
8376         (_initialize_maint_test_settings): No longer install the "maint
8377         test-settings" prefix command.  Rename "maint test-settings set"
8378         to "maint set test-settings", and "maint test-settings show" to
8379         "maint show test-settings".  Adjust all subcommands.
8381 2019-07-03  Pedro Alves  <palves@redhat.com>
8383         * maint-test-settings.c: Fix file's intro comment.  Replace all
8384         references to "test-options" with references to "test-settings",
8385         in comments.
8387 2019-07-03  Pedro Alves  <palves@redhat.com>
8389         * maint-test-settings.c (maintenance_test_settings_xxx)
8390         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8391         New.
8392         (maintenance_test_settings_enums): Use them.
8393         (maintenance_test_settings_enum): Default to
8394         maintenance_test_settings_xxx.
8395         (_initialize_maint_test_settings): Initialize
8396         MAINTENANCE_TEST_SETTINGS_FILENAME.
8398 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8400         * breakpoint.h (remove_breakpoints_inf): Change return type to
8401         void, move function documentation here.
8402         * breakpoint.c (remove_breakpoints_inf): Change return type to
8403         void, move function documentation to header.
8405 2019-07-02  Pedro Alves  <palves@redhat.com>
8407         * NEWS (Completion improvements): Mention "info threads".
8408         * thread.c (struct info_threads_opts, info_threads_option_defs)
8409         (make_info_threads_options_def_group): New.
8410         (info_threads_command): Use gdb::option::process_options.
8411         (info_threads_command_completer): New.
8412         (_initialize_thread): Use gdb::option::build_help to build the
8413         help text for "info threads".
8415 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8417         * defs.h (generic_load): Move from here...
8418         * symfile.h (generic_load): ... to here.  Rename name parameter
8419         to args.
8420         * symfile.c (generic_load): Add comment.
8422 2019-07-01  Tom Tromey  <tromey@adacore.com>
8424         * dwarf2read.c
8425         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8426         declaration of without_params.  Fix formatting.
8428 2019-07-01  Tom Tromey  <tromey@adacore.com>
8430         * ada-exp.y (find_primitive_type): Update.
8431         * ada-lang.h (ada_lookup_symbol): Update.
8432         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8433         parameter.
8434         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8436 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8438         PR breakpoints/24541
8439         * gdbarch.c: Regenerate.
8440         * gdbarch.h: Regenerate.
8441         * gdbarch.sh: Add 'stap_adjust_register'.
8442         * i386-tdep.c: Include '<unordered_set>'.
8443         (i386_stap_adjust_register): New function.
8444         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8445         * stap-probe.c (stap_parse_register_operand): Call
8446         'gdbarch_stap_adjust_register'.
8448 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8450         PR python/24742
8451         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8452         * python/python.c (do_start_initialization): Use 'xmalloc'
8453         instead of 'PyMem_Malloc'.
8455 2019-06-28  Tom Tromey  <tromey@adacore.com>
8457         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8458         for Ada.
8460 2019-06-27  Tom Tromey  <tromey@adacore.com>
8462         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8463         objfile_key.
8464         (arm_find_mapping_symbol, arm_record_special_symbol)
8465         (_initialize_arm_tdep): Update.
8466         (arm_objfile_data_free): Remove.
8468 2019-06-27  Tom Tromey  <tromey@adacore.com>
8470         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8471         to cp_print_static_field.
8473 2019-06-26  Tom Tromey  <tromey@adacore.com>
8475         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8476         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8477         declare.
8479 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8481         * features/aarch64-core.c (create_feature_aarch64_core):
8482         Regenerate.
8483         * features/aarch64-core.xml: Add cpsr flags.
8485 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8487         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8488         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8490 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8492         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8493         field.
8494         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8495         use.
8496         (arm_record_special_symbol): Don't insert new symbol in sorted
8497         position, push it at the end.
8499 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8501         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8502         (arm_mapping_symbol_s): Remove.
8503         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8504         (arm_mapping_symbol_vec): New typedef.
8505         (struct arm_per_objfile): Add constructor.
8506         <section_maps>: Change type to
8507         std::unique_ptr<arm_mapping_symbol_vec[]>.
8508         (arm_compare_mapping_symbols): Remove.
8509         (arm_find_mapping_symbol): Adjust to section_maps type change.
8510         (arm_objfile_data_free): Call delete on arm_per_objfile.
8511         (arm_record_special_symbol): Adjust to section_maps type change.
8512         Allocate arm_per_objfile with new.
8514 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8516         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8517         with the command prefix.
8519 2019-06-25  Tom Tromey  <tom@tromey.com>
8521         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8522         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8524 2019-06-25  Tom Tromey  <tom@tromey.com>
8526         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8527         type.
8528         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8529         protected.
8531 2019-06-25  Tom Tromey  <tom@tromey.com>
8533         * tui/tui-winsource.c
8534         (tui_source_window_base::set_is_exec_point_at): Add check against
8535         LOA_ADDRESS.
8537 2019-06-25  Tom Tromey  <tom@tromey.com>
8539         * tui/tui-source.c (tui_set_source_content): Don't check before
8540         xfree.
8541         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8543 2019-06-25  Tom Tromey  <tom@tromey.com>
8545         * tui/tui-winsource.h (tui_update_source_window_as_is)
8546         (tui_alloc_source_buffer, tui_line_is_displayed)
8547         (tui_addr_is_displayed): Change type of win_info.
8548         * tui/tui-winsource.c (tui_update_source_window_as_is)
8549         (tui_clear_source_content, tui_show_source_line)
8550         (tui_show_source_content, tui_source_window_base::refill)
8551         (tui_source_window_base::set_is_exec_point_at)
8552         (tui_source_window_base::set_is_exec_point_at)
8553         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8554         (tui_alloc_source_buffer, tui_line_is_displayed)
8555         (tui_addr_is_displayed): Change type of win_info.  Update.
8556         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8557         (tui_source_window_base::do_make_visible_with_new_height):
8558         Update.
8559         * tui/tui-source.c (tui_set_source_content)
8560         (tui_set_source_content_nil)
8561         (tui_source_window::do_scroll_vertical): Update.
8562         * tui/tui-layout.c (show_layout): Update.
8563         * tui/tui-disasm.c (tui_set_disassem_content)
8564         (tui_disasm_window::do_scroll_vertical): Update.
8565         * tui/tui-data.h (tui_win_content): Remove.
8566         (struct tui_gen_win_info) <content, content_size>: Remove.
8567         (struct tui_source_element): Add initializers and destructor.
8568         (union tui_which_element, struct tui_win_element): Remove.
8569         (struct tui_source_window_base) <content>: New field.
8570         (struct tui_data_window): Remove destructor.
8571         (tui_alloc_content, tui_free_win_content)
8572         (tui_free_all_source_wins_content): Don't declare.
8573         * tui/tui-data.c (tui_initialize_static_data): Update.
8574         (init_content_element, tui_alloc_content): Remove.
8575         (~tui_gen_win_info): Update.
8576         (~tui_data_window, tui_free_all_source_wins_content)
8577         (tui_free_win_content, free_content, free_content_elements):
8578         Remove.
8580 2019-06-25  Tom Tromey  <tom@tromey.com>
8582         * tui/tui-winsource.h (tui_clear_source_content)
8583         (tui_erase_source_content, tui_show_source_content): Change type
8584         of win_info.
8585         * tui/tui-winsource.c (tui_clear_source_content)
8586         (tui_erase_source_content, tui_show_source_content): Change type
8587         of win_info.
8588         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8589         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8590         win_info.
8591         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8592         win_info.
8593         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8597         * tui/tui-winsource.c (tui_clear_source_content)
8598         (tui_source_window_base::set_is_exec_point_at): Update.
8599         * tui/tui-source.c (tui_set_source_content_nil): Update.
8600         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8601         a bool.
8602         * tui/tui-data.c (init_content_element): Update.
8604 2019-06-25  Tom Tromey  <tom@tromey.com>
8606         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8607         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8608         * tui/tui-layout.c (init_and_make_win): Update.
8609         * tui/tui.h (enum tui_win_type): Update.
8610         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8611         tui_win_is_auxillary.
8612         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8613         tui_win_is_auxillary.
8615 2019-06-25  Tom Tromey  <tom@tromey.com>
8617         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8618         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8619         (tui_delete_data_content_windows, tui_display_all_data)
8620         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8621         Update.
8622         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8623         * tui/tui-regs.c (tui_last_regs_line_no)
8624         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8625         (tui_show_registers): Update.
8626         (tui_show_register_group): Return void.  Update.
8627         (tui_display_registers_from, tui_display_reg_element_at_line)
8628         (tui_display_registers_from_line, tui_check_register_values):
8629         Update.
8630         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8631         member.
8632         (struct tui_data_window) <regs_content>: Now a std::vector.
8633         <regs_content_count>: Remove.
8634         (tui_add_content_elements, tui_free_data_content): Don't declare.
8635         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8636         (init_content_element): Remove DATA_WIN case.  Add assert.
8637         (tui_add_content_elements): Remove.
8638         (tui_data_window): Update.
8639         (tui_free_data_content): Remove.
8640         (free_content_elements): Remove DATA_WIN case.
8642 2019-06-25  Tom Tromey  <tom@tromey.com>
8644         * tui/tui-data.c (tui_data_item_window): Update.
8645         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8646         * tui/tui-windata.c (tui_display_all_data)
8647         (tui_display_data_from_line): Update.
8648         (tui_check_data_values): Remove.
8649         * tui/tui-regs.c (tui_show_register_group)
8650         (tui_display_reg_element_at_line): Update.
8651         * tui/tui-hooks.c (tui_register_changed)
8652         (tui_refresh_frame_and_register_information): Call
8653         tui_check_register_values.
8654         * tui/tui-data.h (struct tui_data_window) <data_content,
8655         data_content_count, data_type>: Remove.
8656         (enum tui_data_type): Remove.
8658         * tui/tui-data.c (tui_data_window::clear_detail)
8659         (~tui_data_window): Update.
8661 2019-06-25  Tom Tromey  <tom@tromey.com>
8663         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8664         declare.
8665         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8666         Rename from tui_first_data_item_displayed.  Update.
8667         (tui_data_window::refresh_all)
8668         (tui_data_window::do_scroll_vertical): Update.
8669         * tui/tui-data.h (struct tui_data_window)
8670         <first_data_item_displayed>: Declare new method.
8672 2019-06-25  Tom Tromey  <tom@tromey.com>
8674         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8675         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8676         contents...
8677         (tui_initialize_static_data): ...here.
8679 2019-06-25  Tom Tromey  <tom@tromey.com>
8681         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8682         (tui_display_registers_from, tui_check_register_values): Update.
8683         (tui_display_register): Remove win_info parameter; update.
8684         (tui_get_register): Change type of parameters.
8685         * tui/tui-data.h (struct tui_data_element): Remove.
8686         (union tui_which_element) <data>: Remove.
8687         <data_window>: Change type.
8688         (struct tui_data_item_window): New.
8689         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8690         case.  Add assert.
8691         (~tui_data_item_window): New destructor.
8692         (free_content_elements): Remove DATA_ITEM_WIN case.
8694 2019-06-25  Tom Tromey  <tom@tromey.com>
8696         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8697         Remove.
8699 2019-06-25  Tom Tromey  <tom@tromey.com>
8701         * tui/tui-data.h (struct tui_command_element): Remove.
8702         (union tui_which_element) <command>: Remove.
8703         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8704         assert.
8705         (free_content_elements): Remove CMD_WIN case.
8707 2019-06-25  Tom Tromey  <tom@tromey.com>
8709         * tui/tui-layout.c (tui_set_layout): Update.
8710         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8711         * tui/tui-data.c (layout_def): Update.
8713 2019-06-25  Tom Tromey  <tom@tromey.com>
8715         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8716         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8717         (tui_source_window_base::set_new_height): Update.
8718         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8719         Update.
8720         (tui_set_locator_fullname, tui_set_locator_info)
8721         (tui_show_frame_info): Update.
8722         * tui/tui-source.c (tui_set_source_content)
8723         (tui_source_is_displayed): Update.
8724         * tui/tui-layout.c (show_source_disasm_command, show_data)
8725         (show_source_or_disasm_and_command): Update.
8726         * tui/tui-disasm.c (tui_set_disassem_content)
8727         (tui_get_begin_asm_address): Update.
8728         * tui/tui-data.h (struct tui_locator_element): Remove.
8729         (union tui_which_element) <locator>: Remove.
8730         (struct tui_locator_window): New.
8731         (tui_locator_win_info_ptr): Change return type.
8732         * tui/tui-data.c (_locator): Change type.
8733         (tui_locator_win_info_ptr): Change return type.
8734         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8735         (tui_alloc_content): Add assert.
8737 2019-06-25  Tom Tromey  <tom@tromey.com>
8739         * tui/tui-winsource.c
8740         (tui_exec_info_window::maybe_allocate_content): New method.
8741         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8742         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8743         (make_source_or_disasm_window): Add cast.
8744         * tui/tui-data.h (union tui_which_element) <simple_string>:
8745         Remove.
8746         (struct tui_source_info): New.
8747         (struct tui_source_window_base) <execution_info>: Change type.
8748         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8749         case, and add assert.
8750         (tui_alloc_content): Add assert.
8752 2019-06-25  Tom Tromey  <tom@tromey.com>
8754         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8755         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8756         * tui/tui-data.c (tui_alloc_win_info): Remove.
8758 2019-06-25  Tom Tromey  <tom@tromey.com>
8760         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8761         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8762         can_highlight.
8764 2019-06-25  Tom Tromey  <tom@tromey.com>
8766         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8767         make_visible_with_new_height method.
8768         (tui_win_info::make_visible_with_new_height): New method.
8769         (tui_source_window_base::do_make_visible_with_new_height)
8770         (tui_data_window::do_make_visible_with_new_height)
8771         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8772         (make_visible_with_new_height): Remove.
8773         (tui_resize_all, tui_adjust_win_heights): Use
8774         make_visible_with_new_height method.
8775         * tui/tui-data.h (struct tui_win_info)
8776         <do_make_visible_with_new_height, make_visible_with_new_height>:
8777         New methods.
8778         (struct tui_source_window_base, struct tui_data_window)
8779         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8780         methods.
8782 2019-06-25  Tom Tromey  <tom@tromey.com>
8784         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8785         method.
8786         (update_tab_width): Call update_tab_width method.
8787         * tui/tui-data.h (struct tui_win_info)
8788         (struct tui_source_window_base) <update_tab_width>: New methods.
8790 2019-06-25  Tom Tromey  <tom@tromey.com>
8792         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8793         parameter.
8794         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8795         parameter.
8796         (tui_gen_win_info::make_visible): Update.
8797         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8798         parameter.
8799         * tui/tui-data.h (enum tui_box): New enum.
8800         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8802 2019-06-25  Tom Tromey  <tom@tromey.com>
8804         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8805         init_and_make_win for EXEC_INFO_WIN.
8806         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8807         longer inline.
8808         (struct tui_win_info) <~tui_win_info>: Inline.
8809         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8810         Don't declare.
8811         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8812         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8813         Remove.
8814         (tui_initialize_static_data): Update.
8815         (~tui_gen_win_info): Handle more cleanup here.
8816         (~tui_source_window_base): Delete "execution_info".
8817         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8819 2019-06-25  Tom Tromey  <tom@tromey.com>
8821         * tui/tui-layout.c (make_command_window): Don't set
8822         can_highlight.
8823         (show_source_disasm_command): Call the reset method.
8824         (show_data): Don't set can_highlight.  Call the reset method.
8825         (tui_gen_win_info::reset): Rename from init_gen_win_info
8826         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8827         (show_source_or_disasm_and_command): Call the reset method.
8828         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8829         (struct tui_cmd_window): Set can_highlight.
8831 2019-06-25  Tom Tromey  <tom@tromey.com>
8833         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8834         from make_visible.
8835         (tui_make_visible, tui_make_invisible): Rewrite.
8836         (tui_win_info::make_visible): Remove.
8837         (tui_source_window_base::make_visible): Update.
8838         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8839         method.  Moved from...
8840         (struct tui_win_info) <make_visible>: ...here.
8842 2019-06-25  Tom Tromey  <tom@tromey.com>
8844         * tui/tui-winsource.c
8845         (tui_source_window_base::do_scroll_horizontal): Remove direction
8846         parameter.
8847         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8848         direction parameter.
8849         * tui/tui-win.c (tui_win_info::forward_scroll)
8850         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8851         (tui_win_info::right_scroll): Update.
8852         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8853         direction parameter.
8854         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8855         direction parameter.
8856         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8857         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8858         Remove direction parameter.
8859         (struct tui_source_window_base, struct tui_source_window)
8860         (struct tui_disasm_window, struct tui_data_window)
8861         (struct tui_cmd_window): Update.
8863 2019-06-25  Tom Tromey  <tom@tromey.com>
8865         * tui/tui-winsource.h (tui_set_exec_info_content)
8866         (tui_show_exec_info_content, tui_erase_exec_info_content)
8867         (tui_clear_exec_info_content, tui_update_exec_info): Change
8868         argument to tui_source_window_base.
8869         * tui/tui-winsource.c (tui_set_exec_info_content)
8870         (tui_show_exec_info_content, tui_erase_exec_info_content)
8871         (tui_clear_exec_info_content, tui_update_exec_info): Change
8872         argument to tui_source_window_base.
8874 2019-06-25  Tom Tromey  <tom@tromey.com>
8876         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8877         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8879 2019-06-25  Tom Tromey  <tom@tromey.com>
8881         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8882         check.
8884 2019-06-25  Tom Tromey  <tom@tromey.com>
8886         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8887         type to void.
8888         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8889         type to void.
8890         * tui/tui-source.c (tui_set_source_content): Update.
8891         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8893 2019-06-25  Tom Tromey  <tom@tromey.com>
8895         * tui/tui-win.c (window_name_completer, tui_set_focus)
8896         (tui_all_windows_info): Use name method.
8897         * tui/tui-data.h (struct tui_gen_win_info)
8898         (struct tui_source_window, struct tui_disasm_window)
8899         (struct tui_data_window, struct tui_cmd_window) <name>: New
8900         method.
8901         (tui_win_name): Don't declare.
8902         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8903         (tui_win_name): Remove.
8905 2019-06-25  Tom Tromey  <tom@tromey.com>
8907         * tui/tui-winsource.h (tui_update_source_window)
8908         (tui_update_source_window_as_is): Change parameter type.
8909         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8910         to be a tui_source_window_base.
8911         (tui_update_source_window_as_is): Likewise.
8912         * tui/tui-win.c (make_visible_with_new_height): Update.
8914 2019-06-25  Tom Tromey  <tom@tromey.com>
8916         * tui/tui-winsource.c (tui_erase_source_content)
8917         (tui_show_source_content, tui_show_exec_info_content)
8918         (tui_erase_exec_info_content): Use refresh_window method.
8919         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8920         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8921         from tui_refresh_win.
8922         (tui_data_window::refresh_window): New method.
8923         (tui_win_info::refresh, tui_source_window_base::refresh)
8924         (tui_refresh_all): Use refresh_window method.
8925         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8926         method.
8927         * tui/tui-regs.c (tui_display_register): Call refresh_window
8928         method.
8929         * tui/tui-layout.c (show_source_disasm_command)
8930         (show_source_or_disasm_and_command): Call refresh_window method.
8931         * tui/tui-data.h (struct tui_gen_win_info)
8932         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8933         New method.
8935 2019-06-25  Tom Tromey  <tom@tromey.com>
8937         * tui/tui.c (tui_rl_other_window, tui_enable)
8938         (tui_is_window_visible, tui_get_command_dimension): Update.
8939         * tui/tui-winsource.c (tui_update_source_window_as_is)
8940         (tui_clear_source_content, tui_erase_source_content)
8941         (tui_show_source_line, tui_source_window_base::refill)
8942         (tui_source_window_base::do_scroll_horizontal)
8943         (tui_source_window_base::set_is_exec_point_at)
8944         (tui_update_breakpoint_info, tui_set_exec_info_content)
8945         (tui_alloc_source_buffer, tui_line_is_displayed)
8946         (tui_addr_is_displayed): Update.
8947         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8948         (tui_check_and_display_highlight_if_needed)
8949         (tui_win_info::make_visible, tui_win_info::refresh)
8950         (tui_refresh_all): Update.
8951         * tui/tui-windata.c (tui_first_data_item_displayed)
8952         (tui_delete_data_content_windows, tui_erase_data_content)
8953         (tui_display_all_data, tui_data_window::refresh_all)
8954         (tui_check_data_values): Update.
8955         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8956         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8957         (tui_win_info::backward_scroll, tui_refresh_all_win)
8958         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8959         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8960         (tui_source_window_base::set_new_height)
8961         (tui_data_window::set_new_height)
8962         (make_invisible_and_set_new_height)
8963         (make_visible_with_new_height, new_height_ok)
8964         (parse_scrolling_args): Update.
8965         * tui/tui-stack.c (tui_show_frame_info): Update.
8966         * tui/tui-source.c (tui_set_source_content)
8967         (tui_set_source_content_nil, tui_source_is_displayed)
8968         (tui_source_window::do_scroll_vertical): Update.
8969         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8970         (tui_display_registers_from, tui_display_reg_element_at_line)
8971         (tui_check_register_values, tui_reg_command): Update.
8972         * tui/tui-layout.c (tui_default_win_height)
8973         (show_source_disasm_command, show_data, init_and_make_win)
8974         (show_source_or_disasm_and_command): Update.
8975         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8976         (tui_redisplay_readline, tui_mld_flush)
8977         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8978         (tui_getc): Update.
8979         * tui/tui-disasm.c (tui_set_disassem_content)
8980         (tui_disasm_window::do_scroll_vertical): Update.
8981         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8982         Now virtual.
8983         (struct tui_win_info): Derive from tui_gen_win_info.
8984         <~tui_win_info>: Mark as override.
8985         <generic>: Remove member.
8986         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8987         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8988         (~tui_data_window, ~tui_win_info)
8989         (tui_free_all_source_wins_content): Update.
8990         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8992 2019-06-25  Tom Tromey  <tom@tromey.com>
8994         * tui/tui-layout.c (init_and_make_win): Use new.
8995         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8996         destructor, initializers.
8997         (tui_alloc_generic_win_info): Don't declare.
8998         * tui/tui-data.c (_locator): Add argument to constructor.
8999         (source_win, disasm_win): New globals.
9000         (exec_info): Remove.
9001         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
9002         Update.
9003         (tui_alloc_generic_win_info): Remove.
9004         (init_content_element): Use new.
9005         (tui_win_info::tui_win_info): Update.
9006         (free_content_elements) <case DATA_WIN>: Use delete.
9008 2019-06-25  Tom Tromey  <tom@tromey.com>
9010         * tui/tui-wingeneral.c (tui_refresh_win): Update.
9011         * tui/tui-windata.c (tui_first_data_item_displayed)
9012         (tui_delete_data_content_windows): Update.
9013         * tui/tui-win.c (tui_data_window::set_new_height): Update.
9014         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
9015         (tui_display_registers_from, tui_check_register_values): Update.
9016         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
9017         pointer.
9018         * tui/tui-data.c (init_content_element): Update.  Allocate the new
9019         window.
9020         (tui_free_data_content): Update.
9021         (free_content_elements) <case DATA_WIN>: Free the window.
9023 2019-06-25  Tom Tromey  <tom@tromey.com>
9025         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
9026         Update.
9027         * tui/tui-layout.c (make_command_window)
9028         (show_source_disasm_command, show_data, init_and_make_win)
9029         (show_source_or_disasm_and_command): Update.
9030         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
9031         method.
9032         <can_highight, is_highlighted>: Now bool.
9033         (tui_set_win_highlight): Don't declare.
9034         * tui/tui-data.c (tui_set_win_highlight): Remove.
9036 2019-06-25  Tom Tromey  <tom@tromey.com>
9038         * tui/tui-wingeneral.c (make_visible): Remove check of window
9039         type.
9041 2019-06-25  Tom Tromey  <tom@tromey.com>
9043         * tui/tui-win.c (tui_win_info::max_height)
9044         (tui_cmd_window::max_height): New methods.
9045         (new_height_ok): Call max_height.
9046         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
9047         <max_height>: New method.
9049 2019-06-25  Tom Tromey  <tom@tromey.com>
9051         * tui/tui-win.c (tui_source_window_base::set_new_height)
9052         (tui_data_window::set_new_height): New methods.
9053         (make_invisible_and_set_new_height): Call set_new_height method.
9054         * tui/tui-data.h (struct tui_win_info)
9055         (struct tui_source_window_base, struct tui_data_window)
9056         <set_new_height>: New method.
9058 2019-06-25  Tom Tromey  <tom@tromey.com>
9060         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
9061         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
9062         tui_refresh_data_win.
9063         * tui/tui-win.c (tui_source_window_base::refresh_all): New
9064         method.
9065         (tui_refresh_all_win): Call the refresh_all method.
9066         (tui_set_focus): Likewise.
9067         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
9068         (struct tui_source_window_base, struct tui_data_window) <refresh>:
9069         Likewise.
9071 2019-06-25  Tom Tromey  <tom@tromey.com>
9073         * tui/tui-winsource.h (tui_refill_source_window)
9074         (tui_set_is_exec_point_at): Don't declare.
9075         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
9076         (tui_source_window_base::refill): Rename from
9077         tui_refill_source_window.
9078         (tui_source_window_base::do_scroll_horizontal): Update.
9079         (tui_source_window_base::set_is_exec_point_at): Rename from
9080         tui_set_is_exec_point_at.
9081         (tui_update_all_breakpoint_info): Update.
9082         * tui/tui-stack.c (tui_show_frame_info): Update.
9083         * tui/tui-layout.c (show_data): Add cast.
9084         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
9085         * tui/tui-data.h (struct tui_source_window_base) <refill,
9086         set_is_exec_point_at>: New methods.
9087         (tui_source_windows, tui_add_to_source_windows): Update types.
9088         (tui_add_to_source_windows): Remove redundant declaration.
9089         * tui/tui-data.c (source_windows): Store tui_source_window_base.
9090         (tui_source_windows): Change return type.
9091         (tui_clear_source_windows_detail): Update.
9092         (tui_add_to_source_windows): Change type of parameter.
9093         (tui_free_all_source_wins_content): Update.
9095 2019-06-25  Tom Tromey  <tom@tromey.com>
9097         * tui/tui-wingeneral.c (tui_win_info::refresh)
9098         (tui_source_window_base::refresh): New methods.
9099         (tui_refresh_all): Call the refresh method.
9100         * tui/tui-data.h (struct tui_win_info)
9101         (struct tui_source_window_base) <refresh>: New method.
9103 2019-06-25  Tom Tromey  <tom@tromey.com>
9105         * tui/tui.h (tui_is_window_visible): Return bool.
9106         * tui/tui.c (tui_is_window_visible): Return bool.
9107         * tui/tui-wingeneral.c (tui_make_window, make_visible)
9108         (tui_make_visible, tui_make_invisible)
9109         (tui_win_info::make_visible)
9110         (tui_source_window_base::make_visible, make_all_visible)
9111         (tui_make_all_visible, tui_make_all_invisible): Update.
9112         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9113         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9114         bool.
9115         (struct tui_win_info, struct tui_source_window_base)
9116         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9117         * tui/tui-data.c (tui_init_generic_part): Update.
9119 2019-06-25  Tom Tromey  <tom@tromey.com>
9121         * tui/tui-wingeneral.c (tui_win_info::make_visible)
9122         (tui_source_window_base::make_visible): New methods.
9123         (make_all_visible): Make method call.
9124         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9125         (struct tui_source_window_base, struct tui_cmd_window): Override
9126         make_visible.
9127         (tui_win_is_source_type): Don't declare.
9128         * tui/tui-data.c (tui_win_is_source_type): Remove.
9130 2019-06-25  Tom Tromey  <tom@tromey.com>
9132         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9133         NULL check.
9135 2019-06-25  Tom Tromey  <tom@tromey.com>
9137         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9138         Inline constructor.  Add initializers for members.
9139         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9140         constructors; now inline in class.
9142 2019-06-25  Tom Tromey  <tom@tromey.com>
9144         * tui/tui-regs.c (tui_show_registers): Update.
9145         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9146         bool.
9147         * tui/tui-data.c (tui_data_window::clear_detail)
9148         (tui_data_window): Update.
9150 2019-06-25  Tom Tromey  <tom@tromey.com>
9152         * tui/tui-windata.c (tui_display_all_data)
9153         (tui_display_data_from_line, tui_display_data_from)
9154         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9155         Update.
9156         * tui/tui-regs.c (tui_last_regs_line_no)
9157         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9158         (tui_show_registers, tui_show_register_group)
9159         (tui_display_registers_from, tui_display_reg_element_at_line)
9160         (tui_display_registers_from_line, tui_check_register_values)
9161         (tui_reg_next, tui_reg_prev): Update.
9162         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9163         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9164         tui_data_window.
9165         (struct tui_win_info) <detail>: Remove.  Add new fields from
9166         tui_data_info.
9167         (TUI_DATA_WIN): Add cast.
9168         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9169         (~tui_data_window): Simplify.
9171 2019-06-25  Tom Tromey  <tom@tromey.com>
9173         * tui/tui-layout.c (show_source_disasm_command)
9174         (show_source_or_disasm_and_command): Update.
9175         * tui/tui-io.c (update_cmdwin_start_line)
9176         (tui_redisplay_readline): Update.
9177         * tui/tui-data.h (struct tui_command_info): Remove.
9178         (struct tui_win_info) <detail>: Remove command_info member.
9179         (struct tui_data_window) <start_line>: New member, from
9180         tui_command_info.
9181         (TUI_CMD_WIN): Add casts.
9183 2019-06-25  Tom Tromey  <tom@tromey.com>
9185         * tui/tui-winsource.c (tui_update_source_window)
9186         (tui_refill_source_window)
9187         (tui_source_window_base::do_scroll_horizontal)
9188         (tui_update_breakpoint_info, tui_set_exec_info_content)
9189         (tui_show_exec_info_content, tui_erase_exec_info_content)
9190         (tui_clear_exec_info_content): Update.
9191         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9192         Update.
9193         * tui/tui-win.c (make_invisible_and_set_new_height)
9194         (make_visible_with_new_height): Update.
9195         * tui/tui-source.c (tui_set_source_content)
9196         (tui_show_symtab_source): Update.
9197         * tui/tui-layout.c (extract_display_start_addr)
9198         (show_source_disasm_command, show_data)
9199         (make_source_or_disasm_window)
9200         (show_source_or_disasm_and_command): Update.
9201         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9202         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9203         "gdbarch".
9204         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9205         to tui_source_window_base.
9206         (struct tui_win_info) <detail>: Remove source_info member.
9207         (struct tui_source_window_base) <has_locator>: Inline.
9208         Move contents from tui_source_info; rename has_locator member to
9209         m_has_locator.
9210         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9211         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9212         header file.
9213         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9214         Simplify.
9215         (tui_free_all_source_wins_content): Cast to
9216         tui_source_window_base.
9218 2019-06-25  Tom Tromey  <tom@tromey.com>
9220         * tui/tui-win.c (make_invisible_and_set_new_height)
9221         (make_visible_with_new_height): Call has_locator method.
9222         * tui/tui-layout.c (show_source_disasm_command, show_data)
9223         (show_source_or_disasm_and_command): Update for bool change.
9224         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9225         (tui_win_info) <has_locator>: New method.
9226         (struct tui_source_window_base) <has_locator>: New method.
9227         (tui_win_has_locator): Don't declare.
9228         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9229         from tui_win_has_locator.
9230         (tui_source_window_base): Use false, not FALSE.
9232 2019-06-25  Tom Tromey  <tom@tromey.com>
9234         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9235         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9236         clear_detail method directly.
9237         (tui_clear_win_detail): Remove.
9239 2019-06-25  Tom Tromey  <tom@tromey.com>
9241         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9242         "this", not TUI_DISASM_WIN.
9244 2019-06-25  Tom Tromey  <tom@tromey.com>
9246         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9247         declare.
9248         * tui/tui-winsource.c
9249         (tui_source_window_base::do_scroll_horizontal): Rename from
9250         tui_horizontal_source_scroll.
9251         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9252         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9253         from tui_vertical_data_scroll.
9254         * tui/tui-win.h (tui_scroll): Don't declare.
9255         * tui/tui-win.c (tui_win_info::forward_scroll)
9256         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9257         (tui_win_info::right_scroll): Rename and update.
9258         (tui_scroll_forward_command, tui_scroll_backward_command)
9259         (tui_scroll_left_command, tui_scroll_right_command): Update.
9260         (tui_scroll): Remove.
9261         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9262         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9263         from tui_vertical_source_scroll.
9264         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9265         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9266         from tui_vertical_disassem_scroll.
9267         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9268         do_scroll_horizontal>: New methods.
9269         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9270         Likewise.
9271         (struct tui_source_window_base): Add do_scroll_horizontal.
9272         (struct tui_source_window, struct tui_disasm_window): Add
9273         do_scroll_vertical.
9274         (struct tui_data_window, struct tui_cmd_window): Add
9275         do_scroll_horizontal and do_scroll_vertical.
9276         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9278 2019-06-25  Tom Tromey  <tom@tromey.com>
9280         * tui/tui-data.h (struct tui_source_window_base): New struct.
9281         (struct tui_source_window): Derive from tui_source_window_base.
9282         (struct tui_disasm_window): New struct.
9283         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9284         from tui_source_window::clear_detail.
9285         (tui_source_window_base): Rename from tui_source_window.
9286         (~tui_source_window_base): Rename from ~tui_source_window.
9287         (tui_alloc_win_info): Create a tui_disasm_window.
9289 2019-06-25  Tom Tromey  <tom@tromey.com>
9291         * tui/tui-data.h (struct tui_source_window)
9292         (struct tui_data_window): Declare destructors.
9293         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9294         destructors.
9295         (tui_win_info): Simplify.
9297 2019-06-25  Tom Tromey  <tom@tromey.com>
9299         * tui/tui-winsource.c (tui_display_main)
9300         (tui_update_source_windows_with_addr)
9301         (tui_update_all_breakpoint_info): Update.
9302         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9303         (new_height_ok, parse_scrolling_args): Update.
9304         * tui/tui-stack.c (tui_show_frame_info): Update.
9305         * tui/tui-data.h (struct tui_list): Remove.
9306         (tui_source_windows): Return a reference to a std::vector.
9307         * tui/tui-data.c (source_windows): Now a std::vector.
9308         (tui_source_windows): Change return type.
9309         (tui_clear_source_windows): Rewrite.
9310         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9311         (tui_free_all_source_wins_content): Rewrite.
9313 2019-06-25  Tom Tromey  <tom@tromey.com>
9315         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9316         (struct tui_data_window, struct tui_cmd_window): Declare
9317         clear_detail method.
9318         * tui/tui-data.c (tui_source_window::clear_detail)
9319         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9320         methods.
9321         (tui_clear_win_detail): Simplify.
9323 2019-06-25  Tom Tromey  <tom@tromey.com>
9325         * tui/tui-layout.c (make_source_window, make_disasm_window)
9326         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9327         Return the new window.
9328         (show_source_disasm_command, show_data)
9329         (show_source_or_disasm_and_command): Update.
9331 2019-06-25  Tom Tromey  <tom@tromey.com>
9333         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9334         parameter.  Return the new window.
9335         (show_source_disasm_command): Update and remove NULL check.
9336         (show_source_or_disasm_and_command): Update.
9338 2019-06-25  Tom Tromey  <tom@tromey.com>
9340         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9342 2019-06-25  Tom Tromey  <tom@tromey.com>
9344         * tui/tui-data.h (struct tui_win_info): Make constructor
9345         protected.  Make destructor virtual.  Add initializers.
9346         (tui_source_window, tui_data_window, tui_cmd_window): New
9347         classes.
9348         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9349         constructor.  Add "type" parameter.
9350         (tui_source_window, tui_data_window, tui_cmd_window): New
9351         constructors.
9352         (tui_alloc_win_info): Instantiate the appropriate subclass.
9354 2019-06-25  Tom Tromey  <tom@tromey.com>
9356         * tui/tui-win.c (tui_resize_all): Use delete.
9357         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9358         destructor.
9359         (tui_free_window): Don't declare.
9360         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9361         Update.
9363 2019-06-25  Tom Tromey  <tom@tromey.com>
9365         * tui/tui-data.h (struct tui_win_info): Add constructor.
9366         * tui/tui-data.c (tui_alloc_win_info): Use new.
9367         (tui_free_window): Use delete.
9369 2019-06-22  Tom Tromey  <tom@tromey.com>
9371         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9372         declare.
9373         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9375 2019-06-22  Tom Tromey  <tom@tromey.com>
9377         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9378         declare.
9379         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9381 2019-06-22  Tom de Vries  <tdevries@suse.de>
9383         * dwarf2read.c (create_addrmap_from_aranges)
9384         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9385         instead of '%zu'.
9387 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9389         * dwarf2read.h (dwarf2_section_info_def): Remove.
9390         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9391         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9392         std::vector<dwarf2_section_info>.
9393         (struct dwo_file) <~dwo_file>: Remove.
9394         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9395         types field.
9396         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9397         (dwarf2_read_debug_names): Likewise.
9398         (create_debug_types_hash_table): Change parameter type to
9399         array_view, adjust code accordingly.
9400         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9401         (partial_die_info::fixup): Likewise.
9402         (determine_prefix): Likewise.
9403         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9405 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9407         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9408         gdb_bfd_ref_ptr.
9409         <~dwo_file>: Remove call to gdb_bfd_unref.
9410         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9411         gdb_bfd_ref_ptr::get.
9413 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9415         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9416         type to htab_up.
9417         * dwarf2read.c (struct dwo_file): Initialize fields.
9418         <~dwo_file>: New.
9419         (free_dwo_file): Remove, move content to ~dwo_file.
9420         (struct dwo_file_deleter): Remove.
9421         (dwo_file_up>: Remove custom deleter.
9422         (free_dwo_files): Remove.
9423         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9424         dwo_files.
9425         (process_skeletonless_type_units): Call unique_ptr::get.
9426         (allocate_dwo_file_hash_table): Add deleter to created hash
9427         table.  Change return type to htab_up.
9428         (lookup_dwo_file_slot): Don't memset dwo_file, call
9429         unique_ptr::get.
9430         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9431         (create_dwo_unit_in_dwp_v2): Likewise.
9432         (open_and_init_dwo_file): Likewise.
9433         (free_dwo_file_from_slot): Remove.
9435 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9437         * dwarf2read.h (struct dwarf2_section_info) <readin,
9438         is_virtual>: Change type to bool.
9439         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9440         true instead of 1.
9442 2019-06-19  Tom Tromey  <tom@tromey.com>
9444         * tui/tui-data.h (tui_init_content_element): Don't declare.
9446 2019-06-19  Tom Tromey  <tom@tromey.com>
9448         * tui/tui-data.h (tui_init_win_info): Don't declare.
9450 2019-06-19  Tom de Vries  <tdevries@suse.de>
9452         * dwarf2read.h (abstract_to_concrete): Change type to
9453         std::unordered_map<sect_offset, std::vector<sect_offset>,
9454         gdb::hash_enum<sect_offset>>.
9456 2019-06-19  Tom Tromey  <tromey@adacore.com>
9458         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9459         EVAL_AVOID_SIDE_EFFECTS specially.
9461 2019-06-19  Tom Tromey  <tromey@adacore.com>
9463         * source-cache.c (highlighter): New global.
9464         (source_cache::get_source_lines): Create a highlighter on demand.
9466 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9468         * defs.h (deprecated_interactive_hook): Delete declaration.
9469         * interps.c (clear_interpreter_hooks): Remove use of
9470         deprecated_interactive_hook.
9471         * top.c (deprecated_interactive_hook): Delete definition.
9472         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9474 2019-06-18  Tom de Vries  <tdevries@suse.de>
9476         PR gdb/24515
9477         * dwarf2read.h (abstract_to_concrete): Change type from
9478         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9479         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9480         * dwarf2read.c (read_variable): Update.
9481         (dwarf2_fetch_die_loc_sect_off): Update.
9483 2019-06-17  Tom de Vries  <tdevries@suse.de>
9485         PR gdb/24617
9486         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9487         accessing parent[parent_len - 1].
9489 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9491         PR gdb/24364
9492         * dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9493         call dtrace_process_dof with NULL dof.
9495 2019-06-16  Tom de Vries  <tdevries@suse.de>
9497         PR gdb/24445
9498         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9500 2019-06-16  Tom Tromey  <tom@tromey.com>
9502         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9503         (make_all_visible): Use address of member.
9505 2019-06-16  Tom Tromey  <tom@tromey.com>
9507         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9508         (tui_free_window, free_content, free_content_elements): Remove
9509         unnecessary cast.
9510         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9511         cast.
9512         * tui/tui-regs.c (tui_show_register_group)
9513         (tui_display_registers_from, tui_display_reg_element_at_line):
9514         Remove unnecessary cast.
9516 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9518         * linux-nat.c (normal_mask): Delete.
9519         (_initialize_linux_nat): Don't initialise normal_mask.
9521 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9523         PR gdb/24445
9524         * dwarf-index-write.h (write_psymtabs_to_index): Add
9525         dwz_basename parameter.
9526         * dwarf-index-write.c (write_gdbindex): Move file writing to
9527         write_gdbindex_1.  Change return type void.
9528         (assert_file_size): Move up, remove filename parameter.
9529         (write_gdbindex_1): New function.
9530         (write_debug_names): Change return type to void, call
9531         assert_file_size.
9532         (struct index_wip_file): New struct.
9533         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9534         file logic to index_wip_file.  Write index for dwz file if
9535         needed.
9536         (save_gdb_index_command): Pass basename of dwz file, if present.
9537         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9538         build-id of dwz file, if present.
9539         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9540         (dwarf2_get_dwz_file): Likewise.
9541         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9542         (dwarf2_get_dwz_file): Likewise.
9544 2019-06-16  Tom Tromey  <tom@tromey.com>
9546         * coffread.c (process_coff_symbol): Use xstrdup.
9547         * value.c (create_internalvar): Use xstrdup.
9549 2019-06-16  Tom Tromey  <tom@tromey.com>
9551         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9552         * breakpoint.c (stopin_command, stopat_command)
9553         (until_break_command, decode_location_default): Remove unnecessary
9554         cast.
9555         * utils.c (subset_compare): Remove unnecessary cast.
9556         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9557         cast.
9558         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9559         cast.
9560         * infcmd.c (path_command): Remove unnecessary cast.
9561         * coffread.c (decode_type): Remove unnecessary cast.
9562         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9563         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9564         * tui/tui-stack.c (tui_show_locator_content)
9565         (tui_show_frame_info): Remove unnecessary cast.
9566         * tui/tui-win.c (tui_scroll_forward_command)
9567         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9568         (parse_scrolling_args): Remove unnecessary cast.
9569         * tui/tui-data.c (init_win_info, tui_del_window)
9570         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9571         (free_content_elements): Remove unnecessary cast.
9572         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9573         unnecessary cast.
9574         * tui/tui-source.c (tui_set_source_content)
9575         (tui_vertical_source_scroll): Remove unnecessary cast.
9576         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9577         cast.
9578         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9579         * tui/tui-regs.c (tui_display_registers_from)
9580         (tui_display_register): Remove unnecessary cast.
9581         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9582         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9583         (make_visible): Remove unnecessary cast.
9584         * tui/tui-winsource.c (tui_erase_source_content)
9585         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9586         unnecessary cast.
9587         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9588         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9589         * stabsread.c (read_type, read_array_type, read_range_type):
9590         Remove unnecessary cast.
9591         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9592         (parse_symbol, parse_type, upgrade_type, parse_external)
9593         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9594         unnecessary cast.
9595         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9597 2019-06-16  Tom Tromey  <tom@tromey.com>
9599         * tui/tui-data.c (tui_alloc_generic_win_info)
9600         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9601         checks.
9603 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9604             Andrew Burgess  <andrew.burgess@embecosm.com>
9606         * f-typeprint.c (f_print_type): Don't return early for not
9607         associated or not allocated types.
9608         (f_type_print_varspec_suffix): Add print_rank parameter and print
9609         ranks of array types in case they dangling.
9610         (f_type_print_base): Add print_rank parameter.
9612 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9614         * NEWS: Mention new MI commands.
9615         * break-catch-throw.c (enum exception_event_kind): Move to
9616         breakpoint.h.
9617         (print_mention_exception_catchpoint): Output text as a single
9618         message.
9619         (catch_exception_command_1): Rename to...
9620         (catch_exception_event): ...this, make non-static, update header
9621         command, and change some parameter types.
9622         (catch_catch_command): Update for changes to
9623         catch_exception_command_1.
9624         (catch_throw_command): Likewise.
9625         (catch_rethrow_command): Likewise.
9626         * breakpoint.c (enum exception_event_kind): Delete.
9627         * breakpoint.h (enum exception_event_kind): Moved here from
9628         break-catch-throw.c.
9629         (catch_exception_event): Declare.
9630         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9631         (mi_cmd_catch_throw): New function.
9632         (mi_cmd_catch_rethrow): New function.
9633         (mi_cmd_catch_catch): New function.
9634         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9635         'catch-catch' entries.
9636         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9637         (mi_cmd_catch_rethrow): Declare.
9638         (mi_cmd_catch_catch): Declare.
9640 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9642         * annotate.c (annotate_source_line): Change return type to void,
9643         update implementation to match.
9644         * annotate.h (annotate_source_line): Change return type to void,
9645         update header comment.
9646         * stack.c (print_frame_info): Don't change what frame information
9647         is printed based on whether annotations are on or not.
9649 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9651         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9652         (annotate_source): Make static.
9653         (annotate_source_line): Moved from source.c and renamed from
9654         identify_source_line.  Update the return type.
9655         * annotate.h (annotate_source): Delete declaration.
9656         (annotate_source_line): Declaration moved from source.h, and
9657         renamed from identify_source_line.  Return type updated.
9658         * source.c (identify_source_line): Moved to annotate.c and renamed
9659         to annotate_source_line.
9660         (info_line_command): Remove check of annotation_level.
9661         * source.h (identify_source_line): Move declaration to annotate.h
9662         and rename to annotate_source_line.
9663         * stack.c: Add 'annotate.h' include.
9664         (print_frame_info): Remove check of annotation_level before
9665         calling annotate_source_line.
9667 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9669         * source-cache.c (source_cache::get_plain_source_lines): Use
9670         open_source_file_with_line_charpos instead of just
9671         open_source_file, remove call to find_source_lines.
9672         (source_cache::get_source_lines): Likewise.
9673         * source.c (find_source_lines): Make static.
9674         (get_filename_and_charpos): Renamed into...
9675         (open_source_file_with_line_charpos): ..this along with changes to
9676         return a scoped_fd, and some other minor clean ups.
9677         (identify_source_line): Use open_source_file_with_line_charpos.
9678         (search_command_helper): Use open_source_file_with_line_charpos
9679         instead of just open_source_file, remove call to
9680         find_source_lines.
9681         * source.h (open_source_file_with_line_charpos): Declare new
9682         function.
9683         (find_source_lines): Delete declaration.
9685 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9687         * source.c (get_filename_and_charpos): Remove fullname
9688         parameter.
9689         (identify_source_line): Update call to get_filename_and_charpos.
9691 2019-06-14  Tom Tromey  <tromey@adacore.com>
9693         PR gdb/24502:
9694         * ui-style.h (skip_ansi_escape): Update comment.
9695         * ui-file.h (class no_terminal_escape_file): New class.
9696         * ui-file.c (no_terminal_escape_file::write)
9697         (no_terminal_escape_file::puts): New methods.
9698         * cli/cli-logging.c (handle_redirections): Use
9699         no_terminal_escape_file.
9701 2019-06-14  Tom Tromey  <tromey@adacore.com>
9703         * NEWS: Move convenience variable news above Python news.
9705 2019-06-14  Tom Tromey  <tom@tromey.com>
9707         * gnulib: Move directory to top-level.
9708         * configure.ac: Don't configure gnulib.
9709         * configure: Rebuild.
9710         * common/common-defs.h: Use new path to gnulib.
9711         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9712         (GNULIB_H): Remove.
9713         (INCGNU): Look in new gnulib location.
9714         (HFILES_NO_SRCDIR): Remove gnulib files.
9715         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9716         (generated_files): Remove GNULIB_H.
9717         ($(LIBGNU), all-lib): Remove targets.
9718         (distclean): Don't mention GNULIB_BUILDDIR.
9719         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9721 2019-06-14  Tom Tromey  <tromey@adacore.com>
9723         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9724         Warn if symbol file does not provide any symbols.
9726 2019-06-14  Tom Tromey  <tromey@adacore.com>
9728         * source.c (find_and_open_source): Respect basenames_may_differ.
9730 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9732         * annotate.c (annotate_breakpoints_invalid): Make use of
9733         scoped_restore_terminal_state.
9734         (annotate_frames_invalid): Likewise.
9736 2019-06-14  Tom Tromey  <tromey@adacore.com>
9738         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9739         allow assignment to an internalvar.
9741 2019-06-14  Tom Tromey  <tromey@adacore.com>
9743         * ada-lex.l: Allow "_" in attribute names.
9745 2019-06-14  Tom Tromey  <tromey@adacore.com>
9747         PR gdb/24653:
9748         * regcache.c (registers_changed): Don't call alloca.
9749         * top.c (execute_command): Don't call alloca.
9751 2019-06-13  Pedro Alves  <palves@redhat.com>
9753         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9754         'expression'.  When parsing an expression, error out if there's
9755         junk after "unlimited".
9756         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9757         (do_set_command): Adjust calls to is_unlimited_literal.
9759 2019-06-13  Pedro Alves  <palves@redhat.com>
9761         * compile/compile.c (make_compile_options_def_group): Add braces
9762         around array_view initializer.
9763         * thread.c (make_thread_apply_all_options_def_group)
9764         (make_thread_apply_all_options_def_group): Likewise.
9766 2019-06-13  Pedro Alves  <palves@redhat.com>
9768         * NEWS (New commands): Mention "maint test-options
9769         require-delimiter", "maint test-options unknown-is-error", "maint
9770         test-options unknown-is-operand" and "maint show
9771         test-options-completion-result".
9772         (New command options, command completion): New section.
9773         (Completion improvements): New section.
9774         Mention that you can abbreviate "unlimited".
9776 2019-06-13  Pedro Alves  <palves@redhat.com>
9778         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9779         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9780         * unittests/cli-utils-selftests.c (test_parse_flags)
9781         (test_parse_flags_qcs): Delete.
9782         (test_cli_utils): Don't call deleted functions.
9784 2019-06-13  Pedro Alves  <palves@redhat.com>
9786         * thread.c: Include "cli/cli-option.h".
9787         (tp_array_compar_ascending): Global.
9788         (tp_array_compar): Delete function.
9789         (tp_array_compar_ascending, tp_array_compar_descending): New
9790         functions.
9791         (ascending_option_def, qcs_flag_option_def)
9792         (thr_qcs_flags_option_defs)
9793         (make_thread_apply_all_options_def_group)
9794         (make_thread_apply_options_def_group): New.
9795         (thread_apply_all_command): Use gdb::option::process_options.
9796         (thread_apply_command_completer)
9797         (thread_apply_all_command_completer): New.
9798         (thread_apply_command): Use gdb::option::process_options.
9799         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9800         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9801         to generate help text of "thread apply".  Adjust "taas"'s help.
9802         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9803         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9805 2019-06-13  Pedro Alves  <palves@redhat.com>
9807         * thread.c (thread_apply_command): Check for invalid TID with
9808         isdigit instead of !isalpha.
9810 2019-06-13  Pedro Alves  <palves@redhat.com>
9812         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9813         (validate_flags_qcs): New.
9814         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9815         (validate_flags_qcs): Declare.
9816         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9817         (make_frame_apply_options_def_group): New.
9818         (frame_apply_command_count): Process options with
9819         gdb::option::process_options.
9820         (frame_apply_completer): New.
9821         (frame_apply_level_completer, frame_apply_all_completer)
9822         (frame_apply_completer): New.
9823         (_initialize_stack): Update help of "frame apply", "frame apply
9824         level", "frame apply all" and "faas" to mention supported options
9825         and install command completers.
9826         * stack.h (frame_apply_all_completer): Declare.
9827         * thread.c: Include "stack.h".
9828         (tfaas_command): Add "--".
9829         (_initialize_thread): Update help "tfaas" to mention supported
9830         options and install command completer.
9832 2019-06-13  Pedro Alves  <palves@redhat.com>
9834         * completer.c (complete_nested_command_line): New.
9835         (gdb_completion_word_break_characters_throw): Add assertion.
9836         * completer.h (complete_nested_command_line): Declare.
9838 2019-06-13  Pedro Alves  <palves@redhat.com>
9840         * stack.c (parse_backtrace_qualifiers): New.
9841         (backtrace_command): Use it.
9842         (backtrace_command_completer): Complete on qualifiers.
9844 2019-06-13  Pedro Alves  <palves@redhat.com>
9846         * frame.c: Include "cli/cli-option.h.
9847         (user_set_backtrace_options): New.
9848         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9849         Delete.
9850         (get_prev_frame): Adjust.
9851         (boolean_option_def, uinteger_option_def)
9852         (set_backtrace_option_defs): New.
9853         (_initialize_frame): Adjust and use
9854         gdb::option::add_setshow_cmds_for_options to install "set
9855         backtrace past-main" and "set backtrace past-entry".
9856         * frame.h: Include "cli/cli-option.h".
9857         (struct frame_print_options): Forward declare.
9858         (print_frame_arguments_all, print_frame_arguments_scalars)
9859         (print_frame_arguments_none): Declare.
9860         (print_entry_values): Delete declaration.
9861         (struct frame_print_options, user_frame_print_options): New.
9862         (struct set_backtrace_options): New.
9863         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9864         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9865         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9866         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9867         (list_args_or_locals): Add frame_print_options parameter.
9868         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9869         * python/py-framefilter.c (enumerate_args): Pass down
9870         USER_FRAME_PRINT_OPTIONS.
9871         * stack.c: Include "cli/cli-option.h".
9872         (print_frame_arguments_all, print_frame_arguments_scalars)
9873         (print_frame_arguments_none): Declare.
9874         (print_raw_frame_arguments, print_entry_values): Delete.
9875         (user_frame_print_options): New.
9876         (boolean_option_def, enum_option_def, frame_print_option_defs):
9877         New.
9878         (struct backtrace_cmd_options): New.
9879         (bt_flag_option_def): New.
9880         (backtrace_command_option_defs): New.
9881         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9882         (print_frame_arg, read_frame_arg, print_frame_args)
9883         (print_frame_info, print_frame): Add frame_print_options parameter
9884         and use it.
9885         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9886         (backtrace_command_1): Add frame_print_options and
9887         backtrace_cmd_options parameters and use them.
9888         (make_backtrace_options_def_group): New.
9889         (backtrace_command): Process command options with
9890         gdb::option::process_options.
9891         (backtrace_command_completer): New.
9892         (_initialize_stack): Extend "backtrace"'s help to mention
9893         supported options.  Install completer for "backtrace".
9894         Install some settings commands with add_setshow_cmds_for_options.
9896 2019-06-13  Pedro Alves  <palves@redhat.com>
9898         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9899         and that "set/show print raw frame-arguments" are now deprecated.
9901         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9902         command.
9903         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9904         * stack.c (_initialize_stack): Install "set/show print
9905         raw-frame-arguments", and deprecate "set/show print raw
9906         frame-arguments".
9907         * valprint.c (_initialize_valprint): Deprecate "set/show print
9908         raw".
9910 2019-06-13  Pedro Alves  <palves@redhat.com>
9912         * compile/compile.c (struct compile_options): New.
9913         (compile_flag_option_def, compile_command_option_defs)
9914         (make_compile_options_def_group): New.
9915         (compile_file_command): Handle options with
9916         gdb::option::process_options.
9917         (compile_file_command_completer): New function.
9918         (compile_code_command): Handle options with
9919         gdb::option::process_options.
9920         (compile_code_command_completer): New function.
9921         (_initialize_compiler): Install completers for "compile code" and
9922         "compile file".  Mention available options in "compile code" and
9923         "compile code"'s help.
9924         * completer.c (advance_to_completion_word): New, factored out from
9925         ...
9926         (advance_to_expression_complete_word_point): ... this.
9927         (advance_to_filename_complete_word_point): New.
9928         * completer.h (advance_to_filename_complete_word_point): New
9929         declaration.
9931 2019-06-13  Pedro Alves  <palves@redhat.com>
9933         * compile/compile.c: Include "cli/cli-option.h".
9934         (compile_print_value): Scope data pointer is now a
9935         value_print_options pointer; adjust.
9936         (compile_print_command): Process options.  Scope data pointer is
9937         now a value_print_options pointer; adjust.
9938         (_initialize_compile): Update "compile print"'s help to include
9939         supported options.  Install a completer for "compile print".
9940         * cp-valprint.c (show_vtblprint, show_objectprint)
9941         (show_static_field_print): Delete.
9942         (_initialize_cp_valprint): Don't install "set print
9943         static-members", "set print vtbl", "set print object" here.
9944         * printcmd.c: Include "cli/cli-option.h" and
9945         "common/gdb_optional.h".
9946         (print_command_parse_format): Rework to fill in a
9947         value_print_options instead of a format_data.
9948         (print_value): Change parameter type from format_data pointer to
9949         value_print_options reference.  Adjust.
9950         (print_command_1): Process options.  Adjust to pass down a
9951         value_print_options.
9952         (print_command_completer): New.
9953         (_initialize_printcmd): Install print_command_completer as
9954         handle_brkchars completer for the "print" command.  Update
9955         "print"'s help to include supported options.
9956         * valprint.c: Include "cli/cli-option.h".
9957         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9958         here from cp-valprint.c.
9959         (boolean_option_def, uinteger_option_def)
9960         (value_print_option_defs, make_value_print_options_def_group):
9961         New.  Use gdb::option::add_setshow_cmds_for_options to install
9962         "set print elements", "set print null-stop", "set print repeats",
9963         "set print pretty", "set print union", "set print array", "set
9964         print address", "set print symbol", "set print array-indexes".
9965         * valprint.h: Include <string> and "cli/cli-option.h".
9966         (make_value_print_options_def_group): Declare.
9967         (print_value): Change parameter type from format_data pointer to
9968         value_print_options reference.
9969         (print_command_completer): Declare.
9971 2019-06-13  Pedro Alves  <palves@redhat.com>
9973         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9974         (COMMON_SFILES): Add maint-test-settings.c.
9975         * cli/cli-decode.c (boolean_enums): New global, factored out from
9976         ...
9977         (add_setshow_boolean_cmd): ... here.
9978         * cli/cli-decode.h (boolean_enums): Declare.
9979         * cli/cli-option.c: New file.
9980         * cli/cli-option.h: New file.
9981         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9982         factored out from ...
9983         (parse_cli_boolean_value(const char *)): ... this.
9984         (is_unlimited_literal): Change parameter type to pointer to
9985         pointer.  Adjust and advance ARG pointer.
9986         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9987         (parse_cli_var_enum): New, factored out from ...
9988         (do_set_command): ... this.  Adjust.
9989         * cli/cli-setshow.h (parse_cli_boolean_value)
9990         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9991         (parse_cli_var_enum): Declare.
9992         * cli/cli-utils.c: Include "cli/cli-option.h".
9993         (get_ulongest): New.
9994         * cli/cli-utils.h (get_ulongest): Declare.
9995         (check_for_argument): New overloads.
9996         * maint-test-options.c: New file.
9998 2019-06-13  Pedro Alves  <palves@redhat.com>
10000         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
10001         parse a range if "-" is at the end of the string.
10003 2019-06-13  Pedro Alves  <palves@redhat.com>
10005         * cli/cli-setshow.c (parse_auto_binary_operation)
10006         (parse_cli_boolean_value): Don't allow "o".
10008 2019-06-13  Pedro Alves  <palves@redhat.com>
10010         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
10011         * NEWS: Mention maint test-settings KIND.
10012         * maint-test-settings.c: New file.
10014 2019-06-13  Pedro Alves  <palves@redhat.com>
10016         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
10017         completer.
10018         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
10019         "set" completers.
10021 2019-06-13  Pedro Alves  <palves@redhat.com>
10023         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
10024         after item.
10026 2019-06-13  Pedro Alves  <palves@redhat.com>
10028         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
10030 2019-06-13  Pedro Alves <palves@redhat.com>
10032         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
10033         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
10034         call.
10035         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
10036         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
10037         calls.
10038         (check_for_argument): Skip spaces after argument.
10040 2019-06-13  Pedro Alves  <palves@redhat.com>
10042         * thread.c (thread_apply_command): Adjust TID parsing.
10043         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
10044         detected before end of string.
10045         (tid_is_in_list): Error out if LIST is invalid.
10047 2019-06-13  Pedro Alves  <palves@redhat.com>
10049         * completer.c (complete_line_internal_1): Rewind completion word
10050         point.
10051         (completion_tracker::advance_custom_word_point_by): Change
10052         parameter type to int.
10053         * completer.h (completion_tracker::advance_custom_word_point_by):
10054         Likewise.
10056 2019-06-13  Pedro Alves  <palves@redhat.com>
10058         * completer.c (advance_to_completion_word): Handle delimiters.
10060 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
10062         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
10064 2019-06-11  Tom Tromey  <tom@tromey.com>
10066         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
10067         (xmalloc_failed): Move to alloc.c.
10068         * alloc.c: New file.
10069         * Makefile.in (COMMON_SFILES): Add alloc.c.
10071 2019-06-11  Tom Tromey  <tom@tromey.com>
10073         * nat/linux-waitpid.c: Don't include server.h.
10074         (linux_debug): Remove.
10075         (my_waitpid): Update.
10077 2019-06-11  Tom Tromey  <tromey@adacore.com>
10079         * infcall.c (_initialize_infcall): Remove trailing newline from
10080         help.
10081         * user-regs.c (_initialize_user_regs): Remove trailing newline
10082         from help.
10083         * typeprint.c (_initialize_typeprint): Remove trailing newline
10084         from help.
10085         * reverse.c (_initialize_reverse): Remove trailing newlines from
10086         help.
10087         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
10088         from help.
10089         * language.c (add_set_language_command): Remove trailing newline
10090         from help.
10091         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
10092         help.
10093         * disasm.c (_initialize_disasm): Remove trailing newline from
10094         help.
10095         * top.c (init_main): Remove trailing newline from help.
10096         * interps.c (_initialize_interpreter): Remove trailing newline
10097         from help.
10098         * btrace.c (_initialize_btrace): Remove trailing newlines from
10099         help.
10100         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
10101         from help.
10102         * python/python.c (_initialize_python): Remove trailing newline
10103         from help.
10104         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10105         help.
10106         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10107         from help.  Reformat some text.
10108         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10109         from help.
10110         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10111         newline from help.
10113 2019-06-11  Tom Tromey  <tromey@adacore.com>
10115         * darwin-nat.c (darwin_decode_exception_message)
10116         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10118 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10120         * valops.c (value_slice): Check for not allocated or not
10121         associated values.
10123 2019-06-10  Tom de Vries  <tdevries@suse.de>
10125         PR gdb/24618
10126         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10127         sure an empty slot (defined by a 32-bit zero pair) is recognized as
10128         invalid.
10130 2019-06-10  Tom de Vries  <tdevries@suse.de>
10132         PR gdb/24611
10133         * linespec.c (linespec_lexer_lex_string): Remove incorrect
10134         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
10136 2019-06-10  Tom de Vries  <tdevries@suse.de>
10138         PR symtab/24545
10139         * symtab.c (struct demangled_name_entry): Add language field.
10140         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
10141         static minimal symbol".  Set and use language field.
10143 2019-06-10  Tom Tromey  <tromey@adacore.com>
10145         * ada-lang.c (_initialize_ada_language): Update help text.
10147 2019-06-10  Tom Tromey  <tromey@adacore.com>
10149         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10150         with a newline.
10151         * guile/guile.c (handle_boot_error): Don't end warning with a
10152         newline.
10153         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10154         warning with a newline.
10155         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10156         newline.
10157         (s12z_frame_cache): Likewise.
10158         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10159         a newline.
10160         * solib-svr4.c (disable_probes_interface): Don't end warning with
10161         a newline.
10162         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10163         newline.
10164         * python/python.c (do_finish_initialization): Don't end warning
10165         with a newline.
10167 2019-06-10  Tom Tromey  <tom@tromey.com>
10169         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10170         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10171         gdbpy_enter.
10173 2019-06-10  Tom Tromey  <tromey@adacore.com>
10175         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10176         data.
10177         (elf_new_init): Don't call stabsread_new_init.
10178         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10179         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10180         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10182 2019-06-10  Tom de Vries  <tdevries@suse.de>
10184         PR symtab/16264
10185         PR symtab/24517
10186         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10188 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10190         * source.c (find_and_open_source): Also rewrite relative file
10191         names.
10193 2019-04-26  Amos Bird  <amosbird@gmail.com>
10195         * annotate.c (annotate_thread_exited): Add "thread-exited"
10196         annotation.
10198 2019-06-06  Tom Tromey  <tromey@adacore.com>
10200         * maint.h (class scoped_command_stats): Use
10201         DISABLE_COPY_AND_ASSIGN.
10202         <print_time>: New method.
10203         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10204         print_time.
10205         (scoped_command_stats::print_time): New method.
10207 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10209         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10210         instructions of lengths 6 or 8 bytes.
10212 2019-06-04  Pedro Alves  <palves@redhat.com>
10214         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10216         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10217         * breakpoint.c (condition_completer): Likewise.
10218         * cli/cli-dump.c (scan_expression): Likewise.
10219         * common/filestuff.c (mkdir_recursive): Likewise.
10220         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10221         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10222         (gdb_abspath): Likewise.
10223         * compile/compile-cplus-types.c
10224         (compile_cplus_instance::decl_name): Likewise.
10225         * completer.c (complete_explicit_location):
10226         (signal_completer, reg_or_group_completer_1): Likewise.
10227         * cp-support.c (cp_remove_params_if_any): Likewise.
10228         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10229         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10230         * infcmd.c (strip_bg_char): Likewise.
10231         * linespec.c (copy_token_string): Likewise.
10232         * mi/mi-main.c (output_cores): Likewise.
10233         * psymtab.c (psymtab_search_name):
10234         * symfile.c (test_set_ext_lang_command): Likewise.
10235         * target.c (target_fileio_read_stralloc): Likewise.
10236         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10237         * value.c (complete_internalvar): Likewise.
10239 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10241         Add objfile property to gdb.Type.
10242         * NEWS: Mention Python API addition.
10243         * python/py-type.c (typy_get_objfile): New method.
10245 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10247         * NEWS: Mention the new set|show style [title|highlight].
10248         Mention changes to "show style", "help" and "apropos".
10250 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10252         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10253         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10254         instead of print_help_for_command.
10255         (print_doc_of_command): New function.
10256         (help_list): Add 'apropos -v word' suggestion.
10257         (print_help_for_command): Style the command name using title style.
10258         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10259         (_initialize_cli_cmds): Describe -v in apropos_command help.
10261 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10263         * cli/cli-style.h (cli_style_option): Add name in constructor,
10264         add m_name class member, add constructor with intensity,
10265         add name class function.
10266         (cli_style_option::add_setshow_commands): Remove name argument.
10267         (highlight_style, title_style): New styles.
10268         * cli/cli-style.c (do_show): New function that shows a style
10269         characteristic styling the style name with itself.
10270         (set_style_name): New function.
10271         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10272         Update all callers according to the changes in cli/cli-style.h.
10273         * utils.h (fputs_highlighted): New function.
10274         * utils.c (fputs_highlighted): Likewise.
10276 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10278         * NEWS: Mention new pipe command and new convenience variables.
10280 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282         * cli/cli-cmds.c (pipe_command): New function.
10283         (_initialize_cli_cmds): Call add_com for pipe_command.
10284         Define | as an alias for pipe.
10285         (exit_status_set_internal_vars): New function.
10286         (shell_escape): Call exit_status_set_internal_vars.
10287         cli/cli-decode.c (find_command_name_length): Recognize | as
10288         a single character command.
10290 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10292         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10293         top.c (execute_command_to_ui_file): New function, mostly a copy
10294         of execute_command_to_string.
10295         (execute_command_to_string): Implement by calling
10296         execute_command_to_ui_file.
10298 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10300         * top.h (saved_command_line): Remove declaration.
10301         * top.c (previous_saved_command_line, previous_repeat_arguments):
10302         New variables.
10303         (saved_command_line): Make static, define together with other
10304         'repeat variables'.
10305         (dont_repeat): Clear repeat_arguments.
10306         (repeat_previous, get_saved_command_line, save_command_line):
10307         New functions.
10308         (gdb_init): Initialize saved_command_line
10309         and previous_saved_command_line.
10310         * main.c (captured_main_1): Remove saved_command_line initialization.
10311         * event-top.c (handle_line_of_input): Update to use
10312         the new 'repeat' related functions instead of direct access to
10313         saved_command_line.
10314         * command.h (repeat_previous, get_saved_command_line,
10315         save_command_line): New declarations.
10316         (dont_repeat): Add comment.
10318 2019-05-30  Tom Tromey  <tromey@adacore.com>
10320         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10321         Fix comment.
10322         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10324 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10326         PR cli/24587
10327         * completer.c (complete): Initialize variable word.
10329 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10331         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10332         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10333         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10334         'body' is NULL to the outter 'if', protecting the '!is_define'
10335         situation as well.
10337 2019-05-29  Tom Tromey  <tromey@adacore.com>
10339         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10340         (dwarf_unknown): New function.
10341         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10342         (dwarf_type_encoding_name): Use dwarf_unknown.
10344 2019-05-29  Tom Tromey  <tromey@adacore.com>
10346         PR c++/20020:
10347         * cp-valprint.c (cp_print_value_fields): Call
10348         cp_print_static_field inside "try".
10350 2019-05-29  Tom Tromey  <tromey@adacore.com>
10352         * inflow.c (struct terminal_info): Add default operator=.
10353         * configure: Rebuild.
10354         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10355         -Wdeprecated-copy-dtor, -Wredundant-move.
10357 2019-05-29  Tom Tromey  <tromey@adacore.com>
10359         * NEWS: Add entry.
10360         * infcmd.c (print_return_value_1): Handle finish_print
10361         option.
10362         (show_print_finish): New function.
10363         (_initialize_infcmd): Add "set/show print finish" commands.
10364         * valprint.c (user_print_options): Initialize new member.
10365         * valprint.h (struct value_print_options) <finish_print>: New
10366         member.
10368 2019-05-28  Tom Tromey  <tromey@adacore.com>
10370         * ada-lang.c (ada_remove_Xbn_suffix)
10371         (find_old_style_renaming_symbol)
10372         (parse_old_style_renaming): Remove.
10373         (ada_find_renaming_symbol): Don't call
10374         find_old_style_renaming_symbol.
10375         (ada_is_renaming_symbol): Rename from
10376         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10377         bool.  Now static.
10378         (ada_read_var_value): Update and simplify.
10379         * ada-exp.y (write_var_or_type): Remove old code.
10381 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10383         PR gdb/25010
10384         * event-top.c: Remove include comment.
10385         * inflow.c (class scoped_ignore_sigttou): Move from here...
10386         * inflow.h (class scoped_ignore_sigttou): ...to here.
10387         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10388         * top.c:  Remove include comment.
10390 2019-05-27  Tom Tromey  <tom@tromey.com>
10392         * NEWS: Fix typo.
10394 2019-05-22  Tom Tromey  <tromey@adacore.com>
10396         * target.c (target_follow_exec): Constify parameter.
10397         * target-delegates.c: Rebuild.
10398         * remote.c (remote_target::follow_exec): Constify parameter.
10399         * infrun.c (follow_exec): Constify parameter.
10400         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10401         (target_follow_exec): Likewise.
10403 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10405         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10406         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10408 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10410         * NEWS: Add debugredirect and testsuite sections.
10412 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10414         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10415         target descriptions using exclusively floating point register name
10416         aliases.
10418 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10420         PR gdb/18644:
10421         * f-lang.c (build_fortran_types): Handle the case where
10422         gdbarch_floatformat_for_type returns a nullptr.
10424 2019-05-21  Tom de Vries  <tdevries@suse.de>
10426         PR cli/24587
10427         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10429 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10431         PR gdb/18644:
10432         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10433         16-byte floats.
10434         * i386-tdep.c (i386_floatformat_for_type): Use
10435         floatformats_ia64_quad for the 16-byte floating point component
10436         within a fortran 32-byte complex number.
10438 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10440         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10441         delete default constructor.
10442         (find_partial_die): Update to return const struct.
10443         (partial_die_parent_scope): Move variable declaration into scope
10444         of its use and change its type to auto.
10445         (guess_partial_die_structure_name): Likewise.
10446         (partial_die_info::fixup): Likewise.
10448 2019-05-17  Tom Tromey  <tromey@adacore.com>
10450         * source.c (find_and_open_source): Remove cast.
10452 2019-05-17  Tom Tromey  <tromey@adacore.com>
10454         * annotate.c (annotate_source): Make "filename" const.
10455         * annotate.h (annotate_source): Use const.
10457 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10459         * disasm.c (set_disassembler_options): Send errors to stderr.
10461 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10463         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10464         (cli_interp_base::set_logging): Check debug_redirect.
10465         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10466         * cli/cli-logging.c (debug_redirect): Add static variable.
10467         (pop_output_files): Add default param.
10468         (handle_redirections): Print debug setting.
10469         (show_logging_command): Likewise.
10470         (_initialize_cli_logging): Add debugredirect command.
10471         * interps.c (current_interp_set_logging): Add debug_redirect
10472         parameter.
10473         * interps.h (set_logging): Add debug_redirect parameter.
10474         (current_interp_set_logging): Likewise.
10475         * mi/mi-common.h: Likewise.
10476         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10478 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10479             Tom Tromey  <tromey@adacore.com>
10481         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10482         directly.
10483         * cli/cli-interp.h (make_logging_output): Remove declaration.
10484         * cli/cli-logging.c (make_logging_output): Remove function.
10485         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10486         directly.
10487         * ui-file.c (tee_file::tee_file): Remove bools.
10488         (tee_file::~tee_file): Remove deletes.
10489         * ui-file.h (tee_file): Remove bools.
10491 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10493         * mi/mi-cmds.h (mi_cmd_complete): New function.
10494         * mi/mi-main.c (mi_cmd_complete): Likewise.
10495         * mi/mi-cmds.c: Define new MI command -complete.
10496         * NEWS: Mention new -complete command.
10498 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10500         * completer.h (complete): New function.
10501         * completer.c (complete): Likewise.
10502         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10503         function defined in completer.h.
10505 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10507         * MAINTAINERS (Write After Approval): Add myself.
10509 2019-05-17  Tom de Vries  <tdevries@suse.de>
10511         PR gdb/24094
10512         * dwarf2read.c (struct cu_partial_die_info): New struct.
10513         (find_partial_die): Return cu_partial_die_info.
10514         (partial_die_parent_scope, guess_partial_die_structure_name)
10515         (partial_die_info::fixup): Handle new return type of find_partial_die.
10517 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10519         PR breakpoints/24541
10520         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10521         "std::string", simplifying the algorithm.
10523 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10525         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10526         (stap_static_probe_ops::get_probes): Likewise.
10528 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10530         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10531         '-')" and "else if".
10532         (stap_parse_single_operand): Join checks for
10533         "gdbarch_stap_parse_special_token_p" and
10534         "gdbarch_stap_parse_special_token" in the same "if" statement.
10535         Invert check when verifying for operation on register
10536         displacement.
10538 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10540         * stap-probe.c (stap_get_opcode): Update comment.
10541         (stap_get_expected_argument_type): Likewise.
10542         (handle_stap_probe): Likewise.
10544 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10546         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10547         return type to 'bool'.  Adjust comment.  Use 'bool' when
10548         appropriate.
10549         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10550         * stap-probe.c (stap_parse_argument_1): Likewise.
10551         (stap_is_operator): Likewise.
10552         (stap_is_generic_prefix): Likewise.
10553         (stap_is_register_prefix): Likewise.
10554         (stap_is_register_indirection_prefix): Likewise.
10555         (stap_is_integer_prefix): Likewise.
10556         (stap_generic_check_suffix): Likewise.
10557         (stap_check_integer_suffix): Likewise.
10558         (stap_check_register_suffix): Likewise.
10559         (stap_check_register_indirection_suffix): Likewise.
10560         (stap_parse_register_operand): Likewise.
10561         (stap_parse_single_operand): Likewise.
10562         (stap_parse_argument_1): Likewise.
10563         (stap_probe::get_argument_count): Likewise.
10564         (stap_is_operator): Likewise.
10566 2019-05-16  Tom Tromey  <tromey@adacore.com>
10568         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10569         keyword to foreach.
10571 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10573         * linux-thread-db.c (try_thread_db_load_1): Change return type
10574         to bool.
10575         (try_thread_db_load): Likewise.
10576         (try_thread_db_load_from_pdir_1): Likewise.
10577         (try_thread_db_load_from_pdir): Likewise.
10578         (try_thread_db_load_from_sdir): Likewise.
10579         (try_thread_db_load_from_dir): Likewise.
10580         (thread_db_load_search): Likewise.
10581         (has_libpthread): Likewise.
10582         (thread_db_load): Likewise.
10584 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10586         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10587         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10588         NULL, and complain/return if that's the case.
10590 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10592         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10593         (advance, posn, abstract_read_memory): New functions.
10594         [struct mem_read_abstraction]: New struct.
10595         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10597 2019-05-14  Tom Tromey  <tromey@adacore.com>
10599         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10600         value is not lval_memory.
10602 2019-05-14  Tom Tromey  <tromey@adacore.com>
10604         * solib.c (info_sharedlibrary_command): Style the file name.
10606 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10608         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10609         (aarch64_vnv_type): Likewise.
10610         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10611         * common/tdesc.c: Likewise.
10612         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10613         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10614         * features/aarch64-fpu.xml: Add ieee half view.
10615         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10616         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10617         * gdbtypes.h (struct builtin_type): Likewise.
10618         (struct objfile_type): Likewise.
10620 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10622         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10623         typo.
10624         * location.h (string_to_event_location): Likewise.
10626 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10628         GDB 8.3 released.
10630 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10632         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10633         New variable declaration.
10634         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10635         New variable.
10636         (print_one_breakpoint): Use ui_out::test_flags and new global
10637         variable to compute use_fixed_output.
10638         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10639         Remove.
10640         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10641         (mi_multi_location_breakpoint_output_fixed): Remove.
10642         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10643         new variable.
10644         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10645         fix_multi_location_breakpoint_output flag if version >= 3.
10646         * ui-out.h (enum ui_out_flag)
10647         <fix_multi_location_breakpoint_output>: New enumerator.
10649 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10651         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10653 2019-05-10  Tom Tromey  <tromey@adacore.com>
10655         * ada-lang.c (catch_ada_completer): New function.
10656         (_initialize_ada_language): Use it.
10658 2019-05-10  Tom Tromey  <tromey@adacore.com>
10660         * thread.c (print_thread_info): Make "requested_threads" const.
10661         * gdbthread.h (print_thread_info): Make "requested_threads"
10662         const.
10663         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10664         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10666 2019-05-08  Tom Tromey  <tom@tromey.com>
10668         * gdbtypes.c (objfile_type_data): Change type.
10669         (objfile_type, _initialize_gdbtypes): Update.
10671 2019-05-08  Tom Tromey  <tom@tromey.com>
10673         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10674         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10675         (_initialize_dwarf2_frame): Update.
10677 2019-05-08  Tom Tromey  <tom@tromey.com>
10679         * objc-lang.c (objc_objfile_data): Change type.
10680         (find_methods): Update.
10681         (_initialize_objc_lang): Remove.
10683 2019-05-08  Tom Tromey  <tom@tromey.com>
10685         * stabsread.c (rs6000_builtin_type_data): Change type.
10686         (rs6000_builtin_type, _initialize_stabsread): Update.
10688 2019-05-08  Tom Tromey  <tom@tromey.com>
10690         * mips-tdep.c (mips_pdr_data): Remove.
10691         (_initialize_mips_tdep): Update.
10693 2019-05-08  Tom Tromey  <tom@tromey.com>
10695         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10696         (hppa_init_objfile_priv_data, read_unwind_info)
10697         (find_unwind_entry, _initialize_hppa_tdep): Update.
10699 2019-05-08  Tom Tromey  <tom@tromey.com>
10701         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10702         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10703         on obstack.
10704         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10706 2019-05-08  Tom Tromey  <tom@tromey.com>
10708         * mdebugread.c (basic_type_data): Change type.
10709         (basic_type, _initialize_mdebugread): Update.
10711 2019-05-08  Tom Tromey  <tom@tromey.com>
10713         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10715 2019-05-08  Tom Tromey  <tom@tromey.com>
10717         * nto-tdep.c (nto_inferior_data_reg): Change type.
10718         (nto_inferior_data): Update.
10719         (nto_inferior_data_cleanup, nto_new_inferior_data)
10720         (_initialize_nto_tdep): Remove.
10721         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10723 2019-05-08  Tom Tromey  <tom@tromey.com>
10725         * ada-lang.c (struct ada_inferior_data): Add initializers.
10726         (ada_inferior_data): Change type.
10727         (ada_inferior_data_cleanup): Remove.
10728         (get_ada_inferior_data, ada_inferior_exit)
10729         (struct ada_pspace_data): Add initializers, destructor.
10730         (ada_pspace_data_handle): Change type.
10731         (get_ada_pspace_data): Update.
10732         (ada_pspace_data_cleanup): Remove.
10734 2019-05-08  Tom Tromey  <tom@tromey.com>
10736         * coffread.c (struct coff_symfile_info): Add initializers.
10737         (coff_objfile_data_key): Move lower.  Change type.
10738         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10739         Update.
10740         (coff_free_info): Remove.
10742 2019-05-08  Tom Tromey  <tom@tromey.com>
10744         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10745         (fbsd_pspace_data_handle): Move lower.  Change type.
10746         (get_fbsd_pspace_data): Update.
10747         (fbsd_pspace_data_cleanup): Remove.
10748         (_initialize_fbsd_tdep): Update.
10750 2019-05-08  Tom Tromey  <tom@tromey.com>
10752         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10753         (get_ada_tasks_pspace_data): Update.
10754         (ada_tasks_pspace_data_cleanup): Remove.
10755         (_initialize_tasks): Update.
10756         (ada_tasks_inferior_data_handle): Change type.
10757         (get_ada_tasks_inferior_data): Update.
10758         (ada_tasks_inferior_data_cleanup): Remove.
10759         (struct ada_tasks_pspace_data): Add initializers.
10761 2019-05-08  Tom Tromey  <tom@tromey.com>
10763         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10764         * symfile-debug.c (debug_sym_get_probes): Change type.
10765         * stap-probe.c (handle_stap_probe):
10766         (stap_static_probe_ops::get_probes): Change type.
10767         * probe.h (class static_probe_ops) <get_probes>: Change type.
10768         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10769         (parse_probes_in_pspace): Update.
10770         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10771         Update.
10772         (any_static_probe_ops::get_probes): Change type.
10773         * elfread.c (elfread_data): New typedef.
10774         (probe_key): Change type.
10775         (elf_get_probes): Likewise.  Update.
10776         (probe_key_free): Remove.
10777         (_initialize_elfread): Update.
10778         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10779         Change type.
10780         (dtrace_process_dof_probe, dtrace_process_dof)
10781         (dtrace_static_probe_ops::get_probe): Change type.
10783 2019-05-08  Tom Tromey  <tom@tromey.com>
10785         * xcoffread.c (struct xcoff_symfile_info): Rename from
10786         coff_symfile_info.  Add initializers.
10787         (xcoff_objfile_data_key): Move lower.  Change type.
10788         (XCOFF_DATA): Rewrite.
10789         (xcoff_free_info): Remove.
10790         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10791         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10792         (xcoff_initial_scan): Update.
10794 2019-05-08  Tom Tromey  <tom@tromey.com>
10796         * solib-svr4.c (struct svr4_info): Add initializers and
10797         destructor.
10798         <probes_table>: Now an htab_up.
10799         (solib_svr4_pspace_data): Change type.
10800         (free_probes_table): Simplify.
10801         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10802         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10803         (probes_table_remove_objfile_probes, register_solib_event_probe)
10804         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10805         (_initialize_svr4_solib): Update.
10807 2019-05-08  Tom Tromey  <tom@tromey.com>
10809         * remote.c (remote_pspace_data): Change type.
10810         (remote_pspace_data_cleanup): Remove.
10811         (get_remote_exec_file, set_pspace_remote_exec_file)
10812         (_initialize_remote): Update.
10814 2019-05-08  Tom Tromey  <tom@tromey.com>
10816         * breakpoint.c (breakpoint_objfile_key): Change type.
10817         (get_breakpoint_objfile_data): Update.
10818         (free_breakpoint_objfile_data): Remove.
10819         (_initialize_breakpoint): Update.
10821 2019-05-08  Tom Tromey  <tom@tromey.com>
10823         * linux-tdep.c (struct linux_info): Add initializers.
10824         (linux_inferior_data): Move.  Change type.
10825         (invalidate_linux_cache_inf): Update.
10826         (linux_inferior_data_cleanup): Remove.
10827         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10829 2019-05-08  Tom Tromey  <tom@tromey.com>
10831         * auxv.c (auxv_inferior_data): Move.  Change type.
10832         (auxv_inferior_data_cleanup): Remove.
10833         (invalidate_auxv_cache_inf): Rewrite.
10834         (get_auxv_inferior_data, _initialize_auxv): Update.
10836 2019-05-08  Tom Tromey  <tom@tromey.com>
10838         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10839         (symfile_debug_objfile_data_key): Change type.
10840         (symfile_debug_installed, debug_qf_has_symbols)
10841         (debug_qf_find_last_source_symtab)
10842         (debug_qf_forget_cached_source_info)
10843         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10844         (debug_qf_print_stats, debug_qf_dump)
10845         (debug_qf_expand_symtabs_for_function)
10846         (debug_qf_expand_all_symtabs)
10847         (debug_qf_expand_symtabs_with_fullname)
10848         (debug_qf_map_matching_symbols)
10849         (debug_qf_expand_symtabs_matching)
10850         (debug_qf_find_pc_sect_compunit_symtab)
10851         (debug_qf_map_symbol_filenames)
10852         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10853         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10854         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10855         (debug_sym_read_linetable, debug_sym_relocate): Update.
10856         (symfile_debug_free_objfile): Remove.
10857         (install_symfile_debug_logging, _initialize_symfile_debug):
10858         Update.
10860 2019-05-08  Tom Tromey  <tom@tromey.com>
10862         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10863         allocate_on_obstack.
10864         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10865         (get_dwarf2_per_objfile): Update.
10866         (set_dwarf2_per_objfile): Remove.
10867         (dwarf2_has_info, dwarf2_get_section_info): Update.
10868         (dwarf2_free_objfile): Remove.
10869         (_initialize_dwarf2_read): Update.
10871 2019-05-08  Tom Tromey  <tom@tromey.com>
10873         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10874         initializers.
10875         <unsupported_script_warning_printed,
10876         script_not_found_warning_printed>: Now bool.
10877         (auto_load_pspace_data): Change type.
10878         (~auto_load_pspace_info): Rename from
10879         auto_load_pspace_data_cleanup.
10880         (get_auto_load_pspace_data, init_loaded_scripts_info)
10881         (clear_section_scripts, maybe_print_unsupported_script_warning)
10882         (maybe_print_script_not_found_warning, _initialize_auto_load):
10883         Update.
10885 2019-05-08  Tom Tromey  <tom@tromey.com>
10887         * objfiles.c (objfile_pspace_info): Add destructor and
10888         initializers.
10889         (objfiles_pspace_data): Change type.
10890         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10891         (get_objfile_pspace_data): Update.
10892         (objfiles_bfd_data): Change type.
10893         (get_objfile_bfd_data): Update.
10894         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10896 2019-05-08  Tom Tromey  <tom@tromey.com>
10898         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10899         Change type.
10900         (get_catch_syscall_inferior_data): Update.
10901         (catch_syscall_inferior_data_cleanup): Remove.
10902         (_initialize_break_catch_syscall): Update.
10904 2019-05-08  Tom Tromey  <tom@tromey.com>
10906         * inflow.c (struct terminal_info): Add destructor and
10907         initializers.
10908         (inflow_inferior_data): Change type.
10909         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10910         (get_inflow_inferior_data, inflow_inferior_exit)
10911         (swap_terminal_info, _initialize_inflow): Update.
10913 2019-05-08  Tom Tromey  <tom@tromey.com>
10915         * target-dcache.c (target_dcache_cleanup): Remove.
10916         (target_dcache_aspace_key): Change type.
10917         (target_dcache_init_p, target_dcache_invalidate)
10918         (target_dcache_get, target_dcache_get_or_init)
10919         (_initialize_target_dcache): Update.
10920         * dcache.h (struct dcache_deleter): New.
10922 2019-05-08  Tom Tromey  <tom@tromey.com>
10924         * symtab.c (struct symbol_cache): Add destructor and
10925         initializers.
10926         (symbol_cache_key): Move.  Change type.
10927         (make_symbol_cache, free_symbol_cache): Remove.
10928         (get_symbol_cache): Update.
10929         (symbol_cache_cleanup): Remove.
10930         (ALL_PSPACES, symbol_cache_flush)
10931         (maintenance_print_symbol_cache)
10932         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10933         Update.
10935 2019-05-08  Tom Tromey  <tom@tromey.com>
10937         * symtab.c (struct main_info): Add destructor and initializers.
10938         (main_progspace_key): Move.  Change type.
10939         (get_main_info): Update.
10940         (main_info_cleanup): Remove.
10941         (_initialize_symtab): Update.
10943 2019-05-08  Tom Tromey  <tom@tromey.com>
10945         * registry.h (DECLARE_REGISTRY): Define the _key class.
10947 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10949         * NEWS: Merge two 'New commands' sections.
10951 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10953         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10954         parameter and use Ada language definition instead.
10955         (ada_val_print_ptr): Remove unused language parameter.
10956         (ada_val_print_num): Remove language parameter and use Ada language
10957         definition instead.
10958         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10959         parameter.
10960         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10961         parameter and use Ada language definition instead.
10962         (ada_val_print_1): Update all ada_val_print_xxx calls.
10963         Remove language parameter.
10964         (ada_val_print): Update ada_val_print_1 call.
10966 2019-05-08  Tom Tromey  <tromey@adacore.com>
10968         * remote.c (remote_hw_watchpoint_limit)
10969         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10970         Now static.
10972 2019-05-08  Tom Tromey  <tromey@adacore.com>
10974         * maint.c (_initialize_maint_cmds): Move initialization code to
10975         remote.c.
10976         (watchdog, show_watchdog): Move to remote.c.
10977         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10978         "watchdog" static.
10979         (_initialize_remote): Move initialization code from maint.c.
10980         * defs.h (watchdog): Don't declare.
10982 2019-05-08  Tom Tromey  <tromey@adacore.com>
10984         * tui/tui-interp.c: Include main.h.
10985         * interps.c: Include main.h.
10986         * main.h (interpreter_p): Declare.
10987         * defs.h (interpreter_p): Don't declare.
10989 2019-05-08  Tom Tromey  <tromey@adacore.com>
10991         * dwarf2loc.c: Include dwarf2read.h.
10992         * defs.h (read_unsigned_leb128): Don't declare.
10993         * dwarf2read.h (read_unsigned_leb128): Declare.
10995 2019-05-08  Tom Tromey  <tromey@adacore.com>
10997         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10998         method.
11000 2019-05-08  Tom Tromey  <tromey@adacore.com>
11002         * utils.c (fputs_maybe_filtered): Reset style after paging, even
11003         when no wrap column is set.
11005 2019-05-08  Tom Tromey  <tromey@adacore.com>
11007         * c-lang.c (c_get_string): Handle non-C-style arrays.
11009 2019-05-08  Tom Tromey  <tromey@adacore.com>
11011         * typeprint.c (print_offset_data::update): Print the bit offset,
11012         not the number of bits remaining.
11014 2019-05-08  Tom Tromey  <tromey@adacore.com>
11016         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
11017         padding at end of comment.
11019 2019-05-08  Tom Tromey  <tromey@adacore.com>
11021         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
11022         Compare main types.
11024 2019-05-06  Tom Tromey  <tom@tromey.com>
11026         * common/scoped_mmap.c: Include common-defs.h.
11027         * common/scoped_mmap.h: Don't include config.h.
11029 2019-05-04  Tom Tromey  <tom@tromey.com>
11031         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
11032         (struct aarch64_call_info): Add initializers.
11033         <si>: Now a std::vector.
11034         (pass_on_stack, aarch64_push_dummy_call): Update.
11036 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
11037             Tom Tromey  <tom@tromey.com>
11039         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
11040         (ppc_threads): Now a std::vector.  Now static.
11041         (hwdebug_find_thread_points_by_tid)
11042         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
11043         Update.
11045 2019-05-04  Tom Tromey  <tom@tromey.com>
11047         * arc-tdep.c (arc_tdesc_init): Return bool.
11049 2019-05-04  Tom Tromey  <tom@tromey.com>
11051         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
11052         Use gdb_assert_not_reached.
11054 2019-05-04  Tom Tromey  <tom@tromey.com>
11056         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
11057         "false".
11059 2019-05-04  Tom Tromey  <tom@tromey.com>
11061         * arc-tdep.c (arc_tdesc_init): Use bool.
11063 2019-05-04  Tom Tromey  <tom@tromey.com>
11065         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
11067 2019-05-04  Tom Tromey  <tom@tromey.com>
11069         * cli/cli-cmds.c (valid_command_p): Return bool.
11071 2019-05-04  Tom Tromey  <tom@tromey.com>
11073         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
11074         * command.h (valid_user_defined_cmd_name_p): Channge return type.
11076 2019-05-04  Raul Tambre  <raul@tambre.ee>
11078         * python/lib/gdb/prompt.py (_ExtendedPrompt)
11079         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
11080         operator for comparison.
11082 2019-05-04  Tom Tromey  <tom@tromey.com>
11084         * psymtab.c (psymbol_name_matches, match_partial_symbol)
11085         (lookup_partial_symbol, print_partial_symbols)
11086         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
11087         (psymbol_compare): Update.
11088         (add_psymbol_to_bcache): Clear the entire psymbol.
11089         (maintenance_check_psymtabs): Update.
11090         * psympriv.h (struct partial_symbol): Don't derive from
11091         general_symbol_info.
11092         <obj_section, unrelocated_address, address,
11093         set_unrelocated_address>: Update.
11094         <ginfo>: New member.
11095         * dwarf-index-write.c (write_psymbols, debug_names::insert)
11096         (debug_names::write_psymbols): Update.
11098 2019-05-04  Tom de Vries  <tdevries@suse.de>
11100         * contrib/cc-with-tweaks.sh: Support -n arg.
11102 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11104         * corelow.c (core_target::detach): Ensure frame cache and
11105         register caches are cleared.
11106         inferior.c (exit_inferior_1): Likewise.
11108 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
11109             Tom Tromey  <tom@tromey.com>
11111         * dictionary.c (collate_pending_symbols_by_language): Remove
11112         "struct" from foreach.
11113         * symtab.c (lookup_global_symbol_from_objfile)
11114         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11115         foreach.
11116         * ser-tcp.c (net_open): Remove "struct" from foreach.
11117         * objfiles.c (objfile_relocate, objfile_rebase)
11118         (objfile_has_symbols): Remove "struct" from foreach.
11119         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11120         from foreach.
11121         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11122         foreach.
11123         * darwin-nat.c (thread_info_from_private_thread_info): Remove
11124         "struct" from foreach.
11125         * ada-lang.c (create_excep_cond_exprs)
11126         (ada_exception_catchpoint_cond_string): Remove "struct" from
11127         foreach.
11129 2019-05-03  Tom Tromey  <tromey@adacore.com>
11131         * ada-exp.y (convert_char_literal): Check suffix of each
11132         enumerator.
11134 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
11136         PR ada/21406:
11137         * ada-exp.y (yywrap): Don't define.
11138         * ada-lex.l (%option): Add noyywrap
11139         (yywrap): Remove.
11141 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
11143         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11144         _WIN32_WINNT to the XP level, unless already defined to a higher
11145         level.
11147         * unittests/parse-connection-spec-selftests.c:
11148         * ser-tcp.c:
11149         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11150         override.
11152         * symfile.c (find_separate_debug_file): Remove colon from the
11153         drive spec of DOS/Windows file names of the target, so that the
11154         file name produced from DEBUGDIR and the target's directory will
11155         be valid on DOS/Windows systems.
11157 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11159         * rust-lang.c (val_print_struct): Handle printing structures
11160         containing strings.
11162 2019-05-02  Tom Tromey  <tromey@adacore.com>
11164         * valarith.c (_initialize_valarith): Remove.
11166 2019-05-01  Tom Tromey  <tromey@adacore.com>
11168         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11169         bitfields.
11171 2019-05-01  Tom Tromey  <tromey@adacore.com>
11173         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11174         for big-endian copies.
11176 2019-04-30  Ali Tamur  <tamur@google.com>
11178         * dwarf2read.c (read_3_bytes): New declaration.
11179         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11180         (read_3_bytes): New function.
11182 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11184         * windows-nat.c (main_thread_id): Delete.
11185         (handle_output_debug_string): Replace main_thread_id by
11186         current_event.dwThreadId.
11187         (fake_create_process): Likewise.
11188         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11189         Do not set main_thread_id.
11190         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11191         current_event.dwThreadId.
11192         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11194 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11196         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11197         Use current_event.dwThreadId instead of main_thread_id.
11199 2019-04-30  Tom Tromey  <tromey@adacore.com>
11201         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11202         (create_excep_cond_exprs): Iterate over program spaces.
11203         (ada_exception_catchpoint_cond_string): Examine all minimal
11204         symbols for exception types.
11206 2019-04-30  Tom Tromey  <tromey@adacore.com>
11208         PR c++/24470:
11209         * dwarf2read.c (process_structure_scope): Handle case where type
11210         has template parameters but no symbol was created.
11212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11213             Chris January  <chris.january@arm.com>
11215         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11216         qualifier.
11217         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11219 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11221         * f-typeprint.c (f_print_type): Update rules for printing
11222         whitespace.
11223         (f_type_print_varspec_suffix): Likewise.
11225 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11226             Chris January  <chris.january@arm.com>
11228         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11229         function arguments.
11231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11233         * f-lang.c (build_fortran_types): Change name of void type to
11234         lower case.
11235         * f-typeprint.c (f_type_print_base): Print the name of the void
11236         type, rather than a fixed string.
11237         * f-valprint.c (f_decorations): Use lower case void string.
11239 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11240             Chris January  <chris.january@arm.com>
11242         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11243         types for Fortran.
11245 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11246             Chris January  <chris.january@arm.com>
11247             David Lecomber  <david.lecomber@arm.com>
11249         * f-exp.y (BINOP_INTRINSIC): New token.
11250         (exp): New parser rule handling BINOP_INTRINSIC.
11251         (f77_keywords): Add new builtin procedures.
11252         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11253         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11254         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11255         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11256         (print_unop_subexp_f): New function.
11257         (print_binop_subexp_f): New function.
11258         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11259         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11260         (dump_subexp_body_f): Likewise.
11261         (operator_check_f): Likewise.
11262         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11263         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11265 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11267         * expprint.c (dump_subexp_body_standard): Remove use of
11268         UNOP_KIND.
11269         * expression.h (exp_opcode): Include 'fortran-operator.def'.
11270         * f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11271         * f-lang.c (evaluate_subexp_f): Likewise.
11272         (operator_length_f): New fuction.
11273         (print_subexp_f): New function.
11274         (op_name_f): New function.
11275         (dump_subexp_body_f): New function.
11276         (operator_check_f): New function.
11277         (exp_descriptor_f): Replace standard expression handling functions
11278         with new functions.
11279         * fortran-operator.def: New file.
11280         * parse.c (operator_length_standard): Remove use of UNOP_KIND.
11281         * std-operator.def: Remove UNOP_KIND.
11283 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11285         * std-operator.def: Remove unbalanced, stray double quote
11286         character.
11288 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11289             Chris January  <chris.january@arm.com>
11290             Daniel Everett  <daniel.everett@arm.com>
11291             Nick Forrington  <nick.forrington@arm.com>
11292             Richard Bunt  <richard.bunt@arm.com>
11294         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11295         of depth when printing anonymous structs or unions.
11296         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11297         Don't print either the top-level value, or the children if the
11298         max-depth is exceeded.
11299         (ppscm_print_children): When printing the key of a map, allow one
11300         extra level of depth.
11301         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11302         print either the top-level value, or the children if the max-depth
11303         is exceeded.
11304         (print_children): When printing the key of a map, allow one extra
11305         level of depth.
11306         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11307         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11308         (user_print_options): Initialise max_depth field.
11309         (val_print_scalar_or_string_type_p): New function.
11310         (val_print): Check to see if the max depth has been reached.
11311         (val_print_check_max_depth): Define new function.
11312         (show_print_max_depth): New function.
11313         (_initialize_valprint): Add 'print max-depth' option.
11314         * valprint.h (struct value_print_options) <max_depth>: New field.
11315         (val_print_check_max_depth): Declare new function.
11316         * NEWS: Document new feature.
11318 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11320         * ada-lang.c (ada_language_defn): Initialise new field.
11321         * c-lang.c (c_is_string_type_p): New function.
11322         (c_language_defn): Initialise new field.
11323         (cplus_language_defn): Initialise new field.
11324         (asm_language_defn): Initialise new field.
11325         (minimal_language_defn): Initialise new field.
11326         * c-lang.h (c_is_string_type_p): Declare new function.
11327         * d-lang.c (d_language_defn): Initialise new field.
11328         * f-lang.c (f_is_string_type_p): New function.
11329         (f_language_defn): Initialise new field.
11330         * go-lang.c (go_is_string_type_p): New function.
11331         (go_language_defn): Initialise new field.
11332         * language.c (default_is_string_type_p): New function.
11333         (unknown_language_defn): Initialise new field.
11334         (auto_language_defn): Initialise new field.
11335         * language.h (struct language_defn) <la_is_string_type_p>: New
11336         member variable.
11337         (default_is_string_type_p): Declare new function.
11338         * m2-lang.c (m2_language_defn): Initialise new field.
11339         * objc-lang.c (objc_language_defn): Initialise new field.
11340         * opencl-lang.c (opencl_language_defn): Initialise new field.
11341         * p-lang.c (pascal_is_string_type_p): New function.
11342         (pascal_language_defn): Initialise new field.
11343         * rust-lang.c (rust_is_string_type_p): New function.
11344         (rust_language_defn): Initialise new field.
11346 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11348         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11349         New field.
11350         * ada-lang.c (ada_language_defn): Initialise new field.
11351         * c-lang.c (c_language_defn): Likewise.
11352         (cplus_language_defn): Likewise.
11353         (asm_language_defn): Likewise.
11354         (minimal_language_defn): Likewise.
11355         * d-lang.c (d_language_defn): Likewise.
11356         * f-lang.c (f_language_defn): Likewise.
11357         * go-lang.c (go_language_defn): Likewise.
11358         * language.c (unknown_language_defn): Likewise.
11359         (auto_language_defn): Likewise.
11360         * m2-lang.c (m2_language_defn): Likewise.
11361         * objc-lang.c (objc_language_defn): Likewise.
11362         * opencl-lang.c (opencl_language_defn): Likewise.
11363         * p-lang.c (pascal_language_defn): Likewise.
11364         * rust-lang.c (rust_language_defn): Likewise.
11366 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11368         * ada-lang.c (ada_is_character_type): Change return type to bool.
11369         (ada_is_string_type): Likewise.
11370         * ada-lang.h (ada_is_character_type): Update declaration
11371         (ada_is_string_type): Likewise.
11373 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11375         Support style in 'frame|thread apply'
11377         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11378         * record.c (record_start, record_stop): Update callers of
11379         execute_command_to_string with false.
11380         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11381         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11382         methods.
11383         (class string_file): New constructor with term_out parameter.
11384         Override methods term_out and can_emit_style_escape.  New member
11385         term_out.
11386         (class stdio_file): Override can_emit_style_escape.
11387         (class tee_file): Override term_out and can_emit_style_escape.
11388         * utils.h (can_emit_style_escape): Remove.
11389         * utils.c (can_emit_style_escape): Likewise.
11390         Update all callers of can_emit_style_escape (SOMESTREAM) to
11391         SOMESTREAM->can_emit_style_escape.
11392         * source-cache.c (source_cache::get_source_lines): Likewise.
11393         * stack.c (frame_apply_command_count): Call execute_command_to_string
11394         passing the term_out characteristic of the current gdb_stdout.
11395         * thread.c (thr_try_catch_cmd): Likewise.
11396         * top.c (execute_command_to_string): pass term_out parameter
11397         to construct the string_file for the command output.
11398         * ui-file.c (term_cli_styling): New function (most code moved
11399         from utils.c can_emit_style_escape).
11400         (string_file::string_file, string_file::can_emit_style_escape,
11401         stdio_file::can_emit_style_escape, tee_file::term_out,
11402         tee_file::can_emit_style_escape): New functions.
11404 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11406         * NEWS: Mention the new set|show may-call-functions.
11407         * infcall.c (may_call_functions_p): New variable.
11408         (show_may_call_functions_p): New function.
11409         (call_function_by_hand_dummy): Throws an error if not
11410         may-call-functions.
11411         (_initialize_infcall): Call add_setshow_boolean_cmd for
11412         may-call-functions.
11414 2019-04-25  Keith Seitz  <keiths@redhat.com>
11416         PR c++/24367
11417         * cp-support.c (inspect_type): Don't attempt substitutions
11418         of symbol with the same name.
11420 2019-04-25  Tom Tromey  <tromey@adacore.com>
11422         PR gdb/24475:
11423         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11424         static.
11426 2019-04-25  Tom Tromey  <tromey@adacore.com>
11428         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11429         rvalue reference.
11430         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11431         (gdb_xml_parser::parse): Use std::move.
11432         * python/python-internal.h (gdbpy_convert_exception): Take a const
11433         reference.
11434         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11435         std::move.
11436         * python/py-utils.c (gdbpy_convert_exception): Take a const
11437         reference.
11438         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11439         Use std::move.
11440         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11441         Use std::move.
11442         * mi/mi-main.c (mi_print_exception): Take a const reference.
11443         * main.c (handle_command_errors): Take a const reference.
11444         * linespec.c (parse_linespec): Use std::move.
11445         * infcall.c (run_inferior_call): Use std::move.
11446         (call_function_by_hand_dummy): Use std::move.
11447         * exec.c (try_open_exec_file): Use std::move.
11448         * exceptions.h (exception_print, exception_fprintf)
11449         (exception_print_same): Update.
11450         * exceptions.c (print_exception, exception_print)
11451         (exception_fprintf, exception_print_same): Change parameters to
11452         const reference.
11453         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11454         * common/new-op.c: Use std::move.
11455         * common/common-exceptions.h (struct gdb_exception): Add move
11456         constructor.
11457         (struct gdb_exception_error, struct gdb_exception_quit, struct
11458         gdb_quit_bad_alloc): Change constructor to move constructor.
11459         (throw_exception): Change parameter to rvalue reference.
11460         * common/common-exceptions.c (throw_exception): Take rvalue
11461         reference.
11462         * cli/cli-interp.c (safe_execute_command): Use std::move.
11463         * breakpoint.c (insert_bp_location, location_to_sals): Use
11464         std::move.
11466 2019-04-25  Tom Tromey  <tromey@adacore.com>
11468         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11469         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11470         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11471         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11472         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11473         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11474         guile/scm-value.c: Use unpack.
11475         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11476         gdbscm_gdb_exception.
11477         (gdbscm_throw_gdb_exception): Likewise.
11478         (struct gdbscm_gdb_exception): New.
11479         (unpack): New function.
11480         (gdbscm_wrap): Use unpack.
11482 2019-04-25  Tom Tromey  <tromey@adacore.com>
11484         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11485         (gdb_rl_callback_handler): Use std::move.
11486         * common/common-exceptions.h (struct gdb_exception): Add move
11487         assignment operator.
11488         (throw_exception_sjlj): Change "exception" to const reference.
11489         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11490         (throw_exception_sjlj): Change "exception" to const reference.
11492 2019-04-25  Tom Tromey  <tromey@adacore.com>
11494         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11495         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11496         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11497         Update.
11498         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11499         Update.
11500         * mi/mi-interp.c (mi_interp::exec): Update.
11501         * linespec.c (parse_linespec): Update.
11502         * infcall.c (run_inferior_call): Update.
11503         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11504         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11505         (gdbscm_lookup_global_symbol): Update.
11506         * guile/scm-param.c (gdbscm_parameter_value): Update.
11507         * guile/scm-frame.c (gdbscm_frame_read_register)
11508         (gdbscm_frame_read_var): Update.
11509         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11510         * exec.c (try_open_exec_file): Update.
11511         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11512         (gdb_rl_callback_handler): Update.
11513         * common/common-exceptions.h (exception_none): Don't declare.
11514         * common/common-exceptions.c (exception_none): Don't define.
11515         (struct catcher) <exception>: Update.
11516         * cli/cli-interp.c (safe_execute_command): Update.
11517         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11519 2019-04-25  Ali Tamur  <tamur@google.com>
11521         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11522         (read_attribute_value): Likewise.
11523         (dwarf2_read_addr_index): Update comment.
11524         (read_str_index): Add DW_FORM_strx.
11525         (dwarf2_string_attr): Likewise.
11526         (dwarf2_const_value_attr): Likewise.
11527         (dump_die_shallow): Likewise.
11528         (dwarf2_fetch_constant_bytes): Likewise.
11529         (skip_form_bytes): Likewise.
11531 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11533         PR corefiles/11608
11534         PR corefiles/18187
11535         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11536         OFFSET.  Verify if current mapping contains an ELF header.
11537         (linux_find_memory_regions_full): Adjust call to
11538         dump_mapping_p.
11540 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11541             Kang Li <kanglictf@gmail.com>
11543         PR gdb/21600
11545         * dwarf2-frame.c (read_initial_length): Be consistent about using
11546         unsigned representation of length.
11547         (decode_frame_entry_1): Likewise.  Check for wraparound of
11548         end pointer as well as buffer overflow.
11550 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11552         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11553         "vq".
11555 2019-04-24  Tom Tromey  <tromey@adacore.com>
11557         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11561         * s12z-tdep.c (s12z_unwind_pc): Delete.
11562         (s12z_unwind_sp): Delete.
11563         (s12z_gdbarch_init): Don't register deleted functions with
11564         gdbarch.
11566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11568         * rl78-tdep.c (rl78_unwind_sp): Delete.
11569         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11573         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11574         (xstormy16_unwind_pc): Delete.
11575         (xstormy16_dummy_id): Delete.
11576         (xstormy16_gdbarch_init): Don't register deleted functions with
11577         gdbarch.
11579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11581         * vax-tdep.c (vax_unwind_pc): Delete.
11582         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11586         * v850-tdep.c (v850_unwind_sp): Delete.
11587         (v850_unwind_pc): Delete.
11588         (v850_dummy_id): Delete.
11589         (v850_gdbarch_init): Don't register deleted functions with
11590         gdbarch.
11592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11594         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11595         (tilegx_unwind_pc): Delete.
11596         (tilegx_unwind_dummy_id): Delete.
11597         (tilegx_gdbarch_init): Don't register deleted functions with
11598         gdbarch.
11600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11602         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11603         (tic6x_dummy_id): Delete.
11604         (tic6x_gdbarch_init): Don't register deleted functions with
11605         gdbarch.
11607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11609         * sparc-tdep.c (sparc_unwind_pc): Delete.
11610         (sparc32_gdbarch_init): Don't register deleted function with
11611         gdbarch.
11613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11615         * sh-tdep.c (sh_unwind_sp): Delete.
11616         (sh_unwind_pc): Delete.
11617         (sh_dummy_id): Delete.
11618         (sh_gdbarch_init): Don't register deleted functions with
11619         gdbarch.
11621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11623         * score-tdep.c (score_unwind_sp): Delete.
11624         (score_unwind_pc): Delete.
11625         (score_dummy_id): Delete.
11626         (score_gdbarch_init): Don't register deleted functions with
11627         gdbarch.
11629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11631         * rx-tdep.c (rx_unwind_pc): Delete.
11632         (rx_unwind_sp): Delete.
11633         (rx_dummy_id): Delete.
11634         (rx_gdbarch_init): Don't register deleted functions with
11635         gdbarch.  Update comment.
11637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11639         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11640         (rs6000_dummy_id): Delete.
11641         (rs6000_gdbarch_init): Don't register deleted functions with
11642         gdbarch.
11644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11646         * or1k-tdep.c (or1k_dummy_id): Delete.
11647         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11651         * nios2-tdep.c (nios2_dummy_id): Delete.
11652         (nios2_unwind_sp): Delete.
11653         (nios2_gdbarch_init): Don't register deleted functions with
11654         gdbarch.
11656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11658         * nds32-tdep.c (nds32_dummy_id): Delete.
11659         (nds32_unwind_pc): Delete.
11660         (nds32_unwind_sp): Delete.
11661         (nds32_gdbarch_init): Don't register deleted functions with
11662         gdbarch.
11664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11666         * msp430-tdep.c (msp430_unwind_pc): Delete.
11667         (msp430_unwind_sp): Delete.
11668         (msp430_dummy_id): Delete.
11669         (msp430_gdbarch_init): Don't register deleted functions with
11670         gdbarch.
11672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11674         * moxie-tdep.c (moxie_unwind_sp): Delete.
11675         (moxie_unwind_pc): Delete.
11676         (moxie_dummy_id): Delete.
11677         (moxie_gdbarch_init): Don't register deleted functions with
11678         gdbarch.
11680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11682         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11683         (mn10300_unwind_pc): Delete.
11684         (mn10300_unwind_sp): Delete.
11685         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11686         mn10300_unwind_sp.
11687         (mn10300_frame_unwind_init): Don't register deleted functions with
11688         gdbarch.
11690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11692         * mep-tdep.c (mep_unwind_pc): Delete.
11693         (mep_unwind_sp): Delete.
11694         (mep_dummy_id): Delete.
11695         (mep_gdbarch_init): Don't register deleted functions with
11696         gdbarch.
11698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11700         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11701         (m68hc11_unwind_sp): Delete.
11702         (m68hc11_gdbarch_init): Don't register deleted functions with
11703         gdbarch.
11705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11707         * m32r-tdep.c (m32r_unwind_sp): Delete.
11708         (m32r_unwind_pc): Delete.
11709         (m32r_dummy_id): Delete.
11710         (m32r_gdbarch_init): Don't register deleted functions with
11711         gdbarch.
11713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11715         * m32c-tdep.c (m32c_unwind_pc): Delete.
11716         (m32c_unwind_sp): Delete.
11717         (m32c_dummy_id): Delete.
11718         (m32c_gdbarch_init): Don't register deleted functions with
11719         gdbarch.
11721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11723         * lm32-tdep.c (lm32_unwind_sp): Delete.
11724         (lm32_unwind_pc): Delete.
11725         (lm32_dummy_id): Delete.
11726         (lm32_gdbarch_init): Don't register deleted functions with
11727         gdbarch.
11729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11731         * iq2000-tdep.c (iq2000_unwind_sp): Delete.
11732         (iq2000_unwind_pc): Delete.
11733         (iq2000_dummy_id): Delete.
11734         (iq2000_gdbarch_init): Don't register deleted functions with
11735         gdbarch.
11737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11739         * nds32-tdep.c (nds32_type_align): Delete.
11740         (nds32_push_dummy_call): Use type_align instead.
11742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11744         * arm-tdep.c (arm_type_align): Only handle vector override case.
11745         (arm_push_dummy_call): Use type_align.
11746         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11750         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11751         case.
11752         (pass_on_stack): Use type_align.
11753         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11754         function.
11756 2019-04-23  Tom Tromey  <tromey@adacore.com>
11758         * dwarf2read.c (line_header::file_name_at): Remove unused
11759         overload.
11761 2019-04-23  Tom de Vries  <tdevries@suse.de>
11763         PR gdb/24438
11764         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11765         invocation.
11768 2019-03-27  Ali Tamur  <tamur@google.com>
11770         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11771         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11772         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11773         (dwarf_expr_context::get_addr_index): Likewise
11774         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11775         (symbol_needs_eval_context::get_addr_index): Likewise
11776         (disassemble_dwarf_expression): Add DW_OP_addrx
11777         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11778         (read_cutu_die_from_dwo): Update comment
11779         (skip_one_die): Add DW_FORM_addrx
11780         (read_attribute_value): Likewise
11781         (var_decode_location): Add DW_OP_addrx
11782         (dwarf2_const_value_attr): Add DW_FORM_addrx
11783         (dump_die_shallow): Likewise
11784         (dwarf2_fetch_constant_bytes): Likewise
11785         (decode_locdesc): Add DW_OP_addrx
11786         (skip_form_bytes): Add DW_FORM_addrx
11788 2019-04-22  Ali Tamur  <tamur@google.com>
11790         * MAINTAINERS (Write After Approval): Add self.
11792 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11794         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11795         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11796         (open_symbol_file_object): Likewise.
11797         (svr4_default_sos): Add info parameter.
11798         (svr4_read_so_list): Likewise.
11799         (svr4_current_sos_direct): Adjust functions calls to pass down
11800         info.
11801         (svr4_current_sos_1): Add info parameter.
11802         (svr4_current_sos): Call get_svr4_info, pass info down to
11803         svr4_current_sos_1.
11804         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11805         get_svr4_info.
11806         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11807         get_svr4_info.
11808         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11809         to get_svr4_info.
11810         (probes_table_remove_objfile_probes): Likewise.
11811         (register_solib_event_probe): Add info parameter.
11812         (solist_update_incremental): Pass info parameter down to
11813         svr4_read_so_list.
11814         (disable_probes_interface): Add info parameter.
11815         (svr4_handle_solib_event): Pass current_program_space to
11816         get_svr4_info.  Adjust disable_probes_interface cleanup.
11817         (svr4_create_probe_breakpoints): Add info parameter, pass it
11818         down to register_solib_event_probe.
11819         (svr4_create_solib_event_breakpoints): Add info parameter,
11820         pass it down to svr4_create_probe_breakpoints.
11821         (enable_break): Pass info down to
11822         svr4_create_solib_event_breakpoints.
11823         (svr4_solib_create_inferior_hook): Pass current_program_space to
11824         get_svr4_info.
11825         (svr4_clear_solib): Likewise.
11827 2019-04-22  Pedro Alves  <palves@redhat.com>
11829         * solib-svr4.c (svr4_free_objfile_observer): New.
11830         (probe_and_action::objfile): New field.
11831         (probes_table_htab_remove_objfile_probes)
11832         (probes_table_remove_objfile_probes): New functions.
11833         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11834         in the new probe_and_action.  Don't store the probe in 'lookup'.
11835         (svr4_create_probe_breakpoints): Pass objfile to
11836         register_solib_event_probe.
11837         (_initialize_svr4_solib): Register a free_objfile observer.
11839 2019-04-19  Tom Tromey  <tom@tromey.com>
11841         * common/queue.h: Remove.
11843 2019-04-19  Tom Tromey  <tom@tromey.com>
11845         * event-loop.c: Don't include "common/queue.h".
11847 2019-04-19  Tom Tromey  <tom@tromey.com>
11849         * remote.c (remote_target): Use delete.
11850         * remote-notif.h: Include <list>, not "common/queue.h".
11851         (notif_client_p): Remove typedef.
11852         (remote_notif_state): Add constructor, destructor, initializer.
11853         <notif_queue>: Now a std::list.
11854         (remote_notif_state_xfree): Don't declare.
11855         * remote-notif.c (remote_notif_process, handle_notification)
11856         (remote_notif_state_allocate): Update.
11857         (~remote_notif_state): Rename from remote_notif_state_xfree.
11859 2019-04-19  Tom Tromey  <tom@tromey.com>
11861         * symfile.c (reread_symbols): Update.
11862         * objfiles.c (objfile_register_static_link)
11863         (objfile_lookup_static_link): Update
11864         (~objfile) Don't delete static_links.
11865         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11867 2019-04-19  Tom Tromey  <tom@tromey.com>
11869         * type-stack.h (struct type_stack) <insert>: Constify string.
11870         * type-stack.c (type_stack::insert): Constify string.
11871         * gdbtypes.h (lookup_template_type): Update.
11872         (address_space_name_to_int): Update.
11873         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11874         const.
11875         (lookup_template_type): Make name const.
11876         * c-exp.y: Update rules.
11877         (lex_one_token, classify_name, classify_inner_name)
11878         (c_print_token): Update.
11879         * p-exp.y: Update rules.
11880         (yylex): Update.
11881         * f-exp.y: Update rules.
11882         (yylex): Update.
11883         * d-exp.y: Update rules.
11884         (lex_one_token, classify_name, classify_inner_name): Update.
11885         * parse.c (write_dollar_variable, copy_name): Return std::string.
11886         * parser-defs.h (copy_name): Change return type.
11887         * m2-exp.y: Update rules.
11888         (yylex): Update.
11889         * go-exp.y (lex_one_token): Update.
11890         Update rules.
11891         (classify_unsafe_function, classify_packaged_name)
11892         (classify_name, yylex): Update.
11894 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11896         * configure.ac: add --enable-source-highlight switch.
11897         * configure: Regenerate.
11898         * top.c (print_gdb_version): plumb --enable-source-highlight
11899         status to "show configuration".
11901 2019-04-19  Tom Tromey  <tromey@adacore.com>
11903         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11904         Check ADA_TYPE_P.
11905         (empty_record, ada_template_to_fixed_record_type_1)
11906         (template_to_static_fixed_type)
11907         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11908         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11909         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11910         macros.
11912 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11914         PR symtab/24423:
11915         * source.c (print_source_lines_base): Advance "iter" when a
11916         control character is seen.
11918 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11920         * inferior.h (struct infcall_suspend_state_deleter):
11921         Catch exception in destructor to avoid crash.
11923 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11925         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11926         close to the add_com "shell".
11928 2019-04-18  Tom Tromey  <tromey@adacore.com>
11930         * process-stratum-target.h (class process_stratum_target)
11931         <stratum>: Add "final".
11933 2019-04-17  Tom Tromey  <tromey@adacore.com>
11935         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11936         against nullptr before use.
11938 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11940         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11942 2019-04-17  Jim Wilson  <jimw@sifive.com>
11943             Andrew Burgess  <andrew.burgess@embecosm.com>
11945         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11946         code read might fail, assume 4-byte breakpoint in that case.
11948 2019-04-15  Leszek Swirski  <leszeks@google.com>
11950         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11951         rather than a hand-rolled POD check when checking for forced MEMORY
11952         classification.
11954 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11956         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11957         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11958         function.
11959         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11960         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11961         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11962         declaration.
11964 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11966         * aarch64-linux-nat.c
11967         (aarch64_linux_nat_target::thread_architecture): Add override.
11968         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11969         each VQ.
11971 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11973         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11975 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11977         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11978         target types of size 96-bits, add some additional comments, and
11979         check that the builtin type we found was the correct size.
11981 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11983         * utils.c (prompt_for_continue): Don't restore the styling at the
11984         end, as applied_style has the wrong value.  This fixes styling in
11985         long lists of file names that are interrupted by the "Continue?"
11986         prompt.
11988 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11990         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11991         * c-lang.c (c_language_defn): Likewise.
11992         (cplus_language_defn): Likewise.
11993         (asm_language_defn): Likewise.
11994         (minimal_language_defn): Likewise.
11995         * d-lang.c (d_language_defn): Likewise.
11996         * f-lang.c (f_language_defn): Likewise.
11997         * go-lang.c (go_language_defn): Likewise.
11998         * language.c (unknown_language_defn): Likewise.
11999         (auto_language_defn): Likewise.
12000         * language.h (struct language_defn): Remove la_magic field.
12001         (LANG_MAGIC): Delete.
12002         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
12003         * objc-lang.c (objc_language_defn): Likewise.
12004         * opencl-lang.c (opencl_language_defn): Likewise.
12005         * p-lang.c (pascal_language_defn): Likewise.
12006         * rust-lang.c (rust_language_defn): Likewise.
12008 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
12010         * riscv-tdep.c (riscv_type_align): New function.
12011         (riscv_type_alignment): Delete.
12012         (riscv_arg_location): Use 'type_align'.
12013         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
12015 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
12017         * gdbtypes.c (type_align): A struct with no non-static fields also
12018         has alignment of 1.
12020 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
12022         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
12023         component to 0.
12024         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
12025         member.
12026         (riscv_struct_info::analyse): New implementation using new
12027         analyse_inner member function.
12028         (riscv_struct_info::field_offset): New member function.
12029         (riscv_struct_info::m_offsets): New member variable.
12030         (riscv_struct_info::analyse_inner): New private member function,
12031         takes the old implementation of riscv_struct_info::analyse but
12032         extended to track field offsets.
12033         (riscv_call_arg_struct): Update the struct folding special cases
12034         to handle cases where empty C++ structs, which are non-zero
12035         length, are found.
12036         (riscv_arg_location): Initialise the length of each location, a
12037         non-zero length now indicates the location is in use.
12038         (riscv_push_dummy_call): Allow for the first location having a
12039         non-zero offset when setting up arguments.
12040         (riscv_return_value): Likewise, but for return values.
12042 2019-04-11  Tom Tromey  <tromey@adacore.com>
12044         * utils.c (internal_vproblem): Make "msg" const.
12046 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
12048         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
12049         * trad-frame.c (trad_frame_reset_saved_regs): New function.
12050         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
12051         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
12053 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
12055         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
12056         function.
12057         (fill_gregset): Call amd64_linux_collect_native_gregset instead
12058         of amd64_collect_native_gregset.
12059         (amd64_linux_nat_target::store_registers): Likewise.
12061 2019-04-10  Tom Tromey  <tom@tromey.com>
12063         * symtab.c (lookup_global_symbol_from_objfile)
12064         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
12065         * objfiles.h (class separate_debug_iterator): New.
12066         (class separate_debug_range): New.
12067         (struct objfile) <separate_debug_objfiles>: New method.
12068         (objfile_separate_debug_iterate): Don't declare.
12069         * objfiles.c (separate_debug_iterator::operator++): Rename from
12070         objfile_separate_debug_iterate.
12071         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
12072         iterator.
12073         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
12074         iterator.
12076 2019-04-10  Tom Tromey  <tom@tromey.com>
12078         * symfile.c (reread_symbols): Remove old comment.
12079         * objfiles.c (free_all_objfiles): Fix a typo.
12081 2019-04-10  Tom Tromey  <tom@tromey.com>
12083         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
12084         * minsyms.c (lookup_minimal_symbol): Use foreach.
12085         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
12086         (lookup_minimal_symbol_solib_trampoline): Likewise.
12087         * symfile.c (reread_symbols): Use foreach.
12089 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
12090             Tom Tromey  <tromey@adacore.com>
12092         PR rust/24414:
12093         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
12094         (rust_lex_int_test): Change "value" to be LONGEST.
12095         (rust_lex_tests): Add test for long integer literal.
12097 2019-04-09  Tom Tromey  <tromey@adacore.com>
12099         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
12100         to bool.
12101         (extended_remote_target::attach): Update.
12102         (remote_target::remote_notice_new_inferior): Update.
12103         (remote_target::add_current_inferior_and_thread): Update.
12104         * inferior.c (exit_inferior_1): Use "false".
12105         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12107 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
12109         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
12110         the "start" command.
12112 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12114         * python/py-inferior.c (infpy_thread_from_thread_handle):
12115         Adjust comments to reflect renaming of thread_from_thread_handle
12116         to thread_from_handle.  Adjust keywords.  Fix type error message.
12117         (inferior_object_methods): Add thread_from_handle.  Retain
12118         thread_from_thread_handle, but mark it as deprecated.
12120 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12122         * gdbthread.h (find_thread_by_handle): Revise declaration.
12123         * thread.c (find_thread_by_handle): Likewise.  Adjust
12124         implementation too.
12125         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12126         support for buffer objects as handles.
12128 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12130         * python/py-infthread.c (thpy_thread_handle): New function.
12131         (thread_object_methods): Register thpy_thread_handle.
12133 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12135         * gdbthread.h (thread_to_thread_handle): Declare.
12136         * thread.c (gdbtypes.h): Include.
12137         (thread_to_thread_handle): New function.
12139         * target.h (struct target_ops): Add thread_info_to_thread_handle.
12140         (target_thread_info_to_thread_handle): Declare.
12141         * target.c (target_thread_info_to_thread_handle): New function.
12142         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12143         * target-delegates.c: Regenerate.
12145         * linux-thread-db.c (class thread_db_target): Add method
12146         thread_info_to_thread_handle.
12147         (thread_db_target::thread_info_to_thread_handle): Define.
12148         * remote.c (class remote_target): Add new method
12149         thread_info_to_thread_handle.
12150         (remote_target::thread_info_to_thread_handle): Define.
12152 2019-04-08  Pedro Alves  <palves@redhat.com>
12154         * common/common-exceptions.c (throw_exception): Don't create
12155         named object to throw; throw directly.
12156         (throw_it): Likewise.  Don't initialize gdb_exception::message
12157         here, with new; pass FMT and AP to the ctor instead.
12158         * common/common-exceptions.h: Include <string>.
12159         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12160         const char *, va_list)): New ctor.  Use std::make_shared.
12161         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12162         errors)): Delete.
12163         (gdb_exception_error::gdb_exception_error(enum errors, const char
12164         *, va_list)): New.
12165         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12166         Add assertion.
12167         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12168         errors)): Delete.
12169         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12170         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12171         Add assertion.
12173 2019-04-08  Tom Tromey  <tom@tromey.com>
12175         * valops.c (value_rtti_indirect_type): Replace throw_exception
12176         with throw.
12177         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12178         with throw.
12179         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12180         throw.
12181         * target.c (target_translate_tls_address): Replace throw_exception
12182         with throw.
12183         * stack.c (frame_apply_command_count): Replace throw_exception
12184         with throw.
12185         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12186         throw.
12187         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12188         with throw.
12189         * rs6000-tdep.c (rs6000_frame_cache)
12190         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12191         * remote.c: Replace throw_exception with throw.
12192         * record-full.c (record_full_message, record_full_wait_1)
12193         (record_full_restore): Replace throw_exception with throw.
12194         * record-btrace.c:
12195         (get_thread_current_frame_id, record_btrace_start_replaying)
12196         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12197         (cmd_record_btrace_start): Replace throw_exception with throw.
12198         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12199         throw.
12200         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12201         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12202         * linespec.c:
12203         (find_linespec_symbols): Replace throw_exception with throw.
12204         * infrun.c (displaced_step_prepare, resume): Replace
12205         throw_exception with throw.
12206         * infcmd.c (post_create_inferior): Replace throw_exception with
12207         throw.
12208         * inf-loop.c (inferior_event_handler): Replace throw_exception
12209         with throw.
12210         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12211         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12212         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12213         (get_prev_frame_always, get_frame_pc_if_available)
12214         (get_frame_address_in_block_if_available, get_frame_language):
12215         Replace throw_exception with throw.
12216         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12217         throw_exception with throw.
12218         * eval.c (fetch_subexp_value, evaluate_var_value)
12219         (evaluate_funcall, evaluate_subexp_standard): Replace
12220         throw_exception with throw.
12221         * dwarf2loc.c (call_site_find_chain)
12222         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12223         Replace throw_exception with throw.
12224         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12225         with throw.
12226         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12227         throw.
12228         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12229         * completer.c (complete_line_internal): Replace throw_exception
12230         with throw.
12231         * compile/compile-object-run.c (compile_object_run): Replace
12232         throw_exception with throw.
12233         * cli/cli-script.c (process_next_line): Replace throw_exception
12234         with throw.
12235         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12236         (btrace_enable, btrace_maint_update_pt_packets): Replace
12237         throw_exception with throw.
12238         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12239         throw_exception with throw.
12240         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12241         throw_exception with throw.
12242         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12243         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12244         * aarch64-tdep.c (aarch64_make_prologue_cache)
12245         (aarch64_make_stub_cache): Replace throw_exception with throw.
12247 2019-04-08  Tom Tromey  <tom@tromey.com>
12249         * common/common-exceptions.c (throw_exception): Rename from
12250         throw_exception_cxx.  Remove old copy.  Make argument const.
12251         (throw_it): Create and throw exception objects directly.
12252         * common/common-exceptions.h (throw_exception): Make argument
12253         const.
12254         (struct gdb_exception_error): Add constructor.
12255         (struct gdb_exception_quit): Add constructor.
12257 2019-04-08  Tom Tromey  <tom@tromey.com>
12259         * common/common-exceptions.h (exception_rethrow): Don't declare.
12260         (TRY_SJLJ): Update comment.
12261         (TRY, CATCH, END_CATCH): Remove.
12262         * common/common-exceptions.c (exception_rethrow): Remove.
12264 2019-04-08  Tom Tromey  <tom@tromey.com>
12266         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12267         Remove.
12268         (gdb_exception_error): Rename from
12269         gdb_exception_RETURN_MASK_ERROR.
12270         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12271         (gdb_quit_bad_alloc): Update.
12272         * aarch64-tdep.c: Update.
12273         * ada-lang.c: Update.
12274         * ada-typeprint.c: Update.
12275         * ada-valprint.c: Update.
12276         * amd64-tdep.c: Update.
12277         * arch-utils.c: Update.
12278         * break-catch-throw.c: Update.
12279         * breakpoint.c: Update.
12280         * btrace.c: Update.
12281         * c-varobj.c: Update.
12282         * cli/cli-cmds.c: Update.
12283         * cli/cli-interp.c: Update.
12284         * cli/cli-script.c: Update.
12285         * common/common-exceptions.c: Update.
12286         * common/new-op.c: Update.
12287         * common/selftest.c: Update.
12288         * compile/compile-c-symbols.c: Update.
12289         * compile/compile-cplus-symbols.c: Update.
12290         * compile/compile-object-load.c: Update.
12291         * compile/compile-object-run.c: Update.
12292         * completer.c: Update.
12293         * corelow.c: Update.
12294         * cp-abi.c: Update.
12295         * cp-support.c: Update.
12296         * cp-valprint.c: Update.
12297         * darwin-nat.c: Update.
12298         * disasm-selftests.c: Update.
12299         * dtrace-probe.c: Update.
12300         * dwarf-index-cache.c: Update.
12301         * dwarf-index-write.c: Update.
12302         * dwarf2-frame-tailcall.c: Update.
12303         * dwarf2-frame.c: Update.
12304         * dwarf2loc.c: Update.
12305         * dwarf2read.c: Update.
12306         * eval.c: Update.
12307         * event-loop.c: Update.
12308         * event-top.c: Update.
12309         * exec.c: Update.
12310         * f-valprint.c: Update.
12311         * fbsd-tdep.c: Update.
12312         * frame-unwind.c: Update.
12313         * frame.c: Update.
12314         * gdbtypes.c: Update.
12315         * gnu-v3-abi.c: Update.
12316         * guile/guile-internal.h: Update.
12317         * guile/scm-block.c: Update.
12318         * guile/scm-breakpoint.c: Update.
12319         * guile/scm-cmd.c: Update.
12320         * guile/scm-disasm.c: Update.
12321         * guile/scm-frame.c: Update.
12322         * guile/scm-lazy-string.c: Update.
12323         * guile/scm-math.c: Update.
12324         * guile/scm-param.c: Update.
12325         * guile/scm-ports.c: Update.
12326         * guile/scm-pretty-print.c: Update.
12327         * guile/scm-symbol.c: Update.
12328         * guile/scm-symtab.c: Update.
12329         * guile/scm-type.c: Update.
12330         * guile/scm-value.c: Update.
12331         * i386-linux-tdep.c: Update.
12332         * i386-tdep.c: Update.
12333         * inf-loop.c: Update.
12334         * infcall.c: Update.
12335         * infcmd.c: Update.
12336         * infrun.c: Update.
12337         * jit.c: Update.
12338         * language.c: Update.
12339         * linespec.c: Update.
12340         * linux-fork.c: Update.
12341         * linux-nat.c: Update.
12342         * linux-tdep.c: Update.
12343         * linux-thread-db.c: Update.
12344         * main.c: Update.
12345         * mi/mi-cmd-break.c: Update.
12346         * mi/mi-cmd-stack.c: Update.
12347         * mi/mi-interp.c: Update.
12348         * mi/mi-main.c: Update.
12349         * objc-lang.c: Update.
12350         * p-valprint.c: Update.
12351         * parse.c: Update.
12352         * ppc-linux-tdep.c: Update.
12353         * printcmd.c: Update.
12354         * python/py-arch.c: Update.
12355         * python/py-breakpoint.c: Update.
12356         * python/py-cmd.c: Update.
12357         * python/py-finishbreakpoint.c: Update.
12358         * python/py-frame.c: Update.
12359         * python/py-framefilter.c: Update.
12360         * python/py-gdb-readline.c: Update.
12361         * python/py-inferior.c: Update.
12362         * python/py-infthread.c: Update.
12363         * python/py-lazy-string.c: Update.
12364         * python/py-linetable.c: Update.
12365         * python/py-objfile.c: Update.
12366         * python/py-param.c: Update.
12367         * python/py-prettyprint.c: Update.
12368         * python/py-progspace.c: Update.
12369         * python/py-record-btrace.c: Update.
12370         * python/py-record.c: Update.
12371         * python/py-symbol.c: Update.
12372         * python/py-type.c: Update.
12373         * python/py-unwind.c: Update.
12374         * python/py-utils.c: Update.
12375         * python/py-value.c: Update.
12376         * python/python.c: Update.
12377         * record-btrace.c: Update.
12378         * record-full.c: Update.
12379         * remote-fileio.c: Update.
12380         * remote.c: Update.
12381         * riscv-tdep.c: Update.
12382         * rs6000-aix-tdep.c: Update.
12383         * rs6000-tdep.c: Update.
12384         * rust-exp.y: Update.
12385         * rust-lang.c: Update.
12386         * s390-tdep.c: Update.
12387         * selftest-arch.c: Update.
12388         * solib-dsbt.c: Update.
12389         * solib-frv.c: Update.
12390         * solib-spu.c: Update.
12391         * solib-svr4.c: Update.
12392         * solib.c: Update.
12393         * sparc64-linux-tdep.c: Update.
12394         * stack.c: Update.
12395         * symfile-mem.c: Update.
12396         * symmisc.c: Update.
12397         * target.c: Update.
12398         * thread.c: Update.
12399         * top.c: Update.
12400         * tracefile-tfile.c: Update.
12401         * tui/tui.c: Update.
12402         * typeprint.c: Update.
12403         * unittests/cli-utils-selftests.c: Update.
12404         * unittests/parse-connection-spec-selftests.c: Update.
12405         * valops.c: Update.
12406         * valprint.c: Update.
12407         * value.c: Update.
12408         * varobj.c: Update.
12409         * windows-nat.c: Update.
12410         * x86-linux-nat.c: Update.
12411         * xml-support.c: Update.
12413 2019-04-08  Tom Tromey  <tom@tromey.com>
12415         * xml-support.c: Use C++ exception handling.
12416         * x86-linux-nat.c: Use C++ exception handling.
12417         * windows-nat.c: Use C++ exception handling.
12418         * varobj.c: Use C++ exception handling.
12419         * value.c: Use C++ exception handling.
12420         * valprint.c: Use C++ exception handling.
12421         * valops.c: Use C++ exception handling.
12422         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12423         handling.
12424         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12425         * typeprint.c: Use C++ exception handling.
12426         * tui/tui.c: Use C++ exception handling.
12427         * tracefile-tfile.c: Use C++ exception handling.
12428         * top.c: Use C++ exception handling.
12429         * thread.c: Use C++ exception handling.
12430         * target.c: Use C++ exception handling.
12431         * symmisc.c: Use C++ exception handling.
12432         * symfile-mem.c: Use C++ exception handling.
12433         * stack.c: Use C++ exception handling.
12434         * sparc64-linux-tdep.c: Use C++ exception handling.
12435         * solib.c: Use C++ exception handling.
12436         * solib-svr4.c: Use C++ exception handling.
12437         * solib-spu.c: Use C++ exception handling.
12438         * solib-frv.c: Use C++ exception handling.
12439         * solib-dsbt.c: Use C++ exception handling.
12440         * selftest-arch.c: Use C++ exception handling.
12441         * s390-tdep.c: Use C++ exception handling.
12442         * rust-lang.c: Use C++ exception handling.
12443         * rust-exp.y: Use C++ exception handling.
12444         * rs6000-tdep.c: Use C++ exception handling.
12445         * rs6000-aix-tdep.c: Use C++ exception handling.
12446         * riscv-tdep.c: Use C++ exception handling.
12447         * remote.c: Use C++ exception handling.
12448         * remote-fileio.c: Use C++ exception handling.
12449         * record-full.c: Use C++ exception handling.
12450         * record-btrace.c: Use C++ exception handling.
12451         * python/python.c: Use C++ exception handling.
12452         * python/py-value.c: Use C++ exception handling.
12453         * python/py-utils.c: Use C++ exception handling.
12454         * python/py-unwind.c: Use C++ exception handling.
12455         * python/py-type.c: Use C++ exception handling.
12456         * python/py-symbol.c: Use C++ exception handling.
12457         * python/py-record.c: Use C++ exception handling.
12458         * python/py-record-btrace.c: Use C++ exception handling.
12459         * python/py-progspace.c: Use C++ exception handling.
12460         * python/py-prettyprint.c: Use C++ exception handling.
12461         * python/py-param.c: Use C++ exception handling.
12462         * python/py-objfile.c: Use C++ exception handling.
12463         * python/py-linetable.c: Use C++ exception handling.
12464         * python/py-lazy-string.c: Use C++ exception handling.
12465         * python/py-infthread.c: Use C++ exception handling.
12466         * python/py-inferior.c: Use C++ exception handling.
12467         * python/py-gdb-readline.c: Use C++ exception handling.
12468         * python/py-framefilter.c: Use C++ exception handling.
12469         * python/py-frame.c: Use C++ exception handling.
12470         * python/py-finishbreakpoint.c: Use C++ exception handling.
12471         * python/py-cmd.c: Use C++ exception handling.
12472         * python/py-breakpoint.c: Use C++ exception handling.
12473         * python/py-arch.c: Use C++ exception handling.
12474         * printcmd.c: Use C++ exception handling.
12475         * ppc-linux-tdep.c: Use C++ exception handling.
12476         * parse.c: Use C++ exception handling.
12477         * p-valprint.c: Use C++ exception handling.
12478         * objc-lang.c: Use C++ exception handling.
12479         * mi/mi-main.c: Use C++ exception handling.
12480         * mi/mi-interp.c: Use C++ exception handling.
12481         * mi/mi-cmd-stack.c: Use C++ exception handling.
12482         * mi/mi-cmd-break.c: Use C++ exception handling.
12483         * main.c: Use C++ exception handling.
12484         * linux-thread-db.c: Use C++ exception handling.
12485         * linux-tdep.c: Use C++ exception handling.
12486         * linux-nat.c: Use C++ exception handling.
12487         * linux-fork.c: Use C++ exception handling.
12488         * linespec.c: Use C++ exception handling.
12489         * language.c: Use C++ exception handling.
12490         * jit.c: Use C++ exception handling.
12491         * infrun.c: Use C++ exception handling.
12492         * infcmd.c: Use C++ exception handling.
12493         * infcall.c: Use C++ exception handling.
12494         * inf-loop.c: Use C++ exception handling.
12495         * i386-tdep.c: Use C++ exception handling.
12496         * i386-linux-tdep.c: Use C++ exception handling.
12497         * guile/scm-value.c: Use C++ exception handling.
12498         * guile/scm-type.c: Use C++ exception handling.
12499         * guile/scm-symtab.c: Use C++ exception handling.
12500         * guile/scm-symbol.c: Use C++ exception handling.
12501         * guile/scm-pretty-print.c: Use C++ exception handling.
12502         * guile/scm-ports.c: Use C++ exception handling.
12503         * guile/scm-param.c: Use C++ exception handling.
12504         * guile/scm-math.c: Use C++ exception handling.
12505         * guile/scm-lazy-string.c: Use C++ exception handling.
12506         * guile/scm-frame.c: Use C++ exception handling.
12507         * guile/scm-disasm.c: Use C++ exception handling.
12508         * guile/scm-cmd.c: Use C++ exception handling.
12509         * guile/scm-breakpoint.c: Use C++ exception handling.
12510         * guile/scm-block.c: Use C++ exception handling.
12511         * guile/guile-internal.h: Use C++ exception handling.
12512         * gnu-v3-abi.c: Use C++ exception handling.
12513         * gdbtypes.c: Use C++ exception handling.
12514         * frame.c: Use C++ exception handling.
12515         * frame-unwind.c: Use C++ exception handling.
12516         * fbsd-tdep.c: Use C++ exception handling.
12517         * f-valprint.c: Use C++ exception handling.
12518         * exec.c: Use C++ exception handling.
12519         * event-top.c: Use C++ exception handling.
12520         * event-loop.c: Use C++ exception handling.
12521         * eval.c: Use C++ exception handling.
12522         * dwarf2read.c: Use C++ exception handling.
12523         * dwarf2loc.c: Use C++ exception handling.
12524         * dwarf2-frame.c: Use C++ exception handling.
12525         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12526         * dwarf-index-write.c: Use C++ exception handling.
12527         * dwarf-index-cache.c: Use C++ exception handling.
12528         * dtrace-probe.c: Use C++ exception handling.
12529         * disasm-selftests.c: Use C++ exception handling.
12530         * darwin-nat.c: Use C++ exception handling.
12531         * cp-valprint.c: Use C++ exception handling.
12532         * cp-support.c: Use C++ exception handling.
12533         * cp-abi.c: Use C++ exception handling.
12534         * corelow.c: Use C++ exception handling.
12535         * completer.c: Use C++ exception handling.
12536         * compile/compile-object-run.c: Use C++ exception handling.
12537         * compile/compile-object-load.c: Use C++ exception handling.
12538         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12539         * compile/compile-c-symbols.c: Use C++ exception handling.
12540         * common/selftest.c: Use C++ exception handling.
12541         * common/new-op.c: Use C++ exception handling.
12542         * cli/cli-script.c: Use C++ exception handling.
12543         * cli/cli-interp.c: Use C++ exception handling.
12544         * cli/cli-cmds.c: Use C++ exception handling.
12545         * c-varobj.c: Use C++ exception handling.
12546         * btrace.c: Use C++ exception handling.
12547         * breakpoint.c: Use C++ exception handling.
12548         * break-catch-throw.c: Use C++ exception handling.
12549         * arch-utils.c: Use C++ exception handling.
12550         * amd64-tdep.c: Use C++ exception handling.
12551         * ada-valprint.c: Use C++ exception handling.
12552         * ada-typeprint.c: Use C++ exception handling.
12553         * ada-lang.c: Use C++ exception handling.
12554         * aarch64-tdep.c: Use C++ exception handling.
12556 2019-04-08  Tom Tromey  <tom@tromey.com>
12558         * xml-support.c (gdb_xml_parser::parse): Update.
12559         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12560         * value.c (show_convenience): Update.
12561         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12562         (test_parse_flags_qcs): Update.
12563         * thread.c (thr_try_catch_cmd): Update.
12564         * target.c (target_translate_tls_address): Update.
12565         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12566         (info_frame_command_core, frame_apply_command_count): Update.
12567         * rust-exp.y (rust_lex_exception_test): Update.
12568         * riscv-tdep.c (riscv_print_one_register_info): Update.
12569         * remote.c (remote_target::enable_btrace): Update.
12570         * record-btrace.c (record_btrace_enable_warn): Update.
12571         * python/py-utils.c (gdbpy_convert_exception): Update.
12572         * printcmd.c (do_one_display, print_variable_and_value): Update.
12573         * mi/mi-main.c (mi_print_exception): Update.
12574         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12575         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12576         * linux-nat.c (linux_nat_target::attach): Update.
12577         * linux-fork.c (class scoped_switch_fork_info): Update.
12578         * infrun.c (displaced_step_prepare): Update.
12579         * infcall.c (call_function_by_hand_dummy): Update.
12580         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12581         * gnu-v3-abi.c (print_one_vtable): Update.
12582         * frame.c (get_prev_frame_always): Update.
12583         * f-valprint.c (info_common_command_for_block): Update.
12584         * exec.c (try_open_exec_file): Update.
12585         * exceptions.c (print_exception, exception_print)
12586         (exception_fprintf, exception_print_same): Update.
12587         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12588         * dwarf-index-cache.c (index_cache::store)
12589         (index_cache::lookup_gdb_index): Update.
12590         * darwin-nat.c (maybe_cache_shell): Update.
12591         * cp-valprint.c (cp_print_value_fields): Update.
12592         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12593         (gcc_cplus_symbol_address): Update.
12594         * compile/compile-c-symbols.c (gcc_convert_symbol)
12595         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12596         * common/selftest.c: Update.
12597         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12598         a std::string.
12599         (exception_try_scope_entry, exception_try_scope_exit): Don't
12600         declare.
12601         (struct exception_try_scope): Remove.
12602         (TRY): Don't use exception_try_scope.
12603         (struct gdb_exception): Add constructor, operator=.
12604         <what>: New method.
12605         (struct gdb_exception_RETURN_MASK_ALL)
12606         (struct gdb_exception_RETURN_MASK_ERROR)
12607         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12608         (struct gdb_quit_bad_alloc): Update.
12609         * common/common-exceptions.c (exception_none): Change
12610         initializer.
12611         (struct catcher) <state, exception>: Initialize inline.
12612         <prev>: Remove member.
12613         (current_catcher): Remove.
12614         (catchers): New global.
12615         (exceptions_state_mc_init): Simplify.
12616         (catcher_pop): Remove.
12617         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12618         (try_scope_depth, exception_try_scope_entry)
12619         (exception_try_scope_exit): Remove.
12620         (throw_exception_sjlj): Update.
12621         (exception_messages, exception_messages_size): Remove.
12622         (throw_it): Simplify.
12623         (gdb_exception_sliced_copy): Remove.
12624         (throw_exception_cxx): Update.
12625         * cli/cli-script.c (script_from_file): Update.
12626         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12627         Update.
12628         * ada-valprint.c (ada_val_print): Update.
12629         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12630         (create_excep_cond_exprs): Update.
12632 2019-04-08  Tom Tromey  <tom@tromey.com>
12634         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12635         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12636         (TRY, CATCH, END_CATCH): Remove some definitions.
12637         * common/common-exceptions.c: Don't use GDB_XCPT.
12638         (catcher_list_size): Remove.
12639         (throw_exception, throw_it): Simplify.
12641 2019-04-05  Tom Tromey  <tom@tromey.com>
12643         Revert the header-sorting patch.
12644         * ft32-tdep.c: Revert.
12645         * frv-tdep.c: Revert.
12646         * frv-linux-tdep.c: Revert.
12647         * frame.c: Revert.
12648         * frame-unwind.c: Revert.
12649         * frame-base.c: Revert.
12650         * fork-child.c: Revert.
12651         * findvar.c: Revert.
12652         * findcmd.c: Revert.
12653         * filesystem.c: Revert.
12654         * filename-seen-cache.h: Revert.
12655         * filename-seen-cache.c: Revert.
12656         * fbsd-tdep.c: Revert.
12657         * fbsd-nat.h: Revert.
12658         * fbsd-nat.c: Revert.
12659         * f-valprint.c: Revert.
12660         * f-typeprint.c: Revert.
12661         * f-lang.c: Revert.
12662         * extension.h: Revert.
12663         * extension.c: Revert.
12664         * extension-priv.h: Revert.
12665         * expprint.c: Revert.
12666         * exec.h: Revert.
12667         * exec.c: Revert.
12668         * exceptions.c: Revert.
12669         * event-top.c: Revert.
12670         * event-loop.c: Revert.
12671         * eval.c: Revert.
12672         * elfread.c: Revert.
12673         * dwarf2read.h: Revert.
12674         * dwarf2read.c: Revert.
12675         * dwarf2loc.c: Revert.
12676         * dwarf2expr.h: Revert.
12677         * dwarf2expr.c: Revert.
12678         * dwarf2-frame.c: Revert.
12679         * dwarf2-frame-tailcall.c: Revert.
12680         * dwarf-index-write.h: Revert.
12681         * dwarf-index-write.c: Revert.
12682         * dwarf-index-common.c: Revert.
12683         * dwarf-index-cache.h: Revert.
12684         * dwarf-index-cache.c: Revert.
12685         * dummy-frame.c: Revert.
12686         * dtrace-probe.c: Revert.
12687         * disasm.h: Revert.
12688         * disasm.c: Revert.
12689         * disasm-selftests.c: Revert.
12690         * dictionary.c: Revert.
12691         * dicos-tdep.c: Revert.
12692         * demangle.c: Revert.
12693         * dcache.h: Revert.
12694         * dcache.c: Revert.
12695         * darwin-nat.h: Revert.
12696         * darwin-nat.c: Revert.
12697         * darwin-nat-info.c: Revert.
12698         * d-valprint.c: Revert.
12699         * d-namespace.c: Revert.
12700         * d-lang.c: Revert.
12701         * ctf.c: Revert.
12702         * csky-tdep.c: Revert.
12703         * csky-linux-tdep.c: Revert.
12704         * cris-tdep.c: Revert.
12705         * cris-linux-tdep.c: Revert.
12706         * cp-valprint.c: Revert.
12707         * cp-support.c: Revert.
12708         * cp-namespace.c: Revert.
12709         * cp-abi.c: Revert.
12710         * corelow.c: Revert.
12711         * corefile.c: Revert.
12712         * continuations.c: Revert.
12713         * completer.h: Revert.
12714         * completer.c: Revert.
12715         * complaints.c: Revert.
12716         * coffread.c: Revert.
12717         * coff-pe-read.c: Revert.
12718         * cli-out.h: Revert.
12719         * cli-out.c: Revert.
12720         * charset.c: Revert.
12721         * c-varobj.c: Revert.
12722         * c-valprint.c: Revert.
12723         * c-typeprint.c: Revert.
12724         * c-lang.c: Revert.
12725         * buildsym.c: Revert.
12726         * buildsym-legacy.c: Revert.
12727         * build-id.h: Revert.
12728         * build-id.c: Revert.
12729         * btrace.c: Revert.
12730         * bsd-uthread.c: Revert.
12731         * breakpoint.h: Revert.
12732         * breakpoint.c: Revert.
12733         * break-catch-throw.c: Revert.
12734         * break-catch-syscall.c: Revert.
12735         * break-catch-sig.c: Revert.
12736         * blockframe.c: Revert.
12737         * block.c: Revert.
12738         * bfin-tdep.c: Revert.
12739         * bfin-linux-tdep.c: Revert.
12740         * bfd-target.c: Revert.
12741         * bcache.c: Revert.
12742         * ax-general.c: Revert.
12743         * ax-gdb.h: Revert.
12744         * ax-gdb.c: Revert.
12745         * avr-tdep.c: Revert.
12746         * auxv.c: Revert.
12747         * auto-load.c: Revert.
12748         * arm-wince-tdep.c: Revert.
12749         * arm-tdep.c: Revert.
12750         * arm-symbian-tdep.c: Revert.
12751         * arm-pikeos-tdep.c: Revert.
12752         * arm-obsd-tdep.c: Revert.
12753         * arm-nbsd-tdep.c: Revert.
12754         * arm-nbsd-nat.c: Revert.
12755         * arm-linux-tdep.c: Revert.
12756         * arm-linux-nat.c: Revert.
12757         * arm-fbsd-tdep.c: Revert.
12758         * arm-fbsd-nat.c: Revert.
12759         * arm-bsd-tdep.c: Revert.
12760         * arch-utils.c: Revert.
12761         * arc-tdep.c: Revert.
12762         * arc-newlib-tdep.c: Revert.
12763         * annotate.h: Revert.
12764         * annotate.c: Revert.
12765         * amd64-windows-tdep.c: Revert.
12766         * amd64-windows-nat.c: Revert.
12767         * amd64-tdep.c: Revert.
12768         * amd64-sol2-tdep.c: Revert.
12769         * amd64-obsd-tdep.c: Revert.
12770         * amd64-obsd-nat.c: Revert.
12771         * amd64-nbsd-tdep.c: Revert.
12772         * amd64-nbsd-nat.c: Revert.
12773         * amd64-nat.c: Revert.
12774         * amd64-linux-tdep.c: Revert.
12775         * amd64-linux-nat.c: Revert.
12776         * amd64-fbsd-tdep.c: Revert.
12777         * amd64-fbsd-nat.c: Revert.
12778         * amd64-dicos-tdep.c: Revert.
12779         * amd64-darwin-tdep.c: Revert.
12780         * amd64-bsd-nat.c: Revert.
12781         * alpha-tdep.c: Revert.
12782         * alpha-obsd-tdep.c: Revert.
12783         * alpha-nbsd-tdep.c: Revert.
12784         * alpha-mdebug-tdep.c: Revert.
12785         * alpha-linux-tdep.c: Revert.
12786         * alpha-linux-nat.c: Revert.
12787         * alpha-bsd-tdep.c: Revert.
12788         * alpha-bsd-nat.c: Revert.
12789         * aix-thread.c: Revert.
12790         * agent.c: Revert.
12791         * addrmap.c: Revert.
12792         * ada-varobj.c: Revert.
12793         * ada-valprint.c: Revert.
12794         * ada-typeprint.c: Revert.
12795         * ada-tasks.c: Revert.
12796         * ada-lang.c: Revert.
12797         * aarch64-tdep.c: Revert.
12798         * aarch64-ravenscar-thread.c: Revert.
12799         * aarch64-newlib-tdep.c: Revert.
12800         * aarch64-linux-tdep.c: Revert.
12801         * aarch64-linux-nat.c: Revert.
12802         * aarch64-fbsd-tdep.c: Revert.
12803         * aarch64-fbsd-nat.c: Revert.
12804         * aarch32-linux-nat.c: Revert.
12806 2019-04-05  Tom Tromey  <tom@tromey.com>
12808         * ft32-tdep.c: Sort headers.
12809         * frv-tdep.c: Sort headers.
12810         * frv-linux-tdep.c: Sort headers.
12811         * frame.c: Sort headers.
12812         * frame-unwind.c: Sort headers.
12813         * frame-base.c: Sort headers.
12814         * fork-child.c: Sort headers.
12815         * findvar.c: Sort headers.
12816         * findcmd.c: Sort headers.
12817         * filesystem.c: Sort headers.
12818         * filename-seen-cache.h: Sort headers.
12819         * filename-seen-cache.c: Sort headers.
12820         * fbsd-tdep.c: Sort headers.
12821         * fbsd-nat.h: Sort headers.
12822         * fbsd-nat.c: Sort headers.
12823         * f-valprint.c: Sort headers.
12824         * f-typeprint.c: Sort headers.
12825         * f-lang.c: Sort headers.
12826         * extension.h: Sort headers.
12827         * extension.c: Sort headers.
12828         * extension-priv.h: Sort headers.
12829         * expprint.c: Sort headers.
12830         * exec.h: Sort headers.
12831         * exec.c: Sort headers.
12832         * exceptions.c: Sort headers.
12833         * event-top.c: Sort headers.
12834         * event-loop.c: Sort headers.
12835         * eval.c: Sort headers.
12836         * elfread.c: Sort headers.
12837         * dwarf2read.h: Sort headers.
12838         * dwarf2read.c: Sort headers.
12839         * dwarf2loc.c: Sort headers.
12840         * dwarf2expr.h: Sort headers.
12841         * dwarf2expr.c: Sort headers.
12842         * dwarf2-frame.c: Sort headers.
12843         * dwarf2-frame-tailcall.c: Sort headers.
12844         * dwarf-index-write.h: Sort headers.
12845         * dwarf-index-write.c: Sort headers.
12846         * dwarf-index-common.c: Sort headers.
12847         * dwarf-index-cache.h: Sort headers.
12848         * dwarf-index-cache.c: Sort headers.
12849         * dummy-frame.c: Sort headers.
12850         * dtrace-probe.c: Sort headers.
12851         * disasm.h: Sort headers.
12852         * disasm.c: Sort headers.
12853         * disasm-selftests.c: Sort headers.
12854         * dictionary.c: Sort headers.
12855         * dicos-tdep.c: Sort headers.
12856         * demangle.c: Sort headers.
12857         * dcache.h: Sort headers.
12858         * dcache.c: Sort headers.
12859         * darwin-nat.h: Sort headers.
12860         * darwin-nat.c: Sort headers.
12861         * darwin-nat-info.c: Sort headers.
12862         * d-valprint.c: Sort headers.
12863         * d-namespace.c: Sort headers.
12864         * d-lang.c: Sort headers.
12865         * ctf.c: Sort headers.
12866         * csky-tdep.c: Sort headers.
12867         * csky-linux-tdep.c: Sort headers.
12868         * cris-tdep.c: Sort headers.
12869         * cris-linux-tdep.c: Sort headers.
12870         * cp-valprint.c: Sort headers.
12871         * cp-support.c: Sort headers.
12872         * cp-namespace.c: Sort headers.
12873         * cp-abi.c: Sort headers.
12874         * corelow.c: Sort headers.
12875         * corefile.c: Sort headers.
12876         * continuations.c: Sort headers.
12877         * completer.h: Sort headers.
12878         * completer.c: Sort headers.
12879         * complaints.c: Sort headers.
12880         * coffread.c: Sort headers.
12881         * coff-pe-read.c: Sort headers.
12882         * cli-out.h: Sort headers.
12883         * cli-out.c: Sort headers.
12884         * charset.c: Sort headers.
12885         * c-varobj.c: Sort headers.
12886         * c-valprint.c: Sort headers.
12887         * c-typeprint.c: Sort headers.
12888         * c-lang.c: Sort headers.
12889         * buildsym.c: Sort headers.
12890         * buildsym-legacy.c: Sort headers.
12891         * build-id.h: Sort headers.
12892         * build-id.c: Sort headers.
12893         * btrace.c: Sort headers.
12894         * bsd-uthread.c: Sort headers.
12895         * breakpoint.h: Sort headers.
12896         * breakpoint.c: Sort headers.
12897         * break-catch-throw.c: Sort headers.
12898         * break-catch-syscall.c: Sort headers.
12899         * break-catch-sig.c: Sort headers.
12900         * blockframe.c: Sort headers.
12901         * block.c: Sort headers.
12902         * bfin-tdep.c: Sort headers.
12903         * bfin-linux-tdep.c: Sort headers.
12904         * bfd-target.c: Sort headers.
12905         * bcache.c: Sort headers.
12906         * ax-general.c: Sort headers.
12907         * ax-gdb.h: Sort headers.
12908         * ax-gdb.c: Sort headers.
12909         * avr-tdep.c: Sort headers.
12910         * auxv.c: Sort headers.
12911         * auto-load.c: Sort headers.
12912         * arm-wince-tdep.c: Sort headers.
12913         * arm-tdep.c: Sort headers.
12914         * arm-symbian-tdep.c: Sort headers.
12915         * arm-pikeos-tdep.c: Sort headers.
12916         * arm-obsd-tdep.c: Sort headers.
12917         * arm-nbsd-tdep.c: Sort headers.
12918         * arm-nbsd-nat.c: Sort headers.
12919         * arm-linux-tdep.c: Sort headers.
12920         * arm-linux-nat.c: Sort headers.
12921         * arm-fbsd-tdep.c: Sort headers.
12922         * arm-fbsd-nat.c: Sort headers.
12923         * arm-bsd-tdep.c: Sort headers.
12924         * arch-utils.c: Sort headers.
12925         * arc-tdep.c: Sort headers.
12926         * arc-newlib-tdep.c: Sort headers.
12927         * annotate.h: Sort headers.
12928         * annotate.c: Sort headers.
12929         * amd64-windows-tdep.c: Sort headers.
12930         * amd64-windows-nat.c: Sort headers.
12931         * amd64-tdep.c: Sort headers.
12932         * amd64-sol2-tdep.c: Sort headers.
12933         * amd64-obsd-tdep.c: Sort headers.
12934         * amd64-obsd-nat.c: Sort headers.
12935         * amd64-nbsd-tdep.c: Sort headers.
12936         * amd64-nbsd-nat.c: Sort headers.
12937         * amd64-nat.c: Sort headers.
12938         * amd64-linux-tdep.c: Sort headers.
12939         * amd64-linux-nat.c: Sort headers.
12940         * amd64-fbsd-tdep.c: Sort headers.
12941         * amd64-fbsd-nat.c: Sort headers.
12942         * amd64-dicos-tdep.c: Sort headers.
12943         * amd64-darwin-tdep.c: Sort headers.
12944         * amd64-bsd-nat.c: Sort headers.
12945         * alpha-tdep.c: Sort headers.
12946         * alpha-obsd-tdep.c: Sort headers.
12947         * alpha-nbsd-tdep.c: Sort headers.
12948         * alpha-mdebug-tdep.c: Sort headers.
12949         * alpha-linux-tdep.c: Sort headers.
12950         * alpha-linux-nat.c: Sort headers.
12951         * alpha-bsd-tdep.c: Sort headers.
12952         * alpha-bsd-nat.c: Sort headers.
12953         * aix-thread.c: Sort headers.
12954         * agent.c: Sort headers.
12955         * addrmap.c: Sort headers.
12956         * ada-varobj.c: Sort headers.
12957         * ada-valprint.c: Sort headers.
12958         * ada-typeprint.c: Sort headers.
12959         * ada-tasks.c: Sort headers.
12960         * ada-lang.c: Sort headers.
12961         * aarch64-tdep.c: Sort headers.
12962         * aarch64-ravenscar-thread.c: Sort headers.
12963         * aarch64-newlib-tdep.c: Sort headers.
12964         * aarch64-linux-tdep.c: Sort headers.
12965         * aarch64-linux-nat.c: Sort headers.
12966         * aarch64-fbsd-tdep.c: Sort headers.
12967         * aarch64-fbsd-nat.c: Sort headers.
12968         * aarch32-linux-nat.c: Sort headers.
12970 2019-04-04  Tom Tromey  <tom@tromey.com>
12972         * varobj.c (varobj_create): Update.
12973         * rust-exp.y (struct rust_parser) <update_innermost_block,
12974         lookup_symbol>: New methods.
12975         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12976         Rename.
12977         (rust_parser::rust_lookup_type)
12978         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12979         * printcmd.c (display_command, do_one_display): Update.
12980         * parser-defs.h (struct parser_state) <parser_state>: Add
12981         "tracker" parameter.
12982         (block_tracker): New member.
12983         (class innermost_block_tracker) <innermost_block_tracker>: Add
12984         "types" parameter.
12985         <reset>: Remove method.
12986         (innermost_block): Don't declare.
12987         (null_post_parser): Update.
12988         * parse.c (innermost_block): Remove global.
12989         (write_dollar_variable): Update.
12990         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12991         Remove "tracker_types" parameter.
12992         (parse_expression): Add "tracker" parameter.
12993         (parse_expression_for_completion): Update.
12994         (null_post_parser): Add "tracker" parameter.
12995         * p-exp.y: Update rules.
12996         * m2-exp.y: Update rules.
12997         * language.h (struct language_defn) <la_post_parser>: Add
12998         "tracker" parameter.
12999         * go-exp.y: Update rules.
13000         * f-exp.y: Update rules.
13001         * expression.h (parse_expression, parse_exp_1): Add "tracker"
13002         parameter.
13003         * d-exp.y: Update rules.
13004         * c-exp.y: Update rules.
13005         * breakpoint.c (set_breakpoint_condition): Create an
13006         innermost_block_tracker.
13007         (watch_command_1): Likewise.
13008         * ada-lang.c (resolve): Add "tracker" parameter.
13009         (resolve_subexp): Likewise.
13010         * ada-exp.y (write_var_from_sym): Update.
13012 2019-04-04  Tom Tromey  <tom@tromey.com>
13014         * type-stack.h: New file.
13015         * type-stack.c: New file.
13016         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
13017         type-stack.h.
13018         (insert_into_type_stack, insert_type, push_type, push_type_int)
13019         (insert_type_address_space, pop_type, pop_type_int)
13020         (pop_typelist, pop_type_stack, append_type_stack)
13021         (push_type_stack, get_type_stack, push_typelist)
13022         (follow_type_instance_flags, follow_types): Don't declare.
13023         * parse.c (type_stack): Remove global.
13024         (parse_exp_in_context): Update.
13025         (insert_into_type_stack, insert_type, push_type, push_type_int)
13026         (insert_type_address_space, pop_type, pop_type_int)
13027         (pop_typelist, pop_type_stack, append_type_stack)
13028         (push_type_stack, get_type_stack, push_typelist)
13029         (follow_type_instance_flags, follow_types): Remove (moved to
13030         type-stack.c).
13031         * f-exp.y (type_stack): New global.
13032         Update rules.
13033         (push_kind_type, f_parse): Update.
13034         * d-exp.y (type_stack): New global.
13035         Update rules.
13036         (d_parse): Update.
13037         * c-exp.y (struct c_parse_state) <type_stack>: New member.
13038         Update rules.
13039         * Makefile.in (COMMON_SFILES): Add type-stack.c.
13040         (HFILES_NO_SRCDIR): Add type-stack.h.
13042 2019-04-04  Tom Tromey  <tom@tromey.com>
13044         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
13045         (rust_parser::convert_ast_to_expression, rust_parse)
13046         (rust_lex_test_completion, rust_lex_tests): Update.
13047         * parser-defs.h (struct expr_completion_state): New.
13048         (struct parser_state) <parser_state>: Add completion parameter.
13049         <mark_struct_expression, mark_completion_tag>: New methods.
13050         <parse_completion, m_completion_state>: New members.
13051         (prefixify_expression, null_post_parser): Update.
13052         (mark_struct_expression, mark_completion_tag): Don't declare.
13053         * parse.c (parse_completion, expout_last_struct)
13054         (expout_tag_completion_type, expout_completion_name): Remove
13055         globals.
13056         (parser_state::mark_struct_expression)
13057         (parser_state::mark_completion_tag): Now methods.
13058         (prefixify_expression): Add last_struct parameter.
13059         (prefixify_subexp): Likewise.
13060         (parse_exp_1): Update.
13061         (parse_exp_in_context): Add cstate parameter.  Update.
13062         (parse_expression_for_completion): Create an
13063         expr_completion_state.
13064         (null_post_parser): Add "completion" parameter.
13065         * p-exp.y: Update rules.
13066         (yylex): Update.
13067         * language.h (struct language_defn) <la_post_parser>: Add
13068         "completing" parameter.
13069         * go-exp.y: Update rules.
13070         (lex_one_token): Update.
13071         * expression.h (parse_completion): Don't declare.
13072         * d-exp.y: Update rules.
13073         (lex_one_token): Update rules.
13074         * c-exp.y: Update rules.
13075         (lex_one_token): Update.
13076         * ada-lang.c (resolve): Add "parse_completion" parameter.
13077         (resolve_subexp): Likewise.
13078         (ada_resolve_function): Likewise.
13080 2019-04-04  Tom Tromey  <tom@tromey.com>
13082         * parser-defs.h (struct parser_state) <start_arglist,
13083         end_arglist>: New methods.
13084         <arglist_len, m_funcall_chain>: New members.
13085         (arglist_len, start_arglist, end_arglist): Don't declare.
13086         * parse.c (arglist_len, funcall_chain): Remove global.
13087         (start_arglist, end_arglist): Remove functions.
13088         (parse_exp_in_context): Update.
13089         * p-exp.y: Update rules.
13090         * m2-exp.y: Update rules.
13091         * go-exp.y: Update rules.
13092         * f-exp.y: Update rules.
13093         * d-exp.y: Update rules.
13094         * c-exp.y: Update rules.
13096 2019-04-04  Tom Tromey  <tom@tromey.com>
13098         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
13099         lex_operator, push_back>: New methods.
13100         Update all rules.
13101         (rust_parser::lex_hex, lex_escape): Rename and update.
13102         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13103         (rust_parser::lex_operator): Rename and update.
13104         (rust_parser::lex_number, rustyylex, rustyyerror)
13105         (rust_lex_test_init, rust_lex_test_sequence)
13106         (rust_lex_test_push_back, rust_lex_tests): Update.
13107         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13108         parameter.
13109         <lexptr, prev_lexptr>: New members.
13110         (lexptr, prev_lexptr): Don't declare.
13111         * parse.c (lexptr, prev_lexptr): Remove globals.
13112         (parse_exp_in_context): Update.
13113         * p-exp.y (yylex, yyerror): Update.
13114         * m2-exp.y (parse_number, yylex, yyerror): Update.
13115         * go-exp.y (lex_one_token, yyerror): Update.
13116         * f-exp.y (match_string_literal, yylex, yyerror): Update.
13117         * d-exp.y (lex_one_token, yyerror): Update.
13118         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13119         (lex_one_token, yyerror): Update.
13120         * ada-lex.l (YY_INPUT): Update.
13121         (rewind_to_char): Update.
13122         * ada-exp.y (yyerror): Update.
13124 2019-04-04  Tom Tromey  <tom@tromey.com>
13126         * rust-exp.y (rustyylex, rust_lex_tests): Update.
13127         * parser-defs.h (struct parser_state) <parser_state>: Add new
13128         parameter.
13129         <comma_terminates>: New member.
13130         (comma_terminates): Don't declare global.
13131         * parse.c (comma_terminates): Remove global.
13132         (parse_exp_in_context): Update.
13133         * p-exp.y (yylex): Update.
13134         * m2-exp.y (yylex): Update.
13135         * go-exp.y (lex_one_token): Update.
13136         * f-exp.y (yylex): Update.
13137         * d-exp.y (lex_one_token): Update.
13138         * c-exp.y (lex_one_token): Update.
13139         * ada-lex.l: Update.
13141 2019-04-04  Tom Tromey  <tom@tromey.com>
13143         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13144         (rustyylex, rust_lex_test_init, rust_lex_test_one)
13145         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13146         * parser-defs.h (paren_depth): Don't declare.
13147         * parse.c (paren_depth): Remove global.
13148         (parse_exp_in_context): Update.
13149         * p-exp.y (paren_depth): New global.
13150         (pascal_parse): Initialize it.
13151         * m2-exp.y (paren_depth): New global.
13152         (m2_parse): Initialize it.
13153         * go-exp.y (paren_depth): New global.
13154         (go_parse): Initialize it.
13155         * f-exp.y (paren_depth): New global.
13156         (f_parse): Initialize it.
13157         * d-exp.y (paren_depth): New global.
13158         (d_parse): Initialize it.
13159         * c-exp.y (paren_depth): New global.
13160         (c_parse): Initialize it.
13161         * ada-lex.l (paren_depth): New global.
13162         (lexer_init): Initialize it.
13164 2019-04-04  Tom Tromey  <tom@tromey.com>
13166         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13167         (rust_parser::convert_ast_to_type)
13168         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13169         * parser-defs.h (struct parser_state) <parser_state>: Add
13170         parameters.  Initialize new members.
13171         <expression_context_block, expression_context_pc>: New members.
13172         * parse.c (expression_context_block, expression_context_pc):
13173         Remove globals.
13174         (parse_exp_in_context): Update.
13175         * p-exp.y: Update all rules.
13176         (yylex): Update.
13177         * m2-exp.y: Update all rules.
13178         (yylex): Update.
13179         * go-exp.y (yylex): Update.
13180         * f-exp.y (yylex): Update.
13181         * d-exp.y: Update all rules.
13182         (yylex): Update.
13183         * c-exp.y: Update all rules.
13184         (lex_one_token, classify_name, yylex, c_parse): Update.
13185         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13187 2019-04-04  Tom Tromey  <tom@tromey.com>
13189         * gdbarch.h, gdbarch.c: Rebuild.
13190         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13191         * stap-probe.h: 
13192         (struct stap_parse_info): Replace "parser_state" with
13193         "expr_builder".
13194         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13195         (parser_state): New class.
13196         * parse.c (expr_builder): Rename.
13197         (expr_builder::release): Rename.
13198         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13199         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13200         (write_exp_elt_longcst, write_exp_elt_floatcst)
13201         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13202         (write_exp_string_vector, write_exp_bitstring)
13203         (write_exp_msymbol, mark_struct_expression)
13204         (write_dollar_variable)
13205         (insert_type_address_space, increase_expout_size): Replace
13206         "parser_state" with "expr_builder".
13207         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13208         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13209         "parser_state" with "expr_builder".
13211 2019-04-04  Tom Tromey  <tom@tromey.com>
13213         * rust-exp.y: Replace "parse_language" with method call.
13214         * p-exp.y: 
13215         (yylex): Replace "parse_language" with method call.
13216         * m2-exp.y: 
13217         (yylex): Replace "parse_language" with method call.
13218         * go-exp.y (classify_name): Replace "parse_language" with method
13219         call.
13220         * f-exp.y (yylex): Replace "parse_language" with method call.
13221         * d-exp.y (lex_one_token): Replace "parse_language" with method
13222         call.
13223         * c-exp.y: 
13224         (lex_one_token, classify_name, yylex): Replace "parse_language"
13225         with method call.
13226         * ada-exp.y (find_primitive_type, type_char)
13227         (type_system_address): Replace "parse_language" with method call.
13229 2019-04-04  Tom Tromey  <tom@tromey.com>
13231         * rust-exp.y: Replace "parse_gdbarch" with method call.
13232         * parse.c (write_dollar_variable, insert_type_address_space):
13233         Replace "parse_gdbarch" with method call.
13234         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13235         call.
13236         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13237         call.
13238         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13239         "parse_gdbarch" with method call.
13240         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13241         with method call.
13242         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13243         "parse_gdbarch" with method call.
13244         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13245         "parse_gdbarch" with method call.
13246         * c-exp.y (parse_type, parse_number, classify_name): Replace
13247         "parse_gdbarch" with method call.
13248         * ada-lex.l: Replace "parse_gdbarch" with method call.
13249         * ada-exp.y (parse_type, find_primitive_type, type_char)
13250         (type_system_address): Replace "parse_gdbarch" with method call.
13252 2019-04-04  Tom Tromey  <tom@tromey.com>
13254         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13255         * stap-probe.c (stap_parse_argument): Update.
13256         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13257         initial_size parameter.
13258         * rust-exp.y (rust_lex_tests): Update.
13259         * parse.c (parser_state): Update.
13260         (parse_exp_in_context): Update.
13261         * parser-defs.h (struct parser_state) <parser_state>: Remove
13262         "initial_size" parameter.
13264 2019-04-04  Tom Tromey  <tom@tromey.com>
13266         * parser-defs.h (increase_expout_size): Don't declare.
13267         * parse.c (increase_expout_size): Now static.
13269 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13271         * gnu-nat.c (gnu_nat_target::wait): Fix
13272         target_waitstatus_to_string call.
13274 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13276         * eval.c (evaluate_subexp_standard): Handle internal functions
13277         during Fortran function call handling.
13279 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13281         * NEWS: Mention new internal functions.
13282         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13283         (read_base_type): Use dwarf2_init_complex_target_type.
13284         * value.c (creal_internal_fn): New function.
13285         (cimag_internal_fn): New function.
13286         (_initialize_values): Register new internal functions.
13288 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13290         * infrun.c (stop_all_threads): If debug_infrun, always
13291         trace the wait status after wait_one, using
13292         target_waitstatus_to_string and target_pid_to_str.
13293         (handle_inferior_event): Replace various trace of
13294         wait status kind by a single trace.
13295         * gnu-nat.c (gnu_nat_target::wait): Replace local
13296         wait status kind image by target_waitstatus_to_string.
13297         * target/waitstatus.c (target_waitstatus_to_string): Fix
13298         obsolete comment.
13300 2019-04-01  Tom Tromey  <tromey@adacore.com>
13302         PR symtab/23331:
13303         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13305 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13306             Pedro Alves  <palves@redhat.com>
13308         * top.c (quit_force): Call 'finalize_values'.
13309         * value.c (finalize_values): New function.
13310         * value.h (finalize_values): Declare.
13312 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13314         * NEWS: Announce $_gdb_major and $_gdb_minor.
13316         * top.c (init_gdb_version_vars): New function.
13317         (gdb_init): Call init_gdb_version_vars.
13319 2019-03-29  Tom Tromey  <tromey@adacore.com>
13321         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13322         help text.  Remove dead code.
13324 2019-03-29  Keith Seitz  <keiths@redhat.com>
13326         From Siddhesh Poyarekar:
13327         * f-lang.h (f77_get_upperbound): Return LONGEST.
13328         (f77_get_lowerbound): Likewise.
13329         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13330         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13331         print them.
13332         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13333         plongest to format print it.
13334         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13335         (f77_get_upperbound): Likewise.
13336         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13337         LOWER_BOUND to LONGEST.
13338         (f77_create_arrayprint_offset_tbl): Likewise.
13340 2019-03-29  Keith Seitz  <keiths@redhat.com>
13342         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13343         %s/pulongest for TYPE_LENGTH instead of %d in format
13344         strings.
13345         * ada-typerint.c (ada_print_type): Likewise.
13346         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13347         * compile/compile-c-support.c (generate_register_struct): Likewise.
13348         * gdbtypes.c (recursive_dump_type): Likewise.
13349         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13350         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13351         instead of %d in format strings.
13352         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13353         to std::min to ULONGEST.
13354         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13355         instead of %d in format strings.
13356         * tracepoint.c (info_scope_command): Likewise.
13357         * typeprint.c (print_offset_data::update)
13358         (print_offset_data::finish): Likewise.
13359         * xtensa-tdep.c (xtensa_store_return_value)
13360         (xtensa_push_dummy_call): Likewise.
13362 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13364         * windows-nat.c (display_selector): Fixed format specifications
13365         for 64-bit Cygwin.
13367 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13369         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13371 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13373         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13374         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13375         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13376         (nios2_linux_init_abi): Install it.
13378 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13380         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13382 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13384         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13386 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13387             Tom Tromey  <tromey@adacore.com>
13389         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13391 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13393         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13394         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13395         method to compute the bounds of range types. Also print "[evaluated]"
13396         if the bounds' values come from a dynamic evaluation.
13398 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13400         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13401         whitespace when pretty printing is on.
13403 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13405         * ppc-linux-nat.c: Add include.
13407 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13409         * NEWS: Mention AArch64 Pointer Authentication.
13411 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13413         * arm-linux-nat.c: Add include.
13415 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13417         * source-cache.c (source_cache::get_source_lines): Re-read
13418         fullname after calling open_source_file.
13420 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13422         * NEWS: Mention TLS support for FreeBSD.
13424 2019-03-25  Tom Tromey  <tromey@adacore.com>
13426         * minsyms.c (BUNCH_SIZE): Update comment.
13427         (~minimal_symbol_reader): Remove old comment.
13428         (compact_minimal_symbols): Update comment.
13429         (minimal_symbol_reader::install): Remove old comment.  Update
13430         other comments.
13432 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13434         * s390-linux-nat.c: Add include.
13436 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13438         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13439         Call linux_get_hwcap.
13440         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13441         Likewise.
13442         (aarch64_linux_get_hwcap): Remove function.
13443         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13444         declaration.
13445         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13446         linux_get_hwcap.
13447         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13448         * linux-tdep.c (linux_get_hwcap): Add function.
13449         (linux_get_hwcap2): Likewise.
13450         * linux-tdep.h (linux_get_hwcap): Add declaration.
13451         (linux_get_hwcap2): Likewise.
13452         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13453         (ppc_linux_get_hwcap2): Likewise.
13454         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13455         linux_get_hwcap.
13456         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13457         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13458         (ppc_linux_nat_target::read_description): Likewise.
13459         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13460         * s390-linux-nat.c: Likewise.
13461         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13463 2019-03-24  Tom Tromey  <tom@tromey.com>
13465         * ada-lang.c (standard_lookup): Simplify initialization.
13466         (ada_lookup_symbol_nonlocal): Simplify return.
13467         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13468         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13469         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13470         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13471         initialization.
13472         * solib.c (solib_global_lookup): Simplify.
13473         * symtab.c (null_block_symbol): Remove.
13474         (symbol_cache_lookup): Simplify returns.
13475         (lookup_language_this): Simplify returns.
13476         (lookup_symbol_aux): Simplify return.
13477         (lookup_local_symbol): Simplify returns.
13478         (lookup_global_symbol_from_objfile): Simplify return.
13479         (lookup_symbol_in_objfile_symtabs)
13480         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13481         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13482         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13483         * cp-namespace.c (cp_lookup_bare_symbol)
13484         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13485         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13486         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13487         (cp_lookup_symbol_via_imports): Simplify initialization.
13488         (find_symbol_in_baseclass): Likewise.
13489         * symtab.h (null_block_symbol): Remove.
13490         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13491         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13492         (d_lookup_symbol_module): Likewise.
13493         (find_symbol_in_baseclass): Simplify initialization.
13495 2019-03-24  Tom Tromey  <tom@tromey.com>
13497         * expression.h: Don't include symtab.h.
13498         (struct block): Forward declare.
13500 2019-03-24  Tom Tromey  <tom@tromey.com>
13502         * c-exp.y (typebase): Remove casts.
13503         * gdbtypes.c (lookup_unsigned_typename, )
13504         (lookup_signed_typename): Remove cast.
13505         * eval.c (parse_to_comma_and_eval): Remove cast.
13506         * parse.c (write_dollar_variable): Remove cast.
13507         * block.h (struct block) <superblock>: Now const.
13508         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13509         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13510         (map_block): Make "block" const.
13511         * symfile.h (struct quick_symbol_functions)
13512         <map_matching_symbols>: Constify block argument to "callback".
13513         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13514         const.
13515         (find_pc_sect_compunit_symtab): Make "b" const.
13516         (find_symbol_at_address): Likewise.
13517         (search_symbols): Likewise.
13518         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13519         (dw2_debug_names_lookup_symbol): Likewise.
13520         (dw2_map_matching_symbols): Update.
13521         * p-valprint.c (pascal_val_print): Remove "block".
13522         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13523         (aux_add_nonlocal_symbols): Make "block" const.
13524         (resolve_subexp): Remove cast.
13525         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13526         const.
13527         (iterate_over_file_blocks): Likewise.
13528         * f-exp.y (%union) <bval>: Remove.
13529         * coffread.c (patch_opaque_types): Make "b" const.
13530         * spu-tdep.c (spu_catch_start): Make "block" const.
13531         * c-valprint.c (print_unpacked_pointer): Remove "block".
13532         * symmisc.c (dump_symtab_1): Make "b" const.
13533         (block_depth): Make "block" const.
13534         * d-exp.y (%union) <bval>: Remove.
13535         * cp-support.h (cp_lookup_rtti_type): Update.
13536         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13537         * psymtab.c (psym_lookup_symbol): Make "block" const.
13538         (maintenance_check_psymtabs): Make "b" const.
13539         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13540         (enumerate_locals, enumerate_args): Update.
13541         * python/py-symtab.c (stpy_global_block): Make "block" const.
13542         (stpy_static_block): Likewise.
13543         * inline-frame.c (block_starting_point_at): Make "new_block"
13544         const.
13545         * block.c (find_block_in_blockvector): Make return type const.
13546         (blockvector_for_pc_sect): Make "b" const.
13547         (find_block_in_blockvector): Make "b" const.
13549 2019-03-23  Tom Tromey  <tom@tromey.com>
13551         * varobj.c (varobj_create): Update.
13552         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13553         * printcmd.c (display_command, do_one_display): Don't reset
13554         innermost_block.
13555         * parser-defs.h (enum innermost_block_tracker_type): Move to
13556         expression.h.
13557         (innermost_block): Update comment.
13558         * parse.c (parse_exp_1): Add tracker_types parameter.
13559         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13560         tracker_types parameter.  Reset innermost_block.
13561         (parse_exp_in_context): Remove.
13562         (parse_expression_for_completion): Update.
13563         * objfiles.c (~objfile): Don't reset expression_context_block or
13564         innermost_block.
13565         * expression.h (enum innermost_block_tracker_type): Move from
13566         parser-defs.h.
13567         (parse_exp_1): Add tracker_types parameter.
13568         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13569         reset innermost_block.
13571 2019-03-23  Tom Tromey  <tom@tromey.com>
13573         * objfiles.h: Include bcache.h.
13575 2019-03-23  Tom Tromey  <tom@tromey.com>
13577         * linespec.c (get_current_search_block): Use
13578         scoped_restore_current_language.
13579         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13581 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13582             Jiong Wang  <jiong.wang@arm.com>
13584         * aarch64-linux-tdep.c
13585         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13586         section.
13587         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13590             Jiong Wang  <jiong.wang@arm.com>
13592         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13593         instructions.
13594         (aarch64_analyze_prologue_test): Add PACIASP test.
13595         (aarch64_prologue_prev_register): Unmask PC value.
13597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13598             Jiong Wang  <jiong.wang@arm.com>
13600         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13601         (aarch64_dwarf2_prev_register): Unmask PC value.
13602         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13603         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13604         DW_CFA_AARCH64_negate_ra_state.
13605         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13608             Jiong Wang  <jiong.wang@arm.com>
13610         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13611         registers.
13612         (aarch64_pseudo_register_name): Likewise.
13613         (aarch64_pseudo_register_type): Likewise.
13614         (aarch64_pseudo_register_reggroup_p): Likewise.
13615         (aarch64_gdbarch_init): Add pauth registers.
13616         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13617         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13618         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13619         (struct gdbarch_tdep): Add regnum for ra_state.
13621 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13622             Jiong Wang  <jiong.wang@arm.com>
13624         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13627             Jiong Wang  <jiong.wang@arm.com>
13629         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13630         function.
13631         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13632         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13633         (aarch64_gdbarch_init): Add puth registers.
13634         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13635         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13636         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13638 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13639             Jiong Wang  <jiong.wang@arm.com>
13641         * aarch64-linux-nat.c
13642         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13643         * aarch64-linux-tdep.c
13644         (aarch64_linux_core_read_description): Likewise.
13645         (aarch64_linux_get_hwcap): New function.
13646         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13647         (aarch64_linux_get_hwcap): New declaration.
13649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13650             Jiong Wang  <jiong.wang@arm.com>
13652         * aarch64-linux-nat.c
13653         (aarch64_linux_nat_target::read_description): Add pauth param.
13654         * aarch64-linux-tdep.c
13655         (aarch64_linux_core_read_description): Likewise.
13656         * aarch64-tdep.c (struct target_desc): Add in pauth.
13657         (aarch64_read_description): Add pauth param.
13658         (aarch64_gdbarch_init): Likewise.
13659         * aarch64-tdep.h (aarch64_read_description): Likewise.
13660         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13661         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13662         * features/Makefile: Add new files.
13663         * features/aarch64-pauth.c: New file.
13664         * features/aarch64-pauth.xml: New file.
13666 2019-03-20  Tom Tromey  <tromey@adacore.com>
13668         * infrun.c (handle_inferior_event): Rename from
13669         handle_inferior_event_1.  Create a scoped_value_mark.
13670         (handle_inferior_event): Remove.
13672 2019-03-19  Tom Tromey  <tromey@adacore.com>
13674         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13675         * infrun.h (print_stop_event): Add "displays" parameter.
13676         * infrun.c (print_stop_event): Add "displays" parameter.
13678 2019-03-19  Pedro Alves  <palves@redhat.com>
13680         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13681         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13682         to -1.  Fix TABs vs spaces.
13683         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13684         * tui/tui-out.h (tui_ui_out) Add intro comments.
13685         <m_line, m_start_of_line>: In-class initialize, and add describing
13686         comment.
13688 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13690         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13691         variable names.
13692         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13694 2019-03-18  Pedro Alves  <palves@redhat.com>
13695             Eli Zaretskii <eliz@gnu.org>
13697         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13698         m_line and m_start_of_line.
13700 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13702         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13703         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13704         it returns a newline.  This fixes a regression in TU mode, whereby
13705         the next line is output on the same screen line as the user input.
13707 2019-03-18  Tom Tromey  <tromey@adacore.com>
13709         * minsyms.c (minimal_symbol_reader::install): Remove call to
13710         obstack_blank.
13712 2019-03-18  Pedro Alves  <palves@redhat.com>
13714         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13715         New globals.
13716         (apply_style): New, factored out from ...
13717         (apply_ansi_escape): ... this.  Handle reverse video mode.
13718         (tui_set_reverse_mode): New function.
13719         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13720         * tui/tui-winsource.c (tui_show_source_line): Use
13721         tui_set_reverse_mode instead of setting A_STANDOUT.
13722         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13723         New setter methods.
13725 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13727         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13728         Handle tabs.
13730 2019-03-18  Tom Tromey  <tromey@adacore.com>
13732         * ada-lang.c (empty_array): Add "high" parameter.
13733         (ada_evaluate_subexp): Update.
13735 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13737         * unittests/string_view-selftests.c: Define
13738         _initialize_string_view_selftests unconditionally.
13740 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13742         PR gdb/24350
13743         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13745 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13747         PR gdb/24351
13748         * windows-nat.c (display_selector): Fix format specifiers.
13750 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13752         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13753         tui_refill_source_window instead of tui_refresh_win, to update the
13754         current execution line.  This fixes redisplay of the current line
13755         when stepping through the code with "next" or "step".
13757 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13759         * source-cache.c (source_cache::get_source_lines): Call
13760         find_source_lines to initialize s->nlines.  This fixes vertical
13761         scrolling of TUI source window when the DOWN arrow is pressed.
13763 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13765         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13766         linux-thread-db.c (_initialize_thread_db): Likewise.
13768 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13770         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13771         wclrtoeol in tui_show_source_line".  This reverts changes made in
13772         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13774 2019-03-15  Tom Tromey  <tom@tromey.com>
13776         * symtab.h (struct minimal_symbol): Derive from
13777         general_symbol_info.
13778         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13779         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13780         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13781         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13782         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13783         (MSYMBOL_SEARCH_NAME): Update.
13784         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13785         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13786         * minsyms.c (minimal_symbol_reader::record_full): Update.
13788 2019-03-15  Tom Tromey  <tom@tromey.com>
13790         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13792 2019-03-15  Tom Tromey  <tom@tromey.com>
13794         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13795         unique_xmalloc_ptr.
13796         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13797         Update.
13798         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13799         (build_minimal_symbol_hash_tables)
13800         (minimal_symbol_reader::install): Update.
13802 2019-03-15  Tom Tromey  <tom@tromey.com>
13804         * symtab.c (create_demangled_names_hash): Update.
13805         (symbol_set_names): Update.
13806         * objfiles.h (struct objfile_per_bfd_storage)
13807         <demangled_names_hash>: Now an htab_up.
13808         * objfiles.c (objfile_per_bfd_storage): Simplify.
13810 2019-03-15  Tom Tromey  <tom@tromey.com>
13812         * objfiles.h (struct objfile_per_bfd_storage): Declare
13813         destructor.
13814         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13815         New.
13816         (get_objfile_bfd_data): Use new.  Don't initialize
13817         language_of_main.
13818         (free_objfile_per_bfd_storage): Remove.
13819         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13821 2019-03-15  Tom Tromey  <tom@tromey.com>
13823         * symfile.c (reread_symbols): Update.
13824         * objfiles.c (objfile::objfile): Update.
13825         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13826         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13827         comment.
13828         (minimal_symbol_reader::install): Update.
13829         (terminate_minimal_symbol_table): Remove.
13830         * jit.c (jit_object_close_impl): Update.
13832 2019-03-15  Tom Tromey  <tom@tromey.com>
13834         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13835         initializations.
13837 2019-03-15  Tom Tromey  <tom@tromey.com>
13839         * objfiles.h (struct objfile_per_bfd_storage)
13840         <demangled_hash_languages>: Now a bitset.
13841         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13842         (lookup_minimal_symbol): Update.
13844 2019-03-15  Tom Tromey  <tom@tromey.com>
13846         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13847         Don't return the symbol.
13848         * coffread.c (record_minimal_symbol): Use record_full.
13850 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13852         The MS-Windows port of ncurses fails to switch to a color pair if
13853         one or both of the colors are the implicit default colors.  This
13854         change records the default colors when TUI is initialized, and
13855         then specifies them explicitly when a color pair uses the default
13856         colors.  This allows color styling in TUI mode on MS-Windows.
13858         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13859         ncurses_norm_attr.
13860         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13861         colors in ncurses_norm_attr.
13862         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13863         "none", replace it with the default color recorded in
13864         ncurses_norm_attr.
13866 2019-03-14  Tom Tromey  <tromey@adacore.com>
13868         * source-cache.h (class source_cache) <get_source_lines>: Return
13869         std::string.
13870         * source-cache.c (source_cache::extract_lines): Handle case where
13871         first_pos==npos.  Return std::string.
13872         (source_cache::get_source_lines): Update.
13874 2019-03-14  Tom Tromey  <tromey@adacore.com>
13876         * NEWS: Add item for "style sources" commands.
13877         * source-cache.c (source_cache::get_source_lines): Check
13878         source_styling.
13879         * cli/cli-style.c (source_styling): New global.
13880         (_initialize_cli_style): Add "style sources" commands.
13881         (show_style_sources): New function.
13882         * cli/cli-style.h (source_styling): Declare.
13884 2019-03-14  Pedro Alves  <palves@redhat.com>
13885             Tom Tromey  <tromey@adacore.com>
13887         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13888         * tui/tui-winsource.c (tui_refill_source_window): New function,
13889         from...
13890         (tui_horizontal_source_scroll): ... here.  Move some logic.
13891         * cli/cli-style.c (set_style_enabled): Notify new observable.
13892         * tui/tui-hooks.c (tui_redisplay_source): New function.
13893         (tui_attach_detach_observers): Attach or detach
13894         tui_redisplay_source.
13895         * observable.h (source_styling_changed): New observable.
13896         * observable.c: Define source_styling_changed observable.
13898 2019-03-13  Tom Tromey  <tromey@adacore.com>
13900         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13901         (i386_gnu_nat_target::store_registers): Update.
13902         * target-debug.h (target_debug_print_std_string): New macro.
13903         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13904         * windows-tdep.c (display_one_tib): Update.
13905         * tui/tui-stack.c (tui_make_status_line): Update.
13906         * top.c (print_inferior_quit_action): Update.
13907         * thread.c (thr_try_catch_cmd): Update.
13908         (add_thread_with_info): Update.
13909         (thread_target_id_str): Update.
13910         (thr_try_catch_cmd): Update.
13911         (thread_command): Update.
13912         (thread_find_command): Update.
13913         * record-btrace.c (record_btrace_target::info_record)
13914         (record_btrace_resume_thread, record_btrace_target::resume)
13915         (record_btrace_cancel_resume, record_btrace_step_thread)
13916         (record_btrace_target::wait, record_btrace_target::wait)
13917         (record_btrace_target::wait, record_btrace_target::stop): Update.
13918         * progspace.c (print_program_space): Update.
13919         * process-stratum-target.c
13920         (process_stratum_target::thread_address_space): Update.
13921         * linux-fork.c (linux_fork_mourn_inferior)
13922         (detach_checkpoint_command, info_checkpoints_command)
13923         (linux_fork_context): Update.
13924         (linux_fork_detach): Update.
13925         (class scoped_switch_fork_info): Update.
13926         (delete_checkpoint_command): Update.
13927         * infrun.c (follow_fork_inferior): Update.
13928         (follow_fork_inferior): Update.
13929         (proceed_after_vfork_done): Update.
13930         (handle_vfork_child_exec_or_exit): Update.
13931         (follow_exec): Update.
13932         (displaced_step_prepare_throw): Update.
13933         (displaced_step_restore): Update.
13934         (start_step_over): Update.
13935         (resume_1): Update.
13936         (clear_proceed_status_thread): Update.
13937         (proceed): Update.
13938         (print_target_wait_results): Update.
13939         (do_target_wait): Update.
13940         (context_switch): Update.
13941         (stop_all_threads): Update.
13942         (restart_threads): Update.
13943         (finish_step_over): Update.
13944         (handle_signal_stop): Update.
13945         (switch_back_to_stepped_thread): Update.
13946         (keep_going_pass_signal): Update.
13947         (print_exited_reason): Update.
13948         (normal_stop): Update.
13949         * inferior.c (inferior_pid_to_str): Change return type.
13950         (print_selected_inferior): Update.
13951         (add_inferior): Update.
13952         (detach_inferior): Update.
13953         * dummy-frame.c (fprint_dummy_frames): Update.
13954         * dcache.c (dcache_info_1): Update.
13955         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13956         (btrace_fetch, btrace_clear): Update.
13957         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13958         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13959         type.
13960         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13961         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13962         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13963         * gdbarch.c, gdbarch.h: Rebuild.
13964         * gdbarch.sh (core_pid_to_str): Change return type.
13965         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13966         return type.
13967         (windows_nat_target::pid_to_str): Change return type.
13968         (windows_delete_thread): Update.
13969         (windows_nat_target::attach): Update.
13970         (windows_nat_target::files_info): Update.
13971         * target-delegates.c: Rebuild.
13972         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13973         return type.
13974         (sol_thread_target::pid_to_str): Change return type.
13975         * remote.c (class remote_target) <pid_to_str>: Change return
13976         type.
13977         (remote_target::pid_to_str): Change return type.
13978         (extended_remote_target::attach, remote_target::remote_stop_ns)
13979         (remote_target::remote_notif_remove_queued_reply)
13980         (remote_target::push_stop_reply, remote_target::disable_btrace):
13981         Update.
13982         (extended_remote_target::attach): Update.
13983         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13984         type.
13985         (gdbsim_target::pid_to_str): Change return type.
13986         * ravenscar-thread.c (struct ravenscar_thread_target)
13987         <pid_to_str>: Change return type.
13988         (ravenscar_thread_target::pid_to_str): Change return type.
13989         * procfs.c (class procfs_target) <pid_to_str>: Change return
13990         type.
13991         (procfs_target::pid_to_str): Change return type.
13992         (procfs_target::attach): Update.
13993         (procfs_target::detach): Update.
13994         (procfs_target::fetch_registers): Update.
13995         (procfs_target::store_registers): Update.
13996         (procfs_target::wait): Update.
13997         (procfs_target::files_info): Update.
13998         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13999         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
14000         return type.
14001         (nto_procfs_target::pid_to_str): Change return type.
14002         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
14003         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
14004         return type.
14005         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
14006         (exit_lwp): Update.
14007         (attach_proc_task_lwp_callback, get_detach_signal)
14008         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
14009         (linux_nat_target::resume, wait_lwp, stop_callback)
14010         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
14011         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
14012         (linux_nat_wait_1, resume_stopped_resumed_lwps)
14013         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
14014         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
14015         type.
14016         (inf_ptrace_target::attach): Update.
14017         (inf_ptrace_target::files_info): Update.
14018         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
14019         type.
14020         (go32_nat_target::pid_to_str): Change return type.
14021         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
14022         (gnu_nat_target::wait): Update.
14023         (gnu_nat_target::wait): Update.
14024         (gnu_nat_target::resume): Update.
14025         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
14026         (fbsd_nat_target::wait): Update.
14027         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
14028         type.
14029         (darwin_nat_target::attach): Update.
14030         * corelow.c (class core_target) <pid_to_str>: Change return type.
14031         (core_target::pid_to_str): Change return type.
14032         * target.c (normal_pid_to_str): Change return type.
14033         (default_pid_to_str): Likewise.
14034         (target_pid_to_str): Change return type.
14035         (target_translate_tls_address): Update.
14036         (target_announce_detach): Update.
14037         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
14038         return type.
14039         (bsd_uthread_target::pid_to_str): Change return type.
14040         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
14041         type.
14042         (bsd_kvm_target::pid_to_str): Change return type.
14043         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
14044         return type.
14045         (aix_thread_target::pid_to_str): Change return type.
14046         * target.h (struct target_ops) <pid_to_str>: Change return type.
14047         (target_pid_to_str, normal_pid_to_str): Likewise.
14048         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
14049         type.
14050         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
14051         type.
14052         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
14053         return type.
14054         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
14055         type.
14056         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
14057         type.
14058         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
14059         return type.
14061 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
14063         * NEWS: Mention that the new default MI version is 3.  Mention
14064         changes to the output of commands and events that deal with
14065         multi-location breakpoints.
14066         * breakpoint.c: Include "mi/mi-out.h".
14067         (print_one_breakpoint): Change output syntax if using MI version
14068         >= 3.
14069         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
14070         New.
14071         (mi_multi_location_breakpoint_output_fixed): New.
14072         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
14073         (mi_cmd_fix_multi_location_breakpoint_output): New.
14074         (mi_multi_location_breakpoint_output_fixed): New.
14075         * mi/mi-cmds.c (mi_cmds): Register command
14076         -fix-multi-location-breakpoint-output.
14077         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
14078         interpreter "mi".
14080 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
14082         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
14083         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
14084         instantiate mi_ui_out based on interpreter name.
14085         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
14086         * mi/mi-main.c (mi_load_progress): Likewise.
14088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14090         * NEWS: Combine separate "New targets" sections for 8.3.
14092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14094         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
14095         (ppcfbsd_init_abi): Install gdbarch
14096         "fetch_tls_load_module_address" and "get_thread_local_address"
14097         methods.
14099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14101         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14102         (riscv_fbsd_init_abi): Install gdbarch
14103         "fetch_tls_load_module_address" and "get_thread_local_address"
14104         methods.
14106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14108         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14109         (i386fbsd_init_abi): Install gdbarch
14110         "fetch_tls_load_module_address" and "get_thread_local_address"
14111         methods.
14113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14115         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14116         (amd64fbsd_init_abi): Install gdbarch
14117         "fetch_tls_load_module_address" and "get_thread_local_address"
14118         methods.
14120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14122         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14123         (struct fbsd_pspace_data): New type.
14124         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14125         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14126         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14127         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14128         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14132         * gdbtypes.c (lookup_struct_elt): New function.
14133         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14134         * gdbtypes.h (struct struct_elt): New type.
14135         (lookup_struct_elt): New prototype.
14137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14139         * gdbtypes.c (lookup_struct_elt_type): Update comment and
14140         remove disabled code block.
14142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14144         * gdbarch.sh (get_thread_local_address): New method.
14145         * gdbarch.h, gdbarch.c: Regenerate.
14146         * target.c (target_translate_tls_address): Use
14147         gdbarch_get_thread_local_address if present instead of
14148         target::get_thread_local_address.
14150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14152         * target.h (target::get_thread_local_address): Update comment.
14154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14156         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14157         objfile->separate_debug_objfile_backlink if not NULL.
14159 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14161         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14162         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14163         (amd64bsd_store_inferior_registers): Likewise.
14164         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14165         Enable segment base registers.
14166         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14167         PT_GETFSBASE and PT_GETGSBASE.
14168         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14169         PT_SETGSBASE.
14170         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14171         segment base registers.
14172         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14176         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14177         Update calls to i386_target_description to add 'segments'
14178         parameter.
14179         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14180         add segment base registers.
14181         * arch/i386.c (i386_create_target_description): Add 'segments'
14182         parameter to enable segment base registers.
14183         * arch/i386.h (i386_create_target_description): Likewise.
14184         * features/i386/32bit-segments.xml: New file.
14185         * features/i386/32bit-segments.c: Generate.
14186         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14187         call to i386_target_description to add 'segments' parameter.
14188         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14189         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14190         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14191         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14192         if feature is present.
14193         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14194         Add 'segments' parameter to call to i386_target_description.
14195         (i386_target_description): Add 'segments' parameter to enable
14196         segment base registers.
14197         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14198         to call to i386_target_description.
14199         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14200         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14201         Define I386_NUM_REGS.
14202         (i386_target_description): Add 'segments' parameter to enable
14203         segment base registers.
14205 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14207         PR/24325
14208         * source-cache.c: #undef open and close, to avoid unresolved
14209         externals during linking.
14211 2019-03-12  Tom Tromey  <tromey@adacore.com>
14213         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14214         const.  Add initializers.
14215         (_initialize_remote): Don't initialize ptid globals.
14217 2019-03-12  Pedro Alves  <palves@redhat.com>
14219         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14221 2019-03-12  Pedro Alves  <palves@redhat.com>
14223         * cp-name-parser.y (main): Remove unused 'len' variable.
14225 2019-03-12  Tom Tromey  <tromey@adacore.com>
14227         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14228         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14230 2019-03-12  Tom Tromey  <tromey@adacore.com>
14232         * linux-nat.c (iterate_over_lwps): Update.
14233         (stop_callback): Remove parameter.
14234         (stop_wait_callback, detach_callback, resume_set_callback)
14235         (select_singlestep_lwp_callback, set_ignore_sigint)
14236         (status_callback, resumed_callback, resume_clear_callback)
14237         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14238         data parameter.
14239         (linux_nat_target::detach, linux_nat_target::resume)
14240         (linux_stop_and_wait_all_lwps, select_event_lwp)
14241         (linux_nat_filter_event, linux_nat_wait_1)
14242         (linux_nat_target::kill, linux_nat_target::stop)
14243         (linux_nat_target::stop): Update.
14244         (linux_nat_resume_callback): Change type.
14245         (resume_stopped_resumed_lwps, count_events_callback)
14246         (select_event_lwp_callback): Likewise.
14247         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14248         * arm-linux-nat.c (struct update_registers_data): Remove.
14249         (update_registers_callback): Change type.
14250         (arm_linux_insert_hw_breakpoint1): Update.
14251         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14252         parameter.
14253         (x86_linux_dr_set_addr): Update.
14254         (x86_linux_dr_set_control): Update.
14255         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14256         (iterate_over_lwps): Use gdb::function_view.
14257         * nat/aarch64-linux-hw-point.c (struct
14258         aarch64_dr_update_callback_param): Remove.
14259         (debug_reg_change_callback): Change type.
14260         (aarch64_notify_debug_reg_change): Update.
14261         * s390-linux-nat.c (s390_refresh_per_info): Update.
14263 2019-03-11  Tom Tromey  <tromey@adacore.com>
14265         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14266         redundant assignment to "this_cu".
14268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14270         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14274         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14275         from...
14276         (rank_one_type): ... this.
14278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14280         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14281         from...
14282         (rank_one_type): ... this.
14284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14286         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14287         from...
14288         (rank_one_type): ... this.
14290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14292         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14293         from...
14294         (rank_one_type): ... this.
14296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14298         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14299         from...
14300         (rank_one_type): ... this.
14302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14304         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14305         from...
14306         (rank_one_type): ... this.
14308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14310         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14311         from...
14312         (rank_one_type): ... this.
14314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14316         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14317         from...
14318         (rank_one_type): ... this.
14320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14322         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14323         from...
14324         (rank_one_type): ... this.
14326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14328         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14329         from...
14330         (rank_one_type): ... this.
14332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14334         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14335         from...
14336         (rank_one_type): ... this.
14338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14340         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14341         from...
14342         (rank_one_type): ... this.
14344 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14346         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14347         inferior-events' shows the example events.
14349 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14351         Support styling on native MS-Windows console
14353         PR/24315
14354         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14355         on MS-Windows if $TERM is not defined.
14357         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14359         * posix-hdep.c (gdb_console_fputs):
14360         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14361         functions.
14362         * ui-file.h (gdb_console_fputs): Add prototype.
14364         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14365         back to fputs only if the former returns zero.
14367 2019-03-07  Tom Tromey  <tom@tromey.com>
14369         * symmisc.c (print_symbol_bcache_statistics): Update.
14370         (print_objfile_statistics): Update.
14371         * symfile.c (allocate_symtab): Update.
14372         * stabsread.c: Don't include bcache.h.
14373         * psymtab.h (struct psymbol_bcache): Don't declare.
14374         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14375         (psymbol_bcache_init, psymbol_bcache_free)
14376         (psymbol_bcache_get_bcache): Don't declare.
14377         * psymtab.c (struct psymbol_bcache): Remove.
14378         (psymtab_storage::psymtab_storage): Update.
14379         (psymtab_storage::~psymtab_storage): Update.
14380         (psymbol_bcache_init, psymbol_bcache_free)
14381         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14382         (add_psymbol_to_bcache): Update.
14383         (allocate_psymtab): Update.
14384         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14385         macro_cache>: No longer pointers.
14386         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14387         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14388         * macrotab.c (macro_bcache): Update.
14389         * macroexp.c: Don't include bcache.h.
14390         * gdbtypes.c (check_types_worklist): Update.
14391         (types_deeply_equal): Remove TRY/CATCH.  Update.
14392         * elfread.c (elf_symtab_read): Update.
14393         * dwarf2read.c: Don't include bcache.h.
14394         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14395         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14396         (print_bcache_statistics, bcache_memory_used): Don't declare.
14397         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14398         methods.  Rename all data members.
14399         * bcache.c (struct bcache): Move to bcache.h.
14400         (bcache::expand_hash_table): Rename from expand_hash_table.
14401         (bcache): Remove.
14402         (bcache::insert): Rename from bcache_full.
14403         (bcache::compare): Rename from bcache_compare.
14404         (bcache_xmalloc): Remove.
14405         (bcache::~bcache): Rename from bcache_xfree.
14406         (bcache::print_statistics): Rename from print_bcache_statistics.
14407         (bcache::memory_used): Rename from bcache_memory_used.
14409 2019-03-07  Pedro Alves  <palves@redhat.com>
14411         * infrun.c (normal_stop): Also check for
14412         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14414 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14416         * f-lang.c (value_from_host_double): Moved to...
14417         * value.c (value_from_host_double): ...here.
14418         * value.h (value_from_host_double): Declare.
14419         * guile/scm-math.c (vlscm_convert_typed_number): Use
14420         value_from_host_double.
14421         (vlscm_convert_number): Likewise.
14422         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14423         * python/py-value.c (convert_value_from_python): Likewise.
14425 2019-03-06  Tom Tromey  <tom@tromey.com>
14427         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14429 2019-03-06  Tom Tromey  <tom@tromey.com>
14431         * utils.h (free_current_contents): Don't declare.
14432         * utils.c (free_current_contents): Remove.
14434 2019-03-06  Tom Tromey  <tom@tromey.com>
14436         * top.c (quit_force): Update.
14437         * main.c (captured_command_loop): Update.
14438         * common/new-op.c (operator new): Update.
14439         * common/common-exceptions.c (struct catcher)
14440         <save_cleanup_chain>: Remove member.
14441         (exceptions_state_mc_init): Update.
14442         (exception_try_scope_entry): Return nullptr.
14443         (exception_try_scope_exit, exception_rethrow)
14444         (throw_exception_sjlj, throw_exception_cxx): Update.
14445         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14446         (all_cleanups, do_cleanups, discard_cleanups)
14447         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14448         (restore_cleanups, restore_final_cleanups): Don't declare.
14449         (do_final_cleanups): Remove parameter.
14450         * common/cleanups.c (cleanup_chain, make_cleanup)
14451         (make_cleanup_dtor, all_cleanups, do_cleanups)
14452         (discard_my_cleanups, discard_cleanups)
14453         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14454         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14455         (null_cleanup): Remove.
14456         (do_final_cleanups): Remove parameter.
14458 2019-03-06  Tom Tromey  <tom@tromey.com>
14460         * remote.c (remote_target::remote_parse_stop_reply): Use
14461         unique_xmalloc_ptr.
14463 2019-03-06  Tom Tromey  <tom@tromey.com>
14465         * stabsread.c (struct stabs_field_info): Rename from field_info.
14466         <list, fnlist>: Add initializers.
14467         <obstack>: New member.
14468         (read_member_functions, read_struct_fields, read_baseclasses):
14469         Allocate on obstack.  Don't use cleanups.
14470         (read_one_struct_field, read_member_functions, read_struct_fields)
14471         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14472         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14473         (read_struct_type): Update.
14475 2019-03-06  Tom Tromey  <tom@tromey.com>
14477         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14478         * common/filestuff.h (make_cleanup_close): Don't declare.
14479         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14480         Remove.
14482 2019-03-06  Tom Tromey  <tom@tromey.com>
14484         * solib-aix.c: Use make_scope_exit.
14486 2019-03-06  Tom Tromey  <tom@tromey.com>
14488         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14489         Use make_scope_exit.
14491 2019-03-06  Tom Tromey  <tom@tromey.com>
14493         * solib-svr4.c (disable_probes_interface): Remove parameter.
14494         (svr4_handle_solib_event): Use make_scope_exit.
14496 2019-03-06  Tom Tromey  <tom@tromey.com>
14498         * remote.c (struct stop_reply_deleter): Remove.
14499         (stop_reply_up): Update.
14500         (struct stop_reply): Derive from notif_event.  Don't typedef.
14501         <regcache>: Now a std::vector.
14502         (stop_reply_xfree): Remove.
14503         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14504         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14505         (remote_target::discard_pending_stop_replies): Use delete.
14506         (remote_target::remote_parse_stop_reply): Update.
14507         (remote_target::process_stop_reply): Update.
14508         * remote-notif.h (struct notif_event): Add virtual destructor.
14509         Remove "dtr" member.
14510         (struct notif_client) <alloc_event>: Return a unique_ptr.
14511         (notif_event_xfree): Don't declare.
14512         (notif_event_up): New typedef.
14513         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14514         (notif_event_xfree, do_notif_event_xfree): Remove.
14515         (remote_notif_state_xfree): Update.
14517 2019-03-06  Tom Tromey  <tom@tromey.com>
14519         * infrun.c (displaced_step_clear_cleanup): Now a
14520         forward_scope_exit type.
14521         (displaced_step_prepare_throw): Update.
14522         (displaced_step_fixup): Update.
14524 2019-03-06  Tom Tromey  <tom@tromey.com>
14526         * inferior.h (class inferior): Update comment.
14527         * gdbthread.h (class thread_info): Update comment.
14529 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14530             Tom Tromey  <tom@tromey.com>
14532         * stabsread.h (struct stab_section_list): Remove.
14533         (coffstab_build_psymtabs): Update.
14534         * dbxread.c (symbuf_sections): Now a std::vector.
14535         (sect_idx): New global.
14536         (fill_symbuf): Update.
14537         (coffstab_build_psymtabs): Change type of stabsects parameter.
14538         Update.
14539         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14540         std::vector.
14541         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14542         (coff_locate_sections): Update.
14543         (coff_symfile_read): Remove cleanups.  Update.
14544         (init_stringtab): Add storage parameter.
14545         (free_stringtab, free_stringtab_cleanup): Remove.
14546         (init_lineno): Add storage parameter.
14547         (free_linetab, free_linetab_cleanup): Remove.
14549 2019-03-06  Pedro Alves  <palves@redhat.com>
14551         * linux-fork.c (fork_info::clobber_regs): Delete.
14552         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14553         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14554         comment.  Adjust.
14555         (scoped_switch_fork_info::scoped_switch_fork_info)
14556         (checkpoint_command, linux_fork_context): Adjust
14557         fork_save_infrun_state calls.
14559 2019-03-06  Pedro Alves  <palves@redhat.com>
14561         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14562         (inf_has_multiple_threads): Return 'bool' and rewrite using
14563         inferior_info::threads().
14565 2019-03-06  Pedro Alves  <palves@redhat.com>
14567         * linux-fork.c: Include <list>.
14568         (fork_list): Now a std::list instance.
14569         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14570         (forks_exist_p, find_last_fork): Adjust.
14571         (new_fork): Delete.
14572         (one_fork_p): New.
14573         (add_fork): Adjust.
14574         (free_fork): Delete, folded into fork_info::~fork_info().
14575         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14576         Adjust.
14577         (init_fork_list): Delete.
14578         (linux_fork_killall, linux_fork_mourn_inferior)
14579         (linux_fork_detach, info_checkpoints_command): Adjust.
14580         (_initialize_linux_fork): No longer call init_fork_list.
14582 2019-03-06  Pedro Alves  <palves@redhat.com>
14584         * linux-fork.c (new_fork): New, split out of ...
14585         (add_fork): ... this.  Return void.  Move "first fork" special
14586         case from here, to ...
14587         (checkpoint_command): ... here.
14588         * linux-linux.h (add_fork): Return void.
14590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14592         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14595             Chris January  <chris.january@arm.com>
14596             David Lecomber  <david.lecomber@arm.com>
14598         * f-exp.y: New token, UNOP_INTRINSIC.
14599         (exp): New pattern using UNOP_INTRINSIC token.
14600         (f77_keywords): Add 'abs' keyword.
14601         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14602         (value_from_host_double): New function.
14603         (evaluate_subexp_f): Support UNOP_ABS.
14605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14607         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14608         types.
14610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14612         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14613         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14614         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14618         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14621             Chris January  <chris.january@arm.com>
14623         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14624         * f-exp.y: Define 'KIND' token.
14625         (exp): New pattern for KIND expressions.
14626         (ptype): Handle types with a kind extension.
14627         (direct_abs_decl): Extend to spot kind extensions.
14628         (f77_keywords): Add 'kind' to the list.
14629         (push_kind_type): New function.
14630         (convert_to_kind_type): New function.
14631         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14632         * parse.c (operator_length_standard): Likewise.
14633         * parser-defs.h (enum type_pieces): Add tp_kind.
14634         * std-operator.def: Add UNOP_KIND.
14636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14638         * f-exp.y (f_parse): Set yydebug.
14640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14642         * f-lang.c (evaluate_subexp_f): New function.
14643         (exp_descriptor_f): New global.
14644         (f_language_defn): Use exp_descriptor_f instead of
14645         exp_descriptor_standard.
14647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14649         * f-exp.y (struct token): Add comments.
14650         (dot_ops): Remove uppercase versions and the end marker.
14651         (f77_keywords): Likewise.
14652         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14653         entries in the dot_ops array are case insensitive, and use
14654         strncasecmp to compare strings.  Also some whitespace cleanup in
14655         this area.  Similar for the f77_keywords array, except entries in
14656         this list might be case sensitive.
14658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14660         * f-exp.y (struct f77_boolean_val): Add comments.
14661         (boolean_values): Remove uppercase versions, and end marker.
14662         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14663         and use strncasecmp to achieve case insensitivity.  Additionally,
14664         perform whitespace cleanup around this code.
14666 2019-03-06  Tom Tromey  <tromey@adacore.com>
14668         * remote-sim.c (gdbsim_target_open): Use result of
14669         gdb_argv::release.
14671 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14672         Dirk Schubert  <dirk.schubert@arm.com>
14673         Chris January  <chris.january@arm.com>
14675         * eval.c (evaluate_subexp_standard): Call Fortran argument
14676         wrapping logic.
14677         * f-lang.c (struct value): A value which can be passed into a
14678         Fortran function call.
14679         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14680         where appropriate.
14681         (struct type): Value ready for a Fortran function call.
14682         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14683         is needed.
14684         * f-lang.h (fortran_argument_convert): Declaration.
14685         (fortran_preserve_arg_pointer): Declaration.
14686         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14688 2019-03-05  Tom Tromey  <tromey@adacore.com>
14690         * python/py-prettyprint.c (print_string_repr): Remove #if.
14691         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14693 2019-03-05  Tom Tromey  <tromey@adacore.com>
14695         * target.c (the_dummy_target): Move later.  Change type to
14696         "dummy_target".
14697         (initialize_targets): Don't initialize the_dummy_target.
14699 2019-03-05  Tom Tromey  <tromey@adacore.com>
14701         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14702         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14704 2019-03-05  Tom Tromey  <tromey@adacore.com>
14706         * windows-nat.c (windows_nat_target::attach)
14707         (windows_nat_target::detach): Don't call gdb_flush.
14708         * valprint.c (generic_val_print, val_print, val_print_string):
14709         Don't call gdb_flush.
14710         * utils.c (defaulted_query): Don't call gdb_flush.
14711         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14712         * target.c (target_announce_detach): Don't call gdb_flush.
14713         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14714         * remote.c (extended_remote_target::attach): Don't call
14715         gdb_flush.
14716         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14717         * printcmd.c (do_examine): Don't call gdb_flush.
14718         (info_display_command): Don't call gdb_flush.
14719         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14720         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14721         * memattr.c (info_mem_command): Don't call gdb_flush.
14722         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14723         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14724         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14725         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14726         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14727         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14728         (gnu_nat_target::detach): Don't call gdb_flush.
14729         * f-valprint.c (f_val_print): Don't call gdb_flush.
14730         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14731         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14732         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14733         gdb_flush.
14734         * c-valprint.c (c_val_print): Don't call gdb_flush.
14735         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14737 2019-03-05  Tom Tromey  <tromey@adacore.com>
14739         * varobj.c (update_dynamic_varobj_children): Update.
14740         (install_default_visualizer): Use reset, not release.
14741         * value.c (set_internalvar): Update.
14742         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14743         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14744         ATTRIBUTE_UNUSED_RESULT.
14746 2019-03-05  Tom Tromey  <tromey@adacore.com>
14748         * remote.c (class scoped_remote_fd) <release>: Add
14749         ATTRIBUTE_UNUSED_RESULT.
14751 2019-03-05  Tom Tromey  <tromey@adacore.com>
14753         * macroexp.c (struct macro_buffer) <release>: Add
14754         ATTRIBUTE_UNUSED_RESULT.
14756 2019-03-05  Tom Tromey  <tromey@adacore.com>
14758         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14759         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14760         ATTRIBUTE_UNUSED_RESULT.
14762 2019-03-05  Tom Tromey  <tromey@adacore.com>
14764         * common/scoped_fd.h (class scoped_fd) <release>: Add
14765         ATTRIBUTE_UNUSED_RESULT.
14767 2019-03-05  Tom Tromey  <tromey@adacore.com>
14769         * parser-defs.h (struct parser_state) <release>: Add
14770         ATTRIBUTE_UNUSED_RESULT.
14772 2019-03-05  Tom Tromey  <tromey@adacore.com>
14774         * utils.h (class gdb_argv) <release>: Add
14775         ATTRIBUTE_UNUSED_RESULT.
14776         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14778 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14780         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14781         for-loop range, to avoid compiler warnings.
14783         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14784         avoid compiler warnings about unused variables.
14786         * NEWS: Mention end of support for native debugging on MS-Windows
14787         before XP.
14789         PR gdb/24292
14790         * common/netstuff.c:
14791         * gdbserver/gdbreplay.c
14792         * gdbserver/remote-utils.c:
14793         * ser-tcp.c:
14794         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14795         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14796         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14797         'getaddrinfo' and 'freeaddrinfo' were not available before
14798         Windows XP, and mingw.org's MinGW headers by default define
14799         _WIN32_WINNT to 0x500.
14801 2019-03-01  Gary Benson <gbenson@redhat.com>
14803         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14805 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14806             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14808         PR gdb/8527
14809         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14810         set_sigint_trap, clear_sigint_trap.
14812 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14814         * target.c (target_detach): Clear the regcache and the
14815         frame cache.
14817 2019-02-27  Pedro Alves  <palves@redhat.com>
14819         * utils.c (set_screen_size): When we cap the height/width sizes,
14820         tweak the corresponding command variable to show "unlimited":
14822 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14823             Pedro Alves  <palves@redhat.com>
14825         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14826         before calling rl_set_screen_size.
14828 2019-02-27  Tom Tromey  <tromey@adacore.com>
14830         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14831         define.
14832         * python/py-value.c: Remove Python 2.4 workaround.
14833         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14834         workaround.
14835         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14836         Python 2.4 workaround.
14837         * python/python-internal.h: Remove Python 2.4 comment.
14838         (Py_ssize_t): Don't define.
14839         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14840         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14841         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14842         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14843         * python/python.c (do_start_initialization): Remove Python 2.4
14844         workaround.
14845         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14846         (print_children): Remove Python 2.4 workaround.
14847         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14848         workaround.
14849         (CHARBUFFERPROC_NAME): Remove.
14850         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14851         Python 2.4 workaround.
14853 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14855         * NEWS: Note minimum Python version.
14857 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14859         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14860         code from these functions.  Remove corresponding ifdefs.  Use
14861         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14862         Remove gotos and target of gotos.
14863         (infpy_search_memory): Likewise.
14865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14867         * hppa-tdep.c (hppa_dummy_id): Delete.
14868         (hppa_gdbarch_init): Don't register deleted functions with
14869         gdbarch.
14871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14873         * h8300-tdep.c (h8300_unwind_pc): Delete.
14874         (h8300_unwind_sp): Delete.
14875         (h8300_dummy_id): Delete.
14876         (h8300_gdbarch_init): Don't register deleted functions with
14877         gdbarch.
14879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14881         * ft32-tdep.c (ft32_dummy_id): Delete.
14882         (ft32_unwind_pc): Delete.
14883         (ft32_unwind_sp): Delete.
14884         (ft32_gdbarch_init): Don't register deleted functions with
14885         gdbarch.
14887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14889         * frv-tdep.c (frv_dummy_id): Delete.
14890         (frv_unwind_pc): Delete.
14891         (frv_unwind_sp): Delete.
14892         (frv_gdbarch_init): Don't register deleted functions with
14893         gdbarch.
14895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14897         * riscv-tdep.c (riscv_dummy_id): Delete.
14898         (riscv_unwind_pc): Delete.
14899         (riscv_unwind_sp): Delete.
14900         (riscv_gdbarch_init): Don't register deleted functions with
14901         gdbarch.
14903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14905         * csky-tdep.c (csky_dummy_id): Delete.
14906         (csky_unwind_pc): Delete.
14907         (csky_unwind_sp): Delete.
14908         (csky_gdbarch_init): Don't register deleted functions with
14909         gdbarch.
14911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14913         * cris-tdep.c (cris_dummy_id): Delete.
14914         (cris_unwind_pc): Delete.
14915         (cris_unwind_sp): Delete.
14916         (cris_gdbarch_init): Don't register deleted functions with
14917         gdbarch.
14919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14921         * bfin-tdep.c (bfin_dummy_id): Delete.
14922         (bfin_unwind_pc): Delete.
14923         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14927         * arm-tdep.c (arm_dummy_id): Delete.
14928         (arm_unwind_pc): Delete.
14929         (arm_unwind_sp): Delete.
14930         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14934         * arc-tdep.c (arc_dummy_id): Delete.
14935         (arc_unwind_pc): Delete.
14936         (arc_unwind_sp): Delete.
14937         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14941         * alpha-tdep.c (alpha_dummy_id): Delete.
14942         (alpha_unwind_pc): Delete.
14943         (alpha_gdbarch_init): Don't register deleted functions with
14944         gdbarch.
14946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14948         * aarch64-tdep.c (aarch64_dummy_id): Delete.
14949         (aarch64_unwind_pc): Delete.
14950         (aarch64_unwind_sp): Delete.
14951         (aarch64_gdbarch_init): Don't register deleted functions with
14952         gdbarch.
14954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14956         * gdbtypes.c (type_align): Don't consider static members when
14957         computing structure alignment.
14959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14961         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14962         return 0 for other types.
14963         * arch-utils.c (default_type_align): Always return 0.
14964         * gdbarch.h: Regenerate.
14965         * gdbarch.sh (type_align): Extend comment.
14966         * gdbtypes.c (type_align): Add additional comments, always call
14967         gdbarch_type_align before applying the default rules.
14968         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14969         generic code will then apply a suitable default.
14970         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14971         types, return 0 for other types.
14973 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14975         * NEWS: Create a new section for the next release branch.
14976         Rename the section of the current branch, now that it has
14977         been cut.
14979 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14981         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14982         * version.in: Bump version to 8.3.50.DATE-git.
14984 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14986         * aix-thread.c (ptid_cmp): Remove unused variable.
14987         (get_signaled_thread): Likewise.
14988         (store_regs_user_thread): Likewise.
14989         (store_regs_kernel_thread): Likewise.
14990         (fetch_regs_kernel_thread): Remove shadowed variable.
14992 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14994         * features/riscv/32bit-cpu.xml: Add register numbers.
14995         * features/riscv/32bit-fpu.c: Regenerate.
14996         * features/riscv/32bit-fpu.xml: Add register numbers.
14997         * features/riscv/64bit-cpu.xml: Add register numbers.
14998         * features/riscv/64bit-fpu.c: Regenerate.
14999         * features/riscv/64bit-fpu.xml: Add register numbers.
15001 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
15003         * NEWS: Mention two argument form of gdb.Value constructor.
15004         * python/py-value.c (convert_buffer_and_type_to_value): New
15005         function.
15006         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
15007         Add support for handling an optional second argument.  Call
15008         convert_buffer_and_type_to_value as appropriate.
15009         * python/python-internal.h (Py_buffer_deleter): New struct.
15010         (Py_buffer_up): New typedef.
15012 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
15014         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
15015         instead of releasing ownership.
15017 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
15019         * dwarf2read.c (open_and_init_dwp_file): Call
15020         elf_numsections instead of bfd_count_sections to initialize
15021         dwp_file->num_sections.
15023 2019-02-25  Tom Tromey  <tromey@adacore.com>
15025         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
15027 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
15029         * gcore.in: Add '--readnever' option when invoking GDB.
15031 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
15033         * MAINTAINERS: Update my email address.
15035 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
15037         * build-id.c (build_id_to_debug_bfd_1): New function.
15038         (build_id_to_debug_bfd): Look for separate debug file in
15039         sysroot.
15041 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
15043         * gdbarch.sh: Update the copyright year range that is placed into
15044         generated files.
15046 2019-02-22  Keith Seitz  <keiths@redhat.com>
15048         PR symtab/23853
15049         * linespec.c (create_sals_line_offset): Search for the default
15050         symtab's filename instead of its fullname.
15052 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
15054         * NEWS: Update style defaults.
15056 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
15058         * main.c (captured_main_1): Disable styling in batch mode.
15060 2019-02-20  Tom Tromey  <tom@tromey.com>
15062         * symtab.c (symtab_symbol_info): Fix typos.
15064 2019-02-20  Tom Tromey  <tromey@adacore.com>
15066         * findcmd.c (_initialize_mem_search): Use upper case for
15067         metasyntactic variables.
15069 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
15071         * aarch64-tdep.c (aarch64_add_reggroups): New function.
15072         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
15074 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
15076         * top.h (source_file_name): Change to std::string.
15077         * top.c (source_file_name): Likewise.
15078         (command_line_input): Adjust.
15079         * cli/cli-script.c (script_from_file): Adjust.
15081 2019-02-19  Tom Tromey  <tromey@adacore.com>
15083         * ravenscar-thread.c
15084         (ravenscar_thread_target::update_thread_list): Don't call
15085         ada_build_task_list.
15086         * ada-lang.h (ada_build_task_list): Don't declare.
15087         * ada-tasks.c (struct ada_tasks_inferior_data)
15088         <task_list_valid_p>: Now bool.
15089         (read_known_tasks, ada_task_list_changed)
15090         (ada_tasks_invalidate_inferior_data): Update.
15091         (read_known_tasks_array): Return bool.
15092         (read_known_tasks_list): Likewise.
15093         (read_known_tasks): Return void.
15094         (ada_build_task_list): Now static.
15096 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
15098         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
15099         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
15101 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15103         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15104         variant for ada_tasks_pspace_data_handle and
15105         ada_tasks_inferior_data_handle.
15106         (ada_tasks_pspace_data_cleanup): New function.
15107         (ada_tasks_inferior_data_cleanup): New function.
15109 2019-02-17  Tom Tromey  <tom@tromey.com>
15111         * macrotab.h (macro_source_fullname): Return a std::string.
15112         * macrotab.c (macro_include, check_for_redefinition)
15113         (macro_undef, macro_lookup_definition, foreach_macro)
15114         (foreach_macro_in_scope): Update.
15115         (macro_source_fullname): Return a std::string.
15116         * macrocmd.c (show_pp_source_pos): Update.
15118 2019-02-17  Tom Tromey  <tom@tromey.com>
15120         * macrocmd.c (show_pp_source_pos): Style the file names.
15122 2019-02-17  Tom Tromey  <tom@tromey.com>
15124         PR tui/24197:
15125         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15127 2019-02-17  Tom Tromey  <tom@tromey.com>
15129         * ada-lang.c (user_select_syms): Use filtered printing.
15130         * utils.c (wrap_style): New global.
15131         (desired_style): Remove.
15132         (emit_style_escape): Add stream parameter.
15133         (set_output_style, reset_terminal_style, prompt_for_continue):
15134         Update.
15135         (flush_wrap_buffer): Only flush gdb_stdout.
15136         (wrap_here): Set wrap_style.
15137         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
15138         treat escape sequences as a character.  Change when wrap buffer is
15139         flushed.
15140         (fputs_styled): Do not set the output style when the default is
15141         requested.
15142         * ui-style.h (struct ui_file_style) <is_default>: New method.
15143         * source.c (print_source_lines_base): Emit escape sequences in one
15144         piece.
15146 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15148         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15149         integers and enumeration types.
15151 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15153         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15154         instead of lookup_symbol_in_language
15155         (do_exact_match): New function.
15156         (ada_get_symbol_name_matcher): Return do_exact_match when
15157         doing a verbatim match.
15159 2019-02-15  Tom Tromey  <tromey@adacore.com>
15161         * ravenscar-thread.c (ravenscar_thread_target::resume)
15162         (ravenscar_thread_target::wait): Special case wildcard requests.
15164 2019-02-15  Tom Tromey  <tromey@adacore.com>
15166         * ravenscar-thread.c (base_ptid): Remove.
15167         (struct ravenscar_thread_target) <close>: New method.
15168         <m_base_ptid>: New member.
15169         <update_inferior_ptid, active_task, task_is_currently_active,
15170         runtime_initialized>: Declare methods.
15171         <ravenscar_thread_target>: Add constructor.
15172         (ravenscar_thread_target::task_is_currently_active)
15173         (ravenscar_thread_target::update_inferior_ptid)
15174         (ravenscar_runtime_initialized): Rename.  Now methods.
15175         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15176         (ravenscar_thread_target::update_thread_list): Update.
15177         (ravenscar_thread_target::active_task): Now method.
15178         (ravenscar_thread_target::store_registers)
15179         (ravenscar_thread_target::prepare_to_store)
15180         (ravenscar_thread_target::prepare_to_store)
15181         (ravenscar_thread_target::mourn_inferior): Update.
15182         (ravenscar_inferior_created): Use "new" to create target.
15183         (ravenscar_thread_target::get_ada_task_ptid): Update.
15184         (_initialize_ravenscar): Don't initialize base_ptid.
15185         (ravenscar_ops): Remove global.
15187 2019-02-15  Tom Tromey  <tromey@adacore.com>
15189         * target.h (push_target): Declare new overload.
15190         * target.c (push_target): New overload, taking an rvalue reference.
15191         * remote.c (remote_target::open_1): Use push_target overload.
15192         * corelow.c (core_target_open): Use push_target overload.
15194 2019-02-15  Tom Tromey  <tromey@adacore.com>
15196         * ravenscar-thread.c (is_ravenscar_task)
15197         (ravenscar_task_is_currently_active): Return bool.
15198         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15199         (_initialize_ravenscar): Remove "(void)".
15200         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15201         Return bool.
15203 2019-02-15  Tom Tromey  <tromey@adacore.com>
15205         * ravenscar-thread.c (ravenscar_runtime_initializer)
15206         (has_ravenscar_runtime, get_running_thread_id)
15207         (ravenscar_thread_target::resume): Fix indentation.
15209 2019-02-15  Tom Tromey  <tromey@adacore.com>
15211         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15212         from ravenscar_arch_ops.
15213         (sparc_ravenscar_ops::fetch_registers)
15214         (sparc_ravenscar_ops::store_registers): Now methods.
15215         (sparc_ravenscar_prepare_to_store): Remove.
15216         (sparc_ravenscar_ops): Redefine.
15217         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15218         methods and destructor.  Remove members.
15219         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15220         (ravenscar_thread_target::store_registers)
15221         (ravenscar_thread_target::prepare_to_store): Update.
15222         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15223         Remove.
15224         (struct ppc_ravenscar_powerpc_ops): Derive from
15225         ravenscar_arch_ops.
15226         (ppc_ravenscar_powerpc_ops::fetch_registers)
15227         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15228         (ppc_ravenscar_powerpc_ops): Redefine.
15229         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15230         (ppc_ravenscar_e500_ops::fetch_registers)
15231         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15232         (ppc_ravenscar_e500_ops): Redefine.
15233         * aarch64-ravenscar-thread.c
15234         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15235         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15236         (aarch64_ravenscar_fetch_registers)
15237         (aarch64_ravenscar_store_registers): Now methods.
15238         (aarch64_ravenscar_ops): Redefine.
15240 2019-02-15  Tom Tromey  <tromey@adacore.com>
15242         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15243         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15244         (ravenscar_thread_target::stopped_by_watchpoint)
15245         (ravenscar_thread_target::stopped_data_address)
15246         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15248 2019-02-15  Tom Tromey  <tromey@adacore.com>
15250         * ravenscar-thread.c: Fix some typos.
15252 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15253             Tom Tromey  <tromey@adacore.com>
15255         * ada-lang.c (ada_exception_sal): Change addr_string to a
15256         std::string.
15257         (create_ada_exception_catchpoint): Update.
15259 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15260             Tom Tromey  <tromey@adacore.com>
15262         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15263         (bp_location_ops): Remove.
15264         (base_breakpoint_allocate_location): Update.
15265         (free_bp_location): Update.
15266         * ada-lang.c (class ada_catchpoint_location)
15267         <ada_catchpoint_location>: Remove ops parameter.
15268         (ada_catchpoint_location_dtor): Remove.
15269         (ada_catchpoint_location_ops): Remove.
15270         (allocate_location_exception): Update.
15271         * breakpoint.h (struct bp_location_ops): Remove.
15272         (class bp_location) <bp_location>: Remove bp_location_ops
15273         parameter.
15274         <~bp_location>: Add destructor.
15275         <ops>: Remove.
15277 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15278             Pedro Alves  <palves@redhat.com>
15280         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15281         'PATH_MAX'.
15283 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15284             Samuel Thibault  <samuel.thibault@gnu.org>
15285             Thomas Schwinge  <thomas@codesourcery.com>
15287         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15288         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15290 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15292         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15293         (check_empty): Use "const char *".
15295         * gnu-nat.c (gnu_nat_target::detach): Instead of
15296         'detach_inferior (pid)' call
15297         'detach_inferior (find_inferior_pid (pid))'.
15299         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15300         'nat/fork-inferior.o'.
15301         * gnu-nat.c: #include "nat/fork-inferior.h".
15303         * gnu-nat.c (gnu_nat_target::detach): Instead of
15304         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15305         * gnu-nat.h: #include "inf-child.h".
15306         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15307         'i386_gnu_nat_target::fetch_registers'.
15308         (gnu_store_registers): Rename/move to
15309         'i386_gnu_nat_target::store_registers'.
15311         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15312         * gnu-nat.h (mach_thread_info): New function.
15313         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15315         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15317 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15319         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15321 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15323         * windows-nat.c (windows_add_thread): Add new parameter
15324         "main_thread_p" with default value set to false.  Update
15325         function documentation as well as all callers.
15326         (windows_delete_thread): Likewise.
15327         (fake_create_process): Update call to windows_add_thread.
15328         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15329         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15330         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15331         call to windows_delete_thread.
15333 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15335         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15337 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15339         * symfile.c (find_separate_debug_file): Use canonical path of
15340         sysroot with child_path instead of gdb_sysroot if it is valid.
15342 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15344         * symfile.c (find_separate_debug_file): Use child_path to
15345         determine if an object file is under a sysroot.
15347 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15349         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15350         unittests/child-path-selftests.c.
15351         * common/pathstuff.c (child_path): New function.
15352         * common/pathstuff.h (child_path): New prototype.
15353         * unittests/child-path-selftests.c: New file.
15355 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15357         * symfile.c (find_separate_debug_file): Look for separate debug
15358         files in debug directories under the sysroot.
15360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15362         * symtab.h (struct minimal_symbol data_p): New const method.
15363         (struct minimal_symbol text_p): Likewise.
15364         * symtab.c (output_source_filename): Use file name style
15365         to print file name.
15366         (print_symbol_info): Likewise.
15367         (print_msymbol_info): Use address style to print addresses.
15368         Use function name style to print executable text symbols.
15369         (expand_symtab_containing_pc): Use data_p.
15370         (find_pc_sect_compunit_symtab): Likewise.
15372 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15374         * breakpoint.c (describe_other_breakpoints): Use address style
15375         to print addresses.
15376         (say_where): Likewise.
15378 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15380         * ada-typeprint.c (print_func_type): Print function name
15381         style to print function name.
15382         * c-typeprint.c (c_print_type_1): Likewise.
15384 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15386         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15387         for execve.
15389 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15391         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15392         type_stack.
15394 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15396         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15397         TYPE_CODE_REF types.
15399 2019-02-08  Jim Wilson  <jimw@sifive.com>
15401         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15402         (riscv_linux_fregset): New.
15403         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15405 2019-02-07  Tom Tromey  <tom@tromey.com>
15407         * thread.c (thread_cancel_execution_command): Update.
15408         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15409         methods.
15410         (struct thread_fsm_ops): Remove.
15411         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15412         (thread_fsm_should_stop, thread_fsm_return_value)
15413         (thread_fsm_set_finished, thread_fsm_finished_p)
15414         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15415         Don't declare.
15416         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15417         * infrun.c (clear_proceed_status_thread)
15418         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15419         (print_stop_event): Update.
15420         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15421         Add constructor.
15422         (step_command_fsm_ops): Remove.
15423         (new_step_command_fsm): Remove.
15424         (step_1): Update.
15425         (step_command_fsm::should_stop): Rename from
15426         step_command_fsm_should_stop.
15427         (step_command_fsm::clean_up): Rename from
15428         step_command_fsm_clean_up.
15429         (step_command_fsm::do_async_reply_reason): Rename from
15430         step_command_fsm_async_reply_reason.
15431         (struct until_next_fsm): Inherit from thread_fsm.  Add
15432         constructor.
15433         (until_next_fsm_ops): Remove.
15434         (new_until_next_fsm): Remove.
15435         (until_next_fsm::should_stop): Rename from
15436         until_next_fsm_should_stop.
15437         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15438         (until_next_fsm::do_async_reply_reason): Rename from
15439         until_next_fsm_async_reply_reason.
15440         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15441         constructor.  Change type of breakpoint.
15442         (finish_command_fsm_ops): Remove.
15443         (new_finish_command_fsm): Remove.
15444         (finish_command_fsm::should_stop): Rename from
15445         finish_command_fsm_should_stop.
15446         (finish_command_fsm::clean_up): Rename from
15447         finish_command_fsm_clean_up.
15448         (finish_command_fsm::return_value): Rename from
15449         finish_command_fsm_return_value.
15450         (finish_command_fsm::do_async_reply_reason): Rename from
15451         finish_command_fsm_async_reply_reason.
15452         (finish_command): Update.
15453         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15454         Add constructor.
15455         (call_thread_fsm_ops): Remove.
15456         (call_thread_fsm::call_thread_fsm): Rename from
15457         new_call_thread_fsm.
15458         (call_thread_fsm::should_stop): Rename from
15459         call_thread_fsm_should_stop.
15460         (call_thread_fsm::should_notify_stop): Rename from
15461         call_thread_fsm_should_notify_stop.
15462         (run_inferior_call, call_function_by_hand_dummy): Update.
15463         * cli/cli-interp.c (should_print_stop_to_console): Update.
15464         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15465         Add constructor.  Change type of location_breakpoint,
15466         caller_breakpoint.
15467         (until_break_fsm_ops): Remove.
15468         (new_until_break_fsm): Remove.
15469         (until_break_fsm::should_stop): Rename from
15470         until_break_fsm_should_stop.
15471         (until_break_fsm::clean_up): Rename from
15472         until_break_fsm_clean_up.
15473         (until_break_fsm::do_async_reply_reason): Rename from
15474         until_break_fsm_async_reply_reason.
15475         (until_break_command): Update.
15476         * thread-fsm.c: Remove.
15477         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15479 2019-02-07  Tom Tromey  <tom@tromey.com>
15481         * yy-remap.h: Add include guard.
15482         * xtensa-tdep.h: Add include guard.
15483         * xcoffread.h: Rename include guard.
15484         * varobj-iter.h: Add include guard.
15485         * tui/tui.h: Rename include guard.
15486         * tui/tui-winsource.h: Rename include guard.
15487         * tui/tui-wingeneral.h: Rename include guard.
15488         * tui/tui-windata.h: Rename include guard.
15489         * tui/tui-win.h: Rename include guard.
15490         * tui/tui-stack.h: Rename include guard.
15491         * tui/tui-source.h: Rename include guard.
15492         * tui/tui-regs.h: Rename include guard.
15493         * tui/tui-out.h: Rename include guard.
15494         * tui/tui-layout.h: Rename include guard.
15495         * tui/tui-io.h: Rename include guard.
15496         * tui/tui-hooks.h: Rename include guard.
15497         * tui/tui-file.h: Rename include guard.
15498         * tui/tui-disasm.h: Rename include guard.
15499         * tui/tui-data.h: Rename include guard.
15500         * tui/tui-command.h: Rename include guard.
15501         * tic6x-tdep.h: Add include guard.
15502         * target/waitstatus.h: Rename include guard.
15503         * target/wait.h: Rename include guard.
15504         * target/target.h: Rename include guard.
15505         * target/resume.h: Rename include guard.
15506         * target-float.h: Rename include guard.
15507         * stabsread.h: Add include guard.
15508         * rs6000-tdep.h: Add include guard.
15509         * riscv-fbsd-tdep.h: Add include guard.
15510         * regformats/regdef.h: Rename include guard.
15511         * record.h: Rename include guard.
15512         * python/python.h: Rename include guard.
15513         * python/python-internal.h: Rename include guard.
15514         * python/py-stopevent.h: Rename include guard.
15515         * python/py-ref.h: Rename include guard.
15516         * python/py-record.h: Rename include guard.
15517         * python/py-record-full.h: Rename include guard.
15518         * python/py-record-btrace.h: Rename include guard.
15519         * python/py-instruction.h: Rename include guard.
15520         * python/py-events.h: Rename include guard.
15521         * python/py-event.h: Rename include guard.
15522         * procfs.h: Add include guard.
15523         * proc-utils.h: Add include guard.
15524         * p-lang.h: Add include guard.
15525         * or1k-tdep.h: Rename include guard.
15526         * observable.h: Rename include guard.
15527         * nto-tdep.h: Rename include guard.
15528         * nat/x86-linux.h: Rename include guard.
15529         * nat/x86-linux-dregs.h: Rename include guard.
15530         * nat/x86-gcc-cpuid.h: Add include guard.
15531         * nat/x86-dregs.h: Rename include guard.
15532         * nat/x86-cpuid.h: Rename include guard.
15533         * nat/ppc-linux.h: Rename include guard.
15534         * nat/mips-linux-watch.h: Rename include guard.
15535         * nat/linux-waitpid.h: Rename include guard.
15536         * nat/linux-ptrace.h: Rename include guard.
15537         * nat/linux-procfs.h: Rename include guard.
15538         * nat/linux-osdata.h: Rename include guard.
15539         * nat/linux-nat.h: Rename include guard.
15540         * nat/linux-namespaces.h: Rename include guard.
15541         * nat/linux-btrace.h: Rename include guard.
15542         * nat/glibc_thread_db.h: Rename include guard.
15543         * nat/gdb_thread_db.h: Rename include guard.
15544         * nat/gdb_ptrace.h: Rename include guard.
15545         * nat/fork-inferior.h: Rename include guard.
15546         * nat/amd64-linux-siginfo.h: Rename include guard.
15547         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15548         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15549         * nat/aarch64-linux.h: Rename include guard.
15550         * nat/aarch64-linux-hw-point.h: Rename include guard.
15551         * mn10300-tdep.h: Add include guard.
15552         * mips-linux-tdep.h: Add include guard.
15553         * mi/mi-parse.h: Rename include guard.
15554         * mi/mi-out.h: Rename include guard.
15555         * mi/mi-main.h: Rename include guard.
15556         * mi/mi-interp.h: Rename include guard.
15557         * mi/mi-getopt.h: Rename include guard.
15558         * mi/mi-console.h: Rename include guard.
15559         * mi/mi-common.h: Rename include guard.
15560         * mi/mi-cmds.h: Rename include guard.
15561         * mi/mi-cmd-break.h: Rename include guard.
15562         * m2-lang.h: Add include guard.
15563         * location.h: Rename include guard.
15564         * linux-record.h: Rename include guard.
15565         * linux-nat.h: Add include guard.
15566         * linux-fork.h: Add include guard.
15567         * i386-darwin-tdep.h: Rename include guard.
15568         * hppa-linux-offsets.h: Add include guard.
15569         * guile/guile.h: Rename include guard.
15570         * guile/guile-internal.h: Rename include guard.
15571         * gnu-nat.h: Rename include guard.
15572         * gdb-stabs.h: Rename include guard.
15573         * frv-tdep.h: Add include guard.
15574         * f-lang.h: Add include guard.
15575         * event-loop.h: Add include guard.
15576         * darwin-nat.h: Rename include guard.
15577         * cp-abi.h: Rename include guard.
15578         * config/sparc/nm-sol2.h: Rename include guard.
15579         * config/nm-nto.h: Rename include guard.
15580         * config/nm-linux.h: Add include guard.
15581         * config/i386/nm-i386gnu.h: Rename include guard.
15582         * config/djgpp/nl_types.h: Rename include guard.
15583         * config/djgpp/langinfo.h: Rename include guard.
15584         * compile/gcc-cp-plugin.h: Add include guard.
15585         * compile/gcc-c-plugin.h: Add include guard.
15586         * compile/compile.h: Rename include guard.
15587         * compile/compile-object-run.h: Rename include guard.
15588         * compile/compile-object-load.h: Rename include guard.
15589         * compile/compile-internal.h: Rename include guard.
15590         * compile/compile-cplus.h: Rename include guard.
15591         * compile/compile-c.h: Rename include guard.
15592         * common/xml-utils.h: Rename include guard.
15593         * common/x86-xstate.h: Rename include guard.
15594         * common/version.h: Rename include guard.
15595         * common/vec.h: Rename include guard.
15596         * common/tdesc.h: Rename include guard.
15597         * common/selftest.h: Rename include guard.
15598         * common/scoped_restore.h: Rename include guard.
15599         * common/scoped_mmap.h: Rename include guard.
15600         * common/scoped_fd.h: Rename include guard.
15601         * common/safe-iterator.h: Rename include guard.
15602         * common/run-time-clock.h: Rename include guard.
15603         * common/refcounted-object.h: Rename include guard.
15604         * common/queue.h: Rename include guard.
15605         * common/ptid.h: Rename include guard.
15606         * common/print-utils.h: Rename include guard.
15607         * common/preprocessor.h: Rename include guard.
15608         * common/pathstuff.h: Rename include guard.
15609         * common/observable.h: Rename include guard.
15610         * common/netstuff.h: Rename include guard.
15611         * common/job-control.h: Rename include guard.
15612         * common/host-defs.h: Rename include guard.
15613         * common/gdb_wait.h: Rename include guard.
15614         * common/gdb_vecs.h: Rename include guard.
15615         * common/gdb_unlinker.h: Rename include guard.
15616         * common/gdb_unique_ptr.h: Rename include guard.
15617         * common/gdb_tilde_expand.h: Rename include guard.
15618         * common/gdb_sys_time.h: Rename include guard.
15619         * common/gdb_string_view.h: Rename include guard.
15620         * common/gdb_splay_tree.h: Rename include guard.
15621         * common/gdb_setjmp.h: Rename include guard.
15622         * common/gdb_ref_ptr.h: Rename include guard.
15623         * common/gdb_optional.h: Rename include guard.
15624         * common/gdb_locale.h: Rename include guard.
15625         * common/gdb_assert.h: Rename include guard.
15626         * common/filtered-iterator.h: Rename include guard.
15627         * common/filestuff.h: Rename include guard.
15628         * common/fileio.h: Rename include guard.
15629         * common/environ.h: Rename include guard.
15630         * common/common-utils.h: Rename include guard.
15631         * common/common-types.h: Rename include guard.
15632         * common/common-regcache.h: Rename include guard.
15633         * common/common-inferior.h: Rename include guard.
15634         * common/common-gdbthread.h: Rename include guard.
15635         * common/common-exceptions.h: Rename include guard.
15636         * common/common-defs.h: Rename include guard.
15637         * common/common-debug.h: Rename include guard.
15638         * common/cleanups.h: Rename include guard.
15639         * common/buffer.h: Rename include guard.
15640         * common/btrace-common.h: Rename include guard.
15641         * common/break-common.h: Rename include guard.
15642         * cli/cli-utils.h: Rename include guard.
15643         * cli/cli-style.h: Rename include guard.
15644         * cli/cli-setshow.h: Rename include guard.
15645         * cli/cli-script.h: Rename include guard.
15646         * cli/cli-interp.h: Rename include guard.
15647         * cli/cli-decode.h: Rename include guard.
15648         * cli/cli-cmds.h: Rename include guard.
15649         * charset-list.h: Add include guard.
15650         * buildsym-legacy.h: Rename include guard.
15651         * bfin-tdep.h: Add include guard.
15652         * ax.h: Rename include guard.
15653         * arm-linux-tdep.h: Add include guard.
15654         * arm-fbsd-tdep.h: Add include guard.
15655         * arch/xtensa.h: Rename include guard.
15656         * arch/tic6x.h: Add include guard.
15657         * arch/i386.h: Add include guard.
15658         * arch/arm.h: Rename include guard.
15659         * arch/arm-linux.h: Rename include guard.
15660         * arch/arm-get-next-pcs.h: Rename include guard.
15661         * arch/amd64.h: Add include guard.
15662         * arch/aarch64-insn.h: Rename include guard.
15663         * arch-utils.h: Rename include guard.
15664         * annotate.h: Add include guard.
15665         * amd64-darwin-tdep.h: Rename include guard.
15666         * aarch64-linux-tdep.h: Add include guard.
15667         * aarch64-fbsd-tdep.h: Add include guard.
15668         * aarch32-linux-nat.h: Add include guard.
15670 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15672         * macrotab.c (macro_define_internal): New function that
15673         factorizes macro_define_object_internal and macro_define_function
15674         code.
15675         (macro_define_object_internal): Use macro_define_internal.
15676         (macro_define_function): Likewise.
15678 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15680         * macrocmd.c (extract_identifier): Return
15681         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15682         callers.
15684 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15686         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15688 2019-02-05  Tom Tromey  <tom@tromey.com>
15690         * target.c (target_stack::unpush): Move assertion earlier.
15692 2019-01-30  Tom Tromey  <tom@tromey.com>
15694         PR python/23615:
15695         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15696         (gdbpy_parse_and_eval): Likewise.
15697         * python/python-internal.h (gdbpy_allow_threads): New class.
15699 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15701         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15702         (aarch64_fbsd_fpregmap): Move earlier.
15703         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15704         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15705         instead of individual calls to trad_frame_set_reg_addr.
15706         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15707         earlier.
15708         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15709         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15710         instead of individual calls to trad_frame_set_reg_addr.
15712 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15714         * CONTRIBUTE: Replace contribution list with wiki link.
15716 2019-01-25  Tom Tromey  <tom@tromey.com>
15718         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15720 2019-01-25  Tom Tromey  <tom@tromey.com>
15722         * xtensa-linux-nat.c: Fix common/ includes.
15723         * xml-support.h: Fix common/ includes.
15724         * xml-support.c: Fix common/ includes.
15725         * x86-linux-nat.c: Fix common/ includes.
15726         * windows-nat.c: Fix common/ includes.
15727         * varobj.h: Fix common/ includes.
15728         * varobj.c: Fix common/ includes.
15729         * value.c: Fix common/ includes.
15730         * valops.c: Fix common/ includes.
15731         * utils.c: Fix common/ includes.
15732         * unittests/xml-utils-selftests.c: Fix common/ includes.
15733         * unittests/utils-selftests.c: Fix common/ includes.
15734         * unittests/unpack-selftests.c: Fix common/ includes.
15735         * unittests/tracepoint-selftests.c: Fix common/ includes.
15736         * unittests/style-selftests.c: Fix common/ includes.
15737         * unittests/string_view-selftests.c: Fix common/ includes.
15738         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15739         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15740         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15741         * unittests/rsp-low-selftests.c: Fix common/ includes.
15742         * unittests/parse-connection-spec-selftests.c: Fix common/
15743         includes.
15744         * unittests/optional-selftests.c: Fix common/ includes.
15745         * unittests/offset-type-selftests.c: Fix common/ includes.
15746         * unittests/observable-selftests.c: Fix common/ includes.
15747         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15748         * unittests/memrange-selftests.c: Fix common/ includes.
15749         * unittests/memory-map-selftests.c: Fix common/ includes.
15750         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15751         * unittests/function-view-selftests.c: Fix common/ includes.
15752         * unittests/environ-selftests.c: Fix common/ includes.
15753         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15754         * unittests/common-utils-selftests.c: Fix common/ includes.
15755         * unittests/cli-utils-selftests.c: Fix common/ includes.
15756         * unittests/array-view-selftests.c: Fix common/ includes.
15757         * ui-file.c: Fix common/ includes.
15758         * tui/tui-io.c: Fix common/ includes.
15759         * tracepoint.h: Fix common/ includes.
15760         * tracepoint.c: Fix common/ includes.
15761         * tracefile-tfile.c: Fix common/ includes.
15762         * top.h: Fix common/ includes.
15763         * top.c: Fix common/ includes.
15764         * thread.c: Fix common/ includes.
15765         * target/waitstatus.h: Fix common/ includes.
15766         * target/waitstatus.c: Fix common/ includes.
15767         * target.h: Fix common/ includes.
15768         * target.c: Fix common/ includes.
15769         * target-memory.c: Fix common/ includes.
15770         * target-descriptions.c: Fix common/ includes.
15771         * symtab.h: Fix common/ includes.
15772         * symfile.c: Fix common/ includes.
15773         * stap-probe.c: Fix common/ includes.
15774         * spu-linux-nat.c: Fix common/ includes.
15775         * sparc-nat.c: Fix common/ includes.
15776         * source.c: Fix common/ includes.
15777         * solib.c: Fix common/ includes.
15778         * solib-target.c: Fix common/ includes.
15779         * ser-unix.c: Fix common/ includes.
15780         * ser-tcp.c: Fix common/ includes.
15781         * ser-pipe.c: Fix common/ includes.
15782         * ser-base.c: Fix common/ includes.
15783         * selftest-arch.c: Fix common/ includes.
15784         * s12z-tdep.c: Fix common/ includes.
15785         * rust-exp.y: Fix common/ includes.
15786         * rs6000-aix-tdep.c: Fix common/ includes.
15787         * riscv-tdep.c: Fix common/ includes.
15788         * remote.c: Fix common/ includes.
15789         * remote-notif.h: Fix common/ includes.
15790         * remote-fileio.h: Fix common/ includes.
15791         * remote-fileio.c: Fix common/ includes.
15792         * regcache.h: Fix common/ includes.
15793         * regcache.c: Fix common/ includes.
15794         * record-btrace.c: Fix common/ includes.
15795         * python/python.c: Fix common/ includes.
15796         * python/py-type.c: Fix common/ includes.
15797         * python/py-inferior.c: Fix common/ includes.
15798         * progspace.h: Fix common/ includes.
15799         * producer.c: Fix common/ includes.
15800         * procfs.c: Fix common/ includes.
15801         * proc-api.c: Fix common/ includes.
15802         * printcmd.c: Fix common/ includes.
15803         * ppc-linux-nat.c: Fix common/ includes.
15804         * parser-defs.h: Fix common/ includes.
15805         * osdata.c: Fix common/ includes.
15806         * obsd-nat.c: Fix common/ includes.
15807         * nat/x86-linux.c: Fix common/ includes.
15808         * nat/x86-linux-dregs.c: Fix common/ includes.
15809         * nat/x86-dregs.h: Fix common/ includes.
15810         * nat/x86-dregs.c: Fix common/ includes.
15811         * nat/ppc-linux.c: Fix common/ includes.
15812         * nat/mips-linux-watch.h: Fix common/ includes.
15813         * nat/mips-linux-watch.c: Fix common/ includes.
15814         * nat/linux-waitpid.c: Fix common/ includes.
15815         * nat/linux-ptrace.h: Fix common/ includes.
15816         * nat/linux-ptrace.c: Fix common/ includes.
15817         * nat/linux-procfs.c: Fix common/ includes.
15818         * nat/linux-personality.c: Fix common/ includes.
15819         * nat/linux-osdata.c: Fix common/ includes.
15820         * nat/linux-namespaces.c: Fix common/ includes.
15821         * nat/linux-btrace.h: Fix common/ includes.
15822         * nat/linux-btrace.c: Fix common/ includes.
15823         * nat/fork-inferior.c: Fix common/ includes.
15824         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15825         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15826         * nat/aarch64-linux.c: Fix common/ includes.
15827         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15828         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15829         * namespace.h: Fix common/ includes.
15830         * mips-linux-tdep.c: Fix common/ includes.
15831         * minsyms.c: Fix common/ includes.
15832         * mi/mi-parse.h: Fix common/ includes.
15833         * mi/mi-main.c: Fix common/ includes.
15834         * mi/mi-cmd-env.c: Fix common/ includes.
15835         * memrange.h: Fix common/ includes.
15836         * memattr.c: Fix common/ includes.
15837         * maint.h: Fix common/ includes.
15838         * maint.c: Fix common/ includes.
15839         * main.c: Fix common/ includes.
15840         * machoread.c: Fix common/ includes.
15841         * location.c: Fix common/ includes.
15842         * linux-thread-db.c: Fix common/ includes.
15843         * linux-nat.c: Fix common/ includes.
15844         * linux-fork.c: Fix common/ includes.
15845         * inline-frame.c: Fix common/ includes.
15846         * infrun.c: Fix common/ includes.
15847         * inflow.c: Fix common/ includes.
15848         * inferior.h: Fix common/ includes.
15849         * inferior.c: Fix common/ includes.
15850         * infcmd.c: Fix common/ includes.
15851         * inf-ptrace.c: Fix common/ includes.
15852         * inf-child.c: Fix common/ includes.
15853         * ia64-linux-nat.c: Fix common/ includes.
15854         * i387-tdep.c: Fix common/ includes.
15855         * i386-tdep.c: Fix common/ includes.
15856         * i386-linux-tdep.c: Fix common/ includes.
15857         * i386-linux-nat.c: Fix common/ includes.
15858         * i386-go32-tdep.c: Fix common/ includes.
15859         * i386-fbsd-tdep.c: Fix common/ includes.
15860         * i386-fbsd-nat.c: Fix common/ includes.
15861         * guile/scm-type.c: Fix common/ includes.
15862         * guile/guile.c: Fix common/ includes.
15863         * go32-nat.c: Fix common/ includes.
15864         * gnu-nat.c: Fix common/ includes.
15865         * gdbthread.h: Fix common/ includes.
15866         * gdbarch-selftests.c: Fix common/ includes.
15867         * gdb_usleep.c: Fix common/ includes.
15868         * gdb_select.h: Fix common/ includes.
15869         * gdb_bfd.c: Fix common/ includes.
15870         * gcore.c: Fix common/ includes.
15871         * fork-child.c: Fix common/ includes.
15872         * findvar.c: Fix common/ includes.
15873         * fbsd-nat.c: Fix common/ includes.
15874         * event-top.c: Fix common/ includes.
15875         * event-loop.c: Fix common/ includes.
15876         * dwarf2read.c: Fix common/ includes.
15877         * dwarf2loc.c: Fix common/ includes.
15878         * dwarf2-frame.c: Fix common/ includes.
15879         * dwarf-index-cache.c: Fix common/ includes.
15880         * dtrace-probe.c: Fix common/ includes.
15881         * disasm-selftests.c: Fix common/ includes.
15882         * defs.h: Fix common/ includes.
15883         * csky-tdep.c: Fix common/ includes.
15884         * cp-valprint.c: Fix common/ includes.
15885         * cp-support.h: Fix common/ includes.
15886         * cp-support.c: Fix common/ includes.
15887         * corelow.c: Fix common/ includes.
15888         * completer.h: Fix common/ includes.
15889         * completer.c: Fix common/ includes.
15890         * compile/compile.c: Fix common/ includes.
15891         * compile/compile-loc2c.c: Fix common/ includes.
15892         * compile/compile-cplus-types.c: Fix common/ includes.
15893         * compile/compile-cplus-symbols.c: Fix common/ includes.
15894         * command.h: Fix common/ includes.
15895         * cli/cli-dump.c: Fix common/ includes.
15896         * cli/cli-cmds.c: Fix common/ includes.
15897         * charset.c: Fix common/ includes.
15898         * build-id.c: Fix common/ includes.
15899         * btrace.h: Fix common/ includes.
15900         * btrace.c: Fix common/ includes.
15901         * breakpoint.h: Fix common/ includes.
15902         * breakpoint.c: Fix common/ includes.
15903         * ax.h: 
15904         (enum agent_op): Fix common/ includes.
15905         * ax-general.c (struct aop_map): Fix common/ includes.
15906         * ax-gdb.c: Fix common/ includes.
15907         * auxv.c: Fix common/ includes.
15908         * auto-load.c: Fix common/ includes.
15909         * arm-tdep.c: Fix common/ includes.
15910         * arch/riscv.c: Fix common/ includes.
15911         * arch/ppc-linux-common.c: Fix common/ includes.
15912         * arch/i386.c: Fix common/ includes.
15913         * arch/arm.c: Fix common/ includes.
15914         * arch/arm-linux.c: Fix common/ includes.
15915         * arch/arm-get-next-pcs.c: Fix common/ includes.
15916         * arch/amd64.c: Fix common/ includes.
15917         * arch/aarch64.c: Fix common/ includes.
15918         * arch/aarch64-insn.c: Fix common/ includes.
15919         * arch-utils.c: Fix common/ includes.
15920         * amd64-windows-tdep.c: Fix common/ includes.
15921         * amd64-tdep.c: Fix common/ includes.
15922         * amd64-sol2-tdep.c: Fix common/ includes.
15923         * amd64-obsd-tdep.c: Fix common/ includes.
15924         * amd64-nbsd-tdep.c: Fix common/ includes.
15925         * amd64-linux-tdep.c: Fix common/ includes.
15926         * amd64-linux-nat.c: Fix common/ includes.
15927         * amd64-fbsd-tdep.c: Fix common/ includes.
15928         * amd64-fbsd-nat.c: Fix common/ includes.
15929         * amd64-dicos-tdep.c: Fix common/ includes.
15930         * amd64-darwin-tdep.c: Fix common/ includes.
15931         * agent.c: Fix common/ includes.
15932         * ada-lang.h: Fix common/ includes.
15933         * ada-lang.c: Fix common/ includes.
15934         * aarch64-tdep.c: Fix common/ includes.
15936 2019-01-25  Tom Tromey  <tom@tromey.com>
15938         * common/create-version.sh: Use common/version.h.
15940 2019-01-24  Pedro Alves  <palves@redhat.com>
15942         * infrun.c (signal_stop, signal_print, signal_program)
15943         (signal_catch, signal_pass): Now arrays instead of pointers.
15944         (update_signals_program_target, do_target_resume)
15945         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15946         * linux-nat.c (linux_nat_target::pass_signals)
15947         (linux_nat_target::create_inferior, linux_nat_target::attach):
15948         Adjust.
15949         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15950         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15951         * procfs.c (procfs_target::pass_signals): Adjust.
15952         * record-full.c (record_full_target::resume): Adjust.
15953         * remote.c (remote_target::pass_signals)
15954         (remote_target::program_signals): Adjust.
15955         * target-debug.h (target_debug_print_signals): Now takes a
15956         gdb::array_view as parameter.  Adjust.
15957         * target.h (target_ops) <pass_signals, program_signals>: Replace
15958         pointer and length parameters with gdb::array_view.
15959         (target_pass_signals, target_program_signals): Likewise.
15960         * target-delegates.c: Regenerate.
15962 2019-01-24  Pedro Alves  <palves@redhat.com>
15964         * common/forward-scope-exit.h
15965         (forward_scope_exit::forward_scope_exit): Pass arguments to
15966         m_bind_function directly, instead of creating a std::bind and
15967         copying that.
15969 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15971         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15972         for static members.
15973         (pass_in_v_vfp_candidate): Likewise.
15975 2019-01-23  Tom Tromey  <tom@tromey.com>
15976             Pedro Alves  <palves@redhat.com>
15978         * regcache.c (class regcache_invalidator): Remove.
15979         (regcache::raw_write): Use make_scope_exit.
15981 2019-01-23  Tom Tromey  <tom@tromey.com>
15983         * ui-out.h (class ui_out_emit_type): Update comment.
15985 2019-01-23  Tom Tromey  <tom@tromey.com>
15987         * infrun.c (fetch_inferior_event): Update comment.
15989 2019-01-23  Tom Tromey  <tom@tromey.com>
15990             Pedro Alves  <palves@redhat.com>
15992         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15993         parameter.
15994         (fetch_inferior_event): Use SCOPE_EXIT.
15997 2019-01-23  Tom Tromey  <tom@tromey.com>
15998             Pedro Alves  <palves@redhat.com>
16000         * infrun.c (disable_thread_events): Delete.
16001         (stop_all_threads): Use SCOPE_EXIT.
16003 2019-01-23  Tom Tromey  <tom@tromey.com>
16004             Pedro Alves  <palves@redhat.com>
16006         * symfile.c: Include forward-scope-exit.h.
16007         (clear_symtab_users_cleanup): Replace forward declaration with
16008         a FORWARD_SCOPE_EXIT.
16009         (syms_from_objfile_1): Use the forward_scope_exit and
16010         gdb::optional instead of cleanup_function.
16011         (reread_symbols): Use the forward_scope_exit instead of
16012         cleanup_function.
16013         (clear_symtab_users_cleanup): Remove function.
16015 2019-01-23  Tom Tromey  <tom@tromey.com>
16016             Pedro Alves  <palves@redhat.com>
16018         * linux-nat.c: Include scope-exit.h.
16019         (cleanup_target_stop): Remove.
16020         (linux_nat_target::static_tracepoint_markers_by_strid): Use
16021         SCOPE_EXIT.
16023 2019-01-23  Tom Tromey  <tom@tromey.com>
16024             Pedro Alves  <palves@redhat.com>
16026         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
16027         (call_function_by_hand_dummy): Use SCOPE_EXIT.
16029 2019-01-23  Tom Tromey  <tom@tromey.com>
16030             Andrew Burgess  <andrew.burgess@embecosm.com>
16031             Pedro Alves  <palves@redhat.com>
16033         * infrun.c (fetch_inferior_event): Use scope_exit.
16034         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
16035         * top.c (execute_command): Use scope_exit.
16036         * breakpoint.c (bpstat_do_actions): Use scope_exit.
16037         * utils.c (do_bpstat_clear_actions_cleanup)
16038         (make_bpstat_clear_actions_cleanup): Remove.
16040 2019-01-23  Tom Tromey  <tom@tromey.com>
16041             Pedro Alves  <palves@redhat.com>
16043         * infrun.c: Include "common/scope-exit.h"
16044         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
16045         (wait_for_inferior): Use SCOPE_EXIT.
16046         (fetch_inferior_event): Use scope_exit.
16048 2019-01-23  Tom Tromey  <tom@tromey.com>
16049             Pedro Alves  <palves@redhat.com>
16051         * breakpoint.c (create_breakpoint): Remove cleanup.
16053 2019-01-23  Tom Tromey  <tom@tromey.com>
16054             Andrew Burgess  <andrew.burgess@embecosm.com>
16055             Pedro Alves  <palves@redhat.com>
16057 2019-01-23  Pedro Alves  <palves@redhat.com>
16059         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
16061 2019-01-23  Pedro Alves  <palves@redhat.com>
16062             Andrew Burgess  <andrew.burgess@embecosm.com>
16064         * gdbthread.h: Include "common/forward-scope-exit.h".
16065         (scoped_finish_thread_state): Redefine custom class in terms of
16066         forward_scope_exit.
16068 2019-01-23  Pedro Alves  <palves@redhat.com>
16069             Andrew Burgess  <andrew.burgess@embecosm.com>
16071         * common/forward-scope-exit.h: New file.
16073 2019-01-23  Pedro Alves  <palves@redhat.com>
16074             Andrew Burgess  <andrew.burgess@embecosm.com>
16075             Tom Tromey  <tom@tromey.com>
16077         * common/scope-exit.h: New file.
16079 2019-01-23  Pedro Alves  <palves@redhat.com>
16081         * common/preprocessor.h (ESC): Rename to ...
16082         (ESC_PARENS): ... this.
16083         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
16084         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
16086 2019-01-23  Tom Tromey  <tom@tromey.com>
16088         * language.h (class scoped_switch_to_sym_language_if_auto):
16089         Initialize m_lang in both cases.
16091 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
16093         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
16094         with XCNEW.
16096 2019-01-22  Tom Tromey  <tom@tromey.com>
16098         * corelow.c: Do not include sys/file.h.
16100 2019-01-22  Tom Tromey  <tom@tromey.com>
16102         * tui/tui-wingeneral.h: Include gdb_curses.h.
16104 2019-01-22  Tom Tromey  <tom@tromey.com>
16106         * source-cache.h (class source_cache) <get_source_lines,
16107         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16109 2019-01-22  Tom Tromey  <tom@tromey.com>
16111         * remote-fileio.h (struct remote_target): Declare.
16113 2019-01-22  Tom Tromey  <tom@tromey.com>
16115         * python/py-arch.c: Do not include py-ref.h.
16116         * python/py-bpevent.c: Do not include py-ref.h.
16117         * python/py-cmd.c: Do not include py-ref.h.
16118         * python/py-continueevent.c: Do not include py-ref.h.
16119         * python/py-event.h: Do not include py-ref.h.
16120         * python/py-evtregistry.c: Do not include py-ref.h.
16121         * python/py-finishbreakpoint.c: Do not include py-ref.h.
16122         * python/py-frame.c: Do not include py-ref.h.
16123         * python/py-framefilter.c: Do not include py-ref.h.
16124         * python/py-function.c: Do not include py-ref.h.
16125         * python/py-infevents.c: Do not include py-ref.h.
16126         * python/py-linetable.c: Do not include py-ref.h.
16127         * python/py-objfile.c: Do not include py-ref.h.
16128         * python/py-param.c: Do not include py-ref.h.
16129         * python/py-prettyprint.c: Do not include py-ref.h.
16130         * python/py-progspace.c: Do not include py-ref.h.
16131         * python/py-symbol.c: Do not include py-ref.h.
16132         * python/py-symtab.c: Do not include py-ref.h.
16133         * python/py-type.c: Do not include py-ref.h.
16134         * python/py-unwind.c: Do not include py-ref.h.
16135         * python/py-utils.c: Do not include py-ref.h.
16136         * python/py-value.c: Do not include py-ref.h.
16137         * python/py-varobj.c: Do not include py-ref.h.
16138         * python/py-xmethods.c: Do not include py-ref.h.
16139         * python/python.c: Do not include py-ref.h.
16140         * varobj.c: Do not include py-ref.h.
16142 2019-01-22  Tom Tromey  <tom@tromey.com>
16144         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16145         keyword for bcache.
16147 2019-01-22  Tom Tromey  <tom@tromey.com>
16149         * compile/compile-cplus-types.c: Remove a comment by #include.
16151 2019-01-22  Tom Tromey  <tom@tromey.com>
16153         * compile/gcc-c-plugin.h: Include compile-internal.h.
16155 2019-01-22  Tom Tromey  <tom@tromey.com>
16157         * stabsread.c (EXTERN): Do not define.
16158         (symnum, next_symbol_text_func, processing_gcc_compilation)
16159         (within_function, global_sym_chain, global_stabs)
16160         (previous_stab_code, this_object_header_files)
16161         (n_this_object_header_files)
16162         (n_allocated_this_object_header_files): Define.
16163         * stabsread.h (EXTERN): Never define.  Use "extern".
16165 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16167         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16168         history_value.
16170 2019-01-21  Tom Tromey  <tom@tromey.com>
16172         * ui-out.c: Fix includes.
16173         * tui/tui-source.c: Fix includes.
16174         * target.c: Fix includes.
16175         * remote.c: Fix includes.
16176         * regcache.c: Fix includes.
16177         * python/py-block.c: Fix includes.
16178         * printcmd.c: Fix includes.
16179         * or1k-tdep.c: Fix includes.
16180         * mi/mi-main.c: Fix includes.
16181         * m32r-tdep.c: Fix includes.
16182         * csky-tdep.c: Fix includes.
16183         * compile/compile-cplus-types.c: Fix includes.
16184         * cli/cli-interp.c: Fix includes.
16186 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16188         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16189         for padding.
16191 2019-01-16  Tom Tromey  <tom@tromey.com>
16193         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16194         earlier.
16195         (struct objfile) <msymbols_range>: Move from top level.
16196         <msymbols>: New method.
16197         (class objfile_msymbols): Remove.
16198         * symtab.c (default_collect_symbol_completion_matches_break_on):
16199         Update.
16200         * symmisc.c (dump_msymbols): Update.
16201         * stabsread.c (scan_file_globals): Update.
16202         * objc-lang.c (info_selectors_command, info_classes_command)
16203         (find_methods): Update.
16204         * minsyms.c (find_solib_trampoline_target): Update.
16205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16206         * coffread.c (coff_symfile_read): Update.
16207         * ada-lang.c (ada_lookup_simple_minsym)
16208         (ada_collect_symbol_completion_matches): Update.
16210 2019-01-16  Tom Tromey  <tom@tromey.com>
16212         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16213         type.  Remove no-argument constructor.
16214         <iterator::operator++>: Simplify.
16215         <begin>: Update.
16216         <end>: Use minimal_symbol_count.
16218 2019-01-16  Tom Tromey  <tom@tromey.com>
16220         * objfiles.h (struct objfile) <psymtabs>: New method.
16221         (class objfile_psymtabs): Remove.
16222         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16223         typedef.
16224         <range>: New method.
16225         (require_partial_symbols): Change return type.
16226         * psymtab.c (require_partial_symbols)
16227         (psym_expand_symtabs_matching): Update.
16228         * mdebugread.c (parse_partial_symbols): Update.
16229         * dbxread.c (dbx_end_psymtab): Update.
16231 2019-01-15  Tom Tromey  <tom@tromey.com>
16233         * symtab.c (lookup_objfile_from_block)
16234         (lookup_symbol_in_objfile_symtabs)
16235         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16236         (find_line_symtab, info_sources_command)
16237         (default_collect_symbol_completion_matches_break_on)
16238         (make_source_files_completion_list): Update.
16239         * symmisc.c (print_objfile_statistics, dump_objfile)
16240         (maintenance_print_symbols, maintenance_info_symtabs)
16241         (maintenance_check_symtabs, maintenance_info_line_tables):
16242         Update.
16243         * source.c (select_source_symtab)
16244         (forget_cached_source_info_for_objfile): Update.
16245         * objfiles.h (class objfile_compunits): Remove.
16246         (struct objfile) <compunits_range>: New typedef.
16247         (compunits): New method.
16248         * objfiles.c (objfile_relocate1): Update.
16249         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16250         * maint.c (count_symtabs_and_blocks): Update.
16251         * linespec.c (iterate_over_all_matching_symtabs): Update.
16252         * cp-support.c (add_symbol_overload_list_qualified): Update.
16253         * coffread.c (coff_symtab_read): Update.
16254         * ada-lang.c (add_nonlocal_symbols)
16255         (ada_collect_symbol_completion_matches)
16256         (ada_add_global_exceptions): Update.
16258 2019-01-15  Tom Tromey  <tom@tromey.com>
16260         * progspace.h (program_space) <objfiles_safe_range>: New
16261         typedef.
16262         <objfiles_safe>: New method.
16263         * objfiles.h (class all_objfiles_safe): Remove.
16264         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16265         * jit.c (jit_inferior_exit_hook): Update.
16267 2019-01-17  Tom Tromey  <tom@tromey.com>
16269         * progspace.h (program_space) <objfiles_range>: New typedef.
16270         <objfiles>: New method.
16271         <objfiles_head>: Rename from objfiles.
16272         (object_files): Update.
16273         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16274         * guile/scm-pretty-print.c
16275         (ppscm_find_pretty_printer_from_objfiles): Update.
16276         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16277         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16278         Update.
16279         * python/py-progspace.c (pspy_get_objfiles): Update.
16280         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16281         Update.
16282         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16283         (objfpy_lookup_objfile_by_build_id): Update.
16284         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16285         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16286         Update.
16287         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16288         (expand_symtab_containing_pc, lookup_objfile_from_block)
16289         (lookup_static_symbol, basic_lookup_transparent_type)
16290         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16291         (find_line_symtab, info_sources_command)
16292         (default_collect_symbol_completion_matches_break_on)
16293         (make_source_files_completion_list, find_main_name): Update.
16294         * symmisc.c (print_symbol_bcache_statistics)
16295         (print_objfile_statistics, maintenance_print_symbols)
16296         (maintenance_print_msymbols, maintenance_print_objfiles)
16297         (maintenance_info_symtabs, maintenance_check_symtabs)
16298         (maintenance_expand_symtabs, maintenance_info_line_tables):
16299         Update.
16300         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16301         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16302         (map_overlay_command, unmap_overlay_command)
16303         (simple_overlay_update, expand_symtabs_matching)
16304         (map_symbol_filenames): Update.
16305         * symfile-debug.c (set_debug_symfile): Update.
16306         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16307         Update.
16308         * source.c (select_source_symtab, forget_cached_source_info):
16309         Update.
16310         * solib.c (solib_read_symbols): Update.
16311         * solib-spu.c (append_ocl_sos): Update.
16312         * psymtab.c (maintenance_print_psymbols)
16313         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16314         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16315         * printcmd.c (info_symbol_command): Update.
16316         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16317         Update.
16318         * objfiles.h (class all_objfiles): Remove.
16319         * objfiles.c (have_partial_symbols, have_full_symbols)
16320         (have_minimal_symbols, qsort_cmp, update_section_map)
16321         (shared_objfile_contains_address_p)
16322         (default_iterate_over_objfiles_in_search_order): Update.
16323         * objc-lang.c (info_selectors_command, info_classes_command)
16324         (find_methods): Update.
16325         * minsyms.c (find_solib_trampoline_target): Update.
16326         * maint.c (maintenance_info_sections)
16327         (maintenance_translate_address, count_symtabs_and_blocks):
16328         Update.
16329         * main.c (captured_main_1): Update.
16330         * linux-thread-db.c (try_thread_db_load_from_pdir)
16331         (has_libpthread): Update.
16332         * linespec.c (iterate_over_all_matching_symtabs)
16333         (search_minsyms_for_name): Update.
16334         * jit.c (jit_find_objf_with_entry_addr): Update.
16335         * hppa-tdep.c (find_unwind_entry)
16336         (hppa_lookup_stub_minimal_symbol): Update.
16337         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16338         Update.
16339         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16340         (elf_gnu_ifunc_resolve_by_got): Update.
16341         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16342         * dwarf-index-write.c (save_gdb_index_command): Update.
16343         * cp-support.c (add_symbol_overload_list_qualified): Update.
16344         * breakpoint.c (create_overlay_event_breakpoint)
16345         (create_longjmp_master_breakpoint)
16346         (create_std_terminate_master_breakpoint)
16347         (create_exception_master_breakpoint): Update.
16348         * blockframe.c (find_pc_partial_function): Update.
16349         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16350         (ada_collect_symbol_completion_matches)
16351         (ada_add_global_exceptions): Update.
16353 2019-01-17  Tom Tromey  <tom@tromey.com>
16355         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16356         declare VEC.
16357         (solib_target_parse_libraries): Change return type.
16358         (library_list_start_segment, library_list_start_section)
16359         (library_list_end_library, library_list_start_library); Update.
16360         (solib_target_free_library_list): Remove.
16361         (solib_target_parse_libraries): Remove cleanup.  Change return
16362         type.
16363         (solib_target_current_sos): Update.
16365 2019-01-17  Tom Tromey  <tromey@bapiya>
16367         * valprint.c: Replace "the the" with "the".
16368         * symtab.c: Replace "the the" with "the".
16369         * solib.c: Replace "the the" with "the".
16370         * solib-dsbt.c: Replace "the the" with "the".
16371         * linespec.c: Replace "the the" with "the".
16372         * dwarf2loc.h: Replace "the the" with "the".
16373         * amd64-windows-tdep.c: Replace "the the" with "the".
16374         * aarch64-tdep.c: Replace "the the" with "the".
16376 2019-01-16  Keith Seitz  <keiths@redhat.com>
16378         PR gdb/23773
16379         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16380         <builder>: Rename to ..
16381         <m_builder>: ... this and make private.
16382         (dwarf2_cu::get_builder): New method.  Change all users of
16383         `builder' to use this method.
16384         (dwarf2_start_symtab): Move to ...
16385         (dwarf2_cu::start_symtab): ... here.  Update all callers
16386         (setup_type_unit_groups): Move to ...
16387         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16388         callers.
16389         (dwarf2_cu::reset_builder): New method.
16390         (process_full_compunit, process_full_type_unit): Use
16391         dwarf2_cu::reset_builder.
16392         (follow_die_offset): Record the ancestor CU if it is different
16393         from the followed DIE's CU.
16394         (follow_die_sig_1): Likewise.
16396 2019-01-15  Tom Tromey  <tom@tromey.com>
16398         * remote.c (class remote_state) <buf>: Now a char_vector.
16399         <buf_size>: Remove.
16400         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16401         parameter.
16402         (remote_target::getpkt_or_notif_sane_1)
16403         (remote_target::getpkt_sane)
16404         (remote_target::getpkt_or_notif_sane): Likewise.
16405         (class remote_target) <putpkt>: New overload.
16406         (remote_target::read_frame): Change type of "buf_p".  Remove
16407         sizeof_p parameter.
16408         (packet_ok): New overload.
16409         (packet_check_result): New overload.
16410         Update all uses.
16412 2019-01-14  Tom Tromey  <tom@tromey.com>
16414         * remote-notif.c (handle_notification, remote_notif_ack)
16415         (remote_notif_parse): Make "buf" const.
16416         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16417         const.
16418         (remote_notif_parse, remote_notif_ack, handle_notification):
16419         Likewise.
16420         * remote.c (remote_notif_stop_parse): Make "buf" const.
16421         (remote_target::remote_parse_stop_reply): Make "buf" const.
16422         (remote_notif_stop_ack): Make "buf" const.
16424 2019-01-14  Tom Tromey  <tom@tromey.com>
16426         * remote.c (remote_console_output): Make parameter const.
16428 2019-01-14  Tom Tromey  <tom@tromey.com>
16430         * target-debug.h (target_debug_print_signals): Constify.
16431         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16432         * procfs.c (procfs_target::pass_signals): Update.
16433         * linux-nat.c (linux_nat_target::pass_signals): Update.
16434         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16435         * target-delegates.c: Rebuild.
16436         * remote.c (remote_target::program_signals): Update.
16437         (remote_target::pass_signals): Update.
16438         * target.c (target_pass_signals): Constify argument.
16439         (target_program_signals): Likewise.
16440         * target.h (struct target_ops) <pass_signals, program_signals>:
16441         Constify argument.
16442         (target_pass_signals, target_program_signals): Constify argument.
16444 2019-01-14  Tom Tromey  <tom@tromey.com>
16446         PR tui/28819:
16447         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16449 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16451         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16452         field.
16453         * rs6000-tdep.c: Include reggroups.h.
16454         (IS_V_ALIAS_PSEUDOREG): Define.
16455         (rs6000_register_name): Return names for the "vX" aliases.
16456         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16457         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16458         aliases.  Call default_register_reggroup_p for all other
16459         pseudo-registers.
16460         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16461         New functions.
16462         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16463         Handle "vX" aliases.
16464         (v_alias_pseudo_register_collect): New function.
16465         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16466         (rs6000_gdbarch_init): Initialize "vX" aliases as
16467         pseudo-registers.  Restore registration of
16468         rs6000_pseudo_register_reggroup_p with
16469         set_tdesc_pseudo_register_reggroup_p.
16471 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16473         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16474         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16475         set_gdbarch_num_pseudo_regs.
16477 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16479         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16480         Remove arg prefixname, add do_set and do_show.
16481         Add member functions set_list and show_list.
16482         * cli/cli-style.c (class cli_style_option): Update accordingly.
16483         (style_set_list): Move to file scope.
16484         (style_show_list): Likewise.
16485         (set_style): Call help_list.
16486         (show_style): Call cmd_show_list.
16487         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16488         Update to use the new macro.
16490 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16492         * ada-lang.c (_initialize_ada_language): Expand the help text
16493         for the "catch exception" command.
16495 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16497         * symtab.c (matching_obj_sections): Initialize obj,
16498         declare it closer to its usage.
16500 2019-01-10  Tom Tromey  <tom@tromey.com>
16502         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16503         (basic_inf_threads_range): Remove.
16504         (inf_threads_range, inf_non_exited_threads_range)
16505         (safe_inf_threads_range): Use next_adapter.
16507 2019-01-10  Keith Seitz  <keiths@redhat.com>
16509         PR gdb/23712
16510         PR symtab/23010
16511         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16512         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16514 2019-01-10  Keith Seitz  <keiths@redhat.com>
16516         PR gdb/23712
16517         PR symtab/23010
16518         * dictionary.c (pending_to_vector): Remove.
16519         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16520         Remove _1 suffix, replacing functions of the same name.  Update
16521         all callers.
16522         (dict_create_hashed, dict_create_hashed_expandable)
16523         (dict_create_linear, dict_create_linear_expandable, dict_free)
16524         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16525         Make functions static.
16527 2019-01-10  Keith Seitz  <keiths@redhat.com>
16529         PR gdb/23712
16530         PR symtab/23010
16531         * dictionary.h (struct dictionary): Replace declaration with
16532         multidictionary.
16533         (dict_create_hashed, dict_create_hashed_expandable)
16534         (dict_create_linear, dict_create_linear_expandable)
16535         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16536         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16537         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16538         taking multidictionary argument.
16539         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16540         * block.h (struct block) <dict>: Change to multidictionary
16541         and rename `multidict'.
16542         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16543         symmisc.c: Update all dictionary references to multidictionary.
16545 2019-01-10  Keith Seitz  <keiths@redhat.com>
16547         PR gdb/23712
16548         PR symtab/23010
16549         * dictionary.c: Include unordered_map.
16550         (pending_to_vector): New function.
16551         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16552         Rewrite the non-"_1" functions to take vector instead
16553         of linked list.
16554         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16555         "new" _1 versions of the same name.
16556         (multidictionary): Define.
16557         (std::hash<enum language): New definition.
16558         (collate_pending_symbols_by_language, mdict_create_hashed)
16559         (mdict_create_hashed_expandable, mdict_create_linear)
16560         (mdict_create_linear_expandable, mdict_free)
16561         (find_language_dictionary, create_new_language_dictionary)
16562         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16563         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16564         (mdict_size, mdict_empty): New functions.
16565         * dictionary.h (mdict_iterator): Define.
16567 2019-01-10  Pedro Alves  <palves@redhat.com>
16569         * breakpoint.c (read_uploaded_action)
16570         (create_tracepoint_from_upload): Adjust to use
16571         gdb::unique_xmalloc_ptr.
16572         * ctf.c (ctf_write_uploaded_tp):
16573         (SET_ARRAY_FIELD): Use emplace_back.
16574         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16575         * tracefile-tfile.c (tfile_write_uploaded_tp):
16576         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16577         gdb::unique_xmalloc_ptr.
16578         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16579         at_string, cond_string, cmd_strings>: Replace char pointers
16580         with gdb::unique_xmalloc_ptr.
16582 2019-01-10  Pedro Alves  <palves@redhat.com>
16584         * solib-target.c (library_list_start_library): Don't xstrdup name.
16586 2019-01-10  Pedro Alves  <palves@redhat.com>
16588         * mdebugread.c (parse_partial_symbols): Use
16589         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16591 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16593         * linux-fork.c (scoped_switch_fork_info)
16594         <~scoped_switch_fork_info>: Fix incorrect variable name.
16596 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16598         * linux-fork.c (scoped_switch_fork_info)
16599         <scoped_switch_fork_info>: Make explicit.
16600         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16602 2019-01-10  Tom Tromey  <tom@tromey.com>
16604         * objfiles.h (objfile::reset_psymtabs): Update.
16605         * objfiles.c (objfile::objfile): Update.
16606         * psymtab.h (psymtab_storage::obstack): Update.
16607         (psymtab_storage::m_obstack): Use gdb::optional.
16608         (class psymtab_storage): Update comment.  Remove objfile
16609         parameter.
16610         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16612 2019-01-10  Tom Tromey  <tom@tromey.com>
16614         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16615         <free_psymtabs>: Now private.
16616         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16617         (allocate_psymtab): Use new method.
16619 2019-01-10  Tom Tromey  <tom@tromey.com>
16621         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16622         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16623         * mdebugread.c (parse_partial_symbols): Use
16624         allocate_dependencies.
16625         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16626         allocate_dependencies.
16627         (process_psymtab_comp_unit_reader)
16628         (build_type_psymtab_dependencies): Likewise.
16629         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16631 2019-01-10  Tom Tromey  <tom@tromey.com>
16633         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16634         PSYMBOL_SET_LANGUAGE.
16635         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16637 2019-01-10  Tom Tromey  <tom@tromey.com>
16639         * psymtab.h (psymtab_storage::obstack): New method.
16640         <m_obstack>: Rename from obstack; now private.
16641         * psymtab.c (psymtab_storage): Update.
16642         * dwarf2read.c (create_addrmap_from_index)
16643         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16644         Update.
16646 2019-01-10  Tom Tromey  <tom@tromey.com>
16648         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16649         * objfiles.h (objfile::reset_psymtabs): New method.
16651 2019-01-10  Tom Tromey  <tom@tromey.com>
16653         * symmisc.c (print_symbol_bcache_statistics): Update.
16654         (print_objfile_statistics): Update.
16655         * symfile.c (reread_symbols): Update.
16656         * psymtab.h (class psymtab_storage): New.
16657         * psymtab.c (psymtab_storage): New constructor.
16658         (~psymtab_storage): New destructor.
16659         (require_partial_symbols): Update.
16660         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16661         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16662         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16663         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16664         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16665         (start_psymtab_common, end_psymtab_common)
16666         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16667         (allocate_psymtab): Update.
16668         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16669         Update.
16670         (dump_psymtab_addrmap, maintenance_print_psymbols)
16671         (maintenance_check_psymtabs): Update.
16672         (class objfile_psymtabs): Move to objfiles.h.
16673         * psympriv.h (discard_psymtab): Now inline.
16674         (psymtab_discarder::psymtab_discarder): Update.
16675         (psymtab_discarder::~psymtab_discarder): Update.
16676         (ALL_OBJFILE_PSYMTABS): Rewrite.
16677         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16678         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16679         Remove fields.
16680         <partial_symtabs>: New field.
16681         (class objfile_psymtabs): Move from psymtab.h.  Update.
16682         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16683         psymbol_cache.
16684         (objfile::~objfile): Don't destroy psymbol_cache.
16685         * mdebugread.c (parse_partial_symbols): Update.
16686         * dwarf2read.c (create_addrmap_from_index)
16687         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16688         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16689         (add_partial_subprogram, dwarf2_ranges_read): Update.
16690         * dwarf-index-write.c (write_address_map)
16691         (write_one_signatured_type, recursively_write_psymbols)
16692         (class debug_names, class debug_names, write_psymtabs_to_index):
16693         Update.
16695 2019-01-10  Tom Tromey  <tom@tromey.com>
16697         * symtab.h (SYMBOL_SET_NAMES): Update.
16698         (symbol_set_names): Update.
16699         (MSYMBOL_SET_NAMES): Update.
16700         * symtab.c (symbol_set_names): Change argument to be an
16701         objfile_per_bfd_storage.
16702         * psymtab.c (add_psymbol_to_bcache): Update.
16703         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16705 2019-01-10  Tom Tromey  <tom@tromey.com>
16707         * symtab.c (create_demangled_names_hash): Change argument to be an
16708         objfile_per_bfd_storage.
16709         (symbol_set_names): Update.
16711 2019-01-10  Tom Tromey  <tom@tromey.com>
16713         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16714         init_psymbol_list.
16715         * psymtab.c (init_psymbol_list): Do nothing if already called.
16716         * psympriv.h (init_psymbol_list): Add comment.
16717         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16718         init_psymbol_list.
16719         * dbxread.c (dbx_symfile_read): Unconditionally call
16720         init_psymbol_list.
16722 2019-01-10  Tom Tromey  <tom@tromey.com>
16724         * xcoffread.c (scan_xcoff_symtab): Update.
16725         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16726         "where".
16727         * mdebugread.c (parse_partial_symbols)
16728         (handle_psymbol_enumerators): Update.
16729         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16730         * dbxread.c (read_dbx_symtab): Update.
16731         * psympriv.h (psymbol_placement): New enum.
16732         (add_psymbol_to_list): Update.
16734 2019-01-10  Tom Tromey  <tom@tromey.com>
16736         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16737         static_psymbols parameters.
16738         (scan_xcoff_symtab): Update.
16739         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16740         static_psymbols parameters.
16741         * psympriv.h (start_psymtab_common): Update.
16742         * mdebugread.c (parse_partial_symbols): Update.
16743         * dwarf2read.c (create_partial_symtab): Update.
16744         * dbxread.c (read_dbx_symtab): Update.
16745         (start_psymtab): Remove global_psymbols and static_psymbols
16746         parameters.
16748 2019-01-10  Tom Tromey  <tom@tromey.com>
16750         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16751         * psymtab.c (allocate_psymtab): Add comment.
16752         * psympriv.h (allocate_psymtab): Add comment.
16753         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16754         initializations.
16755         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16757 2019-01-10  Tom Tromey  <tom@tromey.com>
16759         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16760         Don't declare.
16761         * mipsread.c: Include mdebugread.h.
16762         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16763         Declare.
16764         * elfread.c: Include mdebugread.h.
16766 2019-01-09  Tom Tromey  <tom@tromey.com>
16768         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16769         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16770         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16771         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16772         (psym_lookup_symbol, psym_find_last_source_symtab)
16773         (psym_forget_cached_source_info, psym_print_stats)
16774         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16775         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16776         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16777         (psym_find_compunit_symtab_by_address)
16778         (maintenance_print_psymbols, maintenance_info_psymtabs)
16779         (maintenance_check_psymtabs): Use ranged for.
16780         * psymtab.h (class objfile_psymtabs): New.
16781         (require_partial_symbols): Return objfile_psymtabs.
16782         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16784 2019-01-09  Tom Tromey  <tom@tromey.com>
16786         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16787         (find_pc_mapped_section, list_overlays_command)
16788         (map_overlay_command, unmap_overlay_command)
16789         (simple_overlay_update): Use all_objfiles.
16790         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16791         * printcmd.c (info_symbol_command): Use all_objfiles.
16792         * objfiles.h (ALL_OBJSECTIONS): Remove.
16793         * maint.c (maintenance_translate_address): Use all_objfiles.
16794         * gcore.c (gcore_create_callback): Use all_objfiles.
16795         (objfile_find_memory_regions): Likewise.
16797 2019-01-09  Tom Tromey  <tom@tromey.com>
16799         * symtab.c (find_line_symtab, info_sources_command)
16800         (make_source_files_completion_list): Use objfile_compunits.
16801         * source.c (select_source_symtab): Use objfile_compunits.
16802         * objfiles.h (struct objfile): Update comment.
16803         (ALL_OBJFILES): Remove.
16804         (ALL_FILETABS): Remove.
16805         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16806         objfile_compunits.
16808 2019-01-09  Tom Tromey  <tom@tromey.com>
16810         * symmisc.c (print_objfile_statistics, dump_objfile)
16811         (maintenance_print_symbols): Use compunit_filetabs.
16812         * source.c (forget_cached_source_info_for_objfile): Use
16813         compunit_filetabs.
16814         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16815         (ALL_FILETABS): Use compunit_filetabs.
16816         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16817         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16819 2019-01-09  Tom Tromey  <tom@tromey.com>
16821         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16822         (compunit_filetabs): New.
16823         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16824         compunit_filetabs.
16825         (info_sources_command, make_source_files_completion_list): Remove
16826         declaration.
16827         * symmisc.c (print_objfile_statistics, dump_objfile)
16828         (maintenance_print_symbols): Remove declaration.
16829         (maintenance_info_symtabs): Use compunit_filetabs.
16830         (maintenance_info_line_tables): Likewise.
16831         * source.c (select_source_symtab): Change local variable name.
16832         (forget_cached_source_info_for_objfile): Remove declaration.
16833         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16834         * objfiles.c (objfile_relocate1): Remove declaration.
16835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16836         declaration.
16837         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16838         * coffread.c (coff_symtab_read): Remove declaration.
16839         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16840         compunit_filetabs.
16842 2019-01-09  Tom Tromey  <tom@tromey.com>
16844         * symtab.c (lookup_objfile_from_block)
16845         (find_pc_sect_compunit_symtab, search_symbols)
16846         (default_collect_symbol_completion_matches_break_on): Use
16847         objfile_compunits.
16848         * objfiles.h (ALL_COMPUNITS): Remove.
16849         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16850         * cp-support.c (add_symbol_overload_list_qualified): Use
16851         objfile_compunits.
16852         * ada-lang.c (ada_collect_symbol_completion_matches)
16853         (ada_add_global_exceptions): Use objfile_compunits.
16855 2019-01-09  Tom Tromey  <tom@tromey.com>
16857         * source.c (select_source_symtab)
16858         (forget_cached_source_info_for_objfile): Remove declaration.
16859         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16860         declaration.
16861         * maint.c (count_symtabs_and_blocks): Remove declaration.
16862         * cp-support.c (add_symbol_overload_list_qualified): Remove
16863         declaration.
16864         * coffread.c (coff_symtab_read): Remove declaration.
16865         * symtab.c (lookup_symbol_in_objfile_symtabs)
16866         (basic_lookup_transparent_type_1): Use objfile_compunits.
16867         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16868         (info_sources_command, search_symbols)
16869         (default_collect_symbol_completion_matches_break_on)
16870         (make_source_files_completion_list): Remove declaration.
16871         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16872         (ada_collect_symbol_completion_matches)
16873         (ada_add_global_exceptions): Remove declaration.
16874         * linespec.c (iterate_over_all_matching_symtabs): Use
16875         objfile_compunits.
16876         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16877         (class objfile_compunits): New.
16878         (ALL_COMPUNITS): Use objfile_compunits.
16879         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16880         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16881         objfile_compunits.
16882         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16884 2019-01-09  Tom Tromey  <tom@tromey.com>
16886         * symtab.c (search_symbols)
16887         (default_collect_symbol_completion_matches_break_on): Use
16888         objfile_msymbols.
16889         * ada-lang.c (ada_lookup_simple_minsym)
16890         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16891         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16892         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16893         objfile_msymbols.
16894         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16895         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16896         * objc-lang.c (find_methods): Use objfile_msymbols.
16897         (info_selectors_command, info_classes_command): Likewise.
16898         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16899         * objfiles.h (class objfile_msymbols): New.
16900         (ALL_OBJFILE_MSYMBOLS): Remove.
16901         (ALL_MSYMBOLS): Remove.
16903 2019-01-09  Tom Tromey  <tom@tromey.com>
16905         * common/next-iterator.h (next_adapter): Add Iterator template
16906         parameter.
16907         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16908         (class all_objfiles_safe): New.
16909         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16910         * objfiles.c (put_objfile_before): Update comment.
16911         (add_separate_debug_objfile): Likewise.
16912         (free_all_objfiles): Use all_objfiles_safe.
16913         (objfile_purge_solibs): Likewise.
16915 2019-01-09  Tom Tromey  <tom@tromey.com>
16917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16918         (expand_symtab_containing_pc, lookup_static_symbol)
16919         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16920         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16921         all_objfiles.
16922         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16923         * breakpoint.c (create_overlay_event_breakpoint)
16924         (create_longjmp_master_breakpoint)
16925         (create_std_terminate_master_breakpoint)
16926         (create_exception_master_breakpoint): Use all_objfiles.
16927         * linux-thread-db.c (try_thread_db_load_from_pdir)
16928         (has_libpthread): Use all_objfiles.
16929         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16930         * linespec.c (iterate_over_all_matching_symtabs)
16931         (search_minsyms_for_name): Use all_objfiles.
16932         * maint.c (maintenance_info_sections): Use all_objfiles.
16933         * main.c (captured_main_1): Use all_objfiles.
16934         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16935         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16936         * guile/scm-pretty-print.c
16937         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16938         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16939         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16940         (maintenance_print_msymbols): Use all_objfiles.
16941         * source.c (select_source_symtab): Use all_objfiles.
16942         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16943         * symfile.c (remove_symbol_file_command)
16944         (expand_symtabs_matching, map_symbol_filenames): Use
16945         all_objfiles.
16946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16947         all_objfiles.
16948         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16949         * objc-lang.c (find_methods): Use all_objfiles.
16950         * objfiles.c (have_partial_symbols, have_full_symbols)
16951         (have_minimal_symbols, qsort_cmp)
16952         (default_iterate_over_objfiles_in_search_order): Use
16953         all_objfiles.
16954         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16955         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16956         (maintenance_check_psymtabs): Use all_objfiles.
16957         (ALL_PSYMTABS): Remove.
16958         * compile/compile-object-run.c (do_module_cleanup): Use
16959         all_objfiles.
16960         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16961         * cp-support.c (add_symbol_overload_list_qualified): Use
16962         all_objfiles.
16963         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16964         Use all_objfiles.
16965         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16966         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16967         all_objfiles.
16968         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16969         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16970         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16971         Uses all_objfiles.
16972         * solib.c (solib_read_symbols): Use all_objfiles
16974 2019-01-09  Tom Tromey  <tom@tromey.com>
16976         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16977         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16978         all_objfiles.
16979         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16980         * symmisc.c (print_symbol_bcache_statistics)
16981         (print_objfile_statistics, maintenance_print_objfiles)
16982         (maintenance_info_symtabs, maintenance_check_symtabs)
16983         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16984         all_objfiles.
16985         * source.c (forget_cached_source_info): Use all_objfiles.
16986         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16987         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16988         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16989         * objfiles.c (update_section_map): Use all_objfiles.
16990         (shared_objfile_contains_address_p): Likewise.
16991         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16992         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16994 2019-01-09  Tom Tromey  <tom@tromey.com>
16996         * common/next-iterator.h: New file.
16997         * objfiles.h (class all_objfiles): New.
16998         (struct objfile_iterator): New.
17000 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17002         * NEWS: Move the description of the changed "frame", "select-frame",
17003          and "info frame" commands to the Changed commands section.
17005 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
17007         * gdbtypes.c (check_stub_method_group): Remove handling of old
17008         mangling schemes.
17009         * linespec.c (find_methods): Likewise.
17010         * stabsread.c (read_member_functions): Likewise.
17011         * valops.c (search_struct_method): Likewise.
17012         (value_struct_elt_for_reference): Likewise.
17013         * NEWS: Mention this change.
17015 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
17017         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
17018         print_source_lines.
17019         * source.c (print_source_lines_base): Update line number check.
17020         (print_source_lines): New function.
17021         (source_lines_range::source_lines_range): New function.
17022         * source.h (class source_lines_range): New class.
17023         (print_source_lines): New declaration.
17025 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17027         * linespec.c (linespec_state_destructor): Free self->canonical_names.
17029 2019-01-08  Tom Tromey  <tom@tromey.com>
17030             Simon Marchi  <simon.marchi@ericsson.com>
17032         PR gdb/24060
17033         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
17034         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
17035         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
17036         * f-exp.y (DOLLAR_VARIABLE): Likewise.
17037         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
17038         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
17040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17042         * source.c (select_source_symtab): Move header comment to
17043         declaration in source.h.
17044         (forget_cached_source_info_for_objfile): Likewise.
17045         (forget_cached_source_info): Likewise.
17046         (identify_source_line): Likewise.
17047         * source.h (identify_source_line): Move declaration from symtab.h
17048         and add comment from source.c
17049         (print_source_lines): Likewise.
17050         (forget_cached_source_info_for_objfile): Likewise.
17051         (forget_cached_source_info): Likewise.
17052         (select_source_symtab): Likewise.
17053         (enum print_source_lines_flag): Move definition from symtab.h.
17054         * symtab.h (identify_source_line): Move declaration to source.h.
17055         (print_source_lines): Likewise.
17056         (forget_cached_source_info_for_objfile): Likewise.
17057         (forget_cached_source_info): Likewise.
17058         (select_source_symtab): Likewise.
17059         (enum print_source_lines_flag): Move definition to source.h.
17060         * tui/tui-hooks.c: Add 'source.h' include.
17062 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17064         * source.c (print_source_lines_base): Handle requests to print
17065         reverse line number sequences, and guard against empty lines
17066         string.
17068 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
17070         * source.c (print_source_lines_base): Fix skip of '\r' if next
17071         character is '\n'.
17073 2019-01-06  Tom Tromey  <tom@tromey.com>
17075         * c-exp.y (struct c_parse_state) <macro_original_text,
17076         expansion_obstack>: New member.
17077         (macro_original_text, expansion_obstack): Remove globals.
17078         (scan_macro_expansion, scanning_macro_expansion)
17079         (finished_macro_expansion): Update.
17080         (scan_macro_cleanup): Remove.
17081         (yylex, c_parse): Update.
17083 2019-01-06  Tom Tromey  <tom@tromey.com>
17085         * c-exp.y (struct c_parse_state) <strings>: New member.
17086         (operator_stoken): Update.
17088 2019-01-06  Tom Tromey  <tom@tromey.com>
17090         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
17091         (union type_stack_elt) <typelist_val>: Now a pointer to
17092         std::vector.
17093         (type_stack_cleanup): Don't declare.
17094         (push_typelist): Update.
17095         * parse.c (pop_typelist): Return a std::vector.
17096         (push_typelist): Take a std::vector.
17097         (follow_types): Update.  Do not free args.
17098         (type_stack_cleanup): Remove.
17099         * c-exp.y (struct c_parse_state): New.
17100         (cpstate): New global.
17101         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17102         (nonempty_typelist): Update.
17103         (func_mod): Create a new vector.
17104         (c_parse): Create a c_parse_state.
17105         (check_parameter_typelist): Do not delete params.
17106         (function_method): Update.  Do not delete type_list.
17108 2019-01-06  Tom Tromey  <tom@tromey.com>
17110         PR gdb/28155:
17111         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17112         check_typedef.
17113         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17114         (print_return_value): Likewise.
17116 2019-01-05  Tom Tromey  <tom@tromey.com>
17118         * contrib/cleanup_check.py: Remove.
17119         * contrib/gcc-with-excheck: Remove.
17120         * contrib/exsummary.py: Remove.
17121         * contrib/excheck.py: Remove.
17123 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
17125         * thread.c (delete_thread_1): Add gdb_assert that THR is not
17126         NULL. Initialize tpprev to NULL instead of assigning it
17127         to NULL on the next statement.
17128         * windows-nat.c (windows_delete_thread): Remove check for
17129         main_thread_id before printing thread exit notifications.
17130         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17131         Remove thread ID check against main_thread_id.
17132         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17133         windows_delete_thread.
17134         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17136 2019-01-04  Tom Tromey  <tom@tromey.com>
17138         * compile/compile.c (_initialize_compile): Use upper case for
17139         metasyntactic variables.
17140         * symmisc.c (_initialize_symmisc): Use upper case for
17141         metasyntactic variables.
17142         * psymtab.c (_initialize_psymtab): Use upper case for
17143         metasyntactic variables.
17144         * demangle.c (demangle_command): Use upper case for metasyntactic
17145         variables.
17146         (_initialize_demangler): Likewise.
17147         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17148         variables.
17150 2019-01-03  Tom Tromey  <tom@tromey.com>
17152         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17154 2019-01-03  Tom Tromey  <tom@tromey.com>
17156         * python/py-symtab.c (salpy_str): Update.
17157         (struct salpy_sal_object) <symtab>: Now a PyObject.
17158         (salpy_dealloc): Update.
17159         (del_objfile_sal): Use gdbpy_ref.
17161 2019-01-03  Tom Tromey  <tom@tromey.com>
17163         * python/py-type.c (convert_field): Use new_reference.  Return
17164         gdbpy_ref.
17165         (make_fielditem): Return gdbpy_ref.
17166         (typy_fields): Update.
17167         (typy_getitem): Update.
17168         (field_name): Return gdbpy_ref.  Use new_reference.
17169         (typy_iterator_iternext): Update.
17171 2019-01-03  Tom Tromey  <tom@tromey.com>
17173         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17175 2019-01-03  Tom Tromey  <tom@tromey.com>
17177         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17178         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17179         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17180         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17181         (pspy_set_type_printers): Likewise.
17182         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17183         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17184         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17185         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17186         (objfpy_set_type_printers): Likewise.
17188 2019-01-03  Tom Tromey  <tom@tromey.com>
17190         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17191         (gdbpy_print_stack): Use gdbpy_err_fetch.
17192         * python/python-internal.h (class gdbpy_err_fetch): New class.
17193         (class gdbpy_enter) <m_error_type, m_error_value,
17194         m_error_traceback>: Remove.
17195         <m_error>: New member.
17196         (gdbpy_exception_to_string): Don't declare.
17197         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17198         * python/py-value.c (convert_value_from_python): Use
17199         gdbpy_err_fetch.
17200         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17201         gdbpy_exception_to_string.
17202         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17203         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17204         gdbpy_err_fetch.
17206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17208         * linux-nat.c (delete_lwp_cleanup): Delete.
17209         (struct lwp_deleter): New struct.
17210         (lwp_info_up): New typedef.
17211         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17212         lwp_info_up.
17214 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17216         * linux-fork.c (class scoped_switch_fork_info): New class.
17217         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17219 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17221         * valops.c (find_overload_match): Remove use of null_cleanup, and
17222         calls to do_cleanups.
17224 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17226         * compile/compile-cplus-types.c
17227         (compile_cplus_instance::decl_name): Handle changes to
17228         cp_func_name.
17229         * cp-support.c (cp_func_name): Update header comment, update
17230         return type.
17231         * cp-support.h (cp_func_name): Update return type in declaration.
17232         * valops.c (find_overload_match): Move temp_func local to top
17233         level of function and change its type.  Use temp_func to hold and
17234         delete temporary string obtained from cp_func_name.
17236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17238         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17239         gdb::char_vector, remove cleanup, and update uses of `msg`.
17241 2019-01-03  Jim Wilson  <jimw@sifive.com>
17243         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17245 2019-01-02  Tom Tromey  <tom@tromey.com>
17247         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17248         (tdesc_parse_xml): Remove cleanups.
17249         * target-descriptions.h (make_cleanup_free_target_description):
17250         Don't declare.
17251         (target_desc_deleter): New struct.
17252         (target_desc_up): New typedef.
17253         * target-descriptions.c (target_desc_deleter::operator()): Rename
17254         from free_target_description.
17255         (make_cleanup_free_target_description): Remove.
17257 2019-01-02  Tom Tromey  <tom@tromey.com>
17259         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17260         constructor, destructor.
17261         (linespec_parser): Remove typedef.
17262         (~linespec_parser): Rename from linespec_parser_delete.
17263         (linespec_lex_to_end, linespec_complete_label)
17264         (linespec_complete): Update.
17265         (decode_line_full): Remove cleanups.
17266         (decode_line_1): Update.
17268 2019-01-02  Tom Tromey  <tom@tromey.com>
17270         * python/python-internal.h (inferior_to_inferior_object): Change
17271         return type.
17272         * python/py-exitedevent.c (create_exited_event_object): Update.
17273         * python/py-inferior.c (inferior_to_inferior_object): Return
17274         gdbpy_ref.
17275         (python_new_inferior, python_inferior_deleted)
17276         (thread_to_thread_object, delete_thread_object)
17277         (build_inferior_list, gdbpy_selected_inferior): Update.
17278         * python/py-infthread.c (create_thread_object): Update.  Also fail
17279         if inferior_to_inferior_object fails.
17281 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17283         * inferior.h (class inferior) <displaced_step_state>: New field.
17284         * infrun.h (struct displaced_step_state): Move here from
17285         infrun.c.  Initialize fields, add constructor.
17286         <inf>: Remove field.
17287         <reset>: New method.
17288         * infrun.c (struct displaced_step_inferior_state): Move to
17289         infrun.h.
17290         (displaced_step_inferior_states): Remove.
17291         (get_displaced_stepping_state): Adust.
17292         (displaced_step_in_progress_any_inferior): Adjust.
17293         (displaced_step_in_progress_thread): Adjust.
17294         (displaced_step_in_progress): Adjust.
17295         (add_displaced_stepping_state): Remove.
17296         (get_displaced_step_closure_by_addr): Adjust.
17297         (remove_displaced_stepping_state): Remove.
17298         (infrun_inferior_exit): Call displaced_step_state.reset.
17299         (use_displaced_stepping): Don't check for NULL.
17300         (displaced_step_prepare_throw): Call
17301         get_displaced_stepping_state.
17302         (displaced_step_fixup): Don't check for NULL.
17303         (prepare_for_detach): Don't check for NULL.
17305 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17307         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17308          in case of call that did not complete.
17310 2019-01-02  Andrey Utkin  <autkin@undo.io>
17312         * symfile.c (find_separate_debug_file): Fix search of debug files for
17313         remote debuggee.
17315 2019-01-02  Tom Tromey  <tom@tromey.com>
17317         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17318         indentation.
17319         * python/py-frame.c (frapy_older): Remove cast.
17320         (frapy_newer): Likewise.
17321         * python/py-breakpoint.c (local_setattro): Remove cast.
17322         * python/py-arch.c (archpy_name): Remove local variable.
17323         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17325 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17327         * unittests/basic_string_view/element_access/char/empty.cc:
17328         Fix year range in copyright header.
17330 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17332         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17333         Delete.
17334         <operator==>: Update with for removed field.
17335         <hash>: Likewise.
17336         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17337         <isa_features>: ...this.
17338         <abi_features>: New field.
17339         (riscv_isa_flen): Update comment.
17340         (riscv_abi_xlen): New declaration.
17341         (riscv_abi_flen): New declaration.
17342         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17343         isa_features.
17344         (riscv_abi_xlen): New function.
17345         (riscv_isa_flen): Update to get answer from isa_features.
17346         (riscv_abi_flen): New function.
17347         (riscv_has_fp_abi): Update to get answer from abi_features.
17348         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17349         xlen and flen.
17350         (riscv_call_info) <xlen, flen>: Update comment.
17351         (riscv_call_arg_struct): Remove invalid assertions
17352         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17353         is removed.
17354         (riscv_gdbarch_init): Gather isa features and abi features
17355         separately, ensure both match on the gdbarch when reusing an old
17356         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17357         a target with 64-bit float hardware.
17359 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17361         * source.c (search_command_helper): Stop reverse search
17362         when line 1 has been searched.
17364 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17366         * record-full.c (record_full_base_target::close): Rewrite
17367         record_full_core_buf_list free logic.
17369 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17371         * break-catch-syscall.c (print_one_catch_syscall): xfree
17372         the last text.
17374 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17376         * top.c (print_gdb_version): Update Copyright year in version
17377         message.
17379 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17381         Update copyright year range in all GDB files.
17383 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17385         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17387 For older changes see ChangeLog-2018.
17389 Local Variables:
17390 mode: change-log
17391 left-margin: 8
17392 fill-column: 74
17393 version-control: never
17394 coding: utf-8
17395 End: