1 ============================================================================
4 * This file attempts to describe the rules to use when hacking
7 ============================================================================
10 * The correct response to most actual bugs is to write a new test case
11 which demonstrates the bug. Then fix the bug, re-run the test suite,
12 and check everything in.
14 * If you incorporate a change from somebody on the net:
15 - First, if it is a large change, you must make sure they have
16 signed the appropriate paperwork.
17 - Second, be sure to add their name and email address to THANKS.
19 * If a change fixes a test, mention the test in the commit message.
20 If a change fixes a bug registered in the Automake debbugs tracker,
21 mention the bug number in the commit message.
23 * If somebody reports a new bug, mention his name in the commit message
24 that fixes or exposes the bug, and put him into THANKS.
26 * When documenting a non-trivial idiom or example in the manual, be
27 sure to add a test case for it, and to reference such test case from
28 a proper Texinfo comment.
30 * Some files in the automake package are not owned by automake; these
31 files are listed in the $(FETCHFILES) variable in Makefile.am. They
32 should never be edited here. Almost all of them can be updated from
33 respective upstreams with "make fetch" (this should be done especially
34 before releases). The only exception is the 'lib/COPYING' (from FSF),
35 which should be updated by hand whenever the GPL gets updated (which
36 shouldn't happen that often anyway :-)
38 * Changes other than *trivial* bug fixes must be mentioned in NEWS.
40 * Changes which are potentially controversial, require a non-trivial
41 plan, or must be implemented gradually with a roadmap spanning several
42 releases (either minor or major) should be discussed on the list,
43 and have a proper entry in the PLANS directory. This entry should be
44 always committed in the "maint" branch, even if the change it deals
45 with is only for the master branch, or a topic branch. Usually, in
46 addition to this, it is useful to open a "wishlist" report on the
47 Automake debbugs tracker, to keep the idea more visible, and have the
48 discussions surrounding it easily archived in a central place.
50 ============================================================================
53 * We've adopted the convention that internal AC_SUBSTs and make variables
54 should be named with a leading 'am__', and internally generated targets
55 should be named with a leading 'am--'. This convention, although in
56 place from at least February 2001, isn't yet universally used.
57 But all new code should use it.
59 We used to use '_am_' as the prefix for an internal AC_SUBSTs.
60 However, it turns out that NEWS-OS 4.2R complains if a Makefile
61 variable begins with the underscore character. Yay for them.
62 I changed the target naming convention just to be safe.
64 ============================================================================
67 * Always use $(...) and not ${...}
69 * Prefer ':' over 'true', mostly for consistency with existing code.
71 * Use '##' comments liberally. Comment anything even remotely unusual.
73 * Never use basename or dirname. Instead, use sed.
75 * Do not use 'cd' within back-quotes, use '$(am__cd)' instead.
76 Otherwise the directory name may be printed, depending on CDPATH.
77 More generally, do not ever use plain 'cd' together with a relative
78 directory that does not start with a dot, or you might end up in one
81 * For install and uninstall rules, if a loop is required, it should be
82 silent. Then the body of the loop itself should print each "important"
83 command it runs. The printed commands should be preceded by a single
86 * Ensure install rules do not create any installation directory where
87 nothing is to be actually installed. See automake bug#11030.
89 ============================================================================
90 = Editing automake.in and aclocal.in
92 * Indent using GNU style. For historical reasons, the perl code
93 contains portions indented using Larry Wall's style (perl-mode's
94 default), and other portions using the GNU style (cperl-mode's
95 default). Write new code using GNU style.
97 * Don't use & for function calls, unless really required.
98 The use of & prevents prototypes from being checked.
100 ============================================================================
101 = Automake versioning and compatibility scheme
103 * There are three kinds of automake releases:
105 - new major releases (e.g., 2.0, 5.0)
106 - new minor releases (e.g., 1.14, 2.1)
107 - micro a.k.a. "bug-fixing" releases (e.g., 1.13.2, 2.0.1, 3.5.17).
109 A new major release should have the major version number bumped, and
110 the minor and micro version numbers reset to zero. A new minor release
111 should have the major version number unchanged, the minor version number
112 bumped, and the micro version number reset to zero. Finally, a new
113 micro version should have the major and minor version numbers unchanged,
114 and the micro version number bumped by one.
116 For example, the first minor version after 1.13.2 will be 1.14; the
117 first bug-fixing version after 1.14 that will be 1.14.1; the first
118 new major version after all such releases will be 2.0; the first
119 bug-fixing version after 2.0 will be 2.0.1; and a further bug-fixing
120 version after 2.0.1 will be 2.0.2.
122 * Micro releases should be just bug-fixing releases; no new features
123 should be added, and ideally, only trivial bugs, recent regressions,
124 or documentation issues should be addressed by them. On the other
125 hand, it's OK to include testsuite work and even testsuite refactoring
126 in a micro version, since a regression there is not going to annoy or
127 inconvenience Automake users, but only the Automake developers.
129 * Minor releases can introduce new "safe" features, do non-trivial but
130 mostly safe code clean-ups, and even add new runtime warnings (rigorously
131 non-fatal). But they shouldn't include any backward incompatible change,
132 nor contain any potentially destabilizing refactoring or sweeping change,
133 nor introduce new features whose implementation might be liable to cause
134 bugs or regressions in existing code. However, it might be acceptable to
135 introduce very limited and localized backward-incompatibilities, *only*
136 if that is necessary to fix non-trivial bugs, address serious performance
137 issues, or greatly enhance usability. But please, do this sparsely and
140 * Major releases can introduce backward-incompatibilities (albeit such
141 incompatibilities should be announced well in advance, and a smooth
142 transition plan prepared for them), and try more risking and daring
143 refactorings and code cleanups.
145 * For more information, refer to the extensive discussion associated
146 with automake bug#13578.
148 ============================================================================
151 * To regenerate dependent files created by aclocal and automake,
152 use the 'bootstrap' script. It uses the code from the source
153 tree, so the resulting files (aclocal.m4 and Makefile.in) should
154 be the same as you would get if you install this version of
155 automake and use it to generate those files. Be sure to have the
156 latest stable version of Autoconf installed and available early
159 * The Automake git tree currently carries three basic branches: 'master',
162 * The 'master' branch is where the development of the next release
163 takes place. It should be kept in a stable, almost-releasable state,
164 to simplify testing and deploying of new minor version. Note that
165 this is not a hard rule, and such "stability" is not expected to be
166 absolute (emergency releases are cut from the 'maint' branch anyway).
168 * When planning a release a dedicated branch should be created and after
169 the release is done, the release branch is to be merged both into the
170 'master' branch and the 'maint' branch.
172 * Besides merges from release branches, the 'maint' branch can contain
173 fixes for regressions, trivial bugs, or documentation issues, that
174 will be part of an emergency regression-fixing or security releases.
175 As a consequence it should always be kept in a releasable state and no
176 "active" development should be done whatsoever.
178 * The 'next' branch is reserved for the development of the next major
179 release. Experimenting a little is OK here, but don't let the branch
180 grow too unstable; if you need to do exploratory programming or
181 over-arching change, you should use a dedicated topic branch, and
182 only merge that back once it is reasonably stable.
184 * The 'master' branch should be kept regularly merged into the 'next'
185 branch. It is advisable to merge only after a set of related
186 commits have been applied, to avoid introducing too much noise in
189 * There may be a number of longer-lived feature branches for new
190 developments. They should be based off of a common ancestor of all
191 active branches to which the feature should or might be merged later.
193 * When merging, prefer 'git merge --log' over plain 'git merge', so that
194 a later 'git log' gives an indication of which actual patches were
195 merged even when they don't appear early in the list.
197 * The 'master', 'maint' and 'next' branches should not be rewound,
198 i.e., should always fast-forward, except maybe for privacy issues.
199 For feature branches, the announcement for the branch should
200 document the rewinding policy.
201 If a topic branch is expected to be rewound, it is good practice to put
202 it in the 'experimental/*' namespace; for example, a rewindable branch
203 dealing with Vala support could be named like "experimental/vala-work".
205 ============================================================================
206 = Writing a good commit message
208 * Here is the general format that Automake's commit messages are expected
209 to follow. See the further points below for clarifications and minor
212 topic: brief description (this is the "summary line")
214 <reference to relevant bugs, if any>
216 Here goes a more detailed explanation of why the commit is needed,
217 and a general overview of what it does, and how. This section
218 should almost always be provided, possibly only with the expection
219 of obvious fixes or very trivial changes.
221 And if the detailed explanation is quite long or detailed, you can
222 want to break it in more paragraphs.
224 Then you can add references to relevant mailing list discussions
225 (if any), with proper links. But don't take this as an excuse for
226 writing incomplete commit messages! The "distilled" conclusions
227 reached in such discussions should have been placed in the
230 Finally, here you can thank people that motivated or helped the
231 change. So, thanks to John Doe for bringing up the issue, and to
232 J. Random Hacker for providing suggestions and testing the patch.
234 <detailed list of touched files>
236 * The <detailed list of touched files> should usually be provided (but
237 for short or trivial changes), and should follow the GNU guidelines
238 for ChangeLog entries (described explicitly in the GNU Coding
239 Standards); it might be something of this sort:
241 * some/file (func1): Improved frobnication.
242 (func2): Adjusted accordingly.
243 * another/file (foo, bar): Likewise.
244 * tests/foo.tap: New test.
245 * tests/Makefile.am (TESTS): Add it.
247 * If your commit fixes an automake bug registered in the tracker (say
248 numbered 1234), you should put the following line after the summary
251 This change fixes automake bug#1234.
253 * If your commit is just related to the given bug report, but does not
254 fix it, you might want to add a line like this instead:
256 This change is related to automake bug#1234.
258 * When referring to older commits, use 'git describe' output as pointer.
259 But also try to identify the given commit by date and/or summary line
260 if possible. Examples:
262 Since yesterday's commit, v1.11-2019-g4d2bf42, ...
264 ... removed in commit 'v1.11-1674-g02e9072' of 01-01-2012,
265 "dist: ditch support for lzma"...
267 * If the commit is a tiny change that is exempt from copyright paperwork, the
268 commit message should contain a separate line after the detailed list of
269 touched files like the following:
271 Copyright-paperwork-exempt: yes
273 ============================================================================
276 * Use "make check" and "make maintainer-check" liberally.
278 * Export the 'keep_testdirs' environment variable to "yes" to keep
279 test directories for successful tests also.
281 * Use perl coverage information to ensure your new code is thoroughly
282 tested by your new tests.
284 * See file 't/README' for more information.
286 ============================================================================
289 * The steps outlined here are meant to be followed for alpha and stable
290 releases as well. Where differences are expected, they will be
291 explicitly described.
293 * Fetch new versions of the files that are maintained by the FSF by
294 running "make fetch". In case any file in the automake repository
295 has been updated, commit and re-run the testsuite.
297 * Ensure that the copyright notices of the distributed files is up to
298 date. The maintainer-only target "update-copyright" can help with
301 * Check NEWS; in particular, ensure that all the relevant differences
302 with the last release are actually reported.
304 * Update the version number in configure.ac.
305 (The idea is that every other alpha number will be a net release.
306 The repository will always have its own "odd" number so we can easily
307 distinguish net and repo versions.)
309 * Run these commands, in this order:
312 make check keep_testdirs=yes
313 make maintainer-check
315 make check-no-trailing-backslash-in-recipes
318 It is also advised to run "git clean -fdx" before invoking the
319 bootstrap, to ensure a really clean rebuild. However, it must
320 be done carefully, because that command will remove *all* the
321 files that are not tracked by git!
323 * Run "make git-tag-release".
324 This will run the maintainer checks, verify that the local git
325 repository and working tree are clean and up-to-date, and create
326 a proper signed git tag for the release (based on the contents
329 * Run "make git-upload-release".
330 This will first verify that you are releasing from a tagged version
331 and that the local git repository and working tree are clean and
332 up-to-date, and will then run "make dist" to create the tarballs,
333 and invoke the 'gnupload' script sign and upload them to the correct
334 locations. In case you need to sign with a non-default key, you can
335 use "make GNUPLOADFLAGS='--user KEY' git-upload-release".
337 * For stable releases you'll have to update the manuals at www.gnu.org.
339 - Generate manuals (with the help of the standard gendocs.sh script):
343 The ready-to-be-uploaded manuals (in several formats) will be left
344 in the 'doc/web-manuals' directory.
346 - Commit the updated manuals to web CVS:
348 make web-manual-update
350 If your local username is different from your username at Savannah,
351 you'll have to override the 'CVS_USER' make variable accordingly;
354 make web-manual-update CVS_USER=slattarini
356 - Check for link errors, fix them, recheck until convergence:
357 <http://validator.w3.org/checklink>
359 * Create an announcement message with "make announcement". Edit the
360 generated 'announcement' file appropriately, in particularly filling
361 in by hand any "TODO" left in there.
363 * Update version number in configure.ac to next alpha number.
364 Re-run ./bootstrap and commit.
366 * Don't forget to "git push" your changes so they appear in the public
369 * Send the announcement generated in the earlier steps at least to
370 <autotools-announce@gnu.org> and <automake@gnu.org>. If the release
371 is a stable one, the announcement must also go to <info-gnu@gnu.org>;
372 if it is an alpha or beta release, announcement should be sent also
373 to <platform-testers@gnu.org>, to maximize the possibility of early
374 testing on exotic or proprietary systems. Finally, copy an abridged
375 version of the announcement into the NEWS feed at:
376 <https://savannah.gnu.org/projects/automake>.
377 Be sure to link a version to the complete announcement (from
378 the version you sent to the automake list, as get archived on
379 <https://lists.gnu.org/archive/html/automake/>).
383 Copyright (C) 2003-2018 Free Software Foundation, Inc.
385 This program is free software; you can redistribute it and/or modify
386 it under the terms of the GNU General Public License as published by
387 the Free Software Foundation; either version 2, or (at your option)
390 This program is distributed in the hope that it will be useful,
391 but WITHOUT ANY WARRANTY; without even the implied warranty of
392 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
393 GNU General Public License for more details.
395 You should have received a copy of the GNU General Public License
396 along with this program. If not, see <https://www.gnu.org/licenses/>.