syntax-checks.mk

   1 # Maintainer checks for Automake.  Requires GNU make.
   2
   3 # Copyright (C) 2012 Free Software Foundation, Inc.
   4 #
   5 # This program is free software; you can redistribute it and/or modify
   6 # it under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 2, or (at your option)
   8 # any later version.
   9 #
  10 # This program is distributed in the hope that it will be useful,
  11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  17
  18 # We also have to take into account VPATH builds (where some generated
  19 # tests might be in `$(builddir)' rather than in `$(srcdir)'), TAP-based
  20 # tests script (which have a `.tap' extension) and helper scripts used
  21 # by other test cases (which have a `.sh' extension).
  22 xtests := $(shell \
  23   if test $(srcdir) = .; then \
  24      dirs=.; \
  25    else \
  26      dirs='$(srcdir) .'; \
  27    fi; \
  28    for d in $$dirs; do \
  29      for s in test tap sh; do \
  30        ls $$d/tests/*.$$s 2>/dev/null; \
  31      done; \
  32    done | sort)
  33
  34 ams := $(shell find $(srcdir) -name '*.am')
  35
  36 # Some simple checks, and then ordinary check.  These are only really
  37 # guaranteed to work on my machine.
  38 syntax_check_rules = \
  39 sc_test_names \
  40 sc_diff_automake_in_automake \
  41 sc_diff_aclocal_in_automake \
  42 sc_perl_syntax \
  43 sc_no_brace_variable_expansions \
  44 sc_rm_minus_f \
  45 sc_no_for_variable_in_macro \
  46 sc_mkinstalldirs \
  47 sc_pre_normal_post_install_uninstall \
  48 sc_perl_no_undef \
  49 sc_perl_no_split_regex_space \
  50 sc_cd_in_backquotes \
  51 sc_cd_relative_dir \
  52 sc_perl_at_uscore_in_scalar_context \
  53 sc_perl_local_no_parens \
  54 sc_perl_local \
  55 sc_AMDEP_TRUE_in_automake_in \
  56 sc_tests_make_without_am_makeflags \
  57 sc_tests_obsolete_variables \
  58 sc_tests_plain_make \
  59 sc_tests_plain_autoconf \
  60 sc_tests_plain_autoupdate \
  61 sc_tests_plain_automake \
  62 sc_tests_plain_autom4te \
  63 sc_tests_plain_autoheader \
  64 sc_tests_plain_autoreconf \
  65 sc_tests_here_document_format \
  66 sc_tests_Exit_not_exit \
  67 sc_tests_automake_fails \
  68 sc_tests_plain_aclocal \
  69 sc_tests_plain_perl \
  70 sc_tests_required_after_defs \
  71 sc_tests_tap_plan \
  72 sc_tests_overriding_macros_on_cmdline \
  73 sc_tests_plain_sleep \
  74 sc_tests_plain_egrep_fgrep \
  75 sc_tests_PATH_SEPARATOR \
  76 sc_tests_logs_duplicate_prefixes \
  77 sc_tests_makefile_variable_order \
  78 sc_mkdir_p \
  79 sc_perl_at_substs \
  80 sc_unquoted_DESTDIR \
  81 sc_tabs_in_texi \
  82 sc_at_in_texi
  83
  84 $(syntax_check_rules): automake aclocal
  85 maintainer-check: $(syntax_check_rules)
  86 .PHONY: maintainer-check $(syntax_check_rules)
  87
  88 ## Check that the list of tests given in the Makefile is equal to the
  89 ## list of all test scripts in the Automake testsuite.
  90 .PHONY: maintainer-check-list-of-tests
  91 maintainer-check-list-of-tests:
  92         $(MAKE) -C tests $@
  93 maintainer-check: maintainer-check-list-of-tests
  94
  95 ## Look for test whose names can cause spurious failures when used as
  96 ## first argument to AC_INIT (chiefly because they might contain an
  97 ## m4/m4sugar builtin or macro name).
  98 m4_builtins = \
  99   __gnu__ \
 100   __unix__ \
 101   bpatsubst \
 102   bregexp \
 103   builtin \
 104   changecom \
 105   changequote \
 106   changeword \
 107   debugfile \
 108   debugmode \
 109   decr \
 110   define \
 111   defn \
 112   divert \
 113   divnum \
 114   dnl \
 115   dumpdef \
 116   errprint \
 117   esyscmd \
 118   eval \
 119   format \
 120   ifdef \
 121   ifelse \
 122   include \
 123   incr \
 124   index \
 125   indir \
 126   len \
 127   m4exit \
 128   m4wrap \
 129   maketemp \
 130   mkstemp \
 131   patsubst \
 132   popdef \
 133   pushdef \
 134   regexp \
 135   shift \
 136   sinclude \
 137   substr \
 138   symbols \
 139   syscmd \
 140   sysval \
 141   traceoff \
 142   traceon \
 143   translit \
 144   undefine \
 145   undivert
 146 sc_test_names:
 147         @m4_builtin_rx=`echo $(m4_builtins) | sed 's/ /|/g'`; \
 148          m4_macro_rx="\\<($$m4_builtin_rx)\\>|\\<_?(A[CUMHS]|m4)_"; \
 149          if { \
 150            for t in $(xtests); do echo $$t; done \
 151              | LC_ALL=C grep -E "$$m4_macro_rx"; \
 152          }; then \
 153            echo "the names of the tests above can be problematic" 1>&2; \
 154            echo "Avoid test names that contain names of m4 macros" 1>&2; \
 155            exit 1; \
 156          fi
 157
 158 ## These check avoids accidental configure substitutions in the source.
 159 ## There are exactly 9 lines that should be modified from automake.in to
 160 ## automake, and 10 lines that should be modified from aclocal.in to
 161 ## aclocal; these wors out to 32 and 34 lines of diffs, respectively.
 162 sc_diff_automake_in_automake:
 163         @if test `diff $(srcdir)/automake.in automake | wc -l` -ne 32; then \
 164           echo "found too many diffs between automake.in and automake" 1>&2; \
 165           diff -c $(srcdir)/automake.in automake; \
 166           exit 1; \
 167         fi
 168 sc_diff_aclocal_in_aclocal:
 169         @if test `diff $(srcdir)/aclocal.in aclocal | wc -l` -ne 34; then \
 170           echo "found too many diffs between aclocal.in and aclocal" 1>&2; \
 171           diff -c $(srcdir)/aclocal.in aclocal; \
 172           exit 1; \
 173         fi
 174
 175 ## Syntax check with default Perl (on my machine, Perl 5).
 176 sc_perl_syntax:
 177         @perllibdir="./lib$(PATH_SEPARATOR)$(srcdir)/lib" $(PERL) -c -w automake
 178         @perllibdir="./lib$(PATH_SEPARATOR)$(srcdir)/lib" $(PERL) -c -w aclocal
 179
 180 ## expect no instances of '${...}'.  However, $${...} is ok, since that
 181 ## is a shell construct, not a Makefile construct.
 182 sc_no_brace_variable_expansions:
 183         @if grep -F '$${' $(ams) | grep -F -v '$$$$'; then \
 184           echo "Found too many uses of '\$${' in the lines above." 1>&2; \
 185           exit 1;                               \
 186         else :; fi
 187
 188 ## Make sure `rm' is called with `-f'.
 189 sc_rm_minus_f:
 190         @if grep -v '^#' $(ams) $(xtests) \
 191            | grep -E '\<rm ([^-]|\-[^f ]*\>)'; \
 192         then \
 193           echo "Suspicious 'rm' invocation." 1>&2; \
 194           exit 1;                               \
 195         else :; fi
 196
 197 ## Never use something like `for file in $(FILES)', this doesn't work
 198 ## if FILES is empty or if it contains shell meta characters (e.g. $ is
 199 ## commonly used in Java filenames).
 200 sc_no_for_variable_in_macro:
 201         @if grep 'for .* in \$$(' $(ams) | grep -v '/Makefile\.am:'; then \
 202           echo 'Use "list=$$(mumble); for var in $$$$list".' 1>&2 ; \
 203           exit 1; \
 204         else :; fi
 205
 206 ## Make sure all invocations of mkinstalldirs are correct.
 207 sc_mkinstalldirs:
 208         @if grep -n 'mkinstalldirs' $(ams) \
 209               | grep -F -v '$$(mkinstalldirs)' \
 210               | grep -v '^\./lib/Makefile.am:37:  *mkinstalldirs \\$$'; \
 211         then \
 212           echo "Found incorrect use of mkinstalldirs in the lines above" 1>&2; \
 213           exit 1; \
 214         else :; fi
 215
 216 ## Make sure all calls to PRE/NORMAL/POST_INSTALL/UNINSTALL
 217 sc_pre_normal_post_install_uninstall:
 218         @if grep -E -n '\((PRE|NORMAL|POST)_(|UN)INSTALL\)' $(ams) | \
 219               grep -v ':##' | grep -v ':        @\$$('; then \
 220           echo "Found incorrect use of PRE/NORMAL/POST_INSTALL/UNINSTALL in the lines above" 1>&2; \
 221           exit 1; \
 222         else :; fi
 223
 224 ## We never want to use "undef", only "delete", but for $/.
 225 sc_perl_no_undef:
 226         @if grep -n -w 'undef ' $(srcdir)/automake.in | \
 227               grep -F -v 'undef $$/'; then \
 228           echo "Found undef in automake.in; use delete instead" 1>&2; \
 229           exit 1; \
 230         fi
 231
 232 ## We never want split (/ /,...), only split (' ', ...).
 233 sc_perl_no_split_regex_space:
 234         @if grep -n 'split (/ /' $(srcdir)/automake.in; then \
 235           echo "Found bad split in the lines above." 1>&2; \
 236           exit 1; \
 237         fi
 238
 239 ## Look for cd within backquotes
 240 sc_cd_in_backquotes:
 241         @if grep -n '^[^#]*` *cd ' $(srcdir)/automake.in $(ams); then \
 242           echo "Consider using \$$(am__cd) in the lines above." 1>&2; \
 243           exit 1; \
 244         fi
 245
 246 ## Look for cd to a relative directory (may be influenced by CDPATH).
 247 ## Skip some known directories that are OK.
 248 sc_cd_relative_dir:
 249         @if grep -n '^[^#]*cd ' $(srcdir)/automake.in $(ams) | \
 250               grep -v 'echo.*cd ' | \
 251               grep -v 'am__cd =' | \
 252               grep -v '^[^#]*cd [./]' | \
 253               grep -v '^[^#]*cd \$$(top_builddir)' | \
 254               grep -v '^[^#]*cd "\$$\$$am__cwd' | \
 255               grep -v '^[^#]*cd \$$(abs' | \
 256               grep -v '^[^#]*cd "\$$(DESTDIR)'; then \
 257           echo "Consider using \$$(am__cd) in the lines above." 1>&2; \
 258           exit 1; \
 259         fi
 260
 261 ## Using @_ in a scalar context is most probably a programming error.
 262 sc_perl_at_uscore_in_scalar_context:
 263         @if grep -Hn '[^@_A-Za-z0-9][_A-Za-z0-9]*[^) ] *= *@_' $(srcdir)/automake.in; then \
 264           echo "Using @_ in a scalar context in the lines above." 1>&2; \
 265           exit 1; \
 266         fi
 267
 268 ## Forbid using parens with `local' to ease counting.
 269 sc_perl_local_no_parens:
 270         @if grep '^[ \t]*local *(' $(srcdir)/automake.in; then \
 271           echo "Don't use \`local' with parens: use several \`local' above." >&2; \
 272           exit 1; \
 273         fi
 274
 275 ## Allow only few variables to be localized in Automake.
 276 sc_perl_local:
 277         @if egrep -v '^[ \t]*local \$$[_~]( *=|;)' $(srcdir)/automake.in | \
 278                 grep '^[ \t]*local [^*]'; then \
 279           echo "Please avoid \`local'." 1>&2; \
 280           exit 1; \
 281         fi
 282
 283 ## Don't let AMDEP_TRUE substitution appear in automake.in.
 284 sc_AMDEP_TRUE_in_automake_in:
 285         @if grep '@AMDEP''_TRUE@' $(srcdir)/automake.in; then \
 286           echo "Don't put AMDEP_TRUE substitution in automake.in" 1>&2; \
 287           exit 1; \
 288         fi
 289
 290 ## Recursive make invocations should always pass $(AM_MAKEFLAGS)
 291 ## to $(MAKE), for portability to non-GNU make.
 292 sc_tests_make_without_am_makeflags:
 293         @if grep '^[^#].*(MAKE) ' $(ams) $(srcdir)/automake.in | \
 294                 grep -v 'AM_MAKEFLAGS'; then \
 295           echo 'Use $$(MAKE) $$(AM_MAKEFLAGS).' 1>&2; \
 296           exit 1; \
 297         fi
 298
 299 ## Look out for some obsolete variables.
 300 sc_tests_obsolete_variables:
 301         @vars=" \
 302           using_tap \
 303           parallel_tests \
 304           test_prefer_config_shell \
 305           original_AUTOMAKE \
 306           original_ACLOCAL \
 307         "; \
 308         seen=""; \
 309         for v in $$vars; do \
 310           if grep -E "\b$$v\b" \
 311             $(xtests) $(srcdir)/tests/defs \
 312             $(srcdir)/tests/defs-static.in \
 313           ; then \
 314             seen="$$seen $$v"; \
 315           fi; \
 316         done; \
 317         if test -n "$$seen"; then \
 318           for v in $$seen; do \
 319             echo "Variable '$$v' is obsolete, use 'am_$$v' instead." 1>&2; \
 320           done; \
 321           exit 1; \
 322         else :; fi
 323
 324 ## Tests should never call make directly.
 325 sc_tests_plain_make:
 326         @if grep -v '^#' $(xtests) | $(EGREP) ':[       ]*make( |$$)'; then \
 327           echo 'Do not run "make" in the above tests.  Use "$$MAKE" instead.' 1>&2; \
 328           exit 1; \
 329         fi
 330
 331 ## Tests should never call autoconf directly.
 332 sc_tests_plain_autoconf:
 333         @if grep -v '^#' $(xtests) | grep ':[   ]*autoconf\>'; then \
 334           echo 'Do not run "autoconf" in the above tests.  Use "$$AUTOCONF" instead.' 1>&2; \
 335           exit 1; \
 336         fi
 337
 338 ## Tests should never call autoupdate directly.
 339 sc_tests_plain_autoupdate:
 340         @if grep -v '^#' $(xtests) | grep ':[   ]*autoupdate\>'; then \
 341           echo 'Do not run "autoupdate" in the above tests.  Use "$$AUTOUPDATE" instead.' 1>&2; \
 342           exit 1; \
 343         fi
 344
 345 ## Tests should never call automake directly.
 346 sc_tests_plain_automake:
 347         @if grep -v '^#' $(xtests) | grep -E ':[        ]*automake\>([^:]|$$)'; then \
 348           echo 'Do not run "automake" in the above tests.  Use "$$AUTOMAKE" instead.' 1>&2;  \
 349           exit 1; \
 350         fi
 351
 352 ## Tests should never call autoheader directly.
 353 sc_tests_plain_autoheader:
 354         @if grep -v '^#' $(xtests) | grep ':[   ]*autoheader\>'; then \
 355           echo 'Do not run "autoheader" in the above tests.  Use "$$AUTOHEADER" instead.' 1>&2;  \
 356           exit 1; \
 357         fi
 358
 359 ## Tests should never call autoreconf directly.
 360 sc_tests_plain_autoreconf:
 361         @if grep -v '^#' $(xtests) | grep ':[   ]*autoreconf\>'; then \
 362           echo 'Do not run "autoreconf" in the above tests.  Use "$$AUTORECONF" instead.' 1>&2;  \
 363           exit 1; \
 364         fi
 365
 366 ## Tests should never call autom4te directly.
 367 sc_tests_plain_autom4te:
 368         @if grep -v '^#' $(xtests) | grep ':[   ]*autom4te\>'; then \
 369           echo 'Do not run "autom4te" in the above tests.  Use "$$AUTOM4TE" instead.' 1>&2;  \
 370           exit 1; \
 371         fi
 372
 373 ## Tests should only use END and EOF for here documents
 374 ## (so that the next test is effective).
 375 sc_tests_here_document_format:
 376         @if grep '<<' $(xtests) | grep -v 'END' | grep -v 'EOF'; then \
 377           echo 'Use here documents with "END" and "EOF" only, for greppability.' 1>&2; \
 378           exit 1; \
 379         fi
 380
 381 ## Tests should never call exit directly, but use Exit.
 382 ## This is so that the exit status is transported correctly across the 0 trap.
 383 ## Ignore comments, testsuite self tests, and one perl line in ext2.test.
 384 sc_tests_Exit_not_exit:
 385         @found=false; for file in $(xtests); do \
 386           case $$file in */self-check-*) continue;; esac; \
 387           res=`sed -n -e '/^#/d; /^\$$PERL/d' -e '/<<.*END/,/^END/b' \
 388                       -e '/<<.*EOF/,/^EOF/b' -e '/exit [$$0-9]/p' $$file`; \
 389           if test -n "$$res"; then \
 390             echo "$$file:$$res"; \
 391             found=true; \
 392           fi; \
 393         done; \
 394         if $$found; then \
 395           echo 'Do not call plain "exit", use "Exit" instead, in above tests.' 1>&2; \
 396           exit 1; \
 397         fi
 398
 399 ## Use AUTOMAKE_fails when appropriate
 400 sc_tests_automake_fails:
 401         @if grep -v '^#' $(xtests) | grep '\$$AUTOMAKE.*&&.*[eE]xit'; then \
 402           echo 'Use AUTOMAKE_fails + grep to catch automake failures in the above tests.' 1>&2;  \
 403           exit 1; \
 404         fi
 405
 406 ## Tests should never call aclocal directly.
 407 sc_tests_plain_aclocal:
 408         @if grep -v '^#' $(xtests) | grep ':[   ]*aclocal\>'; then \
 409           echo 'Do not run "aclocal" in the above tests.  Use "$$ACLOCAL" instead.' 1>&2;  \
 410           exit 1; \
 411         fi
 412
 413 ## Tests should never call perl directly.
 414 sc_tests_plain_perl:
 415         @if grep -v '^#' $(xtests) | grep ':[   ]*perl\>'; then \
 416           echo 'Do not run "perl" in the above tests.  Use "$$PERL" instead.' 1>&2; \
 417           exit 1; \
 418         fi
 419
 420 ## Setting `required' after sourcing `./defs' is a bug.
 421 sc_tests_required_after_defs:
 422         @for file in $(xtests); do \
 423           if out=`sed -n '/defs/,$${/required=/p;}' $$file`; test -n "$$out"; then \
 424             echo 'Do not set "required" after sourcing "defs" in '"$$file: $$out" 1>&2; \
 425             exit 1; \
 426           fi; \
 427         done
 428
 429 ## TAP-based test scripts should not forget to declare a TAP plan.  In
 430 ## case it is not known in advance how many tests will be run, a "lazy"
 431 ## plan can be used; but its use should be deliberate, explicitly declared
 432 ## with a "plan_ later" call, rather than the result of an oversight.
 433 ## This check helps to ensure this is indeed the case.
 434 sc_tests_tap_plan:
 435         @with_plan=`grep -l '^ *plan_ ' $(srcdir)/tests/*.tap`; \
 436          with_plan=`echo $$with_plan`; \
 437          ok=:; \
 438          for t in $(srcdir)/tests/*.tap; do \
 439            case " $$with_plan " in *" $$t "*) continue;; esac; \
 440            case $$t in \
 441              *-w.tap) \
 442                : it is ok for an *auto-generated* test sourcing an \
 443                : hand-written one not to declare a TAP plan: that will \
 444                : be done by the sourced test; \
 445                t2=`echo $$t | sed -e 's|.*/||' -e 's/-w\.tap$$/.tap/'` \
 446                  && grep -E "^ *\\.  *[^        ]*/$$t2\\b" $$t >/dev/null \
 447                  && continue || : ;; \
 448            esac; \
 449            ok=false; echo $$t; \
 450          done; \
 451          $$ok || { \
 452           echo 'The tests above do not declare a TAP plan.' 1>&2; \
 453           exit 1; \
 454          }
 455
 456 ## Overriding a Makefile macro on the command line is not portable when
 457 ## recursive targets are used.  Better use an envvar.  SHELL is an
 458 ## exception, POSIX says it can't come from the environment.  V, DESTDIR,
 459 ## DISTCHECK_CONFIGURE_FLAGS and DISABLE_HARD_ERRORS are exceptions, too,
 460 ## as package authors are urged not to initialize them anywhere.
 461 sc_tests_overriding_macros_on_cmdline:
 462         @if grep -E '\$$MAKE .*(SHELL=.*=|=.*SHELL=)' $(xtests); then \
 463           echo 'Rewrite "$$MAKE foo=bar SHELL=$$SHELL" as "foo=bar $$MAKE -e SHELL=$$SHELL"' 1>&2; \
 464           echo ' in the above lines, it is more portable.' 1>&2; \
 465           exit 1; \
 466         fi
 467 # The first s/// tries to account for usages like "$MAKE || st=$?".
 468 # DISTCHECK_CONFIGURE_FLAGS is allowed to contain whitespace in its
 469 # definition, hence the more complex last three substitutions below.
 470         @if sed -e 's/ || .*//' -e 's/ && .*//' \
 471                 -e 's/ DESTDIR=[^ ]*/ /' -e 's/ SHELL=[^ ]*/ /' \
 472                 -e 's/ V=[^ ]*/ /' -e 's/ DISABLE_HARD_ERRORS=[^ ]*/ /' \
 473                 -e "s/ DISTCHECK_CONFIGURE_FLAGS='[^']*'/ /" \
 474                 -e 's/ DISTCHECK_CONFIGURE_FLAGS="[^"]*"/ /' \
 475                 -e 's/ DISTCHECK_CONFIGURE_FLAGS=[^ ]/ /' \
 476               $(xtests) | grep '\$$MAKE .*='; then \
 477           echo 'Rewrite "$$MAKE foo=bar" as "foo=bar $$MAKE -e" in the above lines,' 1>&2; \
 478           echo 'it is more portable.' 1>&2; \
 479           exit 1; \
 480         fi
 481         @if grep 'SHELL=.*\$$MAKE' $(xtests); then \
 482           echo '$$MAKE ignores the SHELL envvar, use "$$MAKE SHELL=$$SHELL" in' 1>&2; \
 483           echo 'the above lines.' 1>&2; \
 484           exit 1; \
 485         fi
 486
 487 ## Never use `sleep 1' to create files with different timestamps.
 488 ## Use `$sleep' instead.  Some filesystems (e.g., Windows') have only
 489 ## a 2sec resolution.
 490 sc_tests_plain_sleep:
 491         @if grep -E '\bsleep +[12345]\b' $(xtests); then \
 492           echo 'Do not use "sleep x" in the above tests.  Use "$$sleep" instead.' 1>&2; \
 493           exit 1; \
 494         fi
 495
 496 ## fgrep and egrep are not required by POSIX.
 497 sc_tests_plain_egrep_fgrep:
 498         @if grep -E '\b[ef]grep\b' $(xtests) ; then \
 499           echo 'Do not use egrep or fgrep in test cases.  Use $$FGREP or $$EGREP.' 1>&2; \
 500           exit 1; \
 501         fi
 502         @if grep -E '\b[ef]grep\b' $(ams) $(srcdir)/m4/*.m4; then \
 503           echo 'Do not use egrep or fgrep in the above files, they are not portable.' 1>&2; \
 504           exit 1; \
 505         fi
 506
 507 ## Rule to ensure that the testsuite has been run before.  We don't depend on `check'
 508 ## here, because that would be very wasteful in the common case.  We could run
 509 ## `make check RECHECK_LOGS=' and avoid toplevel races with AM_RECURSIVE_TARGETS.
 510 ## Suggest keeping test directories around for greppability of the Makefile.in files.
 511 sc_ensure_testsuite_has_run:
 512         @if test ! -f tests/test-suite.log; then \
 513           echo "Run \`env keep_testdirs=yes make check' before \`maintainer-check'" >&2; \
 514           exit 1; \
 515         fi
 516 .PHONY: sc_ensure_testsuite_has_run
 517
 518 ## Ensure our warning and error messages do not contain duplicate 'warning:' prefixes.
 519 ## This test actually depends on the testsuite having been run before.
 520 sc_tests_logs_duplicate_prefixes: sc_ensure_testsuite_has_run
 521         @if grep -E '(warning|error):.*(warning|error):' tests/*.log; then \
 522           echo 'Duplicate warning/error message prefixes seen in above tests.' >&2; \
 523           exit 1; \
 524         fi
 525
 526 ## Ensure variables are listed before rules in Makefile.in files we generate.
 527 sc_tests_makefile_variable_order: sc_ensure_testsuite_has_run
 528         @st=0; \
 529         for file in `find tests -name Makefile.in -print`; do \
 530           latevars=`sed -n \
 531             -e :x -e 's/#.*//' \
 532             -e '/\\\\$$/{' -e N -e 'b x' -e '}' \
 533             -e '# Literal TAB.' \
 534             -e '1,/^    /d' \
 535             -e '# Allow @ so we match conditionals.' \
 536             -e '/^ *[a-zA-Z_@]\{1,\} *=/p' $$file`; \
 537           if test -n "$$latevars"; then \
 538             echo "Variables are expanded too late in $$file:" >&2; \
 539             echo "$$latevars" | sed 's/^/  /' >&2; \
 540             st=1; \
 541           fi; \
 542         done; \
 543         test $$st -eq 0 || { \
 544           echo 'Ensure variables are expanded before rules' >&2; \
 545           exit 1; \
 546         }
 547
 548 ## Using `:' as a PATH separator is not portable.
 549 sc_tests_PATH_SEPARATOR:
 550         @if grep -E '\bPATH=.*:.*' $(xtests) ; then \
 551           echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \
 552           exit 1; \
 553         fi
 554
 555 sc_mkdir_p:
 556         @if grep 'mkdir_p' $(srcdir)/automake.in $(ams) $(xtests); then \
 557           echo 'Do not use mkdir_p in the above files, use MKDIR_P.' 1>&2; \
 558           exit 1; \
 559         fi
 560
 561 ## Try to make sure all @...@ substitutions are covered by our
 562 ## substitution rule.
 563 sc_perl_at_substs:
 564         @if test `grep -E '^[^#]*@[A-Za-z_0-9]+@' aclocal | wc -l` -ne 0; then \
 565           echo "Unresolved @...@ substitution in aclocal" 1>&2; \
 566           exit 1; \
 567         fi
 568         @if test `grep -E '^[^#]*@[A-Za-z_0-9]+@' automake | wc -l` -ne 0; then \
 569           echo "Unresolved @...@ substitution in automake" 1>&2; \
 570           exit 1; \
 571         fi
 572
 573 sc_unquoted_DESTDIR:
 574         @if grep -E "[^\'\"]\\\$$\(DESTDIR" $(ams); then \
 575           echo 'Suspicious unquoted DESTDIR uses.' 1>&2 ; \
 576           exit 1; \
 577         fi
 578
 579 sc_tabs_in_texi:
 580         @if grep '      ' $(srcdir)/doc/automake.texi; then \
 581           echo 'Do not use tabs in the manual.' 1>&2; \
 582           exit 1; \
 583         fi
 584
 585 sc_at_in_texi:
 586         @if grep -E '([^@]|^)@([         ][^@]|$$)' $(srcdir)/doc/automake.texi; \
 587         then \
 588           echo 'Unescaped @.' 1>&2; \
 589           exit 1; \
 590         fi