| commit | bb5dfb0861d659d22f71a74db3a07f427a86e82d | |
| author | XazZ <devel@xazz.no-ip.info> | |
| Mon, 5 May 2008 13:02:10 +0000 (5 15:02 +0200) | ||
| committer | XazZ <devel@xazz.no-ip.info> | |
| Mon, 5 May 2008 13:02:10 +0000 (5 15:02 +0200) | ||
| tree | 20b501ca926f03e25ffeed55ec6aa59ab216911a | treesnapshot (tar.gz zip) |
| parent | 20a52936ed42d07b3f8ea5329c5d334dbd36fd50 | commitdiff |
fix various bugs (thanks to Francis Galiegue <fgaliegue@gmail.com> for doing most of the work!)
Initialization: request IRQ earlier
The call to request_irq was done in acxpci_e_open(), ie when someone attached the interface (on an ifconfig for example).
Do it at initialization time instead, in acxpci_e_probe(). Do it only after the PCI region init is done, since the interrupt routine requires them to be set up.
acxpci_e_probe: use pci_* functions to request/map memory regions at init time
The kernel has helpers to request and map memory regions. Use them instead of request_mem_region()/iomap{,_nocache()}.
Also use the corresponding undoing functions on the exit path in case of failures.
Initialization: request IRQ earlier
The call to request_irq was done in acxpci_e_open(), ie when someone attached the interface (on an ifconfig for example).
Do it at initialization time instead, in acxpci_e_probe(). Do it only after the PCI region init is done, since the interrupt routine requires them to be set up.
acxpci_e_probe: use pci_* functions to request/map memory regions at init time
The kernel has helpers to request and map memory regions. Use them instead of request_mem_region()/iomap{,_nocache()}.
Also use the corresponding undoing functions on the exit path in case of failures.
| pci.c | diffblobblamehistory |