src/TortoiseProc/Settings/SettingGitRemote.cpp

   1 // TortoiseGit - a Windows shell extension for easy version control
   2
   3 // Copyright (C) 2008-2020 - TortoiseGit
   4
   5 // This program is free software; you can redistribute it and/or
   6 // modify it under the terms of the GNU General Public License
   7 // as published by the Free Software Foundation; either version 2
   8 // of the License, or (at your option) any later version.
   9
  10 // This program is distributed in the hope that it will be useful,
  11 // but WITHOUT ANY WARRANTY; without even the implied warranty of
  12 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  13 // GNU General Public License for more details.
  14
  15 // You should have received a copy of the GNU General Public License
  16 // along with this program; if not, write to the Free Software Foundation,
  17 // 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  18 //
  19 // SettingGitRemote.cpp : implementation file
  20 //
  21
  22 #include "stdafx.h"
  23 #include "TortoiseProc.h"
  24 #include "SettingGitRemote.h"
  25 #include "Settings.h"
  26 #include "GitAdminDir.h"
  27 #include "MessageBox.h"
  28 #include "AppUtils.h"
  29 #include "Git.h"
  30 #include "HistoryCombo.h"
  31
  32 // CSettingGitRemote dialog
  33
  34 IMPLEMENT_DYNAMIC(CSettingGitRemote, ISettingsPropPage)
  35
  36 CSettingGitRemote::CSettingGitRemote()
  37         : ISettingsPropPage(CSettingGitRemote::IDD)
  38         , m_bNoFetch(false)
  39         , m_bPrune(2)
  40         , m_bPruneAll(FALSE)
  41         , m_bPushDefault(FALSE)
  42 {
  43         m_ChangedMask = 0;
  44 }
  45
  46 CSettingGitRemote::~CSettingGitRemote()
  47 {
  48 }
  49
  50 void CSettingGitRemote::DoDataExchange(CDataExchange* pDX)
  51 {
  52         CPropertyPage::DoDataExchange(pDX);
  53         DDX_Control(pDX, IDC_LIST_REMOTE, m_ctrlRemoteList);
  54         DDX_Text(pDX, IDC_EDIT_REMOTE, m_strRemote);
  55         DDX_Text(pDX, IDC_EDIT_URL, m_strUrl);
  56         DDX_Text(pDX, IDC_EDIT_PUSHURL, m_strPushUrl);
  57         DDX_Text(pDX, IDC_EDIT_PUTTY_KEY, m_strPuttyKeyfile);
  58         DDX_Control(pDX, IDC_COMBO_TAGOPT, m_ctrlTagOpt);
  59         DDX_Check(pDX, IDC_CHECK_PRUNE, m_bPrune);
  60         DDX_Check(pDX, IDC_CHECK_PRUNEALL, m_bPruneAll);
  61         DDX_Check(pDX, IDC_CHECK_PUSHDEFAULT, m_bPushDefault);
  62 }
  63
  64 BEGIN_MESSAGE_MAP(CSettingGitRemote, CPropertyPage)
  65         ON_WM_TIMER()
  66         ON_BN_CLICKED(IDC_BUTTON_BROWSE, &CSettingGitRemote::OnBnClickedButtonBrowse)
  67         ON_BN_CLICKED(IDC_BUTTON_ADD, &CSettingGitRemote::OnBnClickedButtonAdd)
  68         ON_LBN_SELCHANGE(IDC_LIST_REMOTE, &CSettingGitRemote::OnLbnSelchangeListRemote)
  69         ON_EN_CHANGE(IDC_EDIT_REMOTE, &CSettingGitRemote::OnEnChangeEditRemote)
  70         ON_EN_CHANGE(IDC_EDIT_URL, &CSettingGitRemote::OnEnChangeEditUrl)
  71         ON_EN_CHANGE(IDC_EDIT_PUSHURL, &CSettingGitRemote::OnEnChangeEditPushUrl)
  72         ON_EN_CHANGE(IDC_EDIT_PUTTY_KEY, &CSettingGitRemote::OnEnChangeEditPuttyKey)
  73         ON_CBN_SELCHANGE(IDC_COMBO_TAGOPT, &CSettingGitRemote::OnCbnSelchangeComboTagOpt)
  74         ON_BN_CLICKED(IDC_CHECK_PRUNE, &CSettingGitRemote::OnBnClickedCheckprune)
  75         ON_BN_CLICKED(IDC_CHECK_PRUNEALL, &CSettingGitRemote::OnBnClickedCheckpruneall)
  76         ON_BN_CLICKED(IDC_CHECK_PUSHDEFAULT, &CSettingGitRemote::OnBnClickedCheckpushdefault)
  77         ON_BN_CLICKED(IDC_BUTTON_REMOVE, &CSettingGitRemote::OnBnClickedButtonRemove)
  78         ON_BN_CLICKED(IDC_BUTTON_RENAME_REMOTE, &CSettingGitRemote::OnBnClickedButtonRenameRemote)
  79 END_MESSAGE_MAP()
  80
  81 static void ShowEditBalloon(HWND hDlg, UINT nIdControl, UINT nIdText, UINT nIdTitle, int nIcon = TTI_WARNING)
  82 {
  83         CString text(MAKEINTRESOURCE(nIdText));
  84         CString title(MAKEINTRESOURCE(nIdTitle));
  85         EDITBALLOONTIP bt;
  86         bt.cbStruct = sizeof(bt);
  87         bt.pszText  = text;
  88         bt.pszTitle = title;
  89         bt.ttiIcon  = nIcon;
  90         SendDlgItemMessage(hDlg, nIdControl, EM_SHOWBALLOONTIP, 0, reinterpret_cast<LPARAM>(&bt));
  91 }
  92
  93 #define TIMER_PREFILL 1
  94
  95 BOOL CSettingGitRemote::OnInitDialog()
  96 {
  97         ISettingsPropPage::OnInitDialog();
  98
  99         AdjustControlSize(IDC_CHECK_PRUNE);
 100         AdjustControlSize(IDC_CHECK_PRUNEALL);
 101         AdjustControlSize(IDC_CHECK_PUSHDEFAULT);
 102
 103         STRING_VECTOR remotes;
 104         g_Git.GetRemoteList(remotes);
 105         m_ctrlRemoteList.ResetContent();
 106         for (size_t i = 0; i < remotes.size(); i++)
 107                 m_ctrlRemoteList.AddString(remotes[i]);
 108
 109         m_ctrlTagOpt.AddString(CString(MAKEINTRESOURCE(IDS_FETCH_REACHABLE)));
 110         m_ctrlTagOpt.AddString(CString(MAKEINTRESOURCE(IDS_NONE)));
 111         m_ctrlTagOpt.AddString(CString(MAKEINTRESOURCE(IDS_ALL)));
 112         m_ctrlTagOpt.SetCurSel(0);
 113
 114         CString pruneAll = g_Git.GetConfigValue(L"fetch.prune");
 115         m_bPruneAll = pruneAll == L"true" ? TRUE : FALSE;
 116
 117         {
 118                 CString tmp;
 119                 tmp.Format(IDS_GITCONFIG_SETTING, L"remote.pushdefault");
 120                 m_tooltips.AddTool(IDC_CHECK_PUSHDEFAULT, tmp);
 121                 tmp.Format(IDS_GITCONFIG_SETTING, L"remote.<name>.prune");
 122                 m_tooltips.AddTool(IDC_CHECK_PRUNE, tmp);
 123                 tmp.Format(IDS_GITCONFIG_SETTING, L"fetch.prune");
 124                 m_tooltips.AddTool(IDC_CHECK_PRUNEALL, tmp);
 125                 tmp.Format(IDS_GITCONFIG_SETTING, L"remote<name>.tagopt");
 126                 m_tooltips.AddTool(IDC_COMBO_TAGOPT, tmp);
 127         }
 128
 129         //this->GetDlgItem(IDC_EDIT_REMOTE)->EnableWindow(FALSE);
 130         this->UpdateData(FALSE);
 131
 132         SetTimer(TIMER_PREFILL, 1000, nullptr);
 133         return TRUE;
 134 }
 135 // CSettingGitRemote message handlers
 136
 137 void CSettingGitRemote::OnTimer(UINT_PTR nIDEvent)
 138 {
 139         if (nIDEvent == TIMER_PREFILL)
 140         {
 141                 if (m_strRemote.IsEmpty() && m_ctrlRemoteList.GetCount() == 0)
 142                         ShowEditBalloon(IDC_EDIT_URL, IDS_B_T_PREFILL_ORIGIN, IDS_HINT, TTI_INFO);
 143
 144                 KillTimer(TIMER_PREFILL);
 145         }
 146 }
 147
 148 void CSettingGitRemote::OnBnClickedButtonBrowse()
 149 {
 150         UpdateData();
 151         CString filename = m_strPuttyKeyfile;
 152         if (!PathFileExists(filename))
 153                 filename.Empty();
 154         if (!CAppUtils::FileOpenSave(filename, nullptr, 0, IDS_PUTTYKEYFILEFILTER, true, GetSafeHwnd()))
 155                 return;
 156
 157         m_strPuttyKeyfile = filename;
 158         UpdateData(FALSE);
 159         OnEnChangeEditPuttyKey();
 160 }
 161
 162 void CSettingGitRemote::OnBnClickedButtonAdd()
 163 {
 164         this->UpdateData();
 165
 166         if(m_strRemote.IsEmpty())
 167         {
 168                 CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_REMOTEEMPTY, IDS_APPNAME, MB_OK |  MB_ICONERROR);
 169                 return;
 170         }
 171         if(m_strUrl.IsEmpty())
 172         {
 173                 CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_URLEMPTY, IDS_APPNAME, MB_OK | MB_ICONERROR);
 174                 return;
 175         }
 176
 177         m_ChangedMask = REMOTE_NAME | REMOTE_URL | REMOTE_PUTTYKEY | REMOTE_TAGOPT | REMOTE_PRUNE | REMOTE_PRUNEALL | REMOTE_PUSHDEFAULT | REMOTE_PUSHURL;
 178         if(IsRemoteExist(m_strRemote))
 179         {
 180                 CString msg;
 181                 msg.Format(IDS_PROC_GITCONFIG_OVERWRITEREMOTE, static_cast<LPCTSTR>(m_strRemote));
 182                 if (CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_YESNO | MB_ICONQUESTION | MB_DEFBUTTON2) == IDYES)
 183                         m_ChangedMask &= ~REMOTE_NAME;
 184                 else
 185                         return;
 186         }
 187
 188         this->OnApply();
 189 }
 190
 191 BOOL CSettingGitRemote::IsRemoteExist(const CString& remote)
 192 {
 193         CString str;
 194         for(int i=0;i<m_ctrlRemoteList.GetCount();i++)
 195         {
 196                 m_ctrlRemoteList.GetText(i,str);
 197                 if(str == remote)
 198                         return true;
 199         }
 200         return false;
 201 }
 202
 203 struct CheckRefspecStruct
 204 {
 205         CStringA remote;
 206         bool result;
 207 };
 208
 209 static int CheckRemoteCollideWithRefspec(const git_config_entry *entry, void * payload)
 210 {
 211         auto crs = reinterpret_cast<CheckRefspecStruct*>(payload);
 212         crs->result = false;
 213         if (entry->name == "remote." + crs->remote + ".fetch")
 214                 return 0;
 215         CStringA value = CStringA(entry->value);
 216         CStringA match = ":refs/remotes/" + crs->remote;
 217         int pos = value.Find(match);
 218         if (pos < 0)
 219                 return 0;
 220         if ((pos + match.GetLength() == value.GetLength()) || (value[pos + match.GetLength()] == '/'))
 221         {
 222                 crs->result = true;
 223                 return GIT_EUSER;
 224         }
 225         return 0;
 226 }
 227
 228 bool CSettingGitRemote::IsRemoteCollideWithRefspec(CString remote)
 229 {
 230         CheckRefspecStruct crs = { CUnicodeUtils::GetUTF8(remote), false };
 231         CAutoConfig config(true);
 232         git_config_add_file_ondisk(config, CGit::GetGitPathStringA(g_Git.GetGitLocalConfig()), GIT_CONFIG_LEVEL_LOCAL, g_Git.GetGitRepository(), FALSE);
 233         for (const auto pattern : { "remote\\..*\\.fetch", "svn-remote\\..*\\.fetch", "svn-remote\\..*\\.branches", "svn-remote\\..*\\.tags" })
 234         {
 235                 git_config_foreach_match(config, pattern, CheckRemoteCollideWithRefspec, &crs);
 236                 if (crs.result)
 237                         return true;
 238         }
 239         return false;
 240 }
 241
 242 void CSettingGitRemote::OnLbnSelchangeListRemote()
 243 {
 244         CWaitCursor wait;
 245
 246         if(m_ChangedMask)
 247         {
 248                 if (CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_SAVEREMOTE, IDS_APPNAME, 1, IDI_QUESTION, IDS_SAVEBUTTON, IDS_DISCARDBUTTON) == 1)
 249                         OnApply();
 250         }
 251         SetModified(FALSE);
 252
 253         int index = this->m_ctrlRemoteList.GetCurSel();
 254         if(index<0)
 255         {
 256                 m_strUrl.Empty();
 257                 m_strPushUrl.Empty();
 258                 m_strRemote.Empty();
 259                 m_strPuttyKeyfile.Empty();
 260                 this->UpdateData(FALSE);
 261                 return;
 262         }
 263         m_ctrlRemoteList.GetText(index, m_strRemote);
 264
 265         CString cmd, output;
 266         cmd.Format(L"remote.%s.url", static_cast<LPCTSTR>(m_strRemote));
 267         m_strUrl = g_Git.GetConfigValue(cmd);
 268
 269         cmd.Format(L"remote.%s.pushurl", static_cast<LPCTSTR>(m_strRemote));
 270         m_strPushUrl = g_Git.GetConfigValue(cmd);
 271
 272         cmd.Format(L"remote.%s.puttykeyfile", static_cast<LPCTSTR>(m_strRemote));
 273
 274         this->m_strPuttyKeyfile = g_Git.GetConfigValue(cmd);
 275
 276         m_ChangedMask=0;
 277
 278
 279         cmd.Format(L"remote.%s.tagopt", static_cast<LPCTSTR>(m_strRemote));
 280         CString tagopt = g_Git.GetConfigValue(cmd);
 281         index = 0;
 282         if (tagopt == "--no-tags")
 283                 index = 1;
 284         else if (tagopt == "--tags")
 285                 index = 2;
 286         m_ctrlTagOpt.SetCurSel(index);
 287
 288         CString pushDefault = g_Git.GetConfigValue(L"remote.pushdefault");
 289         m_bPushDefault = pushDefault == m_strRemote ? TRUE : FALSE;
 290         cmd.Format(L"remote.%s.prune", static_cast<LPCTSTR>(m_strRemote));
 291         CString prune = g_Git.GetConfigValue(cmd);
 292         m_bPrune = prune == L"true" ? TRUE : prune == L"false" ? FALSE : 2;
 293         CString pruneAll = g_Git.GetConfigValue(L"fetch.prune");
 294         m_bPruneAll = pruneAll == L"true" ? TRUE : FALSE;
 295
 296         GetDlgItem(IDC_BUTTON_ADD)->EnableWindow(TRUE);
 297         GetDlgItem(IDC_BUTTON_REMOVE)->EnableWindow(TRUE);
 298         GetDlgItem(IDC_BUTTON_RENAME_REMOTE)->EnableWindow(TRUE);
 299         this->UpdateData(FALSE);
 300 }
 301
 302 void CSettingGitRemote::OnEnChangeEditRemote()
 303 {
 304         m_ChangedMask|=REMOTE_NAME;
 305
 306         this->UpdateData();
 307
 308         if (IsRemoteCollideWithRefspec(m_strRemote))
 309                 ShowEditBalloon(IDC_EDIT_REMOTE, IDS_B_T_REMOTE_NAME_COLLIDE, IDS_HINT, TTI_WARNING);
 310         if( (!this->m_strRemote.IsEmpty())&&(!this->m_strUrl.IsEmpty()) )
 311                 this->SetModified();
 312 }
 313
 314 void CSettingGitRemote::OnEnChangeEditUrl()
 315 {
 316         m_ChangedMask|=REMOTE_URL;
 317
 318         this->UpdateData();
 319
 320         if (m_strRemote.IsEmpty() && !m_strUrl.IsEmpty() && m_ctrlRemoteList.GetCount() == 0)
 321         {
 322                 GetDlgItem(IDC_EDIT_REMOTE)->SetWindowText(L"origin");
 323                 OnEnChangeEditRemote();
 324         }
 325
 326         if( (!this->m_strRemote.IsEmpty())&&(!this->m_strUrl.IsEmpty()) )
 327                 this->SetModified();
 328 }
 329
 330 void CSettingGitRemote::OnEnChangeEditPushUrl()
 331 {
 332         m_ChangedMask |= REMOTE_PUSHURL;
 333
 334         this->UpdateData();
 335
 336         if (!this->m_strRemote.IsEmpty())
 337                 this->SetModified();
 338 }
 339
 340 void CSettingGitRemote::OnEnChangeEditPuttyKey()
 341 {
 342         m_ChangedMask|=REMOTE_PUTTYKEY;
 343
 344         this->UpdateData();
 345         if (!this->m_strUrl.IsEmpty())
 346                 this->SetModified();
 347 }
 348
 349 void CSettingGitRemote::OnCbnSelchangeComboTagOpt()
 350 {
 351         m_ChangedMask |= REMOTE_TAGOPT;
 352
 353         this->UpdateData();
 354         this->SetModified();
 355 }
 356
 357 void CSettingGitRemote::OnBnClickedCheckprune()
 358 {
 359         m_ChangedMask |= REMOTE_PRUNE;
 360
 361         this->UpdateData();
 362         this->SetModified();
 363 }
 364
 365 void CSettingGitRemote::OnBnClickedCheckpruneall()
 366 {
 367         m_ChangedMask |= REMOTE_PRUNEALL;
 368         UpdateData();
 369         SetModified();
 370 }
 371
 372 void CSettingGitRemote::OnBnClickedCheckpushdefault()
 373 {
 374         m_ChangedMask |= REMOTE_PUSHDEFAULT;
 375         UpdateData();
 376         SetModified();
 377 }
 378
 379 BOOL CSettingGitRemote::Save(CString key,CString value)
 380 {
 381         CString cmd,out;
 382
 383         cmd.Format(L"remote.%s.%s", static_cast<LPCTSTR>(m_strRemote), static_cast<LPCTSTR>(key));
 384         if (value.IsEmpty())
 385         {
 386                 // don't check result code. it fails if the entry not exist
 387                 g_Git.UnsetConfigValue(cmd, CONFIG_LOCAL);
 388                 if (!g_Git.GetConfigValue(cmd).IsEmpty())
 389                 {
 390                         CString msg;
 391                         msg.FormatMessage(IDS_PROC_SAVECONFIGFAILED, static_cast<LPCTSTR>(cmd), static_cast<LPCTSTR>(value));
 392                         CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_OK | MB_ICONERROR);
 393                         return FALSE;
 394                 }
 395                 return TRUE;
 396         }
 397
 398         if (g_Git.SetConfigValue(cmd, value, CONFIG_LOCAL))
 399         {
 400                 CString msg;
 401                 msg.FormatMessage(IDS_PROC_SAVECONFIGFAILED, static_cast<LPCTSTR>(cmd), static_cast<LPCTSTR>(value));
 402                 CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_OK | MB_ICONERROR);
 403                 return FALSE;
 404         }
 405         return TRUE;
 406 }
 407
 408 BOOL CSettingGitRemote::SaveGeneral(CString key, CString value)
 409 {
 410         if (value.IsEmpty())
 411         {
 412                 // don't check result code. it fails if the entry not exist
 413                 g_Git.UnsetConfigValue(key, CONFIG_LOCAL);
 414                 if (!g_Git.GetConfigValue(key).IsEmpty())
 415                 {
 416                         CString msg;
 417                         msg.FormatMessage(IDS_PROC_SAVECONFIGFAILED, static_cast<LPCTSTR>(key), static_cast<LPCTSTR>(value));
 418                         CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_OK | MB_ICONERROR);
 419                         return FALSE;
 420                 }
 421                 return TRUE;
 422         }
 423
 424         if (g_Git.SetConfigValue(key, value, CONFIG_LOCAL))
 425         {
 426                 CString msg;
 427                 msg.FormatMessage(IDS_PROC_SAVECONFIGFAILED, static_cast<LPCTSTR>(key), static_cast<LPCTSTR>(value));
 428                 CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_OK | MB_ICONERROR);
 429                 return FALSE;
 430         }
 431
 432         return TRUE;
 433 }
 434
 435 BOOL CSettingGitRemote::OnApply()
 436 {
 437         CWaitCursor wait;
 438         this->UpdateData();
 439
 440         if (m_ChangedMask & REMOTE_PUSHDEFAULT)
 441         {
 442                 if (!m_strRemote.Trim().IsEmpty() && m_bPushDefault)
 443                 {
 444                         if (!SaveGeneral(L"remote.pushdefault", m_strRemote.Trim()))
 445                                 return FALSE;
 446                 }
 447                 if (!m_bPushDefault)
 448                 {
 449                         if (!SaveGeneral(L"remote.pushdefault", L""))
 450                                 return FALSE;
 451                 }
 452
 453                 m_ChangedMask &= ~REMOTE_PUSHDEFAULT;
 454         }
 455
 456         if (m_ChangedMask & REMOTE_PRUNEALL)
 457         {
 458                 if (!SaveGeneral(L"fetch.prune", m_bPruneAll == TRUE ? L"true" : L"false"))
 459                         return FALSE;
 460                 m_ChangedMask &= ~REMOTE_PRUNEALL;
 461         }
 462
 463         if (m_ChangedMask && m_strRemote.Trim().IsEmpty())
 464         {
 465                 CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_REMOTEEMPTY, IDS_APPNAME, MB_OK | MB_ICONERROR);
 466                 return FALSE;
 467         }
 468
 469         if(m_ChangedMask & REMOTE_NAME)
 470         {
 471                 //Add Remote
 472                 if(m_strRemote.IsEmpty())
 473                 {
 474                         CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_REMOTEEMPTY, IDS_APPNAME, MB_OK | MB_ICONERROR);
 475                         return FALSE;
 476                 }
 477                 if(m_strUrl.IsEmpty())
 478                 {
 479                         CMessageBox::Show(GetSafeHwnd(), IDS_PROC_GITCONFIG_URLEMPTY, IDS_APPNAME, MB_OK | MB_ICONERROR);
 480                         return FALSE;
 481                 }
 482
 483                 if (m_ctrlRemoteList.GetCount() > 0)
 484                 {
 485                         // tagopt not --no-tags
 486                         if (m_ctrlTagOpt.GetCurSel() != 1)
 487                         {
 488                                 if (CMessageBox::ShowCheck(GetSafeHwnd(), IDS_PROC_GITCONFIG_ASKTAGOPT, IDS_APPNAME, MB_YESNO | MB_ICONQUESTION, L"TagOptNoTagsWarning", IDS_MSGBOX_DONOTSHOWAGAIN) == IDYES)
 489                                 {
 490                                         m_ctrlTagOpt.SetCurSel(1);
 491                                         m_ChangedMask |= REMOTE_TAGOPT;
 492                                 }
 493                         }
 494                 }
 495
 496                 m_strUrl.Replace(L'\\', L'/');
 497                 CString cmd,out;
 498                 cmd.Format(L"git.exe remote add \"%s\" \"%s\"", static_cast<LPCTSTR>(m_strRemote), static_cast<LPCTSTR>(m_strUrl));
 499                 if (g_Git.Run(cmd, &out, CP_UTF8))
 500                 {
 501                         CMessageBox::Show(GetSafeHwnd(), out, L"TorotiseGit", MB_OK | MB_ICONERROR);
 502                         return FALSE;
 503                 }
 504                 m_ChangedMask &= ~REMOTE_URL;
 505
 506                 m_ctrlRemoteList.SetCurSel(m_ctrlRemoteList.AddString(m_strRemote));
 507                 GetDlgItem(IDC_BUTTON_ADD)->EnableWindow(TRUE);
 508                 GetDlgItem(IDC_BUTTON_RENAME_REMOTE)->EnableWindow(TRUE);
 509                 if (!m_bNoFetch && CMessageBox::Show(GetSafeHwnd(), IDS_SETTINGS_FETCH_ADDEDREMOTE, IDS_APPNAME, MB_ICONQUESTION | MB_YESNO) == IDYES)
 510                         CCommonAppUtils::RunTortoiseGitProc(L"/command:fetch /path:\"" + g_Git.m_CurrentDir + L"\" /remote:\"" + m_strRemote + L'"');
 511         }
 512         if(m_ChangedMask & REMOTE_URL)
 513         {
 514                 m_strUrl.Replace(L'\\', L'/');
 515                 if (!Save(L"url", m_strUrl))
 516                         return FALSE;
 517         }
 518
 519         if(m_ChangedMask & REMOTE_PUTTYKEY)
 520         {
 521                 if (!Save(L"puttykeyfile", m_strPuttyKeyfile))
 522                         return FALSE;
 523         }
 524
 525         if (m_ChangedMask & REMOTE_TAGOPT)
 526         {
 527                 CString tagopt;
 528                 int index = m_ctrlTagOpt.GetCurSel();
 529                 if (index == 1)
 530                         tagopt = "--no-tags";
 531                 else if (index == 2)
 532                         tagopt = "--tags";
 533                 if (!Save(L"tagopt", tagopt))
 534                         return FALSE;
 535         }
 536
 537         if (m_ChangedMask & REMOTE_PRUNE)
 538         {
 539                 if (!Save(L"prune", m_bPrune == TRUE ? L"true" : m_bPrune == FALSE ? L"false" : L""))
 540                         return FALSE;
 541         }
 542
 543         if (m_ChangedMask & REMOTE_PUSHURL)
 544         {
 545                 m_strPushUrl.Replace(L'\\', L'/');
 546                 if (!Save(L"pushurl", m_strPushUrl))
 547                         return FALSE;
 548         }
 549
 550         SetModified(FALSE);
 551
 552         m_ChangedMask = 0;
 553         return ISettingsPropPage::OnApply();
 554 }
 555
 556 void CleanupSyncRemotes(const CString& remote)
 557 {
 558         CString workingDir = g_Git.m_CurrentDir;
 559         workingDir.Replace(L':', L'_');
 560         CHistoryCombo::RemoveEntryFromHistory(L"Software\\TortoiseGit\\History\\SyncURL\\" + workingDir, L"url", remote);
 561 }
 562
 563 void CSettingGitRemote::OnBnClickedButtonRemove()
 564 {
 565         int index = m_ctrlRemoteList.GetCurSel();
 566         if(index>=0)
 567         {
 568                 CString str;
 569                 m_ctrlRemoteList.GetText(index,str);
 570                 CString msg;
 571                 msg.Format(IDS_WARN_REMOVE, static_cast<LPCTSTR>(str));
 572                 if (CMessageBox::Show(GetSafeHwnd(), msg, L"TortoiseGit", MB_YESNO | MB_ICONQUESTION) == IDYES)
 573                 {
 574                         CString cmd,out;
 575                         cmd.Format(L"git.exe remote rm %s", static_cast<LPCTSTR>(str));
 576                         if (g_Git.Run(cmd, &out, CP_UTF8))
 577                         {
 578                                 CMessageBox::Show(GetSafeHwnd(), out, L"TortoiseGit", MB_OK | MB_ICONERROR);
 579                                 return;
 580                         }
 581
 582                         CleanupSyncRemotes(str);
 583                         m_ctrlRemoteList.DeleteString(index);
 584                         OnLbnSelchangeListRemote();
 585                 }
 586         }
 587 }
 588
 589 void CSettingGitRemote::OnBnClickedButtonRenameRemote()
 590 {
 591         int sel = m_ctrlRemoteList.GetCurSel();
 592         if (sel >= 0)
 593         {
 594                 CString oldRemote, newRemote;
 595                 m_ctrlRemoteList.GetText(sel, oldRemote);
 596                 GetDlgItem(IDC_EDIT_REMOTE)->GetWindowText(newRemote);
 597                 CString cmd, out;
 598                 cmd.Format(L"git.exe remote rename %s %s", static_cast<LPCTSTR>(oldRemote), static_cast<LPCTSTR>(newRemote));
 599                 if (g_Git.Run(cmd, &out, CP_UTF8))
 600                 {
 601                         CMessageBox::Show(GetSafeHwnd(), out, L"TortoiseGit", MB_OK | MB_ICONERROR);
 602                         return;
 603                 }
 604
 605                 CleanupSyncRemotes(oldRemote);
 606                 m_ctrlRemoteList.DeleteString(sel);
 607                 m_ctrlRemoteList.SetCurSel(m_ctrlRemoteList.AddString(newRemote));
 608                 m_ChangedMask &= ~REMOTE_NAME;
 609                 if (!m_ChangedMask)
 610                         this->SetModified(FALSE);
 611         }
 612 }