dsdb-acl: attr is not optional to acl_check_access_on_attribute()
[Samba/gebeck_regimport.git] / source4 / dsdb / samdb / ldb_modules / objectclass_attrs.c
blob316dcf8c14ba19687a9adc87215245ec55f4beee
1 /*
2 ldb database library
4 Copyright (C) Simo Sorce 2006-2008
5 Copyright (C) Andrew Bartlett <abartlet@samba.org> 2005-2009
6 Copyright (C) Stefan Metzmacher 2009
7 Copyright (C) Matthias Dieter Wallnöfer 2010
9 This program is free software; you can redistribute it and/or modify
10 it under the terms of the GNU General Public License as published by
11 the Free Software Foundation; either version 3 of the License, or
12 (at your option) any later version.
14 This program is distributed in the hope that it will be useful,
15 but WITHOUT ANY WARRANTY; without even the implied warranty of
16 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 GNU General Public License for more details.
19 You should have received a copy of the GNU Lesser General Public
20 License along with this library; if not, see <http://www.gnu.org/licenses/>.
24 * Name: ldb
26 * Component: objectclass attribute checking module
28 * Description: this checks the attributes on a directory entry (if they're
29 * allowed, if the syntax is correct, if mandatory ones are missing,
30 * denies the deletion of mandatory ones...). The module contains portions
31 * of the "objectclass" and the "validate_update" LDB module.
33 * Author: Matthias Dieter Wallnöfer
36 #include "includes.h"
37 #include "ldb_module.h"
38 #include "dsdb/samdb/samdb.h"
40 struct oc_context {
42 struct ldb_module *module;
43 struct ldb_request *req;
44 const struct dsdb_schema *schema;
46 struct ldb_message *msg;
48 struct ldb_reply *search_res;
49 struct ldb_reply *mod_ares;
52 static struct oc_context *oc_init_context(struct ldb_module *module,
53 struct ldb_request *req)
55 struct ldb_context *ldb;
56 struct oc_context *ac;
58 ldb = ldb_module_get_ctx(module);
60 ac = talloc_zero(req, struct oc_context);
61 if (ac == NULL) {
62 ldb_oom(ldb);
63 return NULL;
66 ac->module = module;
67 ac->req = req;
68 ac->schema = dsdb_get_schema(ldb, ac);
70 return ac;
73 static int oc_op_callback(struct ldb_request *req, struct ldb_reply *ares);
76 * Checks the correctness of the "dSHeuristics" attribute as described in both
77 * MS-ADTS 7.1.1.2.4.1.2 dSHeuristics and MS-ADTS 3.1.1.5.3.2 Constraints
79 static int oc_validate_dsheuristics(struct ldb_message_element *el)
81 if (el->num_values > 0) {
82 if ((el->values[0].length >= DS_HR_NINETIETH_CHAR) &&
83 (el->values[0].data[DS_HR_NINETIETH_CHAR-1] != '9')) {
84 return LDB_ERR_CONSTRAINT_VIOLATION;
86 if ((el->values[0].length >= DS_HR_EIGHTIETH_CHAR) &&
87 (el->values[0].data[DS_HR_EIGHTIETH_CHAR-1] != '8')) {
88 return LDB_ERR_CONSTRAINT_VIOLATION;
90 if ((el->values[0].length >= DS_HR_SEVENTIETH_CHAR) &&
91 (el->values[0].data[DS_HR_SEVENTIETH_CHAR-1] != '7')) {
92 return LDB_ERR_CONSTRAINT_VIOLATION;
94 if ((el->values[0].length >= DS_HR_SIXTIETH_CHAR) &&
95 (el->values[0].data[DS_HR_SIXTIETH_CHAR-1] != '6')) {
96 return LDB_ERR_CONSTRAINT_VIOLATION;
98 if ((el->values[0].length >= DS_HR_FIFTIETH_CHAR) &&
99 (el->values[0].data[DS_HR_FIFTIETH_CHAR-1] != '5')) {
100 return LDB_ERR_CONSTRAINT_VIOLATION;
102 if ((el->values[0].length >= DS_HR_FOURTIETH_CHAR) &&
103 (el->values[0].data[DS_HR_FOURTIETH_CHAR-1] != '4')) {
104 return LDB_ERR_CONSTRAINT_VIOLATION;
106 if ((el->values[0].length >= DS_HR_THIRTIETH_CHAR) &&
107 (el->values[0].data[DS_HR_THIRTIETH_CHAR-1] != '3')) {
108 return LDB_ERR_CONSTRAINT_VIOLATION;
110 if ((el->values[0].length >= DS_HR_TWENTIETH_CHAR) &&
111 (el->values[0].data[DS_HR_TWENTIETH_CHAR-1] != '2')) {
112 return LDB_ERR_CONSTRAINT_VIOLATION;
114 if ((el->values[0].length >= DS_HR_TENTH_CHAR) &&
115 (el->values[0].data[DS_HR_TENTH_CHAR-1] != '1')) {
116 return LDB_ERR_CONSTRAINT_VIOLATION;
120 return LDB_SUCCESS;
124 auto normalise values on input
126 static int oc_auto_normalise(struct ldb_context *ldb, const struct dsdb_attribute *attr,
127 struct ldb_message *msg, struct ldb_message_element *el)
129 int i;
130 bool values_copied = false;
132 for (i=0; i<el->num_values; i++) {
133 struct ldb_val v;
134 int ret;
135 ret = attr->ldb_schema_attribute->syntax->canonicalise_fn(ldb, el->values, &el->values[i], &v);
136 if (ret != LDB_SUCCESS) {
137 return ret;
139 if (data_blob_cmp(&v, &el->values[i]) == 0) {
140 /* no need to replace it */
141 talloc_free(v.data);
142 continue;
145 /* we need to copy the values array on the first change */
146 if (!values_copied) {
147 struct ldb_val *v2;
148 v2 = talloc_array(msg->elements, struct ldb_val, el->num_values);
149 if (v2 == NULL) {
150 return ldb_oom(ldb);
152 memcpy(v2, el->values, sizeof(struct ldb_val) * el->num_values);
153 el->values = v2;
154 values_copied = true;
157 el->values[i] = v;
159 return LDB_SUCCESS;
162 static int attr_handler(struct oc_context *ac)
164 struct ldb_context *ldb;
165 struct ldb_message *msg;
166 struct ldb_request *child_req;
167 const struct dsdb_attribute *attr;
168 unsigned int i;
169 int ret;
170 WERROR werr;
171 struct dsdb_syntax_ctx syntax_ctx;
173 ldb = ldb_module_get_ctx(ac->module);
175 if (ac->req->operation == LDB_ADD) {
176 msg = ldb_msg_copy_shallow(ac, ac->req->op.add.message);
177 } else {
178 msg = ldb_msg_copy_shallow(ac, ac->req->op.mod.message);
180 if (msg == NULL) {
181 return ldb_oom(ldb);
183 ac->msg = msg;
185 /* initialize syntax checking context */
186 dsdb_syntax_ctx_init(&syntax_ctx, ldb, ac->schema);
188 /* Check if attributes exist in the schema, if the values match,
189 * if they're not operational and fix the names to the match the schema
190 * case */
191 for (i = 0; i < msg->num_elements; i++) {
192 attr = dsdb_attribute_by_lDAPDisplayName(ac->schema,
193 msg->elements[i].name);
194 if (attr == NULL) {
195 if (ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK) &&
196 ac->req->operation != LDB_ADD) {
197 /* we allow this for dbcheck to fix
198 broken attributes */
199 goto no_attribute;
201 ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' was not found in the schema!",
202 msg->elements[i].name,
203 ldb_dn_get_linearized(msg->dn));
204 return LDB_ERR_NO_SUCH_ATTRIBUTE;
207 if ((attr->linkID & 1) == 1 &&
208 !ldb_request_get_control(ac->req, LDB_CONTROL_RELAX_OID) &&
209 !ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
210 /* Odd is for the target. Illegal to modify */
211 ldb_asprintf_errstring(ldb,
212 "objectclass_attrs: attribute '%s' on entry '%s' must not be modified directly, it is a linked attribute",
213 msg->elements[i].name,
214 ldb_dn_get_linearized(msg->dn));
215 return LDB_ERR_UNWILLING_TO_PERFORM;
218 if (!(msg->elements[i].flags & LDB_FLAG_INTERNAL_DISABLE_VALIDATION)) {
219 werr = attr->syntax->validate_ldb(&syntax_ctx, attr,
220 &msg->elements[i]);
221 if (!W_ERROR_IS_OK(werr) &&
222 !ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
223 ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' contains at least one invalid value!",
224 msg->elements[i].name,
225 ldb_dn_get_linearized(msg->dn));
226 return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
230 if ((attr->systemFlags & DS_FLAG_ATTR_IS_CONSTRUCTED) != 0) {
231 ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' is constructed!",
232 msg->elements[i].name,
233 ldb_dn_get_linearized(msg->dn));
234 if (ac->req->operation == LDB_ADD) {
235 return LDB_ERR_UNDEFINED_ATTRIBUTE_TYPE;
236 } else {
237 return LDB_ERR_CONSTRAINT_VIOLATION;
241 /* "dSHeuristics" syntax check */
242 if (ldb_attr_cmp(attr->lDAPDisplayName, "dSHeuristics") == 0) {
243 ret = oc_validate_dsheuristics(&(msg->elements[i]));
244 if (ret != LDB_SUCCESS) {
245 return ret;
249 /* auto normalise some attribute values */
250 if (attr->syntax->auto_normalise) {
251 ret = oc_auto_normalise(ldb, attr, msg, &msg->elements[i]);
252 if (ret != LDB_SUCCESS) {
253 return ret;
257 /* Substitute the attribute name to match in case */
258 msg->elements[i].name = attr->lDAPDisplayName;
261 no_attribute:
262 if (ac->req->operation == LDB_ADD) {
263 ret = ldb_build_add_req(&child_req, ldb, ac,
264 msg, ac->req->controls,
265 ac, oc_op_callback, ac->req);
266 LDB_REQ_SET_LOCATION(child_req);
267 } else {
268 ret = ldb_build_mod_req(&child_req, ldb, ac,
269 msg, ac->req->controls,
270 ac, oc_op_callback, ac->req);
271 LDB_REQ_SET_LOCATION(child_req);
273 if (ret != LDB_SUCCESS) {
274 return ret;
277 return ldb_next_request(ac->module, child_req);
281 these are attributes which are left over from old ways of doing
282 things in ldb, and are harmless
284 static const char *harmless_attrs[] = { "parentGUID", NULL };
286 static int attr_handler2(struct oc_context *ac)
288 struct ldb_context *ldb;
289 struct ldb_message_element *oc_element;
290 struct ldb_message *msg;
291 const char **must_contain, **may_contain, **found_must_contain;
292 /* There exists a hardcoded delete-protected attributes list in AD */
293 const char *del_prot_attributes[] = { "nTSecurityDescriptor",
294 "objectSid", "sAMAccountType", "sAMAccountName", "groupType",
295 "primaryGroupID", "userAccountControl", "accountExpires",
296 "badPasswordTime", "badPwdCount", "codePage", "countryCode",
297 "lastLogoff", "lastLogon", "logonCount", "pwdLastSet", NULL },
298 **l;
299 const struct dsdb_attribute *attr;
300 unsigned int i;
301 bool found;
302 bool isSchemaAttr = false;
304 ldb = ldb_module_get_ctx(ac->module);
306 if (ac->search_res == NULL) {
307 return ldb_operr(ldb);
310 /* We rely here on the preceeding "objectclass" LDB module which did
311 * already fix up the objectclass list (inheritance, order...). */
312 oc_element = ldb_msg_find_element(ac->search_res->message,
313 "objectClass");
314 if (oc_element == NULL) {
315 return ldb_operr(ldb);
318 /* LSA-specific object classes are not allowed to be created over LDAP,
319 * so we need to tell if this connection is internal (trusted) or not
320 * (untrusted).
322 * Hongwei Sun from Microsoft explains:
323 * The constraint in 3.1.1.5.2.2 MS-ADTS means that LSA objects cannot
324 * be added or modified through the LDAP interface, instead they can
325 * only be handled through LSA Policy API. This is also explained in
326 * 7.1.6.9.7 MS-ADTS as follows:
327 * "Despite being replicated normally between peer DCs in a domain,
328 * the process of creating or manipulating TDOs is specifically
329 * restricted to the LSA Policy APIs, as detailed in [MS-LSAD] section
330 * 3.1.1.5. Unlike other objects in the DS, TDOs may not be created or
331 * manipulated by client machines over the LDAPv3 transport."
333 for (i = 0; i < oc_element->num_values; i++) {
334 char * attname = (char *)oc_element->values[i].data;
335 if (ldb_req_is_untrusted(ac->req)) {
336 if (strcmp(attname, "secret") == 0 ||
337 strcmp(attname, "trustedDomain") == 0) {
338 ldb_asprintf_errstring(ldb, "objectclass_attrs: LSA objectclasses (entry '%s') cannot be created or changed over LDAP!",
339 ldb_dn_get_linearized(ac->search_res->message->dn));
340 return LDB_ERR_UNWILLING_TO_PERFORM;
343 if (strcmp(attname, "attributeSchema") == 0) {
344 isSchemaAttr = true;
348 must_contain = dsdb_full_attribute_list(ac, ac->schema, oc_element,
349 DSDB_SCHEMA_ALL_MUST);
350 may_contain = dsdb_full_attribute_list(ac, ac->schema, oc_element,
351 DSDB_SCHEMA_ALL_MAY);
352 found_must_contain = const_str_list(str_list_copy(ac, must_contain));
353 if ((must_contain == NULL) || (may_contain == NULL)
354 || (found_must_contain == NULL)) {
355 return ldb_operr(ldb);
358 /* Check the delete-protected attributes list */
359 msg = ac->search_res->message;
360 for (l = del_prot_attributes; *l != NULL; l++) {
361 struct ldb_message_element *el;
363 el = ldb_msg_find_element(ac->msg, *l);
364 if (el == NULL) {
366 * It was not specified in the add or modify,
367 * so it doesn't need to be in the stored record
369 continue;
372 found = str_list_check_ci(must_contain, *l);
373 if (!found) {
374 found = str_list_check_ci(may_contain, *l);
376 if (found && (ldb_msg_find_element(msg, *l) == NULL)) {
377 ldb_asprintf_errstring(ldb, "objectclass_attrs: delete protected attribute '%s' on entry '%s' missing!",
379 ldb_dn_get_linearized(msg->dn));
380 return LDB_ERR_UNWILLING_TO_PERFORM;
384 /* Check if all specified attributes are valid in the given
385 * objectclasses and if they meet additional schema restrictions. */
386 for (i = 0; i < msg->num_elements; i++) {
387 attr = dsdb_attribute_by_lDAPDisplayName(ac->schema,
388 msg->elements[i].name);
389 if (attr == NULL) {
390 if (ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
391 /* allow this to make it possible for dbcheck
392 to remove bad attributes */
393 continue;
395 return ldb_operr(ldb);
398 /* We can use "str_list_check" with "strcmp" here since the
399 * attribute information from the schema are always equal
400 * up-down-cased. */
401 found = str_list_check(must_contain, attr->lDAPDisplayName);
402 if (found) {
403 str_list_remove(found_must_contain, attr->lDAPDisplayName);
404 } else {
405 found = str_list_check(may_contain, attr->lDAPDisplayName);
407 if (!found) {
408 found = str_list_check(harmless_attrs, attr->lDAPDisplayName);
410 if (!found) {
411 /* we allow this for dbcheck to fix the rest of this broken entry */
412 if (!ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK) ||
413 ac->req->operation == LDB_ADD) {
414 ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' does not exist in the specified objectclasses!",
415 msg->elements[i].name,
416 ldb_dn_get_linearized(msg->dn));
417 return LDB_ERR_OBJECT_CLASS_VIOLATION;
422 if (found_must_contain[0] != NULL &&
423 ldb_msg_check_string_attribute(msg, "isDeleted", "TRUE") == 0) {
424 ldb_asprintf_errstring(ldb, "objectclass_attrs: at least one mandatory attribute ('%s') on entry '%s' wasn't specified!",
425 found_must_contain[0],
426 ldb_dn_get_linearized(msg->dn));
427 return LDB_ERR_OBJECT_CLASS_VIOLATION;
430 if (isSchemaAttr) {
431 /* Before really adding an attribute in the database,
432 * let's check that we can translate it into a dbsd_attribute and
433 * that we can find a valid syntax object.
434 * If not it's better to reject this attribute than not be able
435 * to start samba next time due to schema being unloadable.
437 struct dsdb_attribute *att = talloc(ac, struct dsdb_attribute);
438 const struct dsdb_syntax *attrSyntax;
439 WERROR status;
441 status= dsdb_attribute_from_ldb(ac->schema, msg, att);
442 if (!W_ERROR_IS_OK(status)) {
443 ldb_set_errstring(ldb,
444 "objectclass: failed to translate the schemaAttribute to a dsdb_attribute");
445 return LDB_ERR_UNWILLING_TO_PERFORM;
448 attrSyntax = dsdb_syntax_for_attribute(att);
449 if (!attrSyntax) {
450 ldb_set_errstring(ldb,
451 "objectclass: unknown attribute syntax");
452 return LDB_ERR_UNWILLING_TO_PERFORM;
455 return ldb_module_done(ac->req, ac->mod_ares->controls,
456 ac->mod_ares->response, LDB_SUCCESS);
459 static int get_search_callback(struct ldb_request *req, struct ldb_reply *ares)
461 struct ldb_context *ldb;
462 struct oc_context *ac;
463 int ret;
465 ac = talloc_get_type(req->context, struct oc_context);
466 ldb = ldb_module_get_ctx(ac->module);
468 if (!ares) {
469 return ldb_module_done(ac->req, NULL, NULL,
470 LDB_ERR_OPERATIONS_ERROR);
472 if (ares->error != LDB_SUCCESS) {
473 return ldb_module_done(ac->req, ares->controls,
474 ares->response, ares->error);
477 ldb_reset_err_string(ldb);
479 switch (ares->type) {
480 case LDB_REPLY_ENTRY:
481 if (ac->search_res != NULL) {
482 ldb_set_errstring(ldb, "Too many results");
483 talloc_free(ares);
484 return ldb_module_done(ac->req, NULL, NULL,
485 LDB_ERR_OPERATIONS_ERROR);
488 ac->search_res = talloc_steal(ac, ares);
489 break;
491 case LDB_REPLY_REFERRAL:
492 /* ignore */
493 talloc_free(ares);
494 break;
496 case LDB_REPLY_DONE:
497 talloc_free(ares);
498 ret = attr_handler2(ac);
499 if (ret != LDB_SUCCESS) {
500 return ldb_module_done(ac->req, NULL, NULL, ret);
502 break;
505 return LDB_SUCCESS;
508 static int oc_op_callback(struct ldb_request *req, struct ldb_reply *ares)
510 struct oc_context *ac;
511 struct ldb_context *ldb;
512 struct ldb_request *search_req;
513 struct ldb_dn *base_dn;
514 int ret;
516 ac = talloc_get_type(req->context, struct oc_context);
517 ldb = ldb_module_get_ctx(ac->module);
519 if (!ares) {
520 return ldb_module_done(ac->req, NULL, NULL,
521 LDB_ERR_OPERATIONS_ERROR);
524 if (ares->type == LDB_REPLY_REFERRAL) {
525 return ldb_module_send_referral(ac->req, ares->referral);
528 if (ares->error != LDB_SUCCESS) {
529 return ldb_module_done(ac->req, ares->controls, ares->response,
530 ares->error);
533 if (ares->type != LDB_REPLY_DONE) {
534 talloc_free(ares);
535 return ldb_module_done(ac->req, NULL, NULL,
536 LDB_ERR_OPERATIONS_ERROR);
539 ac->search_res = NULL;
540 ac->mod_ares = talloc_steal(ac, ares);
542 /* This looks up all attributes of our just added/modified entry */
543 base_dn = ac->req->operation == LDB_ADD ? ac->req->op.add.message->dn
544 : ac->req->op.mod.message->dn;
545 ret = ldb_build_search_req(&search_req, ldb, ac, base_dn,
546 LDB_SCOPE_BASE, "(objectClass=*)",
547 NULL, NULL, ac,
548 get_search_callback, ac->req);
549 LDB_REQ_SET_LOCATION(search_req);
550 if (ret != LDB_SUCCESS) {
551 return ldb_module_done(ac->req, NULL, NULL, ret);
554 ret = ldb_request_add_control(search_req, LDB_CONTROL_SHOW_RECYCLED_OID,
555 true, NULL);
556 if (ret != LDB_SUCCESS) {
557 return ldb_module_done(ac->req, NULL, NULL, ret);
560 ret = ldb_next_request(ac->module, search_req);
561 if (ret != LDB_SUCCESS) {
562 return ldb_module_done(ac->req, NULL, NULL, ret);
565 /* "ldb_module_done" isn't called here since we need to do additional
566 * checks. It is called at the end of "attr_handler2". */
567 return LDB_SUCCESS;
570 static int objectclass_attrs_add(struct ldb_module *module,
571 struct ldb_request *req)
573 struct ldb_context *ldb;
574 struct oc_context *ac;
576 ldb = ldb_module_get_ctx(module);
578 ldb_debug(ldb, LDB_DEBUG_TRACE, "objectclass_attrs_add\n");
580 /* do not manipulate our control entries */
581 if (ldb_dn_is_special(req->op.add.message->dn)) {
582 return ldb_next_request(module, req);
585 ac = oc_init_context(module, req);
586 if (ac == NULL) {
587 return ldb_operr(ldb);
590 /* without schema, there isn't much to do here */
591 if (ac->schema == NULL) {
592 talloc_free(ac);
593 return ldb_next_request(module, req);
596 return attr_handler(ac);
599 static int objectclass_attrs_modify(struct ldb_module *module,
600 struct ldb_request *req)
602 struct ldb_context *ldb;
603 struct ldb_control *sd_propagation_control;
604 int ret;
606 struct oc_context *ac;
608 ldb = ldb_module_get_ctx(module);
610 ldb_debug(ldb, LDB_DEBUG_TRACE, "objectclass_attrs_modify\n");
612 /* do not manipulate our control entries */
613 if (ldb_dn_is_special(req->op.mod.message->dn)) {
614 return ldb_next_request(module, req);
617 sd_propagation_control = ldb_request_get_control(req,
618 DSDB_CONTROL_SEC_DESC_PROPAGATION_OID);
619 if (sd_propagation_control != NULL) {
620 if (req->op.mod.message->num_elements != 1) {
621 return ldb_module_operr(module);
623 ret = strcmp(req->op.mod.message->elements[0].name,
624 "nTSecurityDescriptor");
625 if (ret != 0) {
626 return ldb_module_operr(module);
629 return ldb_next_request(module, req);
632 ac = oc_init_context(module, req);
633 if (ac == NULL) {
634 return ldb_operr(ldb);
637 /* without schema, there isn't much to do here */
638 if (ac->schema == NULL) {
639 talloc_free(ac);
640 return ldb_next_request(module, req);
643 return attr_handler(ac);
646 static const struct ldb_module_ops ldb_objectclass_attrs_module_ops = {
647 .name = "objectclass_attrs",
648 .add = objectclass_attrs_add,
649 .modify = objectclass_attrs_modify
652 int ldb_objectclass_attrs_module_init(const char *version)
654 LDB_MODULE_CHECK_VERSION(version);
655 return ldb_register_module(&ldb_objectclass_attrs_module_ops);