?  search:
summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
blame | history | raw | HEAD
dsdb-acl: remove unused variable
[Samba/gebeck_regimport.git] / source4 / torture / raw / acls.c
blob0342bf9b5d9e6936f571ceeb1d9353b0db989abb
1 /*
2 Unix SMB/CIFS implementation.
3
4 test security descriptor operations
5
6 Copyright (C) Andrew Tridgell 2004
7
8 This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 3 of the License, or
11 (at your option) any later version.
12
13 This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details.
17
18 You should have received a copy of the GNU General Public License
19 along with this program. If not, see <http://www.gnu.org/licenses/>.
20 */
21
22 #include "includes.h"
23 #include "torture/torture.h"
24 #include "libcli/raw/libcliraw.h"
25 #include "libcli/libcli.h"
26 #include "librpc/gen_ndr/lsa.h"
27 #include "libcli/util/clilsa.h"
28 #include "libcli/security/security.h"
29 #include "torture/util.h"
30 #include "librpc/gen_ndr/ndr_security.h"
31 #include "torture/raw/proto.h"
32
33 #define BASEDIR "\\testsd"
34
35 #define CHECK_STATUS(status, correct) do { \
36 if (!NT_STATUS_EQUAL(status, correct)) { \
37 ret = false; \
38 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect status %s - should be %s\n", \
39 __location__, nt_errstr(status), nt_errstr(correct)); \
40 goto done; \
41 }} while (0)
42
43 #define FAIL_UNLESS(__cond) \
44 do { \
45 if (__cond) {} else { \
46 ret = false; \
47 torture_result(tctx, TORTURE_FAIL, "%s) condition violated: %s\n", \
48 __location__, #__cond); \
49 goto done; \
50 } \
51 } while(0)
52
53 #define CHECK_SECURITY_DESCRIPTOR(_sd1, _sd2) do { \
54 if (!security_descriptor_equal(_sd1, _sd2)) { \
55 torture_warning(tctx, "%s: security descriptors don't match!\n", __location__); \
56 torture_warning(tctx, "got:\n"); \
57 NDR_PRINT_DEBUG(security_descriptor, _sd1); \
58 torture_warning(tctx, "expected:\n"); \
59 NDR_PRINT_DEBUG(security_descriptor, _sd2); \
60 ret = false; \
61 } \
62 } while (0)
63
64 /*
65 * Helper function to verify a security descriptor, by querying
66 * and comparing against the passed in sd.
67 * Copied to smb2_util_verify_sd() for SMB2.
68 */
69 static bool verify_sd(TALLOC_CTX *tctx, struct smbcli_state *cli,
70 int fnum, struct security_descriptor *sd)
71 {
72 NTSTATUS status;
73 bool ret = true;
74 union smb_fileinfo q = {};
75
76 if (sd) {
77 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
78 q.query_secdesc.in.file.fnum = fnum;
79 q.query_secdesc.in.secinfo_flags =
80 SECINFO_OWNER |
81 SECINFO_GROUP |
82 SECINFO_DACL;
83 status = smb_raw_fileinfo(cli->tree, tctx, &q);
84 CHECK_STATUS(status, NT_STATUS_OK);
85
86 /* More work is needed if we're going to check this bit. */
87 sd->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
88
89 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
90 }
91
92 done:
93 return ret;
94 }
95
96 /*
97 * Helper function to verify attributes, by querying
98 * and comparing against the passed attrib.
99 * Copied to smb2_util_verify_attrib() for SMB2.
100 */
101 static bool verify_attrib(TALLOC_CTX *tctx, struct smbcli_state *cli,
102 int fnum, uint32_t attrib)
103 {
104 NTSTATUS status;
105 bool ret = true;
106 union smb_fileinfo q2 = {};
107
108 if (attrib) {
109 q2.standard.level = RAW_FILEINFO_STANDARD;
110 q2.standard.in.file.fnum = fnum;
111 status = smb_raw_fileinfo(cli->tree, tctx, &q2);
112 CHECK_STATUS(status, NT_STATUS_OK);
113
114 q2.standard.out.attrib &= ~FILE_ATTRIBUTE_ARCHIVE;
115
116 if (q2.standard.out.attrib != attrib) {
117 torture_warning(tctx, "%s: attributes don't match! "
118 "got %x, expected %x\n", __location__,
119 (uint32_t)q2.standard.out.attrib,
120 (uint32_t)attrib);
121 ret = false;
122 }
123 }
124
125 done:
126 return ret;
127 }
128
129 /**
130 * Test setting and removing a DACL.
131 * Test copied to torture_smb2_setinfo() for SMB2.
132 */
133 static bool test_sd(struct torture_context *tctx, struct smbcli_state *cli)
134 {
135 NTSTATUS status;
136 union smb_open io;
137 const char *fname = BASEDIR "\\sd.txt";
138 bool ret = true;
139 int fnum = -1;
140 union smb_fileinfo q;
141 union smb_setfileinfo set;
142 struct security_ace ace;
143 struct security_descriptor *sd;
144 struct dom_sid *test_sid;
145
146 if (!torture_setup_dir(cli, BASEDIR))
147 return false;
148
149 torture_comment(tctx, "TESTING SETFILEINFO EA_SET\n");
150
151 io.generic.level = RAW_OPEN_NTCREATEX;
152 io.ntcreatex.in.root_fid.fnum = 0;
153 io.ntcreatex.in.flags = 0;
154 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
155 io.ntcreatex.in.create_options = 0;
156 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
157 io.ntcreatex.in.share_access =
158 NTCREATEX_SHARE_ACCESS_READ |
159 NTCREATEX_SHARE_ACCESS_WRITE;
160 io.ntcreatex.in.alloc_size = 0;
161 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
162 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
163 io.ntcreatex.in.security_flags = 0;
164 io.ntcreatex.in.fname = fname;
165 status = smb_raw_open(cli->tree, tctx, &io);
166 CHECK_STATUS(status, NT_STATUS_OK);
167 fnum = io.ntcreatex.out.file.fnum;
168
169 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
170 q.query_secdesc.in.file.fnum = fnum;
171 q.query_secdesc.in.secinfo_flags =
172 SECINFO_OWNER |
173 SECINFO_GROUP |
174 SECINFO_DACL;
175 status = smb_raw_fileinfo(cli->tree, tctx, &q);
176 CHECK_STATUS(status, NT_STATUS_OK);
177 sd = q.query_secdesc.out.sd;
178
179 torture_comment(tctx, "add a new ACE to the DACL\n");
180
181 test_sid = dom_sid_parse_talloc(tctx, SID_NT_AUTHENTICATED_USERS);
182
183 ace.type = SEC_ACE_TYPE_ACCESS_ALLOWED;
184 ace.flags = 0;
185 ace.access_mask = SEC_STD_ALL;
186 ace.trustee = *test_sid;
187
188 status = security_descriptor_dacl_add(sd, &ace);
189 CHECK_STATUS(status, NT_STATUS_OK);
190
191 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
192 set.set_secdesc.in.file.fnum = fnum;
193 set.set_secdesc.in.secinfo_flags = q.query_secdesc.in.secinfo_flags;
194 set.set_secdesc.in.sd = sd;
195
196 status = smb_raw_setfileinfo(cli->tree, &set);
197 CHECK_STATUS(status, NT_STATUS_OK);
198 FAIL_UNLESS(verify_sd(tctx, cli, fnum, sd));
199
200 torture_comment(tctx, "remove it again\n");
201
202 status = security_descriptor_dacl_del(sd, test_sid);
203 CHECK_STATUS(status, NT_STATUS_OK);
204
205 status = smb_raw_setfileinfo(cli->tree, &set);
206 CHECK_STATUS(status, NT_STATUS_OK);
207 FAIL_UNLESS(verify_sd(tctx, cli, fnum, sd));
208
209 done:
210 smbcli_close(cli->tree, fnum);
211 smb_raw_exit(cli->session);
212 smbcli_deltree(cli->tree, BASEDIR);
213
214 return ret;
215 }
216
217
218 /*
219 test using nttrans create to create a file with an initial acl set
220 Test copied to test_create_acl() for SMB2.
221 */
222 static bool test_nttrans_create_ext(struct torture_context *tctx,
223 struct smbcli_state *cli, bool test_dir)
224 {
225 NTSTATUS status;
226 union smb_open io;
227 const char *fname = BASEDIR "\\acl2.txt";
228 bool ret = true;
229 int fnum = -1;
230 union smb_fileinfo q = {};
231 struct security_ace ace;
232 struct security_descriptor *sd;
233 struct dom_sid *test_sid;
234 uint32_t attrib =
235 FILE_ATTRIBUTE_HIDDEN |
236 FILE_ATTRIBUTE_SYSTEM |
237 (test_dir ? FILE_ATTRIBUTE_DIRECTORY : 0);
238 NTSTATUS (*delete_func)(struct smbcli_tree *, const char *) =
239 test_dir ? smbcli_rmdir : smbcli_unlink;
240
241 if (!torture_setup_dir(cli, BASEDIR))
242 return false;
243
244 io.generic.level = RAW_OPEN_NTTRANS_CREATE;
245 io.ntcreatex.in.root_fid.fnum = 0;
246 io.ntcreatex.in.flags = 0;
247 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
248 io.ntcreatex.in.create_options =
249 test_dir ? NTCREATEX_OPTIONS_DIRECTORY : 0;
250 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
251 io.ntcreatex.in.share_access =
252 NTCREATEX_SHARE_ACCESS_READ |
253 NTCREATEX_SHARE_ACCESS_WRITE;
254 io.ntcreatex.in.alloc_size = 0;
255 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
256 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
257 io.ntcreatex.in.security_flags = 0;
258 io.ntcreatex.in.fname = fname;
259 io.ntcreatex.in.sec_desc = NULL;
260 io.ntcreatex.in.ea_list = NULL;
261
262 torture_comment(tctx, "basic create\n");
263
264 status = smb_raw_open(cli->tree, tctx, &io);
265 CHECK_STATUS(status, NT_STATUS_OK);
266 fnum = io.ntcreatex.out.file.fnum;
267
268 torture_comment(tctx, "querying ACL\n");
269
270 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
271 q.query_secdesc.in.file.fnum = fnum;
272 q.query_secdesc.in.secinfo_flags =
273 SECINFO_OWNER |
274 SECINFO_GROUP |
275 SECINFO_DACL;
276 status = smb_raw_fileinfo(cli->tree, tctx, &q);
277 CHECK_STATUS(status, NT_STATUS_OK);
278 sd = q.query_secdesc.out.sd;
279
280 status = smbcli_close(cli->tree, fnum);
281 CHECK_STATUS(status, NT_STATUS_OK);
282
283 status = delete_func(cli->tree, fname);
284 CHECK_STATUS(status, NT_STATUS_OK);
285
286 torture_comment(tctx, "adding a new ACE\n");
287 test_sid = dom_sid_parse_talloc(tctx, SID_NT_AUTHENTICATED_USERS);
288
289 ace.type = SEC_ACE_TYPE_ACCESS_ALLOWED;
290 ace.flags = 0;
291 ace.access_mask = SEC_STD_ALL;
292 ace.trustee = *test_sid;
293
294 status = security_descriptor_dacl_add(sd, &ace);
295 CHECK_STATUS(status, NT_STATUS_OK);
296
297 torture_comment(tctx, "creating with an initial ACL\n");
298
299 io.ntcreatex.in.sec_desc = sd;
300 status = smb_raw_open(cli->tree, tctx, &io);
301 CHECK_STATUS(status, NT_STATUS_OK);
302 fnum = io.ntcreatex.out.file.fnum;
303
304 FAIL_UNLESS(verify_sd(tctx, cli, fnum, sd));
305
306 status = smbcli_close(cli->tree, fnum);
307 CHECK_STATUS(status, NT_STATUS_OK);
308 status = delete_func(cli->tree, fname);
309 CHECK_STATUS(status, NT_STATUS_OK);
310
311 torture_comment(tctx, "creating with attributes\n");
312
313 io.ntcreatex.in.sec_desc = NULL;
314 io.ntcreatex.in.file_attr = attrib;
315 status = smb_raw_open(cli->tree, tctx, &io);
316 CHECK_STATUS(status, NT_STATUS_OK);
317 fnum = io.ntcreatex.out.file.fnum;
318
319 FAIL_UNLESS(verify_attrib(tctx, cli, fnum, attrib));
320
321 status = smbcli_close(cli->tree, fnum);
322 CHECK_STATUS(status, NT_STATUS_OK);
323
324 status = delete_func(cli->tree, fname);
325 CHECK_STATUS(status, NT_STATUS_OK);
326
327 torture_comment(tctx, "creating with attributes and ACL\n");
328
329 io.ntcreatex.in.sec_desc = sd;
330 io.ntcreatex.in.file_attr = attrib;
331 status = smb_raw_open(cli->tree, tctx, &io);
332 CHECK_STATUS(status, NT_STATUS_OK);
333 fnum = io.ntcreatex.out.file.fnum;
334
335 FAIL_UNLESS(verify_sd(tctx, cli, fnum, sd));
336 FAIL_UNLESS(verify_attrib(tctx, cli, fnum, attrib));
337
338 status = smbcli_close(cli->tree, fnum);
339 CHECK_STATUS(status, NT_STATUS_OK);
340 status = delete_func(cli->tree, fname);
341 CHECK_STATUS(status, NT_STATUS_OK);
342
343 torture_comment(tctx, "creating with attributes, ACL and owner\n");
344
345 sd = security_descriptor_dacl_create(tctx,
346 0, SID_WORLD, SID_BUILTIN_USERS,
347 SID_WORLD,
348 SEC_ACE_TYPE_ACCESS_ALLOWED,
349 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
350 0,
351 NULL);
352
353 io.ntcreatex.in.sec_desc = sd;
354 io.ntcreatex.in.file_attr = attrib;
355 status = smb_raw_open(cli->tree, tctx, &io);
356 CHECK_STATUS(status, NT_STATUS_OK);
357 fnum = io.ntcreatex.out.file.fnum;
358
359 FAIL_UNLESS(verify_sd(tctx, cli, fnum, sd));
360 FAIL_UNLESS(verify_attrib(tctx, cli, fnum, attrib));
361
362 status = smbcli_close(cli->tree, fnum);
363 CHECK_STATUS(status, NT_STATUS_OK);
364 status = delete_func(cli->tree, fname);
365 CHECK_STATUS(status, NT_STATUS_OK);
366
367 done:
368 smbcli_close(cli->tree, fnum);
369 smb_raw_exit(cli->session);
370 smbcli_deltree(cli->tree, BASEDIR);
371 return ret;
372 }
373
374 static bool test_nttrans_create_file(struct torture_context *tctx,
375 struct smbcli_state *cli)
376 {
377 torture_comment(tctx, "Testing nttrans create with sec_desc on files\n");
378
379 return test_nttrans_create_ext(tctx, cli, false);
380 }
381
382 static bool test_nttrans_create_dir(struct torture_context *tctx,
383 struct smbcli_state *cli)
384 {
385 torture_comment(tctx, "Testing nttrans create with sec_desc on directories\n");
386
387 return test_nttrans_create_ext(tctx, cli, true);
388 }
389
390 #define CHECK_ACCESS_FLAGS(_fnum, flags) do { \
391 union smb_fileinfo _q; \
392 _q.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION; \
393 _q.access_information.in.file.fnum = (_fnum); \
394 status = smb_raw_fileinfo(cli->tree, tctx, &_q); \
395 CHECK_STATUS(status, NT_STATUS_OK); \
396 if (_q.access_information.out.access_flags != (flags)) { \
397 ret = false; \
398 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
399 __location__, _q.access_information.out.access_flags, (flags)); \
400 goto done; \
401 } \
402 } while (0)
403
404 /*
405 test using NTTRANS CREATE to create a file with a null ACL set
406 Test copied to test_create_null_dacl() for SMB2.
407 */
408 static bool test_nttrans_create_null_dacl(struct torture_context *tctx,
409 struct smbcli_state *cli)
410 {
411 NTSTATUS status;
412 union smb_open io;
413 const char *fname = BASEDIR "\\nulldacl.txt";
414 bool ret = true;
415 int fnum = -1;
416 union smb_fileinfo q;
417 union smb_setfileinfo s;
418 struct security_descriptor *sd = security_descriptor_initialise(tctx);
419 struct security_acl dacl;
420
421 if (!torture_setup_dir(cli, BASEDIR))
422 return false;
423
424 torture_comment(tctx, "TESTING SEC_DESC WITH A NULL DACL\n");
425
426 io.generic.level = RAW_OPEN_NTTRANS_CREATE;
427 io.ntcreatex.in.root_fid.fnum = 0;
428 io.ntcreatex.in.flags = 0;
429 io.ntcreatex.in.access_mask = SEC_STD_READ_CONTROL | SEC_STD_WRITE_DAC
430 | SEC_STD_WRITE_OWNER;
431 io.ntcreatex.in.create_options = 0;
432 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
433 io.ntcreatex.in.share_access =
434 NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
435 io.ntcreatex.in.alloc_size = 0;
436 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
437 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
438 io.ntcreatex.in.security_flags = 0;
439 io.ntcreatex.in.fname = fname;
440 io.ntcreatex.in.sec_desc = sd;
441 io.ntcreatex.in.ea_list = NULL;
442
443 torture_comment(tctx, "creating a file with a empty sd\n");
444 status = smb_raw_open(cli->tree, tctx, &io);
445 CHECK_STATUS(status, NT_STATUS_OK);
446 fnum = io.ntcreatex.out.file.fnum;
447
448 torture_comment(tctx, "get the original sd\n");
449 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
450 q.query_secdesc.in.file.fnum = fnum;
451 q.query_secdesc.in.secinfo_flags =
452 SECINFO_OWNER |
453 SECINFO_GROUP |
454 SECINFO_DACL;
455 status = smb_raw_fileinfo(cli->tree, tctx, &q);
456 CHECK_STATUS(status, NT_STATUS_OK);
457
458 /*
459 * Testing the created DACL,
460 * the server should add the inherited DACL
461 * when SEC_DESC_DACL_PRESENT isn't specified
462 */
463 if (!(q.query_secdesc.out.sd->type & SEC_DESC_DACL_PRESENT)) {
464 ret = false;
465 torture_result(tctx, TORTURE_FAIL, "DACL_PRESENT flag not set by the server!\n");
466 goto done;
467 }
468 if (q.query_secdesc.out.sd->dacl == NULL) {
469 ret = false;
470 torture_result(tctx, TORTURE_FAIL, "no DACL has been created on the server!\n");
471 goto done;
472 }
473
474 torture_comment(tctx, "set NULL DACL\n");
475 sd->type |= SEC_DESC_DACL_PRESENT;
476
477 s.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
478 s.set_secdesc.in.file.fnum = fnum;
479 s.set_secdesc.in.secinfo_flags = SECINFO_DACL;
480 s.set_secdesc.in.sd = sd;
481 status = smb_raw_setfileinfo(cli->tree, &s);
482 CHECK_STATUS(status, NT_STATUS_OK);
483
484 torture_comment(tctx, "get the sd\n");
485 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
486 q.query_secdesc.in.file.fnum = fnum;
487 q.query_secdesc.in.secinfo_flags =
488 SECINFO_OWNER |
489 SECINFO_GROUP |
490 SECINFO_DACL;
491 status = smb_raw_fileinfo(cli->tree, tctx, &q);
492 CHECK_STATUS(status, NT_STATUS_OK);
493
494 /* Testing the modified DACL */
495 if (!(q.query_secdesc.out.sd->type & SEC_DESC_DACL_PRESENT)) {
496 ret = false;
497 torture_result(tctx, TORTURE_FAIL, "DACL_PRESENT flag not set by the server!\n");
498 goto done;
499 }
500 if (q.query_secdesc.out.sd->dacl != NULL) {
501 ret = false;
502 torture_result(tctx, TORTURE_FAIL, "DACL has been created on the server!\n");
503 goto done;
504 }
505
506 torture_comment(tctx, "try open for read control\n");
507 io.ntcreatex.in.access_mask = SEC_STD_READ_CONTROL;
508 status = smb_raw_open(cli->tree, tctx, &io);
509 CHECK_STATUS(status, NT_STATUS_OK);
510 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
511 SEC_STD_READ_CONTROL | SEC_FILE_READ_ATTRIBUTE);
512 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
513
514 torture_comment(tctx, "try open for write\n");
515 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
516 status = smb_raw_open(cli->tree, tctx, &io);
517 CHECK_STATUS(status, NT_STATUS_OK);
518 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
519 SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE);
520 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
521
522 torture_comment(tctx, "try open for read\n");
523 io.ntcreatex.in.access_mask = SEC_FILE_READ_DATA;
524 status = smb_raw_open(cli->tree, tctx, &io);
525 CHECK_STATUS(status, NT_STATUS_OK);
526 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
527 SEC_FILE_READ_DATA | SEC_FILE_READ_ATTRIBUTE);
528 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
529
530 torture_comment(tctx, "try open for generic write\n");
531 io.ntcreatex.in.access_mask = SEC_GENERIC_WRITE;
532 status = smb_raw_open(cli->tree, tctx, &io);
533 CHECK_STATUS(status, NT_STATUS_OK);
534 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
535 SEC_RIGHTS_FILE_WRITE | SEC_FILE_READ_ATTRIBUTE);
536 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
537
538 torture_comment(tctx, "try open for generic read\n");
539 io.ntcreatex.in.access_mask = SEC_GENERIC_READ;
540 status = smb_raw_open(cli->tree, tctx, &io);
541 CHECK_STATUS(status, NT_STATUS_OK);
542 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
543 SEC_RIGHTS_FILE_READ | SEC_FILE_READ_ATTRIBUTE);
544 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
545
546 torture_comment(tctx, "set DACL with 0 aces\n");
547 ZERO_STRUCT(dacl);
548 dacl.revision = SECURITY_ACL_REVISION_NT4;
549 dacl.num_aces = 0;
550 sd->dacl = &dacl;
551
552 s.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
553 s.set_secdesc.in.file.fnum = fnum;
554 s.set_secdesc.in.secinfo_flags = SECINFO_DACL;
555 s.set_secdesc.in.sd = sd;
556 status = smb_raw_setfileinfo(cli->tree, &s);
557 CHECK_STATUS(status, NT_STATUS_OK);
558
559 torture_comment(tctx, "get the sd\n");
560 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
561 q.query_secdesc.in.file.fnum = fnum;
562 q.query_secdesc.in.secinfo_flags =
563 SECINFO_OWNER |
564 SECINFO_GROUP |
565 SECINFO_DACL;
566 status = smb_raw_fileinfo(cli->tree, tctx, &q);
567 CHECK_STATUS(status, NT_STATUS_OK);
568
569 /* Testing the modified DACL */
570 if (!(q.query_secdesc.out.sd->type & SEC_DESC_DACL_PRESENT)) {
571 ret = false;
572 torture_result(tctx, TORTURE_FAIL, "DACL_PRESENT flag not set by the server!\n");
573 goto done;
574 }
575 if (q.query_secdesc.out.sd->dacl == NULL) {
576 ret = false;
577 torture_result(tctx, TORTURE_FAIL, "no DACL has been created on the server!\n");
578 goto done;
579 }
580 if (q.query_secdesc.out.sd->dacl->num_aces != 0) {
581 ret = false;
582 torture_result(tctx, TORTURE_FAIL, "DACL has %u aces!\n",
583 q.query_secdesc.out.sd->dacl->num_aces);
584 goto done;
585 }
586
587 torture_comment(tctx, "try open for read control\n");
588 io.ntcreatex.in.access_mask = SEC_STD_READ_CONTROL;
589 status = smb_raw_open(cli->tree, tctx, &io);
590 CHECK_STATUS(status, NT_STATUS_OK);
591 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
592 SEC_STD_READ_CONTROL | SEC_FILE_READ_ATTRIBUTE);
593 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
594
595 torture_comment(tctx, "try open for write => access_denied\n");
596 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
597 status = smb_raw_open(cli->tree, tctx, &io);
598 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
599
600 torture_comment(tctx, "try open for read => access_denied\n");
601 io.ntcreatex.in.access_mask = SEC_FILE_READ_DATA;
602 status = smb_raw_open(cli->tree, tctx, &io);
603 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
604
605 torture_comment(tctx, "try open for generic write => access_denied\n");
606 io.ntcreatex.in.access_mask = SEC_GENERIC_WRITE;
607 status = smb_raw_open(cli->tree, tctx, &io);
608 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
609
610 torture_comment(tctx, "try open for generic read => access_denied\n");
611 io.ntcreatex.in.access_mask = SEC_GENERIC_READ;
612 status = smb_raw_open(cli->tree, tctx, &io);
613 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
614
615 torture_comment(tctx, "set empty sd\n");
616 sd->type &= ~SEC_DESC_DACL_PRESENT;
617 sd->dacl = NULL;
618
619 s.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
620 s.set_secdesc.in.file.fnum = fnum;
621 s.set_secdesc.in.secinfo_flags = SECINFO_DACL;
622 s.set_secdesc.in.sd = sd;
623 status = smb_raw_setfileinfo(cli->tree, &s);
624 CHECK_STATUS(status, NT_STATUS_OK);
625
626 torture_comment(tctx, "get the sd\n");
627 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
628 q.query_secdesc.in.file.fnum = fnum;
629 q.query_secdesc.in.secinfo_flags =
630 SECINFO_OWNER |
631 SECINFO_GROUP |
632 SECINFO_DACL;
633 status = smb_raw_fileinfo(cli->tree, tctx, &q);
634 CHECK_STATUS(status, NT_STATUS_OK);
635
636 /* Testing the modified DACL */
637 if (!(q.query_secdesc.out.sd->type & SEC_DESC_DACL_PRESENT)) {
638 ret = false;
639 torture_result(tctx, TORTURE_FAIL, "DACL_PRESENT flag not set by the server!\n");
640 goto done;
641 }
642 if (q.query_secdesc.out.sd->dacl != NULL) {
643 ret = false;
644 torture_result(tctx, TORTURE_FAIL, "DACL has been created on the server!\n");
645 goto done;
646 }
647 done:
648 smbcli_close(cli->tree, fnum);
649 smb_raw_exit(cli->session);
650 smbcli_deltree(cli->tree, BASEDIR);
651 return ret;
652 }
653
654 /*
655 test the behaviour of the well known SID_CREATOR_OWNER sid, and some generic
656 mapping bits
657 Test copied to smb2/acls.c for SMB2.
658 */
659 static bool test_creator_sid(struct torture_context *tctx,
660 struct smbcli_state *cli)
661 {
662 NTSTATUS status;
663 union smb_open io;
664 const char *fname = BASEDIR "\\creator.txt";
665 bool ret = true;
666 int fnum = -1;
667 union smb_fileinfo q;
668 union smb_setfileinfo set;
669 struct security_descriptor *sd, *sd_orig, *sd2;
670 const char *owner_sid;
671
672 if (!torture_setup_dir(cli, BASEDIR))
673 return false;
674
675 torture_comment(tctx, "TESTING SID_CREATOR_OWNER\n");
676
677 io.generic.level = RAW_OPEN_NTCREATEX;
678 io.ntcreatex.in.root_fid.fnum = 0;
679 io.ntcreatex.in.flags = 0;
680 io.ntcreatex.in.access_mask = SEC_STD_READ_CONTROL | SEC_STD_WRITE_DAC | SEC_STD_WRITE_OWNER;
681 io.ntcreatex.in.create_options = 0;
682 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
683 io.ntcreatex.in.share_access =
684 NTCREATEX_SHARE_ACCESS_READ |
685 NTCREATEX_SHARE_ACCESS_WRITE;
686 io.ntcreatex.in.alloc_size = 0;
687 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
688 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
689 io.ntcreatex.in.security_flags = 0;
690 io.ntcreatex.in.fname = fname;
691 status = smb_raw_open(cli->tree, tctx, &io);
692 CHECK_STATUS(status, NT_STATUS_OK);
693 fnum = io.ntcreatex.out.file.fnum;
694
695 torture_comment(tctx, "get the original sd\n");
696 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
697 q.query_secdesc.in.file.fnum = fnum;
698 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
699 status = smb_raw_fileinfo(cli->tree, tctx, &q);
700 CHECK_STATUS(status, NT_STATUS_OK);
701 sd_orig = q.query_secdesc.out.sd;
702
703 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
704
705 torture_comment(tctx, "set a sec desc allowing no write by CREATOR_OWNER\n");
706 sd = security_descriptor_dacl_create(tctx,
707 0, NULL, NULL,
708 SID_CREATOR_OWNER,
709 SEC_ACE_TYPE_ACCESS_ALLOWED,
710 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
711 0,
712 NULL);
713
714 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
715 set.set_secdesc.in.file.fnum = fnum;
716 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
717 set.set_secdesc.in.sd = sd;
718
719 status = smb_raw_setfileinfo(cli->tree, &set);
720 CHECK_STATUS(status, NT_STATUS_OK);
721
722 torture_comment(tctx, "try open for write\n");
723 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
724 status = smb_raw_open(cli->tree, tctx, &io);
725 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
726
727 torture_comment(tctx, "try open for read\n");
728 io.ntcreatex.in.access_mask = SEC_FILE_READ_DATA;
729 status = smb_raw_open(cli->tree, tctx, &io);
730 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
731
732 torture_comment(tctx, "try open for generic write\n");
733 io.ntcreatex.in.access_mask = SEC_GENERIC_WRITE;
734 status = smb_raw_open(cli->tree, tctx, &io);
735 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
736
737 torture_comment(tctx, "try open for generic read\n");
738 io.ntcreatex.in.access_mask = SEC_GENERIC_READ;
739 status = smb_raw_open(cli->tree, tctx, &io);
740 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
741
742 torture_comment(tctx, "set a sec desc allowing no write by owner\n");
743 sd = security_descriptor_dacl_create(tctx,
744 0, owner_sid, NULL,
745 owner_sid,
746 SEC_ACE_TYPE_ACCESS_ALLOWED,
747 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
748 0,
749 NULL);
750
751 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
752 set.set_secdesc.in.file.fnum = fnum;
753 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
754 set.set_secdesc.in.sd = sd;
755 status = smb_raw_setfileinfo(cli->tree, &set);
756 CHECK_STATUS(status, NT_STATUS_OK);
757
758 torture_comment(tctx, "check that sd has been mapped correctly\n");
759 status = smb_raw_fileinfo(cli->tree, tctx, &q);
760 CHECK_STATUS(status, NT_STATUS_OK);
761 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
762
763 torture_comment(tctx, "try open for write\n");
764 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
765 status = smb_raw_open(cli->tree, tctx, &io);
766 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
767
768 torture_comment(tctx, "try open for read\n");
769 io.ntcreatex.in.access_mask = SEC_FILE_READ_DATA;
770 status = smb_raw_open(cli->tree, tctx, &io);
771 CHECK_STATUS(status, NT_STATUS_OK);
772 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
773 SEC_FILE_READ_DATA|
774 SEC_FILE_READ_ATTRIBUTE);
775 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
776
777 torture_comment(tctx, "try open for generic write\n");
778 io.ntcreatex.in.access_mask = SEC_GENERIC_WRITE;
779 status = smb_raw_open(cli->tree, tctx, &io);
780 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
781
782 torture_comment(tctx, "try open for generic read\n");
783 io.ntcreatex.in.access_mask = SEC_GENERIC_READ;
784 status = smb_raw_open(cli->tree, tctx, &io);
785 CHECK_STATUS(status, NT_STATUS_OK);
786 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
787 SEC_RIGHTS_FILE_READ);
788 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
789
790 torture_comment(tctx, "set a sec desc allowing generic read by owner\n");
791 sd = security_descriptor_dacl_create(tctx,
792 0, NULL, NULL,
793 owner_sid,
794 SEC_ACE_TYPE_ACCESS_ALLOWED,
795 SEC_GENERIC_READ | SEC_STD_ALL,
796 0,
797 NULL);
798
799 set.set_secdesc.in.sd = sd;
800 status = smb_raw_setfileinfo(cli->tree, &set);
801 CHECK_STATUS(status, NT_STATUS_OK);
802
803 torture_comment(tctx, "check that generic read has been mapped correctly\n");
804 sd2 = security_descriptor_dacl_create(tctx,
805 0, owner_sid, NULL,
806 owner_sid,
807 SEC_ACE_TYPE_ACCESS_ALLOWED,
808 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
809 0,
810 NULL);
811
812 status = smb_raw_fileinfo(cli->tree, tctx, &q);
813 CHECK_STATUS(status, NT_STATUS_OK);
814 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
815
816 torture_comment(tctx, "try open for write\n");
817 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
818 status = smb_raw_open(cli->tree, tctx, &io);
819 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
820
821 torture_comment(tctx, "try open for read\n");
822 io.ntcreatex.in.access_mask = SEC_FILE_READ_DATA;
823 status = smb_raw_open(cli->tree, tctx, &io);
824 CHECK_STATUS(status, NT_STATUS_OK);
825 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
826 SEC_FILE_READ_DATA |
827 SEC_FILE_READ_ATTRIBUTE);
828 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
829
830 torture_comment(tctx, "try open for generic write\n");
831 io.ntcreatex.in.access_mask = SEC_GENERIC_WRITE;
832 status = smb_raw_open(cli->tree, tctx, &io);
833 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
834
835 torture_comment(tctx, "try open for generic read\n");
836 io.ntcreatex.in.access_mask = SEC_GENERIC_READ;
837 status = smb_raw_open(cli->tree, tctx, &io);
838 CHECK_STATUS(status, NT_STATUS_OK);
839 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum, SEC_RIGHTS_FILE_READ);
840 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
841
842
843 torture_comment(tctx, "put back original sd\n");
844 set.set_secdesc.in.sd = sd_orig;
845 status = smb_raw_setfileinfo(cli->tree, &set);
846 CHECK_STATUS(status, NT_STATUS_OK);
847
848
849 done:
850 smbcli_close(cli->tree, fnum);
851 smb_raw_exit(cli->session);
852 smbcli_deltree(cli->tree, BASEDIR);
853 return ret;
854 }
855
856
857 /*
858 test the mapping of the SEC_GENERIC_xx bits to SEC_STD_xx and
859 SEC_FILE_xx bits
860 Test copied to smb2/acls.c for SMB2.
861 */
862 static bool test_generic_bits(struct torture_context *tctx,
863 struct smbcli_state *cli)
864 {
865 NTSTATUS status;
866 union smb_open io;
867 const char *fname = BASEDIR "\\generic.txt";
868 bool ret = true;
869 int fnum = -1, i;
870 union smb_fileinfo q;
871 union smb_setfileinfo set;
872 struct security_descriptor *sd, *sd_orig, *sd2;
873 const char *owner_sid;
874 const struct {
875 uint32_t gen_bits;
876 uint32_t specific_bits;
877 } file_mappings[] = {
878 { 0, 0 },
879 { SEC_GENERIC_READ, SEC_RIGHTS_FILE_READ },
880 { SEC_GENERIC_WRITE, SEC_RIGHTS_FILE_WRITE },
881 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_FILE_EXECUTE },
882 { SEC_GENERIC_ALL, SEC_RIGHTS_FILE_ALL },
883 { SEC_FILE_READ_DATA, SEC_FILE_READ_DATA },
884 { SEC_FILE_READ_ATTRIBUTE, SEC_FILE_READ_ATTRIBUTE }
885 };
886 const struct {
887 uint32_t gen_bits;
888 uint32_t specific_bits;
889 } dir_mappings[] = {
890 { 0, 0 },
891 { SEC_GENERIC_READ, SEC_RIGHTS_DIR_READ },
892 { SEC_GENERIC_WRITE, SEC_RIGHTS_DIR_WRITE },
893 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_DIR_EXECUTE },
894 { SEC_GENERIC_ALL, SEC_RIGHTS_DIR_ALL }
895 };
896 bool has_restore_privilege;
897 bool has_take_ownership_privilege;
898
899 if (!torture_setup_dir(cli, BASEDIR))
900 return false;
901
902 torture_comment(tctx, "TESTING FILE GENERIC BITS\n");
903
904 io.generic.level = RAW_OPEN_NTCREATEX;
905 io.ntcreatex.in.root_fid.fnum = 0;
906 io.ntcreatex.in.flags = 0;
907 io.ntcreatex.in.access_mask =
908 SEC_STD_READ_CONTROL |
909 SEC_STD_WRITE_DAC |
910 SEC_STD_WRITE_OWNER;
911 io.ntcreatex.in.create_options = 0;
912 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
913 io.ntcreatex.in.share_access =
914 NTCREATEX_SHARE_ACCESS_READ |
915 NTCREATEX_SHARE_ACCESS_WRITE;
916 io.ntcreatex.in.alloc_size = 0;
917 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
918 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
919 io.ntcreatex.in.security_flags = 0;
920 io.ntcreatex.in.fname = fname;
921 status = smb_raw_open(cli->tree, tctx, &io);
922 CHECK_STATUS(status, NT_STATUS_OK);
923 fnum = io.ntcreatex.out.file.fnum;
924
925 torture_comment(tctx, "get the original sd\n");
926 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
927 q.query_secdesc.in.file.fnum = fnum;
928 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
929 status = smb_raw_fileinfo(cli->tree, tctx, &q);
930 CHECK_STATUS(status, NT_STATUS_OK);
931 sd_orig = q.query_secdesc.out.sd;
932
933 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
934
935 status = torture_check_privilege(cli,
936 owner_sid,
937 sec_privilege_name(SEC_PRIV_RESTORE));
938 has_restore_privilege = NT_STATUS_IS_OK(status);
939 if (!NT_STATUS_IS_OK(status)) {
940 torture_warning(tctx, "torture_check_privilege - %s\n",
941 nt_errstr(status));
942 }
943 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
944
945 status = torture_check_privilege(cli,
946 owner_sid,
947 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
948 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
949 if (!NT_STATUS_IS_OK(status)) {
950 torture_warning(tctx, "torture_check_privilege - %s\n",
951 nt_errstr(status));
952 }
953 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
954
955 for (i=0;i<ARRAY_SIZE(file_mappings);i++) {
956 uint32_t expected_mask =
957 SEC_STD_WRITE_DAC |
958 SEC_STD_READ_CONTROL |
959 SEC_FILE_READ_ATTRIBUTE |
960 SEC_STD_DELETE;
961 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
962
963 if (has_restore_privilege) {
964 expected_mask_anon |= SEC_STD_DELETE;
965 }
966
967 torture_comment(tctx, "Testing generic bits 0x%08x\n",
968 file_mappings[i].gen_bits);
969 sd = security_descriptor_dacl_create(tctx,
970 0, owner_sid, NULL,
971 owner_sid,
972 SEC_ACE_TYPE_ACCESS_ALLOWED,
973 file_mappings[i].gen_bits,
974 0,
975 NULL);
976
977 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
978 set.set_secdesc.in.file.fnum = fnum;
979 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
980 set.set_secdesc.in.sd = sd;
981
982 status = smb_raw_setfileinfo(cli->tree, &set);
983 CHECK_STATUS(status, NT_STATUS_OK);
984
985 sd2 = security_descriptor_dacl_create(tctx,
986 0, owner_sid, NULL,
987 owner_sid,
988 SEC_ACE_TYPE_ACCESS_ALLOWED,
989 file_mappings[i].specific_bits,
990 0,
991 NULL);
992
993 status = smb_raw_fileinfo(cli->tree, tctx, &q);
994 CHECK_STATUS(status, NT_STATUS_OK);
995 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
996
997 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
998 status = smb_raw_open(cli->tree, tctx, &io);
999 CHECK_STATUS(status, NT_STATUS_OK);
1000 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
1001 expected_mask | file_mappings[i].specific_bits);
1002 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
1003
1004 if (!has_take_ownership_privilege) {
1005 continue;
1006 }
1007
1008 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
1009 file_mappings[i].gen_bits);
1010 sd = security_descriptor_dacl_create(tctx,
1011 0, SID_NT_ANONYMOUS, NULL,
1012 owner_sid,
1013 SEC_ACE_TYPE_ACCESS_ALLOWED,
1014 file_mappings[i].gen_bits,
1015 0,
1016 NULL);
1017
1018 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1019 set.set_secdesc.in.file.fnum = fnum;
1020 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1021 set.set_secdesc.in.sd = sd;
1022
1023 status = smb_raw_setfileinfo(cli->tree, &set);
1024 CHECK_STATUS(status, NT_STATUS_OK);
1025
1026 sd2 = security_descriptor_dacl_create(tctx,
1027 0, SID_NT_ANONYMOUS, NULL,
1028 owner_sid,
1029 SEC_ACE_TYPE_ACCESS_ALLOWED,
1030 file_mappings[i].specific_bits,
1031 0,
1032 NULL);
1033
1034 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1035 CHECK_STATUS(status, NT_STATUS_OK);
1036 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1037
1038 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
1039 status = smb_raw_open(cli->tree, tctx, &io);
1040 CHECK_STATUS(status, NT_STATUS_OK);
1041 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
1042 expected_mask_anon | file_mappings[i].specific_bits);
1043 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
1044 }
1045
1046 torture_comment(tctx, "put back original sd\n");
1047 set.set_secdesc.in.sd = sd_orig;
1048 status = smb_raw_setfileinfo(cli->tree, &set);
1049 CHECK_STATUS(status, NT_STATUS_OK);
1050
1051 smbcli_close(cli->tree, fnum);
1052 smbcli_unlink(cli->tree, fname);
1053
1054
1055 torture_comment(tctx, "TESTING DIR GENERIC BITS\n");
1056
1057 io.generic.level = RAW_OPEN_NTCREATEX;
1058 io.ntcreatex.in.root_fid.fnum = 0;
1059 io.ntcreatex.in.flags = 0;
1060 io.ntcreatex.in.access_mask =
1061 SEC_STD_READ_CONTROL |
1062 SEC_STD_WRITE_DAC |
1063 SEC_STD_WRITE_OWNER;
1064 io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1065 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
1066 io.ntcreatex.in.share_access =
1067 NTCREATEX_SHARE_ACCESS_READ |
1068 NTCREATEX_SHARE_ACCESS_WRITE;
1069 io.ntcreatex.in.alloc_size = 0;
1070 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
1071 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
1072 io.ntcreatex.in.security_flags = 0;
1073 io.ntcreatex.in.fname = fname;
1074 status = smb_raw_open(cli->tree, tctx, &io);
1075 CHECK_STATUS(status, NT_STATUS_OK);
1076 fnum = io.ntcreatex.out.file.fnum;
1077
1078 torture_comment(tctx, "get the original sd\n");
1079 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1080 q.query_secdesc.in.file.fnum = fnum;
1081 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1082 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1083 CHECK_STATUS(status, NT_STATUS_OK);
1084 sd_orig = q.query_secdesc.out.sd;
1085
1086 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1087
1088 status = torture_check_privilege(cli,
1089 owner_sid,
1090 sec_privilege_name(SEC_PRIV_RESTORE));
1091 has_restore_privilege = NT_STATUS_IS_OK(status);
1092 if (!NT_STATUS_IS_OK(status)) {
1093 torture_warning(tctx, "torture_check_privilege - %s\n",
1094 nt_errstr(status));
1095 }
1096 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
1097
1098 status = torture_check_privilege(cli,
1099 owner_sid,
1100 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
1101 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
1102 if (!NT_STATUS_IS_OK(status)) {
1103 torture_warning(tctx, "torture_check_privilege - %s\n",
1104 nt_errstr(status));
1105 }
1106 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
1107
1108 for (i=0;i<ARRAY_SIZE(dir_mappings);i++) {
1109 uint32_t expected_mask =
1110 SEC_STD_WRITE_DAC |
1111 SEC_STD_READ_CONTROL |
1112 SEC_FILE_READ_ATTRIBUTE |
1113 SEC_STD_DELETE;
1114 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
1115
1116 if (has_restore_privilege) {
1117 expected_mask_anon |= SEC_STD_DELETE;
1118 }
1119
1120 torture_comment(tctx, "Testing generic bits 0x%08x\n",
1121 file_mappings[i].gen_bits);
1122 sd = security_descriptor_dacl_create(tctx,
1123 0, owner_sid, NULL,
1124 owner_sid,
1125 SEC_ACE_TYPE_ACCESS_ALLOWED,
1126 dir_mappings[i].gen_bits,
1127 0,
1128 NULL);
1129
1130 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1131 set.set_secdesc.in.file.fnum = fnum;
1132 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1133 set.set_secdesc.in.sd = sd;
1134
1135 status = smb_raw_setfileinfo(cli->tree, &set);
1136 CHECK_STATUS(status, NT_STATUS_OK);
1137
1138 sd2 = security_descriptor_dacl_create(tctx,
1139 0, owner_sid, NULL,
1140 owner_sid,
1141 SEC_ACE_TYPE_ACCESS_ALLOWED,
1142 dir_mappings[i].specific_bits,
1143 0,
1144 NULL);
1145
1146 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1147 CHECK_STATUS(status, NT_STATUS_OK);
1148 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1149
1150 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
1151 status = smb_raw_open(cli->tree, tctx, &io);
1152 CHECK_STATUS(status, NT_STATUS_OK);
1153 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
1154 expected_mask | dir_mappings[i].specific_bits);
1155 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
1156
1157 if (!has_take_ownership_privilege) {
1158 continue;
1159 }
1160
1161 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
1162 file_mappings[i].gen_bits);
1163 sd = security_descriptor_dacl_create(tctx,
1164 0, SID_NT_ANONYMOUS, NULL,
1165 owner_sid,
1166 SEC_ACE_TYPE_ACCESS_ALLOWED,
1167 file_mappings[i].gen_bits,
1168 0,
1169 NULL);
1170
1171 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1172 set.set_secdesc.in.file.fnum = fnum;
1173 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1174 set.set_secdesc.in.sd = sd;
1175
1176 status = smb_raw_setfileinfo(cli->tree, &set);
1177 CHECK_STATUS(status, NT_STATUS_OK);
1178
1179 sd2 = security_descriptor_dacl_create(tctx,
1180 0, SID_NT_ANONYMOUS, NULL,
1181 owner_sid,
1182 SEC_ACE_TYPE_ACCESS_ALLOWED,
1183 file_mappings[i].specific_bits,
1184 0,
1185 NULL);
1186
1187 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1188 CHECK_STATUS(status, NT_STATUS_OK);
1189 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1190
1191 io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
1192 status = smb_raw_open(cli->tree, tctx, &io);
1193 CHECK_STATUS(status, NT_STATUS_OK);
1194 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum,
1195 expected_mask_anon | dir_mappings[i].specific_bits);
1196 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
1197 }
1198
1199 torture_comment(tctx, "put back original sd\n");
1200 set.set_secdesc.in.sd = sd_orig;
1201 status = smb_raw_setfileinfo(cli->tree, &set);
1202 CHECK_STATUS(status, NT_STATUS_OK);
1203
1204 smbcli_close(cli->tree, fnum);
1205 smbcli_unlink(cli->tree, fname);
1206
1207 done:
1208 smbcli_close(cli->tree, fnum);
1209 smb_raw_exit(cli->session);
1210 smbcli_deltree(cli->tree, BASEDIR);
1211 return ret;
1212 }
1213
1214
1215 /*
1216 see what access bits the owner of a file always gets
1217 Test copied to smb2/acls.c for SMB2.
1218 */
1219 static bool test_owner_bits(struct torture_context *tctx,
1220 struct smbcli_state *cli)
1221 {
1222 NTSTATUS status;
1223 union smb_open io;
1224 const char *fname = BASEDIR "\\test_owner_bits.txt";
1225 bool ret = true;
1226 int fnum = -1, i;
1227 union smb_fileinfo q;
1228 union smb_setfileinfo set;
1229 struct security_descriptor *sd, *sd_orig;
1230 const char *owner_sid;
1231 bool has_restore_privilege;
1232 bool has_take_ownership_privilege;
1233 uint32_t expected_bits;
1234
1235 if (!torture_setup_dir(cli, BASEDIR))
1236 return false;
1237
1238 torture_comment(tctx, "TESTING FILE OWNER BITS\n");
1239
1240 io.generic.level = RAW_OPEN_NTCREATEX;
1241 io.ntcreatex.in.root_fid.fnum = 0;
1242 io.ntcreatex.in.flags = 0;
1243 io.ntcreatex.in.access_mask =
1244 SEC_STD_READ_CONTROL |
1245 SEC_STD_WRITE_DAC |
1246 SEC_STD_WRITE_OWNER;
1247 io.ntcreatex.in.create_options = 0;
1248 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
1249 io.ntcreatex.in.share_access =
1250 NTCREATEX_SHARE_ACCESS_READ |
1251 NTCREATEX_SHARE_ACCESS_WRITE;
1252 io.ntcreatex.in.alloc_size = 0;
1253 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
1254 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
1255 io.ntcreatex.in.security_flags = 0;
1256 io.ntcreatex.in.fname = fname;
1257 status = smb_raw_open(cli->tree, tctx, &io);
1258 CHECK_STATUS(status, NT_STATUS_OK);
1259 fnum = io.ntcreatex.out.file.fnum;
1260
1261 torture_comment(tctx, "get the original sd\n");
1262 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1263 q.query_secdesc.in.file.fnum = fnum;
1264 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1265 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1266 CHECK_STATUS(status, NT_STATUS_OK);
1267 sd_orig = q.query_secdesc.out.sd;
1268
1269 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1270
1271 status = torture_check_privilege(cli,
1272 owner_sid,
1273 sec_privilege_name(SEC_PRIV_RESTORE));
1274 has_restore_privilege = NT_STATUS_IS_OK(status);
1275 if (!NT_STATUS_IS_OK(status)) {
1276 torture_warning(tctx, "torture_check_privilege - %s\n", nt_errstr(status));
1277 }
1278 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
1279
1280 status = torture_check_privilege(cli,
1281 owner_sid,
1282 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
1283 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
1284 if (!NT_STATUS_IS_OK(status)) {
1285 torture_warning(tctx, "torture_check_privilege - %s\n", nt_errstr(status));
1286 }
1287 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
1288
1289 sd = security_descriptor_dacl_create(tctx,
1290 0, NULL, NULL,
1291 owner_sid,
1292 SEC_ACE_TYPE_ACCESS_ALLOWED,
1293 SEC_FILE_WRITE_DATA,
1294 0,
1295 NULL);
1296
1297 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1298 set.set_secdesc.in.file.fnum = fnum;
1299 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1300 set.set_secdesc.in.sd = sd;
1301
1302 status = smb_raw_setfileinfo(cli->tree, &set);
1303 CHECK_STATUS(status, NT_STATUS_OK);
1304
1305 expected_bits = SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE;
1306
1307 for (i=0;i<16;i++) {
1308 uint32_t bit = (1<<i);
1309 io.ntcreatex.in.access_mask = bit;
1310 status = smb_raw_open(cli->tree, tctx, &io);
1311 if (expected_bits & bit) {
1312 if (!NT_STATUS_IS_OK(status)) {
1313 torture_warning(tctx, "failed with access mask 0x%08x of expected 0x%08x\n",
1314 bit, expected_bits);
1315 }
1316 CHECK_STATUS(status, NT_STATUS_OK);
1317 CHECK_ACCESS_FLAGS(io.ntcreatex.out.file.fnum, bit | SEC_FILE_READ_ATTRIBUTE);
1318 smbcli_close(cli->tree, io.ntcreatex.out.file.fnum);
1319 } else {
1320 if (NT_STATUS_IS_OK(status)) {
1321 torture_warning(tctx, "open succeeded with access mask 0x%08x of "
1322 "expected 0x%08x - should fail\n",
1323 bit, expected_bits);
1324 }
1325 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1326 }
1327 }
1328
1329 torture_comment(tctx, "put back original sd\n");
1330 set.set_secdesc.in.sd = sd_orig;
1331 status = smb_raw_setfileinfo(cli->tree, &set);
1332 CHECK_STATUS(status, NT_STATUS_OK);
1333
1334 done:
1335 smbcli_close(cli->tree, fnum);
1336 smbcli_unlink(cli->tree, fname);
1337 smb_raw_exit(cli->session);
1338 smbcli_deltree(cli->tree, BASEDIR);
1339 return ret;
1340 }
1341
1342
1343
1344 /*
1345 test the inheritance of ACL flags onto new files and directories
1346 Test copied to smb2/acls.c for SMB2.
1347 */
1348 static bool test_inheritance(struct torture_context *tctx,
1349 struct smbcli_state *cli)
1350 {
1351 NTSTATUS status;
1352 union smb_open io;
1353 const char *dname = BASEDIR "\\inheritance";
1354 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1355 const char *fname2 = BASEDIR "\\inheritance\\testdir";
1356 bool ret = true;
1357 int fnum=0, fnum2, i;
1358 union smb_fileinfo q;
1359 union smb_setfileinfo set;
1360 struct security_descriptor *sd, *sd2, *sd_orig=NULL, *sd_def1, *sd_def2;
1361 const char *owner_sid, *group_sid;
1362 const struct dom_sid *creator_owner;
1363 const struct {
1364 uint32_t parent_flags;
1365 uint32_t file_flags;
1366 uint32_t dir_flags;
1367 } test_flags[] = {
1368 {
1369 0,
1370 0,
1371 0
1372 },
1373 {
1374 SEC_ACE_FLAG_OBJECT_INHERIT,
1375 0,
1376 SEC_ACE_FLAG_OBJECT_INHERIT |
1377 SEC_ACE_FLAG_INHERIT_ONLY,
1378 },
1379 {
1380 SEC_ACE_FLAG_CONTAINER_INHERIT,
1381 0,
1382 SEC_ACE_FLAG_CONTAINER_INHERIT,
1383 },
1384 {
1385 SEC_ACE_FLAG_OBJECT_INHERIT |
1386 SEC_ACE_FLAG_CONTAINER_INHERIT,
1387 0,
1388 SEC_ACE_FLAG_OBJECT_INHERIT |
1389 SEC_ACE_FLAG_CONTAINER_INHERIT,
1390 },
1391 {
1392 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
1393 0,
1394 0,
1395 },
1396 {
1397 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1398 SEC_ACE_FLAG_OBJECT_INHERIT,
1399 0,
1400 0,
1401 },
1402 {
1403 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1404 SEC_ACE_FLAG_CONTAINER_INHERIT,
1405 0,
1406 0,
1407 },
1408 {
1409 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1410 SEC_ACE_FLAG_CONTAINER_INHERIT |
1411 SEC_ACE_FLAG_OBJECT_INHERIT,
1412 0,
1413 0,
1414 },
1415 {
1416 SEC_ACE_FLAG_INHERIT_ONLY,
1417 0,
1418 0,
1419 },
1420 {
1421 SEC_ACE_FLAG_INHERIT_ONLY |
1422 SEC_ACE_FLAG_OBJECT_INHERIT,
1423 0,
1424 SEC_ACE_FLAG_OBJECT_INHERIT |
1425 SEC_ACE_FLAG_INHERIT_ONLY,
1426 },
1427 {
1428 SEC_ACE_FLAG_INHERIT_ONLY |
1429 SEC_ACE_FLAG_CONTAINER_INHERIT,
1430 0,
1431 SEC_ACE_FLAG_CONTAINER_INHERIT,
1432 },
1433 {
1434 SEC_ACE_FLAG_INHERIT_ONLY |
1435 SEC_ACE_FLAG_CONTAINER_INHERIT |
1436 SEC_ACE_FLAG_OBJECT_INHERIT,
1437 0,
1438 SEC_ACE_FLAG_CONTAINER_INHERIT |
1439 SEC_ACE_FLAG_OBJECT_INHERIT,
1440 },
1441 {
1442 SEC_ACE_FLAG_INHERIT_ONLY |
1443 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
1444 0,
1445 0,
1446 },
1447 {
1448 SEC_ACE_FLAG_INHERIT_ONLY |
1449 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1450 SEC_ACE_FLAG_OBJECT_INHERIT,
1451 0,
1452 0,
1453 },
1454 {
1455 SEC_ACE_FLAG_INHERIT_ONLY |
1456 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1457 SEC_ACE_FLAG_CONTAINER_INHERIT,
1458 0,
1459 0,
1460 },
1461 {
1462 SEC_ACE_FLAG_INHERIT_ONLY |
1463 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
1464 SEC_ACE_FLAG_CONTAINER_INHERIT |
1465 SEC_ACE_FLAG_OBJECT_INHERIT,
1466 0,
1467 0,
1468 }
1469 };
1470
1471 if (!torture_setup_dir(cli, BASEDIR))
1472 return false;
1473
1474 torture_comment(tctx, "TESTING ACL INHERITANCE\n");
1475
1476 io.generic.level = RAW_OPEN_NTCREATEX;
1477 io.ntcreatex.in.root_fid.fnum = 0;
1478 io.ntcreatex.in.flags = 0;
1479 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1480 io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1481 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
1482 io.ntcreatex.in.share_access = 0;
1483 io.ntcreatex.in.alloc_size = 0;
1484 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
1485 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
1486 io.ntcreatex.in.security_flags = 0;
1487 io.ntcreatex.in.fname = dname;
1488
1489 status = smb_raw_open(cli->tree, tctx, &io);
1490 CHECK_STATUS(status, NT_STATUS_OK);
1491 fnum = io.ntcreatex.out.file.fnum;
1492
1493 torture_comment(tctx, "get the original sd\n");
1494 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1495 q.query_secdesc.in.file.fnum = fnum;
1496 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER | SECINFO_GROUP;
1497 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1498 CHECK_STATUS(status, NT_STATUS_OK);
1499 sd_orig = q.query_secdesc.out.sd;
1500
1501 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1502 group_sid = dom_sid_string(tctx, sd_orig->group_sid);
1503
1504 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1505 torture_comment(tctx, "group_sid is %s\n", group_sid);
1506
1507 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1508
1509 if (torture_setting_bool(tctx, "samba4", false)) {
1510 /* the default ACL in Samba4 includes the group and
1511 other permissions */
1512 sd_def1 = security_descriptor_dacl_create(tctx,
1513 0, owner_sid, NULL,
1514 owner_sid,
1515 SEC_ACE_TYPE_ACCESS_ALLOWED,
1516 SEC_RIGHTS_FILE_ALL,
1517 0,
1518 group_sid,
1519 SEC_ACE_TYPE_ACCESS_ALLOWED,
1520 SEC_RIGHTS_FILE_READ | SEC_FILE_EXECUTE,
1521 0,
1522 SID_WORLD,
1523 SEC_ACE_TYPE_ACCESS_ALLOWED,
1524 SEC_RIGHTS_FILE_READ | SEC_FILE_EXECUTE,
1525 0,
1526 SID_NT_SYSTEM,
1527 SEC_ACE_TYPE_ACCESS_ALLOWED,
1528 SEC_RIGHTS_FILE_ALL,
1529 0,
1530 NULL);
1531 } else {
1532 /*
1533 * The Windows Default ACL for a new file, when there is no ACL to be
1534 * inherited: FullControl for the owner and SYSTEM.
1535 */
1536 sd_def1 = security_descriptor_dacl_create(tctx,
1537 0, owner_sid, NULL,
1538 owner_sid,
1539 SEC_ACE_TYPE_ACCESS_ALLOWED,
1540 SEC_RIGHTS_FILE_ALL,
1541 0,
1542 SID_NT_SYSTEM,
1543 SEC_ACE_TYPE_ACCESS_ALLOWED,
1544 SEC_RIGHTS_FILE_ALL,
1545 0,
1546 NULL);
1547 }
1548
1549 /*
1550 * Use this in the case the system being tested does not add an ACE for
1551 * the SYSTEM SID.
1552 */
1553 sd_def2 = security_descriptor_dacl_create(tctx,
1554 0, owner_sid, NULL,
1555 owner_sid,
1556 SEC_ACE_TYPE_ACCESS_ALLOWED,
1557 SEC_RIGHTS_FILE_ALL,
1558 0,
1559 NULL);
1560
1561 creator_owner = dom_sid_parse_talloc(tctx, SID_CREATOR_OWNER);
1562
1563 for (i=0;i<ARRAY_SIZE(test_flags);i++) {
1564 sd = security_descriptor_dacl_create(tctx,
1565 0, NULL, NULL,
1566 SID_CREATOR_OWNER,
1567 SEC_ACE_TYPE_ACCESS_ALLOWED,
1568 SEC_FILE_WRITE_DATA,
1569 test_flags[i].parent_flags,
1570 SID_WORLD,
1571 SEC_ACE_TYPE_ACCESS_ALLOWED,
1572 SEC_FILE_ALL | SEC_STD_ALL,
1573 0,
1574 NULL);
1575 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1576 set.set_secdesc.in.file.fnum = fnum;
1577 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1578 set.set_secdesc.in.sd = sd;
1579 status = smb_raw_setfileinfo(cli->tree, &set);
1580 CHECK_STATUS(status, NT_STATUS_OK);
1581
1582 io.ntcreatex.in.fname = fname1;
1583 io.ntcreatex.in.create_options = 0;
1584 status = smb_raw_open(cli->tree, tctx, &io);
1585 CHECK_STATUS(status, NT_STATUS_OK);
1586 fnum2 = io.ntcreatex.out.file.fnum;
1587
1588 q.query_secdesc.in.file.fnum = fnum2;
1589 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1590 CHECK_STATUS(status, NT_STATUS_OK);
1591
1592 smbcli_close(cli->tree, fnum2);
1593 smbcli_unlink(cli->tree, fname1);
1594
1595 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT)) {
1596 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1597 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1598 torture_warning(tctx, "Expected default sd "
1599 "for i=%d:\n", i);
1600 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1601 torture_warning(tctx, "at %d - got:\n", i);
1602 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1603 }
1604 goto check_dir;
1605 }
1606
1607 if (q.query_secdesc.out.sd->dacl == NULL ||
1608 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1609 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1610 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1611 sd_orig->owner_sid)) {
1612 ret = false;
1613 torture_warning(tctx, "Bad sd in child file at %d\n", i);
1614 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1615 goto check_dir;
1616 }
1617
1618 if (q.query_secdesc.out.sd->dacl->aces[0].flags !=
1619 test_flags[i].file_flags) {
1620 torture_warning(tctx, "incorrect file_flags 0x%x - expected 0x%x for parent 0x%x with (i=%d)\n",
1621 q.query_secdesc.out.sd->dacl->aces[0].flags,
1622 test_flags[i].file_flags,
1623 test_flags[i].parent_flags,
1624 i);
1625 ret = false;
1626 }
1627
1628 check_dir:
1629 io.ntcreatex.in.fname = fname2;
1630 io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1631 status = smb_raw_open(cli->tree, tctx, &io);
1632 CHECK_STATUS(status, NT_STATUS_OK);
1633 fnum2 = io.ntcreatex.out.file.fnum;
1634
1635 q.query_secdesc.in.file.fnum = fnum2;
1636 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1637 CHECK_STATUS(status, NT_STATUS_OK);
1638
1639 smbcli_close(cli->tree, fnum2);
1640 smbcli_rmdir(cli->tree, fname2);
1641
1642 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1643 (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT) ||
1644 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT))) {
1645 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1646 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1647 torture_warning(tctx, "Expected default sd for dir at %d:\n", i);
1648 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1649 torture_warning(tctx, "got:\n");
1650 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1651 }
1652 continue;
1653 }
1654
1655 if ((test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1656 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT)) {
1657 if (q.query_secdesc.out.sd->dacl == NULL ||
1658 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1659 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1660 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1661 sd_orig->owner_sid) ||
1662 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1663 torture_warning(tctx, "(CI & NP) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1664 test_flags[i].dir_flags,
1665 test_flags[i].parent_flags, i);
1666 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1667 torture_comment(tctx, "FYI, here is the parent sd:\n");
1668 NDR_PRINT_DEBUG(security_descriptor, sd);
1669 ret = false;
1670 continue;
1671 }
1672 } else if (test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) {
1673 if (q.query_secdesc.out.sd->dacl == NULL ||
1674 q.query_secdesc.out.sd->dacl->num_aces != 2 ||
1675 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1676 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1677 sd_orig->owner_sid) ||
1678 q.query_secdesc.out.sd->dacl->aces[1].access_mask != SEC_FILE_WRITE_DATA ||
1679 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[1].trustee,
1680 creator_owner) ||
1681 q.query_secdesc.out.sd->dacl->aces[0].flags != 0 ||
1682 q.query_secdesc.out.sd->dacl->aces[1].flags !=
1683 (test_flags[i].dir_flags | SEC_ACE_FLAG_INHERIT_ONLY)) {
1684 torture_warning(tctx, "(CI) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1685 test_flags[i].dir_flags,
1686 test_flags[i].parent_flags, i);
1687 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1688 torture_comment(tctx, "FYI, here is the parent sd:\n");
1689 NDR_PRINT_DEBUG(security_descriptor, sd);
1690 ret = false;
1691 continue;
1692 }
1693 } else {
1694 if (q.query_secdesc.out.sd->dacl == NULL ||
1695 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1696 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1697 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1698 creator_owner) ||
1699 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1700 torture_warning(tctx, "(0) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1701 test_flags[i].dir_flags,
1702 test_flags[i].parent_flags, i);
1703 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1704 torture_comment(tctx, "FYI, here is the parent sd:\n");
1705 NDR_PRINT_DEBUG(security_descriptor, sd);
1706 ret = false;
1707 continue;
1708 }
1709 }
1710 }
1711
1712 torture_comment(tctx, "Testing access checks on inherited create with %s\n", fname1);
1713 sd = security_descriptor_dacl_create(tctx,
1714 0, NULL, NULL,
1715 owner_sid,
1716 SEC_ACE_TYPE_ACCESS_ALLOWED,
1717 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1718 SEC_ACE_FLAG_OBJECT_INHERIT,
1719 SID_WORLD,
1720 SEC_ACE_TYPE_ACCESS_ALLOWED,
1721 SEC_FILE_ALL | SEC_STD_ALL,
1722 0,
1723 NULL);
1724 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1725 set.set_secdesc.in.file.fnum = fnum;
1726 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1727 set.set_secdesc.in.sd = sd;
1728 status = smb_raw_setfileinfo(cli->tree, &set);
1729 CHECK_STATUS(status, NT_STATUS_OK);
1730
1731 /* Check DACL we just set. */
1732 torture_comment(tctx, "checking new sd\n");
1733 q.query_secdesc.in.file.fnum = fnum;
1734 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1735 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1736 CHECK_STATUS(status, NT_STATUS_OK);
1737 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1738
1739 io.ntcreatex.in.fname = fname1;
1740 io.ntcreatex.in.create_options = 0;
1741 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1742 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
1743 status = smb_raw_open(cli->tree, tctx, &io);
1744 CHECK_STATUS(status, NT_STATUS_OK);
1745 fnum2 = io.ntcreatex.out.file.fnum;
1746 CHECK_ACCESS_FLAGS(fnum2, SEC_RIGHTS_FILE_ALL);
1747
1748 q.query_secdesc.in.file.fnum = fnum2;
1749 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1750 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1751 CHECK_STATUS(status, NT_STATUS_OK);
1752 smbcli_close(cli->tree, fnum2);
1753
1754 sd2 = security_descriptor_dacl_create(tctx,
1755 0, owner_sid, NULL,
1756 owner_sid,
1757 SEC_ACE_TYPE_ACCESS_ALLOWED,
1758 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1759 0,
1760 NULL);
1761 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1762
1763 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
1764 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1765 status = smb_raw_open(cli->tree, tctx, &io);
1766 if (NT_STATUS_IS_OK(status)) {
1767 torture_warning(tctx, "failed: w2k3 ACL bug (allowed open when ACL should deny)\n");
1768 ret = false;
1769 fnum2 = io.ntcreatex.out.file.fnum;
1770 CHECK_ACCESS_FLAGS(fnum2, SEC_RIGHTS_FILE_ALL);
1771 smbcli_close(cli->tree, fnum2);
1772 } else {
1773 if (TARGET_IS_WIN7(tctx)) {
1774 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1775 } else {
1776 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1777 }
1778 }
1779
1780 torture_comment(tctx, "trying without execute\n");
1781 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
1782 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL & ~SEC_FILE_EXECUTE;
1783 status = smb_raw_open(cli->tree, tctx, &io);
1784 if (TARGET_IS_WIN7(tctx)) {
1785 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1786 } else {
1787 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1788 }
1789
1790 torture_comment(tctx, "and with full permissions again\n");
1791 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
1792 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1793 status = smb_raw_open(cli->tree, tctx, &io);
1794 if (TARGET_IS_WIN7(tctx)) {
1795 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1796 } else {
1797 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1798 }
1799
1800 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
1801 status = smb_raw_open(cli->tree, tctx, &io);
1802 CHECK_STATUS(status, NT_STATUS_OK);
1803 fnum2 = io.ntcreatex.out.file.fnum;
1804 CHECK_ACCESS_FLAGS(fnum2, SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE);
1805 smbcli_close(cli->tree, fnum2);
1806
1807 torture_comment(tctx, "put back original sd\n");
1808 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1809 set.set_secdesc.in.file.fnum = fnum;
1810 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1811 set.set_secdesc.in.sd = sd_orig;
1812 status = smb_raw_setfileinfo(cli->tree, &set);
1813 CHECK_STATUS(status, NT_STATUS_OK);
1814
1815 smbcli_close(cli->tree, fnum);
1816
1817 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1818 status = smb_raw_open(cli->tree, tctx, &io);
1819 if (TARGET_IS_WIN7(tctx)) {
1820 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1821 } else {
1822 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1823 }
1824
1825 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
1826 status = smb_raw_open(cli->tree, tctx, &io);
1827 CHECK_STATUS(status, NT_STATUS_OK);
1828 fnum2 = io.ntcreatex.out.file.fnum;
1829 CHECK_ACCESS_FLAGS(fnum2, SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE);
1830 smbcli_close(cli->tree, fnum2);
1831
1832 done:
1833 if (sd_orig != NULL) {
1834 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1835 set.set_secdesc.in.file.fnum = fnum;
1836 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1837 set.set_secdesc.in.sd = sd_orig;
1838 status = smb_raw_setfileinfo(cli->tree, &set);
1839 }
1840
1841 smbcli_close(cli->tree, fnum);
1842 smbcli_unlink(cli->tree, fname1);
1843 smbcli_rmdir(cli->tree, dname);
1844 smb_raw_exit(cli->session);
1845 smbcli_deltree(cli->tree, BASEDIR);
1846 return ret;
1847 }
1848
1849 static bool test_inheritance_flags(struct torture_context *tctx,
1850 struct smbcli_state *cli)
1851 {
1852 NTSTATUS status;
1853 union smb_open io;
1854 const char *dname = BASEDIR "\\inheritance";
1855 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1856 bool ret = true;
1857 int fnum=0, fnum2, i, j;
1858 union smb_fileinfo q;
1859 union smb_setfileinfo set;
1860 struct security_descriptor *sd, *sd2, *sd_orig=NULL;
1861 const char *owner_sid;
1862 struct {
1863 uint32_t parent_set_sd_type; /* 3 options */
1864 uint32_t parent_set_ace_inherit; /* 1 option */
1865 uint32_t parent_get_sd_type;
1866 uint32_t parent_get_ace_inherit;
1867 uint32_t child_get_sd_type;
1868 uint32_t child_get_ace_inherit;
1869 } tflags[16] = {{0}}; /* 2^4 */
1870
1871 for (i = 0; i < 15; i++) {
1872 torture_comment(tctx, "i=%d:", i);
1873
1874 ZERO_STRUCT(tflags[i]);
1875
1876 if (i & 1) {
1877 tflags[i].parent_set_sd_type |=
1878 SEC_DESC_DACL_AUTO_INHERITED;
1879 torture_comment(tctx, "AUTO_INHERITED, ");
1880 }
1881 if (i & 2) {
1882 tflags[i].parent_set_sd_type |=
1883 SEC_DESC_DACL_AUTO_INHERIT_REQ;
1884 torture_comment(tctx, "AUTO_INHERIT_REQ, ");
1885 }
1886 if (i & 4) {
1887 tflags[i].parent_set_sd_type |=
1888 SEC_DESC_DACL_PROTECTED;
1889 tflags[i].parent_get_sd_type |=
1890 SEC_DESC_DACL_PROTECTED;
1891 torture_comment(tctx, "PROTECTED, ");
1892 }
1893 if (i & 8) {
1894 tflags[i].parent_set_ace_inherit |=
1895 SEC_ACE_FLAG_INHERITED_ACE;
1896 tflags[i].parent_get_ace_inherit |=
1897 SEC_ACE_FLAG_INHERITED_ACE;
1898 torture_comment(tctx, "INHERITED, ");
1899 }
1900
1901 if ((tflags[i].parent_set_sd_type &
1902 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) ==
1903 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) {
1904 tflags[i].parent_get_sd_type |=
1905 SEC_DESC_DACL_AUTO_INHERITED;
1906 tflags[i].child_get_sd_type |=
1907 SEC_DESC_DACL_AUTO_INHERITED;
1908 tflags[i].child_get_ace_inherit |=
1909 SEC_ACE_FLAG_INHERITED_ACE;
1910 torture_comment(tctx, " ... parent is AUTO INHERITED");
1911 }
1912
1913 if (tflags[i].parent_set_ace_inherit &
1914 SEC_ACE_FLAG_INHERITED_ACE) {
1915 tflags[i].parent_get_ace_inherit =
1916 SEC_ACE_FLAG_INHERITED_ACE;
1917 torture_comment(tctx, " ... parent ACE is INHERITED");
1918 }
1919
1920 torture_comment(tctx, "\n");
1921 }
1922
1923 if (!torture_setup_dir(cli, BASEDIR))
1924 return false;
1925
1926 torture_comment(tctx, "TESTING ACL INHERITANCE FLAGS\n");
1927
1928 ZERO_STRUCT(io);
1929
1930 io.generic.level = RAW_OPEN_NTCREATEX;
1931 io.ntcreatex.in.root_fid.fnum = 0;
1932 io.ntcreatex.in.flags = 0;
1933 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
1934 io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1935 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
1936 io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_MASK;
1937 io.ntcreatex.in.alloc_size = 0;
1938 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
1939 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
1940 io.ntcreatex.in.security_flags = 0;
1941 io.ntcreatex.in.fname = dname;
1942
1943 torture_comment(tctx, "creating initial directory %s\n", dname);
1944 status = smb_raw_open(cli->tree, tctx, &io);
1945 CHECK_STATUS(status, NT_STATUS_OK);
1946 fnum = io.ntcreatex.out.file.fnum;
1947
1948 torture_comment(tctx, "getting original sd\n");
1949 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1950 q.query_secdesc.in.file.fnum = fnum;
1951 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1952 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1953 CHECK_STATUS(status, NT_STATUS_OK);
1954 sd_orig = q.query_secdesc.out.sd;
1955
1956 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1957 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1958
1959 for (i=0; i < ARRAY_SIZE(tflags); i++) {
1960 torture_comment(tctx, "setting a new sd on directory, pass #%d\n", i);
1961
1962 sd = security_descriptor_dacl_create(tctx,
1963 tflags[i].parent_set_sd_type,
1964 NULL, NULL,
1965 owner_sid,
1966 SEC_ACE_TYPE_ACCESS_ALLOWED,
1967 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1968 SEC_ACE_FLAG_OBJECT_INHERIT |
1969 SEC_ACE_FLAG_CONTAINER_INHERIT |
1970 tflags[i].parent_set_ace_inherit,
1971 SID_WORLD,
1972 SEC_ACE_TYPE_ACCESS_ALLOWED,
1973 SEC_FILE_ALL | SEC_STD_ALL,
1974 0,
1975 NULL);
1976 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1977 set.set_secdesc.in.file.fnum = fnum;
1978 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1979 set.set_secdesc.in.sd = sd;
1980 status = smb_raw_setfileinfo(cli->tree, &set);
1981 CHECK_STATUS(status, NT_STATUS_OK);
1982
1983 /*
1984 * Check DACL we just set, except change the bits to what they
1985 * should be.
1986 */
1987 torture_comment(tctx, " checking new sd\n");
1988
1989 /* REQ bit should always be false. */
1990 sd->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1991
1992 if ((tflags[i].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1993 sd->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1994
1995 q.query_secdesc.in.file.fnum = fnum;
1996 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1997 status = smb_raw_fileinfo(cli->tree, tctx, &q);
1998 CHECK_STATUS(status, NT_STATUS_OK);
1999 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
2000
2001 /* Create file. */
2002 torture_comment(tctx, " creating file %s\n", fname1);
2003 io.ntcreatex.in.fname = fname1;
2004 io.ntcreatex.in.create_options = 0;
2005 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
2006 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
2007 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
2008 status = smb_raw_open(cli->tree, tctx, &io);
2009 CHECK_STATUS(status, NT_STATUS_OK);
2010 fnum2 = io.ntcreatex.out.file.fnum;
2011 CHECK_ACCESS_FLAGS(fnum2, SEC_RIGHTS_FILE_ALL);
2012
2013 q.query_secdesc.in.file.fnum = fnum2;
2014 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
2015 status = smb_raw_fileinfo(cli->tree, tctx, &q);
2016 CHECK_STATUS(status, NT_STATUS_OK);
2017
2018 torture_comment(tctx, " checking sd on file %s\n", fname1);
2019 sd2 = security_descriptor_dacl_create(tctx,
2020 tflags[i].child_get_sd_type,
2021 owner_sid, NULL,
2022 owner_sid,
2023 SEC_ACE_TYPE_ACCESS_ALLOWED,
2024 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
2025 tflags[i].child_get_ace_inherit,
2026 NULL);
2027 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
2028
2029 /*
2030 * Set new sd on file ... prove that the bits have nothing to
2031 * do with the parents bits when manually setting an ACL. The
2032 * _AUTO_INHERITED bit comes directly from the ACL set.
2033 */
2034 for (j = 0; j < ARRAY_SIZE(tflags); j++) {
2035 torture_comment(tctx, " setting new file sd, pass #%d\n", j);
2036
2037 /* Change sd type. */
2038 sd2->type &= ~(SEC_DESC_DACL_AUTO_INHERITED |
2039 SEC_DESC_DACL_AUTO_INHERIT_REQ |
2040 SEC_DESC_DACL_PROTECTED);
2041 sd2->type |= tflags[j].parent_set_sd_type;
2042
2043 sd2->dacl->aces[0].flags &=
2044 ~SEC_ACE_FLAG_INHERITED_ACE;
2045 sd2->dacl->aces[0].flags |=
2046 tflags[j].parent_set_ace_inherit;
2047
2048 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2049 set.set_secdesc.in.file.fnum = fnum2;
2050 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2051 set.set_secdesc.in.sd = sd2;
2052 status = smb_raw_setfileinfo(cli->tree, &set);
2053 CHECK_STATUS(status, NT_STATUS_OK);
2054
2055 /* Check DACL we just set. */
2056 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
2057 if ((tflags[j].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
2058 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
2059
2060 q.query_secdesc.in.file.fnum = fnum2;
2061 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
2062 status = smb_raw_fileinfo(cli->tree, tctx, &q);
2063 CHECK_STATUS(status, NT_STATUS_OK);
2064
2065 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
2066 }
2067
2068 smbcli_close(cli->tree, fnum2);
2069 smbcli_unlink(cli->tree, fname1);
2070 }
2071
2072 done:
2073 smbcli_close(cli->tree, fnum);
2074 smb_raw_exit(cli->session);
2075 smbcli_deltree(cli->tree, BASEDIR);
2076
2077 if (!ret) {
2078 torture_result(tctx,
2079 TORTURE_FAIL, "(%s) test_inheritance_flags\n",
2080 __location__);
2081 }
2082
2083 return ret;
2084 }
2085
2086 /*
2087 test dynamic acl inheritance
2088 Test copied to smb2/acls.c for SMB2.
2089 */
2090 static bool test_inheritance_dynamic(struct torture_context *tctx,
2091 struct smbcli_state *cli)
2092 {
2093 NTSTATUS status;
2094 union smb_open io;
2095 const char *dname = BASEDIR "\\inheritance2";
2096 const char *fname1 = BASEDIR "\\inheritance2\\testfile";
2097 bool ret = true;
2098 int fnum=0, fnum2;
2099 union smb_fileinfo q;
2100 union smb_setfileinfo set;
2101 struct security_descriptor *sd, *sd_orig=NULL;
2102 const char *owner_sid;
2103
2104 torture_comment(tctx, "TESTING DYNAMIC ACL INHERITANCE\n");
2105
2106 if (!torture_setup_dir(cli, BASEDIR))
2107 return false;
2108
2109 io.generic.level = RAW_OPEN_NTCREATEX;
2110 io.ntcreatex.in.root_fid.fnum = 0;
2111 io.ntcreatex.in.flags = 0;
2112 io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
2113 io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
2114 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
2115 io.ntcreatex.in.share_access = 0;
2116 io.ntcreatex.in.alloc_size = 0;
2117 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
2118 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
2119 io.ntcreatex.in.security_flags = 0;
2120 io.ntcreatex.in.fname = dname;
2121
2122 status = smb_raw_open(cli->tree, tctx, &io);
2123 CHECK_STATUS(status, NT_STATUS_OK);
2124 fnum = io.ntcreatex.out.file.fnum;
2125
2126 torture_comment(tctx, "get the original sd\n");
2127 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2128 q.query_secdesc.in.file.fnum = fnum;
2129 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
2130 status = smb_raw_fileinfo(cli->tree, tctx, &q);
2131 CHECK_STATUS(status, NT_STATUS_OK);
2132 sd_orig = q.query_secdesc.out.sd;
2133
2134 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2135
2136 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
2137
2138 sd = security_descriptor_dacl_create(tctx,
2139 0, NULL, NULL,
2140 owner_sid,
2141 SEC_ACE_TYPE_ACCESS_ALLOWED,
2142 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE,
2143 SEC_ACE_FLAG_OBJECT_INHERIT,
2144 NULL);
2145 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
2146
2147 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2148 set.set_secdesc.in.file.fnum = fnum;
2149 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2150 set.set_secdesc.in.sd = sd;
2151 status = smb_raw_setfileinfo(cli->tree, &set);
2152 CHECK_STATUS(status, NT_STATUS_OK);
2153
2154 torture_comment(tctx, "create a file with an inherited acl\n");
2155 io.ntcreatex.in.fname = fname1;
2156 io.ntcreatex.in.create_options = 0;
2157 io.ntcreatex.in.access_mask = SEC_FILE_READ_ATTRIBUTE;
2158 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_CREATE;
2159 status = smb_raw_open(cli->tree, tctx, &io);
2160 CHECK_STATUS(status, NT_STATUS_OK);
2161 fnum2 = io.ntcreatex.out.file.fnum;
2162 smbcli_close(cli->tree, fnum2);
2163
2164 torture_comment(tctx, "try and access file with base rights - should be OK\n");
2165 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
2166 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
2167 status = smb_raw_open(cli->tree, tctx, &io);
2168 CHECK_STATUS(status, NT_STATUS_OK);
2169 fnum2 = io.ntcreatex.out.file.fnum;
2170 smbcli_close(cli->tree, fnum2);
2171
2172 torture_comment(tctx, "try and access file with extra rights - should be denied\n");
2173 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
2174 status = smb_raw_open(cli->tree, tctx, &io);
2175 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
2176
2177 torture_comment(tctx, "update parent sd\n");
2178 sd = security_descriptor_dacl_create(tctx,
2179 0, NULL, NULL,
2180 owner_sid,
2181 SEC_ACE_TYPE_ACCESS_ALLOWED,
2182 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE | SEC_FILE_EXECUTE,
2183 SEC_ACE_FLAG_OBJECT_INHERIT,
2184 NULL);
2185 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
2186
2187 set.set_secdesc.in.sd = sd;
2188 status = smb_raw_setfileinfo(cli->tree, &set);
2189 CHECK_STATUS(status, NT_STATUS_OK);
2190
2191 torture_comment(tctx, "try and access file with base rights - should be OK\n");
2192 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA;
2193 status = smb_raw_open(cli->tree, tctx, &io);
2194 CHECK_STATUS(status, NT_STATUS_OK);
2195 fnum2 = io.ntcreatex.out.file.fnum;
2196 smbcli_close(cli->tree, fnum2);
2197
2198
2199 torture_comment(tctx, "try and access now - should be OK if dynamic inheritance works\n");
2200 io.ntcreatex.in.access_mask = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
2201 status = smb_raw_open(cli->tree, tctx, &io);
2202 if (NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
2203 torture_comment(tctx, "Server does not have dynamic inheritance\n");
2204 }
2205 if (NT_STATUS_EQUAL(status, NT_STATUS_OK)) {
2206 torture_comment(tctx, "Server does have dynamic inheritance\n");
2207 }
2208 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
2209
2210 smbcli_unlink(cli->tree, fname1);
2211
2212 done:
2213 if (sd_orig != NULL) {
2214 torture_comment(tctx, "put back original sd\n");
2215 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2216 set.set_secdesc.in.file.fnum = fnum;
2217 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2218 set.set_secdesc.in.sd = sd_orig;
2219 status = smb_raw_setfileinfo(cli->tree, &set);
2220 }
2221 smbcli_close(cli->tree, fnum);
2222 smbcli_rmdir(cli->tree, dname);
2223 smb_raw_exit(cli->session);
2224 smbcli_deltree(cli->tree, BASEDIR);
2225
2226 return ret;
2227 }
2228
2229 #define CHECK_STATUS_FOR_BIT_ACTION(status, bits, action) do { \
2230 if (!(bits & desired_64)) {\
2231 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED); \
2232 action; \
2233 } else { \
2234 CHECK_STATUS(status, NT_STATUS_OK); \
2235 } \
2236 } while (0)
2237
2238 #define CHECK_STATUS_FOR_BIT(status, bits, access) do { \
2239 if (NT_STATUS_IS_OK(status)) { \
2240 if (!(granted & access)) {\
2241 ret = false; \
2242 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are not granted! granted[0x%08X] desired[0x%08X]\n", \
2243 __location__, nt_errstr(status), access, granted, desired); \
2244 goto done; \
2245 } \
2246 } else { \
2247 if (granted & access) {\
2248 ret = false; \
2249 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are granted! granted[0x%08X] desired[0x%08X]\n", \
2250 __location__, nt_errstr(status), access, granted, desired); \
2251 goto done; \
2252 } \
2253 } \
2254 CHECK_STATUS_FOR_BIT_ACTION(status, bits, do {} while (0)); \
2255 } while (0)
2256
2257 #if 0
2258
2259 /* test what access mask is needed for getting and setting security_descriptors
2260 Test copied to smb2/acls.c for SMB2. */
2261 static bool test_sd_get_set(struct torture_context *tctx,
2262 struct smbcli_state *cli)
2263 {
2264 NTSTATUS status;
2265 bool ret = true;
2266 union smb_open io;
2267 union smb_fileinfo fi;
2268 union smb_setfileinfo si;
2269 struct security_descriptor *sd;
2270 struct security_descriptor *sd_owner = NULL;
2271 struct security_descriptor *sd_group = NULL;
2272 struct security_descriptor *sd_dacl = NULL;
2273 struct security_descriptor *sd_sacl = NULL;
2274 int fnum=0;
2275 const char *fname = BASEDIR "\\sd_get_set.txt";
2276 uint64_t desired_64;
2277 uint32_t desired = 0, granted;
2278 int i = 0;
2279 #define NO_BITS_HACK (((uint64_t)1)<<32)
2280 uint64_t open_bits =
2281 SEC_MASK_GENERIC |
2282 SEC_FLAG_SYSTEM_SECURITY |
2283 SEC_FLAG_MAXIMUM_ALLOWED |
2284 SEC_STD_ALL |
2285 SEC_FILE_ALL |
2286 NO_BITS_HACK;
2287 uint64_t get_owner_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
2288 uint64_t set_owner_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
2289 uint64_t get_group_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
2290 uint64_t set_group_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
2291 uint64_t get_dacl_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
2292 uint64_t set_dacl_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_DAC;
2293 uint64_t get_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
2294 uint64_t set_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
2295
2296 if (!torture_setup_dir(cli, BASEDIR))
2297 return false;
2298
2299 torture_comment(tctx, "TESTING ACCESS MASKS FOR SD GET/SET\n");
2300
2301 /* first create a file with full access for everyone */
2302 sd = security_descriptor_dacl_create(tctx,
2303 0, SID_NT_ANONYMOUS, SID_BUILTIN_USERS,
2304 SID_WORLD,
2305 SEC_ACE_TYPE_ACCESS_ALLOWED,
2306 SEC_GENERIC_ALL,
2307 0,
2308 NULL);
2309 sd->type |= SEC_DESC_SACL_PRESENT;
2310 sd->sacl = NULL;
2311 io.ntcreatex.level = RAW_OPEN_NTTRANS_CREATE;
2312 io.ntcreatex.in.root_fid.fnum = 0;
2313 io.ntcreatex.in.flags = 0;
2314 io.ntcreatex.in.access_mask = SEC_GENERIC_ALL;
2315 io.ntcreatex.in.create_options = 0;
2316 io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
2317 io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
2318 io.ntcreatex.in.alloc_size = 0;
2319 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OVERWRITE_IF;
2320 io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
2321 io.ntcreatex.in.security_flags = 0;
2322 io.ntcreatex.in.fname = fname;
2323 io.ntcreatex.in.sec_desc = sd;
2324 io.ntcreatex.in.ea_list = NULL;
2325 status = smb_raw_open(cli->tree, tctx, &io);
2326 CHECK_STATUS(status, NT_STATUS_OK);
2327 fnum = io.ntcreatex.out.file.fnum;
2328
2329 status = smbcli_close(cli->tree, fnum);
2330 CHECK_STATUS(status, NT_STATUS_OK);
2331
2332 /*
2333 * now try each access_mask bit and no bit at all in a loop
2334 * and see what's allowed
2335 * NOTE: if i == 32 it means access_mask = 0 (see NO_BITS_HACK above)
2336 */
2337 for (i=0; i <= 32; i++) {
2338 desired_64 = ((uint64_t)1) << i;
2339 desired = (uint32_t)desired_64;
2340
2341 /* first open the file with the desired access */
2342 io.ntcreatex.level = RAW_OPEN_NTCREATEX;
2343 io.ntcreatex.in.access_mask = desired;
2344 io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
2345 status = smb_raw_open(cli->tree, tctx, &io);
2346 CHECK_STATUS_FOR_BIT_ACTION(status, open_bits, goto next);
2347 fnum = io.ntcreatex.out.file.fnum;
2348
2349 /* then check what access was granted */
2350 fi.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION;
2351 fi.access_information.in.file.fnum = fnum;
2352 status = smb_raw_fileinfo(cli->tree, tctx, &fi);
2353 CHECK_STATUS(status, NT_STATUS_OK);
2354 granted = fi.access_information.out.access_flags;
2355
2356 /* test the owner */
2357 ZERO_STRUCT(fi);
2358 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2359 fi.query_secdesc.in.file.fnum = fnum;
2360 fi.query_secdesc.in.secinfo_flags = SECINFO_OWNER;
2361 status = smb_raw_fileinfo(cli->tree, tctx, &fi);
2362 CHECK_STATUS_FOR_BIT(status, get_owner_bits, SEC_STD_READ_CONTROL);
2363 if (fi.query_secdesc.out.sd) {
2364 sd_owner = fi.query_secdesc.out.sd;
2365 } else if (!sd_owner) {
2366 sd_owner = sd;
2367 }
2368 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2369 si.set_secdesc.in.file.fnum = fnum;
2370 si.set_secdesc.in.secinfo_flags = SECINFO_OWNER;
2371 si.set_secdesc.in.sd = sd_owner;
2372 status = smb_raw_setfileinfo(cli->tree, &si);
2373 CHECK_STATUS_FOR_BIT(status, set_owner_bits, SEC_STD_WRITE_OWNER);
2374
2375 /* test the group */
2376 ZERO_STRUCT(fi);
2377 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2378 fi.query_secdesc.in.file.fnum = fnum;
2379 fi.query_secdesc.in.secinfo_flags = SECINFO_GROUP;
2380 status = smb_raw_fileinfo(cli->tree, tctx, &fi);
2381 CHECK_STATUS_FOR_BIT(status, get_group_bits, SEC_STD_READ_CONTROL);
2382 if (fi.query_secdesc.out.sd) {
2383 sd_group = fi.query_secdesc.out.sd;
2384 } else if (!sd_group) {
2385 sd_group = sd;
2386 }
2387 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2388 si.set_secdesc.in.file.fnum = fnum;
2389 si.set_secdesc.in.secinfo_flags = SECINFO_GROUP;
2390 si.set_secdesc.in.sd = sd_group;
2391 status = smb_raw_setfileinfo(cli->tree, &si);
2392 CHECK_STATUS_FOR_BIT(status, set_group_bits, SEC_STD_WRITE_OWNER);
2393
2394 /* test the DACL */
2395 ZERO_STRUCT(fi);
2396 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2397 fi.query_secdesc.in.file.fnum = fnum;
2398 fi.query_secdesc.in.secinfo_flags = SECINFO_DACL;
2399 status = smb_raw_fileinfo(cli->tree, tctx, &fi);
2400 CHECK_STATUS_FOR_BIT(status, get_dacl_bits, SEC_STD_READ_CONTROL);
2401 if (fi.query_secdesc.out.sd) {
2402 sd_dacl = fi.query_secdesc.out.sd;
2403 } else if (!sd_dacl) {
2404 sd_dacl = sd;
2405 }
2406 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2407 si.set_secdesc.in.file.fnum = fnum;
2408 si.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2409 si.set_secdesc.in.sd = sd_dacl;
2410 status = smb_raw_setfileinfo(cli->tree, &si);
2411 CHECK_STATUS_FOR_BIT(status, set_dacl_bits, SEC_STD_WRITE_DAC);
2412
2413 /* test the SACL */
2414 ZERO_STRUCT(fi);
2415 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2416 fi.query_secdesc.in.file.fnum = fnum;
2417 fi.query_secdesc.in.secinfo_flags = SECINFO_SACL;
2418 status = smb_raw_fileinfo(cli->tree, tctx, &fi);
2419 CHECK_STATUS_FOR_BIT(status, get_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
2420 if (fi.query_secdesc.out.sd) {
2421 sd_sacl = fi.query_secdesc.out.sd;
2422 } else if (!sd_sacl) {
2423 sd_sacl = sd;
2424 }
2425 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2426 si.set_secdesc.in.file.fnum = fnum;
2427 si.set_secdesc.in.secinfo_flags = SECINFO_SACL;
2428 si.set_secdesc.in.sd = sd_sacl;
2429 status = smb_raw_setfileinfo(cli->tree, &si);
2430 CHECK_STATUS_FOR_BIT(status, set_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
2431
2432 /* close the handle */
2433 status = smbcli_close(cli->tree, fnum);
2434 CHECK_STATUS(status, NT_STATUS_OK);
2435 next:
2436 continue;
2437 }
2438
2439 done:
2440 smbcli_close(cli->tree, fnum);
2441 smbcli_unlink(cli->tree, fname);
2442 smb_raw_exit(cli->session);
2443 smbcli_deltree(cli->tree, BASEDIR);
2444
2445 return ret;
2446 }
2447
2448 #endif
2449
2450 /*
2451 basic testing of security descriptor calls
2452 */
2453 struct torture_suite *torture_raw_acls(TALLOC_CTX *mem_ctx)
2454 {
2455 struct torture_suite *suite = torture_suite_create(mem_ctx, "acls");
2456
2457 torture_suite_add_1smb_test(suite, "sd", test_sd);
2458 torture_suite_add_1smb_test(suite, "create_file", test_nttrans_create_file);
2459 torture_suite_add_1smb_test(suite, "create_dir", test_nttrans_create_dir);
2460 torture_suite_add_1smb_test(suite, "nulldacl", test_nttrans_create_null_dacl);
2461 torture_suite_add_1smb_test(suite, "creator", test_creator_sid);
2462 torture_suite_add_1smb_test(suite, "generic", test_generic_bits);
2463 torture_suite_add_1smb_test(suite, "owner", test_owner_bits);
2464 torture_suite_add_1smb_test(suite, "inheritance", test_inheritance);
2465
2466 torture_suite_add_1smb_test(suite, "INHERITFLAGS", test_inheritance_flags);
2467 torture_suite_add_1smb_test(suite, "dynamic", test_inheritance_dynamic);
2468 #if 0
2469 /* XXX This test does not work against XP or Vista. */
2470 torture_suite_add_1smb_test(suite, "GETSET", test_sd_get_set);
2471 #endif
2472
2473 return suite;
2474 }
reg import