2 Unix SMB/CIFS mplementation.
3 LDAP protocol helper functions for SAMBA
4 Copyright (C) Jean François Micouleau 1998
5 Copyright (C) Gerald Carter 2001-2003
6 Copyright (C) Shahms King 2001
7 Copyright (C) Andrew Bartlett 2002-2003
8 Copyright (C) Stefan (metze) Metzmacher 2002-2003
10 This program is free software; you can redistribute it and/or modify
11 it under the terms of the GNU General Public License as published by
12 the Free Software Foundation; either version 2 of the License, or
13 (at your option) any later version.
15 This program is distributed in the hope that it will be useful,
16 but WITHOUT ANY WARRANTY; without even the implied warranty of
17 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18 GNU General Public License for more details.
20 You should have received a copy of the GNU General Public License
21 along with this program; if not, write to the Free Software
22 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
29 #ifndef LDAP_OPT_SUCCESS
30 #define LDAP_OPT_SUCCESS 0
33 /* Try not to hit the up or down server forever */
35 #define SMBLDAP_DONT_PING_TIME 10 /* ping only all 10 seconds */
36 #define SMBLDAP_NUM_RETRIES 8 /* retry only 8 times */
38 #define SMBLDAP_IDLE_TIME 150 /* After 2.5 minutes disconnect */
41 /* attributes used by Samba 2.2 */
43 ATTRIB_MAP_ENTRY attrib_map_v22
[] = {
44 { LDAP_ATTR_UID
, "uid" },
45 { LDAP_ATTR_UIDNUMBER
, LDAP_ATTRIBUTE_UIDNUMBER
},
46 { LDAP_ATTR_GIDNUMBER
, LDAP_ATTRIBUTE_GIDNUMBER
},
47 { LDAP_ATTR_UNIX_HOME
, "homeDirectory" },
48 { LDAP_ATTR_PWD_LAST_SET
, "pwdLastSet" },
49 { LDAP_ATTR_PWD_CAN_CHANGE
, "pwdCanChange" },
50 { LDAP_ATTR_PWD_MUST_CHANGE
, "pwdMustChange" },
51 { LDAP_ATTR_LOGON_TIME
, "logonTime" },
52 { LDAP_ATTR_LOGOFF_TIME
, "logoffTime" },
53 { LDAP_ATTR_KICKOFF_TIME
, "kickoffTime" },
54 { LDAP_ATTR_CN
, "cn" },
55 { LDAP_ATTR_DISPLAY_NAME
, "displayName" },
56 { LDAP_ATTR_HOME_PATH
, "smbHome" },
57 { LDAP_ATTR_HOME_DRIVE
, "homeDrives" },
58 { LDAP_ATTR_LOGON_SCRIPT
, "scriptPath" },
59 { LDAP_ATTR_PROFILE_PATH
, "profilePath" },
60 { LDAP_ATTR_DESC
, "description" },
61 { LDAP_ATTR_USER_WKS
, "userWorkstations"},
62 { LDAP_ATTR_USER_RID
, "rid" },
63 { LDAP_ATTR_PRIMARY_GROUP_RID
, "primaryGroupID"},
64 { LDAP_ATTR_LMPW
, "lmPassword" },
65 { LDAP_ATTR_NTPW
, "ntPassword" },
66 { LDAP_ATTR_DOMAIN
, "domain" },
67 { LDAP_ATTR_OBJCLASS
, "objectClass" },
68 { LDAP_ATTR_ACB_INFO
, "acctFlags" },
69 { LDAP_ATTR_LIST_END
, NULL
}
72 /* attributes used by Samba 3.0's sambaSamAccount */
74 ATTRIB_MAP_ENTRY attrib_map_v30
[] = {
75 { LDAP_ATTR_UID
, "uid" },
76 { LDAP_ATTR_UIDNUMBER
, LDAP_ATTRIBUTE_UIDNUMBER
},
77 { LDAP_ATTR_GIDNUMBER
, LDAP_ATTRIBUTE_GIDNUMBER
},
78 { LDAP_ATTR_UNIX_HOME
, "homeDirectory" },
79 { LDAP_ATTR_PWD_LAST_SET
, "sambaPwdLastSet" },
80 { LDAP_ATTR_PWD_CAN_CHANGE
, "sambaPwdCanChange" },
81 { LDAP_ATTR_PWD_MUST_CHANGE
, "sambaPwdMustChange" },
82 { LDAP_ATTR_LOGON_TIME
, "sambaLogonTime" },
83 { LDAP_ATTR_LOGOFF_TIME
, "sambaLogoffTime" },
84 { LDAP_ATTR_KICKOFF_TIME
, "sambaKickoffTime" },
85 { LDAP_ATTR_CN
, "cn" },
86 { LDAP_ATTR_DISPLAY_NAME
, "displayName" },
87 { LDAP_ATTR_HOME_DRIVE
, "sambaHomeDrive" },
88 { LDAP_ATTR_HOME_PATH
, "sambaHomePath" },
89 { LDAP_ATTR_LOGON_SCRIPT
, "sambaLogonScript" },
90 { LDAP_ATTR_PROFILE_PATH
, "sambaProfilePath" },
91 { LDAP_ATTR_DESC
, "description" },
92 { LDAP_ATTR_USER_WKS
, "sambaUserWorkstations" },
93 { LDAP_ATTR_USER_SID
, LDAP_ATTRIBUTE_SID
},
94 { LDAP_ATTR_PRIMARY_GROUP_SID
, "sambaPrimaryGroupSID" },
95 { LDAP_ATTR_LMPW
, "sambaLMPassword" },
96 { LDAP_ATTR_NTPW
, "sambaNTPassword" },
97 { LDAP_ATTR_DOMAIN
, "sambaDomainName" },
98 { LDAP_ATTR_OBJCLASS
, "objectClass" },
99 { LDAP_ATTR_ACB_INFO
, "sambaAcctFlags" },
100 { LDAP_ATTR_MUNGED_DIAL
, "sambaMungedDial" },
101 { LDAP_ATTR_BAD_PASSWORD_COUNT
, "sambaBadPasswordCount" },
102 { LDAP_ATTR_BAD_PASSWORD_TIME
, "sambaBadPasswordTime" },
103 { LDAP_ATTR_LIST_END
, NULL
}
106 /* attributes used for alalocating RIDs */
108 ATTRIB_MAP_ENTRY dominfo_attr_list
[] = {
109 { LDAP_ATTR_DOMAIN
, "sambaDomainName" },
110 { LDAP_ATTR_NEXT_RID
, "sambaNextRid" },
111 { LDAP_ATTR_NEXT_USERRID
, "sambaNextUserRid" },
112 { LDAP_ATTR_NEXT_GROUPRID
, "sambaNextGroupRid" },
113 { LDAP_ATTR_DOM_SID
, LDAP_ATTRIBUTE_SID
},
114 { LDAP_ATTR_ALGORITHMIC_RID_BASE
,"sambaAlgorithmicRidBase"},
115 { LDAP_ATTR_OBJCLASS
, "objectClass" },
116 { LDAP_ATTR_LIST_END
, NULL
},
119 /* Samba 3.0 group mapping attributes */
121 ATTRIB_MAP_ENTRY groupmap_attr_list
[] = {
122 { LDAP_ATTR_GIDNUMBER
, LDAP_ATTRIBUTE_GIDNUMBER
},
123 { LDAP_ATTR_GROUP_SID
, LDAP_ATTRIBUTE_SID
},
124 { LDAP_ATTR_GROUP_TYPE
, "sambaGroupType" },
125 { LDAP_ATTR_DESC
, "description" },
126 { LDAP_ATTR_DISPLAY_NAME
, "displayName" },
127 { LDAP_ATTR_CN
, "cn" },
128 { LDAP_ATTR_OBJCLASS
, "objectClass" },
129 { LDAP_ATTR_LIST_END
, NULL
}
132 ATTRIB_MAP_ENTRY groupmap_attr_list_to_delete
[] = {
133 { LDAP_ATTR_GROUP_SID
, LDAP_ATTRIBUTE_SID
},
134 { LDAP_ATTR_GROUP_TYPE
, "sambaGroupType" },
135 { LDAP_ATTR_DESC
, "description" },
136 { LDAP_ATTR_DISPLAY_NAME
, "displayName" },
137 { LDAP_ATTR_LIST_END
, NULL
}
140 /* idmap_ldap sambaUnixIdPool */
142 ATTRIB_MAP_ENTRY idpool_attr_list
[] = {
143 { LDAP_ATTR_UIDNUMBER
, LDAP_ATTRIBUTE_UIDNUMBER
},
144 { LDAP_ATTR_GIDNUMBER
, LDAP_ATTRIBUTE_GIDNUMBER
},
145 { LDAP_ATTR_OBJCLASS
, "objectClass" },
146 { LDAP_ATTR_LIST_END
, NULL
}
149 ATTRIB_MAP_ENTRY sidmap_attr_list
[] = {
150 { LDAP_ATTR_SID
, LDAP_ATTRIBUTE_SID
},
151 { LDAP_ATTR_UIDNUMBER
, LDAP_ATTRIBUTE_UIDNUMBER
},
152 { LDAP_ATTR_GIDNUMBER
, LDAP_ATTRIBUTE_GIDNUMBER
},
153 { LDAP_ATTR_OBJCLASS
, "objectClass" },
154 { LDAP_ATTR_LIST_END
, NULL
}
157 /**********************************************************************
158 perform a simple table lookup and return the attribute name
159 **********************************************************************/
161 const char* get_attr_key2string( ATTRIB_MAP_ENTRY table
[], int key
)
165 while ( table
[i
].attrib
!= LDAP_ATTR_LIST_END
) {
166 if ( table
[i
].attrib
== key
)
167 return table
[i
].name
;
175 /**********************************************************************
176 Return the list of attribute names from a mapping table
177 **********************************************************************/
179 char** get_attr_list( ATTRIB_MAP_ENTRY table
[] )
184 while ( table
[i
].attrib
!= LDAP_ATTR_LIST_END
)
188 names
= (char**)malloc( sizeof(char*)*i
);
190 DEBUG(0,("get_attr_list: out of memory\n"));
195 while ( table
[i
].attrib
!= LDAP_ATTR_LIST_END
) {
196 names
[i
] = strdup( table
[i
].name
);
204 /*********************************************************************
206 ********************************************************************/
208 void free_attr_list( char **list
)
216 SAFE_FREE( list
[i
] );
223 /*******************************************************************
224 find the ldap password
225 ******************************************************************/
226 static BOOL
fetch_ldap_pw(char **dn
, char** pw
)
231 *dn
= smb_xstrdup(lp_ldap_admin_dn());
233 if (asprintf(&key
, "%s/%s", SECRETS_LDAP_BIND_PW
, *dn
) < 0) {
235 DEBUG(0, ("fetch_ldap_pw: asprintf failed!\n"));
238 *pw
=secrets_fetch(key
, &size
);
242 /* Upgrade 2.2 style entry */
244 char* old_style_key
= strdup(*dn
);
246 fstring old_style_pw
;
248 if (!old_style_key
) {
249 DEBUG(0, ("fetch_ldap_pw: strdup failed!\n"));
253 for (p
=old_style_key
; *p
; p
++)
254 if (*p
== ',') *p
= '/';
256 data
=secrets_fetch(old_style_key
, &size
);
257 if (!size
&& size
< sizeof(old_style_pw
)) {
258 DEBUG(0,("fetch_ldap_pw: neither ldap secret retrieved!\n"));
259 SAFE_FREE(old_style_key
);
264 size
= MIN(size
, sizeof(fstring
)-1);
265 strncpy(old_style_pw
, data
, size
);
266 old_style_pw
[size
] = 0;
270 if (!secrets_store_ldap_pw(*dn
, old_style_pw
)) {
271 DEBUG(0,("fetch_ldap_pw: ldap secret could not be upgraded!\n"));
272 SAFE_FREE(old_style_key
);
276 if (!secrets_delete(old_style_key
)) {
277 DEBUG(0,("fetch_ldap_pw: old ldap secret could not be deleted!\n"));
280 SAFE_FREE(old_style_key
);
282 *pw
= smb_xstrdup(old_style_pw
);
288 /*******************************************************************
289 Search an attribute and return the first value found.
290 ******************************************************************/
292 BOOL
smbldap_get_single_attribute (LDAP
* ldap_struct
, LDAPMessage
* entry
,
293 const char *attribute
, pstring value
)
302 if ((values
= ldap_get_values (ldap_struct
, entry
, attribute
)) == NULL
) {
303 DEBUG (10, ("smbldap_get_single_attribute: [%s] = [<does not exist>]\n", attribute
));
308 if (convert_string(CH_UTF8
, CH_UNIX
,values
[0], -1, value
, sizeof(pstring
)) == (size_t)-1) {
309 DEBUG(1, ("smbldap_get_single_attribute: string conversion of [%s] = [%s] failed!\n",
310 attribute
, values
[0]));
311 ldap_value_free(values
);
315 ldap_value_free(values
);
316 #ifdef DEBUG_PASSWORDS
317 DEBUG (100, ("smbldap_get_single_attribute: [%s] = [%s]\n", attribute
, value
));
322 /************************************************************************
323 Routine to manage the LDAPMod structure array
324 manage memory used by the array, by each struct, and values
325 ***********************************************************************/
327 void smbldap_set_mod (LDAPMod
*** modlist
, int modop
, const char *attribute
, const char *value
)
335 /* sanity checks on the mod values */
337 if (attribute
== NULL
|| *attribute
== '\0')
339 #if 0 /* commented out after discussion with abartlet. Do not reenable.
340 left here so other so re-add similar code --jerry */
341 if (value
== NULL
|| *value
== '\0')
347 mods
= (LDAPMod
**) malloc(sizeof(LDAPMod
*));
350 DEBUG(0, ("make_a_mod: out of memory!\n"));
356 for (i
= 0; mods
[i
] != NULL
; ++i
) {
357 if (mods
[i
]->mod_op
== modop
&& strequal(mods
[i
]->mod_type
, attribute
))
363 mods
= (LDAPMod
**) Realloc (mods
, (i
+ 2) * sizeof (LDAPMod
*));
366 DEBUG(0, ("make_a_mod: out of memory!\n"));
369 mods
[i
] = (LDAPMod
*) malloc(sizeof(LDAPMod
));
372 DEBUG(0, ("make_a_mod: out of memory!\n"));
375 mods
[i
]->mod_op
= modop
;
376 mods
[i
]->mod_values
= NULL
;
377 mods
[i
]->mod_type
= strdup(attribute
);
383 char *utf8_value
= NULL
;
386 if (mods
[i
]->mod_values
!= NULL
) {
387 for (; mods
[i
]->mod_values
[j
] != NULL
; j
++);
389 mods
[i
]->mod_values
= (char **)Realloc(mods
[i
]->mod_values
,
390 (j
+ 2) * sizeof (char *));
392 if (mods
[i
]->mod_values
== NULL
) {
393 DEBUG (0, ("make_a_mod: Memory allocation failure!\n"));
397 if (push_utf8_allocate(&utf8_value
, value
) == (size_t)-1) {
398 DEBUG (0, ("make_a_mod: String conversion failure!\n"));
402 mods
[i
]->mod_values
[j
] = utf8_value
;
404 mods
[i
]->mod_values
[j
+ 1] = NULL
;
409 /**********************************************************************
410 Set attribute to newval in LDAP, regardless of what value the
411 attribute had in LDAP before.
412 *********************************************************************/
414 void smbldap_make_mod(LDAP
*ldap_struct
, LDAPMessage
*existing
,
416 const char *attribute
, const char *newval
)
421 if (existing
!= NULL
) {
422 existed
= smbldap_get_single_attribute(ldap_struct
, existing
, attribute
, oldval
);
428 /* all of our string attributes are case insensitive */
430 if (existed
&& newval
&& (StrCaseCmp(oldval
, newval
) == 0)) {
432 /* Believe it or not, but LDAP will deny a delete and
433 an add at the same time if the values are the
439 /* There has been no value before, so don't delete it.
440 * Here's a possible race: We might end up with
441 * duplicate attributes */
442 /* By deleting exactly the value we found in the entry this
443 * should be race-free in the sense that the LDAP-Server will
444 * deny the complete operation if somebody changed the
445 * attribute behind our back. */
446 /* This will also allow modifying single valued attributes
447 * in Novell NDS. In NDS you have to first remove attribute and then
448 * you could add new value */
450 smbldap_set_mod(mods
, LDAP_MOD_DELETE
, attribute
, oldval
);
453 /* Regardless of the real operation (add or modify)
454 we add the new value here. We rely on deleting
455 the old value, should it exist. */
457 if ((newval
!= NULL
) && (strlen(newval
) > 0)) {
458 smbldap_set_mod(mods
, LDAP_MOD_ADD
, attribute
, newval
);
462 /**********************************************************************
463 Some varients of the LDAP rebind code do not pass in the third 'arg'
464 pointer to a void*, so we try and work around it by assuming that the
465 value of the 'LDAP *' pointer is the same as the one we had passed in
466 **********************************************************************/
468 struct smbldap_state_lookup
{
470 struct smbldap_state
*smbldap_state
;
471 struct smbldap_state_lookup
*prev
, *next
;
474 static struct smbldap_state_lookup
*smbldap_state_lookup_list
;
476 static struct smbldap_state
*smbldap_find_state(LDAP
*ld
)
478 struct smbldap_state_lookup
*t
;
480 for (t
= smbldap_state_lookup_list
; t
; t
= t
->next
) {
482 return t
->smbldap_state
;
488 static void smbldap_delete_state(struct smbldap_state
*smbldap_state
)
490 struct smbldap_state_lookup
*t
;
492 for (t
= smbldap_state_lookup_list
; t
; t
= t
->next
) {
493 if (t
->smbldap_state
== smbldap_state
) {
494 DLIST_REMOVE(smbldap_state_lookup_list
, t
);
501 static void smbldap_store_state(LDAP
*ld
, struct smbldap_state
*smbldap_state
)
503 struct smbldap_state
*tmp_ldap_state
;
504 struct smbldap_state_lookup
*t
;
505 struct smbldap_state_lookup
*tmp
;
507 if ((tmp_ldap_state
= smbldap_find_state(ld
))) {
508 SMB_ASSERT(tmp_ldap_state
== smbldap_state
);
512 t
= smb_xmalloc(sizeof(*t
));
515 DLIST_ADD_END(smbldap_state_lookup_list
, t
, tmp
);
517 t
->smbldap_state
= smbldap_state
;
520 /*******************************************************************
521 open a connection to the ldap server.
522 ******************************************************************/
523 static int smbldap_open_connection (struct smbldap_state
*ldap_state
)
526 int rc
= LDAP_SUCCESS
;
528 BOOL ldap_v3
= False
;
529 LDAP
**ldap_struct
= &ldap_state
->ldap_struct
;
531 #ifdef HAVE_LDAP_INITIALIZE
532 DEBUG(10, ("smbldap_open_connection: %s\n", ldap_state
->uri
));
534 if ((rc
= ldap_initialize(ldap_struct
, ldap_state
->uri
)) != LDAP_SUCCESS
) {
535 DEBUG(0, ("ldap_initialize: %s\n", ldap_err2string(rc
)));
540 /* Parse the string manually */
546 const char *p
= ldap_state
->uri
;
547 SMB_ASSERT(sizeof(protocol
)>10 && sizeof(host
)>254);
549 /* skip leading "URL:" (if any) */
550 if ( strnequal( p
, "URL:", 4 ) ) {
554 sscanf(p
, "%10[^:]://%254[^:/]:%d", protocol
, host
, &port
);
557 if (strequal(protocol
, "ldap")) {
559 } else if (strequal(protocol
, "ldaps")) {
562 DEBUG(0, ("unrecognised protocol (%s)!\n", protocol
));
566 if ((*ldap_struct
= ldap_init(host
, port
)) == NULL
) {
567 DEBUG(0, ("ldap_init failed !\n"));
568 return LDAP_OPERATIONS_ERROR
;
571 if (strequal(protocol
, "ldaps")) {
572 #ifdef LDAP_OPT_X_TLS
573 int tls
= LDAP_OPT_X_TLS_HARD
;
574 if (ldap_set_option (*ldap_struct
, LDAP_OPT_X_TLS
, &tls
) != LDAP_SUCCESS
)
576 DEBUG(0, ("Failed to setup a TLS session\n"));
579 DEBUG(3,("LDAPS option set...!\n"));
581 DEBUG(0,("smbldap_open_connection: Secure connection not supported by LDAP client libraries!\n"));
582 return LDAP_OPERATIONS_ERROR
;
588 /* Store the LDAP pointer in a lookup list */
590 smbldap_store_state(*ldap_struct
, ldap_state
);
592 /* Upgrade to LDAPv3 if possible */
594 if (ldap_get_option(*ldap_struct
, LDAP_OPT_PROTOCOL_VERSION
, &version
) == LDAP_OPT_SUCCESS
)
596 if (version
!= LDAP_VERSION3
)
598 version
= LDAP_VERSION3
;
599 if (ldap_set_option (*ldap_struct
, LDAP_OPT_PROTOCOL_VERSION
, &version
) == LDAP_OPT_SUCCESS
) {
607 if (lp_ldap_ssl() == LDAP_SSL_START_TLS
) {
608 #ifdef LDAP_OPT_X_TLS
610 if ((rc
= ldap_start_tls_s (*ldap_struct
, NULL
, NULL
)) != LDAP_SUCCESS
)
612 DEBUG(0,("Failed to issue the StartTLS instruction: %s\n",
613 ldap_err2string(rc
)));
616 DEBUG (3, ("StartTLS issued: using a TLS connection\n"));
619 DEBUG(0, ("Need LDAPv3 for Start TLS\n"));
620 return LDAP_OPERATIONS_ERROR
;
623 DEBUG(0,("smbldap_open_connection: StartTLS not supported by LDAP client libraries!\n"));
624 return LDAP_OPERATIONS_ERROR
;
628 DEBUG(2, ("smbldap_open_connection: connection opened\n"));
633 /*******************************************************************
634 a rebind function for authenticated referrals
635 This version takes a void* that we can shove useful stuff in :-)
636 ******************************************************************/
637 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
639 static int rebindproc_with_state (LDAP
* ld
, char **whop
, char **credp
,
640 int *methodp
, int freeit
, void *arg
)
642 struct smbldap_state
*ldap_state
= arg
;
644 /** @TODO Should we be doing something to check what servers we rebind to?
645 Could we get a referral to a machine that we don't want to give our
646 username and password to? */
650 memset(*credp
, '\0', strlen(*credp
));
653 DEBUG(5,("rebind_proc_with_state: Rebinding as \"%s\"\n",
654 ldap_state
->bind_dn
));
656 *whop
= strdup(ldap_state
->bind_dn
);
658 return LDAP_NO_MEMORY
;
660 *credp
= strdup(ldap_state
->bind_secret
);
663 return LDAP_NO_MEMORY
;
665 *methodp
= LDAP_AUTH_SIMPLE
;
668 gettimeofday(&(ldap_state
->last_rebind
),NULL
);
672 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
674 /*******************************************************************
675 a rebind function for authenticated referrals
676 This version takes a void* that we can shove useful stuff in :-)
677 and actually does the connection.
678 ******************************************************************/
679 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
680 static int rebindproc_connect_with_state (LDAP
*ldap_struct
,
681 LDAP_CONST
char *url
,
683 ber_int_t msgid
, void *arg
)
685 struct smbldap_state
*ldap_state
= arg
;
687 DEBUG(5,("rebindproc_connect_with_state: Rebinding as \"%s\"\n",
688 ldap_state
->bind_dn
));
690 /** @TODO Should we be doing something to check what servers we rebind to?
691 Could we get a referral to a machine that we don't want to give our
692 username and password to? */
694 rc
= ldap_simple_bind_s(ldap_struct
, ldap_state
->bind_dn
, ldap_state
->bind_secret
);
696 gettimeofday(&(ldap_state
->last_rebind
),NULL
);
700 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
702 /*******************************************************************
703 Add a rebind function for authenticated referrals
704 ******************************************************************/
705 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
707 # if LDAP_SET_REBIND_PROC_ARGS == 2
708 static int rebindproc (LDAP
*ldap_struct
, char **whop
, char **credp
,
709 int *method
, int freeit
)
711 struct smbldap_state
*ldap_state
= smbldap_find_state(ldap_struct
);
713 return rebindproc_with_state(ldap_struct
, whop
, credp
,
714 method
, freeit
, ldap_state
);
717 # endif /*LDAP_SET_REBIND_PROC_ARGS == 2*/
718 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
720 /*******************************************************************
721 a rebind function for authenticated referrals
722 this also does the connection, but no void*.
723 ******************************************************************/
724 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
725 # if LDAP_SET_REBIND_PROC_ARGS == 2
726 static int rebindproc_connect (LDAP
* ld
, LDAP_CONST
char *url
, int request
,
729 struct smbldap_state
*ldap_state
= smbldap_find_state(ld
);
731 return rebindproc_connect_with_state(ld
, url
, (ber_tag_t
)request
, msgid
,
734 # endif /*LDAP_SET_REBIND_PROC_ARGS == 2*/
735 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
737 /*******************************************************************
738 connect to the ldap server under system privilege.
739 ******************************************************************/
740 static int smbldap_connect_system(struct smbldap_state
*ldap_state
, LDAP
* ldap_struct
)
746 /* get the password */
747 if (!fetch_ldap_pw(&ldap_dn
, &ldap_secret
))
749 DEBUG(0, ("ldap_connect_system: Failed to retrieve password from secrets.tdb\n"));
750 return LDAP_INVALID_CREDENTIALS
;
753 ldap_state
->bind_dn
= ldap_dn
;
754 ldap_state
->bind_secret
= ldap_secret
;
756 /* removed the sasl_bind_s "EXTERNAL" stuff, as my testsuite
757 (OpenLDAP) doesnt' seem to support it */
759 DEBUG(10,("ldap_connect_system: Binding to ldap server %s as \"%s\"\n",
760 ldap_state
->uri
, ldap_dn
));
762 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
763 # if LDAP_SET_REBIND_PROC_ARGS == 2
764 ldap_set_rebind_proc(ldap_struct
, &rebindproc_connect
);
766 # if LDAP_SET_REBIND_PROC_ARGS == 3
767 ldap_set_rebind_proc(ldap_struct
, &rebindproc_connect_with_state
, (void *)ldap_state
);
769 #else /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
770 # if LDAP_SET_REBIND_PROC_ARGS == 2
771 ldap_set_rebind_proc(ldap_struct
, &rebindproc
);
773 # if LDAP_SET_REBIND_PROC_ARGS == 3
774 ldap_set_rebind_proc(ldap_struct
, &rebindproc_with_state
, (void *)ldap_state
);
776 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
778 rc
= ldap_simple_bind_s(ldap_struct
, ldap_dn
, ldap_secret
);
780 if (rc
!= LDAP_SUCCESS
) {
781 char *ld_error
= NULL
;
782 ldap_get_option(ldap_state
->ldap_struct
, LDAP_OPT_ERROR_STRING
,
784 DEBUG(ldap_state
->num_failures
? 2 : 0,
785 ("failed to bind to server with dn= %s Error: %s\n\t%s\n",
786 ldap_dn
? ldap_dn
: "(unknown)", ldap_err2string(rc
),
787 ld_error
? ld_error
: "(unknown)"));
789 ldap_state
->num_failures
++;
793 ldap_state
->num_failures
= 0;
795 DEBUG(3, ("ldap_connect_system: succesful connection to the LDAP server\n"));
799 /**********************************************************************
800 Connect to LDAP server (called before every ldap operation)
801 *********************************************************************/
802 static int smbldap_open(struct smbldap_state
*ldap_state
)
805 SMB_ASSERT(ldap_state
);
807 #ifndef NO_LDAP_SECURITY
808 if (geteuid() != 0) {
809 DEBUG(0, ("smbldap_open: cannot access LDAP when not root..\n"));
810 return LDAP_INSUFFICIENT_ACCESS
;
814 if ((ldap_state
->ldap_struct
!= NULL
) && ((ldap_state
->last_ping
+ SMBLDAP_DONT_PING_TIME
) < time(NULL
))) {
815 struct sockaddr_un addr
;
816 socklen_t len
= sizeof(addr
);
818 if (ldap_get_option(ldap_state
->ldap_struct
, LDAP_OPT_DESC
, &sd
) == 0 &&
819 getpeername(sd
, (struct sockaddr
*) &addr
, &len
) < 0) {
820 /* the other end has died. reopen. */
821 ldap_unbind_ext(ldap_state
->ldap_struct
, NULL
, NULL
);
822 ldap_state
->ldap_struct
= NULL
;
823 ldap_state
->last_ping
= (time_t)0;
825 ldap_state
->last_ping
= time(NULL
);
829 if (ldap_state
->ldap_struct
!= NULL
) {
830 DEBUG(11,("smbldap_open: already connected to the LDAP server\n"));
834 if ((rc
= smbldap_open_connection(ldap_state
))) {
838 if ((rc
= smbldap_connect_system(ldap_state
, ldap_state
->ldap_struct
))) {
839 ldap_unbind_ext(ldap_state
->ldap_struct
, NULL
, NULL
);
840 ldap_state
->ldap_struct
= NULL
;
845 ldap_state
->last_ping
= time(NULL
);
846 DEBUG(4,("The LDAP server is succesful connected\n"));
851 /**********************************************************************
852 Disconnect from LDAP server
853 *********************************************************************/
854 static NTSTATUS
smbldap_close(struct smbldap_state
*ldap_state
)
857 return NT_STATUS_INVALID_PARAMETER
;
859 if (ldap_state
->ldap_struct
!= NULL
) {
860 ldap_unbind_ext(ldap_state
->ldap_struct
, NULL
, NULL
);
861 ldap_state
->ldap_struct
= NULL
;
864 smbldap_delete_state(ldap_state
);
866 DEBUG(5,("The connection to the LDAP server was closed\n"));
867 /* maybe free the results here --metze */
874 int smbldap_retry_open(struct smbldap_state
*ldap_state
, int *attempts
)
878 SMB_ASSERT(ldap_state
&& attempts
);
880 if (*attempts
!= 0) {
881 unsigned int sleep_time
;
884 /* Sleep for a random timeout */
885 rand_byte
= (char)(sys_random());
887 sleep_time
= (((*attempts
)*(*attempts
))/2)*rand_byte
*2;
888 /* we retry after (0.5, 1, 2, 3, 4.5, 6) seconds
891 DEBUG(3, ("Sleeping for %u milliseconds before reconnecting\n",
897 if ((rc
= smbldap_open(ldap_state
))) {
898 DEBUG(1,("Connection to LDAP Server failed for the %d try!\n",*attempts
));
906 /*********************************************************************
907 ********************************************************************/
909 int smbldap_search(struct smbldap_state
*ldap_state
,
910 const char *base
, int scope
, const char *filter
,
911 char *attrs
[], int attrsonly
,
914 int rc
= LDAP_SERVER_DOWN
;
918 SMB_ASSERT(ldap_state
);
920 DEBUG(5,("smbldap_search: base => [%s], filter => [%s], scope => [%d]\n",
921 base
, filter
, scope
));
923 if (ldap_state
->last_rebind
.tv_sec
> 0) {
930 gettimeofday(&tval
,NULL
);
932 tdiff
= 1000000 *(tval
.tv_sec
- ldap_state
->last_rebind
.tv_sec
) +
933 (tval
.tv_usec
- ldap_state
->last_rebind
.tv_usec
);
935 sleep_time
= ((1000*lp_ldap_replication_sleep())-tdiff
)/1000;
937 if (sleep_time
> 0) {
938 /* we wait for the LDAP replication */
939 DEBUG(5,("smbldap_search: waiting %d milliseconds for LDAP replication.\n",sleep_time
));
941 DEBUG(5,("smbldap_search: go on!\n"));
942 ZERO_STRUCT(ldap_state
->last_rebind
);
946 if (push_utf8_allocate(&utf8_filter
, filter
) == (size_t)-1) {
947 return LDAP_NO_MEMORY
;
950 while ((rc
== LDAP_SERVER_DOWN
) && (attempts
< SMBLDAP_NUM_RETRIES
)) {
952 if ((rc
= smbldap_retry_open(ldap_state
,&attempts
)) != LDAP_SUCCESS
)
955 rc
= ldap_search_s(ldap_state
->ldap_struct
, base
, scope
,
956 utf8_filter
, attrs
, attrsonly
, res
);
959 if (rc
== LDAP_SERVER_DOWN
) {
960 DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO
));
961 smbldap_close(ldap_state
);
964 ldap_state
->last_use
= time(NULL
);
966 SAFE_FREE(utf8_filter
);
970 int smbldap_modify(struct smbldap_state
*ldap_state
, const char *dn
, LDAPMod
*attrs
[])
972 int rc
= LDAP_SERVER_DOWN
;
976 SMB_ASSERT(ldap_state
);
978 DEBUG(5,("smbldap_modify: dn => [%s]\n", dn
));
980 if (push_utf8_allocate(&utf8_dn
, dn
) == (size_t)-1) {
981 return LDAP_NO_MEMORY
;
984 while ((rc
== LDAP_SERVER_DOWN
) && (attempts
< SMBLDAP_NUM_RETRIES
)) {
986 if ((rc
= smbldap_retry_open(ldap_state
,&attempts
)) != LDAP_SUCCESS
)
989 rc
= ldap_modify_s(ldap_state
->ldap_struct
, utf8_dn
, attrs
);
992 if (rc
== LDAP_SERVER_DOWN
) {
993 DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO
));
994 smbldap_close(ldap_state
);
997 ldap_state
->last_use
= time(NULL
);
1003 int smbldap_add(struct smbldap_state
*ldap_state
, const char *dn
, LDAPMod
*attrs
[])
1005 int rc
= LDAP_SERVER_DOWN
;
1009 SMB_ASSERT(ldap_state
);
1011 DEBUG(5,("smbldap_add: dn => [%s]\n", dn
));
1013 if (push_utf8_allocate(&utf8_dn
, dn
) == (size_t)-1) {
1014 return LDAP_NO_MEMORY
;
1017 while ((rc
== LDAP_SERVER_DOWN
) && (attempts
< SMBLDAP_NUM_RETRIES
)) {
1019 if ((rc
= smbldap_retry_open(ldap_state
,&attempts
)) != LDAP_SUCCESS
)
1022 rc
= ldap_add_s(ldap_state
->ldap_struct
, utf8_dn
, attrs
);
1025 if (rc
== LDAP_SERVER_DOWN
) {
1026 DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO
));
1027 smbldap_close(ldap_state
);
1030 ldap_state
->last_use
= time(NULL
);
1036 int smbldap_delete(struct smbldap_state
*ldap_state
, const char *dn
)
1038 int rc
= LDAP_SERVER_DOWN
;
1042 SMB_ASSERT(ldap_state
);
1044 DEBUG(5,("smbldap_delete: dn => [%s]\n", dn
));
1046 if (push_utf8_allocate(&utf8_dn
, dn
) == (size_t)-1) {
1047 return LDAP_NO_MEMORY
;
1050 while ((rc
== LDAP_SERVER_DOWN
) && (attempts
< SMBLDAP_NUM_RETRIES
)) {
1052 if ((rc
= smbldap_retry_open(ldap_state
,&attempts
)) != LDAP_SUCCESS
)
1055 rc
= ldap_delete_s(ldap_state
->ldap_struct
, utf8_dn
);
1058 if (rc
== LDAP_SERVER_DOWN
) {
1059 DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO
));
1060 smbldap_close(ldap_state
);
1063 ldap_state
->last_use
= time(NULL
);
1069 int smbldap_extended_operation(struct smbldap_state
*ldap_state
,
1070 LDAP_CONST
char *reqoid
, struct berval
*reqdata
,
1071 LDAPControl
**serverctrls
, LDAPControl
**clientctrls
,
1072 char **retoidp
, struct berval
**retdatap
)
1074 int rc
= LDAP_SERVER_DOWN
;
1080 while ((rc
== LDAP_SERVER_DOWN
) && (attempts
< SMBLDAP_NUM_RETRIES
)) {
1082 if ((rc
= smbldap_retry_open(ldap_state
,&attempts
)) != LDAP_SUCCESS
)
1085 rc
= ldap_extended_operation_s(ldap_state
->ldap_struct
, reqoid
, reqdata
,
1086 serverctrls
, clientctrls
, retoidp
, retdatap
);
1089 if (rc
== LDAP_SERVER_DOWN
) {
1090 DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO
));
1091 smbldap_close(ldap_state
);
1094 ldap_state
->last_use
= time(NULL
);
1099 /*******************************************************************
1100 run the search by name.
1101 ******************************************************************/
1102 int smbldap_search_suffix (struct smbldap_state
*ldap_state
, const char *filter
,
1103 char **search_attr
, LDAPMessage
** result
)
1105 int scope
= LDAP_SCOPE_SUBTREE
;
1108 rc
= smbldap_search(ldap_state
, lp_ldap_suffix(), scope
, filter
, search_attr
, 0, result
);
1110 if (rc
!= LDAP_SUCCESS
) {
1111 char *ld_error
= NULL
;
1112 ldap_get_option(ldap_state
->ldap_struct
, LDAP_OPT_ERROR_STRING
,
1114 DEBUG(0,("smbldap_search_suffix: Problem during the LDAP search: %s (%s)\n",
1115 ld_error
?ld_error
:"(unknown)", ldap_err2string (rc
)));
1116 SAFE_FREE(ld_error
);
1122 static void smbldap_idle_fn(void **data
, time_t *interval
, time_t now
)
1124 struct smbldap_state
*state
= (struct smbldap_state
*)(*data
);
1126 if (state
->ldap_struct
== NULL
) {
1127 DEBUG(10,("ldap connection not connected...\n"));
1131 if ((state
->last_use
+SMBLDAP_IDLE_TIME
) > now
) {
1132 DEBUG(10,("ldap connection not idle...\n"));
1136 DEBUG(7,("ldap connection idle...closing connection\n"));
1137 smbldap_close(state
);
1140 /**********************************************************************
1142 *********************************************************************/
1144 void smbldap_free_struct(struct smbldap_state
**ldap_state
)
1146 smbldap_close(*ldap_state
);
1148 if ((*ldap_state
)->bind_secret
) {
1149 memset((*ldap_state
)->bind_secret
, '\0', strlen((*ldap_state
)->bind_secret
));
1152 SAFE_FREE((*ldap_state
)->bind_dn
);
1153 SAFE_FREE((*ldap_state
)->bind_secret
);
1155 smb_unregister_idle_event((*ldap_state
)->event_id
);
1159 /* No need to free any further, as it is talloc()ed */
1163 /**********************************************************************
1164 Intitalise the 'general' ldap structures, on which ldap operations may be conducted
1165 *********************************************************************/
1167 NTSTATUS
smbldap_init(TALLOC_CTX
*mem_ctx
, const char *location
, struct smbldap_state
**smbldap_state
)
1169 *smbldap_state
= talloc_zero(mem_ctx
, sizeof(**smbldap_state
));
1170 if (!*smbldap_state
) {
1171 DEBUG(0, ("talloc() failed for ldapsam private_data!\n"));
1172 return NT_STATUS_NO_MEMORY
;
1176 (*smbldap_state
)->uri
= talloc_strdup(mem_ctx
, location
);
1178 (*smbldap_state
)->uri
= "ldap://localhost";
1181 (*smbldap_state
)->event_id
=
1182 smb_register_idle_event(smbldap_idle_fn
, (void *)(*smbldap_state
),
1185 if ((*smbldap_state
)->event_id
== SMB_EVENT_ID_INVALID
) {
1186 DEBUG(0,("Failed to register LDAP idle event!\n"));
1187 return NT_STATUS_INVALID_HANDLE
;
1190 return NT_STATUS_OK
;
1193 /**********************************************************************
1194 Add the sambaDomain to LDAP, so we don't have to search for this stuff
1195 again. This is a once-add operation for now.
1197 TODO: Add other attributes, and allow modification.
1198 *********************************************************************/
1199 static NTSTATUS
add_new_domain_info(struct smbldap_state
*ldap_state
,
1200 const char *domain_name
)
1203 fstring algorithmic_rid_base_string
;
1205 LDAPMod
**mods
= NULL
;
1208 LDAPMessage
*result
= NULL
;
1211 uid_t u_low
, u_high
;
1212 gid_t g_low
, g_high
;
1213 uint32 rid_low
, rid_high
;
1215 slprintf (filter
, sizeof (filter
) - 1, "(&(%s=%s)(objectclass=%s))",
1216 get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_DOMAIN
),
1217 domain_name
, LDAP_OBJ_DOMINFO
);
1219 attr_list
= get_attr_list( dominfo_attr_list
);
1220 rc
= smbldap_search_suffix(ldap_state
, filter
, attr_list
, &result
);
1221 free_attr_list( attr_list
);
1223 if (rc
!= LDAP_SUCCESS
) {
1224 return NT_STATUS_UNSUCCESSFUL
;
1227 num_result
= ldap_count_entries(ldap_state
->ldap_struct
, result
);
1229 if (num_result
> 1) {
1230 DEBUG (0, ("More than domain with that name exists: bailing out!\n"));
1231 ldap_msgfree(result
);
1232 return NT_STATUS_UNSUCCESSFUL
;
1235 /* Check if we need to add an entry */
1236 DEBUG(3,("Adding new domain\n"));
1237 ldap_op
= LDAP_MOD_ADD
;
1239 pstr_sprintf(dn
, "%s=%s,%s", get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_DOMAIN
),
1240 domain_name
, lp_ldap_suffix());
1242 /* Free original search */
1243 ldap_msgfree(result
);
1245 /* make the changes - the entry *must* not already have samba attributes */
1246 smbldap_set_mod(&mods
, LDAP_MOD_ADD
, get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_DOMAIN
),
1249 /* If we don't have an entry, then ask secrets.tdb for what it thinks.
1250 It may choose to make it up */
1252 sid_to_string(sid_string
, get_global_sam_sid());
1253 smbldap_set_mod(&mods
, LDAP_MOD_ADD
, get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_DOM_SID
), sid_string
);
1255 slprintf(algorithmic_rid_base_string
, sizeof(algorithmic_rid_base_string
) - 1, "%i", algorithmic_rid_base());
1256 smbldap_set_mod(&mods
, LDAP_MOD_ADD
, get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_ALGORITHMIC_RID_BASE
),
1257 algorithmic_rid_base_string
);
1258 smbldap_set_mod(&mods
, LDAP_MOD_ADD
, "objectclass", LDAP_OBJ_DOMINFO
);
1260 /* add the sambaNext[User|Group]Rid attributes if the idmap ranges are set.
1261 TODO: fix all the places where the line between idmap and normal operations
1262 needed by smbd gets fuzzy --jerry 2003-08-11 */
1264 if ( lp_idmap_uid(&u_low
, &u_high
) && lp_idmap_gid(&g_low
, &g_high
)
1265 && get_free_rid_range(&rid_low
, &rid_high
) )
1269 fstr_sprintf( rid_str
, "%i", rid_high
|USER_RID_TYPE
);
1270 DEBUG(10,("setting next available user rid [%s]\n", rid_str
));
1271 smbldap_set_mod(&mods
, LDAP_MOD_ADD
,
1272 get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_NEXT_USERRID
),
1275 fstr_sprintf( rid_str
, "%i", rid_high
|GROUP_RID_TYPE
);
1276 DEBUG(10,("setting next available group rid [%s]\n", rid_str
));
1277 smbldap_set_mod(&mods
, LDAP_MOD_ADD
,
1278 get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_NEXT_GROUPRID
),
1287 rc
= smbldap_add(ldap_state
, dn
, mods
);
1289 case LDAP_MOD_REPLACE
:
1290 rc
= smbldap_modify(ldap_state
, dn
, mods
);
1293 DEBUG(0,("Wrong LDAP operation type: %d!\n", ldap_op
));
1294 return NT_STATUS_INVALID_PARAMETER
;
1297 if (rc
!=LDAP_SUCCESS
) {
1298 char *ld_error
= NULL
;
1299 ldap_get_option(ldap_state
->ldap_struct
, LDAP_OPT_ERROR_STRING
, &ld_error
);
1300 DEBUG(1,("failed to %s domain dn= %s with: %s\n\t%s\n",
1301 ldap_op
== LDAP_MOD_ADD
? "add" : "modify",
1302 dn
, ldap_err2string(rc
),
1303 ld_error
?ld_error
:"unknown"));
1304 SAFE_FREE(ld_error
);
1306 ldap_mods_free(mods
, True
);
1307 return NT_STATUS_UNSUCCESSFUL
;
1310 DEBUG(2,("added: domain = %s in the LDAP database\n", domain_name
));
1311 ldap_mods_free(mods
, True
);
1312 return NT_STATUS_OK
;
1315 /**********************************************************************
1316 Search for the domain info entry
1317 *********************************************************************/
1318 NTSTATUS
smbldap_search_domain_info(struct smbldap_state
*ldap_state
,
1319 LDAPMessage
** result
, const char *domain_name
,
1322 NTSTATUS ret
= NT_STATUS_UNSUCCESSFUL
;
1328 pstr_sprintf(filter
, "(&(objectClass=%s)(%s=%s))",
1330 get_attr_key2string(dominfo_attr_list
, LDAP_ATTR_DOMAIN
),
1333 DEBUG(2, ("Searching for:[%s]\n", filter
));
1336 attr_list
= get_attr_list( dominfo_attr_list
);
1337 rc
= smbldap_search_suffix(ldap_state
, filter
, attr_list
, result
);
1338 free_attr_list( attr_list
);
1340 if (rc
!= LDAP_SUCCESS
) {
1341 DEBUG(2,("Problem during LDAPsearch: %s\n", ldap_err2string (rc
)));
1342 DEBUG(2,("Query was: %s, %s\n", lp_ldap_suffix(), filter
));
1343 } else if (ldap_count_entries(ldap_state
->ldap_struct
, *result
) < 1) {
1344 DEBUG(3, ("Got no domain info entries for domain\n"));
1345 ldap_msgfree(*result
);
1347 if (try_add
&& NT_STATUS_IS_OK(ret
= add_new_domain_info(ldap_state
, domain_name
))) {
1348 return smbldap_search_domain_info(ldap_state
, result
, domain_name
, False
);
1351 DEBUG(0, ("Adding domain info for %s failed with %s\n",
1352 domain_name
, nt_errstr(ret
)));
1355 } else if ((count
= ldap_count_entries(ldap_state
->ldap_struct
, *result
)) > 1) {
1356 DEBUG(0, ("Got too many (%d) domain info entries for domain %s\n",
1357 count
, domain_name
));
1358 ldap_msgfree(*result
);
1362 return NT_STATUS_OK
;
1368 /*******************************************************************
1369 Return a copy of the DN for a LDAPMessage. Convert from utf8 to CH_UNIX.
1370 ********************************************************************/
1372 char *smbldap_get_dn(LDAP
*ld
, LDAPMessage
*entry
)
1374 char *utf8_dn
, *unix_dn
;
1376 utf8_dn
= ldap_get_dn(ld
, entry
);
1378 DEBUG (5, ("smbldap_get_dn: ldap_get_dn failed\n"));
1381 if (pull_utf8_allocate(&unix_dn
, utf8_dn
) == (size_t)-1) {
1382 DEBUG (0, ("smbldap_get_dn: String conversion failure utf8 [%s]\n", utf8_dn
));
1385 ldap_memfree(utf8_dn
);