s4-smbtorture: fix spoolss_EnumPrinterDataEx tests.
[Samba/eduardoll.git] / source4 / torture / rpc / spoolss_win.c
blob5624e68d03fde1fcb3c28bd94dad02c5ae01c6bd
1 /*
2 Unix SMB/CIFS implementation.
3 test suite for spoolss rpc operations as performed by various win versions
5 Copyright (C) Kai Blin 2007
7 This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 3 of the License, or
10 (at your option) any later version.
12 This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with this program. If not, see <http://www.gnu.org/licenses/>.
21 #include "includes.h"
22 #include "torture/torture.h"
23 #include "torture/rpc/rpc.h"
24 #include "librpc/gen_ndr/ndr_spoolss_c.h"
25 #include "rpc_server/dcerpc_server.h"
26 #include "ntvfs/ntvfs.h"
27 #include "param/param.h"
29 struct test_spoolss_win_context {
30 /* EnumPrinters */
31 uint32_t printer_count;
32 union spoolss_PrinterInfo *printer_info;
33 union spoolss_PrinterInfo *current_info;
35 /* EnumPrinterKeys */
36 char *printer_keys;
39 /* This is a convenience function for all OpenPrinterEx calls */
40 static bool test_OpenPrinterEx(struct torture_context *tctx,
41 struct dcerpc_pipe *p,
42 struct policy_handle *handle,
43 const char *printer_name,
44 uint32_t access_mask)
46 NTSTATUS status;
47 struct spoolss_OpenPrinterEx op;
48 struct spoolss_UserLevel1 ul_1;
50 torture_comment(tctx, "Opening printer '%s'\n", printer_name);
52 op.in.printername = talloc_strdup(tctx, printer_name);
53 op.in.datatype = NULL;
54 op.in.devmode_ctr.devmode = NULL;
55 op.in.access_mask = access_mask;
56 op.in.level = 1;
57 op.in.userlevel.level1 = &ul_1;
58 op.out.handle = handle;
60 ul_1.size = 1234;
61 ul_1.client = "\\clientname";
62 ul_1.user = "username";
63 ul_1.build = 1;
64 ul_1.major = 2;
65 ul_1.minor = 3;
66 ul_1.processor = 4567;
68 status = dcerpc_spoolss_OpenPrinterEx(p, tctx, &op);
69 torture_assert_ntstatus_ok(tctx, status, "OpenPrinterEx failed");
70 torture_assert_werr_ok(tctx, op.out.result, "OpenPrinterEx failed");
72 return true;
75 static bool test_OpenPrinterAsAdmin(struct torture_context *tctx,
76 struct dcerpc_pipe *p,
77 const char *printername)
79 NTSTATUS status;
80 struct spoolss_OpenPrinterEx op;
81 struct spoolss_ClosePrinter cp;
82 struct spoolss_UserLevel1 ul_1;
83 struct policy_handle handle;
85 ul_1.size = 1234;
86 ul_1.client = "\\clientname";
87 ul_1.user = "username";
88 ul_1.build = 1;
89 ul_1.major = 2;
90 ul_1.minor = 3;
91 ul_1.processor = 4567;
93 op.in.printername = talloc_strdup(tctx, printername);
94 op.in.datatype = NULL;
95 op.in.devmode_ctr.devmode = NULL;
96 op.in.access_mask = SERVER_ALL_ACCESS;
97 op.in.level = 1;
98 op.in.userlevel.level1 = &ul_1;
99 op.out.handle = &handle;
101 cp.in.handle = &handle;
102 cp.out.handle = &handle;
104 torture_comment(tctx, "Testing OpenPrinterEx(%s) with admin rights\n",
105 op.in.printername);
107 status = dcerpc_spoolss_OpenPrinterEx(p, tctx, &op);
109 if (NT_STATUS_IS_OK(status) && W_ERROR_IS_OK(op.out.result)) {
110 status = dcerpc_spoolss_ClosePrinter(p, tctx, &cp);
111 torture_assert_ntstatus_ok(tctx, status, "ClosePrinter failed");
114 return true;
118 static bool test_ClosePrinter(struct torture_context *tctx,
119 struct dcerpc_pipe *p,
120 struct policy_handle *handle);
122 /* This replicates the opening sequence of OpenPrinterEx calls XP does */
123 static bool test_OpenPrinterSequence(struct torture_context *tctx,
124 struct dcerpc_pipe *p,
125 struct policy_handle *handle)
127 bool ret;
128 char *printername = talloc_asprintf(tctx, "\\\\%s",
129 dcerpc_server_name(p));
131 /* First, see if we can open the printer read_only */
132 ret = test_OpenPrinterEx(tctx, p, handle, printername, 0);
133 torture_assert(tctx, ret == true, "OpenPrinterEx failed.");
135 ret = test_ClosePrinter(tctx, p, handle);
136 torture_assert(tctx, ret, "ClosePrinter failed");
138 /* Now let's see if we have admin rights to it. */
139 ret = test_OpenPrinterAsAdmin(tctx, p, printername);
140 torture_assert(tctx, ret == true,
141 "OpenPrinterEx as admin failed unexpectedly.");
143 ret = test_OpenPrinterEx(tctx, p, handle, printername, SERVER_EXECUTE);
144 torture_assert(tctx, ret == true, "OpenPrinterEx failed.");
146 return true;
149 static bool test_GetPrinterData(struct torture_context *tctx,
150 struct dcerpc_pipe *p,
151 struct policy_handle *handle,
152 const char *value_name,
153 WERROR expected_werr,
154 uint32_t expected_value)
156 NTSTATUS status;
157 struct spoolss_GetPrinterData gpd;
158 uint32_t needed;
159 enum winreg_Type type;
160 union spoolss_PrinterData data;
162 torture_comment(tctx, "Testing GetPrinterData(%s).\n", value_name);
163 gpd.in.handle = handle;
164 gpd.in.value_name = value_name;
165 gpd.in.offered = 4;
166 gpd.out.needed = &needed;
167 gpd.out.type = &type;
168 gpd.out.data = &data;
170 status = dcerpc_spoolss_GetPrinterData(p, tctx, &gpd);
171 torture_assert_ntstatus_ok(tctx, status, "GetPrinterData failed.");
172 torture_assert_werr_equal(tctx, gpd.out.result, expected_werr,
173 "GetPrinterData did not return expected error value.");
175 if (W_ERROR_IS_OK(expected_werr)) {
176 torture_assert_int_equal(tctx, data.value,
177 expected_value,
178 "GetPrinterData did not return expected value.");
180 return true;
183 static bool test_EnumPrinters(struct torture_context *tctx,
184 struct dcerpc_pipe *p,
185 struct test_spoolss_win_context *ctx,
186 uint32_t initial_blob_size)
188 NTSTATUS status;
189 struct spoolss_EnumPrinters ep;
190 DATA_BLOB blob = data_blob_talloc_zero(ctx, initial_blob_size);
191 uint32_t needed;
192 uint32_t count;
193 union spoolss_PrinterInfo *info;
195 ep.in.flags = PRINTER_ENUM_NAME;
196 ep.in.server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
197 ep.in.level = 2;
198 ep.in.buffer = &blob;
199 ep.in.offered = initial_blob_size;
200 ep.out.needed = &needed;
201 ep.out.count = &count;
202 ep.out.info = &info;
204 status = dcerpc_spoolss_EnumPrinters(p, ctx, &ep);
205 torture_assert_ntstatus_ok(tctx, status, "EnumPrinters failed.");
207 if (W_ERROR_EQUAL(ep.out.result, WERR_INSUFFICIENT_BUFFER)) {
208 blob = data_blob_talloc_zero(ctx, needed);
209 ep.in.buffer = &blob;
210 ep.in.offered = needed;
211 status = dcerpc_spoolss_EnumPrinters(p, ctx, &ep);
212 torture_assert_ntstatus_ok(tctx, status,"EnumPrinters failed.");
215 torture_assert_werr_ok(tctx, ep.out.result, "EnumPrinters failed.");
217 ctx->printer_count = count;
218 ctx->printer_info = info;
220 torture_comment(tctx, "Found %d printer(s).\n", ctx->printer_count);
222 return true;
225 static bool test_GetPrinter(struct torture_context *tctx,
226 struct dcerpc_pipe *p,
227 struct policy_handle *handle,
228 struct test_spoolss_win_context *ctx,
229 uint32_t level,
230 uint32_t initial_blob_size)
232 NTSTATUS status;
233 struct spoolss_GetPrinter gp;
234 DATA_BLOB blob = data_blob_talloc_zero(ctx, initial_blob_size);
235 uint32_t needed;
237 torture_comment(tctx, "Test GetPrinter level %d\n", level);
239 gp.in.handle = handle;
240 gp.in.level = level;
241 gp.in.buffer = (initial_blob_size == 0)?NULL:&blob;
242 gp.in.offered = initial_blob_size;
243 gp.out.needed = &needed;
245 status = dcerpc_spoolss_GetPrinter(p, tctx, &gp);
246 torture_assert_ntstatus_ok(tctx, status, "GetPrinter failed");
248 if (W_ERROR_EQUAL(gp.out.result, WERR_INSUFFICIENT_BUFFER)) {
249 blob = data_blob_talloc_zero(ctx, needed);
250 gp.in.buffer = &blob;
251 gp.in.offered = needed;
252 status = dcerpc_spoolss_GetPrinter(p, tctx, &gp);
253 torture_assert_ntstatus_ok(tctx, status, "GetPrinter failed");
256 torture_assert_werr_ok(tctx, gp.out.result, "GetPrinter failed");
258 ctx->current_info = gp.out.info;
259 return true;
262 static bool test_EnumJobs(struct torture_context *tctx,
263 struct dcerpc_pipe *p,
264 struct policy_handle *handle)
266 NTSTATUS status;
267 struct spoolss_EnumJobs ej;
268 DATA_BLOB blob = data_blob_talloc_zero(tctx, 1024);
269 uint32_t needed;
270 uint32_t count;
271 union spoolss_JobInfo *info;
273 torture_comment(tctx, "Test EnumJobs\n");
275 ej.in.handle = handle;
276 ej.in.level = 2;
277 ej.in.buffer = &blob;
278 ej.in.offered = 1024;
279 ej.out.needed = &needed;
280 ej.out.count = &count;
281 ej.out.info = &info;
283 status = dcerpc_spoolss_EnumJobs(p, tctx, &ej);
284 torture_assert_ntstatus_ok(tctx, status, "EnumJobs failed");
285 torture_assert_werr_ok(tctx, ej.out.result, "EnumJobs failed");
287 return true;
290 static bool test_GetPrinterDriver2(struct torture_context *tctx,
291 struct dcerpc_pipe *p,
292 struct policy_handle *handle)
294 NTSTATUS status;
295 struct spoolss_GetPrinterDriver2 gpd2;
296 DATA_BLOB blob = data_blob_talloc_zero(tctx, 87424);
297 uint32_t needed;
298 uint32_t server_major_version;
299 uint32_t server_minor_version;
301 torture_comment(tctx, "Testing GetPrinterDriver2\n");
303 gpd2.in.handle = handle;
304 gpd2.in.architecture = "Windows NT x86";
305 gpd2.in.level = 101;
306 gpd2.in.buffer = &blob;
307 gpd2.in.offered = 87424;
308 gpd2.in.client_major_version = 3;
309 gpd2.in.client_minor_version = 0;
310 gpd2.out.needed = &needed;
311 gpd2.out.server_major_version = &server_major_version;
312 gpd2.out.server_minor_version = &server_minor_version;
314 status = dcerpc_spoolss_GetPrinterDriver2(p, tctx, &gpd2);
315 torture_assert_ntstatus_ok(tctx, status, "GetPrinterDriver2 failed");
316 torture_assert_werr_ok(tctx, gpd2.out.result,
317 "GetPrinterDriver2 failed.");
319 return true;
322 static bool test_EnumForms(struct torture_context *tctx,
323 struct dcerpc_pipe *p,
324 struct policy_handle *handle,
325 uint32_t initial_blob_size)
327 NTSTATUS status;
328 struct spoolss_EnumForms ef;
329 DATA_BLOB blob = data_blob_talloc_zero(tctx, initial_blob_size);
330 uint32_t needed;
331 uint32_t count;
332 union spoolss_FormInfo *info;
334 torture_comment(tctx, "Testing EnumForms\n");
336 ef.in.handle = handle;
337 ef.in.level = 1;
338 ef.in.buffer = (initial_blob_size == 0)?NULL:&blob;
339 ef.in.offered = initial_blob_size;
340 ef.out.needed = &needed;
341 ef.out.count = &count;
342 ef.out.info = &info;
344 status = dcerpc_spoolss_EnumForms(p, tctx, &ef);
345 torture_assert_ntstatus_ok(tctx, status, "EnumForms failed");
347 if (W_ERROR_EQUAL(ef.out.result, WERR_INSUFFICIENT_BUFFER)) {
348 blob = data_blob_talloc_zero(tctx, needed);
349 ef.in.buffer = &blob;
350 ef.in.offered = needed;
351 status = dcerpc_spoolss_EnumForms(p, tctx, &ef);
352 torture_assert_ntstatus_ok(tctx, status, "EnumForms failed");
355 torture_assert_werr_ok(tctx, ef.out.result, "EnumForms failed");
357 return true;
360 static bool test_EnumPrinterKey(struct torture_context *tctx,
361 struct dcerpc_pipe *p,
362 struct policy_handle *handle,
363 const char* key,
364 struct test_spoolss_win_context *ctx)
366 NTSTATUS status;
367 struct spoolss_EnumPrinterKey epk;
368 uint32_t needed = 0;
369 const char **key_buffer = NULL;
371 torture_comment(tctx, "Testing EnumPrinterKey(%s)\n", key);
373 epk.in.handle = handle;
374 epk.in.key_name = talloc_strdup(tctx, key);
375 epk.in.offered = 0;
376 epk.out.needed = &needed;
377 epk.out.key_buffer = &key_buffer;
379 status = dcerpc_spoolss_EnumPrinterKey(p, tctx, &epk);
380 torture_assert_ntstatus_ok(tctx, status, "EnumPrinterKey failed");
383 if (W_ERROR_EQUAL(epk.out.result, WERR_MORE_DATA)) {
384 epk.in.offered = needed;
385 status = dcerpc_spoolss_EnumPrinterKey(p, tctx, &epk);
386 torture_assert_ntstatus_ok(tctx, status,
387 "EnumPrinterKey failed");
390 torture_assert_werr_ok(tctx, epk.out.result, "EnumPrinterKey failed");
392 convert_string_talloc_convenience(ctx, lp_iconv_convenience(tctx->lp_ctx), CH_UTF16,
393 CH_UNIX, epk.out.key_buffer, *epk.out.needed,
394 (void**)&ctx->printer_keys, NULL, false);
396 return true;
399 static bool test_EnumPrinterDataEx(struct torture_context *tctx,
400 struct dcerpc_pipe *p,
401 struct policy_handle *handle,
402 const char *key,
403 uint32_t initial_blob_size,
404 WERROR expected_error)
406 NTSTATUS status;
407 struct spoolss_EnumPrinterDataEx epde;
408 struct spoolss_PrinterEnumValues *info;
409 uint32_t needed;
410 uint32_t count;
412 torture_comment(tctx, "Testing EnumPrinterDataEx(%s)\n", key);
414 epde.in.handle = handle;
415 epde.in.key_name = talloc_strdup(tctx, key);
416 epde.in.offered = 0;
417 epde.out.needed = &needed;
418 epde.out.count = &count;
419 epde.out.info = &info;
421 status = dcerpc_spoolss_EnumPrinterDataEx(p, tctx, &epde);
422 torture_assert_ntstatus_ok(tctx, status, "EnumPrinterDataEx failed.");
423 if (W_ERROR_EQUAL(epde.out.result, WERR_MORE_DATA)) {
424 epde.in.offered = needed;
425 status = dcerpc_spoolss_EnumPrinterDataEx(p, tctx, &epde);
426 torture_assert_ntstatus_ok(tctx, status,
427 "EnumPrinterDataEx failed.");
430 torture_assert_werr_equal(tctx, epde.out.result, expected_error,
431 "EnumPrinterDataEx failed.");
433 return true;
436 static bool test_ClosePrinter(struct torture_context *tctx,
437 struct dcerpc_pipe *p,
438 struct policy_handle *handle)
440 NTSTATUS status;
441 struct spoolss_ClosePrinter cp;
443 cp.in.handle = handle;
444 cp.out.handle = handle;
446 status = dcerpc_spoolss_ClosePrinter(p, tctx, &cp);
447 torture_assert_ntstatus_ok(tctx, status, "ClosePrinter failed");
449 return true;
452 static bool test_WinXP(struct torture_context *tctx, struct dcerpc_pipe *p)
454 bool ret = true;
455 struct test_spoolss_win_context *ctx, *tmp_ctx;
456 struct policy_handle handle01, handle02, handle03, handle04;
457 /* Sometimes a handle stays unused. In order to make this clear in the
458 * code, the unused_handle structures are used for that. */
459 struct policy_handle unused_handle1, unused_handle2;
460 char *server_name;
461 char *key_pointer;
463 ntvfs_init(tctx->lp_ctx);
465 ctx = talloc_zero(tctx, struct test_spoolss_win_context);
466 tmp_ctx = talloc_zero(tctx, struct test_spoolss_win_context);
468 ret &= test_OpenPrinterSequence(tctx, p, &handle01);
469 ret &= test_GetPrinterData(tctx, p, &handle01,"UISingleJobStatusString",
470 WERR_INVALID_PARAM, 0);
471 torture_comment(tctx, "Skip RemoteFindNextPrinterChangeNotifyEx test\n");
473 server_name = talloc_asprintf(ctx, "\\\\%s", dcerpc_server_name(p));
474 ret &= test_OpenPrinterEx(tctx, p, &unused_handle1, server_name, 0);
476 ret &= test_EnumPrinters(tctx, p, ctx, 1024);
478 ret &= test_OpenPrinterEx(tctx, p, &handle02, server_name, 0);
479 ret &= test_GetPrinterData(tctx, p, &handle02, "MajorVersion", WERR_OK,
481 ret &= test_ClosePrinter(tctx, p, &handle02);
483 /* If no printers were found, skip all tests that need a printer */
484 if (ctx->printer_count == 0) {
485 goto end_testWinXP;
488 ret &= test_OpenPrinterEx(tctx, p, &handle02,
489 ctx->printer_info[0].info2.printername,
490 PRINTER_ACCESS_USE);
491 ret &= test_GetPrinter(tctx, p, &handle02, ctx, 2, 0);
493 torture_assert_str_equal(tctx, ctx->current_info->info2.printername,
494 ctx->printer_info[0].info2.printername,
495 "GetPrinter returned unexpected printername");
496 /*FIXME: Test more components of the PrinterInfo2 struct */
498 ret &= test_OpenPrinterEx(tctx, p, &handle03,
499 ctx->printer_info[0].info2.printername, 0);
500 ret &= test_GetPrinter(tctx, p, &handle03, ctx, 0, 1164);
501 ret &= test_GetPrinter(tctx, p, &handle03, ctx, 2, 0);
503 ret &= test_OpenPrinterEx(tctx, p, &handle04,
504 ctx->printer_info[0].info2.printername, 0);
505 ret &= test_GetPrinter(tctx, p, &handle04, ctx, 2, 0);
506 ret &= test_ClosePrinter(tctx, p, &handle04);
508 ret &= test_OpenPrinterEx(tctx, p, &handle04,
509 ctx->printer_info[0].info2.printername, 0);
510 ret &= test_GetPrinter(tctx, p, &handle04, ctx, 2, 4096);
511 ret &= test_ClosePrinter(tctx, p, &handle04);
513 ret &= test_OpenPrinterAsAdmin(tctx, p,
514 ctx->printer_info[0].info2.printername);
516 ret &= test_OpenPrinterEx(tctx, p, &handle04,
517 ctx->printer_info[0].info2.printername, PRINTER_READ);
518 ret &= test_GetPrinterData(tctx, p, &handle04,"UISingleJobStatusString",
519 WERR_BADFILE, 0);
520 torture_comment(tctx, "Skip RemoteFindNextPrinterChangeNotifyEx test\n");
522 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
523 ctx->printer_info[0].info2.printername, 0);
525 ret &= test_EnumJobs(tctx, p, &handle04);
526 ret &= test_GetPrinter(tctx, p, &handle04, ctx, 2, 4096);
528 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
529 ret &= test_ClosePrinter(tctx, p, &handle04);
531 ret &= test_EnumPrinters(tctx, p, ctx, 1556);
532 ret &= test_GetPrinterDriver2(tctx, p, &handle03);
533 ret &= test_EnumForms(tctx, p, &handle03, 0);
535 ret &= test_EnumPrinterKey(tctx, p, &handle03, "", ctx);
536 key_pointer = ctx->printer_keys;
537 while(*key_pointer != '\0') {
538 char *end_pointer;
539 char *key_name;
541 for(end_pointer = key_pointer; *end_pointer != '\0';
542 ++end_pointer) {
543 /* Do nothing, just move the pointer */
545 key_name = talloc_strndup(tctx, key_pointer,
546 end_pointer - key_pointer);
548 ret &= test_EnumPrinterKey(tctx, p, &handle03, key_name,
549 tmp_ctx);
550 ret &= test_EnumPrinterDataEx(tctx, p, &handle03, key_name, 0,
551 WERR_OK);
553 key_pointer = ++end_pointer;
556 ret &= test_EnumPrinterDataEx(tctx, p, &handle03, "", 0,
557 WERR_INVALID_PARAM);
559 ret &= test_GetPrinter(tctx, p, &handle03, tmp_ctx, 2, 0);
561 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
562 ctx->printer_info[0].info2.printername, 0);
563 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
565 ret &= test_GetPrinter(tctx, p, &handle03, tmp_ctx, 2, 2556);
567 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
568 ctx->printer_info[0].info2.printername, 0);
569 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
571 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
572 ctx->printer_info[0].info2.printername, 0);
573 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
575 ret &= test_GetPrinter(tctx, p, &handle03, tmp_ctx, 7, 0);
577 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
578 ctx->printer_info[0].info2.printername, 0);
579 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
581 ret &= test_ClosePrinter(tctx, p, &handle03);
583 ret &= test_OpenPrinterEx(tctx, p, &unused_handle2,
584 ctx->printer_info[0].info2.printername, 0);
585 ret &= test_ClosePrinter(tctx, p, &unused_handle2);
587 ret &= test_OpenPrinterEx(tctx, p, &handle03, server_name, 0);
588 ret &= test_GetPrinterData(tctx, p, &handle03, "W3SvcInstalled",
589 WERR_OK, 0);
590 ret &= test_ClosePrinter(tctx, p, &handle03);
592 ret &= test_ClosePrinter(tctx, p, &unused_handle1);
593 ret &= test_ClosePrinter(tctx, p, &handle02);
595 ret &= test_OpenPrinterEx(tctx, p, &handle02,
596 ctx->printer_info[0].info2.sharename, 0);
597 ret &= test_GetPrinter(tctx, p, &handle02, tmp_ctx, 2, 0);
598 ret &= test_ClosePrinter(tctx, p, &handle02);
600 end_testWinXP:
601 ret &= test_ClosePrinter(tctx, p, &handle01);
603 talloc_free(tmp_ctx);
604 talloc_free(ctx);
605 return ret;
608 struct torture_suite *torture_rpc_spoolss_win(TALLOC_CTX *mem_ctx)
610 struct torture_suite *suite = torture_suite_create(mem_ctx, "SPOOLSS-WIN");
612 struct torture_rpc_tcase *tcase = torture_suite_add_rpc_iface_tcase(suite,
613 "win", &ndr_table_spoolss);
615 torture_rpc_tcase_add_test(tcase, "testWinXP", test_WinXP);
617 return suite;