| commit | 5f5969b3c5bd237277b8f2f1eaa4ddacce5fb63b | |
| author | Ivan Gyurdiev <ivg2@cornell.edu> | |
| Tue, 6 Jun 2006 06:46:59 +0000 (6 02:46 -0400) | ||
| committer | Alexandre Julliard <julliard@winehq.org> | |
| Tue, 6 Jun 2006 09:58:54 +0000 (6 11:58 +0200) | ||
| tree | 25b36978cc938da4f84a6aa1070a952d67e53ef0 | treesnapshot (tar.gz zip) |
| parent | 0909df6711d4e39d496dd302f8bbbe209eaa1d99 | commitdiff |
wined3d: Remove constant type field in stateblock.
It is wrong to maintain a mapping from a constant index to a type
field, because different constant types do not share an index -
boolean constant 0 is supposed to co-exist with floating point
constant 0, not replace it. Drawprim and other code using the type
array to decide whether to look up a constant in bools, floats, or
ints is wrong - you can't make that decision based on the index.
It is wrong to maintain a mapping from a constant index to a type
field, because different constant types do not share an index -
boolean constant 0 is supposed to co-exist with floating point
constant 0, not replace it. Drawprim and other code using the type
array to decide whether to look up a constant in bools, floats, or
ints is wrong - you can't make that decision based on the index.