| commit | 23156bef7e3e280a46f34a1e30d7ccf516117901 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 20 Aug 2015 17:12:46 +0000 (20 20:12 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 20 Aug 2015 17:12:46 +0000 (20 20:12 +0300) | ||
| tree | 2e3995d296c10dff82b3a1321b81cc22df599858 | treesnapshot (tar.gz zip) |
| parent | fcf3227ed50b114efca19c535b740426007c1eca | commitdiff |
double_checking: avoid more false positives
Oleg reported that there are false positives caused by backwards gotos.
Silence this by adding an "if (inside_loop()) " test.
If it is a known value then we don't need to check.
We seem not to need the code marked "FIXME: needed?" so I have deleted it.
I guess we do use "is_true" for ignoring duplicate checks to see that a
variable is non-NULL. I've just swapped that for an implied_condition_true()
test.
Reported-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oleg reported that there are false positives caused by backwards gotos.
Silence this by adding an "if (inside_loop()) " test.
If it is a known value then we don't need to check.
We seem not to need the code marked "FIXME: needed?" so I have deleted it.
I guess we do use "is_true" for ignoring duplicate checks to see that a
variable is non-NULL. I've just swapped that for an implied_condition_true()
test.
Reported-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| check_double_checking.c | diffblobblamehistory |