| commit | b86c9e59228c35c955d6758269755720cef78b50 | |
| author | Uoti Urpala <uau@glyph.nonexistent.invalid> | |
| Sun, 16 Jan 2011 18:59:11 +0000 (16 20:59 +0200) | ||
| committer | Uoti Urpala <uau@glyph.nonexistent.invalid> | |
| Tue, 18 Jan 2011 12:58:09 +0000 (18 14:58 +0200) | ||
| tree | 64e3dafc32eecdb71da4433386324e7032d12afc | treesnapshot (tar.gz zip) |
| parent | 8e7dae173d07533e1de46fad7bb2f834febe27cf | commitdiff |
subs/demux: don't try to enable sub track when creating it
demuxer.c new_sh_sub_sid() tried to immediately select the created sub
track for playback if its id matched the "-sid" option value. This was
buggy, as more initialization is needed to properly enable subtitles.
Normally the correct track to play is selected after the demuxer has
been created. It's possible that some DVD use case or such depended on
the removed code to make -sid work with a subtitle track that's not
found at start and only added later (vobsubs probably would start
playing without separate initialization); if so then that needs to be
fixed later in a different way.
demuxer.c new_sh_sub_sid() tried to immediately select the created sub
track for playback if its id matched the "-sid" option value. This was
buggy, as more initialization is needed to properly enable subtitles.
Normally the correct track to play is selected after the demuxer has
been created. It's possible that some DVD use case or such depended on
the removed code to make -sid work with a subtitle track that's not
found at start and only added later (vobsubs probably would start
playing without separate initialization); if so then that needs to be
fixed later in a different way.
| libmpdemux/demuxer.c | diffblobblamehistory |