| commit | efde8b6e16f11e7d1681c68d86c7fd51053cada7 | |
| author | David Howells <dhowells@redhat.com> | |
| Tue, 17 Jan 2012 20:39:40 +0000 (17 20:39 +0000) | ||
| committer | James Morris <jmorris@namei.org> | |
| Tue, 17 Jan 2012 23:41:27 +0000 (18 10:41 +1100) | ||
| tree | 4fb5e80428c4f36c5da35ff3319cd71c1771451c | treesnapshot (tar.gz zip) |
| parent | 25add8cf99c9ec8b8dc0acd8b9241e963fc0d29c | commitdiff |
KEYS: Add missing smp_rmb() primitives to the keyring search code
Add missing smp_rmb() primitives to the keyring search code.
When keyring payloads are appended to without replacement (thus using up spare
slots in the key pointer array), an smp_wmb() is issued between the pointer
assignment and the increment of the key count (nkeys).
There should be corresponding read barriers between the read of nkeys and
dereferences of keys[n] when n is dependent on the value of nkeys.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Add missing smp_rmb() primitives to the keyring search code.
When keyring payloads are appended to without replacement (thus using up spare
slots in the key pointer array), an smp_wmb() is issued between the pointer
assignment and the increment of the key count (nkeys).
There should be corresponding read barriers between the read of nkeys and
dereferences of keys[n] when n is dependent on the value of nkeys.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
| security/keys/gc.c | diffblobblamehistory | |
| security/keys/keyring.c | diffblobblamehistory |