| commit | c0a215161566b57f26743fd761f355b4dcdc8adf | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 5 Nov 2015 14:31:13 +0000 (5 17:31 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Thu, 5 Nov 2015 14:31:13 +0000 (5 17:31 +0300) | ||
| tree | 9afc6624bcd050aebc76ebb7027011440cb51504 | treesnapshot (tar.gz zip) |
| parent | 996c13b333213d282fafa84a8fa71e441b07efd4 | commitdiff |
extra: modifications inside WARN_ON() macros should not be ignored
We ignore code like:
WARN_ON(i >= ARRAY_SIZE(array)) {
The logic here is that does that mean it is possible or not?? There really
isn't any useful information there.
On the other hand if we had an assignment in there:
WARN_ON(frob(&mv_var));
Then we want to record the assignment obviously...
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
We ignore code like:
WARN_ON(i >= ARRAY_SIZE(array)) {
The logic here is that does that mean it is possible or not?? There really
isn't any useful information there.
On the other hand if we had an assignment in there:
WARN_ON(frob(&mv_var));
Then we want to record the assignment obviously...
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| smatch_extra.c | diffblobblamehistory |