| commit | 15842d06c0dab4f9fdaece1a6d47f3a0e72c3dea | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 16 May 2012 12:38:10 +0000 (16 15:38 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 16 May 2012 12:38:10 +0000 (16 15:38 +0300) | ||
| tree | 48663fa026e7b1f05ed43cf1e46acb480ed08225 | treesnapshot (tar.gz zip) |
| parent | a8464a015ec7d21f91ae2369437397cef352b8c7 | commitdiff |
extra: dereferencing a pointer means it is valid
If you see a pointer that is dereferenced, that means it is a valid
pointer.
The check for places that dereference first and then check ignored when
people did unneeded checks and it was clear from the context that the
pointer was non-NULL. Now that we set the pointer to non-NULL after a
dereference that means we have to turn on those warnings.
It still ends up silencing some warnings, when you check, then dereference,
then check again. But that used to get two warnings, so now it only gets
one. No big deal.
The sm_select2.c validation test isn't really doing anything. I've deleted
it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
If you see a pointer that is dereferenced, that means it is a valid
pointer.
The check for places that dereference first and then check ignored when
people did unneeded checks and it was clear from the context that the
pointer was non-NULL. Now that we set the pointer to non-NULL after a
dereference that means we have to turn on those warnings.
It still ends up silencing some warnings, when you check, then dereference,
then check again. But that used to get two warnings, so now it only gets
one. No big deal.
The sm_select2.c validation test isn't really doing anything. I've deleted
it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>