| commit | 019129ac0095671de52db5237bd908dbdc67d28f | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Mon, 8 Apr 2013 08:30:05 +0000 (8 11:30 +0300) | ||
| committer | Dan Carpenter <dan.carpenter@oracle.com> | |
| Mon, 8 Apr 2013 08:30:05 +0000 (8 11:30 +0300) | ||
| tree | a2f6128e1056afa4ab3e79bc25b83ab9de335ce4 | treesnapshot (tar.gz zip) |
| parent | ad71730fd2f67b4063b681f94b474b89e878608d | commitdiff |
locking: take returns values into consideration
There are a lot of places which, for example, take the lock on success
and return zero but don't take the lock on the failure paths. In the old
code this would generate a warning but now it shouldn't.
I use the broken-apart return value so if we get "return err;" it looks
at the individual paths which merge into "err" instead of taking them all
together.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There are a lot of places which, for example, take the lock on success
and return zero but don't take the lock on the failure paths. In the old
code this would generate a warning but now it shouldn't.
I use the broken-apart return value so if we get "return err;" it looks
at the individual paths which merge into "err" instead of taking them all
together.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| check_locking.c | diffblobblamehistory |