flash: fix error handling
[openocd/genbsdl.git] / src / flash / nor / core.c
blob2c1d9dee04dbcb29b12abb038e7d7f69679c8b8d
1 /***************************************************************************
2 * Copyright (C) 2005 by Dominic Rath <Dominic.Rath@gmx.de> *
3 * Copyright (C) 2007-2010 Øyvind Harboe <oyvind.harboe@zylin.com> *
4 * Copyright (C) 2008 by Spencer Oliver <spen@spen-soft.co.uk> *
5 * Copyright (C) 2009 Zachary T Welch <zw@superlucidity.net> *
6 * Copyright (C) 2010 by Antonio Borneo <borneo.antonio@gmail.com> *
7 * *
8 * This program is free software; you can redistribute it and/or modify *
9 * it under the terms of the GNU General Public License as published by *
10 * the Free Software Foundation; either version 2 of the License, or *
11 * (at your option) any later version. *
12 * *
13 * This program is distributed in the hope that it will be useful, *
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of *
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
16 * GNU General Public License for more details. *
17 * *
18 * You should have received a copy of the GNU General Public License *
19 * along with this program; if not, write to the *
20 * Free Software Foundation, Inc., *
21 * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *
22 ***************************************************************************/
24 #ifdef HAVE_CONFIG_H
25 #include <config.h>
26 #endif
27 #include <flash/common.h>
28 #include <flash/nor/core.h>
29 #include <flash/nor/imp.h>
30 #include <target/image.h>
33 /**
34 * @file
35 * Upper level of NOR flash framework.
36 * The lower level interfaces are to drivers. These upper level ones
37 * primarily support access from Tcl scripts or from GDB.
40 static struct flash_bank *flash_banks;
42 int flash_driver_erase(struct flash_bank *bank, int first, int last)
44 int retval;
46 retval = bank->driver->erase(bank, first, last);
47 if (retval != ERROR_OK)
49 LOG_ERROR("failed erasing sectors %d to %d (%d)", first, last, retval);
52 return retval;
55 int flash_driver_protect(struct flash_bank *bank, int set, int first, int last)
57 int retval;
59 /* callers may not supply illegal parameters ... */
60 if (first < 0 || first > last || last >= bank->num_sectors)
62 LOG_ERROR("illegal sector range");
63 return ERROR_FAIL;
66 /* force "set" to 0/1 */
67 set = !!set;
69 /* DANGER!
71 * We must not use any cached information about protection state!!!!
73 * There are a million things that could change the protect state:
75 * the target could have reset, power cycled, been hot plugged,
76 * the application could have run, etc.
78 * Drivers only receive valid sector range.
80 retval = bank->driver->protect(bank, set, first, last);
81 if (retval != ERROR_OK)
83 LOG_ERROR("failed setting protection for areas %d to %d (%d)", first, last, retval);
86 return retval;
89 int flash_driver_write(struct flash_bank *bank,
90 uint8_t *buffer, uint32_t offset, uint32_t count)
92 int retval;
94 retval = bank->driver->write(bank, buffer, offset, count);
95 if (retval != ERROR_OK)
97 LOG_ERROR("error writing to flash at address 0x%08" PRIx32 " at offset 0x%8.8" PRIx32 " (%d)",
98 bank->base, offset, retval);
101 return retval;
104 int flash_driver_read(struct flash_bank *bank,
105 uint8_t *buffer, uint32_t offset, uint32_t count)
107 int retval;
109 LOG_DEBUG("call flash_driver_read()");
111 retval = bank->driver->read(bank, buffer, offset, count);
112 if (retval != ERROR_OK)
114 LOG_ERROR("error reading to flash at address 0x%08" PRIx32 " at offset 0x%8.8" PRIx32 " (%d)",
115 bank->base, offset, retval);
118 return retval;
121 int default_flash_read(struct flash_bank *bank,
122 uint8_t *buffer, uint32_t offset, uint32_t count)
124 return target_read_buffer(bank->target, offset + bank->base, count, buffer);
127 void flash_bank_add(struct flash_bank *bank)
129 /* put flash bank in linked list */
130 unsigned bank_num = 0;
131 if (flash_banks)
133 /* find last flash bank */
134 struct flash_bank *p = flash_banks;
135 while (NULL != p->next)
137 bank_num += 1;
138 p = p->next;
140 p->next = bank;
141 bank_num += 1;
143 else
144 flash_banks = bank;
146 bank->bank_number = bank_num;
149 struct flash_bank *flash_bank_list(void)
151 return flash_banks;
154 struct flash_bank *get_flash_bank_by_num_noprobe(int num)
156 struct flash_bank *p;
157 int i = 0;
159 for (p = flash_banks; p; p = p->next)
161 if (i++ == num)
163 return p;
166 LOG_ERROR("flash bank %d does not exist", num);
167 return NULL;
170 int flash_get_bank_count(void)
172 struct flash_bank *p;
173 int i = 0;
174 for (p = flash_banks; p; p = p->next)
176 i++;
178 return i;
181 struct flash_bank *get_flash_bank_by_name_noprobe(const char *name)
183 unsigned requested = get_flash_name_index(name);
184 unsigned found = 0;
186 struct flash_bank *bank;
187 for (bank = flash_banks; NULL != bank; bank = bank->next)
189 if (strcmp(bank->name, name) == 0)
190 return bank;
191 if (!flash_driver_name_matches(bank->driver->name, name))
192 continue;
193 if (++found < requested)
194 continue;
195 return bank;
197 return NULL;
200 int get_flash_bank_by_name(const char *name, struct flash_bank **bank_result)
202 struct flash_bank *bank;
203 int retval;
205 bank = get_flash_bank_by_name_noprobe(name);
206 if (bank != NULL)
208 retval = bank->driver->auto_probe(bank);
210 if (retval != ERROR_OK)
212 LOG_ERROR("auto_probe failed %d\n", retval);
213 return retval;
217 *bank_result = bank;
218 return ERROR_OK;
221 int get_flash_bank_by_num(int num, struct flash_bank **bank)
223 struct flash_bank *p = get_flash_bank_by_num_noprobe(num);
224 int retval;
226 if (p == NULL)
228 return ERROR_FAIL;
231 retval = p->driver->auto_probe(p);
233 if (retval != ERROR_OK)
235 LOG_ERROR("auto_probe failed %d\n", retval);
236 return retval;
238 *bank = p;
239 return ERROR_OK;
242 /* lookup flash bank by address, bank not found is success, but
243 * result_bank is set to NULL. */
244 int get_flash_bank_by_addr(struct target *target, uint32_t addr, bool check, struct flash_bank **result_bank)
246 struct flash_bank *c;
248 /* cycle through bank list */
249 for (c = flash_banks; c; c = c->next)
251 int retval;
252 retval = c->driver->auto_probe(c);
254 if (retval != ERROR_OK)
256 LOG_ERROR("auto_probe failed %d\n", retval);
257 return retval;
259 /* check whether address belongs to this flash bank */
260 if ((addr >= c->base) && (addr <= c->base + (c->size - 1)) && target == c->target)
262 *result_bank = c;
263 return ERROR_OK;
266 *result_bank = NULL;
267 if (check)
269 LOG_ERROR("No flash at address 0x%08" PRIx32 "\n", addr);
270 return ERROR_FAIL;
272 return ERROR_OK;
275 int default_flash_mem_blank_check(struct flash_bank *bank)
277 struct target *target = bank->target;
278 const int buffer_size = 1024;
279 int i;
280 uint32_t nBytes;
281 int retval = ERROR_OK;
283 if (bank->target->state != TARGET_HALTED)
285 LOG_ERROR("Target not halted");
286 return ERROR_TARGET_NOT_HALTED;
289 uint8_t *buffer = malloc(buffer_size);
291 for (i = 0; i < bank->num_sectors; i++)
293 uint32_t j;
294 bank->sectors[i].is_erased = 1;
296 for (j = 0; j < bank->sectors[i].size; j += buffer_size)
298 uint32_t chunk;
299 chunk = buffer_size;
300 if (chunk > (j - bank->sectors[i].size))
302 chunk = (j - bank->sectors[i].size);
305 retval = target_read_memory(target, bank->base + bank->sectors[i].offset + j, 4, chunk/4, buffer);
306 if (retval != ERROR_OK)
308 goto done;
311 for (nBytes = 0; nBytes < chunk; nBytes++)
313 if (buffer[nBytes] != 0xFF)
315 bank->sectors[i].is_erased = 0;
316 break;
322 done:
323 free(buffer);
325 return retval;
328 int default_flash_blank_check(struct flash_bank *bank)
330 struct target *target = bank->target;
331 int i;
332 int retval;
333 int fast_check = 0;
334 uint32_t blank;
336 if (bank->target->state != TARGET_HALTED)
338 LOG_ERROR("Target not halted");
339 return ERROR_TARGET_NOT_HALTED;
342 for (i = 0; i < bank->num_sectors; i++)
344 uint32_t address = bank->base + bank->sectors[i].offset;
345 uint32_t size = bank->sectors[i].size;
347 if ((retval = target_blank_check_memory(target, address, size, &blank)) != ERROR_OK)
349 fast_check = 0;
350 break;
352 if (blank == 0xFF)
353 bank->sectors[i].is_erased = 1;
354 else
355 bank->sectors[i].is_erased = 0;
356 fast_check = 1;
359 if (!fast_check)
361 LOG_USER("Running slow fallback erase check - add working memory");
362 return default_flash_mem_blank_check(bank);
365 return ERROR_OK;
368 /* Manipulate given flash region, selecting the bank according to target
369 * and address. Maps an address range to a set of sectors, and issues
370 * the callback() on that set ... e.g. to erase or unprotect its members.
372 * (Note a current bad assumption: that protection operates on the same
373 * size sectors as erase operations use.)
375 * The "pad_reason" parameter is a kind of boolean: when it's NULL, the
376 * range must fit those sectors exactly. This is clearly safe; it can't
377 * erase data which the caller said to leave alone, for example. If it's
378 * non-NULL, rather than failing, extra data in the first and/or last
379 * sectors will be added to the range, and that reason string is used when
380 * warning about those additions.
382 static int flash_iterate_address_range(struct target *target,
383 char *pad_reason, uint32_t addr, uint32_t length,
384 int (*callback)(struct flash_bank *bank, int first, int last))
386 struct flash_bank *c;
387 uint32_t last_addr = addr + length; /* first address AFTER end */
388 int first = -1;
389 int last = -1;
390 int i;
392 int retval = get_flash_bank_by_addr(target, addr, true, &c);
393 if (retval != ERROR_OK)
394 return retval;
396 if (c->size == 0 || c->num_sectors == 0)
398 LOG_ERROR("Bank is invalid");
399 return ERROR_FLASH_BANK_INVALID;
402 if (length == 0)
404 /* special case, erase whole bank when length is zero */
405 if (addr != c->base)
407 LOG_ERROR("Whole bank access must start at beginning of bank.");
408 return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
411 return callback(c, 0, c->num_sectors - 1);
414 /* check whether it all fits in this bank */
415 if (addr + length - 1 > c->base + c->size - 1)
417 LOG_ERROR("Flash access does not fit into bank.");
418 return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
421 /** @todo: handle erasures that cross into adjacent banks */
423 addr -= c->base;
424 last_addr -= c->base;
426 for (i = 0; i < c->num_sectors; i++)
428 struct flash_sector *f = c->sectors + i;
429 uint32_t end = f->offset + f->size;
431 /* start only on a sector boundary */
432 if (first < 0) {
433 /* scanned past the first sector? */
434 if (addr < f->offset)
435 break;
437 /* is this the first sector? */
438 if (addr == f->offset)
439 first = i;
441 /* Does this need head-padding? If so, pad and warn;
442 * or else force an error.
444 * Such padding can make trouble, since *WE* can't
445 * ever know if that data was in use. The warning
446 * should help users sort out messes later.
448 else if (addr < end && pad_reason) {
449 /* FIXME say how many bytes (e.g. 80 KB) */
450 LOG_WARNING("Adding extra %s range, "
451 "%#8.8x to %#8.8x",
452 pad_reason,
453 (unsigned) f->offset,
454 (unsigned) addr - 1);
455 first = i;
456 } else
457 continue;
460 /* is this (also?) the last sector? */
461 if (last_addr == end) {
462 last = i;
463 break;
466 /* Does this need tail-padding? If so, pad and warn;
467 * or else force an error.
469 if (last_addr < end && pad_reason) {
470 /* FIXME say how many bytes (e.g. 80 KB) */
471 LOG_WARNING("Adding extra %s range, "
472 "%#8.8x to %#8.8x",
473 pad_reason,
474 (unsigned) last_addr,
475 (unsigned) end - 1);
476 last = i;
477 break;
480 /* MUST finish on a sector boundary */
481 if (last_addr <= f->offset)
482 break;
485 /* invalid start or end address? */
486 if (first == -1 || last == -1) {
487 LOG_ERROR("address range 0x%8.8x .. 0x%8.8x "
488 "is not sector-aligned",
489 (unsigned) (c->base + addr),
490 (unsigned) (c->base + last_addr - 1));
491 return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
494 /* The NOR driver may trim this range down, based on what
495 * sectors are already erased/unprotected. GDB currently
496 * blocks such optimizations.
498 return callback(c, first, last);
501 int flash_erase_address_range(struct target *target,
502 bool pad, uint32_t addr, uint32_t length)
504 return flash_iterate_address_range(target, pad ? "erase" : NULL,
505 addr, length, &flash_driver_erase);
508 static int flash_driver_unprotect(struct flash_bank *bank, int first, int last)
510 return flash_driver_protect(bank, 0, first, last);
513 int flash_unlock_address_range(struct target *target, uint32_t addr, uint32_t length)
515 /* By default, pad to sector boundaries ... the real issue here
516 * is that our (only) caller *permanently* removes protection,
517 * and doesn't restore it.
519 return flash_iterate_address_range(target, "unprotect",
520 addr, length, &flash_driver_unprotect);
523 static int compare_section (const void * a, const void * b)
525 struct imagesection *b1, *b2;
526 b1=*((struct imagesection **)a);
527 b2=*((struct imagesection **)b);
529 if (b1->base_address == b2->base_address)
531 return 0;
532 } else if (b1->base_address > b2->base_address)
534 return 1;
535 } else
537 return -1;
542 int flash_write_unlock(struct target *target, struct image *image,
543 uint32_t *written, int erase, bool unlock)
545 int retval = ERROR_OK;
547 int section;
548 uint32_t section_offset;
549 struct flash_bank *c;
550 int *padding;
552 section = 0;
553 section_offset = 0;
555 if (written)
556 *written = 0;
558 if (erase)
560 /* assume all sectors need erasing - stops any problems
561 * when flash_write is called multiple times */
563 flash_set_dirty();
566 /* allocate padding array */
567 padding = calloc(image->num_sections, sizeof(*padding));
569 /* This fn requires all sections to be in ascending order of addresses,
570 * whereas an image can have sections out of order. */
571 struct imagesection **sections = malloc(sizeof(struct imagesection *) *
572 image->num_sections);
573 int i;
574 for (i = 0; i < image->num_sections; i++)
576 sections[i] = &image->sections[i];
579 qsort(sections, image->num_sections, sizeof(struct imagesection *),
580 compare_section);
582 /* loop until we reach end of the image */
583 while (section < image->num_sections)
585 uint32_t buffer_size;
586 uint8_t *buffer;
587 int section_first;
588 int section_last;
589 uint32_t run_address = sections[section]->base_address + section_offset;
590 uint32_t run_size = sections[section]->size - section_offset;
591 int pad_bytes = 0;
593 if (sections[section]->size == 0)
595 LOG_WARNING("empty section %d", section);
596 section++;
597 section_offset = 0;
598 continue;
601 /* find the corresponding flash bank */
602 retval = get_flash_bank_by_addr(target, run_address, false, &c);
603 if (retval != ERROR_OK)
605 goto done;
607 if (c == NULL)
609 section++; /* and skip it */
610 section_offset = 0;
611 continue;
614 /* collect consecutive sections which fall into the same bank */
615 section_first = section;
616 section_last = section;
617 padding[section] = 0;
618 while ((run_address + run_size - 1 < c->base + c->size - 1)
619 && (section_last + 1 < image->num_sections))
621 /* sections are sorted */
622 assert(sections[section_last + 1]->base_address >= c->base);
623 if (sections[section_last + 1]->base_address >= (c->base + c->size))
625 /* Done with this bank */
626 break;
629 /* FIXME This needlessly touches sectors BETWEEN the
630 * sections it's writing. Without auto erase, it just
631 * writes ones. That WILL INVALIDATE data in cases
632 * like Stellaris Tempest chips, corrupting internal
633 * ECC codes; and at least FreeScale suggests issues
634 * with that approach (in HC11 documentation).
636 * With auto erase enabled, data in those sectors will
637 * be needlessly destroyed; and some of the limited
638 * number of flash erase cycles will be wasted...
640 * In both cases, the extra writes slow things down.
643 /* if we have multiple sections within our image,
644 * flash programming could fail due to alignment issues
645 * attempt to rebuild a consecutive buffer for the flash loader */
646 pad_bytes = (sections[section_last + 1]->base_address) - (run_address + run_size);
647 padding[section_last] = pad_bytes;
648 run_size += sections[++section_last]->size;
649 run_size += pad_bytes;
651 if (pad_bytes > 0)
652 LOG_INFO("Padding image section %d with %d bytes", section_last-1, pad_bytes);
655 if (run_address + run_size - 1 > c->base + c->size - 1)
657 LOG_ERROR("The image is too big for the flash");
658 retval = ERROR_FAIL;
659 goto done;
662 /* If we're applying any sector automagic, then pad this
663 * (maybe-combined) segment to the end of its last sector.
665 if (unlock || erase) {
666 int sector;
667 uint32_t offset_start = run_address - c->base;
668 uint32_t offset_end = offset_start + run_size;
669 uint32_t end = offset_end, delta;
671 for (sector = 0; sector < c->num_sectors; sector++) {
672 end = c->sectors[sector].offset
673 + c->sectors[sector].size;
674 if (offset_end <= end)
675 break;
678 delta = end - offset_end;
679 padding[section_last] += delta;
680 run_size += delta;
683 /* allocate buffer */
684 buffer = malloc(run_size);
685 if (buffer == NULL)
687 LOG_ERROR("Out of memory for flash bank buffer");
688 retval = ERROR_FAIL;
689 goto done;
691 buffer_size = 0;
693 /* read sections to the buffer */
694 while (buffer_size < run_size)
696 size_t size_read;
698 size_read = run_size - buffer_size;
699 if (size_read > sections[section]->size - section_offset)
700 size_read = sections[section]->size - section_offset;
702 /* KLUDGE!
704 * #¤%#"%¤% we have to figure out the section # from the sorted
705 * list of pointers to sections to invoke image_read_section()...
707 intptr_t diff = (intptr_t)sections[section] - (intptr_t)image->sections;
708 int t_section_num = diff / sizeof(struct imagesection);
710 LOG_DEBUG("image_read_section: section = %d, t_section_num = %d, section_offset = %d, buffer_size = %d, size_read = %d",
711 (int)section,
712 (int)t_section_num, (int)section_offset, (int)buffer_size, (int)size_read);
713 if ((retval = image_read_section(image, t_section_num, section_offset,
714 size_read, buffer + buffer_size, &size_read)) != ERROR_OK || size_read == 0)
716 free(buffer);
717 goto done;
720 /* see if we need to pad the section */
721 while (padding[section]--)
722 (buffer + buffer_size)[size_read++] = 0xff;
724 buffer_size += size_read;
725 section_offset += size_read;
727 if (section_offset >= sections[section]->size)
729 section++;
730 section_offset = 0;
734 retval = ERROR_OK;
736 if (unlock)
738 retval = flash_unlock_address_range(target, run_address, run_size);
740 if (retval == ERROR_OK)
742 if (erase)
744 /* calculate and erase sectors */
745 retval = flash_erase_address_range(target,
746 true, run_address, run_size);
750 if (retval == ERROR_OK)
752 /* write flash sectors */
753 retval = flash_driver_write(c, buffer, run_address - c->base, run_size);
756 free(buffer);
758 if (retval != ERROR_OK)
760 /* abort operation */
761 goto done;
764 if (written != NULL)
765 *written += run_size; /* add run size to total written counter */
769 done:
770 free(sections);
771 free(padding);
773 return retval;
776 int flash_write(struct target *target, struct image *image,
777 uint32_t *written, int erase)
779 return flash_write_unlock(target, image, written, erase, false);