runtime: don't assume that _ = *s will panic if s is nil
commit6103480c5d816349b9c9f86d186254b6122ac0f8
authorian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>
Thu, 22 Jun 2017 14:46:12 +0000 (22 14:46 +0000)
committerian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>
Thu, 22 Jun 2017 14:46:12 +0000 (22 14:46 +0000)
tree60dae3998cda620358797eb5bf0fff80691fc09e
parent2386202283cf3daa799f87f01f30f4bafdca79c6
runtime: don't assume that _ = *s will panic if s is nil

    With the gc toolchain apparently
            var s *string
            _ = *s
    is enough to panic with a nil pointer dereference. The gccgo compiler
    will simply discard the dereference, which I think is a reasonable and
    acceptable optimization. Change the tests to use an exported variable
    instead. The tests are not currently run, but they will be with a
    later patch to gotools.

    Reviewed-on: https://go-review.googlesource.com/46450

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@249562 138bc75d-0d04-0410-961f-82ee72b054a4
gcc/go/gofrontend/MERGE
libgo/go/runtime/testdata/testprog/crash.go
libgo/go/runtime/testdata/testprogcgo/crash.go