i386: Allow -mlarge-data-threshold with -mcmodel=large
commit1a64156c7e25813afa8d4d8bbeb0590cad91cf55
authorUros Bizjak <ubizjak@gmail.com>
Mon, 16 Oct 2023 20:22:28 +0000 (16 22:22 +0200)
committerUros Bizjak <ubizjak@gmail.com>
Mon, 16 Oct 2023 21:44:23 +0000 (16 23:44 +0200)
tree175ab4690a19f33d8867dbc8aa34146c5cf7dfb7
parent328745607c5d403a1c7b6bc2ecaa1574ee42122f
i386: Allow -mlarge-data-threshold with -mcmodel=large

From: Fangrui Song <maskray@google.com>

When using -mcmodel=medium, large data objects larger than the
-mlarge-data-threshold threshold are placed into large data sections
(.lrodata, .ldata, .lbss and some variants).  GNU ld and ld.lld 17 place
.l* sections into separate output sections.  If small and medium code
model object files are mixed, the .l* sections won't exert relocation
overflow pressure on sections in object files built with -mcmodel=small.

However, when using -mcmodel=large, -mlarge-data-threshold doesn't
apply.  This means that the .rodata/.data/.bss sections may exert
relocation overflow pressure on sections in -mcmodel=small object files.

This patch allows -mcmodel=large to generate .l* sections and drops an
unneeded documentation restriction that the value must be the same.

Link: https://groups.google.com/g/x86-64-abi/c/jnQdJeabxiU
("Large data sections for the large code model")

Signed-off-by: Fangrui Song <maskray@google.com>
gcc/ChangeLog:

* config/i386/i386.cc (ix86_can_inline_p):
Handle CM_LARGE and CM_LARGE_PIC.
(x86_elf_aligned_decl_common): Ditto.
(x86_output_aligned_bss): Ditto.
* config/i386/i386.opt: Update doc for -mlarge-data-threshold=.
* doc/invoke.texi: Update doc for -mlarge-data-threshold=.

gcc/testsuite/ChangeLog:

* gcc.target/i386/large-data.c: New test.
gcc/config/i386/i386.cc
gcc/config/i386/i386.opt
gcc/doc/invoke.texi
gcc/testsuite/gcc.target/i386/large-data.c [new file with mode: 0644]