?  search:
summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
blame | history | raw | HEAD
hwmon: (asus_atk0110) Fix memory leak
[linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git] / drivers / hwmon / asus_atk0110.c
blob3462242f6ca67c7fa9b5ffcf3342c3bf3e96dc36
1 /*
2 * Copyright (C) 2007-2009 Luca Tettamanti <kronos.it@gmail.com>
3 *
4 * This file is released under the GPLv2
5 * See COPYING in the top level directory of the kernel tree.
6 */
7
8 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
9
10 #include <linux/debugfs.h>
11 #include <linux/kernel.h>
12 #include <linux/hwmon.h>
13 #include <linux/list.h>
14 #include <linux/module.h>
15 #include <linux/slab.h>
16 #include <linux/dmi.h>
17
18 #include <acpi/acpi.h>
19 #include <acpi/acpixf.h>
20 #include <acpi/acpi_drivers.h>
21 #include <acpi/acpi_bus.h>
22
23
24 #define ATK_HID "ATK0110"
25
26 static bool new_if;
27 module_param(new_if, bool, 0);
28 MODULE_PARM_DESC(new_if, "Override detection heuristic and force the use of the new ATK0110 interface");
29
30 static const struct dmi_system_id __initconst atk_force_new_if[] = {
31 {
32 /* Old interface has broken MCH temp monitoring */
33 .ident = "Asus Sabertooth X58",
34 .matches = {
35 DMI_MATCH(DMI_BOARD_NAME, "SABERTOOTH X58")
36 }
37 },
38 { }
39 };
40
41 /* Minimum time between readings, enforced in order to avoid
42 * hogging the CPU.
43 */
44 #define CACHE_TIME HZ
45
46 #define BOARD_ID "MBIF"
47 #define METHOD_ENUMERATE "GGRP"
48 #define METHOD_READ "GITM"
49 #define METHOD_WRITE "SITM"
50 #define METHOD_OLD_READ_TMP "RTMP"
51 #define METHOD_OLD_READ_VLT "RVLT"
52 #define METHOD_OLD_READ_FAN "RFAN"
53 #define METHOD_OLD_ENUM_TMP "TSIF"
54 #define METHOD_OLD_ENUM_VLT "VSIF"
55 #define METHOD_OLD_ENUM_FAN "FSIF"
56
57 #define ATK_MUX_HWMON 0x00000006ULL
58 #define ATK_MUX_MGMT 0x00000011ULL
59
60 #define ATK_CLASS_MASK 0xff000000ULL
61 #define ATK_CLASS_FREQ_CTL 0x03000000ULL
62 #define ATK_CLASS_FAN_CTL 0x04000000ULL
63 #define ATK_CLASS_HWMON 0x06000000ULL
64 #define ATK_CLASS_MGMT 0x11000000ULL
65
66 #define ATK_TYPE_MASK 0x00ff0000ULL
67 #define HWMON_TYPE_VOLT 0x00020000ULL
68 #define HWMON_TYPE_TEMP 0x00030000ULL
69 #define HWMON_TYPE_FAN 0x00040000ULL
70
71 #define ATK_ELEMENT_ID_MASK 0x0000ffffULL
72
73 #define ATK_EC_ID 0x11060004ULL
74
75 enum atk_pack_member {
76 HWMON_PACK_FLAGS,
77 HWMON_PACK_NAME,
78 HWMON_PACK_LIMIT1,
79 HWMON_PACK_LIMIT2,
80 HWMON_PACK_ENABLE
81 };
82
83 /* New package format */
84 #define _HWMON_NEW_PACK_SIZE 7
85 #define _HWMON_NEW_PACK_FLAGS 0
86 #define _HWMON_NEW_PACK_NAME 1
87 #define _HWMON_NEW_PACK_UNK1 2
88 #define _HWMON_NEW_PACK_UNK2 3
89 #define _HWMON_NEW_PACK_LIMIT1 4
90 #define _HWMON_NEW_PACK_LIMIT2 5
91 #define _HWMON_NEW_PACK_ENABLE 6
92
93 /* Old package format */
94 #define _HWMON_OLD_PACK_SIZE 5
95 #define _HWMON_OLD_PACK_FLAGS 0
96 #define _HWMON_OLD_PACK_NAME 1
97 #define _HWMON_OLD_PACK_LIMIT1 2
98 #define _HWMON_OLD_PACK_LIMIT2 3
99 #define _HWMON_OLD_PACK_ENABLE 4
100
101
102 struct atk_data {
103 struct device *hwmon_dev;
104 acpi_handle atk_handle;
105 struct acpi_device *acpi_dev;
106
107 bool old_interface;
108
109 /* old interface */
110 acpi_handle rtmp_handle;
111 acpi_handle rvlt_handle;
112 acpi_handle rfan_handle;
113 /* new inteface */
114 acpi_handle enumerate_handle;
115 acpi_handle read_handle;
116 acpi_handle write_handle;
117
118 bool disable_ec;
119
120 int voltage_count;
121 int temperature_count;
122 int fan_count;
123 struct list_head sensor_list;
124
125 struct {
126 struct dentry *root;
127 u32 id;
128 } debugfs;
129 };
130
131
132 typedef ssize_t (*sysfs_show_func)(struct device *dev,
133 struct device_attribute *attr, char *buf);
134
135 static const struct acpi_device_id atk_ids[] = {
136 {ATK_HID, 0},
137 {"", 0},
138 };
139 MODULE_DEVICE_TABLE(acpi, atk_ids);
140
141 #define ATTR_NAME_SIZE 16 /* Worst case is "tempN_input" */
142
143 struct atk_sensor_data {
144 struct list_head list;
145 struct atk_data *data;
146 struct device_attribute label_attr;
147 struct device_attribute input_attr;
148 struct device_attribute limit1_attr;
149 struct device_attribute limit2_attr;
150 char label_attr_name[ATTR_NAME_SIZE];
151 char input_attr_name[ATTR_NAME_SIZE];
152 char limit1_attr_name[ATTR_NAME_SIZE];
153 char limit2_attr_name[ATTR_NAME_SIZE];
154 u64 id;
155 u64 type;
156 u64 limit1;
157 u64 limit2;
158 u64 cached_value;
159 unsigned long last_updated; /* in jiffies */
160 bool is_valid;
161 char const *acpi_name;
162 };
163
164 /* Return buffer format:
165 * [0-3] "value" is valid flag
166 * [4-7] value
167 * [8- ] unknown stuff on newer mobos
168 */
169 struct atk_acpi_ret_buffer {
170 u32 flags;
171 u32 value;
172 u8 data[];
173 };
174
175 /* Input buffer used for GITM and SITM methods */
176 struct atk_acpi_input_buf {
177 u32 id;
178 u32 param1;
179 u32 param2;
180 };
181
182 static int atk_add(struct acpi_device *device);
183 static int atk_remove(struct acpi_device *device, int type);
184 static void atk_print_sensor(struct atk_data *data, union acpi_object *obj);
185 static int atk_read_value(struct atk_sensor_data *sensor, u64 *value);
186 static void atk_free_sensors(struct atk_data *data);
187
188 static struct acpi_driver atk_driver = {
189 .name = ATK_HID,
190 .class = "hwmon",
191 .ids = atk_ids,
192 .ops = {
193 .add = atk_add,
194 .remove = atk_remove,
195 },
196 };
197
198 #define input_to_atk_sensor(attr) \
199 container_of(attr, struct atk_sensor_data, input_attr)
200
201 #define label_to_atk_sensor(attr) \
202 container_of(attr, struct atk_sensor_data, label_attr)
203
204 #define limit1_to_atk_sensor(attr) \
205 container_of(attr, struct atk_sensor_data, limit1_attr)
206
207 #define limit2_to_atk_sensor(attr) \
208 container_of(attr, struct atk_sensor_data, limit2_attr)
209
210 static ssize_t atk_input_show(struct device *dev,
211 struct device_attribute *attr, char *buf)
212 {
213 struct atk_sensor_data *s = input_to_atk_sensor(attr);
214 u64 value;
215 int err;
216
217 err = atk_read_value(s, &value);
218 if (err)
219 return err;
220
221 if (s->type == HWMON_TYPE_TEMP)
222 /* ACPI returns decidegree */
223 value *= 100;
224
225 return sprintf(buf, "%llu\n", value);
226 }
227
228 static ssize_t atk_label_show(struct device *dev,
229 struct device_attribute *attr, char *buf)
230 {
231 struct atk_sensor_data *s = label_to_atk_sensor(attr);
232
233 return sprintf(buf, "%s\n", s->acpi_name);
234 }
235
236 static ssize_t atk_limit1_show(struct device *dev,
237 struct device_attribute *attr, char *buf)
238 {
239 struct atk_sensor_data *s = limit1_to_atk_sensor(attr);
240 u64 value = s->limit1;
241
242 if (s->type == HWMON_TYPE_TEMP)
243 value *= 100;
244
245 return sprintf(buf, "%lld\n", value);
246 }
247
248 static ssize_t atk_limit2_show(struct device *dev,
249 struct device_attribute *attr, char *buf)
250 {
251 struct atk_sensor_data *s = limit2_to_atk_sensor(attr);
252 u64 value = s->limit2;
253
254 if (s->type == HWMON_TYPE_TEMP)
255 value *= 100;
256
257 return sprintf(buf, "%lld\n", value);
258 }
259
260 static ssize_t atk_name_show(struct device *dev,
261 struct device_attribute *attr, char *buf)
262 {
263 return sprintf(buf, "atk0110\n");
264 }
265 static struct device_attribute atk_name_attr =
266 __ATTR(name, 0444, atk_name_show, NULL);
267
268 static void atk_init_attribute(struct device_attribute *attr, char *name,
269 sysfs_show_func show)
270 {
271 attr->attr.name = name;
272 attr->attr.mode = 0444;
273 attr->show = show;
274 attr->store = NULL;
275 }
276
277
278 static union acpi_object *atk_get_pack_member(struct atk_data *data,
279 union acpi_object *pack,
280 enum atk_pack_member m)
281 {
282 bool old_if = data->old_interface;
283 int offset;
284
285 switch (m) {
286 case HWMON_PACK_FLAGS:
287 offset = old_if ? _HWMON_OLD_PACK_FLAGS : _HWMON_NEW_PACK_FLAGS;
288 break;
289 case HWMON_PACK_NAME:
290 offset = old_if ? _HWMON_OLD_PACK_NAME : _HWMON_NEW_PACK_NAME;
291 break;
292 case HWMON_PACK_LIMIT1:
293 offset = old_if ? _HWMON_OLD_PACK_LIMIT1 :
294 _HWMON_NEW_PACK_LIMIT1;
295 break;
296 case HWMON_PACK_LIMIT2:
297 offset = old_if ? _HWMON_OLD_PACK_LIMIT2 :
298 _HWMON_NEW_PACK_LIMIT2;
299 break;
300 case HWMON_PACK_ENABLE:
301 offset = old_if ? _HWMON_OLD_PACK_ENABLE :
302 _HWMON_NEW_PACK_ENABLE;
303 break;
304 default:
305 return NULL;
306 }
307
308 return &pack->package.elements[offset];
309 }
310
311
312 /* New package format is:
313 * - flag (int)
314 * class - used for de-muxing the request to the correct GITn
315 * type (volt, temp, fan)
316 * sensor id |
317 * sensor id - used for de-muxing the request _inside_ the GITn
318 * - name (str)
319 * - unknown (int)
320 * - unknown (int)
321 * - limit1 (int)
322 * - limit2 (int)
323 * - enable (int)
324 *
325 * The old package has the same format but it's missing the two unknown fields.
326 */
327 static int validate_hwmon_pack(struct atk_data *data, union acpi_object *obj)
328 {
329 struct device *dev = &data->acpi_dev->dev;
330 union acpi_object *tmp;
331 bool old_if = data->old_interface;
332 int const expected_size = old_if ? _HWMON_OLD_PACK_SIZE :
333 _HWMON_NEW_PACK_SIZE;
334
335 if (obj->type != ACPI_TYPE_PACKAGE) {
336 dev_warn(dev, "Invalid type: %d\n", obj->type);
337 return -EINVAL;
338 }
339
340 if (obj->package.count != expected_size) {
341 dev_warn(dev, "Invalid package size: %d, expected: %d\n",
342 obj->package.count, expected_size);
343 return -EINVAL;
344 }
345
346 tmp = atk_get_pack_member(data, obj, HWMON_PACK_FLAGS);
347 if (tmp->type != ACPI_TYPE_INTEGER) {
348 dev_warn(dev, "Invalid type (flag): %d\n", tmp->type);
349 return -EINVAL;
350 }
351
352 tmp = atk_get_pack_member(data, obj, HWMON_PACK_NAME);
353 if (tmp->type != ACPI_TYPE_STRING) {
354 dev_warn(dev, "Invalid type (name): %d\n", tmp->type);
355 return -EINVAL;
356 }
357
358 /* Don't check... we don't know what they're useful for anyway */
359 #if 0
360 tmp = &obj->package.elements[HWMON_PACK_UNK1];
361 if (tmp->type != ACPI_TYPE_INTEGER) {
362 dev_warn(dev, "Invalid type (unk1): %d\n", tmp->type);
363 return -EINVAL;
364 }
365
366 tmp = &obj->package.elements[HWMON_PACK_UNK2];
367 if (tmp->type != ACPI_TYPE_INTEGER) {
368 dev_warn(dev, "Invalid type (unk2): %d\n", tmp->type);
369 return -EINVAL;
370 }
371 #endif
372
373 tmp = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT1);
374 if (tmp->type != ACPI_TYPE_INTEGER) {
375 dev_warn(dev, "Invalid type (limit1): %d\n", tmp->type);
376 return -EINVAL;
377 }
378
379 tmp = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT2);
380 if (tmp->type != ACPI_TYPE_INTEGER) {
381 dev_warn(dev, "Invalid type (limit2): %d\n", tmp->type);
382 return -EINVAL;
383 }
384
385 tmp = atk_get_pack_member(data, obj, HWMON_PACK_ENABLE);
386 if (tmp->type != ACPI_TYPE_INTEGER) {
387 dev_warn(dev, "Invalid type (enable): %d\n", tmp->type);
388 return -EINVAL;
389 }
390
391 atk_print_sensor(data, obj);
392
393 return 0;
394 }
395
396 #ifdef DEBUG
397 static char const *atk_sensor_type(union acpi_object *flags)
398 {
399 u64 type = flags->integer.value & ATK_TYPE_MASK;
400 char const *what;
401
402 switch (type) {
403 case HWMON_TYPE_VOLT:
404 what = "voltage";
405 break;
406 case HWMON_TYPE_TEMP:
407 what = "temperature";
408 break;
409 case HWMON_TYPE_FAN:
410 what = "fan";
411 break;
412 default:
413 what = "unknown";
414 break;
415 }
416
417 return what;
418 }
419 #endif
420
421 static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
422 {
423 #ifdef DEBUG
424 struct device *dev = &data->acpi_dev->dev;
425 union acpi_object *flags;
426 union acpi_object *name;
427 union acpi_object *limit1;
428 union acpi_object *limit2;
429 union acpi_object *enable;
430 char const *what;
431
432 flags = atk_get_pack_member(data, obj, HWMON_PACK_FLAGS);
433 name = atk_get_pack_member(data, obj, HWMON_PACK_NAME);
434 limit1 = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT1);
435 limit2 = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT2);
436 enable = atk_get_pack_member(data, obj, HWMON_PACK_ENABLE);
437
438 what = atk_sensor_type(flags);
439
440 dev_dbg(dev, "%s: %#llx %s [%llu-%llu] %s\n", what,
441 flags->integer.value,
442 name->string.pointer,
443 limit1->integer.value, limit2->integer.value,
444 enable->integer.value ? "enabled" : "disabled");
445 #endif
446 }
447
448 static int atk_read_value_old(struct atk_sensor_data *sensor, u64 *value)
449 {
450 struct atk_data *data = sensor->data;
451 struct device *dev = &data->acpi_dev->dev;
452 struct acpi_object_list params;
453 union acpi_object id;
454 acpi_status status;
455 acpi_handle method;
456
457 switch (sensor->type) {
458 case HWMON_TYPE_VOLT:
459 method = data->rvlt_handle;
460 break;
461 case HWMON_TYPE_TEMP:
462 method = data->rtmp_handle;
463 break;
464 case HWMON_TYPE_FAN:
465 method = data->rfan_handle;
466 break;
467 default:
468 return -EINVAL;
469 }
470
471 id.type = ACPI_TYPE_INTEGER;
472 id.integer.value = sensor->id;
473
474 params.count = 1;
475 params.pointer = &id;
476
477 status = acpi_evaluate_integer(method, NULL, &params, value);
478 if (status != AE_OK) {
479 dev_warn(dev, "%s: ACPI exception: %s\n", __func__,
480 acpi_format_exception(status));
481 return -EIO;
482 }
483
484 return 0;
485 }
486
487 static union acpi_object *atk_ggrp(struct atk_data *data, u16 mux)
488 {
489 struct device *dev = &data->acpi_dev->dev;
490 struct acpi_buffer buf;
491 acpi_status ret;
492 struct acpi_object_list params;
493 union acpi_object id;
494 union acpi_object *pack;
495
496 id.type = ACPI_TYPE_INTEGER;
497 id.integer.value = mux;
498 params.count = 1;
499 params.pointer = &id;
500
501 buf.length = ACPI_ALLOCATE_BUFFER;
502 ret = acpi_evaluate_object(data->enumerate_handle, NULL, &params, &buf);
503 if (ret != AE_OK) {
504 dev_err(dev, "GGRP[%#x] ACPI exception: %s\n", mux,
505 acpi_format_exception(ret));
506 return ERR_PTR(-EIO);
507 }
508 pack = buf.pointer;
509 if (pack->type != ACPI_TYPE_PACKAGE) {
510 /* Execution was successful, but the id was not found */
511 ACPI_FREE(pack);
512 return ERR_PTR(-ENOENT);
513 }
514
515 if (pack->package.count < 1) {
516 dev_err(dev, "GGRP[%#x] package is too small\n", mux);
517 ACPI_FREE(pack);
518 return ERR_PTR(-EIO);
519 }
520 return pack;
521 }
522
523 static union acpi_object *atk_gitm(struct atk_data *data, u64 id)
524 {
525 struct device *dev = &data->acpi_dev->dev;
526 struct atk_acpi_input_buf buf;
527 union acpi_object tmp;
528 struct acpi_object_list params;
529 struct acpi_buffer ret;
530 union acpi_object *obj;
531 acpi_status status;
532
533 buf.id = id;
534 buf.param1 = 0;
535 buf.param2 = 0;
536
537 tmp.type = ACPI_TYPE_BUFFER;
538 tmp.buffer.pointer = (u8 *)&buf;
539 tmp.buffer.length = sizeof(buf);
540
541 params.count = 1;
542 params.pointer = (void *)&tmp;
543
544 ret.length = ACPI_ALLOCATE_BUFFER;
545 status = acpi_evaluate_object_typed(data->read_handle, NULL, &params,
546 &ret, ACPI_TYPE_BUFFER);
547 if (status != AE_OK) {
548 dev_warn(dev, "GITM[%#llx] ACPI exception: %s\n", id,
549 acpi_format_exception(status));
550 return ERR_PTR(-EIO);
551 }
552 obj = ret.pointer;
553
554 /* Sanity check */
555 if (obj->buffer.length < 8) {
556 dev_warn(dev, "Unexpected ASBF length: %u\n",
557 obj->buffer.length);
558 ACPI_FREE(obj);
559 return ERR_PTR(-EIO);
560 }
561 return obj;
562 }
563
564 static union acpi_object *atk_sitm(struct atk_data *data,
565 struct atk_acpi_input_buf *buf)
566 {
567 struct device *dev = &data->acpi_dev->dev;
568 struct acpi_object_list params;
569 union acpi_object tmp;
570 struct acpi_buffer ret;
571 union acpi_object *obj;
572 acpi_status status;
573
574 tmp.type = ACPI_TYPE_BUFFER;
575 tmp.buffer.pointer = (u8 *)buf;
576 tmp.buffer.length = sizeof(*buf);
577
578 params.count = 1;
579 params.pointer = &tmp;
580
581 ret.length = ACPI_ALLOCATE_BUFFER;
582 status = acpi_evaluate_object_typed(data->write_handle, NULL, &params,
583 &ret, ACPI_TYPE_BUFFER);
584 if (status != AE_OK) {
585 dev_warn(dev, "SITM[%#x] ACPI exception: %s\n", buf->id,
586 acpi_format_exception(status));
587 return ERR_PTR(-EIO);
588 }
589 obj = ret.pointer;
590
591 /* Sanity check */
592 if (obj->buffer.length < 8) {
593 dev_warn(dev, "Unexpected ASBF length: %u\n",
594 obj->buffer.length);
595 ACPI_FREE(obj);
596 return ERR_PTR(-EIO);
597 }
598 return obj;
599 }
600
601 static int atk_read_value_new(struct atk_sensor_data *sensor, u64 *value)
602 {
603 struct atk_data *data = sensor->data;
604 struct device *dev = &data->acpi_dev->dev;
605 union acpi_object *obj;
606 struct atk_acpi_ret_buffer *buf;
607 int err = 0;
608
609 obj = atk_gitm(data, sensor->id);
610 if (IS_ERR(obj))
611 return PTR_ERR(obj);
612
613 buf = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
614 if (buf->flags == 0) {
615 /* The reading is not valid, possible causes:
616 * - sensor failure
617 * - enumeration was FUBAR (and we didn't notice)
618 */
619 dev_warn(dev, "Read failed, sensor = %#llx\n", sensor->id);
620 err = -EIO;
621 goto out;
622 }
623
624 *value = buf->value;
625 out:
626 ACPI_FREE(obj);
627 return err;
628 }
629
630 static int atk_read_value(struct atk_sensor_data *sensor, u64 *value)
631 {
632 int err;
633
634 if (!sensor->is_valid ||
635 time_after(jiffies, sensor->last_updated + CACHE_TIME)) {
636 if (sensor->data->old_interface)
637 err = atk_read_value_old(sensor, value);
638 else
639 err = atk_read_value_new(sensor, value);
640
641 sensor->is_valid = true;
642 sensor->last_updated = jiffies;
643 sensor->cached_value = *value;
644 } else {
645 *value = sensor->cached_value;
646 err = 0;
647 }
648
649 return err;
650 }
651
652 #ifdef CONFIG_DEBUG_FS
653 static int atk_debugfs_gitm_get(void *p, u64 *val)
654 {
655 struct atk_data *data = p;
656 union acpi_object *ret;
657 struct atk_acpi_ret_buffer *buf;
658 int err = 0;
659
660 if (!data->read_handle)
661 return -ENODEV;
662
663 if (!data->debugfs.id)
664 return -EINVAL;
665
666 ret = atk_gitm(data, data->debugfs.id);
667 if (IS_ERR(ret))
668 return PTR_ERR(ret);
669
670 buf = (struct atk_acpi_ret_buffer *)ret->buffer.pointer;
671 if (buf->flags)
672 *val = buf->value;
673 else
674 err = -EIO;
675
676 ACPI_FREE(ret);
677 return err;
678 }
679
680 DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm,
681 atk_debugfs_gitm_get,
682 NULL,
683 "0x%08llx\n")
684
685 static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj)
686 {
687 int ret = 0;
688
689 switch (obj->type) {
690 case ACPI_TYPE_INTEGER:
691 ret = snprintf(buf, sz, "0x%08llx\n", obj->integer.value);
692 break;
693 case ACPI_TYPE_STRING:
694 ret = snprintf(buf, sz, "%s\n", obj->string.pointer);
695 break;
696 }
697
698 return ret;
699 }
700
701 static void atk_pack_print(char *buf, size_t sz, union acpi_object *pack)
702 {
703 int ret;
704 int i;
705
706 for (i = 0; i < pack->package.count; i++) {
707 union acpi_object *obj = &pack->package.elements[i];
708
709 ret = atk_acpi_print(buf, sz, obj);
710 if (ret >= sz)
711 break;
712 buf += ret;
713 sz -= ret;
714 }
715 }
716
717 static int atk_debugfs_ggrp_open(struct inode *inode, struct file *file)
718 {
719 struct atk_data *data = inode->i_private;
720 char *buf = NULL;
721 union acpi_object *ret;
722 u8 cls;
723 int i;
724
725 if (!data->enumerate_handle)
726 return -ENODEV;
727 if (!data->debugfs.id)
728 return -EINVAL;
729
730 cls = (data->debugfs.id & 0xff000000) >> 24;
731 ret = atk_ggrp(data, cls);
732 if (IS_ERR(ret))
733 return PTR_ERR(ret);
734
735 for (i = 0; i < ret->package.count; i++) {
736 union acpi_object *pack = &ret->package.elements[i];
737 union acpi_object *id;
738
739 if (pack->type != ACPI_TYPE_PACKAGE)
740 continue;
741 if (!pack->package.count)
742 continue;
743 id = &pack->package.elements[0];
744 if (id->integer.value == data->debugfs.id) {
745 /* Print the package */
746 buf = kzalloc(512, GFP_KERNEL);
747 if (!buf) {
748 ACPI_FREE(ret);
749 return -ENOMEM;
750 }
751 atk_pack_print(buf, 512, pack);
752 break;
753 }
754 }
755 ACPI_FREE(ret);
756
757 if (!buf)
758 return -EINVAL;
759
760 file->private_data = buf;
761
762 return nonseekable_open(inode, file);
763 }
764
765 static ssize_t atk_debugfs_ggrp_read(struct file *file, char __user *buf,
766 size_t count, loff_t *pos)
767 {
768 char *str = file->private_data;
769 size_t len = strlen(str);
770
771 return simple_read_from_buffer(buf, count, pos, str, len);
772 }
773
774 static int atk_debugfs_ggrp_release(struct inode *inode, struct file *file)
775 {
776 kfree(file->private_data);
777 return 0;
778 }
779
780 static const struct file_operations atk_debugfs_ggrp_fops = {
781 .read = atk_debugfs_ggrp_read,
782 .open = atk_debugfs_ggrp_open,
783 .release = atk_debugfs_ggrp_release,
784 .llseek = no_llseek,
785 };
786
787 static void atk_debugfs_init(struct atk_data *data)
788 {
789 struct dentry *d;
790 struct dentry *f;
791
792 data->debugfs.id = 0;
793
794 d = debugfs_create_dir("asus_atk0110", NULL);
795 if (!d || IS_ERR(d))
796 return;
797
798 f = debugfs_create_x32("id", S_IRUSR | S_IWUSR, d, &data->debugfs.id);
799 if (!f || IS_ERR(f))
800 goto cleanup;
801
802 f = debugfs_create_file("gitm", S_IRUSR, d, data,
803 &atk_debugfs_gitm);
804 if (!f || IS_ERR(f))
805 goto cleanup;
806
807 f = debugfs_create_file("ggrp", S_IRUSR, d, data,
808 &atk_debugfs_ggrp_fops);
809 if (!f || IS_ERR(f))
810 goto cleanup;
811
812 data->debugfs.root = d;
813
814 return;
815 cleanup:
816 debugfs_remove_recursive(d);
817 }
818
819 static void atk_debugfs_cleanup(struct atk_data *data)
820 {
821 debugfs_remove_recursive(data->debugfs.root);
822 }
823
824 #else /* CONFIG_DEBUG_FS */
825
826 static void atk_debugfs_init(struct atk_data *data)
827 {
828 }
829
830 static void atk_debugfs_cleanup(struct atk_data *data)
831 {
832 }
833 #endif
834
835 static int atk_add_sensor(struct atk_data *data, union acpi_object *obj)
836 {
837 struct device *dev = &data->acpi_dev->dev;
838 union acpi_object *flags;
839 union acpi_object *name;
840 union acpi_object *limit1;
841 union acpi_object *limit2;
842 union acpi_object *enable;
843 struct atk_sensor_data *sensor;
844 char const *base_name;
845 char const *limit1_name;
846 char const *limit2_name;
847 u64 type;
848 int err;
849 int *num;
850 int start;
851
852 if (obj->type != ACPI_TYPE_PACKAGE) {
853 /* wft is this? */
854 dev_warn(dev, "Unknown type for ACPI object: (%d)\n",
855 obj->type);
856 return -EINVAL;
857 }
858
859 err = validate_hwmon_pack(data, obj);
860 if (err)
861 return err;
862
863 /* Ok, we have a valid hwmon package */
864 type = atk_get_pack_member(data, obj, HWMON_PACK_FLAGS)->integer.value
865 & ATK_TYPE_MASK;
866
867 switch (type) {
868 case HWMON_TYPE_VOLT:
869 base_name = "in";
870 limit1_name = "min";
871 limit2_name = "max";
872 num = &data->voltage_count;
873 start = 0;
874 break;
875 case HWMON_TYPE_TEMP:
876 base_name = "temp";
877 limit1_name = "max";
878 limit2_name = "crit";
879 num = &data->temperature_count;
880 start = 1;
881 break;
882 case HWMON_TYPE_FAN:
883 base_name = "fan";
884 limit1_name = "min";
885 limit2_name = "max";
886 num = &data->fan_count;
887 start = 1;
888 break;
889 default:
890 dev_warn(dev, "Unknown sensor type: %#llx\n", type);
891 return -EINVAL;
892 }
893
894 enable = atk_get_pack_member(data, obj, HWMON_PACK_ENABLE);
895 if (!enable->integer.value)
896 /* sensor is disabled */
897 return 0;
898
899 flags = atk_get_pack_member(data, obj, HWMON_PACK_FLAGS);
900 name = atk_get_pack_member(data, obj, HWMON_PACK_NAME);
901 limit1 = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT1);
902 limit2 = atk_get_pack_member(data, obj, HWMON_PACK_LIMIT2);
903
904 sensor = kzalloc(sizeof(*sensor), GFP_KERNEL);
905 if (!sensor)
906 return -ENOMEM;
907
908 sensor->acpi_name = kstrdup(name->string.pointer, GFP_KERNEL);
909 if (!sensor->acpi_name) {
910 err = -ENOMEM;
911 goto out;
912 }
913
914 INIT_LIST_HEAD(&sensor->list);
915 sensor->type = type;
916 sensor->data = data;
917 sensor->id = flags->integer.value;
918 sensor->limit1 = limit1->integer.value;
919 if (data->old_interface)
920 sensor->limit2 = limit2->integer.value;
921 else
922 /* The upper limit is expressed as delta from lower limit */
923 sensor->limit2 = sensor->limit1 + limit2->integer.value;
924
925 snprintf(sensor->input_attr_name, ATTR_NAME_SIZE,
926 "%s%d_input", base_name, start + *num);
927 atk_init_attribute(&sensor->input_attr,
928 sensor->input_attr_name,
929 atk_input_show);
930
931 snprintf(sensor->label_attr_name, ATTR_NAME_SIZE,
932 "%s%d_label", base_name, start + *num);
933 atk_init_attribute(&sensor->label_attr,
934 sensor->label_attr_name,
935 atk_label_show);
936
937 snprintf(sensor->limit1_attr_name, ATTR_NAME_SIZE,
938 "%s%d_%s", base_name, start + *num, limit1_name);
939 atk_init_attribute(&sensor->limit1_attr,
940 sensor->limit1_attr_name,
941 atk_limit1_show);
942
943 snprintf(sensor->limit2_attr_name, ATTR_NAME_SIZE,
944 "%s%d_%s", base_name, start + *num, limit2_name);
945 atk_init_attribute(&sensor->limit2_attr,
946 sensor->limit2_attr_name,
947 atk_limit2_show);
948
949 list_add(&sensor->list, &data->sensor_list);
950 (*num)++;
951
952 return 1;
953 out:
954 kfree(sensor->acpi_name);
955 kfree(sensor);
956 return err;
957 }
958
959 static int atk_enumerate_old_hwmon(struct atk_data *data)
960 {
961 struct device *dev = &data->acpi_dev->dev;
962 struct acpi_buffer buf;
963 union acpi_object *pack;
964 acpi_status status;
965 int i, ret;
966 int count = 0;
967
968 /* Voltages */
969 buf.length = ACPI_ALLOCATE_BUFFER;
970 status = acpi_evaluate_object_typed(data->atk_handle,
971 METHOD_OLD_ENUM_VLT, NULL, &buf, ACPI_TYPE_PACKAGE);
972 if (status != AE_OK) {
973 dev_warn(dev, METHOD_OLD_ENUM_VLT ": ACPI exception: %s\n",
974 acpi_format_exception(status));
975
976 return -ENODEV;
977 }
978
979 pack = buf.pointer;
980 for (i = 1; i < pack->package.count; i++) {
981 union acpi_object *obj = &pack->package.elements[i];
982
983 ret = atk_add_sensor(data, obj);
984 if (ret > 0)
985 count++;
986 }
987 ACPI_FREE(buf.pointer);
988
989 /* Temperatures */
990 buf.length = ACPI_ALLOCATE_BUFFER;
991 status = acpi_evaluate_object_typed(data->atk_handle,
992 METHOD_OLD_ENUM_TMP, NULL, &buf, ACPI_TYPE_PACKAGE);
993 if (status != AE_OK) {
994 dev_warn(dev, METHOD_OLD_ENUM_TMP ": ACPI exception: %s\n",
995 acpi_format_exception(status));
996
997 ret = -ENODEV;
998 goto cleanup;
999 }
1000
1001 pack = buf.pointer;
1002 for (i = 1; i < pack->package.count; i++) {
1003 union acpi_object *obj = &pack->package.elements[i];
1004
1005 ret = atk_add_sensor(data, obj);
1006 if (ret > 0)
1007 count++;
1008 }
1009 ACPI_FREE(buf.pointer);
1010
1011 /* Fans */
1012 buf.length = ACPI_ALLOCATE_BUFFER;
1013 status = acpi_evaluate_object_typed(data->atk_handle,
1014 METHOD_OLD_ENUM_FAN, NULL, &buf, ACPI_TYPE_PACKAGE);
1015 if (status != AE_OK) {
1016 dev_warn(dev, METHOD_OLD_ENUM_FAN ": ACPI exception: %s\n",
1017 acpi_format_exception(status));
1018
1019 ret = -ENODEV;
1020 goto cleanup;
1021 }
1022
1023 pack = buf.pointer;
1024 for (i = 1; i < pack->package.count; i++) {
1025 union acpi_object *obj = &pack->package.elements[i];
1026
1027 ret = atk_add_sensor(data, obj);
1028 if (ret > 0)
1029 count++;
1030 }
1031 ACPI_FREE(buf.pointer);
1032
1033 return count;
1034 cleanup:
1035 atk_free_sensors(data);
1036 return ret;
1037 }
1038
1039 static int atk_ec_present(struct atk_data *data)
1040 {
1041 struct device *dev = &data->acpi_dev->dev;
1042 union acpi_object *pack;
1043 union acpi_object *ec;
1044 int ret;
1045 int i;
1046
1047 pack = atk_ggrp(data, ATK_MUX_MGMT);
1048 if (IS_ERR(pack)) {
1049 if (PTR_ERR(pack) == -ENOENT) {
1050 /* The MGMT class does not exists - that's ok */
1051 dev_dbg(dev, "Class %#llx not found\n", ATK_MUX_MGMT);
1052 return 0;
1053 }
1054 return PTR_ERR(pack);
1055 }
1056
1057 /* Search the EC */
1058 ec = NULL;
1059 for (i = 0; i < pack->package.count; i++) {
1060 union acpi_object *obj = &pack->package.elements[i];
1061 union acpi_object *id;
1062
1063 if (obj->type != ACPI_TYPE_PACKAGE)
1064 continue;
1065
1066 id = &obj->package.elements[0];
1067 if (id->type != ACPI_TYPE_INTEGER)
1068 continue;
1069
1070 if (id->integer.value == ATK_EC_ID) {
1071 ec = obj;
1072 break;
1073 }
1074 }
1075
1076 ret = (ec != NULL);
1077 if (!ret)
1078 /* The system has no EC */
1079 dev_dbg(dev, "EC not found\n");
1080
1081 ACPI_FREE(pack);
1082 return ret;
1083 }
1084
1085 static int atk_ec_enabled(struct atk_data *data)
1086 {
1087 struct device *dev = &data->acpi_dev->dev;
1088 union acpi_object *obj;
1089 struct atk_acpi_ret_buffer *buf;
1090 int err;
1091
1092 obj = atk_gitm(data, ATK_EC_ID);
1093 if (IS_ERR(obj)) {
1094 dev_err(dev, "Unable to query EC status\n");
1095 return PTR_ERR(obj);
1096 }
1097 buf = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
1098
1099 if (buf->flags == 0) {
1100 dev_err(dev, "Unable to query EC status\n");
1101 err = -EIO;
1102 } else {
1103 err = (buf->value != 0);
1104 dev_dbg(dev, "EC is %sabled\n",
1105 err ? "en" : "dis");
1106 }
1107
1108 ACPI_FREE(obj);
1109 return err;
1110 }
1111
1112 static int atk_ec_ctl(struct atk_data *data, int enable)
1113 {
1114 struct device *dev = &data->acpi_dev->dev;
1115 union acpi_object *obj;
1116 struct atk_acpi_input_buf sitm;
1117 struct atk_acpi_ret_buffer *ec_ret;
1118 int err = 0;
1119
1120 sitm.id = ATK_EC_ID;
1121 sitm.param1 = enable;
1122 sitm.param2 = 0;
1123
1124 obj = atk_sitm(data, &sitm);
1125 if (IS_ERR(obj)) {
1126 dev_err(dev, "Failed to %sable the EC\n",
1127 enable ? "en" : "dis");
1128 return PTR_ERR(obj);
1129 }
1130 ec_ret = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
1131 if (ec_ret->flags == 0) {
1132 dev_err(dev, "Failed to %sable the EC\n",
1133 enable ? "en" : "dis");
1134 err = -EIO;
1135 } else {
1136 dev_info(dev, "EC %sabled\n",
1137 enable ? "en" : "dis");
1138 }
1139
1140 ACPI_FREE(obj);
1141 return err;
1142 }
1143
1144 static int atk_enumerate_new_hwmon(struct atk_data *data)
1145 {
1146 struct device *dev = &data->acpi_dev->dev;
1147 union acpi_object *pack;
1148 int err;
1149 int i;
1150
1151 err = atk_ec_present(data);
1152 if (err < 0)
1153 return err;
1154 if (err) {
1155 err = atk_ec_enabled(data);
1156 if (err < 0)
1157 return err;
1158 /* If the EC was disabled we will disable it again on unload */
1159 data->disable_ec = err;
1160
1161 err = atk_ec_ctl(data, 1);
1162 if (err) {
1163 data->disable_ec = false;
1164 return err;
1165 }
1166 }
1167
1168 dev_dbg(dev, "Enumerating hwmon sensors\n");
1169
1170 pack = atk_ggrp(data, ATK_MUX_HWMON);
1171 if (IS_ERR(pack))
1172 return PTR_ERR(pack);
1173
1174 for (i = 0; i < pack->package.count; i++) {
1175 union acpi_object *obj = &pack->package.elements[i];
1176
1177 atk_add_sensor(data, obj);
1178 }
1179
1180 err = data->voltage_count + data->temperature_count + data->fan_count;
1181
1182 ACPI_FREE(pack);
1183 return err;
1184 }
1185
1186 static int atk_create_files(struct atk_data *data)
1187 {
1188 struct atk_sensor_data *s;
1189 int err;
1190
1191 list_for_each_entry(s, &data->sensor_list, list) {
1192 sysfs_attr_init(&s->input_attr.attr);
1193 err = device_create_file(data->hwmon_dev, &s->input_attr);
1194 if (err)
1195 return err;
1196 sysfs_attr_init(&s->label_attr.attr);
1197 err = device_create_file(data->hwmon_dev, &s->label_attr);
1198 if (err)
1199 return err;
1200 sysfs_attr_init(&s->limit1_attr.attr);
1201 err = device_create_file(data->hwmon_dev, &s->limit1_attr);
1202 if (err)
1203 return err;
1204 sysfs_attr_init(&s->limit2_attr.attr);
1205 err = device_create_file(data->hwmon_dev, &s->limit2_attr);
1206 if (err)
1207 return err;
1208 }
1209
1210 err = device_create_file(data->hwmon_dev, &atk_name_attr);
1211
1212 return err;
1213 }
1214
1215 static void atk_remove_files(struct atk_data *data)
1216 {
1217 struct atk_sensor_data *s;
1218
1219 list_for_each_entry(s, &data->sensor_list, list) {
1220 device_remove_file(data->hwmon_dev, &s->input_attr);
1221 device_remove_file(data->hwmon_dev, &s->label_attr);
1222 device_remove_file(data->hwmon_dev, &s->limit1_attr);
1223 device_remove_file(data->hwmon_dev, &s->limit2_attr);
1224 }
1225 device_remove_file(data->hwmon_dev, &atk_name_attr);
1226 }
1227
1228 static void atk_free_sensors(struct atk_data *data)
1229 {
1230 struct list_head *head = &data->sensor_list;
1231 struct atk_sensor_data *s, *tmp;
1232
1233 list_for_each_entry_safe(s, tmp, head, list) {
1234 kfree(s->acpi_name);
1235 kfree(s);
1236 }
1237 }
1238
1239 static int atk_register_hwmon(struct atk_data *data)
1240 {
1241 struct device *dev = &data->acpi_dev->dev;
1242 int err;
1243
1244 dev_dbg(dev, "registering hwmon device\n");
1245 data->hwmon_dev = hwmon_device_register(dev);
1246 if (IS_ERR(data->hwmon_dev))
1247 return PTR_ERR(data->hwmon_dev);
1248
1249 dev_dbg(dev, "populating sysfs directory\n");
1250 err = atk_create_files(data);
1251 if (err)
1252 goto remove;
1253
1254 return 0;
1255 remove:
1256 /* Cleanup the registered files */
1257 atk_remove_files(data);
1258 hwmon_device_unregister(data->hwmon_dev);
1259 return err;
1260 }
1261
1262 static int atk_probe_if(struct atk_data *data)
1263 {
1264 struct device *dev = &data->acpi_dev->dev;
1265 acpi_handle ret;
1266 acpi_status status;
1267 int err = 0;
1268
1269 /* RTMP: read temperature */
1270 status = acpi_get_handle(data->atk_handle, METHOD_OLD_READ_TMP, &ret);
1271 if (ACPI_SUCCESS(status))
1272 data->rtmp_handle = ret;
1273 else
1274 dev_dbg(dev, "method " METHOD_OLD_READ_TMP " not found: %s\n",
1275 acpi_format_exception(status));
1276
1277 /* RVLT: read voltage */
1278 status = acpi_get_handle(data->atk_handle, METHOD_OLD_READ_VLT, &ret);
1279 if (ACPI_SUCCESS(status))
1280 data->rvlt_handle = ret;
1281 else
1282 dev_dbg(dev, "method " METHOD_OLD_READ_VLT " not found: %s\n",
1283 acpi_format_exception(status));
1284
1285 /* RFAN: read fan status */
1286 status = acpi_get_handle(data->atk_handle, METHOD_OLD_READ_FAN, &ret);
1287 if (ACPI_SUCCESS(status))
1288 data->rfan_handle = ret;
1289 else
1290 dev_dbg(dev, "method " METHOD_OLD_READ_FAN " not found: %s\n",
1291 acpi_format_exception(status));
1292
1293 /* Enumeration */
1294 status = acpi_get_handle(data->atk_handle, METHOD_ENUMERATE, &ret);
1295 if (ACPI_SUCCESS(status))
1296 data->enumerate_handle = ret;
1297 else
1298 dev_dbg(dev, "method " METHOD_ENUMERATE " not found: %s\n",
1299 acpi_format_exception(status));
1300
1301 /* De-multiplexer (read) */
1302 status = acpi_get_handle(data->atk_handle, METHOD_READ, &ret);
1303 if (ACPI_SUCCESS(status))
1304 data->read_handle = ret;
1305 else
1306 dev_dbg(dev, "method " METHOD_READ " not found: %s\n",
1307 acpi_format_exception(status));
1308
1309 /* De-multiplexer (write) */
1310 status = acpi_get_handle(data->atk_handle, METHOD_WRITE, &ret);
1311 if (ACPI_SUCCESS(status))
1312 data->write_handle = ret;
1313 else
1314 dev_dbg(dev, "method " METHOD_WRITE " not found: %s\n",
1315 acpi_format_exception(status));
1316
1317 /* Check for hwmon methods: first check "old" style methods; note that
1318 * both may be present: in this case we stick to the old interface;
1319 * analysis of multiple DSDTs indicates that when both interfaces
1320 * are present the new one (GGRP/GITM) is not functional.
1321 */
1322 if (new_if)
1323 dev_info(dev, "Overriding interface detection\n");
1324 if (data->rtmp_handle && data->rvlt_handle && data->rfan_handle && !new_if)
1325 data->old_interface = true;
1326 else if (data->enumerate_handle && data->read_handle &&
1327 data->write_handle)
1328 data->old_interface = false;
1329 else
1330 err = -ENODEV;
1331
1332 return err;
1333 }
1334
1335 static int atk_add(struct acpi_device *device)
1336 {
1337 acpi_status ret;
1338 int err;
1339 struct acpi_buffer buf;
1340 union acpi_object *obj;
1341 struct atk_data *data;
1342
1343 dev_dbg(&device->dev, "adding...\n");
1344
1345 data = kzalloc(sizeof(*data), GFP_KERNEL);
1346 if (!data)
1347 return -ENOMEM;
1348
1349 data->acpi_dev = device;
1350 data->atk_handle = device->handle;
1351 INIT_LIST_HEAD(&data->sensor_list);
1352 data->disable_ec = false;
1353
1354 buf.length = ACPI_ALLOCATE_BUFFER;
1355 ret = acpi_evaluate_object_typed(data->atk_handle, BOARD_ID, NULL,
1356 &buf, ACPI_TYPE_PACKAGE);
1357 if (ret != AE_OK) {
1358 dev_dbg(&device->dev, "atk: method MBIF not found\n");
1359 } else {
1360 obj = buf.pointer;
1361 if (obj->package.count >= 2) {
1362 union acpi_object *id = &obj->package.elements[1];
1363 if (id->type == ACPI_TYPE_STRING)
1364 dev_dbg(&device->dev, "board ID = %s\n",
1365 id->string.pointer);
1366 }
1367 ACPI_FREE(buf.pointer);
1368 }
1369
1370 err = atk_probe_if(data);
1371 if (err) {
1372 dev_err(&device->dev, "No usable hwmon interface detected\n");
1373 goto out;
1374 }
1375
1376 if (data->old_interface) {
1377 dev_dbg(&device->dev, "Using old hwmon interface\n");
1378 err = atk_enumerate_old_hwmon(data);
1379 } else {
1380 dev_dbg(&device->dev, "Using new hwmon interface\n");
1381 err = atk_enumerate_new_hwmon(data);
1382 }
1383 if (err < 0)
1384 goto out;
1385 if (err == 0) {
1386 dev_info(&device->dev,
1387 "No usable sensor detected, bailing out\n");
1388 err = -ENODEV;
1389 goto out;
1390 }
1391
1392 err = atk_register_hwmon(data);
1393 if (err)
1394 goto cleanup;
1395
1396 atk_debugfs_init(data);
1397
1398 device->driver_data = data;
1399 return 0;
1400 cleanup:
1401 atk_free_sensors(data);
1402 out:
1403 if (data->disable_ec)
1404 atk_ec_ctl(data, 0);
1405 kfree(data);
1406 return err;
1407 }
1408
1409 static int atk_remove(struct acpi_device *device, int type)
1410 {
1411 struct atk_data *data = device->driver_data;
1412 dev_dbg(&device->dev, "removing...\n");
1413
1414 device->driver_data = NULL;
1415
1416 atk_debugfs_cleanup(data);
1417
1418 atk_remove_files(data);
1419 atk_free_sensors(data);
1420 hwmon_device_unregister(data->hwmon_dev);
1421
1422 if (data->disable_ec) {
1423 if (atk_ec_ctl(data, 0))
1424 dev_err(&device->dev, "Failed to disable EC\n");
1425 }
1426
1427 kfree(data);
1428
1429 return 0;
1430 }
1431
1432 static int __init atk0110_init(void)
1433 {
1434 int ret;
1435
1436 /* Make sure it's safe to access the device through ACPI */
1437 if (!acpi_resources_are_enforced()) {
1438 pr_err("Resources not safely usable due to acpi_enforce_resources kernel parameter\n");
1439 return -EBUSY;
1440 }
1441
1442 if (dmi_check_system(atk_force_new_if))
1443 new_if = true;
1444
1445 ret = acpi_bus_register_driver(&atk_driver);
1446 if (ret)
1447 pr_info("acpi_bus_register_driver failed: %d\n", ret);
1448
1449 return ret;
1450 }
1451
1452 static void __exit atk0110_exit(void)
1453 {
1454 acpi_bus_unregister_driver(&atk_driver);
1455 }
1456
1457 module_init(atk0110_init);
1458 module_exit(atk0110_exit);
1459
1460 MODULE_LICENSE("GPL");
Linux 2.6 ibm-acpi/thinkpad-acpi driver git tree