review-2.6.22.y/ACPI-check-a-return-value-correctly-in-acpi_power_get_context.patch

   1 From a815ab8b5891f3d2515316655729272f68269e3b Mon Sep 17 00:00:00 2001
   2 From: Li Zefan <lizf@cn.fujitsu.com>
   3 Date: Fri, 18 Apr 2008 13:27:29 -0700
   4 Subject: [PATCH] ACPI: check a return value correctly in acpi_power_get_context()
   5
   6 We should check *resource != NULL rather than resource != NULL, which will be
   7 always true.
   8
   9 Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
  10 Acked-by: Zhao Yakui <yakui.zhao@intel.com>
  11 Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  12 Signed-off-by: Len Brown <len.brown@intel.com>
  13 Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>
  14
  15 diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
  16 index 76bf6d9..f2a76ac 100644
  17 --- a/drivers/acpi/power.c
  18 +++ b/drivers/acpi/power.c
  19 @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handle,
  20         }
  21
  22         *resource = acpi_driver_data(device);
  23 -       if (!resource)
  24 +       if (!*resource)
  25                 return -ENODEV;
  26
  27         return 0;