t/db_dependent/Accounts.t

   1 #!/usr/bin/perl
   2
   3 # Copyright 2015 BibLibre
   4 #
   5 # This file is part of Koha.
   6 #
   7 # Koha is free software; you can redistribute it and/or modify it under the
   8 # terms of the GNU General Public License as published by the Free Software
   9 # Foundation; either version 3 of the License, or (at your option) any later
  10 # version.
  11 #
  12 # Koha is distributed in the hope that it will be useful, but WITHOUT ANY
  13 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
  14 # A PARTICULAR PURPOSE. See the GNU General Public License for more details.
  15 #
  16 # You should have received a copy of the GNU General Public License along
  17 # with Koha; if not, see <http://www.gnu.org/licenses>.
  18
  19 use Modern::Perl;
  20
  21 use Test::More tests => 26;
  22 use Test::MockModule;
  23 use Test::Warn;
  24
  25 use t::lib::TestBuilder;
  26 use t::lib::Mocks;
  27
  28 use Koha::Account;
  29 use Koha::Account::Lines;
  30 use Koha::Account::Offsets;
  31 use Koha::DateUtils qw( dt_from_string );
  32
  33 BEGIN {
  34     use_ok('C4::Accounts');
  35     use_ok('Koha::Object');
  36     use_ok('Koha::Patron');
  37     use_ok('Data::Dumper');
  38 }
  39
  40 can_ok( 'C4::Accounts',
  41     qw(
  42         getnextacctno
  43         chargelostitem
  44         manualinvoice
  45         getcharges
  46         ReversePayment
  47         purge_zero_balance_fees )
  48 );
  49
  50 my $schema  = Koha::Database->new->schema;
  51 $schema->storage->txn_begin;
  52 my $dbh = C4::Context->dbh;
  53
  54 my $builder = t::lib::TestBuilder->new;
  55 my $library = $builder->build( { source => 'Branch' } );
  56
  57 $dbh->do(q|DELETE FROM accountlines|);
  58 $dbh->do(q|DELETE FROM issues|);
  59 $dbh->do(q|DELETE FROM borrowers|);
  60
  61 my $branchcode = $library->{branchcode};
  62 my $borrower_number;
  63
  64 my $context = new Test::MockModule('C4::Context');
  65 $context->mock( 'userenv', sub {
  66     return {
  67         flags  => 1,
  68         id     => 'my_userid',
  69         branch => $branchcode,
  70     };
  71 });
  72
  73 # Testing purge_zero_balance_fees
  74
  75 # The 3rd value in the insert is 'days ago' --
  76 # 0 => today
  77 # 1 => yesterday
  78 # etc.
  79
  80 my $sth = $dbh->prepare(
  81     "INSERT INTO accountlines (
  82          borrowernumber,
  83          amountoutstanding,
  84          date,
  85          description
  86      )
  87      VALUES ( ?, ?, (select date_sub(CURRENT_DATE, INTERVAL ? DAY) ), ? )"
  88 );
  89
  90 my $days = 5;
  91
  92 my @test_data = (
  93     { amount => 0     , days_ago => 0         , description =>'purge_zero_balance_fees should not delete 0 balance fees with date today'                     , delete => 0 } ,
  94     { amount => 0     , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete 0 balance fees with date before threshold day'      , delete => 0 } ,
  95     { amount => 0     , days_ago => $days     , description =>'purge_zero_balance_fees should not delete 0 balance fees with date on threshold day'          , delete => 0 } ,
  96     { amount => 0     , days_ago => $days + 1 , description =>'purge_zero_balance_fees should delete 0 balance fees with date after threshold day'           , delete => 1 } ,
  97     { amount => undef , days_ago => $days + 1 , description =>'purge_zero_balance_fees should delete NULL balance fees with date after threshold day'        , delete => 1 } ,
  98     { amount => 5     , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete fees with positive amout owed before threshold day'  , delete => 0 } ,
  99     { amount => 5     , days_ago => $days     , description =>'purge_zero_balance_fees should not delete fees with positive amout owed on threshold day'      , delete => 0 } ,
 100     { amount => 5     , days_ago => $days + 1 , description =>'purge_zero_balance_fees should not delete fees with positive amout owed after threshold day'   , delete => 0 } ,
 101     { amount => -5    , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete fees with negative amout owed before threshold day' , delete => 0 } ,
 102     { amount => -5    , days_ago => $days     , description =>'purge_zero_balance_fees should not delete fees with negative amout owed on threshold day'     , delete => 0 } ,
 103     { amount => -5    , days_ago => $days + 1 , description =>'purge_zero_balance_fees should not delete fees with negative amout owed after threshold day'  , delete => 0 }
 104 );
 105 my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
 106 my $borrower = Koha::Patron->new( { firstname => 'Test', surname => 'Patron', categorycode => $categorycode, branchcode => $branchcode } )->store();
 107
 108 for my $data ( @test_data ) {
 109     $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description});
 110 }
 111
 112 purge_zero_balance_fees( $days );
 113
 114 $sth = $dbh->prepare(
 115             "select count(*) = 0 as deleted
 116              from accountlines
 117              where description = ?"
 118        );
 119
 120 #
 121 sub is_delete_correct {
 122     my $should_delete = shift;
 123     my $description = shift;
 124     $sth->execute( $description );
 125     my $test = $sth->fetchrow_hashref();
 126     is( $test->{deleted}, $should_delete, $description )
 127 }
 128
 129 for my $data  (@test_data) {
 130     is_delete_correct( $data->{delete}, $data->{description});
 131 }
 132
 133 $dbh->do(q|DELETE FROM accountlines|);
 134
 135 subtest "Koha::Account::pay tests" => sub {
 136
 137     plan tests => 13;
 138
 139     # Create a borrower
 140     my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
 141     my $branchcode   = $builder->build({ source => 'Branch' })->{ branchcode };
 142
 143     my $borrower = Koha::Patron->new( {
 144         cardnumber => '1234567890',
 145         surname => 'McFly',
 146         firstname => 'Marty',
 147     } );
 148     $borrower->categorycode( $categorycode );
 149     $borrower->branchcode( $branchcode );
 150     $borrower->store;
 151
 152     my $account = Koha::Account->new({ patron_id => $borrower->id });
 153
 154     my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 100 })->store();
 155     my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 200 })->store();
 156
 157     $sth = $dbh->prepare("SELECT count(*) FROM accountlines");
 158     $sth->execute;
 159     my $count = $sth->fetchrow_array;
 160     is($count, 2, 'There is 2 lines as expected');
 161
 162     # There is $100 in the account
 163     $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
 164     my $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
 165     my $amountleft = 0;
 166     for my $line ( @$amountoutstanding ) {
 167         $amountleft += $line;
 168     }
 169     is($amountleft, 300, 'The account has 300$ as expected' );
 170
 171     # We make a $20 payment
 172     my $borrowernumber = $borrower->borrowernumber;
 173     my $data = '20.00';
 174     my $payment_note = '$20.00 payment note';
 175     my $id = $account->pay( { amount => $data, note => $payment_note, payment_type => "TEST_TYPE" } );
 176
 177     my $accountline = Koha::Account::Lines->find( $id );
 178     is( $accountline->payment_type, "TEST_TYPE", "Payment type passed into pay is set in account line correctly" );
 179
 180     # There is now $280 in the account
 181     $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
 182     $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
 183     $amountleft = 0;
 184     for my $line ( @$amountoutstanding ) {
 185         $amountleft += $line;
 186     }
 187     is($amountleft, 280, 'The account has $280 as expected' );
 188
 189     # Is the payment note well registered
 190     $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
 191     $sth->execute($borrower->borrowernumber);
 192     my $note = $sth->fetchrow_array;
 193     is($note,'$20.00 payment note', '$20.00 payment note is registered');
 194
 195     # We make a -$30 payment (a NEGATIVE payment)
 196     $data = '-30.00';
 197     $payment_note = '-$30.00 payment note';
 198     $account->pay( { amount => $data, note => $payment_note } );
 199
 200     # There is now $310 in the account
 201     $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
 202     $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
 203     $amountleft = 0;
 204     for my $line ( @$amountoutstanding ) {
 205         $amountleft += $line;
 206     }
 207     is($amountleft, 310, 'The account has $310 as expected' );
 208     # Is the payment note well registered
 209     $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
 210     $sth->execute($borrower->borrowernumber);
 211     $note = $sth->fetchrow_array;
 212     is($note,'-$30.00 payment note', '-$30.00 payment note is registered');
 213
 214     #We make a $150 payment ( > 1stLine )
 215     $data = '150.00';
 216     $payment_note = '$150.00 payment note';
 217     $account->pay( { amount => $data, note => $payment_note } );
 218
 219     # There is now $160 in the account
 220     $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
 221     $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
 222     $amountleft = 0;
 223     for my $line ( @$amountoutstanding ) {
 224         $amountleft += $line;
 225     }
 226     is($amountleft, 160, 'The account has $160 as expected' );
 227
 228     # Is the payment note well registered
 229     $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
 230     $sth->execute($borrower->borrowernumber);
 231     $note = $sth->fetchrow_array;
 232     is($note,'$150.00 payment note', '$150.00 payment note is registered');
 233
 234     #We make a $200 payment ( > amountleft )
 235     $data = '200.00';
 236     $payment_note = '$200.00 payment note';
 237     $account->pay( { amount => $data, note => $payment_note } );
 238
 239     # There is now -$40 in the account
 240     $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
 241     $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
 242     $amountleft = 0;
 243     for my $line ( @$amountoutstanding ) {
 244         $amountleft += $line;
 245     }
 246     is($amountleft, -40, 'The account has -$40 as expected, (credit situation)' );
 247
 248     # Is the payment note well registered
 249     $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
 250     $sth->execute($borrower->borrowernumber);
 251     $note = $sth->fetchrow_array;
 252     is($note,'$200.00 payment note', '$200.00 payment note is registered');
 253
 254     my $line3 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 42, accounttype => 'TEST' })->store();
 255     my $payment_id = $account->pay( { lines => [$line3], amount => 42 } );
 256     my $payment = Koha::Account::Lines->find( $payment_id );
 257     is( $payment->amount(), '-42.000000', "Payment paid the specified fine" );
 258     $line3 = Koha::Account::Lines->find( $line3->id );
 259     is( $line3->amountoutstanding, '0.000000', "Specified fine is paid" );
 260 };
 261
 262 subtest "Koha::Account::pay particular line tests" => sub {
 263
 264     plan tests => 5;
 265
 266     # Create a borrower
 267     my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
 268     my $branchcode   = $builder->build({ source => 'Branch' })->{ branchcode };
 269
 270     my $borrower = Koha::Patron->new( {
 271         cardnumber => 'kylemhall',
 272         surname => 'Hall',
 273         firstname => 'Kyle',
 274     } );
 275     $borrower->categorycode( $categorycode );
 276     $borrower->branchcode( $branchcode );
 277     $borrower->store;
 278
 279     my $account = Koha::Account->new({ patron_id => $borrower->id });
 280
 281     my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 1 })->store();
 282     my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 2 })->store();
 283     my $line3 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 3 })->store();
 284     my $line4 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 4 })->store();
 285
 286     is( $account->balance(), 10, "Account balance is 10" );
 287
 288     $account->pay(
 289         {
 290             lines => [$line2, $line3, $line4],
 291             amount => 4,
 292         }
 293     );
 294
 295     $_->_result->discard_changes foreach ( $line1, $line2, $line3, $line4 );
 296
 297     # Line1 is not paid at all, as it was not passed in the lines param
 298     is( $line1->amountoutstanding, "1.000000", "Line 1 was not paid" );
 299     # Line2 was paid in full, as it was the first in the lines list
 300     is( $line2->amountoutstanding, "0.000000", "Line 2 was paid in full" );
 301     # Line3 was paid partially, as the remaining balance did not cover it entirely
 302     is( $line3->amountoutstanding, "1.000000", "Line 3 was paid to 1.00" );
 303     # Line4 was not paid at all, as the payment was all used up by that point
 304     is( $line4->amountoutstanding, "4.000000", "Line 4 was not paid" );
 305 };
 306
 307 subtest "Koha::Account::pay writeoff tests" => sub {
 308
 309     plan tests => 5;
 310
 311     # Create a borrower
 312     my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
 313     my $branchcode   = $builder->build({ source => 'Branch' })->{ branchcode };
 314
 315     my $borrower = Koha::Patron->new( {
 316         cardnumber => 'chelseahall',
 317         surname => 'Hall',
 318         firstname => 'Chelsea',
 319     } );
 320     $borrower->categorycode( $categorycode );
 321     $borrower->branchcode( $branchcode );
 322     $borrower->store;
 323
 324     my $account = Koha::Account->new({ patron_id => $borrower->id });
 325
 326     my $line = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 42 })->store();
 327
 328     is( $account->balance(), 42, "Account balance is 42" );
 329
 330     my $id = $account->pay(
 331         {
 332             lines  => [$line],
 333             amount => 42,
 334             type   => 'writeoff',
 335         }
 336     );
 337
 338     $line->_result->discard_changes();
 339
 340     is( $line->amountoutstanding, "0.000000", "Line was written off" );
 341
 342     my $writeoff = Koha::Account::Lines->find( $id );
 343
 344     is( $writeoff->accounttype, 'W', 'Type is correct' );
 345     is( $writeoff->description, 'Writeoff', 'Description is correct' );
 346     is( $writeoff->amount, '-42.000000', 'Amount is correct' );
 347 };
 348
 349 subtest "More Koha::Account::pay tests" => sub {
 350
 351     plan tests => 8;
 352
 353     # Create a borrower
 354     my $category   = $builder->build({ source => 'Category' })->{ categorycode };
 355     my $branch     = $builder->build({ source => 'Branch' })->{ branchcode };
 356     $branchcode = $branch;
 357     my $borrowernumber = $builder->build({
 358         source => 'Borrower',
 359         value  => { categorycode => $category,
 360                     branchcode   => $branch }
 361     })->{ borrowernumber };
 362
 363     my $amount = 100;
 364     my $accountline = $builder->build({ source => 'Accountline',
 365         value  => { borrowernumber => $borrowernumber,
 366                     amount => $amount,
 367                     amountoutstanding => $amount }
 368     });
 369
 370     my $rs = $schema->resultset('Accountline')->search({
 371         borrowernumber => $borrowernumber
 372     });
 373
 374     is( $rs->count(), 1, 'Accountline created' );
 375
 376     my $account = Koha::Account->new( { patron_id => $borrowernumber } );
 377     my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } );
 378     # make the full payment
 379     $account->pay({ lines => [$line], amount => $amount, library_id => $branch, note => 'A payment note' });
 380
 381     my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->{accountlines_id} })->next();
 382     is( $offset->amount(), '-100.000000', 'Offset amount is -100.00' );
 383     is( $offset->type(), 'Payment', 'Offset type is Payment' );
 384
 385     my $stat = $schema->resultset('Statistic')->search({
 386         branch  => $branch,
 387         type    => 'payment'
 388     }, { order_by => { -desc => 'datetime' } })->next();
 389
 390     ok( defined $stat, "There's a payment log that matches the branch" );
 391
 392     SKIP: {
 393         skip "No statistic logged", 4 unless defined $stat;
 394
 395         is( $stat->type, 'payment', "Correct statistic type" );
 396         is( $stat->branch, $branch, "Correct branch logged to statistics" );
 397         is( $stat->borrowernumber, $borrowernumber, "Correct borrowernumber logged to statistics" );
 398         is( $stat->value, "$amount" . "\.0000", "Correct amount logged to statistics" );
 399     }
 400 };
 401
 402 subtest "Even more Koha::Account::pay tests" => sub {
 403
 404     plan tests => 8;
 405
 406     # Create a borrower
 407     my $category   = $builder->build({ source => 'Category' })->{ categorycode };
 408     my $branch     = $builder->build({ source => 'Branch' })->{ branchcode };
 409     $branchcode = $branch;
 410     my $borrowernumber = $builder->build({
 411         source => 'Borrower',
 412         value  => { categorycode => $category,
 413                     branchcode   => $branch }
 414     })->{ borrowernumber };
 415
 416     my $amount = 100;
 417     my $partialamount = 60;
 418     my $accountline = $builder->build({ source => 'Accountline',
 419         value  => { borrowernumber => $borrowernumber,
 420                     amount => $amount,
 421                     amountoutstanding => $amount }
 422     });
 423
 424     my $rs = $schema->resultset('Accountline')->search({
 425         borrowernumber => $borrowernumber
 426     });
 427
 428     is( $rs->count(), 1, 'Accountline created' );
 429
 430     my $account = Koha::Account->new( { patron_id => $borrowernumber } );
 431     my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } );
 432     # make the full payment
 433     $account->pay({ lines => [$line], amount => $partialamount, library_id => $branch, note => 'A payment note' });
 434
 435     my $offset = Koha::Account::Offsets->search( { debit_id => $accountline->{ accountlines_id } } )->next();
 436     is( $offset->amount, '-60.000000', 'Offset amount is -60.00' );
 437     is( $offset->type, 'Payment', 'Offset type is payment' );
 438
 439     my $stat = $schema->resultset('Statistic')->search({
 440         branch  => $branch,
 441         type    => 'payment'
 442     }, { order_by => { -desc => 'datetime' } })->next();
 443
 444     ok( defined $stat, "There's a payment log that matches the branch" );
 445
 446     SKIP: {
 447         skip "No statistic logged", 4 unless defined $stat;
 448
 449         is( $stat->type, 'payment', "Correct statistic type" );
 450         is( $stat->branch, $branch, "Correct branch logged to statistics" );
 451         is( $stat->borrowernumber, $borrowernumber, "Correct borrowernumber logged to statistics" );
 452         is( $stat->value, "$partialamount" . "\.0000", "Correct amount logged to statistics" );
 453     }
 454 };
 455
 456 subtest 'balance' => sub {
 457     plan tests => 2;
 458
 459     my $patron = $builder->build({source => 'Borrower'});
 460     $patron = Koha::Patrons->find( $patron->{borrowernumber} );
 461     my $account = $patron->account;
 462     is( $account->balance, 0, 'balance should return 0 if the patron does not have fines' );
 463
 464     my $accountline_1 = $builder->build(
 465         {
 466             source => 'Accountline',
 467             value  => {
 468                 borrowernumber    => $patron->borrowernumber,
 469                 amount            => 42,
 470                 amountoutstanding => 42
 471             }
 472         }
 473     );
 474     my $accountline_2 = $builder->build(
 475         {
 476             source => 'Accountline',
 477             value  => {
 478                 borrowernumber    => $patron->borrowernumber,
 479                 amount            => -13,
 480                 amountoutstanding => -13
 481             }
 482         }
 483     );
 484
 485     my $balance = $patron->account->balance;
 486     is( int($balance), 29, 'balance should return the correct value');
 487
 488     $patron->delete;
 489 };
 490
 491 subtest "Koha::Account::chargelostitem tests" => sub {
 492     plan tests => 32;
 493
 494     my $lostfine;
 495     my $procfee;
 496
 497     my $itype_no_replace_no_fee = $builder->build({ source => 'Itemtype', value => {
 498             rentalcharge => 0,
 499             defaultreplacecost => undef,
 500             processfee => undef,
 501     }});
 502     my $itype_replace_no_fee = $builder->build({ source => 'Itemtype', value => {
 503             rentalcharge => 0,
 504             defaultreplacecost => 16.32,
 505             processfee => undef,
 506     }});
 507     my $itype_no_replace_fee = $builder->build({ source => 'Itemtype', value => {
 508             rentalcharge => 0,
 509             defaultreplacecost => undef,
 510             processfee => 8.16,
 511     }});
 512     my $itype_replace_fee = $builder->build({ source => 'Itemtype', value => {
 513             rentalcharge => 0,
 514             defaultreplacecost => 4.08,
 515             processfee => 2.04,
 516     }});
 517     my $cli_borrowernumber = $builder->build({ source => 'Borrower' })->{'borrowernumber'};
 518     my $cli_itemnumber1 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_no_fee->{itemtype} } })->{'itemnumber'};
 519     my $cli_itemnumber2 = $builder->build({ source => 'Item', value => { itype => $itype_replace_no_fee->{itemtype} } })->{'itemnumber'};
 520     my $cli_itemnumber3 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_fee->{itemtype} } })->{'itemnumber'};
 521     my $cli_itemnumber4 = $builder->build({ source => 'Item', value => { itype => $itype_replace_fee->{itemtype} } })->{'itemnumber'};
 522     my $duck = Koha::Items->find({itemnumber=>$cli_itemnumber1});
 523
 524     t::lib::Mocks::mock_preference('item-level_itypes', '1');
 525     t::lib::Mocks::mock_preference('useDefaultReplacementCost', '0');
 526
 527     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
 528     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
 529     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
 530     ok( !$lostfine, "No lost fine if no replacementcost or default when pref off");
 531     ok( !$procfee,  "No processing fee if no processing fee");
 532     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
 533     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
 534     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
 535     ok( $lostfine->amount == 6.12, "Lost fine equals replacementcost when pref off and no default set");
 536     ok( !$procfee,  "No processing fee if no processing fee");
 537     $lostfine->delete();
 538
 539     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
 540     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
 541     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
 542     ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
 543     ok( !$procfee,  "No processing fee if no processing fee");
 544     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
 545     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
 546     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
 547     ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
 548     ok( !$procfee,  "No processing fee if no processing fee");
 549     $lostfine->delete();
 550
 551     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
 552     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
 553     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
 554     ok( !$lostfine, "No lost fine if no replacementcost and no default set when pref off");
 555     ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
 556     $procfee->delete();
 557     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
 558     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
 559     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
 560     ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and no default set");
 561     ok( $procfee->amount == 8.16,  "Processing fee if processing fee");
 562     $lostfine->delete();
 563     $procfee->delete();
 564
 565     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
 566     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
 567     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
 568     ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
 569     ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
 570     $procfee->delete();
 571     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
 572     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
 573     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
 574     ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
 575     ok( $procfee->amount == 2.04,  "Processing fee if processing fee");
 576     $lostfine->delete();
 577     $procfee->delete();
 578
 579     t::lib::Mocks::mock_preference('useDefaultReplacementCost', '1');
 580
 581     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
 582     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
 583     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
 584     ok( !$lostfine, "No lost fine if no replacementcost or default when pref on");
 585     ok( !$procfee,  "No processing fee if no processing fee");
 586     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
 587     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
 588     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
 589     is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
 590     ok( !$procfee,  "No processing fee if no processing fee");
 591
 592     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
 593     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
 594     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
 595     is( $lostfine->amount(), "16.320000", "Lost fine is default if no replacementcost but default set when pref on");
 596     ok( !$procfee,  "No processing fee if no processing fee");
 597     $lostfine->delete();
 598     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
 599     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
 600     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
 601     is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");
 602     ok( !$procfee,  "No processing fee if no processing fee");
 603
 604     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
 605     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
 606     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
 607     ok( !$lostfine, "No lost fine if no replacementcost and default not set when pref on");
 608     is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
 609     $procfee->delete();
 610     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
 611     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
 612     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
 613     is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
 614     is( $procfee->amount, "8.160000",  "Processing fee if processing fee");
 615
 616     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
 617     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
 618     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
 619     is( $lostfine->amount, "4.080000", "Lost fine is default if no replacementcost but default set when pref on");
 620     is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
 621     $lostfine->delete();
 622     $procfee->delete();
 623     C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
 624     $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
 625     $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
 626     is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and default set");
 627     is( $procfee->amount, "2.040000",  "Processing fee if processing fee");
 628 };
 629
 630 subtest "Koha::Account::non_issues_charges tests" => sub {
 631     plan tests => 21;
 632
 633     my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
 634
 635     my $today  = dt_from_string;
 636     my $res    = 3;
 637     my $rent   = 5;
 638     my $manual = 7;
 639     Koha::Account::Line->new(
 640         {
 641             borrowernumber    => $patron->borrowernumber,
 642             accountno         => 1,
 643             date              => $today,
 644             description       => 'a Res fee',
 645             accounttype       => 'Res',
 646             amountoutstanding => $res,
 647         }
 648     )->store;
 649     Koha::Account::Line->new(
 650         {
 651             borrowernumber    => $patron->borrowernumber,
 652             accountno         => 2,
 653             date              => $today,
 654             description       => 'a Rental fee',
 655             accounttype       => 'Rent',
 656             amountoutstanding => $rent,
 657         }
 658     )->store;
 659     Koha::Account::Line->new(
 660         {
 661             borrowernumber    => $patron->borrowernumber,
 662             accountno         => 3,
 663             date              => $today,
 664             description       => 'a Manual invoice fee',
 665             accounttype       => 'Copie',
 666             amountoutstanding => $manual,
 667         }
 668     )->store;
 669     Koha::AuthorisedValue->new(
 670         {
 671             category         => 'MANUAL_INV',
 672             authorised_value => 'Copie',
 673             lib              => 'Fee for copie',
 674         }
 675     )->store;
 676
 677     my $account = $patron->account;
 678
 679     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   0 );
 680     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
 681     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  0 );
 682     my ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 683     my $other_charges = $total - $non_issues_charges;
 684     is(
 685         $account->balance,
 686         $res + $rent + $manual,
 687         'Total charges should be Res + Rent + Manual'
 688     );
 689     is( $non_issues_charges, 0,
 690         'If 0|0|0 there should not have non issues charges' );
 691     is( $other_charges, 15, 'If 0|0|0 there should only have other charges' );
 692
 693     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   0 );
 694     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
 695     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  1 );
 696     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 697     $other_charges = $total - $non_issues_charges;
 698     is(
 699         $total,
 700         $res + $rent + $manual,
 701         'Total charges should be Res + Rent + Manual'
 702     );
 703     is( $non_issues_charges, $manual,
 704         'If 0|0|1 Only Manual should be a non issue charge' );
 705     is(
 706         $other_charges,
 707         $res + $rent,
 708         'If 0|0|1 Res + Rent should be other charges'
 709     );
 710
 711     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   0 );
 712     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
 713     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  0 );
 714     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 715     $other_charges = $total - $non_issues_charges;
 716     is(
 717         $total,
 718         $res + $rent + $manual,
 719         'Total charges should be Res + Rent + Manual'
 720     );
 721     is( $non_issues_charges, $rent,
 722         'If 0|1|0 Only Rental should be a non issue charge' );
 723     is(
 724         $other_charges,
 725         $res + $manual,
 726         'If 0|1|0 Rent + Manual should be other charges'
 727     );
 728
 729     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   0 );
 730     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
 731     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  1 );
 732     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 733     $other_charges = $total - $non_issues_charges;
 734     is(
 735         $total,
 736         $res + $rent + $manual,
 737         'Total charges should be Res + Rent + Manual'
 738     );
 739     is(
 740         $non_issues_charges,
 741         $rent + $manual,
 742         'If 0|1|1 Rent + Manual should be non issues charges'
 743     );
 744     is( $other_charges, $res, 'If 0|1|1 there should only have other charges' );
 745
 746     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   1 );
 747     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
 748     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  0 );
 749     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 750     $other_charges = $total - $non_issues_charges;
 751     is(
 752         $total,
 753         $res + $rent + $manual,
 754         'Total charges should be Res + Rent + Manual'
 755     );
 756     is( $non_issues_charges, $res,
 757         'If 1|0|0 Only Res should be non issues charges' );
 758     is(
 759         $other_charges,
 760         $rent + $manual,
 761         'If 1|0|0 Rent + Manual should be other charges'
 762     );
 763
 764     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   1 );
 765     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
 766     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  0 );
 767     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 768     $other_charges = $total - $non_issues_charges;
 769     is(
 770         $total,
 771         $res + $rent + $manual,
 772         'Total charges should be Res + Rent + Manual'
 773     );
 774     is(
 775         $non_issues_charges,
 776         $res + $rent,
 777         'If 1|1|0 Res + Rent should be non issues charges'
 778     );
 779     is( $other_charges, $manual,
 780         'If 1|1|0 Only Manual should be other charges' );
 781
 782     t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge',   1 );
 783     t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
 784     t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge',  1 );
 785     ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
 786     $other_charges = $total - $non_issues_charges;
 787     is(
 788         $total,
 789         $res + $rent + $manual,
 790         'Total charges should be Res + Rent + Manual'
 791     );
 792     is(
 793         $non_issues_charges,
 794         $res + $rent + $manual,
 795         'If 1|1|1 Res + Rent + Manual should be non issues charges'
 796     );
 797     is( $other_charges, 0, 'If 1|1|1 there should not have any other charges' );
 798 };
 799
 800 subtest "Koha::Account::non_issues_charges tests" => sub {
 801     plan tests => 9;
 802
 803     my $patron = $builder->build_object(
 804         {
 805             class => "Koha::Patrons",
 806             value => {
 807                 firstname    => 'Test',
 808                 surname      => 'Patron',
 809                 categorycode => $categorycode,
 810                 branchcode   => $branchcode
 811             }
 812         }
 813     );
 814
 815     my $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
 816     my $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => -5 })->store();
 817     my $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store();
 818     purge_zero_balance_fees( 1 );
 819     my $debit_2 = Koha::Account::Lines->find( $debit->id );
 820     my $credit_2 = Koha::Account::Lines->find( $credit->id );
 821     ok( $debit_2, 'Debit was correctly not deleted when credit has balance' );
 822     ok( $credit_2, 'Credit was correctly not deleted when credit has balance' );
 823     is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2, "The 2 account lines still exists" );
 824
 825     $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 5 })->store();
 826     $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
 827     $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store();
 828     purge_zero_balance_fees( 1 );
 829     $debit_2 = $credit_2 = undef;
 830     $debit_2 = Koha::Account::Lines->find( $debit->id );
 831     $credit_2 = Koha::Account::Lines->find( $credit->id );
 832     ok( $debit_2, 'Debit was correctly not deleted when debit has balance' );
 833     ok( $credit_2, 'Credit was correctly not deleted when debit has balance' );
 834     is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2 + 2, "The 2 + 2 account lines still exists" );
 835
 836     $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
 837     $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
 838     $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store();
 839     purge_zero_balance_fees( 1 );
 840     $debit_2 = Koha::Account::Lines->find( $debit->id );
 841     $credit_2 = Koha::Account::Lines->find( $credit->id );
 842     ok( !$debit_2, 'Debit was correctly deleted' );
 843     ok( !$credit_2, 'Credit was correctly deleted' );
 844     is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2 + 2, "The 2 + 2 account lines still exists, the last 2 have been deleted ok" );
 845 };
 846
 847 subtest "Koha::Account::Line::void tests" => sub {
 848
 849     plan tests => 12;
 850
 851     # Create a borrower
 852     my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
 853     my $branchcode   = $builder->build({ source => 'Branch' })->{ branchcode };
 854
 855     my $borrower = Koha::Patron->new( {
 856         cardnumber => 'dariahall',
 857         surname => 'Hall',
 858         firstname => 'Daria',
 859     } );
 860     $borrower->categorycode( $categorycode );
 861     $borrower->branchcode( $branchcode );
 862     $borrower->store;
 863
 864     my $account = Koha::Account->new({ patron_id => $borrower->id });
 865
 866     my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 10, amountoutstanding => 10 })->store();
 867     my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 20, amountoutstanding => 20 })->store();
 868
 869     is( $account->balance(), 30, "Account balance is 30" );
 870     is( $line1->amountoutstanding, 10, 'First fee has amount outstanding of 10' );
 871     is( $line2->amountoutstanding, 20, 'Second fee has amount outstanding of 20' );
 872
 873     my $id = $account->pay(
 874         {
 875             lines  => [$line1, $line2],
 876             amount => 30,
 877         }
 878     );
 879     my $account_payment = Koha::Account::Lines->find( $id );
 880
 881     is( $account->balance(), 0, "Account balance is 0" );
 882
 883     $line1->_result->discard_changes();
 884     $line2->_result->discard_changes();
 885     is( $line1->amountoutstanding+0, 0, 'First fee has amount outstanding of 0' );
 886     is( $line2->amountoutstanding+0, 0, 'Second fee has amount outstanding of 0' );
 887
 888     $account_payment->void();
 889
 890     is( $account->balance(), 30, "Account balance is again 30" );
 891
 892     $account_payment->_result->discard_changes();
 893     $line1->_result->discard_changes();
 894     $line2->_result->discard_changes();
 895
 896     is( $account_payment->accounttype, 'VOID', 'Voided payment accounttype is VOID' );
 897     is( $account_payment->amount+0, 0, 'Voided payment amount is 0' );
 898     is( $account_payment->amountoutstanding+0, 0, 'Voided payment amount outstanding is 0' );
 899
 900     is( $line1->amountoutstanding+0, 10, 'First fee again has amount outstanding of 10' );
 901     is( $line2->amountoutstanding+0, 20, 'Second fee again has amount outstanding of 20' );
 902 };
 903
 904 1;