| commit | 9e01482d12e48c160f18cdee75508abcf195788e | |
| author | Sven Verdoolaege <skimo@kotnet.org> | |
| Thu, 7 Mar 2013 12:48:18 +0000 (7 13:48 +0100) | ||
| committer | Sven Verdoolaege <skimo@kotnet.org> | |
| Fri, 8 Mar 2013 09:46:21 +0000 (8 10:46 +0100) | ||
| tree | 143c664a46effd0dc5294709476ea0cef9eb02d7 | treesnapshot (tar.gz zip) |
| parent | 56798a073916c14d9671f11ccf3438b2762e09a1 | commitdiff |
isl_basic_set_sort_constraints: take into account all coefficients
The comparison function was mistakenly not taking into account
the coefficient of the last variable. By ignoring this last
coefficient, the comparison could not guarantee the property required
by uset_gist.
Moreover, since constraints that only differ in this last coefficient
would compare equal to each other, the order of such constraints
could depend on the implementation of qsort, resulting in failing
test cases on Solaris 10.
We fix this problem by ignoring the constant term instead of
the last coefficient. If two constraints only differ in the
constant term, then one of them should have been eliminated
already.
Reported-by: Amos <a.goo0h@gmail.com>
Tested-by: Marc Girod <marc.girod@gmail.com>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
The comparison function was mistakenly not taking into account
the coefficient of the last variable. By ignoring this last
coefficient, the comparison could not guarantee the property required
by uset_gist.
Moreover, since constraints that only differ in this last coefficient
would compare equal to each other, the order of such constraints
could depend on the implementation of qsort, resulting in failing
test cases on Solaris 10.
We fix this problem by ignoring the constant term instead of
the last coefficient. If two constraints only differ in the
constant term, then one of them should have been eliminated
already.
Reported-by: Amos <a.goo0h@gmail.com>
Tested-by: Marc Girod <marc.girod@gmail.com>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
70 files changed: