| commit | da3e217447390d52363989474a5e33bd298ff3ad | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Sat, 20 Nov 2010 00:46:54 +0000 (19 18:46 -0600) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 24 Nov 2010 22:51:42 +0000 (24 14:51 -0800) | ||
| tree | e0dd4b8ac125557ed727f4232b8c3f1235725724 | treesnapshot (tar.gz zip) |
| parent | 1d13e9f600986b7ced8db37a9a9c4967ee7ff9d5 | commitdiff |
vcs-svn: Eliminate node_ctx.mark global
The mark variable is only used in handle_node(). Its life is
very short and simple: first, a new mark number is allocated if
this node has text attached, then that mark is recorded in the
in-core tree being built up, and lastly the mark is communicated
to fast-import in the stream along with the associated text.
A new reader may worry about interaction with other code, especially
since mark is not initialized to zero in handle_node() itself.
Disperse such worries by making it local. No functional change
intended.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The mark variable is only used in handle_node(). Its life is
very short and simple: first, a new mark number is allocated if
this node has text attached, then that mark is recorded in the
in-core tree being built up, and lastly the mark is communicated
to fast-import in the stream along with the associated text.
A new reader may worry about interaction with other code, especially
since mark is not initialized to zero in handle_node() itself.
Disperse such worries by making it local. No functional change
intended.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| vcs-svn/svndump.c | diffblobblamehistory |