| commit | 212eb96a96e256933a76e48d85fa4f500bed0dee | |
| author | Thomas Rast <trast@inf.ethz.ch> | |
| Fri, 21 Jun 2013 11:38:00 +0000 (21 13:38 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 21 Jun 2013 15:36:07 +0000 (21 08:36 -0700) | ||
| tree | 114f51785e5003bb54b424f0bf5eabd574b53cc5 | treesnapshot (tar.gz zip) |
| parent | 0ce2e396ee9fb0fa07e8381b338e49859dbf03db | commitdiff |
apply: carefully strdup a possibly-NULL name
2901bbe (apply: free patch->{def,old,new}_name fields, 2012-03-21)
cleaned up the memory management of filenames in the patches, but
forgot that find_name_traditional() can return NULL as a way of saying
"I couldn't find a name".
That NULL unfortunately gets passed into xstrdup() next, resulting in
a segfault. Use null_strdup() so as to safely propagate the null,
which will let us emit the correct error message.
Reported-by: DevHC on #git
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2901bbe (apply: free patch->{def,old,new}_name fields, 2012-03-21)
cleaned up the memory management of filenames in the patches, but
forgot that find_name_traditional() can return NULL as a way of saying
"I couldn't find a name".
That NULL unfortunately gets passed into xstrdup() next, resulting in
a segfault. Use null_strdup() so as to safely propagate the null,
which will let us emit the correct error message.
Reported-by: DevHC on #git
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/apply.c | diffblobblamehistory | |
| t/t4111-apply-subdir.sh | diffblobblamehistory |