| commit | 8e2af8f0db329a8c0211a309fa9cb611b6dc2517 | |
| author | David Aguilar <davvid@gmail.com> | |
| Fri, 1 Oct 2021 01:37:55 +0000 (30 18:37 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 1 Oct 2021 01:48:51 +0000 (30 18:48 -0700) | ||
| tree | 3a68d28d2a36f78af554d4f1949e4e96df7bf991 | treesnapshot (tar.gz zip) |
| parent | 2255c80c91da9ed7fa127dad3aa92eb9f448c88b | commitdiff |
difftool: remove an unnecessary call to strbuf_release()
The `buf` strbuf is reused again later in the same function, so there
is no benefit to calling strbuf_release(). The subsequent usage is
already using strbuf_reset() to reset the buffer, so releasing it
early is only going to lead to a wasteful reallocation.
Remove the early call to strbuf_release(). The same strbuf is already
cleaned up in the "finish:" section so nothing is leaked, either.
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The `buf` strbuf is reused again later in the same function, so there
is no benefit to calling strbuf_release(). The subsequent usage is
already using strbuf_reset() to reset the buffer, so releasing it
early is only going to lead to a wasteful reallocation.
Remove the early call to strbuf_release(). The same strbuf is already
cleaned up in the "finish:" section so nothing is leaked, either.
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/difftool.c | diffblobblamehistory |