| commit | 696235c6c1c85085fd55ff849663d44c51464e69 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Wed, 23 Jan 2008 05:39:50 +0000 (23 00:39 -0500) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Wed, 24 Sep 2008 19:48:31 +0000 (24 12:48 -0700) | ||
| tree | d49ea9c80e1f605fc72eaeb566cb305bf2203129 | treesnapshot (tar.gz zip) |
| parent | 1ffca60f0b0395e1e593e64d66e7ed3c47d8517e | commitdiff |
git-gui: Assume `blame --incremental` output is in UTF-8
Most commits have author name encoded in UTF-8, but the incremental
blame output dumps raw bytes and doesn't give us the encoding header
from the commit. Rather than fixing up tooltip data after we have
viewed that particular commit in the blame viewer we can assume all
names are in UTF-8.
This is still going to cause problems when the author name is not
encoded in UTF-8, but the only (efficient) way to solve that is to
add an "encoding" header to the blame --incremental mode output,
as otherwise we need to run `git cat-file commit $sha1` for each
and every commit identified and that would be horribly expensive
on any platform.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Most commits have author name encoded in UTF-8, but the incremental
blame output dumps raw bytes and doesn't give us the encoding header
from the commit. Rather than fixing up tooltip data after we have
viewed that particular commit in the blame viewer we can assume all
names are in UTF-8.
This is still going to cause problems when the author name is not
encoded in UTF-8, but the only (efficient) way to solve that is to
add an "encoding" header to the blame --incremental mode output,
as otherwise we need to run `git cat-file commit $sha1` for each
and every commit identified and that would be horribly expensive
on any platform.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| lib/blame.tcl | diffblobblamehistory |