platform/smRunner/testSrc/com/intellij/execution/testframework/sm/runner/ui/SMTestRunnerResultsFormTest.java

   1 /*
   2  * Copyright 2000-2009 JetBrains s.r.o.
   3  *
   4  * Licensed under the Apache License, Version 2.0 (the "License");
   5  * you may not use this file except in compliance with the License.
   6  * You may obtain a copy of the License at
   7  *
   8  * http://www.apache.org/licenses/LICENSE-2.0
   9  *
  10  * Unless required by applicable law or agreed to in writing, software
  11  * distributed under the License is distributed on an "AS IS" BASIS,
  12  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13  * See the License for the specific language governing permissions and
  14  * limitations under the License.
  15  */
  16 package com.intellij.execution.testframework.sm.runner.ui;
  17
  18 import com.intellij.execution.runners.ExecutionEnvironment;
  19 import com.intellij.execution.testframework.TestConsoleProperties;
  20 import com.intellij.execution.testframework.sm.Marker;
  21 import com.intellij.execution.testframework.sm.runner.BaseSMTRunnerTestCase;
  22 import com.intellij.execution.testframework.sm.runner.GeneralToSMTRunnerEventsConvertor;
  23 import com.intellij.execution.testframework.sm.runner.SMTestProxy;
  24 import com.intellij.openapi.progress.util.ColorProgressBar;
  25 import com.intellij.openapi.util.Disposer;
  26 import com.intellij.openapi.util.Ref;
  27 import org.jetbrains.annotations.NotNull;
  28 import org.jetbrains.annotations.Nullable;
  29
  30 import javax.swing.tree.DefaultMutableTreeNode;
  31 import javax.swing.tree.TreeModel;
  32 import javax.swing.tree.TreePath;
  33
  34 /**
  35  * @author Roman Chernyatchik
  36  */
  37 public class SMTestRunnerResultsFormTest extends BaseSMTRunnerTestCase {
  38   private SMTRunnerConsoleView myConsole;
  39   private GeneralToSMTRunnerEventsConvertor myEventsProcessor;
  40   private TreeModel myTreeModel;
  41   private SMTestRunnerResultsForm myResultsViewer;
  42   private TestConsoleProperties myConsoleProperties;
  43   private SMTestProxy myTestsRootNode;
  44
  45   @Override
  46   protected void setUp() throws Exception {
  47     super.setUp();
  48
  49     myConsoleProperties = createConsoleProperties();
  50     TestConsoleProperties.HIDE_PASSED_TESTS.set(myConsoleProperties, false);
  51     TestConsoleProperties.OPEN_FAILURE_LINE.set(myConsoleProperties, false);
  52     TestConsoleProperties.SCROLL_TO_SOURCE.set(myConsoleProperties, false);
  53     TestConsoleProperties.SELECT_FIRST_DEFECT.set(myConsoleProperties, false);
  54     TestConsoleProperties.TRACK_RUNNING_TEST.set(myConsoleProperties, false);
  55
  56     final ExecutionEnvironment environment = new ExecutionEnvironment();
  57
  58     myConsole = new SMTRunnerConsoleView(myConsoleProperties, environment.getRunnerSettings(), environment.getConfigurationSettings());
  59     myConsole.initUI();
  60     myResultsViewer = myConsole.getResultsViewer();
  61     myTestsRootNode = myResultsViewer.getTestsRootNode();
  62     myEventsProcessor = new GeneralToSMTRunnerEventsConvertor(myResultsViewer.getTestsRootNode());
  63     myEventsProcessor.addEventsListener(myResultsViewer);
  64     myTreeModel = myResultsViewer.getTreeView().getModel();
  65   }
  66
  67   @Override
  68   protected void tearDown() throws Exception {
  69     Disposer.dispose(myEventsProcessor);
  70     Disposer.dispose(myConsole);
  71
  72     super.tearDown();
  73   }
  74
  75   public void testGetTestsRootNode() {
  76     assertNotNull(myTestsRootNode);
  77
  78     myResultsViewer.onTestingFinished(myTestsRootNode);
  79     assertNotNull(myResultsViewer.getTestsRootNode());
  80   }
  81
  82   public void testTestingStarted() {
  83     myResultsViewer.onTestingStarted(myTestsRootNode);
  84
  85     assertTrue(myResultsViewer.getStartTime() > 0);
  86     assertEquals(0, myResultsViewer.getTestsCurrentCount());
  87     assertEquals(0, myResultsViewer.getTestsTotal());
  88   }
  89
  90   public void testOnTestStarted() {
  91     myResultsViewer.onTestStarted(createTestProxy("some_test", myTestsRootNode));
  92     assertEquals(1, myResultsViewer.getTestsCurrentCount());
  93
  94     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
  95     assertEquals(2, myResultsViewer.getTestsCurrentCount());
  96   }
  97
  98   public void testCount() {
  99     myResultsViewer.onTestsCountInSuite(1);
 100
 101     assertEquals(1, myResultsViewer.getTestsTotal());
 102
 103     myResultsViewer.onTestStarted(createTestProxy("some_test", myTestsRootNode));
 104     assertEquals(1, myResultsViewer.getTestsTotal());
 105
 106     // if exceeds - will be incremented
 107     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 108     assertEquals(2, myResultsViewer.getTestsTotal());
 109   }
 110
 111   public void testCount_UnSet() {
 112     myResultsViewer.onTestStarted(createTestProxy("some_test", myTestsRootNode));
 113     assertEquals(0, myResultsViewer.getTestsTotal());
 114
 115     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 116     assertEquals(0, myResultsViewer.getTestsTotal());
 117
 118     // count will be updated only on tests finished if wasn't set
 119     myResultsViewer.onTestingFinished(myTestsRootNode);
 120     assertEquals(2, myResultsViewer.getTestsTotal());
 121   }
 122
 123   public void testOnTestFailure() {
 124     final SMTestProxy test = createTestProxy(myTestsRootNode);
 125
 126     myResultsViewer.onTestStarted(test);
 127     myResultsViewer.onTestFailed(test);
 128
 129     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 130   }
 131
 132   public void testOnTestFinished() {
 133     final SMTestProxy test = createTestProxy("some_test", myTestsRootNode);
 134
 135     myResultsViewer.onTestStarted(test);
 136     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 137
 138     myResultsViewer.onTestFinished(test);
 139     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 140   }
 141
 142   public void testOnTestsCountInSuite() {
 143     myResultsViewer.onTestsCountInSuite(200);
 144
 145     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 146     assertEquals(200, myResultsViewer.getTestsTotal());
 147
 148     myResultsViewer.onTestsCountInSuite(50);
 149     assertEquals(250, myResultsViewer.getTestsTotal());
 150   }
 151
 152   public void testOnTestStart_ChangeTotal() {
 153     myResultsViewer.onTestsCountInSuite(2);
 154
 155     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 156     assertEquals(2, myResultsViewer.getTestsTotal());
 157     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 158     assertEquals(2, myResultsViewer.getTestsTotal());
 159     myResultsViewer.onTestStarted(createTestProxy("some_test3", myTestsRootNode));
 160     assertEquals(3, myResultsViewer.getTestsTotal());
 161     myResultsViewer.onTestStarted(createTestProxy("some_test4", myTestsRootNode));
 162     assertEquals(4, myResultsViewer.getTestsTotal());
 163
 164     myResultsViewer.onTestsCountInSuite(2);
 165     myResultsViewer.onTestStarted(createTestProxy("another_test1", myTestsRootNode));
 166     assertEquals(6, myResultsViewer.getTestsTotal());
 167     myResultsViewer.onTestStarted(createTestProxy("another_test2", myTestsRootNode));
 168     assertEquals(6, myResultsViewer.getTestsTotal());
 169     myResultsViewer.onTestStarted(createTestProxy("another_test3", myTestsRootNode));
 170     assertEquals(7, myResultsViewer.getTestsTotal());
 171   }
 172
 173   public void testOnFinishTesting_EndTime() {
 174     myResultsViewer.onTestingFinished(myTestsRootNode);
 175     assertTrue(myResultsViewer.getEndTime() > 0);
 176   }
 177
 178   public void testOnSuiteStarted() {
 179     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 180     myResultsViewer.onSuiteStarted(createSuiteProxy(myTestsRootNode));
 181     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 182   }
 183
 184   public void testChangeSelectionAction() {
 185     final Marker onSelectedHappend = new Marker();
 186     final Ref<SMTestProxy> proxyRef = new Ref<SMTestProxy>();
 187     final Ref<Boolean> focusRequestedRef = new Ref<Boolean>();
 188
 189     myResultsViewer.setShowStatisticForProxyHandler(new PropagateSelectionHandler() {
 190       public void handlePropagateSelectionRequest(@Nullable final SMTestProxy selectedTestProxy, @NotNull final Object sender,
 191                                                   final boolean requestFocus) {
 192         onSelectedHappend.set();
 193         proxyRef.set(selectedTestProxy);
 194         focusRequestedRef.set(requestFocus);
 195       }
 196     });
 197
 198     final SMTestProxy suite = createSuiteProxy("suite", myTestsRootNode);
 199     final SMTestProxy test = createTestProxy("test", myTestsRootNode);
 200     myResultsViewer.onSuiteStarted(suite);
 201     myResultsViewer.onTestStarted(test);
 202
 203     //On test
 204     myResultsViewer.selectAndNotify(test);
 205     myResultsViewer.showStatisticsForSelectedProxy();
 206     assertTrue(onSelectedHappend.isSet());
 207     assertEquals(test, proxyRef.get());
 208     assertTrue(focusRequestedRef.get());
 209
 210     //on suite
 211     //reset markers
 212     onSelectedHappend.reset();
 213     proxyRef.set(null);
 214     focusRequestedRef.set(null);
 215
 216     myResultsViewer.selectAndNotify(suite);
 217     myResultsViewer.showStatisticsForSelectedProxy();
 218     assertTrue(onSelectedHappend.isSet());
 219     assertEquals(suite, proxyRef.get());
 220     assertTrue(focusRequestedRef.get());
 221   }
 222
 223   public void testRuby_1767() throws InterruptedException {
 224     TestConsoleProperties.HIDE_PASSED_TESTS.set(myConsoleProperties, true);
 225
 226     myEventsProcessor.onStartTesting();
 227     myEventsProcessor.onSuiteStarted("suite", null);
 228     myResultsViewer.performUpdate();
 229
 230     myEventsProcessor.onTestStarted("test_failed", null);
 231     myResultsViewer.performUpdate();
 232     myEventsProcessor.onTestFailure("test_failed", "", "", false);
 233     myResultsViewer.performUpdate();
 234     myEventsProcessor.onTestFinished("test_failed", 10);
 235     myResultsViewer.performUpdate();
 236
 237     myEventsProcessor.onTestStarted("test", null);
 238     myResultsViewer.performUpdate();
 239     assertEquals(2, myTreeModel.getChildCount(myTreeModel.getChild(myTreeModel.getRoot(), 0)));
 240
 241     myEventsProcessor.onTestFinished("test", 10);
 242     assertEquals(2, myTreeModel.getChildCount(myTreeModel.getChild(myTreeModel.getRoot(), 0)));
 243
 244     myEventsProcessor.onSuiteFinished("suite");
 245     myEventsProcessor.onFinishTesting();
 246
 247     assertEquals(1, myTreeModel.getChildCount(myTreeModel.getChild(myTreeModel.getRoot(), 0)));
 248   }
 249
 250   public void testExpandIfOnlyOneRootChild() throws InterruptedException {
 251     myEventsProcessor.onStartTesting();
 252     myEventsProcessor.onSuiteStarted("suite1", null);
 253     myResultsViewer.performUpdate();
 254     myEventsProcessor.onSuiteStarted("suite2", null);
 255     myResultsViewer.performUpdate();
 256
 257     myEventsProcessor.onTestStarted("test_failed", null);
 258     myResultsViewer.performUpdate();
 259     myEventsProcessor.onTestFailure("test_failed", "", "", false);
 260     myResultsViewer.performUpdate();
 261     myEventsProcessor.onTestFinished("test_failed", 10);
 262     myResultsViewer.performUpdate();
 263
 264     myEventsProcessor.onTestStarted("test", null);
 265     myResultsViewer.performUpdate();
 266
 267     myEventsProcessor.onTestFinished("test", 10);
 268     myResultsViewer.performUpdate();
 269
 270     myEventsProcessor.onSuiteFinished("suite2");
 271     myResultsViewer.performUpdate();
 272     myEventsProcessor.onSuiteFinished("suite1");
 273     myResultsViewer.performUpdate();
 274     myEventsProcessor.onFinishTesting();
 275     myResultsViewer.performUpdate();
 276
 277     final DefaultMutableTreeNode suite1Node =
 278       (DefaultMutableTreeNode)myTreeModel.getChild(myTreeModel.getRoot(), 0);
 279     final DefaultMutableTreeNode suite2Node =
 280       (DefaultMutableTreeNode)myTreeModel.getChild(suite1Node, 0);
 281
 282     assertTrue(myResultsViewer.getTreeView().isExpanded(new TreePath(suite1Node.getPath())));
 283     assertFalse(myResultsViewer.getTreeView().isExpanded(new TreePath(suite2Node.getPath())));
 284   }
 285
 286   public void testCustomProgress_General() {
 287     myResultsViewer.onCustomProgressTestsCategory("foo", 4);
 288
 289     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 290     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 291     myResultsViewer.onCustomProgressTestStarted();
 292     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 293
 294     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 295     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 296     myResultsViewer.onCustomProgressTestStarted();
 297     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 298   }
 299
 300   public void testCustomProgress_MixedMde() {
 301     // enable custom mode
 302     myResultsViewer.onCustomProgressTestsCategory("foo", 4);
 303
 304     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 305     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 306     myResultsViewer.onCustomProgressTestStarted();
 307     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 308
 309     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 310     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 311     myResultsViewer.onCustomProgressTestStarted();
 312     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 313
 314     // disable custom mode
 315     myResultsViewer.onCustomProgressTestsCategory(null, 0);
 316
 317     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 318     myResultsViewer.onCustomProgressTestStarted();
 319     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 320     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 321     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 322
 323     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 324     myResultsViewer.onCustomProgressTestStarted();
 325     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 326     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 327     assertEquals(4, myResultsViewer.getTestsCurrentCount());
 328   }
 329
 330   public void testCustomProgress_Failure() {
 331     myResultsViewer.onCustomProgressTestsCategory("foo", 4);
 332
 333     final SMTestProxy test1 = createTestProxy("some_test1", myTestsRootNode);
 334     myResultsViewer.onTestStarted(test1);
 335     myResultsViewer.onCustomProgressTestStarted();
 336
 337     myResultsViewer.onTestFailed(test1);
 338     assertEquals(0, myResultsViewer.getTestsFailuresCount());
 339
 340     myResultsViewer.onCustomProgressTestFailed();
 341     assertEquals(1, myResultsViewer.getTestsFailuresCount());
 342
 343     assertEquals(ColorProgressBar.RED, myResultsViewer.getTestsStatusColor());
 344   }
 345
 346   public void testCustomProgress_Terminated() {
 347     myResultsViewer.onTestingStarted(myTestsRootNode);
 348
 349     final SMTestProxy test1 = createTestProxy("some_test1", myTestsRootNode);
 350     myResultsViewer.onTestStarted(test1);
 351
 352     myResultsViewer.onTestingFinished(myTestsRootNode);
 353
 354     assertEquals(ColorProgressBar.GREEN, myResultsViewer.getTestsStatusColor());
 355   }
 356
 357   public void testCustomProgress_NotRun() {
 358     myResultsViewer.onTestingStarted(myTestsRootNode);
 359     myResultsViewer.onTestingFinished(myTestsRootNode);
 360
 361     assertEquals(ColorProgressBar.RED, myResultsViewer.getTestsStatusColor());
 362   }
 363
 364   public void testCustomProgress_UnSetCount() {
 365     myResultsViewer.onCustomProgressTestsCategory("foo", 0);
 366
 367     assertEquals(0, myResultsViewer.getTestsTotal());
 368
 369     myResultsViewer.onCustomProgressTestStarted();
 370     assertEquals(0, myResultsViewer.getTestsTotal());
 371
 372     myResultsViewer.onCustomProgressTestStarted();
 373     assertEquals(0, myResultsViewer.getTestsTotal());
 374
 375     // count will be updated only on tests finished if wasn't set
 376     myResultsViewer.onTestingFinished(myTestsRootNode);
 377     assertEquals(2, myResultsViewer.getTestsTotal());
 378   }
 379
 380   public void testCustomProgress_IncreaseCount() {
 381     myResultsViewer.onCustomProgressTestsCategory("foo", 1);
 382
 383     assertEquals(1, myResultsViewer.getTestsTotal());
 384
 385     myResultsViewer.onCustomProgressTestStarted();
 386     assertEquals(1, myResultsViewer.getTestsTotal());
 387
 388     myResultsViewer.onCustomProgressTestStarted();
 389     assertEquals(2, myResultsViewer.getTestsTotal());
 390   }
 391
 392   public void testCustomProgress_IncreaseCount_MixedMode() {
 393     // custom mode
 394     myResultsViewer.onCustomProgressTestsCategory("foo", 1);
 395
 396     assertEquals(1, myResultsViewer.getTestsTotal());
 397
 398     myResultsViewer.onCustomProgressTestStarted();
 399     assertEquals(1, myResultsViewer.getTestsTotal());
 400
 401     myResultsViewer.onCustomProgressTestStarted();
 402     assertEquals(2, myResultsViewer.getTestsTotal());
 403
 404     // disable custom mode
 405     myResultsViewer.onCustomProgressTestsCategory(null, 0);
 406     assertEquals(2, myResultsViewer.getTestsTotal());
 407
 408     myResultsViewer.onTestsCountInSuite(1);
 409     assertEquals(3, myResultsViewer.getTestsTotal());
 410
 411     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 412     assertEquals(3, myResultsViewer.getTestsTotal());
 413
 414     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 415     assertEquals(4, myResultsViewer.getTestsTotal());
 416   }
 417
 418   //TODO categories - mized
 419
 420   public void testCustomProgress_MentionedCategories_CategoryWithoutName() {
 421     // enable custom mode
 422     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 423
 424     myResultsViewer.onCustomProgressTestsCategory("foo", 4);
 425
 426     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 427   }
 428
 429   public void testCustomProgress_MentionedCategories_DefaultCategory() {
 430     // enable custom mode
 431     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 432
 433     myResultsViewer.onCustomProgressTestStarted();
 434
 435     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 436   }
 437
 438   public void testCustomProgress_MentionedCategories_OneCustomCategory() {
 439     // enable custom mode
 440     myResultsViewer.onCustomProgressTestsCategory("Foo", 4);
 441     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 442
 443     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 444     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 445
 446     myResultsViewer.onCustomProgressTestStarted();
 447     assertSameElements(myResultsViewer.getMentionedCategories(), "Foo");
 448
 449     // disable custom mode
 450     myResultsViewer.onCustomProgressTestsCategory(null, 0);
 451     assertSameElements(myResultsViewer.getMentionedCategories(), "Foo");
 452   }
 453
 454   public void testCustomProgress_MentionedCategories_SeveralCategories() {
 455     // enable custom mode
 456     myResultsViewer.onCustomProgressTestsCategory("Foo", 4);
 457     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 458
 459     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 460     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 461
 462     myResultsViewer.onCustomProgressTestStarted();
 463     assertSameElements(myResultsViewer.getMentionedCategories(), "Foo");
 464
 465     // disable custom mode
 466     myResultsViewer.onCustomProgressTestsCategory(null, 0);
 467
 468     myResultsViewer.onCustomProgressTestStarted();
 469     assertSameElements(myResultsViewer.getMentionedCategories(), "Foo");
 470
 471     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 472     assertSameElements(myResultsViewer.getMentionedCategories(), "Foo", TestsPresentationUtil.DEFAULT_TESTS_CATEGORY);
 473   }
 474
 475   public void testCustomProgress_MentionedCategories() {
 476     // enable custom mode
 477     assertTrue(myResultsViewer.getMentionedCategories().isEmpty());
 478
 479     myResultsViewer.onCustomProgressTestsCategory("foo", 4);
 480
 481     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 482     assertEquals(0, myResultsViewer.getTestsCurrentCount());
 483     myResultsViewer.onCustomProgressTestStarted();
 484     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 485
 486     myResultsViewer.onTestStarted(createTestProxy("some_test2", myTestsRootNode));
 487     assertEquals(1, myResultsViewer.getTestsCurrentCount());
 488     myResultsViewer.onCustomProgressTestStarted();
 489     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 490
 491     // disable custom mode
 492     myResultsViewer.onCustomProgressTestsCategory(null, 0);
 493
 494     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 495     myResultsViewer.onCustomProgressTestStarted();
 496     assertEquals(2, myResultsViewer.getTestsCurrentCount());
 497     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 498     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 499
 500     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 501     myResultsViewer.onCustomProgressTestStarted();
 502     assertEquals(3, myResultsViewer.getTestsCurrentCount());
 503     myResultsViewer.onTestStarted(createTestProxy("some_test1", myTestsRootNode));
 504     assertEquals(4, myResultsViewer.getTestsCurrentCount());
 505   }
 506 }