add patch fix-return-value-of-ext4_do_update_inode
[ext4-patch-queue.git] / remove-a-duplicate-call-in-ext4_init_new_dir
blobc9e8f289b70807338de82eea9d6c51394296662d
1 ext4: remove a duplicate call in ext4_init_new_dir()
3 From: Wang Shilong <wshilong@ddn.com>
5 ext4_journal_get_write_access() has just been called in ext4_append()
6 calling it again here is duplicated.
8 Signed-off-by: Wang Shilong <wshilong@ddn.com>
9 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
10 ---
11  fs/ext4/namei.c | 4 ----
12  1 file changed, 4 deletions(-)
14 diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
15 index 3520ab8..6d0d01f 100644
16 --- a/fs/ext4/namei.c
17 +++ b/fs/ext4/namei.c
18 @@ -2390,10 +2390,6 @@ static int ext4_init_new_dir(handle_t *handle, struct inode *dir,
19         dir_block = ext4_append(handle, inode, &block);
20         if (IS_ERR(dir_block))
21                 return PTR_ERR(dir_block);
22 -       BUFFER_TRACE(dir_block, "get_write_access");
23 -       err = ext4_journal_get_write_access(handle, dir_block);
24 -       if (err)
25 -               goto out;
26         de = (struct ext4_dir_entry_2 *)dir_block->b_data;
27         ext4_init_dot_dotdot(inode, de, blocksize, csum_size, dir->i_ino, 0);
28         set_nlink(inode, 2);
29 -- 
30 1.9.3
33 To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
34 the body of a message to majordomo@vger.kernel.org
35 More majordomo info at  http://vger.kernel.org/majordomo-info.html