add-missing-le32-conversions

   1 ext4: add missing le32_to_cpu(e_value_inum) conversions
   2
   3 From: Tahsin Erdogan <tahsin@google.com>
   4
   5 Two places in code missed converting xattr inode number using
   6 le32_to_cpu().
   7
   8 Signed-off-by: Tahsin Erdogan <tahsin@google.com>
   9 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  10 ---
  11  fs/ext4/xattr.c | 9 +++++----
  12  1 file changed, 5 insertions(+), 4 deletions(-)
  13
  14 diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
  15 index 8e855fc2eb03..4dd8be16d175 100644
  16 --- a/fs/ext4/xattr.c
  17 +++ b/fs/ext4/xattr.c
  18 @@ -1997,6 +1997,7 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode,
  19         struct ext4_inode *raw_inode;
  20         struct ext4_iloc iloc;
  21         struct ext4_xattr_entry *entry;
  22 +       unsigned int ea_ino;
  23         int credits = 3, error = 0;
  24
  25         if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR))
  26 @@ -2011,8 +2012,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode,
  27              entry = EXT4_XATTR_NEXT(entry)) {
  28                 if (!entry->e_value_inum)
  29                         continue;
  30 -               if (ext4_expand_ino_array(lea_ino_array,
  31 -                                         entry->e_value_inum) != 0) {
  32 +               ea_ino = le32_to_cpu(entry->e_value_inum);
  33 +               if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0) {
  34                         brelse(iloc.bh);
  35                         goto cleanup;
  36                 }
  37 @@ -2044,8 +2045,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode,
  38              entry = EXT4_XATTR_NEXT(entry)) {
  39                 if (!entry->e_value_inum)
  40                         continue;
  41 -               if (ext4_expand_ino_array(lea_ino_array,
  42 -                                         entry->e_value_inum) != 0)
  43 +               ea_ino = le32_to_cpu(entry->e_value_inum);
  44 +               if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0)
  45                         goto cleanup;
  46                 entry->e_value_inum = 0;
  47         }
  48 --
  49 2.13.1.611.g7e3b11ae1-goog
  50
  51