remove-unused-ac_ex_scanned

   1 ext4: remove unused ac_ex_scanned
   2
   3 From: Eric Sandeen <sandeen@redhat.com>
   4
   5 When looking at a bug report with:
   6
   7 > kernel: EXT4-fs: 0 scanned, 0 found
   8
   9 I thought wow, 0 scanned, that's odd?  But it's not odd; it's printing
  10 a variable that is initialized to 0 and never touched again.
  11
  12 It's never been used since the original merge, so I don't really even
  13 know what the original intent was, either.
  14
  15 If anyone knows how to hook it up, speak now via patch, otherwise just
  16 yank it so it's not making a confusing situation more confusing in
  17 kernel logs.
  18
  19 Signed-off-by: Eric Sandeen <sandeen@redhat.com>
  20 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  21 ---
  22
  23 diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
  24 index 4bbbf13..3aee266 100644
  25 --- a/fs/ext4/mballoc.c
  26 +++ b/fs/ext4/mballoc.c
  27 @@ -3983,8 +3983,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac)
  28                         (unsigned long)ac->ac_b_ex.fe_len,
  29                         (unsigned long)ac->ac_b_ex.fe_logical,
  30                         (int)ac->ac_criteria);
  31 -       ext4_msg(ac->ac_sb, KERN_ERR, "%lu scanned, %d found",
  32 -                ac->ac_ex_scanned, ac->ac_found);
  33 +       ext4_msg(ac->ac_sb, KERN_ERR, "%d found", ac->ac_found);
  34         ext4_msg(ac->ac_sb, KERN_ERR, "groups: ");
  35         ngroups = ext4_get_groups_count(sb);
  36         for (i = 0; i < ngroups; i++) {
  37 diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
  38 index 08481ee..72db0a0 100644
  39 --- a/fs/ext4/mballoc.h
  40 +++ b/fs/ext4/mballoc.h
  41 @@ -175,8 +175,6 @@ struct ext4_allocation_context {
  42         /* copy of the best found extent taken before preallocation efforts */
  43         struct ext4_free_extent ac_f_ex;
  44
  45 -       /* number of iterations done. we have to track to limit searching */
  46 -       unsigned long ac_ex_scanned;
  47         __u16 ac_groups_scanned;
  48         __u16 ac_found;
  49         __u16 ac_tail;
  50
  51 --
  52 To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
  53 the body of a message to majordomo@vger.kernel.org
  54 More majordomo info at  http://vger.kernel.org/majordomo-info.html
  55