add patch move-error-report-out-of-atomic-context
[ext4-patch-queue.git] / fix-return-value-of-ext4_do_update_inode
blobe1e0fb2c5d11342b2c416ceb27d7900c3cbaa161
1 ext4: fix return value of ext4_do_update_inode
3 From: Li Xi <pkuelelixi@gmail.com>
5 When ext4_do_update_inode() gets error from ext4_inode_blocks_set(),
6 error number should be returned.
8 Signed-off-by: Li Xi <lixi@ddn.com>
9 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
10 Reviewed-by: Eric Sandeen <sandeen@redhat.com>
11 Reviewed-by: Jan Kara <jack@suse.cz>
12 ---
13  fs/ext4/inode.c |    3 ++-
14  1 files changed, 2 insertions(+), 1 deletions(-)
16 diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
17 index d5dd7d4..03ddfd7 100644
18 --- a/fs/ext4/inode.c
19 +++ b/fs/ext4/inode.c
20 @@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle,
21         EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode);
22         EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode);
24 -       if (ext4_inode_blocks_set(handle, raw_inode, ei)) {
25 +       err = ext4_inode_blocks_set(handle, raw_inode, ei);
26 +       if (err) {
27                 spin_unlock(&ei->i_raw_lock);
28                 goto out_brelse;
29         }
30 -- 
31 1.7.1
34 To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
35 the body of a message to majordomo@vger.kernel.org
36 More majordomo info at  http://vger.kernel.org/majordomo-info.html