1 2012-04-20 Chong Yidong <cyd@gnu.org>
3 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4 set the status to "failed" and ensure that sentinel is run.
6 2012-04-18 Glenn Morris <rgm@gnu.org>
8 * process.c (Fset_process_inherit_coding_system_flag)
9 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
10 (Fmake_network_process, Fmake_serial_process): Doc fix.
12 2012-04-17 Eli Zaretskii <eliz@gnu.org>
14 * xdisp.c (string_buffer_position_lim): Limit starting position to
16 (set_cursor_from_row): If called for a mode-line or header-line
17 row, return zero immediately.
18 (try_cursor_movement): If inside continuation line, don't back up
19 farther than the first row after the header line, if any. Don't
20 consider the header-line row as "partially visible", even if
21 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
23 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
25 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
27 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
29 * process.c (make_process):
30 * process.h: Add integer `gnutls_handshakes_tried' member to
33 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
34 Add convenience `GNUTLS_LOG2i' macro.
36 * gnutls.c (gnutls_log_function2i): Convenience log function.
37 (emacs_gnutls_read): Use new log functions,
38 `gnutls_handshakes_tried' process member, and
39 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
40 attempts per process (connection).
42 2012-04-09 Eli Zaretskii <eliz@gnu.org>
44 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
45 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
47 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
49 * nsterm.m (constrainFrameRect): Always constrain when there is only
50 one screen (Bug#10962).
52 2012-04-06 Eli Zaretskii <eliz@gnu.org>
54 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
55 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
56 about subtle differences between FETCH_CHAR* and STRING_CHAR*
57 macros related to unification of CJK characters. For the details,
58 see the discussion following the message here:
59 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
61 2012-04-04 Chong Yidong <cyd@gnu.org>
63 * keyboard.c (Vdelayed_warnings_list): Doc fix.
65 2012-04-01 Eli Zaretskii <eliz@gnu.org>
67 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
68 instead of alloca. (Bug#11138)
70 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
72 * w32menu.c (is_simple_dialog): Properly check lisp types.
75 2012-03-31 Eli Zaretskii <eliz@gnu.org>
77 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
78 position we get to after a call to move_it_to fails the
79 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
80 only if we wind up in a string from display property. (Bug#11063)
82 * window.c (Fdelete_other_windows_internal): Invalidate the row
83 and column information about mouse highlight, so that redisplay
84 restores it after reallocating the glyph matrices. (Bug#7464)
86 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
87 string comes from a `display' text property, use the buffer
88 position of that property as if we actually saw that position in
90 (move_it_by_lines): Remove the assertion that
91 "it->current_x == 0 && it->hpos == 0" which can be legitimately
92 violated when there's a before-string at the beginning of a line.
95 2012-03-30 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (append_space_for_newline): If the default face was
98 remapped, use the remapped face for the appended newline.
99 (extend_face_to_end_of_line): Use the remapped default face for
100 extending the face to the end of the line.
101 (display_line): Call extend_face_to_end_of_line when the default
102 face was remapped. (Bug#11068)
104 2012-03-29 Eli Zaretskii <eliz@gnu.org>
106 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
108 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
110 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
112 2012-03-27 Glenn Morris <rgm@gnu.org>
114 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
117 2012-03-26 Kenichi Handa <handa@m17n.org>
119 * dispextern.h (struct glyph): Fix previous change. Change the
120 bit length of glyphless.ch to 25 (Bug#11082).
122 2012-03-26 Chong Yidong <cyd@gnu.org>
124 * keyboard.c (Vselection_inhibit_update_commands): New variable.
125 (command_loop_1): Use it; inhibit selection update for
126 handle-select-window too (Bug#8996).
128 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
130 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
132 2012-03-25 Kenichi Handa <handa@m17n.org>
134 * dispextern.h (struct glyph): Change the bit length of
135 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
137 2012-03-24 Eli Zaretskii <eliz@gnu.org>
139 * s/ms-w32.h (tzname): Include time.h before redirecting to
140 _tzname. Fixes the MSVC build. (Bug#9960)
142 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
144 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
147 * xterm.c (XTread_socket): Only modify handling_signal if
148 !SYNC_INPUT. (Bug#11080)
150 2012-03-23 Eli Zaretskii <eliz@gnu.org>
152 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
153 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
154 when fetching a multibyte character consumes more bytes than
155 CHAR_BYTES returns, due to unification of CJK characters in
156 string_char. (Bug#11073)
158 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
160 * process.c (wait_reading_process_output): Handle pty disconnect
161 by refraining from sending oneself a SIGCHLD (bug#10933).
163 2012-03-22 Chong Yidong <cyd@gnu.org>
165 * dispextern.h (struct it): New member string_from_prefix_prop_p.
167 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
168 Mark string as coming from a prefix property.
169 (handle_face_prop): Use default face for prefix strings (Bug#4281).
170 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
172 2012-03-21 Chong Yidong <cyd@gnu.org>
174 * xfaces.c (Vface_remapping_alist): Doc fix.
176 2012-03-20 Eli Zaretskii <eliz@gnu.org>
178 * w32proc.c (Fw32_set_console_codepage)
179 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
182 2012-03-20 Chong Yidong <cyd@gnu.org>
184 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
185 to reflect default non-nil value of redisplay-dont-pause.
187 2012-03-19 Kenichi Handa <handa@m17n.org>
189 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
190 it fit in a valid range (Bug#11003).
192 2012-03-18 Eli Zaretskii <eliz@gnu.org>
194 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
195 that is not from display property, accept the row as a "cursor
196 row" if one of the string's character has a non-nil `cursor'
197 property. Fixes cursor positioning when there are newlines in
198 overlay strings, e.g. in icomplete.el. (Bug#11035)
200 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
202 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
204 2012-03-12 Chong Yidong <cyd@gnu.org>
206 * eval.c (inhibit_lisp_code): Rename from
207 inhibit_window_configuration_change_hook; move from window.c.
209 * xfns.c (unwind_create_frame_1, Fx_create_frame):
210 * window.c (run_window_configuration_change_hook)
211 (syms_of_window): Callers changed.
213 2012-03-11 Chong Yidong <cyd@gnu.org>
215 * keymap.c (Fkey_description): Doc fix (Bug#9700).
217 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
219 2012-03-10 Chong Yidong <cyd@gnu.org>
221 * frame.c (other_visible_frames): Don't assume the selected frame
222 is visible (Bug#10955).
224 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
226 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
228 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
230 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
231 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
234 2012-03-03 Glenn Morris <rgm@gnu.org>
236 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
238 2012-03-02 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
241 position past the first glyph_row that ends at ZV. (Bug#10902)
242 (redisplay_window, next_element_from_string): Fix typos in
244 (redisplay_window): Pass to move_it_vertically the margin in
245 pixels, not in screen lines.
247 2012-03-02 Glenn Morris <rgm@gnu.org>
249 * buffer.c (buffer-list-update-hook): Doc fix.
251 2012-02-29 Eli Zaretskii <eliz@gnu.org>
253 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
254 push_it before setting up the iterator for the first overlay
255 string, even if we have an empty string loaded.
256 (next_overlay_string): If there's an empty string on the iterator
257 stack, pop the stack. (Bug#10903)
259 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
261 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
262 Suggested by Stefan Monnier in
263 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
264 * alloc.c (widen_to_Lisp_Object): New static function.
265 (mark_memory): Also mark Lisp_Objects by fetching pointer words
266 and widening them to Lisp_Objects. This would work even if
267 USE_LSB_TAG is defined and wide integers are used, which might
268 happen in a future version of Emacs.
270 2012-02-25 Chong Yidong <cyd@gnu.org>
272 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
275 * xselect.c (Fx_selection_exists_p): Doc fix.
276 (x_clipboard_manager_save_all): Print an informative message
277 before saving to clipboard manager.
279 2012-02-24 Chong Yidong <cyd@gnu.org>
281 * keyboard.c (process_special_events): Handle all X selection
282 requests in kbd_buffer, not just the next one (Bug#8869).
284 2012-02-23 Chong Yidong <cyd@gnu.org>
286 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
287 call when setting menu-bar-lines and tool-bar-lines parameters.
288 (unwind_create_frame_1): New helper function.
290 * window.c (inhibit_window_configuration_change_hook): New var.
291 (run_window_configuration_change_hook): Obey it.
292 (syms_of_window): Initialize it.
294 2012-02-22 Chong Yidong <cyd@gnu.org>
296 * xterm.c (x_draw_image_relief): Add missing type check for
297 Vtool_bar_button_margin (Bug#10743).
299 2012-02-21 Chong Yidong <cyd@gnu.org>
301 * fileio.c (Vfile_name_handler_alist): Doc fix.
303 * buffer.c (Fget_file_buffer): Protect against invalid file
304 handler return value.
306 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
308 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
309 when computing $valmask.
311 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
312 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
313 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
314 It's useless in that case, and it can cause problems on hosts
315 that allocate halves of EMACS_INT values separately.
316 Reported by Dan Horák. Diagnosed by Andreas Schwab in
317 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
318 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
319 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
320 it avoids undefined behavior on hosts where shifting right by more
321 than the word width has undefined behavior.
323 2012-02-19 Chong Yidong <cyd@gnu.org>
325 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
326 (Funhandled_file_name_directory, Ffile_name_as_directory)
327 (Fdirectory_file_name, Fexpand_file_name)
328 (Fsubstitute_in_file_name): Protect against invalid file handler
329 return values (Bug#10845).
331 2012-02-18 Eli Zaretskii <eliz@gnu.org>
333 * .gdbinit (pitx): Fix incorrect references to fields of the
336 2012-02-17 Chong Yidong <cyd@gnu.org>
338 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
340 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
342 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
343 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
345 2012-02-15 Chong Yidong <cyd@gnu.org>
347 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
348 marked as special. Also, starting docstrings with * is obsolete.
350 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
352 * gnutls.c (emacs_gnutls_write): Fix last change.
354 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
356 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
359 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
361 * keymap.c (Fsingle_key_description): Handle char ranges.
363 2012-02-12 Chong Yidong <cyd@gnu.org>
365 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
366 as that creates a dangerous corner case.
368 * window.c (Fdelete_window_internal): Invalidate the mouse
369 highlight (Bug#9904).
371 2012-02-12 Glenn Morris <rgm@gnu.org>
373 * xselect.c (Fx_own_selection_internal)
374 (Fx_get_selection_internal, Fx_disown_selection_internal)
375 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
376 * nsselect.m (Fx_own_selection_internal)
377 (Fx_disown_selection_internal, Fx_selection_exists_p)
378 (Fx_selection_owner_p, Fx_get_selection_internal):
379 Sync docs and argument specs with the xselect.c versions.
381 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
383 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
385 2012-02-11 Eli Zaretskii <eliz@gnu.org>
387 * w32select.c (Fx_selection_exists_p): Sync doc string and
388 argument list with xselect.c. (Bug#10783)
390 * w16select.c (Fx_selection_exists_p): Sync doc string and
391 argument list with xselect.c. (Bug#10783)
393 2012-02-10 Glenn Morris <rgm@gnu.org>
395 * fns.c (Fsecure_hash): Doc fix.
397 2012-02-09 Kenichi Handa <handa@m17n.org>
399 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
401 2012-02-07 Chong Yidong <cyd@gnu.org>
403 * buffer.c (Fbuffer_local_variables)
404 (buffer_lisp_local_variables): Handle unbound vars correctly;
405 don't let Qunbound leak into Lisp.
407 2012-02-07 Glenn Morris <rgm@gnu.org>
409 * image.c (Fimagemagick_types): Doc fix.
411 * image.c (imagemagick-render-type): Change it from a lisp object
412 to an integer. Move the doc here from the lisp manual.
413 Treat all values not equal to 0 the same.
415 2012-02-06 Chong Yidong <cyd@gnu.org>
417 * doc.c (store_function_docstring): Avoid applying docstring of
418 alias to base function (Bug#2603).
420 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
422 * .gdbinit (pp1, pv1): Remove redundant defines.
425 2012-02-04 Chong Yidong <cyd@gnu.org>
427 * nsterm.m: Declare a global (Bug#10694).
429 2012-02-04 Eli Zaretskii <eliz@gnu.org>
431 * w32.c (get_emacs_configuration_options):
432 Include --enable-checking, if specified, in the return value.
434 2012-02-04 Martin Rudalics <rudalics@gmx.at>
436 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
437 after rounding frame sizes. (Bug#9723)
439 2012-02-04 Eli Zaretskii <eliz@gnu.org>
441 * keyboard.c (adjust_point_for_property): Don't position point
442 before BEGV. (Bug#10696)
444 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
446 Handle overflow when computing char display width (Bug#9496).
447 * character.c (char_width): Return EMACS_INT, not int.
448 (char_width, c_string_width): Check for overflow when
449 computing the width; this is possible now that individual
450 characters can have unbounded width. Problem introduced
451 by merge from Emacs 23 on 2012-01-19.
453 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
455 * dbusbind.c (Fdbus_register_method): Mention the return value
456 :ignore in the docstring.
458 2012-02-02 Glenn Morris <rgm@gnu.org>
460 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
462 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
463 Unconditionally set to t. (Bug#10673)
464 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
465 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
466 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
468 2012-02-02 Kenichi Handa <handa@m17n.org>
470 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
471 0, do not call append_composite_glyph.
473 2012-02-02 Kenichi Handa <handa@m17n.org>
475 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
477 (x_produce_glyphs): If the component of a composition is a null
478 string, set it->pixel_width to 1 to avoid zero-width glyph.
480 2012-02-01 Eli Zaretskii <eliz@gnu.org>
482 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
483 first 2 arguments are identical. This makes inserting large
484 output from a subprocess an order of magnitude faster on
485 MS-Windows, where all sbrk'ed memory is always contiguous.
487 2012-01-31 Glenn Morris <rgm@gnu.org>
489 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
490 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
491 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
493 2012-01-29 Glenn Morris <rgm@gnu.org>
495 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
497 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
499 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
501 2012-01-28 Chong Yidong <cyd@gnu.org>
503 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
505 2012-01-26 Chong Yidong <cyd@gnu.org>
507 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
509 * search.c (Fsearch_forward, Fsearch_backward): Document negative
510 repeat counts (Bug#10507).
512 2012-01-26 Glenn Morris <rgm@gnu.org>
514 * lread.c (syms_of_lread): Doc fix.
516 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
518 * coding.c (encode_designation_at_bol): Change return value to
521 2012-01-25 Chong Yidong <cyd@gnu.org>
523 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
525 2012-01-21 Chong Yidong <cyd@gnu.org>
527 * floatfns.c (Fcopysign): Make the second argument non-optional,
528 since nil is not allowed anyway.
530 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
532 * process.c (read_process_output): Use p instead of XPROCESS (proc).
533 (send_process): Likewise.
535 2012-01-19 Martin Rudalics <rudalics@gmx.at>
537 * window.c (save_window_save, Fcurrent_window_configuration)
538 (Vwindow_persistent_parameters): Do not use Qstate.
541 2012-01-19 Kenichi Handa <handa@m17n.org>
543 * character.c (char_width): New function.
544 (Fchar_width, c_string_width, lisp_string_width):
545 Use char_width (Bug#9496).
547 2012-01-16 Martin Rudalics <rudalics@gmx.at>
549 * window.c (Vwindow_persistent_parameters): New variable.
550 (Fset_window_configuration, save_window_save): Handle persistent
553 2012-01-14 Eli Zaretskii <eliz@gnu.org>
555 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
556 thrashing the stack of the thread. (Bug#9087)
558 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
560 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
562 2012-01-11 Eli Zaretskii <eliz@gnu.org>
564 * xdisp.c (rows_from_pos_range): Handle the case where the
565 highlight ends on a newline. (Bug#10464)
566 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
567 he end column for display of highlight that ends on a newline
570 2012-01-11 Glenn Morris <rgm@gnu.org>
572 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
573 from load-path also when installation-directory is nil. (Bug#10208)
575 2012-01-10 Glenn Morris <rgm@gnu.org>
577 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
579 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
580 Update template values to be closer to their typical values these days.
582 2012-01-09 Eli Zaretskii <eliz@gnu.org>
584 * xdisp.c (rows_from_pos_range): Accept additional argument
585 DISP_STRING, and accept any glyph in a row whose object is that
586 string as eligible for mouse highlight. Fixes mouse highlight of
587 display strings from overlays. (Bug#10464)
589 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
591 emacs: fix an auto-save permissions race condition (Bug#10400)
592 * fileio.c (auto_saving_dir_umask): New static var.
593 (Fmake_directory_internal): Use it.
594 (do_auto_save_make_dir): Set it, instead of invoking chmod after
595 creating the directory. The old code temporarily assigns
596 too-generous permissions to the directory.
597 (do_auto_save_eh): Clear it.
598 (Fdo_auto_save): Catch all errors, not just file errors, so
599 that the var is always cleared.
601 2012-01-07 Eli Zaretskii <eliz@gnu.org>
603 * search.c (scan_buffer): Pass character positions to
604 know_region_cache, not byte positions. (Bug#6540)
606 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
608 * w32.c (sys_rename): Report EXDEV when rename of a directory
609 fails because the target is on another logical disk. (Bug#10284)
611 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
613 * xterm.c (x_embed_request_focus): New function.
615 * xterm.h: Add prototype.
617 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
619 2012-01-05 Glenn Morris <rgm@gnu.org>
621 * emacs.c (emacs_copyright): Update short copyright year to 2012.
623 2012-01-01 Eli Zaretskii <eliz@gnu.org>
625 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
626 Load gnutls_transport_set_lowat only if GnuTLS version is below
628 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
629 GnuTLS versions below 2.11.1.
631 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
633 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
634 to the doc string advising against its use for altering the way
635 windows are scrolled.
637 2011-12-28 Kenichi Handa <handa@m17n.org>
639 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
640 coding-system ASCII compatible only when it does not produce BOM
641 on encoding (Bug#10383).
643 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
645 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
647 (create_and_show_popup_menu): Always use menu_position_func for
650 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
652 * callint.c (Fcall_interactively): Don't truncate prompt string.
654 2011-12-23 Eli Zaretskii <eliz@gnu.org>
656 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
657 property that ends at ZV, so that the bidi iteration could be
658 resumed from there (after widening). (Bug#10360)
660 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
662 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
664 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
666 * nsterm.m (x_free_frame_resources):
667 Release f->output_data.ns->miniimage.
668 (ns_index_color): Fix indentation. Do not retain
669 color_table->colors[i].
671 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
674 * nsfns.m (x_set_background_color): Assign return value from
675 ns_index_color to face-background instead of NSColor*.
676 (ns_implicitly_set_icon_type): Fix indentation.
677 Change assignment in for loop to comparison.
679 * emacs.c (ns_pool): New variable.
680 (main): Assign ns_pool.
681 (Fkill_emacs): Call ns_release_autorelease_pool.
683 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
684 autorelease fdesc, release fdAttrs and tdict.
685 (ns_get_covering_families): Release charset.
686 (ns_findfonts): Release NSFontDescriptor created with new.
687 (ns_uni_to_glyphs): Fix indentation.
688 (setString): Release attrStr before assigning new value.
690 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
692 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
694 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
695 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
697 2011-12-18 David Reitter <reitter@cmu.edu>
699 * nsterm.m (ns_term_init): Subscribe for notifications
700 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
701 to method trackingNotification in EmacsMenu.
703 * nsmenu.m (trackingMenu): New variable.
704 (trackingNotification): New method (from Aquamacs).
705 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
706 from Aquamacs (Bug#7030).
708 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
710 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
711 (symbol_to_nsstring): Fix indentation.
712 (ns_symbol_to_pb): New function.
713 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
714 (Fns_rotate_cut_buffers_internal): Remove.
715 (Fns_store_selection_internal): Rename from
716 Fns_store_cut_buffer_internal.
717 (ns_get_foreign_selection, Fx_own_selection_internal)
718 (Fx_disown_selection_internal, Fx_selection_exists_p)
719 (Fns_get_selection_internal, Fns_store_selection_internal):
720 Use ns_symbol_to_pb and check if return value is nil.
721 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
722 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
723 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
724 renamed to Sns_store_selection_internal.
725 (ns_handle_selection_request): Move code to Fx_own_selection_internal
726 and remove this function.
727 (ns_handle_selection_clear): Remove, never used.
728 (Fx_own_selection_internal): Move code from ns_handle_selection_request
731 2011-12-17 Ken Brown <kbrown@cornell.edu>
733 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
734 GID is unknown (Bug#10257).
736 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
738 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
739 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
740 which caused a build failure on GNU/Linux IA-64. This problem was
741 introduced by my 2011-10-07 patch.
743 2011-12-15 Juri Linkov <juri@jurta.org>
745 * image.c (imagemagick_error): New function. (Bug#10112)
746 (imagemagick_load_image): Comment out `MagickSetResolution' call.
747 Use `imagemagick_error' where ImageMagick functions return
749 (Fimagemagick_types): Add `Fnreverse' to return the list in the
752 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
754 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
755 fill background (Bug#8992).
757 2011-12-13 Martin Rudalics <rudalics@gmx.at>
759 * window.c (Vwindow_combination_resize)
760 (Vwindow_combination_limit): Use t instead of non-nil in
762 (Vrecenter_redisplay): Add first sentence of doc-string on
764 (Frecenter): Fix doc-string typo.
766 2011-12-11 Kenichi Handa <handa@m17n.org>
768 * coding.c (Funencodable_char_position): Pay attention to the
769 buffer text relocation (Bug#9389).
771 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
773 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
774 gtk_init (Bug#10100).
776 2011-12-10 Eli Zaretskii <eliz@gnu.org>
778 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
779 IT->string is nil. (Bug#10263)
781 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
783 * nsterm.h (x_free_frame_resources): Declare.
785 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
786 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
788 * nsterm.h (ns_get_defaults_value): Declare.
790 * nsterm.m (ns_default): Call ns_get_defaults_value.
792 2011-12-09 Eli Zaretskii <eliz@gnu.org>
794 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
797 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
799 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
800 that where the value of an _OBJC_* symbol points to is in the .bss
803 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
805 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
806 after the loop to call ccl_driver at least once (Bug#8619).
808 2011-12-08 Kenichi Handa <handa@m17n.org>
810 * ftfont.c (get_adstyle_property): Fix previous change
813 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
815 * w32.c (init_environment): If no_site_lisp, remove site-lisp
816 dirs from the default value of EMACSLOADPATH (bug#10208).
818 2011-12-07 Glenn Morris <rgm@gnu.org>
820 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
821 installation and source directories as well. (Bug#10208)
823 2011-12-06 Chong Yidong <cyd@gnu.org>
825 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
827 2011-12-06 Glenn Morris <rgm@gnu.org>
829 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
830 as an error, not just -1. (Bug#10217)
832 2011-12-05 Chong Yidong <cyd@gnu.org>
834 * keyboard.c (process_special_events): New function.
835 (swallow_events, Finput_pending_p): Use it (Bug#10195).
837 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
839 * coding.c (encode_designation_at_bol): Don't use uninitialized
840 local variable (Bug#9318).
842 2011-12-05 Kenichi Handa <handa@m17n.org>
844 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
845 return Qnil (Bug#8046, Bug#10193).
847 2011-12-05 Kenichi Handa <handa@m17n.org>
849 * coding.c (encode_designation_at_bol): New args charbuf_end and
850 dst. Return the number of produced bytes. Callers changed.
851 (coding_set_source): Return how many bytes coding->source was
853 (coding_set_destination): Return how many bytes
854 coding->destination was relocated.
855 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
856 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
858 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
860 * coding.c (CODING_CHAR_CHARSET_P): New macro.
861 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
864 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
866 The following changes are to fix Bug#9318.
868 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
869 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
870 (encode_coding_iso_2022, encode_coding_sjis)
871 (encode_coding_big5, encode_coding_charset): Use the above macros.
873 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
875 * lisp.h (process_quit_flag): Fix external declaration.
877 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
879 Don't macro-inline non-performance-critical code.
880 * eval.c (process_quit_flag): New function.
881 * lisp.h (QUIT): Use it.
883 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
885 * nsfns.m (get_geometry_from_preferences): New function.
886 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
888 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
890 * emacs.c (Qkill_emacs): Define.
891 (syms_of_emacs): Initialize it.
892 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
893 Qquit_flag to `kill-emacs' instead.
894 (quit_throw_to_read_char): Add parameter `from_signal'.
895 All callers changed. Call Fkill_emacs if requested and safe.
896 * lisp.h (QUIT): Call Fkill_emacs if requested.
898 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
900 * widget.c (update_wm_hints): Return if wmshell is null.
901 (widget_update_wm_size_hints): New function.
903 * widget.h (widget_update_wm_size_hints): Declare.
905 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
906 widget_update_wm_size_hints (Bug#10104).
908 2011-12-03 Eli Zaretskii <eliz@gnu.org>
910 * xdisp.c (handle_invisible_prop): If the invisible text ends just
911 before a newline, prepare the bidi iterator for consuming the
912 newline, and keep the current paragraph direction. (Bug#10183)
913 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
915 2011-12-02 Juri Linkov <juri@jurta.org>
917 * search.c (Fword_search_regexp): New Lisp function created from
918 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
919 (Fword_search_backward, Fword_search_forward)
920 (Fword_search_backward_lax, Fword_search_forward_lax):
921 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
922 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
924 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
926 * fileio.c (Finsert_file_contents): Move after-change-function call
927 to before the "handled:" label, since all "goto handled" appear in
928 cases where the *-change-functions have already been properly called
931 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
933 * keyboard.c (interrupt_signal): Don't call kill-emacs when
934 waiting for input. (Bug#10169)
936 2011-11-30 Eli Zaretskii <eliz@gnu.org>
938 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
939 verifies glyph row's hash code--we have just reallocated the
940 glyphs, so their contents can be complete garbage. (Bug#10164)
942 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
944 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
946 2011-11-30 Eli Zaretskii <eliz@gnu.org>
948 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
949 attributes are tested _before_ calling verify_row_hash, to protect
950 against GCC re-ordering of the tests. (Bug#10164)
952 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
954 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
956 * xterm.c (handle_one_xevent): Only set async_visible and friends
957 if net_wm_state_hidden_seen is non-zero (Bug#10002)
958 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
959 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
961 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
963 Remove GCPRO-related macros that exist only to avoid shadowing locals.
964 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
965 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
966 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
967 All uses changed to use GCPRO1 etc.
968 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
969 Revert to old implementation (i.e., before 2011-03-11).
971 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
973 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
974 of scroll runs so as to avoid assigning disabled bogus rows and
975 unnecessary graphics copy operations.
977 2011-11-27 Eli Zaretskii <eliz@gnu.org>
979 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
980 (snprintf) [_MSC_VER]: Redirect to _snprintf.
981 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
982 (malloc, free, realloc, calloc): Redirect to e_* only when
985 * lisp.h (GCTYPEBITS): Move before first use.
986 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
987 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
988 this macro definition.
990 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
993 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
995 * gtkutil.c (xg_create_frame_widgets):
996 Call gtk_window_set_has_resize_grip (FALSE) if that function is
997 present with Gtk+ 2.0.
999 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1001 * fileio.c (Finsert_file_contents): Undo previous change; see
1002 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1004 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1006 Rename locals to avoid shadowing.
1007 * fileio.c (Finsert_file_contents):
1008 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1009 * process.c (wait_reading_process_output):
1010 Rename inner 'proc' to 'p' to avoid shadowing.
1011 Indent for consistency with usual Emacs style.
1013 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1015 * xdisp.c (redisplay_window): If cursor row is not fully visible
1016 after recentering, and scroll-conservatively is set to a large
1017 number, scroll window by a few more lines to make the cursor fully
1018 visible and out of scroll-margin. (Bug#10105)
1019 (start_display): Don't move to the next line if the display should
1020 start at a newline that is part of a display vector or an overlay
1023 2011-11-24 Juri Linkov <juri@jurta.org>
1025 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1026 after the `MagickPingImage' call. (Bug#10112)
1028 2011-11-23 Chong Yidong <cyd@gnu.org>
1030 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1032 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1034 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1035 making another buffer current. (Bug#10114)
1037 2011-11-23 Glenn Morris <rgm@gnu.org>
1039 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1041 2011-11-23 Chong Yidong <cyd@gnu.org>
1043 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1044 using it (Bug#5984).
1046 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1048 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1049 and header-lines, as they don't have one computed for them.
1052 * .gdbinit (prow): Make displayed values more self-explaining.
1053 Add row's hash code.
1055 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1057 * process.c (wait_reading_process_output): Fix asynchrounous
1058 GnuTLS socket handling on some versions of the GnuTLS library.
1059 (wait_reading_process_output): Add comment and URL.
1061 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1063 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1065 2011-11-21 Chong Yidong <cyd@gnu.org>
1067 * window.c (Fnext_window, Fprevious_window): Doc fix.
1069 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1071 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1073 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1075 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1077 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1079 * window.c (Fset_window_combination_limit): Rename argument
1081 (Vwindow_combination_limit): Remove "status" from doc-string.
1083 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1085 * m/ibms390.h: Remove.
1086 * m/ibms390x.h: Don't include "ibms390.h".
1088 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1090 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1091 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1093 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1095 * casetab.c (Fset_case_table):
1096 * charset.c (Fcharset_after): Fix typos.
1098 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1100 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1101 Otherwise, valgrind does not work on some platforms.
1102 Problem reported by Andreas Schwab in
1103 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1104 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1105 is set, removing the need for VIRT_ADDRESS_VARIES.
1106 (PURE_P): Use a more-efficient implementation that needs just one
1107 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1108 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1109 to 4 (xorl, subq, cmpq, setbe).
1110 * alloc.c (pure): Always extern now, since that's the
1111 VIRT_ADDR_VARIES behavior.
1112 (PURE_POINTER_P): Use a single comparison, not two, for
1113 consistency with the new puresize.h.
1114 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1115 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1116 Remove VIRT_ADDR_VARIES no longer needed.
1118 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1120 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1121 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1122 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1123 behave as if the cursor position were at the window margin.
1125 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1126 and the cursor position is out of bounds, behave as if the cursor
1127 position were at the window margin. (Bug#10075)
1129 2011-11-18 Chong Yidong <cyd@gnu.org>
1131 * window.c (Fwindow_combination_limit): Make first argument
1132 non-optional, since it is meaningless for live windows like the
1135 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1137 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1139 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1141 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1142 (graft_intervals_into_buffer): Simplify.
1144 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1146 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1147 hash values of the two rows.
1148 (copy_row_except_pointers): Preserve the used[] arrays and the
1149 hash values of the two rows. (Bug#10035)
1150 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1152 * xdisp.c (row_hash): New function, body extracted from
1153 compute_line_metrics.
1154 (compute_line_metrics): Call row_hash, instead of computing the
1157 * dispnew.c (verify_row_hash): Call row_hash for computing the
1158 hash code of a row, instead of duplicating code from xdisp.c.
1160 * dispextern.h (row_hash): Add prototype.
1162 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1164 * frame.c (delete_frame): Don't delete the terminal when the last
1165 X frame is closed if emacs is built with GTK toolkit.
1167 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1169 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1171 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1173 * window.c (Vwindow_splits): Rename to
1174 Vwindow_combination_resize. Suggested by Juri Linkov.
1175 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1178 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1180 * nsfns.m (Fns_font_name):
1181 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1183 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1185 * window.h (window): Rename slot "nest" to "combination_limit".
1186 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1187 (Fset_window_nest): Rename to Fset_window_combination_limit.
1188 (Vwindow_nest): Rename to Vwindow_combination_limit.
1189 (recombine_windows, make_parent_window, make_window)
1190 (Fsplit_window_internal, saved_window)
1191 (Fset_window_configuration, save_window_save): Rename all
1192 occurrences of window_nest to window_combination_limit.
1194 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1196 * image.c (imagemagick_load_image): Fix typo.
1198 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1200 * xdisp.c (display_line): Move the call to
1201 highlight_trailing_whitespace before the call to
1202 compute_line_metrics, since the latter needs to see the final
1203 faces of all the glyphs to compute ROW's hash value.
1204 Fixes assertion violations in row_equal_p. (Bug#10035)
1206 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1208 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1209 just return (bug#10044).
1211 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1213 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1214 with user-defined heap size. Bump the default size of the temacs
1215 heap to 27MB, to avoid memory warning when running temacs.
1216 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1218 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1219 current_matrix and desired_matrix. (Bug#9990)
1220 (verify_row_hash) [XASSERTS]: New function.
1221 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1222 that the hash value of glyph rows is correct.
1224 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1226 * window.h (window): Remove splits slot.
1227 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1228 (Fdelete_other_windows_internal, make_parent_window)
1229 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1230 (Fset_window_configuration, save_window_save): Don't deal with
1231 split status of windows.
1232 (saved_window): Remove splits slot.
1233 (Vwindow_splits): Rewrite doc-string.
1235 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1237 * xfns.c (unwind_create_frame):
1238 * nsfns.m (unwind_create_frame):
1239 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1240 Vframe_list (Bug#9999).
1242 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1244 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1246 2011-11-11 Kenichi Handa <handa@m17n.org>
1248 * callproc.c (Fcall_process): Set the member dst_multibyte of
1251 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1253 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1254 avoid a crash (bug#9496).
1256 2011-11-09 Chong Yidong <cyd@gnu.org>
1258 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1259 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1261 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1263 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1265 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1267 Avoid some portability problems by eschewing 'extern inline' functions.
1268 The trivial performance wins aren't worth the portability hassles; see
1269 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1271 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1272 (window_box_width, window_box_left, window_box_left_offset)
1273 (window_box_right, window_box_right_offset): Undo previous change,
1274 by removing the "extern"s.
1275 * intervals.c (adjust_intervals_for_insertion)
1276 (adjust_intervals_for_deletion): Undo previous change,
1277 making these static again.
1278 (offset_intervals, temp_set_point_both, temp_set_point)
1279 (copy_intervals_to_string): No longer inline.
1280 * xdisp.c (window_text_bottom_y, window_box_width)
1281 (window_box_height, window_box_left_offset)
1282 (window_box_right_offset, window_box_left, window_box_right)
1283 (window_box): No longer inline.
1285 2011-11-08 Chong Yidong <cyd@gnu.org>
1287 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1288 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1289 Signal an error if not a live window.
1290 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1291 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1293 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1295 * lisp.h (syms_of_abbrev): Remove declaration.
1296 Reported by CHENG Gao <chenggao@royau.me>.
1298 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1300 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1301 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1302 of temacs in GUI mode.
1304 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1306 * window.h: Declare delete_all_child_windows instead of
1307 delete_all_subwindows.
1308 * window.c (Fwindow_nest, Fset_window_nest)
1309 (Fset_window_new_total, Fset_window_new_normal)
1310 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1311 (delete_all_subwindows): Rename to delete_all_child_windows.
1312 (Fdelete_other_windows_internal, Fset_window_configuration):
1313 Call delete_all_child_windows instead of delete_all_subwindows.
1314 * frame.c (delete_frame): Call delete_all_child_windows instead
1315 of delete_all_subwindows.
1317 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1319 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1320 This is also needed for porting to any host where GC_MARK_STACK is
1321 not GC_MAKE_GCPROS_NOOPS.
1322 (which_symbols): Use it.
1324 2011-11-07 Kenichi Handa <handa@m17n.org>
1326 * coding.c (coding_set_destination): Check coding->src_pos only
1327 when coding->src_object is a buffer (bug#9910).
1329 * process.c (send_process): Set the member src_multibyte of coding
1330 to 0 (bug#9911) when sending a unibyte text.
1332 * callproc.c (Fcall_process): Set the member src_multibyte of
1333 process_coding to 0 (bug#9912).
1335 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1337 * xmenu.c (cleanup_widget_value_tree): New function.
1338 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1339 calling free_menubar_widget_value_tree directly (Bug#9830).
1341 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1343 Fix some portability problems with 'inline'.
1344 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1345 (window_box_width, window_box_left, window_box_left_offset)
1346 (window_box_right, window_box_right_offset): Declare extern.
1347 Otherwise, these inline functions do not conform to C99 and
1348 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1349 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1350 * intervals.c (adjust_intervals_for_insertion)
1351 (adjust_intervals_for_deletion): Now extern, because otherwise the
1352 extern inline functions 'offset_intervals' couldn't refer to it.
1353 (static_offset_intervals): Remove.
1354 (offset_intervals): Rewrite using the old contents of
1355 static_offset_intervals. The old version didn't conform to C99
1356 because an extern inline function contained a reference to an
1357 identifier with static linkage.
1359 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1361 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1364 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1366 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1367 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1368 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1369 return Qleft_to_right.
1371 2011-11-06 Chong Yidong <cyd@gnu.org>
1373 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1374 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1375 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1376 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1377 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1378 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1379 (Fwindow_vscroll): Doc fix.
1380 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1381 argument, since it makes no sense to pass a live window and for
1382 consistency with window-child.
1384 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1386 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1389 2011-11-05 Jason Rumney <jasonr@gnu.org>
1391 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1392 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1394 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1395 bitwise arithmetic preventing use of unicode-sip and non-truetype
1398 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1400 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1403 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1404 initialization code to keep similarity to xfns.c after changes
1407 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1409 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1410 (unwind_create_frame): New function (Bug#9943).
1411 (Fx_create_frame): Restructure code to be more similar to the one in
1412 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1413 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1414 Move terminal->reference_count++ just before making the frame official
1417 * nsterm.m (x_free_frame_resources): New function.
1418 (x_destroy_window): Move code to x_free_frame_resources.
1420 * xfns.c (unwind_create_frame): Fix comment.
1421 (Fx_create_frame, x_create_tip_frame):
1422 Move terminal->reference_count++ just before making the frame
1423 official. Move initialization of image_cache_refcount and
1424 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1426 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1428 Support MSVC build with newer versions of Visual Studio.
1429 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1430 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1433 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1434 which are not supported by MSVC.
1435 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1436 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1438 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1440 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1442 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1444 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1446 Support MSVC build with newer versions of Visual Studio.
1447 * w32.c: Don't include w32api.h for MSVC.
1448 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1450 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1451 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1452 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1453 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1455 (alloca) [_MSC_VER]: Define to _alloca.
1457 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1459 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1461 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1463 * xdisp.c (note_mouse_highlight): If either of
1464 previous/next-single-property-change returns nil, treat that as
1465 the beginning or the end of the buffer. (Bug#9955)
1467 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1469 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1470 label is not null (Bug#9951).
1471 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1474 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1476 * window.c (Fwindow_body_size): Mention in the doc string that the
1477 return value is in frame's canonical units. (Bug#9949)
1479 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1481 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1483 * w32fns.c (unwind_create_frame): If needed, free the glyph
1484 matrices of the partially constructed frame. (Bug#9943)
1485 * xfns.c (unwind_create_frame): Likewise.
1487 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1489 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1490 Don't stop backward scan on the continuation glyph, even though
1491 its CHARPOS is positive.
1492 (mouse_face_from_buffer_pos, note_mouse_highlight):
1493 Rename cover_string to disp_string.
1495 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1497 * window.c (temp_output_buffer_show): Don't use
1498 Vtemp_buffer_show_specifiers.
1499 (Vtemp_buffer_show_specifiers): Remove unused variable.
1501 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1503 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1504 past the beginning of the current glyph matrix.
1506 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1508 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1509 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1510 HAVE_GTK3 (Bug#9869).
1512 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1513 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1515 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1517 * xterm.c: Declare x_handle_net_wm_state to return int.
1518 (handle_one_xevent): Check if we are iconified but don't have
1519 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1520 (get_current_wm_state): Return non-zero if not hidden,
1521 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1522 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1523 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1524 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1526 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1528 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1529 so that this new function doesn't get optimized away by a
1530 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1532 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1534 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1536 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1538 Fix the `xbytecode' command.
1539 * .gdbinit (xprintbytestr): New command.
1540 (xwhichsymbols): Rename from `which'; all callers changed.
1541 (xbytecode): Print the byte-code string as well.
1543 2011-10-29 Kim Storm <storm@cua.dk>
1545 * alloc.c (which_symbols): New function.
1547 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1549 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1552 2011-10-29 Glenn Morris <rgm@gnu.org>
1554 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1555 Not clear what it was for, and it causes various bugs. (Bug#9839)
1557 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1559 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1560 possible random value that matches one of those tested as
1561 condition to clear the mouse face.
1563 2011-10-28 Chong Yidong <cyd@gnu.org>
1565 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1567 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1569 * window.c (make_window): Initialize phys_cursor_on_p.
1571 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * lisp.h (struct Lisp_Symbol): Update comments.
1575 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1577 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1579 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1581 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1582 <oslsachem@gmail.com> for helping to debug this.
1584 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1585 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1586 (g_b_init_get_glyph_outline_w): New static variables.
1587 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1588 (GetGlyphOutlineW_Proc): New typedefs.
1589 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1590 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1592 (w32font_open_internal, compute_metrics):
1593 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1594 instead of calling the "wide" APIs directly.
1596 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1598 * w32.h (syms_of_w32font): Add prototype.
1600 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1602 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1603 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1604 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1605 (Fmove_to_window_line): Doc fix.
1607 2011-10-27 Chong Yidong <cyd@gnu.org>
1609 * process.c (make_process): Set gnutls_state to NULL.
1611 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1612 non-NULL, regardless of GNUTLS_INITSTAGE.
1613 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1614 an error. Set process slots as soon as we allocate them.
1616 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1618 2011-10-27 Chong Yidong <cyd@gnu.org>
1620 * gnutls.c (emacs_gnutls_deinit): New function.
1621 Deallocate credentials structures as well as calling gnutls_deinit.
1622 (Fgnutls_deinit, Fgnutls_boot): Use it.
1624 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1625 (deactivate_process): Call emacs_gnutls_deinit.
1627 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1629 * image.c (x_create_x_image_and_pixmap):
1630 * w32.c (sys_rename, w32_delayed_load):
1631 * w32font.c (fill_in_logfont):
1632 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1634 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1636 * w32fns.c (w32_default_color_map): New function,
1637 extracted from Fw32_default_color_map.
1638 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1640 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1642 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1644 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1646 * keyboard.c (test_undefined): New function (bug#9751).
1647 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1649 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1651 * sysdep.c (init_sys_modes): Fix the check for the controlling
1652 terminal (Bug#6649).
1654 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1656 * dispextern.h (struct bidi_it): New member next_en_type.
1658 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1659 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1660 current character, check also for next_en_type being WEAK_EN.
1661 (bidi_resolve_weak): Don't enter the expensive loop if the current
1662 position is before next_en_pos. Record the bidi type of the first
1663 non-ET, non-BN character we find, in addition to its position.
1664 (bidi_level_of_next_char): Invalidate next_en_type when
1665 next_en_pos is over-stepped.
1667 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1669 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1670 * editfns.c: Rewrite current-time-zone so that it invokes
1671 the equivalent of (format-time-string "%Z") to get the time zone name.
1672 This fixes a bug when the time zone name contains characters that
1673 need converting from the system time locale to Emacs internal format.
1674 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1675 that patch fixed format-time-string to do the conversion, but
1676 I forgot to fix current-time-zone.
1677 (format_time_string): New function, containing most of
1678 what Fformat_time_string used to contain.
1679 (Fformat_time_string): Rewrite in terms of format_time_string.
1680 This doesn't change this function's behavior.
1681 (current-time-zone): Rewrite to use format_time_string.
1682 This fixes the bug reported by Michael Schierl in
1683 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1684 Jason Rumney's 2007-06-07 change worked around this bug, but
1686 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1688 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1690 * xdisp.c (start_display): If the character at POS is displayed
1691 via a display vector, reset IT->current.dpvec_index to zero.
1692 (try_window_reusing_current_matrix): If a line ends in a display
1693 vector or the next line starts in a display vector, continue
1694 redrawing the window even though the character position of
1695 start_row was reached.
1698 2011-10-18 Chong Yidong <cyd@gnu.org>
1700 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1701 with nobreak-char-display too.
1703 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1705 Fix part 3 of bug#9771.
1706 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1707 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1708 non-neutral characters if the current character is a paragraph
1709 separator (a.k.a. Newline). This avoids running the same
1710 expensive loop twice, once when we consume the preceding newline
1711 and the other time when the line actually needs to be displayed.
1712 Avoid the loop when we see neutrals on the base embedding level
1713 following a character whose directionality is the same as the
1714 paragraph's. This avoids running the expensive loop when a line
1715 ends in a long sequence of neutrals, like control characters.
1716 Add assertion against STRONG_AL type. Slightly rearrange code
1717 that determines the type of a neutral given the first non-neutral
1719 (bidi_level_of_next_char): Set next_en_pos to zero when
1720 invalidating its info.
1722 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1724 * xdisp.c (push_display_prop): Determine whether to record string
1725 or buffer position by IT->string, not by IT->method. Allow
1726 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1727 (move_it_vertically_backward): Don't look for character position
1728 immediately after the newline when in a continuation line.
1731 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1733 * window.c (coordinates_in_window): Rewrite and delabelize
1734 vertical border check. (Bug#5357) (Bug#9618)
1736 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1738 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1739 errors in XSetWindowBorder (bug#9310).
1741 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1743 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1744 avoid crash when xmalloc overrun checking is enabled.
1746 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1748 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1749 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1750 cursor motion with <left> and <right> arrow keys.
1752 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1753 some callers set that themselves.
1755 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1757 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1758 display string and the previous row comes from the same string and
1759 is empty. (Bug#9739) (Bug#9738)
1761 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1763 * doc.c (get_doc_string): Encode file name (bug#9735).
1765 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1767 * bidi.c (bidi_level_of_next_char):
1768 * xdisp.c (get_visually_first_element): Remove old incorrect
1769 comments regarding the Unicode Line Separator character.
1771 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1773 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1775 * alloc.c (Fgc_status): Do not access beyond zombies array
1776 boundary if nzombies > MAX_ZOMBIES.
1777 * alloc.c (dump_zombies): Add missing format specifier.
1779 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1781 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1782 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1784 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1785 Some packages use them to denote characters with modifiers.
1787 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1789 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1790 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1791 matching a pp-number. Rename parameter var to var1.
1793 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1795 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1797 2011-10-08 Glenn Morris <rgm@gnu.org>
1799 * callint.c (Fcall_interactively): Give a more explicit error for the
1800 'c' case with a non-character input. (Bug#8479)
1802 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1804 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1806 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1807 lines that are hscrolled on the left.
1809 * dispnew.c (buffer_posn_from_coords): Account for a possible
1810 presence of header-line. (Bug#4426)
1812 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1814 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1815 Don't advertise functionality which we discourage or doesn't work.
1817 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1819 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1820 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1821 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1822 this makes Emacs dump core during garbage collection on rare
1823 occasions. sizeof is obviously inferior to offsetof here, so
1824 stick with offsetof.
1825 (GC_POINTER_ALIGNMENT): New macro.
1826 (mark_memory): Omit 3rd (offset) arg; caller changed.
1827 Don't assume EMACS_INT alignment is the same as pointer alignment.
1829 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1831 * keyboard.c (read_key_sequence_remapped): New var.
1832 (read_key_sequence): Compute remapping in the right buffer.
1833 (command_loop_1): Use read_key_sequence's remapping directly.
1835 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1837 * dired.c (file_name_completion): Don't expand file name.
1838 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1839 before checking file name handler.
1841 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1842 they've been requested explicitly (bug#9591).
1844 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1846 * keymap.c (Fsingle_key_description): Use make_specified_string
1847 instead of build_string to build string from push_key_description.
1850 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1852 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1853 This fixes a Y2038 bug on 64-bit hosts.
1854 * buffer.c (reset_buffer):
1855 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1856 (Fclear_buffer_auto_save_failure):
1857 Use 0, not -1, to represent an unset failure time, since time_t
1858 might not be signed.
1860 Remove dependency on glibc malloc internals.
1861 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1862 Move back here from lisp.h, but with their new implementations.
1863 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1864 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1865 * charset.c (charset_table_init): New static var.
1866 (syms_of_charset): Use it instead of xmalloc. This removes a
1867 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1868 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1869 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1870 Move back to alloc.c.
1871 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1872 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1874 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1876 * nsterm.m (windowDidResize): Call x_set_window_size only when
1877 ns_in_resize is true. Otherwise set pixelwidth/height and
1878 call change_frame_size (Bug#9628).
1880 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1882 Port --enable-checking=all to Fedora 14 x86-64.
1883 * charset.c (syms_of_charset): Also account for glibc malloc's
1884 internal overhead when calculating the initial malloc maximum.
1886 Port --enable-checking=all to Fedora 14 x86.
1887 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1889 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1890 (overrun_check_realloc, overrun_check_free):
1891 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1892 That way, xmalloc returns a properly-aligned pointer even if
1893 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1894 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1895 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1896 into account when calculating the initial malloc maximum.
1897 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1898 Move here from alloc.c, so that charset.c can use it too.
1899 Properly align; the old code wasn't right for common 32-bit hosts
1900 when configured with --enable-checking=all.
1901 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1902 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1904 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1906 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1909 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1911 * xdisp.c (compute_display_string_end): If there's no display
1912 string at CHARPOS, return -1.
1914 * bidi.c (bidi_fetch_char): When compute_display_string_end
1915 returns a negative value, treat the character as a normal
1916 character not covered by a display string. (Bug#9624)
1918 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1920 * lread.c (Fread_from_string): Fix typo in docstring.
1922 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1924 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1925 newline, reseat the iterator instead of bidi-iterating there one
1926 character at a time. (Bug#9610)
1927 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1928 TO_CHARPOS if the bidi iterator is at base embedding level.
1930 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1932 * lread.c (readevalloop): Use correct code for NBSP.
1933 (read1): Likewise. (Bug#9608)
1935 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1937 * dbusbind.c (Fdbus_register_signal): When service is not
1938 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1940 2011-09-25 Glenn Morris <rgm@gnu.org>
1942 * buffer.c (truncate-lines): Doc fix.
1944 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1946 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1947 (Fset_window_next_buffers): Doc fix.
1949 2011-09-24 Glenn Morris <rgm@gnu.org>
1951 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1953 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1955 Fix minor problems found by static checking.
1956 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1957 * indent.c (Fvertical_motion): Fix == vs = typo.
1959 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1961 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1962 Default value is now t. Doc fix.
1964 * indent.c (Fvertical_motion): Compute and apply the overshoot
1965 logic when moving up, not only when moving down. Fix the
1966 confusing name and values of the it_overshoot_expected variable;
1967 logic changes accordingly. (Bug#9254) (Bug#9549)
1969 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1970 CHARPOS is covered by a display string which includes newlines.
1971 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1972 is covered by a display string with embedded newlines.
1974 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1976 * dbusbind.c (Fdbus_register_signal): Add match rule to
1977 Vdbus_registered_objects_table. (Bug#9581)
1978 (Fdbus_register_method, Vdbus_registered_objects_table):
1981 2011-09-24 Jim Meyering <meyering@redhat.com>
1983 do not ignore write error for any output size
1984 The previous change was incomplete.
1985 While it makes emacs --batch detect the vast majority of stdout
1986 write failures, errors were still ignored whenever the output size is
1987 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1988 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1989 && echo FAIL: ignored write error
1990 FAIL: ignored write error
1991 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1992 && echo FAIL: ignored write error
1993 FAIL: ignored write error
1994 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1996 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1998 * emacs.c (Fkill_emacs): In noninteractive mode exit
1999 non-successfully if a write error occurred on stdout. (Bug#9574)
2001 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2003 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2006 * dispextern.h (struct it): Update the comment documenting what
2009 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2012 a display string, extend search for cursor position to end of row.
2013 (find_row_edges): If the row ends in a newline from a display
2014 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2015 Handle the case of a display string with multiple newlines.
2016 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2017 non-empty line. Fixes confusing cursor motion with arrow keys at
2018 the beginning of a line that starts with whitespace.
2020 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2022 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2025 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2027 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2030 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2032 * xdisp.c (display_line): Record maximum and minimum buffer
2033 positions even if no glyphs were produced (e.g., by a zero-width
2034 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2035 buffer positions that will be removed from the glyph row because
2037 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2038 column is beyond frame width: don't subtract 1 "pixel" when
2039 computing width of the stretch.
2040 (reseat_at_next_visible_line_start): Undo the change made on
2041 2011-09-17 that saved paragraph information and restored it after
2042 the call to `reseat'. (Bug#9545)
2044 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2046 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2047 and turn window cursor on if cleared (Bug#9415).
2049 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2051 * search.c (boyer_moore): Take unibyte characters from pattern
2052 literally. (Bug#9458)
2054 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2056 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2058 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2060 Fix minor problem found by static checking.
2061 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2062 initialized, to pacify gcc -Wuninitialized.
2064 * fileio.c: Report proper errno when syscall falls.
2065 (Finsert_file_contents): Save and restore errno,
2066 so that report_file_error outputs the correct diagnostic.
2067 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2069 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2071 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2073 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2076 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2078 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2080 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2081 about the current paragraph and restore it after the call to reseat.
2083 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2084 (bidi_find_paragraph_start): Search back for paragraph beginning
2085 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2086 (bidi_move_to_visually_next): Only trigger paragraph-related
2087 computations when the last character is a newline or at EOB, not
2088 just any NEUTRAL_B. (Bug#9470)
2090 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2091 truncated lines if point is covered by a display string. (Bug#9524)
2093 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2095 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2096 (cons_to_x_long): New function.
2097 (lisp_data_to_selection_data): Use it. Correct the test for
2098 short-versus-long data; it was negated. Break out of vector
2099 loop, for efficiency, when a long datum is discovered.
2101 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2103 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2105 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2107 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2108 GCC PR/17406) by declaring this function with external scope.
2110 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2112 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2113 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2115 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2117 * editfns.c (Fformat): Correctly handle text properties on "%%".
2119 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2121 * xterm.c (x_draw_composite_glyph_string_foreground):
2122 * w32term.c (x_draw_composite_glyph_string_foreground):
2123 * term.c (encode_terminal_code):
2124 * composite.c (composition_update_it, get_composition_id):
2125 * xdisp.c (get_next_display_element)
2126 (fill_composite_glyph_string): Add comments about special meaning
2127 of TAB characters in a composition.
2129 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2131 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2132 This occurs when processing a multibyte format.
2133 Problem reported by Wolfgang Jenker.
2135 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2137 * xdisp.c (try_cursor_movement): Only check for exact match if
2138 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2140 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2142 Remove unused external symbols.
2143 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2144 * xdisp.c (calc_pixel_width_or_height): Now static.
2145 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2146 * indent.c (check_display_width):
2147 * w32term.c: Fix comment to match code.
2148 * xterm.c, xterm.h (x_catching_errors): Remove.
2150 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2152 * xselect.c: Use signed conversions more consistently (Bug#9498).
2153 (selection_data_to_lisp_data): Assume incoming selection data are
2154 signed integers, not unsigned. This is to be consistent with
2155 outgoing selection data, which was modified to use signed integers
2156 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2157 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2158 expects long, not unsigned long.
2160 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2162 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2163 computation of loop end. Reported by Johan Bockgård
2166 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2168 * frame.c (Fother_visible_frames_p): Function deleted.
2170 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2172 * indent.c (compute_motion): Process display vector front to back
2173 rather than the other way around. (Bug#2496)
2175 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2177 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2179 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2181 * minibuf.c (Fread_from_minibuffer): Doc fix.
2183 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2185 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2186 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2188 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2190 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2191 value for non-existent files.
2193 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2195 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2196 set its "size" to -1. This will set the modtime_size field of
2197 the corresponding buffer to -1, which is what
2198 verify-visited-file-modtime expects for files that do not exist.
2201 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2203 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2205 * lisp.h: ... from here. push_key_description is no longer
2206 defined in keyboard.c, so its declaration should not be in
2207 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2208 logically belongs with push_key_description.
2210 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2212 * buffer.h: Include <sys/types.h> instead of <time.h>.
2213 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2214 Problem reported by Herbert J. Skuhra.
2216 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2218 * xml.c (parse_region): Make the parsing work for
2219 non-comment-starting XML files again (bug#9144).
2221 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2223 * image.c (gif_load): Fix calculation of bottom and right corner.
2226 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2228 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2229 redisplay in small windows.
2231 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2233 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2235 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2237 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2238 Operate on live windows only.
2240 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2242 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2244 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2246 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2247 only under bidi iteration.
2249 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2251 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2253 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2255 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2256 Without this fix, the command to link temacs failed due to an
2257 undefined symbol __builtin_isnan. This is because
2258 /usr/include/iso/math_c99.h #defines isnan(x) to
2259 __builtin_isnan(x), but the bundled gcc, which identifies itself
2260 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2262 * floatfns.c (isnan): #undef, and then #define to a clone of
2264 (Fisnan): Always define, since it's always available now.
2265 (syms_of_floatfns): Always define isnan at the Lisp level.
2267 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2269 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2271 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2273 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2274 The previous code assumed that file offsets (off_t values) fit in
2275 EMACS_INT variables, which is not true on typical 32-bit hosts.
2276 The code messed up by falsely reporting buffer overflow in cases
2277 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2278 when "big" contains more than 2**29 bytes, even though this
2279 inserts just one byte and does not overflow the buffer.
2280 (Finsert_file_contents): Store file offsets as off_t
2281 values, not as EMACS_INT values. Check for overflow when
2282 converting between EMACS_INT and off_t. When checking for
2283 buffer overflow or for overlap, take the offsets into account.
2284 Don't use EMACS_INT for small values where int suffices.
2285 When checking for overlap, fix a typo: ZV was used where
2286 ZV_BYTE was intended.
2287 (Fwrite_region): Don't assume off_t fits into 'long'.
2288 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2290 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2292 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2294 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2296 sprintf-related integer and memory overflow issues (Bug#9412).
2298 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2299 (esprintf, exprintf, evxprintf): New functions.
2300 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2301 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2302 (modify_event_symbol): Do not assume that the length of
2303 name_alist_or_stem is safe to alloca and fits in int.
2304 (Fexecute_extended_command): Likewise for function name and binding.
2305 (Frecursion_depth): Wrap around reliably on integer overflow.
2306 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2307 since some callers pass EMACS_INT values.
2308 (Fsingle_key_description): Don't crash if symbol name contains more
2309 than MAX_ALLOCA bytes.
2310 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2311 (get_minibuffer): Arg is now EMACS_INT, not int.
2312 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2313 (esprintf, exprintf, evxprintf): New decls.
2314 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2316 * dbusbind.c (signature_cat): New function.
2317 (xd_signature, Fdbus_register_signal):
2318 Do not overrun buffer; instead, report string overflow.
2320 * dispnew.c (add_window_display_history): Don't overrun buffer.
2321 Truncate instead; this is OK since it's just a log.
2323 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2324 even if the time zone offset is outlandishly large.
2325 Don't mishandle offset == INT_MIN.
2327 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2328 when creating daemon; the previous buffer-overflow check was incorrect.
2330 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2331 which has the guts of the old verror function.
2333 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2334 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2336 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2337 (font_unparse_xlfd): Don't blindly alloca long strings.
2338 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2339 fits in int, when using sprintf. Use single snprintf to count
2340 length of string rather than counting it via multiple sprintfs;
2341 that's simpler and more reliable.
2342 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2343 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2344 sprintf, in case result does not fit in int.
2346 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2347 (fontset_from_font): Print it.
2349 * frame.c (tty_frame_count): Now printmax_t, not int.
2350 (make_terminal_frame, set_term_frame_name): Print it.
2351 (x_report_frame_params): In X, window IDs are unsigned long,
2352 not signed long, so print them as unsigned.
2353 (validate_x_resource_name): Check for implausibly long names,
2354 and don't assume name length fits in 'int'.
2355 (x_get_resource_string): Don't blindly alloca invocation name;
2356 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2359 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2360 (xg_check_special_colors, xg_set_geometry):
2361 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2363 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2364 Use esprintf, not sprintf, in case result does not fit in int.
2366 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2367 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2368 it as a large positive number.
2369 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2370 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2372 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2373 in case result does not fit in int.
2375 * print.c (float_to_string): Detect width overflow more reliably.
2376 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2377 buffer overrun. Don't assume list length fits in 'int'. Treat
2378 print length of 0 as 0, not as infinity; to be consistent with other
2379 uses of print length in this function. Don't overflow print length
2380 index. Don't assume hash table size fits in 'long', or that
2381 vectorlike size fits in 'unsigned long'.
2383 * process.c (make_process): Use printmax_t, not int, to format
2384 process-name gensyms.
2386 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2388 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2389 to avoid potential buffer overrun.
2391 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2392 if X resource line is longer than 512 bytes.
2394 * xfns.c (x_window): Make sprintf buffer a bit bigger
2395 to avoid potential buffer overrun.
2397 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2399 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2401 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2403 Integer overflow fixes for scrolling, etc.
2404 Without these, Emacs silently mishandles large integers sometimes.
2405 For example, "C-u 4294967297 M-x recenter" was treated as if
2406 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2408 * xdisp.c (try_window_id): Check Emacs fixnum range before
2409 converting to 'int'.
2411 * window.c (window_scroll_line_based, Frecenter):
2412 Check that an Emacs fixnum is in range before assigning it to 'int'.
2413 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2414 values converted from Emacs fixnums.
2415 (Frecenter): Don't wrap around a line count if it is out of 'int'
2416 range; instead, treat it as an extreme value.
2417 (Fset_window_configuration, compare_window_configurations):
2418 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2420 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2421 that can exceed INT_MAX. Check that EMACS_INT value is in range
2422 before assigning it to the (possibly-narrower) index.
2423 (match_limit): Don't assume that a fixnum can fit in 'int'.
2425 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2428 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2429 (Fvertical_motion): Don't wrap around LINES values that don't fit
2430 in 'int'. Instead, treat them as extreme values. This is good
2431 enough for windows, which can't have more than INT_MAX lines anyway.
2433 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2435 * Require libxml/parser.h to avoid compilation warning.
2437 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2439 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2440 since this reportedly can destroy thread storage.
2442 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2444 * syntax.c (find_defun_start): Update all cache variables if
2445 exiting early (Bug#9401).
2447 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2449 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2451 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2452 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2453 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2455 * term.c (tty_append_glyph): New function.
2456 (produce_stretch_glyph): Static function and its prototype deleted.
2458 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2461 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2463 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2464 when checking :margin (Bug#9390).
2465 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2466 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2467 so that the name doesn't mislead. All uses changed.
2469 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2471 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2474 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2476 * xdisp.c (move_it_to): Don't bail out early when reaching
2477 position beyond to_charpos, if we are scanning backwards.
2478 (move_it_vertically_backward): When DY == 0, make sure we get to
2479 the first character in the line after the newline.
2481 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2483 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2484 (ccl_driver): Do not generate an out-of-range pointer.
2485 (Fccl_execute_on_string): Remove unnecessary check for
2486 integer overflow, noted by Stefan Monnier in
2487 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2488 Remove a FIXME that didn't need fixing.
2489 Simplify the newly-introduced buffer reallocation code.
2491 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2493 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2495 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2497 Integer and memory overflow issues (Bug#9196).
2499 * doc.c (get_doc_string): Rework so that
2500 get_doc_string_buffer_size is the actual buffer size, rather than
2501 being 1 less than the actual buffer size; this makes xpalloc more
2504 * image.c (x_allocate_bitmap_record, cache_image):
2505 * xselect.c (Fx_register_dnd_atom):
2506 Simplify previous changes by using xpalloc.
2508 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2509 since either will do and ptrdiff_t is convenient with xpalloc.
2511 * charset.c (charset_table_size)
2512 (struct charset_sort_data.priority): Now ptrdiff_t.
2513 (charset_compare): Don't overflow if priorities differ greatly.
2514 (Fsort_charsets): Don't assume list length fits in int.
2515 Check for size-calculation overflow when allocating sort data.
2516 (syms_of_charset): Allocate an initial charset table that is
2517 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2519 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2521 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2522 The actual value is always <= INT_MAX, and leaving it unsigned made
2523 overflow checking harder.
2525 * dispextern.h (struct glyph_matrix.rows_allocated)
2526 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2527 with xpalloc. The values are still always <= INT_MAX.
2529 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2531 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2532 (SAFE_NALLOCA): New macro.
2534 * region-cache.c (struct boundary.pos, find_cache_boundary)
2535 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2536 (set_cache_region, invalidate_region_cache)
2537 (revalidate_region_cache, know_region_cache, region_cache_forward)
2538 (region_cache_backward, pp_cache):
2539 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2540 so that ptrdiff_t * can be passed to xpalloc.
2541 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2542 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2543 (pp_cache): Don't assume cache_len fits in int.
2544 * region-cache.h: Adjust extern decls to match.
2546 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2547 EMACS_INT, since either will do, for xpalloc.
2549 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2550 (xnmalloc, xnrealloc, xpalloc): New functions.
2552 * bidi.c (bidi_shelve_header_size): New constant.
2553 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2554 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2556 * bidi.c (bidi_cache_shrink):
2557 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2559 Don't update size of array until after memory allocation succeeds,
2560 because xmalloc/xrealloc may not return.
2561 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2562 now that we have proper integer overflow checking.
2563 (record_overlay_string, overlay_strings): Catch overflows when
2564 calculating size of overlay_str_buf.
2566 * callproc.c (Fcall_process): Check for size overflow when
2567 calculating size of args2.
2568 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2569 Normally we prefer signed values, but sticking with ptrdiff_t would
2570 require adding more-complicated checks.
2572 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2573 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2574 Redo buffer-overflow calculations to avoid integer overflow.
2575 Add a FIXME comment where memory seems to be over-allocated.
2577 * character.c (Fstring): Check for size-calculation overflow.
2579 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2580 unnecessary integer overflow. Check for size overflow.
2581 (encode_coding_object): Don't update size until xmalloc succeeds.
2583 * composite.c (get_composition_id): Check for overflow in glyph
2584 length calculations.
2586 Integer and memory overflow fixes for display code.
2587 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2588 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2589 (scrolling_window): Check for overflow in size calculations.
2590 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2591 Don't assume glyph table len fits in int.
2592 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2593 (row_table_size): Now ptrdiff_t, not int.
2594 (scrolling_window): Avoid overflow in size calculations.
2595 Don't update size until allocation succeeds.
2596 * fns.c (concat): Check for overflow in size calculations.
2597 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2598 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2599 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2601 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2602 (get_doc_string): Check for size calculation overflow.
2603 Don't update size until allocation succeeds.
2604 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2605 EMACS_INT, where ptrdiff_t will do.
2606 (Fsubstitute_command_keys): Check for string overflow.
2608 * editfns.c (set_time_zone_rule): Don't assume environment length
2610 (message_length): Now ptrdiff_t, not int.
2611 (Fmessage_box): Don't update size until allocation succeeds.
2612 Don't assume message length fits in int.
2613 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2615 * emacs.c (main): Do not reallocate argv, since there is a null at
2616 the end that can be overwritten, and this way there's no need to
2617 worry about size-calculation overflow.
2618 (sort_args): Check for size-calculation overflow.
2620 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2622 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2624 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2625 (x_set_scroll_bar_width, x_figure_window_size):
2626 Check for integer overflow.
2627 (x_set_alpha): Do not assume XINT fits in int.
2629 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2630 This is for the members text_lines, text_cols, total_lines, total_cols,
2631 where the system imposes an 'int' limit.
2633 * fringe.c (Fdefine_fringe_bitmap):
2634 Don't update size until alloc works.
2636 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2637 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2639 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2640 Check for size-calculation overflow.
2641 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2642 do, as we prefer signed integers.
2643 (id_to_widget.max_size, id_to_widget.used)
2644 (xg_store_widget_in_map, xg_remove_widget_from_map)
2645 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2646 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2647 Use and return ptrdiff_t, not int.
2648 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2649 * gtkutil.h: Change prototypes to match the above.
2651 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2652 are duplicate now that they've been promoted to lisp.h.
2653 (x_allocate_bitmap_record, x_alloc_image_color)
2654 (make_image_cache, cache_image, xpm_load):
2655 Don't update size until alloc is done.
2656 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2658 Check for size calculation overflow.
2659 (ct_colors_allocated_max): New constant.
2660 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2663 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2664 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2665 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2666 Use ptrdiff_t, not int, to count maps.
2667 (read_char_minibuf_menu_prompt): Check for overflow in size
2668 calculations. Don't update size until allocation succeeds.
2669 Redo calculations to avoid overflow.
2670 * keyboard.h: Change prototypes to match the above.
2672 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2674 (current_minor_maps): Check for size calculation overflow.
2675 * keymap.h: Change prototypes to match the above.
2677 * lread.c (read1, init_obarray): Don't update size until alloc done.
2679 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2680 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2682 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2683 Now ptrdiff_t, not int.
2684 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2685 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2687 * process.c (Fnetwork_interface_list): Check for overflow
2688 in size calculation.
2690 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2692 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2693 overflow. Don't bother calling xmalloc when xrealloc will do.
2695 * search.c (Freplace_match): Check for size calculation overflow.
2696 (Fset_match_data): Don't assume list lengths fit in 'int'.
2698 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2699 for command line length. Do not attempt to address one before the
2700 beginning of an array, as that's not portable.
2702 * term.c (max_frame_lines): Remove; unused.
2703 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2705 (encode_terminal_code, calculate_costs): Check for size
2706 calculation overflow.
2707 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2708 table lengths and related sizes. Don't update size until alloc
2709 done. Redo calculations to avoid overflow.
2710 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2712 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2713 subtracting pointers.
2714 (gobble_line): Check for overflow more carefully. Don't update size
2717 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2718 Don't update size until alloc done.
2719 Redo size calculations to avoid overflow.
2720 Check for size calculation overflow.
2721 (main) [DEBUG]: Fix typo in invoking tparam1.
2723 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2724 Use ptrdiff_t, not int, for sizes.
2725 (store_mode_line_noprop_char): Don't update size until alloc done.
2727 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2728 Use ptrdiff_t, not int, for sizes.
2729 (Finternal_make_lisp_face, cache_face):
2730 Check for size calculation overflow.
2731 (cache_face): Treat size calculation overflows as if they were
2732 memory exhaustion (the usual treatment), rather than aborting.
2734 * xfns.c (x_encode_text, x_set_name_internal)
2735 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2736 sizes, since they can exceed INT_MAX in size. Check for size
2737 calculation overflow.
2739 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2740 (xg_select): Check for size calculation overflow.
2741 Don't update size until alloc done.
2743 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2744 as sprintf is limited to int lengths.
2746 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2747 (X_LONG_MIN): New macros.
2748 Use them to make the following changes clearer.
2749 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2750 This change doesn't affect the value now, but it may help remind
2751 future maintainers not to raise the value too much later.
2752 (SELECTION_QUANTUM): Remove, replacing with ...
2753 (selection_quantum): ... new function, which avoids overflow.
2755 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2756 assumption that selection length fits in 'int'.
2757 (x_reply_selection_request, x_handle_selection_request)
2758 (x_get_window_property, receive_incremental_selection)
2759 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2760 (lisp_data_to_selection_data, clean_local_selection_data):
2761 Use ptrdiff_t, not int, to record length of selection.
2762 (x_reply_selection_request, x_get_window_property)
2763 (receive_incremental_selection, x_property_data_to_lisp):
2764 Redo calculations to avoid overflow.
2765 (x_reply_selection_request): When sending hint, ceiling it at
2766 X_LONG_MAX rather than relying on wraparound overflow to send
2768 (x_get_window_property, receive_incremental_selection)
2769 (lisp_data_to_selection_data, x_property_data_to_lisp):
2770 Check for size-calculation overflow.
2771 (x_get_window_property, receive_incremental_selection)
2772 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2773 Don't store size until memory allocation succeeds.
2774 (x_get_window_property): Plug memory leak on memory exhaustion.
2775 Don't double-block input; malloc is safe here. Don't assume 2**34
2776 - 4 fits in unsigned long. Add an xassert to check
2777 XGetWindowProperty overflow. Be more careful about overflow
2778 calculations, and distinguish size from memory overflow better.
2779 (receive_incremental_selection): When tracing, don't assume
2780 unsigned int is less than INT_MAX.
2781 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2782 harmful) conversions of unsigned short to int.
2783 (lisp_data_to_selection_data): Don't assume that integers
2784 in the range -65535 through -1 fit in an X unsigned short.
2785 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2786 result parameters unless successful. Rely on cons_to_unsigned
2787 to report problems with elements; the old code wasn't right anyway.
2788 (x_check_property_data): Check for int overflow; we cannot use
2789 a wider type due to X limits.
2790 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2792 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2794 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2795 (x_term_init): Check for size calculation overflow.
2796 (x_color_cells): Don't store size until memory allocation succeeds.
2797 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2798 Don't assume alloca size is less than MAX_ALLOCA.
2799 (x_term_init): Don't assume length fits in int (sprintf is limited
2802 Use ptrdiff_t for composition IDs.
2803 * character.c (lisp_string_width):
2804 * composite.c (composition_table_size, n_compositions)
2805 (get_composition_id, composition_gstring_from_id):
2806 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2807 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2808 * window.c (Frecenter):
2809 Use ptrdiff_t, not int, for composition IDs.
2810 * composite.c (get_composition_id): Check for integer overflow.
2811 * composite.h: Adjust prototypes to match the above changes.
2813 Use ptrdiff_t for hash table indexes.
2814 * category.c (hash_get_category_set):
2815 * ccl.c (ccl_driver):
2816 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2817 * coding.c (coding_system_charset_list, detect_coding_system):
2818 * coding.h (struct coding_system.id):
2819 * composite.c (get_composition_id, gstring_lookup_cache):
2820 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2821 * image.c (xpm_get_color_table_h):
2822 * lisp.h (hash_lookup, hash_put):
2823 * minibuf.c (Ftest_completion):
2824 Use ptrdiff_t for hash table indexes, not int (which is too
2825 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2826 32-bit --with-wide-int hosts).
2828 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2829 Add a FIXME comment about memory leaks.
2830 (syms_of_charset): Don't assume xmalloc returns.
2832 Don't assume that stated character widths fit in int.
2833 * character.c (Fchar_width, c_string_width, lisp_string_width):
2834 * character.h (CHAR_WIDTH):
2835 * indent.c (MULTIBYTE_BYTES_WIDTH):
2836 Use sanitize_char_width to avoid undefined and/or bad behavior
2837 with outlandish widths.
2838 * character.h (sanitize_tab_width): Rename from sanitize_width,
2839 now that we have two such functions. All uses changed.
2840 (sanitize_char_width): New inline function.
2842 Don't assume that tab-width fits in int.
2843 * character.h (sanitize_width): New inline function.
2844 (SANE_TAB_WIDTH): New macro.
2845 (ASCII_CHAR_WIDTH): Use it.
2846 * indent.c (sane_tab_width): Remove. All uses replaced by
2847 SANE_TAB_WIDTH (current_buffer).
2848 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2850 * fileio.c: Integer overflow issues with file modes.
2851 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2853 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2854 Remove unreachable code.
2855 (read_hex, load_charset_map_from_file): Check for integer overflow.
2857 * xterm.c: Don't go over XClientMessageEvent limit.
2858 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2859 (x_send_scroll_bar_event): Likewise. Check that the size does not
2860 exceed limits imposed by XClientMessageEvent, as well as the usual
2861 ptrdiff_t and size_t limits.
2863 * keyboard.c: Overflow, signedness and related fixes.
2864 (make_lispy_movement): Use same integer type in forward decl
2865 that is used in the definition.
2866 (read_key_sequence, keyremap_step):
2867 Change bufsize argument back to int, undoing my 2011-03-30 change.
2868 We prefer signed types, and int is wide enough here.
2869 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2870 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2871 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2872 length, not size_t. Use ptrdiff_t for index, not int.
2873 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2874 possibility of integer overflow.
2876 Overflow, signedness and related fixes for images.
2878 * dispextern.h (struct it.stack[0].u.image.image_id)
2879 (struct_it.image_id, struct image.id, struct image_cache.size)
2880 (struct image_cache.used, struct image_cache.ref_count):
2881 * gtkutil.c (update_frame_tool_bar):
2882 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2883 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2884 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2885 * nsmenu.m (update_frame_tool_bar):
2886 * xdisp.c (calc_pixel_width_or_height):
2887 * xfns.c (image_cache_refcount):
2888 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2889 on typical 64-bit hosts.
2891 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2892 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2893 Omit unnecessary casts to int.
2894 (parse_image_spec): Check that integers fall into 'int' range
2895 when the callers expect that.
2896 (image_ascent): Redo ascent calculation to avoid int overflow.
2897 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2898 (lookup_image): Remove unnecessary tests.
2899 (xbm_image_p): Locals are now of int, not EMACS_INT,
2900 since parse_image_check makes sure they fit into int.
2901 (png_load, gif_load, svg_load_image):
2902 Prefer int to unsigned where either will do.
2903 (tiff_handler): New function, combining the cores of the
2904 old tiff_error_handler and tiff_warning_handler.
2905 This function is rewritten to use vsnprintf and thereby avoid
2906 stack buffer overflows. It uses only the features of vsnprintf
2907 that are common to both POSIX and native Microsoft.
2908 (tiff_error_handler, tiff_warning_handler): Use it.
2909 (tiff_load, gif_load, imagemagick_load_image):
2910 Don't assume :index value fits in 'int'.
2911 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2912 (imagemagick_load_image): Check that crop parameters fit into
2913 the integer types that MagickCropImage accepts. Don't assume
2914 Vimagemagick_render_type has a nonnegative value. Don't assume
2915 size_t fits in 'long'.
2916 (gs_load): Use printmax_t to print the widest integers possible.
2917 Check for integer overflow when computing image height and width.
2919 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2921 * xdisp.c (redisplay_window): Don't force window start if point
2922 will be invisible in the resulting window. (Bug#9324)
2924 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2926 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2927 the display spec is of the form `(space ...)'.
2928 (handle_display_spec): Return the value returned by
2929 handle_single_display_spec, not just 1 or zero.
2930 (handle_single_display_spec): If the display spec is of the form
2931 `(space ...)', and specifies display in the text area, return 2
2933 (try_cursor_movement): Check for the need to scroll more
2934 accurately, and prefer exact match for point under bidi.
2935 Don't advance `row' beyond the last row of the window.
2937 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2938 into disp_prop; all users changed.
2940 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2941 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2942 for the text covered by the display property.
2944 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2946 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2947 Change return value to nil.
2948 (Frecord_buffer): Delete unused function.
2950 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2952 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2953 buffers, return left-to-right.
2954 (set_cursor_from_row): Consider candidate row a win if its glyph
2955 represents a newline and point is on that newline. Fixes cursor
2956 positioning on the newline at EOL of R2L text within L2R
2957 paragraph, and vice versa.
2958 (try_cursor_movement): Check continued rows, in addition to
2959 continuation rows. Fixes unwarranted scroll when point enters a
2960 continued line of R2L text within an L2R paragraph, or vice versa.
2961 (cursor_row_p): Consider the case of point being equal to
2962 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2963 from the end of a short line to the beginning of a continued line
2964 of R2L text within L2R paragraph.
2965 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2966 composed characters.
2968 * bidi.c (bidi_check_type): Use xassert.
2969 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2972 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2974 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2977 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2979 * nsfont.m (ns_otf_to_script): Fix typo.
2981 2011-08-22 Kenichi Handa <handa@m17n.org>
2983 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2984 extra slot even if the purpose is char-code-property-table.
2986 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2988 * xdisp.c (redisplay_window): When computing centering_position,
2989 account for the height of the header line. (Bug#8874)
2991 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2992 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2993 candidate is selected by the mouse, and that candidate has a
2994 composed character under the mouse.
2996 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2997 coordinates reported by pos-visible-in-window-p for a composed
2998 character in column zero.
3000 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3002 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3004 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3006 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3007 consider it a hit if to_charpos is anywhere in the range of the
3008 composed buffer positions.
3010 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3012 * image.c (gif_load): Don't assume that each subimage has the same
3013 dimensions as the base image. Handle disposal method that is
3014 "undefined" by the gif spec (Bug#9335).
3016 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3018 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3019 (Fcondition_case): Document `debug' symbol in error handler.
3021 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3023 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3024 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3025 from an Org mode buffer to a Speedbar frame.
3027 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3028 a composition, take its buffer position from IT->cmp_it.charpos.
3029 Fixes cursor positioning at the beginning of a line that begins
3030 with a composed character.
3032 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3034 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3035 character bidirectional type, use STRONG_L instead. Fixes crashes
3036 in a buffer produced by `describe-categories'.
3038 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3039 members before the level stack, so they would be saved and
3040 restored when copying iterator state. Fixes incorrect reordering
3041 around TABs covered by display properties.
3043 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3045 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3047 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3049 * eval.c (internal_condition_case, internal_condition_case_1)
3050 (internal_condition_case_2, internal_condition_case_n):
3051 Remove unnecessary aborts (Bug#9081).
3053 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3055 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3056 has no `load' handler, try opening the file locally. (Bug#9311)
3058 2011-08-16 Ken Brown <kbrown@cornell.edu>
3060 * gmalloc.c: Expand comment.
3062 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3064 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3065 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3067 2011-08-16 Ken Brown <kbrown@cornell.edu>
3069 Fix memory allocation problems in Cygwin build (Bug#9273).
3071 * unexcw.c ( __malloc_initialized): Declare external variable.
3072 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3074 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3076 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3078 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3080 [CYGWIN] (special_realloc): New function.
3081 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3082 requests to realloc storage in the static heap.
3084 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3086 * bidi.c (bidi_initialize): Remove unused local.
3088 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3091 * biditype.h: Remove file.
3092 * makefile.w32-in ($(BLD)/bidi.$(O)):
3093 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3095 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3097 * chartab.c: Improve commentary for the uniprop_table API.
3099 * bidi.c (bidi_paragraph_init): Support zero value of
3100 bidi_ignore_explicit_marks_for_paragraph_level.
3101 (bidi_initialize): Use uniprop_table instead of including
3102 biditype.h and bidimirror.h.
3104 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3105 coordinates of the iterator when restoring from ppos_it.
3108 2011-08-14 Kenichi Handa <handa@m17n.org>
3110 * process.c (create_process): Call setup_process_coding_systems
3111 after the pid of the process is set to -1 (Bug#8162).
3113 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3115 * xdisp.c (move_it_in_display_line_to): Don't invoke
3116 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3117 ppos_it. Fixes vertical cursor motion when line beginning is
3118 covered by an image. (Bug#9296)
3120 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3122 * nsterm.h (ns_run_ascript): Declare.
3123 (NSAPP_DATA2_RUNASSCRIPT): Define.
3125 * nsfns.m (as_script, as_result, as_status): New static variables.
3126 (ns_run_ascript): New function.
3127 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3128 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3129 the event loop. Get status from as_status (Bug#7276).
3131 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3132 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3133 the event loop (Bug#7276).
3135 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3137 * gnutls.c (QCgnutls_bootprop_priority)
3138 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3139 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3140 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3141 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3142 (QCgnutls_bootprop_verify_hostname_error)
3143 (QCgnutls_bootprop_callbacks_verify): Rename from
3144 Qgnutls_bootprop_..., all uses changed.
3146 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3149 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3151 * xfaces.c (Qframe_set_background_mode): Now static.
3152 * dispextern.h (Qframe_set_background_mode): Remove decl.
3154 * process.c (Fnetwork_interface_info): Declare local only if needed.
3156 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3158 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3159 (Fnetwork_interface_list): Allocate in increments of bytes instead
3160 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3161 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3163 (struct ifflag_def): notrailers is smart on OSX.
3164 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3165 Get hardware address with getifaddrs if available.
3167 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3169 * xdisp.c (iterate_out_of_display_property): xassert that
3170 IT->position is set to within IT->object's boundaries. Break from
3171 the loop as soon as EOB is reached; avoids infloops in redisplay
3172 when IT->position is set up wrongly due to some bug.
3173 Set IT->current to match the bidi iterator unconditionally.
3174 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3175 entry. Force push_it to save on the stack the current
3176 buffer/string position, to be restored by pop_it. Fix flags in
3177 the iterator structure wrt the object coming from a display
3178 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3179 properties. (Bug#9284)
3181 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3183 * fontset.c (fontset_get_font_group): Add proper type checks.
3186 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3188 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3189 and LC_VERSION_MIN_MACOSX.
3190 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3191 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3193 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3195 * xdisp.c (forward_to_next_line_start): Allow to use the
3196 no-display-properties-and-no-overlays under bidi display.
3197 Set disp_pos in the bidi iterator to avoid searches for display
3198 properties and overlays.
3200 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3202 * editfns.c (Fset_time_zone_rule): Document relationship with the
3205 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3206 the font entity extracted from the cache (Bug#8109).
3208 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3210 * composite.c (autocmp_chars): Don't reset point. That is done by
3211 restore_point_unwind (Bug#5984).
3213 2011-08-07 Juri Linkov <juri@jurta.org>
3215 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3216 to show the arg `TIME' instead of `TIMEVAL'.
3218 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3220 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3221 display property strides EOL and includes a newline, as in
3222 longlines-mode. (Bug#9254)
3223 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3224 word-wrap under bidirectional display. (Bug#9224)
3226 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3227 is non-zero, even if the data buffer is NULL. Fixes a crash in
3228 vertical-motion with longlines-mode. (Bug#9254)
3230 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3232 * bidi.c <bidi_cache_total_alloc>: Now static.
3233 (bidi_initialize): Initialize bidi_cache_total_alloc.
3235 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3238 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3239 amount allocated this far in `bidi_cache_total_alloc'.
3240 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3241 non-zero, only free the data buffer without restoring the cache
3242 contents. All callers changed.
3244 * dispextern.h (bidi_unshelve_cache): Update prototype.
3246 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3247 (move_it_in_display_line, move_it_to)
3248 (move_it_vertically_backward, move_it_by_lines): Replace the call
3249 to xfree to an equivalent call to bidi_unshelve_cache.
3250 (move_it_in_display_line_to): Fix logic of returning
3251 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3253 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3255 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3256 came from a string character with a `cursor' property. (Bug#9229)
3258 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3260 * Makefile.in (LIB_PTHREAD): New variable.
3261 (LIBES): Add LIB_PTHREAD (Bug#9216).
3263 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3264 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3266 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3268 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3270 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3272 * xterm.c (x_find_topmost_parent): New function.
3273 (x_set_frame_alpha): Find topmost parent window with
3274 x_find_topmost_parent and set the property there also (bug#9181).
3275 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3277 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3279 * callproc.c (Fcall_process): Avoid vfork clobbering
3280 the local vars buffer, coding_systems, current_dir.
3282 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3284 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3286 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3288 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3289 so that it is not optimized away.
3291 * xdisp.c (compute_display_string_pos): Remove unused local.
3293 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3295 Fix slow cursor motion and scrolling in large buffers with
3296 selective display, like Org Mode buffers. (Bug#9218)
3298 * dispextern.h (struct bidi_it): New member disp_prop_p.
3300 * xdisp.c: Remove one-slot cache of display string positions.
3301 (compute_display_string_pos): Accept an additional argument
3302 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3303 for a display string or property. If found, set DISP_PROP_P
3306 * bidi.c (bidi_fetch_char): Accept an additional argument
3307 DISP_PROP_P, and pass it to compute_display_string_pos.
3308 Only handle text covered by a display string if DISP_PROP_P is returned
3309 non-zero. All callers of bidi_fetch_char changed.
3311 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3313 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3315 2010-12-03 Don March <don@ohspite.net>
3317 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3318 last character M-[char] is translated to ESC [char] (bug#7541).
3320 2011-08-02 Kenichi Handa <handa@m17n.org>
3322 * lisp.h (uniprop_table): Extern it.
3324 * chartab.c (uniprop_table): Make it non-static.
3326 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3328 * xdisp.c (forward_to_next_line_start): Accept additional argument
3329 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3331 (reseat_at_next_visible_line_start): Use the bidi iterator state
3332 returned by forward_to_next_line_start to restore the state of
3333 it->bidi_it after backing up to previous newline. (Bug#9212)
3335 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3337 * regex.c (re_comp): Protoize.
3338 (re_exec): Fix return type.
3339 (regexec): Fix type of `ret'. (Bug#9203)
3341 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3343 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3344 This is needed if max-image-size is a floating-point number.
3346 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3348 * print.c (print_object): Print empty symbol as ##.
3350 * lread.c (read1): Read ## as empty symbol.
3352 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3354 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3355 setting frame foreground color (Bug#9175).
3356 (x_set_background_color): Likewise.
3358 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3359 contents (Bug#9176).
3360 (EmacsTooltip -init): Remove bezels and add shadows to
3363 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3364 or scroll bar (Bug#8470).
3366 * nsfont.m (nsfont_open): Remove assignment to voffset and
3367 unnecessary vars hshink, expand, hd, full_height, min_height.
3368 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3370 * nsterm.h (nsfont_info): Remove voffset field.
3372 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3374 Implement strike-through and overline on NextStep (Bug#8863).
3376 * nsfont.m (nsfont_open): Use underline position provided by font,
3377 instead of hard-coded value of 2.
3378 (nsfont_draw): Call ns_draw_text_decoration instead.
3380 * nsterm.h: Add declaration for ns_draw_text_decoration.
3382 * nsterm.m (ns_draw_text_decoration): New function for drawing
3383 underline, overline, and strike-through.
3384 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3385 ns_draw_text_decoration. Change treatment of cursor drawing to
3386 accommodate underlining, etc.
3388 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3390 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3393 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3395 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3396 Without this fix, if a signal arrives just after memory fills up,
3397 'malloc' might be invoked reentrantly.
3399 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3400 In other words, assume that every image size is allowed, on non-X
3401 hosts. This assumption is probably wrong, but it lets Emacs compile.
3403 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3405 * regex.c (re_iswctype): Convert return values to boolean.
3407 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3409 * xdisp.c (compute_display_string_pos): Don't use cached display
3410 string position if the buffer had its restriction changed.
3413 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3415 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3417 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3419 Integer signedness and overflow and related fixes. (Bug#9079)
3421 * bidi.c: Integer size and overflow fixes.
3422 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3423 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3424 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3425 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3426 (bidi_find_other_level_edge):
3427 Use ptrdiff_t instead of EMACS_INT where either will do.
3428 This works better on 32-bit hosts configured --with-wide-int.
3429 (bidi_cache_ensure_space): Check for size-calculation overflow.
3430 Use % rather than repeated addition, for better worst-case speed.
3431 Don't set bidi_cache_size until after xrealloc returns, because it
3433 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3434 (bidi_cache_ensure_space): Also check that the bidi cache size
3435 does not exceed that of the largest Lisp string or buffer. See Eli
3436 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3438 * alloc.c (__malloc_size_t): Remove.
3439 All uses replaced by size_t. See Andreas Schwab's note
3440 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3442 * image.c: Improve checking for integer overflow.
3443 (check_image_size): Assume that f is nonnull, since
3444 it is always nonnull in practice. This is one less thing to
3445 worry about when checking for integer overflow later.
3446 (x_check_image_size): New function, which checks for integer
3447 overflow issues inside X.
3448 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3449 This removes the need for a memory_full check.
3450 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3451 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3452 (xbm_read_bitmap_data): Change locals back to 'int', since
3453 their values must fit in 'int'.
3454 (xpm_load_image, png_load, tiff_load):
3455 Invoke x_create_x_image_and_pixmap earlier,
3456 to avoid much needless work if the image is too large.
3457 (tiff_load): Treat overly large images as if
3458 x_create_x_image_and_pixmap failed, not as malloc failures.
3459 (gs_load): Use x_check_image_size.
3461 * gtkutil.c: Omit integer casts.
3462 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3463 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3465 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3467 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3468 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3469 would wrongly return t on a 64-bit host.
3471 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3472 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3473 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3474 and therefore cause GCC to emit a bogus diagnostic in some cases.
3476 * image.c: Integer signedness and overflow and related fixes.
3477 This is not an exhaustive set of fixes, but it's time to
3478 record what I've got.
3479 (lookup_pixel_color, check_image_size): Remove redundant decls.
3480 (check_image_size): Don't assume that arbitrary EMACS_INT values
3481 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3482 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3483 (tiff_load, imagemagick_load_image):
3484 Check for overflow in size calculations.
3485 (x_create_x_image_and_pixmap): Remove unnecessary test for
3486 xmalloc returning NULL; that can't happen.
3487 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3488 (xpm_color_bucket): Use better integer hashing function.
3489 (xpm_cache_color): Don't possibly over-allocate memory.
3490 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3491 (gif_memory_source):
3492 Use ptrdiff_t, not int or size_t, to record sizes.
3493 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3494 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3495 either works, as we prefer signed integers.
3496 (tiff_read_from_memory, tiff_write_from_memory):
3497 Return tsize_t, not size_t, since that's what the TIFF API wants.
3498 (tiff_read_from_memory): Don't fail simply because the read would
3499 go past EOF; instead, return a short read.
3500 (tiff_load): Omit no-longer-needed casts.
3501 (Fimagemagick_types): Don't assume size fits into 'int'.
3503 Improve hashing quality when configured --with-wide-int.
3504 * fns.c (hash_string): New function, taken from sxhash_string.
3505 Do not discard information about ASCII character case; this
3506 discarding is no longer needed.
3507 (sxhash-string): Use it. Change sig to match it. Caller changed.
3508 * lisp.h: Declare it.
3509 * lread.c (hash_string): Remove, since we now use fns.c's version.
3510 The fns.c version returns a wider integer if --with-wide-int is
3511 specified, so this should help the quality of the hashing a bit.
3513 * emacs.c: Integer overflow minor fix.
3514 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3515 Define only if GNU_LINUX.
3516 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3518 * dispnew.c: Integer signedness and overflow fixes.
3519 Remove unnecessary forward decls, that were a maintenance hassle.
3520 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3522 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3523 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3524 (prepare_desired_row, line_draw_cost):
3525 Use int, not unsigned, where either works.
3526 (save_current_matrix, restore_current_matrix):
3527 Use ptrdiff_t, not size_t, where either works.
3528 (init_display): Check for overflow more accurately, and without
3529 relying on undefined behavior.
3531 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3532 Remove, replacing with the new symbols in lisp.h. All uses changed.
3533 * fileio.c (make_temp_name):
3534 * filelock.c (lock_file_1, lock_file):
3535 * xdisp.c (message_dolog):
3536 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3537 Use pMd etc. instead.
3538 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3539 replacing the pWIDE etc. symbols removed from editfns.c.
3541 * keyboard.h (num_input_events): Now uintmax_t.
3542 This is (very slightly) less likely to mess up due to wraparound.
3545 * buffer.c: Integer signedness fixes.
3546 (alloc_buffer_text, enlarge_buffer_text):
3547 Use ptrdiff_t rather than size_t when either will do, as we prefer
3550 * alloc.c: Integer signedness and overflow fixes.
3551 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3552 (__malloc_size_t): Default to size_t, not to int.
3553 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3554 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3555 Prefer ptrdiff_t to size_t when either would do, as we prefer
3557 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3558 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3559 Now const. Initialize with values that are in range even if char
3561 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3562 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3563 These functions do the right thing with sizes > 2**32.
3564 (check_depth): Now ptrdiff_t, not int.
3565 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3566 Adjust to new way of storing sizes. Check for size overflow bugs
3568 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3569 slightly wrong anyway, as it missed one instance of
3570 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3571 (refill_memory_reserve): Omit needless cast to size_t.
3572 (mark_object_loop_halt): Mark as externally visible.
3574 * xselect.c: Integer signedness and overflow fixes.
3575 (Fx_register_dnd_atom, x_handle_dnd_message):
3576 Use ptrdiff_t, not size_t, since we prefer signed.
3577 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3578 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3579 x_dnd_atoms_size and x_dnd_atoms_length.
3581 * doprnt.c: Prefer signed to unsigned when either works.
3583 * doprnt.c (doprnt):
3585 * xdisp.c (vmessage):
3586 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3587 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3588 prefer signed arithmetic to avoid comparison confusion.
3589 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3590 but is a bit tricky.
3592 Assume freestanding C89 headers, string.h, stdlib.h.
3593 * data.c, doprnt.c, floatfns.c, print.c:
3594 Include float.h unconditionally.
3595 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3596 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3597 * regex.c: Likewise for stddef.h, string.h.
3598 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3599 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3600 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3601 (STDC_HEADERS): Remove obsolete defines.
3602 * sysdep.c: Include limits.h unconditionally.
3604 Assume support for memcmp, memcpy, memmove, memset.
3605 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3606 * regex.c (memcmp, memcpy):
3607 Remove; we assume C89 now.
3609 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3610 (__malloc_safe_bcopy): Remove; no longer needed.
3612 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3613 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3614 well either way, and we prefer signed to unsigned.
3616 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3618 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3619 closes the connection while we're reading (bug#9182).
3621 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3623 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3624 are specified (Bug#9168).
3626 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3628 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3629 Found by GCC static checking and --with-wide-int on a 32-bit host.
3631 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (compute_display_string_pos): Fix logic of caching
3634 previous display string position. Initialize cached_prev_pos to
3635 -1. Fixes slow-down at the beginning of a buffer.
3637 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3639 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3640 for attrs[LFACE_FONTSET_INDEX].
3642 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3644 * xml.c (parse_region): Remove unused local
3645 that was recently introduced.
3647 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3649 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3650 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3652 * xdisp.c (move_it_in_display_line_to): Record the best matching
3653 position for TO_CHARPOS while scanning the line, and restore it on
3654 exit if none of the characters scanned was an exact match.
3655 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3656 when exact match is impossible due to invisible text, and the
3657 lines are truncated.
3659 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3661 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3664 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3666 Fix a significant slow-down of cursor motion with C-n, C-p,
3667 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3668 auto-repeat under bidi redisplay in fontified buffers.
3669 * xdisp.c (compute_stop_pos_backwards): New function.
3670 (next_element_from_buffer): Call compute_stop_pos_backwards to
3671 find a suitable prev_stop when we find ourselves before
3673 (reseat): Don't look for prev_stop, as that could mean a very long
3675 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3676 <cached_disp_overlay_modiff>: Cache for last found display string
3678 (compute_display_string_pos): Return the cached position if asked
3679 about the same buffer in the same area of character positions, and
3680 the buffer wasn't changed since the time the display string
3681 position was cached.
3683 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3685 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3686 is an integer, which is important for empty lines. (Bug#9149)
3688 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3690 * frame.c (Fmodify_frame_parameters): In tty case, update the
3691 default face if necessary (Bug#4238).
3693 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3695 * editfns.c (Fstring_to_char): No need to explain what a character
3696 is in the docstring (Bug#6576).
3698 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3700 * xml.c (parse_region): Make sure we always return a tree.
3702 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3704 * xml.c (parse_region): If a document contains only comments,
3707 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3709 * xml.c (make_dom): Return comments, too.
3711 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3714 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3715 and the surrounding thread.
3716 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3717 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3718 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3720 * s/openbsd.h (BROKEN_SIGIO): Define.
3721 * unexelf.c (unexec) [__OpenBSD__]:
3722 Don't update the .mdebug section of the Alpha COFF symbol table.
3724 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3726 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3729 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3731 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3732 This fixes some race conditions on the permissions of any newly
3735 * alloc.c (valid_pointer_p): Use pipe, not open.
3736 This fixes some permissions issues when debugging.
3738 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3739 If fchown fails to set both uid and gid, try to set just gid,
3740 as that is sometimes allowed. Adjust the file's mode to eliminate
3741 setuid or setgid bits that are inappropriate if fchown fails.
3743 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3745 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3746 to compare Lisp_Objects.
3747 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3748 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3749 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3751 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3753 * lread.c (read_integer): Unread even EOF character.
3754 (read1): Likewise. Properly record start position of symbol.
3756 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3757 symbol character follows.
3759 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3761 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3762 This works around a problem with the previous change to Fcopy_file.
3763 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3764 and without this change, GCC might complain about discarding
3765 fchown's return value.
3767 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3769 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3771 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3773 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3775 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3777 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3778 it's used from the C level.
3780 * process.c: Use the same condition for POLL_FOR_INPUT in both
3781 keyboard.c and process.c (bug#1858).
3783 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3785 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3786 (Fgnutls_boot): Use it.
3788 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3790 * doc.c (Fsubstitute_command_keys): Revert last change.
3792 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3795 quotes the next character, and doesn't affect other longer
3796 sequences (bug#8935).
3798 * lread.c (syms_of_lread): Clarify that is isn't only
3799 `eval-buffer' and `eval-defun' that's affected by
3800 `lexical-binding' (bug#8460).
3802 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3804 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3805 bidi redisplay when a line includes both an image and is truncated.
3807 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3809 Fix minor problems found by static checking.
3810 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3811 (elsz): Now a signed constant, not a size_t var. We prefer signed
3812 types to unsigned, to avoid integer comparison confusion. Without
3813 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3814 "cannot optimize loop, the loop counter may overflow", a symptom
3816 * indent.c (Fvertical_motion): Mark locals as initialized.
3817 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3819 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3821 * search.c (Fre_search_backward): Mention `case-fold-search' in
3822 all the re_search_* functions (bug#8138).
3824 * keyboard.c (Fopen_dribble_file): Document when the file is
3827 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3829 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3832 Support bidi reordering of display and overlay strings.
3833 * xdisp.c (compute_display_string_pos)
3834 (compute_display_string_end): Accept additional argument STRING.
3835 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3836 (reseat_to_string): Initialize bidi_it->string.s and
3837 bidi_it->string.schars.
3838 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3839 NULL (avoids a crash in bidi_paragraph_init).
3840 Initialize itb.string.lstring.
3841 (init_iterator): Call bidi_init_it only of a valid
3842 buffer position was specified. Initialize paragraph_embedding to
3844 (reseat_to_string): Initialize the bidi iterator.
3845 (display_string): If we need to ignore text properties of
3846 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3847 original value of -1 will not work with bidi.)
3848 (compute_display_string_pos): First arg is now struct
3849 `text_pos *'; all callers changed. Support display properties on
3851 (compute_display_string_end): Support display properties on Lisp
3853 (init_iterator, reseat_1, reseat_to_string): Initialize the
3854 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3855 when iterating on a string not from display properties).
3856 (compute_display_string_pos, compute_display_string_end):
3857 Fix calculation of the object to scan. Fixes an error when using
3859 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3860 base_level_stop; instead, set base_level_stop to BEGV.
3861 Fixes crashes in vertical-motion.
3862 (next_element_from_buffer): Improve commentary for when
3863 the iterator is before prev_stop.
3864 (init_iterator): Initialize bidi_p from the default value of
3865 bidi-display-reordering, not from buffer-local value. Use the
3866 buffer-local value only if initializing for buffer iteration.
3867 (handle_invisible_prop): Support invisible properties on strings
3868 that are being bidi-reordered.
3869 (set_iterator_to_next): Support bidi reordering of C strings and
3871 (next_element_from_string): Support bidi reordering of Lisp
3873 (handle_stop_backwards): Support Lisp strings as well.
3874 (display_string): Support display of R2L glyph rows.
3875 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3876 (init_iterator): Don't initialize it->bidi_p for strings
3878 (reseat_to_string): Initialize it->bidi_p for strings here.
3879 (next_element_from_string, next_element_from_c_string)
3880 (next_element_from_buffer): Add xassert's for correspondence
3881 between IT's object being iterated and it->bidi_it.string
3883 (face_before_or_after_it_pos): Support bidi iteration.
3884 (next_element_from_c_string): Handle the case of the first string
3885 character that is not the first one in the visual order.
3886 (get_visually_first_element): New function, refactored from common
3887 parts of next_element_from_buffer, next_element_from_string, and
3888 next_element_from_c_string.
3889 (tool_bar_lines_needed, redisplay_tool_bar)
3890 (display_menu_bar): Force left-to-right direction. Add a FIXME
3891 comment for making that be controlled by a user option.
3892 (push_it, pop_it): Save and restore the state of the
3893 bidi iterator. Save and restore the bidi_p flag.
3894 (pop_it): Iterate out of display property for string iteration as
3896 (iterate_out_of_display_property): Support iteration over strings.
3897 (handle_single_display_spec): Set up it->bidi_it for iteration
3898 over a display string, and call bidi_init_it.
3899 (handle_single_display_spec, next_overlay_string)
3900 (get_overlay_strings_1, push_display_prop): Set up the bidi
3901 iterator for displaying display or overlay strings.
3902 (forward_to_next_line_start): Don't use the shortcut if
3904 (back_to_previous_visible_line_start): If handle_display_prop
3905 pushed the iterator stack, restore the internal state of the bidi
3906 iterator by calling bidi_pop_it same number of times.
3907 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3908 and we are bidi-iterating, don't decrement the iterator position;
3909 instead, set the first_elt flag in the bidi iterator, to produce
3911 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3912 (push_display_prop): xassert that we are iterating a buffer.
3913 (push_it, pop_it): Save and restore paragraph_embedding member.
3914 (handle_single_display_spec, next_overlay_string)
3915 (get_overlay_strings_1, reseat_1, reseat_to_string)
3916 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3917 correctly. Don't assume unibyte strings are not bidi-reordered.
3918 (compute_display_string_pos)
3919 (compute_display_string_end): Fix handling the case of C string.
3920 (push_it, pop_it): Save and restore from_disp_prop_p.
3921 (handle_single_display_spec, push_display_prop): Set the
3922 from_disp_prop_p flag.
3923 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3924 (pop_it): Call iterate_out_of_display_property only if we are
3925 popping after iteration over a string that came from a display
3926 property. Fix a typo in popping stretch info. Add an assertion
3927 for verifying that the iterator position is in sync with the bidi
3929 (handle_single_display_spec, get_overlay_strings_1)
3930 (push_display_prop): Fix initialization of paragraph direction for
3931 string when that of the parent object is not yet determined.
3932 (reseat_1): Call bidi_init_it to resync the bidi
3933 iterator with IT's position. (Bug#7616)
3934 (find_row_edges): If ROW->start.pos gives position
3935 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3936 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3937 Reset the from_disp_prop_p flag.
3938 (SAVE_IT, RESTORE_IT): New macros.
3939 (pos_visible_p, face_before_or_after_it_pos)
3940 (back_to_previous_visible_line_start)
3941 (move_it_in_display_line_to, move_it_in_display_line)
3942 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3943 (try_scrolling, redisplay_window, display_line): Use them when
3944 saving a temporary copy of the iterator and restoring it back.
3945 (back_to_previous_visible_line_start, reseat_1)
3946 (init_iterator): Empty the bidi cache "stack".
3947 (move_it_in_display_line_to): If iterator ended up at
3948 EOL, but we never saw any buffer positions smaller than
3949 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3950 motion in bidi-reordered lines.
3951 (move_it_in_display_line_to): Record prev_method and prev_pos
3952 immediately before the call to set_iterator_to_next. Fixes cursor
3953 motion in bidi-reordered lines with stretch glyphs and strings
3954 displayed in margins. (Bug#8133) (Bug#8867)
3955 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3957 (pos_visible_p): Support positions in bidi-reordered lines.
3958 Save and restore bidi cache.
3960 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3961 (bidi_paragraph_info): Delete unused struct.
3962 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3963 (bidi_cache_start): New variable.
3964 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3966 (bidi_cache_fetch_state, bidi_cache_search)
3967 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3968 (bidi_cache_find, bidi_peek_at_next_level)
3969 (bidi_level_of_next_char, bidi_find_other_level_edge)
3970 (bidi_move_to_visually_next): Compare cache index with
3971 bidi_cache_start rather than with zero.
3972 (bidi_fetch_char): Accept new argument STRING; all callers
3973 changed. Support iteration over a string. Support strings with
3974 display properties. Support unibyte strings. Fix the type of
3975 `len' according to what STRING_CHAR_AND_LENGTH expects.
3976 (bidi_paragraph_init, bidi_resolve_explicit_1)
3977 (bidi_resolve_explicit, bidi_resolve_weak)
3978 (bidi_level_of_next_char, bidi_move_to_visually_next):
3979 Support iteration over a string.
3980 (bidi_set_sor_type, bidi_resolve_explicit_1)
3981 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3982 can now be zero (for strings); special values 0 and -1 were
3983 changed to -1 and -2, respectively.
3984 (bidi_char_at_pos): New function.
3985 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3986 Call it instead of FETCH_MULTIBYTE_CHAR.
3987 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3988 initialized to valid values.
3989 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3991 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3992 the test for valid cached positions. Fix the logic for looking up
3993 the sentinel state in the cache. GCPRO the Lisp string we are
3995 (bidi_push_it, bidi_pop_it): New functions.
3996 (bidi_initialize): Initialize the bidi cache start stack pointer.
3997 (bidi_cache_ensure_space): New function, refactored from part of
3998 bidi_cache_iterator_state. Don't assume the required size is just
3999 one BIDI_CACHE_CHUNK away.
4000 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4001 (bidi_count_bytes, bidi_char_at_pos): New functions.
4002 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4003 always valid if bidi_cache_idx is valid.
4004 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4005 is valid if it's going to be used.
4006 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4007 (bidi_cache_fetch_state, bidi_cache_search)
4008 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4009 (bidi_cache_iterator_state, bidi_cache_find)
4010 (bidi_find_other_level_edge, bidi_cache_start_stack):
4011 All variables related to cache indices are now EMACS_INT.
4013 * dispextern.h (struct bidi_string_data): New structure.
4014 (struct bidi_it): New member `string'. Make flag members be 1-bit
4015 fields, and put them last in the struct.
4016 (compute_display_string_pos, compute_display_string_end):
4018 (bidi_push_it, bidi_pop_it): Add prototypes.
4019 (struct iterator_stack_entry): New members bidi_p,
4020 paragraph_embedding, and from_disp_prop_p.
4021 (struct it): Member bidi_p is now a bit field 1 bit wide.
4022 (bidi_shelve_cache, bidi_unshelve_cache):
4025 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4026 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4027 and vector-like objects.
4029 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4030 cache around display iteration.
4032 * window.c (Fwindow_end, window_scroll_pixel_based)
4033 (displayed_window_lines, Frecenter): Save and restore the bidi
4034 cache around display iteration.
4036 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4038 * editfns.c (Fdelete_region): Clarify the use of the named
4039 parameters (bug#6788).
4041 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4043 * indent.c (Fvertical_motion): Set and restore w->pointm when
4044 saving and restoring the window's buffer (Bug#9006).
4046 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048 * editfns.c (Fstring_to_char): Clarify just what is returned
4049 (bug#6576). Text by Eli Zaretskii.
4051 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4053 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4055 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4057 * buffer.c (mmap_find): Fix a typo.
4059 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4061 Fix execution of x selection hooks.
4062 * xselect.c (Qx_lost_selection_functions)
4063 (Qx_sent_selection_functions): New vars.
4064 (syms_of_xselect): DEFSYM them.
4065 (x_handle_selection_request): Pass Qx_sent_selection_functions
4066 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4067 (x_handle_selection_clear,x_clear_frame_selections):
4068 Pass Qx_lost_selection_functions rather than
4069 Vx_lost_selection_functions to Frun_hook_with_args.
4071 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4073 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4074 The old code sometimes used this field without initializing it.
4076 * alloc.c (gc_sweep): Don't read past end of array.
4077 In theory, the old code could also have corrupted Emacs internals,
4078 though it'd be very unlikely.
4080 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4082 * character.c (Fcharacterp): Don't advertise optional ignored
4083 argument. (Bug#4026)
4085 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4087 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4090 * window.c (Fset_window_start): Doc fix (bug#4199).
4091 (Fset_window_hscroll): Ditto.
4093 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4095 Fix minor new problems caught by GCC 4.6.1.
4096 * term.c (init_tty): Remove unused local.
4097 * xsettings.c (store_monospaced_changed): Define this function only
4098 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4101 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4103 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4105 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4107 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4108 are the mini-buffer and the echo area (bug#3320).
4110 * term.c (init_tty): Remove support for supdup, c10 and perq
4111 terminals, which are no longer supported (bug#1482).
4113 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4115 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4117 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4119 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4120 for non-popups (Bug#3642).
4122 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4124 * alloc.c (reset_malloc_hooks): Protoize.
4125 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4126 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4127 * cm.c (losecursor): Likewise.
4128 * data.c (fmod): Likewise.
4129 * dispnew.c (swap_glyphs_in_rows): Likewise.
4130 * emacs.c (memory_warning_signal): Likewise.
4131 * floatfns.c (float_error): Likewise.
4132 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4133 (otf_open, font_otf_capability, generate_otf_features)
4134 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4136 * image.c (pbm_read_file): Likewise.
4137 * indent.c (string_display_width): Likewise.
4138 * intervals.c (check_for_interval, search_for_interval)
4139 (inc_interval_count, count_intervals, root_interval)
4140 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4141 * lread.c (defalias): Likewise.
4142 * ralloc.c (r_alloc_check): Likewise.
4143 * regex.c (set_image_of_range_1, set_image_of_range)
4144 (regex_grow_registers): Likewise.
4145 * sysdep.c (strerror): Likewise.
4146 * termcap.c (valid_filename_p, tprint, main): Likewise.
4147 * tparam.c (main): Likewise.
4148 * unexhp9k800.c (run_time_remap, save_data_space)
4149 (update_file_ptrs, read_header, write_header, calculate_checksum)
4150 (copy_file, copy_rest, display_header): Likewise.
4151 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4153 * xdisp.c (check_it): Likewise.
4154 * xfaces.c (register_color, unregister_color, unregister_colors):
4156 * xfns.c (print_fontset_result): Likewise.
4157 * xrdb.c (member, fatal, main): Likewise.
4159 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4161 Fix minor problems found by static checking (Bug#9031).
4162 * chartab.c (char_table_set_range, map_sub_char_table):
4163 Remove unused locals.
4164 (uniprop_table): Now static.
4165 * composite.c (_work_char): Remove unused static var.
4167 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4169 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4171 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4173 * gtkutil.c (qttip_cb): Remove code without function.
4175 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4177 * w32.c (pthread_sigmask): New stub.
4179 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4181 Use pthread_sigmask, not sigprocmask (Bug#9010).
4182 sigprocmask is portable only for single-threaded applications, and
4183 Emacs can be multi-threaded when it uses GTK.
4184 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4186 * callproc.c (Fcall_process):
4187 * process.c (create_process):
4188 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4189 Use pthread_sigmask, not sigprocmask.
4191 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4193 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4194 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4197 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4199 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4200 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4201 (xg_hide_tooltip): Fix comment.
4203 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4204 in registerServicesMenuSendTypes.
4205 (validRequestorForSendType): Don't check ns_return_types.
4207 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4210 2011-07-08 Jason Rumney <jasonr@gnu.org>
4212 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4213 SH_SHOW for hidden windows (Bug#5482).
4215 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4216 frame struct members of non-existent frames (Bug#6284).
4218 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4220 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4221 variable firstTime not needed on OSX >= 10.6.
4222 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4223 >= 10.5. Use setKnobProportion, setDoubleValue.
4225 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4226 (MAC_OS_X_VERSION_10_5): Define if not defined.
4227 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4228 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4229 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4231 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4232 cString and lossyCString on OSX >= 10.4
4234 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4235 sizeToFit on OSX >= 10.2.
4237 * nsimage.m (allocInitFromFile): Don't use deprecated method
4238 bestRepresentationForDevice on OSX >= 10.6.
4240 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4243 * emacs.c: Declare unexec_init_emacs_zone.
4245 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4247 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4249 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4250 on svcsMenu (Bug#8842).
4252 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4254 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4256 * nsterm.m (QUTF8_STRING): Declare.
4257 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4258 (validRequestorForSendType): Return type is (id).
4259 Change indexOfObjectIdenticalTo to indexOfObject.
4260 Check if we have local selection before returning self (Bug#8842).
4261 (writeSelectionToPasteboard): Put local selection into paste board
4262 if we have a local selection (Bug#8842).
4263 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4265 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4266 (ns_get_local_selection): Declare.
4268 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4270 * keymap.c (describe_map_tree): Don't insert a double newline at
4271 the end of the buffer (bug#1169) and return whether we inserted
4274 * callint.c (Fcall_interactively): Change "reading args" to
4275 "providing args" to try to clarify what it does (bug#1010).
4277 2011-07-07 Kenichi Handa <handa@m17n.org>
4279 * composite.c (composition_compute_stop_pos): Ignore a static
4280 composition starting before CHARPOS (Bug#8915).
4282 * xdisp.c (handle_composition_prop): Likewise.
4284 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4286 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4289 2011-07-07 Kenichi Handa <handa@m17n.org>
4291 * character.h (unicode_category_t): New enum type.
4293 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4294 (Qchar_code_property_table): New variable.
4295 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4296 (UNIPROP_COMPRESSED_FORM_P): New macros.
4297 (char_table_ascii): Uncompress the compressed values.
4298 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4299 Uncompress the compressed values.
4300 (sub_char_table_ref_and_range): Likewise.
4301 (char_table_ref_and_range): Uncompress the compressed values.
4302 (sub_char_table_set): New arg is_uniprop. Callers changed.
4303 Uncompress the compressed values.
4304 (sub_char_table_set_range): Args changed. Callers changed.
4305 (char_table_set_range): Adjuted for the above change.
4306 (map_sub_char_table): Delete args default_val and parent. Add arg
4307 top. Give decoded values to a Lisp function.
4308 (map_char_table): Adjust for the above change. Give decoded
4309 values to a Lisp function. Gcpro more variables.
4310 (uniprop_table_uncompress)
4311 (uniprop_decode_value_run_length): New functions.
4312 (uniprop_decoder, uniprop_decoder_count): New variables.
4313 (uniprop_get_decoder, uniprop_encode_value_character)
4314 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4316 (uniprop_encoder, uniprop_encoder_count): New variables.
4317 (uniprop_get_encoder, uniprop_table)
4318 (Funicode_property_table_internal, Fget_unicode_property_internal)
4319 (Fput_unicode_property_internal): New functions.
4320 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4321 Sunicode_property_table_internal, Sget_unicode_property_internal,
4322 and Sput_unicode_property_internal. Defvar_lisp
4323 char-code-property-alist.
4325 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4326 Vunicode_category_table.
4328 * font.c (font_range): Adjust for the change of
4329 Vunicode_category_table.
4331 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4333 * m/iris4d.h: Remove file, move contents ...
4334 * s/irix6-5.h: ... here.
4336 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4338 Remove unportable assumption about struct layout (Bug#8884).
4339 * alloc.c (mark_buffer):
4340 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4341 (clone_per_buffer_values): Don't assume that
4342 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4343 This isn't true in general, and it's particularly not true
4344 if Emacs is configured with --with-wide-int.
4345 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4346 New macros, used in the buffer.c change.
4348 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4350 * xsettings.c: Use both GConf and GSettings if both are available.
4351 (store_config_changed_event): Add comment.
4352 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4353 (store_tool_bar_style_changed): New functions.
4354 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4355 (struct xsettings): Move font inside HAVE_XFT.
4356 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4357 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4358 Move inside HAVE_XFT.
4359 (something_changed_gsettingsCB): Rename from something_changedCB.
4360 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4362 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4363 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4364 (something_changed_gconfCB): Rename from something_changedCB.
4365 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4366 (parse_settings): Move check for font inside HAVE_XFT.
4367 (read_settings, apply_xft_settings): Add comment.
4368 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4369 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4370 call store_font_name_changed.
4371 (xft_settings_event): Add comment.
4372 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4373 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4374 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4375 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4376 (xsettings_initialize): Call init_gsettings last.
4377 (xsettings_get_system_font, xsettings_get_system_normal_font):
4380 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4382 Random fixes. E.g., (random) never returned negative values.
4383 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4384 subseconds part to the entropy, as that's a bit more random.
4385 Prefer signed to unsigned, since the signedness doesn't matter and
4386 in general we prefer signed. When given a limit, use a
4387 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4388 latter isn't right if USE_2_TAGS_FOR_INTS.
4389 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4390 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4392 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4394 * textprop.c (text_property_stickiness):
4395 Obey Vtext_property_default_nonsticky.
4396 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4397 * w32fns.c (syms_of_w32fns):
4398 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4400 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4402 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4403 This is more efficient than Ffile_directory_p and avoids a minor race.
4405 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4407 * buffer.c (Foverlay_put): Say what the return value is
4410 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4411 is a directory before asking whether to use the file name
4413 (barf_or_query_if_file_exists): Make the "File is a directory"
4414 error be more correct.
4416 * fns.c (Frequire): Remove the mention of the .gz files, since
4417 that's installation-specific, but keep the mention of
4418 `get-load-suffixes'.
4420 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4422 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4423 Report string overflow if the output is too long.
4425 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4427 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4428 (syms_of_gnutls): Remove duplicate DEFSYM for
4429 Qgnutls_bootprop_verify_hostname_error, an error for
4430 Qgnutls_bootprop_verify_error (which is no longer used).
4432 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4433 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4434 Also (re)move comments that are misplaced or no longer relevant.
4436 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4438 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4440 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4442 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4443 and background color parameters if they have been changed.
4445 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4447 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4449 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4451 * xsettings.c (SYSTEM_FONT): Define only when used.
4452 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4454 * keymap.c (access_keymap_1): Now static.
4456 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4458 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4459 leave any prefix arg for the up event (Bug#1586).
4461 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4463 * lread.c (syms_of_lread): Mention single symbols defined by
4464 `defvar' or `defconst' (bug#7154).
4466 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4467 (Frequire): Mention get-load-suffixes.
4469 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4471 * window.h (window): Remove clone_number slot.
4472 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4474 (make_parent_window, make_window, saved_window)
4475 (Fset_window_configuration, save_window_save): Don't deal with
4477 * buffer.c (Qclone_number): Remove declaration.
4478 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4480 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4482 Add multiple inheritance to keymaps.
4483 * keymap.c (Fmake_composed_keymap): New function.
4484 (Fset_keymap_parent): Simplify.
4485 (fix_submap_inheritance): Remove.
4486 (access_keymap_1): New function extracted from access_keymap to handle
4487 embedded parents and handle lists of maps.
4488 (access_keymap): Use it.
4489 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4490 (Fcopy_keymap): Handle embedded parents.
4491 (Fcommand_remapping, define_as_prefix): Simplify.
4492 (Fkey_binding): Simplify.
4493 (syms_of_keymap): Move minibuffer-local-completion-map,
4494 minibuffer-local-filename-completion-map,
4495 minibuffer-local-must-match-map, and
4496 minibuffer-local-filename-must-match-map to Elisp.
4497 (syms_of_keymap): Defsubr make-composed-keymap.
4498 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4499 (parse_menu_item): Trivial simplification.
4501 2011-07-01 Glenn Morris <rgm@gnu.org>
4503 * Makefile.in (SETTINGS_LIBS): Fix typo.
4505 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4507 * coding.c (Fencode_coding_string): Record the last coding system
4508 used, as the function doc string says (bug#8738).
4510 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4512 * xsettings.c (store_monospaced_changed): Take new font as arg and
4513 check for change against current_mono_font.
4514 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4515 (emacs_settings_constructor, emacs_settings_get_property)
4516 (emacs_settings_set_property, emacs_settings_class_init)
4517 (emacs_settings_init, gsettings_obj): Remove.
4518 (something_changedCB): New function for HAVE_GSETTINGS.
4519 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4520 with value as argument.
4521 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4522 g_settings_new (Bug#8967). Do not create gsettings_obj.
4523 Remove calls to g_settings_bind. Connect something_changedCB to
4526 * xgselect.c: Add defined (HAVE_GSETTINGS).
4527 (xgselect_initialize): Ditto.
4529 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4530 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4533 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4535 * eval.c (struct backtrace): Simplify and port the data structure.
4536 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4537 signed bit field, as this assumption is not portable and it makes
4538 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4539 "char debug_on_exit : 1" as this is not portable either; instead,
4540 use the portable "unsigned int debug_on_exit : 1". Remove unused
4541 member evalargs. Remove obsolete comments about cc bombing out.
4543 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4545 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4546 Let HAVE_GSETTINGS override HAVE_GCONF.
4547 (store_monospaced_changed): New function.
4548 (EMACS_SETTINGS): A new type derived from GObject to handle
4549 GSettings notifications.
4550 (emacs_settings_constructor, emacs_settings_get_property)
4551 (emacs_settings_set_property, emacs_settings_class_init):
4553 (gsettings_client, gsettings_obj): New variables.
4554 (GSETTINGS_SCHEMA): New define.
4555 (something_changedCB): Call store_monospaced_changed.
4556 (init_gsettings): New function.
4557 (xsettings_initialize): Call init_gsettings.
4558 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4561 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4564 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4566 * window.c (resize_root_window, grow_mini_window)
4567 (shrink_mini_window): Rename Qresize_root_window to
4568 Qwindow_resize_root_window and Qresize_root_window_vertically to
4569 Qwindow_resize_root_window_vertically.
4571 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4573 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4575 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4577 * makefile.w32-in: Redesign dependencies so they reflect more
4578 clearly which files are directly included by each source file,
4579 and not through other includes.
4581 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4583 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4584 (sort_overlays, overlay_strings): When an overlay's clone number
4585 matches the window's clone number process the overlay even if
4586 the overlay's window property doesn't match the current window.
4588 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4589 (Fwindow_hchild): Rename to Fwindow_left_child.
4590 (Fwindow_next): Rename to Fwindow_next_sibling.
4591 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4592 (resize_window_check): Rename to window_resize_check.
4593 (resize_window_apply): Rename to window_resize_apply.
4594 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4595 (Fdelete_other_windows_internal, resize_frame_windows)
4596 (Fsplit_window_internal, Fdelete_window_internal)
4597 (grow_mini_window, shrink_mini_window)
4598 (Fresize_mini_window_internal): Fix callers accordingly.
4600 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4602 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4603 (emacs_fixed_set_min_size): Remove.
4604 (emacs_fixed_new): Take frame as argument.
4606 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4607 (_EmacsFixedPrivate): Remove minwidth/height.
4608 Add struct frame *f.
4609 (emacs_fixed_init): Initialize priv->f.
4610 (get_parent_class, emacs_fixed_set_min_size): Remove.
4611 (emacs_fixed_new): Set priv->f to argument.
4612 (emacs_fixed_get_preferred_width)
4613 (emacs_fixed_get_preferred_height): Use min_width/height from
4614 frames size_hint to set minimum and natural (Bug#8919).
4615 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4616 and use min_width/height from frames size_hint to set
4617 min_width/height (Bug#8919).
4619 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4620 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4623 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4625 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4626 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4629 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4631 * process.c (wait_reading_process_output): Bypass select if
4632 waiting for a cell while ignoring keyboard input, and input is
4633 pending. Suggested by Jan Djärv (Bug#8869).
4635 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4637 Use gnulib's dup2 module instead of rolling our own.
4638 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4640 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4642 * dispnew.c (scrolling_window): Before scrolling, turn off a
4643 mouse-highlight in the window being scrolled.
4645 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4647 Move DEFSYM to lisp.h and use everywhere.
4649 * character.h (DEFSYM): Move declaration...
4650 * lisp.h (DEFSYM): ...here.
4656 * w32select.c: Don't include character.h.
4658 * alloc.c (syms_of_alloc):
4659 * buffer.c (syms_of_buffer):
4660 * bytecode.c (syms_of_bytecode):
4661 * callint.c (syms_of_callint):
4662 * casefiddle.c (syms_of_casefiddle):
4663 * casetab.c (init_casetab_once):
4664 * category.c (init_category_once, syms_of_category):
4665 * ccl.c (syms_of_ccl):
4666 * cmds.c (syms_of_cmds):
4667 * composite.c (syms_of_composite):
4668 * dbusbind.c (syms_of_dbusbind):
4669 * dired.c (syms_of_dired):
4670 * dispnew.c (syms_of_display):
4671 * doc.c (syms_of_doc):
4672 * editfns.c (syms_of_editfns):
4673 * emacs.c (syms_of_emacs):
4674 * eval.c (syms_of_eval):
4675 * fileio.c (syms_of_fileio):
4676 * fns.c (syms_of_fns):
4677 * frame.c (syms_of_frame):
4678 * fringe.c (syms_of_fringe):
4679 * insdel.c (syms_of_insdel):
4680 * keymap.c (syms_of_keymap):
4681 * lread.c (init_obarray, syms_of_lread):
4682 * macros.c (syms_of_macros):
4683 * msdos.c (syms_of_msdos):
4684 * print.c (syms_of_print):
4685 * process.c (syms_of_process):
4686 * search.c (syms_of_search):
4687 * sound.c (syms_of_sound):
4688 * syntax.c (init_syntax_once, syms_of_syntax):
4689 * terminal.c (syms_of_terminal):
4690 * textprop.c (syms_of_textprop):
4691 * undo.c (syms_of_undo):
4692 * w32.c (globals_of_w32):
4693 * window.c (syms_of_window):
4694 * xdisp.c (syms_of_xdisp):
4695 * xfaces.c (syms_of_xfaces):
4696 * xfns.c (syms_of_xfns):
4697 * xmenu.c (syms_of_xmenu):
4698 * xsettings.c (syms_of_xsettings):
4699 * xterm.c (syms_of_xterm): Use DEFSYM.
4701 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4703 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4705 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4707 Integer and buffer overflow fixes (Bug#8873).
4709 * print.c (printchar, strout): Check for string overflow.
4710 (PRINTPREPARE, printchar, strout):
4711 Don't set size unless allocation succeeds.
4713 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4714 for sizes. Check for string overflow more accurately.
4715 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4717 * macros.c: Integer and buffer overflow fixes.
4718 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4719 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4720 Use ptrdiff_t, not int, for sizes.
4721 Don't increment bufsize until after realloc succeeds.
4722 Check for size-calculation overflow.
4723 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4725 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4727 * lread.c: Integer overflow fixes.
4728 (read_integer): Radix is now EMACS_INT, not int,
4729 to improve quality of diagnostics for out-of-range radices.
4730 Calculate buffer size correctly for out-of-range radices.
4731 (read1): Check for integer overflow in radices, and in
4732 read-circle numbers.
4733 (read_escape): Avoid int overflow.
4734 (Fload, openp, read_buffer_size, read1)
4735 (substitute_object_recurse, read_vector, read_list, map_obarray):
4736 Use ptrdiff_t, not int, for sizes.
4737 (read1): Use EMACS_INT, not int, for sizes.
4738 Check for size overflow.
4740 * image.c (cache_image): Check for size arithmetic overflow.
4742 * lread.c: Integer overflow issues.
4743 (saved_doc_string_size, saved_doc_string_length)
4744 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4745 Now ptrdiff_t, not int.
4746 (read1): Don't assume doc string length fits in int. Check for
4747 out-of-range doc string lengths.
4748 (read_list): Don't assume file position fits in int.
4749 (read_escape): Check for hex character overflow.
4751 2011-06-22 Leo Liu <sdl.web@gmail.com>
4753 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4754 Move to minibuffer.el.
4756 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4758 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4759 The following patches are for when GLYPH_DEBUG && !XASSERT.
4760 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4761 * dispnew.c (flush_stdout):
4762 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4763 Mark as externally visible.
4764 * dispnew.c (check_window_matrix_pointers): Now static.
4765 * dispnew.c (window_to_frame_vpos):
4766 * xfns.c (unwind_create_frame):
4767 * xterm.c (x_check_font): Remove unused local.
4768 * scroll.c (CHECK_BOUNDS):
4769 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4770 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4771 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4772 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4773 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4775 (debug_method_add): Use va_list and vsprintf rather than relying
4776 on undefined behavior with wrong number of arguments.
4777 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4778 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4779 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4780 since we're not interested in debugging glyphs with old libraries.
4781 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4782 GCC 4.6.0's static checking.
4784 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4786 Integer overflow and signedness fixes (Bug#8873).
4787 A few related buffer overrun fixes, too.
4789 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4791 * dispextern.h (struct face.stipple):
4792 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4793 (x_bitmap_mask, x_allocate_bitmap_record)
4794 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4795 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4796 (x_create_bitmap_from_xpm_data):
4797 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4798 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4800 * xfaces.c (load_pixmap):
4801 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4802 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4803 (.bitmaps_last, struct x_output.icon_bitmap):
4804 Use ptrdiff_t, not int, for bitmap indexes.
4805 (x_allocate_bitmap_record): Check for size overflow.
4806 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4808 Use ptrdiff_t, not int, for overlay counts.
4809 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4810 * editfns.c (overlays_around, get_pos_property):
4811 * textprop.c (get_char_property_and_overlay):
4812 * xdisp.c (next_overlay_change, note_mouse_highlight):
4813 * xfaces.c (face_at_buffer_position):
4814 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4815 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4816 (Fnext_overlay_change, Fprevious_overlay_change)
4817 (mouse_face_overlay_overlaps, Foverlays_in):
4818 Use ptrdiff_t, not int, for sizes.
4819 (overlays_at, overlays_in): Check for size-calculation overflow.
4821 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4823 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4824 (x_session_initialize): Do not assume string length fits in int.
4826 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4827 This is unlikely, but can occur if DPI is outlandish.
4829 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4830 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4832 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4833 * xrdb.c (magic_file_p, search_magic_path):
4834 Omit last arg SUFFIX; it was always 0. All callers changed.
4835 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4837 * xfont.c (xfont_match): Avoid need for strlen.
4839 * xfns.c: Don't assume strlen fits in int.
4840 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4842 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4843 not unsigned long, as we prefer signed integers. All callers changed.
4844 Detect integer overflow in repeat count.
4845 (message_dolog): Don't assume print length fits in 39 bytes.
4846 (display_mode_element): Don't assume strlen fits in int.
4848 * termcap.c: Don't assume sizes fit in int and never overflow.
4849 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4850 (gobble_line): Check for size-calculation overflow.
4852 * minibuf.c (Fread_buffer):
4853 * lread.c (intern, intern_c_string):
4854 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4855 Don't assume string length fits in int.
4857 * keyboard.c (parse_tool_bar_item):
4858 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4860 * font.c: Don't assume string length fits in int.
4861 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4862 Use ptrdiff_t, not int.
4863 (font_intern_prop): Don't assume string length fits in int.
4864 Don't assume integer property fits in fixnum.
4865 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4867 * filelock.c: Fix some buffer overrun and integer overflow issues.
4868 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4869 Reformulate so as not to need the command string.
4870 Invoke gzip -cd rather than gunzip, as it's more portable.
4871 (lock_info_type, lock_file_1, lock_file):
4872 Don't assume pid_t and time_t fit in unsigned long.
4873 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4874 (current_lock_owner): Prefer signed type for sizes.
4875 Use memcpy, not strncpy, where memcpy is what is really wanted.
4876 Don't assume (via atoi) that time_t and pid_t fit in int.
4877 Check for time_t and/or pid_t out of range, e.g., via a network share.
4878 Don't alloca where an auto var works fine.
4880 * fileio.c: Fix some integer overflow issues.
4881 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4882 Don't assume string length fits in int.
4883 (directory_file_name): Don't assume string length fits in long.
4884 (make_temp_name): Don't assume pid fits in int, or that its print
4885 length is less than 20.
4887 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4889 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4891 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4893 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4894 We prefer signed integers, even for size calculations.
4896 * emacs.c: Don't assume string length fits in 'int'.
4897 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4898 (main): Don't invoke strlen when not needed.
4900 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4901 (XD_DEBUG_MESSAGE): Don't waste a byte.
4903 * callproc.c (getenv_internal_1, getenv_internal)
4905 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4907 * lread.c (invalid_syntax): Omit length argument.
4908 All uses changed. This doesn't fix a bug, but it simplifies the
4909 code away from its former Hollerith-constant appearance, and it's
4910 one less 'int' to worry about when looking at integer-overflow issues.
4911 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4913 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4914 This didn't break anything, but it didn't help either.
4915 It's confusing to put a bogus integer in a place where the actual
4916 value does not matter.
4917 (LIST_END_P): Remove unused macro and its bogus comment.
4918 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4920 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4921 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4923 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4924 We prefer signed types, and the value cannot exceed the EMACS_INT
4925 range anyway (because otherwise the length would not be representable).
4926 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4927 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4928 This avoids a GCC warning when WIDE_EMACS_INT.
4930 * indent.c (sane_tab_width): New function.
4931 (current_column, scan_for_column, Findent_to, position_indentation)
4932 (compute_motion): Use it. This is just for clarity.
4933 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4935 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4937 * lisp.h (lint_assume): New macro.
4938 * composite.c (composition_gstring_put_cache):
4939 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4941 * editfns.c, insdel.c:
4942 Omit unnecessary forward decls, to simplify future changes.
4944 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4946 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4948 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4949 Use much-faster test for byte-length change.
4950 Don't assume string byte-length fits in 'int'.
4951 Check that character arg fits in 'int'.
4952 (mapcar1): Declare byte as byte, for clarity.
4954 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4956 * fns.c (concat): Catch string overflow earlier.
4957 Do not rely on integer wraparound.
4959 * dispextern.h (struct it.overlay_strings_charpos)
4960 (struct it.selective): Now EMACS_INT, not int.
4961 * xdisp.c (forward_to_next_line_start)
4962 (back_to_previous_visible_line_start)
4963 (reseat_at_next_visible_line_start, next_element_from_buffer):
4964 Don't arbitrarily truncate the value of 'selective' to int.
4966 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4968 * composite.c: Don't truncate sizes to 'int'.
4969 (composition_gstring_p, composition_reseat_it)
4970 (composition_adjust_point): Use EMACS_INT, not int.
4971 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4972 not EMACS_UINT, for indexes.
4974 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4976 * buffer.c: Include <verify.h>.
4977 (struct sortvec.priority, struct sortstr.priority):
4978 Now EMACS_INT, not int.
4979 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4980 (struct sortstr.size, record_overlay_string)
4981 (struct sortstrlist.size, struct sortlist.used):
4982 Don't truncate size to int.
4983 (record_overlay_string): Check for size-calculation overflow.
4984 (init_buffer_once): Check at compile-time, not run-time.
4986 2011-06-22 Jim Meyering <meyering@redhat.com>
4988 Don't leak an XBM-image-sized buffer
4989 * image.c (xbm_load): Free the image buffer after using it.
4991 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4994 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4995 that Sun C diagnosed.
4996 * fns.c (secure_hash): Fix pointer signedness issue.
4997 * intervals.c (static_offset_intervals): New function.
4998 (offset_intervals): Use it.
5000 2011-06-21 Leo Liu <sdl.web@gmail.com>
5003 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5006 * fns.c (secure_hash): Rename from crypto_hash_function and change
5007 the first arg to accept symbols.
5008 (Fsecure_hash): New primitive.
5009 (syms_of_fns): New symbols.
5011 2011-06-20 Deniz Dogan <deniz@dogan.se>
5013 * process.c (Fset_process_buffer): Clarify return value in
5016 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5018 * dispnew.c (add_window_display_history): Use BVAR.
5020 * xdisp.c (debug_method_add): Use BVAR.
5021 (check_window_end, dump_glyph_matrix, dump_glyph)
5022 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5024 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5027 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5028 check till after the cache is created in init_frame_faces.
5030 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5032 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5034 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5036 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5037 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5038 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5040 Improve buffer-overflow checking (Bug#8873).
5041 * fileio.c (Finsert_file_contents):
5042 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5043 Remove the old (too-loose) buffer overflow checks.
5044 They weren't needed, since make_gap checks for buffer overflow.
5045 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5046 The old code merely checked for Emacs fixnum overflow, and relied
5047 on undefined (wraparound) behavior. The new code avoids undefined
5048 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5050 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5051 Tune. Don't use wider integers than needed. Don't use alloca.
5052 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5054 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5056 * insdel.c, lisp.h (buffer_overflow): New function.
5057 (insert_from_buffer_1, replace_range, replace_range_2):
5058 * insdel.c (make_gap_larger):
5059 * editfns.c (Finsert_char):
5060 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5062 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5064 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5066 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5068 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5069 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5071 * fileio.c: Don't assume EMACS_INT fits in off_t.
5072 (emacs_lseek): New static function.
5073 (Finsert_file_contents, Fwrite_region): Use it.
5074 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5076 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5078 * fns.c: Don't overflow int when computing a list length.
5079 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5080 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5081 truncation on 64-bit hosts. Check for QUIT every
5082 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5083 faster and is responsive enough.
5084 (Flength): Report an error instead of overflowing an integer.
5085 (Fsafe_length): Return a float if the value is not representable
5086 as a fixnum. This shouldn't happen except in contrived situations.
5087 (Fnthcdr, Fsort): Don't assume list length fits in int.
5088 (Fcopy_sequence): Don't assume vector length fits in int.
5090 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5091 (header_size, word_size): New constants.
5092 (allocate_vectorlike): Don't check size overflow here.
5093 (allocate_vector): Check it here instead, since this is the only
5094 caller of allocate_vectorlike that could cause overflow.
5095 Check that the new vector's length is representable as a fixnum.
5097 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5098 The previous code was bogus. For example, next_almost_prime (32)
5099 returned 39, which is undesirable as it is a multiple of 3; and
5100 next_almost_prime (24) returned 25, which is a multiple of 5 so
5101 why was the code bothering to check for multiples of 7?
5103 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5105 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5107 Variadic C functions now count arguments with ptrdiff_t.
5108 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5109 Back then I didn't know that the Emacs coding style prefers signed int.
5110 Also, in the meantime I found a few more instances where arguments
5111 were being counted with int, which may truncate counts on 64-bit
5112 machines, or EMACS_INT, which may be unnecessarily wide.
5113 * lisp.h (struct Lisp_Subr.function.aMANY)
5114 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5115 Arg counts are now ptrdiff_t, not size_t.
5116 All variadic functions and their callers changed accordingly.
5117 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5118 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5119 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5120 * callint.c (Fcall_interactively): Check arg count for overflow,
5121 to avoid potential buffer overrun. Use signed char, not 'int',
5122 for 'varies' array, so that we needn't bother to check its size
5123 calculation for overflow.
5124 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5125 * eval.c (apply_lambda):
5126 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5127 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5128 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5130 * callint.c (Fcall_interactively): Don't use index var as event count.
5132 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5133 * mem-limits.h (SIZE): Remove; no longer used.
5135 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5137 Remove unnecessary casts.
5138 * xterm.c (x_term_init):
5139 * xfns.c (x_set_border_pixel):
5140 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5141 These aren't needed now that we assume ANSI C.
5143 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5144 It's more likely to cause problems (due to unsigned overflow)
5147 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5149 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5151 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5153 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5155 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5157 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5159 GLYPH_CODE_FACE returns EMACS_INT, not int.
5160 * dispextern.h (merge_faces):
5161 * xfaces.c (merge_faces):
5162 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5163 Don't assume EMACS_INT fits in int.
5165 * character.h (CHAR_VALID_P): Remove unused parameter.
5166 * fontset.c, lisp.h, xdisp.c: All uses changed.
5168 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5170 * fns.c (concat): Minor tuning based on overflow analysis.
5171 This doesn't fix any bugs. Use int to hold character, instead
5172 of constantly refetching from Emacs object. Use XFASTINT, not
5173 XINT, for value known to be a character. Don't bother comparing
5174 a single byte to 0400, as it's always less.
5176 * floatfns.c (Fexpt):
5177 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5179 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5182 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5184 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5185 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5186 incorrectly succeed when S was a string, because 4294967386 was
5187 truncated before it was used.
5189 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5190 Otherwise, an out-of-range integer could cause undefined behavior
5193 * composite.c: Use int, not EMACS_INT, for characters.
5194 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5195 EMACS_INT, for values that are known to be in character range.
5196 This doesn't fix any bugs but is the usual style inside Emacs and
5197 may generate better code on 32-bit machines.
5199 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5200 This is for reasons similar to the recent CHAR_STRING fix.
5201 * charset.c (Fencode_char): Check that character arg is actually
5202 a character. Pass an int to ENCODE_CHAR.
5203 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5204 wider than 'int', as a compile-time check to prevent future regressions
5207 * character.c (char_string): Remove unnecessary casts.
5209 Make sure a 64-bit char is never passed to CHAR_STRING.
5210 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5211 by silently ignoring the top 32 bits, allowing some values
5212 that were far too large to be valid characters.
5213 * character.h: Include <verify.h>.
5214 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5215 arguments are no wider than unsigned, as a compile-time check
5216 to prevent future regressions in this area.
5218 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5219 (Fsubst_char_in_region):
5221 * xdisp.c (decode_mode_spec_coding):
5222 Adjust to CHAR_STRING's new requirement.
5223 * editfns.c (Finsert_char, Fsubst_char_in_region):
5224 * fns.c (concat): Check that character args are actually
5225 characters. Without this test, these functions did the wrong
5226 thing with wildly out-of-range values on 64-bit hosts.
5228 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5229 These casts should not be needed on 32-bit hosts, either.
5230 * keyboard.c (read_char):
5231 * lread.c (Fload): Remove casts to unsigned.
5233 * lisp.h (UNSIGNED_CMP): New macro.
5234 This fixes comparison bugs on 64-bit hosts.
5235 (ASCII_CHAR_P): Use it.
5236 * casefiddle.c (casify_object):
5237 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5238 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5239 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5240 * dispextern.h (FACE_FROM_ID):
5241 * keyboard.c (read_char): Use UNSIGNED_CMP.
5243 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5244 not to EMACS_INT, to avoid GCC warning.
5246 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5248 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5249 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5250 isn't needed on 32-bit machines.
5252 * buffer.c (Fgenerate_new_buffer_name):
5253 Use EMACS_INT for count, not int.
5254 (advance_to_char_boundary): Return EMACS_INT, not int.
5256 * data.c (Qcompiled_function): Now static.
5258 * window.c (window_body_lines): Now static.
5260 * image.c (gif_load): Rename local to avoid shadowing.
5262 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5263 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5264 * alloc.c (make_save_value): Integer argument is now of type
5266 (mark_object): Use ptrdiff_t, not int.
5267 * lisp.h (pD): New macro.
5268 * print.c (print_object): Use it.
5270 * alloc.c: Use EMACS_INT, not int, to count objects.
5271 (total_conses, total_markers, total_symbols, total_vector_size)
5272 (total_free_conses, total_free_markers, total_free_symbols)
5273 (total_free_floats, total_floats, total_free_intervals)
5274 (total_intervals, total_strings, total_free_strings):
5275 Now EMACS_INT, not int. All uses changed.
5276 (Fgarbage_collect): Compute overall total using a double, so that
5277 integer overflow is less likely to be a problem. Check for overflow
5278 when converting back to an integer.
5279 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5280 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5281 These were 'int' variables that could overflow on 64-bit hosts;
5282 they were never used, so remove them instead of repairing them.
5283 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5284 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5285 Previously, this ceilinged at INT_MAX, but that doesn't work on
5287 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5289 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5290 (allocate_vectorlike): Check for ptrdiff_t overflow.
5291 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5292 when a (possibly-narrower) signed value would do just as well.
5293 We prefer using signed arithmetic, to avoid comparison confusion.
5295 * alloc.c: Catch some string size overflows that we were missing.
5296 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5297 for convenience in STRING_BYTES_MAX.
5298 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5299 The definition here is exact; the one in lisp.h was approximate.
5300 (allocate_string_data): Check for string overflow. This catches
5301 some instances we weren't catching before. Also, it catches
5302 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5303 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5304 and ptrdiff_t and EMACS_INT are both 64 bits.
5306 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5307 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5308 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5310 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5312 * alloc.c (Fmake_string): Check for out-of-range init.
5314 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5316 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5318 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5320 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5321 xg_get_default_scrollbar_width.
5323 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5324 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5325 (style_changed_cb): Call update_theme_scrollbar_width and call
5326 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5327 all frames (Bug#8505).
5328 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5329 Call gtk_window_set_resizable if HAVE_GTK3.
5330 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5331 and height if HAVE_GTK3 (Bug#8505).
5332 (scroll_bar_width_for_theme): New variable.
5333 (update_theme_scrollbar_width): New function.
5334 (xg_get_default_scrollbar_width): Move code to
5335 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5336 (xg_initialize): Call update_theme_scrollbar_width.
5338 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5340 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5342 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5344 * frame.c (make_frame): Call other_buffer_safely instead of
5347 * window.c (temp_output_buffer_show): Call display_buffer with
5348 second argument Vtemp_buffer_show_specifiers and reset latter
5349 immediately after the call.
5350 (Vtemp_buffer_show_specifiers): New variable.
5351 (auto_window_vscroll_p, next_screen_context_lines)
5352 (Vscroll_preserve_screen_position): Remove leading asterisks from
5355 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5357 Fix minor problems found by GCC 4.6.0 static checking.
5358 * buffer.c (Qclone_number): Remove for now, as it's unused.
5359 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5360 (record_buffer): Remove unused local.
5361 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5362 (set_frame_buffer_list): Remove; unused.
5363 * frame.h (other_visible_frames): Remove decl.
5364 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5365 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5366 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5368 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5369 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5370 Define only if HAVE_GPM.
5371 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5372 (update_hints_inhibit): Remove; never set. All uses removed.
5373 * widgetprv.h (emacsFrameClassRec): Remove decl.
5374 * window.c (delete_deletable_window): Now returns void, since it
5375 wasn't returning anything.
5376 (compare_window_configurations): Remove unused locals.
5377 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5378 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5379 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5380 the same widths as pointers. This follows up on the 2011-05-06 patch.
5381 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5382 * xterm.h: Likewise.
5383 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5385 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5387 * makefile.w32-in: Update dependencies.
5388 (LISP_H): Add lib/intprops.h.
5390 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5392 * image.c (gif_load): Add animation frame delay to the metadata.
5393 (syms_of_image): Use DEFSYM. New symbol `delay'.
5395 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5397 * window.c (delete_deletable_window): Re-add.
5398 (Fset_window_configuration): Rewrite to handle dead buffers and
5399 consequently deletable windows.
5400 (window_tree, Fwindow_tree): Remove. Supply functionality in
5402 (compare_window_configurations): Simplify code.
5404 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5406 * image.c (imagemagick_load_image): Fix type mismatch.
5407 (Fimagemagick_types): Likewise.
5409 * window.h (replace_buffer_in_windows): Declare.
5411 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5413 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5414 Qclone_number. Remove external declaration of Qdelete_window.
5415 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5417 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5418 Run Qbuffer_list_update_hook if allowed.
5419 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5420 buffer list implementation.
5421 (other_buffer_safely): New function.
5422 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5423 calls to replace_buffer_in_windows and
5424 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5426 (record_buffer): Inhibit quitting and rewrite using quittable
5427 functions. Run Qbuffer_list_update_hook if allowed.
5428 (Frecord_buffer, Funrecord_buffer): New functions.
5429 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5430 Move switch-to-buffer to window.el.
5431 (bury-buffer): Move to window.el.
5432 (Vbuffer_list_update_hook): New variable.
5434 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5437 * window.h (resize_frame_windows): Move up in code.
5438 (Fwindow_frame): Remove EXFUN.
5439 (replace_buffer_in_all_windows): Remove prototype.
5440 (replace_buffer_in_windows_safely): Add prototype.
5442 * window.c: Declare Qdelete_window static again. Move down
5443 declaration of select_count.
5444 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5445 (Fother_window): Move to window.el.
5446 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5447 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5448 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5450 (replace_buffer_in_windows): Implement by calling
5451 Qreplace_buffer_in_windows.
5452 (replace_buffer_in_all_windows): Remove with some functionality
5453 moved into replace_buffer_in_windows_safely.
5454 (replace_buffer_in_windows_safely): New function.
5455 (select_window_norecord, select_frame_norecord): Move in front
5456 of run_window_configuration_change_hook. Remove now obsolete
5458 (Fset_window_buffer): Rewrite doc-string.
5459 Call Qrecord_window_buffer.
5460 (keys_of_window): Move binding for other-window to window.el.
5462 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5464 * dispextern.h (struct image): Replace data member, whose int_val
5465 and ptr_val fields were not used by anything, with a single
5468 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5469 (gif_clear_image, gif_load, imagemagick_load_image)
5470 (gs_clear_image, gs_load): Callers changed.
5472 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5474 * buffer.h: Include <time.h>, for time_t.
5475 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5477 Fix minor problems found by static checking.
5479 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5481 Make identifiers static if they are not used in other modules.
5482 * data.c (Qcompiled_function, Qframe, Qvector):
5483 * image.c (QimageMagick, Qsvg):
5484 * minibuf.c (Qmetadata):
5485 * window.c (resize_window_check, resize_root_window): Now static.
5486 * window.h (resize_window_check, resize_root_window): Remove decls.
5488 * window.c (window_deletion_count, delete_deletable_window):
5490 (window_body_lines): Now static.
5491 (Fdelete_other_windows_internal): Mark vars as initialized.
5492 Make sure 'resize_failed' is initialized.
5493 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5494 (resize_window_apply): Remove unused local.
5495 * window.h (delete_deletable_window): Remove decl.
5497 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5498 (imagemagick_load_image): Fix pointer signedness problem by changing
5499 last arg from unsigned char * to char *. All uses changed.
5500 Also, fix a local for similar reasons.
5501 Remove unused locals. Remove locals to avoid shadowing.
5502 (fn_rsvg_handle_free): Remove; unused.
5503 (svg_load, svg_load_image): Fix pointer signedness problem.
5504 (imagemagick_load_image): Don't use garbage pointer image_wand.
5506 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5508 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5510 * image.c (gif_load): Fix omitted cast error introduced by
5513 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5515 * window.h (resize_proportionally, orig_total_lines)
5516 (orig_top_line): Remove from window structure.
5517 (set_window_height, set_window_width, change_window_heights)
5518 (Fdelete_window): Remove prototypes.
5519 (resize_frame_windows): Remove duplicate declaration.
5521 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5523 * window.h (resize_frame_windows, resize_window_check)
5524 (delete_deletable_window, resize_root_window)
5525 (resize_frame_windows): Declare prototypes.
5527 * window.c (resize_window_apply): Make definition be "static" to
5528 match the prototype.
5530 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5532 * window.c: Remove declarations of Qwindow_size_fixed,
5533 window_min_size_1, window_min_size_2, window_min_size,
5534 size_window, window_fixed_size_p, enlarge_window, delete_window.
5535 Remove static from declaration of Qdelete_window, it's
5536 temporarily needed by Fbury_buffer.
5537 (replace_window): Don't assign orig_top_line and
5539 (Fdelete_window, delete_window): Remove. Window deletion is
5540 handled by window.el.
5541 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5542 Replace Fdelete_window calls with calls to Qdelete_window.
5543 (Fdelete_other_windows): Remove. Deleting other windows is
5544 handled by window.el.
5545 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5546 handled in window.el.
5547 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5548 Window minimum sizes are handled in window.el.
5549 (shrink_windows, size_window, set_window_height)
5550 (set_window_width, change_window_heights, window_height)
5551 (window_width, CURBEG, CURSIZE, enlarge_window)
5552 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5553 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5554 handled in window.el.
5555 (make_dummy_parent): Rename to make_parent_window and give it a
5556 second argument horflag.
5557 (make_window): Don't set resize_proportionally any more.
5558 (Fsplit_window): Remove. Windows are split in window.el.
5559 (save_restore_action, save_restore_orig_size)
5560 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5561 Resize mini windows in window.el.
5562 (grow_mini_window, shrink_mini_window): Implement by calling
5563 Qresize_root_window_vertically, resize_window_check and
5564 resize_window_apply.
5565 (saved_window, Fset_window_configuration, save_window_save):
5566 Do not handle orig_top_line, orig_total_lines, and
5567 resize_proportionally.
5568 (window_min_height, window_min_width): Move to window.el.
5569 (keys_of_window): Move bindings for delete-other-windows,
5570 split-window, delete-window and enlarge-window to window.el.
5572 * buffer.c: Temporarily extern Qdelete_window.
5573 (Fbury_buffer): Temporarily call Qdelete_window instead of
5574 Fdelete_window (Fbury_buffer will move to window.el soon).
5576 * frame.c (set_menu_bar_lines_1): Remove code handling
5577 orig_top_line and orig_total_lines.
5579 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5580 set_window_height but set heights directly.
5581 (change_frame_size_1): Use resize_frame_windows.
5583 * xdisp.c (init_xdisp): Don't use set_window_height but set
5586 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5587 Use resize_frame_windows instead of change_window_heights and run
5588 run_window_configuration_change_hook.
5590 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5591 instead of change_window_heights and run
5592 run_window_configuration_change_hook.
5594 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5596 * window.c (replace_window): Rename second argument REPLACEMENT to
5597 NEW. New third argument SETFLAG. Rewrite.
5598 (delete_window, make_dummy_parent): Call replace_window with
5600 (window_list_1): Move down in code.
5601 (run_window_configuration_change_hook): Move set_buffer part
5602 before select_frame_norecord part in order to unwind correctly.
5603 Rename count1 to count.
5604 (recombine_windows, delete_deletable_window, resize_root_window)
5605 (Fdelete_other_windows_internal)
5606 (Frun_window_configuration_change_hook, make_parent_window)
5607 (resize_window_check, resize_window_apply, Fresize_window_apply)
5608 (resize_frame_windows, Fsplit_window_internal)
5609 (Fdelete_window_internal, Fresize_mini_window_internal):
5611 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5613 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5615 * window.h (window): Add some new members to window structure -
5616 normal_lines, normal_cols, new_total, new_normal, clone_number,
5617 splits, nest, prev_buffers, next_buffers.
5618 (WINDOW_TOTAL_SIZE): Move here from window.c.
5619 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5621 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5623 (make_dummy_parent): Set new members of windows structure.
5624 (make_window): Move down in code. Handle new members of window
5626 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5627 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5628 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5629 (Fset_window_prev_buffers, Fwindow_next_buffers)
5630 (Fset_window_next_buffers, Fset_window_clone_number):
5632 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5633 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5635 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5636 Argument WINDOW can be now internal window too.
5637 (Fwindow_use_time): Move up in code.
5638 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5640 (Fset_window_configuration, saved_window)
5641 (Fcurrent_window_configuration, save_window_save): Handle new
5642 members of window structure.
5643 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5644 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5645 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5646 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5647 Qget_mru_window, Qresize_root_window,
5648 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5649 Qauto_buffer_name; staticpro them.
5651 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5653 * window.c (Fwindow_total_size, Fwindow_left_column)
5654 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5655 (Fwindow_list_1): New functions.
5656 (window_box_text_cols): Replace with window_body_cols.
5657 (Fwindow_width, Fscroll_left, Fscroll_right):
5658 Use window_body_cols instead of window_box_text_cols.
5659 (delete_window, Fset_window_configuration):
5660 Call delete_all_subwindows with window as argument.
5661 (delete_all_subwindows): Take a window as argument and not a
5663 (window_loop): Remove handling of GET_LRU_WINDOW and
5665 (Fget_lru_window, Fget_largest_window): Move to window.el.
5667 * window.h: Extern window_body_cols instead of
5668 window_box_text_cols. delete_all_subwindows now takes a
5669 Lisp_Object as argument.
5671 * indent.c (compute_motion, Fcompute_motion):
5672 Use window_body_cols instead of window_box_text_cols.
5674 * frame.c (delete_frame): Call delete_all_subwindows with root
5677 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5679 * fns.c (Fputhash): Document return value.
5681 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5683 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5685 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5687 Cons<->int and similar integer overflow fixes (Bug#8794).
5689 Check for overflow when converting integer to cons and back.
5690 * charset.c (Fdefine_charset_internal, Fdecode_char):
5691 Use cons_to_unsigned to catch overflow.
5692 (Fencode_char): Use INTEGER_TO_CONS.
5693 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5694 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5695 * data.c (long_to_cons, cons_to_long): Remove.
5696 (cons_to_unsigned, cons_to_signed): New functions.
5697 These signal an error for invalid or out-of-range values.
5698 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5699 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5700 * font.c (Ffont_variation_glyphs):
5701 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5702 * lisp.h: Include <intprops.h>.
5703 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5704 (cons_to_signed, cons_to_unsigned): New decls.
5705 (long_to_cons, cons_to_long): Remove decls.
5706 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5707 (Fprimitive_undo): Use CONS_TO_INTEGER.
5708 * xfns.c (Fx_window_property): Likewise.
5709 * xselect.c: Include <limits.h>.
5710 (x_own_selection, selection_data_to_lisp_data):
5711 Use INTEGER_TO_CONS.
5712 (x_handle_selection_request, x_handle_selection_clear)
5713 (x_get_foreign_selection, Fx_disown_selection_internal)
5714 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5715 (lisp_data_to_selection_data): Use cons_to_unsigned.
5716 (x_fill_property_data): Use cons_to_signed.
5717 Report values out of range.
5719 Check for buffer and string overflow more precisely.
5720 * buffer.h (BUF_BYTES_MAX): New macro.
5721 * lisp.h (STRING_BYTES_MAX): New macro.
5722 * alloc.c (Fmake_string):
5723 * character.c (string_escape_byte8):
5724 * coding.c (coding_alloc_by_realloc):
5725 * doprnt.c (doprnt):
5726 * editfns.c (Fformat):
5728 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5729 since they may not be the same number.
5730 * editfns.c (Finsert_char):
5731 * fileio.c (Finsert_file_contents):
5732 Likewise for BUF_BYTES_MAX.
5734 * image.c: Use ptrdiff_t, not int, for sizes.
5735 (slurp_file): Switch from int to ptrdiff_t.
5737 (slurp_file): Check that file size fits in both size_t (for
5738 malloc) and ptrdiff_t (for sanity and safety).
5740 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5741 if b->modtime has its maximal value.
5743 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5745 Don't assume time_t can fit into int.
5746 * buffer.h (struct buffer.modtime): Now time_t, not int.
5747 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5748 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5750 Minor fixes for signed vs unsigned integers.
5751 * character.h (MAYBE_UNIFY_CHAR):
5752 * charset.c (maybe_unify_char):
5753 * keyboard.c (read_char, reorder_modifiers):
5754 XINT -> XFASTINT, since the integer must be nonnegative.
5755 * ftfont.c (ftfont_spec_pattern):
5756 * keymap.c (access_keymap, silly_event_symbol_error):
5757 XUINT -> XFASTINT, since the integer must be nonnegative.
5758 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5759 since it makes no difference and we prefer signed.
5760 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5761 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5764 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5766 * window.h (Fwindow_frame): Declare.
5768 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5770 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5771 (SPARE_MEMORY): Always define.
5772 (LARGE_REQUEST): Remove.
5773 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5775 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5777 * lisp.h: Move EXFUNS for Fframe_root_window,
5778 Fframe_first_window and Fset_frame_selected_window to window.h.
5780 * window.h: Move EXFUNS for Fframe_root_window,
5781 Fframe_first_window and Fset_frame_selected_window here from
5784 * frame.c (Fwindow_frame, Fframe_first_window)
5785 (Fframe_root_window, Fframe_selected_window)
5786 (Fset_frame_selected_window): Move to window.c.
5787 (Factive_minibuffer_window): Move to minibuf.c.
5788 (Fother_visible_frames_p): New function.
5790 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5792 * window.c (decode_window, decode_any_window): Move up in code.
5793 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5794 (inhibit_frame_unsplittable): Remove unused variable.
5795 (Fwindow_buffer): Move up and rewrite doc-string.
5796 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5797 (Fwindow_prev): New functions.
5798 (Fwindow_frame): Move here from frame.c. Accept any window as
5800 (Fframe_root_window, Fframe_first_window)
5801 (Fframe_selected_window): Move here from frame.c. Accept frame
5802 or arbitrary window as argument. Update doc-strings.
5803 (Fminibuffer_window): Move up in code.
5804 (Fwindow_minibuffer_p): Move up in code and simplify.
5805 (Fset_frame_selected_window): Move here from frame.c.
5807 (Fselected_window, select_window, Fselect_window): Move up in
5808 code. Minor doc-string fixes.
5810 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5812 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5813 Do not assume that spare memory exists; that assumption is valid
5814 only if SYSTEM_MALLOC.
5815 (LARGE_REQUEST): New macro, so that the issue of large requests
5816 is separated from the issue of spare memory.
5818 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5820 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5823 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5825 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5828 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5830 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5832 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5834 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5835 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5837 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5839 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5841 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5843 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5844 (x_clipboard_manager_save): Add return value.
5845 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5847 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5848 Obey Vx_select_enable_clipboard_manager. Catch errors in
5849 x_clipboard_manager_save (Bug#8779).
5850 (Vx_select_enable_clipboard_manager): New variable.
5851 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5853 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5855 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5857 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5859 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5860 in the current matrix if keep_current_p is non-zero.
5862 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5864 * bidi.c (bidi_level_of_next_char): Fix last change.
5866 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5868 Support bidi reordering of text covered by display properties.
5870 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5871 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5872 (bidi_cache_search, bidi_cache_iterator_state)
5873 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5874 (bidi_level_of_next_char, bidi_move_to_visually_next):
5875 Support character positions inside a run of characters covered by a
5877 (bidi_paragraph_init, bidi_resolve_explicit_1)
5878 (bidi_level_of_next_char): Call bidi_fetch_char and
5879 bidi_fetch_char_advance instead of FETCH_CHAR and
5881 (bidi_init_it): Initialize new members.
5882 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5884 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5885 instead of using explicit *_CHAR codes.
5886 (bidi_resolve_explicit, bidi_resolve_weak):
5887 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5888 bidirectional text is supported only in multibyte buffers.
5889 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5890 it to initialize the frame_window_p member of struct bidi_it.
5891 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5892 (bidi_resolve_explicit, bidi_resolve_weak)
5893 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5894 bidi_it->nchars is non-positive.
5895 (bidi_level_of_next_char): Don't try to lookup the cache for the
5896 next/previous character if nothing is cached there yet, or if we
5897 were just reseat()'ed to a new position.
5899 * xdisp.c (set_cursor_from_row): Set start and stop points
5900 according to the row's direction when priming the loop that looks
5901 for the glyph on which to display cursor.
5902 (single_display_spec_intangible_p): Function deleted.
5903 (display_prop_intangible_p): Reimplement to call
5904 handle_display_spec instead of single_display_spec_intangible_p.
5905 Accept 3 additional arguments needed by handle_display_spec.
5906 This fixes incorrect cursor motion across display property with complex
5907 values: lists, `(when COND...)' forms, etc.
5908 (single_display_spec_string_p): Support property values that are
5909 lists with the argument STRING its top-level element.
5910 (display_prop_string_p): Fix the condition for processing a
5911 property that is a list to be consistent with handle_display_spec.
5912 (handle_display_spec): New function, refactored from the
5913 last portion of handle_display_prop.
5914 (compute_display_string_pos): Accept additional argument
5915 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5916 value of a `display' property is a "replacing spec".
5917 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5918 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5919 the display property, but just return a value indicating whether
5920 the display property will replace the characters it covers.
5921 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5922 frame_window_p members of struct bidi_it.
5923 (compute_display_string_pos, compute_display_string_end):
5925 (push_it): Accept second argument POSITION, where pop_it should
5926 jump to continue iteration.
5927 (reseat_1): Initialize bidi_it.disp_pos.
5929 * keyboard.c (adjust_point_for_property): Adjust the call to
5930 display_prop_intangible_p to its new signature.
5932 * dispextern.h (struct bidi_it): New member frame_window_p.
5933 (bidi_init_it): Update prototypes.
5934 (display_prop_intangible_p): Update prototype.
5935 (compute_display_string_pos, compute_display_string_end):
5937 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5940 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5942 Malloc failure behavior now depends on size of allocation.
5943 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5944 * lisp.h: Change signatures accordingly.
5945 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5946 All callers changed. (Bug#8762)
5948 * gnutls.c: Use Emacs's memory allocators.
5949 Without this change, the gnutls library would invoke malloc etc.
5950 directly, which causes problems on non-SYNC_INPUT hosts, and which
5951 runs afoul of improving memory_full behavior. (Bug#8761)
5952 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5953 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5954 xfree instead of the default malloc, realloc, free.
5955 (Fgnutls_boot): No need to check for memory allocation failure,
5956 since xmalloc does that for us.
5958 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5959 * category.c (hash_get_category_set):
5960 * ccl.c (ccl_driver):
5961 * charset.c (Fdefine_charset_internal):
5962 * charset.h (struct charset.hash_index):
5963 * composite.c (get_composition_id, gstring_lookup_cache)
5964 (composition_gstring_put_cache):
5965 * composite.h (struct composition.hash_index):
5966 * dispextern.h (struct image.hash):
5967 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5968 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5969 (hashfn_equal, hashfn_user_defined, make_hash_table)
5970 (maybe_resize_hash_table, hash_lookup, hash_put)
5971 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5972 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5973 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5974 * image.c (make_image, search_image_cache, lookup_image)
5975 (xpm_put_color_table_h):
5976 * lisp.h (struct Lisp_Hash_Table):
5977 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5978 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5979 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5980 * alloc.c (allocate_vectorlike):
5981 Check for overflow in vector size calculations.
5982 * ccl.c (ccl_driver):
5983 Check for overflow when converting EMACS_INT to int.
5984 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5985 need to be updated by these changes.
5986 * fns.c (make_hash_table, maybe_resize_hash_table):
5987 Check for integer overflow with large hash tables.
5988 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5989 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5990 (SXHASH_REDUCE): New macro.
5991 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5992 Use it instead of discarding useful hash info with large hash values.
5993 (sxhash_float): New function.
5994 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5995 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5996 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5997 Rewrite to use FIXNUM_BITS, as this simplifies things.
5998 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5999 Adjust signatures to match updated version of code.
6000 (consing_since_gc): Now EMACS_INT, since a single hash table can
6001 use more than INT_MAX bytes.
6003 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6005 Make it possible to build with GCC-4.6+ -O2 -flto.
6007 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6009 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6011 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6012 Call minibuffer-inactive-mode.
6014 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6016 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6017 Update dependencies.
6019 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6021 * data.c (init_data): Remove code for UTS, this system is not
6024 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6026 Don't force ./temacs to start in terminal mode.
6028 * frame.c (make_initial_frame): Initialize faces in all cases, not
6029 only when CANNOT_DUMP is defined.
6030 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6032 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6034 * dispnew.c (add_window_display_history): Use const for the string
6035 pointer. Remove declaration, not needed.
6037 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6039 Use 'inline', not 'INLINE'.
6040 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6041 * alloc.c, fontset.c (INLINE): Remove.
6042 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6043 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6044 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6045 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6046 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6048 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6050 Make it possible to run ./temacs.
6052 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6053 syms_of_callproc does the same thing. Remove test for
6054 "initialized", do it in the caller.
6055 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6057 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6059 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6060 (read_minibuf): Use get_minibuffer.
6061 (syms_of_minibuf): Use DEFSYM.
6062 (Qmetadata): New var.
6063 * data.c (Qbuffer): Don't make it static.
6064 (syms_of_data): Use DEFSYM.
6066 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6068 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6069 (CCL_CODE_MIN): New macro.
6071 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6073 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6075 * eval.c (Qdebug): Now static.
6076 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6077 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6078 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6080 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6082 * image.c: Various fixes to ImageMagick code comments.
6083 (Fimagemagick_types): Doc fix.
6085 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6087 Minor fixes prompted by GCC 4.6.0 warnings.
6089 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6091 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6092 (x_clipboard_manager_save_all): Move extern decl to ...
6093 * xterm.h: ... here, so that it can be checked for consistency.
6095 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6097 * xselect.c (x_clipboard_manager_save_frame)
6098 (x_clipboard_manager_save_all): New functions.
6099 (Fx_clipboard_manager_save): Lisp function deleted.
6101 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6102 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6104 * xterm.h: Update prototype.
6106 2011-05-28 William Xu <william.xwl@gmail.com>
6108 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6111 2011-05-28 Jim Meyering <meyering@redhat.com>
6113 Avoid a sign-extension bug in crypto_hash_function.
6114 * fns.c (to_uchar): Define.
6115 (crypto_hash_function): Use it to convert some newly-signed
6116 variables to unsigned, to avoid sign-extension bugs. For example,
6117 without this change, (md5 "truc") would evaluate to
6118 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6119 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6120 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6122 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6124 Integer overflow fixes.
6126 * dbusbind.c: Serial number integer overflow fixes.
6127 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6128 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6129 to hold a serial number that is too large for a fixnum.
6130 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6131 Check for serial numbers out of range. Decode any serial number
6132 that was so large that it became a float. (Bug#8722)
6134 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6135 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6136 Use XFASTINT rather than XUINT when numbers are nonnegative.
6137 (xd_append_arg, Fdbus_method_return_internal):
6138 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6139 arguments, check that Lisp number is nonnegative, rather than
6140 silently wrapping negative numbers around. (Bug#8722)
6141 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6144 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6146 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6148 ccl: Add integer overflow checks.
6149 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6150 (IN_INT_RANGE): New macros.
6151 (ccl_driver): Use them to check for integer overflow when
6152 decoding a CCL program. Many of the new checks are whether XINT (x)
6153 fits in int; it doesn't always, on 64-bit hosts. The new version
6154 doesn't catch all possible integer overflows, but it's an
6155 improvement. (Bug#8719)
6157 * alloc.c (make_event_array): Use XINT, not XUINT.
6158 There's no need for unsigned here.
6160 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6161 This follows up to the 2011-05-06 change that substituted uintptr_t
6162 for EMACS_INT. This case wasn't caught back then.
6164 Rework Fformat to avoid integer overflow issues.
6165 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6166 now (part of C89). Include <verify.h>.
6167 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6168 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6169 (Fformat): Avoid the prepass trying to compute sizes; it was only
6170 approximate and thus did not catch overflow reliably. Instead, walk
6171 through the format just once, formatting and computing sizes as we go,
6172 checking for integer overflow at every step, and allocating a larger
6173 buffer as needed. Keep track separately whether the format is
6174 multibyte. Keep only the most-recently calculated precision, rather
6175 than them all. Record whether each argument has been converted to
6176 string. Use EMACS_INT, not int, for byte and char and arg counts.
6177 Support field widths and precisions larger than INT_MAX. Avoid
6178 sprintf's undefined behavior with conversion specifications such as %#d
6179 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6180 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6181 formatting out-of-range floating point numbers with int
6184 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6186 * data.c: Avoid integer truncation in expressions involving floats.
6187 * data.c: Include <intprops.h>.
6188 (arith_driver): When there's an integer overflow in an expression
6189 involving floating point, convert the integers to floating point
6190 so that the resulting value does not suffer from catastrophic
6191 integer truncation. For example, on a 64-bit host (* 4
6192 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6193 Do not rely on undefined behavior after integer overflow.
6195 merge count_size_as_multibyte, parse_str_to_multibyte
6196 * character.c, character.h (count_size_as_multibyte):
6197 Rename from parse_str_to_multibyte; all uses changed.
6198 Check for integer overflow.
6199 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6200 since it's now a duplicate of the other. This is more of
6201 a character than a buffer op, so better that it's in character.c.
6202 * fns.c, print.c: Adjust to above changes.
6204 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6206 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6208 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6210 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6211 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6212 (x_clipboard_manager_save): Now static.
6213 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6215 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6216 (crypto_hash_function): Now static.
6217 Fix pointer signedness problems. Avoid unnecessary initializations.
6219 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6221 * termhooks.h (Vselection_alist): Make it terminal-local.
6223 * terminal.c (create_terminal): Initialize it.
6225 * xselect.c: Support for clipboard managers.
6226 (Vselection_alist): Move to termhooks.h as terminal-local var.
6227 (LOCAL_SELECTION): New macro.
6228 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6229 (symbol_to_x_atom): Remove gratuitous arg.
6230 (x_handle_selection_request, lisp_data_to_selection_data)
6231 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6232 (x_own_selection, x_get_local_selection, x_convert_selection):
6233 New arg, specifying work frame. Use terminal-local Vselection_alist.
6234 (some_frame_on_display): Delete unused function.
6235 (Fx_own_selection_internal, Fx_get_selection_internal)
6236 (Fx_disown_selection_internal, Fx_selection_owner_p)
6237 (Fx_selection_exists_p): New optional frame arg.
6238 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6239 (x_handle_selection_clear): Don't treat other terminals with the
6240 same keyboard specially. Use the terminal-local Vselection_alist.
6241 (x_clear_frame_selections): Use Frun_hook_with_args.
6243 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6245 * xterm.h: Add support for those atoms.
6247 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6249 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6250 (converted_selections, conversion_fail_tag): New global variables.
6251 (x_selection_request_lisp_error): Free the above.
6252 (x_get_local_selection): Remove unnecessary code.
6253 (x_reply_selection_request): Args changed; handle arbitrary array
6254 of converted selections stored in converted_selections.
6255 Separate the XChangeProperty and SelectionNotify steps.
6256 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6257 (x_convert_selection): New function.
6258 (x_handle_selection_event): Simplify.
6259 (x_get_foreign_selection): Don't ignore incoming requests while
6260 waiting for an answer; this will fail when we implement
6261 SAVE_TARGETS, and seems unnecessary anyway.
6262 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6263 (Vx_sent_selection_functions): Doc fix.
6265 2011-05-26 Leo Liu <sdl.web@gmail.com>
6267 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6269 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6271 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6273 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6274 for fringe update if it has periodic bitmap.
6275 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6276 and fringe_bitmap_periodic_p.
6278 * fringe.c (get_fringe_bitmap_data): New function.
6279 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6280 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6281 row. Mark glyph row for fringe update if periodicity changed.
6283 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6284 for fringe update unless it has periodic bitmap.
6286 2011-05-25 Kenichi Handa <handa@m17n.org>
6288 * xdisp.c (get_next_display_element): Set correct it->face_id for
6289 a static composition.
6291 2011-05-24 Leo Liu <sdl.web@gmail.com>
6294 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6296 * fns.c (crypto_hash_function, Fsha1): New function.
6297 (Fmd5): Use crypto_hash_function.
6298 (syms_of_fns): Add Ssha1.
6300 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6302 * gnutls.c: Remove unused macros.
6303 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6304 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6305 Remove macros that are defined and never used.
6306 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6308 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6310 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6311 (Fx_get_selection_internal): Minor cleanup.
6312 (Fx_own_selection_internal): Rename arguments for consistency with
6315 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6317 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6319 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6321 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6323 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6325 * dispnew.c (scrolling_window): Don't exclude the case that the
6326 last enabled row in the desired matrix touches the bottom boundary.
6328 2011-05-21 Glenn Morris <rgm@gnu.org>
6330 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6331 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6332 and add some more files.
6334 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6336 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6337 report_file_error introduced by the change from 2011-05-07.
6339 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6341 * systime.h (Time): Define only if emacs is defined.
6342 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6343 where the include path doesn't have X11/X.h by default. See
6344 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6346 2011-05-20 Kenichi Handa <handa@m17n.org>
6348 * composite.c (find_automatic_composition): Fix previous change.
6350 2011-05-20 Glenn Morris <rgm@gnu.org>
6352 * lisp.mk: New file, split from Makefile.in.
6353 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6354 (shortlisp): Remove.
6355 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6357 2011-05-19 Glenn Morris <rgm@gnu.org>
6359 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6360 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6361 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6362 (lisp): Set the order to that of loadup.el.
6363 (shortlisp): Make it a copy of $lisp.
6364 (SOME_MACHINE_LISP): Remove.
6365 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6366 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6368 2011-05-18 Kenichi Handa <handa@m17n.org>
6370 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6371 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6372 (find_automatic_composition): Mostly rewrite for efficiency.
6374 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6376 * makefile.w32-in: Update dependencies.
6378 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6380 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6381 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6383 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6385 Fix some integer overflow issues, such as string length overflow.
6387 * insdel.c (count_size_as_multibyte): Check for string overflow.
6389 * character.c (lisp_string_width): Check for string overflow.
6390 Use EMACS_INT, not int, for string indexes and lengths; in
6391 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6392 the resulting string length overflows an EMACS_INT; instead,
6393 report a string overflow if no precision given. When checking for
6394 precision exhaustion, use a check that cannot possibly have
6395 integer overflow. (Bug#8675)
6396 * character.h (lisp_string_width): Adjust to new signature.
6398 * alloc.c (string_overflow): New function.
6399 (Fmake_string): Use it. This doesn't change behavior, but saves
6400 a few bytes and will simplify future changes.
6401 * character.c (string_escape_byte8): Likewise.
6402 * lisp.h (string_overflow): New decl.
6404 Fixups, following up to the user-interface timestamp change.
6405 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6406 for UI timestamps, instead of unsigned long.
6407 * msdos.c (mouse_get_pos): Likewise.
6408 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6409 * w32gui.h (Time): Define by including "systime.h" rather than by
6410 declaring it ourselves. (Bug#8664)
6412 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6413 * image.c (clear_image_cache): Likewise.
6415 * term.c (term_mouse_position): Don't assume time_t wraparound.
6417 Be more systematic about user-interface timestamps.
6418 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6419 and sometimes 'EMACS_UINT', to represent these timestamps.
6420 This change causes it to use 'Time' uniformly, as that's what X uses.
6421 This makes the code easier to follow, and makes it easier to catch
6422 integer overflow bugs such as Bug#8664.
6423 * frame.c (Fmouse_position, Fmouse_pixel_position):
6424 Use Time, not unsigned long, for user-interface timestamps.
6425 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6426 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6427 * keyboard.h (last_event_timestamp): Likewise.
6428 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6429 * menu.h (xmenu_show): Likewise.
6430 * term.c (term_mouse_position): Likewise.
6431 * termhooks.h (struct input_event.timestamp): Likewise.
6432 (struct terminal.mouse_position_hook): Likewise.
6433 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6434 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6435 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6436 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6438 * menu.h, termhooks.h: Include "systime.h", for Time.
6440 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6441 Don't assume that the difference between two unsigned long values
6442 can fit into an integer. At this point, we know button_down_time
6443 <= event->timestamp, so the difference must be nonnegative, so
6444 there's no need to cast the result if double-click-time is
6445 nonnegative, as it should be; check that it's nonnegative, just in
6446 case. This bug is triggered when events are more than 2**31 ms
6447 apart (about 25 days). (Bug#8664)
6449 * xselect.c (last_event_timestamp): Remove duplicate decl.
6450 (x_own_selection): Remove needless cast to unsigned long.
6452 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6453 that always fit in int. Use a sentinel instead of a counter, to
6454 avoid a temp and to allay GCC's concerns about possible int overflow.
6455 * frame.h (struct frame): Use int for menu_bar_items_used
6456 instead of EMACS_INT, since it always fits in int.
6458 * menu.c (grow_menu_items): Check for int overflow.
6460 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6462 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6463 Before, the code was not consistent. These values cannot exceed
6464 2**31 - 1 so there's no need to make them unsigned.
6465 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6466 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6467 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6469 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6471 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6472 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6473 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6474 presumably because the widths might not match.
6476 * window.c (size_window): Avoid needless test at loop start.
6478 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6480 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6482 2011-05-12 Drew Adams <drew.adams@oracle.com>
6484 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6486 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6488 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6489 `width' to `bar_area_x' and `bar_area_width', respectively.
6490 (x_scroll_run): Take account of fringe background extension.
6492 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6493 Rename local vars `left' and `width' to `bar_area_x' and
6494 `bar_area_width', respectively.
6495 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6496 background extension.
6498 2011-05-10 Jim Meyering <meyering@redhat.com>
6500 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6502 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6504 * image.c (Finit_image_library): Return t for built-in image types,
6505 like pbm and xbm. (Bug#8640)
6507 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6509 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6511 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6513 * w32console.c (Fset_screen_color): Doc fix.
6514 (Fget_screen_color): New function.
6515 (syms_of_ntterm): Defsubr it.
6517 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6518 unlink the temporary file if Fcall_process didn't create it in the
6520 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6521 child process will be redirected to a file specified with `:file'.
6522 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6523 cue to call_process_cleanup not to close that handle.
6525 2011-05-07 Ben Key <bkey76@gmail.com>
6527 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6528 one of two shell specific rules, either bootstrap-temacs-CMD or
6529 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6530 to the previous implementation of the bootstrap-temacs rule.
6531 The bootstrap-temacs-CMD rule is similar to the previous
6532 implementation of the bootstrap-temacs rule except that it
6533 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6536 These changes, along with some changes to nt/configure.bat,
6537 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6538 earlier fix to add support for --cflags and --ldflags options
6539 that include quotes so that it works whether make uses cmd or
6542 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6544 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6545 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6547 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6548 a string. Handle both cases.
6549 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6550 (Fdbus_register_method): Use Qinvalid_function.
6552 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6554 * makefile.w32-in: Update dependencies.
6555 (LISP_H): Add inttypes.h and stdin.h.
6556 (PROCESS_H): Add unistd.h.
6558 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6560 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6561 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6563 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6565 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6567 * term.c (vfatal): Remove stray call to va_end.
6568 It's not needed and the C Standard doesn't allow it here anyway.
6570 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6571 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6573 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6576 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6578 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6580 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6582 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6584 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6586 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6587 * charset.c (Fdefine_charset_internal): Don't initialize
6588 charset.code_space[15]. The value was garbage, on hosts with
6589 32-bit int (Bug#8600).
6591 * lread.c (read_integer): Be more consistent with string-to-number.
6592 Use string_to_number to do the actual conversion; this avoids
6593 rounding errors and fixes some other screwups. Without this fix,
6594 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6595 (digit_to_number): Move earlier, for benefit of read_integer.
6596 Return -1 if the digit is out of range for the base, -2 if it is
6597 not a digit in any supported base. (Bug#8602)
6599 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6601 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6602 to match comment at start of function. This also removes a
6603 GCC warning about overflow in a 32+64-bit port.
6605 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6607 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6608 Reported by Stefan Monnier in
6609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6610 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6611 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6613 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6614 (EMACS_UINTPTR): Likewise, with uintptr_t.
6616 * lisp.h: Prefer 64-bit EMACS_INT if available.
6617 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6618 on 32-bit hosts that have 64-bit int, so that they can access
6620 However, temporarily disable this change unless the temporary
6621 symbol WIDE_EMACS_INT is defined.
6623 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6625 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6626 This removes an assumption that EMACS_INT and long are the same
6627 width as pointers. The assumption is true for Emacs porting targets
6628 now, but we want to make other targets possible.
6629 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6630 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6631 In the rest of the code, change types of integers that hold casted
6632 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6633 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6634 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6635 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6636 No need to cast type when ORing.
6637 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6638 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6639 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6640 assume EMACS_INT is the same width as char *.
6641 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6642 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6643 Remove no-longer-needed casts.
6644 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6645 (xg_tool_bar_help_callback, xg_make_tool_item):
6646 Use EMACS_INTPTR to hold an integer
6647 that will be cast to void *; this can avoid a GCC warning
6648 if EMACS_INT is not the same width as void *.
6649 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6650 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6651 (current_message_1, set_message_1):
6652 Use a local to convert to proper width without a cast.
6653 * xmenu.c (dialog_selection_callback): Likewise.
6655 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6656 Also, don't assume VALBITS / RAND_BITS is less than 5,
6657 and don't rely on undefined behavior when shifting a 1 left into
6659 * lisp.h (get_random): Change signature to match.
6661 * lread.c (hash_string): Use size_t, not int, for hash computation.
6662 Normally we prefer signed values; but hashing is special, because
6663 it's better to use unsigned division on hash table sizes so that
6664 the remainder is nonnegative. Also, size_t is the natural width
6665 for hashing into memory. The previous code used 'int', which doesn't
6666 retain enough info to hash well into very large tables.
6667 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6669 * dbusbind.c: Don't possibly lose pointer info when converting.
6670 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6671 Use XPNTR rather than XHASH, so that the high-order bits of
6672 the pointer aren't lost when converting through void *.
6674 * eval.c (Fautoload): Don't double-shift a pointer.
6676 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6678 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6680 * gnutls.c (DEF_GNUTLS_FN):
6681 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6683 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6685 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6688 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6690 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6691 New version that can reserve upto 2GB of heap space.
6693 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6695 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6697 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6699 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6700 `gnutls_certificate_set_x509_key_file'.
6702 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6704 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6705 Update dependencies.
6707 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6709 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6710 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6711 Remove unused parameter `fildes'.
6712 * process.c (read_process_output, send_process): Don't pass it.
6714 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6716 Fix previous change: the library cache is defined in w32.c.
6717 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6718 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6720 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6722 Implement dynamic loading of GnuTLS on Windows.
6724 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6725 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6726 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6729 * gnutls.c (Qgnutls_dll): Define.
6730 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6731 (gnutls_*): Declare function pointers.
6732 (init_gnutls_functions): New function to initialize function pointers.
6733 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6734 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6735 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6736 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6737 (emacs_gnutls_write, emacs_gnutls_read)
6738 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6739 (Fgnutls_available_p): New function.
6740 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6741 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6742 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6744 * image.c: Include w32.h.
6745 (Vimage_type_cache): Delete.
6746 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6747 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6748 (w32_delayed_load): Move to w32.c.
6750 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6752 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6753 (w32_delayed_load): Move from image.c. When loading a library, record
6754 its filename in the :loaded-from property of the library id.
6755 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6756 Initialize and staticpro them.
6757 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6759 * process.c: Include lisp.h before w32.h, not after.
6760 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6761 instead of gnutls_record_check_pending.
6763 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6765 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6767 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6768 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6771 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6773 * xterm.c (x_set_frame_alpha): Do not set property on anything
6774 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6776 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6778 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6780 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6782 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6783 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6784 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6785 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6786 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6787 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6788 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6789 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6790 (Qgnutls_bootprop_callbacks_verify): Make static.
6792 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6794 * callproc.c: Indentation fixup.
6796 * sysdep.c (wait_for_termination_1): Make static.
6797 (wait_for_termination, interruptible_wait_for_termination):
6798 Move after wait_for_termination_1.
6800 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6802 * sysdep.c (interruptible_wait_for_termination): New function
6803 which is like wait_for_termination, but allows keyboard
6806 * callproc.c (Fcall_process): Add (:file "file") as an option for
6808 (Fcall_process_region): Ditto.
6810 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6812 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6813 rather than `XVECTOR (FOO)->size'.
6815 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6816 inttypes.h, as a gnulib replacement is used if it not available in
6819 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6821 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6822 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6823 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6825 * coding.c (coding_alloc_by_realloc): Error out if destination
6826 will grow beyond MOST_POSITIVE_FIXNUM.
6827 (decode_coding_emacs_mule): Abort if there isn't enough place in
6828 charbuf for the composition carryover bytes. Reserve an extra
6829 space for up to 2 characters produced in a loop.
6830 (decode_coding_iso_2022): Abort if there isn't enough place in
6831 charbuf for the composition carryover bytes.
6833 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6835 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6836 aborting when %lld or %lll format is passed.
6837 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6838 %llo or %llx format is passed. (Bug#8545)
6840 * window.c (window_scroll_line_based): Use a marker instead of
6841 simple variables to record original value of point. (Bug#7952)
6843 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6844 produced by %s or %c overflows available buffer space. (Bug#8545)
6846 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6848 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6849 (SIZE_MAX): Move defn after all includes, as they might #define it.
6851 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6853 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6855 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6857 * keyboard.c (Qdelayed_warnings_hook): Define.
6858 (command_loop_1): Run `delayed-warnings-hook'
6859 if Vdelayed_warnings_list is non-nil.
6860 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6861 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6863 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6865 * doprnt.c (doprnt): Don't return value smaller than the buffer
6866 size if the message was truncated. (Bug#8545).
6868 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6870 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6871 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6873 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6875 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6877 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6879 * makefile.w32-in: Update dependencies.
6881 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6883 Improve `doprnt' and its usage. (Bug#8545)
6884 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6885 `format_end'. Remove support for %l as a conversion specifier.
6886 Don't use xrealloc. Improve diagnostics when the %l size modifier
6887 is used. Update the commentary.
6889 * eval.c (verror): Simplify calculation of size_t.
6891 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6894 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6896 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6899 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6901 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6902 This makes this file independent of the recent pseudovector change.
6904 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6906 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6908 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6909 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6910 Remove unused local.
6911 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6913 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6914 GCC 4.6.0 optimizes based on type-based alias analysis.
6915 For example, if b is of type struct buffer * and v of type struct
6916 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6917 != &v->size, and therefore "v->size = 1; b->size = 2; return
6918 v->size;" must therefore return 1. This assumption is incorrect
6919 for Emacs, since it type-puns struct Lisp_Vector * with many other
6920 types. To fix this problem, this patch adds a new type struct
6921 vectorlike_header that documents the constraints on layout of vectors
6922 and pseudovectors, and helps optimizing compilers not get fooled
6923 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6924 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6925 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6927 (XSETPVECTYPE): Rewrite in terms of new macro.
6928 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6929 This is a bit clearer, and further avoids the possibility of
6930 undesirable aliasing.
6931 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6932 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6933 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6934 since Lisp_Subr is a special case (no "next" field).
6935 (ASIZE): Now uses header.size rather than size.
6936 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6937 to avoid the hassle of writing XVECTOR (foo)->header.size.
6938 (struct vectorlike_header): New type.
6939 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6940 object, to help avoid aliasing.
6941 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6942 (SUBRP): Likewise, since Lisp_Subr is a special case.
6943 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6944 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6945 (struct Lisp_Hash_Table): Combine first two members into a single
6946 struct vectorlike_header member. All uses of "size" and "next" members
6947 changed to be "header.size" and "header.next".
6948 * buffer.h (struct buffer): Likewise.
6949 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6950 * frame.h (struct frame): Likewise.
6951 * process.h (struct Lisp_Process): Likewise.
6952 * termhooks.h (struct terminal): Likewise.
6953 * window.c (struct save_window_data, struct saved_window): Likewise.
6954 * window.h (struct window): Likewise.
6955 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6956 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6957 * buffer.c (init_buffer_once): Likewise.
6958 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6960 * process.c (Fformat_network_address): Use local var for size,
6963 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6965 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6966 * data.c (atof): Remove decl; no longer used or needed.
6967 (digit_to_number): Move to lread.c.
6968 (Fstring_to_number): Use new string_to_number function, to be
6969 consistent with how the Lisp reader treats infinities and NaNs.
6970 Do not assume that floating-point numbers represent EMACS_INT
6971 without losing information; this is not true on most 64-bit hosts.
6972 Avoid double-rounding errors, by insisting on integers when
6973 parsing non-base-10 numbers, as the documentation specifies.
6974 * lisp.h (string_to_number): New decl, replacing ...
6975 (isfloat_string): Remove.
6976 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6977 (read1): Do not accept +. and -. as integers; this
6978 appears to have been a coding error. Similarly, do not accept
6979 strings like +-1e0 as floating point numbers. Do not report
6980 overflow for integer overflows unless the base is not 10 which
6981 means we have no simple and reliable way to continue.
6982 Break out the floating-point parsing into a new
6983 function string_to_number, so that Fstring_to_number parses
6984 floating point numbers consistently with the Lisp reader.
6985 (digit_to_number): Move here from data.c. Make it static inline.
6986 (E_CHAR, EXP_INT): Remove, replacing with ...
6987 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6988 (string_to_number): New function, replacing isfloat_string.
6989 This function checks for valid syntax and produces the resulting
6990 Lisp float number too. Rework it so that string-to-number
6991 no longer mishandles examples like "1.0e+". Use strtoumax,
6992 so that overflow for non-base-10 numbers is reported only when
6993 there's no portable and simple way to convert to floating point.
6995 * textprop.c (set_text_properties_1): Rewrite for clarity,
6996 and to avoid GCC warning about integer overflow.
6998 * intervals.h (struct interval): Use EMACS_INT for members
6999 where EMACS_UINT might cause problems. See
7000 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7001 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7002 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7004 (offset_intervals): Tell GCC not to worry about length overflow
7005 when negating a negative length.
7007 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7008 (overrun_check_free): Likewise.
7010 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7011 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7014 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7015 (gnutls_make_error): Rename local to avoid shadowing.
7016 (gnutls_emacs_global_deinit): ifdef out; not used.
7017 (Fgnutls_boot): Use const for pointer to readonly storage.
7018 Comment out unused local. Fix pointer signedness problems.
7020 * lread.c (openp): Don't stuff size_t into an 'int'.
7021 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7022 about possible signed overflow.
7024 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7025 (GDK_KEY_g): Don't define if already defined.
7026 (xg_prepare_tooltip): Avoid pointer signedness problem.
7027 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7029 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7030 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7032 * xfns.c (Fx_window_property): Simplify a bit,
7033 to make a bit faster and to avoid GCC 4.6.0 warning.
7034 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7036 * fns.c (internal_equal): Don't assume size_t fits in int.
7038 * alloc.c (compact_small_strings): Tighten assertion a little.
7040 Replace pEd with more-general pI, and fix some printf arg casts.
7041 * lisp.h (pI): New macro, generalizing old pEd macro to other
7042 conversion specifiers. For example, use "...%"pI"d..." rather
7043 than "...%"pEd"...".
7044 (pEd): Remove. All uses replaced with similar uses of pI.
7045 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7046 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7047 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7048 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7049 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7050 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7051 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7053 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7054 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7055 * print.c (safe_debug_print, print_object): Likewise.
7056 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7058 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7059 avoiding the 0 flag, which is not portable.
7060 * process.c (Fmake_network_process): Use pI to avoid cast.
7061 * region-cache.c (pp_cache): Likewise.
7062 * xdisp.c (decode_mode_spec): Likewise.
7063 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7064 behavior on 64-bit hosts with printf arg.
7065 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7066 (x_stop_queuing_selection_requests): Likewise.
7067 (x_get_window_property): Don't truncate byte count to an 'int'
7070 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7071 here, since it parses constructs like leading '-' and spaces,
7072 which are not wanted; and it overflows with large numbers.
7073 Instead, simply match F[0-9]+, which is what is wanted anyway.
7075 * alloc.c: Remove unportable assumptions about struct layout.
7076 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7077 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7078 (allocate_vectorlike, make_pure_vector): Use the new macros,
7079 plus offsetof, to remove unportable assumptions about struct layout.
7080 These assumptions hold on all porting targets that I know of, but
7081 they are not guaranteed, they're easy to remove, and removing them
7082 makes further changes easier.
7084 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7085 This doesn't fix a bug but makes the code clearer.
7086 (string_overrun_cookie): Now const. Use initializers that
7087 don't formally overflow signed char, to avoid warnings.
7088 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7089 can cause Emacs to crash when string overrun checking is enabled.
7090 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7091 multiple of sizeof (EMACS_INT); it need not be, if
7092 alignof(EMACS_INT) < sizeof (EMACS_INT).
7093 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7095 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7097 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7099 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7101 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7102 supposed to be handshaking. (Bug#8556)
7103 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7105 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7107 * lisp.h (Qdebug): List symbol.
7108 * eval.c (Qdebug): Restore global linkage.
7109 * keyboard.c (debug-on-event): New variable.
7110 (handle_user_signal): Break into debugger when debug-on-event
7111 matches the current signal symbol.
7113 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7115 * alloc.c (check_sblock, check_string_bytes)
7116 (check_string_free_list): Convert to standard C.
7118 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7120 * w32.c (emacs_gnutls_push): Fix typo.
7122 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7124 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7125 "cast to pointer from integer of different size".
7127 Improve doprnt and its use in verror. (Bug#8545)
7128 * doprnt.c (doprnt): Document the set of format control sequences
7129 supported by the function. Use SAFE_ALLOCA instead of always
7132 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7133 is one byte too soon. Don't use xrealloc; instead xfree and
7136 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7138 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7141 * gnutls.c: Renamed global_initialized to
7142 gnutls_global_initialized. Added internals for the
7143 :verify-hostname-error, :verify-error, and :verify-flags
7144 parameters of `gnutls-boot' and documented those parameters in the
7145 docstring. Start callback support.
7146 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7147 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7148 on error. Return error code.
7149 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7150 (emacs_gnutls_read): Likewise.
7151 (Fgnutls_boot): Return handshake error code.
7152 (emacs_gnutls_handle_error): New function.
7153 (wsaerror_to_errno): Likewise.
7155 * w32.h (emacs_gnutls_pull): Add prototype.
7156 (emacs_gnutls_push): Likewise.
7158 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7159 (emacs_gnutls_push): Likewise.
7161 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7163 * process.c (wait_reading_process_output): Check if GnuTLS
7164 buffered some data internally if no FDs are set for TLS
7167 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7168 (LIBS): Link to USER_LIBS.
7169 ($(BLD)/gnutls.$(0)): New target.
7171 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7173 * xdisp.c (handle_single_display_spec): Rename the
7174 display_replaced_before_p argument into display_replaced_p, to
7175 make it consistent with the commentary. Fix typos in the
7178 * textprop.c (syms_of_textprop): Remove dead code.
7179 (copy_text_properties): Delete obsolete commentary about an
7180 interface that was deleted long ago. Fix typos in the description
7183 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7184 to changes in oldXMenu/XMenu.h from 2011-04-16.
7185 <menu_help_message, prev_menu_help_message>: Constify.
7186 (IT_menu_make_room): menu->help_text is now `const char **';
7189 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7190 to changes in oldXMenu/XMenu.h from 2011-04-16.
7191 (struct XMenu): Declare `help_text' `const char **'.
7193 * xfaces.c <Qunspecified>: Make extern again.
7195 * syntax.c: Include sys/types.h before including regex.h, as
7198 * doc.c (get_doc_string): Improve the format passed to `error'.
7200 * doprnt.c (doprnt): Improve commentary.
7202 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7204 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7207 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7208 changes in globals.h immediately force recompilation.
7209 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7210 $(CURDIR)/s/ms-w32.h.
7211 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7213 * character.c (Fchar_direction): Function deleted.
7214 (syms_of_character): Don't defsubr it.
7215 <char-direction-table>: Deleted.
7217 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7219 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7220 * doprnt.c: Include limits.h.
7221 (SIZE_MAX): New macro.
7222 (doprnt): Return a size_t value. 2nd arg is now size_t.
7223 Many local variables are now size_t instead of int or unsigned.
7224 Improve overflow protection. Support `l' modifier for integer
7225 conversions. Support %l conversion. Don't assume an EMACS_INT
7226 argument for integer conversions and for %c.
7228 * lisp.h (doprnt): Restore prototype.
7230 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7233 * Makefile.in (base_obj): Add back doprnt.o.
7235 * deps.mk (doprnt.o): Add back prerequisites.
7236 (callint.o): Depend on character.h.
7238 * eval.c (internal_lisp_condition_case): Include the handler
7239 representation in the error message.
7240 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7241 when breaking from the loop.
7243 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7245 * callint.c (Fcall_interactively): When displaying error message
7246 about invalid control letter, pass the character's codepoint, not
7247 a pointer to its multibyte form. Improve display of the character
7248 in octal and display also its hex code.
7250 * character.c (char_string): Use %x to display the (unsigned)
7251 codepoint of an invalid character, to avoid displaying a bogus
7254 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7255 `error', not SYMBOL_NAME itself.
7257 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7258 character arguments to `error'.
7260 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7261 to `error' in error message about FINAL_CHAR argument. Make sure
7262 FINAL_CHAR is a character, and use %c when it is passed as
7263 argument to `error'.
7265 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7267 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7269 * w32.c: Include <time.h>.
7270 (sys_localtime): New function.
7272 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7274 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7276 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7278 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7280 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7283 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7285 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7286 gl_state.e_property when gl_state.object is Qt.
7288 * insdel.c (make_gap_larger): Remove limitation of buffer size
7291 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7293 * xdisp.c (lookup_glyphless_char_display)
7294 (produce_glyphless_glyph): Handle cons cell entry in
7295 glyphless-char-display.
7296 (Vglyphless_char_display): Document it.
7298 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7299 glyphless-char-display.
7301 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7303 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7305 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7307 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7308 definition for no-X builds.
7310 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7312 Static checks with GCC 4.6.0 and non-default toolkits.
7314 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7316 * process.c (keyboard_bit_set): Define only if SIGIO.
7317 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7318 (send_process): Repair possible setjmp clobbering.
7320 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7322 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7324 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7326 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7327 Define only if needed.
7329 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7330 by pacifying GCC about it. Maybe it's time to retire it?
7331 * xfaces.c (USG, __TIMEVAL__): Likewise.
7333 * dispextern.h (struct redisplay_interface): Rename param
7335 * termhooks.h (struct terminal): Likewise.
7336 * xterm.c (xembed_send_message): Likewise.
7338 * insdel.c (make_gap_smaller): Define only if
7339 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7341 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7344 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7345 so that we aren't warned about unused symbols.
7347 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7349 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7351 * xfns.c (x_real_positions): Mark locals as initialized.
7353 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7355 * xterm.c: Fix problems found by static analysis with other toolkits.
7356 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7357 (x_dispatch_event): Declare static if USE_GTK, and
7358 define if USE_GTK || USE_X_TOOLKIT.
7359 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7360 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7361 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7362 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7364 * xmenu.c (menu_help_callback): Pointer type fixes.
7365 Use const pointers when pointing at readonly data. Avoid pointer
7367 (FALSE): Remove unused macro.
7368 (update_frame_menubar): Remove unused decl.
7370 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7372 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7373 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7374 (single_menu_item): Rename local to avoid shadowing.
7376 * keyboard.c (make_lispy_event): Remove unused local var.
7378 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7379 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7381 * bitmaps: Change bitmaps from unsigned char back to the X11
7382 compatible char. Avoid the old compiler warnings about
7383 out-of-range initializers by using, for example, '\xab' rather
7386 * xgselect.c (xgselect_initialize): Check vs interface
7387 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7389 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7391 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7392 to read-only memory.
7394 * fns.c (vector): Remove; this old hack is no longer needed.
7396 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7398 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7400 * xrdb.c (x_load_resources): Omit unused local.
7402 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7403 (x_window): Rename locals to avoid shadowing.
7404 (USG): Use the kludged USG macro, to pacify gcc.
7406 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7407 (x_term_init): Remove local to avoid shadowing.
7409 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7411 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7412 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7414 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7416 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7418 Fix regex.c, syntax.c and friends for buffers > 2GB.
7419 * syntax.h (struct gl_state_s): Declare character position members
7422 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7424 * textprop.c (verify_interval_modification, interval_of):
7425 Declare arguments EMACS_INT.
7427 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7430 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7432 * indent.c (Fvertical_motion): Local variable it_start is now
7435 * regex.c (re_match, re_match_2, re_match_2_internal)
7436 (bcmp_translate, regcomp, regexec, print_double_string)
7437 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7438 (re_compile_pattern, re_exec): Declare arguments and local
7439 variables `size_t' and `ssize_t' and return values `regoff_t', as
7441 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7442 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7443 <compile_stack_type>: `size' and `avail' are now `size_t'.
7445 * regex.h <regoff_t>: Use ssize_t, not int.
7446 (re_search, re_search_2, re_match, re_match_2): Arguments that
7447 specify buffer/string position and length are now ssize_t and
7448 size_t. Return type is regoff_t.
7450 2011-04-16 Ben Key <bkey76@gmail.com>
7452 * nsfont.m: Fixed bugs in ns_get_family and
7453 ns_descriptor_to_entity that were caused by using free to
7454 deallocate memory blocks that were allocated by xmalloc (via
7455 xstrdup). This caused Emacs to crash when compiled with
7456 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7457 --enable-checking=xmallocoverrun). xfree is now used to
7458 deallocate these memory blocks.
7460 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7462 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7464 emacs_write: Accept and return EMACS_INT for sizes.
7465 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7467 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7468 Accept and return EMACS_INT.
7469 (emacs_gnutls_write): Return the number of bytes written on
7471 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7472 (emacs_read, emacs_write): Remove check for negative size, as the
7473 Emacs source code has been audited now.
7474 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7475 (emacs_read, emacs_write): Use it.
7476 * process.c (send_process): Adjust to the new signatures of
7477 emacs_write and emacs_gnutls_write. Do not attempt to store
7478 a byte offset into an 'int'; it might overflow.
7479 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7481 * sound.c: Don't assume sizes fit in 'int'.
7482 (struct sound_device.period_size, alsa_period_size):
7483 Return EMACS_INT, not int.
7484 (struct sound_device.write, vox_write, alsa_write):
7485 Accept EMACS_INT, not int.
7486 (wav_play, au_play): Use EMACS_INT to store sizes and to
7487 record read return values.
7489 2011-04-15 Ben Key <bkey76@gmail.com>
7491 * keyboard.c (Qundefined): Don't declare static since it is used
7493 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7494 static since they are used in nsfont.m.
7496 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7498 * process.c (Qprocessp): Don't declare static.
7499 * lisp.h (Qprocessp): Declare again.
7501 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7503 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7505 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7507 Improve C-level modularity by making more things 'static'.
7509 Don't publish debugger-only interfaces to other modules.
7510 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7511 (verify_bytepos, count_markers): Move decls to the only modules
7513 * region-cache.h (pp_cache): Likewise.
7514 * window.h (check_all_windows): Likewise.
7515 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7517 * sysdep.c (croak): Now static, if
7518 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7519 * syssignal.h (croak): Declare only if not static.
7521 * alloc.c (refill_memory_reserve): Now static if
7522 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7523 * lisp.h (refill_memory_reserve): Declare only if not static.
7525 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7526 Define only if USE_LUCID.
7528 * xrdb.c (x_customization_string, x_rm_string): Now static.
7530 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7531 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7533 * xdisp.c (draw_row_with_mouse_face): Now static.
7534 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7536 * window.h (check_all_windows): Mark externally visible.
7538 * window.c (window_deletion_count): Now static.
7540 * undo.c: Make symbols static if they're not exported.
7541 (last_undo_buffer, last_boundary_position, pending_boundary):
7544 * textprop.c (interval_insert_behind_hooks): Now static.
7545 (interval_insert_in_front_hooks): Likewise.
7547 * term.c: Make symbols static if they're not exported.
7548 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7549 (max_frame_lines, tty_set_terminal_modes):
7550 (tty_reset_terminal_modes, tty_turn_off_highlight):
7551 (get_tty_terminal): Now static.
7552 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7553 * termhooks.h (term_mouse_moveto): Do not declare if
7555 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7556 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7558 * sysdep.c: Make symbols static if they're not exported.
7559 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7561 (sigprocmask_set, full_mask): Remove; unused.
7562 (wait_debugging): Mark as visible.
7563 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7564 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7566 * syntax.c (syntax_temp): Define only if !__GNUC__.
7568 * sound.c (current_sound_device, current_sound): Now static.
7570 * search.c (searchbufs, searchbuf_head): Now static.
7572 * scroll.c (scroll_cost): Remove; unused.
7573 * dispextern.h (scroll_cost): Remove decl.
7575 * region-cache.h (pp_cache): Mark as externally visible.
7577 * process.c: Make symbols static if they're not exported.
7578 (process_tick, update_tick, create_process, chan_process):
7579 (Vprocess_alist, proc_buffered_char, datagram_access):
7580 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7581 (deactivate_process): Mark defn as static, as well as decl.
7582 * lisp.h (create_process): Remove decl.
7583 * process.h (chan_process, Vprocess_alist): Remove decls.
7585 * print.c: Make symbols static if they're not exported.
7586 (print_depth, new_backquote_output, being_printed, print_buffer):
7587 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7588 (print_interval, print_number_index, initial_stderr_stream):
7590 * lisp.h (Fprinc): Remove decl.
7591 (debug_output_compilation_hack): Mark as externally visible.
7593 * sysdep.c (croak): Move decl from here to syssignal.h.
7594 * syssignal.h (croak): Put it here, so the API can be checked when
7595 'croak' is called from dissociate_if_controlling_tty.
7597 * minibuf.c: Make symbols static if they're not exported.
7598 (minibuf_save_list, choose_minibuf_frame): Now static.
7599 * lisp.h (choose_minibuf_frame): Remove decl.
7601 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7603 * lread.c: Make symbols static if they're not exported.
7604 (read_objects, initial_obarray, oblookup_last_bucket_number):
7606 (make_symbol): Remove; unused.
7607 * lisp.h (initial_obarray, make_symbol): Remove decls.
7609 * keyboard.c: Make symbols static if they're not exported.
7610 (single_kboard, recent_keys_index, total_keys, recent_keys):
7611 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7612 (this_single_command_key_start, echoing, last_auto_save):
7613 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7614 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7615 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7616 (Vlispy_mouse_stem, double_click_count):
7618 (force_auto_save_soon): Define only if SIGDANGER.
7619 (ignore_mouse_drag_p): Now static if
7620 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7621 (print_help): Remove; unused.
7622 (stop_character, last_timer_event): Mark as externally visible.
7623 * keyboard.h (ignore_mouse_drag_p): Declare only if
7624 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7625 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7626 * lisp.h (echoing): Remove decl.
7627 (force_auto_save_soon): Declare only if SIGDANGER.
7628 * xdisp.c (redisplay_window): Simplify code, to make it more
7629 obvious that ignore_mouse_drag_p is not accessed if !defined
7630 USE_GTK && !defined HAVE_NS.
7632 * intervals.c: Make symbols static if they're not exported.
7633 (merge_properties_sticky, merge_interval_right, delete_interval):
7635 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7637 * insdel.c: Make symbols static if they're not exported.
7638 However, leave prepare_to_modify_buffer alone. It's never
7639 called from outside this function, but that appears to be a bug.
7640 (combine_after_change_list, combine_after_change_buffer):
7641 (adjust_after_replace, signal_before_change): Now static.
7642 (adjust_after_replace_noundo): Remove; unused.
7643 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7644 (signal_before_change): Remove decls.
7646 * indent.c (val_compute_motion, val_vmotion): Now static.
7648 * image.c: Make symbols static if they're not exported.
7649 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7651 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7652 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7654 * fringe.c (standard_bitmaps): Now static.
7655 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7657 * frame.c: Make symbols static if they're not exported.
7658 (x_report_frame_params, make_terminal_frame): Now static.
7659 (get_frame_param): Now static, unless HAVE_NS.
7660 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7661 (x_get_resource_string): Remove; not used.
7662 * frame.h (make_terminal_frame, x_report_frame_params):
7663 (x_get_resource_string); Remove decls.
7664 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7665 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7667 * font.c, fontset.c: Make symbols static if they're not exported.
7668 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7669 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7670 * font.c (font_close_object): Now static.
7671 * font.h (font_close_object): Remove.
7672 * fontset.c (FONTSET_OBJLIST): Remove.
7673 (free_realized_fontset) #if-0 the body, which does nothing.
7674 (face_suitable_for_char_p): #if-0, as it's never called.
7675 * fontset.h (face_suitable_for_char_p): Remove decl.
7676 * xfaces.c (face_at_string_position):
7677 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7678 since 0 is always ASCII.
7680 * fns.c (weak_hash_tables): Now static.
7682 * fileio.c: Make symbols static if they're not exported.
7683 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7684 (Vwrite_region_annotation_buffers): Now static.
7686 * eval.c: Make symbols static if they're not exported.
7687 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7688 * lisp.h (backtrace_list): Remove decl.
7690 * emacs.c: Make symbols static if they're not exported.
7691 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7692 (fatal_error_code, fatal_error_signal_hook, standard_args):
7694 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7695 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7696 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7697 * lisp.h (fatal_error_signal_hook): Remove decl.
7698 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7700 * editfns.c: Move a (normally-unused) function to its only use.
7701 * editfns.c, lisp.h (get_operating_system_release): Remove.
7702 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7703 worth the hassle of breaking this out.
7705 * xterm.c: Make symbols static if they're not exported.
7706 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7707 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7708 (x_destroy_window, x_delete_display):
7710 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7711 (x_mouse_leave): Remove; unused.
7712 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7713 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7714 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7716 (x_mouse_leave): Declare only if WINDOWSNT.
7717 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7718 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7721 * ftxfont.c: Make symbols static if they're not exported.
7722 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7724 * font.h (ftxfont_driver): Likewise.
7726 * xfns.c: Make symbols static if they're not exported.
7727 (x_last_font_name, x_display_info_for_name):
7728 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7729 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7730 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7731 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7732 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7733 (last_show_tip_args): Now static.
7734 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7735 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7736 (x_screen_planes): Remove; unused.
7737 * dispextern.h (x_screen_planes): Remove decl.
7739 * dispnew.c: Make symbols static if they're not exported.
7740 * dispextern.h (redraw_garbaged_frames, scrolling):
7741 (increment_row_positions): Remove.
7742 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7743 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7745 (redraw_garbaged_frames): Remove; unused.
7747 * xfaces.c: Make symbols static if they're not exported.
7748 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7750 * xterm.h (defined_color): Remove decls.
7751 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7752 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7753 (menu_face_changed_default, defined_color, free_realized_face):
7754 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7755 (ascii_face_of_lisp_face): Remove; unused.
7757 * xdisp.c: Make symbols static if they're not exported.
7758 * dispextern.h (scratch_glyph_row, window_box_edges):
7759 (glyph_to_pixel_coords, set_cursor_from_row):
7760 (get_next_display_element, set_iterator_to_next):
7761 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7762 (show_mouse_face): Remove decls
7763 * frame.h (message_buf_print): Likewise.
7764 * lisp.h (pop_message, set_message, check_point_in_composition):
7766 * xterm.h (set_vertical_scroll_bar): Likewise.
7767 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7768 (message_buf_print, scratch_glyph_row, displayed_buffer):
7769 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7770 (get_next_display_element, show_mouse_face, window_box_edges):
7771 (frame_to_window_pixel_xy, check_point_in_composition):
7772 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7773 (glyph_to_pixel_coords): Remove; unused.
7775 * dired.c (file_name_completion): Now static.
7777 * dbusbind.c (xd_in_read_queued_messages): Now static.
7779 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7780 * data.c (circular_list_error): Remove.
7782 * commands.h (last_point_position, last_point_position_buffer):
7783 (last_point_position_window): Remove decls.
7784 * keyboard.c: Make these variables static.
7786 * coding.h (coding, code_convert_region, encode_coding_gap):
7788 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7789 (iso_code_class, detect_coding, code_convert_region): Now static.
7790 (encode_coding_gap): Remove; unused.
7792 * chartab.c (chartab_chars, chartab_bits): Now static.
7794 * charset.h (charset_iso_8859_1): Remove decl.
7795 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7798 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7799 * ccl.c (Vccl_program_table): Now static.
7800 (check_ccl_update): Remove; unused.
7802 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7803 * category.h: ... from here.
7804 * category.c (check_category_table, set_category_set): Now static.
7806 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7807 * lisp.h: Remove these decls.
7809 * buffer.c (buffer_count): Remove unused var.
7811 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7812 so that it's not optimized away.
7813 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7814 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7815 exported only to the debugger.
7817 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7818 * atimer.h (run_all_atimers): Remove; not exported.
7820 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7821 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7822 was inaccessible from Lisp.
7823 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7824 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7826 alloc.c: Import and export fewer symbols, and remove unused items.
7827 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7829 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7830 it's not optimized away by whole-program optimization.
7831 (message_enable_multibyte, free_misc): Remove.
7832 (catchlist, handlerlist, mark_backtrace):
7833 Declare only if BYTE_MARK_STACK.
7834 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7835 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7836 (message_enable_multibyte): Remove decl.
7837 (free_misc, interval_free_list, float_block, float_block_index):
7838 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7839 (cons_free_list, last_marked_index):
7841 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7842 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7843 (mark_backtrace): Define only if BYTE_MARK_STACK.
7844 * xdisp.c (message_enable_multibyte): Now static.
7846 Declare Lisp_Object Q* variables to be 'static' if not exported.
7847 This makes it easier for human readers (and static analyzers)
7848 to see whether these variables are used from other modules.
7849 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7850 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7851 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7852 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7853 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7854 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7855 * xmenu.c, xselect.c:
7856 Declare Q* vars static if they are not used in other modules.
7857 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7858 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7859 Remove decls of unexported vars.
7860 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7862 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7864 Make Emacs functions such as Fatom 'static' by default.
7865 This makes it easier for human readers (and static analyzers)
7866 to see whether these functions can be called from other modules.
7867 DEFUN now defines a static function. To make the function external
7868 so that it can be used in other C modules, use the new macro DEFUE.
7869 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7870 (Finit_image_library):
7871 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7872 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7873 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7874 Remove decls, since these functions are now static.
7875 (Funintern, Fget_internal_run_time): New decls, since these functions
7876 were already external.
7878 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7879 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7880 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7881 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7882 * keyboard.c, keymap.c, lread.c:
7883 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7884 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7885 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7886 Mark functions with DEFUE instead of DEFUN,
7887 if they are used in other modules.
7888 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7889 decls for now-static functions.
7890 * buffer.h (Fdelete_overlay): Remove decl.
7891 * callproc.c (Fgetenv_internal): Mark as internal.
7892 * composite.c (Fremove_list_of_text_properties): Remove decl.
7893 (Fcomposition_get_gstring): New forward static decl.
7894 * composite.h (Fcomposite_get_gstring): Remove decl.
7895 * dired.c (Ffile_attributes): New forward static decl.
7896 * doc.c (Fdocumntation_property): New forward static decl.
7897 * eval.c (Ffetch_bytecode): New forward static decl.
7898 (Funintern): Remove extern decl; now in .h file where it belongs.
7899 * fileio.c (Fmake_symbolic_link): New forward static decl.
7900 * image.c (Finit_image_library): New forward static decl.
7901 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7902 * intervals.h (Fprevious_property_change):
7903 (Fremove_list_of_text_properties): Remove decls.
7904 * keyboard.c (Fthis_command_keys): Remove decl.
7905 (Fcommand_execute): New forward static decl.
7906 * keymap.c (Flookup_key): New forward static decl.
7907 (Fcopy_keymap): Now static.
7908 * keymap.h (Flookup_key): Remove decl.
7909 * process.c (Fget_process): New forward static decl.
7910 (Fprocess_datagram_address): Mark as internal.
7911 * syntax.c (Fsyntax_table_p): New forward static decl.
7912 (skip_chars): Remove duplicate decl.
7913 * textprop.c (Fprevious_property_change): New forward static decl.
7914 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7916 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7917 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7919 * editfns.c (Fformat): Remove unreachable code.
7921 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7923 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7926 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7928 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7929 when at ZV. (Bug#8487)
7931 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7933 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7935 * keyboard.c (parse_tool_bar_item): Likewise.
7936 * sound.c (sound_cleanup, alsa_close): Likewise.
7937 * termcap.c (tgetent): Likewise.
7938 * xfns.c (x_default_font_parameter): Likewise.
7939 * xsettings.c (read_and_apply_settings): Likewise.
7941 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7942 (overrun_check_free): Protoize.
7944 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7946 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7947 since callers should never pass a negative size.
7948 Change the signature to match that of plain 'read' and 'write'; see
7949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7950 * lisp.h: Update prototypes of emacs_write and emacs_read.
7952 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7954 * xdisp.c (redisplay_window): Don't try to determine the character
7955 position of the scroll margin if the window start point w->startp
7956 is outside the buffer's accessible region. (Bug#8468)
7958 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7960 Fix write-region and its subroutines for buffers > 2GB.
7961 * fileio.c (a_write, e_write): Modify declaration of arguments and
7962 local variables to support buffers larger than 2GB.
7963 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7965 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7966 argument, local variables, and return value.
7968 * lisp.h: Update prototypes of emacs_write and emacs_read.
7970 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7972 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7974 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7976 Fix more problems found by GCC 4.6.0's static checks.
7978 * xdisp.c (vmessage): Use a better test for character truncation.
7980 * charset.c (load_charset_map): <, not <=, for optimization,
7981 and to avoid potential problems with integer overflow.
7982 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7983 * casetab.c (set_identity, shuffle): Likewise.
7984 * editfns.c (Fformat): Likewise.
7985 * syntax.c (skip_chars): Likewise.
7987 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7988 This also lets GCC 4.6.0 generate slightly better loop code.
7990 * callint.c (Fcall_interactively): <, not <=, for optimization.
7991 (Fcall_interactively): Count the number of arguments produced,
7992 not the number of arguments given. This is simpler and lets GCC
7993 4.6.0 generate slightly better code.
7995 * ftfont.c: Distingish more carefully between FcChar8 and char.
7996 The previous code passed unsigned char * to a functions like
7997 strlen and xstrcasecmp that expect char *, which does not
7998 conform to the C standard.
7999 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8000 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8001 char * when the C standard requires it.
8003 * keyboard.c (read_char): Remove unused var.
8005 * eval.c: Port to Windows vsnprintf (Bug#8435).
8007 (SIZE_MAX): Define if the headers do not.
8008 (verror): Do not give up if vsnprintf returns a negative count.
8009 Instead, grow the buffer. This ports to Windows vsnprintf, which
8010 does not conform to C99. Problem reported by Eli Zaretskii.
8011 Also, simplify the allocation scheme, by avoiding the need for
8012 calling realloc, and removing the ALLOCATED variable.
8014 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8016 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8017 But keep the doprint source code for now, as we might revamp it
8018 and use it again (Bug#8435).
8019 * lisp.h (doprnt): Remove.
8020 * Makefile.in (base_obj): Remove doprnt.o.
8021 * deps.mk (doprnt.o): Remove.
8023 error: Print 32- and 64-bit integers portably (Bug#8435).
8024 Without this change, on typical 64-bit hosts error ("...%d...", N)
8025 was used to print both 32- and 64-bit integers N, which relied on
8027 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8028 * lisp.h (error, verror): Mark as printf-like functions.
8029 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8030 Report overflow in size calculations when allocating printf buffer.
8031 Do not truncate output string at its first null byte.
8032 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8033 Truncate the output at a character boundary, since vsnprintf does not
8035 * charset.c (check_iso_charset_parameter): Convert internal
8036 character to string before calling 'error', since %c now has the
8038 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8039 overflow when computing char to be passed to 'error'. Do not
8040 pass Lisp_Object to 'error'; pass the integer instead.
8041 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8042 formatted with plain %d.
8044 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8046 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8048 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8050 * xterm.c (x_catch_errors): Remove duplicate declaration.
8052 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8054 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8056 2011-04-10 Jim Meyering <meyering@redhat.com>
8058 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8059 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8060 return ssize_t not "int", and use size_t as the buffer length.
8061 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8062 * gnutls.h: Update declarations.
8063 * process.c (read_process_output): Use ssize_t, to match.
8064 (send_process): Likewise.
8066 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8068 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8070 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8072 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8073 Use unsigned char, to match FcChar8 type definition.
8075 * xterm.c (handle_one_xevent):
8076 * xmenu.c (create_and_show_popup_menu):
8077 * xselect.c (x_decline_selection_request)
8078 (x_reply_selection_request): Avoid type-punned deref of X events.
8080 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8082 Fix some uses of `int' instead of EMACS_INT.
8083 * search.c (string_match_1, fast_string_match)
8084 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8085 (scan_buffer, find_next_newline_no_quit)
8086 (find_before_next_newline, search_command, Freplace_match)
8087 (Fmatch_data): Make some `int' variables be EMACS_INT.
8089 * xdisp.c (display_count_lines): 3rd argument and return value now
8090 EMACS_INT. All callers changed.
8091 (pint2hrstr): Last argument is now EMACS_INT.
8093 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8094 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8095 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8096 (decode_coding_utf_16, decode_coding_emacs_mule)
8097 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8098 (decode_coding_ccl, decode_coding_charset)
8099 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8100 (decode_coding_iso_2022, decode_coding_emacs_mule)
8101 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8102 <char_offset, last_offset>: Declare EMACS_INT.
8103 (encode_coding_utf_8, encode_coding_utf_16)
8104 (encode_coding_emacs_mule, encode_invocation_designation)
8105 (encode_designation_at_bol, encode_coding_iso_2022)
8106 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8107 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8109 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8110 (encode_invocation_designation): Last argument P_NCHARS is now
8112 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8113 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8115 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8118 * ccl.c (Fccl_execute_on_string): Declare some variables
8121 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8123 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8125 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8127 * process.c (Fformat_network_address): Doc fix.
8129 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8131 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8133 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8135 * keyboard.c (read_char): Call Lisp function help-form-show,
8136 instead of using internal_with_output_to_temp_buffer.
8137 (Qhelp_form_show): New var.
8138 (syms_of_keyboard): Use DEFSYM macro.
8140 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8142 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8144 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8146 * process.c (Flist_processes): Remove to Lisp.
8147 (list_processes_1): Delete.
8149 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8151 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8153 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8155 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8157 Fix more problems found by GCC 4.6.0's static checks.
8159 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8161 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8163 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8165 * xdisp.c (vmessage): Mark as a printf-like function.
8167 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8169 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8171 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8172 printf-like functions.
8173 (tiff_load): Add casts to remove these marks before passing them
8174 to system-supplied API.
8176 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8178 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8179 This avoids several warnings with gcc -Wstrict-overflow.
8180 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8181 directly, rather than having caller test rule sign. This avoids
8182 some unnecessary tests.
8183 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8184 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8185 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8187 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8188 (xfont_open): Avoid unnecessary tests.
8190 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8192 * composite.h, composite.c (composition_gstring_put_cache):
8193 Use EMACS_INT, not int, for length.
8195 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8196 breaking out part of COMPOSITION_DECODE_RULE.
8197 (COMPOSITION_DECODE_RULE): Use it.
8198 * composite.c (get_composition_id): Remove unused local vars,
8199 by using the new macro.
8201 * textprop.c (set_text_properties_1): Change while to do-while,
8202 since the condition is always true at first.
8204 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8205 (interval_deletion_adjustment): Return unsigned value.
8208 * process.c (list_processes_1, create_pty, read_process_output):
8209 (exec_sentinel): Remove vars that were set but not used.
8210 (create_pty): Remove unnecessary "volatile"s.
8211 (Fnetwork_interface_info): Avoid possibility of int overflow.
8212 (read_process_output): Do adaptive read buffering even if carryover.
8213 (read_process_output): Simplify nbytes computation if buffered.
8215 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8217 * syntax.c (scan_words): Remove var that was set but not used.
8218 (update_syntax_table): Use unsigned instead of int.
8220 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8221 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8222 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8224 * print.c (print_error_message): Avoid int overflow.
8226 * font.c (font_list_entities): Redo for clarity,
8227 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8229 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8230 (font_score): Avoid potential overflow in diff calculation.
8232 * fns.c (substring_both): Remove var that is set but not used.
8233 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8235 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8237 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8238 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8239 can always succeed if overflow has undefined behavior.
8241 * search.c (boyer_moore, wordify): Remove vars set but not used.
8242 (wordify): Omit three unnecessary tests.
8244 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8245 All callers changed. This avoids the need for an unused var.
8247 * casefiddle.c (casify_region): Remove var that is set but not used.
8249 * dired.c (file_name_completion): Remove var that is set but not used.
8251 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8253 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8254 (Finsert_file_contents): Remove unnecessary code checking fd.
8256 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8257 Check for integer overflow on size calculations.
8259 * buffer.c (Fprevious_overlay_change): Remove var that is set
8262 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8263 Remove vars that are set but not used.
8264 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8265 (timer_check_2): Mark vars as initialized.
8267 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8269 * image.c (lookup_image): Remove var that is set but not used.
8270 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8272 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8273 that are set but not used.
8275 * xfns.c (make_invisible_cursor): Don't return garbage
8276 if XCreateBitmapFromData fails (Bug#8410).
8278 * xselect.c (x_get_local_selection, x_handle_property_notify):
8279 Remove vars that are set but not used.
8281 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8282 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8284 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8285 Remove var that is set but not used.
8286 (scroll_bar_windows_size): Now size_t, not int.
8287 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8290 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8291 (map_tty_color) [!defined MSDOS]: Likewise.
8293 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8295 * coding.c: Remove vars that are set but not used.
8296 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8297 All callers changed.
8298 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8299 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8300 (decode_coding_charset): Remove vars that are set but not used.
8302 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8303 that is set but not used.
8305 * print.c (print_object): Remove var that is set but not used.
8307 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8308 The gnulib version avoids calling malloc in the usual case,
8309 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8310 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8311 * filelock.c (current_lock_owner): Likewise.
8312 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8313 * sysdep.c: Include allocator.h, careadlinkat.h.
8314 (emacs_no_realloc_allocator): New static constant.
8315 (emacs_readlink): New function.
8316 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8317 ../lib/careadlinkat.h.
8319 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8321 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8322 first non-nil return value).
8324 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8326 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8327 if not defined (Bug#8403).
8329 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8331 * xdisp.c (display_count_lines): Remove parameter `start',
8332 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8333 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8334 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8335 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8336 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8337 and thereabouts. All callers changed.
8338 (get_per_char_metric): Remove parameter `f', unused since
8339 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8341 2011-04-02 Jim Meyering <meyering@redhat.com>
8343 do not dereference NULL upon failed strdup
8344 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8345 (ns_get_family): Likewise.
8347 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8349 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8351 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8353 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8356 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8358 Add lexical binding.
8360 * window.c (Ftemp_output_buffer_show): New fun.
8361 (Fsave_window_excursion):
8362 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8364 * lread.c (lisp_file_lexically_bound_p): New function.
8365 (Fload): Bind Qlexical_binding.
8366 (readevalloop): Remove `evalfun' arg.
8367 Bind Qinternal_interpreter_environment.
8368 (Feval_buffer): Bind Qlexical_binding.
8369 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8371 (syms_of_lread): Declare `lexical-binding'.
8373 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8375 * keyboard.c (eval_dyn): New fun.
8376 (menu_item_eval_property): Use it.
8378 * image.c (parse_image_spec): Use Ffunctionp.
8380 * fns.c (concat, mapcar1): Accept byte-code-functions.
8382 * eval.c (Fsetq): Handle lexical vars.
8383 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8384 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8385 (FletX, Flet): Obey lexical binding.
8386 (Fcommandp): Handle closures.
8387 (Feval): New `lexical' arg.
8388 (eval_sub): New function extracted from Feval. Use it almost
8389 everywhere where Feval was used. Look up vars in lexical env.
8391 (Ffunctionp): Move from subr.el.
8392 (Ffuncall): Handle closures.
8393 (apply_lambda): Remove `eval_flags'.
8394 (funcall_lambda): Handle closures and new byte-code-functions.
8395 (Fspecial_variable_p): New function.
8396 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8397 but without exporting it to Lisp.
8399 * doc.c (Fdocumentation, store_function_docstring):
8400 * data.c (Finteractive_form): Handle closures.
8402 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8405 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8407 (exec_byte_code): New function extracted from Fbyte_code to handle new
8408 calling convention for byte-code-functions. Add new byte-codes.
8410 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8412 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8414 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8416 * xdisp.c (redisplay_internal): Fix prototype.
8418 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8420 * xdisp.c (SCROLL_LIMIT): New macro.
8421 (try_scrolling): Use it when setting scroll_limit.
8422 Limit scrolling to 100 screen lines.
8423 (redisplay_window): Even when falling back on "recentering",
8424 position point in the window according to scroll-conservatively,
8425 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8427 (try_scrolling): When point is above the window, allow searching
8428 as far as scroll_max, or one screenful, to compute vertical
8429 distance from PT to the scroll margin position. This prevents
8430 try_scrolling from unnecessarily failing when
8431 scroll-conservatively is set to a value slightly larger than the
8432 window height. Clean up the case of PT below the margin at bottom
8433 of window: scroll_max can no longer be INT_MAX. When aggressive
8434 scrolling is in use, don't let point enter the opposite scroll
8435 margin as result of the scroll.
8436 (syms_of_xdisp) <scroll-conservatively>: Document the
8437 threshold of 100 lines for never-recentering scrolling.
8439 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8441 * dispextern.h (move_it_by_lines):
8442 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8443 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8444 (message_log_check_duplicate): Remove parameters `prev_bol' and
8445 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8446 (redisplay_internal): Remove parameter `preserve_echo_area',
8447 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8449 * indent.c (Fvertical_motion):
8450 * window.c (window_scroll_pixel_based, Frecenter):
8451 Don't pass `need_y_p' to `move_it_by_lines'.
8453 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8455 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8456 steal a few bits to be more compact.
8457 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8458 Remove unneeded casts.
8460 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8462 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8464 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8465 binding" message (bug#7967).
8467 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8469 Fix more problems found by GCC 4.6.0's static checks.
8471 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8472 Remove unused local var.
8474 * editfns.c (Fmessage_box): Remove unused local var.
8476 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8477 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8478 Omit unused local vars.
8479 * window.c (shrink_windows): Omit unused local var.
8480 * menu.c (digest_single_submenu): Omit unused local var.
8481 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8482 Omit unused local var.
8484 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8485 Don't assume string length fits in int.
8486 (keyremap_step, read_key_sequence): Use size_t for sizes.
8487 (read_key_sequence): Don't check last_real_key_start redundantly.
8489 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8490 instead of alloca (Bug#8344).
8492 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8493 (Fbacktrace_frame): Don't assume nframes fits in int.
8495 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8497 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8500 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8502 * cm.c (calccost): Turn while-do into do-while, for clarity.
8504 * keyboard.c (syms_of_keyboard): Use the same style as later
8505 in this function when indexing through an array. This also
8506 works around GCC bug 48267.
8508 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8510 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8512 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8513 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8515 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8516 This avoids undefined behavior on integer overflow, and is a bit
8517 more convenient anyway since it is compared to a size_t variable.
8519 Variadic C functions now count arguments with size_t, not int.
8520 This avoids an unnecessary limitation on 64-bit machines, which
8521 caused (substring ...) to crash on large vectors (Bug#8344).
8522 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8523 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8524 All variadic functions and their callers changed accordingly.
8525 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8526 * data.c (arith_driver, float_arith_driver): Likewise.
8527 * editfns.c (general_insert_function): Likewise.
8528 * eval.c (struct backtrace.nargs, interactive_p)
8529 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8530 (funcall_lambda, mark_backtrace): Likewise.
8531 * fns.c (concat): Likewise.
8532 * frame.c (x_set_frame_parameters): Likewise.
8533 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8534 0 if not found, not -1. All callers changed.
8536 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8537 (stack_copy_size): Now size_t, not int.
8538 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8540 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8542 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8543 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8544 All callers changed.
8546 * lisp.h (multibyte_char_to_unibyte):
8547 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8548 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8549 * character.h (CHAR_TO_BYTE8):
8550 * cmds.c (internal_self_insert):
8551 * editfns.c (general_insert_function):
8552 * keymap.c (push_key_description):
8553 * search.c (Freplace_match):
8554 * xdisp.c (message_dolog, set_message_1): All callers changed.
8556 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8558 * keyboard.c (safe_run_hook_funcall): New function.
8559 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8560 don't set the hook to nil, but remove the offending function instead.
8561 (Qcommand_hook_internal): Remove, unused.
8562 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8563 Vcommand_hook_internal.
8565 * eval.c (enum run_hooks_condition): Remove.
8566 (funcall_nil, funcall_not): New functions.
8567 (run_hook_with_args): Call each function through a `funcall' argument.
8568 Remove `cond' argument, now redundant.
8569 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8570 (Frun_hook_with_args_until_failure): Adjust accordingly.
8571 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8573 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8575 * dispextern.h (string_buffer_position): Remove declaration.
8577 * print.c (strout): Remove parameter `multibyte', unused since
8578 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8580 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8581 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8582 All callers changed.
8584 * w32.c (_wsa_errlist): Use braces for struct initializers.
8586 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8587 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8588 All callers changed.
8589 (string_buffer_position): Likewise. Also, make static (it's never
8590 used outside xdisp.c).
8591 (cursor_row_p): Remove parameter `w', unused since
8592 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8593 (decode_mode_spec): Remove parameter `precision', introduced during
8594 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8595 All callers changed.
8597 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8599 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8601 2011-03-27 Anders Lindgren <andlind@gmail.com>
8603 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8604 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8605 (ns_update_auto_hide_menu_bar): New functions.
8606 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8607 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8608 ns_constrain_all_frames.
8609 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8610 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8612 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8614 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8616 2011-03-27 Glenn Morris <rgm@gnu.org>
8618 * syssignal.h: Replace RETSIGTYPE with void.
8619 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8620 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8621 Replace SIGTYPE with void everywhere.
8622 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8623 * s/template.h (SIGTYPE): Remove commented out definition.
8625 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8627 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8628 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8630 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8632 * w32.c (read_unc_volume): Use parameter `henum', instead of
8633 global variable `wget_enum_handle'.
8635 * keymap.c (describe_vector): Remove parameters `indices' and
8636 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8637 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8639 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8641 * keyboard.c (timer_check): Remove parameter `do_it_now',
8642 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8643 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8644 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8646 * keyboard.c (read_char):
8647 * w32menu.c (w32_menu_display_help):
8648 * xmenu.c (show_help_event, menu_help_callback):
8649 Adjust calls to `show_help_echo'.
8651 * gtkutil.c (xg_maybe_add_timer):
8652 * keyboard.c (readable_events):
8653 * process.c (wait_reading_process_output):
8654 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8656 * insdel.c (adjust_markers_gap_motion):
8657 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8658 (gap_left, gap_right): Don't call it.
8660 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8662 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8663 incurred during fontification.
8665 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8667 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8668 (DEFVAR_PER_BUFFER): Don't pass it.
8670 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8671 (scrolling_window): Don't pass it.
8673 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8675 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8677 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8679 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8680 of variables specific to SELinux and computation of `encoded_absname'.
8682 * image.c (XPutPixel): Remove unused variable `height'.
8684 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8686 * unexw32.c (get_section_info): Remove unused variable `section'.
8688 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8689 (system_process_attributes): Remove unused variable `sess'.
8690 (sys_read): Remove unused variable `err'.
8692 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8693 (w32_wnd_proc): Remove unused variable `isdead'.
8694 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8695 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8696 (x_create_tip_frame): Remove unused variable `tem'.
8698 * w32inevt.c (w32_console_read_socket):
8699 Remove unused variable `no_events'.
8701 * w32term.c (x_draw_composite_glyph_string_foreground):
8702 Remove unused variable `width'.
8704 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8706 * w32term.c (x_set_glyph_string_clipping):
8707 Don't pass uninitialized region to CombineRgn.
8709 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8711 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8712 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8713 (Fx_close_connection): Remove unused variable `i'.
8715 * w32font.c (w32font_draw): Return number of glyphs.
8716 (w32font_open_internal): Remove unused variable `i'.
8717 (w32font_driver): Add missing initializer.
8719 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8720 (fill_in_menu): Remove unused variable `items_added'.
8722 * w32term.c (last_mouse_press_frame): Remove static global variable.
8723 (w32_clip_to_row): Remove unused variable `f'.
8724 (x_delete_terminal): Remove unused variable `i'.
8726 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8727 (NOTHING): Remove unused static global variable.
8728 (uniscribe_check_otf): Remove unused variable `table'.
8729 (uniscribe_font_driver): Add missing initializers.
8731 2011-03-23 Julien Danjou <julien@danjou.info>
8733 * term.c (Fsuspend_tty, Fresume_tty):
8734 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8735 * window.c (temp_output_buffer_show):
8736 * insdel.c (signal_before_change):
8737 * frame.c (Fhandle_switch_frame):
8738 * fileio.c (Fdo_auto_save):
8739 * emacs.c (Fkill_emacs):
8740 * editfns.c (save_excursion_restore):
8741 * cmds.c (internal_self_insert):
8742 * callint.c (Fcall_interactively):
8743 * buffer.c (Fkill_all_local_variables):
8744 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8746 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8747 unconditionally since it does the check itself.
8749 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8751 Fix more problems found by GCC 4.5.2's static checks.
8753 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8754 the first time through the loop, since we know p0 < p1 then.
8755 This also avoids a gcc -Wstrict-overflow warning.
8757 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8758 leading to a memory leak, possible in functions like
8759 load_charset_map_from_file that can allocate an unbounded number
8760 of objects (Bug#8318).
8762 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8763 that could (at least in theory) be that large.
8765 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8766 This is less likely to overflow, and avoids undefined behavior if
8767 overflow does occur. All callers changed. Use strtoul to scan
8768 for the unsigned long integer.
8769 (pint2hrstr): Simplify and tune code slightly.
8770 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8772 * scroll.c (do_scrolling): Work around GCC bug 48228.
8773 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8775 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8776 This also avoids a warning with gcc -Wstrict-overflow.
8777 (validate_x_resource_name): Simplify count usage.
8778 This also avoids a warning with gcc -Wstrict-overflow.
8780 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8783 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8785 * process.c (Fmake_network_process): Use socklen_t, not int,
8786 where POSIX says socklen_t is required in portable programs.
8787 This fixes a porting bug on hosts like 64-bit HP-UX, where
8788 socklen_t is wider than int (Bug#8277).
8789 (Fmake_network_process, server_accept_connection):
8790 (wait_reading_process_output, read_process_output):
8793 * process.c: Rename or move locals to avoid shadowing.
8794 (list_processes_1, Fmake_network_process):
8795 (read_process_output_error_handler, exec_sentinel_error_handler):
8796 Rename or move locals.
8797 (Fmake_network_process): Define label "retry_connect" only if needed.
8798 (Fnetwork_interface_info): Fix pointer signedness.
8799 (process_send_signal): Add cast to avoid pointer signedness problem.
8800 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8801 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8803 Make tparam.h and terminfo.c consistent.
8804 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8805 Include tparam.h instead, since it declares them.
8806 * cm.h (PC): Remove extern decl; tparam.h now does this.
8807 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8808 * terminfo.c: Include tparam.h, to check interfaces.
8809 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8810 (tparam): Adjust signature to match interface in tparam.h;
8811 this removes some undefined behavior. Check that outstring and len
8812 are zero, which they always are with Emacs.
8813 * tparam.h (PC, BC, UP): New extern decls.
8815 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8816 (xftfont_open): Rename locals to avoid shadowing.
8818 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8819 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8820 (OTF_TAG_SYM): Omit macro if not needed.
8821 (ftfont_list): Remove unused local.
8822 (get_adstyle_property, ftfont_pattern_entity):
8823 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8824 Rename locals to avoid shadowing.
8826 * xfont.c (xfont_list_family): Mark var as initialized.
8828 * xml.c (make_dom): Now static.
8830 * composite.c (composition_compute_stop_pos): Rename local to
8832 (composition_reseat_it): Remove unused locals.
8833 (find_automatic_composition, composition_adjust_point): Likewise.
8834 (composition_update_it): Mark var as initialized.
8835 (find_automatic_composition): Mark vars as initialized,
8836 with a FIXME (Bug#8290).
8838 character.h: Rename locals to avoid shadowing.
8839 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8840 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8841 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8842 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8845 * textprop.c (property_change_between_p): Remove; unused.
8847 * intervals.c (interval_start_pos): Now static.
8849 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8851 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8852 Rename locals to avoid shadowing.
8854 * sound.c (wav_play, au_play, Fplay_sound_internal):
8855 Fix pointer signedness.
8856 (alsa_choose_format): Remove unused local var.
8857 (wav_play): Initialize a variable to 0, to prevent undefined
8858 behavior (Bug#8278).
8860 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8862 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8864 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8865 clobbering (Bug#8298).
8866 * sysdep.c (sys_subshell): Likewise.
8867 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8869 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8870 This should get cleaned up, so that child_setup has the
8871 same signature on all platforms.
8873 * callproc.c (call_process_cleanup): Now static.
8874 (relocate_fd): Rename locals to avoid shadowing.
8876 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8878 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8879 not to be necessary, and produces flickering.
8881 2011-03-20 Glenn Morris <rgm@gnu.org>
8883 * config.in: Remove file.
8885 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8887 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8888 are now in src/globals.h.
8889 (syms_of_minibuf): Remove spurious & from previous change.
8891 2011-03-20 Leo Liu <sdl.web@gmail.com>
8893 * minibuf.c (completing-read-function): New variable.
8894 (completing-read-default): Rename from completing-read.
8895 (completing-read): Call completing-read-function.
8897 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8899 * xfaces.c (Fx_load_color_file):
8900 Read color file from absolute filename (bug#8250).
8902 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8904 * makefile.w32-in: Update dependencies.
8906 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8908 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8910 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8912 Fix more problems found by GCC 4.5.2's static checks.
8914 * process.c (make_serial_process_unwind, send_process_trap):
8915 (sigchld_handler): Now static.
8917 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8918 That way, the code declares only the vars that it needs.
8919 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8920 * s/cygwin.h (PTY_ITERATION): Likewise.
8921 * s/darwin.h (PTY_ITERATION): Likewise.
8922 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8924 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8925 * process.c (allocate_pty): Don't declare stb unless it's needed.
8927 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8928 (CONSTANTLIM): Remove; unused.
8929 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8930 Define only if needed.
8932 * unexelf.c (unexec): Name an expression,
8933 to avoid gcc -Wbad-function-cast warning.
8934 Use a different way to cause a compilation error if anyone uses
8935 n rather than nn, a way that does not involve shadowing.
8936 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8938 * deps.mk (unexalpha.o): Remove; unused.
8940 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8941 * unexec.h: New file.
8942 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8943 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8945 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8946 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8947 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8948 Change as necessary to match prototype in unexec.h.
8950 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8952 (back_comment, skip_chars): Mark vars as initialized.
8954 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8955 Rename locals to avoid shadowing.
8957 * lread.c (read1): Rewrite so as not to use empty "else".
8958 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8960 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8962 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8963 warning when compiling print.c.
8965 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8966 instead of using an uninitialized var.
8967 (font_sort_entities): Mark var as initialized.
8969 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8971 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8972 pointers to constants.
8973 (font_parse_fcname): Remove unused vars.
8974 (font_delete_unmatched): Now static.
8975 (font_get_spec): Remove; unused.
8976 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8977 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8978 Rename or move locals to avoid shadowing.
8980 * fns.c (require_nesting_list, require_unwind): Now static.
8981 (Ffillarray): Rename locals to avoid shadowing.
8983 * floatfns.c (domain_error2): Define only if needed.
8984 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8986 * alloc.c (mark_backtrace): Move decl from here ...
8987 * lisp.h: ... to here, so that it can be checked.
8989 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8990 (Fdefvar): Rewrite so as not to use empty "else".
8991 (lisp_indirect_variable): Name an expression,
8992 to avoid gcc -Wbad-function-cast warning.
8993 (Fdefvar): Rename locals to avoid shadowing.
8995 * callint.c (quotify_arg, quotify_args): Now static.
8996 (Fcall_interactively): Rename locals to avoid shadowing.
8997 Use const pointer when appropriate.
8999 * lisp.h (get_system_name, get_operating_system_release):
9000 Move decls here, to check interfaces.
9001 * process.c (get_operating_system_release): Move decl to lisp.h.
9002 * xrdb.c (get_system_name): Likewise.
9003 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9004 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9005 some of which prompt warnings from gcc -Wbad-function-cast.
9006 (Fformat_time_string, Fencode_time, Finsert_char):
9007 (Ftranslate_region_internal, Fformat):
9008 Rename or remove local vars to avoid shadowing.
9009 (Ftranslate_region_internal): Mark var as initialized.
9011 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9014 * lisp.h (eassert): Check that the argument compiles, even if
9015 ENABLE_CHECKING is not defined.
9017 * data.c (Findirect_variable): Name an expression, to avoid
9018 gcc -Wbad-function-cast warning.
9019 (default_value, arithcompare, arith_driver, arith_error): Now static.
9020 (store_symval_forwarding): Rename local to avoid shadowing.
9021 (Fmake_variable_buffer_local, Fmake_local_variable):
9022 Mark variables as initialized.
9023 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9025 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9026 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9027 Rename locals to avoid shadowing.
9028 (mark_stack): Move local variables into the #ifdef region where
9030 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9031 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9033 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9034 (GC_STRING_CHARS): Remove; not used.
9035 (Fmemory_limit): Cast sbrk's returned value to char *.
9037 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9038 avoids undefined behavior in theory.
9040 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9042 Use functions, not macros, for up- and down-casing (Bug#8254).
9043 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9044 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9045 to use the following functions instead of these macros.
9046 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9047 EMACS_INT, since callers assume the returned value fits in int.
9048 (upcase1): Likewise, for UPCASE_TABLE.
9049 (uppercasep, lowercasep, upcase): New static inline functions.
9050 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9051 the race-condition problem in the old DOWNCASE.
9053 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9054 Rename locals to avoid shadowing.
9055 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9056 (regex_compile, re_search_2, re_match_2_internal):
9057 Remove unused local vars.
9058 (FREE_VAR): Rewrite so as not to use empty "else",
9059 which gcc can warn about.
9060 (regex_compile, re_match_2_internal): Mark locals as initialized.
9061 (RETALLOC_IF): Define only if needed.
9062 (WORDCHAR_P): Likewise. This one is never needed, but is used
9063 only in a comment talking about a compiler bug, so put inside
9064 the #if 0 of that comment.
9065 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9066 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9069 * search.c (boyer_moore): Rename locals to avoid shadowing.
9070 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9071 (PREV_CHAR_BOUNDARY): Likewise.
9073 * search.c (simple_search): Remove unused var.
9075 * dired.c (compile_pattern): Move decl from here ...
9076 * lisp.h: ... to here, so that it can be checked.
9077 (struct re_registers): New forward decl.
9079 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9081 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9083 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9084 Rename locals to avoid shadowing.
9085 (Fvertical_motion): Mark locals as initialized.
9087 * casefiddle.c (casify_object, casify_region): Now static.
9088 (casify_region): Mark local as initialized.
9090 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9092 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9093 New macros, so that the caller can use some names other than
9094 gcpro1, gcpro2, etc.
9095 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9097 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9098 argument, for consistency with GCPRO2_VAR, etc: it is now the
9099 prefix of the variable, not the variable itself. All uses
9101 * dired.c (directory_files_internal, file_name_completion):
9102 Rename locals to avoid shadowing.
9104 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9105 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9106 dired.c's scmp function, had undefined behavior.
9107 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9108 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9109 * buffer.h: ... to here, because these macros use current_buffer,
9110 and the new implementation with inline functions needs to have
9111 current_buffer in scope now, rather than later when the macros
9113 (downcase, upcase1): New static inline functions.
9114 (DOWNCASE, UPCASE1): Reimplement using these functions.
9115 This avoids undefined behavior in expressions like
9116 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9117 from race conditions in accessing the global variables
9118 case_temp1 and case_temp2.
9119 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9120 * lisp.h (case_temp1, case_temp2): Remove their decls.
9121 * character.h (ASCII_CHAR_P): Move from here ...
9122 * lisp.h: ... to here, so that the inline functions mentioned
9125 * dired.c (directory_files_internal_unwind): Now static.
9127 * fileio.c (file_name_as_directory, directory_file_name):
9128 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9130 (file_name_as_directory): Use const pointers when appropriate.
9131 (Fexpand_file_name): Likewise. In particular, newdir might
9132 point at constant storage, so make it a const pointer.
9133 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9134 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9136 (Fset_file_times, Finsert_file_contents, auto_save_error):
9137 Rename locals to avoid shadowing.
9139 * minibuf.c (choose_minibuf_frame_1): Now static.
9140 (Ftry_completion, Fall_completions): Rename or remove locals
9143 * marker.c (bytepos_to_charpos): Remove; unused.
9145 * lisp.h (verify_bytepos, count_markers): New decls,
9146 so that gcc does not warn that these functions aren't declared.
9148 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9149 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9150 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9151 (copy_text): Remove unused local var.
9153 * filelock.c (within_one_second): Now static.
9154 (lock_file_1): Rename local to avoid shadowing.
9156 * buffer.c (fix_overlays_before): Mark locals as initialized.
9157 (fix_start_end_in_overlays): Likewise. This function should be
9158 simplified by using pointers-to-pointers, but that's a different
9160 (switch_to_buffer_1): Now static.
9161 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9162 (report_overlay_modification): Rename locals to avoid shadowing.
9164 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9165 Fix pointer signedness issue.
9166 (sys_subshell): Mark local as volatile if checking for lint,
9167 to suppress a gcc -Wclobbered warning that does not seem to be right.
9168 (MAXPATHLEN): Define only if needed.
9170 * process.c (serial_open, serial_configure): Move decls from here ...
9171 * systty.h: ... to here, so that they can be checked.
9173 * fns.c (get_random, seed_random): Move extern decls from here ...
9174 * lisp.h: ... to here, so that they can be checked.
9176 * sysdep.c (reset_io): Now static.
9177 (wait_for_termination_signal): Remove; unused.
9179 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9180 (copy_keymap_item, append_key, push_text_char_description):
9182 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9183 (DENSE_TABLE_SIZE): Remove; unused.
9184 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9185 (describe_map_tree):
9186 Rename locals to avoid shadowing.
9188 * keyboard.c: Declare functions static if they are not used elsewhere.
9189 (echo_char, echo_dash, cmd_error, top_level_2):
9190 (poll_for_input, handle_async_input): Now static.
9191 (read_char, kbd_buffer_get_event, make_lispy_position):
9192 (make_lispy_event, make_lispy_movement, apply_modifiers):
9193 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9194 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9195 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9196 (read_key_sequence, read_char): Mark locals as initialized.
9197 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9199 * keyboard.h (make_ctrl_char): New decl.
9200 (mark_kboards): Move decl here ...
9201 * alloc.c (mark_kboards): ... from here.
9203 * lisp.h (force_auto_save_soon): New decl.
9205 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9206 (DEFINE_DUMMY_FUNCTION): New macro.
9207 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9209 (main): Add casts to avoid warnings
9210 if GCC considers string literals to be constants.
9212 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9214 * dbusbind.c: Pointer signedness fixes.
9215 (xd_signature, xd_append_arg, xd_initialize):
9216 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9217 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9218 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9219 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9221 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9222 if GCC considers string literals to be constants.
9223 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9225 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9227 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9228 (print_preprocess, print_object): New macro to fix last change.
9230 * print.c (print_preprocess): Don't forget font objects.
9232 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9234 * emacs.c (USAGE3): Doc fixes.
9236 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9238 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9241 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9243 * lisp.h (VWindow_system, Qfile_name_history):
9244 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9245 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9246 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9248 * w32select.c: Don't #include "keyboard.h".
9249 (run_protected): Add extern declaration for waiting_for_input.
9251 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9252 * w32console.c (detect_input_pending, read_input_pending)
9253 (encode_terminal_code):
9254 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9255 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9256 (w32_system_caret_y, Qfile_name_history):
9257 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9258 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9259 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9260 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9261 * w32proc.c (Qlocal, report_file_error):
9262 * w32term.c (Vwindow_system, updating_frame):
9263 * w32uniscribe.c (initialized, uniscribe_font_driver):
9264 Remove unneeded extern declarations.
9266 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9268 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9270 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9272 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9273 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9274 These macros can no longer be used for assignment.
9276 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9277 Assign struct members directly, instead of using BUF_BEGV etc.
9278 (record_buffer_markers, fetch_buffer_markers): New functions for
9279 recording and fetching special buffer markers.
9280 (set_buffer_internal_1, set_buffer_temp): Use them.
9282 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9284 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9286 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9287 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9289 * xdisp.c (hscroll_window_tree):
9290 (reconsider_clip_changes): Use PT instead of BUF_PT.
9292 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9294 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9295 $(EMACS_ROOT)/lib/intprops.h.
9297 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9299 Fix more problems found by GCC 4.5.2's static checks.
9301 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9302 to unsigned char * to avoid compiler diagnostic.
9303 (xg_free_frame_widgets): Make it clear that a local variable is
9304 needed only if USE_GTK_TOOLTIP.
9305 (gdk_window_get_screen): Make it clear that this macro is needed
9306 only if USE_GTK_TOOLTIP.
9307 (int_gtk_range_get_value): New function, which avoids a diagnostic
9308 from gcc -Wbad-function-cast.
9309 (xg_set_toolkit_scroll_bar_thumb): Use it.
9310 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9311 diagnostic from gcc -Wbad-function-cast.
9312 (get_utf8_string, xg_get_file_with_chooser):
9313 Rename locals to avoid shadowing.
9314 (create_dialog): Move locals to avoid shadowing.
9316 * xgselect.c (xg_select): Remove unused var.
9318 * image.c (four_corners_best): Mark locals as initialized.
9319 (gif_load): Initialize transparent_p to zero (Bug#8238).
9320 Mark another local as initialized.
9321 (my_png_error, my_error_exit): Mark with NO_RETURN.
9323 * image.c (clear_image_cache): Now static.
9324 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9325 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9326 (x_edge_detection): Remove unnecessary cast that
9327 gcc -Wbad-function-cast diagnoses.
9328 (gif_load): Fix pointer signedness.
9329 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9330 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9332 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9334 Improve quality of tests for time stamp overflow.
9335 For example, without this patch (encode-time 0 0 0 1 1
9336 1152921504606846976) returns the obviously-bogus value (-948597
9337 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9338 reports time overflow. See
9339 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9340 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9341 * editfns.c: Include limits.h and intprops.h.
9342 (TIME_T_MIN, TIME_T_MAX): New macros.
9343 (time_overflow): Move earlier, to before first use.
9344 (hi_time, lo_time): New functions, for an accurate test for
9346 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9347 (Fget_internal_run_time): Don't assume time_t fits in int.
9348 (make_time): Use list2 instead of Fcons twice.
9349 (Fdecode_time): More accurate test for out-of-range times.
9350 (check_tm_member): New function.
9351 (Fencode_time): Use it, to test for out-of-range times.
9352 (lisp_time_argument): Don't rely on undefined left-shift and
9353 right-shift behavior when checking for time stamp overflow.
9355 * editfns.c (time_overflow): New function, refactoring common code.
9356 (Fformat_time_string, Fdecode_time, Fencode_time):
9357 (Fcurrent_time_string): Use it.
9359 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9360 * dired.c (make_time): Move to ...
9361 * editfns.c (make_time): ... here.
9362 * systime.h: Note the move.
9364 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9366 * fringe.c (update_window_fringes): Remove unused variables.
9368 * unexmacosx.c (copy_data_segment): Also copy __got section.
9371 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9373 * termcap.c [MSDOS]: Include "msdos.h".
9374 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9375 Constify `char *' arguments and their references according to
9376 prototypes in tparam.h.
9378 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9380 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9381 Adapt all references accordingly.
9383 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9385 2011-03-11 Tom Tromey <tromey@redhat.com>
9387 * buffer.c (syms_of_buffer): Remove obsolete comment.
9389 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9391 * termhooks.h (encode_terminal_code): Declare prototype.
9393 * msdos.c (encode_terminal_code): Don't declare prototype.
9395 * term.c (encode_terminal_code): Now external again, used by
9396 w32console.c and msdos.c.
9398 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9399 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9401 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9403 Fix some minor problems found by GCC 4.5.2's static checks.
9405 * fringe.c (update_window_fringes): Mark locals as initialized
9407 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9409 * alloc.c (mark_fringe_data): Move decl from here ...
9410 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9411 to check its interface.
9412 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9414 * fontset.c (free_realized_fontset): Now static.
9415 (Fset_fontset_font): Rename local to avoid shadowing.
9416 (fontset_font): Mark local as initialized.
9417 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9419 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9421 * xselect.c (x_disown_buffer_selections): Remove; not used.
9422 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9423 (x_own_selection, Fx_disown_selection_internal): Rename locals
9425 (x_handle_dnd_message): Remove local to avoid shadowing.
9427 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9428 so that the caller can use some name other than gcpro1.
9429 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9430 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9431 (Fx_backspace_delete_keys_p):
9432 Use them to avoid shadowing, and rename vars to avoid shadowing.
9433 (x_decode_color, x_set_name, x_window): Now static.
9434 (Fx_create_frame): Add braces to silence GCC warning.
9435 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9436 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9437 Remove unused locals.
9438 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9439 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9440 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9443 * xterm.h (x_mouse_leave): New decl.
9445 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9446 Remove unused functions.
9447 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9448 (x_calc_absolute_position): Now static.
9449 (XTread_socket): Don't define label "out" unless it's used.
9450 Don't declare local "event" unless it's used.
9451 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9452 unless they are used.
9453 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9454 (x_fatal_error_signal): Remove; not used.
9455 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9456 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9457 (x_error_catcher, x_connection_closed, x_error_handler):
9458 (x_error_quitter, xembed_send_message, x_iconify_frame):
9459 (my_log_handler): Rename locals to avoid shadowing.
9460 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9461 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9463 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9464 Rename or move locals to avoid shadowing.
9465 (tty_defined_color, merge_face_heights): Now static.
9466 (free_realized_faces_for_fontset): Remove; not used.
9467 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9468 does not deduce is never used uninitialized.
9469 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9470 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9472 * terminal.c (store_terminal_param): Now static.
9474 * xmenu.c (menu_highlight_callback): Now static.
9475 (set_frame_menubar): Remove unused local.
9476 (xmenu_show): Rename parameter to avoid shadowing.
9477 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9478 since they might point to immutable storage.
9479 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9480 since it's unused otherwise.
9482 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9483 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9484 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9485 avoids a gcc -Wuninitialized diagnostic.
9486 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9487 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9488 does not deduce are never used uninitialized.
9490 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9492 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9493 * window.c (window_loop, size_window):
9494 (run_window_configuration_change_hook, enlarge_window): Likewise.
9496 * window.c (display_buffer): Now static.
9497 (size_window): Mark variables that gcc -Wuninitialized
9498 does not deduce are never used uninitialized.
9499 * window.h (check_all_windows): New decl, to forestall
9500 gcc -Wmissing-prototypes diagnostic.
9501 * dispextern.h (bidi_dump_cached_states): Likewise.
9503 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9505 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9507 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9508 and to avoid gcc -Wuninitialized warning.
9509 (load_charset_map): Mark variables that gcc -Wuninitialized
9510 does not deduce are never used uninitialized.
9511 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9513 * coding.c (coding_set_source, coding_set_destination):
9514 Use "else { /* comment */ }" rather than "else /* comment */;"
9515 for clarity, and to avoid gcc -Wempty-body warning.
9516 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9517 a block, when the outer 'i' will do.
9518 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9519 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9520 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9521 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9522 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9523 Rename locals to avoid shadowing.
9524 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9525 * coding.c (emacs_mule_char, encode_invocation_designation):
9526 Now static, since they're not used elsewhere.
9527 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9528 (decode_coding_object, encode_coding_object, detect_coding_system):
9529 (decode_coding_emacs_mule): Mark variables that gcc
9530 -Wuninitialized does not deduce are never used uninitialized.
9531 (detect_coding_iso_2022): Initialize a local variable that might
9532 be used uninitialized. Leave a FIXME because it's not clear that
9533 this initialization is needed. (Bug#8211)
9534 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9535 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9536 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9537 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9538 Remove unused macros.
9540 * category.c (hash_get_category_set): Remove unused local var.
9541 (copy_category_table): Now static, since it's not used elsewhere.
9542 * character.c (string_count_byte8): Likewise.
9544 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9545 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9547 * chartab.c (copy_sub_char_table): Now static, since it's not used
9549 (sub_char_table_ref_and_range, char_table_ref_and_range):
9550 Rename locals to avoid shadowing.
9551 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9553 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9554 (BIDI_BOB): Remove unused macro.
9556 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9557 deduce are never used uninitialized.
9558 * term.c (encode_terminal_code): Likewise.
9560 * term.c (encode_terminal_code): Now static. Remove unused local.
9562 * tparam.h: New file.
9563 * term.c, tparam.h: Include it.
9564 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9565 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9566 Move these decls to tparam.h, and make them agree with what
9567 is actually in tparam.c. The previous trick of using incompatible
9568 decls in different modules does not conform to the C standard.
9569 All callers of tparam changed to use tparam's actual API.
9570 * tparam.c (tparam1, tparam, tgoto):
9571 Use const pointers where appropriate.
9573 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9574 * cm.h (struct cm): Likewise.
9575 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9576 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9577 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9578 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9579 (turn_on_face, init_tty): Likewise.
9580 * termchar.h (struct tty_display_info): Likewise.
9582 * term.c (term_mouse_position): Rename local to avoid shadowing.
9584 * alloc.c (mark_ttys): Move decl from here ...
9585 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9587 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9589 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9591 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9593 * search.c (compile_pattern_1): Remove argument regp, unused since
9594 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9595 (compile_pattern): Don't pass it.
9597 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9599 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9600 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9602 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9604 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9606 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9607 gdk_window_get_screen, gdk_window_get_geometry,
9608 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9609 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9610 (xg_get_pixbuf_from_pixmap): New function.
9611 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9612 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9613 Call xg_get_pixbuf_from_pixmap instead of
9614 gdk_pixbuf_get_from_drawable.
9615 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9616 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9617 (xg_check_special_colors): Use GtkStyleContext and its functions
9619 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9620 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9621 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9622 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9623 Call gtk_widget_get_preferred_size.
9624 (xg_frame_resized): gdk_window_get_geometry only takes 5
9626 (xg_win_to_widget, xg_event_is_for_menubar):
9627 Call gdk_x11_window_lookup_for_display.
9628 (xg_set_widget_bg): New function.
9629 (delete_cb): New function.
9630 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9631 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9632 (xg_set_background_color): Call xg_set_widget_bg.
9633 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9634 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9635 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9636 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9638 (update_frame_tool_bar): Call gtk_widget_hide.
9639 (xg_initialize): Use GDK_KEY_g.
9641 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9643 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9645 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9646 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9647 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9649 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9651 * w32xfns.c (select_palette): Check success of RealizePalette against
9652 GDI_ERROR, not zero.
9654 See ChangeLog.11 for earlier changes.
9660 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9662 This file is part of GNU Emacs.
9664 GNU Emacs is free software: you can redistribute it and/or modify
9665 it under the terms of the GNU General Public License as published by
9666 the Free Software Foundation, either version 3 of the License, or
9667 (at your option) any later version.
9669 GNU Emacs is distributed in the hope that it will be useful,
9670 but WITHOUT ANY WARRANTY; without even the implied warranty of
9671 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9672 GNU General Public License for more details.
9674 You should have received a copy of the GNU General Public License
9675 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.