1 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4 that is not from display property, accept the row as a "cursor
5 row" if one of the string's character has a non-nil `cursor'
6 property. Fixes cursor positioning when there are newlines in
7 overlay strings, e.g. in icomplete.el. (Bug#11035)
9 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
11 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
13 2012-03-12 Chong Yidong <cyd@gnu.org>
15 * eval.c (inhibit_lisp_code): Rename from
16 inhibit_window_configuration_change_hook; move from window.c.
18 * xfns.c (unwind_create_frame_1, Fx_create_frame):
19 * window.c (run_window_configuration_change_hook)
20 (syms_of_window): Callers changed.
22 2012-03-11 Chong Yidong <cyd@gnu.org>
24 * keymap.c (Fkey_description): Doc fix (Bug#9700).
26 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
28 2012-03-10 Chong Yidong <cyd@gnu.org>
30 * frame.c (other_visible_frames): Don't assume the selected frame
31 is visible (Bug#10955).
33 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
35 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
37 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
39 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
40 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
43 2012-03-03 Glenn Morris <rgm@gnu.org>
45 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
47 2012-03-02 Eli Zaretskii <eliz@gnu.org>
49 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
50 position past the first glyph_row that ends at ZV. (Bug#10902)
51 (redisplay_window, next_element_from_string): Fix typos in
53 (redisplay_window): Pass to move_it_vertically the margin in
54 pixels, not in screen lines.
56 2012-03-02 Glenn Morris <rgm@gnu.org>
58 * buffer.c (buffer-list-update-hook): Doc fix.
60 2012-02-29 Eli Zaretskii <eliz@gnu.org>
62 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
63 push_it before setting up the iterator for the first overlay
64 string, even if we have an empty string loaded.
65 (next_overlay_string): If there's an empty string on the iterator
66 stack, pop the stack. (Bug#10903)
68 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
70 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
71 Suggested by Stefan Monnier in
72 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
73 * alloc.c (widen_to_Lisp_Object): New static function.
74 (mark_memory): Also mark Lisp_Objects by fetching pointer words
75 and widening them to Lisp_Objects. This would work even if
76 USE_LSB_TAG is defined and wide integers are used, which might
77 happen in a future version of Emacs.
79 2012-02-25 Chong Yidong <cyd@gnu.org>
81 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
84 * xselect.c (Fx_selection_exists_p): Doc fix.
85 (x_clipboard_manager_save_all): Print an informative message
86 before saving to clipboard manager.
88 2012-02-24 Chong Yidong <cyd@gnu.org>
90 * keyboard.c (process_special_events): Handle all X selection
91 requests in kbd_buffer, not just the next one (Bug#8869).
93 2012-02-23 Chong Yidong <cyd@gnu.org>
95 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
96 call when setting menu-bar-lines and tool-bar-lines parameters.
97 (unwind_create_frame_1): New helper function.
99 * window.c (inhibit_window_configuration_change_hook): New var.
100 (run_window_configuration_change_hook): Obey it.
101 (syms_of_window): Initialize it.
103 2012-02-22 Chong Yidong <cyd@gnu.org>
105 * xterm.c (x_draw_image_relief): Add missing type check for
106 Vtool_bar_button_margin (Bug#10743).
108 2012-02-21 Chong Yidong <cyd@gnu.org>
110 * fileio.c (Vfile_name_handler_alist): Doc fix.
112 * buffer.c (Fget_file_buffer): Protect against invalid file
113 handler return value.
115 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
117 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
118 when computing $valmask.
120 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
121 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
122 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
123 It's useless in that case, and it can cause problems on hosts
124 that allocate halves of EMACS_INT values separately.
125 Reported by Dan Horák. Diagnosed by Andreas Schwab in
126 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
127 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
128 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
129 it avoids undefined behavior on hosts where shifting right by more
130 than the word width has undefined behavior.
132 2012-02-19 Chong Yidong <cyd@gnu.org>
134 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
135 (Funhandled_file_name_directory, Ffile_name_as_directory)
136 (Fdirectory_file_name, Fexpand_file_name)
137 (Fsubstitute_in_file_name): Protect against invalid file handler
138 return values (Bug#10845).
140 2012-02-18 Eli Zaretskii <eliz@gnu.org>
142 * .gdbinit (pitx): Fix incorrect references to fields of the
145 2012-02-17 Chong Yidong <cyd@gnu.org>
147 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
149 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
151 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
152 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
154 2012-02-15 Chong Yidong <cyd@gnu.org>
156 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
157 marked as special. Also, starting docstrings with * is obsolete.
159 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
161 * gnutls.c (emacs_gnutls_write): Fix last change.
163 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
165 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
168 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
170 * keymap.c (Fsingle_key_description): Handle char ranges.
172 2012-02-12 Chong Yidong <cyd@gnu.org>
174 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
175 as that creates a dangerous corner case.
177 * window.c (Fdelete_window_internal): Invalidate the mouse
178 highlight (Bug#9904).
180 2012-02-12 Glenn Morris <rgm@gnu.org>
182 * xselect.c (Fx_own_selection_internal)
183 (Fx_get_selection_internal, Fx_disown_selection_internal)
184 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
185 * nsselect.m (Fx_own_selection_internal)
186 (Fx_disown_selection_internal, Fx_selection_exists_p)
187 (Fx_selection_owner_p, Fx_get_selection_internal):
188 Sync docs and argument specs with the xselect.c versions.
190 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
192 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
194 2012-02-11 Eli Zaretskii <eliz@gnu.org>
196 * w32select.c (Fx_selection_exists_p): Sync doc string and
197 argument list with xselect.c. (Bug#10783)
199 * w16select.c (Fx_selection_exists_p): Sync doc string and
200 argument list with xselect.c. (Bug#10783)
202 2012-02-10 Glenn Morris <rgm@gnu.org>
204 * fns.c (Fsecure_hash): Doc fix.
206 2012-02-09 Kenichi Handa <handa@m17n.org>
208 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
210 2012-02-07 Chong Yidong <cyd@gnu.org>
212 * buffer.c (Fbuffer_local_variables)
213 (buffer_lisp_local_variables): Handle unbound vars correctly;
214 don't let Qunbound leak into Lisp.
216 2012-02-07 Glenn Morris <rgm@gnu.org>
218 * image.c (Fimagemagick_types): Doc fix.
220 * image.c (imagemagick-render-type): Change it from a lisp object
221 to an integer. Move the doc here from the lisp manual.
222 Treat all values not equal to 0 the same.
224 2012-02-06 Chong Yidong <cyd@gnu.org>
226 * doc.c (store_function_docstring): Avoid applying docstring of
227 alias to base function (Bug#2603).
229 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
231 * .gdbinit (pp1, pv1): Remove redundant defines.
234 2012-02-04 Chong Yidong <cyd@gnu.org>
236 * nsterm.m: Declare a global (Bug#10694).
238 2012-02-04 Eli Zaretskii <eliz@gnu.org>
240 * w32.c (get_emacs_configuration_options):
241 Include --enable-checking, if specified, in the return value.
243 2012-02-04 Martin Rudalics <rudalics@gmx.at>
245 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
246 after rounding frame sizes. (Bug#9723)
248 2012-02-04 Eli Zaretskii <eliz@gnu.org>
250 * keyboard.c (adjust_point_for_property): Don't position point
251 before BEGV. (Bug#10696)
253 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
255 Handle overflow when computing char display width (Bug#9496).
256 * character.c (char_width): Return EMACS_INT, not int.
257 (char_width, c_string_width): Check for overflow when
258 computing the width; this is possible now that individual
259 characters can have unbounded width. Problem introduced
260 by merge from Emacs 23 on 2012-01-19.
262 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
264 * dbusbind.c (Fdbus_register_method): Mention the return value
265 :ignore in the docstring.
267 2012-02-02 Glenn Morris <rgm@gnu.org>
269 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
272 Unconditionally set to t. (Bug#10673)
273 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
274 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
275 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
277 2012-02-02 Kenichi Handa <handa@m17n.org>
279 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
280 0, do not call append_composite_glyph.
282 2012-02-02 Kenichi Handa <handa@m17n.org>
284 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
286 (x_produce_glyphs): If the component of a composition is a null
287 string, set it->pixel_width to 1 to avoid zero-width glyph.
289 2012-02-01 Eli Zaretskii <eliz@gnu.org>
291 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
292 first 2 arguments are identical. This makes inserting large
293 output from a subprocess an order of magnitude faster on
294 MS-Windows, where all sbrk'ed memory is always contiguous.
296 2012-01-31 Glenn Morris <rgm@gnu.org>
298 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
299 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
300 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
302 2012-01-29 Glenn Morris <rgm@gnu.org>
304 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
306 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
308 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
310 2012-01-28 Chong Yidong <cyd@gnu.org>
312 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
314 2012-01-26 Chong Yidong <cyd@gnu.org>
316 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
318 * search.c (Fsearch_forward, Fsearch_backward): Document negative
319 repeat counts (Bug#10507).
321 2012-01-26 Glenn Morris <rgm@gnu.org>
323 * lread.c (syms_of_lread): Doc fix.
325 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
327 * coding.c (encode_designation_at_bol): Change return value to
330 2012-01-25 Chong Yidong <cyd@gnu.org>
332 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
334 2012-01-21 Chong Yidong <cyd@gnu.org>
336 * floatfns.c (Fcopysign): Make the second argument non-optional,
337 since nil is not allowed anyway.
339 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
341 * process.c (read_process_output): Use p instead of XPROCESS (proc).
342 (send_process): Likewise.
344 2012-01-19 Martin Rudalics <rudalics@gmx.at>
346 * window.c (save_window_save, Fcurrent_window_configuration)
347 (Vwindow_persistent_parameters): Do not use Qstate.
350 2012-01-19 Kenichi Handa <handa@m17n.org>
352 * character.c (char_width): New function.
353 (Fchar_width, c_string_width, lisp_string_width):
354 Use char_width (Bug#9496).
356 2012-01-16 Martin Rudalics <rudalics@gmx.at>
358 * window.c (Vwindow_persistent_parameters): New variable.
359 (Fset_window_configuration, save_window_save): Handle persistent
362 2012-01-14 Eli Zaretskii <eliz@gnu.org>
364 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
365 thrashing the stack of the thread. (Bug#9087)
367 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
369 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
371 2012-01-11 Eli Zaretskii <eliz@gnu.org>
373 * xdisp.c (rows_from_pos_range): Handle the case where the
374 highlight ends on a newline. (Bug#10464)
375 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
376 he end column for display of highlight that ends on a newline
379 2012-01-11 Glenn Morris <rgm@gnu.org>
381 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
382 from load-path also when installation-directory is nil. (Bug#10208)
384 2012-01-10 Glenn Morris <rgm@gnu.org>
386 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
388 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
389 Update template values to be closer to their typical values these days.
391 2012-01-09 Eli Zaretskii <eliz@gnu.org>
393 * xdisp.c (rows_from_pos_range): Accept additional argument
394 DISP_STRING, and accept any glyph in a row whose object is that
395 string as eligible for mouse highlight. Fixes mouse highlight of
396 display strings from overlays. (Bug#10464)
398 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
400 emacs: fix an auto-save permissions race condition (Bug#10400)
401 * fileio.c (auto_saving_dir_umask): New static var.
402 (Fmake_directory_internal): Use it.
403 (do_auto_save_make_dir): Set it, instead of invoking chmod after
404 creating the directory. The old code temporarily assigns
405 too-generous permissions to the directory.
406 (do_auto_save_eh): Clear it.
407 (Fdo_auto_save): Catch all errors, not just file errors, so
408 that the var is always cleared.
410 2012-01-07 Eli Zaretskii <eliz@gnu.org>
412 * search.c (scan_buffer): Pass character positions to
413 know_region_cache, not byte positions. (Bug#6540)
415 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
417 * w32.c (sys_rename): Report EXDEV when rename of a directory
418 fails because the target is on another logical disk. (Bug#10284)
420 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
422 * xterm.c (x_embed_request_focus): New function.
424 * xterm.h: Add prototype.
426 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
428 2012-01-05 Glenn Morris <rgm@gnu.org>
430 * emacs.c (emacs_copyright): Update short copyright year to 2012.
432 2012-01-01 Eli Zaretskii <eliz@gnu.org>
434 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
435 Load gnutls_transport_set_lowat only if GnuTLS version is below
437 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
438 GnuTLS versions below 2.11.1.
440 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
442 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
443 to the doc string advising against its use for altering the way
444 windows are scrolled.
446 2011-12-28 Kenichi Handa <handa@m17n.org>
448 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
449 coding-system ASCII compatible only when it does not produce BOM
450 on encoding (Bug#10383).
452 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
454 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
456 (create_and_show_popup_menu): Always use menu_position_func for
459 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
461 * callint.c (Fcall_interactively): Don't truncate prompt string.
463 2011-12-23 Eli Zaretskii <eliz@gnu.org>
465 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
466 property that ends at ZV, so that the bidi iteration could be
467 resumed from there (after widening). (Bug#10360)
469 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
471 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
473 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
475 * nsterm.m (x_free_frame_resources):
476 Release f->output_data.ns->miniimage.
477 (ns_index_color): Fix indentation. Do not retain
478 color_table->colors[i].
480 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
483 * nsfns.m (x_set_background_color): Assign return value from
484 ns_index_color to face-background instead of NSColor*.
485 (ns_implicitly_set_icon_type): Fix indentation.
486 Change assignment in for loop to comparison.
488 * emacs.c (ns_pool): New variable.
489 (main): Assign ns_pool.
490 (Fkill_emacs): Call ns_release_autorelease_pool.
492 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
493 autorelease fdesc, release fdAttrs and tdict.
494 (ns_get_covering_families): Release charset.
495 (ns_findfonts): Release NSFontDescriptor created with new.
496 (ns_uni_to_glyphs): Fix indentation.
497 (setString): Release attrStr before assigning new value.
499 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
501 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
503 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
504 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
506 2011-12-18 David Reitter <reitter@cmu.edu>
508 * nsterm.m (ns_term_init): Subscribe for notifications
509 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
510 to method trackingNotification in EmacsMenu.
512 * nsmenu.m (trackingMenu): New variable.
513 (trackingNotification): New method (from Aquamacs).
514 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
515 from Aquamacs (Bug#7030).
517 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
519 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
520 (symbol_to_nsstring): Fix indentation.
521 (ns_symbol_to_pb): New function.
522 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
523 (Fns_rotate_cut_buffers_internal): Remove.
524 (Fns_store_selection_internal): Rename from
525 Fns_store_cut_buffer_internal.
526 (ns_get_foreign_selection, Fx_own_selection_internal)
527 (Fx_disown_selection_internal, Fx_selection_exists_p)
528 (Fns_get_selection_internal, Fns_store_selection_internal):
529 Use ns_symbol_to_pb and check if return value is nil.
530 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
531 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
532 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
533 renamed to Sns_store_selection_internal.
534 (ns_handle_selection_request): Move code to Fx_own_selection_internal
535 and remove this function.
536 (ns_handle_selection_clear): Remove, never used.
537 (Fx_own_selection_internal): Move code from ns_handle_selection_request
540 2011-12-17 Ken Brown <kbrown@cornell.edu>
542 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
543 GID is unknown (Bug#10257).
545 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
547 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
548 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
549 which caused a build failure on GNU/Linux IA-64. This problem was
550 introduced by my 2011-10-07 patch.
552 2011-12-15 Juri Linkov <juri@jurta.org>
554 * image.c (imagemagick_error): New function. (Bug#10112)
555 (imagemagick_load_image): Comment out `MagickSetResolution' call.
556 Use `imagemagick_error' where ImageMagick functions return
558 (Fimagemagick_types): Add `Fnreverse' to return the list in the
561 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
563 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
564 fill background (Bug#8992).
566 2011-12-13 Martin Rudalics <rudalics@gmx.at>
568 * window.c (Vwindow_combination_resize)
569 (Vwindow_combination_limit): Use t instead of non-nil in
571 (Vrecenter_redisplay): Add first sentence of doc-string on
573 (Frecenter): Fix doc-string typo.
575 2011-12-11 Kenichi Handa <handa@m17n.org>
577 * coding.c (Funencodable_char_position): Pay attention to the
578 buffer text relocation (Bug#9389).
580 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
582 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
583 gtk_init (Bug#10100).
585 2011-12-10 Eli Zaretskii <eliz@gnu.org>
587 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
588 IT->string is nil. (Bug#10263)
590 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
592 * nsterm.h (x_free_frame_resources): Declare.
594 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
595 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
597 * nsterm.h (ns_get_defaults_value): Declare.
599 * nsterm.m (ns_default): Call ns_get_defaults_value.
601 2011-12-09 Eli Zaretskii <eliz@gnu.org>
603 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
606 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
608 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
609 that where the value of an _OBJC_* symbol points to is in the .bss
612 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
614 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
615 after the loop to call ccl_driver at least once (Bug#8619).
617 2011-12-08 Kenichi Handa <handa@m17n.org>
619 * ftfont.c (get_adstyle_property): Fix previous change
622 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
624 * w32.c (init_environment): If no_site_lisp, remove site-lisp
625 dirs from the default value of EMACSLOADPATH (bug#10208).
627 2011-12-07 Glenn Morris <rgm@gnu.org>
629 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
630 installation and source directories as well. (Bug#10208)
632 2011-12-06 Chong Yidong <cyd@gnu.org>
634 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
636 2011-12-06 Glenn Morris <rgm@gnu.org>
638 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
639 as an error, not just -1. (Bug#10217)
641 2011-12-05 Chong Yidong <cyd@gnu.org>
643 * keyboard.c (process_special_events): New function.
644 (swallow_events, Finput_pending_p): Use it (Bug#10195).
646 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
648 * coding.c (encode_designation_at_bol): Don't use uninitialized
649 local variable (Bug#9318).
651 2011-12-05 Kenichi Handa <handa@m17n.org>
653 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
654 return Qnil (Bug#8046, Bug#10193).
656 2011-12-05 Kenichi Handa <handa@m17n.org>
658 * coding.c (encode_designation_at_bol): New args charbuf_end and
659 dst. Return the number of produced bytes. Callers changed.
660 (coding_set_source): Return how many bytes coding->source was
662 (coding_set_destination): Return how many bytes
663 coding->destination was relocated.
664 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
665 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
667 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
669 * coding.c (CODING_CHAR_CHARSET_P): New macro.
670 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
673 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
675 The following changes are to fix Bug#9318.
677 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
678 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
679 (encode_coding_iso_2022, encode_coding_sjis)
680 (encode_coding_big5, encode_coding_charset): Use the above macros.
682 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
684 * lisp.h (process_quit_flag): Fix external declaration.
686 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
688 Don't macro-inline non-performance-critical code.
689 * eval.c (process_quit_flag): New function.
690 * lisp.h (QUIT): Use it.
692 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
694 * nsfns.m (get_geometry_from_preferences): New function.
695 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
697 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
699 * emacs.c (Qkill_emacs): Define.
700 (syms_of_emacs): Initialize it.
701 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
702 Qquit_flag to `kill-emacs' instead.
703 (quit_throw_to_read_char): Add parameter `from_signal'.
704 All callers changed. Call Fkill_emacs if requested and safe.
705 * lisp.h (QUIT): Call Fkill_emacs if requested.
707 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
709 * widget.c (update_wm_hints): Return if wmshell is null.
710 (widget_update_wm_size_hints): New function.
712 * widget.h (widget_update_wm_size_hints): Declare.
714 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
715 widget_update_wm_size_hints (Bug#10104).
717 2011-12-03 Eli Zaretskii <eliz@gnu.org>
719 * xdisp.c (handle_invisible_prop): If the invisible text ends just
720 before a newline, prepare the bidi iterator for consuming the
721 newline, and keep the current paragraph direction. (Bug#10183)
722 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
724 2011-12-02 Juri Linkov <juri@jurta.org>
726 * search.c (Fword_search_regexp): New Lisp function created from
727 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
728 (Fword_search_backward, Fword_search_forward)
729 (Fword_search_backward_lax, Fword_search_forward_lax):
730 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
731 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
733 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
735 * fileio.c (Finsert_file_contents): Move after-change-function call
736 to before the "handled:" label, since all "goto handled" appear in
737 cases where the *-change-functions have already been properly called
740 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
742 * keyboard.c (interrupt_signal): Don't call kill-emacs when
743 waiting for input. (Bug#10169)
745 2011-11-30 Eli Zaretskii <eliz@gnu.org>
747 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
748 verifies glyph row's hash code--we have just reallocated the
749 glyphs, so their contents can be complete garbage. (Bug#10164)
751 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
753 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
755 2011-11-30 Eli Zaretskii <eliz@gnu.org>
757 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
758 attributes are tested _before_ calling verify_row_hash, to protect
759 against GCC re-ordering of the tests. (Bug#10164)
761 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
763 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
765 * xterm.c (handle_one_xevent): Only set async_visible and friends
766 if net_wm_state_hidden_seen is non-zero (Bug#10002)
767 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
768 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
770 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
772 Remove GCPRO-related macros that exist only to avoid shadowing locals.
773 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
774 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
775 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
776 All uses changed to use GCPRO1 etc.
777 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
778 Revert to old implementation (i.e., before 2011-03-11).
780 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
782 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
783 of scroll runs so as to avoid assigning disabled bogus rows and
784 unnecessary graphics copy operations.
786 2011-11-27 Eli Zaretskii <eliz@gnu.org>
788 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
789 (snprintf) [_MSC_VER]: Redirect to _snprintf.
790 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
791 (malloc, free, realloc, calloc): Redirect to e_* only when
794 * lisp.h (GCTYPEBITS): Move before first use.
795 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
796 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
797 this macro definition.
799 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
802 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
804 * gtkutil.c (xg_create_frame_widgets):
805 Call gtk_window_set_has_resize_grip (FALSE) if that function is
806 present with Gtk+ 2.0.
808 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
810 * fileio.c (Finsert_file_contents): Undo previous change; see
811 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
813 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
815 Rename locals to avoid shadowing.
816 * fileio.c (Finsert_file_contents):
817 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
818 * process.c (wait_reading_process_output):
819 Rename inner 'proc' to 'p' to avoid shadowing.
820 Indent for consistency with usual Emacs style.
822 2011-11-25 Eli Zaretskii <eliz@gnu.org>
824 * xdisp.c (redisplay_window): If cursor row is not fully visible
825 after recentering, and scroll-conservatively is set to a large
826 number, scroll window by a few more lines to make the cursor fully
827 visible and out of scroll-margin. (Bug#10105)
828 (start_display): Don't move to the next line if the display should
829 start at a newline that is part of a display vector or an overlay
832 2011-11-24 Juri Linkov <juri@jurta.org>
834 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
835 after the `MagickPingImage' call. (Bug#10112)
837 2011-11-23 Chong Yidong <cyd@gnu.org>
839 * window.c (Fcoordinates_in_window_p): Accept only live windows.
841 2011-11-23 Martin Rudalics <rudalics@gmx.at>
843 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
844 making another buffer current. (Bug#10114)
846 2011-11-23 Glenn Morris <rgm@gnu.org>
848 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
850 2011-11-23 Chong Yidong <cyd@gnu.org>
852 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
855 2011-11-22 Eli Zaretskii <eliz@gnu.org>
857 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
858 and header-lines, as they don't have one computed for them.
861 * .gdbinit (prow): Make displayed values more self-explaining.
864 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
866 * process.c (wait_reading_process_output): Fix asynchrounous
867 GnuTLS socket handling on some versions of the GnuTLS library.
868 (wait_reading_process_output): Add comment and URL.
870 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
872 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
874 2011-11-21 Chong Yidong <cyd@gnu.org>
876 * window.c (Fnext_window, Fprevious_window): Doc fix.
878 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
880 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
882 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
884 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
886 2011-11-20 Martin Rudalics <rudalics@gmx.at>
888 * window.c (Fset_window_combination_limit): Rename argument
890 (Vwindow_combination_limit): Remove "status" from doc-string.
892 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
894 * m/ibms390.h: Remove.
895 * m/ibms390x.h: Don't include "ibms390.h".
897 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
899 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
900 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
902 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
904 * casetab.c (Fset_case_table):
905 * charset.c (Fcharset_after): Fix typos.
907 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
909 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
910 Otherwise, valgrind does not work on some platforms.
911 Problem reported by Andreas Schwab in
912 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
913 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
914 is set, removing the need for VIRT_ADDRESS_VARIES.
915 (PURE_P): Use a more-efficient implementation that needs just one
916 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
917 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
918 to 4 (xorl, subq, cmpq, setbe).
919 * alloc.c (pure): Always extern now, since that's the
920 VIRT_ADDR_VARIES behavior.
921 (PURE_POINTER_P): Use a single comparison, not two, for
922 consistency with the new puresize.h.
923 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
924 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
925 Remove VIRT_ADDR_VARIES no longer needed.
927 2011-11-19 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
930 (erase_phys_cursor, update_window_cursor, show_mouse_face)
931 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
932 behave as if the cursor position were at the window margin.
934 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
935 and the cursor position is out of bounds, behave as if the cursor
936 position were at the window margin. (Bug#10075)
938 2011-11-18 Chong Yidong <cyd@gnu.org>
940 * window.c (Fwindow_combination_limit): Make first argument
941 non-optional, since it is meaningless for live windows like the
944 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
946 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
948 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
950 * intervals.c: Fix grafting over the whole buffer (bug#10071).
951 (graft_intervals_into_buffer): Simplify.
953 2011-11-18 Eli Zaretskii <eliz@gnu.org>
955 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
956 hash values of the two rows.
957 (copy_row_except_pointers): Preserve the used[] arrays and the
958 hash values of the two rows. (Bug#10035)
959 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
961 * xdisp.c (row_hash): New function, body extracted from
962 compute_line_metrics.
963 (compute_line_metrics): Call row_hash, instead of computing the
966 * dispnew.c (verify_row_hash): Call row_hash for computing the
967 hash code of a row, instead of duplicating code from xdisp.c.
969 * dispextern.h (row_hash): Add prototype.
971 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
973 * frame.c (delete_frame): Don't delete the terminal when the last
974 X frame is closed if emacs is built with GTK toolkit.
976 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
978 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
980 2011-11-17 Martin Rudalics <rudalics@gmx.at>
982 * window.c (Vwindow_splits): Rename to
983 Vwindow_combination_resize. Suggested by Juri Linkov.
984 (Fsplit_window_internal): Use Vwindow_combination_resize instead
987 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
989 * nsfns.m (Fns_font_name):
990 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
992 2011-11-16 Martin Rudalics <rudalics@gmx.at>
994 * window.h (window): Rename slot "nest" to "combination_limit".
995 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
996 (Fset_window_nest): Rename to Fset_window_combination_limit.
997 (Vwindow_nest): Rename to Vwindow_combination_limit.
998 (recombine_windows, make_parent_window, make_window)
999 (Fsplit_window_internal, saved_window)
1000 (Fset_window_configuration, save_window_save): Rename all
1001 occurrences of window_nest to window_combination_limit.
1003 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1005 * image.c (imagemagick_load_image): Fix typo.
1007 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1009 * xdisp.c (display_line): Move the call to
1010 highlight_trailing_whitespace before the call to
1011 compute_line_metrics, since the latter needs to see the final
1012 faces of all the glyphs to compute ROW's hash value.
1013 Fixes assertion violations in row_equal_p. (Bug#10035)
1015 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1017 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1018 just return (bug#10044).
1020 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1022 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1023 with user-defined heap size. Bump the default size of the temacs
1024 heap to 27MB, to avoid memory warning when running temacs.
1025 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1027 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1028 current_matrix and desired_matrix. (Bug#9990)
1029 (verify_row_hash) [XASSERTS]: New function.
1030 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1031 that the hash value of glyph rows is correct.
1033 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1035 * window.h (window): Remove splits slot.
1036 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1037 (Fdelete_other_windows_internal, make_parent_window)
1038 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1039 (Fset_window_configuration, save_window_save): Don't deal with
1040 split status of windows.
1041 (saved_window): Remove splits slot.
1042 (Vwindow_splits): Rewrite doc-string.
1044 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1046 * xfns.c (unwind_create_frame):
1047 * nsfns.m (unwind_create_frame):
1048 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1049 Vframe_list (Bug#9999).
1051 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1053 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1055 2011-11-11 Kenichi Handa <handa@m17n.org>
1057 * callproc.c (Fcall_process): Set the member dst_multibyte of
1060 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1062 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1063 avoid a crash (bug#9496).
1065 2011-11-09 Chong Yidong <cyd@gnu.org>
1067 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1068 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1070 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1072 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1074 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1076 Avoid some portability problems by eschewing 'extern inline' functions.
1077 The trivial performance wins aren't worth the portability hassles; see
1078 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1080 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1081 (window_box_width, window_box_left, window_box_left_offset)
1082 (window_box_right, window_box_right_offset): Undo previous change,
1083 by removing the "extern"s.
1084 * intervals.c (adjust_intervals_for_insertion)
1085 (adjust_intervals_for_deletion): Undo previous change,
1086 making these static again.
1087 (offset_intervals, temp_set_point_both, temp_set_point)
1088 (copy_intervals_to_string): No longer inline.
1089 * xdisp.c (window_text_bottom_y, window_box_width)
1090 (window_box_height, window_box_left_offset)
1091 (window_box_right_offset, window_box_left, window_box_right)
1092 (window_box): No longer inline.
1094 2011-11-08 Chong Yidong <cyd@gnu.org>
1096 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1097 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1098 Signal an error if not a live window.
1099 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1100 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1102 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1104 * lisp.h (syms_of_abbrev): Remove declaration.
1105 Reported by CHENG Gao <chenggao@royau.me>.
1107 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1109 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1110 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1111 of temacs in GUI mode.
1113 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1115 * window.h: Declare delete_all_child_windows instead of
1116 delete_all_subwindows.
1117 * window.c (Fwindow_nest, Fset_window_nest)
1118 (Fset_window_new_total, Fset_window_new_normal)
1119 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1120 (delete_all_subwindows): Rename to delete_all_child_windows.
1121 (Fdelete_other_windows_internal, Fset_window_configuration):
1122 Call delete_all_child_windows instead of delete_all_subwindows.
1123 * frame.c (delete_frame): Call delete_all_child_windows instead
1124 of delete_all_subwindows.
1126 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1128 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1129 This is also needed for porting to any host where GC_MARK_STACK is
1130 not GC_MAKE_GCPROS_NOOPS.
1131 (which_symbols): Use it.
1133 2011-11-07 Kenichi Handa <handa@m17n.org>
1135 * coding.c (coding_set_destination): Check coding->src_pos only
1136 when coding->src_object is a buffer (bug#9910).
1138 * process.c (send_process): Set the member src_multibyte of coding
1139 to 0 (bug#9911) when sending a unibyte text.
1141 * callproc.c (Fcall_process): Set the member src_multibyte of
1142 process_coding to 0 (bug#9912).
1144 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1146 * xmenu.c (cleanup_widget_value_tree): New function.
1147 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1148 calling free_menubar_widget_value_tree directly (Bug#9830).
1150 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1152 Fix some portability problems with 'inline'.
1153 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1154 (window_box_width, window_box_left, window_box_left_offset)
1155 (window_box_right, window_box_right_offset): Declare extern.
1156 Otherwise, these inline functions do not conform to C99 and
1157 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1158 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1159 * intervals.c (adjust_intervals_for_insertion)
1160 (adjust_intervals_for_deletion): Now extern, because otherwise the
1161 extern inline functions 'offset_intervals' couldn't refer to it.
1162 (static_offset_intervals): Remove.
1163 (offset_intervals): Rewrite using the old contents of
1164 static_offset_intervals. The old version didn't conform to C99
1165 because an extern inline function contained a reference to an
1166 identifier with static linkage.
1168 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1170 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1173 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1175 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1176 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1177 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1178 return Qleft_to_right.
1180 2011-11-06 Chong Yidong <cyd@gnu.org>
1182 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1183 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1184 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1185 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1186 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1187 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1188 (Fwindow_vscroll): Doc fix.
1189 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1190 argument, since it makes no sense to pass a live window and for
1191 consistency with window-child.
1193 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1195 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1198 2011-11-05 Jason Rumney <jasonr@gnu.org>
1200 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1201 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1203 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1204 bitwise arithmetic preventing use of unicode-sip and non-truetype
1207 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1209 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1212 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1213 initialization code to keep similarity to xfns.c after changes
1216 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1218 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1219 (unwind_create_frame): New function (Bug#9943).
1220 (Fx_create_frame): Restructure code to be more similar to the one in
1221 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1222 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1223 Move terminal->reference_count++ just before making the frame official
1226 * nsterm.m (x_free_frame_resources): New function.
1227 (x_destroy_window): Move code to x_free_frame_resources.
1229 * xfns.c (unwind_create_frame): Fix comment.
1230 (Fx_create_frame, x_create_tip_frame):
1231 Move terminal->reference_count++ just before making the frame
1232 official. Move initialization of image_cache_refcount and
1233 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1235 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1237 Support MSVC build with newer versions of Visual Studio.
1238 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1239 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1242 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1243 which are not supported by MSVC.
1244 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1245 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1247 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1249 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1251 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1253 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1255 Support MSVC build with newer versions of Visual Studio.
1256 * w32.c: Don't include w32api.h for MSVC.
1257 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1259 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1260 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1261 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1262 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1264 (alloca) [_MSC_VER]: Define to _alloca.
1266 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1268 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1270 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1272 * xdisp.c (note_mouse_highlight): If either of
1273 previous/next-single-property-change returns nil, treat that as
1274 the beginning or the end of the buffer. (Bug#9955)
1276 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1278 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1279 label is not null (Bug#9951).
1280 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1283 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1285 * window.c (Fwindow_body_size): Mention in the doc string that the
1286 return value is in frame's canonical units. (Bug#9949)
1288 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1290 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1292 * w32fns.c (unwind_create_frame): If needed, free the glyph
1293 matrices of the partially constructed frame. (Bug#9943)
1294 * xfns.c (unwind_create_frame): Likewise.
1296 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1298 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1299 Don't stop backward scan on the continuation glyph, even though
1300 its CHARPOS is positive.
1301 (mouse_face_from_buffer_pos, note_mouse_highlight):
1302 Rename cover_string to disp_string.
1304 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1306 * window.c (temp_output_buffer_show): Don't use
1307 Vtemp_buffer_show_specifiers.
1308 (Vtemp_buffer_show_specifiers): Remove unused variable.
1310 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1312 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1313 past the beginning of the current glyph matrix.
1315 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1317 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1318 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1319 HAVE_GTK3 (Bug#9869).
1321 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1322 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1324 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1326 * xterm.c: Declare x_handle_net_wm_state to return int.
1327 (handle_one_xevent): Check if we are iconified but don't have
1328 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1329 (get_current_wm_state): Return non-zero if not hidden,
1330 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1331 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1332 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1333 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1335 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1337 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1338 so that this new function doesn't get optimized away by a
1339 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1341 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1343 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1345 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1347 Fix the `xbytecode' command.
1348 * .gdbinit (xprintbytestr): New command.
1349 (xwhichsymbols): Rename from `which'; all callers changed.
1350 (xbytecode): Print the byte-code string as well.
1352 2011-10-29 Kim Storm <storm@cua.dk>
1354 * alloc.c (which_symbols): New function.
1356 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1358 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1361 2011-10-29 Glenn Morris <rgm@gnu.org>
1363 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1364 Not clear what it was for, and it causes various bugs. (Bug#9839)
1366 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1368 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1369 possible random value that matches one of those tested as
1370 condition to clear the mouse face.
1372 2011-10-28 Chong Yidong <cyd@gnu.org>
1374 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1376 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1378 * window.c (make_window): Initialize phys_cursor_on_p.
1380 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1382 * lisp.h (struct Lisp_Symbol): Update comments.
1384 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1386 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1388 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1390 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1391 <oslsachem@gmail.com> for helping to debug this.
1393 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1394 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1395 (g_b_init_get_glyph_outline_w): New static variables.
1396 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1397 (GetGlyphOutlineW_Proc): New typedefs.
1398 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1399 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1401 (w32font_open_internal, compute_metrics):
1402 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1403 instead of calling the "wide" APIs directly.
1405 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1407 * w32.h (syms_of_w32font): Add prototype.
1409 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1411 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1412 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1413 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1414 (Fmove_to_window_line): Doc fix.
1416 2011-10-27 Chong Yidong <cyd@gnu.org>
1418 * process.c (make_process): Set gnutls_state to NULL.
1420 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1421 non-NULL, regardless of GNUTLS_INITSTAGE.
1422 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1423 an error. Set process slots as soon as we allocate them.
1425 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1427 2011-10-27 Chong Yidong <cyd@gnu.org>
1429 * gnutls.c (emacs_gnutls_deinit): New function.
1430 Deallocate credentials structures as well as calling gnutls_deinit.
1431 (Fgnutls_deinit, Fgnutls_boot): Use it.
1433 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1434 (deactivate_process): Call emacs_gnutls_deinit.
1436 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1438 * image.c (x_create_x_image_and_pixmap):
1439 * w32.c (sys_rename, w32_delayed_load):
1440 * w32font.c (fill_in_logfont):
1441 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1443 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1445 * w32fns.c (w32_default_color_map): New function,
1446 extracted from Fw32_default_color_map.
1447 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1449 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1451 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1453 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1455 * keyboard.c (test_undefined): New function (bug#9751).
1456 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1458 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1460 * sysdep.c (init_sys_modes): Fix the check for the controlling
1461 terminal (Bug#6649).
1463 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1465 * dispextern.h (struct bidi_it): New member next_en_type.
1467 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1468 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1469 current character, check also for next_en_type being WEAK_EN.
1470 (bidi_resolve_weak): Don't enter the expensive loop if the current
1471 position is before next_en_pos. Record the bidi type of the first
1472 non-ET, non-BN character we find, in addition to its position.
1473 (bidi_level_of_next_char): Invalidate next_en_type when
1474 next_en_pos is over-stepped.
1476 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1478 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1479 * editfns.c: Rewrite current-time-zone so that it invokes
1480 the equivalent of (format-time-string "%Z") to get the time zone name.
1481 This fixes a bug when the time zone name contains characters that
1482 need converting from the system time locale to Emacs internal format.
1483 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1484 that patch fixed format-time-string to do the conversion, but
1485 I forgot to fix current-time-zone.
1486 (format_time_string): New function, containing most of
1487 what Fformat_time_string used to contain.
1488 (Fformat_time_string): Rewrite in terms of format_time_string.
1489 This doesn't change this function's behavior.
1490 (current-time-zone): Rewrite to use format_time_string.
1491 This fixes the bug reported by Michael Schierl in
1492 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1493 Jason Rumney's 2007-06-07 change worked around this bug, but
1495 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1497 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1499 * xdisp.c (start_display): If the character at POS is displayed
1500 via a display vector, reset IT->current.dpvec_index to zero.
1501 (try_window_reusing_current_matrix): If a line ends in a display
1502 vector or the next line starts in a display vector, continue
1503 redrawing the window even though the character position of
1504 start_row was reached.
1507 2011-10-18 Chong Yidong <cyd@gnu.org>
1509 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1510 with nobreak-char-display too.
1512 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1514 Fix part 3 of bug#9771.
1515 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1516 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1517 non-neutral characters if the current character is a paragraph
1518 separator (a.k.a. Newline). This avoids running the same
1519 expensive loop twice, once when we consume the preceding newline
1520 and the other time when the line actually needs to be displayed.
1521 Avoid the loop when we see neutrals on the base embedding level
1522 following a character whose directionality is the same as the
1523 paragraph's. This avoids running the expensive loop when a line
1524 ends in a long sequence of neutrals, like control characters.
1525 Add assertion against STRONG_AL type. Slightly rearrange code
1526 that determines the type of a neutral given the first non-neutral
1528 (bidi_level_of_next_char): Set next_en_pos to zero when
1529 invalidating its info.
1531 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1533 * xdisp.c (push_display_prop): Determine whether to record string
1534 or buffer position by IT->string, not by IT->method. Allow
1535 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1536 (move_it_vertically_backward): Don't look for character position
1537 immediately after the newline when in a continuation line.
1540 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1542 * window.c (coordinates_in_window): Rewrite and delabelize
1543 vertical border check. (Bug#5357) (Bug#9618)
1545 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1547 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1548 errors in XSetWindowBorder (bug#9310).
1550 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1552 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1553 avoid crash when xmalloc overrun checking is enabled.
1555 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1557 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1558 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1559 cursor motion with <left> and <right> arrow keys.
1561 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1562 some callers set that themselves.
1564 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1566 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1567 display string and the previous row comes from the same string and
1568 is empty. (Bug#9739) (Bug#9738)
1570 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1572 * doc.c (get_doc_string): Encode file name (bug#9735).
1574 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1576 * bidi.c (bidi_level_of_next_char):
1577 * xdisp.c (get_visually_first_element): Remove old incorrect
1578 comments regarding the Unicode Line Separator character.
1580 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1582 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1584 * alloc.c (Fgc_status): Do not access beyond zombies array
1585 boundary if nzombies > MAX_ZOMBIES.
1586 * alloc.c (dump_zombies): Add missing format specifier.
1588 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1590 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1591 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1593 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1594 Some packages use them to denote characters with modifiers.
1596 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1598 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1599 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1600 matching a pp-number. Rename parameter var to var1.
1602 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1604 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1606 2011-10-08 Glenn Morris <rgm@gnu.org>
1608 * callint.c (Fcall_interactively): Give a more explicit error for the
1609 'c' case with a non-character input. (Bug#8479)
1611 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1613 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1615 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1616 lines that are hscrolled on the left.
1618 * dispnew.c (buffer_posn_from_coords): Account for a possible
1619 presence of header-line. (Bug#4426)
1621 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1623 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1624 Don't advertise functionality which we discourage or doesn't work.
1626 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1628 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1629 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1630 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1631 this makes Emacs dump core during garbage collection on rare
1632 occasions. sizeof is obviously inferior to offsetof here, so
1633 stick with offsetof.
1634 (GC_POINTER_ALIGNMENT): New macro.
1635 (mark_memory): Omit 3rd (offset) arg; caller changed.
1636 Don't assume EMACS_INT alignment is the same as pointer alignment.
1638 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1640 * keyboard.c (read_key_sequence_remapped): New var.
1641 (read_key_sequence): Compute remapping in the right buffer.
1642 (command_loop_1): Use read_key_sequence's remapping directly.
1644 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1646 * dired.c (file_name_completion): Don't expand file name.
1647 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1648 before checking file name handler.
1650 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1651 they've been requested explicitly (bug#9591).
1653 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1655 * keymap.c (Fsingle_key_description): Use make_specified_string
1656 instead of build_string to build string from push_key_description.
1659 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1661 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1662 This fixes a Y2038 bug on 64-bit hosts.
1663 * buffer.c (reset_buffer):
1664 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1665 (Fclear_buffer_auto_save_failure):
1666 Use 0, not -1, to represent an unset failure time, since time_t
1667 might not be signed.
1669 Remove dependency on glibc malloc internals.
1670 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 Move back here from lisp.h, but with their new implementations.
1672 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1673 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1674 * charset.c (charset_table_init): New static var.
1675 (syms_of_charset): Use it instead of xmalloc. This removes a
1676 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1677 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1678 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1679 Move back to alloc.c.
1680 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1681 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1683 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1685 * nsterm.m (windowDidResize): Call x_set_window_size only when
1686 ns_in_resize is true. Otherwise set pixelwidth/height and
1687 call change_frame_size (Bug#9628).
1689 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1691 Port --enable-checking=all to Fedora 14 x86-64.
1692 * charset.c (syms_of_charset): Also account for glibc malloc's
1693 internal overhead when calculating the initial malloc maximum.
1695 Port --enable-checking=all to Fedora 14 x86.
1696 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1698 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1699 (overrun_check_realloc, overrun_check_free):
1700 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1701 That way, xmalloc returns a properly-aligned pointer even if
1702 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1703 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1704 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1705 into account when calculating the initial malloc maximum.
1706 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1707 Move here from alloc.c, so that charset.c can use it too.
1708 Properly align; the old code wasn't right for common 32-bit hosts
1709 when configured with --enable-checking=all.
1710 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1711 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1713 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1715 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1718 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1720 * xdisp.c (compute_display_string_end): If there's no display
1721 string at CHARPOS, return -1.
1723 * bidi.c (bidi_fetch_char): When compute_display_string_end
1724 returns a negative value, treat the character as a normal
1725 character not covered by a display string. (Bug#9624)
1727 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1729 * lread.c (Fread_from_string): Fix typo in docstring.
1731 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1734 newline, reseat the iterator instead of bidi-iterating there one
1735 character at a time. (Bug#9610)
1736 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1737 TO_CHARPOS if the bidi iterator is at base embedding level.
1739 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1741 * lread.c (readevalloop): Use correct code for NBSP.
1742 (read1): Likewise. (Bug#9608)
1744 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1746 * dbusbind.c (Fdbus_register_signal): When service is not
1747 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1749 2011-09-25 Glenn Morris <rgm@gnu.org>
1751 * buffer.c (truncate-lines): Doc fix.
1753 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1755 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1756 (Fset_window_next_buffers): Doc fix.
1758 2011-09-24 Glenn Morris <rgm@gnu.org>
1760 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1762 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1764 Fix minor problems found by static checking.
1765 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1766 * indent.c (Fvertical_motion): Fix == vs = typo.
1768 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1770 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1771 Default value is now t. Doc fix.
1773 * indent.c (Fvertical_motion): Compute and apply the overshoot
1774 logic when moving up, not only when moving down. Fix the
1775 confusing name and values of the it_overshoot_expected variable;
1776 logic changes accordingly. (Bug#9254) (Bug#9549)
1778 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1779 CHARPOS is covered by a display string which includes newlines.
1780 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1781 is covered by a display string with embedded newlines.
1783 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1785 * dbusbind.c (Fdbus_register_signal): Add match rule to
1786 Vdbus_registered_objects_table. (Bug#9581)
1787 (Fdbus_register_method, Vdbus_registered_objects_table):
1790 2011-09-24 Jim Meyering <meyering@redhat.com>
1792 do not ignore write error for any output size
1793 The previous change was incomplete.
1794 While it makes emacs --batch detect the vast majority of stdout
1795 write failures, errors were still ignored whenever the output size is
1796 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1797 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1798 && echo FAIL: ignored write error
1799 FAIL: ignored write error
1800 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1801 && echo FAIL: ignored write error
1802 FAIL: ignored write error
1803 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1805 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1807 * emacs.c (Fkill_emacs): In noninteractive mode exit
1808 non-successfully if a write error occurred on stdout. (Bug#9574)
1810 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1812 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1815 * dispextern.h (struct it): Update the comment documenting what
1818 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1820 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1821 a display string, extend search for cursor position to end of row.
1822 (find_row_edges): If the row ends in a newline from a display
1823 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1824 Handle the case of a display string with multiple newlines.
1825 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1826 non-empty line. Fixes confusing cursor motion with arrow keys at
1827 the beginning of a line that starts with whitespace.
1829 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1831 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1834 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1836 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1839 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1841 * xdisp.c (display_line): Record maximum and minimum buffer
1842 positions even if no glyphs were produced (e.g., by a zero-width
1843 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1844 buffer positions that will be removed from the glyph row because
1846 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1847 column is beyond frame width: don't subtract 1 "pixel" when
1848 computing width of the stretch.
1849 (reseat_at_next_visible_line_start): Undo the change made on
1850 2011-09-17 that saved paragraph information and restored it after
1851 the call to `reseat'. (Bug#9545)
1853 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1855 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1856 and turn window cursor on if cleared (Bug#9415).
1858 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1860 * search.c (boyer_moore): Take unibyte characters from pattern
1861 literally. (Bug#9458)
1863 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1865 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1867 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1869 Fix minor problem found by static checking.
1870 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1871 initialized, to pacify gcc -Wuninitialized.
1873 * fileio.c: Report proper errno when syscall falls.
1874 (Finsert_file_contents): Save and restore errno,
1875 so that report_file_error outputs the correct diagnostic.
1876 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1878 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1880 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1882 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1885 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1887 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1889 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1890 about the current paragraph and restore it after the call to reseat.
1892 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1893 (bidi_find_paragraph_start): Search back for paragraph beginning
1894 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1895 (bidi_move_to_visually_next): Only trigger paragraph-related
1896 computations when the last character is a newline or at EOB, not
1897 just any NEUTRAL_B. (Bug#9470)
1899 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1900 truncated lines if point is covered by a display string. (Bug#9524)
1902 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1904 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1905 (cons_to_x_long): New function.
1906 (lisp_data_to_selection_data): Use it. Correct the test for
1907 short-versus-long data; it was negated. Break out of vector
1908 loop, for efficiency, when a long datum is discovered.
1910 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1912 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1914 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1916 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1917 GCC PR/17406) by declaring this function with external scope.
1919 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1921 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1922 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1924 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1926 * editfns.c (Fformat): Correctly handle text properties on "%%".
1928 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1930 * xterm.c (x_draw_composite_glyph_string_foreground):
1931 * w32term.c (x_draw_composite_glyph_string_foreground):
1932 * term.c (encode_terminal_code):
1933 * composite.c (composition_update_it, get_composition_id):
1934 * xdisp.c (get_next_display_element)
1935 (fill_composite_glyph_string): Add comments about special meaning
1936 of TAB characters in a composition.
1938 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1940 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1941 This occurs when processing a multibyte format.
1942 Problem reported by Wolfgang Jenker.
1944 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1946 * xdisp.c (try_cursor_movement): Only check for exact match if
1947 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1949 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1951 Remove unused external symbols.
1952 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1953 * xdisp.c (calc_pixel_width_or_height): Now static.
1954 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1955 * indent.c (check_display_width):
1956 * w32term.c: Fix comment to match code.
1957 * xterm.c, xterm.h (x_catching_errors): Remove.
1959 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1961 * xselect.c: Use signed conversions more consistently (Bug#9498).
1962 (selection_data_to_lisp_data): Assume incoming selection data are
1963 signed integers, not unsigned. This is to be consistent with
1964 outgoing selection data, which was modified to use signed integers
1965 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1966 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1967 expects long, not unsigned long.
1969 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1971 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1972 computation of loop end. Reported by Johan Bockgård
1975 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1977 * frame.c (Fother_visible_frames_p): Function deleted.
1979 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1981 * indent.c (compute_motion): Process display vector front to back
1982 rather than the other way around. (Bug#2496)
1984 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1986 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1988 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1990 * minibuf.c (Fread_from_minibuffer): Doc fix.
1992 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1994 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1995 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1997 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1999 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2000 value for non-existent files.
2002 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2004 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2005 set its "size" to -1. This will set the modtime_size field of
2006 the corresponding buffer to -1, which is what
2007 verify-visited-file-modtime expects for files that do not exist.
2010 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2012 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2014 * lisp.h: ... from here. push_key_description is no longer
2015 defined in keyboard.c, so its declaration should not be in
2016 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2017 logically belongs with push_key_description.
2019 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2021 * buffer.h: Include <sys/types.h> instead of <time.h>.
2022 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2023 Problem reported by Herbert J. Skuhra.
2025 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2027 * xml.c (parse_region): Make the parsing work for
2028 non-comment-starting XML files again (bug#9144).
2030 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2032 * image.c (gif_load): Fix calculation of bottom and right corner.
2035 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2037 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2038 redisplay in small windows.
2040 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2042 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2044 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2046 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2047 Operate on live windows only.
2049 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2051 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2053 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2055 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2056 only under bidi iteration.
2058 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2060 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2062 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2064 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2065 Without this fix, the command to link temacs failed due to an
2066 undefined symbol __builtin_isnan. This is because
2067 /usr/include/iso/math_c99.h #defines isnan(x) to
2068 __builtin_isnan(x), but the bundled gcc, which identifies itself
2069 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2071 * floatfns.c (isnan): #undef, and then #define to a clone of
2073 (Fisnan): Always define, since it's always available now.
2074 (syms_of_floatfns): Always define isnan at the Lisp level.
2076 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2078 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2080 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2082 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2083 The previous code assumed that file offsets (off_t values) fit in
2084 EMACS_INT variables, which is not true on typical 32-bit hosts.
2085 The code messed up by falsely reporting buffer overflow in cases
2086 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2087 when "big" contains more than 2**29 bytes, even though this
2088 inserts just one byte and does not overflow the buffer.
2089 (Finsert_file_contents): Store file offsets as off_t
2090 values, not as EMACS_INT values. Check for overflow when
2091 converting between EMACS_INT and off_t. When checking for
2092 buffer overflow or for overlap, take the offsets into account.
2093 Don't use EMACS_INT for small values where int suffices.
2094 When checking for overlap, fix a typo: ZV was used where
2095 ZV_BYTE was intended.
2096 (Fwrite_region): Don't assume off_t fits into 'long'.
2097 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2099 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2101 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2103 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2105 sprintf-related integer and memory overflow issues (Bug#9412).
2107 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2108 (esprintf, exprintf, evxprintf): New functions.
2109 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2110 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2111 (modify_event_symbol): Do not assume that the length of
2112 name_alist_or_stem is safe to alloca and fits in int.
2113 (Fexecute_extended_command): Likewise for function name and binding.
2114 (Frecursion_depth): Wrap around reliably on integer overflow.
2115 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2116 since some callers pass EMACS_INT values.
2117 (Fsingle_key_description): Don't crash if symbol name contains more
2118 than MAX_ALLOCA bytes.
2119 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2120 (get_minibuffer): Arg is now EMACS_INT, not int.
2121 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2122 (esprintf, exprintf, evxprintf): New decls.
2123 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2125 * dbusbind.c (signature_cat): New function.
2126 (xd_signature, Fdbus_register_signal):
2127 Do not overrun buffer; instead, report string overflow.
2129 * dispnew.c (add_window_display_history): Don't overrun buffer.
2130 Truncate instead; this is OK since it's just a log.
2132 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2133 even if the time zone offset is outlandishly large.
2134 Don't mishandle offset == INT_MIN.
2136 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2137 when creating daemon; the previous buffer-overflow check was incorrect.
2139 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2140 which has the guts of the old verror function.
2142 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2143 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2145 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2146 (font_unparse_xlfd): Don't blindly alloca long strings.
2147 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2148 fits in int, when using sprintf. Use single snprintf to count
2149 length of string rather than counting it via multiple sprintfs;
2150 that's simpler and more reliable.
2151 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2152 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2153 sprintf, in case result does not fit in int.
2155 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2156 (fontset_from_font): Print it.
2158 * frame.c (tty_frame_count): Now printmax_t, not int.
2159 (make_terminal_frame, set_term_frame_name): Print it.
2160 (x_report_frame_params): In X, window IDs are unsigned long,
2161 not signed long, so print them as unsigned.
2162 (validate_x_resource_name): Check for implausibly long names,
2163 and don't assume name length fits in 'int'.
2164 (x_get_resource_string): Don't blindly alloca invocation name;
2165 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2168 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2169 (xg_check_special_colors, xg_set_geometry):
2170 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2172 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2173 Use esprintf, not sprintf, in case result does not fit in int.
2175 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2176 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2177 it as a large positive number.
2178 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2179 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2181 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2182 in case result does not fit in int.
2184 * print.c (float_to_string): Detect width overflow more reliably.
2185 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2186 buffer overrun. Don't assume list length fits in 'int'. Treat
2187 print length of 0 as 0, not as infinity; to be consistent with other
2188 uses of print length in this function. Don't overflow print length
2189 index. Don't assume hash table size fits in 'long', or that
2190 vectorlike size fits in 'unsigned long'.
2192 * process.c (make_process): Use printmax_t, not int, to format
2193 process-name gensyms.
2195 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2197 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2198 to avoid potential buffer overrun.
2200 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2201 if X resource line is longer than 512 bytes.
2203 * xfns.c (x_window): Make sprintf buffer a bit bigger
2204 to avoid potential buffer overrun.
2206 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2208 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2210 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2212 Integer overflow fixes for scrolling, etc.
2213 Without these, Emacs silently mishandles large integers sometimes.
2214 For example, "C-u 4294967297 M-x recenter" was treated as if
2215 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2217 * xdisp.c (try_window_id): Check Emacs fixnum range before
2218 converting to 'int'.
2220 * window.c (window_scroll_line_based, Frecenter):
2221 Check that an Emacs fixnum is in range before assigning it to 'int'.
2222 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2223 values converted from Emacs fixnums.
2224 (Frecenter): Don't wrap around a line count if it is out of 'int'
2225 range; instead, treat it as an extreme value.
2226 (Fset_window_configuration, compare_window_configurations):
2227 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2229 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2230 that can exceed INT_MAX. Check that EMACS_INT value is in range
2231 before assigning it to the (possibly-narrower) index.
2232 (match_limit): Don't assume that a fixnum can fit in 'int'.
2234 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2237 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2238 (Fvertical_motion): Don't wrap around LINES values that don't fit
2239 in 'int'. Instead, treat them as extreme values. This is good
2240 enough for windows, which can't have more than INT_MAX lines anyway.
2242 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2244 * Require libxml/parser.h to avoid compilation warning.
2246 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2248 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2249 since this reportedly can destroy thread storage.
2251 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2253 * syntax.c (find_defun_start): Update all cache variables if
2254 exiting early (Bug#9401).
2256 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2258 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2260 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2261 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2262 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2264 * term.c (tty_append_glyph): New function.
2265 (produce_stretch_glyph): Static function and its prototype deleted.
2267 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2270 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2272 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2273 when checking :margin (Bug#9390).
2274 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2275 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2276 so that the name doesn't mislead. All uses changed.
2278 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2280 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2283 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2285 * xdisp.c (move_it_to): Don't bail out early when reaching
2286 position beyond to_charpos, if we are scanning backwards.
2287 (move_it_vertically_backward): When DY == 0, make sure we get to
2288 the first character in the line after the newline.
2290 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2292 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2293 (ccl_driver): Do not generate an out-of-range pointer.
2294 (Fccl_execute_on_string): Remove unnecessary check for
2295 integer overflow, noted by Stefan Monnier in
2296 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2297 Remove a FIXME that didn't need fixing.
2298 Simplify the newly-introduced buffer reallocation code.
2300 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2302 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2304 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2306 Integer and memory overflow issues (Bug#9196).
2308 * doc.c (get_doc_string): Rework so that
2309 get_doc_string_buffer_size is the actual buffer size, rather than
2310 being 1 less than the actual buffer size; this makes xpalloc more
2313 * image.c (x_allocate_bitmap_record, cache_image):
2314 * xselect.c (Fx_register_dnd_atom):
2315 Simplify previous changes by using xpalloc.
2317 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2318 since either will do and ptrdiff_t is convenient with xpalloc.
2320 * charset.c (charset_table_size)
2321 (struct charset_sort_data.priority): Now ptrdiff_t.
2322 (charset_compare): Don't overflow if priorities differ greatly.
2323 (Fsort_charsets): Don't assume list length fits in int.
2324 Check for size-calculation overflow when allocating sort data.
2325 (syms_of_charset): Allocate an initial charset table that is
2326 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2328 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2330 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2331 The actual value is always <= INT_MAX, and leaving it unsigned made
2332 overflow checking harder.
2334 * dispextern.h (struct glyph_matrix.rows_allocated)
2335 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2336 with xpalloc. The values are still always <= INT_MAX.
2338 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2340 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2341 (SAFE_NALLOCA): New macro.
2343 * region-cache.c (struct boundary.pos, find_cache_boundary)
2344 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2345 (set_cache_region, invalidate_region_cache)
2346 (revalidate_region_cache, know_region_cache, region_cache_forward)
2347 (region_cache_backward, pp_cache):
2348 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2349 so that ptrdiff_t * can be passed to xpalloc.
2350 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2351 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2352 (pp_cache): Don't assume cache_len fits in int.
2353 * region-cache.h: Adjust extern decls to match.
2355 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2356 EMACS_INT, since either will do, for xpalloc.
2358 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2359 (xnmalloc, xnrealloc, xpalloc): New functions.
2361 * bidi.c (bidi_shelve_header_size): New constant.
2362 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2363 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2365 * bidi.c (bidi_cache_shrink):
2366 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2368 Don't update size of array until after memory allocation succeeds,
2369 because xmalloc/xrealloc may not return.
2370 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2371 now that we have proper integer overflow checking.
2372 (record_overlay_string, overlay_strings): Catch overflows when
2373 calculating size of overlay_str_buf.
2375 * callproc.c (Fcall_process): Check for size overflow when
2376 calculating size of args2.
2377 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2378 Normally we prefer signed values, but sticking with ptrdiff_t would
2379 require adding more-complicated checks.
2381 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2382 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2383 Redo buffer-overflow calculations to avoid integer overflow.
2384 Add a FIXME comment where memory seems to be over-allocated.
2386 * character.c (Fstring): Check for size-calculation overflow.
2388 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2389 unnecessary integer overflow. Check for size overflow.
2390 (encode_coding_object): Don't update size until xmalloc succeeds.
2392 * composite.c (get_composition_id): Check for overflow in glyph
2393 length calculations.
2395 Integer and memory overflow fixes for display code.
2396 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2397 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2398 (scrolling_window): Check for overflow in size calculations.
2399 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2400 Don't assume glyph table len fits in int.
2401 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2402 (row_table_size): Now ptrdiff_t, not int.
2403 (scrolling_window): Avoid overflow in size calculations.
2404 Don't update size until allocation succeeds.
2405 * fns.c (concat): Check for overflow in size calculations.
2406 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2407 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2408 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2410 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2411 (get_doc_string): Check for size calculation overflow.
2412 Don't update size until allocation succeeds.
2413 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2414 EMACS_INT, where ptrdiff_t will do.
2415 (Fsubstitute_command_keys): Check for string overflow.
2417 * editfns.c (set_time_zone_rule): Don't assume environment length
2419 (message_length): Now ptrdiff_t, not int.
2420 (Fmessage_box): Don't update size until allocation succeeds.
2421 Don't assume message length fits in int.
2422 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2424 * emacs.c (main): Do not reallocate argv, since there is a null at
2425 the end that can be overwritten, and this way there's no need to
2426 worry about size-calculation overflow.
2427 (sort_args): Check for size-calculation overflow.
2429 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2431 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2433 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2434 (x_set_scroll_bar_width, x_figure_window_size):
2435 Check for integer overflow.
2436 (x_set_alpha): Do not assume XINT fits in int.
2438 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2439 This is for the members text_lines, text_cols, total_lines, total_cols,
2440 where the system imposes an 'int' limit.
2442 * fringe.c (Fdefine_fringe_bitmap):
2443 Don't update size until alloc works.
2445 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2446 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2448 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2449 Check for size-calculation overflow.
2450 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2451 do, as we prefer signed integers.
2452 (id_to_widget.max_size, id_to_widget.used)
2453 (xg_store_widget_in_map, xg_remove_widget_from_map)
2454 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2455 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2456 Use and return ptrdiff_t, not int.
2457 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2458 * gtkutil.h: Change prototypes to match the above.
2460 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2461 are duplicate now that they've been promoted to lisp.h.
2462 (x_allocate_bitmap_record, x_alloc_image_color)
2463 (make_image_cache, cache_image, xpm_load):
2464 Don't update size until alloc is done.
2465 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2467 Check for size calculation overflow.
2468 (ct_colors_allocated_max): New constant.
2469 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2472 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2473 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2474 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2475 Use ptrdiff_t, not int, to count maps.
2476 (read_char_minibuf_menu_prompt): Check for overflow in size
2477 calculations. Don't update size until allocation succeeds.
2478 Redo calculations to avoid overflow.
2479 * keyboard.h: Change prototypes to match the above.
2481 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2483 (current_minor_maps): Check for size calculation overflow.
2484 * keymap.h: Change prototypes to match the above.
2486 * lread.c (read1, init_obarray): Don't update size until alloc done.
2488 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2489 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2491 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2492 Now ptrdiff_t, not int.
2493 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2494 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2496 * process.c (Fnetwork_interface_list): Check for overflow
2497 in size calculation.
2499 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2501 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2502 overflow. Don't bother calling xmalloc when xrealloc will do.
2504 * search.c (Freplace_match): Check for size calculation overflow.
2505 (Fset_match_data): Don't assume list lengths fit in 'int'.
2507 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2508 for command line length. Do not attempt to address one before the
2509 beginning of an array, as that's not portable.
2511 * term.c (max_frame_lines): Remove; unused.
2512 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2514 (encode_terminal_code, calculate_costs): Check for size
2515 calculation overflow.
2516 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2517 table lengths and related sizes. Don't update size until alloc
2518 done. Redo calculations to avoid overflow.
2519 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2521 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2522 subtracting pointers.
2523 (gobble_line): Check for overflow more carefully. Don't update size
2526 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2527 Don't update size until alloc done.
2528 Redo size calculations to avoid overflow.
2529 Check for size calculation overflow.
2530 (main) [DEBUG]: Fix typo in invoking tparam1.
2532 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2533 Use ptrdiff_t, not int, for sizes.
2534 (store_mode_line_noprop_char): Don't update size until alloc done.
2536 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2537 Use ptrdiff_t, not int, for sizes.
2538 (Finternal_make_lisp_face, cache_face):
2539 Check for size calculation overflow.
2540 (cache_face): Treat size calculation overflows as if they were
2541 memory exhaustion (the usual treatment), rather than aborting.
2543 * xfns.c (x_encode_text, x_set_name_internal)
2544 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2545 sizes, since they can exceed INT_MAX in size. Check for size
2546 calculation overflow.
2548 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2549 (xg_select): Check for size calculation overflow.
2550 Don't update size until alloc done.
2552 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2553 as sprintf is limited to int lengths.
2555 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2556 (X_LONG_MIN): New macros.
2557 Use them to make the following changes clearer.
2558 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2559 This change doesn't affect the value now, but it may help remind
2560 future maintainers not to raise the value too much later.
2561 (SELECTION_QUANTUM): Remove, replacing with ...
2562 (selection_quantum): ... new function, which avoids overflow.
2564 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2565 assumption that selection length fits in 'int'.
2566 (x_reply_selection_request, x_handle_selection_request)
2567 (x_get_window_property, receive_incremental_selection)
2568 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2569 (lisp_data_to_selection_data, clean_local_selection_data):
2570 Use ptrdiff_t, not int, to record length of selection.
2571 (x_reply_selection_request, x_get_window_property)
2572 (receive_incremental_selection, x_property_data_to_lisp):
2573 Redo calculations to avoid overflow.
2574 (x_reply_selection_request): When sending hint, ceiling it at
2575 X_LONG_MAX rather than relying on wraparound overflow to send
2577 (x_get_window_property, receive_incremental_selection)
2578 (lisp_data_to_selection_data, x_property_data_to_lisp):
2579 Check for size-calculation overflow.
2580 (x_get_window_property, receive_incremental_selection)
2581 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2582 Don't store size until memory allocation succeeds.
2583 (x_get_window_property): Plug memory leak on memory exhaustion.
2584 Don't double-block input; malloc is safe here. Don't assume 2**34
2585 - 4 fits in unsigned long. Add an xassert to check
2586 XGetWindowProperty overflow. Be more careful about overflow
2587 calculations, and distinguish size from memory overflow better.
2588 (receive_incremental_selection): When tracing, don't assume
2589 unsigned int is less than INT_MAX.
2590 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2591 harmful) conversions of unsigned short to int.
2592 (lisp_data_to_selection_data): Don't assume that integers
2593 in the range -65535 through -1 fit in an X unsigned short.
2594 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2595 result parameters unless successful. Rely on cons_to_unsigned
2596 to report problems with elements; the old code wasn't right anyway.
2597 (x_check_property_data): Check for int overflow; we cannot use
2598 a wider type due to X limits.
2599 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2601 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2603 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2604 (x_term_init): Check for size calculation overflow.
2605 (x_color_cells): Don't store size until memory allocation succeeds.
2606 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2607 Don't assume alloca size is less than MAX_ALLOCA.
2608 (x_term_init): Don't assume length fits in int (sprintf is limited
2611 Use ptrdiff_t for composition IDs.
2612 * character.c (lisp_string_width):
2613 * composite.c (composition_table_size, n_compositions)
2614 (get_composition_id, composition_gstring_from_id):
2615 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2616 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2617 * window.c (Frecenter):
2618 Use ptrdiff_t, not int, for composition IDs.
2619 * composite.c (get_composition_id): Check for integer overflow.
2620 * composite.h: Adjust prototypes to match the above changes.
2622 Use ptrdiff_t for hash table indexes.
2623 * category.c (hash_get_category_set):
2624 * ccl.c (ccl_driver):
2625 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2626 * coding.c (coding_system_charset_list, detect_coding_system):
2627 * coding.h (struct coding_system.id):
2628 * composite.c (get_composition_id, gstring_lookup_cache):
2629 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2630 * image.c (xpm_get_color_table_h):
2631 * lisp.h (hash_lookup, hash_put):
2632 * minibuf.c (Ftest_completion):
2633 Use ptrdiff_t for hash table indexes, not int (which is too
2634 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2635 32-bit --with-wide-int hosts).
2637 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2638 Add a FIXME comment about memory leaks.
2639 (syms_of_charset): Don't assume xmalloc returns.
2641 Don't assume that stated character widths fit in int.
2642 * character.c (Fchar_width, c_string_width, lisp_string_width):
2643 * character.h (CHAR_WIDTH):
2644 * indent.c (MULTIBYTE_BYTES_WIDTH):
2645 Use sanitize_char_width to avoid undefined and/or bad behavior
2646 with outlandish widths.
2647 * character.h (sanitize_tab_width): Rename from sanitize_width,
2648 now that we have two such functions. All uses changed.
2649 (sanitize_char_width): New inline function.
2651 Don't assume that tab-width fits in int.
2652 * character.h (sanitize_width): New inline function.
2653 (SANE_TAB_WIDTH): New macro.
2654 (ASCII_CHAR_WIDTH): Use it.
2655 * indent.c (sane_tab_width): Remove. All uses replaced by
2656 SANE_TAB_WIDTH (current_buffer).
2657 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2659 * fileio.c: Integer overflow issues with file modes.
2660 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2662 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2663 Remove unreachable code.
2664 (read_hex, load_charset_map_from_file): Check for integer overflow.
2666 * xterm.c: Don't go over XClientMessageEvent limit.
2667 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2668 (x_send_scroll_bar_event): Likewise. Check that the size does not
2669 exceed limits imposed by XClientMessageEvent, as well as the usual
2670 ptrdiff_t and size_t limits.
2672 * keyboard.c: Overflow, signedness and related fixes.
2673 (make_lispy_movement): Use same integer type in forward decl
2674 that is used in the definition.
2675 (read_key_sequence, keyremap_step):
2676 Change bufsize argument back to int, undoing my 2011-03-30 change.
2677 We prefer signed types, and int is wide enough here.
2678 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2679 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2680 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2681 length, not size_t. Use ptrdiff_t for index, not int.
2682 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2683 possibility of integer overflow.
2685 Overflow, signedness and related fixes for images.
2687 * dispextern.h (struct it.stack[0].u.image.image_id)
2688 (struct_it.image_id, struct image.id, struct image_cache.size)
2689 (struct image_cache.used, struct image_cache.ref_count):
2690 * gtkutil.c (update_frame_tool_bar):
2691 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2692 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2693 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2694 * nsmenu.m (update_frame_tool_bar):
2695 * xdisp.c (calc_pixel_width_or_height):
2696 * xfns.c (image_cache_refcount):
2697 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2698 on typical 64-bit hosts.
2700 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2701 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2702 Omit unnecessary casts to int.
2703 (parse_image_spec): Check that integers fall into 'int' range
2704 when the callers expect that.
2705 (image_ascent): Redo ascent calculation to avoid int overflow.
2706 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2707 (lookup_image): Remove unnecessary tests.
2708 (xbm_image_p): Locals are now of int, not EMACS_INT,
2709 since parse_image_check makes sure they fit into int.
2710 (png_load, gif_load, svg_load_image):
2711 Prefer int to unsigned where either will do.
2712 (tiff_handler): New function, combining the cores of the
2713 old tiff_error_handler and tiff_warning_handler.
2714 This function is rewritten to use vsnprintf and thereby avoid
2715 stack buffer overflows. It uses only the features of vsnprintf
2716 that are common to both POSIX and native Microsoft.
2717 (tiff_error_handler, tiff_warning_handler): Use it.
2718 (tiff_load, gif_load, imagemagick_load_image):
2719 Don't assume :index value fits in 'int'.
2720 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2721 (imagemagick_load_image): Check that crop parameters fit into
2722 the integer types that MagickCropImage accepts. Don't assume
2723 Vimagemagick_render_type has a nonnegative value. Don't assume
2724 size_t fits in 'long'.
2725 (gs_load): Use printmax_t to print the widest integers possible.
2726 Check for integer overflow when computing image height and width.
2728 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2730 * xdisp.c (redisplay_window): Don't force window start if point
2731 will be invisible in the resulting window. (Bug#9324)
2733 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2735 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2736 the display spec is of the form `(space ...)'.
2737 (handle_display_spec): Return the value returned by
2738 handle_single_display_spec, not just 1 or zero.
2739 (handle_single_display_spec): If the display spec is of the form
2740 `(space ...)', and specifies display in the text area, return 2
2742 (try_cursor_movement): Check for the need to scroll more
2743 accurately, and prefer exact match for point under bidi.
2744 Don't advance `row' beyond the last row of the window.
2746 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2747 into disp_prop; all users changed.
2749 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2750 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2751 for the text covered by the display property.
2753 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2755 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2756 Change return value to nil.
2757 (Frecord_buffer): Delete unused function.
2759 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2761 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2762 buffers, return left-to-right.
2763 (set_cursor_from_row): Consider candidate row a win if its glyph
2764 represents a newline and point is on that newline. Fixes cursor
2765 positioning on the newline at EOL of R2L text within L2R
2766 paragraph, and vice versa.
2767 (try_cursor_movement): Check continued rows, in addition to
2768 continuation rows. Fixes unwarranted scroll when point enters a
2769 continued line of R2L text within an L2R paragraph, or vice versa.
2770 (cursor_row_p): Consider the case of point being equal to
2771 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2772 from the end of a short line to the beginning of a continued line
2773 of R2L text within L2R paragraph.
2774 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2775 composed characters.
2777 * bidi.c (bidi_check_type): Use xassert.
2778 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2781 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2783 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2786 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2788 * nsfont.m (ns_otf_to_script): Fix typo.
2790 2011-08-22 Kenichi Handa <handa@m17n.org>
2792 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2793 extra slot even if the purpose is char-code-property-table.
2795 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2797 * xdisp.c (redisplay_window): When computing centering_position,
2798 account for the height of the header line. (Bug#8874)
2800 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2801 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2802 candidate is selected by the mouse, and that candidate has a
2803 composed character under the mouse.
2805 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2806 coordinates reported by pos-visible-in-window-p for a composed
2807 character in column zero.
2809 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2811 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2813 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2815 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2816 consider it a hit if to_charpos is anywhere in the range of the
2817 composed buffer positions.
2819 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2821 * image.c (gif_load): Don't assume that each subimage has the same
2822 dimensions as the base image. Handle disposal method that is
2823 "undefined" by the gif spec (Bug#9335).
2825 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2827 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2828 (Fcondition_case): Document `debug' symbol in error handler.
2830 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2832 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2833 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2834 from an Org mode buffer to a Speedbar frame.
2836 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2837 a composition, take its buffer position from IT->cmp_it.charpos.
2838 Fixes cursor positioning at the beginning of a line that begins
2839 with a composed character.
2841 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2843 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2844 character bidirectional type, use STRONG_L instead. Fixes crashes
2845 in a buffer produced by `describe-categories'.
2847 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2848 members before the level stack, so they would be saved and
2849 restored when copying iterator state. Fixes incorrect reordering
2850 around TABs covered by display properties.
2852 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2854 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2856 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2858 * eval.c (internal_condition_case, internal_condition_case_1)
2859 (internal_condition_case_2, internal_condition_case_n):
2860 Remove unnecessary aborts (Bug#9081).
2862 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2864 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2865 has no `load' handler, try opening the file locally. (Bug#9311)
2867 2011-08-16 Ken Brown <kbrown@cornell.edu>
2869 * gmalloc.c: Expand comment.
2871 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2873 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2874 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2876 2011-08-16 Ken Brown <kbrown@cornell.edu>
2878 Fix memory allocation problems in Cygwin build (Bug#9273).
2880 * unexcw.c ( __malloc_initialized): Declare external variable.
2881 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2883 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2885 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2887 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2889 [CYGWIN] (special_realloc): New function.
2890 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2891 requests to realloc storage in the static heap.
2893 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2895 * bidi.c (bidi_initialize): Remove unused local.
2897 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2900 * biditype.h: Remove file.
2901 * makefile.w32-in ($(BLD)/bidi.$(O)):
2902 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2904 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2906 * chartab.c: Improve commentary for the uniprop_table API.
2908 * bidi.c (bidi_paragraph_init): Support zero value of
2909 bidi_ignore_explicit_marks_for_paragraph_level.
2910 (bidi_initialize): Use uniprop_table instead of including
2911 biditype.h and bidimirror.h.
2913 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2914 coordinates of the iterator when restoring from ppos_it.
2917 2011-08-14 Kenichi Handa <handa@m17n.org>
2919 * process.c (create_process): Call setup_process_coding_systems
2920 after the pid of the process is set to -1 (Bug#8162).
2922 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2924 * xdisp.c (move_it_in_display_line_to): Don't invoke
2925 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2926 ppos_it. Fixes vertical cursor motion when line beginning is
2927 covered by an image. (Bug#9296)
2929 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2931 * nsterm.h (ns_run_ascript): Declare.
2932 (NSAPP_DATA2_RUNASSCRIPT): Define.
2934 * nsfns.m (as_script, as_result, as_status): New static variables.
2935 (ns_run_ascript): New function.
2936 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2937 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2938 the event loop. Get status from as_status (Bug#7276).
2940 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2941 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2942 the event loop (Bug#7276).
2944 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2946 * gnutls.c (QCgnutls_bootprop_priority)
2947 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2948 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2949 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2950 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2951 (QCgnutls_bootprop_verify_hostname_error)
2952 (QCgnutls_bootprop_callbacks_verify): Rename from
2953 Qgnutls_bootprop_..., all uses changed.
2955 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2958 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2960 * xfaces.c (Qframe_set_background_mode): Now static.
2961 * dispextern.h (Qframe_set_background_mode): Remove decl.
2963 * process.c (Fnetwork_interface_info): Declare local only if needed.
2965 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2967 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2968 (Fnetwork_interface_list): Allocate in increments of bytes instead
2969 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2970 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2972 (struct ifflag_def): notrailers is smart on OSX.
2973 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2974 Get hardware address with getifaddrs if available.
2976 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2978 * xdisp.c (iterate_out_of_display_property): xassert that
2979 IT->position is set to within IT->object's boundaries. Break from
2980 the loop as soon as EOB is reached; avoids infloops in redisplay
2981 when IT->position is set up wrongly due to some bug.
2982 Set IT->current to match the bidi iterator unconditionally.
2983 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2984 entry. Force push_it to save on the stack the current
2985 buffer/string position, to be restored by pop_it. Fix flags in
2986 the iterator structure wrt the object coming from a display
2987 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2988 properties. (Bug#9284)
2990 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2992 * fontset.c (fontset_get_font_group): Add proper type checks.
2995 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2997 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2998 and LC_VERSION_MIN_MACOSX.
2999 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3000 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3002 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3004 * xdisp.c (forward_to_next_line_start): Allow to use the
3005 no-display-properties-and-no-overlays under bidi display.
3006 Set disp_pos in the bidi iterator to avoid searches for display
3007 properties and overlays.
3009 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3011 * editfns.c (Fset_time_zone_rule): Document relationship with the
3014 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3015 the font entity extracted from the cache (Bug#8109).
3017 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3019 * composite.c (autocmp_chars): Don't reset point. That is done by
3020 restore_point_unwind (Bug#5984).
3022 2011-08-07 Juri Linkov <juri@jurta.org>
3024 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3025 to show the arg `TIME' instead of `TIMEVAL'.
3027 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3029 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3030 display property strides EOL and includes a newline, as in
3031 longlines-mode. (Bug#9254)
3032 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3033 word-wrap under bidirectional display. (Bug#9224)
3035 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3036 is non-zero, even if the data buffer is NULL. Fixes a crash in
3037 vertical-motion with longlines-mode. (Bug#9254)
3039 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3041 * bidi.c <bidi_cache_total_alloc>: Now static.
3042 (bidi_initialize): Initialize bidi_cache_total_alloc.
3044 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3047 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3048 amount allocated this far in `bidi_cache_total_alloc'.
3049 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3050 non-zero, only free the data buffer without restoring the cache
3051 contents. All callers changed.
3053 * dispextern.h (bidi_unshelve_cache): Update prototype.
3055 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3056 (move_it_in_display_line, move_it_to)
3057 (move_it_vertically_backward, move_it_by_lines): Replace the call
3058 to xfree to an equivalent call to bidi_unshelve_cache.
3059 (move_it_in_display_line_to): Fix logic of returning
3060 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3062 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3064 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3065 came from a string character with a `cursor' property. (Bug#9229)
3067 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3069 * Makefile.in (LIB_PTHREAD): New variable.
3070 (LIBES): Add LIB_PTHREAD (Bug#9216).
3072 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3073 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3075 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3077 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3079 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3081 * xterm.c (x_find_topmost_parent): New function.
3082 (x_set_frame_alpha): Find topmost parent window with
3083 x_find_topmost_parent and set the property there also (bug#9181).
3084 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3086 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3088 * callproc.c (Fcall_process): Avoid vfork clobbering
3089 the local vars buffer, coding_systems, current_dir.
3091 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3093 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3095 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3097 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3098 so that it is not optimized away.
3100 * xdisp.c (compute_display_string_pos): Remove unused local.
3102 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3104 Fix slow cursor motion and scrolling in large buffers with
3105 selective display, like Org Mode buffers. (Bug#9218)
3107 * dispextern.h (struct bidi_it): New member disp_prop_p.
3109 * xdisp.c: Remove one-slot cache of display string positions.
3110 (compute_display_string_pos): Accept an additional argument
3111 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3112 for a display string or property. If found, set DISP_PROP_P
3115 * bidi.c (bidi_fetch_char): Accept an additional argument
3116 DISP_PROP_P, and pass it to compute_display_string_pos.
3117 Only handle text covered by a display string if DISP_PROP_P is returned
3118 non-zero. All callers of bidi_fetch_char changed.
3120 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3122 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3124 2010-12-03 Don March <don@ohspite.net>
3126 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3127 last character M-[char] is translated to ESC [char] (bug#7541).
3129 2011-08-02 Kenichi Handa <handa@m17n.org>
3131 * lisp.h (uniprop_table): Extern it.
3133 * chartab.c (uniprop_table): Make it non-static.
3135 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3137 * xdisp.c (forward_to_next_line_start): Accept additional argument
3138 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3140 (reseat_at_next_visible_line_start): Use the bidi iterator state
3141 returned by forward_to_next_line_start to restore the state of
3142 it->bidi_it after backing up to previous newline. (Bug#9212)
3144 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3146 * regex.c (re_comp): Protoize.
3147 (re_exec): Fix return type.
3148 (regexec): Fix type of `ret'. (Bug#9203)
3150 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3152 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3153 This is needed if max-image-size is a floating-point number.
3155 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3157 * print.c (print_object): Print empty symbol as ##.
3159 * lread.c (read1): Read ## as empty symbol.
3161 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3163 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3164 setting frame foreground color (Bug#9175).
3165 (x_set_background_color): Likewise.
3167 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3168 contents (Bug#9176).
3169 (EmacsTooltip -init): Remove bezels and add shadows to
3172 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3173 or scroll bar (Bug#8470).
3175 * nsfont.m (nsfont_open): Remove assignment to voffset and
3176 unnecessary vars hshink, expand, hd, full_height, min_height.
3177 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3179 * nsterm.h (nsfont_info): Remove voffset field.
3181 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3183 Implement strike-through and overline on NextStep (Bug#8863).
3185 * nsfont.m (nsfont_open): Use underline position provided by font,
3186 instead of hard-coded value of 2.
3187 (nsfont_draw): Call ns_draw_text_decoration instead.
3189 * nsterm.h: Add declaration for ns_draw_text_decoration.
3191 * nsterm.m (ns_draw_text_decoration): New function for drawing
3192 underline, overline, and strike-through.
3193 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3194 ns_draw_text_decoration. Change treatment of cursor drawing to
3195 accommodate underlining, etc.
3197 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3199 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3202 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3204 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3205 Without this fix, if a signal arrives just after memory fills up,
3206 'malloc' might be invoked reentrantly.
3208 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3209 In other words, assume that every image size is allowed, on non-X
3210 hosts. This assumption is probably wrong, but it lets Emacs compile.
3212 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3214 * regex.c (re_iswctype): Convert return values to boolean.
3216 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3218 * xdisp.c (compute_display_string_pos): Don't use cached display
3219 string position if the buffer had its restriction changed.
3222 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3226 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3228 Integer signedness and overflow and related fixes. (Bug#9079)
3230 * bidi.c: Integer size and overflow fixes.
3231 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3232 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3233 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3234 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3235 (bidi_find_other_level_edge):
3236 Use ptrdiff_t instead of EMACS_INT where either will do.
3237 This works better on 32-bit hosts configured --with-wide-int.
3238 (bidi_cache_ensure_space): Check for size-calculation overflow.
3239 Use % rather than repeated addition, for better worst-case speed.
3240 Don't set bidi_cache_size until after xrealloc returns, because it
3242 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3243 (bidi_cache_ensure_space): Also check that the bidi cache size
3244 does not exceed that of the largest Lisp string or buffer. See Eli
3245 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3247 * alloc.c (__malloc_size_t): Remove.
3248 All uses replaced by size_t. See Andreas Schwab's note
3249 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3251 * image.c: Improve checking for integer overflow.
3252 (check_image_size): Assume that f is nonnull, since
3253 it is always nonnull in practice. This is one less thing to
3254 worry about when checking for integer overflow later.
3255 (x_check_image_size): New function, which checks for integer
3256 overflow issues inside X.
3257 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3258 This removes the need for a memory_full check.
3259 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3260 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3261 (xbm_read_bitmap_data): Change locals back to 'int', since
3262 their values must fit in 'int'.
3263 (xpm_load_image, png_load, tiff_load):
3264 Invoke x_create_x_image_and_pixmap earlier,
3265 to avoid much needless work if the image is too large.
3266 (tiff_load): Treat overly large images as if
3267 x_create_x_image_and_pixmap failed, not as malloc failures.
3268 (gs_load): Use x_check_image_size.
3270 * gtkutil.c: Omit integer casts.
3271 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3272 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3274 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3276 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3277 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3278 would wrongly return t on a 64-bit host.
3280 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3281 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3282 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3283 and therefore cause GCC to emit a bogus diagnostic in some cases.
3285 * image.c: Integer signedness and overflow and related fixes.
3286 This is not an exhaustive set of fixes, but it's time to
3287 record what I've got.
3288 (lookup_pixel_color, check_image_size): Remove redundant decls.
3289 (check_image_size): Don't assume that arbitrary EMACS_INT values
3290 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3291 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3292 (tiff_load, imagemagick_load_image):
3293 Check for overflow in size calculations.
3294 (x_create_x_image_and_pixmap): Remove unnecessary test for
3295 xmalloc returning NULL; that can't happen.
3296 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3297 (xpm_color_bucket): Use better integer hashing function.
3298 (xpm_cache_color): Don't possibly over-allocate memory.
3299 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3300 (gif_memory_source):
3301 Use ptrdiff_t, not int or size_t, to record sizes.
3302 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3303 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3304 either works, as we prefer signed integers.
3305 (tiff_read_from_memory, tiff_write_from_memory):
3306 Return tsize_t, not size_t, since that's what the TIFF API wants.
3307 (tiff_read_from_memory): Don't fail simply because the read would
3308 go past EOF; instead, return a short read.
3309 (tiff_load): Omit no-longer-needed casts.
3310 (Fimagemagick_types): Don't assume size fits into 'int'.
3312 Improve hashing quality when configured --with-wide-int.
3313 * fns.c (hash_string): New function, taken from sxhash_string.
3314 Do not discard information about ASCII character case; this
3315 discarding is no longer needed.
3316 (sxhash-string): Use it. Change sig to match it. Caller changed.
3317 * lisp.h: Declare it.
3318 * lread.c (hash_string): Remove, since we now use fns.c's version.
3319 The fns.c version returns a wider integer if --with-wide-int is
3320 specified, so this should help the quality of the hashing a bit.
3322 * emacs.c: Integer overflow minor fix.
3323 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3324 Define only if GNU_LINUX.
3325 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3327 * dispnew.c: Integer signedness and overflow fixes.
3328 Remove unnecessary forward decls, that were a maintenance hassle.
3329 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3331 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3332 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3333 (prepare_desired_row, line_draw_cost):
3334 Use int, not unsigned, where either works.
3335 (save_current_matrix, restore_current_matrix):
3336 Use ptrdiff_t, not size_t, where either works.
3337 (init_display): Check for overflow more accurately, and without
3338 relying on undefined behavior.
3340 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3341 Remove, replacing with the new symbols in lisp.h. All uses changed.
3342 * fileio.c (make_temp_name):
3343 * filelock.c (lock_file_1, lock_file):
3344 * xdisp.c (message_dolog):
3345 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3346 Use pMd etc. instead.
3347 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3348 replacing the pWIDE etc. symbols removed from editfns.c.
3350 * keyboard.h (num_input_events): Now uintmax_t.
3351 This is (very slightly) less likely to mess up due to wraparound.
3354 * buffer.c: Integer signedness fixes.
3355 (alloc_buffer_text, enlarge_buffer_text):
3356 Use ptrdiff_t rather than size_t when either will do, as we prefer
3359 * alloc.c: Integer signedness and overflow fixes.
3360 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3361 (__malloc_size_t): Default to size_t, not to int.
3362 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3363 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3364 Prefer ptrdiff_t to size_t when either would do, as we prefer
3366 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3367 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3368 Now const. Initialize with values that are in range even if char
3370 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3371 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3372 These functions do the right thing with sizes > 2**32.
3373 (check_depth): Now ptrdiff_t, not int.
3374 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3375 Adjust to new way of storing sizes. Check for size overflow bugs
3377 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3378 slightly wrong anyway, as it missed one instance of
3379 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3380 (refill_memory_reserve): Omit needless cast to size_t.
3381 (mark_object_loop_halt): Mark as externally visible.
3383 * xselect.c: Integer signedness and overflow fixes.
3384 (Fx_register_dnd_atom, x_handle_dnd_message):
3385 Use ptrdiff_t, not size_t, since we prefer signed.
3386 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3387 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3388 x_dnd_atoms_size and x_dnd_atoms_length.
3390 * doprnt.c: Prefer signed to unsigned when either works.
3392 * doprnt.c (doprnt):
3394 * xdisp.c (vmessage):
3395 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3396 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3397 prefer signed arithmetic to avoid comparison confusion.
3398 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3399 but is a bit tricky.
3401 Assume freestanding C89 headers, string.h, stdlib.h.
3402 * data.c, doprnt.c, floatfns.c, print.c:
3403 Include float.h unconditionally.
3404 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3405 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3406 * regex.c: Likewise for stddef.h, string.h.
3407 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3408 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3409 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3410 (STDC_HEADERS): Remove obsolete defines.
3411 * sysdep.c: Include limits.h unconditionally.
3413 Assume support for memcmp, memcpy, memmove, memset.
3414 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3415 * regex.c (memcmp, memcpy):
3416 Remove; we assume C89 now.
3418 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3419 (__malloc_safe_bcopy): Remove; no longer needed.
3421 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3422 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3423 well either way, and we prefer signed to unsigned.
3425 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3428 closes the connection while we're reading (bug#9182).
3430 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3432 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3433 are specified (Bug#9168).
3435 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3437 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3438 Found by GCC static checking and --with-wide-int on a 32-bit host.
3440 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3442 * xdisp.c (compute_display_string_pos): Fix logic of caching
3443 previous display string position. Initialize cached_prev_pos to
3444 -1. Fixes slow-down at the beginning of a buffer.
3446 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3448 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3449 for attrs[LFACE_FONTSET_INDEX].
3451 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3453 * xml.c (parse_region): Remove unused local
3454 that was recently introduced.
3456 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3458 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3459 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3461 * xdisp.c (move_it_in_display_line_to): Record the best matching
3462 position for TO_CHARPOS while scanning the line, and restore it on
3463 exit if none of the characters scanned was an exact match.
3464 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3465 when exact match is impossible due to invisible text, and the
3466 lines are truncated.
3468 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3470 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3473 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3475 Fix a significant slow-down of cursor motion with C-n, C-p,
3476 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3477 auto-repeat under bidi redisplay in fontified buffers.
3478 * xdisp.c (compute_stop_pos_backwards): New function.
3479 (next_element_from_buffer): Call compute_stop_pos_backwards to
3480 find a suitable prev_stop when we find ourselves before
3482 (reseat): Don't look for prev_stop, as that could mean a very long
3484 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3485 <cached_disp_overlay_modiff>: Cache for last found display string
3487 (compute_display_string_pos): Return the cached position if asked
3488 about the same buffer in the same area of character positions, and
3489 the buffer wasn't changed since the time the display string
3490 position was cached.
3492 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3494 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3495 is an integer, which is important for empty lines. (Bug#9149)
3497 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3499 * frame.c (Fmodify_frame_parameters): In tty case, update the
3500 default face if necessary (Bug#4238).
3502 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3504 * editfns.c (Fstring_to_char): No need to explain what a character
3505 is in the docstring (Bug#6576).
3507 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3509 * xml.c (parse_region): Make sure we always return a tree.
3511 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3513 * xml.c (parse_region): If a document contains only comments,
3516 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518 * xml.c (make_dom): Return comments, too.
3520 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3523 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3524 and the surrounding thread.
3525 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3526 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3527 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3529 * s/openbsd.h (BROKEN_SIGIO): Define.
3530 * unexelf.c (unexec) [__OpenBSD__]:
3531 Don't update the .mdebug section of the Alpha COFF symbol table.
3533 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3535 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3538 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3540 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3541 This fixes some race conditions on the permissions of any newly
3544 * alloc.c (valid_pointer_p): Use pipe, not open.
3545 This fixes some permissions issues when debugging.
3547 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3548 If fchown fails to set both uid and gid, try to set just gid,
3549 as that is sometimes allowed. Adjust the file's mode to eliminate
3550 setuid or setgid bits that are inappropriate if fchown fails.
3552 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3554 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3555 to compare Lisp_Objects.
3556 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3557 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3558 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3560 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3562 * lread.c (read_integer): Unread even EOF character.
3563 (read1): Likewise. Properly record start position of symbol.
3565 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3566 symbol character follows.
3568 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3570 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3571 This works around a problem with the previous change to Fcopy_file.
3572 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3573 and without this change, GCC might complain about discarding
3574 fchown's return value.
3576 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3578 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3580 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3582 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3584 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3586 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3587 it's used from the C level.
3589 * process.c: Use the same condition for POLL_FOR_INPUT in both
3590 keyboard.c and process.c (bug#1858).
3592 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3594 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3595 (Fgnutls_boot): Use it.
3597 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3599 * doc.c (Fsubstitute_command_keys): Revert last change.
3601 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3603 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3604 quotes the next character, and doesn't affect other longer
3605 sequences (bug#8935).
3607 * lread.c (syms_of_lread): Clarify that is isn't only
3608 `eval-buffer' and `eval-defun' that's affected by
3609 `lexical-binding' (bug#8460).
3611 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3614 bidi redisplay when a line includes both an image and is truncated.
3616 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3618 Fix minor problems found by static checking.
3619 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3620 (elsz): Now a signed constant, not a size_t var. We prefer signed
3621 types to unsigned, to avoid integer comparison confusion. Without
3622 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3623 "cannot optimize loop, the loop counter may overflow", a symptom
3625 * indent.c (Fvertical_motion): Mark locals as initialized.
3626 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3628 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3630 * search.c (Fre_search_backward): Mention `case-fold-search' in
3631 all the re_search_* functions (bug#8138).
3633 * keyboard.c (Fopen_dribble_file): Document when the file is
3636 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3638 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3641 Support bidi reordering of display and overlay strings.
3642 * xdisp.c (compute_display_string_pos)
3643 (compute_display_string_end): Accept additional argument STRING.
3644 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3645 (reseat_to_string): Initialize bidi_it->string.s and
3646 bidi_it->string.schars.
3647 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3648 NULL (avoids a crash in bidi_paragraph_init).
3649 Initialize itb.string.lstring.
3650 (init_iterator): Call bidi_init_it only of a valid
3651 buffer position was specified. Initialize paragraph_embedding to
3653 (reseat_to_string): Initialize the bidi iterator.
3654 (display_string): If we need to ignore text properties of
3655 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3656 original value of -1 will not work with bidi.)
3657 (compute_display_string_pos): First arg is now struct
3658 `text_pos *'; all callers changed. Support display properties on
3660 (compute_display_string_end): Support display properties on Lisp
3662 (init_iterator, reseat_1, reseat_to_string): Initialize the
3663 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3664 when iterating on a string not from display properties).
3665 (compute_display_string_pos, compute_display_string_end):
3666 Fix calculation of the object to scan. Fixes an error when using
3668 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3669 base_level_stop; instead, set base_level_stop to BEGV.
3670 Fixes crashes in vertical-motion.
3671 (next_element_from_buffer): Improve commentary for when
3672 the iterator is before prev_stop.
3673 (init_iterator): Initialize bidi_p from the default value of
3674 bidi-display-reordering, not from buffer-local value. Use the
3675 buffer-local value only if initializing for buffer iteration.
3676 (handle_invisible_prop): Support invisible properties on strings
3677 that are being bidi-reordered.
3678 (set_iterator_to_next): Support bidi reordering of C strings and
3680 (next_element_from_string): Support bidi reordering of Lisp
3682 (handle_stop_backwards): Support Lisp strings as well.
3683 (display_string): Support display of R2L glyph rows.
3684 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3685 (init_iterator): Don't initialize it->bidi_p for strings
3687 (reseat_to_string): Initialize it->bidi_p for strings here.
3688 (next_element_from_string, next_element_from_c_string)
3689 (next_element_from_buffer): Add xassert's for correspondence
3690 between IT's object being iterated and it->bidi_it.string
3692 (face_before_or_after_it_pos): Support bidi iteration.
3693 (next_element_from_c_string): Handle the case of the first string
3694 character that is not the first one in the visual order.
3695 (get_visually_first_element): New function, refactored from common
3696 parts of next_element_from_buffer, next_element_from_string, and
3697 next_element_from_c_string.
3698 (tool_bar_lines_needed, redisplay_tool_bar)
3699 (display_menu_bar): Force left-to-right direction. Add a FIXME
3700 comment for making that be controlled by a user option.
3701 (push_it, pop_it): Save and restore the state of the
3702 bidi iterator. Save and restore the bidi_p flag.
3703 (pop_it): Iterate out of display property for string iteration as
3705 (iterate_out_of_display_property): Support iteration over strings.
3706 (handle_single_display_spec): Set up it->bidi_it for iteration
3707 over a display string, and call bidi_init_it.
3708 (handle_single_display_spec, next_overlay_string)
3709 (get_overlay_strings_1, push_display_prop): Set up the bidi
3710 iterator for displaying display or overlay strings.
3711 (forward_to_next_line_start): Don't use the shortcut if
3713 (back_to_previous_visible_line_start): If handle_display_prop
3714 pushed the iterator stack, restore the internal state of the bidi
3715 iterator by calling bidi_pop_it same number of times.
3716 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3717 and we are bidi-iterating, don't decrement the iterator position;
3718 instead, set the first_elt flag in the bidi iterator, to produce
3720 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3721 (push_display_prop): xassert that we are iterating a buffer.
3722 (push_it, pop_it): Save and restore paragraph_embedding member.
3723 (handle_single_display_spec, next_overlay_string)
3724 (get_overlay_strings_1, reseat_1, reseat_to_string)
3725 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3726 correctly. Don't assume unibyte strings are not bidi-reordered.
3727 (compute_display_string_pos)
3728 (compute_display_string_end): Fix handling the case of C string.
3729 (push_it, pop_it): Save and restore from_disp_prop_p.
3730 (handle_single_display_spec, push_display_prop): Set the
3731 from_disp_prop_p flag.
3732 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3733 (pop_it): Call iterate_out_of_display_property only if we are
3734 popping after iteration over a string that came from a display
3735 property. Fix a typo in popping stretch info. Add an assertion
3736 for verifying that the iterator position is in sync with the bidi
3738 (handle_single_display_spec, get_overlay_strings_1)
3739 (push_display_prop): Fix initialization of paragraph direction for
3740 string when that of the parent object is not yet determined.
3741 (reseat_1): Call bidi_init_it to resync the bidi
3742 iterator with IT's position. (Bug#7616)
3743 (find_row_edges): If ROW->start.pos gives position
3744 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3745 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3746 Reset the from_disp_prop_p flag.
3747 (SAVE_IT, RESTORE_IT): New macros.
3748 (pos_visible_p, face_before_or_after_it_pos)
3749 (back_to_previous_visible_line_start)
3750 (move_it_in_display_line_to, move_it_in_display_line)
3751 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3752 (try_scrolling, redisplay_window, display_line): Use them when
3753 saving a temporary copy of the iterator and restoring it back.
3754 (back_to_previous_visible_line_start, reseat_1)
3755 (init_iterator): Empty the bidi cache "stack".
3756 (move_it_in_display_line_to): If iterator ended up at
3757 EOL, but we never saw any buffer positions smaller than
3758 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3759 motion in bidi-reordered lines.
3760 (move_it_in_display_line_to): Record prev_method and prev_pos
3761 immediately before the call to set_iterator_to_next. Fixes cursor
3762 motion in bidi-reordered lines with stretch glyphs and strings
3763 displayed in margins. (Bug#8133) (Bug#8867)
3764 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3766 (pos_visible_p): Support positions in bidi-reordered lines.
3767 Save and restore bidi cache.
3769 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3770 (bidi_paragraph_info): Delete unused struct.
3771 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3772 (bidi_cache_start): New variable.
3773 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3775 (bidi_cache_fetch_state, bidi_cache_search)
3776 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3777 (bidi_cache_find, bidi_peek_at_next_level)
3778 (bidi_level_of_next_char, bidi_find_other_level_edge)
3779 (bidi_move_to_visually_next): Compare cache index with
3780 bidi_cache_start rather than with zero.
3781 (bidi_fetch_char): Accept new argument STRING; all callers
3782 changed. Support iteration over a string. Support strings with
3783 display properties. Support unibyte strings. Fix the type of
3784 `len' according to what STRING_CHAR_AND_LENGTH expects.
3785 (bidi_paragraph_init, bidi_resolve_explicit_1)
3786 (bidi_resolve_explicit, bidi_resolve_weak)
3787 (bidi_level_of_next_char, bidi_move_to_visually_next):
3788 Support iteration over a string.
3789 (bidi_set_sor_type, bidi_resolve_explicit_1)
3790 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3791 can now be zero (for strings); special values 0 and -1 were
3792 changed to -1 and -2, respectively.
3793 (bidi_char_at_pos): New function.
3794 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3795 Call it instead of FETCH_MULTIBYTE_CHAR.
3796 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3797 initialized to valid values.
3798 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3800 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3801 the test for valid cached positions. Fix the logic for looking up
3802 the sentinel state in the cache. GCPRO the Lisp string we are
3804 (bidi_push_it, bidi_pop_it): New functions.
3805 (bidi_initialize): Initialize the bidi cache start stack pointer.
3806 (bidi_cache_ensure_space): New function, refactored from part of
3807 bidi_cache_iterator_state. Don't assume the required size is just
3808 one BIDI_CACHE_CHUNK away.
3809 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3810 (bidi_count_bytes, bidi_char_at_pos): New functions.
3811 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3812 always valid if bidi_cache_idx is valid.
3813 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3814 is valid if it's going to be used.
3815 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3816 (bidi_cache_fetch_state, bidi_cache_search)
3817 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3818 (bidi_cache_iterator_state, bidi_cache_find)
3819 (bidi_find_other_level_edge, bidi_cache_start_stack):
3820 All variables related to cache indices are now EMACS_INT.
3822 * dispextern.h (struct bidi_string_data): New structure.
3823 (struct bidi_it): New member `string'. Make flag members be 1-bit
3824 fields, and put them last in the struct.
3825 (compute_display_string_pos, compute_display_string_end):
3827 (bidi_push_it, bidi_pop_it): Add prototypes.
3828 (struct iterator_stack_entry): New members bidi_p,
3829 paragraph_embedding, and from_disp_prop_p.
3830 (struct it): Member bidi_p is now a bit field 1 bit wide.
3831 (bidi_shelve_cache, bidi_unshelve_cache):
3834 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3835 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3836 and vector-like objects.
3838 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3839 cache around display iteration.
3841 * window.c (Fwindow_end, window_scroll_pixel_based)
3842 (displayed_window_lines, Frecenter): Save and restore the bidi
3843 cache around display iteration.
3845 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3847 * editfns.c (Fdelete_region): Clarify the use of the named
3848 parameters (bug#6788).
3850 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3852 * indent.c (Fvertical_motion): Set and restore w->pointm when
3853 saving and restoring the window's buffer (Bug#9006).
3855 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3857 * editfns.c (Fstring_to_char): Clarify just what is returned
3858 (bug#6576). Text by Eli Zaretskii.
3860 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3862 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3864 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3866 * buffer.c (mmap_find): Fix a typo.
3868 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3870 Fix execution of x selection hooks.
3871 * xselect.c (Qx_lost_selection_functions)
3872 (Qx_sent_selection_functions): New vars.
3873 (syms_of_xselect): DEFSYM them.
3874 (x_handle_selection_request): Pass Qx_sent_selection_functions
3875 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3876 (x_handle_selection_clear,x_clear_frame_selections):
3877 Pass Qx_lost_selection_functions rather than
3878 Vx_lost_selection_functions to Frun_hook_with_args.
3880 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3882 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3883 The old code sometimes used this field without initializing it.
3885 * alloc.c (gc_sweep): Don't read past end of array.
3886 In theory, the old code could also have corrupted Emacs internals,
3887 though it'd be very unlikely.
3889 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3891 * character.c (Fcharacterp): Don't advertise optional ignored
3892 argument. (Bug#4026)
3894 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3896 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3899 * window.c (Fset_window_start): Doc fix (bug#4199).
3900 (Fset_window_hscroll): Ditto.
3902 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3904 Fix minor new problems caught by GCC 4.6.1.
3905 * term.c (init_tty): Remove unused local.
3906 * xsettings.c (store_monospaced_changed): Define this function only
3907 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3910 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3912 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3914 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3916 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3917 are the mini-buffer and the echo area (bug#3320).
3919 * term.c (init_tty): Remove support for supdup, c10 and perq
3920 terminals, which are no longer supported (bug#1482).
3922 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3924 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3926 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3928 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3929 for non-popups (Bug#3642).
3931 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3933 * alloc.c (reset_malloc_hooks): Protoize.
3934 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3935 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3936 * cm.c (losecursor): Likewise.
3937 * data.c (fmod): Likewise.
3938 * dispnew.c (swap_glyphs_in_rows): Likewise.
3939 * emacs.c (memory_warning_signal): Likewise.
3940 * floatfns.c (float_error): Likewise.
3941 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3942 (otf_open, font_otf_capability, generate_otf_features)
3943 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3945 * image.c (pbm_read_file): Likewise.
3946 * indent.c (string_display_width): Likewise.
3947 * intervals.c (check_for_interval, search_for_interval)
3948 (inc_interval_count, count_intervals, root_interval)
3949 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3950 * lread.c (defalias): Likewise.
3951 * ralloc.c (r_alloc_check): Likewise.
3952 * regex.c (set_image_of_range_1, set_image_of_range)
3953 (regex_grow_registers): Likewise.
3954 * sysdep.c (strerror): Likewise.
3955 * termcap.c (valid_filename_p, tprint, main): Likewise.
3956 * tparam.c (main): Likewise.
3957 * unexhp9k800.c (run_time_remap, save_data_space)
3958 (update_file_ptrs, read_header, write_header, calculate_checksum)
3959 (copy_file, copy_rest, display_header): Likewise.
3960 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3962 * xdisp.c (check_it): Likewise.
3963 * xfaces.c (register_color, unregister_color, unregister_colors):
3965 * xfns.c (print_fontset_result): Likewise.
3966 * xrdb.c (member, fatal, main): Likewise.
3968 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3970 Fix minor problems found by static checking (Bug#9031).
3971 * chartab.c (char_table_set_range, map_sub_char_table):
3972 Remove unused locals.
3973 (uniprop_table): Now static.
3974 * composite.c (_work_char): Remove unused static var.
3976 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3978 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3980 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3982 * gtkutil.c (qttip_cb): Remove code without function.
3984 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3986 * w32.c (pthread_sigmask): New stub.
3988 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3990 Use pthread_sigmask, not sigprocmask (Bug#9010).
3991 sigprocmask is portable only for single-threaded applications, and
3992 Emacs can be multi-threaded when it uses GTK.
3993 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3995 * callproc.c (Fcall_process):
3996 * process.c (create_process):
3997 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3998 Use pthread_sigmask, not sigprocmask.
4000 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4002 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4003 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4006 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4008 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4009 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4010 (xg_hide_tooltip): Fix comment.
4012 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4013 in registerServicesMenuSendTypes.
4014 (validRequestorForSendType): Don't check ns_return_types.
4016 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4019 2011-07-08 Jason Rumney <jasonr@gnu.org>
4021 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4022 SH_SHOW for hidden windows (Bug#5482).
4024 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4025 frame struct members of non-existent frames (Bug#6284).
4027 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4029 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4030 variable firstTime not needed on OSX >= 10.6.
4031 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4032 >= 10.5. Use setKnobProportion, setDoubleValue.
4034 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4035 (MAC_OS_X_VERSION_10_5): Define if not defined.
4036 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4037 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4038 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4040 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4041 cString and lossyCString on OSX >= 10.4
4043 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4044 sizeToFit on OSX >= 10.2.
4046 * nsimage.m (allocInitFromFile): Don't use deprecated method
4047 bestRepresentationForDevice on OSX >= 10.6.
4049 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4052 * emacs.c: Declare unexec_init_emacs_zone.
4054 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4056 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4058 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4059 on svcsMenu (Bug#8842).
4061 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4063 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4065 * nsterm.m (QUTF8_STRING): Declare.
4066 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4067 (validRequestorForSendType): Return type is (id).
4068 Change indexOfObjectIdenticalTo to indexOfObject.
4069 Check if we have local selection before returning self (Bug#8842).
4070 (writeSelectionToPasteboard): Put local selection into paste board
4071 if we have a local selection (Bug#8842).
4072 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4074 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4075 (ns_get_local_selection): Declare.
4077 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4079 * keymap.c (describe_map_tree): Don't insert a double newline at
4080 the end of the buffer (bug#1169) and return whether we inserted
4083 * callint.c (Fcall_interactively): Change "reading args" to
4084 "providing args" to try to clarify what it does (bug#1010).
4086 2011-07-07 Kenichi Handa <handa@m17n.org>
4088 * composite.c (composition_compute_stop_pos): Ignore a static
4089 composition starting before CHARPOS (Bug#8915).
4091 * xdisp.c (handle_composition_prop): Likewise.
4093 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4095 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4098 2011-07-07 Kenichi Handa <handa@m17n.org>
4100 * character.h (unicode_category_t): New enum type.
4102 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4103 (Qchar_code_property_table): New variable.
4104 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4105 (UNIPROP_COMPRESSED_FORM_P): New macros.
4106 (char_table_ascii): Uncompress the compressed values.
4107 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4108 Uncompress the compressed values.
4109 (sub_char_table_ref_and_range): Likewise.
4110 (char_table_ref_and_range): Uncompress the compressed values.
4111 (sub_char_table_set): New arg is_uniprop. Callers changed.
4112 Uncompress the compressed values.
4113 (sub_char_table_set_range): Args changed. Callers changed.
4114 (char_table_set_range): Adjuted for the above change.
4115 (map_sub_char_table): Delete args default_val and parent. Add arg
4116 top. Give decoded values to a Lisp function.
4117 (map_char_table): Adjust for the above change. Give decoded
4118 values to a Lisp function. Gcpro more variables.
4119 (uniprop_table_uncompress)
4120 (uniprop_decode_value_run_length): New functions.
4121 (uniprop_decoder, uniprop_decoder_count): New variables.
4122 (uniprop_get_decoder, uniprop_encode_value_character)
4123 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4125 (uniprop_encoder, uniprop_encoder_count): New variables.
4126 (uniprop_get_encoder, uniprop_table)
4127 (Funicode_property_table_internal, Fget_unicode_property_internal)
4128 (Fput_unicode_property_internal): New functions.
4129 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4130 Sunicode_property_table_internal, Sget_unicode_property_internal,
4131 and Sput_unicode_property_internal. Defvar_lisp
4132 char-code-property-alist.
4134 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4135 Vunicode_category_table.
4137 * font.c (font_range): Adjust for the change of
4138 Vunicode_category_table.
4140 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4142 * m/iris4d.h: Remove file, move contents ...
4143 * s/irix6-5.h: ... here.
4145 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4147 Remove unportable assumption about struct layout (Bug#8884).
4148 * alloc.c (mark_buffer):
4149 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4150 (clone_per_buffer_values): Don't assume that
4151 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4152 This isn't true in general, and it's particularly not true
4153 if Emacs is configured with --with-wide-int.
4154 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4155 New macros, used in the buffer.c change.
4157 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4159 * xsettings.c: Use both GConf and GSettings if both are available.
4160 (store_config_changed_event): Add comment.
4161 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4162 (store_tool_bar_style_changed): New functions.
4163 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4164 (struct xsettings): Move font inside HAVE_XFT.
4165 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4166 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4167 Move inside HAVE_XFT.
4168 (something_changed_gsettingsCB): Rename from something_changedCB.
4169 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4171 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4172 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4173 (something_changed_gconfCB): Rename from something_changedCB.
4174 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4175 (parse_settings): Move check for font inside HAVE_XFT.
4176 (read_settings, apply_xft_settings): Add comment.
4177 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4178 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4179 call store_font_name_changed.
4180 (xft_settings_event): Add comment.
4181 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4182 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4183 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4184 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4185 (xsettings_initialize): Call init_gsettings last.
4186 (xsettings_get_system_font, xsettings_get_system_normal_font):
4189 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4191 Random fixes. E.g., (random) never returned negative values.
4192 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4193 subseconds part to the entropy, as that's a bit more random.
4194 Prefer signed to unsigned, since the signedness doesn't matter and
4195 in general we prefer signed. When given a limit, use a
4196 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4197 latter isn't right if USE_2_TAGS_FOR_INTS.
4198 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4199 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4201 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4203 * textprop.c (text_property_stickiness):
4204 Obey Vtext_property_default_nonsticky.
4205 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4206 * w32fns.c (syms_of_w32fns):
4207 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4209 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4211 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4212 This is more efficient than Ffile_directory_p and avoids a minor race.
4214 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4216 * buffer.c (Foverlay_put): Say what the return value is
4219 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4220 is a directory before asking whether to use the file name
4222 (barf_or_query_if_file_exists): Make the "File is a directory"
4223 error be more correct.
4225 * fns.c (Frequire): Remove the mention of the .gz files, since
4226 that's installation-specific, but keep the mention of
4227 `get-load-suffixes'.
4229 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4231 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4232 Report string overflow if the output is too long.
4234 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4236 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4237 (syms_of_gnutls): Remove duplicate DEFSYM for
4238 Qgnutls_bootprop_verify_hostname_error, an error for
4239 Qgnutls_bootprop_verify_error (which is no longer used).
4241 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4242 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4243 Also (re)move comments that are misplaced or no longer relevant.
4245 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4247 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4249 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4251 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4252 and background color parameters if they have been changed.
4254 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4258 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4260 * xsettings.c (SYSTEM_FONT): Define only when used.
4261 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4263 * keymap.c (access_keymap_1): Now static.
4265 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4267 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4268 leave any prefix arg for the up event (Bug#1586).
4270 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4272 * lread.c (syms_of_lread): Mention single symbols defined by
4273 `defvar' or `defconst' (bug#7154).
4275 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4276 (Frequire): Mention get-load-suffixes.
4278 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4280 * window.h (window): Remove clone_number slot.
4281 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4283 (make_parent_window, make_window, saved_window)
4284 (Fset_window_configuration, save_window_save): Don't deal with
4286 * buffer.c (Qclone_number): Remove declaration.
4287 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4289 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4291 Add multiple inheritance to keymaps.
4292 * keymap.c (Fmake_composed_keymap): New function.
4293 (Fset_keymap_parent): Simplify.
4294 (fix_submap_inheritance): Remove.
4295 (access_keymap_1): New function extracted from access_keymap to handle
4296 embedded parents and handle lists of maps.
4297 (access_keymap): Use it.
4298 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4299 (Fcopy_keymap): Handle embedded parents.
4300 (Fcommand_remapping, define_as_prefix): Simplify.
4301 (Fkey_binding): Simplify.
4302 (syms_of_keymap): Move minibuffer-local-completion-map,
4303 minibuffer-local-filename-completion-map,
4304 minibuffer-local-must-match-map, and
4305 minibuffer-local-filename-must-match-map to Elisp.
4306 (syms_of_keymap): Defsubr make-composed-keymap.
4307 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4308 (parse_menu_item): Trivial simplification.
4310 2011-07-01 Glenn Morris <rgm@gnu.org>
4312 * Makefile.in (SETTINGS_LIBS): Fix typo.
4314 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4316 * coding.c (Fencode_coding_string): Record the last coding system
4317 used, as the function doc string says (bug#8738).
4319 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4321 * xsettings.c (store_monospaced_changed): Take new font as arg and
4322 check for change against current_mono_font.
4323 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4324 (emacs_settings_constructor, emacs_settings_get_property)
4325 (emacs_settings_set_property, emacs_settings_class_init)
4326 (emacs_settings_init, gsettings_obj): Remove.
4327 (something_changedCB): New function for HAVE_GSETTINGS.
4328 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4329 with value as argument.
4330 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4331 g_settings_new (Bug#8967). Do not create gsettings_obj.
4332 Remove calls to g_settings_bind. Connect something_changedCB to
4335 * xgselect.c: Add defined (HAVE_GSETTINGS).
4336 (xgselect_initialize): Ditto.
4338 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4339 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4342 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4344 * eval.c (struct backtrace): Simplify and port the data structure.
4345 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4346 signed bit field, as this assumption is not portable and it makes
4347 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4348 "char debug_on_exit : 1" as this is not portable either; instead,
4349 use the portable "unsigned int debug_on_exit : 1". Remove unused
4350 member evalargs. Remove obsolete comments about cc bombing out.
4352 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4354 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4355 Let HAVE_GSETTINGS override HAVE_GCONF.
4356 (store_monospaced_changed): New function.
4357 (EMACS_SETTINGS): A new type derived from GObject to handle
4358 GSettings notifications.
4359 (emacs_settings_constructor, emacs_settings_get_property)
4360 (emacs_settings_set_property, emacs_settings_class_init):
4362 (gsettings_client, gsettings_obj): New variables.
4363 (GSETTINGS_SCHEMA): New define.
4364 (something_changedCB): Call store_monospaced_changed.
4365 (init_gsettings): New function.
4366 (xsettings_initialize): Call init_gsettings.
4367 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4370 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4373 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4375 * window.c (resize_root_window, grow_mini_window)
4376 (shrink_mini_window): Rename Qresize_root_window to
4377 Qwindow_resize_root_window and Qresize_root_window_vertically to
4378 Qwindow_resize_root_window_vertically.
4380 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4382 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4384 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4386 * makefile.w32-in: Redesign dependencies so they reflect more
4387 clearly which files are directly included by each source file,
4388 and not through other includes.
4390 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4392 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4393 (sort_overlays, overlay_strings): When an overlay's clone number
4394 matches the window's clone number process the overlay even if
4395 the overlay's window property doesn't match the current window.
4397 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4398 (Fwindow_hchild): Rename to Fwindow_left_child.
4399 (Fwindow_next): Rename to Fwindow_next_sibling.
4400 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4401 (resize_window_check): Rename to window_resize_check.
4402 (resize_window_apply): Rename to window_resize_apply.
4403 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4404 (Fdelete_other_windows_internal, resize_frame_windows)
4405 (Fsplit_window_internal, Fdelete_window_internal)
4406 (grow_mini_window, shrink_mini_window)
4407 (Fresize_mini_window_internal): Fix callers accordingly.
4409 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4411 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4412 (emacs_fixed_set_min_size): Remove.
4413 (emacs_fixed_new): Take frame as argument.
4415 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4416 (_EmacsFixedPrivate): Remove minwidth/height.
4417 Add struct frame *f.
4418 (emacs_fixed_init): Initialize priv->f.
4419 (get_parent_class, emacs_fixed_set_min_size): Remove.
4420 (emacs_fixed_new): Set priv->f to argument.
4421 (emacs_fixed_get_preferred_width)
4422 (emacs_fixed_get_preferred_height): Use min_width/height from
4423 frames size_hint to set minimum and natural (Bug#8919).
4424 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4425 and use min_width/height from frames size_hint to set
4426 min_width/height (Bug#8919).
4428 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4429 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4432 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4434 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4435 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4438 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4440 * process.c (wait_reading_process_output): Bypass select if
4441 waiting for a cell while ignoring keyboard input, and input is
4442 pending. Suggested by Jan Djärv (Bug#8869).
4444 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4446 Use gnulib's dup2 module instead of rolling our own.
4447 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4449 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4451 * dispnew.c (scrolling_window): Before scrolling, turn off a
4452 mouse-highlight in the window being scrolled.
4454 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4456 Move DEFSYM to lisp.h and use everywhere.
4458 * character.h (DEFSYM): Move declaration...
4459 * lisp.h (DEFSYM): ...here.
4465 * w32select.c: Don't include character.h.
4467 * alloc.c (syms_of_alloc):
4468 * buffer.c (syms_of_buffer):
4469 * bytecode.c (syms_of_bytecode):
4470 * callint.c (syms_of_callint):
4471 * casefiddle.c (syms_of_casefiddle):
4472 * casetab.c (init_casetab_once):
4473 * category.c (init_category_once, syms_of_category):
4474 * ccl.c (syms_of_ccl):
4475 * cmds.c (syms_of_cmds):
4476 * composite.c (syms_of_composite):
4477 * dbusbind.c (syms_of_dbusbind):
4478 * dired.c (syms_of_dired):
4479 * dispnew.c (syms_of_display):
4480 * doc.c (syms_of_doc):
4481 * editfns.c (syms_of_editfns):
4482 * emacs.c (syms_of_emacs):
4483 * eval.c (syms_of_eval):
4484 * fileio.c (syms_of_fileio):
4485 * fns.c (syms_of_fns):
4486 * frame.c (syms_of_frame):
4487 * fringe.c (syms_of_fringe):
4488 * insdel.c (syms_of_insdel):
4489 * keymap.c (syms_of_keymap):
4490 * lread.c (init_obarray, syms_of_lread):
4491 * macros.c (syms_of_macros):
4492 * msdos.c (syms_of_msdos):
4493 * print.c (syms_of_print):
4494 * process.c (syms_of_process):
4495 * search.c (syms_of_search):
4496 * sound.c (syms_of_sound):
4497 * syntax.c (init_syntax_once, syms_of_syntax):
4498 * terminal.c (syms_of_terminal):
4499 * textprop.c (syms_of_textprop):
4500 * undo.c (syms_of_undo):
4501 * w32.c (globals_of_w32):
4502 * window.c (syms_of_window):
4503 * xdisp.c (syms_of_xdisp):
4504 * xfaces.c (syms_of_xfaces):
4505 * xfns.c (syms_of_xfns):
4506 * xmenu.c (syms_of_xmenu):
4507 * xsettings.c (syms_of_xsettings):
4508 * xterm.c (syms_of_xterm): Use DEFSYM.
4510 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4512 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4514 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4516 Integer and buffer overflow fixes (Bug#8873).
4518 * print.c (printchar, strout): Check for string overflow.
4519 (PRINTPREPARE, printchar, strout):
4520 Don't set size unless allocation succeeds.
4522 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4523 for sizes. Check for string overflow more accurately.
4524 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4526 * macros.c: Integer and buffer overflow fixes.
4527 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4528 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4529 Use ptrdiff_t, not int, for sizes.
4530 Don't increment bufsize until after realloc succeeds.
4531 Check for size-calculation overflow.
4532 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4534 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4536 * lread.c: Integer overflow fixes.
4537 (read_integer): Radix is now EMACS_INT, not int,
4538 to improve quality of diagnostics for out-of-range radices.
4539 Calculate buffer size correctly for out-of-range radices.
4540 (read1): Check for integer overflow in radices, and in
4541 read-circle numbers.
4542 (read_escape): Avoid int overflow.
4543 (Fload, openp, read_buffer_size, read1)
4544 (substitute_object_recurse, read_vector, read_list, map_obarray):
4545 Use ptrdiff_t, not int, for sizes.
4546 (read1): Use EMACS_INT, not int, for sizes.
4547 Check for size overflow.
4549 * image.c (cache_image): Check for size arithmetic overflow.
4551 * lread.c: Integer overflow issues.
4552 (saved_doc_string_size, saved_doc_string_length)
4553 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4554 Now ptrdiff_t, not int.
4555 (read1): Don't assume doc string length fits in int. Check for
4556 out-of-range doc string lengths.
4557 (read_list): Don't assume file position fits in int.
4558 (read_escape): Check for hex character overflow.
4560 2011-06-22 Leo Liu <sdl.web@gmail.com>
4562 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4563 Move to minibuffer.el.
4565 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4567 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4568 The following patches are for when GLYPH_DEBUG && !XASSERT.
4569 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4570 * dispnew.c (flush_stdout):
4571 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4572 Mark as externally visible.
4573 * dispnew.c (check_window_matrix_pointers): Now static.
4574 * dispnew.c (window_to_frame_vpos):
4575 * xfns.c (unwind_create_frame):
4576 * xterm.c (x_check_font): Remove unused local.
4577 * scroll.c (CHECK_BOUNDS):
4578 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4579 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4580 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4581 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4582 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4584 (debug_method_add): Use va_list and vsprintf rather than relying
4585 on undefined behavior with wrong number of arguments.
4586 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4587 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4588 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4589 since we're not interested in debugging glyphs with old libraries.
4590 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4591 GCC 4.6.0's static checking.
4593 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4595 Integer overflow and signedness fixes (Bug#8873).
4596 A few related buffer overrun fixes, too.
4598 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4600 * dispextern.h (struct face.stipple):
4601 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4602 (x_bitmap_mask, x_allocate_bitmap_record)
4603 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4604 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4605 (x_create_bitmap_from_xpm_data):
4606 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4607 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4609 * xfaces.c (load_pixmap):
4610 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4611 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4612 (.bitmaps_last, struct x_output.icon_bitmap):
4613 Use ptrdiff_t, not int, for bitmap indexes.
4614 (x_allocate_bitmap_record): Check for size overflow.
4615 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4617 Use ptrdiff_t, not int, for overlay counts.
4618 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4619 * editfns.c (overlays_around, get_pos_property):
4620 * textprop.c (get_char_property_and_overlay):
4621 * xdisp.c (next_overlay_change, note_mouse_highlight):
4622 * xfaces.c (face_at_buffer_position):
4623 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4624 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4625 (Fnext_overlay_change, Fprevious_overlay_change)
4626 (mouse_face_overlay_overlaps, Foverlays_in):
4627 Use ptrdiff_t, not int, for sizes.
4628 (overlays_at, overlays_in): Check for size-calculation overflow.
4630 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4632 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4633 (x_session_initialize): Do not assume string length fits in int.
4635 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4636 This is unlikely, but can occur if DPI is outlandish.
4638 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4639 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4641 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4642 * xrdb.c (magic_file_p, search_magic_path):
4643 Omit last arg SUFFIX; it was always 0. All callers changed.
4644 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4646 * xfont.c (xfont_match): Avoid need for strlen.
4648 * xfns.c: Don't assume strlen fits in int.
4649 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4651 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4652 not unsigned long, as we prefer signed integers. All callers changed.
4653 Detect integer overflow in repeat count.
4654 (message_dolog): Don't assume print length fits in 39 bytes.
4655 (display_mode_element): Don't assume strlen fits in int.
4657 * termcap.c: Don't assume sizes fit in int and never overflow.
4658 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4659 (gobble_line): Check for size-calculation overflow.
4661 * minibuf.c (Fread_buffer):
4662 * lread.c (intern, intern_c_string):
4663 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4664 Don't assume string length fits in int.
4666 * keyboard.c (parse_tool_bar_item):
4667 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4669 * font.c: Don't assume string length fits in int.
4670 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4671 Use ptrdiff_t, not int.
4672 (font_intern_prop): Don't assume string length fits in int.
4673 Don't assume integer property fits in fixnum.
4674 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4676 * filelock.c: Fix some buffer overrun and integer overflow issues.
4677 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4678 Reformulate so as not to need the command string.
4679 Invoke gzip -cd rather than gunzip, as it's more portable.
4680 (lock_info_type, lock_file_1, lock_file):
4681 Don't assume pid_t and time_t fit in unsigned long.
4682 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4683 (current_lock_owner): Prefer signed type for sizes.
4684 Use memcpy, not strncpy, where memcpy is what is really wanted.
4685 Don't assume (via atoi) that time_t and pid_t fit in int.
4686 Check for time_t and/or pid_t out of range, e.g., via a network share.
4687 Don't alloca where an auto var works fine.
4689 * fileio.c: Fix some integer overflow issues.
4690 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4691 Don't assume string length fits in int.
4692 (directory_file_name): Don't assume string length fits in long.
4693 (make_temp_name): Don't assume pid fits in int, or that its print
4694 length is less than 20.
4696 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4698 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4700 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4702 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4703 We prefer signed integers, even for size calculations.
4705 * emacs.c: Don't assume string length fits in 'int'.
4706 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4707 (main): Don't invoke strlen when not needed.
4709 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4710 (XD_DEBUG_MESSAGE): Don't waste a byte.
4712 * callproc.c (getenv_internal_1, getenv_internal)
4714 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4716 * lread.c (invalid_syntax): Omit length argument.
4717 All uses changed. This doesn't fix a bug, but it simplifies the
4718 code away from its former Hollerith-constant appearance, and it's
4719 one less 'int' to worry about when looking at integer-overflow issues.
4720 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4722 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4723 This didn't break anything, but it didn't help either.
4724 It's confusing to put a bogus integer in a place where the actual
4725 value does not matter.
4726 (LIST_END_P): Remove unused macro and its bogus comment.
4727 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4729 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4730 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4732 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4733 We prefer signed types, and the value cannot exceed the EMACS_INT
4734 range anyway (because otherwise the length would not be representable).
4735 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4736 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4737 This avoids a GCC warning when WIDE_EMACS_INT.
4739 * indent.c (sane_tab_width): New function.
4740 (current_column, scan_for_column, Findent_to, position_indentation)
4741 (compute_motion): Use it. This is just for clarity.
4742 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4744 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4746 * lisp.h (lint_assume): New macro.
4747 * composite.c (composition_gstring_put_cache):
4748 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4750 * editfns.c, insdel.c:
4751 Omit unnecessary forward decls, to simplify future changes.
4753 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4755 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4757 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4758 Use much-faster test for byte-length change.
4759 Don't assume string byte-length fits in 'int'.
4760 Check that character arg fits in 'int'.
4761 (mapcar1): Declare byte as byte, for clarity.
4763 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4765 * fns.c (concat): Catch string overflow earlier.
4766 Do not rely on integer wraparound.
4768 * dispextern.h (struct it.overlay_strings_charpos)
4769 (struct it.selective): Now EMACS_INT, not int.
4770 * xdisp.c (forward_to_next_line_start)
4771 (back_to_previous_visible_line_start)
4772 (reseat_at_next_visible_line_start, next_element_from_buffer):
4773 Don't arbitrarily truncate the value of 'selective' to int.
4775 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4777 * composite.c: Don't truncate sizes to 'int'.
4778 (composition_gstring_p, composition_reseat_it)
4779 (composition_adjust_point): Use EMACS_INT, not int.
4780 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4781 not EMACS_UINT, for indexes.
4783 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4785 * buffer.c: Include <verify.h>.
4786 (struct sortvec.priority, struct sortstr.priority):
4787 Now EMACS_INT, not int.
4788 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4789 (struct sortstr.size, record_overlay_string)
4790 (struct sortstrlist.size, struct sortlist.used):
4791 Don't truncate size to int.
4792 (record_overlay_string): Check for size-calculation overflow.
4793 (init_buffer_once): Check at compile-time, not run-time.
4795 2011-06-22 Jim Meyering <meyering@redhat.com>
4797 Don't leak an XBM-image-sized buffer
4798 * image.c (xbm_load): Free the image buffer after using it.
4800 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4803 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4804 that Sun C diagnosed.
4805 * fns.c (secure_hash): Fix pointer signedness issue.
4806 * intervals.c (static_offset_intervals): New function.
4807 (offset_intervals): Use it.
4809 2011-06-21 Leo Liu <sdl.web@gmail.com>
4812 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4815 * fns.c (secure_hash): Rename from crypto_hash_function and change
4816 the first arg to accept symbols.
4817 (Fsecure_hash): New primitive.
4818 (syms_of_fns): New symbols.
4820 2011-06-20 Deniz Dogan <deniz@dogan.se>
4822 * process.c (Fset_process_buffer): Clarify return value in
4825 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4827 * dispnew.c (add_window_display_history): Use BVAR.
4829 * xdisp.c (debug_method_add): Use BVAR.
4830 (check_window_end, dump_glyph_matrix, dump_glyph)
4831 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4833 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4836 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4837 check till after the cache is created in init_frame_faces.
4839 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4841 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4843 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4845 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4846 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4847 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4849 Improve buffer-overflow checking (Bug#8873).
4850 * fileio.c (Finsert_file_contents):
4851 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4852 Remove the old (too-loose) buffer overflow checks.
4853 They weren't needed, since make_gap checks for buffer overflow.
4854 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4855 The old code merely checked for Emacs fixnum overflow, and relied
4856 on undefined (wraparound) behavior. The new code avoids undefined
4857 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4859 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4860 Tune. Don't use wider integers than needed. Don't use alloca.
4861 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4863 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4865 * insdel.c, lisp.h (buffer_overflow): New function.
4866 (insert_from_buffer_1, replace_range, replace_range_2):
4867 * insdel.c (make_gap_larger):
4868 * editfns.c (Finsert_char):
4869 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4871 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4873 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4875 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4877 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4878 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4880 * fileio.c: Don't assume EMACS_INT fits in off_t.
4881 (emacs_lseek): New static function.
4882 (Finsert_file_contents, Fwrite_region): Use it.
4883 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4885 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4887 * fns.c: Don't overflow int when computing a list length.
4888 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4889 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4890 truncation on 64-bit hosts. Check for QUIT every
4891 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4892 faster and is responsive enough.
4893 (Flength): Report an error instead of overflowing an integer.
4894 (Fsafe_length): Return a float if the value is not representable
4895 as a fixnum. This shouldn't happen except in contrived situations.
4896 (Fnthcdr, Fsort): Don't assume list length fits in int.
4897 (Fcopy_sequence): Don't assume vector length fits in int.
4899 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4900 (header_size, word_size): New constants.
4901 (allocate_vectorlike): Don't check size overflow here.
4902 (allocate_vector): Check it here instead, since this is the only
4903 caller of allocate_vectorlike that could cause overflow.
4904 Check that the new vector's length is representable as a fixnum.
4906 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4907 The previous code was bogus. For example, next_almost_prime (32)
4908 returned 39, which is undesirable as it is a multiple of 3; and
4909 next_almost_prime (24) returned 25, which is a multiple of 5 so
4910 why was the code bothering to check for multiples of 7?
4912 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4914 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4916 Variadic C functions now count arguments with ptrdiff_t.
4917 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4918 Back then I didn't know that the Emacs coding style prefers signed int.
4919 Also, in the meantime I found a few more instances where arguments
4920 were being counted with int, which may truncate counts on 64-bit
4921 machines, or EMACS_INT, which may be unnecessarily wide.
4922 * lisp.h (struct Lisp_Subr.function.aMANY)
4923 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4924 Arg counts are now ptrdiff_t, not size_t.
4925 All variadic functions and their callers changed accordingly.
4926 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4927 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4928 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4929 * callint.c (Fcall_interactively): Check arg count for overflow,
4930 to avoid potential buffer overrun. Use signed char, not 'int',
4931 for 'varies' array, so that we needn't bother to check its size
4932 calculation for overflow.
4933 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4934 * eval.c (apply_lambda):
4935 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4936 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4937 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4939 * callint.c (Fcall_interactively): Don't use index var as event count.
4941 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4942 * mem-limits.h (SIZE): Remove; no longer used.
4944 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4946 Remove unnecessary casts.
4947 * xterm.c (x_term_init):
4948 * xfns.c (x_set_border_pixel):
4949 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4950 These aren't needed now that we assume ANSI C.
4952 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4953 It's more likely to cause problems (due to unsigned overflow)
4956 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4958 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4960 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4962 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4964 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4966 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4968 GLYPH_CODE_FACE returns EMACS_INT, not int.
4969 * dispextern.h (merge_faces):
4970 * xfaces.c (merge_faces):
4971 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4972 Don't assume EMACS_INT fits in int.
4974 * character.h (CHAR_VALID_P): Remove unused parameter.
4975 * fontset.c, lisp.h, xdisp.c: All uses changed.
4977 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4979 * fns.c (concat): Minor tuning based on overflow analysis.
4980 This doesn't fix any bugs. Use int to hold character, instead
4981 of constantly refetching from Emacs object. Use XFASTINT, not
4982 XINT, for value known to be a character. Don't bother comparing
4983 a single byte to 0400, as it's always less.
4985 * floatfns.c (Fexpt):
4986 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4988 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4991 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4993 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4994 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4995 incorrectly succeed when S was a string, because 4294967386 was
4996 truncated before it was used.
4998 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4999 Otherwise, an out-of-range integer could cause undefined behavior
5002 * composite.c: Use int, not EMACS_INT, for characters.
5003 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5004 EMACS_INT, for values that are known to be in character range.
5005 This doesn't fix any bugs but is the usual style inside Emacs and
5006 may generate better code on 32-bit machines.
5008 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5009 This is for reasons similar to the recent CHAR_STRING fix.
5010 * charset.c (Fencode_char): Check that character arg is actually
5011 a character. Pass an int to ENCODE_CHAR.
5012 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5013 wider than 'int', as a compile-time check to prevent future regressions
5016 * character.c (char_string): Remove unnecessary casts.
5018 Make sure a 64-bit char is never passed to CHAR_STRING.
5019 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5020 by silently ignoring the top 32 bits, allowing some values
5021 that were far too large to be valid characters.
5022 * character.h: Include <verify.h>.
5023 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5024 arguments are no wider than unsigned, as a compile-time check
5025 to prevent future regressions in this area.
5027 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5028 (Fsubst_char_in_region):
5030 * xdisp.c (decode_mode_spec_coding):
5031 Adjust to CHAR_STRING's new requirement.
5032 * editfns.c (Finsert_char, Fsubst_char_in_region):
5033 * fns.c (concat): Check that character args are actually
5034 characters. Without this test, these functions did the wrong
5035 thing with wildly out-of-range values on 64-bit hosts.
5037 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5038 These casts should not be needed on 32-bit hosts, either.
5039 * keyboard.c (read_char):
5040 * lread.c (Fload): Remove casts to unsigned.
5042 * lisp.h (UNSIGNED_CMP): New macro.
5043 This fixes comparison bugs on 64-bit hosts.
5044 (ASCII_CHAR_P): Use it.
5045 * casefiddle.c (casify_object):
5046 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5047 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5048 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5049 * dispextern.h (FACE_FROM_ID):
5050 * keyboard.c (read_char): Use UNSIGNED_CMP.
5052 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5053 not to EMACS_INT, to avoid GCC warning.
5055 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5057 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5058 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5059 isn't needed on 32-bit machines.
5061 * buffer.c (Fgenerate_new_buffer_name):
5062 Use EMACS_INT for count, not int.
5063 (advance_to_char_boundary): Return EMACS_INT, not int.
5065 * data.c (Qcompiled_function): Now static.
5067 * window.c (window_body_lines): Now static.
5069 * image.c (gif_load): Rename local to avoid shadowing.
5071 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5072 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5073 * alloc.c (make_save_value): Integer argument is now of type
5075 (mark_object): Use ptrdiff_t, not int.
5076 * lisp.h (pD): New macro.
5077 * print.c (print_object): Use it.
5079 * alloc.c: Use EMACS_INT, not int, to count objects.
5080 (total_conses, total_markers, total_symbols, total_vector_size)
5081 (total_free_conses, total_free_markers, total_free_symbols)
5082 (total_free_floats, total_floats, total_free_intervals)
5083 (total_intervals, total_strings, total_free_strings):
5084 Now EMACS_INT, not int. All uses changed.
5085 (Fgarbage_collect): Compute overall total using a double, so that
5086 integer overflow is less likely to be a problem. Check for overflow
5087 when converting back to an integer.
5088 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5089 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5090 These were 'int' variables that could overflow on 64-bit hosts;
5091 they were never used, so remove them instead of repairing them.
5092 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5093 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5094 Previously, this ceilinged at INT_MAX, but that doesn't work on
5096 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5098 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5099 (allocate_vectorlike): Check for ptrdiff_t overflow.
5100 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5101 when a (possibly-narrower) signed value would do just as well.
5102 We prefer using signed arithmetic, to avoid comparison confusion.
5104 * alloc.c: Catch some string size overflows that we were missing.
5105 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5106 for convenience in STRING_BYTES_MAX.
5107 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5108 The definition here is exact; the one in lisp.h was approximate.
5109 (allocate_string_data): Check for string overflow. This catches
5110 some instances we weren't catching before. Also, it catches
5111 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5112 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5113 and ptrdiff_t and EMACS_INT are both 64 bits.
5115 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5116 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5117 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5119 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5121 * alloc.c (Fmake_string): Check for out-of-range init.
5123 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5125 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5127 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5129 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5130 xg_get_default_scrollbar_width.
5132 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5133 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5134 (style_changed_cb): Call update_theme_scrollbar_width and call
5135 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5136 all frames (Bug#8505).
5137 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5138 Call gtk_window_set_resizable if HAVE_GTK3.
5139 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5140 and height if HAVE_GTK3 (Bug#8505).
5141 (scroll_bar_width_for_theme): New variable.
5142 (update_theme_scrollbar_width): New function.
5143 (xg_get_default_scrollbar_width): Move code to
5144 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5145 (xg_initialize): Call update_theme_scrollbar_width.
5147 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5149 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5151 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5153 * frame.c (make_frame): Call other_buffer_safely instead of
5156 * window.c (temp_output_buffer_show): Call display_buffer with
5157 second argument Vtemp_buffer_show_specifiers and reset latter
5158 immediately after the call.
5159 (Vtemp_buffer_show_specifiers): New variable.
5160 (auto_window_vscroll_p, next_screen_context_lines)
5161 (Vscroll_preserve_screen_position): Remove leading asterisks from
5164 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5166 Fix minor problems found by GCC 4.6.0 static checking.
5167 * buffer.c (Qclone_number): Remove for now, as it's unused.
5168 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5169 (record_buffer): Remove unused local.
5170 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5171 (set_frame_buffer_list): Remove; unused.
5172 * frame.h (other_visible_frames): Remove decl.
5173 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5174 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5175 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5177 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5178 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5179 Define only if HAVE_GPM.
5180 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5181 (update_hints_inhibit): Remove; never set. All uses removed.
5182 * widgetprv.h (emacsFrameClassRec): Remove decl.
5183 * window.c (delete_deletable_window): Now returns void, since it
5184 wasn't returning anything.
5185 (compare_window_configurations): Remove unused locals.
5186 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5187 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5188 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5189 the same widths as pointers. This follows up on the 2011-05-06 patch.
5190 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5191 * xterm.h: Likewise.
5192 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5194 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5196 * makefile.w32-in: Update dependencies.
5197 (LISP_H): Add lib/intprops.h.
5199 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5201 * image.c (gif_load): Add animation frame delay to the metadata.
5202 (syms_of_image): Use DEFSYM. New symbol `delay'.
5204 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5206 * window.c (delete_deletable_window): Re-add.
5207 (Fset_window_configuration): Rewrite to handle dead buffers and
5208 consequently deletable windows.
5209 (window_tree, Fwindow_tree): Remove. Supply functionality in
5211 (compare_window_configurations): Simplify code.
5213 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5215 * image.c (imagemagick_load_image): Fix type mismatch.
5216 (Fimagemagick_types): Likewise.
5218 * window.h (replace_buffer_in_windows): Declare.
5220 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5222 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5223 Qclone_number. Remove external declaration of Qdelete_window.
5224 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5226 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5227 Run Qbuffer_list_update_hook if allowed.
5228 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5229 buffer list implementation.
5230 (other_buffer_safely): New function.
5231 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5232 calls to replace_buffer_in_windows and
5233 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5235 (record_buffer): Inhibit quitting and rewrite using quittable
5236 functions. Run Qbuffer_list_update_hook if allowed.
5237 (Frecord_buffer, Funrecord_buffer): New functions.
5238 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5239 Move switch-to-buffer to window.el.
5240 (bury-buffer): Move to window.el.
5241 (Vbuffer_list_update_hook): New variable.
5243 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5246 * window.h (resize_frame_windows): Move up in code.
5247 (Fwindow_frame): Remove EXFUN.
5248 (replace_buffer_in_all_windows): Remove prototype.
5249 (replace_buffer_in_windows_safely): Add prototype.
5251 * window.c: Declare Qdelete_window static again. Move down
5252 declaration of select_count.
5253 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5254 (Fother_window): Move to window.el.
5255 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5256 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5257 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5259 (replace_buffer_in_windows): Implement by calling
5260 Qreplace_buffer_in_windows.
5261 (replace_buffer_in_all_windows): Remove with some functionality
5262 moved into replace_buffer_in_windows_safely.
5263 (replace_buffer_in_windows_safely): New function.
5264 (select_window_norecord, select_frame_norecord): Move in front
5265 of run_window_configuration_change_hook. Remove now obsolete
5267 (Fset_window_buffer): Rewrite doc-string.
5268 Call Qrecord_window_buffer.
5269 (keys_of_window): Move binding for other-window to window.el.
5271 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5273 * dispextern.h (struct image): Replace data member, whose int_val
5274 and ptr_val fields were not used by anything, with a single
5277 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5278 (gif_clear_image, gif_load, imagemagick_load_image)
5279 (gs_clear_image, gs_load): Callers changed.
5281 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5283 * buffer.h: Include <time.h>, for time_t.
5284 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5286 Fix minor problems found by static checking.
5288 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5290 Make identifiers static if they are not used in other modules.
5291 * data.c (Qcompiled_function, Qframe, Qvector):
5292 * image.c (QimageMagick, Qsvg):
5293 * minibuf.c (Qmetadata):
5294 * window.c (resize_window_check, resize_root_window): Now static.
5295 * window.h (resize_window_check, resize_root_window): Remove decls.
5297 * window.c (window_deletion_count, delete_deletable_window):
5299 (window_body_lines): Now static.
5300 (Fdelete_other_windows_internal): Mark vars as initialized.
5301 Make sure 'resize_failed' is initialized.
5302 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5303 (resize_window_apply): Remove unused local.
5304 * window.h (delete_deletable_window): Remove decl.
5306 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5307 (imagemagick_load_image): Fix pointer signedness problem by changing
5308 last arg from unsigned char * to char *. All uses changed.
5309 Also, fix a local for similar reasons.
5310 Remove unused locals. Remove locals to avoid shadowing.
5311 (fn_rsvg_handle_free): Remove; unused.
5312 (svg_load, svg_load_image): Fix pointer signedness problem.
5313 (imagemagick_load_image): Don't use garbage pointer image_wand.
5315 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5317 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5319 * image.c (gif_load): Fix omitted cast error introduced by
5322 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5324 * window.h (resize_proportionally, orig_total_lines)
5325 (orig_top_line): Remove from window structure.
5326 (set_window_height, set_window_width, change_window_heights)
5327 (Fdelete_window): Remove prototypes.
5328 (resize_frame_windows): Remove duplicate declaration.
5330 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5332 * window.h (resize_frame_windows, resize_window_check)
5333 (delete_deletable_window, resize_root_window)
5334 (resize_frame_windows): Declare prototypes.
5336 * window.c (resize_window_apply): Make definition be "static" to
5337 match the prototype.
5339 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5341 * window.c: Remove declarations of Qwindow_size_fixed,
5342 window_min_size_1, window_min_size_2, window_min_size,
5343 size_window, window_fixed_size_p, enlarge_window, delete_window.
5344 Remove static from declaration of Qdelete_window, it's
5345 temporarily needed by Fbury_buffer.
5346 (replace_window): Don't assign orig_top_line and
5348 (Fdelete_window, delete_window): Remove. Window deletion is
5349 handled by window.el.
5350 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5351 Replace Fdelete_window calls with calls to Qdelete_window.
5352 (Fdelete_other_windows): Remove. Deleting other windows is
5353 handled by window.el.
5354 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5355 handled in window.el.
5356 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5357 Window minimum sizes are handled in window.el.
5358 (shrink_windows, size_window, set_window_height)
5359 (set_window_width, change_window_heights, window_height)
5360 (window_width, CURBEG, CURSIZE, enlarge_window)
5361 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5362 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5363 handled in window.el.
5364 (make_dummy_parent): Rename to make_parent_window and give it a
5365 second argument horflag.
5366 (make_window): Don't set resize_proportionally any more.
5367 (Fsplit_window): Remove. Windows are split in window.el.
5368 (save_restore_action, save_restore_orig_size)
5369 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5370 Resize mini windows in window.el.
5371 (grow_mini_window, shrink_mini_window): Implement by calling
5372 Qresize_root_window_vertically, resize_window_check and
5373 resize_window_apply.
5374 (saved_window, Fset_window_configuration, save_window_save):
5375 Do not handle orig_top_line, orig_total_lines, and
5376 resize_proportionally.
5377 (window_min_height, window_min_width): Move to window.el.
5378 (keys_of_window): Move bindings for delete-other-windows,
5379 split-window, delete-window and enlarge-window to window.el.
5381 * buffer.c: Temporarily extern Qdelete_window.
5382 (Fbury_buffer): Temporarily call Qdelete_window instead of
5383 Fdelete_window (Fbury_buffer will move to window.el soon).
5385 * frame.c (set_menu_bar_lines_1): Remove code handling
5386 orig_top_line and orig_total_lines.
5388 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5389 set_window_height but set heights directly.
5390 (change_frame_size_1): Use resize_frame_windows.
5392 * xdisp.c (init_xdisp): Don't use set_window_height but set
5395 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5396 Use resize_frame_windows instead of change_window_heights and run
5397 run_window_configuration_change_hook.
5399 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5400 instead of change_window_heights and run
5401 run_window_configuration_change_hook.
5403 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5405 * window.c (replace_window): Rename second argument REPLACEMENT to
5406 NEW. New third argument SETFLAG. Rewrite.
5407 (delete_window, make_dummy_parent): Call replace_window with
5409 (window_list_1): Move down in code.
5410 (run_window_configuration_change_hook): Move set_buffer part
5411 before select_frame_norecord part in order to unwind correctly.
5412 Rename count1 to count.
5413 (recombine_windows, delete_deletable_window, resize_root_window)
5414 (Fdelete_other_windows_internal)
5415 (Frun_window_configuration_change_hook, make_parent_window)
5416 (resize_window_check, resize_window_apply, Fresize_window_apply)
5417 (resize_frame_windows, Fsplit_window_internal)
5418 (Fdelete_window_internal, Fresize_mini_window_internal):
5420 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5422 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5424 * window.h (window): Add some new members to window structure -
5425 normal_lines, normal_cols, new_total, new_normal, clone_number,
5426 splits, nest, prev_buffers, next_buffers.
5427 (WINDOW_TOTAL_SIZE): Move here from window.c.
5428 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5430 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5432 (make_dummy_parent): Set new members of windows structure.
5433 (make_window): Move down in code. Handle new members of window
5435 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5436 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5437 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5438 (Fset_window_prev_buffers, Fwindow_next_buffers)
5439 (Fset_window_next_buffers, Fset_window_clone_number):
5441 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5442 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5444 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5445 Argument WINDOW can be now internal window too.
5446 (Fwindow_use_time): Move up in code.
5447 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5449 (Fset_window_configuration, saved_window)
5450 (Fcurrent_window_configuration, save_window_save): Handle new
5451 members of window structure.
5452 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5453 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5454 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5455 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5456 Qget_mru_window, Qresize_root_window,
5457 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5458 Qauto_buffer_name; staticpro them.
5460 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5462 * window.c (Fwindow_total_size, Fwindow_left_column)
5463 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5464 (Fwindow_list_1): New functions.
5465 (window_box_text_cols): Replace with window_body_cols.
5466 (Fwindow_width, Fscroll_left, Fscroll_right):
5467 Use window_body_cols instead of window_box_text_cols.
5468 (delete_window, Fset_window_configuration):
5469 Call delete_all_subwindows with window as argument.
5470 (delete_all_subwindows): Take a window as argument and not a
5472 (window_loop): Remove handling of GET_LRU_WINDOW and
5474 (Fget_lru_window, Fget_largest_window): Move to window.el.
5476 * window.h: Extern window_body_cols instead of
5477 window_box_text_cols. delete_all_subwindows now takes a
5478 Lisp_Object as argument.
5480 * indent.c (compute_motion, Fcompute_motion):
5481 Use window_body_cols instead of window_box_text_cols.
5483 * frame.c (delete_frame): Call delete_all_subwindows with root
5486 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5488 * fns.c (Fputhash): Document return value.
5490 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5492 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5494 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5496 Cons<->int and similar integer overflow fixes (Bug#8794).
5498 Check for overflow when converting integer to cons and back.
5499 * charset.c (Fdefine_charset_internal, Fdecode_char):
5500 Use cons_to_unsigned to catch overflow.
5501 (Fencode_char): Use INTEGER_TO_CONS.
5502 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5503 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5504 * data.c (long_to_cons, cons_to_long): Remove.
5505 (cons_to_unsigned, cons_to_signed): New functions.
5506 These signal an error for invalid or out-of-range values.
5507 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5508 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5509 * font.c (Ffont_variation_glyphs):
5510 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5511 * lisp.h: Include <intprops.h>.
5512 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5513 (cons_to_signed, cons_to_unsigned): New decls.
5514 (long_to_cons, cons_to_long): Remove decls.
5515 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5516 (Fprimitive_undo): Use CONS_TO_INTEGER.
5517 * xfns.c (Fx_window_property): Likewise.
5518 * xselect.c: Include <limits.h>.
5519 (x_own_selection, selection_data_to_lisp_data):
5520 Use INTEGER_TO_CONS.
5521 (x_handle_selection_request, x_handle_selection_clear)
5522 (x_get_foreign_selection, Fx_disown_selection_internal)
5523 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5524 (lisp_data_to_selection_data): Use cons_to_unsigned.
5525 (x_fill_property_data): Use cons_to_signed.
5526 Report values out of range.
5528 Check for buffer and string overflow more precisely.
5529 * buffer.h (BUF_BYTES_MAX): New macro.
5530 * lisp.h (STRING_BYTES_MAX): New macro.
5531 * alloc.c (Fmake_string):
5532 * character.c (string_escape_byte8):
5533 * coding.c (coding_alloc_by_realloc):
5534 * doprnt.c (doprnt):
5535 * editfns.c (Fformat):
5537 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5538 since they may not be the same number.
5539 * editfns.c (Finsert_char):
5540 * fileio.c (Finsert_file_contents):
5541 Likewise for BUF_BYTES_MAX.
5543 * image.c: Use ptrdiff_t, not int, for sizes.
5544 (slurp_file): Switch from int to ptrdiff_t.
5546 (slurp_file): Check that file size fits in both size_t (for
5547 malloc) and ptrdiff_t (for sanity and safety).
5549 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5550 if b->modtime has its maximal value.
5552 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5554 Don't assume time_t can fit into int.
5555 * buffer.h (struct buffer.modtime): Now time_t, not int.
5556 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5557 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5559 Minor fixes for signed vs unsigned integers.
5560 * character.h (MAYBE_UNIFY_CHAR):
5561 * charset.c (maybe_unify_char):
5562 * keyboard.c (read_char, reorder_modifiers):
5563 XINT -> XFASTINT, since the integer must be nonnegative.
5564 * ftfont.c (ftfont_spec_pattern):
5565 * keymap.c (access_keymap, silly_event_symbol_error):
5566 XUINT -> XFASTINT, since the integer must be nonnegative.
5567 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5568 since it makes no difference and we prefer signed.
5569 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5570 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5573 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5575 * window.h (Fwindow_frame): Declare.
5577 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5579 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5580 (SPARE_MEMORY): Always define.
5581 (LARGE_REQUEST): Remove.
5582 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5584 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5586 * lisp.h: Move EXFUNS for Fframe_root_window,
5587 Fframe_first_window and Fset_frame_selected_window to window.h.
5589 * window.h: Move EXFUNS for Fframe_root_window,
5590 Fframe_first_window and Fset_frame_selected_window here from
5593 * frame.c (Fwindow_frame, Fframe_first_window)
5594 (Fframe_root_window, Fframe_selected_window)
5595 (Fset_frame_selected_window): Move to window.c.
5596 (Factive_minibuffer_window): Move to minibuf.c.
5597 (Fother_visible_frames_p): New function.
5599 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5601 * window.c (decode_window, decode_any_window): Move up in code.
5602 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5603 (inhibit_frame_unsplittable): Remove unused variable.
5604 (Fwindow_buffer): Move up and rewrite doc-string.
5605 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5606 (Fwindow_prev): New functions.
5607 (Fwindow_frame): Move here from frame.c. Accept any window as
5609 (Fframe_root_window, Fframe_first_window)
5610 (Fframe_selected_window): Move here from frame.c. Accept frame
5611 or arbitrary window as argument. Update doc-strings.
5612 (Fminibuffer_window): Move up in code.
5613 (Fwindow_minibuffer_p): Move up in code and simplify.
5614 (Fset_frame_selected_window): Move here from frame.c.
5616 (Fselected_window, select_window, Fselect_window): Move up in
5617 code. Minor doc-string fixes.
5619 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5621 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5622 Do not assume that spare memory exists; that assumption is valid
5623 only if SYSTEM_MALLOC.
5624 (LARGE_REQUEST): New macro, so that the issue of large requests
5625 is separated from the issue of spare memory.
5627 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5629 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5632 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5634 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5637 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5639 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5641 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5643 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5644 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5646 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5648 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5650 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5652 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5653 (x_clipboard_manager_save): Add return value.
5654 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5656 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5657 Obey Vx_select_enable_clipboard_manager. Catch errors in
5658 x_clipboard_manager_save (Bug#8779).
5659 (Vx_select_enable_clipboard_manager): New variable.
5660 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5662 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5664 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5666 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5668 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5669 in the current matrix if keep_current_p is non-zero.
5671 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5673 * bidi.c (bidi_level_of_next_char): Fix last change.
5675 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5677 Support bidi reordering of text covered by display properties.
5679 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5680 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5681 (bidi_cache_search, bidi_cache_iterator_state)
5682 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5683 (bidi_level_of_next_char, bidi_move_to_visually_next):
5684 Support character positions inside a run of characters covered by a
5686 (bidi_paragraph_init, bidi_resolve_explicit_1)
5687 (bidi_level_of_next_char): Call bidi_fetch_char and
5688 bidi_fetch_char_advance instead of FETCH_CHAR and
5690 (bidi_init_it): Initialize new members.
5691 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5693 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5694 instead of using explicit *_CHAR codes.
5695 (bidi_resolve_explicit, bidi_resolve_weak):
5696 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5697 bidirectional text is supported only in multibyte buffers.
5698 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5699 it to initialize the frame_window_p member of struct bidi_it.
5700 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5701 (bidi_resolve_explicit, bidi_resolve_weak)
5702 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5703 bidi_it->nchars is non-positive.
5704 (bidi_level_of_next_char): Don't try to lookup the cache for the
5705 next/previous character if nothing is cached there yet, or if we
5706 were just reseat()'ed to a new position.
5708 * xdisp.c (set_cursor_from_row): Set start and stop points
5709 according to the row's direction when priming the loop that looks
5710 for the glyph on which to display cursor.
5711 (single_display_spec_intangible_p): Function deleted.
5712 (display_prop_intangible_p): Reimplement to call
5713 handle_display_spec instead of single_display_spec_intangible_p.
5714 Accept 3 additional arguments needed by handle_display_spec.
5715 This fixes incorrect cursor motion across display property with complex
5716 values: lists, `(when COND...)' forms, etc.
5717 (single_display_spec_string_p): Support property values that are
5718 lists with the argument STRING its top-level element.
5719 (display_prop_string_p): Fix the condition for processing a
5720 property that is a list to be consistent with handle_display_spec.
5721 (handle_display_spec): New function, refactored from the
5722 last portion of handle_display_prop.
5723 (compute_display_string_pos): Accept additional argument
5724 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5725 value of a `display' property is a "replacing spec".
5726 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5727 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5728 the display property, but just return a value indicating whether
5729 the display property will replace the characters it covers.
5730 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5731 frame_window_p members of struct bidi_it.
5732 (compute_display_string_pos, compute_display_string_end):
5734 (push_it): Accept second argument POSITION, where pop_it should
5735 jump to continue iteration.
5736 (reseat_1): Initialize bidi_it.disp_pos.
5738 * keyboard.c (adjust_point_for_property): Adjust the call to
5739 display_prop_intangible_p to its new signature.
5741 * dispextern.h (struct bidi_it): New member frame_window_p.
5742 (bidi_init_it): Update prototypes.
5743 (display_prop_intangible_p): Update prototype.
5744 (compute_display_string_pos, compute_display_string_end):
5746 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5749 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5751 Malloc failure behavior now depends on size of allocation.
5752 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5753 * lisp.h: Change signatures accordingly.
5754 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5755 All callers changed. (Bug#8762)
5757 * gnutls.c: Use Emacs's memory allocators.
5758 Without this change, the gnutls library would invoke malloc etc.
5759 directly, which causes problems on non-SYNC_INPUT hosts, and which
5760 runs afoul of improving memory_full behavior. (Bug#8761)
5761 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5762 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5763 xfree instead of the default malloc, realloc, free.
5764 (Fgnutls_boot): No need to check for memory allocation failure,
5765 since xmalloc does that for us.
5767 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5768 * category.c (hash_get_category_set):
5769 * ccl.c (ccl_driver):
5770 * charset.c (Fdefine_charset_internal):
5771 * charset.h (struct charset.hash_index):
5772 * composite.c (get_composition_id, gstring_lookup_cache)
5773 (composition_gstring_put_cache):
5774 * composite.h (struct composition.hash_index):
5775 * dispextern.h (struct image.hash):
5776 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5777 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5778 (hashfn_equal, hashfn_user_defined, make_hash_table)
5779 (maybe_resize_hash_table, hash_lookup, hash_put)
5780 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5781 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5782 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5783 * image.c (make_image, search_image_cache, lookup_image)
5784 (xpm_put_color_table_h):
5785 * lisp.h (struct Lisp_Hash_Table):
5786 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5787 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5788 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5789 * alloc.c (allocate_vectorlike):
5790 Check for overflow in vector size calculations.
5791 * ccl.c (ccl_driver):
5792 Check for overflow when converting EMACS_INT to int.
5793 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5794 need to be updated by these changes.
5795 * fns.c (make_hash_table, maybe_resize_hash_table):
5796 Check for integer overflow with large hash tables.
5797 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5798 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5799 (SXHASH_REDUCE): New macro.
5800 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5801 Use it instead of discarding useful hash info with large hash values.
5802 (sxhash_float): New function.
5803 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5804 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5805 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5806 Rewrite to use FIXNUM_BITS, as this simplifies things.
5807 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5808 Adjust signatures to match updated version of code.
5809 (consing_since_gc): Now EMACS_INT, since a single hash table can
5810 use more than INT_MAX bytes.
5812 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5814 Make it possible to build with GCC-4.6+ -O2 -flto.
5816 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5818 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5820 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5821 Call minibuffer-inactive-mode.
5823 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5825 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5826 Update dependencies.
5828 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5830 * data.c (init_data): Remove code for UTS, this system is not
5833 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5835 Don't force ./temacs to start in terminal mode.
5837 * frame.c (make_initial_frame): Initialize faces in all cases, not
5838 only when CANNOT_DUMP is defined.
5839 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5841 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5843 * dispnew.c (add_window_display_history): Use const for the string
5844 pointer. Remove declaration, not needed.
5846 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5848 Use 'inline', not 'INLINE'.
5849 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5850 * alloc.c, fontset.c (INLINE): Remove.
5851 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5852 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5853 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5854 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5855 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5857 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5859 Make it possible to run ./temacs.
5861 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5862 syms_of_callproc does the same thing. Remove test for
5863 "initialized", do it in the caller.
5864 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5866 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5868 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5869 (read_minibuf): Use get_minibuffer.
5870 (syms_of_minibuf): Use DEFSYM.
5871 (Qmetadata): New var.
5872 * data.c (Qbuffer): Don't make it static.
5873 (syms_of_data): Use DEFSYM.
5875 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5877 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5878 (CCL_CODE_MIN): New macro.
5880 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5882 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5884 * eval.c (Qdebug): Now static.
5885 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5886 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5887 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5889 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5891 * image.c: Various fixes to ImageMagick code comments.
5892 (Fimagemagick_types): Doc fix.
5894 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5896 Minor fixes prompted by GCC 4.6.0 warnings.
5898 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5900 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5901 (x_clipboard_manager_save_all): Move extern decl to ...
5902 * xterm.h: ... here, so that it can be checked for consistency.
5904 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5906 * xselect.c (x_clipboard_manager_save_frame)
5907 (x_clipboard_manager_save_all): New functions.
5908 (Fx_clipboard_manager_save): Lisp function deleted.
5910 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5911 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5913 * xterm.h: Update prototype.
5915 2011-05-28 William Xu <william.xwl@gmail.com>
5917 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5920 2011-05-28 Jim Meyering <meyering@redhat.com>
5922 Avoid a sign-extension bug in crypto_hash_function.
5923 * fns.c (to_uchar): Define.
5924 (crypto_hash_function): Use it to convert some newly-signed
5925 variables to unsigned, to avoid sign-extension bugs. For example,
5926 without this change, (md5 "truc") would evaluate to
5927 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5928 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5929 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5931 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5933 Integer overflow fixes.
5935 * dbusbind.c: Serial number integer overflow fixes.
5936 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5937 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5938 to hold a serial number that is too large for a fixnum.
5939 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5940 Check for serial numbers out of range. Decode any serial number
5941 that was so large that it became a float. (Bug#8722)
5943 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5944 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5945 Use XFASTINT rather than XUINT when numbers are nonnegative.
5946 (xd_append_arg, Fdbus_method_return_internal):
5947 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5948 arguments, check that Lisp number is nonnegative, rather than
5949 silently wrapping negative numbers around. (Bug#8722)
5950 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5953 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5955 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5957 ccl: Add integer overflow checks.
5958 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5959 (IN_INT_RANGE): New macros.
5960 (ccl_driver): Use them to check for integer overflow when
5961 decoding a CCL program. Many of the new checks are whether XINT (x)
5962 fits in int; it doesn't always, on 64-bit hosts. The new version
5963 doesn't catch all possible integer overflows, but it's an
5964 improvement. (Bug#8719)
5966 * alloc.c (make_event_array): Use XINT, not XUINT.
5967 There's no need for unsigned here.
5969 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5970 This follows up to the 2011-05-06 change that substituted uintptr_t
5971 for EMACS_INT. This case wasn't caught back then.
5973 Rework Fformat to avoid integer overflow issues.
5974 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5975 now (part of C89). Include <verify.h>.
5976 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5977 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5978 (Fformat): Avoid the prepass trying to compute sizes; it was only
5979 approximate and thus did not catch overflow reliably. Instead, walk
5980 through the format just once, formatting and computing sizes as we go,
5981 checking for integer overflow at every step, and allocating a larger
5982 buffer as needed. Keep track separately whether the format is
5983 multibyte. Keep only the most-recently calculated precision, rather
5984 than them all. Record whether each argument has been converted to
5985 string. Use EMACS_INT, not int, for byte and char and arg counts.
5986 Support field widths and precisions larger than INT_MAX. Avoid
5987 sprintf's undefined behavior with conversion specifications such as %#d
5988 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5989 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5990 formatting out-of-range floating point numbers with int
5993 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5995 * data.c: Avoid integer truncation in expressions involving floats.
5996 * data.c: Include <intprops.h>.
5997 (arith_driver): When there's an integer overflow in an expression
5998 involving floating point, convert the integers to floating point
5999 so that the resulting value does not suffer from catastrophic
6000 integer truncation. For example, on a 64-bit host (* 4
6001 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6002 Do not rely on undefined behavior after integer overflow.
6004 merge count_size_as_multibyte, parse_str_to_multibyte
6005 * character.c, character.h (count_size_as_multibyte):
6006 Rename from parse_str_to_multibyte; all uses changed.
6007 Check for integer overflow.
6008 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6009 since it's now a duplicate of the other. This is more of
6010 a character than a buffer op, so better that it's in character.c.
6011 * fns.c, print.c: Adjust to above changes.
6013 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6015 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6017 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6019 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6020 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6021 (x_clipboard_manager_save): Now static.
6022 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6024 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6025 (crypto_hash_function): Now static.
6026 Fix pointer signedness problems. Avoid unnecessary initializations.
6028 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6030 * termhooks.h (Vselection_alist): Make it terminal-local.
6032 * terminal.c (create_terminal): Initialize it.
6034 * xselect.c: Support for clipboard managers.
6035 (Vselection_alist): Move to termhooks.h as terminal-local var.
6036 (LOCAL_SELECTION): New macro.
6037 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6038 (symbol_to_x_atom): Remove gratuitous arg.
6039 (x_handle_selection_request, lisp_data_to_selection_data)
6040 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6041 (x_own_selection, x_get_local_selection, x_convert_selection):
6042 New arg, specifying work frame. Use terminal-local Vselection_alist.
6043 (some_frame_on_display): Delete unused function.
6044 (Fx_own_selection_internal, Fx_get_selection_internal)
6045 (Fx_disown_selection_internal, Fx_selection_owner_p)
6046 (Fx_selection_exists_p): New optional frame arg.
6047 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6048 (x_handle_selection_clear): Don't treat other terminals with the
6049 same keyboard specially. Use the terminal-local Vselection_alist.
6050 (x_clear_frame_selections): Use Frun_hook_with_args.
6052 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6054 * xterm.h: Add support for those atoms.
6056 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6058 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6059 (converted_selections, conversion_fail_tag): New global variables.
6060 (x_selection_request_lisp_error): Free the above.
6061 (x_get_local_selection): Remove unnecessary code.
6062 (x_reply_selection_request): Args changed; handle arbitrary array
6063 of converted selections stored in converted_selections.
6064 Separate the XChangeProperty and SelectionNotify steps.
6065 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6066 (x_convert_selection): New function.
6067 (x_handle_selection_event): Simplify.
6068 (x_get_foreign_selection): Don't ignore incoming requests while
6069 waiting for an answer; this will fail when we implement
6070 SAVE_TARGETS, and seems unnecessary anyway.
6071 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6072 (Vx_sent_selection_functions): Doc fix.
6074 2011-05-26 Leo Liu <sdl.web@gmail.com>
6076 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6078 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6080 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6082 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6083 for fringe update if it has periodic bitmap.
6084 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6085 and fringe_bitmap_periodic_p.
6087 * fringe.c (get_fringe_bitmap_data): New function.
6088 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6089 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6090 row. Mark glyph row for fringe update if periodicity changed.
6092 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6093 for fringe update unless it has periodic bitmap.
6095 2011-05-25 Kenichi Handa <handa@m17n.org>
6097 * xdisp.c (get_next_display_element): Set correct it->face_id for
6098 a static composition.
6100 2011-05-24 Leo Liu <sdl.web@gmail.com>
6103 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6105 * fns.c (crypto_hash_function, Fsha1): New function.
6106 (Fmd5): Use crypto_hash_function.
6107 (syms_of_fns): Add Ssha1.
6109 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6111 * gnutls.c: Remove unused macros.
6112 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6113 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6114 Remove macros that are defined and never used.
6115 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6117 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6119 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6120 (Fx_get_selection_internal): Minor cleanup.
6121 (Fx_own_selection_internal): Rename arguments for consistency with
6124 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6126 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6128 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6130 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6132 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6134 * dispnew.c (scrolling_window): Don't exclude the case that the
6135 last enabled row in the desired matrix touches the bottom boundary.
6137 2011-05-21 Glenn Morris <rgm@gnu.org>
6139 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6140 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6141 and add some more files.
6143 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6145 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6146 report_file_error introduced by the change from 2011-05-07.
6148 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6150 * systime.h (Time): Define only if emacs is defined.
6151 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6152 where the include path doesn't have X11/X.h by default. See
6153 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6155 2011-05-20 Kenichi Handa <handa@m17n.org>
6157 * composite.c (find_automatic_composition): Fix previous change.
6159 2011-05-20 Glenn Morris <rgm@gnu.org>
6161 * lisp.mk: New file, split from Makefile.in.
6162 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6163 (shortlisp): Remove.
6164 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6166 2011-05-19 Glenn Morris <rgm@gnu.org>
6168 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6169 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6170 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6171 (lisp): Set the order to that of loadup.el.
6172 (shortlisp): Make it a copy of $lisp.
6173 (SOME_MACHINE_LISP): Remove.
6174 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6175 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6177 2011-05-18 Kenichi Handa <handa@m17n.org>
6179 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6180 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6181 (find_automatic_composition): Mostly rewrite for efficiency.
6183 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6185 * makefile.w32-in: Update dependencies.
6187 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6189 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6190 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6192 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6194 Fix some integer overflow issues, such as string length overflow.
6196 * insdel.c (count_size_as_multibyte): Check for string overflow.
6198 * character.c (lisp_string_width): Check for string overflow.
6199 Use EMACS_INT, not int, for string indexes and lengths; in
6200 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6201 the resulting string length overflows an EMACS_INT; instead,
6202 report a string overflow if no precision given. When checking for
6203 precision exhaustion, use a check that cannot possibly have
6204 integer overflow. (Bug#8675)
6205 * character.h (lisp_string_width): Adjust to new signature.
6207 * alloc.c (string_overflow): New function.
6208 (Fmake_string): Use it. This doesn't change behavior, but saves
6209 a few bytes and will simplify future changes.
6210 * character.c (string_escape_byte8): Likewise.
6211 * lisp.h (string_overflow): New decl.
6213 Fixups, following up to the user-interface timestamp change.
6214 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6215 for UI timestamps, instead of unsigned long.
6216 * msdos.c (mouse_get_pos): Likewise.
6217 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6218 * w32gui.h (Time): Define by including "systime.h" rather than by
6219 declaring it ourselves. (Bug#8664)
6221 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6222 * image.c (clear_image_cache): Likewise.
6224 * term.c (term_mouse_position): Don't assume time_t wraparound.
6226 Be more systematic about user-interface timestamps.
6227 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6228 and sometimes 'EMACS_UINT', to represent these timestamps.
6229 This change causes it to use 'Time' uniformly, as that's what X uses.
6230 This makes the code easier to follow, and makes it easier to catch
6231 integer overflow bugs such as Bug#8664.
6232 * frame.c (Fmouse_position, Fmouse_pixel_position):
6233 Use Time, not unsigned long, for user-interface timestamps.
6234 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6235 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6236 * keyboard.h (last_event_timestamp): Likewise.
6237 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6238 * menu.h (xmenu_show): Likewise.
6239 * term.c (term_mouse_position): Likewise.
6240 * termhooks.h (struct input_event.timestamp): Likewise.
6241 (struct terminal.mouse_position_hook): Likewise.
6242 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6243 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6244 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6245 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6247 * menu.h, termhooks.h: Include "systime.h", for Time.
6249 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6250 Don't assume that the difference between two unsigned long values
6251 can fit into an integer. At this point, we know button_down_time
6252 <= event->timestamp, so the difference must be nonnegative, so
6253 there's no need to cast the result if double-click-time is
6254 nonnegative, as it should be; check that it's nonnegative, just in
6255 case. This bug is triggered when events are more than 2**31 ms
6256 apart (about 25 days). (Bug#8664)
6258 * xselect.c (last_event_timestamp): Remove duplicate decl.
6259 (x_own_selection): Remove needless cast to unsigned long.
6261 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6262 that always fit in int. Use a sentinel instead of a counter, to
6263 avoid a temp and to allay GCC's concerns about possible int overflow.
6264 * frame.h (struct frame): Use int for menu_bar_items_used
6265 instead of EMACS_INT, since it always fits in int.
6267 * menu.c (grow_menu_items): Check for int overflow.
6269 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6271 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6272 Before, the code was not consistent. These values cannot exceed
6273 2**31 - 1 so there's no need to make them unsigned.
6274 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6275 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6276 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6278 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6280 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6281 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6282 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6283 presumably because the widths might not match.
6285 * window.c (size_window): Avoid needless test at loop start.
6287 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6289 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6291 2011-05-12 Drew Adams <drew.adams@oracle.com>
6293 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6295 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6297 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6298 `width' to `bar_area_x' and `bar_area_width', respectively.
6299 (x_scroll_run): Take account of fringe background extension.
6301 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6302 Rename local vars `left' and `width' to `bar_area_x' and
6303 `bar_area_width', respectively.
6304 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6305 background extension.
6307 2011-05-10 Jim Meyering <meyering@redhat.com>
6309 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6311 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6313 * image.c (Finit_image_library): Return t for built-in image types,
6314 like pbm and xbm. (Bug#8640)
6316 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6318 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6320 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6322 * w32console.c (Fset_screen_color): Doc fix.
6323 (Fget_screen_color): New function.
6324 (syms_of_ntterm): Defsubr it.
6326 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6327 unlink the temporary file if Fcall_process didn't create it in the
6329 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6330 child process will be redirected to a file specified with `:file'.
6331 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6332 cue to call_process_cleanup not to close that handle.
6334 2011-05-07 Ben Key <bkey76@gmail.com>
6336 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6337 one of two shell specific rules, either bootstrap-temacs-CMD or
6338 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6339 to the previous implementation of the bootstrap-temacs rule.
6340 The bootstrap-temacs-CMD rule is similar to the previous
6341 implementation of the bootstrap-temacs rule except that it
6342 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6345 These changes, along with some changes to nt/configure.bat,
6346 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6347 earlier fix to add support for --cflags and --ldflags options
6348 that include quotes so that it works whether make uses cmd or
6351 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6353 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6354 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6356 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6357 a string. Handle both cases.
6358 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6359 (Fdbus_register_method): Use Qinvalid_function.
6361 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6363 * makefile.w32-in: Update dependencies.
6364 (LISP_H): Add inttypes.h and stdin.h.
6365 (PROCESS_H): Add unistd.h.
6367 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6369 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6370 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6372 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6374 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6376 * term.c (vfatal): Remove stray call to va_end.
6377 It's not needed and the C Standard doesn't allow it here anyway.
6379 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6380 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6382 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6385 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6389 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6391 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6393 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6395 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6396 * charset.c (Fdefine_charset_internal): Don't initialize
6397 charset.code_space[15]. The value was garbage, on hosts with
6398 32-bit int (Bug#8600).
6400 * lread.c (read_integer): Be more consistent with string-to-number.
6401 Use string_to_number to do the actual conversion; this avoids
6402 rounding errors and fixes some other screwups. Without this fix,
6403 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6404 (digit_to_number): Move earlier, for benefit of read_integer.
6405 Return -1 if the digit is out of range for the base, -2 if it is
6406 not a digit in any supported base. (Bug#8602)
6408 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6410 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6411 to match comment at start of function. This also removes a
6412 GCC warning about overflow in a 32+64-bit port.
6414 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6416 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6417 Reported by Stefan Monnier in
6418 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6419 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6420 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6422 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6423 (EMACS_UINTPTR): Likewise, with uintptr_t.
6425 * lisp.h: Prefer 64-bit EMACS_INT if available.
6426 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6427 on 32-bit hosts that have 64-bit int, so that they can access
6429 However, temporarily disable this change unless the temporary
6430 symbol WIDE_EMACS_INT is defined.
6432 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6434 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6435 This removes an assumption that EMACS_INT and long are the same
6436 width as pointers. The assumption is true for Emacs porting targets
6437 now, but we want to make other targets possible.
6438 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6439 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6440 In the rest of the code, change types of integers that hold casted
6441 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6442 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6443 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6444 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6445 No need to cast type when ORing.
6446 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6447 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6448 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6449 assume EMACS_INT is the same width as char *.
6450 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6451 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6452 Remove no-longer-needed casts.
6453 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6454 (xg_tool_bar_help_callback, xg_make_tool_item):
6455 Use EMACS_INTPTR to hold an integer
6456 that will be cast to void *; this can avoid a GCC warning
6457 if EMACS_INT is not the same width as void *.
6458 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6459 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6460 (current_message_1, set_message_1):
6461 Use a local to convert to proper width without a cast.
6462 * xmenu.c (dialog_selection_callback): Likewise.
6464 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6465 Also, don't assume VALBITS / RAND_BITS is less than 5,
6466 and don't rely on undefined behavior when shifting a 1 left into
6468 * lisp.h (get_random): Change signature to match.
6470 * lread.c (hash_string): Use size_t, not int, for hash computation.
6471 Normally we prefer signed values; but hashing is special, because
6472 it's better to use unsigned division on hash table sizes so that
6473 the remainder is nonnegative. Also, size_t is the natural width
6474 for hashing into memory. The previous code used 'int', which doesn't
6475 retain enough info to hash well into very large tables.
6476 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6478 * dbusbind.c: Don't possibly lose pointer info when converting.
6479 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6480 Use XPNTR rather than XHASH, so that the high-order bits of
6481 the pointer aren't lost when converting through void *.
6483 * eval.c (Fautoload): Don't double-shift a pointer.
6485 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6487 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6489 * gnutls.c (DEF_GNUTLS_FN):
6490 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6492 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6494 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6497 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6499 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6500 New version that can reserve upto 2GB of heap space.
6502 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6504 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6506 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6508 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6509 `gnutls_certificate_set_x509_key_file'.
6511 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6513 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6514 Update dependencies.
6516 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6518 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6519 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6520 Remove unused parameter `fildes'.
6521 * process.c (read_process_output, send_process): Don't pass it.
6523 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6525 Fix previous change: the library cache is defined in w32.c.
6526 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6527 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6529 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6531 Implement dynamic loading of GnuTLS on Windows.
6533 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6534 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6535 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6538 * gnutls.c (Qgnutls_dll): Define.
6539 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6540 (gnutls_*): Declare function pointers.
6541 (init_gnutls_functions): New function to initialize function pointers.
6542 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6543 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6545 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6546 (emacs_gnutls_write, emacs_gnutls_read)
6547 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6548 (Fgnutls_available_p): New function.
6549 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6550 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6551 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6553 * image.c: Include w32.h.
6554 (Vimage_type_cache): Delete.
6555 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6556 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6557 (w32_delayed_load): Move to w32.c.
6559 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6561 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6562 (w32_delayed_load): Move from image.c. When loading a library, record
6563 its filename in the :loaded-from property of the library id.
6564 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6565 Initialize and staticpro them.
6566 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6568 * process.c: Include lisp.h before w32.h, not after.
6569 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6570 instead of gnutls_record_check_pending.
6572 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6574 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6576 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6577 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6580 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6582 * xterm.c (x_set_frame_alpha): Do not set property on anything
6583 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6585 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6587 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6589 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6591 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6592 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6593 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6594 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6595 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6596 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6597 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6598 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6599 (Qgnutls_bootprop_callbacks_verify): Make static.
6601 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6603 * callproc.c: Indentation fixup.
6605 * sysdep.c (wait_for_termination_1): Make static.
6606 (wait_for_termination, interruptible_wait_for_termination):
6607 Move after wait_for_termination_1.
6609 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6611 * sysdep.c (interruptible_wait_for_termination): New function
6612 which is like wait_for_termination, but allows keyboard
6615 * callproc.c (Fcall_process): Add (:file "file") as an option for
6617 (Fcall_process_region): Ditto.
6619 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6621 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6622 rather than `XVECTOR (FOO)->size'.
6624 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6625 inttypes.h, as a gnulib replacement is used if it not available in
6628 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6630 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6631 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6632 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6634 * coding.c (coding_alloc_by_realloc): Error out if destination
6635 will grow beyond MOST_POSITIVE_FIXNUM.
6636 (decode_coding_emacs_mule): Abort if there isn't enough place in
6637 charbuf for the composition carryover bytes. Reserve an extra
6638 space for up to 2 characters produced in a loop.
6639 (decode_coding_iso_2022): Abort if there isn't enough place in
6640 charbuf for the composition carryover bytes.
6642 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6644 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6645 aborting when %lld or %lll format is passed.
6646 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6647 %llo or %llx format is passed. (Bug#8545)
6649 * window.c (window_scroll_line_based): Use a marker instead of
6650 simple variables to record original value of point. (Bug#7952)
6652 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6653 produced by %s or %c overflows available buffer space. (Bug#8545)
6655 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6657 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6658 (SIZE_MAX): Move defn after all includes, as they might #define it.
6660 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6662 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6664 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6666 * keyboard.c (Qdelayed_warnings_hook): Define.
6667 (command_loop_1): Run `delayed-warnings-hook'
6668 if Vdelayed_warnings_list is non-nil.
6669 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6670 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6672 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6674 * doprnt.c (doprnt): Don't return value smaller than the buffer
6675 size if the message was truncated. (Bug#8545).
6677 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6679 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6680 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6682 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6684 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6686 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6688 * makefile.w32-in: Update dependencies.
6690 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6692 Improve `doprnt' and its usage. (Bug#8545)
6693 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6694 `format_end'. Remove support for %l as a conversion specifier.
6695 Don't use xrealloc. Improve diagnostics when the %l size modifier
6696 is used. Update the commentary.
6698 * eval.c (verror): Simplify calculation of size_t.
6700 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6703 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6705 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6708 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6710 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6711 This makes this file independent of the recent pseudovector change.
6713 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6715 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6717 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6718 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6719 Remove unused local.
6720 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6722 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6723 GCC 4.6.0 optimizes based on type-based alias analysis.
6724 For example, if b is of type struct buffer * and v of type struct
6725 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6726 != &v->size, and therefore "v->size = 1; b->size = 2; return
6727 v->size;" must therefore return 1. This assumption is incorrect
6728 for Emacs, since it type-puns struct Lisp_Vector * with many other
6729 types. To fix this problem, this patch adds a new type struct
6730 vectorlike_header that documents the constraints on layout of vectors
6731 and pseudovectors, and helps optimizing compilers not get fooled
6732 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6733 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6734 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6736 (XSETPVECTYPE): Rewrite in terms of new macro.
6737 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6738 This is a bit clearer, and further avoids the possibility of
6739 undesirable aliasing.
6740 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6741 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6742 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6743 since Lisp_Subr is a special case (no "next" field).
6744 (ASIZE): Now uses header.size rather than size.
6745 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6746 to avoid the hassle of writing XVECTOR (foo)->header.size.
6747 (struct vectorlike_header): New type.
6748 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6749 object, to help avoid aliasing.
6750 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6751 (SUBRP): Likewise, since Lisp_Subr is a special case.
6752 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6753 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6754 (struct Lisp_Hash_Table): Combine first two members into a single
6755 struct vectorlike_header member. All uses of "size" and "next" members
6756 changed to be "header.size" and "header.next".
6757 * buffer.h (struct buffer): Likewise.
6758 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6759 * frame.h (struct frame): Likewise.
6760 * process.h (struct Lisp_Process): Likewise.
6761 * termhooks.h (struct terminal): Likewise.
6762 * window.c (struct save_window_data, struct saved_window): Likewise.
6763 * window.h (struct window): Likewise.
6764 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6765 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6766 * buffer.c (init_buffer_once): Likewise.
6767 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6769 * process.c (Fformat_network_address): Use local var for size,
6772 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6774 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6775 * data.c (atof): Remove decl; no longer used or needed.
6776 (digit_to_number): Move to lread.c.
6777 (Fstring_to_number): Use new string_to_number function, to be
6778 consistent with how the Lisp reader treats infinities and NaNs.
6779 Do not assume that floating-point numbers represent EMACS_INT
6780 without losing information; this is not true on most 64-bit hosts.
6781 Avoid double-rounding errors, by insisting on integers when
6782 parsing non-base-10 numbers, as the documentation specifies.
6783 * lisp.h (string_to_number): New decl, replacing ...
6784 (isfloat_string): Remove.
6785 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6786 (read1): Do not accept +. and -. as integers; this
6787 appears to have been a coding error. Similarly, do not accept
6788 strings like +-1e0 as floating point numbers. Do not report
6789 overflow for integer overflows unless the base is not 10 which
6790 means we have no simple and reliable way to continue.
6791 Break out the floating-point parsing into a new
6792 function string_to_number, so that Fstring_to_number parses
6793 floating point numbers consistently with the Lisp reader.
6794 (digit_to_number): Move here from data.c. Make it static inline.
6795 (E_CHAR, EXP_INT): Remove, replacing with ...
6796 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6797 (string_to_number): New function, replacing isfloat_string.
6798 This function checks for valid syntax and produces the resulting
6799 Lisp float number too. Rework it so that string-to-number
6800 no longer mishandles examples like "1.0e+". Use strtoumax,
6801 so that overflow for non-base-10 numbers is reported only when
6802 there's no portable and simple way to convert to floating point.
6804 * textprop.c (set_text_properties_1): Rewrite for clarity,
6805 and to avoid GCC warning about integer overflow.
6807 * intervals.h (struct interval): Use EMACS_INT for members
6808 where EMACS_UINT might cause problems. See
6809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6810 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6811 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6813 (offset_intervals): Tell GCC not to worry about length overflow
6814 when negating a negative length.
6816 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6817 (overrun_check_free): Likewise.
6819 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6820 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6823 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6824 (gnutls_make_error): Rename local to avoid shadowing.
6825 (gnutls_emacs_global_deinit): ifdef out; not used.
6826 (Fgnutls_boot): Use const for pointer to readonly storage.
6827 Comment out unused local. Fix pointer signedness problems.
6829 * lread.c (openp): Don't stuff size_t into an 'int'.
6830 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6831 about possible signed overflow.
6833 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6834 (GDK_KEY_g): Don't define if already defined.
6835 (xg_prepare_tooltip): Avoid pointer signedness problem.
6836 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6838 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6839 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6841 * xfns.c (Fx_window_property): Simplify a bit,
6842 to make a bit faster and to avoid GCC 4.6.0 warning.
6843 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6845 * fns.c (internal_equal): Don't assume size_t fits in int.
6847 * alloc.c (compact_small_strings): Tighten assertion a little.
6849 Replace pEd with more-general pI, and fix some printf arg casts.
6850 * lisp.h (pI): New macro, generalizing old pEd macro to other
6851 conversion specifiers. For example, use "...%"pI"d..." rather
6852 than "...%"pEd"...".
6853 (pEd): Remove. All uses replaced with similar uses of pI.
6854 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6855 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6856 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6857 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6858 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6859 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6860 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6862 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6863 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6864 * print.c (safe_debug_print, print_object): Likewise.
6865 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6867 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6868 avoiding the 0 flag, which is not portable.
6869 * process.c (Fmake_network_process): Use pI to avoid cast.
6870 * region-cache.c (pp_cache): Likewise.
6871 * xdisp.c (decode_mode_spec): Likewise.
6872 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6873 behavior on 64-bit hosts with printf arg.
6874 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6875 (x_stop_queuing_selection_requests): Likewise.
6876 (x_get_window_property): Don't truncate byte count to an 'int'
6879 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6880 here, since it parses constructs like leading '-' and spaces,
6881 which are not wanted; and it overflows with large numbers.
6882 Instead, simply match F[0-9]+, which is what is wanted anyway.
6884 * alloc.c: Remove unportable assumptions about struct layout.
6885 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6886 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6887 (allocate_vectorlike, make_pure_vector): Use the new macros,
6888 plus offsetof, to remove unportable assumptions about struct layout.
6889 These assumptions hold on all porting targets that I know of, but
6890 they are not guaranteed, they're easy to remove, and removing them
6891 makes further changes easier.
6893 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6894 This doesn't fix a bug but makes the code clearer.
6895 (string_overrun_cookie): Now const. Use initializers that
6896 don't formally overflow signed char, to avoid warnings.
6897 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6898 can cause Emacs to crash when string overrun checking is enabled.
6899 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6900 multiple of sizeof (EMACS_INT); it need not be, if
6901 alignof(EMACS_INT) < sizeof (EMACS_INT).
6902 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6904 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6906 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6908 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6910 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6911 supposed to be handshaking. (Bug#8556)
6912 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6914 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6916 * lisp.h (Qdebug): List symbol.
6917 * eval.c (Qdebug): Restore global linkage.
6918 * keyboard.c (debug-on-event): New variable.
6919 (handle_user_signal): Break into debugger when debug-on-event
6920 matches the current signal symbol.
6922 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6924 * alloc.c (check_sblock, check_string_bytes)
6925 (check_string_free_list): Convert to standard C.
6927 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6929 * w32.c (emacs_gnutls_push): Fix typo.
6931 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6933 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6934 "cast to pointer from integer of different size".
6936 Improve doprnt and its use in verror. (Bug#8545)
6937 * doprnt.c (doprnt): Document the set of format control sequences
6938 supported by the function. Use SAFE_ALLOCA instead of always
6941 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6942 is one byte too soon. Don't use xrealloc; instead xfree and
6945 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6947 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6950 * gnutls.c: Renamed global_initialized to
6951 gnutls_global_initialized. Added internals for the
6952 :verify-hostname-error, :verify-error, and :verify-flags
6953 parameters of `gnutls-boot' and documented those parameters in the
6954 docstring. Start callback support.
6955 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6956 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6957 on error. Return error code.
6958 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6959 (emacs_gnutls_read): Likewise.
6960 (Fgnutls_boot): Return handshake error code.
6961 (emacs_gnutls_handle_error): New function.
6962 (wsaerror_to_errno): Likewise.
6964 * w32.h (emacs_gnutls_pull): Add prototype.
6965 (emacs_gnutls_push): Likewise.
6967 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6968 (emacs_gnutls_push): Likewise.
6970 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6972 * process.c (wait_reading_process_output): Check if GnuTLS
6973 buffered some data internally if no FDs are set for TLS
6976 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6977 (LIBS): Link to USER_LIBS.
6978 ($(BLD)/gnutls.$(0)): New target.
6980 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6982 * xdisp.c (handle_single_display_spec): Rename the
6983 display_replaced_before_p argument into display_replaced_p, to
6984 make it consistent with the commentary. Fix typos in the
6987 * textprop.c (syms_of_textprop): Remove dead code.
6988 (copy_text_properties): Delete obsolete commentary about an
6989 interface that was deleted long ago. Fix typos in the description
6992 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6993 to changes in oldXMenu/XMenu.h from 2011-04-16.
6994 <menu_help_message, prev_menu_help_message>: Constify.
6995 (IT_menu_make_room): menu->help_text is now `const char **';
6998 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6999 to changes in oldXMenu/XMenu.h from 2011-04-16.
7000 (struct XMenu): Declare `help_text' `const char **'.
7002 * xfaces.c <Qunspecified>: Make extern again.
7004 * syntax.c: Include sys/types.h before including regex.h, as
7007 * doc.c (get_doc_string): Improve the format passed to `error'.
7009 * doprnt.c (doprnt): Improve commentary.
7011 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7013 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7016 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7017 changes in globals.h immediately force recompilation.
7018 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7019 $(CURDIR)/s/ms-w32.h.
7020 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7022 * character.c (Fchar_direction): Function deleted.
7023 (syms_of_character): Don't defsubr it.
7024 <char-direction-table>: Deleted.
7026 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7028 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7029 * doprnt.c: Include limits.h.
7030 (SIZE_MAX): New macro.
7031 (doprnt): Return a size_t value. 2nd arg is now size_t.
7032 Many local variables are now size_t instead of int or unsigned.
7033 Improve overflow protection. Support `l' modifier for integer
7034 conversions. Support %l conversion. Don't assume an EMACS_INT
7035 argument for integer conversions and for %c.
7037 * lisp.h (doprnt): Restore prototype.
7039 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7042 * Makefile.in (base_obj): Add back doprnt.o.
7044 * deps.mk (doprnt.o): Add back prerequisites.
7045 (callint.o): Depend on character.h.
7047 * eval.c (internal_lisp_condition_case): Include the handler
7048 representation in the error message.
7049 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7050 when breaking from the loop.
7052 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7054 * callint.c (Fcall_interactively): When displaying error message
7055 about invalid control letter, pass the character's codepoint, not
7056 a pointer to its multibyte form. Improve display of the character
7057 in octal and display also its hex code.
7059 * character.c (char_string): Use %x to display the (unsigned)
7060 codepoint of an invalid character, to avoid displaying a bogus
7063 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7064 `error', not SYMBOL_NAME itself.
7066 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7067 character arguments to `error'.
7069 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7070 to `error' in error message about FINAL_CHAR argument. Make sure
7071 FINAL_CHAR is a character, and use %c when it is passed as
7072 argument to `error'.
7074 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7076 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7078 * w32.c: Include <time.h>.
7079 (sys_localtime): New function.
7081 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7083 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7085 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7087 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7089 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7092 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7094 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7095 gl_state.e_property when gl_state.object is Qt.
7097 * insdel.c (make_gap_larger): Remove limitation of buffer size
7100 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7102 * xdisp.c (lookup_glyphless_char_display)
7103 (produce_glyphless_glyph): Handle cons cell entry in
7104 glyphless-char-display.
7105 (Vglyphless_char_display): Document it.
7107 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7108 glyphless-char-display.
7110 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7112 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7114 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7116 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7117 definition for no-X builds.
7119 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7121 Static checks with GCC 4.6.0 and non-default toolkits.
7123 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7125 * process.c (keyboard_bit_set): Define only if SIGIO.
7126 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7127 (send_process): Repair possible setjmp clobbering.
7129 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7131 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7133 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7135 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7136 Define only if needed.
7138 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7139 by pacifying GCC about it. Maybe it's time to retire it?
7140 * xfaces.c (USG, __TIMEVAL__): Likewise.
7142 * dispextern.h (struct redisplay_interface): Rename param
7144 * termhooks.h (struct terminal): Likewise.
7145 * xterm.c (xembed_send_message): Likewise.
7147 * insdel.c (make_gap_smaller): Define only if
7148 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7150 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7153 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7154 so that we aren't warned about unused symbols.
7156 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7158 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7160 * xfns.c (x_real_positions): Mark locals as initialized.
7162 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7164 * xterm.c: Fix problems found by static analysis with other toolkits.
7165 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7166 (x_dispatch_event): Declare static if USE_GTK, and
7167 define if USE_GTK || USE_X_TOOLKIT.
7168 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7169 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7170 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7171 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7173 * xmenu.c (menu_help_callback): Pointer type fixes.
7174 Use const pointers when pointing at readonly data. Avoid pointer
7176 (FALSE): Remove unused macro.
7177 (update_frame_menubar): Remove unused decl.
7179 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7181 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7182 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7183 (single_menu_item): Rename local to avoid shadowing.
7185 * keyboard.c (make_lispy_event): Remove unused local var.
7187 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7188 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7190 * bitmaps: Change bitmaps from unsigned char back to the X11
7191 compatible char. Avoid the old compiler warnings about
7192 out-of-range initializers by using, for example, '\xab' rather
7195 * xgselect.c (xgselect_initialize): Check vs interface
7196 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7198 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7200 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7201 to read-only memory.
7203 * fns.c (vector): Remove; this old hack is no longer needed.
7205 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7207 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7209 * xrdb.c (x_load_resources): Omit unused local.
7211 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7212 (x_window): Rename locals to avoid shadowing.
7213 (USG): Use the kludged USG macro, to pacify gcc.
7215 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7216 (x_term_init): Remove local to avoid shadowing.
7218 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7220 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7221 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7223 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7225 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7227 Fix regex.c, syntax.c and friends for buffers > 2GB.
7228 * syntax.h (struct gl_state_s): Declare character position members
7231 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7233 * textprop.c (verify_interval_modification, interval_of):
7234 Declare arguments EMACS_INT.
7236 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7239 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7241 * indent.c (Fvertical_motion): Local variable it_start is now
7244 * regex.c (re_match, re_match_2, re_match_2_internal)
7245 (bcmp_translate, regcomp, regexec, print_double_string)
7246 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7247 (re_compile_pattern, re_exec): Declare arguments and local
7248 variables `size_t' and `ssize_t' and return values `regoff_t', as
7250 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7251 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7252 <compile_stack_type>: `size' and `avail' are now `size_t'.
7254 * regex.h <regoff_t>: Use ssize_t, not int.
7255 (re_search, re_search_2, re_match, re_match_2): Arguments that
7256 specify buffer/string position and length are now ssize_t and
7257 size_t. Return type is regoff_t.
7259 2011-04-16 Ben Key <bkey76@gmail.com>
7261 * nsfont.m: Fixed bugs in ns_get_family and
7262 ns_descriptor_to_entity that were caused by using free to
7263 deallocate memory blocks that were allocated by xmalloc (via
7264 xstrdup). This caused Emacs to crash when compiled with
7265 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7266 --enable-checking=xmallocoverrun). xfree is now used to
7267 deallocate these memory blocks.
7269 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7271 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7273 emacs_write: Accept and return EMACS_INT for sizes.
7274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7276 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7277 Accept and return EMACS_INT.
7278 (emacs_gnutls_write): Return the number of bytes written on
7280 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7281 (emacs_read, emacs_write): Remove check for negative size, as the
7282 Emacs source code has been audited now.
7283 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7284 (emacs_read, emacs_write): Use it.
7285 * process.c (send_process): Adjust to the new signatures of
7286 emacs_write and emacs_gnutls_write. Do not attempt to store
7287 a byte offset into an 'int'; it might overflow.
7288 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7290 * sound.c: Don't assume sizes fit in 'int'.
7291 (struct sound_device.period_size, alsa_period_size):
7292 Return EMACS_INT, not int.
7293 (struct sound_device.write, vox_write, alsa_write):
7294 Accept EMACS_INT, not int.
7295 (wav_play, au_play): Use EMACS_INT to store sizes and to
7296 record read return values.
7298 2011-04-15 Ben Key <bkey76@gmail.com>
7300 * keyboard.c (Qundefined): Don't declare static since it is used
7302 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7303 static since they are used in nsfont.m.
7305 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7307 * process.c (Qprocessp): Don't declare static.
7308 * lisp.h (Qprocessp): Declare again.
7310 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7312 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7314 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7316 Improve C-level modularity by making more things 'static'.
7318 Don't publish debugger-only interfaces to other modules.
7319 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7320 (verify_bytepos, count_markers): Move decls to the only modules
7322 * region-cache.h (pp_cache): Likewise.
7323 * window.h (check_all_windows): Likewise.
7324 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7326 * sysdep.c (croak): Now static, if
7327 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7328 * syssignal.h (croak): Declare only if not static.
7330 * alloc.c (refill_memory_reserve): Now static if
7331 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7332 * lisp.h (refill_memory_reserve): Declare only if not static.
7334 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7335 Define only if USE_LUCID.
7337 * xrdb.c (x_customization_string, x_rm_string): Now static.
7339 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7340 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7342 * xdisp.c (draw_row_with_mouse_face): Now static.
7343 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7345 * window.h (check_all_windows): Mark externally visible.
7347 * window.c (window_deletion_count): Now static.
7349 * undo.c: Make symbols static if they're not exported.
7350 (last_undo_buffer, last_boundary_position, pending_boundary):
7353 * textprop.c (interval_insert_behind_hooks): Now static.
7354 (interval_insert_in_front_hooks): Likewise.
7356 * term.c: Make symbols static if they're not exported.
7357 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7358 (max_frame_lines, tty_set_terminal_modes):
7359 (tty_reset_terminal_modes, tty_turn_off_highlight):
7360 (get_tty_terminal): Now static.
7361 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7362 * termhooks.h (term_mouse_moveto): Do not declare if
7364 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7365 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7367 * sysdep.c: Make symbols static if they're not exported.
7368 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7370 (sigprocmask_set, full_mask): Remove; unused.
7371 (wait_debugging): Mark as visible.
7372 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7373 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7375 * syntax.c (syntax_temp): Define only if !__GNUC__.
7377 * sound.c (current_sound_device, current_sound): Now static.
7379 * search.c (searchbufs, searchbuf_head): Now static.
7381 * scroll.c (scroll_cost): Remove; unused.
7382 * dispextern.h (scroll_cost): Remove decl.
7384 * region-cache.h (pp_cache): Mark as externally visible.
7386 * process.c: Make symbols static if they're not exported.
7387 (process_tick, update_tick, create_process, chan_process):
7388 (Vprocess_alist, proc_buffered_char, datagram_access):
7389 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7390 (deactivate_process): Mark defn as static, as well as decl.
7391 * lisp.h (create_process): Remove decl.
7392 * process.h (chan_process, Vprocess_alist): Remove decls.
7394 * print.c: Make symbols static if they're not exported.
7395 (print_depth, new_backquote_output, being_printed, print_buffer):
7396 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7397 (print_interval, print_number_index, initial_stderr_stream):
7399 * lisp.h (Fprinc): Remove decl.
7400 (debug_output_compilation_hack): Mark as externally visible.
7402 * sysdep.c (croak): Move decl from here to syssignal.h.
7403 * syssignal.h (croak): Put it here, so the API can be checked when
7404 'croak' is called from dissociate_if_controlling_tty.
7406 * minibuf.c: Make symbols static if they're not exported.
7407 (minibuf_save_list, choose_minibuf_frame): Now static.
7408 * lisp.h (choose_minibuf_frame): Remove decl.
7410 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7412 * lread.c: Make symbols static if they're not exported.
7413 (read_objects, initial_obarray, oblookup_last_bucket_number):
7415 (make_symbol): Remove; unused.
7416 * lisp.h (initial_obarray, make_symbol): Remove decls.
7418 * keyboard.c: Make symbols static if they're not exported.
7419 (single_kboard, recent_keys_index, total_keys, recent_keys):
7420 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7421 (this_single_command_key_start, echoing, last_auto_save):
7422 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7423 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7424 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7425 (Vlispy_mouse_stem, double_click_count):
7427 (force_auto_save_soon): Define only if SIGDANGER.
7428 (ignore_mouse_drag_p): Now static if
7429 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7430 (print_help): Remove; unused.
7431 (stop_character, last_timer_event): Mark as externally visible.
7432 * keyboard.h (ignore_mouse_drag_p): Declare only if
7433 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7434 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7435 * lisp.h (echoing): Remove decl.
7436 (force_auto_save_soon): Declare only if SIGDANGER.
7437 * xdisp.c (redisplay_window): Simplify code, to make it more
7438 obvious that ignore_mouse_drag_p is not accessed if !defined
7439 USE_GTK && !defined HAVE_NS.
7441 * intervals.c: Make symbols static if they're not exported.
7442 (merge_properties_sticky, merge_interval_right, delete_interval):
7444 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7446 * insdel.c: Make symbols static if they're not exported.
7447 However, leave prepare_to_modify_buffer alone. It's never
7448 called from outside this function, but that appears to be a bug.
7449 (combine_after_change_list, combine_after_change_buffer):
7450 (adjust_after_replace, signal_before_change): Now static.
7451 (adjust_after_replace_noundo): Remove; unused.
7452 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7453 (signal_before_change): Remove decls.
7455 * indent.c (val_compute_motion, val_vmotion): Now static.
7457 * image.c: Make symbols static if they're not exported.
7458 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7460 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7461 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7463 * fringe.c (standard_bitmaps): Now static.
7464 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7466 * frame.c: Make symbols static if they're not exported.
7467 (x_report_frame_params, make_terminal_frame): Now static.
7468 (get_frame_param): Now static, unless HAVE_NS.
7469 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7470 (x_get_resource_string): Remove; not used.
7471 * frame.h (make_terminal_frame, x_report_frame_params):
7472 (x_get_resource_string); Remove decls.
7473 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7474 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7476 * font.c, fontset.c: Make symbols static if they're not exported.
7477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7478 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7479 * font.c (font_close_object): Now static.
7480 * font.h (font_close_object): Remove.
7481 * fontset.c (FONTSET_OBJLIST): Remove.
7482 (free_realized_fontset) #if-0 the body, which does nothing.
7483 (face_suitable_for_char_p): #if-0, as it's never called.
7484 * fontset.h (face_suitable_for_char_p): Remove decl.
7485 * xfaces.c (face_at_string_position):
7486 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7487 since 0 is always ASCII.
7489 * fns.c (weak_hash_tables): Now static.
7491 * fileio.c: Make symbols static if they're not exported.
7492 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7493 (Vwrite_region_annotation_buffers): Now static.
7495 * eval.c: Make symbols static if they're not exported.
7496 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7497 * lisp.h (backtrace_list): Remove decl.
7499 * emacs.c: Make symbols static if they're not exported.
7500 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7501 (fatal_error_code, fatal_error_signal_hook, standard_args):
7503 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7504 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7505 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7506 * lisp.h (fatal_error_signal_hook): Remove decl.
7507 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7509 * editfns.c: Move a (normally-unused) function to its only use.
7510 * editfns.c, lisp.h (get_operating_system_release): Remove.
7511 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7512 worth the hassle of breaking this out.
7514 * xterm.c: Make symbols static if they're not exported.
7515 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7516 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7517 (x_destroy_window, x_delete_display):
7519 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7520 (x_mouse_leave): Remove; unused.
7521 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7522 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7523 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7525 (x_mouse_leave): Declare only if WINDOWSNT.
7526 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7527 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7530 * ftxfont.c: Make symbols static if they're not exported.
7531 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7533 * font.h (ftxfont_driver): Likewise.
7535 * xfns.c: Make symbols static if they're not exported.
7536 (x_last_font_name, x_display_info_for_name):
7537 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7538 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7539 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7540 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7541 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7542 (last_show_tip_args): Now static.
7543 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7544 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7545 (x_screen_planes): Remove; unused.
7546 * dispextern.h (x_screen_planes): Remove decl.
7548 * dispnew.c: Make symbols static if they're not exported.
7549 * dispextern.h (redraw_garbaged_frames, scrolling):
7550 (increment_row_positions): Remove.
7551 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7552 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7554 (redraw_garbaged_frames): Remove; unused.
7556 * xfaces.c: Make symbols static if they're not exported.
7557 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7559 * xterm.h (defined_color): Remove decls.
7560 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7561 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7562 (menu_face_changed_default, defined_color, free_realized_face):
7563 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7564 (ascii_face_of_lisp_face): Remove; unused.
7566 * xdisp.c: Make symbols static if they're not exported.
7567 * dispextern.h (scratch_glyph_row, window_box_edges):
7568 (glyph_to_pixel_coords, set_cursor_from_row):
7569 (get_next_display_element, set_iterator_to_next):
7570 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7571 (show_mouse_face): Remove decls
7572 * frame.h (message_buf_print): Likewise.
7573 * lisp.h (pop_message, set_message, check_point_in_composition):
7575 * xterm.h (set_vertical_scroll_bar): Likewise.
7576 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7577 (message_buf_print, scratch_glyph_row, displayed_buffer):
7578 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7579 (get_next_display_element, show_mouse_face, window_box_edges):
7580 (frame_to_window_pixel_xy, check_point_in_composition):
7581 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7582 (glyph_to_pixel_coords): Remove; unused.
7584 * dired.c (file_name_completion): Now static.
7586 * dbusbind.c (xd_in_read_queued_messages): Now static.
7588 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7589 * data.c (circular_list_error): Remove.
7591 * commands.h (last_point_position, last_point_position_buffer):
7592 (last_point_position_window): Remove decls.
7593 * keyboard.c: Make these variables static.
7595 * coding.h (coding, code_convert_region, encode_coding_gap):
7597 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7598 (iso_code_class, detect_coding, code_convert_region): Now static.
7599 (encode_coding_gap): Remove; unused.
7601 * chartab.c (chartab_chars, chartab_bits): Now static.
7603 * charset.h (charset_iso_8859_1): Remove decl.
7604 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7607 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7608 * ccl.c (Vccl_program_table): Now static.
7609 (check_ccl_update): Remove; unused.
7611 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7612 * category.h: ... from here.
7613 * category.c (check_category_table, set_category_set): Now static.
7615 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7616 * lisp.h: Remove these decls.
7618 * buffer.c (buffer_count): Remove unused var.
7620 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7621 so that it's not optimized away.
7622 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7623 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7624 exported only to the debugger.
7626 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7627 * atimer.h (run_all_atimers): Remove; not exported.
7629 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7630 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7631 was inaccessible from Lisp.
7632 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7633 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7635 alloc.c: Import and export fewer symbols, and remove unused items.
7636 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7638 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7639 it's not optimized away by whole-program optimization.
7640 (message_enable_multibyte, free_misc): Remove.
7641 (catchlist, handlerlist, mark_backtrace):
7642 Declare only if BYTE_MARK_STACK.
7643 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7644 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7645 (message_enable_multibyte): Remove decl.
7646 (free_misc, interval_free_list, float_block, float_block_index):
7647 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7648 (cons_free_list, last_marked_index):
7650 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7651 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7652 (mark_backtrace): Define only if BYTE_MARK_STACK.
7653 * xdisp.c (message_enable_multibyte): Now static.
7655 Declare Lisp_Object Q* variables to be 'static' if not exported.
7656 This makes it easier for human readers (and static analyzers)
7657 to see whether these variables are used from other modules.
7658 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7659 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7660 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7661 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7662 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7663 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7664 * xmenu.c, xselect.c:
7665 Declare Q* vars static if they are not used in other modules.
7666 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7667 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7668 Remove decls of unexported vars.
7669 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7671 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7673 Make Emacs functions such as Fatom 'static' by default.
7674 This makes it easier for human readers (and static analyzers)
7675 to see whether these functions can be called from other modules.
7676 DEFUN now defines a static function. To make the function external
7677 so that it can be used in other C modules, use the new macro DEFUE.
7678 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7679 (Finit_image_library):
7680 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7681 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7682 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7683 Remove decls, since these functions are now static.
7684 (Funintern, Fget_internal_run_time): New decls, since these functions
7685 were already external.
7687 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7688 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7689 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7690 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7691 * keyboard.c, keymap.c, lread.c:
7692 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7693 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7694 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7695 Mark functions with DEFUE instead of DEFUN,
7696 if they are used in other modules.
7697 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7698 decls for now-static functions.
7699 * buffer.h (Fdelete_overlay): Remove decl.
7700 * callproc.c (Fgetenv_internal): Mark as internal.
7701 * composite.c (Fremove_list_of_text_properties): Remove decl.
7702 (Fcomposition_get_gstring): New forward static decl.
7703 * composite.h (Fcomposite_get_gstring): Remove decl.
7704 * dired.c (Ffile_attributes): New forward static decl.
7705 * doc.c (Fdocumntation_property): New forward static decl.
7706 * eval.c (Ffetch_bytecode): New forward static decl.
7707 (Funintern): Remove extern decl; now in .h file where it belongs.
7708 * fileio.c (Fmake_symbolic_link): New forward static decl.
7709 * image.c (Finit_image_library): New forward static decl.
7710 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7711 * intervals.h (Fprevious_property_change):
7712 (Fremove_list_of_text_properties): Remove decls.
7713 * keyboard.c (Fthis_command_keys): Remove decl.
7714 (Fcommand_execute): New forward static decl.
7715 * keymap.c (Flookup_key): New forward static decl.
7716 (Fcopy_keymap): Now static.
7717 * keymap.h (Flookup_key): Remove decl.
7718 * process.c (Fget_process): New forward static decl.
7719 (Fprocess_datagram_address): Mark as internal.
7720 * syntax.c (Fsyntax_table_p): New forward static decl.
7721 (skip_chars): Remove duplicate decl.
7722 * textprop.c (Fprevious_property_change): New forward static decl.
7723 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7725 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7726 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7728 * editfns.c (Fformat): Remove unreachable code.
7730 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7732 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7735 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7737 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7738 when at ZV. (Bug#8487)
7740 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7742 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7744 * keyboard.c (parse_tool_bar_item): Likewise.
7745 * sound.c (sound_cleanup, alsa_close): Likewise.
7746 * termcap.c (tgetent): Likewise.
7747 * xfns.c (x_default_font_parameter): Likewise.
7748 * xsettings.c (read_and_apply_settings): Likewise.
7750 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7751 (overrun_check_free): Protoize.
7753 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7755 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7756 since callers should never pass a negative size.
7757 Change the signature to match that of plain 'read' and 'write'; see
7758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7759 * lisp.h: Update prototypes of emacs_write and emacs_read.
7761 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7763 * xdisp.c (redisplay_window): Don't try to determine the character
7764 position of the scroll margin if the window start point w->startp
7765 is outside the buffer's accessible region. (Bug#8468)
7767 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7769 Fix write-region and its subroutines for buffers > 2GB.
7770 * fileio.c (a_write, e_write): Modify declaration of arguments and
7771 local variables to support buffers larger than 2GB.
7772 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7774 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7775 argument, local variables, and return value.
7777 * lisp.h: Update prototypes of emacs_write and emacs_read.
7779 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7781 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7783 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7785 Fix more problems found by GCC 4.6.0's static checks.
7787 * xdisp.c (vmessage): Use a better test for character truncation.
7789 * charset.c (load_charset_map): <, not <=, for optimization,
7790 and to avoid potential problems with integer overflow.
7791 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7792 * casetab.c (set_identity, shuffle): Likewise.
7793 * editfns.c (Fformat): Likewise.
7794 * syntax.c (skip_chars): Likewise.
7796 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7797 This also lets GCC 4.6.0 generate slightly better loop code.
7799 * callint.c (Fcall_interactively): <, not <=, for optimization.
7800 (Fcall_interactively): Count the number of arguments produced,
7801 not the number of arguments given. This is simpler and lets GCC
7802 4.6.0 generate slightly better code.
7804 * ftfont.c: Distingish more carefully between FcChar8 and char.
7805 The previous code passed unsigned char * to a functions like
7806 strlen and xstrcasecmp that expect char *, which does not
7807 conform to the C standard.
7808 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7809 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7810 char * when the C standard requires it.
7812 * keyboard.c (read_char): Remove unused var.
7814 * eval.c: Port to Windows vsnprintf (Bug#8435).
7816 (SIZE_MAX): Define if the headers do not.
7817 (verror): Do not give up if vsnprintf returns a negative count.
7818 Instead, grow the buffer. This ports to Windows vsnprintf, which
7819 does not conform to C99. Problem reported by Eli Zaretskii.
7820 Also, simplify the allocation scheme, by avoiding the need for
7821 calling realloc, and removing the ALLOCATED variable.
7823 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7825 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7826 But keep the doprint source code for now, as we might revamp it
7827 and use it again (Bug#8435).
7828 * lisp.h (doprnt): Remove.
7829 * Makefile.in (base_obj): Remove doprnt.o.
7830 * deps.mk (doprnt.o): Remove.
7832 error: Print 32- and 64-bit integers portably (Bug#8435).
7833 Without this change, on typical 64-bit hosts error ("...%d...", N)
7834 was used to print both 32- and 64-bit integers N, which relied on
7836 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7837 * lisp.h (error, verror): Mark as printf-like functions.
7838 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7839 Report overflow in size calculations when allocating printf buffer.
7840 Do not truncate output string at its first null byte.
7841 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7842 Truncate the output at a character boundary, since vsnprintf does not
7844 * charset.c (check_iso_charset_parameter): Convert internal
7845 character to string before calling 'error', since %c now has the
7847 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7848 overflow when computing char to be passed to 'error'. Do not
7849 pass Lisp_Object to 'error'; pass the integer instead.
7850 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7851 formatted with plain %d.
7853 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7855 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7857 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7859 * xterm.c (x_catch_errors): Remove duplicate declaration.
7861 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7863 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7865 2011-04-10 Jim Meyering <meyering@redhat.com>
7867 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7868 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7869 return ssize_t not "int", and use size_t as the buffer length.
7870 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7871 * gnutls.h: Update declarations.
7872 * process.c (read_process_output): Use ssize_t, to match.
7873 (send_process): Likewise.
7875 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7877 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7879 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7881 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7882 Use unsigned char, to match FcChar8 type definition.
7884 * xterm.c (handle_one_xevent):
7885 * xmenu.c (create_and_show_popup_menu):
7886 * xselect.c (x_decline_selection_request)
7887 (x_reply_selection_request): Avoid type-punned deref of X events.
7889 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7891 Fix some uses of `int' instead of EMACS_INT.
7892 * search.c (string_match_1, fast_string_match)
7893 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7894 (scan_buffer, find_next_newline_no_quit)
7895 (find_before_next_newline, search_command, Freplace_match)
7896 (Fmatch_data): Make some `int' variables be EMACS_INT.
7898 * xdisp.c (display_count_lines): 3rd argument and return value now
7899 EMACS_INT. All callers changed.
7900 (pint2hrstr): Last argument is now EMACS_INT.
7902 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7903 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7904 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7905 (decode_coding_utf_16, decode_coding_emacs_mule)
7906 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7907 (decode_coding_ccl, decode_coding_charset)
7908 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7909 (decode_coding_iso_2022, decode_coding_emacs_mule)
7910 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7911 <char_offset, last_offset>: Declare EMACS_INT.
7912 (encode_coding_utf_8, encode_coding_utf_16)
7913 (encode_coding_emacs_mule, encode_invocation_designation)
7914 (encode_designation_at_bol, encode_coding_iso_2022)
7915 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7916 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7918 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7919 (encode_invocation_designation): Last argument P_NCHARS is now
7921 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7922 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7924 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7927 * ccl.c (Fccl_execute_on_string): Declare some variables
7930 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7932 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7934 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7936 * process.c (Fformat_network_address): Doc fix.
7938 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7940 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7942 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7944 * keyboard.c (read_char): Call Lisp function help-form-show,
7945 instead of using internal_with_output_to_temp_buffer.
7946 (Qhelp_form_show): New var.
7947 (syms_of_keyboard): Use DEFSYM macro.
7949 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7951 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7953 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7955 * process.c (Flist_processes): Remove to Lisp.
7956 (list_processes_1): Delete.
7958 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7960 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7962 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7964 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7966 Fix more problems found by GCC 4.6.0's static checks.
7968 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7970 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7972 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7974 * xdisp.c (vmessage): Mark as a printf-like function.
7976 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7978 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7980 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7981 printf-like functions.
7982 (tiff_load): Add casts to remove these marks before passing them
7983 to system-supplied API.
7985 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7987 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7988 This avoids several warnings with gcc -Wstrict-overflow.
7989 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7990 directly, rather than having caller test rule sign. This avoids
7991 some unnecessary tests.
7992 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7993 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7994 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7996 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7997 (xfont_open): Avoid unnecessary tests.
7999 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8001 * composite.h, composite.c (composition_gstring_put_cache):
8002 Use EMACS_INT, not int, for length.
8004 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8005 breaking out part of COMPOSITION_DECODE_RULE.
8006 (COMPOSITION_DECODE_RULE): Use it.
8007 * composite.c (get_composition_id): Remove unused local vars,
8008 by using the new macro.
8010 * textprop.c (set_text_properties_1): Change while to do-while,
8011 since the condition is always true at first.
8013 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8014 (interval_deletion_adjustment): Return unsigned value.
8017 * process.c (list_processes_1, create_pty, read_process_output):
8018 (exec_sentinel): Remove vars that were set but not used.
8019 (create_pty): Remove unnecessary "volatile"s.
8020 (Fnetwork_interface_info): Avoid possibility of int overflow.
8021 (read_process_output): Do adaptive read buffering even if carryover.
8022 (read_process_output): Simplify nbytes computation if buffered.
8024 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8026 * syntax.c (scan_words): Remove var that was set but not used.
8027 (update_syntax_table): Use unsigned instead of int.
8029 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8030 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8031 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8033 * print.c (print_error_message): Avoid int overflow.
8035 * font.c (font_list_entities): Redo for clarity,
8036 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8038 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8039 (font_score): Avoid potential overflow in diff calculation.
8041 * fns.c (substring_both): Remove var that is set but not used.
8042 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8044 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8046 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8047 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8048 can always succeed if overflow has undefined behavior.
8050 * search.c (boyer_moore, wordify): Remove vars set but not used.
8051 (wordify): Omit three unnecessary tests.
8053 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8054 All callers changed. This avoids the need for an unused var.
8056 * casefiddle.c (casify_region): Remove var that is set but not used.
8058 * dired.c (file_name_completion): Remove var that is set but not used.
8060 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8062 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8063 (Finsert_file_contents): Remove unnecessary code checking fd.
8065 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8066 Check for integer overflow on size calculations.
8068 * buffer.c (Fprevious_overlay_change): Remove var that is set
8071 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8072 Remove vars that are set but not used.
8073 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8074 (timer_check_2): Mark vars as initialized.
8076 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8078 * image.c (lookup_image): Remove var that is set but not used.
8079 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8081 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8082 that are set but not used.
8084 * xfns.c (make_invisible_cursor): Don't return garbage
8085 if XCreateBitmapFromData fails (Bug#8410).
8087 * xselect.c (x_get_local_selection, x_handle_property_notify):
8088 Remove vars that are set but not used.
8090 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8091 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8093 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8094 Remove var that is set but not used.
8095 (scroll_bar_windows_size): Now size_t, not int.
8096 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8099 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8100 (map_tty_color) [!defined MSDOS]: Likewise.
8102 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8104 * coding.c: Remove vars that are set but not used.
8105 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8106 All callers changed.
8107 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8108 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8109 (decode_coding_charset): Remove vars that are set but not used.
8111 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8112 that is set but not used.
8114 * print.c (print_object): Remove var that is set but not used.
8116 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8117 The gnulib version avoids calling malloc in the usual case,
8118 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8119 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8120 * filelock.c (current_lock_owner): Likewise.
8121 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8122 * sysdep.c: Include allocator.h, careadlinkat.h.
8123 (emacs_no_realloc_allocator): New static constant.
8124 (emacs_readlink): New function.
8125 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8126 ../lib/careadlinkat.h.
8128 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8130 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8131 first non-nil return value).
8133 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8135 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8136 if not defined (Bug#8403).
8138 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8140 * xdisp.c (display_count_lines): Remove parameter `start',
8141 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8142 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8143 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8144 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8145 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8146 and thereabouts. All callers changed.
8147 (get_per_char_metric): Remove parameter `f', unused since
8148 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8150 2011-04-02 Jim Meyering <meyering@redhat.com>
8152 do not dereference NULL upon failed strdup
8153 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8154 (ns_get_family): Likewise.
8156 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8158 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8160 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8162 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8165 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8167 Add lexical binding.
8169 * window.c (Ftemp_output_buffer_show): New fun.
8170 (Fsave_window_excursion):
8171 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8173 * lread.c (lisp_file_lexically_bound_p): New function.
8174 (Fload): Bind Qlexical_binding.
8175 (readevalloop): Remove `evalfun' arg.
8176 Bind Qinternal_interpreter_environment.
8177 (Feval_buffer): Bind Qlexical_binding.
8178 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8180 (syms_of_lread): Declare `lexical-binding'.
8182 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8184 * keyboard.c (eval_dyn): New fun.
8185 (menu_item_eval_property): Use it.
8187 * image.c (parse_image_spec): Use Ffunctionp.
8189 * fns.c (concat, mapcar1): Accept byte-code-functions.
8191 * eval.c (Fsetq): Handle lexical vars.
8192 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8193 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8194 (FletX, Flet): Obey lexical binding.
8195 (Fcommandp): Handle closures.
8196 (Feval): New `lexical' arg.
8197 (eval_sub): New function extracted from Feval. Use it almost
8198 everywhere where Feval was used. Look up vars in lexical env.
8200 (Ffunctionp): Move from subr.el.
8201 (Ffuncall): Handle closures.
8202 (apply_lambda): Remove `eval_flags'.
8203 (funcall_lambda): Handle closures and new byte-code-functions.
8204 (Fspecial_variable_p): New function.
8205 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8206 but without exporting it to Lisp.
8208 * doc.c (Fdocumentation, store_function_docstring):
8209 * data.c (Finteractive_form): Handle closures.
8211 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8214 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8216 (exec_byte_code): New function extracted from Fbyte_code to handle new
8217 calling convention for byte-code-functions. Add new byte-codes.
8219 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8221 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8223 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8225 * xdisp.c (redisplay_internal): Fix prototype.
8227 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8229 * xdisp.c (SCROLL_LIMIT): New macro.
8230 (try_scrolling): Use it when setting scroll_limit.
8231 Limit scrolling to 100 screen lines.
8232 (redisplay_window): Even when falling back on "recentering",
8233 position point in the window according to scroll-conservatively,
8234 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8236 (try_scrolling): When point is above the window, allow searching
8237 as far as scroll_max, or one screenful, to compute vertical
8238 distance from PT to the scroll margin position. This prevents
8239 try_scrolling from unnecessarily failing when
8240 scroll-conservatively is set to a value slightly larger than the
8241 window height. Clean up the case of PT below the margin at bottom
8242 of window: scroll_max can no longer be INT_MAX. When aggressive
8243 scrolling is in use, don't let point enter the opposite scroll
8244 margin as result of the scroll.
8245 (syms_of_xdisp) <scroll-conservatively>: Document the
8246 threshold of 100 lines for never-recentering scrolling.
8248 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8250 * dispextern.h (move_it_by_lines):
8251 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8252 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8253 (message_log_check_duplicate): Remove parameters `prev_bol' and
8254 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8255 (redisplay_internal): Remove parameter `preserve_echo_area',
8256 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8258 * indent.c (Fvertical_motion):
8259 * window.c (window_scroll_pixel_based, Frecenter):
8260 Don't pass `need_y_p' to `move_it_by_lines'.
8262 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8264 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8265 steal a few bits to be more compact.
8266 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8267 Remove unneeded casts.
8269 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8271 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8273 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8274 binding" message (bug#7967).
8276 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8278 Fix more problems found by GCC 4.6.0's static checks.
8280 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8281 Remove unused local var.
8283 * editfns.c (Fmessage_box): Remove unused local var.
8285 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8286 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8287 Omit unused local vars.
8288 * window.c (shrink_windows): Omit unused local var.
8289 * menu.c (digest_single_submenu): Omit unused local var.
8290 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8291 Omit unused local var.
8293 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8294 Don't assume string length fits in int.
8295 (keyremap_step, read_key_sequence): Use size_t for sizes.
8296 (read_key_sequence): Don't check last_real_key_start redundantly.
8298 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8299 instead of alloca (Bug#8344).
8301 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8302 (Fbacktrace_frame): Don't assume nframes fits in int.
8304 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8306 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8309 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8311 * cm.c (calccost): Turn while-do into do-while, for clarity.
8313 * keyboard.c (syms_of_keyboard): Use the same style as later
8314 in this function when indexing through an array. This also
8315 works around GCC bug 48267.
8317 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8319 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8321 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8322 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8324 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8325 This avoids undefined behavior on integer overflow, and is a bit
8326 more convenient anyway since it is compared to a size_t variable.
8328 Variadic C functions now count arguments with size_t, not int.
8329 This avoids an unnecessary limitation on 64-bit machines, which
8330 caused (substring ...) to crash on large vectors (Bug#8344).
8331 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8332 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8333 All variadic functions and their callers changed accordingly.
8334 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8335 * data.c (arith_driver, float_arith_driver): Likewise.
8336 * editfns.c (general_insert_function): Likewise.
8337 * eval.c (struct backtrace.nargs, interactive_p)
8338 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8339 (funcall_lambda, mark_backtrace): Likewise.
8340 * fns.c (concat): Likewise.
8341 * frame.c (x_set_frame_parameters): Likewise.
8342 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8343 0 if not found, not -1. All callers changed.
8345 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8346 (stack_copy_size): Now size_t, not int.
8347 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8349 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8351 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8352 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8353 All callers changed.
8355 * lisp.h (multibyte_char_to_unibyte):
8356 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8357 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8358 * character.h (CHAR_TO_BYTE8):
8359 * cmds.c (internal_self_insert):
8360 * editfns.c (general_insert_function):
8361 * keymap.c (push_key_description):
8362 * search.c (Freplace_match):
8363 * xdisp.c (message_dolog, set_message_1): All callers changed.
8365 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8367 * keyboard.c (safe_run_hook_funcall): New function.
8368 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8369 don't set the hook to nil, but remove the offending function instead.
8370 (Qcommand_hook_internal): Remove, unused.
8371 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8372 Vcommand_hook_internal.
8374 * eval.c (enum run_hooks_condition): Remove.
8375 (funcall_nil, funcall_not): New functions.
8376 (run_hook_with_args): Call each function through a `funcall' argument.
8377 Remove `cond' argument, now redundant.
8378 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8379 (Frun_hook_with_args_until_failure): Adjust accordingly.
8380 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8382 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8384 * dispextern.h (string_buffer_position): Remove declaration.
8386 * print.c (strout): Remove parameter `multibyte', unused since
8387 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8389 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8390 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8391 All callers changed.
8393 * w32.c (_wsa_errlist): Use braces for struct initializers.
8395 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8396 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8397 All callers changed.
8398 (string_buffer_position): Likewise. Also, make static (it's never
8399 used outside xdisp.c).
8400 (cursor_row_p): Remove parameter `w', unused since
8401 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8402 (decode_mode_spec): Remove parameter `precision', introduced during
8403 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8404 All callers changed.
8406 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8408 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8410 2011-03-27 Anders Lindgren <andlind@gmail.com>
8412 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8413 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8414 (ns_update_auto_hide_menu_bar): New functions.
8415 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8416 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8417 ns_constrain_all_frames.
8418 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8419 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8421 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8423 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8425 2011-03-27 Glenn Morris <rgm@gnu.org>
8427 * syssignal.h: Replace RETSIGTYPE with void.
8428 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8429 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8430 Replace SIGTYPE with void everywhere.
8431 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8432 * s/template.h (SIGTYPE): Remove commented out definition.
8434 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8436 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8437 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8439 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8441 * w32.c (read_unc_volume): Use parameter `henum', instead of
8442 global variable `wget_enum_handle'.
8444 * keymap.c (describe_vector): Remove parameters `indices' and
8445 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8446 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8448 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8450 * keyboard.c (timer_check): Remove parameter `do_it_now',
8451 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8452 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8453 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8455 * keyboard.c (read_char):
8456 * w32menu.c (w32_menu_display_help):
8457 * xmenu.c (show_help_event, menu_help_callback):
8458 Adjust calls to `show_help_echo'.
8460 * gtkutil.c (xg_maybe_add_timer):
8461 * keyboard.c (readable_events):
8462 * process.c (wait_reading_process_output):
8463 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8465 * insdel.c (adjust_markers_gap_motion):
8466 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8467 (gap_left, gap_right): Don't call it.
8469 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8471 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8472 incurred during fontification.
8474 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8476 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8477 (DEFVAR_PER_BUFFER): Don't pass it.
8479 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8480 (scrolling_window): Don't pass it.
8482 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8484 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8486 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8488 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8489 of variables specific to SELinux and computation of `encoded_absname'.
8491 * image.c (XPutPixel): Remove unused variable `height'.
8493 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8495 * unexw32.c (get_section_info): Remove unused variable `section'.
8497 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8498 (system_process_attributes): Remove unused variable `sess'.
8499 (sys_read): Remove unused variable `err'.
8501 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8502 (w32_wnd_proc): Remove unused variable `isdead'.
8503 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8504 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8505 (x_create_tip_frame): Remove unused variable `tem'.
8507 * w32inevt.c (w32_console_read_socket):
8508 Remove unused variable `no_events'.
8510 * w32term.c (x_draw_composite_glyph_string_foreground):
8511 Remove unused variable `width'.
8513 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8515 * w32term.c (x_set_glyph_string_clipping):
8516 Don't pass uninitialized region to CombineRgn.
8518 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8520 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8521 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8522 (Fx_close_connection): Remove unused variable `i'.
8524 * w32font.c (w32font_draw): Return number of glyphs.
8525 (w32font_open_internal): Remove unused variable `i'.
8526 (w32font_driver): Add missing initializer.
8528 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8529 (fill_in_menu): Remove unused variable `items_added'.
8531 * w32term.c (last_mouse_press_frame): Remove static global variable.
8532 (w32_clip_to_row): Remove unused variable `f'.
8533 (x_delete_terminal): Remove unused variable `i'.
8535 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8536 (NOTHING): Remove unused static global variable.
8537 (uniscribe_check_otf): Remove unused variable `table'.
8538 (uniscribe_font_driver): Add missing initializers.
8540 2011-03-23 Julien Danjou <julien@danjou.info>
8542 * term.c (Fsuspend_tty, Fresume_tty):
8543 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8544 * window.c (temp_output_buffer_show):
8545 * insdel.c (signal_before_change):
8546 * frame.c (Fhandle_switch_frame):
8547 * fileio.c (Fdo_auto_save):
8548 * emacs.c (Fkill_emacs):
8549 * editfns.c (save_excursion_restore):
8550 * cmds.c (internal_self_insert):
8551 * callint.c (Fcall_interactively):
8552 * buffer.c (Fkill_all_local_variables):
8553 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8555 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8556 unconditionally since it does the check itself.
8558 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8560 Fix more problems found by GCC 4.5.2's static checks.
8562 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8563 the first time through the loop, since we know p0 < p1 then.
8564 This also avoids a gcc -Wstrict-overflow warning.
8566 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8567 leading to a memory leak, possible in functions like
8568 load_charset_map_from_file that can allocate an unbounded number
8569 of objects (Bug#8318).
8571 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8572 that could (at least in theory) be that large.
8574 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8575 This is less likely to overflow, and avoids undefined behavior if
8576 overflow does occur. All callers changed. Use strtoul to scan
8577 for the unsigned long integer.
8578 (pint2hrstr): Simplify and tune code slightly.
8579 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8581 * scroll.c (do_scrolling): Work around GCC bug 48228.
8582 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8584 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8585 This also avoids a warning with gcc -Wstrict-overflow.
8586 (validate_x_resource_name): Simplify count usage.
8587 This also avoids a warning with gcc -Wstrict-overflow.
8589 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8592 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8594 * process.c (Fmake_network_process): Use socklen_t, not int,
8595 where POSIX says socklen_t is required in portable programs.
8596 This fixes a porting bug on hosts like 64-bit HP-UX, where
8597 socklen_t is wider than int (Bug#8277).
8598 (Fmake_network_process, server_accept_connection):
8599 (wait_reading_process_output, read_process_output):
8602 * process.c: Rename or move locals to avoid shadowing.
8603 (list_processes_1, Fmake_network_process):
8604 (read_process_output_error_handler, exec_sentinel_error_handler):
8605 Rename or move locals.
8606 (Fmake_network_process): Define label "retry_connect" only if needed.
8607 (Fnetwork_interface_info): Fix pointer signedness.
8608 (process_send_signal): Add cast to avoid pointer signedness problem.
8609 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8610 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8612 Make tparam.h and terminfo.c consistent.
8613 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8614 Include tparam.h instead, since it declares them.
8615 * cm.h (PC): Remove extern decl; tparam.h now does this.
8616 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8617 * terminfo.c: Include tparam.h, to check interfaces.
8618 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8619 (tparam): Adjust signature to match interface in tparam.h;
8620 this removes some undefined behavior. Check that outstring and len
8621 are zero, which they always are with Emacs.
8622 * tparam.h (PC, BC, UP): New extern decls.
8624 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8625 (xftfont_open): Rename locals to avoid shadowing.
8627 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8628 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8629 (OTF_TAG_SYM): Omit macro if not needed.
8630 (ftfont_list): Remove unused local.
8631 (get_adstyle_property, ftfont_pattern_entity):
8632 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8633 Rename locals to avoid shadowing.
8635 * xfont.c (xfont_list_family): Mark var as initialized.
8637 * xml.c (make_dom): Now static.
8639 * composite.c (composition_compute_stop_pos): Rename local to
8641 (composition_reseat_it): Remove unused locals.
8642 (find_automatic_composition, composition_adjust_point): Likewise.
8643 (composition_update_it): Mark var as initialized.
8644 (find_automatic_composition): Mark vars as initialized,
8645 with a FIXME (Bug#8290).
8647 character.h: Rename locals to avoid shadowing.
8648 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8649 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8650 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8651 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8654 * textprop.c (property_change_between_p): Remove; unused.
8656 * intervals.c (interval_start_pos): Now static.
8658 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8660 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8661 Rename locals to avoid shadowing.
8663 * sound.c (wav_play, au_play, Fplay_sound_internal):
8664 Fix pointer signedness.
8665 (alsa_choose_format): Remove unused local var.
8666 (wav_play): Initialize a variable to 0, to prevent undefined
8667 behavior (Bug#8278).
8669 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8671 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8674 clobbering (Bug#8298).
8675 * sysdep.c (sys_subshell): Likewise.
8676 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8678 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8679 This should get cleaned up, so that child_setup has the
8680 same signature on all platforms.
8682 * callproc.c (call_process_cleanup): Now static.
8683 (relocate_fd): Rename locals to avoid shadowing.
8685 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8687 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8688 not to be necessary, and produces flickering.
8690 2011-03-20 Glenn Morris <rgm@gnu.org>
8692 * config.in: Remove file.
8694 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8696 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8697 are now in src/globals.h.
8698 (syms_of_minibuf): Remove spurious & from previous change.
8700 2011-03-20 Leo Liu <sdl.web@gmail.com>
8702 * minibuf.c (completing-read-function): New variable.
8703 (completing-read-default): Rename from completing-read.
8704 (completing-read): Call completing-read-function.
8706 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8708 * xfaces.c (Fx_load_color_file):
8709 Read color file from absolute filename (bug#8250).
8711 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8713 * makefile.w32-in: Update dependencies.
8715 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8717 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8719 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8721 Fix more problems found by GCC 4.5.2's static checks.
8723 * process.c (make_serial_process_unwind, send_process_trap):
8724 (sigchld_handler): Now static.
8726 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8727 That way, the code declares only the vars that it needs.
8728 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8729 * s/cygwin.h (PTY_ITERATION): Likewise.
8730 * s/darwin.h (PTY_ITERATION): Likewise.
8731 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8733 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8734 * process.c (allocate_pty): Don't declare stb unless it's needed.
8736 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8737 (CONSTANTLIM): Remove; unused.
8738 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8739 Define only if needed.
8741 * unexelf.c (unexec): Name an expression,
8742 to avoid gcc -Wbad-function-cast warning.
8743 Use a different way to cause a compilation error if anyone uses
8744 n rather than nn, a way that does not involve shadowing.
8745 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8747 * deps.mk (unexalpha.o): Remove; unused.
8749 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8750 * unexec.h: New file.
8751 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8752 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8754 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8755 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8756 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8757 Change as necessary to match prototype in unexec.h.
8759 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8761 (back_comment, skip_chars): Mark vars as initialized.
8763 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8764 Rename locals to avoid shadowing.
8766 * lread.c (read1): Rewrite so as not to use empty "else".
8767 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8769 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8771 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8772 warning when compiling print.c.
8774 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8775 instead of using an uninitialized var.
8776 (font_sort_entities): Mark var as initialized.
8778 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8780 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8781 pointers to constants.
8782 (font_parse_fcname): Remove unused vars.
8783 (font_delete_unmatched): Now static.
8784 (font_get_spec): Remove; unused.
8785 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8786 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8787 Rename or move locals to avoid shadowing.
8789 * fns.c (require_nesting_list, require_unwind): Now static.
8790 (Ffillarray): Rename locals to avoid shadowing.
8792 * floatfns.c (domain_error2): Define only if needed.
8793 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8795 * alloc.c (mark_backtrace): Move decl from here ...
8796 * lisp.h: ... to here, so that it can be checked.
8798 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8799 (Fdefvar): Rewrite so as not to use empty "else".
8800 (lisp_indirect_variable): Name an expression,
8801 to avoid gcc -Wbad-function-cast warning.
8802 (Fdefvar): Rename locals to avoid shadowing.
8804 * callint.c (quotify_arg, quotify_args): Now static.
8805 (Fcall_interactively): Rename locals to avoid shadowing.
8806 Use const pointer when appropriate.
8808 * lisp.h (get_system_name, get_operating_system_release):
8809 Move decls here, to check interfaces.
8810 * process.c (get_operating_system_release): Move decl to lisp.h.
8811 * xrdb.c (get_system_name): Likewise.
8812 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8813 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8814 some of which prompt warnings from gcc -Wbad-function-cast.
8815 (Fformat_time_string, Fencode_time, Finsert_char):
8816 (Ftranslate_region_internal, Fformat):
8817 Rename or remove local vars to avoid shadowing.
8818 (Ftranslate_region_internal): Mark var as initialized.
8820 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8823 * lisp.h (eassert): Check that the argument compiles, even if
8824 ENABLE_CHECKING is not defined.
8826 * data.c (Findirect_variable): Name an expression, to avoid
8827 gcc -Wbad-function-cast warning.
8828 (default_value, arithcompare, arith_driver, arith_error): Now static.
8829 (store_symval_forwarding): Rename local to avoid shadowing.
8830 (Fmake_variable_buffer_local, Fmake_local_variable):
8831 Mark variables as initialized.
8832 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8834 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8835 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8836 Rename locals to avoid shadowing.
8837 (mark_stack): Move local variables into the #ifdef region where
8839 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8840 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8842 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8843 (GC_STRING_CHARS): Remove; not used.
8844 (Fmemory_limit): Cast sbrk's returned value to char *.
8846 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8847 avoids undefined behavior in theory.
8849 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8851 Use functions, not macros, for up- and down-casing (Bug#8254).
8852 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8853 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8854 to use the following functions instead of these macros.
8855 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8856 EMACS_INT, since callers assume the returned value fits in int.
8857 (upcase1): Likewise, for UPCASE_TABLE.
8858 (uppercasep, lowercasep, upcase): New static inline functions.
8859 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8860 the race-condition problem in the old DOWNCASE.
8862 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8863 Rename locals to avoid shadowing.
8864 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8865 (regex_compile, re_search_2, re_match_2_internal):
8866 Remove unused local vars.
8867 (FREE_VAR): Rewrite so as not to use empty "else",
8868 which gcc can warn about.
8869 (regex_compile, re_match_2_internal): Mark locals as initialized.
8870 (RETALLOC_IF): Define only if needed.
8871 (WORDCHAR_P): Likewise. This one is never needed, but is used
8872 only in a comment talking about a compiler bug, so put inside
8873 the #if 0 of that comment.
8874 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8875 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8878 * search.c (boyer_moore): Rename locals to avoid shadowing.
8879 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8880 (PREV_CHAR_BOUNDARY): Likewise.
8882 * search.c (simple_search): Remove unused var.
8884 * dired.c (compile_pattern): Move decl from here ...
8885 * lisp.h: ... to here, so that it can be checked.
8886 (struct re_registers): New forward decl.
8888 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8890 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8892 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8893 Rename locals to avoid shadowing.
8894 (Fvertical_motion): Mark locals as initialized.
8896 * casefiddle.c (casify_object, casify_region): Now static.
8897 (casify_region): Mark local as initialized.
8899 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8901 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8902 New macros, so that the caller can use some names other than
8903 gcpro1, gcpro2, etc.
8904 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8906 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8907 argument, for consistency with GCPRO2_VAR, etc: it is now the
8908 prefix of the variable, not the variable itself. All uses
8910 * dired.c (directory_files_internal, file_name_completion):
8911 Rename locals to avoid shadowing.
8913 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8914 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8915 dired.c's scmp function, had undefined behavior.
8916 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8917 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8918 * buffer.h: ... to here, because these macros use current_buffer,
8919 and the new implementation with inline functions needs to have
8920 current_buffer in scope now, rather than later when the macros
8922 (downcase, upcase1): New static inline functions.
8923 (DOWNCASE, UPCASE1): Reimplement using these functions.
8924 This avoids undefined behavior in expressions like
8925 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8926 from race conditions in accessing the global variables
8927 case_temp1 and case_temp2.
8928 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8929 * lisp.h (case_temp1, case_temp2): Remove their decls.
8930 * character.h (ASCII_CHAR_P): Move from here ...
8931 * lisp.h: ... to here, so that the inline functions mentioned
8934 * dired.c (directory_files_internal_unwind): Now static.
8936 * fileio.c (file_name_as_directory, directory_file_name):
8937 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8939 (file_name_as_directory): Use const pointers when appropriate.
8940 (Fexpand_file_name): Likewise. In particular, newdir might
8941 point at constant storage, so make it a const pointer.
8942 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8943 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8945 (Fset_file_times, Finsert_file_contents, auto_save_error):
8946 Rename locals to avoid shadowing.
8948 * minibuf.c (choose_minibuf_frame_1): Now static.
8949 (Ftry_completion, Fall_completions): Rename or remove locals
8952 * marker.c (bytepos_to_charpos): Remove; unused.
8954 * lisp.h (verify_bytepos, count_markers): New decls,
8955 so that gcc does not warn that these functions aren't declared.
8957 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8958 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8959 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8960 (copy_text): Remove unused local var.
8962 * filelock.c (within_one_second): Now static.
8963 (lock_file_1): Rename local to avoid shadowing.
8965 * buffer.c (fix_overlays_before): Mark locals as initialized.
8966 (fix_start_end_in_overlays): Likewise. This function should be
8967 simplified by using pointers-to-pointers, but that's a different
8969 (switch_to_buffer_1): Now static.
8970 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8971 (report_overlay_modification): Rename locals to avoid shadowing.
8973 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8974 Fix pointer signedness issue.
8975 (sys_subshell): Mark local as volatile if checking for lint,
8976 to suppress a gcc -Wclobbered warning that does not seem to be right.
8977 (MAXPATHLEN): Define only if needed.
8979 * process.c (serial_open, serial_configure): Move decls from here ...
8980 * systty.h: ... to here, so that they can be checked.
8982 * fns.c (get_random, seed_random): Move extern decls from here ...
8983 * lisp.h: ... to here, so that they can be checked.
8985 * sysdep.c (reset_io): Now static.
8986 (wait_for_termination_signal): Remove; unused.
8988 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8989 (copy_keymap_item, append_key, push_text_char_description):
8991 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8992 (DENSE_TABLE_SIZE): Remove; unused.
8993 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8994 (describe_map_tree):
8995 Rename locals to avoid shadowing.
8997 * keyboard.c: Declare functions static if they are not used elsewhere.
8998 (echo_char, echo_dash, cmd_error, top_level_2):
8999 (poll_for_input, handle_async_input): Now static.
9000 (read_char, kbd_buffer_get_event, make_lispy_position):
9001 (make_lispy_event, make_lispy_movement, apply_modifiers):
9002 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9003 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9004 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9005 (read_key_sequence, read_char): Mark locals as initialized.
9006 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9008 * keyboard.h (make_ctrl_char): New decl.
9009 (mark_kboards): Move decl here ...
9010 * alloc.c (mark_kboards): ... from here.
9012 * lisp.h (force_auto_save_soon): New decl.
9014 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9015 (DEFINE_DUMMY_FUNCTION): New macro.
9016 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9018 (main): Add casts to avoid warnings
9019 if GCC considers string literals to be constants.
9021 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9023 * dbusbind.c: Pointer signedness fixes.
9024 (xd_signature, xd_append_arg, xd_initialize):
9025 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9026 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9027 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9028 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9030 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9031 if GCC considers string literals to be constants.
9032 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9034 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9036 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9037 (print_preprocess, print_object): New macro to fix last change.
9039 * print.c (print_preprocess): Don't forget font objects.
9041 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9043 * emacs.c (USAGE3): Doc fixes.
9045 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9047 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9050 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9052 * lisp.h (VWindow_system, Qfile_name_history):
9053 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9054 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9055 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9057 * w32select.c: Don't #include "keyboard.h".
9058 (run_protected): Add extern declaration for waiting_for_input.
9060 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9061 * w32console.c (detect_input_pending, read_input_pending)
9062 (encode_terminal_code):
9063 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9064 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9065 (w32_system_caret_y, Qfile_name_history):
9066 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9067 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9068 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9069 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9070 * w32proc.c (Qlocal, report_file_error):
9071 * w32term.c (Vwindow_system, updating_frame):
9072 * w32uniscribe.c (initialized, uniscribe_font_driver):
9073 Remove unneeded extern declarations.
9075 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9077 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9079 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9081 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9082 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9083 These macros can no longer be used for assignment.
9085 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9086 Assign struct members directly, instead of using BUF_BEGV etc.
9087 (record_buffer_markers, fetch_buffer_markers): New functions for
9088 recording and fetching special buffer markers.
9089 (set_buffer_internal_1, set_buffer_temp): Use them.
9091 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9093 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9095 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9096 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9098 * xdisp.c (hscroll_window_tree):
9099 (reconsider_clip_changes): Use PT instead of BUF_PT.
9101 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9103 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9104 $(EMACS_ROOT)/lib/intprops.h.
9106 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9108 Fix more problems found by GCC 4.5.2's static checks.
9110 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9111 to unsigned char * to avoid compiler diagnostic.
9112 (xg_free_frame_widgets): Make it clear that a local variable is
9113 needed only if USE_GTK_TOOLTIP.
9114 (gdk_window_get_screen): Make it clear that this macro is needed
9115 only if USE_GTK_TOOLTIP.
9116 (int_gtk_range_get_value): New function, which avoids a diagnostic
9117 from gcc -Wbad-function-cast.
9118 (xg_set_toolkit_scroll_bar_thumb): Use it.
9119 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9120 diagnostic from gcc -Wbad-function-cast.
9121 (get_utf8_string, xg_get_file_with_chooser):
9122 Rename locals to avoid shadowing.
9123 (create_dialog): Move locals to avoid shadowing.
9125 * xgselect.c (xg_select): Remove unused var.
9127 * image.c (four_corners_best): Mark locals as initialized.
9128 (gif_load): Initialize transparent_p to zero (Bug#8238).
9129 Mark another local as initialized.
9130 (my_png_error, my_error_exit): Mark with NO_RETURN.
9132 * image.c (clear_image_cache): Now static.
9133 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9134 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9135 (x_edge_detection): Remove unnecessary cast that
9136 gcc -Wbad-function-cast diagnoses.
9137 (gif_load): Fix pointer signedness.
9138 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9139 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9141 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9143 Improve quality of tests for time stamp overflow.
9144 For example, without this patch (encode-time 0 0 0 1 1
9145 1152921504606846976) returns the obviously-bogus value (-948597
9146 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9147 reports time overflow. See
9148 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9149 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9150 * editfns.c: Include limits.h and intprops.h.
9151 (TIME_T_MIN, TIME_T_MAX): New macros.
9152 (time_overflow): Move earlier, to before first use.
9153 (hi_time, lo_time): New functions, for an accurate test for
9155 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9156 (Fget_internal_run_time): Don't assume time_t fits in int.
9157 (make_time): Use list2 instead of Fcons twice.
9158 (Fdecode_time): More accurate test for out-of-range times.
9159 (check_tm_member): New function.
9160 (Fencode_time): Use it, to test for out-of-range times.
9161 (lisp_time_argument): Don't rely on undefined left-shift and
9162 right-shift behavior when checking for time stamp overflow.
9164 * editfns.c (time_overflow): New function, refactoring common code.
9165 (Fformat_time_string, Fdecode_time, Fencode_time):
9166 (Fcurrent_time_string): Use it.
9168 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9169 * dired.c (make_time): Move to ...
9170 * editfns.c (make_time): ... here.
9171 * systime.h: Note the move.
9173 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9175 * fringe.c (update_window_fringes): Remove unused variables.
9177 * unexmacosx.c (copy_data_segment): Also copy __got section.
9180 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9182 * termcap.c [MSDOS]: Include "msdos.h".
9183 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9184 Constify `char *' arguments and their references according to
9185 prototypes in tparam.h.
9187 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9189 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9190 Adapt all references accordingly.
9192 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9194 2011-03-11 Tom Tromey <tromey@redhat.com>
9196 * buffer.c (syms_of_buffer): Remove obsolete comment.
9198 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9200 * termhooks.h (encode_terminal_code): Declare prototype.
9202 * msdos.c (encode_terminal_code): Don't declare prototype.
9204 * term.c (encode_terminal_code): Now external again, used by
9205 w32console.c and msdos.c.
9207 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9208 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9210 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9212 Fix some minor problems found by GCC 4.5.2's static checks.
9214 * fringe.c (update_window_fringes): Mark locals as initialized
9216 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9218 * alloc.c (mark_fringe_data): Move decl from here ...
9219 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9220 to check its interface.
9221 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9223 * fontset.c (free_realized_fontset): Now static.
9224 (Fset_fontset_font): Rename local to avoid shadowing.
9225 (fontset_font): Mark local as initialized.
9226 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9228 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9230 * xselect.c (x_disown_buffer_selections): Remove; not used.
9231 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9232 (x_own_selection, Fx_disown_selection_internal): Rename locals
9234 (x_handle_dnd_message): Remove local to avoid shadowing.
9236 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9237 so that the caller can use some name other than gcpro1.
9238 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9239 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9240 (Fx_backspace_delete_keys_p):
9241 Use them to avoid shadowing, and rename vars to avoid shadowing.
9242 (x_decode_color, x_set_name, x_window): Now static.
9243 (Fx_create_frame): Add braces to silence GCC warning.
9244 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9245 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9246 Remove unused locals.
9247 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9248 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9249 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9252 * xterm.h (x_mouse_leave): New decl.
9254 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9255 Remove unused functions.
9256 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9257 (x_calc_absolute_position): Now static.
9258 (XTread_socket): Don't define label "out" unless it's used.
9259 Don't declare local "event" unless it's used.
9260 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9261 unless they are used.
9262 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9263 (x_fatal_error_signal): Remove; not used.
9264 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9265 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9266 (x_error_catcher, x_connection_closed, x_error_handler):
9267 (x_error_quitter, xembed_send_message, x_iconify_frame):
9268 (my_log_handler): Rename locals to avoid shadowing.
9269 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9270 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9272 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9273 Rename or move locals to avoid shadowing.
9274 (tty_defined_color, merge_face_heights): Now static.
9275 (free_realized_faces_for_fontset): Remove; not used.
9276 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9277 does not deduce is never used uninitialized.
9278 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9279 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9281 * terminal.c (store_terminal_param): Now static.
9283 * xmenu.c (menu_highlight_callback): Now static.
9284 (set_frame_menubar): Remove unused local.
9285 (xmenu_show): Rename parameter to avoid shadowing.
9286 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9287 since they might point to immutable storage.
9288 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9289 since it's unused otherwise.
9291 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9292 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9293 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9294 avoids a gcc -Wuninitialized diagnostic.
9295 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9296 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9297 does not deduce are never used uninitialized.
9299 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9301 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9302 * window.c (window_loop, size_window):
9303 (run_window_configuration_change_hook, enlarge_window): Likewise.
9305 * window.c (display_buffer): Now static.
9306 (size_window): Mark variables that gcc -Wuninitialized
9307 does not deduce are never used uninitialized.
9308 * window.h (check_all_windows): New decl, to forestall
9309 gcc -Wmissing-prototypes diagnostic.
9310 * dispextern.h (bidi_dump_cached_states): Likewise.
9312 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9314 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9316 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9317 and to avoid gcc -Wuninitialized warning.
9318 (load_charset_map): Mark variables that gcc -Wuninitialized
9319 does not deduce are never used uninitialized.
9320 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9322 * coding.c (coding_set_source, coding_set_destination):
9323 Use "else { /* comment */ }" rather than "else /* comment */;"
9324 for clarity, and to avoid gcc -Wempty-body warning.
9325 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9326 a block, when the outer 'i' will do.
9327 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9328 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9329 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9330 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9331 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9332 Rename locals to avoid shadowing.
9333 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9334 * coding.c (emacs_mule_char, encode_invocation_designation):
9335 Now static, since they're not used elsewhere.
9336 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9337 (decode_coding_object, encode_coding_object, detect_coding_system):
9338 (decode_coding_emacs_mule): Mark variables that gcc
9339 -Wuninitialized does not deduce are never used uninitialized.
9340 (detect_coding_iso_2022): Initialize a local variable that might
9341 be used uninitialized. Leave a FIXME because it's not clear that
9342 this initialization is needed. (Bug#8211)
9343 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9344 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9345 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9346 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9347 Remove unused macros.
9349 * category.c (hash_get_category_set): Remove unused local var.
9350 (copy_category_table): Now static, since it's not used elsewhere.
9351 * character.c (string_count_byte8): Likewise.
9353 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9354 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9356 * chartab.c (copy_sub_char_table): Now static, since it's not used
9358 (sub_char_table_ref_and_range, char_table_ref_and_range):
9359 Rename locals to avoid shadowing.
9360 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9362 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9363 (BIDI_BOB): Remove unused macro.
9365 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9366 deduce are never used uninitialized.
9367 * term.c (encode_terminal_code): Likewise.
9369 * term.c (encode_terminal_code): Now static. Remove unused local.
9371 * tparam.h: New file.
9372 * term.c, tparam.h: Include it.
9373 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9374 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9375 Move these decls to tparam.h, and make them agree with what
9376 is actually in tparam.c. The previous trick of using incompatible
9377 decls in different modules does not conform to the C standard.
9378 All callers of tparam changed to use tparam's actual API.
9379 * tparam.c (tparam1, tparam, tgoto):
9380 Use const pointers where appropriate.
9382 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9383 * cm.h (struct cm): Likewise.
9384 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9385 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9386 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9387 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9388 (turn_on_face, init_tty): Likewise.
9389 * termchar.h (struct tty_display_info): Likewise.
9391 * term.c (term_mouse_position): Rename local to avoid shadowing.
9393 * alloc.c (mark_ttys): Move decl from here ...
9394 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9396 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9398 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9400 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9402 * search.c (compile_pattern_1): Remove argument regp, unused since
9403 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9404 (compile_pattern): Don't pass it.
9406 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9408 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9409 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9411 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9413 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9415 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9416 gdk_window_get_screen, gdk_window_get_geometry,
9417 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9418 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9419 (xg_get_pixbuf_from_pixmap): New function.
9420 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9421 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9422 Call xg_get_pixbuf_from_pixmap instead of
9423 gdk_pixbuf_get_from_drawable.
9424 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9425 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9426 (xg_check_special_colors): Use GtkStyleContext and its functions
9428 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9429 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9430 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9431 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9432 Call gtk_widget_get_preferred_size.
9433 (xg_frame_resized): gdk_window_get_geometry only takes 5
9435 (xg_win_to_widget, xg_event_is_for_menubar):
9436 Call gdk_x11_window_lookup_for_display.
9437 (xg_set_widget_bg): New function.
9438 (delete_cb): New function.
9439 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9440 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9441 (xg_set_background_color): Call xg_set_widget_bg.
9442 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9443 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9444 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9445 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9447 (update_frame_tool_bar): Call gtk_widget_hide.
9448 (xg_initialize): Use GDK_KEY_g.
9450 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9452 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9454 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9455 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9456 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9458 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9460 * w32xfns.c (select_palette): Check success of RealizePalette against
9461 GDI_ERROR, not zero.
9463 See ChangeLog.11 for earlier changes.
9469 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9471 This file is part of GNU Emacs.
9473 GNU Emacs is free software: you can redistribute it and/or modify
9474 it under the terms of the GNU General Public License as published by
9475 the Free Software Foundation, either version 3 of the License, or
9476 (at your option) any later version.
9478 GNU Emacs is distributed in the hope that it will be useful,
9479 but WITHOUT ANY WARRANTY; without even the implied warranty of
9480 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9481 GNU General Public License for more details.
9483 You should have received a copy of the GNU General Public License
9484 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.