1 2012-06-09 Chong Yidong <cyd@gnu.org>
3 * term.c: Support italics in capable terminals (Bug#9652).
4 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5 (turn_on_face): Output using TS_enter_italic_mode if available.
6 Don't handle unused blinking and alt-charset cases.
7 (turn_off_face): Handle italic case; discard unused tty_blinking_p
8 and tty_alt_charset_p cases.
9 (tty_capable_p, init_tty): Support italics.
11 * termchar.h (struct tty_display_info): Add field for italics.
12 Remove unused blink field.
14 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
17 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
18 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
19 tty_alt_charset_p. Add tty_italic_p.
21 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
23 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
24 dbus_type_is_basic if available.
25 (xd_extract_signed, xd_extract_unsigned): Rename from
26 extract_signed and extract_unsigned, respectively. Adapt callers.
28 2012-06-09 Chong Yidong <cyd@gnu.org>
30 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
32 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
35 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
37 * xdisp.c (vmessage): Treat frame message as multibyte.
38 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
39 would generate the diagnostic "Making \302\247 buffer-local while
42 2012-06-08 Eli Zaretskii <eliz@gnu.org>
44 * dispnew.c (showing_window_margins_p): Undo last change, which
45 was done due to an inadvertent commit.
46 (adjust_frame_glyphs_for_frame_redisplay): Do call
47 showing_window_margins_p.
49 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
51 * eval.c (Fmake_var_non_special): New primitive.
52 (syms_of_eval): Defsubr it.
53 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
55 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
57 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
58 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
60 2012-06-08 Eli Zaretskii <eliz@gnu.org>
62 * alloc.c (allocate_vectorlike): Fix last change.
64 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
66 Block-based vector allocation of small vectors.
67 * lisp.h (struct vectorlike_header): New field `nbytes',
68 adjust comment accordingly.
69 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
70 to denote vector blocks. Adjust users (live_vector_p,
71 mark_maybe_pointer, valid_lisp_object_p) accordingly.
72 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
73 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
74 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
75 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
76 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
77 (roundup_size): New constant.
78 (struct vector_block): New data type.
79 (vector_blocks, vector_free_lists, zero_vector): New variables.
80 (all_vectors): Rename to `large_vectors'.
81 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
82 (sweep_vectors): New functions.
83 (allocate_vectorlike): Return `zero_vector' as the only vector of
84 0 items. Allocate new vector from block if vector size is less than
85 or equal to VBLOCK_BYTES_MAX.
86 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
87 (init_alloc_once): Add call to init_vectors.
89 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
91 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
93 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
95 * doprnt.c (doprnt): Truncate multibyte char correctly.
96 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
97 would mishandle a string argument "Xc" if X was a multibyte
98 character of length 2: it would truncate after X's first byte
99 rather than including all of X.
101 2012-06-06 Chong Yidong <cyd@gnu.org>
103 * buffer.c (word_wrap): Doc fix.
105 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
107 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
109 2012-06-03 Glenn Morris <rgm@gnu.org>
111 * xdisp.c (tool-bar-style): Doc fix.
113 2012-06-03 Ulrich Müller <ulm@gentoo.org>
115 * Makefile.in (PAXCTL): Define.
116 (temacs$(EXEEXT)): Disable memory randomization for the temacs
117 binary via PaX flags if the paxctl utility is available.
118 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
119 Restore PaX flags to their default. (Bug#11398)
121 2012-06-03 Chong Yidong <cyd@gnu.org>
123 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
126 2012-06-03 Chong Yidong <cyd@gnu.org>
128 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
129 (note_mode_line_or_margin_highlight): If there is no help echo,
130 use mode-line-default-help-echo. Handle the case where the mouse
131 position is past the end of the mode line string.
133 * buffer.c (buffer_local_value_1): New function, split from
134 Fbuffer_local_value; can return Qunbound.
135 (Fbuffer_local_value): Use it.
136 (Vmode_line_format): Docstring tweaks.
138 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
140 * sysdep.c (system_process_attributes): Improve comment.
142 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
144 * keyboard.c: Export real-this-command to Elisp.
145 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
146 and DEFVAR it. Update all users.
148 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
150 * minibuf.c (Fassoc_string): Remove duplicate declaration.
152 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
153 Convert pctcpu and pctmem to Lisp float properly.
154 Let the compiler fold better, as 100.0/0x8000 is exact.
156 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
158 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
161 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
163 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
165 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
167 For a 'struct window', replace some Lisp_Object fields to
168 bitfields where appropriate, remove unused fields.
169 * window.h (struct window): Remove unused 'last_mark_x' and
170 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
171 change it's type from Lisp_Object to bitfield.
172 Change type of 'force_start', 'optional_new_start',
173 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
174 fields from Lisp_Object to bitfield. Adjust users accordingly.
176 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
178 Pacify gcc -Wdouble-precision when using Xaw.
179 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
180 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
181 Use 'float' consistently, rather than 'float' in most places
182 and 'double' in a couple of places.
184 2012-05-31 Eli Zaretskii <eliz@gnu.org>
186 * xdisp.c (handle_stop): Detect whether we have overlay strings
187 loaded by testing it->current.overlay_string_index to be
188 non-negative, instead of checking whether n_overlay_strings is
189 positive. (Bug#11587)
191 2012-05-31 Chong Yidong <cyd@gnu.org>
193 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
195 * doc.c (Fsubstitute_command_keys): Doc fix.
197 2012-05-31 Eli Zaretskii <eliz@gnu.org>
199 * search.c (search_buffer): Remove calls to
200 r_alloc_inhibit_buffer_relocation, as it is now called by
201 maybe_unify_char, which was the cause of relocation of buffer text
204 2012-05-31 Eli Zaretskii <eliz@gnu.org>
206 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
207 for the duration of call to load_charset, to avoid problems with
208 callers of maybe_unify_char that access buffer text through C
211 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
212 decrement the inhibition flag, instead of just setting or
215 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
217 Remove obsolete '#define static' cruft.
218 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
219 This #undef was "temporary" in 2000; it is no longer needed
220 now that '#define static' has gone away.
221 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
222 (gray_bitmap_bits): Remove; no longer needed.
223 All uses replaced with definiens.
224 * xterm.c: Include "bitmaps/gray.xbm".
226 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
228 Clean up __executable_start, monstartup when --enable-profiling.
229 The following changes affect the code only when profiling.
230 * dispnew.c (__executable_start): Rename from safe_bcopy.
231 Define only on platforms that need it.
232 * emacs.c: Include <sys/gmon.h> when profiling.
233 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
234 (__executable_start): Remove decl, since lisp.h does it now.
235 (safe_bcopy): Remove decl; no longer has that name.
236 (main): Coalesce #if into single bit of code, for simplicity.
237 Cast pointers to uintptr_t, since standard libraries want integers
239 * lisp.h (__executable_start): New decl.
241 2012-05-31 Glenn Morris <rgm@gnu.org>
243 * image.c (Fimagemagick_types): Doc fix.
245 2012-05-30 Jim Meyering <meyering@redhat.com>
247 * callproc.c (Fcall_process_region): Include directory component
248 in mkstemp error message (Bug#11586).
250 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
252 * alloc.c, lisp.h (make_pure_vector): Now static.
254 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
256 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
258 (Fautoload): Do the hash-doc more carefully.
259 * data.c (Fdefalias): Purify definition, except for keymaps.
260 (Qdefun): Move from eval.c.
261 * lisp.h (Qdefun): Remove.
262 * lread.c (read1): Tiny simplification.
264 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
266 Do not create empty overlays with the evaporate property (Bug#9642).
267 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
268 Bug#9642, but explicitly check that the buffer the overlay would
269 be moved to is live and rearrange lines to make sure that errors
270 will not put the overlay in an inconsistent state.
271 (Fdelete_overlay): Cosmetics.
273 2012-05-28 Eli Zaretskii <eliz@gnu.org>
275 * w32term.c (my_bring_window_to_top): New function.
276 (x_raise_frame): Use handle returned by DeferWindowPos, which
277 could be different from the original one.
278 Call my_bring_window_to_top instead of my_set_foreground_window.
281 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
282 by calling BringWindowToTop.
284 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
285 (WM_EMACS_END): Increase by one.
287 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
289 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
290 This avoids undefined behavior that might cause the eassert
291 to not catch an out-of-range value.
293 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
295 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
298 2012-05-27 Eli Zaretskii <eliz@gnu.org>
300 * bidi.c (bidi_mirror_char): Fix last change.
302 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
304 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
305 when referring to sectname field in printf format.
307 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
309 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
310 Only r_alloc_inhibit_buffer_relocation needed to be added;
311 the others were already declared.
313 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
314 before checking whether it's out of range. Put the check inside
316 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
318 2012-05-27 Ken Brown <kbrown@cornell.edu>
320 * callproc.c (Fcall_process): Restore a line that was accidentally
321 commented out in the 2011-02-13 change (bug#11547).
323 2012-05-27 Eli Zaretskii <eliz@gnu.org>
325 * lisp.h [REL_ALLOC]: Add prototypes for external functions
328 * buffer.c [REL_ALLOC]: Remove prototypes of
329 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
330 they are now on lisp.h.
332 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
334 * search.c (search_buffer): Use it to inhibit relocation of buffer
335 text while re_search_2 is doing its job, because re_search_2 is
336 passed C pointers to buffer text. (Bug#11519)
338 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
341 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
342 state after an additional call to move_it_in_display_line_to, keep
343 the values of it->max_ascent and it->max_descent found for the
345 (pos_visible_p): Revert the comparison against bottom_y to what it
346 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
349 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
351 Fix coding-related core dumps with gcc -ftrapv.
352 The code was computing A - B, where A and B are pointers, and B is
353 random garbage. This can lead to core dumps on platforms that
354 have special pointer registers, and it also leads to core dumps on
355 x86-64 when compiled with gcc -ftrapv. The fix is to compute
356 A - B only when B is initialized properly.
357 * coding.c (coding_set_source, coding_set_destination): Return void.
358 (coding_change_source, coding_change_destinations): New functions,
359 with the old behaviors of coding_set_source and coding_set_destination.
360 All callers that need an offset changed to use these new functions.
362 2012-05-26 Glenn Morris <rgm@gnu.org>
364 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
366 2012-05-26 Eli Zaretskii <eliz@gnu.org>
368 Extend mouse support on W32 text-mode console.
369 * xdisp.c (draw_row_with_mouse_face):
370 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
372 * w32console.c: Include window.h.
373 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
375 (initialize_w32_display): Initialize mouse-highlight data.
377 * w32inevt.c: Include termchar.h and window.h.
378 (do_mouse_event): Support mouse-autoselect-window. When the mouse
379 moves, call note_mouse_highlight. If help_echo changed, call
380 gen_help_event to produce help-echo message in the echo area.
381 Call clear_mouse_face if mouse_face_hidden is set in the mouse
384 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
386 * lread.c (read1): Simplify slightly to avoid an overflow warning
387 with GCC 4.7.0 on x86-64.
389 2012-05-26 Eli Zaretskii <eliz@gnu.org>
391 * bidi.c (bidi_mirror_char): Revert last change: an int is
392 definitely wide enough here.
394 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
396 Fix integer width and related bugs (Bug#9874).
397 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
398 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
399 (string_bytes, check_sblock, allocate_string_data):
400 (compact_small_strings, Fmake_bool_vector, make_string)
401 (make_unibyte_string, make_multibyte_string)
402 (make_string_from_bytes, make_specified_string)
403 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
404 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
407 (allocate_pseudovector):
408 Use int, not EMACS_INT, where int is wide enough.
409 (inhibit_garbage_collection, Fgarbage_collect):
410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
411 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
412 int might not be wide enough.
413 (bidi_cache_search, bidi_cache_find, bidi_init_it)
414 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
415 (bidi_at_paragraph_end, bidi_find_paragraph_start)
416 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
417 (bidi_level_of_next_char, bidi_move_to_visually_next):
418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
419 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
420 (Fkill_buffer, Fset_buffer_major_mode)
421 (advance_to_char_boundary, Fbuffer_swap_text)
422 (Fset_buffer_multibyte, overlays_at, overlays_in)
423 (overlay_touches_p, struct sortvec, record_overlay_string)
424 (overlay_strings, recenter_overlay_lists)
425 (adjust_overlays_for_insert, adjust_overlays_for_delete)
426 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
427 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
428 (Foverlay_recenter, last_overlay_modification_hooks_used)
429 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 (validate_region): Omit unnecessary test for b <= e,
432 since that's guaranteed by the previous test.
433 (adjust_overlays_for_delete): Avoid pos + length overflow.
434 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
435 (report_overlay_modification):
436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
437 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
438 Omit pointer cast, which isn't needed anyway, and doesn't work
439 after the EMACS_INT -> ptrdiff_t change.
440 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
441 * buffer.h: Adjust decls to match defn changes elsewhere.
442 (struct buffer_text, struct buffer):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 Use EMACS_INT, not int, where int might not be wide enough.
445 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
446 not int, to avoid needless 32-bit limit on 64-bit hosts.
447 (exec_byte_code): Use tighter memory-full test, one that checks
448 for alloca overflow. Don't compute the address of the object just
449 before an array, as that's not portable. Use EMACS_INT, not
450 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
451 * callint.c (Fcall_interactively):
452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
453 * callproc.c (call_process_kill, Fcall_process):
454 Don't assume pid_t fits into an Emacs fixnum.
455 (call_process_cleanup, Fcall_process, child_setup):
456 Don't assume pid_t fits into int.
457 (call_process_cleanup, Fcall_process, delete_temp_file)
458 (Fcall_process_region):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (Fcall_process): Simplify handling of volatile integers.
461 Use int, not EMACS_INT, where int will do.
462 * casefiddle.c (casify_object, casify_region, operate_on_word)
463 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
465 (casify_object): Avoid integer overflow when overallocating buffer.
466 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
467 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
468 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
469 * category.h (CATEGORYP): Don't assume arg is nonnegative.
470 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
471 integers are now checked earlier. All uses replaced with XINT.
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 For CCL_MapSingle, check that content and value are in int range.
475 (ccl_driver, Fregister_code_conversion_map):
476 Check that Vcode_version_map_vector is a vector.
477 (resolve_symbol_ccl_program): Check that vector header is in range.
478 Always copy the vector, so that we can check its contents reliably
479 now rather than having to recheck each instruction as it's being
480 executed. Check that vector words fit in 'int'.
481 (ccl_get_compiled_code, Fregister_ccl_program)
482 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
483 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
484 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
485 contents are in range.
486 (Fccl_execute_on_string): Check that status is in range.
487 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
488 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
489 Accept and return EMACS_INT, not int, because callers can pass values
491 (c_string_width, strwidth, lisp_string_width, chars_in_text)
492 (multibyte_chars_in_text, parse_str_as_multibyte)
493 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
494 (str_as_unibyte, str_to_unibyte, string_count_byte8)
495 (string_escape_byte8, Fget_byte):
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
497 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
498 avoid mishandling large integers.
499 * character.h: Adjust decls to match defn changes elsewhere.
500 * charset.c (load_charset_map_from_file, find_charsets_in_text)
501 (Ffind_charset_region):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
504 (load_charset_map_from_vector, Fdefine_charset_internal):
505 Don't assume fixnum fits in int.
506 (load_charset_map_from_vector, Fmap_charset_chars):
507 Remove now-unnecessary CHECK_NATNUMs.
508 (Fdefine_charset_internal): Check ranges here, more carefully.
509 Don't rely on undefined behavior with signed left shift overflow.
510 Don't assume unsigned int fits into fixnum, or that fixnum fits
511 into unsigned int. Don't require max_code to be a valid fixnum;
512 that's not true for gb10830 4-byte on a 32-bit host. Allow
513 invalid_code to be a cons, for the same reason. Require code_offset
514 to be a character. Avoid int overflow if max_char is close
516 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
517 this is intended anyway and avoids some undefined behavior.
518 (load_charset_map): Pass unsigned, not int, as 2nd arg of
519 INDEX_TO_CODE_POINT, as that's what it expects.
520 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
521 * charset.h (DECODE_CHAR): Return int, not unsigned;
522 this is what was intended anyway, and it avoids undefined behavior.
523 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
524 integer-overflow issues.
525 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
526 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
527 where the argument is EMACS_INT, and this behavior is not intended.
528 * chartab.c (Fmake_char_table, Fset_char_table_range)
529 (uniprop_get_decoder, uniprop_get_encoder):
530 Don't assume fixnum fits in int.
531 * cmds.c (move_point): New function, that does the gist of
532 Fforward_char and Fbackward_char, but does so while checking
533 for integer overflow more accurately.
534 (Fforward_char, Fbackward_char): Use it.
535 (Fforward_line, Fend_of_line, internal_self_insert)
536 (internal_self_insert):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 Fix a FIXME, by checking for integer overflow when calculating
539 target_clm and actual_clm.
540 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
541 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
542 (ASSURE_DESTINATION, coding_alloc_by_realloc)
543 (coding_alloc_by_making_gap, alloc_destination)
544 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
545 (encode_coding_utf_16, detect_coding_emacs_mule)
546 (decode_coding_emacs_mule, encode_coding_emacs_mule)
547 (detect_coding_iso_2022, decode_coding_iso_2022)
548 (encode_invocation_designation, encode_designation_at_bol)
549 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
550 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
551 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
552 (encode_coding_ccl, encode_coding_raw_text)
553 (detect_coding_charset, decode_coding_charset)
554 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
555 (produce_composition, produce_charset, produce_annotation)
556 (decode_coding, handle_composition_annotation)
557 (handle_charset_annotation, consume_chars, decode_coding_gap)
558 (decode_coding_object, encode_coding_object, detect_coding_system)
559 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
560 (code_convert_region, code_convert_string)
561 (Fdefine_coding_system_internal)
562 (coding_set_source, coding_set_destination):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
565 (Fdefine_coding_system_internal):
566 Don't assume fixnums fit in int.
567 (decode_coding_gap, decode_coding_object, encode_coding_object)
568 (Fread_coding_system, Fdetect_coding_region)
569 (Funencodable_char_position, Fcheck_coding_systems_region)
570 (get_translation, handle_composition_annotation, consume_chars):
571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
572 (consume_chars): Rewrite to not calculate an address outside buffer.
573 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
574 Don't access memory outside of the args array.
575 (Fdefine_coding_system_internal): Check for charset-id overflow.
576 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
577 result of ENCODE_CHAR.
578 * coding.h: Adjust decls to match defn changes elsewhere.
579 (struct coding_system):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 * composite.c (get_composition_id, find_composition)
582 (run_composition_function, update_compositions)
583 (compose_text, composition_gstring_put_cache)
584 (composition_gstring_p, composition_gstring_width)
585 (fill_gstring_header, fill_gstring_body, autocmp_chars)
586 (composition_compute_stop_pos, composition_reseat_it)
587 (composition_update_it, struct position_record)
588 (find_automatic_composition, composition_adjust_point)
589 (Fcomposition_get_gstring, Ffind_composition_internal):
590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
591 (update_compositions):
592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
593 * composite.h: Adjust decls to match defn changes elsewhere.
594 (struct composition):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
597 Do not attempt to compute the address of the object just before a
598 buffer; this is not portable.
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Faset): Use int, not EMACS_INT, where int is wide enough.
602 (Fstring_to_number): Don't assume fixnums fit in int.
603 (Frem): Don't assume arg is nonnegative.
604 * dbusbind.c (xd_append_arg): Check for integers out of range.
605 (Fdbus_call_method): Don't overflow the timeout int.
606 (extract_signed, extract_unsigned): New functions.
607 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
608 (xd_get_connection_references): Return ptrdiff_t, not int.
610 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
612 Use int, not unsigned, where the dbus API uses int.
613 (Fdbus_message_internal): Don't overflow mtype.
614 (syms_of_dbusbind): Allocate right-sized buffer for integers.
615 * dired.c (directory_files_internal, file_name_completion, scmp)
616 (file_name_completion_stat):
617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
618 (file_name_completion): Don't overflow matchcount.
619 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
620 * dispextern.h: Adjust decls to match defn changes elsewhere.
621 (struct text_pos, struct glyph, struct bidi_saved_info)
622 (struct bidi_string_data, struct bidi_it, struct composition_it)
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 (struct display_pos, struct composition_it, struct it):
626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
627 * dispnew.c (increment_matrix_positions)
628 (increment_row_positions, mode_line_string)
629 (marginal_area_string):
630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
631 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 (duration_to_sec_usec): New function, to check for overflow better.
634 (Fsleep_for, sit_for): Use it.
635 * doc.c (get_doc_string, store_function_docstring):
636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
637 (get_doc_string, Fsnarf_documentation):
638 Use int, not EMACS_INT, where int is wide enough.
640 Use SAFE_ALLOCA, not alloca.
641 Check for overflow when converting EMACS_INT to off_t.
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
645 Don't assume uid_t fits into fixnum.
646 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
647 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
648 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
649 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
650 (general_insert_function)
651 (Finsert_char, make_buffer_string, make_buffer_string_both)
652 (update_buffer_properties, Fbuffer_substring)
653 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
654 (Fsubst_char_in_region, check_translation)
655 (Ftranslate_region_internal, save_restriction_restore, Fformat)
656 (transpose_markers, Ftranspose_regions):
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (clip_to_bounds): Move to lisp.h as an inline function).
659 (Fconstrain_to_field): Don't assume integers are nonnegative.
660 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
661 (Fsubst_char_in_region, Fsave_restriction):
662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
663 (Femacs_pid): Don't assume pid_t fits into fixnum.
664 (lo_time): Use int, not EMACS_INT, when int suffices.
665 (lisp_time_argument): Check for usec out of range.
666 (Fencode_time): Don't assume fixnum fits in int.
667 (Fuser_login_name, Fuser_full_name): Signal an error
668 if a uid argument is out of range, rather than relying on
670 (Fformat_time_string): Remove now-unnecessary check.
671 lisp_time_argument checks for out-of-range usec now.
672 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
673 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
674 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
675 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
676 (init_cmdargs, Fdump_emacs):
677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
678 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
679 the bottom (typically) 32 bits of the fixnum.
680 * eval.c (specpdl_size, call_debugger):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 (when_entered_debugger, Fbacktrace_debug):
683 Don't assume fixnum can fit in int.
684 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
685 the object just before a buffer; this is not portable.
686 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
687 (grow_specpdl, unbind_to):
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
690 (grow_specpdl): Simplify allocation by using xpalloc.
691 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
692 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
693 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (Fcopy_file, non_regular_nbytes, read_non_regular)
699 (Finsert_file_contents):
700 Use int, not EMACS_INT, where int is wide enough.
701 (READ_BUF_SIZE): Verify that it fits in int.
702 (Finsert_file_contents): Check that counts are in proper range,
703 rather than assuming fixnums fit into ptrdiff_t etc.
704 Don't assume fixnums fit into int.
705 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
706 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
707 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
708 (string_char_to_byte, string_byte_to_char)
709 (string_make_multibyte, string_to_multibyte)
710 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
711 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
712 (substring_both, Fdelete, internal_equal, Ffillarray)
713 (Fclear_string, mapcar1)
714 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
715 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
716 (larger_vector, make_hash_table, maybe_resize_hash_table)
717 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
718 (Fmaphash, secure_hash):
719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
720 (concat): Check for string index and length overflow.
721 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (larger_vector): New API (vec, incr_min, size_max) replaces old
725 one (vec, new_size, init). This catches size overflow.
726 INIT was removed because it was always Qnil.
728 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
729 the upper bound on a hash table index size.
730 (make_hash_table, maybe_resize_hash_table): Use it.
731 (secure_hash): Computer start_byte and end_byte only after
732 they're known to be in ptrdiff_t range.
733 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
734 (Ffont_get_glyphs, Ffont_at):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
737 (Flist_fonts, Fopen_font):
738 Don't assume fixnum can fit in int.
739 (check_gstring): Don't assume index can fit in int.
740 (font_match_p): Check that fixnum is a character, not a nonnegative
741 fixnum, since the later code needs to stuff it into an int.
742 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
743 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
744 conversion overflow issues.
745 (Fopen_font): Check for integer out of range.
746 (Ffont_get_glyphs): Don't assume index can fit in int.
747 * font.h: Adjust decls to match defn changes elsewhere.
748 * fontset.c (reorder_font_vector): Redo score calculation to avoid
750 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
751 printmax_t, where ptrdiff_t is wide enough.
752 (Finternal_char_font):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
755 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
756 (Fset_frame_position, x_set_frame_parameters)
757 (x_set_line_spacing, x_set_border_width)
758 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
759 Check that fixnums are in proper range for system types.
760 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
763 Use SAFE_ALLOCA_LISP, not alloca.
764 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
765 intptr_t is wide enough.
766 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
767 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
768 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
769 Check for fixnum out of range.
770 * ftfont.c (ftfont_list): Don't assume index fits in int.
771 Check that fixnums are in proper range for system types.
772 (ftfont_shape_by_flt):
773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
774 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
777 Check that fixnums are in proper range for system types.
778 * gnutls.h: Adjust decls to match defn changes elsewhere.
779 * gtkutil.c (xg_dialog_run):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 (update_frame_tool_bar):
782 Check that fixnums are in proper range for system types.
783 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
784 (lookup_image): Check that fixnums are in range for system types.
785 * indent.c (last_known_column, last_known_column_point):
786 (current_column_bol_cache):
787 (skip_invisible, current_column, check_display_width):
788 (check_display_width, scan_for_column, current_column_1)
789 (Findent_to, Fcurrent_indentation, position_indentation)
790 (indented_beyond_p, Fmove_to_column, compute_motion):
791 (Fcompute_motion, Fvertical_motion):
792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 (last_known_column_modified): Use EMACS_INT, not int.
794 (check_display_width):
796 Check that fixnums and floats are in proper range for system types.
797 (compute_motion): Don't assume index or fixnum fits in int.
798 (compute_motion, Fcompute_motion):
799 Use int, not EMACS_INT, when it is wide enough.
800 (vmotion): Omit local var start_hpos that is always 0; that way
801 we don't need to worry about overflow in expressions involving it.
802 * indent.h: Adjust decls to match defn changes elsewhere.
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 Use int, not EMACS_INT, where int is wide enough.
806 Remove unused members ovstring_chars_done and tab_offset;
808 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
809 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
810 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
811 (make_gap, copy_text, insert, insert_and_inherit)
812 (insert_before_markers, insert_before_markers_and_inherit)
813 (insert_1, count_combining_before, count_combining_after)
814 (insert_1_both, insert_from_string)
815 (insert_from_string_before_markers, insert_from_string_1)
816 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
817 (adjust_after_replace, adjust_after_insert, replace_range)
818 (replace_range_2, del_range, del_range_1, del_range_byte)
819 (del_range_both, del_range_2, modify_region)
820 (prepare_to_modify_buffer, signal_before_change)
821 (signal_after_change, Fcombine_after_change_execute):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 * intervals.c (traverse_intervals, rotate_right, rotate_left)
824 (balance_an_interval, split_interval_right, split_interval_left)
825 (find_interval, next_interval, update_interval)
826 (adjust_intervals_for_insertion, delete_node, delete_interval)
827 (interval_deletion_adjustment, adjust_intervals_for_deletion)
828 (static_offset_intervals, offset_intervals)
829 (merge_interval_right, merge_interval_left, make_new_interval)
830 (graft_intervals_into_buffer, temp_set_point_both)
831 (temp_set_point, set_point, adjust_for_invis_intang)
832 (set_point_both, move_if_not_intangible, get_property_and_range)
833 (get_local_map, copy_intervals, copy_intervals_to_string)
834 (compare_string_intervals, set_intervals_multibyte_1):
835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
836 * intervals.h: Adjust decls to match defn changes elsewhere.
838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
839 * keyboard.c (this_command_key_count, this_single_command_key_start)
840 (before_command_key_count, before_command_echo_length, echo_now)
841 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
842 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
843 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
844 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
846 (last_non_minibuf_size, last_point_position, echo_truncate)
847 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
848 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
849 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
850 (stuff_buffered_input):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 (last_auto_save, command_loop_1, read_char):
853 Use EMACS_INT, not int, to avoid integer overflow.
854 (record_char): Avoid overflow in total_keys computation.
855 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
856 * keyboard.h: Adjust decls to match defn changes elsewhere.
857 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
858 (Fkey_description, Fdescribe_vector, Flookup_key):
859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
860 (click_position): New function, to check that positions are in range.
861 (Fcurrent_active_maps):
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
864 (Faccessible_keymaps, Fkey_description):
865 (preferred_sequence_p):
866 Don't assume fixnum can fit into int.
867 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
868 Check for integer overflow in size calculations.
869 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
870 avoid mishandling large integers.
871 * lisp.h: Adjust decls to match defn changes elsewhere.
872 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
873 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
874 (struct Lisp_Marker):
875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
876 (clip_to_bounds): Now an inline function, moved here from editfns.c.
877 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
878 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
880 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
881 Assume the arg has valid form, since it always does.
882 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
883 unsigned integer system type.
884 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
885 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
887 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
888 (duration_to_sec_usec): New decl.
889 * lread.c (read_from_string_index, read_from_string_index_byte)
890 (read_from_string_limit, readchar, unreadchar, openp)
891 (read_internal_start, read1, oblookup):
892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
893 (Fload, readevalloop, Feval_buffer, Feval_region):
894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
895 (openp): Check for out-of-range argument to 'access'.
896 (read1): Use int, not EMACS_INT, where int is wide enough.
897 Don't assume fixnum fits into int.
898 Fix off-by-one error that can read outside a buffer.
899 (read_filtered_event): Use duration_to_sec_usec
900 to do proper overflow checking on durations.
901 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
903 (Fexecute_kbd_macro):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
906 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
907 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
908 (set_marker_both, set_marker_restricted_both, marker_position)
909 (marker_byte_position, Fbuffer_has_markers_at):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
912 * menu.c (ensure_menu_items): Rename from grow_menu_items.
913 It now merely ensures that the menu is large enough, without
914 necessarily growing it, as this avoids some integer overflow issues.
916 (keymap_panes, parse_single_submenu, Fx_popup_menu):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
919 Use SAFE_ALLOCA_LISP, not alloca.
920 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
921 to EMACS_INT. Check that fixnums are in proper range for system types.
922 * minibuf.c (minibuf_prompt_width, string_to_object)
923 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
924 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 (get_minibuffer, read_minibuf_unwind):
927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
928 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
929 this simplifies overflow checking. All callers changed.
930 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
934 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
935 Check that fixnums are in proper range for system types.
936 (Fx_create_frame, Fx_show_tip):
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 * nsfont.m (ns_findfonts, nsfont_list_family):
939 Don't assume fixnum fits in long.
940 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
944 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
947 (PRINTDECLARE, PRINTPREPARE):
948 (strout, print_string):
949 (print, print_preprocess, print_check_string_charset_prop)
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
953 (temp_output_buffer_setup, Fprin1_to_string, print_object):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
956 (printchar, strout): Use xpalloc to catch size calculation overflow.
957 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
958 (print_error_message): Use SAFE_ALLOCA, not alloca.
959 (print_object): Use int, not EMACS_INT, where int is wide enough.
960 (print_depth, new_backquote_output, print_number_index):
961 Use ptrdiff_t, not int, where int might not be wide enough.
962 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
963 (Fset_process_window_size, Fformat_network_address)
964 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
966 Check that fixnums are in proper range for system types.
967 (Fsignal_process): Simplify by avoiding a goto.
968 Check for process-ids out of pid_t range rather than relying on
970 (process_tick, update_tick): Use EMACS_INT, not int.
971 (Fformat_network_address, read_process_output, send_process)
972 (Fprocess_send_region, status_notify):
973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
974 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
975 (wait_reading_process_output, read_process_output, exec_sentinel):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
978 (Faccept_process_output): Use duration_to_sec_usec to do proper
979 overflow checking on durations.
980 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
981 Don't assume pid_t fits in int.
982 * process.h (struct Lisp_Process): Members tick and update_tick
983 are now of type EMACS_INT, not int.
984 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
985 configured --with-wide-int.
986 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
987 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
988 * search.c (looking_at_1, string_match_1):
989 (fast_string_match, fast_c_string_match_ignore_case)
990 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
991 (scan_newline, find_before_next_newline, search_command)
992 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
993 (set_search_regs, wordify):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (string_match_1, search_buffer, set_search_regs):
999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 (wordify): Check for overflow in size calculation.
1001 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1002 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1003 Check that fixnums are in proper range for system types.
1004 * sound.c (struct sound_device)
1005 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1007 (Fplay_sound_internal):
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1009 * syntax.c (struct lisp_parse_state, find_start_modiff)
1010 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1011 (Fparse_partial_sexp):
1012 Don't assume fixnums can fit in int.
1013 (struct lisp_parse_state, find_start_pos, find_start_value)
1014 (find_start_value_byte, find_start_begv)
1015 (update_syntax_table, char_quoted, dec_bytepos)
1016 (find_defun_start, prev_char_comend_first, back_comment):
1017 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1018 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (Finternal_describe_syntax_value): Check that match_lisp is a
1021 character, not an integer, since the code stuffs it into int.
1022 (scan_words, scan_sexps_forward):
1023 Check that fixnums are in proper range for system types.
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (scan_sexps_forward):
1027 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1028 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1029 * syntax.h: Adjust decls to match defn changes elsewhere.
1030 (struct gl_state_s):
1031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1032 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1033 MOST_POSITIVE_FIXNUM.
1034 * sysdep.c (wait_for_termination_1, wait_for_termination)
1035 (interruptible_wait_for_termination, mkdir):
1036 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1037 (emacs_read, emacs_write):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1039 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1040 and double all fit in int.
1041 * term.c (set_tty_color_mode):
1042 Check that fixnums are in proper range for system types.
1043 * termhooks.h (struct input_event):
1044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1045 * textprop.c (validate_interval_range, interval_of)
1046 (Fadd_text_properties, set_text_properties_1)
1047 (Fremove_text_properties, Fremove_list_of_text_properties)
1048 (Ftext_property_any, Ftext_property_not_all)
1049 (copy_text_properties, text_property_list, extend_property_ranges)
1050 (verify_interval_modification):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1052 (Fnext_single_char_property_change)
1053 (Fprevious_single_char_property_change):
1054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1055 (copy_text_properties):
1056 Check for integer overflow in index calculation.
1057 * undo.c (last_boundary_position, record_point, record_insert)
1058 (record_delete, record_marker_adjustment, record_change)
1059 (record_property_change):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1064 (Fx_hide_tip, Fx_file_dialog):
1065 * w32menu.c (set_frame_menubar):
1066 Use ptrdiff_t, not int, for consistency with rest of code.
1067 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1068 (select_window, Fdelete_other_windows_internal)
1069 (window_scroll_pixel_based, window_scroll_line_based)
1070 (Frecenter, Fset_window_configuration):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (Fset_window_hscroll, run_window_configuration_change_hook)
1073 (set_window_buffer, temp_output_buffer_show, scroll_command)
1074 (Fscroll_other_window, Frecenter):
1075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1076 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1077 Don't assume fixnum fits in int.
1078 (Fset_window_scroll_bars):
1079 Check that fixnums are in proper range for system types.
1080 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1081 (string_pos, c_string_pos, number_of_chars, init_iterator)
1082 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1083 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1084 (compute_display_string_end, handle_face_prop)
1085 (face_before_or_after_it_pos, handle_invisible_prop)
1086 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1087 (display_prop_intangible_p, string_buffer_position_lim)
1088 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1089 (get_overlay_strings_1, get_overlay_strings)
1090 (iterate_out_of_display_property, forward_to_next_line_start)
1091 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1092 (get_next_display_element, set_iterator_to_next)
1093 (get_visually_first_element, compute_stop_pos_backwards)
1094 (handle_stop_backwards, next_element_from_buffer)
1095 (move_it_in_display_line_to, move_it_in_display_line)
1096 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1097 (add_to_log, message_dolog, message_log_check_duplicate)
1098 (message2, message2_nolog, message3, message3_nolog
1099 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1100 (current_message_1, truncate_echo_area, truncate_message_1)
1101 (set_message, set_message_1, store_mode_line_noprop)
1102 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1103 (text_outside_line_unchanged_p, check_point_in_composition)
1104 (reconsider_clip_changes)
1105 (redisplay_internal, set_cursor_from_row, try_scrolling)
1106 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1107 (redisplay_window, find_last_unchanged_at_beg_row)
1108 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1109 (trailing_whitespace_p, find_row_edges, display_line)
1110 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1111 (display_mode_element, store_mode_line_string)
1112 (pint2str, pint2hrstr, decode_mode_spec)
1113 (display_count_lines, display_string, draw_glyphs)
1114 (x_produce_glyphs, x_insert_glyphs)
1115 (rows_from_pos_range, mouse_face_from_buffer_pos)
1116 (fast_find_string_pos, mouse_face_from_string_pos)
1117 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1119 (safe_call, init_from_display_pos, handle_fontified_prop)
1120 (handle_single_display_spec, load_overlay_strings)
1121 (with_echo_area_buffer, setup_echo_area_for_printing)
1122 (display_echo_area, echo_area_display)
1123 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1124 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1125 (redisplay_window, dump_glyph_row, display_mode_line)
1126 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1127 (handle_display_spec, display_prop_string_p):
1128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1129 (handle_single_display_spec, build_desired_tool_bar_string)
1130 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1131 (get_specified_cursor_type):
1132 Check that fixnums are in proper range for system types.
1133 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1134 (Flookup_image_map):
1135 Don't assume fixnums fit in int.
1136 (compare_overlay_entries):
1137 Avoid mishandling comparisons due to subtraction overflow.
1138 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1139 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1140 (handle_tool_bar_click):
1141 Use int, not unsigned, since we prefer signed and the signedness
1142 doesn't matter here.
1143 (get_next_display_element, next_element_from_display_vector):
1144 Use int, not EMACS_INT, when int is wide enough.
1145 (start_hourglass): Use duration_to_sec_usec to do proper
1146 overflow checking on durations.
1147 * xfaces.c (Fbitmap_spec_p):
1148 Check that fixnums are in proper range for system types.
1149 (compare_fonts_by_sort_order):
1150 Avoid mishandling comparisons due to subtraction overflow.
1151 (Fx_family_fonts, realize_basic_faces):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1154 Don't assume fixnum fits in int.
1155 Use SAFE_ALLOCA_LISP, not alloca.
1156 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1157 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1158 (face_at_buffer_position, face_for_overlay_string)
1159 (face_at_string_position):
1160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1161 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1162 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1164 Check that fixnums are in proper range for system types.
1165 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1166 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1168 (Fx_change_window_property): Don't assume fixnums fit in int.
1169 * xfont.c (xfont_chars_supported):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1172 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1174 * xml.c (parse_region):
1175 * xrdb.c (magic_file_p):
1176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1177 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1178 (x_get_local_selection, x_reply_selection_request)
1179 (x_handle_selection_request, wait_for_property_change):
1180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1181 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1182 short is wide enough.
1183 (x_send_client_event): Don't assume fixnum fits in int.
1184 * xterm.c (x_x_to_emacs_modifiers):
1185 Don't assume EMACS_INT overflows nicely into int.
1186 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1188 (handle_one_xevent): NATNUMP can eval its arg twice.
1189 (x_connection_closed):
1190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1191 * xterm.h: Adjust decls to match defn changes elsewhere.
1192 (struct scroll_bar): Use struct vectorlike_header
1193 rather than rolling our own approximation.
1194 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1196 2012-05-25 Glenn Morris <rgm@gnu.org>
1198 * lisp.mk (lisp): Update for more files being compiled now.
1200 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1202 * lread.c: Remove `read_pure' which makes no difference.
1203 (read_pure): Remove var.
1204 (unreadpure): Remove function.
1205 (readevalloop): Don't call read_list with -1 flag.
1206 (read1, read_vector): Don't test read_pure any more.
1207 (read_list): Simplify.
1209 * fileio.c, character.h: Minor style tweaks.
1211 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1213 * window.h (clip_changed): Remove useless declaration.
1215 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1217 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1218 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1220 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1223 This directory predates autoconf and is no longer needed nowadays.
1224 Move its few remaining bits of functionality to where they're needed.
1225 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1226 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1227 * m/template.h: Remove.
1228 * Makefile.in (M_FILE): Remove. All uses removed.
1229 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1230 * lisp.h (USE_LSB_TAG):
1231 * mem-limits.h (EXCEEDS_LISP_PTR):
1232 Use VAL_MAX, not VALBITS, in #if.
1233 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1234 (EMACS_UINT): Define unconditionally now.
1235 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1236 (BITS_PER_EMACS_INT): New constants, replacing
1237 what used to be in config.h, but not useful in #if.
1238 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1239 define them any more.
1240 (VAL_MAX): New macro.
1242 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1243 BITS_PER_EMACS_INT, in #if.
1244 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1245 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1246 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1247 * s/ms-w32.h (DATA_START):
1248 Move here from removed file m/intel386.h.
1249 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1250 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1252 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1254 Assume C89 or later.
1255 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1256 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1258 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1259 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1260 * textprop.c, tparam.c (NULL): Remove.
1261 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1262 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1263 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1264 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1265 * xterm.c (input_signal_count): Assume volatile works.
1267 2012-05-21 Ken Brown <kbrown@cornell.edu>
1269 * xgselect.c (xg_select): Fix first argument in call to 'select'
1272 2012-05-20 Ken Brown <kbrown@cornell.edu>
1274 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1275 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1277 2012-05-19 Ken Brown <kbrown@cornell.edu>
1279 * xfns.c (x_in_use): Remove `static' qualifier.
1280 * xterm.h (x_in_use): Declare.
1281 * xgselect.c: Include xterm.h.
1282 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1283 and `display_arg' (bug#9754).
1285 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1287 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1289 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1290 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1292 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1294 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1296 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1297 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1299 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1300 reference to image_cache->refcount.
1301 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1303 2012-05-17 Juri Linkov <juri@jurta.org>
1305 * search.c (Fword_search_regexp, Fword_search_backward)
1306 (Fword_search_forward, Fword_search_backward_lax)
1307 (Fword_search_forward_lax): Move functions to isearch.el
1308 (bug#10145, bug#11381).
1310 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1312 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1314 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1316 * lread.c (init_obarray): Declare Qt and Qnil as special.
1318 2012-05-14 Glenn Morris <rgm@gnu.org>
1320 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1321 Put "libexec" before "bin", for the sake of init_callproc_1.
1323 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1325 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1327 * unexaix.c: Port to more-recent AIX compilers.
1328 (report_error, report_error_1, make_hdr, copy_sym)
1329 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1330 Make arguments const char *, not char *, to avoid violations of C
1331 standard and to fix some AIX warnings reported by Gilles Pion.
1333 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1335 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1336 already have overlays loaded.
1337 (handle_single_display_spec): Before returning without displaying
1338 fringe bitmap, synchronize the bidi iterator with the main display
1339 iterator, by calling iterate_out_of_display_property.
1340 (iterate_out_of_display_property): Detect buffer iteration by
1341 testing that it->string is a Lisp string.
1342 (get_next_display_element): When the current object is exhausted,
1343 and there's something on it->stack, call set_iterator_to_next to
1344 proceed with what's on the stack, instead of returning zero.
1345 (set_iterator_to_next): If called at the end of a Lisp string,
1346 proceed to consider_string_end without incrementing string
1347 position. Don't increment display vector index past the end of
1348 the display vector. (Bug#11417)
1349 (pos_visible_p): Don't report a position visible when move_it_to
1350 stopped at the last line of window, which happens to be scanned
1351 backwards by the bidi iteration. (Bug#11464)
1353 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1356 and right-margin display specs even if the spec is invalid or we
1357 are on a TTY, and thus unable to display on the fringes.
1358 That's because the text with the property will not be displayed anyway,
1359 so we need to signal to the caller that this is a "replacing"
1360 display spec. This fixes display when the spec is invalid or we
1363 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1365 * unexaix.c (make_hdr): Fix typo in prototype.
1366 This bug broke the build on AIX. Problem reported by Gilles Pion.
1368 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1370 * keyboard.c (kbd_buffer_get_event): Read special events also in
1371 batch mode. (Bug#11415)
1373 2012-05-12 Glenn Morris <rgm@gnu.org>
1375 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1377 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1379 * lisp.mk (lisp): Add newcomment.elc.
1381 2012-05-12 Glenn Morris <rgm@gnu.org>
1383 * Makefile.in (MKDIR_P): New, set by configure.
1384 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1386 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1388 Remove unused function hourglass_started.
1389 * dispextern.h (hourglass_started):
1390 * w32fns.c (hourglass_started):
1391 * xdisp.c (hourglass_started): Remove.
1393 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1395 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1396 Update dependencies.
1398 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1400 * xgselect.c (xg_select): Put maxfds+1 into a var.
1401 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1403 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1405 2012-05-10 Dave Abrahams <dave@boostpro.com>
1407 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1408 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1410 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1412 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1413 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1414 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1415 Initialize xd_registered_buses.
1417 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1419 Untag more efficiently if USE_LSB_TAG.
1420 This is based on a proposal by YAMAMOTO Mitsuharu in
1421 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1422 For an admittedly artificial (nth 8000 longlist) benchmark on
1423 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1424 Emacs's overall text size by 1%.
1425 * lisp.h (XUNTAG): New macro.
1426 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1427 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1428 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1429 * eval.c (Fautoload):
1430 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1431 * frame.h (XFRAME): Use XUNTAG.
1433 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1434 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1435 Remove unportable assumptions about print widths of types like
1437 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1438 intptr_t when converting between pointer and integer, to avoid GCC
1439 warnings about wrong width.
1441 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1443 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1444 stack for each reader_thread, instead of defaulting to 8MB
1445 determined by the linker. This avoids failures in creating
1446 subprocesses on Windows 7, see the discussion in this thread:
1447 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1449 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1451 Fix up display of the *Minibuf-0* buffer in the mini window.
1452 * keyboard.c (read_char): Don't clear the echo area if there's no
1454 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1455 contents of *Minibuf-0*) if there's no message displayed in its stead.
1457 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1459 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1462 2012-05-06 Chong Yidong <cyd@gnu.org>
1464 * lisp.mk (lisp): Update.
1466 2012-05-05 Jim Meyering <meyering@redhat.com>
1468 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1470 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1472 * data.c (PUT_ERROR): New macro.
1473 (syms_of_data): Use it. Add new error type `user-error'.
1474 * undo.c (user_error): New function.
1475 (Fprimitive_undo): Use it.
1476 * print.c (print_error_message): Adjust print style for `user-error'.
1477 * keyboard.c (user_error): New function.
1478 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1480 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1482 Do not limit current-time-string to years 1000..9999.
1483 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1484 (Fcurrent_time_string): Support any year that is supported by the
1485 underlying localtime representation. Don't use asctime, as it
1486 has undefined behavior for years outside the range -999..9999.
1488 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1490 Fix race conditions involving setenv, gmtime, localtime, asctime.
1491 Without this fix, interrupts could mess up code that uses these
1492 nonreentrant functions, since setting TZ invalidates existing
1493 tm_zone or tzname values, and since most of these functions return
1494 pointers to static storage.
1495 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1496 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1497 Grow the critical sections to include not just invoking
1498 localtime/gmtime, but also accessing these functions' results
1499 including their tm_zone values if any, and any related TZ setting.
1500 (format_time_string): Last arg is now struct tm *, not struct tm **,
1501 so that the struct tm is saved in the critical section.
1502 All callers changed. Simplify allocation of initial buffer, partly
1503 motivated by the fact that memory allocation needs to be outside
1504 the critical section.
1506 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1508 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1509 with RESET_INTERVAL.
1511 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1512 Remove duplicated buffer name initialization.
1514 2012-05-02 Jim Meyering <jim@meyering.net>
1516 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1518 * xfns.c (x_window): Use xstrdup (Bug#11375).
1520 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1522 * xdisp.c (pos_visible_p): If already at a newline from the
1523 display string before the 'while' loop, don't walk back the glyphs
1524 from it3.glyph_row. Solves assertion violation when the display
1525 string begins with a newline (egg.el). (Bug#11367)
1527 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1529 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1532 2012-05-01 Glenn Morris <rgm@gnu.org>
1534 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1535 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1536 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1537 All were removed before 23.1.
1539 * dispnew.c: Remove HAVE_LIBNCURSES test;
1540 it is always true on relevant platforms.
1542 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1543 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1545 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1547 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1549 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1550 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1553 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1555 Do not avoid creating empty evaporating overlays (Bug#9642).
1556 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1557 That is, do not delete an evaporating overlay if it becomes
1558 empty after its bounds are adjusted to fit within its buffer.
1559 This fix caused other problems, and I'm reverting it until we get
1560 to the bottom of them.
1562 2012-04-27 Chong Yidong <cyd@gnu.org>
1564 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1566 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1568 * xdisp.c (pos_visible_p): If the window start position is beyond
1569 ZV, start the display from buffer beginning. Prevents assertion
1570 violation in init_iterator when the minibuffer window is scrolled
1573 * window.c (window_scroll_pixel_based): Likewise.
1575 2012-04-27 Chong Yidong <cyd@gnu.org>
1577 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1579 2012-04-27 Glenn Morris <rgm@gnu.org>
1581 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1582 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1584 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1586 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1587 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1589 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1591 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1592 display element, check also the underlying string or buffer
1593 character. (Bug#11341)
1595 * w32menu.c: Include w32heap.h.
1596 (add_menu_item): If the call to AppendMenuW (via
1597 unicode_append_menu) fails, disable Unicode menus only if we are
1598 running on Windows 9X/Me.
1600 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1602 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1603 (xgetint): Add missing shift for LSB tags.
1605 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1607 * keyboard.c (read_char): Don't wipe echo area for select window
1608 events: These might get delayed via `mouse-autoselect-window'
1611 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1613 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1614 manipulation of :loaded-from data.
1616 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1618 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1619 now a cons (bug#11311).
1621 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1623 Do not create empty overlays with the evaporate property (Bug#9642).
1624 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1625 if it becomes empty after its bounds are adjusted to fit within
1626 its buffer. Without this fix, in a nonempty buffer (let ((o
1627 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1628 yields an empty overlay that has the evaporate property, which is
1629 not supposed to happen.
1631 Fix minor GTK3 problems found by static checking.
1632 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1633 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1634 (struct _EmacsFixedClass, emacs_fixed_get_type):
1635 Move decls here from emacsgtkfixed.h, since they needn't be public.
1636 (emacs_fixed_get_type): Now static.
1637 (emacs_fixed_class_init): Omit unused local.
1638 (emacs_fixed_child_type): Remove; unused.
1639 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1640 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1641 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1642 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1643 (EMACS_FIXED_GET_CLASS): Remove; unused.
1644 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1646 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1647 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1649 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1651 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1652 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1653 (__malloc_size_t, __malloc_ptrdiff_t):
1654 Remove. All uses removed, replaced by the definiens if needed,
1655 since we can assume C89 or better now.
1656 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1657 (protect_malloc_state, align, get_contiguous_space)
1658 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1659 (malloc_atfork_handler_child, malloc_enable_thread)
1660 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1661 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1662 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1663 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1664 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1665 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1666 Define using prototypes, not old style.
1667 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1668 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1669 (align): Don't assume that signed integer overflow wraps around.
1670 Omit unused local var.
1671 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1672 (_free_internal_nolock, memalign, mallochook, reallochook):
1673 Omit no-longer-needed casts.
1674 (valloc): Use getpagesize, not __getpagesize.
1675 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1676 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1678 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1680 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1682 Move functions from C to Lisp. Make non-blocking method calls
1683 the default. Implement further D-Bus standard interfaces.
1685 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1686 (QCdbus_request_name_allow_replacement)
1687 (QCdbus_request_name_replace_existing)
1688 (QCdbus_request_name_do_not_queue)
1689 (QCdbus_request_name_reply_primary_owner)
1690 (QCdbus_request_name_reply_in_queue)
1691 (QCdbus_request_name_reply_exists)
1692 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1693 (QCdbus_registered_serial, QCdbus_registered_method)
1694 (QCdbus_registered_signal): New Lisp objects.
1695 (XD_DEBUG_MESSAGE): Use sizeof.
1696 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1697 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1698 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1699 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1700 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1701 (xd_signature, xd_append_arg): Allow float for integer types.
1702 (xd_get_connection_references): New function.
1703 (xd_get_connection_address): Rename from xd_initialize.
1704 Return cached address.
1705 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1706 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1708 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1709 Return number of refcounts.
1710 (Fdbus_get_unique_name): Make stronger parameter check.
1711 (Fdbus_message_internal): New defun.
1712 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1713 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1714 (Fdbus_send_signal, Fdbus_register_service)
1715 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1716 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1717 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1718 (Vdbus_compiled_version, Vdbus_runtime_version)
1719 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1720 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1721 (Vdbus_message_type_signal): New defvars.
1722 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1725 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1727 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1728 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1729 Do not assume ptrdiff_t is the same width as 'int'.
1731 * alloc.c: Handle unusual debugging option combinations.
1732 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1733 since the two debugging options are incompatible.
1734 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1736 (mem_init, mem_insert, mem_insert_fixup):
1737 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1738 (NEED_MEM_INSERT): Remove; no longer needed.
1740 2012-04-22 Leo Liu <sdl.web@gmail.com>
1742 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1744 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1746 * sysdep.c [__FreeBSD__]: Minor cleanups.
1747 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1748 Use Emacs indenting style more consistently. Avoid some casts.
1749 Use 'double' consistently rather than mixing 'float' and 'double'.
1751 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1753 * sysdep.c (list_system_processes, system_process_attributes):
1754 Add implementation for FreeBSD (Bug#5243).
1756 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1758 * lisp.mk (lisp): Update.
1760 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1762 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1763 It is never used otherwise.
1765 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1767 * print.c (print_preprocess): Only check print_depth if print-circle
1769 (print_object): Check for cycles even when print-circle is nil and
1770 print-gensym is t, but only check print_depth if print-circle is nil.
1772 2012-04-20 Chong Yidong <cyd@gnu.org>
1774 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1775 set the status to "failed" and ensure that sentinel is run.
1777 2012-04-20 Glenn Morris <rgm@gnu.org>
1779 * process.c (Fset_process_inherit_coding_system_flag)
1780 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1781 (Fmake_network_process, Fmake_serial_process): Doc fix.
1783 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (string_buffer_position_lim): Limit starting position to
1787 (set_cursor_from_row): If called for a mode-line or header-line
1788 row, return zero immediately.
1789 (try_cursor_movement): If inside continuation line, don't back up
1790 farther than the first row after the header line, if any.
1791 Don't consider the header-line row as "partially visible", even if
1792 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1794 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1796 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1799 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1800 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1802 configure: new option --enable-gcc-warnings (Bug#11207)
1803 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1804 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1805 (ALL_CFLAGS): Use new macros rather than old.
1806 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1807 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1808 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1809 -Wunused-result, -Wunused-variable. This should go away once
1810 the Emacs and Gnulib regex code is merged.
1811 (xmalloc, xrealloc): Now static.
1813 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1815 * dired.c (Fsystem_groups): Remove unused local.
1817 2012-04-17 Glenn Morris <rgm@gnu.org>
1819 * dired.c (Fsystem_users): Doc fix.
1821 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1823 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1824 (syms_of_dired): Add them.
1826 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1828 Fix minor alloc.c problems found by static checking.
1829 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1830 New extern decls, to avoid calling undeclared functions.
1831 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1832 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1833 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1834 (NEED_MEM_INSERT): New macro.
1835 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1836 Remove one incorrect comment and fix another.
1838 Fix minor ralloc.c problems found by static checking.
1839 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1840 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1841 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1842 (r_alloc_sbrk): Now static.
1844 Improve ralloc.c interface checking.
1845 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1846 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1847 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1848 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1849 [REL_ALLOC]: ... to here, to check interface.
1850 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1851 Remove decls. This fixes an "It stinks!".
1853 * alloc.c (which_symbols): Fix alignment issue / type clash.
1855 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1857 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1858 (struct Lisp_Misc_Any): Likewise.
1859 (struct Lisp_Free): Likewise.
1860 * alloc.c (union aligned_Lisp_Symbol): Define.
1861 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1862 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1863 (union aligned_Lisp_Misc): Define.
1864 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1865 aligned_Lisp_Misc instead of union Lisp_Misc.
1866 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1868 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1870 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1871 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1872 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1873 * s/netbsd.h, s/sol2-6.h:
1874 Remove definition of GC_MARK_STACK, since the default now works.
1875 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1876 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1877 no longer the default.
1878 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1880 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1882 * lread.c (lisp_file_lexically_bound_p):
1883 Fix hang at ";-*-\n" (bug#11238).
1885 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1887 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1888 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1890 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1892 * nsterm.m (constrainFrameRect): Always constrain when there is only
1893 one screen (Bug#10962).
1895 2012-04-13 Ken Brown <kbrown@cornell.edu>
1897 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1899 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1901 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1903 2012-04-11 Daniel Colascione <dancol@dancol.org>
1905 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1906 against is gone. It's better to use vfork now so that when Cygwin
1907 gains a new, working vfork, we use it automatically (bug#10398).
1909 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1911 * window.c (save_window_save): Obey window-point-insertion-type.
1913 2012-04-11 Glenn Morris <rgm@gnu.org>
1915 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1917 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1919 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1921 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1923 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1924 (force_quit_count): New var.
1925 (handle_interrupt): Use it.
1927 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1929 * w32.c (w32_delayed_load): Record the full path of the library
1930 being loaded (bug#10424).
1932 2012-04-09 Glenn Morris <rgm@gnu.org>
1934 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1935 not just in the obarray, before snarfing them. (Bug#11036)
1937 * Makefile.in ($(leimdir)/leim-list.el):
1938 Pass EMACS rather than BUILT_EMACS.
1940 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1942 * process.c (make_process):
1943 * process.h: Add integer `gnutls_handshakes_tried' member to
1946 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1947 Add convenience `GNUTLS_LOG2i' macro.
1949 * gnutls.c (gnutls_log_function2i): Convenience log function.
1950 (emacs_gnutls_read): Use new log functions,
1951 `gnutls_handshakes_tried' process member, and
1952 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1953 attempts per process (connection).
1955 2012-04-09 Chong Yidong <cyd@gnu.org>
1957 * eval.c (Fuser_variable_p, user_variable_p_eh)
1958 (lisp_indirect_variable): Functions deleted.
1959 (Fdefvar): Caller changed.
1961 * callint.c (Finteractive, Fcall_interactively):
1962 * minibuf.c (Fread_variable): Callers changed.
1964 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1966 * xdisp.c (set_cursor_from_row): If the display string appears in
1967 the buffer at position that is closer to point than the position
1968 after the display string, display the cursor on the first glyph of
1969 the display string. Fixes cursor display when a 'display' text
1970 property immediately follows invisible text. (Bug#11094)
1972 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1974 composite.c: use 'double' consistently
1975 * composite.c (get_composition_id): Use 'double' consistently
1976 instead of converting 'float' to 'double' and vice versa; this is
1977 easier to understand and avoids a GCC warning.
1979 2012-04-09 Glenn Morris <rgm@gnu.org>
1981 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1982 preparation for dumping it with emacs. (Bug#4789)
1983 (leimdir): New variable.
1984 ($(leimdir)/leim-list.el): New rule.
1985 (emacs$(EXEEXT)): Depend on leim-list.el.
1987 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1988 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1989 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1991 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1993 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1996 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1998 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1999 Remove unused local variable.
2001 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2003 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2004 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2005 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2006 objects, as mark_maybe_pointer will catch them otherwise.
2007 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2008 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2010 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2012 Fix typo that broke non-Windows builds.
2013 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2015 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2017 Support building on MS-Windows with libxml2.
2019 * makefile.w32-in (OBJ2): Add xml.$(O).
2020 (GLOBAL_SOURCES): Add xml.c.
2021 ($(BLD)/xml.$(O)): New dependency list.
2023 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2024 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2025 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2026 [!WINDOWSNT]: New macros.
2027 (init_libxml2_functions, libxml2_loaded_p): New functions.
2028 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2029 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2030 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2031 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2033 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2034 Call init_libxml2_functions before calling libxml2 functions.
2035 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2037 * emacs.c: Don't include libxml/parser.h.
2038 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2039 xmlCleanupParser directly.
2041 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2043 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2045 * indent.c (Fvertical_motion): If there is a display string at
2046 point, use it.vpos to compute how many lines to backtrack after
2047 move_it_to point. (Bug#11133)
2049 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2051 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2052 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2053 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2054 macros related to unification of CJK characters. For the details,
2055 see the discussion following the message here:
2056 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2058 2012-04-04 Chong Yidong <cyd@gnu.org>
2060 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2062 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2064 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2065 instead of alloca. (Bug#11138)
2067 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2069 * w32menu.c (is_simple_dialog): Properly check lisp types.
2072 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2074 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2075 position we get to after a call to move_it_to fails the
2076 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2077 only if we wind up in a string from display property. (Bug#11063)
2079 * window.c (Fdelete_other_windows_internal): Invalidate the row
2080 and column information about mouse highlight, so that redisplay
2081 restores it after reallocating the glyph matrices. (Bug#7464)
2083 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2084 string comes from a `display' text property, use the buffer
2085 position of that property as if we actually saw that position in
2087 (move_it_by_lines): Remove the assertion that
2088 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2089 violated when there's a before-string at the beginning of a line.
2092 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2094 * xdisp.c (append_space_for_newline): If the default face was
2095 remapped, use the remapped face for the appended newline.
2096 (extend_face_to_end_of_line): Use the remapped default face for
2097 extending the face to the end of the line.
2098 (display_line): Call extend_face_to_end_of_line when the default
2099 face was remapped. (Bug#11068)
2101 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2103 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2105 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2107 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2109 2012-03-27 Glenn Morris <rgm@gnu.org>
2111 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2114 2012-03-26 Kenichi Handa <handa@m17n.org>
2116 * dispextern.h (struct glyph): Fix previous change. Change the
2117 bit length of glyphless.ch to 25 (Bug#11082).
2119 2012-03-26 Chong Yidong <cyd@gnu.org>
2121 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2122 (command_loop_1): Use it; inhibit selection update for
2123 handle-select-window too (Bug#8996).
2125 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2127 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2129 2012-03-25 Kenichi Handa <handa@m17n.org>
2131 * dispextern.h (struct glyph): Change the bit length of
2132 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2134 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2136 * s/ms-w32.h (tzname): Include time.h before redirecting to
2137 _tzname. Fixes the MSVC build. (Bug#9960)
2139 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2141 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2144 * xterm.c (XTread_socket): Only modify handling_signal if
2145 !SYNC_INPUT. (Bug#11080)
2147 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2149 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2150 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2151 when fetching a multibyte character consumes more bytes than
2152 CHAR_BYTES returns, due to unification of CJK characters in
2153 string_char. (Bug#11073)
2155 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2157 * process.c (wait_reading_process_output): Handle pty disconnect
2158 by refraining from sending oneself a SIGCHLD (bug#10933).
2160 2012-03-22 Chong Yidong <cyd@gnu.org>
2162 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2164 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2165 Mark string as coming from a prefix property.
2166 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2167 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2169 2012-03-21 Chong Yidong <cyd@gnu.org>
2171 * xfaces.c (Vface_remapping_alist): Doc fix.
2173 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2175 * w32proc.c (Fw32_set_console_codepage)
2176 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2179 2012-03-20 Chong Yidong <cyd@gnu.org>
2181 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2182 to reflect default non-nil value of redisplay-dont-pause.
2184 2012-03-19 Kenichi Handa <handa@m17n.org>
2186 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2187 it fit in a valid range (Bug#11003).
2189 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2191 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2192 that is not from display property, accept the row as a "cursor
2193 row" if one of the string's character has a non-nil `cursor'
2194 property. Fixes cursor positioning when there are newlines in
2195 overlay strings, e.g. in icomplete.el. (Bug#11035)
2197 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2199 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2201 2012-03-12 Chong Yidong <cyd@gnu.org>
2203 * eval.c (inhibit_lisp_code): Rename from
2204 inhibit_window_configuration_change_hook; move from window.c.
2206 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2207 * window.c (run_window_configuration_change_hook)
2208 (syms_of_window): Callers changed.
2210 2012-03-11 Chong Yidong <cyd@gnu.org>
2212 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2214 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2216 2012-03-10 Chong Yidong <cyd@gnu.org>
2218 * frame.c (other_visible_frames): Don't assume the selected frame
2219 is visible (Bug#10955).
2221 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2223 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2225 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2227 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2228 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2231 2012-03-03 Glenn Morris <rgm@gnu.org>
2233 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2235 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2237 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2238 position past the first glyph_row that ends at ZV. (Bug#10902)
2239 (redisplay_window, next_element_from_string): Fix typos in
2241 (redisplay_window): Pass to move_it_vertically the margin in
2242 pixels, not in screen lines.
2244 2012-03-02 Glenn Morris <rgm@gnu.org>
2246 * buffer.c (buffer-list-update-hook): Doc fix.
2248 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2250 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2251 push_it before setting up the iterator for the first overlay
2252 string, even if we have an empty string loaded.
2253 (next_overlay_string): If there's an empty string on the iterator
2254 stack, pop the stack. (Bug#10903)
2256 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2258 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2259 Suggested by Stefan Monnier in
2260 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2261 * alloc.c (widen_to_Lisp_Object): New static function.
2262 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2263 and widening them to Lisp_Objects. This would work even if
2264 USE_LSB_TAG is defined and wide integers are used, which might
2265 happen in a future version of Emacs.
2267 2012-02-25 Chong Yidong <cyd@gnu.org>
2269 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2272 * xselect.c (Fx_selection_exists_p): Doc fix.
2273 (x_clipboard_manager_save_all): Print an informative message
2274 before saving to clipboard manager.
2276 2012-02-24 Chong Yidong <cyd@gnu.org>
2278 * keyboard.c (process_special_events): Handle all X selection
2279 requests in kbd_buffer, not just the next one (Bug#8869).
2281 2012-02-23 Chong Yidong <cyd@gnu.org>
2283 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2284 call when setting menu-bar-lines and tool-bar-lines parameters.
2285 (unwind_create_frame_1): New helper function.
2287 * window.c (inhibit_window_configuration_change_hook): New var.
2288 (run_window_configuration_change_hook): Obey it.
2289 (syms_of_window): Initialize it.
2291 2012-02-22 Chong Yidong <cyd@gnu.org>
2293 * xterm.c (x_draw_image_relief): Add missing type check for
2294 Vtool_bar_button_margin (Bug#10743).
2296 2012-02-21 Chong Yidong <cyd@gnu.org>
2298 * fileio.c (Vfile_name_handler_alist): Doc fix.
2300 * buffer.c (Fget_file_buffer): Protect against invalid file
2301 handler return value.
2303 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2305 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2306 when computing $valmask.
2308 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2309 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2310 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2311 It's useless in that case, and it can cause problems on hosts
2312 that allocate halves of EMACS_INT values separately.
2313 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2314 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2315 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2316 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2317 it avoids undefined behavior on hosts where shifting right by more
2318 than the word width has undefined behavior.
2320 2012-02-19 Chong Yidong <cyd@gnu.org>
2322 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2323 (Funhandled_file_name_directory, Ffile_name_as_directory)
2324 (Fdirectory_file_name, Fexpand_file_name)
2325 (Fsubstitute_in_file_name): Protect against invalid file handler
2326 return values (Bug#10845).
2328 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2330 * .gdbinit (pitx): Fix incorrect references to fields of the
2333 2012-02-17 Chong Yidong <cyd@gnu.org>
2335 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2337 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2339 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2340 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2342 2012-02-15 Chong Yidong <cyd@gnu.org>
2344 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2345 marked as special. Also, starting docstrings with * is obsolete.
2347 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2349 * gnutls.c (emacs_gnutls_write): Fix last change.
2351 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2353 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2356 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2358 * keymap.c (Fsingle_key_description): Handle char ranges.
2360 2012-02-12 Chong Yidong <cyd@gnu.org>
2362 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2363 as that creates a dangerous corner case.
2365 * window.c (Fdelete_window_internal): Invalidate the mouse
2366 highlight (Bug#9904).
2368 2012-02-12 Glenn Morris <rgm@gnu.org>
2370 * xselect.c (Fx_own_selection_internal)
2371 (Fx_get_selection_internal, Fx_disown_selection_internal)
2372 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2373 * nsselect.m (Fx_own_selection_internal)
2374 (Fx_disown_selection_internal, Fx_selection_exists_p)
2375 (Fx_selection_owner_p, Fx_get_selection_internal):
2376 Sync docs and argument specs with the xselect.c versions.
2378 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2380 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2382 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2384 * w32select.c (Fx_selection_exists_p): Sync doc string and
2385 argument list with xselect.c. (Bug#10783)
2387 * w16select.c (Fx_selection_exists_p): Sync doc string and
2388 argument list with xselect.c. (Bug#10783)
2390 2012-02-10 Glenn Morris <rgm@gnu.org>
2392 * fns.c (Fsecure_hash): Doc fix.
2394 2012-02-09 Kenichi Handa <handa@m17n.org>
2396 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2398 2012-02-07 Chong Yidong <cyd@gnu.org>
2400 * buffer.c (Fbuffer_local_variables)
2401 (buffer_lisp_local_variables): Handle unbound vars correctly;
2402 don't let Qunbound leak into Lisp.
2404 2012-02-07 Glenn Morris <rgm@gnu.org>
2406 * image.c (Fimagemagick_types): Doc fix.
2408 * image.c (imagemagick-render-type): Change it from a lisp object
2409 to an integer. Move the doc here from the lisp manual.
2410 Treat all values not equal to 0 the same.
2412 2012-02-06 Chong Yidong <cyd@gnu.org>
2414 * doc.c (store_function_docstring): Avoid applying docstring of
2415 alias to base function (Bug#2603).
2417 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2419 * .gdbinit (pp1, pv1): Remove redundant defines.
2422 2012-02-04 Chong Yidong <cyd@gnu.org>
2424 * nsterm.m: Declare a global (Bug#10694).
2426 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2428 * w32.c (get_emacs_configuration_options):
2429 Include --enable-checking, if specified, in the return value.
2431 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2433 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2434 after rounding frame sizes. (Bug#9723)
2436 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2438 * keyboard.c (adjust_point_for_property): Don't position point
2439 before BEGV. (Bug#10696)
2441 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2443 Handle overflow when computing char display width (Bug#9496).
2444 * character.c (char_width): Return EMACS_INT, not int.
2445 (char_width, c_string_width): Check for overflow when
2446 computing the width; this is possible now that individual
2447 characters can have unbounded width. Problem introduced
2448 by merge from Emacs 23 on 2012-01-19.
2450 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2452 * dbusbind.c (Fdbus_register_method): Mention the return value
2453 :ignore in the docstring.
2455 2012-02-02 Glenn Morris <rgm@gnu.org>
2457 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2459 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2460 Unconditionally set to t. (Bug#10673)
2461 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2462 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2463 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2465 2012-02-02 Kenichi Handa <handa@m17n.org>
2467 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2468 0, do not call append_composite_glyph.
2470 2012-02-02 Kenichi Handa <handa@m17n.org>
2472 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2474 (x_produce_glyphs): If the component of a composition is a null
2475 string, set it->pixel_width to 1 to avoid zero-width glyph.
2477 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2479 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2480 first 2 arguments are identical. This makes inserting large
2481 output from a subprocess an order of magnitude faster on
2482 MS-Windows, where all sbrk'ed memory is always contiguous.
2484 2012-01-31 Glenn Morris <rgm@gnu.org>
2486 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2487 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2488 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2490 2012-01-29 Glenn Morris <rgm@gnu.org>
2492 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2494 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2496 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2498 2012-01-28 Chong Yidong <cyd@gnu.org>
2500 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2502 2012-01-26 Chong Yidong <cyd@gnu.org>
2504 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2506 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2507 repeat counts (Bug#10507).
2509 2012-01-26 Glenn Morris <rgm@gnu.org>
2511 * lread.c (syms_of_lread): Doc fix.
2513 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2515 * coding.c (encode_designation_at_bol): Change return value to
2518 2012-01-25 Chong Yidong <cyd@gnu.org>
2520 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2522 2012-01-21 Chong Yidong <cyd@gnu.org>
2524 * floatfns.c (Fcopysign): Make the second argument non-optional,
2525 since nil is not allowed anyway.
2527 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2529 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2530 (send_process): Likewise.
2532 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2534 * window.c (save_window_save, Fcurrent_window_configuration)
2535 (Vwindow_persistent_parameters): Do not use Qstate.
2536 Rewrite doc-strings.
2538 2012-01-19 Kenichi Handa <handa@m17n.org>
2540 * character.c (char_width): New function.
2541 (Fchar_width, c_string_width, lisp_string_width):
2542 Use char_width (Bug#9496).
2544 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2546 * window.c (Vwindow_persistent_parameters): New variable.
2547 (Fset_window_configuration, save_window_save): Handle persistent
2550 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2552 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2553 thrashing the stack of the thread. (Bug#9087)
2555 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2557 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2559 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2561 * xdisp.c (rows_from_pos_range): Handle the case where the
2562 highlight ends on a newline. (Bug#10464)
2563 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2564 he end column for display of highlight that ends on a newline
2567 2012-01-11 Glenn Morris <rgm@gnu.org>
2569 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2570 from load-path also when installation-directory is nil. (Bug#10208)
2572 2012-01-10 Glenn Morris <rgm@gnu.org>
2574 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2576 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2577 Update template values to be closer to their typical values these days.
2579 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2581 * xdisp.c (rows_from_pos_range): Accept additional argument
2582 DISP_STRING, and accept any glyph in a row whose object is that
2583 string as eligible for mouse highlight. Fixes mouse highlight of
2584 display strings from overlays. (Bug#10464)
2586 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2588 emacs: fix an auto-save permissions race condition (Bug#10400)
2589 * fileio.c (auto_saving_dir_umask): New static var.
2590 (Fmake_directory_internal): Use it.
2591 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2592 creating the directory. The old code temporarily assigns
2593 too-generous permissions to the directory.
2594 (do_auto_save_eh): Clear it.
2595 (Fdo_auto_save): Catch all errors, not just file errors, so
2596 that the var is always cleared.
2598 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2600 * search.c (scan_buffer): Pass character positions to
2601 know_region_cache, not byte positions. (Bug#6540)
2603 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2605 * w32.c (sys_rename): Report EXDEV when rename of a directory
2606 fails because the target is on another logical disk. (Bug#10284)
2608 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2610 * xterm.c (x_embed_request_focus): New function.
2612 * xterm.h: Add prototype.
2614 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2616 2012-01-05 Glenn Morris <rgm@gnu.org>
2618 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2620 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2622 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2623 Load gnutls_transport_set_lowat only if GnuTLS version is below
2625 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2626 GnuTLS versions below 2.11.1.
2628 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2630 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2631 to the doc string advising against its use for altering the way
2632 windows are scrolled.
2634 2011-12-28 Kenichi Handa <handa@m17n.org>
2636 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2637 coding-system ASCII compatible only when it does not produce BOM
2638 on encoding (Bug#10383).
2640 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2642 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2644 (create_and_show_popup_menu): Always use menu_position_func for
2647 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2649 * callint.c (Fcall_interactively): Don't truncate prompt string.
2651 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2653 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2654 property that ends at ZV, so that the bidi iteration could be
2655 resumed from there (after widening). (Bug#10360)
2657 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2659 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2661 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2663 * nsterm.m (x_free_frame_resources):
2664 Release f->output_data.ns->miniimage.
2665 (ns_index_color): Fix indentation. Do not retain
2666 color_table->colors[i].
2668 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2671 * nsfns.m (x_set_background_color): Assign return value from
2672 ns_index_color to face-background instead of NSColor*.
2673 (ns_implicitly_set_icon_type): Fix indentation.
2674 Change assignment in for loop to comparison.
2676 * emacs.c (ns_pool): New variable.
2677 (main): Assign ns_pool.
2678 (Fkill_emacs): Call ns_release_autorelease_pool.
2680 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2681 autorelease fdesc, release fdAttrs and tdict.
2682 (ns_get_covering_families): Release charset.
2683 (ns_findfonts): Release NSFontDescriptor created with new.
2684 (ns_uni_to_glyphs): Fix indentation.
2685 (setString): Release attrStr before assigning new value.
2687 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2689 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2691 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2692 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2694 2011-12-18 David Reitter <reitter@cmu.edu>
2696 * nsterm.m (ns_term_init): Subscribe for notifications
2697 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2698 to method trackingNotification in EmacsMenu.
2700 * nsmenu.m (trackingMenu): New variable.
2701 (trackingNotification): New method (from Aquamacs).
2702 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2703 from Aquamacs (Bug#7030).
2705 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2707 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2708 (symbol_to_nsstring): Fix indentation.
2709 (ns_symbol_to_pb): New function.
2710 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2711 (Fns_rotate_cut_buffers_internal): Remove.
2712 (Fns_store_selection_internal): Rename from
2713 Fns_store_cut_buffer_internal.
2714 (ns_get_foreign_selection, Fx_own_selection_internal)
2715 (Fx_disown_selection_internal, Fx_selection_exists_p)
2716 (Fns_get_selection_internal, Fns_store_selection_internal):
2717 Use ns_symbol_to_pb and check if return value is nil.
2718 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2719 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2720 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2721 renamed to Sns_store_selection_internal.
2722 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2723 and remove this function.
2724 (ns_handle_selection_clear): Remove, never used.
2725 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2728 2011-12-17 Ken Brown <kbrown@cornell.edu>
2730 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2731 GID is unknown (Bug#10257).
2733 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2735 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2736 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2737 which caused a build failure on GNU/Linux IA-64. This problem was
2738 introduced by my 2011-10-07 patch.
2740 2011-12-15 Juri Linkov <juri@jurta.org>
2742 * image.c (imagemagick_error): New function. (Bug#10112)
2743 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2744 Use `imagemagick_error' where ImageMagick functions return
2746 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2749 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2751 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2752 fill background (Bug#8992).
2754 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2756 * window.c (Vwindow_combination_resize)
2757 (Vwindow_combination_limit): Use t instead of non-nil in
2759 (Vrecenter_redisplay): Add first sentence of doc-string on
2761 (Frecenter): Fix doc-string typo.
2763 2011-12-11 Kenichi Handa <handa@m17n.org>
2765 * coding.c (Funencodable_char_position): Pay attention to the
2766 buffer text relocation (Bug#9389).
2768 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2770 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2771 gtk_init (Bug#10100).
2773 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2775 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2776 IT->string is nil. (Bug#10263)
2778 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2780 * nsterm.h (x_free_frame_resources): Declare.
2782 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2783 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2785 * nsterm.h (ns_get_defaults_value): Declare.
2787 * nsterm.m (ns_default): Call ns_get_defaults_value.
2789 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2791 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2794 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2796 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2797 that where the value of an _OBJC_* symbol points to is in the .bss
2798 section (Bug#10240).
2800 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2802 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2803 after the loop to call ccl_driver at least once (Bug#8619).
2805 2011-12-08 Kenichi Handa <handa@m17n.org>
2807 * ftfont.c (get_adstyle_property): Fix previous change
2810 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2812 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2813 dirs from the default value of EMACSLOADPATH (bug#10208).
2815 2011-12-07 Glenn Morris <rgm@gnu.org>
2817 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2818 installation and source directories as well. (Bug#10208)
2820 2011-12-06 Chong Yidong <cyd@gnu.org>
2822 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2824 2011-12-06 Glenn Morris <rgm@gnu.org>
2826 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2827 as an error, not just -1. (Bug#10217)
2829 2011-12-05 Chong Yidong <cyd@gnu.org>
2831 * keyboard.c (process_special_events): New function.
2832 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2834 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2836 * coding.c (encode_designation_at_bol): Don't use uninitialized
2837 local variable (Bug#9318).
2839 2011-12-05 Kenichi Handa <handa@m17n.org>
2841 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2842 return Qnil (Bug#8046, Bug#10193).
2844 2011-12-05 Kenichi Handa <handa@m17n.org>
2846 * coding.c (encode_designation_at_bol): New args charbuf_end and
2847 dst. Return the number of produced bytes. Callers changed.
2848 (coding_set_source): Return how many bytes coding->source was
2850 (coding_set_destination): Return how many bytes
2851 coding->destination was relocated.
2852 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2853 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2855 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2857 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2858 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2861 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2863 The following changes are to fix Bug#9318.
2865 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2866 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2867 (encode_coding_iso_2022, encode_coding_sjis)
2868 (encode_coding_big5, encode_coding_charset): Use the above macros.
2870 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2872 * lisp.h (process_quit_flag): Fix external declaration.
2874 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2876 Don't macro-inline non-performance-critical code.
2877 * eval.c (process_quit_flag): New function.
2878 * lisp.h (QUIT): Use it.
2880 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2882 * nsfns.m (get_geometry_from_preferences): New function.
2883 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2885 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2887 * emacs.c (Qkill_emacs): Define.
2888 (syms_of_emacs): Initialize it.
2889 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2890 Qquit_flag to `kill-emacs' instead.
2891 (quit_throw_to_read_char): Add parameter `from_signal'.
2892 All callers changed. Call Fkill_emacs if requested and safe.
2893 * lisp.h (QUIT): Call Fkill_emacs if requested.
2895 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2897 * widget.c (update_wm_hints): Return if wmshell is null.
2898 (widget_update_wm_size_hints): New function.
2900 * widget.h (widget_update_wm_size_hints): Declare.
2902 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2903 widget_update_wm_size_hints (Bug#10104).
2905 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2907 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2908 before a newline, prepare the bidi iterator for consuming the
2909 newline, and keep the current paragraph direction. (Bug#10183)
2910 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2912 2011-12-02 Juri Linkov <juri@jurta.org>
2914 * search.c (Fword_search_regexp): New Lisp function created from
2915 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2916 (Fword_search_backward, Fword_search_forward)
2917 (Fword_search_backward_lax, Fword_search_forward_lax):
2918 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2919 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2921 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2923 * fileio.c (Finsert_file_contents): Move after-change-function call
2924 to before the "handled:" label, since all "goto handled" appear in
2925 cases where the *-change-functions have already been properly called
2928 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2930 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2931 waiting for input. (Bug#10169)
2933 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2935 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2936 verifies glyph row's hash code--we have just reallocated the
2937 glyphs, so their contents can be complete garbage. (Bug#10164)
2939 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2941 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2943 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2945 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2946 attributes are tested _before_ calling verify_row_hash, to protect
2947 against GCC re-ordering of the tests. (Bug#10164)
2949 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2951 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2953 * xterm.c (handle_one_xevent): Only set async_visible and friends
2954 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2955 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2956 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2958 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2960 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2961 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2962 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2963 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2964 All uses changed to use GCPRO1 etc.
2965 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2966 Revert to old implementation (i.e., before 2011-03-11).
2968 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2970 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2971 of scroll runs so as to avoid assigning disabled bogus rows and
2972 unnecessary graphics copy operations.
2974 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2976 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2977 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2978 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2979 (malloc, free, realloc, calloc): Redirect to e_* only when
2982 * lisp.h (GCTYPEBITS): Move before first use.
2983 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2984 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2985 this macro definition.
2987 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2990 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2992 * gtkutil.c (xg_create_frame_widgets):
2993 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2994 present with Gtk+ 2.0.
2996 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2998 * fileio.c (Finsert_file_contents): Undo previous change; see
2999 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3001 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3003 Rename locals to avoid shadowing.
3004 * fileio.c (Finsert_file_contents):
3005 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3006 * process.c (wait_reading_process_output):
3007 Rename inner 'proc' to 'p' to avoid shadowing.
3008 Indent for consistency with usual Emacs style.
3010 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3012 * xdisp.c (redisplay_window): If cursor row is not fully visible
3013 after recentering, and scroll-conservatively is set to a large
3014 number, scroll window by a few more lines to make the cursor fully
3015 visible and out of scroll-margin. (Bug#10105)
3016 (start_display): Don't move to the next line if the display should
3017 start at a newline that is part of a display vector or an overlay
3020 2011-11-24 Juri Linkov <juri@jurta.org>
3022 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3023 after the `MagickPingImage' call. (Bug#10112)
3025 2011-11-23 Chong Yidong <cyd@gnu.org>
3027 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3029 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3031 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3032 making another buffer current. (Bug#10114)
3034 2011-11-23 Glenn Morris <rgm@gnu.org>
3036 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3038 2011-11-23 Chong Yidong <cyd@gnu.org>
3040 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3041 using it (Bug#5984).
3043 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3045 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3046 and header-lines, as they don't have one computed for them.
3049 * .gdbinit (prow): Make displayed values more self-explaining.
3050 Add row's hash code.
3052 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3054 * process.c (wait_reading_process_output): Fix asynchrounous
3055 GnuTLS socket handling on some versions of the GnuTLS library.
3056 (wait_reading_process_output): Add comment and URL.
3058 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3060 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3062 2011-11-21 Chong Yidong <cyd@gnu.org>
3064 * window.c (Fnext_window, Fprevious_window): Doc fix.
3066 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3068 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3070 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3072 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3074 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3076 * window.c (Fset_window_combination_limit): Rename argument
3078 (Vwindow_combination_limit): Remove "status" from doc-string.
3080 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3082 * m/ibms390.h: Remove.
3083 * m/ibms390x.h: Don't include "ibms390.h".
3085 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3087 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3088 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3090 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3092 * casetab.c (Fset_case_table):
3093 * charset.c (Fcharset_after): Fix typos.
3095 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3097 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3098 Otherwise, valgrind does not work on some platforms.
3099 Problem reported by Andreas Schwab in
3100 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3101 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3102 is set, removing the need for VIRT_ADDRESS_VARIES.
3103 (PURE_P): Use a more-efficient implementation that needs just one
3104 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3105 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3106 to 4 (xorl, subq, cmpq, setbe).
3107 * alloc.c (pure): Always extern now, since that's the
3108 VIRT_ADDR_VARIES behavior.
3109 (PURE_POINTER_P): Use a single comparison, not two, for
3110 consistency with the new puresize.h.
3111 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3112 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3113 Remove VIRT_ADDR_VARIES no longer needed.
3115 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3117 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3118 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3119 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3120 behave as if the cursor position were at the window margin.
3122 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3123 and the cursor position is out of bounds, behave as if the cursor
3124 position were at the window margin. (Bug#10075)
3126 2011-11-18 Chong Yidong <cyd@gnu.org>
3128 * window.c (Fwindow_combination_limit): Make first argument
3129 non-optional, since it is meaningless for live windows like the
3132 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3134 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3136 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3138 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3139 (graft_intervals_into_buffer): Simplify.
3141 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3143 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3144 hash values of the two rows.
3145 (copy_row_except_pointers): Preserve the used[] arrays and the
3146 hash values of the two rows. (Bug#10035)
3147 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3149 * xdisp.c (row_hash): New function, body extracted from
3150 compute_line_metrics.
3151 (compute_line_metrics): Call row_hash, instead of computing the
3154 * dispnew.c (verify_row_hash): Call row_hash for computing the
3155 hash code of a row, instead of duplicating code from xdisp.c.
3157 * dispextern.h (row_hash): Add prototype.
3159 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3161 * frame.c (delete_frame): Don't delete the terminal when the last
3162 X frame is closed if emacs is built with GTK toolkit.
3164 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3166 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3168 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3170 * window.c (Vwindow_splits): Rename to
3171 Vwindow_combination_resize. Suggested by Juri Linkov.
3172 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3175 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3177 * nsfns.m (Fns_font_name):
3178 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3180 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3182 * window.h (window): Rename slot "nest" to "combination_limit".
3183 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3184 (Fset_window_nest): Rename to Fset_window_combination_limit.
3185 (Vwindow_nest): Rename to Vwindow_combination_limit.
3186 (recombine_windows, make_parent_window, make_window)
3187 (Fsplit_window_internal, saved_window)
3188 (Fset_window_configuration, save_window_save): Rename all
3189 occurrences of window_nest to window_combination_limit.
3191 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3193 * image.c (imagemagick_load_image): Fix typo.
3195 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3197 * xdisp.c (display_line): Move the call to
3198 highlight_trailing_whitespace before the call to
3199 compute_line_metrics, since the latter needs to see the final
3200 faces of all the glyphs to compute ROW's hash value.
3201 Fixes assertion violations in row_equal_p. (Bug#10035)
3203 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3205 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3206 just return (bug#10044).
3208 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3210 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3211 with user-defined heap size. Bump the default size of the temacs
3212 heap to 27MB, to avoid memory warning when running temacs.
3213 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3215 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3216 current_matrix and desired_matrix. (Bug#9990)
3217 (verify_row_hash) [XASSERTS]: New function.
3218 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3219 that the hash value of glyph rows is correct.
3221 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3223 * window.h (window): Remove splits slot.
3224 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3225 (Fdelete_other_windows_internal, make_parent_window)
3226 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3227 (Fset_window_configuration, save_window_save): Don't deal with
3228 split status of windows.
3229 (saved_window): Remove splits slot.
3230 (Vwindow_splits): Rewrite doc-string.
3232 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3234 * xfns.c (unwind_create_frame):
3235 * nsfns.m (unwind_create_frame):
3236 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3237 Vframe_list (Bug#9999).
3239 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3241 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3243 2011-11-11 Kenichi Handa <handa@m17n.org>
3245 * callproc.c (Fcall_process): Set the member dst_multibyte of
3248 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3250 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3251 avoid a crash (bug#9496).
3253 2011-11-09 Chong Yidong <cyd@gnu.org>
3255 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3256 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3258 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3260 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3262 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3264 Avoid some portability problems by eschewing 'extern inline' functions.
3265 The trivial performance wins aren't worth the portability hassles; see
3266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3268 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3269 (window_box_width, window_box_left, window_box_left_offset)
3270 (window_box_right, window_box_right_offset): Undo previous change,
3271 by removing the "extern"s.
3272 * intervals.c (adjust_intervals_for_insertion)
3273 (adjust_intervals_for_deletion): Undo previous change,
3274 making these static again.
3275 (offset_intervals, temp_set_point_both, temp_set_point)
3276 (copy_intervals_to_string): No longer inline.
3277 * xdisp.c (window_text_bottom_y, window_box_width)
3278 (window_box_height, window_box_left_offset)
3279 (window_box_right_offset, window_box_left, window_box_right)
3280 (window_box): No longer inline.
3282 2011-11-08 Chong Yidong <cyd@gnu.org>
3284 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3285 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3286 Signal an error if not a live window.
3287 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3288 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3290 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3292 * lisp.h (syms_of_abbrev): Remove declaration.
3293 Reported by CHENG Gao <chenggao@royau.me>.
3295 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3297 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3298 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3299 of temacs in GUI mode.
3301 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3303 * window.h: Declare delete_all_child_windows instead of
3304 delete_all_subwindows.
3305 * window.c (Fwindow_nest, Fset_window_nest)
3306 (Fset_window_new_total, Fset_window_new_normal)
3307 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3308 (delete_all_subwindows): Rename to delete_all_child_windows.
3309 (Fdelete_other_windows_internal, Fset_window_configuration):
3310 Call delete_all_child_windows instead of delete_all_subwindows.
3311 * frame.c (delete_frame): Call delete_all_child_windows instead
3312 of delete_all_subwindows.
3314 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3316 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3317 This is also needed for porting to any host where GC_MARK_STACK is
3318 not GC_MAKE_GCPROS_NOOPS.
3319 (which_symbols): Use it.
3321 2011-11-07 Kenichi Handa <handa@m17n.org>
3323 * coding.c (coding_set_destination): Check coding->src_pos only
3324 when coding->src_object is a buffer (bug#9910).
3326 * process.c (send_process): Set the member src_multibyte of coding
3327 to 0 (bug#9911) when sending a unibyte text.
3329 * callproc.c (Fcall_process): Set the member src_multibyte of
3330 process_coding to 0 (bug#9912).
3332 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3334 * xmenu.c (cleanup_widget_value_tree): New function.
3335 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3336 calling free_menubar_widget_value_tree directly (Bug#9830).
3338 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3340 Fix some portability problems with 'inline'.
3341 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3342 (window_box_width, window_box_left, window_box_left_offset)
3343 (window_box_right, window_box_right_offset): Declare extern.
3344 Otherwise, these inline functions do not conform to C99 and
3345 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3347 * intervals.c (adjust_intervals_for_insertion)
3348 (adjust_intervals_for_deletion): Now extern, because otherwise the
3349 extern inline functions 'offset_intervals' couldn't refer to it.
3350 (static_offset_intervals): Remove.
3351 (offset_intervals): Rewrite using the old contents of
3352 static_offset_intervals. The old version didn't conform to C99
3353 because an extern inline function contained a reference to an
3354 identifier with static linkage.
3356 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3358 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3361 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3363 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3364 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3365 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3366 return Qleft_to_right.
3368 2011-11-06 Chong Yidong <cyd@gnu.org>
3370 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3371 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3372 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3373 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3374 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3375 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3376 (Fwindow_vscroll): Doc fix.
3377 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3378 argument, since it makes no sense to pass a live window and for
3379 consistency with window-child.
3381 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3383 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3386 2011-11-05 Jason Rumney <jasonr@gnu.org>
3388 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3389 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3391 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3392 bitwise arithmetic preventing use of unicode-sip and non-truetype
3395 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3397 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3400 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3401 initialization code to keep similarity to xfns.c after changes
3404 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3406 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3407 (unwind_create_frame): New function (Bug#9943).
3408 (Fx_create_frame): Restructure code to be more similar to the one in
3409 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3410 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3411 Move terminal->reference_count++ just before making the frame official
3414 * nsterm.m (x_free_frame_resources): New function.
3415 (x_destroy_window): Move code to x_free_frame_resources.
3417 * xfns.c (unwind_create_frame): Fix comment.
3418 (Fx_create_frame, x_create_tip_frame):
3419 Move terminal->reference_count++ just before making the frame
3420 official. Move initialization of image_cache_refcount and
3421 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3423 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3425 Support MSVC build with newer versions of Visual Studio.
3426 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3427 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3430 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3431 which are not supported by MSVC.
3432 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3433 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3435 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3437 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3439 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3441 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3443 Support MSVC build with newer versions of Visual Studio.
3444 * w32.c: Don't include w32api.h for MSVC.
3445 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3447 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3448 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3449 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3450 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3452 (alloca) [_MSC_VER]: Define to _alloca.
3454 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3456 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3458 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3460 * xdisp.c (note_mouse_highlight): If either of
3461 previous/next-single-property-change returns nil, treat that as
3462 the beginning or the end of the buffer. (Bug#9955)
3464 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3466 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3467 label is not null (Bug#9951).
3468 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3471 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3473 * window.c (Fwindow_body_size): Mention in the doc string that the
3474 return value is in frame's canonical units. (Bug#9949)
3476 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3478 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3480 * w32fns.c (unwind_create_frame): If needed, free the glyph
3481 matrices of the partially constructed frame. (Bug#9943)
3482 * xfns.c (unwind_create_frame): Likewise.
3484 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3486 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3487 Don't stop backward scan on the continuation glyph, even though
3488 its CHARPOS is positive.
3489 (mouse_face_from_buffer_pos, note_mouse_highlight):
3490 Rename cover_string to disp_string.
3492 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3494 * window.c (temp_output_buffer_show): Don't use
3495 Vtemp_buffer_show_specifiers.
3496 (Vtemp_buffer_show_specifiers): Remove unused variable.
3498 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3500 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3501 past the beginning of the current glyph matrix.
3503 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3505 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3506 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3507 HAVE_GTK3 (Bug#9869).
3509 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3510 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3512 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3514 * xterm.c: Declare x_handle_net_wm_state to return int.
3515 (handle_one_xevent): Check if we are iconified but don't have
3516 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3517 (get_current_wm_state): Return non-zero if not hidden,
3518 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3519 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3520 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3521 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3523 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3525 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3526 so that this new function doesn't get optimized away by a
3527 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3529 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3531 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3533 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3535 Fix the `xbytecode' command.
3536 * .gdbinit (xprintbytestr): New command.
3537 (xwhichsymbols): Rename from `which'; all callers changed.
3538 (xbytecode): Print the byte-code string as well.
3540 2011-10-29 Kim Storm <storm@cua.dk>
3542 * alloc.c (which_symbols): New function.
3544 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3546 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3549 2011-10-29 Glenn Morris <rgm@gnu.org>
3551 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3552 Not clear what it was for, and it causes various bugs. (Bug#9839)
3554 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3556 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3557 possible random value that matches one of those tested as
3558 condition to clear the mouse face.
3560 2011-10-28 Chong Yidong <cyd@gnu.org>
3562 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3564 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3566 * window.c (make_window): Initialize phys_cursor_on_p.
3568 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3570 * lisp.h (struct Lisp_Symbol): Update comments.
3572 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3574 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3576 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3578 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3579 <oslsachem@gmail.com> for helping to debug this.
3581 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3582 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3583 (g_b_init_get_glyph_outline_w): New static variables.
3584 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3585 (GetGlyphOutlineW_Proc): New typedefs.
3586 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3587 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3589 (w32font_open_internal, compute_metrics):
3590 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3591 instead of calling the "wide" APIs directly.
3593 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3595 * w32.h (syms_of_w32font): Add prototype.
3597 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3599 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3600 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3601 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3602 (Fmove_to_window_line): Doc fix.
3604 2011-10-27 Chong Yidong <cyd@gnu.org>
3606 * process.c (make_process): Set gnutls_state to NULL.
3608 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3609 non-NULL, regardless of GNUTLS_INITSTAGE.
3610 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3611 an error. Set process slots as soon as we allocate them.
3613 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3615 2011-10-27 Chong Yidong <cyd@gnu.org>
3617 * gnutls.c (emacs_gnutls_deinit): New function.
3618 Deallocate credentials structures as well as calling gnutls_deinit.
3619 (Fgnutls_deinit, Fgnutls_boot): Use it.
3621 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3622 (deactivate_process): Call emacs_gnutls_deinit.
3624 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3626 * image.c (x_create_x_image_and_pixmap):
3627 * w32.c (sys_rename, w32_delayed_load):
3628 * w32font.c (fill_in_logfont):
3629 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3631 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3633 * w32fns.c (w32_default_color_map): New function,
3634 extracted from Fw32_default_color_map.
3635 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3637 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3639 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3641 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3643 * keyboard.c (test_undefined): New function (bug#9751).
3644 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3646 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3648 * sysdep.c (init_sys_modes): Fix the check for the controlling
3649 terminal (Bug#6649).
3651 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3653 * dispextern.h (struct bidi_it): New member next_en_type.
3655 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3656 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3657 current character, check also for next_en_type being WEAK_EN.
3658 (bidi_resolve_weak): Don't enter the expensive loop if the current
3659 position is before next_en_pos. Record the bidi type of the first
3660 non-ET, non-BN character we find, in addition to its position.
3661 (bidi_level_of_next_char): Invalidate next_en_type when
3662 next_en_pos is over-stepped.
3664 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3666 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3667 * editfns.c: Rewrite current-time-zone so that it invokes
3668 the equivalent of (format-time-string "%Z") to get the time zone name.
3669 This fixes a bug when the time zone name contains characters that
3670 need converting from the system time locale to Emacs internal format.
3671 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3672 that patch fixed format-time-string to do the conversion, but
3673 I forgot to fix current-time-zone.
3674 (format_time_string): New function, containing most of
3675 what Fformat_time_string used to contain.
3676 (Fformat_time_string): Rewrite in terms of format_time_string.
3677 This doesn't change this function's behavior.
3678 (current-time-zone): Rewrite to use format_time_string.
3679 This fixes the bug reported by Michael Schierl in
3680 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3681 Jason Rumney's 2007-06-07 change worked around this bug, but
3683 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3685 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3687 * xdisp.c (start_display): If the character at POS is displayed
3688 via a display vector, reset IT->current.dpvec_index to zero.
3689 (try_window_reusing_current_matrix): If a line ends in a display
3690 vector or the next line starts in a display vector, continue
3691 redrawing the window even though the character position of
3692 start_row was reached.
3695 2011-10-18 Chong Yidong <cyd@gnu.org>
3697 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3698 with nobreak-char-display too.
3700 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3702 Fix part 3 of bug#9771.
3703 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3704 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3705 non-neutral characters if the current character is a paragraph
3706 separator (a.k.a. Newline). This avoids running the same
3707 expensive loop twice, once when we consume the preceding newline
3708 and the other time when the line actually needs to be displayed.
3709 Avoid the loop when we see neutrals on the base embedding level
3710 following a character whose directionality is the same as the
3711 paragraph's. This avoids running the expensive loop when a line
3712 ends in a long sequence of neutrals, like control characters.
3713 Add assertion against STRONG_AL type. Slightly rearrange code
3714 that determines the type of a neutral given the first non-neutral
3716 (bidi_level_of_next_char): Set next_en_pos to zero when
3717 invalidating its info.
3719 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3721 * xdisp.c (push_display_prop): Determine whether to record string
3722 or buffer position by IT->string, not by IT->method. Allow
3723 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3724 (move_it_vertically_backward): Don't look for character position
3725 immediately after the newline when in a continuation line.
3728 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3730 * window.c (coordinates_in_window): Rewrite and delabelize
3731 vertical border check. (Bug#5357) (Bug#9618)
3733 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3735 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3736 errors in XSetWindowBorder (bug#9310).
3738 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3740 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3741 avoid crash when xmalloc overrun checking is enabled.
3743 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3745 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3746 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3747 cursor motion with <left> and <right> arrow keys.
3749 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3750 some callers set that themselves.
3752 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3754 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3755 display string and the previous row comes from the same string and
3756 is empty. (Bug#9739) (Bug#9738)
3758 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3760 * doc.c (get_doc_string): Encode file name (bug#9735).
3762 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3764 * bidi.c (bidi_level_of_next_char):
3765 * xdisp.c (get_visually_first_element): Remove old incorrect
3766 comments regarding the Unicode Line Separator character.
3768 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3770 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3772 * alloc.c (Fgc_status): Do not access beyond zombies array
3773 boundary if nzombies > MAX_ZOMBIES.
3774 * alloc.c (dump_zombies): Add missing format specifier.
3776 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3778 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3779 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3781 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3782 Some packages use them to denote characters with modifiers.
3784 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3786 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3787 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3788 matching a pp-number. Rename parameter var to var1.
3790 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3792 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3794 2011-10-08 Glenn Morris <rgm@gnu.org>
3796 * callint.c (Fcall_interactively): Give a more explicit error for the
3797 'c' case with a non-character input. (Bug#8479)
3799 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3801 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3803 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3804 lines that are hscrolled on the left.
3806 * dispnew.c (buffer_posn_from_coords): Account for a possible
3807 presence of header-line. (Bug#4426)
3809 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3811 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3812 Don't advertise functionality which we discourage or doesn't work.
3814 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3816 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3817 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3818 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3819 this makes Emacs dump core during garbage collection on rare
3820 occasions. sizeof is obviously inferior to offsetof here, so
3821 stick with offsetof.
3822 (GC_POINTER_ALIGNMENT): New macro.
3823 (mark_memory): Omit 3rd (offset) arg; caller changed.
3824 Don't assume EMACS_INT alignment is the same as pointer alignment.
3826 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3828 * keyboard.c (read_key_sequence_remapped): New var.
3829 (read_key_sequence): Compute remapping in the right buffer.
3830 (command_loop_1): Use read_key_sequence's remapping directly.
3832 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3834 * dired.c (file_name_completion): Don't expand file name.
3835 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3836 before checking file name handler.
3838 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3839 they've been requested explicitly (bug#9591).
3841 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3843 * keymap.c (Fsingle_key_description): Use make_specified_string
3844 instead of build_string to build string from push_key_description.
3847 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3849 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3850 This fixes a Y2038 bug on 64-bit hosts.
3851 * buffer.c (reset_buffer):
3852 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3853 (Fclear_buffer_auto_save_failure):
3854 Use 0, not -1, to represent an unset failure time, since time_t
3855 might not be signed.
3857 Remove dependency on glibc malloc internals.
3858 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3859 Move back here from lisp.h, but with their new implementations.
3860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3861 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3862 * charset.c (charset_table_init): New static var.
3863 (syms_of_charset): Use it instead of xmalloc. This removes a
3864 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3865 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3866 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3867 Move back to alloc.c.
3868 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3869 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3871 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3873 * nsterm.m (windowDidResize): Call x_set_window_size only when
3874 ns_in_resize is true. Otherwise set pixelwidth/height and
3875 call change_frame_size (Bug#9628).
3877 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3879 Port --enable-checking=all to Fedora 14 x86-64.
3880 * charset.c (syms_of_charset): Also account for glibc malloc's
3881 internal overhead when calculating the initial malloc maximum.
3883 Port --enable-checking=all to Fedora 14 x86.
3884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3886 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3887 (overrun_check_realloc, overrun_check_free):
3888 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3889 That way, xmalloc returns a properly-aligned pointer even if
3890 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3891 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3892 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3893 into account when calculating the initial malloc maximum.
3894 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3895 Move here from alloc.c, so that charset.c can use it too.
3896 Properly align; the old code wasn't right for common 32-bit hosts
3897 when configured with --enable-checking=all.
3898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3899 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3901 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3903 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3906 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3908 * xdisp.c (compute_display_string_end): If there's no display
3909 string at CHARPOS, return -1.
3911 * bidi.c (bidi_fetch_char): When compute_display_string_end
3912 returns a negative value, treat the character as a normal
3913 character not covered by a display string. (Bug#9624)
3915 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3917 * lread.c (Fread_from_string): Fix typo in docstring.
3919 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3921 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3922 newline, reseat the iterator instead of bidi-iterating there one
3923 character at a time. (Bug#9610)
3924 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3925 TO_CHARPOS if the bidi iterator is at base embedding level.
3927 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3929 * lread.c (readevalloop): Use correct code for NBSP.
3930 (read1): Likewise. (Bug#9608)
3932 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3934 * dbusbind.c (Fdbus_register_signal): When service is not
3935 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3937 2011-09-25 Glenn Morris <rgm@gnu.org>
3939 * buffer.c (truncate-lines): Doc fix.
3941 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3943 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3944 (Fset_window_next_buffers): Doc fix.
3946 2011-09-24 Glenn Morris <rgm@gnu.org>
3948 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3950 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3952 Fix minor problems found by static checking.
3953 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3954 * indent.c (Fvertical_motion): Fix == vs = typo.
3956 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3958 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3959 Default value is now t. Doc fix.
3961 * indent.c (Fvertical_motion): Compute and apply the overshoot
3962 logic when moving up, not only when moving down. Fix the
3963 confusing name and values of the it_overshoot_expected variable;
3964 logic changes accordingly. (Bug#9254) (Bug#9549)
3966 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3967 CHARPOS is covered by a display string which includes newlines.
3968 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3969 is covered by a display string with embedded newlines.
3971 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3973 * dbusbind.c (Fdbus_register_signal): Add match rule to
3974 Vdbus_registered_objects_table. (Bug#9581)
3975 (Fdbus_register_method, Vdbus_registered_objects_table):
3978 2011-09-24 Jim Meyering <meyering@redhat.com>
3980 do not ignore write error for any output size
3981 The previous change was incomplete.
3982 While it makes emacs --batch detect the vast majority of stdout
3983 write failures, errors were still ignored whenever the output size is
3984 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3985 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3986 && echo FAIL: ignored write error
3987 FAIL: ignored write error
3988 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3989 && echo FAIL: ignored write error
3990 FAIL: ignored write error
3991 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3993 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3995 * emacs.c (Fkill_emacs): In noninteractive mode exit
3996 non-successfully if a write error occurred on stdout. (Bug#9574)
3998 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4000 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4003 * dispextern.h (struct it): Update the comment documenting what
4006 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4008 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4009 a display string, extend search for cursor position to end of row.
4010 (find_row_edges): If the row ends in a newline from a display
4011 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4012 Handle the case of a display string with multiple newlines.
4013 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4014 non-empty line. Fixes confusing cursor motion with arrow keys at
4015 the beginning of a line that starts with whitespace.
4017 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4019 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4022 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4024 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4027 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4029 * xdisp.c (display_line): Record maximum and minimum buffer
4030 positions even if no glyphs were produced (e.g., by a zero-width
4031 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4032 buffer positions that will be removed from the glyph row because
4034 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4035 column is beyond frame width: don't subtract 1 "pixel" when
4036 computing width of the stretch.
4037 (reseat_at_next_visible_line_start): Undo the change made on
4038 2011-09-17 that saved paragraph information and restored it after
4039 the call to `reseat'. (Bug#9545)
4041 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4043 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4044 and turn window cursor on if cleared (Bug#9415).
4046 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4048 * search.c (boyer_moore): Take unibyte characters from pattern
4049 literally. (Bug#9458)
4051 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4053 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4055 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4057 Fix minor problem found by static checking.
4058 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4059 initialized, to pacify gcc -Wuninitialized.
4061 * fileio.c: Report proper errno when syscall falls.
4062 (Finsert_file_contents): Save and restore errno,
4063 so that report_file_error outputs the correct diagnostic.
4064 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4066 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4068 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4070 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4072 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4073 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4075 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4077 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4078 about the current paragraph and restore it after the call to reseat.
4080 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4081 (bidi_find_paragraph_start): Search back for paragraph beginning
4082 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4083 (bidi_move_to_visually_next): Only trigger paragraph-related
4084 computations when the last character is a newline or at EOB, not
4085 just any NEUTRAL_B. (Bug#9470)
4087 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4088 truncated lines if point is covered by a display string. (Bug#9524)
4090 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4092 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4093 (cons_to_x_long): New function.
4094 (lisp_data_to_selection_data): Use it. Correct the test for
4095 short-versus-long data; it was negated. Break out of vector
4096 loop, for efficiency, when a long datum is discovered.
4098 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4100 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4102 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4104 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4105 GCC PR/17406) by declaring this function with external scope.
4107 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4109 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4110 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4112 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4114 * editfns.c (Fformat): Correctly handle text properties on "%%".
4116 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4118 * xterm.c (x_draw_composite_glyph_string_foreground):
4119 * w32term.c (x_draw_composite_glyph_string_foreground):
4120 * term.c (encode_terminal_code):
4121 * composite.c (composition_update_it, get_composition_id):
4122 * xdisp.c (get_next_display_element)
4123 (fill_composite_glyph_string): Add comments about special meaning
4124 of TAB characters in a composition.
4126 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4128 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4129 This occurs when processing a multibyte format.
4130 Problem reported by Wolfgang Jenker.
4132 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4134 * xdisp.c (try_cursor_movement): Only check for exact match if
4135 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4137 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4139 Remove unused external symbols.
4140 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4141 * xdisp.c (calc_pixel_width_or_height): Now static.
4142 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4143 * indent.c (check_display_width):
4144 * w32term.c: Fix comment to match code.
4145 * xterm.c, xterm.h (x_catching_errors): Remove.
4147 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4149 * xselect.c: Use signed conversions more consistently (Bug#9498).
4150 (selection_data_to_lisp_data): Assume incoming selection data are
4151 signed integers, not unsigned. This is to be consistent with
4152 outgoing selection data, which was modified to use signed integers
4153 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4154 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4155 expects long, not unsigned long.
4157 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4159 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4160 computation of loop end. Reported by Johan Bockgård
4163 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4165 * frame.c (Fother_visible_frames_p): Function deleted.
4167 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4169 * indent.c (compute_motion): Process display vector front to back
4170 rather than the other way around. (Bug#2496)
4172 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4174 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4176 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4178 * minibuf.c (Fread_from_minibuffer): Doc fix.
4180 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4182 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4183 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4185 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4188 value for non-existent files.
4190 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4192 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4193 set its "size" to -1. This will set the modtime_size field of
4194 the corresponding buffer to -1, which is what
4195 verify-visited-file-modtime expects for files that do not exist.
4198 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4200 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4202 * lisp.h: ... from here. push_key_description is no longer
4203 defined in keyboard.c, so its declaration should not be in
4204 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4205 logically belongs with push_key_description.
4207 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4209 * buffer.h: Include <sys/types.h> instead of <time.h>.
4210 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4211 Problem reported by Herbert J. Skuhra.
4213 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4215 * xml.c (parse_region): Make the parsing work for
4216 non-comment-starting XML files again (bug#9144).
4218 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4220 * image.c (gif_load): Fix calculation of bottom and right corner.
4223 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4225 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4226 redisplay in small windows.
4228 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4230 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4232 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4234 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4235 Operate on live windows only.
4237 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4239 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4241 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4243 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4244 only under bidi iteration.
4246 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4248 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4250 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4252 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4253 Without this fix, the command to link temacs failed due to an
4254 undefined symbol __builtin_isnan. This is because
4255 /usr/include/iso/math_c99.h #defines isnan(x) to
4256 __builtin_isnan(x), but the bundled gcc, which identifies itself
4257 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4259 * floatfns.c (isnan): #undef, and then #define to a clone of
4261 (Fisnan): Always define, since it's always available now.
4262 (syms_of_floatfns): Always define isnan at the Lisp level.
4264 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4266 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4268 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4270 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4271 The previous code assumed that file offsets (off_t values) fit in
4272 EMACS_INT variables, which is not true on typical 32-bit hosts.
4273 The code messed up by falsely reporting buffer overflow in cases
4274 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4275 when "big" contains more than 2**29 bytes, even though this
4276 inserts just one byte and does not overflow the buffer.
4277 (Finsert_file_contents): Store file offsets as off_t
4278 values, not as EMACS_INT values. Check for overflow when
4279 converting between EMACS_INT and off_t. When checking for
4280 buffer overflow or for overlap, take the offsets into account.
4281 Don't use EMACS_INT for small values where int suffices.
4282 When checking for overlap, fix a typo: ZV was used where
4283 ZV_BYTE was intended.
4284 (Fwrite_region): Don't assume off_t fits into 'long'.
4285 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4287 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4289 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4291 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4293 sprintf-related integer and memory overflow issues (Bug#9412).
4295 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4296 (esprintf, exprintf, evxprintf): New functions.
4297 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4298 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4299 (modify_event_symbol): Do not assume that the length of
4300 name_alist_or_stem is safe to alloca and fits in int.
4301 (Fexecute_extended_command): Likewise for function name and binding.
4302 (Frecursion_depth): Wrap around reliably on integer overflow.
4303 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4304 since some callers pass EMACS_INT values.
4305 (Fsingle_key_description): Don't crash if symbol name contains more
4306 than MAX_ALLOCA bytes.
4307 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4308 (get_minibuffer): Arg is now EMACS_INT, not int.
4309 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4310 (esprintf, exprintf, evxprintf): New decls.
4311 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4313 * dbusbind.c (signature_cat): New function.
4314 (xd_signature, Fdbus_register_signal):
4315 Do not overrun buffer; instead, report string overflow.
4317 * dispnew.c (add_window_display_history): Don't overrun buffer.
4318 Truncate instead; this is OK since it's just a log.
4320 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4321 even if the time zone offset is outlandishly large.
4322 Don't mishandle offset == INT_MIN.
4324 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4325 when creating daemon; the previous buffer-overflow check was incorrect.
4327 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4328 which has the guts of the old verror function.
4330 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4331 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4333 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4334 (font_unparse_xlfd): Don't blindly alloca long strings.
4335 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4336 fits in int, when using sprintf. Use single snprintf to count
4337 length of string rather than counting it via multiple sprintfs;
4338 that's simpler and more reliable.
4339 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4340 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4341 sprintf, in case result does not fit in int.
4343 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4344 (fontset_from_font): Print it.
4346 * frame.c (tty_frame_count): Now printmax_t, not int.
4347 (make_terminal_frame, set_term_frame_name): Print it.
4348 (x_report_frame_params): In X, window IDs are unsigned long,
4349 not signed long, so print them as unsigned.
4350 (validate_x_resource_name): Check for implausibly long names,
4351 and don't assume name length fits in 'int'.
4352 (x_get_resource_string): Don't blindly alloca invocation name;
4353 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4356 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4357 (xg_check_special_colors, xg_set_geometry):
4358 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4360 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4361 Use esprintf, not sprintf, in case result does not fit in int.
4363 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4364 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4365 it as a large positive number.
4366 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4367 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4369 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4370 in case result does not fit in int.
4372 * print.c (float_to_string): Detect width overflow more reliably.
4373 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4374 buffer overrun. Don't assume list length fits in 'int'. Treat
4375 print length of 0 as 0, not as infinity; to be consistent with other
4376 uses of print length in this function. Don't overflow print length
4377 index. Don't assume hash table size fits in 'long', or that
4378 vectorlike size fits in 'unsigned long'.
4380 * process.c (make_process): Use printmax_t, not int, to format
4381 process-name gensyms.
4383 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4385 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4386 to avoid potential buffer overrun.
4388 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4389 if X resource line is longer than 512 bytes.
4391 * xfns.c (x_window): Make sprintf buffer a bit bigger
4392 to avoid potential buffer overrun.
4394 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4396 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4398 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4400 Integer overflow fixes for scrolling, etc.
4401 Without these, Emacs silently mishandles large integers sometimes.
4402 For example, "C-u 4294967297 M-x recenter" was treated as if
4403 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4405 * xdisp.c (try_window_id): Check Emacs fixnum range before
4406 converting to 'int'.
4408 * window.c (window_scroll_line_based, Frecenter):
4409 Check that an Emacs fixnum is in range before assigning it to 'int'.
4410 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4411 values converted from Emacs fixnums.
4412 (Frecenter): Don't wrap around a line count if it is out of 'int'
4413 range; instead, treat it as an extreme value.
4414 (Fset_window_configuration, compare_window_configurations):
4415 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4417 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4418 that can exceed INT_MAX. Check that EMACS_INT value is in range
4419 before assigning it to the (possibly-narrower) index.
4420 (match_limit): Don't assume that a fixnum can fit in 'int'.
4422 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4425 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4426 (Fvertical_motion): Don't wrap around LINES values that don't fit
4427 in 'int'. Instead, treat them as extreme values. This is good
4428 enough for windows, which can't have more than INT_MAX lines anyway.
4430 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4432 * Require libxml/parser.h to avoid compilation warning.
4434 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4436 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4437 since this reportedly can destroy thread storage.
4439 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4441 * syntax.c (find_defun_start): Update all cache variables if
4442 exiting early (Bug#9401).
4444 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4446 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4448 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4449 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4450 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4452 * term.c (tty_append_glyph): New function.
4453 (produce_stretch_glyph): Static function and its prototype deleted.
4455 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4458 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4460 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4461 when checking :margin (Bug#9390).
4462 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4463 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4464 so that the name doesn't mislead. All uses changed.
4466 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4468 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4471 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4473 * xdisp.c (move_it_to): Don't bail out early when reaching
4474 position beyond to_charpos, if we are scanning backwards.
4475 (move_it_vertically_backward): When DY == 0, make sure we get to
4476 the first character in the line after the newline.
4478 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4480 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4481 (ccl_driver): Do not generate an out-of-range pointer.
4482 (Fccl_execute_on_string): Remove unnecessary check for
4483 integer overflow, noted by Stefan Monnier in
4484 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4485 Remove a FIXME that didn't need fixing.
4486 Simplify the newly-introduced buffer reallocation code.
4488 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4490 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4492 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4494 Integer and memory overflow issues (Bug#9196).
4496 * doc.c (get_doc_string): Rework so that
4497 get_doc_string_buffer_size is the actual buffer size, rather than
4498 being 1 less than the actual buffer size; this makes xpalloc more
4501 * image.c (x_allocate_bitmap_record, cache_image):
4502 * xselect.c (Fx_register_dnd_atom):
4503 Simplify previous changes by using xpalloc.
4505 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4506 since either will do and ptrdiff_t is convenient with xpalloc.
4508 * charset.c (charset_table_size)
4509 (struct charset_sort_data.priority): Now ptrdiff_t.
4510 (charset_compare): Don't overflow if priorities differ greatly.
4511 (Fsort_charsets): Don't assume list length fits in int.
4512 Check for size-calculation overflow when allocating sort data.
4513 (syms_of_charset): Allocate an initial charset table that is
4514 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4516 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4518 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4519 The actual value is always <= INT_MAX, and leaving it unsigned made
4520 overflow checking harder.
4522 * dispextern.h (struct glyph_matrix.rows_allocated)
4523 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4524 with xpalloc. The values are still always <= INT_MAX.
4526 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4528 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4529 (SAFE_NALLOCA): New macro.
4531 * region-cache.c (struct boundary.pos, find_cache_boundary)
4532 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4533 (set_cache_region, invalidate_region_cache)
4534 (revalidate_region_cache, know_region_cache, region_cache_forward)
4535 (region_cache_backward, pp_cache):
4536 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4537 so that ptrdiff_t * can be passed to xpalloc.
4538 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4539 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4540 (pp_cache): Don't assume cache_len fits in int.
4541 * region-cache.h: Adjust extern decls to match.
4543 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4544 EMACS_INT, since either will do, for xpalloc.
4546 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4547 (xnmalloc, xnrealloc, xpalloc): New functions.
4549 * bidi.c (bidi_shelve_header_size): New constant.
4550 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4551 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4553 * bidi.c (bidi_cache_shrink):
4554 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4556 Don't update size of array until after memory allocation succeeds,
4557 because xmalloc/xrealloc may not return.
4558 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4559 now that we have proper integer overflow checking.
4560 (record_overlay_string, overlay_strings): Catch overflows when
4561 calculating size of overlay_str_buf.
4563 * callproc.c (Fcall_process): Check for size overflow when
4564 calculating size of args2.
4565 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4566 Normally we prefer signed values, but sticking with ptrdiff_t would
4567 require adding more-complicated checks.
4569 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4570 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4571 Redo buffer-overflow calculations to avoid integer overflow.
4572 Add a FIXME comment where memory seems to be over-allocated.
4574 * character.c (Fstring): Check for size-calculation overflow.
4576 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4577 unnecessary integer overflow. Check for size overflow.
4578 (encode_coding_object): Don't update size until xmalloc succeeds.
4580 * composite.c (get_composition_id): Check for overflow in glyph
4581 length calculations.
4583 Integer and memory overflow fixes for display code.
4584 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4585 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4586 (scrolling_window): Check for overflow in size calculations.
4587 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4588 Don't assume glyph table len fits in int.
4589 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4590 (row_table_size): Now ptrdiff_t, not int.
4591 (scrolling_window): Avoid overflow in size calculations.
4592 Don't update size until allocation succeeds.
4593 * fns.c (concat): Check for overflow in size calculations.
4594 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4595 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4596 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4598 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4599 (get_doc_string): Check for size calculation overflow.
4600 Don't update size until allocation succeeds.
4601 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4602 EMACS_INT, where ptrdiff_t will do.
4603 (Fsubstitute_command_keys): Check for string overflow.
4605 * editfns.c (set_time_zone_rule): Don't assume environment length
4607 (message_length): Now ptrdiff_t, not int.
4608 (Fmessage_box): Don't update size until allocation succeeds.
4609 Don't assume message length fits in int.
4610 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4612 * emacs.c (main): Do not reallocate argv, since there is a null at
4613 the end that can be overwritten, and this way there's no need to
4614 worry about size-calculation overflow.
4615 (sort_args): Check for size-calculation overflow.
4617 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4619 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4621 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4622 (x_set_scroll_bar_width, x_figure_window_size):
4623 Check for integer overflow.
4624 (x_set_alpha): Do not assume XINT fits in int.
4626 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4627 This is for the members text_lines, text_cols, total_lines, total_cols,
4628 where the system imposes an 'int' limit.
4630 * fringe.c (Fdefine_fringe_bitmap):
4631 Don't update size until alloc works.
4633 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4634 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4636 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4637 Check for size-calculation overflow.
4638 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4639 do, as we prefer signed integers.
4640 (id_to_widget.max_size, id_to_widget.used)
4641 (xg_store_widget_in_map, xg_remove_widget_from_map)
4642 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4643 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4644 Use and return ptrdiff_t, not int.
4645 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4646 * gtkutil.h: Change prototypes to match the above.
4648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4649 are duplicate now that they've been promoted to lisp.h.
4650 (x_allocate_bitmap_record, x_alloc_image_color)
4651 (make_image_cache, cache_image, xpm_load):
4652 Don't update size until alloc is done.
4653 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4655 Check for size calculation overflow.
4656 (ct_colors_allocated_max): New constant.
4657 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4660 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4661 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4662 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4663 Use ptrdiff_t, not int, to count maps.
4664 (read_char_minibuf_menu_prompt): Check for overflow in size
4665 calculations. Don't update size until allocation succeeds.
4666 Redo calculations to avoid overflow.
4667 * keyboard.h: Change prototypes to match the above.
4669 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4671 (current_minor_maps): Check for size calculation overflow.
4672 * keymap.h: Change prototypes to match the above.
4674 * lread.c (read1, init_obarray): Don't update size until alloc done.
4676 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4677 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4679 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4680 Now ptrdiff_t, not int.
4681 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4682 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4684 * process.c (Fnetwork_interface_list): Check for overflow
4685 in size calculation.
4687 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4689 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4690 overflow. Don't bother calling xmalloc when xrealloc will do.
4692 * search.c (Freplace_match): Check for size calculation overflow.
4693 (Fset_match_data): Don't assume list lengths fit in 'int'.
4695 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4696 for command line length. Do not attempt to address one before the
4697 beginning of an array, as that's not portable.
4699 * term.c (max_frame_lines): Remove; unused.
4700 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4702 (encode_terminal_code, calculate_costs): Check for size
4703 calculation overflow.
4704 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4705 table lengths and related sizes. Don't update size until alloc
4706 done. Redo calculations to avoid overflow.
4707 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4709 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4710 subtracting pointers.
4711 (gobble_line): Check for overflow more carefully. Don't update size
4714 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4715 Don't update size until alloc done.
4716 Redo size calculations to avoid overflow.
4717 Check for size calculation overflow.
4718 (main) [DEBUG]: Fix typo in invoking tparam1.
4720 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4721 Use ptrdiff_t, not int, for sizes.
4722 (store_mode_line_noprop_char): Don't update size until alloc done.
4724 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4725 Use ptrdiff_t, not int, for sizes.
4726 (Finternal_make_lisp_face, cache_face):
4727 Check for size calculation overflow.
4728 (cache_face): Treat size calculation overflows as if they were
4729 memory exhaustion (the usual treatment), rather than aborting.
4731 * xfns.c (x_encode_text, x_set_name_internal)
4732 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4733 sizes, since they can exceed INT_MAX in size. Check for size
4734 calculation overflow.
4736 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4737 (xg_select): Check for size calculation overflow.
4738 Don't update size until alloc done.
4740 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4741 as sprintf is limited to int lengths.
4743 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4744 (X_LONG_MIN): New macros.
4745 Use them to make the following changes clearer.
4746 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4747 This change doesn't affect the value now, but it may help remind
4748 future maintainers not to raise the value too much later.
4749 (SELECTION_QUANTUM): Remove, replacing with ...
4750 (selection_quantum): ... new function, which avoids overflow.
4752 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4753 assumption that selection length fits in 'int'.
4754 (x_reply_selection_request, x_handle_selection_request)
4755 (x_get_window_property, receive_incremental_selection)
4756 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4757 (lisp_data_to_selection_data, clean_local_selection_data):
4758 Use ptrdiff_t, not int, to record length of selection.
4759 (x_reply_selection_request, x_get_window_property)
4760 (receive_incremental_selection, x_property_data_to_lisp):
4761 Redo calculations to avoid overflow.
4762 (x_reply_selection_request): When sending hint, ceiling it at
4763 X_LONG_MAX rather than relying on wraparound overflow to send
4765 (x_get_window_property, receive_incremental_selection)
4766 (lisp_data_to_selection_data, x_property_data_to_lisp):
4767 Check for size-calculation overflow.
4768 (x_get_window_property, receive_incremental_selection)
4769 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4770 Don't store size until memory allocation succeeds.
4771 (x_get_window_property): Plug memory leak on memory exhaustion.
4772 Don't double-block input; malloc is safe here. Don't assume 2**34
4773 - 4 fits in unsigned long. Add an xassert to check
4774 XGetWindowProperty overflow. Be more careful about overflow
4775 calculations, and distinguish size from memory overflow better.
4776 (receive_incremental_selection): When tracing, don't assume
4777 unsigned int is less than INT_MAX.
4778 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4779 harmful) conversions of unsigned short to int.
4780 (lisp_data_to_selection_data): Don't assume that integers
4781 in the range -65535 through -1 fit in an X unsigned short.
4782 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4783 result parameters unless successful. Rely on cons_to_unsigned
4784 to report problems with elements; the old code wasn't right anyway.
4785 (x_check_property_data): Check for int overflow; we cannot use
4786 a wider type due to X limits.
4787 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4789 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4791 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4792 (x_term_init): Check for size calculation overflow.
4793 (x_color_cells): Don't store size until memory allocation succeeds.
4794 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4795 Don't assume alloca size is less than MAX_ALLOCA.
4796 (x_term_init): Don't assume length fits in int (sprintf is limited
4799 Use ptrdiff_t for composition IDs.
4800 * character.c (lisp_string_width):
4801 * composite.c (composition_table_size, n_compositions)
4802 (get_composition_id, composition_gstring_from_id):
4803 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4804 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4805 * window.c (Frecenter):
4806 Use ptrdiff_t, not int, for composition IDs.
4807 * composite.c (get_composition_id): Check for integer overflow.
4808 * composite.h: Adjust prototypes to match the above changes.
4810 Use ptrdiff_t for hash table indexes.
4811 * category.c (hash_get_category_set):
4812 * ccl.c (ccl_driver):
4813 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4814 * coding.c (coding_system_charset_list, detect_coding_system):
4815 * coding.h (struct coding_system.id):
4816 * composite.c (get_composition_id, gstring_lookup_cache):
4817 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4818 * image.c (xpm_get_color_table_h):
4819 * lisp.h (hash_lookup, hash_put):
4820 * minibuf.c (Ftest_completion):
4821 Use ptrdiff_t for hash table indexes, not int (which is too
4822 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4823 32-bit --with-wide-int hosts).
4825 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4826 Add a FIXME comment about memory leaks.
4827 (syms_of_charset): Don't assume xmalloc returns.
4829 Don't assume that stated character widths fit in int.
4830 * character.c (Fchar_width, c_string_width, lisp_string_width):
4831 * character.h (CHAR_WIDTH):
4832 * indent.c (MULTIBYTE_BYTES_WIDTH):
4833 Use sanitize_char_width to avoid undefined and/or bad behavior
4834 with outlandish widths.
4835 * character.h (sanitize_tab_width): Rename from sanitize_width,
4836 now that we have two such functions. All uses changed.
4837 (sanitize_char_width): New inline function.
4839 Don't assume that tab-width fits in int.
4840 * character.h (sanitize_width): New inline function.
4841 (SANE_TAB_WIDTH): New macro.
4842 (ASCII_CHAR_WIDTH): Use it.
4843 * indent.c (sane_tab_width): Remove. All uses replaced by
4844 SANE_TAB_WIDTH (current_buffer).
4845 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4847 * fileio.c: Integer overflow issues with file modes.
4848 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4850 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4851 Remove unreachable code.
4852 (read_hex, load_charset_map_from_file): Check for integer overflow.
4854 * xterm.c: Don't go over XClientMessageEvent limit.
4855 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4856 (x_send_scroll_bar_event): Likewise. Check that the size does not
4857 exceed limits imposed by XClientMessageEvent, as well as the usual
4858 ptrdiff_t and size_t limits.
4860 * keyboard.c: Overflow, signedness and related fixes.
4861 (make_lispy_movement): Use same integer type in forward decl
4862 that is used in the definition.
4863 (read_key_sequence, keyremap_step):
4864 Change bufsize argument back to int, undoing my 2011-03-30 change.
4865 We prefer signed types, and int is wide enough here.
4866 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4867 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4868 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4869 length, not size_t. Use ptrdiff_t for index, not int.
4870 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4871 possibility of integer overflow.
4873 Overflow, signedness and related fixes for images.
4875 * dispextern.h (struct it.stack[0].u.image.image_id)
4876 (struct_it.image_id, struct image.id, struct image_cache.size)
4877 (struct image_cache.used, struct image_cache.ref_count):
4878 * gtkutil.c (update_frame_tool_bar):
4879 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4880 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4881 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4882 * nsmenu.m (update_frame_tool_bar):
4883 * xdisp.c (calc_pixel_width_or_height):
4884 * xfns.c (image_cache_refcount):
4885 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4886 on typical 64-bit hosts.
4888 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4889 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4890 Omit unnecessary casts to int.
4891 (parse_image_spec): Check that integers fall into 'int' range
4892 when the callers expect that.
4893 (image_ascent): Redo ascent calculation to avoid int overflow.
4894 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4895 (lookup_image): Remove unnecessary tests.
4896 (xbm_image_p): Locals are now of int, not EMACS_INT,
4897 since parse_image_check makes sure they fit into int.
4898 (png_load, gif_load, svg_load_image):
4899 Prefer int to unsigned where either will do.
4900 (tiff_handler): New function, combining the cores of the
4901 old tiff_error_handler and tiff_warning_handler.
4902 This function is rewritten to use vsnprintf and thereby avoid
4903 stack buffer overflows. It uses only the features of vsnprintf
4904 that are common to both POSIX and native Microsoft.
4905 (tiff_error_handler, tiff_warning_handler): Use it.
4906 (tiff_load, gif_load, imagemagick_load_image):
4907 Don't assume :index value fits in 'int'.
4908 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4909 (imagemagick_load_image): Check that crop parameters fit into
4910 the integer types that MagickCropImage accepts. Don't assume
4911 Vimagemagick_render_type has a nonnegative value. Don't assume
4912 size_t fits in 'long'.
4913 (gs_load): Use printmax_t to print the widest integers possible.
4914 Check for integer overflow when computing image height and width.
4916 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4918 * xdisp.c (redisplay_window): Don't force window start if point
4919 will be invisible in the resulting window. (Bug#9324)
4921 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4923 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4924 the display spec is of the form `(space ...)'.
4925 (handle_display_spec): Return the value returned by
4926 handle_single_display_spec, not just 1 or zero.
4927 (handle_single_display_spec): If the display spec is of the form
4928 `(space ...)', and specifies display in the text area, return 2
4930 (try_cursor_movement): Check for the need to scroll more
4931 accurately, and prefer exact match for point under bidi.
4932 Don't advance `row' beyond the last row of the window.
4934 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4935 into disp_prop; all users changed.
4937 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4938 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4939 for the text covered by the display property.
4941 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4943 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4944 Change return value to nil.
4945 (Frecord_buffer): Delete unused function.
4947 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4949 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4950 buffers, return left-to-right.
4951 (set_cursor_from_row): Consider candidate row a win if its glyph
4952 represents a newline and point is on that newline. Fixes cursor
4953 positioning on the newline at EOL of R2L text within L2R
4954 paragraph, and vice versa.
4955 (try_cursor_movement): Check continued rows, in addition to
4956 continuation rows. Fixes unwarranted scroll when point enters a
4957 continued line of R2L text within an L2R paragraph, or vice versa.
4958 (cursor_row_p): Consider the case of point being equal to
4959 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4960 from the end of a short line to the beginning of a continued line
4961 of R2L text within L2R paragraph.
4962 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4963 composed characters.
4965 * bidi.c (bidi_check_type): Use xassert.
4966 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4969 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4971 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4974 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4976 * nsfont.m (ns_otf_to_script): Fix typo.
4978 2011-08-22 Kenichi Handa <handa@m17n.org>
4980 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4981 extra slot even if the purpose is char-code-property-table.
4983 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4985 * xdisp.c (redisplay_window): When computing centering_position,
4986 account for the height of the header line. (Bug#8874)
4988 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4989 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4990 candidate is selected by the mouse, and that candidate has a
4991 composed character under the mouse.
4993 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4994 coordinates reported by pos-visible-in-window-p for a composed
4995 character in column zero.
4997 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4999 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5001 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5003 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5004 consider it a hit if to_charpos is anywhere in the range of the
5005 composed buffer positions.
5007 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5009 * image.c (gif_load): Don't assume that each subimage has the same
5010 dimensions as the base image. Handle disposal method that is
5011 "undefined" by the gif spec (Bug#9335).
5013 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5015 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5016 (Fcondition_case): Document `debug' symbol in error handler.
5018 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5020 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5021 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5022 from an Org mode buffer to a Speedbar frame.
5024 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5025 a composition, take its buffer position from IT->cmp_it.charpos.
5026 Fixes cursor positioning at the beginning of a line that begins
5027 with a composed character.
5029 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5031 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5032 character bidirectional type, use STRONG_L instead. Fixes crashes
5033 in a buffer produced by `describe-categories'.
5035 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5036 members before the level stack, so they would be saved and
5037 restored when copying iterator state. Fixes incorrect reordering
5038 around TABs covered by display properties.
5040 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5042 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5044 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5046 * eval.c (internal_condition_case, internal_condition_case_1)
5047 (internal_condition_case_2, internal_condition_case_n):
5048 Remove unnecessary aborts (Bug#9081).
5050 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5052 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5053 has no `load' handler, try opening the file locally. (Bug#9311)
5055 2011-08-16 Ken Brown <kbrown@cornell.edu>
5057 * gmalloc.c: Expand comment.
5059 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5061 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5062 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5064 2011-08-16 Ken Brown <kbrown@cornell.edu>
5066 Fix memory allocation problems in Cygwin build (Bug#9273).
5068 * unexcw.c ( __malloc_initialized): Declare external variable.
5069 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5071 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5073 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5075 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5077 [CYGWIN] (special_realloc): New function.
5078 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5079 requests to realloc storage in the static heap.
5081 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5083 * bidi.c (bidi_initialize): Remove unused local.
5085 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5088 * biditype.h: Remove file.
5089 * makefile.w32-in ($(BLD)/bidi.$(O)):
5090 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5092 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5094 * chartab.c: Improve commentary for the uniprop_table API.
5096 * bidi.c (bidi_paragraph_init): Support zero value of
5097 bidi_ignore_explicit_marks_for_paragraph_level.
5098 (bidi_initialize): Use uniprop_table instead of including
5099 biditype.h and bidimirror.h.
5101 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5102 coordinates of the iterator when restoring from ppos_it.
5105 2011-08-14 Kenichi Handa <handa@m17n.org>
5107 * process.c (create_process): Call setup_process_coding_systems
5108 after the pid of the process is set to -1 (Bug#8162).
5110 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5112 * xdisp.c (move_it_in_display_line_to): Don't invoke
5113 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5114 ppos_it. Fixes vertical cursor motion when line beginning is
5115 covered by an image. (Bug#9296)
5117 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5119 * nsterm.h (ns_run_ascript): Declare.
5120 (NSAPP_DATA2_RUNASSCRIPT): Define.
5122 * nsfns.m (as_script, as_result, as_status): New static variables.
5123 (ns_run_ascript): New function.
5124 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5125 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5126 the event loop. Get status from as_status (Bug#7276).
5128 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5129 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5130 the event loop (Bug#7276).
5132 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5134 * gnutls.c (QCgnutls_bootprop_priority)
5135 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5136 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5137 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5138 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5139 (QCgnutls_bootprop_verify_hostname_error)
5140 (QCgnutls_bootprop_callbacks_verify): Rename from
5141 Qgnutls_bootprop_..., all uses changed.
5143 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5146 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5148 * xfaces.c (Qframe_set_background_mode): Now static.
5149 * dispextern.h (Qframe_set_background_mode): Remove decl.
5151 * process.c (Fnetwork_interface_info): Declare local only if needed.
5153 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5155 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5156 (Fnetwork_interface_list): Allocate in increments of bytes instead
5157 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5158 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5160 (struct ifflag_def): notrailers is smart on OSX.
5161 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5162 Get hardware address with getifaddrs if available.
5164 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5166 * xdisp.c (iterate_out_of_display_property): xassert that
5167 IT->position is set to within IT->object's boundaries. Break from
5168 the loop as soon as EOB is reached; avoids infloops in redisplay
5169 when IT->position is set up wrongly due to some bug.
5170 Set IT->current to match the bidi iterator unconditionally.
5171 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5172 entry. Force push_it to save on the stack the current
5173 buffer/string position, to be restored by pop_it. Fix flags in
5174 the iterator structure wrt the object coming from a display
5175 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5176 properties. (Bug#9284)
5178 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5180 * fontset.c (fontset_get_font_group): Add proper type checks.
5183 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5185 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5186 and LC_VERSION_MIN_MACOSX.
5187 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5188 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5190 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5192 * xdisp.c (forward_to_next_line_start): Allow to use the
5193 no-display-properties-and-no-overlays under bidi display.
5194 Set disp_pos in the bidi iterator to avoid searches for display
5195 properties and overlays.
5197 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5199 * editfns.c (Fset_time_zone_rule): Document relationship with the
5202 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5203 the font entity extracted from the cache (Bug#8109).
5205 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5207 * composite.c (autocmp_chars): Don't reset point. That is done by
5208 restore_point_unwind (Bug#5984).
5210 2011-08-07 Juri Linkov <juri@jurta.org>
5212 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5213 to show the arg `TIME' instead of `TIMEVAL'.
5215 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5217 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5218 display property strides EOL and includes a newline, as in
5219 longlines-mode. (Bug#9254)
5220 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5221 word-wrap under bidirectional display. (Bug#9224)
5223 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5224 is non-zero, even if the data buffer is NULL. Fixes a crash in
5225 vertical-motion with longlines-mode. (Bug#9254)
5227 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5229 * bidi.c <bidi_cache_total_alloc>: Now static.
5230 (bidi_initialize): Initialize bidi_cache_total_alloc.
5232 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5235 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5236 amount allocated this far in `bidi_cache_total_alloc'.
5237 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5238 non-zero, only free the data buffer without restoring the cache
5239 contents. All callers changed.
5241 * dispextern.h (bidi_unshelve_cache): Update prototype.
5243 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5244 (move_it_in_display_line, move_it_to)
5245 (move_it_vertically_backward, move_it_by_lines): Replace the call
5246 to xfree to an equivalent call to bidi_unshelve_cache.
5247 (move_it_in_display_line_to): Fix logic of returning
5248 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5250 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5252 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5253 came from a string character with a `cursor' property. (Bug#9229)
5255 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5257 * Makefile.in (LIB_PTHREAD): New variable.
5258 (LIBES): Add LIB_PTHREAD (Bug#9216).
5260 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5261 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5263 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5265 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5267 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5269 * xterm.c (x_find_topmost_parent): New function.
5270 (x_set_frame_alpha): Find topmost parent window with
5271 x_find_topmost_parent and set the property there also (bug#9181).
5272 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5274 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5276 * callproc.c (Fcall_process): Avoid vfork clobbering
5277 the local vars buffer, coding_systems, current_dir.
5279 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5281 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5283 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5285 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5286 so that it is not optimized away.
5288 * xdisp.c (compute_display_string_pos): Remove unused local.
5290 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5292 Fix slow cursor motion and scrolling in large buffers with
5293 selective display, like Org Mode buffers. (Bug#9218)
5295 * dispextern.h (struct bidi_it): New member disp_prop_p.
5297 * xdisp.c: Remove one-slot cache of display string positions.
5298 (compute_display_string_pos): Accept an additional argument
5299 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5300 for a display string or property. If found, set DISP_PROP_P
5303 * bidi.c (bidi_fetch_char): Accept an additional argument
5304 DISP_PROP_P, and pass it to compute_display_string_pos.
5305 Only handle text covered by a display string if DISP_PROP_P is returned
5306 non-zero. All callers of bidi_fetch_char changed.
5308 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5310 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5312 2010-12-03 Don March <don@ohspite.net>
5314 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5315 last character M-[char] is translated to ESC [char] (bug#7541).
5317 2011-08-02 Kenichi Handa <handa@m17n.org>
5319 * lisp.h (uniprop_table): Extern it.
5321 * chartab.c (uniprop_table): Make it non-static.
5323 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5325 * xdisp.c (forward_to_next_line_start): Accept additional argument
5326 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5328 (reseat_at_next_visible_line_start): Use the bidi iterator state
5329 returned by forward_to_next_line_start to restore the state of
5330 it->bidi_it after backing up to previous newline. (Bug#9212)
5332 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5334 * regex.c (re_comp): Protoize.
5335 (re_exec): Fix return type.
5336 (regexec): Fix type of `ret'. (Bug#9203)
5338 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5340 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5341 This is needed if max-image-size is a floating-point number.
5343 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5345 * print.c (print_object): Print empty symbol as ##.
5347 * lread.c (read1): Read ## as empty symbol.
5349 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5351 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5352 setting frame foreground color (Bug#9175).
5353 (x_set_background_color): Likewise.
5355 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5356 contents (Bug#9176).
5357 (EmacsTooltip -init): Remove bezels and add shadows to
5360 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5361 or scroll bar (Bug#8470).
5363 * nsfont.m (nsfont_open): Remove assignment to voffset and
5364 unnecessary vars hshink, expand, hd, full_height, min_height.
5365 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5367 * nsterm.h (nsfont_info): Remove voffset field.
5369 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5371 Implement strike-through and overline on NextStep (Bug#8863).
5373 * nsfont.m (nsfont_open): Use underline position provided by font,
5374 instead of hard-coded value of 2.
5375 (nsfont_draw): Call ns_draw_text_decoration instead.
5377 * nsterm.h: Add declaration for ns_draw_text_decoration.
5379 * nsterm.m (ns_draw_text_decoration): New function for drawing
5380 underline, overline, and strike-through.
5381 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5382 ns_draw_text_decoration. Change treatment of cursor drawing to
5383 accommodate underlining, etc.
5385 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5387 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5390 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5392 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5393 Without this fix, if a signal arrives just after memory fills up,
5394 'malloc' might be invoked reentrantly.
5396 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5397 In other words, assume that every image size is allowed, on non-X
5398 hosts. This assumption is probably wrong, but it lets Emacs compile.
5400 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5402 * regex.c (re_iswctype): Convert return values to boolean.
5404 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5406 * xdisp.c (compute_display_string_pos): Don't use cached display
5407 string position if the buffer had its restriction changed.
5410 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5412 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5414 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5416 Integer signedness and overflow and related fixes. (Bug#9079)
5418 * bidi.c: Integer size and overflow fixes.
5419 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5420 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5421 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5422 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5423 (bidi_find_other_level_edge):
5424 Use ptrdiff_t instead of EMACS_INT where either will do.
5425 This works better on 32-bit hosts configured --with-wide-int.
5426 (bidi_cache_ensure_space): Check for size-calculation overflow.
5427 Use % rather than repeated addition, for better worst-case speed.
5428 Don't set bidi_cache_size until after xrealloc returns, because it
5430 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5431 (bidi_cache_ensure_space): Also check that the bidi cache size
5432 does not exceed that of the largest Lisp string or buffer. See Eli
5433 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5435 * alloc.c (__malloc_size_t): Remove.
5436 All uses replaced by size_t. See Andreas Schwab's note
5437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5439 * image.c: Improve checking for integer overflow.
5440 (check_image_size): Assume that f is nonnull, since
5441 it is always nonnull in practice. This is one less thing to
5442 worry about when checking for integer overflow later.
5443 (x_check_image_size): New function, which checks for integer
5444 overflow issues inside X.
5445 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5446 This removes the need for a memory_full check.
5447 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5448 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5449 (xbm_read_bitmap_data): Change locals back to 'int', since
5450 their values must fit in 'int'.
5451 (xpm_load_image, png_load, tiff_load):
5452 Invoke x_create_x_image_and_pixmap earlier,
5453 to avoid much needless work if the image is too large.
5454 (tiff_load): Treat overly large images as if
5455 x_create_x_image_and_pixmap failed, not as malloc failures.
5456 (gs_load): Use x_check_image_size.
5458 * gtkutil.c: Omit integer casts.
5459 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5460 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5462 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5464 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5465 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5466 would wrongly return t on a 64-bit host.
5468 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5469 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5470 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5471 and therefore cause GCC to emit a bogus diagnostic in some cases.
5473 * image.c: Integer signedness and overflow and related fixes.
5474 This is not an exhaustive set of fixes, but it's time to
5475 record what I've got.
5476 (lookup_pixel_color, check_image_size): Remove redundant decls.
5477 (check_image_size): Don't assume that arbitrary EMACS_INT values
5478 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5479 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5480 (tiff_load, imagemagick_load_image):
5481 Check for overflow in size calculations.
5482 (x_create_x_image_and_pixmap): Remove unnecessary test for
5483 xmalloc returning NULL; that can't happen.
5484 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5485 (xpm_color_bucket): Use better integer hashing function.
5486 (xpm_cache_color): Don't possibly over-allocate memory.
5487 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5488 (gif_memory_source):
5489 Use ptrdiff_t, not int or size_t, to record sizes.
5490 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5491 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5492 either works, as we prefer signed integers.
5493 (tiff_read_from_memory, tiff_write_from_memory):
5494 Return tsize_t, not size_t, since that's what the TIFF API wants.
5495 (tiff_read_from_memory): Don't fail simply because the read would
5496 go past EOF; instead, return a short read.
5497 (tiff_load): Omit no-longer-needed casts.
5498 (Fimagemagick_types): Don't assume size fits into 'int'.
5500 Improve hashing quality when configured --with-wide-int.
5501 * fns.c (hash_string): New function, taken from sxhash_string.
5502 Do not discard information about ASCII character case; this
5503 discarding is no longer needed.
5504 (sxhash-string): Use it. Change sig to match it. Caller changed.
5505 * lisp.h: Declare it.
5506 * lread.c (hash_string): Remove, since we now use fns.c's version.
5507 The fns.c version returns a wider integer if --with-wide-int is
5508 specified, so this should help the quality of the hashing a bit.
5510 * emacs.c: Integer overflow minor fix.
5511 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5512 Define only if GNU_LINUX.
5513 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5515 * dispnew.c: Integer signedness and overflow fixes.
5516 Remove unnecessary forward decls, that were a maintenance hassle.
5517 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5519 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5520 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5521 (prepare_desired_row, line_draw_cost):
5522 Use int, not unsigned, where either works.
5523 (save_current_matrix, restore_current_matrix):
5524 Use ptrdiff_t, not size_t, where either works.
5525 (init_display): Check for overflow more accurately, and without
5526 relying on undefined behavior.
5528 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5529 Remove, replacing with the new symbols in lisp.h. All uses changed.
5530 * fileio.c (make_temp_name):
5531 * filelock.c (lock_file_1, lock_file):
5532 * xdisp.c (message_dolog):
5533 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5534 Use pMd etc. instead.
5535 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5536 replacing the pWIDE etc. symbols removed from editfns.c.
5538 * keyboard.h (num_input_events): Now uintmax_t.
5539 This is (very slightly) less likely to mess up due to wraparound.
5542 * buffer.c: Integer signedness fixes.
5543 (alloc_buffer_text, enlarge_buffer_text):
5544 Use ptrdiff_t rather than size_t when either will do, as we prefer
5547 * alloc.c: Integer signedness and overflow fixes.
5548 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5549 (__malloc_size_t): Default to size_t, not to int.
5550 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5551 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5552 Prefer ptrdiff_t to size_t when either would do, as we prefer
5554 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5555 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5556 Now const. Initialize with values that are in range even if char
5558 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5559 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5560 These functions do the right thing with sizes > 2**32.
5561 (check_depth): Now ptrdiff_t, not int.
5562 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5563 Adjust to new way of storing sizes. Check for size overflow bugs
5565 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5566 slightly wrong anyway, as it missed one instance of
5567 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5568 (refill_memory_reserve): Omit needless cast to size_t.
5569 (mark_object_loop_halt): Mark as externally visible.
5571 * xselect.c: Integer signedness and overflow fixes.
5572 (Fx_register_dnd_atom, x_handle_dnd_message):
5573 Use ptrdiff_t, not size_t, since we prefer signed.
5574 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5575 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5576 x_dnd_atoms_size and x_dnd_atoms_length.
5578 * doprnt.c: Prefer signed to unsigned when either works.
5580 * doprnt.c (doprnt):
5582 * xdisp.c (vmessage):
5583 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5584 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5585 prefer signed arithmetic to avoid comparison confusion.
5586 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5587 but is a bit tricky.
5589 Assume freestanding C89 headers, string.h, stdlib.h.
5590 * data.c, doprnt.c, floatfns.c, print.c:
5591 Include float.h unconditionally.
5592 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5593 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5594 * regex.c: Likewise for stddef.h, string.h.
5595 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5596 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5597 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5598 (STDC_HEADERS): Remove obsolete defines.
5599 * sysdep.c: Include limits.h unconditionally.
5601 Assume support for memcmp, memcpy, memmove, memset.
5602 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5603 * regex.c (memcmp, memcpy):
5604 Remove; we assume C89 now.
5606 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5607 (__malloc_safe_bcopy): Remove; no longer needed.
5609 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5610 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5611 well either way, and we prefer signed to unsigned.
5613 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5615 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5616 closes the connection while we're reading (bug#9182).
5618 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5620 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5621 are specified (Bug#9168).
5623 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5625 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5626 Found by GCC static checking and --with-wide-int on a 32-bit host.
5628 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5630 * xdisp.c (compute_display_string_pos): Fix logic of caching
5631 previous display string position. Initialize cached_prev_pos to
5632 -1. Fixes slow-down at the beginning of a buffer.
5634 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5636 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5637 for attrs[LFACE_FONTSET_INDEX].
5639 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5641 * xml.c (parse_region): Remove unused local
5642 that was recently introduced.
5644 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5646 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5647 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5649 * xdisp.c (move_it_in_display_line_to): Record the best matching
5650 position for TO_CHARPOS while scanning the line, and restore it on
5651 exit if none of the characters scanned was an exact match.
5652 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5653 when exact match is impossible due to invisible text, and the
5654 lines are truncated.
5656 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5658 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5661 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5663 Fix a significant slow-down of cursor motion with C-n, C-p,
5664 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5665 auto-repeat under bidi redisplay in fontified buffers.
5666 * xdisp.c (compute_stop_pos_backwards): New function.
5667 (next_element_from_buffer): Call compute_stop_pos_backwards to
5668 find a suitable prev_stop when we find ourselves before
5670 (reseat): Don't look for prev_stop, as that could mean a very long
5672 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5673 <cached_disp_overlay_modiff>: Cache for last found display string
5675 (compute_display_string_pos): Return the cached position if asked
5676 about the same buffer in the same area of character positions, and
5677 the buffer wasn't changed since the time the display string
5678 position was cached.
5680 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5682 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5683 is an integer, which is important for empty lines. (Bug#9149)
5685 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5687 * frame.c (Fmodify_frame_parameters): In tty case, update the
5688 default face if necessary (Bug#4238).
5690 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5692 * editfns.c (Fstring_to_char): No need to explain what a character
5693 is in the docstring (Bug#6576).
5695 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5697 * xml.c (parse_region): Make sure we always return a tree.
5699 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5701 * xml.c (parse_region): If a document contains only comments,
5704 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5706 * xml.c (make_dom): Return comments, too.
5708 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5711 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5712 and the surrounding thread.
5713 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5714 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5715 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5717 * s/openbsd.h (BROKEN_SIGIO): Define.
5718 * unexelf.c (unexec) [__OpenBSD__]:
5719 Don't update the .mdebug section of the Alpha COFF symbol table.
5721 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5723 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5726 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5728 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5729 This fixes some race conditions on the permissions of any newly
5732 * alloc.c (valid_pointer_p): Use pipe, not open.
5733 This fixes some permissions issues when debugging.
5735 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5736 If fchown fails to set both uid and gid, try to set just gid,
5737 as that is sometimes allowed. Adjust the file's mode to eliminate
5738 setuid or setgid bits that are inappropriate if fchown fails.
5740 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5742 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5743 to compare Lisp_Objects.
5744 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5745 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5746 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5748 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5750 * lread.c (read_integer): Unread even EOF character.
5751 (read1): Likewise. Properly record start position of symbol.
5753 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5754 symbol character follows.
5756 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5758 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5759 This works around a problem with the previous change to Fcopy_file.
5760 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5761 and without this change, GCC might complain about discarding
5762 fchown's return value.
5764 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5766 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5768 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5770 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5772 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5774 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5775 it's used from the C level.
5777 * process.c: Use the same condition for POLL_FOR_INPUT in both
5778 keyboard.c and process.c (bug#1858).
5780 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5782 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5783 (Fgnutls_boot): Use it.
5785 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5787 * doc.c (Fsubstitute_command_keys): Revert last change.
5789 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5791 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5792 quotes the next character, and doesn't affect other longer
5793 sequences (bug#8935).
5795 * lread.c (syms_of_lread): Clarify that is isn't only
5796 `eval-buffer' and `eval-defun' that's affected by
5797 `lexical-binding' (bug#8460).
5799 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5801 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5802 bidi redisplay when a line includes both an image and is truncated.
5804 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5806 Fix minor problems found by static checking.
5807 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5808 (elsz): Now a signed constant, not a size_t var. We prefer signed
5809 types to unsigned, to avoid integer comparison confusion. Without
5810 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5811 "cannot optimize loop, the loop counter may overflow", a symptom
5813 * indent.c (Fvertical_motion): Mark locals as initialized.
5814 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5816 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5818 * search.c (Fre_search_backward): Mention `case-fold-search' in
5819 all the re_search_* functions (bug#8138).
5821 * keyboard.c (Fopen_dribble_file): Document when the file is
5824 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5826 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5829 Support bidi reordering of display and overlay strings.
5830 * xdisp.c (compute_display_string_pos)
5831 (compute_display_string_end): Accept additional argument STRING.
5832 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5833 (reseat_to_string): Initialize bidi_it->string.s and
5834 bidi_it->string.schars.
5835 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5836 NULL (avoids a crash in bidi_paragraph_init).
5837 Initialize itb.string.lstring.
5838 (init_iterator): Call bidi_init_it only of a valid
5839 buffer position was specified. Initialize paragraph_embedding to
5841 (reseat_to_string): Initialize the bidi iterator.
5842 (display_string): If we need to ignore text properties of
5843 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5844 original value of -1 will not work with bidi.)
5845 (compute_display_string_pos): First arg is now struct
5846 `text_pos *'; all callers changed. Support display properties on
5848 (compute_display_string_end): Support display properties on Lisp
5850 (init_iterator, reseat_1, reseat_to_string): Initialize the
5851 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5852 when iterating on a string not from display properties).
5853 (compute_display_string_pos, compute_display_string_end):
5854 Fix calculation of the object to scan. Fixes an error when using
5856 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5857 base_level_stop; instead, set base_level_stop to BEGV.
5858 Fixes crashes in vertical-motion.
5859 (next_element_from_buffer): Improve commentary for when
5860 the iterator is before prev_stop.
5861 (init_iterator): Initialize bidi_p from the default value of
5862 bidi-display-reordering, not from buffer-local value. Use the
5863 buffer-local value only if initializing for buffer iteration.
5864 (handle_invisible_prop): Support invisible properties on strings
5865 that are being bidi-reordered.
5866 (set_iterator_to_next): Support bidi reordering of C strings and
5868 (next_element_from_string): Support bidi reordering of Lisp
5870 (handle_stop_backwards): Support Lisp strings as well.
5871 (display_string): Support display of R2L glyph rows.
5872 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5873 (init_iterator): Don't initialize it->bidi_p for strings
5875 (reseat_to_string): Initialize it->bidi_p for strings here.
5876 (next_element_from_string, next_element_from_c_string)
5877 (next_element_from_buffer): Add xassert's for correspondence
5878 between IT's object being iterated and it->bidi_it.string
5880 (face_before_or_after_it_pos): Support bidi iteration.
5881 (next_element_from_c_string): Handle the case of the first string
5882 character that is not the first one in the visual order.
5883 (get_visually_first_element): New function, refactored from common
5884 parts of next_element_from_buffer, next_element_from_string, and
5885 next_element_from_c_string.
5886 (tool_bar_lines_needed, redisplay_tool_bar)
5887 (display_menu_bar): Force left-to-right direction. Add a FIXME
5888 comment for making that be controlled by a user option.
5889 (push_it, pop_it): Save and restore the state of the
5890 bidi iterator. Save and restore the bidi_p flag.
5891 (pop_it): Iterate out of display property for string iteration as
5893 (iterate_out_of_display_property): Support iteration over strings.
5894 (handle_single_display_spec): Set up it->bidi_it for iteration
5895 over a display string, and call bidi_init_it.
5896 (handle_single_display_spec, next_overlay_string)
5897 (get_overlay_strings_1, push_display_prop): Set up the bidi
5898 iterator for displaying display or overlay strings.
5899 (forward_to_next_line_start): Don't use the shortcut if
5901 (back_to_previous_visible_line_start): If handle_display_prop
5902 pushed the iterator stack, restore the internal state of the bidi
5903 iterator by calling bidi_pop_it same number of times.
5904 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5905 and we are bidi-iterating, don't decrement the iterator position;
5906 instead, set the first_elt flag in the bidi iterator, to produce
5908 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5909 (push_display_prop): xassert that we are iterating a buffer.
5910 (push_it, pop_it): Save and restore paragraph_embedding member.
5911 (handle_single_display_spec, next_overlay_string)
5912 (get_overlay_strings_1, reseat_1, reseat_to_string)
5913 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5914 correctly. Don't assume unibyte strings are not bidi-reordered.
5915 (compute_display_string_pos)
5916 (compute_display_string_end): Fix handling the case of C string.
5917 (push_it, pop_it): Save and restore from_disp_prop_p.
5918 (handle_single_display_spec, push_display_prop): Set the
5919 from_disp_prop_p flag.
5920 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5921 (pop_it): Call iterate_out_of_display_property only if we are
5922 popping after iteration over a string that came from a display
5923 property. Fix a typo in popping stretch info. Add an assertion
5924 for verifying that the iterator position is in sync with the bidi
5926 (handle_single_display_spec, get_overlay_strings_1)
5927 (push_display_prop): Fix initialization of paragraph direction for
5928 string when that of the parent object is not yet determined.
5929 (reseat_1): Call bidi_init_it to resync the bidi
5930 iterator with IT's position. (Bug#7616)
5931 (find_row_edges): If ROW->start.pos gives position
5932 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5933 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5934 Reset the from_disp_prop_p flag.
5935 (SAVE_IT, RESTORE_IT): New macros.
5936 (pos_visible_p, face_before_or_after_it_pos)
5937 (back_to_previous_visible_line_start)
5938 (move_it_in_display_line_to, move_it_in_display_line)
5939 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5940 (try_scrolling, redisplay_window, display_line): Use them when
5941 saving a temporary copy of the iterator and restoring it back.
5942 (back_to_previous_visible_line_start, reseat_1)
5943 (init_iterator): Empty the bidi cache "stack".
5944 (move_it_in_display_line_to): If iterator ended up at
5945 EOL, but we never saw any buffer positions smaller than
5946 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5947 motion in bidi-reordered lines.
5948 (move_it_in_display_line_to): Record prev_method and prev_pos
5949 immediately before the call to set_iterator_to_next. Fixes cursor
5950 motion in bidi-reordered lines with stretch glyphs and strings
5951 displayed in margins. (Bug#8133) (Bug#8867)
5952 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5954 (pos_visible_p): Support positions in bidi-reordered lines.
5955 Save and restore bidi cache.
5957 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5958 (bidi_paragraph_info): Delete unused struct.
5959 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5960 (bidi_cache_start): New variable.
5961 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5963 (bidi_cache_fetch_state, bidi_cache_search)
5964 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5965 (bidi_cache_find, bidi_peek_at_next_level)
5966 (bidi_level_of_next_char, bidi_find_other_level_edge)
5967 (bidi_move_to_visually_next): Compare cache index with
5968 bidi_cache_start rather than with zero.
5969 (bidi_fetch_char): Accept new argument STRING; all callers
5970 changed. Support iteration over a string. Support strings with
5971 display properties. Support unibyte strings. Fix the type of
5972 `len' according to what STRING_CHAR_AND_LENGTH expects.
5973 (bidi_paragraph_init, bidi_resolve_explicit_1)
5974 (bidi_resolve_explicit, bidi_resolve_weak)
5975 (bidi_level_of_next_char, bidi_move_to_visually_next):
5976 Support iteration over a string.
5977 (bidi_set_sor_type, bidi_resolve_explicit_1)
5978 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5979 can now be zero (for strings); special values 0 and -1 were
5980 changed to -1 and -2, respectively.
5981 (bidi_char_at_pos): New function.
5982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5983 Call it instead of FETCH_MULTIBYTE_CHAR.
5984 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5985 initialized to valid values.
5986 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5988 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5989 the test for valid cached positions. Fix the logic for looking up
5990 the sentinel state in the cache. GCPRO the Lisp string we are
5992 (bidi_push_it, bidi_pop_it): New functions.
5993 (bidi_initialize): Initialize the bidi cache start stack pointer.
5994 (bidi_cache_ensure_space): New function, refactored from part of
5995 bidi_cache_iterator_state. Don't assume the required size is just
5996 one BIDI_CACHE_CHUNK away.
5997 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5998 (bidi_count_bytes, bidi_char_at_pos): New functions.
5999 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6000 always valid if bidi_cache_idx is valid.
6001 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6002 is valid if it's going to be used.
6003 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6004 (bidi_cache_fetch_state, bidi_cache_search)
6005 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6006 (bidi_cache_iterator_state, bidi_cache_find)
6007 (bidi_find_other_level_edge, bidi_cache_start_stack):
6008 All variables related to cache indices are now EMACS_INT.
6010 * dispextern.h (struct bidi_string_data): New structure.
6011 (struct bidi_it): New member `string'. Make flag members be 1-bit
6012 fields, and put them last in the struct.
6013 (compute_display_string_pos, compute_display_string_end):
6015 (bidi_push_it, bidi_pop_it): Add prototypes.
6016 (struct iterator_stack_entry): New members bidi_p,
6017 paragraph_embedding, and from_disp_prop_p.
6018 (struct it): Member bidi_p is now a bit field 1 bit wide.
6019 (bidi_shelve_cache, bidi_unshelve_cache):
6022 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6023 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6024 and vector-like objects.
6026 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6027 cache around display iteration.
6029 * window.c (Fwindow_end, window_scroll_pixel_based)
6030 (displayed_window_lines, Frecenter): Save and restore the bidi
6031 cache around display iteration.
6033 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6035 * editfns.c (Fdelete_region): Clarify the use of the named
6036 parameters (bug#6788).
6038 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6040 * indent.c (Fvertical_motion): Set and restore w->pointm when
6041 saving and restoring the window's buffer (Bug#9006).
6043 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6045 * editfns.c (Fstring_to_char): Clarify just what is returned
6046 (bug#6576). Text by Eli Zaretskii.
6048 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6050 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6052 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6054 * buffer.c (mmap_find): Fix a typo.
6056 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6058 Fix execution of x selection hooks.
6059 * xselect.c (Qx_lost_selection_functions)
6060 (Qx_sent_selection_functions): New vars.
6061 (syms_of_xselect): DEFSYM them.
6062 (x_handle_selection_request): Pass Qx_sent_selection_functions
6063 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6064 (x_handle_selection_clear,x_clear_frame_selections):
6065 Pass Qx_lost_selection_functions rather than
6066 Vx_lost_selection_functions to Frun_hook_with_args.
6068 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6070 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6071 The old code sometimes used this field without initializing it.
6073 * alloc.c (gc_sweep): Don't read past end of array.
6074 In theory, the old code could also have corrupted Emacs internals,
6075 though it'd be very unlikely.
6077 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6079 * character.c (Fcharacterp): Don't advertise optional ignored
6080 argument. (Bug#4026)
6082 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6084 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6087 * window.c (Fset_window_start): Doc fix (bug#4199).
6088 (Fset_window_hscroll): Ditto.
6090 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6092 Fix minor new problems caught by GCC 4.6.1.
6093 * term.c (init_tty): Remove unused local.
6094 * xsettings.c (store_monospaced_changed): Define this function only
6095 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6098 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6100 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6102 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6104 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6105 are the mini-buffer and the echo area (bug#3320).
6107 * term.c (init_tty): Remove support for supdup, c10 and perq
6108 terminals, which are no longer supported (bug#1482).
6110 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6112 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6114 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6116 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6117 for non-popups (Bug#3642).
6119 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6121 * alloc.c (reset_malloc_hooks): Protoize.
6122 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6123 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6124 * cm.c (losecursor): Likewise.
6125 * data.c (fmod): Likewise.
6126 * dispnew.c (swap_glyphs_in_rows): Likewise.
6127 * emacs.c (memory_warning_signal): Likewise.
6128 * floatfns.c (float_error): Likewise.
6129 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6130 (otf_open, font_otf_capability, generate_otf_features)
6131 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6133 * image.c (pbm_read_file): Likewise.
6134 * indent.c (string_display_width): Likewise.
6135 * intervals.c (check_for_interval, search_for_interval)
6136 (inc_interval_count, count_intervals, root_interval)
6137 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6138 * lread.c (defalias): Likewise.
6139 * ralloc.c (r_alloc_check): Likewise.
6140 * regex.c (set_image_of_range_1, set_image_of_range)
6141 (regex_grow_registers): Likewise.
6142 * sysdep.c (strerror): Likewise.
6143 * termcap.c (valid_filename_p, tprint, main): Likewise.
6144 * tparam.c (main): Likewise.
6145 * unexhp9k800.c (run_time_remap, save_data_space)
6146 (update_file_ptrs, read_header, write_header, calculate_checksum)
6147 (copy_file, copy_rest, display_header): Likewise.
6148 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6150 * xdisp.c (check_it): Likewise.
6151 * xfaces.c (register_color, unregister_color, unregister_colors):
6153 * xfns.c (print_fontset_result): Likewise.
6154 * xrdb.c (member, fatal, main): Likewise.
6156 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6158 Fix minor problems found by static checking (Bug#9031).
6159 * chartab.c (char_table_set_range, map_sub_char_table):
6160 Remove unused locals.
6161 (uniprop_table): Now static.
6162 * composite.c (_work_char): Remove unused static var.
6164 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6166 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6168 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6170 * gtkutil.c (qttip_cb): Remove code without function.
6172 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6174 * w32.c (pthread_sigmask): New stub.
6176 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6178 Use pthread_sigmask, not sigprocmask (Bug#9010).
6179 sigprocmask is portable only for single-threaded applications, and
6180 Emacs can be multi-threaded when it uses GTK.
6181 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6183 * callproc.c (Fcall_process):
6184 * process.c (create_process):
6185 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6186 Use pthread_sigmask, not sigprocmask.
6188 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6190 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6191 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6194 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6196 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6197 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6198 (xg_hide_tooltip): Fix comment.
6200 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6201 in registerServicesMenuSendTypes.
6202 (validRequestorForSendType): Don't check ns_return_types.
6204 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6207 2011-07-08 Jason Rumney <jasonr@gnu.org>
6209 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6210 SH_SHOW for hidden windows (Bug#5482).
6212 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6213 frame struct members of non-existent frames (Bug#6284).
6215 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6217 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6218 variable firstTime not needed on OSX >= 10.6.
6219 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6220 >= 10.5. Use setKnobProportion, setDoubleValue.
6222 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6223 (MAC_OS_X_VERSION_10_5): Define if not defined.
6224 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6225 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6226 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6228 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6229 cString and lossyCString on OSX >= 10.4
6231 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6232 sizeToFit on OSX >= 10.2.
6234 * nsimage.m (allocInitFromFile): Don't use deprecated method
6235 bestRepresentationForDevice on OSX >= 10.6.
6237 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6240 * emacs.c: Declare unexec_init_emacs_zone.
6242 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6244 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6246 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6247 on svcsMenu (Bug#8842).
6249 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6251 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6253 * nsterm.m (QUTF8_STRING): Declare.
6254 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6255 (validRequestorForSendType): Return type is (id).
6256 Change indexOfObjectIdenticalTo to indexOfObject.
6257 Check if we have local selection before returning self (Bug#8842).
6258 (writeSelectionToPasteboard): Put local selection into paste board
6259 if we have a local selection (Bug#8842).
6260 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6262 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6263 (ns_get_local_selection): Declare.
6265 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6267 * keymap.c (describe_map_tree): Don't insert a double newline at
6268 the end of the buffer (bug#1169) and return whether we inserted
6271 * callint.c (Fcall_interactively): Change "reading args" to
6272 "providing args" to try to clarify what it does (bug#1010).
6274 2011-07-07 Kenichi Handa <handa@m17n.org>
6276 * composite.c (composition_compute_stop_pos): Ignore a static
6277 composition starting before CHARPOS (Bug#8915).
6279 * xdisp.c (handle_composition_prop): Likewise.
6281 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6283 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6286 2011-07-07 Kenichi Handa <handa@m17n.org>
6288 * character.h (unicode_category_t): New enum type.
6290 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6291 (Qchar_code_property_table): New variable.
6292 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6293 (UNIPROP_COMPRESSED_FORM_P): New macros.
6294 (char_table_ascii): Uncompress the compressed values.
6295 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6296 Uncompress the compressed values.
6297 (sub_char_table_ref_and_range): Likewise.
6298 (char_table_ref_and_range): Uncompress the compressed values.
6299 (sub_char_table_set): New arg is_uniprop. Callers changed.
6300 Uncompress the compressed values.
6301 (sub_char_table_set_range): Args changed. Callers changed.
6302 (char_table_set_range): Adjuted for the above change.
6303 (map_sub_char_table): Delete args default_val and parent. Add arg
6304 top. Give decoded values to a Lisp function.
6305 (map_char_table): Adjust for the above change. Give decoded
6306 values to a Lisp function. Gcpro more variables.
6307 (uniprop_table_uncompress)
6308 (uniprop_decode_value_run_length): New functions.
6309 (uniprop_decoder, uniprop_decoder_count): New variables.
6310 (uniprop_get_decoder, uniprop_encode_value_character)
6311 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6313 (uniprop_encoder, uniprop_encoder_count): New variables.
6314 (uniprop_get_encoder, uniprop_table)
6315 (Funicode_property_table_internal, Fget_unicode_property_internal)
6316 (Fput_unicode_property_internal): New functions.
6317 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6318 Sunicode_property_table_internal, Sget_unicode_property_internal,
6319 and Sput_unicode_property_internal. Defvar_lisp
6320 char-code-property-alist.
6322 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6323 Vunicode_category_table.
6325 * font.c (font_range): Adjust for the change of
6326 Vunicode_category_table.
6328 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6330 * m/iris4d.h: Remove file, move contents ...
6331 * s/irix6-5.h: ... here.
6333 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6335 Remove unportable assumption about struct layout (Bug#8884).
6336 * alloc.c (mark_buffer):
6337 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6338 (clone_per_buffer_values): Don't assume that
6339 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6340 This isn't true in general, and it's particularly not true
6341 if Emacs is configured with --with-wide-int.
6342 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6343 New macros, used in the buffer.c change.
6345 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6347 * xsettings.c: Use both GConf and GSettings if both are available.
6348 (store_config_changed_event): Add comment.
6349 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6350 (store_tool_bar_style_changed): New functions.
6351 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6352 (struct xsettings): Move font inside HAVE_XFT.
6353 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6354 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6355 Move inside HAVE_XFT.
6356 (something_changed_gsettingsCB): Rename from something_changedCB.
6357 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6359 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6360 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6361 (something_changed_gconfCB): Rename from something_changedCB.
6362 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6363 (parse_settings): Move check for font inside HAVE_XFT.
6364 (read_settings, apply_xft_settings): Add comment.
6365 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6366 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6367 call store_font_name_changed.
6368 (xft_settings_event): Add comment.
6369 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6370 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6371 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6372 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6373 (xsettings_initialize): Call init_gsettings last.
6374 (xsettings_get_system_font, xsettings_get_system_normal_font):
6377 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6379 Random fixes. E.g., (random) never returned negative values.
6380 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6381 subseconds part to the entropy, as that's a bit more random.
6382 Prefer signed to unsigned, since the signedness doesn't matter and
6383 in general we prefer signed. When given a limit, use a
6384 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6385 latter isn't right if USE_2_TAGS_FOR_INTS.
6386 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6387 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6389 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6391 * textprop.c (text_property_stickiness):
6392 Obey Vtext_property_default_nonsticky.
6393 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6394 * w32fns.c (syms_of_w32fns):
6395 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6397 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6399 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6400 This is more efficient than Ffile_directory_p and avoids a minor race.
6402 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6404 * buffer.c (Foverlay_put): Say what the return value is
6407 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6408 is a directory before asking whether to use the file name
6410 (barf_or_query_if_file_exists): Make the "File is a directory"
6411 error be more correct.
6413 * fns.c (Frequire): Remove the mention of the .gz files, since
6414 that's installation-specific, but keep the mention of
6415 `get-load-suffixes'.
6417 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6419 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6420 Report string overflow if the output is too long.
6422 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6424 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6425 (syms_of_gnutls): Remove duplicate DEFSYM for
6426 Qgnutls_bootprop_verify_hostname_error, an error for
6427 Qgnutls_bootprop_verify_error (which is no longer used).
6429 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6430 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6431 Also (re)move comments that are misplaced or no longer relevant.
6433 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6435 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6437 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6439 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6440 and background color parameters if they have been changed.
6442 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6444 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6446 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6448 * xsettings.c (SYSTEM_FONT): Define only when used.
6449 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6451 * keymap.c (access_keymap_1): Now static.
6453 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6455 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6456 leave any prefix arg for the up event (Bug#1586).
6458 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6460 * lread.c (syms_of_lread): Mention single symbols defined by
6461 `defvar' or `defconst' (bug#7154).
6463 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6464 (Frequire): Mention get-load-suffixes.
6466 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6468 * window.h (window): Remove clone_number slot.
6469 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6471 (make_parent_window, make_window, saved_window)
6472 (Fset_window_configuration, save_window_save): Don't deal with
6474 * buffer.c (Qclone_number): Remove declaration.
6475 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6477 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6479 Add multiple inheritance to keymaps.
6480 * keymap.c (Fmake_composed_keymap): New function.
6481 (Fset_keymap_parent): Simplify.
6482 (fix_submap_inheritance): Remove.
6483 (access_keymap_1): New function extracted from access_keymap to handle
6484 embedded parents and handle lists of maps.
6485 (access_keymap): Use it.
6486 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6487 (Fcopy_keymap): Handle embedded parents.
6488 (Fcommand_remapping, define_as_prefix): Simplify.
6489 (Fkey_binding): Simplify.
6490 (syms_of_keymap): Move minibuffer-local-completion-map,
6491 minibuffer-local-filename-completion-map,
6492 minibuffer-local-must-match-map, and
6493 minibuffer-local-filename-must-match-map to Elisp.
6494 (syms_of_keymap): Defsubr make-composed-keymap.
6495 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6496 (parse_menu_item): Trivial simplification.
6498 2011-07-01 Glenn Morris <rgm@gnu.org>
6500 * Makefile.in (SETTINGS_LIBS): Fix typo.
6502 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6504 * coding.c (Fencode_coding_string): Record the last coding system
6505 used, as the function doc string says (bug#8738).
6507 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6509 * xsettings.c (store_monospaced_changed): Take new font as arg and
6510 check for change against current_mono_font.
6511 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6512 (emacs_settings_constructor, emacs_settings_get_property)
6513 (emacs_settings_set_property, emacs_settings_class_init)
6514 (emacs_settings_init, gsettings_obj): Remove.
6515 (something_changedCB): New function for HAVE_GSETTINGS.
6516 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6517 with value as argument.
6518 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6519 g_settings_new (Bug#8967). Do not create gsettings_obj.
6520 Remove calls to g_settings_bind. Connect something_changedCB to
6523 * xgselect.c: Add defined (HAVE_GSETTINGS).
6524 (xgselect_initialize): Ditto.
6526 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6527 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6530 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6532 * eval.c (struct backtrace): Simplify and port the data structure.
6533 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6534 signed bit field, as this assumption is not portable and it makes
6535 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6536 "char debug_on_exit : 1" as this is not portable either; instead,
6537 use the portable "unsigned int debug_on_exit : 1". Remove unused
6538 member evalargs. Remove obsolete comments about cc bombing out.
6540 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6542 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6543 Let HAVE_GSETTINGS override HAVE_GCONF.
6544 (store_monospaced_changed): New function.
6545 (EMACS_SETTINGS): A new type derived from GObject to handle
6546 GSettings notifications.
6547 (emacs_settings_constructor, emacs_settings_get_property)
6548 (emacs_settings_set_property, emacs_settings_class_init):
6550 (gsettings_client, gsettings_obj): New variables.
6551 (GSETTINGS_SCHEMA): New define.
6552 (something_changedCB): Call store_monospaced_changed.
6553 (init_gsettings): New function.
6554 (xsettings_initialize): Call init_gsettings.
6555 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6558 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6561 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6563 * window.c (resize_root_window, grow_mini_window)
6564 (shrink_mini_window): Rename Qresize_root_window to
6565 Qwindow_resize_root_window and Qresize_root_window_vertically to
6566 Qwindow_resize_root_window_vertically.
6568 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6570 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6572 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6574 * makefile.w32-in: Redesign dependencies so they reflect more
6575 clearly which files are directly included by each source file,
6576 and not through other includes.
6578 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6580 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6581 (sort_overlays, overlay_strings): When an overlay's clone number
6582 matches the window's clone number process the overlay even if
6583 the overlay's window property doesn't match the current window.
6585 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6586 (Fwindow_hchild): Rename to Fwindow_left_child.
6587 (Fwindow_next): Rename to Fwindow_next_sibling.
6588 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6589 (resize_window_check): Rename to window_resize_check.
6590 (resize_window_apply): Rename to window_resize_apply.
6591 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6592 (Fdelete_other_windows_internal, resize_frame_windows)
6593 (Fsplit_window_internal, Fdelete_window_internal)
6594 (grow_mini_window, shrink_mini_window)
6595 (Fresize_mini_window_internal): Fix callers accordingly.
6597 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6599 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6600 (emacs_fixed_set_min_size): Remove.
6601 (emacs_fixed_new): Take frame as argument.
6603 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6604 (_EmacsFixedPrivate): Remove minwidth/height.
6605 Add struct frame *f.
6606 (emacs_fixed_init): Initialize priv->f.
6607 (get_parent_class, emacs_fixed_set_min_size): Remove.
6608 (emacs_fixed_new): Set priv->f to argument.
6609 (emacs_fixed_get_preferred_width)
6610 (emacs_fixed_get_preferred_height): Use min_width/height from
6611 frames size_hint to set minimum and natural (Bug#8919).
6612 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6613 and use min_width/height from frames size_hint to set
6614 min_width/height (Bug#8919).
6616 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6617 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6620 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6622 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6623 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6626 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6628 * process.c (wait_reading_process_output): Bypass select if
6629 waiting for a cell while ignoring keyboard input, and input is
6630 pending. Suggested by Jan Djärv (Bug#8869).
6632 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6634 Use gnulib's dup2 module instead of rolling our own.
6635 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6637 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6639 * dispnew.c (scrolling_window): Before scrolling, turn off a
6640 mouse-highlight in the window being scrolled.
6642 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6644 Move DEFSYM to lisp.h and use everywhere.
6646 * character.h (DEFSYM): Move declaration...
6647 * lisp.h (DEFSYM): ...here.
6653 * w32select.c: Don't include character.h.
6655 * alloc.c (syms_of_alloc):
6656 * buffer.c (syms_of_buffer):
6657 * bytecode.c (syms_of_bytecode):
6658 * callint.c (syms_of_callint):
6659 * casefiddle.c (syms_of_casefiddle):
6660 * casetab.c (init_casetab_once):
6661 * category.c (init_category_once, syms_of_category):
6662 * ccl.c (syms_of_ccl):
6663 * cmds.c (syms_of_cmds):
6664 * composite.c (syms_of_composite):
6665 * dbusbind.c (syms_of_dbusbind):
6666 * dired.c (syms_of_dired):
6667 * dispnew.c (syms_of_display):
6668 * doc.c (syms_of_doc):
6669 * editfns.c (syms_of_editfns):
6670 * emacs.c (syms_of_emacs):
6671 * eval.c (syms_of_eval):
6672 * fileio.c (syms_of_fileio):
6673 * fns.c (syms_of_fns):
6674 * frame.c (syms_of_frame):
6675 * fringe.c (syms_of_fringe):
6676 * insdel.c (syms_of_insdel):
6677 * keymap.c (syms_of_keymap):
6678 * lread.c (init_obarray, syms_of_lread):
6679 * macros.c (syms_of_macros):
6680 * msdos.c (syms_of_msdos):
6681 * print.c (syms_of_print):
6682 * process.c (syms_of_process):
6683 * search.c (syms_of_search):
6684 * sound.c (syms_of_sound):
6685 * syntax.c (init_syntax_once, syms_of_syntax):
6686 * terminal.c (syms_of_terminal):
6687 * textprop.c (syms_of_textprop):
6688 * undo.c (syms_of_undo):
6689 * w32.c (globals_of_w32):
6690 * window.c (syms_of_window):
6691 * xdisp.c (syms_of_xdisp):
6692 * xfaces.c (syms_of_xfaces):
6693 * xfns.c (syms_of_xfns):
6694 * xmenu.c (syms_of_xmenu):
6695 * xsettings.c (syms_of_xsettings):
6696 * xterm.c (syms_of_xterm): Use DEFSYM.
6698 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6700 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6702 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6704 Integer and buffer overflow fixes (Bug#8873).
6706 * print.c (printchar, strout): Check for string overflow.
6707 (PRINTPREPARE, printchar, strout):
6708 Don't set size unless allocation succeeds.
6710 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6711 for sizes. Check for string overflow more accurately.
6712 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6714 * macros.c: Integer and buffer overflow fixes.
6715 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6716 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6717 Use ptrdiff_t, not int, for sizes.
6718 Don't increment bufsize until after realloc succeeds.
6719 Check for size-calculation overflow.
6720 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6722 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6724 * lread.c: Integer overflow fixes.
6725 (read_integer): Radix is now EMACS_INT, not int,
6726 to improve quality of diagnostics for out-of-range radices.
6727 Calculate buffer size correctly for out-of-range radices.
6728 (read1): Check for integer overflow in radices, and in
6729 read-circle numbers.
6730 (read_escape): Avoid int overflow.
6731 (Fload, openp, read_buffer_size, read1)
6732 (substitute_object_recurse, read_vector, read_list, map_obarray):
6733 Use ptrdiff_t, not int, for sizes.
6734 (read1): Use EMACS_INT, not int, for sizes.
6735 Check for size overflow.
6737 * image.c (cache_image): Check for size arithmetic overflow.
6739 * lread.c: Integer overflow issues.
6740 (saved_doc_string_size, saved_doc_string_length)
6741 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6742 Now ptrdiff_t, not int.
6743 (read1): Don't assume doc string length fits in int. Check for
6744 out-of-range doc string lengths.
6745 (read_list): Don't assume file position fits in int.
6746 (read_escape): Check for hex character overflow.
6748 2011-06-22 Leo Liu <sdl.web@gmail.com>
6750 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6751 Move to minibuffer.el.
6753 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6755 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6756 The following patches are for when GLYPH_DEBUG && !XASSERT.
6757 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6758 * dispnew.c (flush_stdout):
6759 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6760 Mark as externally visible.
6761 * dispnew.c (check_window_matrix_pointers): Now static.
6762 * dispnew.c (window_to_frame_vpos):
6763 * xfns.c (unwind_create_frame):
6764 * xterm.c (x_check_font): Remove unused local.
6765 * scroll.c (CHECK_BOUNDS):
6766 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6767 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6768 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6769 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6770 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6772 (debug_method_add): Use va_list and vsprintf rather than relying
6773 on undefined behavior with wrong number of arguments.
6774 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6775 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6776 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6777 since we're not interested in debugging glyphs with old libraries.
6778 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6779 GCC 4.6.0's static checking.
6781 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6783 Integer overflow and signedness fixes (Bug#8873).
6784 A few related buffer overrun fixes, too.
6786 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6788 * dispextern.h (struct face.stipple):
6789 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6790 (x_bitmap_mask, x_allocate_bitmap_record)
6791 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6792 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6793 (x_create_bitmap_from_xpm_data):
6794 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6795 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6797 * xfaces.c (load_pixmap):
6798 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6799 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6800 (.bitmaps_last, struct x_output.icon_bitmap):
6801 Use ptrdiff_t, not int, for bitmap indexes.
6802 (x_allocate_bitmap_record): Check for size overflow.
6803 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6805 Use ptrdiff_t, not int, for overlay counts.
6806 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6807 * editfns.c (overlays_around, get_pos_property):
6808 * textprop.c (get_char_property_and_overlay):
6809 * xdisp.c (next_overlay_change, note_mouse_highlight):
6810 * xfaces.c (face_at_buffer_position):
6811 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6812 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6813 (Fnext_overlay_change, Fprevious_overlay_change)
6814 (mouse_face_overlay_overlaps, Foverlays_in):
6815 Use ptrdiff_t, not int, for sizes.
6816 (overlays_at, overlays_in): Check for size-calculation overflow.
6818 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6820 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6821 (x_session_initialize): Do not assume string length fits in int.
6823 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6824 This is unlikely, but can occur if DPI is outlandish.
6826 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6827 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6829 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6830 * xrdb.c (magic_file_p, search_magic_path):
6831 Omit last arg SUFFIX; it was always 0. All callers changed.
6832 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6834 * xfont.c (xfont_match): Avoid need for strlen.
6836 * xfns.c: Don't assume strlen fits in int.
6837 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6839 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6840 not unsigned long, as we prefer signed integers. All callers changed.
6841 Detect integer overflow in repeat count.
6842 (message_dolog): Don't assume print length fits in 39 bytes.
6843 (display_mode_element): Don't assume strlen fits in int.
6845 * termcap.c: Don't assume sizes fit in int and never overflow.
6846 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6847 (gobble_line): Check for size-calculation overflow.
6849 * minibuf.c (Fread_buffer):
6850 * lread.c (intern, intern_c_string):
6851 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6852 Don't assume string length fits in int.
6854 * keyboard.c (parse_tool_bar_item):
6855 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6857 * font.c: Don't assume string length fits in int.
6858 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6859 Use ptrdiff_t, not int.
6860 (font_intern_prop): Don't assume string length fits in int.
6861 Don't assume integer property fits in fixnum.
6862 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6864 * filelock.c: Fix some buffer overrun and integer overflow issues.
6865 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6866 Reformulate so as not to need the command string.
6867 Invoke gzip -cd rather than gunzip, as it's more portable.
6868 (lock_info_type, lock_file_1, lock_file):
6869 Don't assume pid_t and time_t fit in unsigned long.
6870 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6871 (current_lock_owner): Prefer signed type for sizes.
6872 Use memcpy, not strncpy, where memcpy is what is really wanted.
6873 Don't assume (via atoi) that time_t and pid_t fit in int.
6874 Check for time_t and/or pid_t out of range, e.g., via a network share.
6875 Don't alloca where an auto var works fine.
6877 * fileio.c: Fix some integer overflow issues.
6878 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6879 Don't assume string length fits in int.
6880 (directory_file_name): Don't assume string length fits in long.
6881 (make_temp_name): Don't assume pid fits in int, or that its print
6882 length is less than 20.
6884 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6886 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6888 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6890 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6891 We prefer signed integers, even for size calculations.
6893 * emacs.c: Don't assume string length fits in 'int'.
6894 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6895 (main): Don't invoke strlen when not needed.
6897 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6898 (XD_DEBUG_MESSAGE): Don't waste a byte.
6900 * callproc.c (getenv_internal_1, getenv_internal)
6902 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6904 * lread.c (invalid_syntax): Omit length argument.
6905 All uses changed. This doesn't fix a bug, but it simplifies the
6906 code away from its former Hollerith-constant appearance, and it's
6907 one less 'int' to worry about when looking at integer-overflow issues.
6908 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6910 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6911 This didn't break anything, but it didn't help either.
6912 It's confusing to put a bogus integer in a place where the actual
6913 value does not matter.
6914 (LIST_END_P): Remove unused macro and its bogus comment.
6915 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6917 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6918 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6920 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6921 We prefer signed types, and the value cannot exceed the EMACS_INT
6922 range anyway (because otherwise the length would not be representable).
6923 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6924 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6925 This avoids a GCC warning when WIDE_EMACS_INT.
6927 * indent.c (sane_tab_width): New function.
6928 (current_column, scan_for_column, Findent_to, position_indentation)
6929 (compute_motion): Use it. This is just for clarity.
6930 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6932 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6934 * lisp.h (lint_assume): New macro.
6935 * composite.c (composition_gstring_put_cache):
6936 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6938 * editfns.c, insdel.c:
6939 Omit unnecessary forward decls, to simplify future changes.
6941 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6943 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6945 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6946 Use much-faster test for byte-length change.
6947 Don't assume string byte-length fits in 'int'.
6948 Check that character arg fits in 'int'.
6949 (mapcar1): Declare byte as byte, for clarity.
6951 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6953 * fns.c (concat): Catch string overflow earlier.
6954 Do not rely on integer wraparound.
6956 * dispextern.h (struct it.overlay_strings_charpos)
6957 (struct it.selective): Now EMACS_INT, not int.
6958 * xdisp.c (forward_to_next_line_start)
6959 (back_to_previous_visible_line_start)
6960 (reseat_at_next_visible_line_start, next_element_from_buffer):
6961 Don't arbitrarily truncate the value of 'selective' to int.
6963 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6965 * composite.c: Don't truncate sizes to 'int'.
6966 (composition_gstring_p, composition_reseat_it)
6967 (composition_adjust_point): Use EMACS_INT, not int.
6968 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6969 not EMACS_UINT, for indexes.
6971 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6973 * buffer.c: Include <verify.h>.
6974 (struct sortvec.priority, struct sortstr.priority):
6975 Now EMACS_INT, not int.
6976 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6977 (struct sortstr.size, record_overlay_string)
6978 (struct sortstrlist.size, struct sortlist.used):
6979 Don't truncate size to int.
6980 (record_overlay_string): Check for size-calculation overflow.
6981 (init_buffer_once): Check at compile-time, not run-time.
6983 2011-06-22 Jim Meyering <meyering@redhat.com>
6985 Don't leak an XBM-image-sized buffer
6986 * image.c (xbm_load): Free the image buffer after using it.
6988 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6991 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6992 that Sun C diagnosed.
6993 * fns.c (secure_hash): Fix pointer signedness issue.
6994 * intervals.c (static_offset_intervals): New function.
6995 (offset_intervals): Use it.
6997 2011-06-21 Leo Liu <sdl.web@gmail.com>
7000 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7003 * fns.c (secure_hash): Rename from crypto_hash_function and change
7004 the first arg to accept symbols.
7005 (Fsecure_hash): New primitive.
7006 (syms_of_fns): New symbols.
7008 2011-06-20 Deniz Dogan <deniz@dogan.se>
7010 * process.c (Fset_process_buffer): Clarify return value in
7013 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7015 * dispnew.c (add_window_display_history): Use BVAR.
7017 * xdisp.c (debug_method_add): Use BVAR.
7018 (check_window_end, dump_glyph_matrix, dump_glyph)
7019 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7021 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7024 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7025 check till after the cache is created in init_frame_faces.
7027 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7029 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7031 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7033 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7034 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7035 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7037 Improve buffer-overflow checking (Bug#8873).
7038 * fileio.c (Finsert_file_contents):
7039 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7040 Remove the old (too-loose) buffer overflow checks.
7041 They weren't needed, since make_gap checks for buffer overflow.
7042 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7043 The old code merely checked for Emacs fixnum overflow, and relied
7044 on undefined (wraparound) behavior. The new code avoids undefined
7045 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7047 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7048 Tune. Don't use wider integers than needed. Don't use alloca.
7049 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7051 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7053 * insdel.c, lisp.h (buffer_overflow): New function.
7054 (insert_from_buffer_1, replace_range, replace_range_2):
7055 * insdel.c (make_gap_larger):
7056 * editfns.c (Finsert_char):
7057 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7059 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7061 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7063 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7065 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7066 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7068 * fileio.c: Don't assume EMACS_INT fits in off_t.
7069 (emacs_lseek): New static function.
7070 (Finsert_file_contents, Fwrite_region): Use it.
7071 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7073 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7075 * fns.c: Don't overflow int when computing a list length.
7076 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7077 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7078 truncation on 64-bit hosts. Check for QUIT every
7079 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7080 faster and is responsive enough.
7081 (Flength): Report an error instead of overflowing an integer.
7082 (Fsafe_length): Return a float if the value is not representable
7083 as a fixnum. This shouldn't happen except in contrived situations.
7084 (Fnthcdr, Fsort): Don't assume list length fits in int.
7085 (Fcopy_sequence): Don't assume vector length fits in int.
7087 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7088 (header_size, word_size): New constants.
7089 (allocate_vectorlike): Don't check size overflow here.
7090 (allocate_vector): Check it here instead, since this is the only
7091 caller of allocate_vectorlike that could cause overflow.
7092 Check that the new vector's length is representable as a fixnum.
7094 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7095 The previous code was bogus. For example, next_almost_prime (32)
7096 returned 39, which is undesirable as it is a multiple of 3; and
7097 next_almost_prime (24) returned 25, which is a multiple of 5 so
7098 why was the code bothering to check for multiples of 7?
7100 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7102 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7104 Variadic C functions now count arguments with ptrdiff_t.
7105 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7106 Back then I didn't know that the Emacs coding style prefers signed int.
7107 Also, in the meantime I found a few more instances where arguments
7108 were being counted with int, which may truncate counts on 64-bit
7109 machines, or EMACS_INT, which may be unnecessarily wide.
7110 * lisp.h (struct Lisp_Subr.function.aMANY)
7111 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7112 Arg counts are now ptrdiff_t, not size_t.
7113 All variadic functions and their callers changed accordingly.
7114 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7115 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7116 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7117 * callint.c (Fcall_interactively): Check arg count for overflow,
7118 to avoid potential buffer overrun. Use signed char, not 'int',
7119 for 'varies' array, so that we needn't bother to check its size
7120 calculation for overflow.
7121 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7122 * eval.c (apply_lambda):
7123 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7124 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7125 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7127 * callint.c (Fcall_interactively): Don't use index var as event count.
7129 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7130 * mem-limits.h (SIZE): Remove; no longer used.
7132 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7134 Remove unnecessary casts.
7135 * xterm.c (x_term_init):
7136 * xfns.c (x_set_border_pixel):
7137 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7138 These aren't needed now that we assume ANSI C.
7140 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7141 It's more likely to cause problems (due to unsigned overflow)
7144 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7146 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7148 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7150 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7152 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7154 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7156 GLYPH_CODE_FACE returns EMACS_INT, not int.
7157 * dispextern.h (merge_faces):
7158 * xfaces.c (merge_faces):
7159 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7160 Don't assume EMACS_INT fits in int.
7162 * character.h (CHAR_VALID_P): Remove unused parameter.
7163 * fontset.c, lisp.h, xdisp.c: All uses changed.
7165 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7167 * fns.c (concat): Minor tuning based on overflow analysis.
7168 This doesn't fix any bugs. Use int to hold character, instead
7169 of constantly refetching from Emacs object. Use XFASTINT, not
7170 XINT, for value known to be a character. Don't bother comparing
7171 a single byte to 0400, as it's always less.
7173 * floatfns.c (Fexpt):
7174 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7176 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7179 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7181 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7182 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7183 incorrectly succeed when S was a string, because 4294967386 was
7184 truncated before it was used.
7186 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7187 Otherwise, an out-of-range integer could cause undefined behavior
7190 * composite.c: Use int, not EMACS_INT, for characters.
7191 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7192 EMACS_INT, for values that are known to be in character range.
7193 This doesn't fix any bugs but is the usual style inside Emacs and
7194 may generate better code on 32-bit machines.
7196 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7197 This is for reasons similar to the recent CHAR_STRING fix.
7198 * charset.c (Fencode_char): Check that character arg is actually
7199 a character. Pass an int to ENCODE_CHAR.
7200 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7201 wider than 'int', as a compile-time check to prevent future regressions
7204 * character.c (char_string): Remove unnecessary casts.
7206 Make sure a 64-bit char is never passed to CHAR_STRING.
7207 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7208 by silently ignoring the top 32 bits, allowing some values
7209 that were far too large to be valid characters.
7210 * character.h: Include <verify.h>.
7211 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7212 arguments are no wider than unsigned, as a compile-time check
7213 to prevent future regressions in this area.
7215 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7216 (Fsubst_char_in_region):
7218 * xdisp.c (decode_mode_spec_coding):
7219 Adjust to CHAR_STRING's new requirement.
7220 * editfns.c (Finsert_char, Fsubst_char_in_region):
7221 * fns.c (concat): Check that character args are actually
7222 characters. Without this test, these functions did the wrong
7223 thing with wildly out-of-range values on 64-bit hosts.
7225 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7226 These casts should not be needed on 32-bit hosts, either.
7227 * keyboard.c (read_char):
7228 * lread.c (Fload): Remove casts to unsigned.
7230 * lisp.h (UNSIGNED_CMP): New macro.
7231 This fixes comparison bugs on 64-bit hosts.
7232 (ASCII_CHAR_P): Use it.
7233 * casefiddle.c (casify_object):
7234 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7235 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7236 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7237 * dispextern.h (FACE_FROM_ID):
7238 * keyboard.c (read_char): Use UNSIGNED_CMP.
7240 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7241 not to EMACS_INT, to avoid GCC warning.
7243 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7245 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7246 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7247 isn't needed on 32-bit machines.
7249 * buffer.c (Fgenerate_new_buffer_name):
7250 Use EMACS_INT for count, not int.
7251 (advance_to_char_boundary): Return EMACS_INT, not int.
7253 * data.c (Qcompiled_function): Now static.
7255 * window.c (window_body_lines): Now static.
7257 * image.c (gif_load): Rename local to avoid shadowing.
7259 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7260 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7261 * alloc.c (make_save_value): Integer argument is now of type
7263 (mark_object): Use ptrdiff_t, not int.
7264 * lisp.h (pD): New macro.
7265 * print.c (print_object): Use it.
7267 * alloc.c: Use EMACS_INT, not int, to count objects.
7268 (total_conses, total_markers, total_symbols, total_vector_size)
7269 (total_free_conses, total_free_markers, total_free_symbols)
7270 (total_free_floats, total_floats, total_free_intervals)
7271 (total_intervals, total_strings, total_free_strings):
7272 Now EMACS_INT, not int. All uses changed.
7273 (Fgarbage_collect): Compute overall total using a double, so that
7274 integer overflow is less likely to be a problem. Check for overflow
7275 when converting back to an integer.
7276 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7277 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7278 These were 'int' variables that could overflow on 64-bit hosts;
7279 they were never used, so remove them instead of repairing them.
7280 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7281 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7282 Previously, this ceilinged at INT_MAX, but that doesn't work on
7284 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7286 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7287 (allocate_vectorlike): Check for ptrdiff_t overflow.
7288 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7289 when a (possibly-narrower) signed value would do just as well.
7290 We prefer using signed arithmetic, to avoid comparison confusion.
7292 * alloc.c: Catch some string size overflows that we were missing.
7293 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7294 for convenience in STRING_BYTES_MAX.
7295 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7296 The definition here is exact; the one in lisp.h was approximate.
7297 (allocate_string_data): Check for string overflow. This catches
7298 some instances we weren't catching before. Also, it catches
7299 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7300 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7301 and ptrdiff_t and EMACS_INT are both 64 bits.
7303 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7304 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7305 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7307 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7309 * alloc.c (Fmake_string): Check for out-of-range init.
7311 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7313 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7315 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7317 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7318 xg_get_default_scrollbar_width.
7320 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7321 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7322 (style_changed_cb): Call update_theme_scrollbar_width and call
7323 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7324 all frames (Bug#8505).
7325 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7326 Call gtk_window_set_resizable if HAVE_GTK3.
7327 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7328 and height if HAVE_GTK3 (Bug#8505).
7329 (scroll_bar_width_for_theme): New variable.
7330 (update_theme_scrollbar_width): New function.
7331 (xg_get_default_scrollbar_width): Move code to
7332 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7333 (xg_initialize): Call update_theme_scrollbar_width.
7335 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7337 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7339 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7341 * frame.c (make_frame): Call other_buffer_safely instead of
7344 * window.c (temp_output_buffer_show): Call display_buffer with
7345 second argument Vtemp_buffer_show_specifiers and reset latter
7346 immediately after the call.
7347 (Vtemp_buffer_show_specifiers): New variable.
7348 (auto_window_vscroll_p, next_screen_context_lines)
7349 (Vscroll_preserve_screen_position): Remove leading asterisks from
7352 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7354 Fix minor problems found by GCC 4.6.0 static checking.
7355 * buffer.c (Qclone_number): Remove for now, as it's unused.
7356 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7357 (record_buffer): Remove unused local.
7358 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7359 (set_frame_buffer_list): Remove; unused.
7360 * frame.h (other_visible_frames): Remove decl.
7361 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7362 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7363 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7365 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7366 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7367 Define only if HAVE_GPM.
7368 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7369 (update_hints_inhibit): Remove; never set. All uses removed.
7370 * widgetprv.h (emacsFrameClassRec): Remove decl.
7371 * window.c (delete_deletable_window): Now returns void, since it
7372 wasn't returning anything.
7373 (compare_window_configurations): Remove unused locals.
7374 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7375 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7376 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7377 the same widths as pointers. This follows up on the 2011-05-06 patch.
7378 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7379 * xterm.h: Likewise.
7380 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7382 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7384 * makefile.w32-in: Update dependencies.
7385 (LISP_H): Add lib/intprops.h.
7387 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7389 * image.c (gif_load): Add animation frame delay to the metadata.
7390 (syms_of_image): Use DEFSYM. New symbol `delay'.
7392 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7394 * window.c (delete_deletable_window): Re-add.
7395 (Fset_window_configuration): Rewrite to handle dead buffers and
7396 consequently deletable windows.
7397 (window_tree, Fwindow_tree): Remove. Supply functionality in
7399 (compare_window_configurations): Simplify code.
7401 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7403 * image.c (imagemagick_load_image): Fix type mismatch.
7404 (Fimagemagick_types): Likewise.
7406 * window.h (replace_buffer_in_windows): Declare.
7408 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7410 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7411 Qclone_number. Remove external declaration of Qdelete_window.
7412 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7414 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7415 Run Qbuffer_list_update_hook if allowed.
7416 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7417 buffer list implementation.
7418 (other_buffer_safely): New function.
7419 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7420 calls to replace_buffer_in_windows and
7421 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7423 (record_buffer): Inhibit quitting and rewrite using quittable
7424 functions. Run Qbuffer_list_update_hook if allowed.
7425 (Frecord_buffer, Funrecord_buffer): New functions.
7426 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7427 Move switch-to-buffer to window.el.
7428 (bury-buffer): Move to window.el.
7429 (Vbuffer_list_update_hook): New variable.
7431 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7434 * window.h (resize_frame_windows): Move up in code.
7435 (Fwindow_frame): Remove EXFUN.
7436 (replace_buffer_in_all_windows): Remove prototype.
7437 (replace_buffer_in_windows_safely): Add prototype.
7439 * window.c: Declare Qdelete_window static again. Move down
7440 declaration of select_count.
7441 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7442 (Fother_window): Move to window.el.
7443 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7444 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7445 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7447 (replace_buffer_in_windows): Implement by calling
7448 Qreplace_buffer_in_windows.
7449 (replace_buffer_in_all_windows): Remove with some functionality
7450 moved into replace_buffer_in_windows_safely.
7451 (replace_buffer_in_windows_safely): New function.
7452 (select_window_norecord, select_frame_norecord): Move in front
7453 of run_window_configuration_change_hook. Remove now obsolete
7455 (Fset_window_buffer): Rewrite doc-string.
7456 Call Qrecord_window_buffer.
7457 (keys_of_window): Move binding for other-window to window.el.
7459 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7461 * dispextern.h (struct image): Replace data member, whose int_val
7462 and ptr_val fields were not used by anything, with a single
7465 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7466 (gif_clear_image, gif_load, imagemagick_load_image)
7467 (gs_clear_image, gs_load): Callers changed.
7469 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7471 * buffer.h: Include <time.h>, for time_t.
7472 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7474 Fix minor problems found by static checking.
7476 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7478 Make identifiers static if they are not used in other modules.
7479 * data.c (Qcompiled_function, Qframe, Qvector):
7480 * image.c (QimageMagick, Qsvg):
7481 * minibuf.c (Qmetadata):
7482 * window.c (resize_window_check, resize_root_window): Now static.
7483 * window.h (resize_window_check, resize_root_window): Remove decls.
7485 * window.c (window_deletion_count, delete_deletable_window):
7487 (window_body_lines): Now static.
7488 (Fdelete_other_windows_internal): Mark vars as initialized.
7489 Make sure 'resize_failed' is initialized.
7490 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7491 (resize_window_apply): Remove unused local.
7492 * window.h (delete_deletable_window): Remove decl.
7494 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7495 (imagemagick_load_image): Fix pointer signedness problem by changing
7496 last arg from unsigned char * to char *. All uses changed.
7497 Also, fix a local for similar reasons.
7498 Remove unused locals. Remove locals to avoid shadowing.
7499 (fn_rsvg_handle_free): Remove; unused.
7500 (svg_load, svg_load_image): Fix pointer signedness problem.
7501 (imagemagick_load_image): Don't use garbage pointer image_wand.
7503 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7505 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7507 * image.c (gif_load): Fix omitted cast error introduced by
7510 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7512 * window.h (resize_proportionally, orig_total_lines)
7513 (orig_top_line): Remove from window structure.
7514 (set_window_height, set_window_width, change_window_heights)
7515 (Fdelete_window): Remove prototypes.
7516 (resize_frame_windows): Remove duplicate declaration.
7518 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7520 * window.h (resize_frame_windows, resize_window_check)
7521 (delete_deletable_window, resize_root_window)
7522 (resize_frame_windows): Declare prototypes.
7524 * window.c (resize_window_apply): Make definition be "static" to
7525 match the prototype.
7527 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7529 * window.c: Remove declarations of Qwindow_size_fixed,
7530 window_min_size_1, window_min_size_2, window_min_size,
7531 size_window, window_fixed_size_p, enlarge_window, delete_window.
7532 Remove static from declaration of Qdelete_window, it's
7533 temporarily needed by Fbury_buffer.
7534 (replace_window): Don't assign orig_top_line and
7536 (Fdelete_window, delete_window): Remove. Window deletion is
7537 handled by window.el.
7538 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7539 Replace Fdelete_window calls with calls to Qdelete_window.
7540 (Fdelete_other_windows): Remove. Deleting other windows is
7541 handled by window.el.
7542 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7543 handled in window.el.
7544 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7545 Window minimum sizes are handled in window.el.
7546 (shrink_windows, size_window, set_window_height)
7547 (set_window_width, change_window_heights, window_height)
7548 (window_width, CURBEG, CURSIZE, enlarge_window)
7549 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7550 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7551 handled in window.el.
7552 (make_dummy_parent): Rename to make_parent_window and give it a
7553 second argument horflag.
7554 (make_window): Don't set resize_proportionally any more.
7555 (Fsplit_window): Remove. Windows are split in window.el.
7556 (save_restore_action, save_restore_orig_size)
7557 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7558 Resize mini windows in window.el.
7559 (grow_mini_window, shrink_mini_window): Implement by calling
7560 Qresize_root_window_vertically, resize_window_check and
7561 resize_window_apply.
7562 (saved_window, Fset_window_configuration, save_window_save):
7563 Do not handle orig_top_line, orig_total_lines, and
7564 resize_proportionally.
7565 (window_min_height, window_min_width): Move to window.el.
7566 (keys_of_window): Move bindings for delete-other-windows,
7567 split-window, delete-window and enlarge-window to window.el.
7569 * buffer.c: Temporarily extern Qdelete_window.
7570 (Fbury_buffer): Temporarily call Qdelete_window instead of
7571 Fdelete_window (Fbury_buffer will move to window.el soon).
7573 * frame.c (set_menu_bar_lines_1): Remove code handling
7574 orig_top_line and orig_total_lines.
7576 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7577 set_window_height but set heights directly.
7578 (change_frame_size_1): Use resize_frame_windows.
7580 * xdisp.c (init_xdisp): Don't use set_window_height but set
7583 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7584 Use resize_frame_windows instead of change_window_heights and run
7585 run_window_configuration_change_hook.
7587 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7588 instead of change_window_heights and run
7589 run_window_configuration_change_hook.
7591 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7593 * window.c (replace_window): Rename second argument REPLACEMENT to
7594 NEW. New third argument SETFLAG. Rewrite.
7595 (delete_window, make_dummy_parent): Call replace_window with
7597 (window_list_1): Move down in code.
7598 (run_window_configuration_change_hook): Move set_buffer part
7599 before select_frame_norecord part in order to unwind correctly.
7600 Rename count1 to count.
7601 (recombine_windows, delete_deletable_window, resize_root_window)
7602 (Fdelete_other_windows_internal)
7603 (Frun_window_configuration_change_hook, make_parent_window)
7604 (resize_window_check, resize_window_apply, Fresize_window_apply)
7605 (resize_frame_windows, Fsplit_window_internal)
7606 (Fdelete_window_internal, Fresize_mini_window_internal):
7608 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7610 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7612 * window.h (window): Add some new members to window structure -
7613 normal_lines, normal_cols, new_total, new_normal, clone_number,
7614 splits, nest, prev_buffers, next_buffers.
7615 (WINDOW_TOTAL_SIZE): Move here from window.c.
7616 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7618 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7620 (make_dummy_parent): Set new members of windows structure.
7621 (make_window): Move down in code. Handle new members of window
7623 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7624 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7625 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7626 (Fset_window_prev_buffers, Fwindow_next_buffers)
7627 (Fset_window_next_buffers, Fset_window_clone_number):
7629 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7630 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7632 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7633 Argument WINDOW can be now internal window too.
7634 (Fwindow_use_time): Move up in code.
7635 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7637 (Fset_window_configuration, saved_window)
7638 (Fcurrent_window_configuration, save_window_save): Handle new
7639 members of window structure.
7640 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7641 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7642 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7643 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7644 Qget_mru_window, Qresize_root_window,
7645 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7646 Qauto_buffer_name; staticpro them.
7648 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7650 * window.c (Fwindow_total_size, Fwindow_left_column)
7651 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7652 (Fwindow_list_1): New functions.
7653 (window_box_text_cols): Replace with window_body_cols.
7654 (Fwindow_width, Fscroll_left, Fscroll_right):
7655 Use window_body_cols instead of window_box_text_cols.
7656 (delete_window, Fset_window_configuration):
7657 Call delete_all_subwindows with window as argument.
7658 (delete_all_subwindows): Take a window as argument and not a
7660 (window_loop): Remove handling of GET_LRU_WINDOW and
7662 (Fget_lru_window, Fget_largest_window): Move to window.el.
7664 * window.h: Extern window_body_cols instead of
7665 window_box_text_cols. delete_all_subwindows now takes a
7666 Lisp_Object as argument.
7668 * indent.c (compute_motion, Fcompute_motion):
7669 Use window_body_cols instead of window_box_text_cols.
7671 * frame.c (delete_frame): Call delete_all_subwindows with root
7674 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7676 * fns.c (Fputhash): Document return value.
7678 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7680 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7682 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7684 Cons<->int and similar integer overflow fixes (Bug#8794).
7686 Check for overflow when converting integer to cons and back.
7687 * charset.c (Fdefine_charset_internal, Fdecode_char):
7688 Use cons_to_unsigned to catch overflow.
7689 (Fencode_char): Use INTEGER_TO_CONS.
7690 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7691 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7692 * data.c (long_to_cons, cons_to_long): Remove.
7693 (cons_to_unsigned, cons_to_signed): New functions.
7694 These signal an error for invalid or out-of-range values.
7695 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7696 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7697 * font.c (Ffont_variation_glyphs):
7698 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7699 * lisp.h: Include <intprops.h>.
7700 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7701 (cons_to_signed, cons_to_unsigned): New decls.
7702 (long_to_cons, cons_to_long): Remove decls.
7703 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7704 (Fprimitive_undo): Use CONS_TO_INTEGER.
7705 * xfns.c (Fx_window_property): Likewise.
7706 * xselect.c: Include <limits.h>.
7707 (x_own_selection, selection_data_to_lisp_data):
7708 Use INTEGER_TO_CONS.
7709 (x_handle_selection_request, x_handle_selection_clear)
7710 (x_get_foreign_selection, Fx_disown_selection_internal)
7711 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7712 (lisp_data_to_selection_data): Use cons_to_unsigned.
7713 (x_fill_property_data): Use cons_to_signed.
7714 Report values out of range.
7716 Check for buffer and string overflow more precisely.
7717 * buffer.h (BUF_BYTES_MAX): New macro.
7718 * lisp.h (STRING_BYTES_MAX): New macro.
7719 * alloc.c (Fmake_string):
7720 * character.c (string_escape_byte8):
7721 * coding.c (coding_alloc_by_realloc):
7722 * doprnt.c (doprnt):
7723 * editfns.c (Fformat):
7725 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7726 since they may not be the same number.
7727 * editfns.c (Finsert_char):
7728 * fileio.c (Finsert_file_contents):
7729 Likewise for BUF_BYTES_MAX.
7731 * image.c: Use ptrdiff_t, not int, for sizes.
7732 (slurp_file): Switch from int to ptrdiff_t.
7734 (slurp_file): Check that file size fits in both size_t (for
7735 malloc) and ptrdiff_t (for sanity and safety).
7737 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7738 if b->modtime has its maximal value.
7740 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7742 Don't assume time_t can fit into int.
7743 * buffer.h (struct buffer.modtime): Now time_t, not int.
7744 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7745 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7747 Minor fixes for signed vs unsigned integers.
7748 * character.h (MAYBE_UNIFY_CHAR):
7749 * charset.c (maybe_unify_char):
7750 * keyboard.c (read_char, reorder_modifiers):
7751 XINT -> XFASTINT, since the integer must be nonnegative.
7752 * ftfont.c (ftfont_spec_pattern):
7753 * keymap.c (access_keymap, silly_event_symbol_error):
7754 XUINT -> XFASTINT, since the integer must be nonnegative.
7755 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7756 since it makes no difference and we prefer signed.
7757 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7758 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7761 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7763 * window.h (Fwindow_frame): Declare.
7765 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7767 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7768 (SPARE_MEMORY): Always define.
7769 (LARGE_REQUEST): Remove.
7770 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7772 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7774 * lisp.h: Move EXFUNS for Fframe_root_window,
7775 Fframe_first_window and Fset_frame_selected_window to window.h.
7777 * window.h: Move EXFUNS for Fframe_root_window,
7778 Fframe_first_window and Fset_frame_selected_window here from
7781 * frame.c (Fwindow_frame, Fframe_first_window)
7782 (Fframe_root_window, Fframe_selected_window)
7783 (Fset_frame_selected_window): Move to window.c.
7784 (Factive_minibuffer_window): Move to minibuf.c.
7785 (Fother_visible_frames_p): New function.
7787 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7789 * window.c (decode_window, decode_any_window): Move up in code.
7790 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7791 (inhibit_frame_unsplittable): Remove unused variable.
7792 (Fwindow_buffer): Move up and rewrite doc-string.
7793 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7794 (Fwindow_prev): New functions.
7795 (Fwindow_frame): Move here from frame.c. Accept any window as
7797 (Fframe_root_window, Fframe_first_window)
7798 (Fframe_selected_window): Move here from frame.c. Accept frame
7799 or arbitrary window as argument. Update doc-strings.
7800 (Fminibuffer_window): Move up in code.
7801 (Fwindow_minibuffer_p): Move up in code and simplify.
7802 (Fset_frame_selected_window): Move here from frame.c.
7804 (Fselected_window, select_window, Fselect_window): Move up in
7805 code. Minor doc-string fixes.
7807 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7809 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7810 Do not assume that spare memory exists; that assumption is valid
7811 only if SYSTEM_MALLOC.
7812 (LARGE_REQUEST): New macro, so that the issue of large requests
7813 is separated from the issue of spare memory.
7815 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7817 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7820 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7822 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7825 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7827 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7829 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7831 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7832 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7834 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7836 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7838 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7840 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7841 (x_clipboard_manager_save): Add return value.
7842 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7844 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7845 Obey Vx_select_enable_clipboard_manager. Catch errors in
7846 x_clipboard_manager_save (Bug#8779).
7847 (Vx_select_enable_clipboard_manager): New variable.
7848 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7850 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7852 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7854 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7856 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7857 in the current matrix if keep_current_p is non-zero.
7859 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7861 * bidi.c (bidi_level_of_next_char): Fix last change.
7863 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7865 Support bidi reordering of text covered by display properties.
7867 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7868 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7869 (bidi_cache_search, bidi_cache_iterator_state)
7870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7871 (bidi_level_of_next_char, bidi_move_to_visually_next):
7872 Support character positions inside a run of characters covered by a
7874 (bidi_paragraph_init, bidi_resolve_explicit_1)
7875 (bidi_level_of_next_char): Call bidi_fetch_char and
7876 bidi_fetch_char_advance instead of FETCH_CHAR and
7878 (bidi_init_it): Initialize new members.
7879 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7881 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7882 instead of using explicit *_CHAR codes.
7883 (bidi_resolve_explicit, bidi_resolve_weak):
7884 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7885 bidirectional text is supported only in multibyte buffers.
7886 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7887 it to initialize the frame_window_p member of struct bidi_it.
7888 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7889 (bidi_resolve_explicit, bidi_resolve_weak)
7890 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7891 bidi_it->nchars is non-positive.
7892 (bidi_level_of_next_char): Don't try to lookup the cache for the
7893 next/previous character if nothing is cached there yet, or if we
7894 were just reseat()'ed to a new position.
7896 * xdisp.c (set_cursor_from_row): Set start and stop points
7897 according to the row's direction when priming the loop that looks
7898 for the glyph on which to display cursor.
7899 (single_display_spec_intangible_p): Function deleted.
7900 (display_prop_intangible_p): Reimplement to call
7901 handle_display_spec instead of single_display_spec_intangible_p.
7902 Accept 3 additional arguments needed by handle_display_spec.
7903 This fixes incorrect cursor motion across display property with complex
7904 values: lists, `(when COND...)' forms, etc.
7905 (single_display_spec_string_p): Support property values that are
7906 lists with the argument STRING its top-level element.
7907 (display_prop_string_p): Fix the condition for processing a
7908 property that is a list to be consistent with handle_display_spec.
7909 (handle_display_spec): New function, refactored from the
7910 last portion of handle_display_prop.
7911 (compute_display_string_pos): Accept additional argument
7912 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7913 value of a `display' property is a "replacing spec".
7914 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7915 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7916 the display property, but just return a value indicating whether
7917 the display property will replace the characters it covers.
7918 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7919 frame_window_p members of struct bidi_it.
7920 (compute_display_string_pos, compute_display_string_end):
7922 (push_it): Accept second argument POSITION, where pop_it should
7923 jump to continue iteration.
7924 (reseat_1): Initialize bidi_it.disp_pos.
7926 * keyboard.c (adjust_point_for_property): Adjust the call to
7927 display_prop_intangible_p to its new signature.
7929 * dispextern.h (struct bidi_it): New member frame_window_p.
7930 (bidi_init_it): Update prototypes.
7931 (display_prop_intangible_p): Update prototype.
7932 (compute_display_string_pos, compute_display_string_end):
7934 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7937 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7939 Malloc failure behavior now depends on size of allocation.
7940 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7941 * lisp.h: Change signatures accordingly.
7942 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7943 All callers changed. (Bug#8762)
7945 * gnutls.c: Use Emacs's memory allocators.
7946 Without this change, the gnutls library would invoke malloc etc.
7947 directly, which causes problems on non-SYNC_INPUT hosts, and which
7948 runs afoul of improving memory_full behavior. (Bug#8761)
7949 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7950 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7951 xfree instead of the default malloc, realloc, free.
7952 (Fgnutls_boot): No need to check for memory allocation failure,
7953 since xmalloc does that for us.
7955 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7956 * category.c (hash_get_category_set):
7957 * ccl.c (ccl_driver):
7958 * charset.c (Fdefine_charset_internal):
7959 * charset.h (struct charset.hash_index):
7960 * composite.c (get_composition_id, gstring_lookup_cache)
7961 (composition_gstring_put_cache):
7962 * composite.h (struct composition.hash_index):
7963 * dispextern.h (struct image.hash):
7964 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7965 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7966 (hashfn_equal, hashfn_user_defined, make_hash_table)
7967 (maybe_resize_hash_table, hash_lookup, hash_put)
7968 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7970 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7971 * image.c (make_image, search_image_cache, lookup_image)
7972 (xpm_put_color_table_h):
7973 * lisp.h (struct Lisp_Hash_Table):
7974 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7975 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7976 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7977 * alloc.c (allocate_vectorlike):
7978 Check for overflow in vector size calculations.
7979 * ccl.c (ccl_driver):
7980 Check for overflow when converting EMACS_INT to int.
7981 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7982 need to be updated by these changes.
7983 * fns.c (make_hash_table, maybe_resize_hash_table):
7984 Check for integer overflow with large hash tables.
7985 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7986 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7987 (SXHASH_REDUCE): New macro.
7988 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7989 Use it instead of discarding useful hash info with large hash values.
7990 (sxhash_float): New function.
7991 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7992 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7993 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7994 Rewrite to use FIXNUM_BITS, as this simplifies things.
7995 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7996 Adjust signatures to match updated version of code.
7997 (consing_since_gc): Now EMACS_INT, since a single hash table can
7998 use more than INT_MAX bytes.
8000 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8002 Make it possible to build with GCC-4.6+ -O2 -flto.
8004 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8006 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8008 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8009 Call minibuffer-inactive-mode.
8011 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8013 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8014 Update dependencies.
8016 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8018 * data.c (init_data): Remove code for UTS, this system is not
8021 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8023 Don't force ./temacs to start in terminal mode.
8025 * frame.c (make_initial_frame): Initialize faces in all cases, not
8026 only when CANNOT_DUMP is defined.
8027 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8029 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8031 * dispnew.c (add_window_display_history): Use const for the string
8032 pointer. Remove declaration, not needed.
8034 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8036 Use 'inline', not 'INLINE'.
8037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8038 * alloc.c, fontset.c (INLINE): Remove.
8039 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8040 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8041 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8042 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8043 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8045 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8047 Make it possible to run ./temacs.
8049 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8050 syms_of_callproc does the same thing. Remove test for
8051 "initialized", do it in the caller.
8052 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8054 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8056 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8057 (read_minibuf): Use get_minibuffer.
8058 (syms_of_minibuf): Use DEFSYM.
8059 (Qmetadata): New var.
8060 * data.c (Qbuffer): Don't make it static.
8061 (syms_of_data): Use DEFSYM.
8063 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8065 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8066 (CCL_CODE_MIN): New macro.
8068 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8070 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8072 * eval.c (Qdebug): Now static.
8073 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8074 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8075 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8077 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8079 * image.c: Various fixes to ImageMagick code comments.
8080 (Fimagemagick_types): Doc fix.
8082 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8084 Minor fixes prompted by GCC 4.6.0 warnings.
8086 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8088 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8089 (x_clipboard_manager_save_all): Move extern decl to ...
8090 * xterm.h: ... here, so that it can be checked for consistency.
8092 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8094 * xselect.c (x_clipboard_manager_save_frame)
8095 (x_clipboard_manager_save_all): New functions.
8096 (Fx_clipboard_manager_save): Lisp function deleted.
8098 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8099 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8101 * xterm.h: Update prototype.
8103 2011-05-28 William Xu <william.xwl@gmail.com>
8105 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8108 2011-05-28 Jim Meyering <meyering@redhat.com>
8110 Avoid a sign-extension bug in crypto_hash_function.
8111 * fns.c (to_uchar): Define.
8112 (crypto_hash_function): Use it to convert some newly-signed
8113 variables to unsigned, to avoid sign-extension bugs. For example,
8114 without this change, (md5 "truc") would evaluate to
8115 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8116 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8117 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8119 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8121 Integer overflow fixes.
8123 * dbusbind.c: Serial number integer overflow fixes.
8124 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8125 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8126 to hold a serial number that is too large for a fixnum.
8127 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8128 Check for serial numbers out of range. Decode any serial number
8129 that was so large that it became a float. (Bug#8722)
8131 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8132 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8133 Use XFASTINT rather than XUINT when numbers are nonnegative.
8134 (xd_append_arg, Fdbus_method_return_internal):
8135 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8136 arguments, check that Lisp number is nonnegative, rather than
8137 silently wrapping negative numbers around. (Bug#8722)
8138 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8141 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8143 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8145 ccl: Add integer overflow checks.
8146 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8147 (IN_INT_RANGE): New macros.
8148 (ccl_driver): Use them to check for integer overflow when
8149 decoding a CCL program. Many of the new checks are whether XINT (x)
8150 fits in int; it doesn't always, on 64-bit hosts. The new version
8151 doesn't catch all possible integer overflows, but it's an
8152 improvement. (Bug#8719)
8154 * alloc.c (make_event_array): Use XINT, not XUINT.
8155 There's no need for unsigned here.
8157 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8158 This follows up to the 2011-05-06 change that substituted uintptr_t
8159 for EMACS_INT. This case wasn't caught back then.
8161 Rework Fformat to avoid integer overflow issues.
8162 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8163 now (part of C89). Include <verify.h>.
8164 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8165 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8166 (Fformat): Avoid the prepass trying to compute sizes; it was only
8167 approximate and thus did not catch overflow reliably. Instead, walk
8168 through the format just once, formatting and computing sizes as we go,
8169 checking for integer overflow at every step, and allocating a larger
8170 buffer as needed. Keep track separately whether the format is
8171 multibyte. Keep only the most-recently calculated precision, rather
8172 than them all. Record whether each argument has been converted to
8173 string. Use EMACS_INT, not int, for byte and char and arg counts.
8174 Support field widths and precisions larger than INT_MAX. Avoid
8175 sprintf's undefined behavior with conversion specifications such as %#d
8176 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8177 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8178 formatting out-of-range floating point numbers with int
8181 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8183 * data.c: Avoid integer truncation in expressions involving floats.
8184 * data.c: Include <intprops.h>.
8185 (arith_driver): When there's an integer overflow in an expression
8186 involving floating point, convert the integers to floating point
8187 so that the resulting value does not suffer from catastrophic
8188 integer truncation. For example, on a 64-bit host (* 4
8189 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8190 Do not rely on undefined behavior after integer overflow.
8192 merge count_size_as_multibyte, parse_str_to_multibyte
8193 * character.c, character.h (count_size_as_multibyte):
8194 Rename from parse_str_to_multibyte; all uses changed.
8195 Check for integer overflow.
8196 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8197 since it's now a duplicate of the other. This is more of
8198 a character than a buffer op, so better that it's in character.c.
8199 * fns.c, print.c: Adjust to above changes.
8201 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8203 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8205 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8207 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8208 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8209 (x_clipboard_manager_save): Now static.
8210 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8212 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8213 (crypto_hash_function): Now static.
8214 Fix pointer signedness problems. Avoid unnecessary initializations.
8216 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8218 * termhooks.h (Vselection_alist): Make it terminal-local.
8220 * terminal.c (create_terminal): Initialize it.
8222 * xselect.c: Support for clipboard managers.
8223 (Vselection_alist): Move to termhooks.h as terminal-local var.
8224 (LOCAL_SELECTION): New macro.
8225 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8226 (symbol_to_x_atom): Remove gratuitous arg.
8227 (x_handle_selection_request, lisp_data_to_selection_data)
8228 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8229 (x_own_selection, x_get_local_selection, x_convert_selection):
8230 New arg, specifying work frame. Use terminal-local Vselection_alist.
8231 (some_frame_on_display): Delete unused function.
8232 (Fx_own_selection_internal, Fx_get_selection_internal)
8233 (Fx_disown_selection_internal, Fx_selection_owner_p)
8234 (Fx_selection_exists_p): New optional frame arg.
8235 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8236 (x_handle_selection_clear): Don't treat other terminals with the
8237 same keyboard specially. Use the terminal-local Vselection_alist.
8238 (x_clear_frame_selections): Use Frun_hook_with_args.
8240 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8242 * xterm.h: Add support for those atoms.
8244 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8246 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8247 (converted_selections, conversion_fail_tag): New global variables.
8248 (x_selection_request_lisp_error): Free the above.
8249 (x_get_local_selection): Remove unnecessary code.
8250 (x_reply_selection_request): Args changed; handle arbitrary array
8251 of converted selections stored in converted_selections.
8252 Separate the XChangeProperty and SelectionNotify steps.
8253 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8254 (x_convert_selection): New function.
8255 (x_handle_selection_event): Simplify.
8256 (x_get_foreign_selection): Don't ignore incoming requests while
8257 waiting for an answer; this will fail when we implement
8258 SAVE_TARGETS, and seems unnecessary anyway.
8259 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8260 (Vx_sent_selection_functions): Doc fix.
8262 2011-05-26 Leo Liu <sdl.web@gmail.com>
8264 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8266 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8268 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8270 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8271 for fringe update if it has periodic bitmap.
8272 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8273 and fringe_bitmap_periodic_p.
8275 * fringe.c (get_fringe_bitmap_data): New function.
8276 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8277 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8278 row. Mark glyph row for fringe update if periodicity changed.
8280 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8281 for fringe update unless it has periodic bitmap.
8283 2011-05-25 Kenichi Handa <handa@m17n.org>
8285 * xdisp.c (get_next_display_element): Set correct it->face_id for
8286 a static composition.
8288 2011-05-24 Leo Liu <sdl.web@gmail.com>
8291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8293 * fns.c (crypto_hash_function, Fsha1): New function.
8294 (Fmd5): Use crypto_hash_function.
8295 (syms_of_fns): Add Ssha1.
8297 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8299 * gnutls.c: Remove unused macros.
8300 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8301 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8302 Remove macros that are defined and never used.
8303 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8305 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8307 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8308 (Fx_get_selection_internal): Minor cleanup.
8309 (Fx_own_selection_internal): Rename arguments for consistency with
8312 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8314 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8316 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8318 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8320 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8322 * dispnew.c (scrolling_window): Don't exclude the case that the
8323 last enabled row in the desired matrix touches the bottom boundary.
8325 2011-05-21 Glenn Morris <rgm@gnu.org>
8327 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8328 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8329 and add some more files.
8331 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8333 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8334 report_file_error introduced by the change from 2011-05-07.
8336 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8338 * systime.h (Time): Define only if emacs is defined.
8339 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8340 where the include path doesn't have X11/X.h by default. See
8341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8343 2011-05-20 Kenichi Handa <handa@m17n.org>
8345 * composite.c (find_automatic_composition): Fix previous change.
8347 2011-05-20 Glenn Morris <rgm@gnu.org>
8349 * lisp.mk: New file, split from Makefile.in.
8350 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8351 (shortlisp): Remove.
8352 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8354 2011-05-19 Glenn Morris <rgm@gnu.org>
8356 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8357 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8358 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8359 (lisp): Set the order to that of loadup.el.
8360 (shortlisp): Make it a copy of $lisp.
8361 (SOME_MACHINE_LISP): Remove.
8362 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8363 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8365 2011-05-18 Kenichi Handa <handa@m17n.org>
8367 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8368 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8369 (find_automatic_composition): Mostly rewrite for efficiency.
8371 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8373 * makefile.w32-in: Update dependencies.
8375 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8377 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8378 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8380 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8382 Fix some integer overflow issues, such as string length overflow.
8384 * insdel.c (count_size_as_multibyte): Check for string overflow.
8386 * character.c (lisp_string_width): Check for string overflow.
8387 Use EMACS_INT, not int, for string indexes and lengths; in
8388 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8389 the resulting string length overflows an EMACS_INT; instead,
8390 report a string overflow if no precision given. When checking for
8391 precision exhaustion, use a check that cannot possibly have
8392 integer overflow. (Bug#8675)
8393 * character.h (lisp_string_width): Adjust to new signature.
8395 * alloc.c (string_overflow): New function.
8396 (Fmake_string): Use it. This doesn't change behavior, but saves
8397 a few bytes and will simplify future changes.
8398 * character.c (string_escape_byte8): Likewise.
8399 * lisp.h (string_overflow): New decl.
8401 Fixups, following up to the user-interface timestamp change.
8402 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8403 for UI timestamps, instead of unsigned long.
8404 * msdos.c (mouse_get_pos): Likewise.
8405 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8406 * w32gui.h (Time): Define by including "systime.h" rather than by
8407 declaring it ourselves. (Bug#8664)
8409 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8410 * image.c (clear_image_cache): Likewise.
8412 * term.c (term_mouse_position): Don't assume time_t wraparound.
8414 Be more systematic about user-interface timestamps.
8415 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8416 and sometimes 'EMACS_UINT', to represent these timestamps.
8417 This change causes it to use 'Time' uniformly, as that's what X uses.
8418 This makes the code easier to follow, and makes it easier to catch
8419 integer overflow bugs such as Bug#8664.
8420 * frame.c (Fmouse_position, Fmouse_pixel_position):
8421 Use Time, not unsigned long, for user-interface timestamps.
8422 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8423 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8424 * keyboard.h (last_event_timestamp): Likewise.
8425 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8426 * menu.h (xmenu_show): Likewise.
8427 * term.c (term_mouse_position): Likewise.
8428 * termhooks.h (struct input_event.timestamp): Likewise.
8429 (struct terminal.mouse_position_hook): Likewise.
8430 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8431 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8432 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8433 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8435 * menu.h, termhooks.h: Include "systime.h", for Time.
8437 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8438 Don't assume that the difference between two unsigned long values
8439 can fit into an integer. At this point, we know button_down_time
8440 <= event->timestamp, so the difference must be nonnegative, so
8441 there's no need to cast the result if double-click-time is
8442 nonnegative, as it should be; check that it's nonnegative, just in
8443 case. This bug is triggered when events are more than 2**31 ms
8444 apart (about 25 days). (Bug#8664)
8446 * xselect.c (last_event_timestamp): Remove duplicate decl.
8447 (x_own_selection): Remove needless cast to unsigned long.
8449 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8450 that always fit in int. Use a sentinel instead of a counter, to
8451 avoid a temp and to allay GCC's concerns about possible int overflow.
8452 * frame.h (struct frame): Use int for menu_bar_items_used
8453 instead of EMACS_INT, since it always fits in int.
8455 * menu.c (grow_menu_items): Check for int overflow.
8457 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8459 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8460 Before, the code was not consistent. These values cannot exceed
8461 2**31 - 1 so there's no need to make them unsigned.
8462 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8463 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8464 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8466 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8468 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8469 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8470 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8471 presumably because the widths might not match.
8473 * window.c (size_window): Avoid needless test at loop start.
8475 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8477 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8479 2011-05-12 Drew Adams <drew.adams@oracle.com>
8481 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8483 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8485 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8486 `width' to `bar_area_x' and `bar_area_width', respectively.
8487 (x_scroll_run): Take account of fringe background extension.
8489 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8490 Rename local vars `left' and `width' to `bar_area_x' and
8491 `bar_area_width', respectively.
8492 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8493 background extension.
8495 2011-05-10 Jim Meyering <meyering@redhat.com>
8497 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8499 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8501 * image.c (Finit_image_library): Return t for built-in image types,
8502 like pbm and xbm. (Bug#8640)
8504 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8506 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8508 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8510 * w32console.c (Fset_screen_color): Doc fix.
8511 (Fget_screen_color): New function.
8512 (syms_of_ntterm): Defsubr it.
8514 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8515 unlink the temporary file if Fcall_process didn't create it in the
8517 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8518 child process will be redirected to a file specified with `:file'.
8519 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8520 cue to call_process_cleanup not to close that handle.
8522 2011-05-07 Ben Key <bkey76@gmail.com>
8524 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8525 one of two shell specific rules, either bootstrap-temacs-CMD or
8526 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8527 to the previous implementation of the bootstrap-temacs rule.
8528 The bootstrap-temacs-CMD rule is similar to the previous
8529 implementation of the bootstrap-temacs rule except that it
8530 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8533 These changes, along with some changes to nt/configure.bat,
8534 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8535 earlier fix to add support for --cflags and --ldflags options
8536 that include quotes so that it works whether make uses cmd or
8539 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8541 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8542 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8544 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8545 a string. Handle both cases.
8546 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8547 (Fdbus_register_method): Use Qinvalid_function.
8549 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8551 * makefile.w32-in: Update dependencies.
8552 (LISP_H): Add inttypes.h and stdin.h.
8553 (PROCESS_H): Add unistd.h.
8555 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8557 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8558 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8560 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8562 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8564 * term.c (vfatal): Remove stray call to va_end.
8565 It's not needed and the C Standard doesn't allow it here anyway.
8567 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8568 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8570 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8573 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8577 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8579 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8581 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8583 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8584 * charset.c (Fdefine_charset_internal): Don't initialize
8585 charset.code_space[15]. The value was garbage, on hosts with
8586 32-bit int (Bug#8600).
8588 * lread.c (read_integer): Be more consistent with string-to-number.
8589 Use string_to_number to do the actual conversion; this avoids
8590 rounding errors and fixes some other screwups. Without this fix,
8591 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8592 (digit_to_number): Move earlier, for benefit of read_integer.
8593 Return -1 if the digit is out of range for the base, -2 if it is
8594 not a digit in any supported base. (Bug#8602)
8596 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8598 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8599 to match comment at start of function. This also removes a
8600 GCC warning about overflow in a 32+64-bit port.
8602 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8604 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8605 Reported by Stefan Monnier in
8606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8607 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8608 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8610 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8611 (EMACS_UINTPTR): Likewise, with uintptr_t.
8613 * lisp.h: Prefer 64-bit EMACS_INT if available.
8614 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8615 on 32-bit hosts that have 64-bit int, so that they can access
8617 However, temporarily disable this change unless the temporary
8618 symbol WIDE_EMACS_INT is defined.
8620 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8622 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8623 This removes an assumption that EMACS_INT and long are the same
8624 width as pointers. The assumption is true for Emacs porting targets
8625 now, but we want to make other targets possible.
8626 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8627 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8628 In the rest of the code, change types of integers that hold casted
8629 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8630 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8631 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8632 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8633 No need to cast type when ORing.
8634 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8635 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8636 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8637 assume EMACS_INT is the same width as char *.
8638 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8639 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8640 Remove no-longer-needed casts.
8641 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8642 (xg_tool_bar_help_callback, xg_make_tool_item):
8643 Use EMACS_INTPTR to hold an integer
8644 that will be cast to void *; this can avoid a GCC warning
8645 if EMACS_INT is not the same width as void *.
8646 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8647 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8648 (current_message_1, set_message_1):
8649 Use a local to convert to proper width without a cast.
8650 * xmenu.c (dialog_selection_callback): Likewise.
8652 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8653 Also, don't assume VALBITS / RAND_BITS is less than 5,
8654 and don't rely on undefined behavior when shifting a 1 left into
8656 * lisp.h (get_random): Change signature to match.
8658 * lread.c (hash_string): Use size_t, not int, for hash computation.
8659 Normally we prefer signed values; but hashing is special, because
8660 it's better to use unsigned division on hash table sizes so that
8661 the remainder is nonnegative. Also, size_t is the natural width
8662 for hashing into memory. The previous code used 'int', which doesn't
8663 retain enough info to hash well into very large tables.
8664 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8666 * dbusbind.c: Don't possibly lose pointer info when converting.
8667 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8668 Use XPNTR rather than XHASH, so that the high-order bits of
8669 the pointer aren't lost when converting through void *.
8671 * eval.c (Fautoload): Don't double-shift a pointer.
8673 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8675 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8677 * gnutls.c (DEF_GNUTLS_FN):
8678 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8680 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8682 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8685 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8687 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8688 New version that can reserve upto 2GB of heap space.
8690 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8692 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8694 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8696 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8697 `gnutls_certificate_set_x509_key_file'.
8699 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8701 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8702 Update dependencies.
8704 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8706 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8707 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8708 Remove unused parameter `fildes'.
8709 * process.c (read_process_output, send_process): Don't pass it.
8711 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8713 Fix previous change: the library cache is defined in w32.c.
8714 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8715 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8717 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8719 Implement dynamic loading of GnuTLS on Windows.
8721 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8722 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8723 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8726 * gnutls.c (Qgnutls_dll): Define.
8727 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8728 (gnutls_*): Declare function pointers.
8729 (init_gnutls_functions): New function to initialize function pointers.
8730 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8731 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8733 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8734 (emacs_gnutls_write, emacs_gnutls_read)
8735 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8736 (Fgnutls_available_p): New function.
8737 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8738 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8739 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8741 * image.c: Include w32.h.
8742 (Vimage_type_cache): Delete.
8743 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8744 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8745 (w32_delayed_load): Move to w32.c.
8747 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8749 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8750 (w32_delayed_load): Move from image.c. When loading a library, record
8751 its filename in the :loaded-from property of the library id.
8752 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8753 Initialize and staticpro them.
8754 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8756 * process.c: Include lisp.h before w32.h, not after.
8757 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8758 instead of gnutls_record_check_pending.
8760 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8762 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8764 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8765 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8768 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8770 * xterm.c (x_set_frame_alpha): Do not set property on anything
8771 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8773 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8775 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8777 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8779 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8780 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8781 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8782 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8783 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8784 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8785 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8786 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8787 (Qgnutls_bootprop_callbacks_verify): Make static.
8789 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8791 * callproc.c: Indentation fixup.
8793 * sysdep.c (wait_for_termination_1): Make static.
8794 (wait_for_termination, interruptible_wait_for_termination):
8795 Move after wait_for_termination_1.
8797 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8799 * sysdep.c (interruptible_wait_for_termination): New function
8800 which is like wait_for_termination, but allows keyboard
8803 * callproc.c (Fcall_process): Add (:file "file") as an option for
8805 (Fcall_process_region): Ditto.
8807 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8809 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8810 rather than `XVECTOR (FOO)->size'.
8812 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8813 inttypes.h, as a gnulib replacement is used if it not available in
8816 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8818 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8819 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8820 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8822 * coding.c (coding_alloc_by_realloc): Error out if destination
8823 will grow beyond MOST_POSITIVE_FIXNUM.
8824 (decode_coding_emacs_mule): Abort if there isn't enough place in
8825 charbuf for the composition carryover bytes. Reserve an extra
8826 space for up to 2 characters produced in a loop.
8827 (decode_coding_iso_2022): Abort if there isn't enough place in
8828 charbuf for the composition carryover bytes.
8830 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8832 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8833 aborting when %lld or %lll format is passed.
8834 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8835 %llo or %llx format is passed. (Bug#8545)
8837 * window.c (window_scroll_line_based): Use a marker instead of
8838 simple variables to record original value of point. (Bug#7952)
8840 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8841 produced by %s or %c overflows available buffer space. (Bug#8545)
8843 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8845 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8846 (SIZE_MAX): Move defn after all includes, as they might #define it.
8848 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8850 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8852 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8854 * keyboard.c (Qdelayed_warnings_hook): Define.
8855 (command_loop_1): Run `delayed-warnings-hook'
8856 if Vdelayed_warnings_list is non-nil.
8857 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8858 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8860 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8862 * doprnt.c (doprnt): Don't return value smaller than the buffer
8863 size if the message was truncated. (Bug#8545).
8865 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8867 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8868 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8870 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8872 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8874 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8876 * makefile.w32-in: Update dependencies.
8878 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8880 Improve `doprnt' and its usage. (Bug#8545)
8881 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8882 `format_end'. Remove support for %l as a conversion specifier.
8883 Don't use xrealloc. Improve diagnostics when the %l size modifier
8884 is used. Update the commentary.
8886 * eval.c (verror): Simplify calculation of size_t.
8888 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8891 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8893 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8896 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8898 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8899 This makes this file independent of the recent pseudovector change.
8901 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8903 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8905 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8906 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8907 Remove unused local.
8908 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8910 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8911 GCC 4.6.0 optimizes based on type-based alias analysis.
8912 For example, if b is of type struct buffer * and v of type struct
8913 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8914 != &v->size, and therefore "v->size = 1; b->size = 2; return
8915 v->size;" must therefore return 1. This assumption is incorrect
8916 for Emacs, since it type-puns struct Lisp_Vector * with many other
8917 types. To fix this problem, this patch adds a new type struct
8918 vectorlike_header that documents the constraints on layout of vectors
8919 and pseudovectors, and helps optimizing compilers not get fooled
8920 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8921 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8922 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8924 (XSETPVECTYPE): Rewrite in terms of new macro.
8925 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8926 This is a bit clearer, and further avoids the possibility of
8927 undesirable aliasing.
8928 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8929 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8930 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8931 since Lisp_Subr is a special case (no "next" field).
8932 (ASIZE): Now uses header.size rather than size.
8933 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8934 to avoid the hassle of writing XVECTOR (foo)->header.size.
8935 (struct vectorlike_header): New type.
8936 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8937 object, to help avoid aliasing.
8938 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8939 (SUBRP): Likewise, since Lisp_Subr is a special case.
8940 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8941 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8942 (struct Lisp_Hash_Table): Combine first two members into a single
8943 struct vectorlike_header member. All uses of "size" and "next" members
8944 changed to be "header.size" and "header.next".
8945 * buffer.h (struct buffer): Likewise.
8946 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8947 * frame.h (struct frame): Likewise.
8948 * process.h (struct Lisp_Process): Likewise.
8949 * termhooks.h (struct terminal): Likewise.
8950 * window.c (struct save_window_data, struct saved_window): Likewise.
8951 * window.h (struct window): Likewise.
8952 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8953 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8954 * buffer.c (init_buffer_once): Likewise.
8955 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8957 * process.c (Fformat_network_address): Use local var for size,
8960 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8962 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8963 * data.c (atof): Remove decl; no longer used or needed.
8964 (digit_to_number): Move to lread.c.
8965 (Fstring_to_number): Use new string_to_number function, to be
8966 consistent with how the Lisp reader treats infinities and NaNs.
8967 Do not assume that floating-point numbers represent EMACS_INT
8968 without losing information; this is not true on most 64-bit hosts.
8969 Avoid double-rounding errors, by insisting on integers when
8970 parsing non-base-10 numbers, as the documentation specifies.
8971 * lisp.h (string_to_number): New decl, replacing ...
8972 (isfloat_string): Remove.
8973 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8974 (read1): Do not accept +. and -. as integers; this
8975 appears to have been a coding error. Similarly, do not accept
8976 strings like +-1e0 as floating point numbers. Do not report
8977 overflow for integer overflows unless the base is not 10 which
8978 means we have no simple and reliable way to continue.
8979 Break out the floating-point parsing into a new
8980 function string_to_number, so that Fstring_to_number parses
8981 floating point numbers consistently with the Lisp reader.
8982 (digit_to_number): Move here from data.c. Make it static inline.
8983 (E_CHAR, EXP_INT): Remove, replacing with ...
8984 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8985 (string_to_number): New function, replacing isfloat_string.
8986 This function checks for valid syntax and produces the resulting
8987 Lisp float number too. Rework it so that string-to-number
8988 no longer mishandles examples like "1.0e+". Use strtoumax,
8989 so that overflow for non-base-10 numbers is reported only when
8990 there's no portable and simple way to convert to floating point.
8992 * textprop.c (set_text_properties_1): Rewrite for clarity,
8993 and to avoid GCC warning about integer overflow.
8995 * intervals.h (struct interval): Use EMACS_INT for members
8996 where EMACS_UINT might cause problems. See
8997 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8998 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8999 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9001 (offset_intervals): Tell GCC not to worry about length overflow
9002 when negating a negative length.
9004 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9005 (overrun_check_free): Likewise.
9007 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9008 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9011 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9012 (gnutls_make_error): Rename local to avoid shadowing.
9013 (gnutls_emacs_global_deinit): ifdef out; not used.
9014 (Fgnutls_boot): Use const for pointer to readonly storage.
9015 Comment out unused local. Fix pointer signedness problems.
9017 * lread.c (openp): Don't stuff size_t into an 'int'.
9018 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9019 about possible signed overflow.
9021 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9022 (GDK_KEY_g): Don't define if already defined.
9023 (xg_prepare_tooltip): Avoid pointer signedness problem.
9024 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9026 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9027 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9029 * xfns.c (Fx_window_property): Simplify a bit,
9030 to make a bit faster and to avoid GCC 4.6.0 warning.
9031 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9033 * fns.c (internal_equal): Don't assume size_t fits in int.
9035 * alloc.c (compact_small_strings): Tighten assertion a little.
9037 Replace pEd with more-general pI, and fix some printf arg casts.
9038 * lisp.h (pI): New macro, generalizing old pEd macro to other
9039 conversion specifiers. For example, use "...%"pI"d..." rather
9040 than "...%"pEd"...".
9041 (pEd): Remove. All uses replaced with similar uses of pI.
9042 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9043 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9044 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9045 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9046 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9047 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9048 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9050 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9051 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9052 * print.c (safe_debug_print, print_object): Likewise.
9053 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9055 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9056 avoiding the 0 flag, which is not portable.
9057 * process.c (Fmake_network_process): Use pI to avoid cast.
9058 * region-cache.c (pp_cache): Likewise.
9059 * xdisp.c (decode_mode_spec): Likewise.
9060 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9061 behavior on 64-bit hosts with printf arg.
9062 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9063 (x_stop_queuing_selection_requests): Likewise.
9064 (x_get_window_property): Don't truncate byte count to an 'int'
9067 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9068 here, since it parses constructs like leading '-' and spaces,
9069 which are not wanted; and it overflows with large numbers.
9070 Instead, simply match F[0-9]+, which is what is wanted anyway.
9072 * alloc.c: Remove unportable assumptions about struct layout.
9073 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9074 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9075 (allocate_vectorlike, make_pure_vector): Use the new macros,
9076 plus offsetof, to remove unportable assumptions about struct layout.
9077 These assumptions hold on all porting targets that I know of, but
9078 they are not guaranteed, they're easy to remove, and removing them
9079 makes further changes easier.
9081 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9082 This doesn't fix a bug but makes the code clearer.
9083 (string_overrun_cookie): Now const. Use initializers that
9084 don't formally overflow signed char, to avoid warnings.
9085 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9086 can cause Emacs to crash when string overrun checking is enabled.
9087 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9088 multiple of sizeof (EMACS_INT); it need not be, if
9089 alignof(EMACS_INT) < sizeof (EMACS_INT).
9090 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9092 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9094 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9096 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9098 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9099 supposed to be handshaking. (Bug#8556)
9100 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9102 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9104 * lisp.h (Qdebug): List symbol.
9105 * eval.c (Qdebug): Restore global linkage.
9106 * keyboard.c (debug-on-event): New variable.
9107 (handle_user_signal): Break into debugger when debug-on-event
9108 matches the current signal symbol.
9110 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9112 * alloc.c (check_sblock, check_string_bytes)
9113 (check_string_free_list): Convert to standard C.
9115 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9117 * w32.c (emacs_gnutls_push): Fix typo.
9119 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9121 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9122 "cast to pointer from integer of different size".
9124 Improve doprnt and its use in verror. (Bug#8545)
9125 * doprnt.c (doprnt): Document the set of format control sequences
9126 supported by the function. Use SAFE_ALLOCA instead of always
9129 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9130 is one byte too soon. Don't use xrealloc; instead xfree and
9133 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9135 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9138 * gnutls.c: Renamed global_initialized to
9139 gnutls_global_initialized. Added internals for the
9140 :verify-hostname-error, :verify-error, and :verify-flags
9141 parameters of `gnutls-boot' and documented those parameters in the
9142 docstring. Start callback support.
9143 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9144 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9145 on error. Return error code.
9146 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9147 (emacs_gnutls_read): Likewise.
9148 (Fgnutls_boot): Return handshake error code.
9149 (emacs_gnutls_handle_error): New function.
9150 (wsaerror_to_errno): Likewise.
9152 * w32.h (emacs_gnutls_pull): Add prototype.
9153 (emacs_gnutls_push): Likewise.
9155 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9156 (emacs_gnutls_push): Likewise.
9158 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9160 * process.c (wait_reading_process_output): Check if GnuTLS
9161 buffered some data internally if no FDs are set for TLS
9164 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9165 (LIBS): Link to USER_LIBS.
9166 ($(BLD)/gnutls.$(0)): New target.
9168 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9170 * xdisp.c (handle_single_display_spec): Rename the
9171 display_replaced_before_p argument into display_replaced_p, to
9172 make it consistent with the commentary. Fix typos in the
9175 * textprop.c (syms_of_textprop): Remove dead code.
9176 (copy_text_properties): Delete obsolete commentary about an
9177 interface that was deleted long ago. Fix typos in the description
9180 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9181 to changes in oldXMenu/XMenu.h from 2011-04-16.
9182 <menu_help_message, prev_menu_help_message>: Constify.
9183 (IT_menu_make_room): menu->help_text is now `const char **';
9186 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9187 to changes in oldXMenu/XMenu.h from 2011-04-16.
9188 (struct XMenu): Declare `help_text' `const char **'.
9190 * xfaces.c <Qunspecified>: Make extern again.
9192 * syntax.c: Include sys/types.h before including regex.h, as
9195 * doc.c (get_doc_string): Improve the format passed to `error'.
9197 * doprnt.c (doprnt): Improve commentary.
9199 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9201 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9204 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9205 changes in globals.h immediately force recompilation.
9206 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9207 $(CURDIR)/s/ms-w32.h.
9208 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9210 * character.c (Fchar_direction): Function deleted.
9211 (syms_of_character): Don't defsubr it.
9212 <char-direction-table>: Deleted.
9214 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9216 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9217 * doprnt.c: Include limits.h.
9218 (SIZE_MAX): New macro.
9219 (doprnt): Return a size_t value. 2nd arg is now size_t.
9220 Many local variables are now size_t instead of int or unsigned.
9221 Improve overflow protection. Support `l' modifier for integer
9222 conversions. Support %l conversion. Don't assume an EMACS_INT
9223 argument for integer conversions and for %c.
9225 * lisp.h (doprnt): Restore prototype.
9227 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9230 * Makefile.in (base_obj): Add back doprnt.o.
9232 * deps.mk (doprnt.o): Add back prerequisites.
9233 (callint.o): Depend on character.h.
9235 * eval.c (internal_lisp_condition_case): Include the handler
9236 representation in the error message.
9237 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9238 when breaking from the loop.
9240 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9242 * callint.c (Fcall_interactively): When displaying error message
9243 about invalid control letter, pass the character's codepoint, not
9244 a pointer to its multibyte form. Improve display of the character
9245 in octal and display also its hex code.
9247 * character.c (char_string): Use %x to display the (unsigned)
9248 codepoint of an invalid character, to avoid displaying a bogus
9251 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9252 `error', not SYMBOL_NAME itself.
9254 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9255 character arguments to `error'.
9257 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9258 to `error' in error message about FINAL_CHAR argument. Make sure
9259 FINAL_CHAR is a character, and use %c when it is passed as
9260 argument to `error'.
9262 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9264 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9266 * w32.c: Include <time.h>.
9267 (sys_localtime): New function.
9269 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9271 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9273 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9275 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9277 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9280 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9282 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9283 gl_state.e_property when gl_state.object is Qt.
9285 * insdel.c (make_gap_larger): Remove limitation of buffer size
9288 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9290 * xdisp.c (lookup_glyphless_char_display)
9291 (produce_glyphless_glyph): Handle cons cell entry in
9292 glyphless-char-display.
9293 (Vglyphless_char_display): Document it.
9295 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9296 glyphless-char-display.
9298 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9300 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9302 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9305 definition for no-X builds.
9307 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9309 Static checks with GCC 4.6.0 and non-default toolkits.
9311 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9313 * process.c (keyboard_bit_set): Define only if SIGIO.
9314 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9315 (send_process): Repair possible setjmp clobbering.
9317 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9319 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9321 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9323 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9324 Define only if needed.
9326 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9327 by pacifying GCC about it. Maybe it's time to retire it?
9328 * xfaces.c (USG, __TIMEVAL__): Likewise.
9330 * dispextern.h (struct redisplay_interface): Rename param
9332 * termhooks.h (struct terminal): Likewise.
9333 * xterm.c (xembed_send_message): Likewise.
9335 * insdel.c (make_gap_smaller): Define only if
9336 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9338 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9341 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9342 so that we aren't warned about unused symbols.
9344 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9346 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9348 * xfns.c (x_real_positions): Mark locals as initialized.
9350 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9352 * xterm.c: Fix problems found by static analysis with other toolkits.
9353 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9354 (x_dispatch_event): Declare static if USE_GTK, and
9355 define if USE_GTK || USE_X_TOOLKIT.
9356 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9357 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9358 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9359 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9361 * xmenu.c (menu_help_callback): Pointer type fixes.
9362 Use const pointers when pointing at readonly data. Avoid pointer
9364 (FALSE): Remove unused macro.
9365 (update_frame_menubar): Remove unused decl.
9367 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9369 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9370 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9371 (single_menu_item): Rename local to avoid shadowing.
9373 * keyboard.c (make_lispy_event): Remove unused local var.
9375 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9376 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9378 * bitmaps: Change bitmaps from unsigned char back to the X11
9379 compatible char. Avoid the old compiler warnings about
9380 out-of-range initializers by using, for example, '\xab' rather
9383 * xgselect.c (xgselect_initialize): Check vs interface
9384 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9386 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9388 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9389 to read-only memory.
9391 * fns.c (vector): Remove; this old hack is no longer needed.
9393 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9395 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9397 * xrdb.c (x_load_resources): Omit unused local.
9399 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9400 (x_window): Rename locals to avoid shadowing.
9401 (USG): Use the kludged USG macro, to pacify gcc.
9403 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9404 (x_term_init): Remove local to avoid shadowing.
9406 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9408 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9409 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9411 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9413 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9415 Fix regex.c, syntax.c and friends for buffers > 2GB.
9416 * syntax.h (struct gl_state_s): Declare character position members
9419 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9421 * textprop.c (verify_interval_modification, interval_of):
9422 Declare arguments EMACS_INT.
9424 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9427 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9429 * indent.c (Fvertical_motion): Local variable it_start is now
9432 * regex.c (re_match, re_match_2, re_match_2_internal)
9433 (bcmp_translate, regcomp, regexec, print_double_string)
9434 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9435 (re_compile_pattern, re_exec): Declare arguments and local
9436 variables `size_t' and `ssize_t' and return values `regoff_t', as
9438 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9439 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9440 <compile_stack_type>: `size' and `avail' are now `size_t'.
9442 * regex.h <regoff_t>: Use ssize_t, not int.
9443 (re_search, re_search_2, re_match, re_match_2): Arguments that
9444 specify buffer/string position and length are now ssize_t and
9445 size_t. Return type is regoff_t.
9447 2011-04-16 Ben Key <bkey76@gmail.com>
9449 * nsfont.m: Fixed bugs in ns_get_family and
9450 ns_descriptor_to_entity that were caused by using free to
9451 deallocate memory blocks that were allocated by xmalloc (via
9452 xstrdup). This caused Emacs to crash when compiled with
9453 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9454 --enable-checking=xmallocoverrun). xfree is now used to
9455 deallocate these memory blocks.
9457 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9459 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9461 emacs_write: Accept and return EMACS_INT for sizes.
9462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9464 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9465 Accept and return EMACS_INT.
9466 (emacs_gnutls_write): Return the number of bytes written on
9468 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9469 (emacs_read, emacs_write): Remove check for negative size, as the
9470 Emacs source code has been audited now.
9471 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9472 (emacs_read, emacs_write): Use it.
9473 * process.c (send_process): Adjust to the new signatures of
9474 emacs_write and emacs_gnutls_write. Do not attempt to store
9475 a byte offset into an 'int'; it might overflow.
9476 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9478 * sound.c: Don't assume sizes fit in 'int'.
9479 (struct sound_device.period_size, alsa_period_size):
9480 Return EMACS_INT, not int.
9481 (struct sound_device.write, vox_write, alsa_write):
9482 Accept EMACS_INT, not int.
9483 (wav_play, au_play): Use EMACS_INT to store sizes and to
9484 record read return values.
9486 2011-04-15 Ben Key <bkey76@gmail.com>
9488 * keyboard.c (Qundefined): Don't declare static since it is used
9490 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9491 static since they are used in nsfont.m.
9493 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9495 * process.c (Qprocessp): Don't declare static.
9496 * lisp.h (Qprocessp): Declare again.
9498 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9500 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9502 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9504 Improve C-level modularity by making more things 'static'.
9506 Don't publish debugger-only interfaces to other modules.
9507 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9508 (verify_bytepos, count_markers): Move decls to the only modules
9510 * region-cache.h (pp_cache): Likewise.
9511 * window.h (check_all_windows): Likewise.
9512 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9514 * sysdep.c (croak): Now static, if
9515 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9516 * syssignal.h (croak): Declare only if not static.
9518 * alloc.c (refill_memory_reserve): Now static if
9519 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9520 * lisp.h (refill_memory_reserve): Declare only if not static.
9522 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9523 Define only if USE_LUCID.
9525 * xrdb.c (x_customization_string, x_rm_string): Now static.
9527 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9528 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9530 * xdisp.c (draw_row_with_mouse_face): Now static.
9531 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9533 * window.h (check_all_windows): Mark externally visible.
9535 * window.c (window_deletion_count): Now static.
9537 * undo.c: Make symbols static if they're not exported.
9538 (last_undo_buffer, last_boundary_position, pending_boundary):
9541 * textprop.c (interval_insert_behind_hooks): Now static.
9542 (interval_insert_in_front_hooks): Likewise.
9544 * term.c: Make symbols static if they're not exported.
9545 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9546 (max_frame_lines, tty_set_terminal_modes):
9547 (tty_reset_terminal_modes, tty_turn_off_highlight):
9548 (get_tty_terminal): Now static.
9549 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9550 * termhooks.h (term_mouse_moveto): Do not declare if
9552 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9553 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9555 * sysdep.c: Make symbols static if they're not exported.
9556 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9558 (sigprocmask_set, full_mask): Remove; unused.
9559 (wait_debugging): Mark as visible.
9560 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9561 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9563 * syntax.c (syntax_temp): Define only if !__GNUC__.
9565 * sound.c (current_sound_device, current_sound): Now static.
9567 * search.c (searchbufs, searchbuf_head): Now static.
9569 * scroll.c (scroll_cost): Remove; unused.
9570 * dispextern.h (scroll_cost): Remove decl.
9572 * region-cache.h (pp_cache): Mark as externally visible.
9574 * process.c: Make symbols static if they're not exported.
9575 (process_tick, update_tick, create_process, chan_process):
9576 (Vprocess_alist, proc_buffered_char, datagram_access):
9577 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9578 (deactivate_process): Mark defn as static, as well as decl.
9579 * lisp.h (create_process): Remove decl.
9580 * process.h (chan_process, Vprocess_alist): Remove decls.
9582 * print.c: Make symbols static if they're not exported.
9583 (print_depth, new_backquote_output, being_printed, print_buffer):
9584 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9585 (print_interval, print_number_index, initial_stderr_stream):
9587 * lisp.h (Fprinc): Remove decl.
9588 (debug_output_compilation_hack): Mark as externally visible.
9590 * sysdep.c (croak): Move decl from here to syssignal.h.
9591 * syssignal.h (croak): Put it here, so the API can be checked when
9592 'croak' is called from dissociate_if_controlling_tty.
9594 * minibuf.c: Make symbols static if they're not exported.
9595 (minibuf_save_list, choose_minibuf_frame): Now static.
9596 * lisp.h (choose_minibuf_frame): Remove decl.
9598 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9600 * lread.c: Make symbols static if they're not exported.
9601 (read_objects, initial_obarray, oblookup_last_bucket_number):
9603 (make_symbol): Remove; unused.
9604 * lisp.h (initial_obarray, make_symbol): Remove decls.
9606 * keyboard.c: Make symbols static if they're not exported.
9607 (single_kboard, recent_keys_index, total_keys, recent_keys):
9608 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9609 (this_single_command_key_start, echoing, last_auto_save):
9610 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9611 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9612 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9613 (Vlispy_mouse_stem, double_click_count):
9615 (force_auto_save_soon): Define only if SIGDANGER.
9616 (ignore_mouse_drag_p): Now static if
9617 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9618 (print_help): Remove; unused.
9619 (stop_character, last_timer_event): Mark as externally visible.
9620 * keyboard.h (ignore_mouse_drag_p): Declare only if
9621 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9622 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9623 * lisp.h (echoing): Remove decl.
9624 (force_auto_save_soon): Declare only if SIGDANGER.
9625 * xdisp.c (redisplay_window): Simplify code, to make it more
9626 obvious that ignore_mouse_drag_p is not accessed if !defined
9627 USE_GTK && !defined HAVE_NS.
9629 * intervals.c: Make symbols static if they're not exported.
9630 (merge_properties_sticky, merge_interval_right, delete_interval):
9632 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9634 * insdel.c: Make symbols static if they're not exported.
9635 However, leave prepare_to_modify_buffer alone. It's never
9636 called from outside this function, but that appears to be a bug.
9637 (combine_after_change_list, combine_after_change_buffer):
9638 (adjust_after_replace, signal_before_change): Now static.
9639 (adjust_after_replace_noundo): Remove; unused.
9640 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9641 (signal_before_change): Remove decls.
9643 * indent.c (val_compute_motion, val_vmotion): Now static.
9645 * image.c: Make symbols static if they're not exported.
9646 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9648 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9649 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9651 * fringe.c (standard_bitmaps): Now static.
9652 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9654 * frame.c: Make symbols static if they're not exported.
9655 (x_report_frame_params, make_terminal_frame): Now static.
9656 (get_frame_param): Now static, unless HAVE_NS.
9657 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9658 (x_get_resource_string): Remove; not used.
9659 * frame.h (make_terminal_frame, x_report_frame_params):
9660 (x_get_resource_string); Remove decls.
9661 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9662 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9664 * font.c, fontset.c: Make symbols static if they're not exported.
9665 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9666 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9667 * font.c (font_close_object): Now static.
9668 * font.h (font_close_object): Remove.
9669 * fontset.c (FONTSET_OBJLIST): Remove.
9670 (free_realized_fontset) #if-0 the body, which does nothing.
9671 (face_suitable_for_char_p): #if-0, as it's never called.
9672 * fontset.h (face_suitable_for_char_p): Remove decl.
9673 * xfaces.c (face_at_string_position):
9674 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9675 since 0 is always ASCII.
9677 * fns.c (weak_hash_tables): Now static.
9679 * fileio.c: Make symbols static if they're not exported.
9680 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9681 (Vwrite_region_annotation_buffers): Now static.
9683 * eval.c: Make symbols static if they're not exported.
9684 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9685 * lisp.h (backtrace_list): Remove decl.
9687 * emacs.c: Make symbols static if they're not exported.
9688 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9689 (fatal_error_code, fatal_error_signal_hook, standard_args):
9691 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9692 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9693 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9694 * lisp.h (fatal_error_signal_hook): Remove decl.
9695 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9697 * editfns.c: Move a (normally-unused) function to its only use.
9698 * editfns.c, lisp.h (get_operating_system_release): Remove.
9699 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9700 worth the hassle of breaking this out.
9702 * xterm.c: Make symbols static if they're not exported.
9703 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9704 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9705 (x_destroy_window, x_delete_display):
9707 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9708 (x_mouse_leave): Remove; unused.
9709 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9710 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9711 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9713 (x_mouse_leave): Declare only if WINDOWSNT.
9714 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9715 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9718 * ftxfont.c: Make symbols static if they're not exported.
9719 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9721 * font.h (ftxfont_driver): Likewise.
9723 * xfns.c: Make symbols static if they're not exported.
9724 (x_last_font_name, x_display_info_for_name):
9725 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9726 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9727 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9728 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9729 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9730 (last_show_tip_args): Now static.
9731 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9732 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9733 (x_screen_planes): Remove; unused.
9734 * dispextern.h (x_screen_planes): Remove decl.
9736 * dispnew.c: Make symbols static if they're not exported.
9737 * dispextern.h (redraw_garbaged_frames, scrolling):
9738 (increment_row_positions): Remove.
9739 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9740 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9742 (redraw_garbaged_frames): Remove; unused.
9744 * xfaces.c: Make symbols static if they're not exported.
9745 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9747 * xterm.h (defined_color): Remove decls.
9748 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9749 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9750 (menu_face_changed_default, defined_color, free_realized_face):
9751 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9752 (ascii_face_of_lisp_face): Remove; unused.
9754 * xdisp.c: Make symbols static if they're not exported.
9755 * dispextern.h (scratch_glyph_row, window_box_edges):
9756 (glyph_to_pixel_coords, set_cursor_from_row):
9757 (get_next_display_element, set_iterator_to_next):
9758 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9759 (show_mouse_face): Remove decls
9760 * frame.h (message_buf_print): Likewise.
9761 * lisp.h (pop_message, set_message, check_point_in_composition):
9763 * xterm.h (set_vertical_scroll_bar): Likewise.
9764 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9765 (message_buf_print, scratch_glyph_row, displayed_buffer):
9766 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9767 (get_next_display_element, show_mouse_face, window_box_edges):
9768 (frame_to_window_pixel_xy, check_point_in_composition):
9769 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9770 (glyph_to_pixel_coords): Remove; unused.
9772 * dired.c (file_name_completion): Now static.
9774 * dbusbind.c (xd_in_read_queued_messages): Now static.
9776 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9777 * data.c (circular_list_error): Remove.
9779 * commands.h (last_point_position, last_point_position_buffer):
9780 (last_point_position_window): Remove decls.
9781 * keyboard.c: Make these variables static.
9783 * coding.h (coding, code_convert_region, encode_coding_gap):
9785 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9786 (iso_code_class, detect_coding, code_convert_region): Now static.
9787 (encode_coding_gap): Remove; unused.
9789 * chartab.c (chartab_chars, chartab_bits): Now static.
9791 * charset.h (charset_iso_8859_1): Remove decl.
9792 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9795 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9796 * ccl.c (Vccl_program_table): Now static.
9797 (check_ccl_update): Remove; unused.
9799 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9800 * category.h: ... from here.
9801 * category.c (check_category_table, set_category_set): Now static.
9803 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9804 * lisp.h: Remove these decls.
9806 * buffer.c (buffer_count): Remove unused var.
9808 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9809 so that it's not optimized away.
9810 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9811 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9812 exported only to the debugger.
9814 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9815 * atimer.h (run_all_atimers): Remove; not exported.
9817 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9818 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9819 was inaccessible from Lisp.
9820 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9821 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9823 alloc.c: Import and export fewer symbols, and remove unused items.
9824 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9826 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9827 it's not optimized away by whole-program optimization.
9828 (message_enable_multibyte, free_misc): Remove.
9829 (catchlist, handlerlist, mark_backtrace):
9830 Declare only if BYTE_MARK_STACK.
9831 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9832 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9833 (message_enable_multibyte): Remove decl.
9834 (free_misc, interval_free_list, float_block, float_block_index):
9835 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9836 (cons_free_list, last_marked_index):
9838 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9839 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9840 (mark_backtrace): Define only if BYTE_MARK_STACK.
9841 * xdisp.c (message_enable_multibyte): Now static.
9843 Declare Lisp_Object Q* variables to be 'static' if not exported.
9844 This makes it easier for human readers (and static analyzers)
9845 to see whether these variables are used from other modules.
9846 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9847 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9848 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9849 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9850 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9851 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9852 * xmenu.c, xselect.c:
9853 Declare Q* vars static if they are not used in other modules.
9854 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9855 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9856 Remove decls of unexported vars.
9857 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9859 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9861 Make Emacs functions such as Fatom 'static' by default.
9862 This makes it easier for human readers (and static analyzers)
9863 to see whether these functions can be called from other modules.
9864 DEFUN now defines a static function. To make the function external
9865 so that it can be used in other C modules, use the new macro DEFUE.
9866 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9867 (Finit_image_library):
9868 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9869 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9870 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9871 Remove decls, since these functions are now static.
9872 (Funintern, Fget_internal_run_time): New decls, since these functions
9873 were already external.
9875 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9876 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9878 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9879 * keyboard.c, keymap.c, lread.c:
9880 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9881 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9882 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9883 Mark functions with DEFUE instead of DEFUN,
9884 if they are used in other modules.
9885 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9886 decls for now-static functions.
9887 * buffer.h (Fdelete_overlay): Remove decl.
9888 * callproc.c (Fgetenv_internal): Mark as internal.
9889 * composite.c (Fremove_list_of_text_properties): Remove decl.
9890 (Fcomposition_get_gstring): New forward static decl.
9891 * composite.h (Fcomposite_get_gstring): Remove decl.
9892 * dired.c (Ffile_attributes): New forward static decl.
9893 * doc.c (Fdocumntation_property): New forward static decl.
9894 * eval.c (Ffetch_bytecode): New forward static decl.
9895 (Funintern): Remove extern decl; now in .h file where it belongs.
9896 * fileio.c (Fmake_symbolic_link): New forward static decl.
9897 * image.c (Finit_image_library): New forward static decl.
9898 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9899 * intervals.h (Fprevious_property_change):
9900 (Fremove_list_of_text_properties): Remove decls.
9901 * keyboard.c (Fthis_command_keys): Remove decl.
9902 (Fcommand_execute): New forward static decl.
9903 * keymap.c (Flookup_key): New forward static decl.
9904 (Fcopy_keymap): Now static.
9905 * keymap.h (Flookup_key): Remove decl.
9906 * process.c (Fget_process): New forward static decl.
9907 (Fprocess_datagram_address): Mark as internal.
9908 * syntax.c (Fsyntax_table_p): New forward static decl.
9909 (skip_chars): Remove duplicate decl.
9910 * textprop.c (Fprevious_property_change): New forward static decl.
9911 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9913 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9914 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9916 * editfns.c (Fformat): Remove unreachable code.
9918 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9920 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9923 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9925 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9926 when at ZV. (Bug#8487)
9928 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9930 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9932 * keyboard.c (parse_tool_bar_item): Likewise.
9933 * sound.c (sound_cleanup, alsa_close): Likewise.
9934 * termcap.c (tgetent): Likewise.
9935 * xfns.c (x_default_font_parameter): Likewise.
9936 * xsettings.c (read_and_apply_settings): Likewise.
9938 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9939 (overrun_check_free): Protoize.
9941 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9943 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9944 since callers should never pass a negative size.
9945 Change the signature to match that of plain 'read' and 'write'; see
9946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9947 * lisp.h: Update prototypes of emacs_write and emacs_read.
9949 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9951 * xdisp.c (redisplay_window): Don't try to determine the character
9952 position of the scroll margin if the window start point w->startp
9953 is outside the buffer's accessible region. (Bug#8468)
9955 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9957 Fix write-region and its subroutines for buffers > 2GB.
9958 * fileio.c (a_write, e_write): Modify declaration of arguments and
9959 local variables to support buffers larger than 2GB.
9960 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9962 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9963 argument, local variables, and return value.
9965 * lisp.h: Update prototypes of emacs_write and emacs_read.
9967 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9969 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9971 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9973 Fix more problems found by GCC 4.6.0's static checks.
9975 * xdisp.c (vmessage): Use a better test for character truncation.
9977 * charset.c (load_charset_map): <, not <=, for optimization,
9978 and to avoid potential problems with integer overflow.
9979 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9980 * casetab.c (set_identity, shuffle): Likewise.
9981 * editfns.c (Fformat): Likewise.
9982 * syntax.c (skip_chars): Likewise.
9984 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9985 This also lets GCC 4.6.0 generate slightly better loop code.
9987 * callint.c (Fcall_interactively): <, not <=, for optimization.
9988 (Fcall_interactively): Count the number of arguments produced,
9989 not the number of arguments given. This is simpler and lets GCC
9990 4.6.0 generate slightly better code.
9992 * ftfont.c: Distingish more carefully between FcChar8 and char.
9993 The previous code passed unsigned char * to a functions like
9994 strlen and xstrcasecmp that expect char *, which does not
9995 conform to the C standard.
9996 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9997 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9998 char * when the C standard requires it.
10000 * keyboard.c (read_char): Remove unused var.
10002 * eval.c: Port to Windows vsnprintf (Bug#8435).
10003 Include <limits.h>.
10004 (SIZE_MAX): Define if the headers do not.
10005 (verror): Do not give up if vsnprintf returns a negative count.
10006 Instead, grow the buffer. This ports to Windows vsnprintf, which
10007 does not conform to C99. Problem reported by Eli Zaretskii.
10008 Also, simplify the allocation scheme, by avoiding the need for
10009 calling realloc, and removing the ALLOCATED variable.
10011 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10013 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10014 But keep the doprint source code for now, as we might revamp it
10015 and use it again (Bug#8435).
10016 * lisp.h (doprnt): Remove.
10017 * Makefile.in (base_obj): Remove doprnt.o.
10018 * deps.mk (doprnt.o): Remove.
10020 error: Print 32- and 64-bit integers portably (Bug#8435).
10021 Without this change, on typical 64-bit hosts error ("...%d...", N)
10022 was used to print both 32- and 64-bit integers N, which relied on
10023 undefined behavior.
10024 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10025 * lisp.h (error, verror): Mark as printf-like functions.
10026 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10027 Report overflow in size calculations when allocating printf buffer.
10028 Do not truncate output string at its first null byte.
10029 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10030 Truncate the output at a character boundary, since vsnprintf does not
10032 * charset.c (check_iso_charset_parameter): Convert internal
10033 character to string before calling 'error', since %c now has the
10035 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10036 overflow when computing char to be passed to 'error'. Do not
10037 pass Lisp_Object to 'error'; pass the integer instead.
10038 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10039 formatted with plain %d.
10041 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10043 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10045 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10047 * xterm.c (x_catch_errors): Remove duplicate declaration.
10049 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10051 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10053 2011-04-10 Jim Meyering <meyering@redhat.com>
10055 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10056 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10057 return ssize_t not "int", and use size_t as the buffer length.
10058 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10059 * gnutls.h: Update declarations.
10060 * process.c (read_process_output): Use ssize_t, to match.
10061 (send_process): Likewise.
10063 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10065 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10067 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10069 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10070 Use unsigned char, to match FcChar8 type definition.
10072 * xterm.c (handle_one_xevent):
10073 * xmenu.c (create_and_show_popup_menu):
10074 * xselect.c (x_decline_selection_request)
10075 (x_reply_selection_request): Avoid type-punned deref of X events.
10077 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10079 Fix some uses of `int' instead of EMACS_INT.
10080 * search.c (string_match_1, fast_string_match)
10081 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10082 (scan_buffer, find_next_newline_no_quit)
10083 (find_before_next_newline, search_command, Freplace_match)
10084 (Fmatch_data): Make some `int' variables be EMACS_INT.
10086 * xdisp.c (display_count_lines): 3rd argument and return value now
10087 EMACS_INT. All callers changed.
10088 (pint2hrstr): Last argument is now EMACS_INT.
10090 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10091 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10092 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10093 (decode_coding_utf_16, decode_coding_emacs_mule)
10094 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10095 (decode_coding_ccl, decode_coding_charset)
10096 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10097 (decode_coding_iso_2022, decode_coding_emacs_mule)
10098 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10099 <char_offset, last_offset>: Declare EMACS_INT.
10100 (encode_coding_utf_8, encode_coding_utf_16)
10101 (encode_coding_emacs_mule, encode_invocation_designation)
10102 (encode_designation_at_bol, encode_coding_iso_2022)
10103 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10104 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10106 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10107 (encode_invocation_designation): Last argument P_NCHARS is now
10109 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10110 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10112 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10115 * ccl.c (Fccl_execute_on_string): Declare some variables
10118 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10120 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10122 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10124 * process.c (Fformat_network_address): Doc fix.
10126 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10128 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10130 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10132 * keyboard.c (read_char): Call Lisp function help-form-show,
10133 instead of using internal_with_output_to_temp_buffer.
10134 (Qhelp_form_show): New var.
10135 (syms_of_keyboard): Use DEFSYM macro.
10137 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10139 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10141 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10143 * process.c (Flist_processes): Remove to Lisp.
10144 (list_processes_1): Delete.
10146 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10148 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10150 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10152 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10154 Fix more problems found by GCC 4.6.0's static checks.
10156 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10158 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10160 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10162 * xdisp.c (vmessage): Mark as a printf-like function.
10164 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10166 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10168 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10169 printf-like functions.
10170 (tiff_load): Add casts to remove these marks before passing them
10171 to system-supplied API.
10173 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10175 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10176 This avoids several warnings with gcc -Wstrict-overflow.
10177 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10178 directly, rather than having caller test rule sign. This avoids
10179 some unnecessary tests.
10180 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10181 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10182 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10184 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10185 (xfont_open): Avoid unnecessary tests.
10187 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10189 * composite.h, composite.c (composition_gstring_put_cache):
10190 Use EMACS_INT, not int, for length.
10192 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10193 breaking out part of COMPOSITION_DECODE_RULE.
10194 (COMPOSITION_DECODE_RULE): Use it.
10195 * composite.c (get_composition_id): Remove unused local vars,
10196 by using the new macro.
10198 * textprop.c (set_text_properties_1): Change while to do-while,
10199 since the condition is always true at first.
10201 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10202 (interval_deletion_adjustment): Return unsigned value.
10205 * process.c (list_processes_1, create_pty, read_process_output):
10206 (exec_sentinel): Remove vars that were set but not used.
10207 (create_pty): Remove unnecessary "volatile"s.
10208 (Fnetwork_interface_info): Avoid possibility of int overflow.
10209 (read_process_output): Do adaptive read buffering even if carryover.
10210 (read_process_output): Simplify nbytes computation if buffered.
10212 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10214 * syntax.c (scan_words): Remove var that was set but not used.
10215 (update_syntax_table): Use unsigned instead of int.
10217 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10218 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10219 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10221 * print.c (print_error_message): Avoid int overflow.
10223 * font.c (font_list_entities): Redo for clarity,
10224 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10226 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10227 (font_score): Avoid potential overflow in diff calculation.
10229 * fns.c (substring_both): Remove var that is set but not used.
10230 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10232 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10234 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10235 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10236 can always succeed if overflow has undefined behavior.
10238 * search.c (boyer_moore, wordify): Remove vars set but not used.
10239 (wordify): Omit three unnecessary tests.
10241 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10242 All callers changed. This avoids the need for an unused var.
10244 * casefiddle.c (casify_region): Remove var that is set but not used.
10246 * dired.c (file_name_completion): Remove var that is set but not used.
10248 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10250 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10251 (Finsert_file_contents): Remove unnecessary code checking fd.
10253 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10254 Check for integer overflow on size calculations.
10256 * buffer.c (Fprevious_overlay_change): Remove var that is set
10259 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10260 Remove vars that are set but not used.
10261 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10262 (timer_check_2): Mark vars as initialized.
10264 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10266 * image.c (lookup_image): Remove var that is set but not used.
10267 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10269 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10270 that are set but not used.
10272 * xfns.c (make_invisible_cursor): Don't return garbage
10273 if XCreateBitmapFromData fails (Bug#8410).
10275 * xselect.c (x_get_local_selection, x_handle_property_notify):
10276 Remove vars that are set but not used.
10278 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10279 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10281 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10282 Remove var that is set but not used.
10283 (scroll_bar_windows_size): Now size_t, not int.
10284 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10285 Check for overflow.
10287 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10288 (map_tty_color) [!defined MSDOS]: Likewise.
10290 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10292 * coding.c: Remove vars that are set but not used.
10293 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10294 All callers changed.
10295 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10296 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10297 (decode_coding_charset): Remove vars that are set but not used.
10299 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10300 that is set but not used.
10302 * print.c (print_object): Remove var that is set but not used.
10304 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10305 The gnulib version avoids calling malloc in the usual case,
10306 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10307 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10308 * filelock.c (current_lock_owner): Likewise.
10309 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10310 * sysdep.c: Include allocator.h, careadlinkat.h.
10311 (emacs_no_realloc_allocator): New static constant.
10312 (emacs_readlink): New function.
10313 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10314 ../lib/careadlinkat.h.
10316 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10318 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10319 first non-nil return value).
10321 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10323 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10324 if not defined (Bug#8403).
10326 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10328 * xdisp.c (display_count_lines): Remove parameter `start',
10329 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10330 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10331 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10332 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10333 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10334 and thereabouts. All callers changed.
10335 (get_per_char_metric): Remove parameter `f', unused since
10336 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10338 2011-04-02 Jim Meyering <meyering@redhat.com>
10340 do not dereference NULL upon failed strdup
10341 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10342 (ns_get_family): Likewise.
10344 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10346 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10348 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10350 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10353 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10355 Add lexical binding.
10357 * window.c (Ftemp_output_buffer_show): New fun.
10358 (Fsave_window_excursion):
10359 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10361 * lread.c (lisp_file_lexically_bound_p): New function.
10362 (Fload): Bind Qlexical_binding.
10363 (readevalloop): Remove `evalfun' arg.
10364 Bind Qinternal_interpreter_environment.
10365 (Feval_buffer): Bind Qlexical_binding.
10366 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10368 (syms_of_lread): Declare `lexical-binding'.
10370 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10372 * keyboard.c (eval_dyn): New fun.
10373 (menu_item_eval_property): Use it.
10375 * image.c (parse_image_spec): Use Ffunctionp.
10377 * fns.c (concat, mapcar1): Accept byte-code-functions.
10379 * eval.c (Fsetq): Handle lexical vars.
10380 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10381 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10382 (FletX, Flet): Obey lexical binding.
10383 (Fcommandp): Handle closures.
10384 (Feval): New `lexical' arg.
10385 (eval_sub): New function extracted from Feval. Use it almost
10386 everywhere where Feval was used. Look up vars in lexical env.
10388 (Ffunctionp): Move from subr.el.
10389 (Ffuncall): Handle closures.
10390 (apply_lambda): Remove `eval_flags'.
10391 (funcall_lambda): Handle closures and new byte-code-functions.
10392 (Fspecial_variable_p): New function.
10393 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10394 but without exporting it to Lisp.
10396 * doc.c (Fdocumentation, store_function_docstring):
10397 * data.c (Finteractive_form): Handle closures.
10399 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10402 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10404 (exec_byte_code): New function extracted from Fbyte_code to handle new
10405 calling convention for byte-code-functions. Add new byte-codes.
10407 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10409 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10411 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10413 * xdisp.c (redisplay_internal): Fix prototype.
10415 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10417 * xdisp.c (SCROLL_LIMIT): New macro.
10418 (try_scrolling): Use it when setting scroll_limit.
10419 Limit scrolling to 100 screen lines.
10420 (redisplay_window): Even when falling back on "recentering",
10421 position point in the window according to scroll-conservatively,
10422 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10424 (try_scrolling): When point is above the window, allow searching
10425 as far as scroll_max, or one screenful, to compute vertical
10426 distance from PT to the scroll margin position. This prevents
10427 try_scrolling from unnecessarily failing when
10428 scroll-conservatively is set to a value slightly larger than the
10429 window height. Clean up the case of PT below the margin at bottom
10430 of window: scroll_max can no longer be INT_MAX. When aggressive
10431 scrolling is in use, don't let point enter the opposite scroll
10432 margin as result of the scroll.
10433 (syms_of_xdisp) <scroll-conservatively>: Document the
10434 threshold of 100 lines for never-recentering scrolling.
10436 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10438 * dispextern.h (move_it_by_lines):
10439 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10440 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10441 (message_log_check_duplicate): Remove parameters `prev_bol' and
10442 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10443 (redisplay_internal): Remove parameter `preserve_echo_area',
10444 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10446 * indent.c (Fvertical_motion):
10447 * window.c (window_scroll_pixel_based, Frecenter):
10448 Don't pass `need_y_p' to `move_it_by_lines'.
10450 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10452 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10453 steal a few bits to be more compact.
10454 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10455 Remove unneeded casts.
10457 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10459 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10461 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10462 binding" message (bug#7967).
10464 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10466 Fix more problems found by GCC 4.6.0's static checks.
10468 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10469 Remove unused local var.
10471 * editfns.c (Fmessage_box): Remove unused local var.
10473 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10474 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10475 Omit unused local vars.
10476 * window.c (shrink_windows): Omit unused local var.
10477 * menu.c (digest_single_submenu): Omit unused local var.
10478 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10479 Omit unused local var.
10481 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10482 Don't assume string length fits in int.
10483 (keyremap_step, read_key_sequence): Use size_t for sizes.
10484 (read_key_sequence): Don't check last_real_key_start redundantly.
10486 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10487 instead of alloca (Bug#8344).
10489 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10490 (Fbacktrace_frame): Don't assume nframes fits in int.
10492 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10494 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10497 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10499 * cm.c (calccost): Turn while-do into do-while, for clarity.
10501 * keyboard.c (syms_of_keyboard): Use the same style as later
10502 in this function when indexing through an array. This also
10503 works around GCC bug 48267.
10505 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10507 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10509 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10510 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10512 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10513 This avoids undefined behavior on integer overflow, and is a bit
10514 more convenient anyway since it is compared to a size_t variable.
10516 Variadic C functions now count arguments with size_t, not int.
10517 This avoids an unnecessary limitation on 64-bit machines, which
10518 caused (substring ...) to crash on large vectors (Bug#8344).
10519 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10520 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10521 All variadic functions and their callers changed accordingly.
10522 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10523 * data.c (arith_driver, float_arith_driver): Likewise.
10524 * editfns.c (general_insert_function): Likewise.
10525 * eval.c (struct backtrace.nargs, interactive_p)
10526 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10527 (funcall_lambda, mark_backtrace): Likewise.
10528 * fns.c (concat): Likewise.
10529 * frame.c (x_set_frame_parameters): Likewise.
10530 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10531 0 if not found, not -1. All callers changed.
10533 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10534 (stack_copy_size): Now size_t, not int.
10535 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10537 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10539 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10540 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10541 All callers changed.
10543 * lisp.h (multibyte_char_to_unibyte):
10544 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10545 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10546 * character.h (CHAR_TO_BYTE8):
10547 * cmds.c (internal_self_insert):
10548 * editfns.c (general_insert_function):
10549 * keymap.c (push_key_description):
10550 * search.c (Freplace_match):
10551 * xdisp.c (message_dolog, set_message_1): All callers changed.
10553 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10555 * keyboard.c (safe_run_hook_funcall): New function.
10556 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10557 don't set the hook to nil, but remove the offending function instead.
10558 (Qcommand_hook_internal): Remove, unused.
10559 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10560 Vcommand_hook_internal.
10562 * eval.c (enum run_hooks_condition): Remove.
10563 (funcall_nil, funcall_not): New functions.
10564 (run_hook_with_args): Call each function through a `funcall' argument.
10565 Remove `cond' argument, now redundant.
10566 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10567 (Frun_hook_with_args_until_failure): Adjust accordingly.
10568 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10570 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10572 * dispextern.h (string_buffer_position): Remove declaration.
10574 * print.c (strout): Remove parameter `multibyte', unused since
10575 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10577 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10578 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10579 All callers changed.
10581 * w32.c (_wsa_errlist): Use braces for struct initializers.
10583 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10584 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10585 All callers changed.
10586 (string_buffer_position): Likewise. Also, make static (it's never
10587 used outside xdisp.c).
10588 (cursor_row_p): Remove parameter `w', unused since
10589 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10590 (decode_mode_spec): Remove parameter `precision', introduced during
10591 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10592 All callers changed.
10594 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10596 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10598 2011-03-27 Anders Lindgren <andlind@gmail.com>
10600 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10601 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10602 (ns_update_auto_hide_menu_bar): New functions.
10603 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10604 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10605 ns_constrain_all_frames.
10606 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10607 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10609 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10611 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10613 2011-03-27 Glenn Morris <rgm@gnu.org>
10615 * syssignal.h: Replace RETSIGTYPE with void.
10616 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10617 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10618 Replace SIGTYPE with void everywhere.
10619 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10620 * s/template.h (SIGTYPE): Remove commented out definition.
10622 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10624 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10625 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10627 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10629 * w32.c (read_unc_volume): Use parameter `henum', instead of
10630 global variable `wget_enum_handle'.
10632 * keymap.c (describe_vector): Remove parameters `indices' and
10633 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10634 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10636 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10638 * keyboard.c (timer_check): Remove parameter `do_it_now',
10639 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10640 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10641 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10643 * keyboard.c (read_char):
10644 * w32menu.c (w32_menu_display_help):
10645 * xmenu.c (show_help_event, menu_help_callback):
10646 Adjust calls to `show_help_echo'.
10648 * gtkutil.c (xg_maybe_add_timer):
10649 * keyboard.c (readable_events):
10650 * process.c (wait_reading_process_output):
10651 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10653 * insdel.c (adjust_markers_gap_motion):
10654 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10655 (gap_left, gap_right): Don't call it.
10657 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10659 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10660 incurred during fontification.
10662 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10664 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10665 (DEFVAR_PER_BUFFER): Don't pass it.
10667 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10668 (scrolling_window): Don't pass it.
10670 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10672 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10674 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10676 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10677 of variables specific to SELinux and computation of `encoded_absname'.
10679 * image.c (XPutPixel): Remove unused variable `height'.
10681 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10683 * unexw32.c (get_section_info): Remove unused variable `section'.
10685 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10686 (system_process_attributes): Remove unused variable `sess'.
10687 (sys_read): Remove unused variable `err'.
10689 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10690 (w32_wnd_proc): Remove unused variable `isdead'.
10691 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10692 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10693 (x_create_tip_frame): Remove unused variable `tem'.
10695 * w32inevt.c (w32_console_read_socket):
10696 Remove unused variable `no_events'.
10698 * w32term.c (x_draw_composite_glyph_string_foreground):
10699 Remove unused variable `width'.
10701 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10703 * w32term.c (x_set_glyph_string_clipping):
10704 Don't pass uninitialized region to CombineRgn.
10706 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10708 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10709 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10710 (Fx_close_connection): Remove unused variable `i'.
10712 * w32font.c (w32font_draw): Return number of glyphs.
10713 (w32font_open_internal): Remove unused variable `i'.
10714 (w32font_driver): Add missing initializer.
10716 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10717 (fill_in_menu): Remove unused variable `items_added'.
10719 * w32term.c (last_mouse_press_frame): Remove static global variable.
10720 (w32_clip_to_row): Remove unused variable `f'.
10721 (x_delete_terminal): Remove unused variable `i'.
10723 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10724 (NOTHING): Remove unused static global variable.
10725 (uniscribe_check_otf): Remove unused variable `table'.
10726 (uniscribe_font_driver): Add missing initializers.
10728 2011-03-23 Julien Danjou <julien@danjou.info>
10730 * term.c (Fsuspend_tty, Fresume_tty):
10731 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10732 * window.c (temp_output_buffer_show):
10733 * insdel.c (signal_before_change):
10734 * frame.c (Fhandle_switch_frame):
10735 * fileio.c (Fdo_auto_save):
10736 * emacs.c (Fkill_emacs):
10737 * editfns.c (save_excursion_restore):
10738 * cmds.c (internal_self_insert):
10739 * callint.c (Fcall_interactively):
10740 * buffer.c (Fkill_all_local_variables):
10741 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10743 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10744 unconditionally since it does the check itself.
10746 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10748 Fix more problems found by GCC 4.5.2's static checks.
10750 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10751 the first time through the loop, since we know p0 < p1 then.
10752 This also avoids a gcc -Wstrict-overflow warning.
10754 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10755 leading to a memory leak, possible in functions like
10756 load_charset_map_from_file that can allocate an unbounded number
10757 of objects (Bug#8318).
10759 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10760 that could (at least in theory) be that large.
10762 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10763 This is less likely to overflow, and avoids undefined behavior if
10764 overflow does occur. All callers changed. Use strtoul to scan
10765 for the unsigned long integer.
10766 (pint2hrstr): Simplify and tune code slightly.
10767 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10769 * scroll.c (do_scrolling): Work around GCC bug 48228.
10770 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10772 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10773 This also avoids a warning with gcc -Wstrict-overflow.
10774 (validate_x_resource_name): Simplify count usage.
10775 This also avoids a warning with gcc -Wstrict-overflow.
10777 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10780 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10782 * process.c (Fmake_network_process): Use socklen_t, not int,
10783 where POSIX says socklen_t is required in portable programs.
10784 This fixes a porting bug on hosts like 64-bit HP-UX, where
10785 socklen_t is wider than int (Bug#8277).
10786 (Fmake_network_process, server_accept_connection):
10787 (wait_reading_process_output, read_process_output):
10790 * process.c: Rename or move locals to avoid shadowing.
10791 (list_processes_1, Fmake_network_process):
10792 (read_process_output_error_handler, exec_sentinel_error_handler):
10793 Rename or move locals.
10794 (Fmake_network_process): Define label "retry_connect" only if needed.
10795 (Fnetwork_interface_info): Fix pointer signedness.
10796 (process_send_signal): Add cast to avoid pointer signedness problem.
10797 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10798 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10800 Make tparam.h and terminfo.c consistent.
10801 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10802 Include tparam.h instead, since it declares them.
10803 * cm.h (PC): Remove extern decl; tparam.h now does this.
10804 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10805 * terminfo.c: Include tparam.h, to check interfaces.
10806 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10807 (tparam): Adjust signature to match interface in tparam.h;
10808 this removes some undefined behavior. Check that outstring and len
10809 are zero, which they always are with Emacs.
10810 * tparam.h (PC, BC, UP): New extern decls.
10812 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10813 (xftfont_open): Rename locals to avoid shadowing.
10815 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10816 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10817 (OTF_TAG_SYM): Omit macro if not needed.
10818 (ftfont_list): Remove unused local.
10819 (get_adstyle_property, ftfont_pattern_entity):
10820 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10821 Rename locals to avoid shadowing.
10823 * xfont.c (xfont_list_family): Mark var as initialized.
10825 * xml.c (make_dom): Now static.
10827 * composite.c (composition_compute_stop_pos): Rename local to
10829 (composition_reseat_it): Remove unused locals.
10830 (find_automatic_composition, composition_adjust_point): Likewise.
10831 (composition_update_it): Mark var as initialized.
10832 (find_automatic_composition): Mark vars as initialized,
10833 with a FIXME (Bug#8290).
10835 character.h: Rename locals to avoid shadowing.
10836 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10837 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10838 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10839 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10840 to avoid shadowing.
10842 * textprop.c (property_change_between_p): Remove; unused.
10844 * intervals.c (interval_start_pos): Now static.
10846 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10848 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10849 Rename locals to avoid shadowing.
10851 * sound.c (wav_play, au_play, Fplay_sound_internal):
10852 Fix pointer signedness.
10853 (alsa_choose_format): Remove unused local var.
10854 (wav_play): Initialize a variable to 0, to prevent undefined
10855 behavior (Bug#8278).
10857 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10859 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10862 clobbering (Bug#8298).
10863 * sysdep.c (sys_subshell): Likewise.
10864 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10866 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10867 This should get cleaned up, so that child_setup has the
10868 same signature on all platforms.
10870 * callproc.c (call_process_cleanup): Now static.
10871 (relocate_fd): Rename locals to avoid shadowing.
10873 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10875 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10876 not to be necessary, and produces flickering.
10878 2011-03-20 Glenn Morris <rgm@gnu.org>
10880 * config.in: Remove file.
10882 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10884 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10885 are now in src/globals.h.
10886 (syms_of_minibuf): Remove spurious & from previous change.
10888 2011-03-20 Leo Liu <sdl.web@gmail.com>
10890 * minibuf.c (completing-read-function): New variable.
10891 (completing-read-default): Rename from completing-read.
10892 (completing-read): Call completing-read-function.
10894 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10896 * xfaces.c (Fx_load_color_file):
10897 Read color file from absolute filename (bug#8250).
10899 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10901 * makefile.w32-in: Update dependencies.
10903 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10905 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10907 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10909 Fix more problems found by GCC 4.5.2's static checks.
10911 * process.c (make_serial_process_unwind, send_process_trap):
10912 (sigchld_handler): Now static.
10914 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10915 That way, the code declares only the vars that it needs.
10916 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10917 * s/cygwin.h (PTY_ITERATION): Likewise.
10918 * s/darwin.h (PTY_ITERATION): Likewise.
10919 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10921 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10922 * process.c (allocate_pty): Don't declare stb unless it's needed.
10924 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10925 (CONSTANTLIM): Remove; unused.
10926 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10927 Define only if needed.
10929 * unexelf.c (unexec): Name an expression,
10930 to avoid gcc -Wbad-function-cast warning.
10931 Use a different way to cause a compilation error if anyone uses
10932 n rather than nn, a way that does not involve shadowing.
10933 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10935 * deps.mk (unexalpha.o): Remove; unused.
10937 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10938 * unexec.h: New file.
10939 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10940 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10941 Depend on unexec.h.
10942 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10943 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10944 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10945 Change as necessary to match prototype in unexec.h.
10947 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10949 (back_comment, skip_chars): Mark vars as initialized.
10951 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10952 Rename locals to avoid shadowing.
10954 * lread.c (read1): Rewrite so as not to use empty "else".
10955 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10957 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10959 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10960 warning when compiling print.c.
10962 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10963 instead of using an uninitialized var.
10964 (font_sort_entities): Mark var as initialized.
10966 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10968 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10969 pointers to constants.
10970 (font_parse_fcname): Remove unused vars.
10971 (font_delete_unmatched): Now static.
10972 (font_get_spec): Remove; unused.
10973 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10974 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10975 Rename or move locals to avoid shadowing.
10977 * fns.c (require_nesting_list, require_unwind): Now static.
10978 (Ffillarray): Rename locals to avoid shadowing.
10980 * floatfns.c (domain_error2): Define only if needed.
10981 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10983 * alloc.c (mark_backtrace): Move decl from here ...
10984 * lisp.h: ... to here, so that it can be checked.
10986 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10987 (Fdefvar): Rewrite so as not to use empty "else".
10988 (lisp_indirect_variable): Name an expression,
10989 to avoid gcc -Wbad-function-cast warning.
10990 (Fdefvar): Rename locals to avoid shadowing.
10992 * callint.c (quotify_arg, quotify_args): Now static.
10993 (Fcall_interactively): Rename locals to avoid shadowing.
10994 Use const pointer when appropriate.
10996 * lisp.h (get_system_name, get_operating_system_release):
10997 Move decls here, to check interfaces.
10998 * process.c (get_operating_system_release): Move decl to lisp.h.
10999 * xrdb.c (get_system_name): Likewise.
11000 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11001 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11002 some of which prompt warnings from gcc -Wbad-function-cast.
11003 (Fformat_time_string, Fencode_time, Finsert_char):
11004 (Ftranslate_region_internal, Fformat):
11005 Rename or remove local vars to avoid shadowing.
11006 (Ftranslate_region_internal): Mark var as initialized.
11008 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11011 * lisp.h (eassert): Check that the argument compiles, even if
11012 ENABLE_CHECKING is not defined.
11014 * data.c (Findirect_variable): Name an expression, to avoid
11015 gcc -Wbad-function-cast warning.
11016 (default_value, arithcompare, arith_driver, arith_error): Now static.
11017 (store_symval_forwarding): Rename local to avoid shadowing.
11018 (Fmake_variable_buffer_local, Fmake_local_variable):
11019 Mark variables as initialized.
11020 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11022 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11023 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11024 Rename locals to avoid shadowing.
11025 (mark_stack): Move local variables into the #ifdef region where
11027 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11028 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11030 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11031 (GC_STRING_CHARS): Remove; not used.
11032 (Fmemory_limit): Cast sbrk's returned value to char *.
11034 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11035 avoids undefined behavior in theory.
11037 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11039 Use functions, not macros, for up- and down-casing (Bug#8254).
11040 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11041 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11042 to use the following functions instead of these macros.
11043 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11044 EMACS_INT, since callers assume the returned value fits in int.
11045 (upcase1): Likewise, for UPCASE_TABLE.
11046 (uppercasep, lowercasep, upcase): New static inline functions.
11047 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11048 the race-condition problem in the old DOWNCASE.
11050 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11051 Rename locals to avoid shadowing.
11052 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11053 (regex_compile, re_search_2, re_match_2_internal):
11054 Remove unused local vars.
11055 (FREE_VAR): Rewrite so as not to use empty "else",
11056 which gcc can warn about.
11057 (regex_compile, re_match_2_internal): Mark locals as initialized.
11058 (RETALLOC_IF): Define only if needed.
11059 (WORDCHAR_P): Likewise. This one is never needed, but is used
11060 only in a comment talking about a compiler bug, so put inside
11061 the #if 0 of that comment.
11062 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11063 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11066 * search.c (boyer_moore): Rename locals to avoid shadowing.
11067 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11068 (PREV_CHAR_BOUNDARY): Likewise.
11070 * search.c (simple_search): Remove unused var.
11072 * dired.c (compile_pattern): Move decl from here ...
11073 * lisp.h: ... to here, so that it can be checked.
11074 (struct re_registers): New forward decl.
11076 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11078 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11080 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11081 Rename locals to avoid shadowing.
11082 (Fvertical_motion): Mark locals as initialized.
11084 * casefiddle.c (casify_object, casify_region): Now static.
11085 (casify_region): Mark local as initialized.
11087 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11089 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11090 New macros, so that the caller can use some names other than
11091 gcpro1, gcpro2, etc.
11092 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11094 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11095 argument, for consistency with GCPRO2_VAR, etc: it is now the
11096 prefix of the variable, not the variable itself. All uses
11098 * dired.c (directory_files_internal, file_name_completion):
11099 Rename locals to avoid shadowing.
11101 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11102 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11103 dired.c's scmp function, had undefined behavior.
11104 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11105 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11106 * buffer.h: ... to here, because these macros use current_buffer,
11107 and the new implementation with inline functions needs to have
11108 current_buffer in scope now, rather than later when the macros
11110 (downcase, upcase1): New static inline functions.
11111 (DOWNCASE, UPCASE1): Reimplement using these functions.
11112 This avoids undefined behavior in expressions like
11113 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11114 from race conditions in accessing the global variables
11115 case_temp1 and case_temp2.
11116 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11117 * lisp.h (case_temp1, case_temp2): Remove their decls.
11118 * character.h (ASCII_CHAR_P): Move from here ...
11119 * lisp.h: ... to here, so that the inline functions mentioned
11120 above can use them.
11122 * dired.c (directory_files_internal_unwind): Now static.
11124 * fileio.c (file_name_as_directory, directory_file_name):
11125 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11127 (file_name_as_directory): Use const pointers when appropriate.
11128 (Fexpand_file_name): Likewise. In particular, newdir might
11129 point at constant storage, so make it a const pointer.
11130 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11131 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11133 (Fset_file_times, Finsert_file_contents, auto_save_error):
11134 Rename locals to avoid shadowing.
11136 * minibuf.c (choose_minibuf_frame_1): Now static.
11137 (Ftry_completion, Fall_completions): Rename or remove locals
11138 to avoid shadowing.
11140 * marker.c (bytepos_to_charpos): Remove; unused.
11142 * lisp.h (verify_bytepos, count_markers): New decls,
11143 so that gcc does not warn that these functions aren't declared.
11145 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11146 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11147 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11148 (copy_text): Remove unused local var.
11150 * filelock.c (within_one_second): Now static.
11151 (lock_file_1): Rename local to avoid shadowing.
11153 * buffer.c (fix_overlays_before): Mark locals as initialized.
11154 (fix_start_end_in_overlays): Likewise. This function should be
11155 simplified by using pointers-to-pointers, but that's a different
11157 (switch_to_buffer_1): Now static.
11158 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11159 (report_overlay_modification): Rename locals to avoid shadowing.
11161 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11162 Fix pointer signedness issue.
11163 (sys_subshell): Mark local as volatile if checking for lint,
11164 to suppress a gcc -Wclobbered warning that does not seem to be right.
11165 (MAXPATHLEN): Define only if needed.
11167 * process.c (serial_open, serial_configure): Move decls from here ...
11168 * systty.h: ... to here, so that they can be checked.
11170 * fns.c (get_random, seed_random): Move extern decls from here ...
11171 * lisp.h: ... to here, so that they can be checked.
11173 * sysdep.c (reset_io): Now static.
11174 (wait_for_termination_signal): Remove; unused.
11176 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11177 (copy_keymap_item, append_key, push_text_char_description):
11179 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11180 (DENSE_TABLE_SIZE): Remove; unused.
11181 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11182 (describe_map_tree):
11183 Rename locals to avoid shadowing.
11185 * keyboard.c: Declare functions static if they are not used elsewhere.
11186 (echo_char, echo_dash, cmd_error, top_level_2):
11187 (poll_for_input, handle_async_input): Now static.
11188 (read_char, kbd_buffer_get_event, make_lispy_position):
11189 (make_lispy_event, make_lispy_movement, apply_modifiers):
11190 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11191 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11192 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11193 (read_key_sequence, read_char): Mark locals as initialized.
11194 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11196 * keyboard.h (make_ctrl_char): New decl.
11197 (mark_kboards): Move decl here ...
11198 * alloc.c (mark_kboards): ... from here.
11200 * lisp.h (force_auto_save_soon): New decl.
11202 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11203 (DEFINE_DUMMY_FUNCTION): New macro.
11204 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11206 (main): Add casts to avoid warnings
11207 if GCC considers string literals to be constants.
11209 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11211 * dbusbind.c: Pointer signedness fixes.
11212 (xd_signature, xd_append_arg, xd_initialize):
11213 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11214 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11215 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11216 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11218 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11219 if GCC considers string literals to be constants.
11220 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11222 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11224 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11225 (print_preprocess, print_object): New macro to fix last change.
11227 * print.c (print_preprocess): Don't forget font objects.
11229 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11231 * emacs.c (USAGE3): Doc fixes.
11233 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11235 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11238 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11240 * lisp.h (VWindow_system, Qfile_name_history):
11241 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11242 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11243 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11245 * w32select.c: Don't #include "keyboard.h".
11246 (run_protected): Add extern declaration for waiting_for_input.
11248 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11249 * w32console.c (detect_input_pending, read_input_pending)
11250 (encode_terminal_code):
11251 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11252 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11253 (w32_system_caret_y, Qfile_name_history):
11254 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11255 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11256 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11257 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11258 * w32proc.c (Qlocal, report_file_error):
11259 * w32term.c (Vwindow_system, updating_frame):
11260 * w32uniscribe.c (initialized, uniscribe_font_driver):
11261 Remove unneeded extern declarations.
11263 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11265 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11267 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11269 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11270 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11271 These macros can no longer be used for assignment.
11273 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11274 Assign struct members directly, instead of using BUF_BEGV etc.
11275 (record_buffer_markers, fetch_buffer_markers): New functions for
11276 recording and fetching special buffer markers.
11277 (set_buffer_internal_1, set_buffer_temp): Use them.
11279 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11281 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11283 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11284 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11286 * xdisp.c (hscroll_window_tree):
11287 (reconsider_clip_changes): Use PT instead of BUF_PT.
11289 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11291 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11292 $(EMACS_ROOT)/lib/intprops.h.
11294 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11296 Fix more problems found by GCC 4.5.2's static checks.
11298 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11299 to unsigned char * to avoid compiler diagnostic.
11300 (xg_free_frame_widgets): Make it clear that a local variable is
11301 needed only if USE_GTK_TOOLTIP.
11302 (gdk_window_get_screen): Make it clear that this macro is needed
11303 only if USE_GTK_TOOLTIP.
11304 (int_gtk_range_get_value): New function, which avoids a diagnostic
11305 from gcc -Wbad-function-cast.
11306 (xg_set_toolkit_scroll_bar_thumb): Use it.
11307 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11308 diagnostic from gcc -Wbad-function-cast.
11309 (get_utf8_string, xg_get_file_with_chooser):
11310 Rename locals to avoid shadowing.
11311 (create_dialog): Move locals to avoid shadowing.
11313 * xgselect.c (xg_select): Remove unused var.
11315 * image.c (four_corners_best): Mark locals as initialized.
11316 (gif_load): Initialize transparent_p to zero (Bug#8238).
11317 Mark another local as initialized.
11318 (my_png_error, my_error_exit): Mark with NO_RETURN.
11320 * image.c (clear_image_cache): Now static.
11321 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11322 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11323 (x_edge_detection): Remove unnecessary cast that
11324 gcc -Wbad-function-cast diagnoses.
11325 (gif_load): Fix pointer signedness.
11326 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11327 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11329 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11331 Improve quality of tests for time stamp overflow.
11332 For example, without this patch (encode-time 0 0 0 1 1
11333 1152921504606846976) returns the obviously-bogus value (-948597
11334 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11335 reports time overflow. See
11336 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11337 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11338 * editfns.c: Include limits.h and intprops.h.
11339 (TIME_T_MIN, TIME_T_MAX): New macros.
11340 (time_overflow): Move earlier, to before first use.
11341 (hi_time, lo_time): New functions, for an accurate test for
11342 out-of-range times.
11343 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11344 (Fget_internal_run_time): Don't assume time_t fits in int.
11345 (make_time): Use list2 instead of Fcons twice.
11346 (Fdecode_time): More accurate test for out-of-range times.
11347 (check_tm_member): New function.
11348 (Fencode_time): Use it, to test for out-of-range times.
11349 (lisp_time_argument): Don't rely on undefined left-shift and
11350 right-shift behavior when checking for time stamp overflow.
11352 * editfns.c (time_overflow): New function, refactoring common code.
11353 (Fformat_time_string, Fdecode_time, Fencode_time):
11354 (Fcurrent_time_string): Use it.
11356 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11357 * dired.c (make_time): Move to ...
11358 * editfns.c (make_time): ... here.
11359 * systime.h: Note the move.
11361 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11363 * fringe.c (update_window_fringes): Remove unused variables.
11365 * unexmacosx.c (copy_data_segment): Also copy __got section.
11368 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11370 * termcap.c [MSDOS]: Include "msdos.h".
11371 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11372 Constify `char *' arguments and their references according to
11373 prototypes in tparam.h.
11375 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11377 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11378 Adapt all references accordingly.
11380 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11382 2011-03-11 Tom Tromey <tromey@redhat.com>
11384 * buffer.c (syms_of_buffer): Remove obsolete comment.
11386 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11388 * termhooks.h (encode_terminal_code): Declare prototype.
11390 * msdos.c (encode_terminal_code): Don't declare prototype.
11392 * term.c (encode_terminal_code): Now external again, used by
11393 w32console.c and msdos.c.
11395 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11396 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11398 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11400 Fix some minor problems found by GCC 4.5.2's static checks.
11402 * fringe.c (update_window_fringes): Mark locals as initialized
11404 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11406 * alloc.c (mark_fringe_data): Move decl from here ...
11407 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11408 to check its interface.
11409 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11411 * fontset.c (free_realized_fontset): Now static.
11412 (Fset_fontset_font): Rename local to avoid shadowing.
11413 (fontset_font): Mark local as initialized.
11414 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11416 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11418 * xselect.c (x_disown_buffer_selections): Remove; not used.
11419 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11420 (x_own_selection, Fx_disown_selection_internal): Rename locals
11421 to avoid shadowing.
11422 (x_handle_dnd_message): Remove local to avoid shadowing.
11424 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11425 so that the caller can use some name other than gcpro1.
11426 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11427 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11428 (Fx_backspace_delete_keys_p):
11429 Use them to avoid shadowing, and rename vars to avoid shadowing.
11430 (x_decode_color, x_set_name, x_window): Now static.
11431 (Fx_create_frame): Add braces to silence GCC warning.
11432 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11433 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11434 Remove unused locals.
11435 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11436 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11437 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11440 * xterm.h (x_mouse_leave): New decl.
11442 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11443 Remove unused functions.
11444 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11445 (x_calc_absolute_position): Now static.
11446 (XTread_socket): Don't define label "out" unless it's used.
11447 Don't declare local "event" unless it's used.
11448 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11449 unless they are used.
11450 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11451 (x_fatal_error_signal): Remove; not used.
11452 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11453 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11454 (x_error_catcher, x_connection_closed, x_error_handler):
11455 (x_error_quitter, xembed_send_message, x_iconify_frame):
11456 (my_log_handler): Rename locals to avoid shadowing.
11457 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11458 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11460 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11461 Rename or move locals to avoid shadowing.
11462 (tty_defined_color, merge_face_heights): Now static.
11463 (free_realized_faces_for_fontset): Remove; not used.
11464 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11465 does not deduce is never used uninitialized.
11466 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11467 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11469 * terminal.c (store_terminal_param): Now static.
11471 * xmenu.c (menu_highlight_callback): Now static.
11472 (set_frame_menubar): Remove unused local.
11473 (xmenu_show): Rename parameter to avoid shadowing.
11474 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11475 since they might point to immutable storage.
11476 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11477 since it's unused otherwise.
11479 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11480 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11481 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11482 avoids a gcc -Wuninitialized diagnostic.
11483 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11484 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11485 does not deduce are never used uninitialized.
11487 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11489 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11490 * window.c (window_loop, size_window):
11491 (run_window_configuration_change_hook, enlarge_window): Likewise.
11493 * window.c (display_buffer): Now static.
11494 (size_window): Mark variables that gcc -Wuninitialized
11495 does not deduce are never used uninitialized.
11496 * window.h (check_all_windows): New decl, to forestall
11497 gcc -Wmissing-prototypes diagnostic.
11498 * dispextern.h (bidi_dump_cached_states): Likewise.
11500 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11502 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11503 Include <limits.h>.
11504 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11505 and to avoid gcc -Wuninitialized warning.
11506 (load_charset_map): Mark variables that gcc -Wuninitialized
11507 does not deduce are never used uninitialized.
11508 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11510 * coding.c (coding_set_source, coding_set_destination):
11511 Use "else { /* comment */ }" rather than "else /* comment */;"
11512 for clarity, and to avoid gcc -Wempty-body warning.
11513 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11514 a block, when the outer 'i' will do.
11515 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11516 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11517 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11518 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11519 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11520 Rename locals to avoid shadowing.
11521 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11522 * coding.c (emacs_mule_char, encode_invocation_designation):
11523 Now static, since they're not used elsewhere.
11524 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11525 (decode_coding_object, encode_coding_object, detect_coding_system):
11526 (decode_coding_emacs_mule): Mark variables that gcc
11527 -Wuninitialized does not deduce are never used uninitialized.
11528 (detect_coding_iso_2022): Initialize a local variable that might
11529 be used uninitialized. Leave a FIXME because it's not clear that
11530 this initialization is needed. (Bug#8211)
11531 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11532 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11533 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11534 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11535 Remove unused macros.
11537 * category.c (hash_get_category_set): Remove unused local var.
11538 (copy_category_table): Now static, since it's not used elsewhere.
11539 * character.c (string_count_byte8): Likewise.
11541 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11542 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11544 * chartab.c (copy_sub_char_table): Now static, since it's not used
11546 (sub_char_table_ref_and_range, char_table_ref_and_range):
11547 Rename locals to avoid shadowing.
11548 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11550 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11551 (BIDI_BOB): Remove unused macro.
11553 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11554 deduce are never used uninitialized.
11555 * term.c (encode_terminal_code): Likewise.
11557 * term.c (encode_terminal_code): Now static. Remove unused local.
11559 * tparam.h: New file.
11560 * term.c, tparam.h: Include it.
11561 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11562 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11563 Move these decls to tparam.h, and make them agree with what
11564 is actually in tparam.c. The previous trick of using incompatible
11565 decls in different modules does not conform to the C standard.
11566 All callers of tparam changed to use tparam's actual API.
11567 * tparam.c (tparam1, tparam, tgoto):
11568 Use const pointers where appropriate.
11570 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11571 * cm.h (struct cm): Likewise.
11572 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11573 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11574 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11575 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11576 (turn_on_face, init_tty): Likewise.
11577 * termchar.h (struct tty_display_info): Likewise.
11579 * term.c (term_mouse_position): Rename local to avoid shadowing.
11581 * alloc.c (mark_ttys): Move decl from here ...
11582 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11584 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11586 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11588 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11590 * search.c (compile_pattern_1): Remove argument regp, unused since
11591 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11592 (compile_pattern): Don't pass it.
11594 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11596 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11597 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11599 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11601 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11603 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11604 gdk_window_get_screen, gdk_window_get_geometry,
11605 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11606 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11607 (xg_get_pixbuf_from_pixmap): New function.
11608 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11609 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11610 Call xg_get_pixbuf_from_pixmap instead of
11611 gdk_pixbuf_get_from_drawable.
11612 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11613 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11614 (xg_check_special_colors): Use GtkStyleContext and its functions
11616 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11617 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11618 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11619 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11620 Call gtk_widget_get_preferred_size.
11621 (xg_frame_resized): gdk_window_get_geometry only takes 5
11623 (xg_win_to_widget, xg_event_is_for_menubar):
11624 Call gdk_x11_window_lookup_for_display.
11625 (xg_set_widget_bg): New function.
11626 (delete_cb): New function.
11627 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11628 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11629 (xg_set_background_color): Call xg_set_widget_bg.
11630 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11631 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11632 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11633 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11635 (update_frame_tool_bar): Call gtk_widget_hide.
11636 (xg_initialize): Use GDK_KEY_g.
11638 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11640 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11642 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11643 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11644 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11646 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11648 * w32xfns.c (select_palette): Check success of RealizePalette against
11649 GDI_ERROR, not zero.
11651 See ChangeLog.11 for earlier changes.
11653 ;; Local Variables:
11657 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11659 This file is part of GNU Emacs.
11661 GNU Emacs is free software: you can redistribute it and/or modify
11662 it under the terms of the GNU General Public License as published by
11663 the Free Software Foundation, either version 3 of the License, or
11664 (at your option) any later version.
11666 GNU Emacs is distributed in the hope that it will be useful,
11667 but WITHOUT ANY WARRANTY; without even the implied warranty of
11668 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11669 GNU General Public License for more details.
11671 You should have received a copy of the GNU General Public License
11672 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.