1 2012-07-17 Chong Yidong <cyd@gnu.org>
3 * editfns.c (Finsert_char): Doc fix.
5 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
7 Fix previous change to make Fmemory_free always accurate.
8 * alloc.c (make_interval): Update total_free_intervals.
9 (make_float): Likewise for total_free_floats.
10 (free_cons, Fcons): Likewise for total_free_conses.
11 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
12 Likewise for total_free_vector_bytes.
13 (Fmake_symbol): Likewise for total_free_symbols.
16 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
18 Simple free memory accounting feature.
19 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
20 (sweep_vectors): Accumulate size of free vectors.
21 (Fgarbage_collect): Setup bytes_free.
22 (Fmemory_free): New function.
23 (syms_of_alloc): Register it.
25 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
27 Cleanup overlays checking.
28 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
29 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
31 (sort_overlays): Change to use OVERLAYP.
33 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
35 * editfns.c (Finsert_char): Make it interactive, and make the
36 second arg optional. Copy interactive spec and docstring from
39 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
41 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
42 Unlike the other wrapped functions, fabs has an unspecified
45 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
47 * nsterm.m (keyDown): Interpret flags without left/right bits
48 as the left key (Bug#11670).
50 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
52 Remove empty and useless init functions.
53 * lisp.h (init_character_once, init_fns, init_image)
54 (init_filelock, init_sound): Remove prototype.
55 * character.c (init_character_once): Remove.
56 * filelock.c (init_filelock): Likewise.
57 * fns.c (init_fns): Likewise.
58 * image.c (init_image): Likewise.
59 * sound.c (init_sound): Likewise.
60 * emacs.c (main): Adjust accordingly.
62 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
64 * gtkutil.h: Tiny cleanups.
65 (use_old_gtk_file_dialog): Remove useless declaration.
66 (xg_uses_old_file_dialog): Add suggested const attribute.
68 2012-07-15 Eli Zaretskii <eliz@gnu.org>
70 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
71 (bidi_paragraph_init): Use it to limit search forward for a strong
72 directional character in abnormally large paragraphs full of
73 neutral or weak characters. (Bug#11943)
75 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
77 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
78 the toolbar (Bug#9451).
79 (xg_make_tool_item): Give the widget event box a transparent
82 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
84 Cleanup basic allocation variables and functions.
85 * alloc.c (ignore_warnings, init_intervals, init_float)
86 (init_cons, init_symbol, init_marker): Remove.
87 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
88 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
89 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
90 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
91 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
92 (staticidx, init_alloc_once, init_strings, free_ablock):
93 Remove redundant initialization.
94 * fns.c (init_weak_hash_tables): Remove.
95 * lisp.h (init_weak_hash_tables): Remove prototype.
97 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
99 Use zero_vector where appropriate.
100 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
102 * lisp.h (zero_vector): New declaration.
103 * font.c (null_vector): Remove.
104 (syms_of_font): Remove initialization and staticpro.
105 (font_list_entities, font_find_for_lface): Change to use zero_vector.
106 * keymap.c (Faccessible_keymaps): Likewise.
108 2012-07-15 Leo Liu <sdl.web@gmail.com>
110 * fringe.c: Fix typo in comments.
112 2012-07-14 Leo Liu <sdl.web@gmail.com>
114 * fringe.c: Add a new bitmap exclamation-mark.
116 2012-07-14 Eli Zaretskii <eliz@gnu.org>
118 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
120 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
121 (HAVE_MENUS): Don't define, defined by editing config.in with
123 (GMALLOC_INHIBIT_VALLOC): Don't define.
124 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
126 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
128 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
130 2012-07-14 Glenn Morris <rgm@gnu.org>
132 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
133 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
134 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
136 2012-07-13 Glenn Morris <rgm@gnu.org>
138 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
140 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
141 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
143 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
145 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
146 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
147 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
148 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
150 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
151 as boolean expression.
152 (x_set_window_size): Remove unused variable toolbar.
153 (ns_get_color_default, ns_mod_to_lisp): Remove.
154 (ns_mouse_position): Remove unused variables xchar and ychar.
155 (ns_compute_glyph_string_overhangs): Remove unused variable face.
156 (ns_set_vertical_scroll_bar): Remove unused variable count.
157 (ns_delete_terminal): Remove unused variable i.
158 (ns_term_init): Remove unused variables r, g and b.
159 (mouseDown): Remove unused variable window.
160 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
161 (initFrameFromEmacs): Remove unused variable vbextra.
162 (mouseEntered): Remove unused variables p and dpyinfo.
163 (mouseExited): Remove unused variables p and r.
164 (ns_define_frame_cursor, ns_clear_frame_area)
165 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
166 (menuDown): Assign [sender tag] to variable and cast the variable.
168 * nsterm.h (menuDown): Add id as type to argument sender.
169 (ns_display_info_for_name): Add Lisp_Object argument.
170 (ns_term_init): Add Lisp_Object argument.
171 (ns_map_event_to_object): Add void argument.
172 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
173 prototype with arguments and only declare if __OBJC__.
174 (nxatoms_of_nsselect): Add void argument.
175 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
176 (ns_alloc_autorelease_pool): Add void argument.
177 (ns_release_autorelease_pool): Add void* argument.
178 (ns_get_defaults_value): Add const char* argument.
180 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
181 (initFromContents): Use SSDATA where appropriate.
182 (ns_update_menubar): Add braces to ambigous if-else.
183 (initWithTitle): Put () around assignment in if statement.
184 (ns_menu_show): Remove unused variables window and keymap.
185 (update_frame_tool_bar): Remove unused variable selected_p.
186 (initWithContentRect): Remove unused variable this_cmd_name.
188 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
190 (setXBMColor): Remove unused variable len.
191 (setPixmapData): Put () around assignment in loop statement.
193 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
194 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
196 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
197 around assignment in loop statement.
198 (nsfont_open): Remove unused variable i.
199 (nsfont_open): Remove unused variable len.
200 (nsfont_draw): Remove unused variable cs.
202 * nsfns.m (x_set_icon_name, ns_set_name_internal)
203 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
204 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
205 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
206 (Fns_font_name, Fns_perform_service)
207 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
208 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
209 (ns_set_name): Remove unused variable view.
210 (x_set_menu_bar_lines): Remove unused variable olines.
211 (x_set_tool_bar_lines): Remove unused variable root_window.
212 (Fns_list_colors): Put () around assignment in while statement.
213 (Fns_perform_service): Remove unused variable len.
214 (Fns_display_usable_bounds): Remove unused variable top.
215 (syms_of_nsfns): Remove unused variable i.
217 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
220 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
222 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
223 and free it with DestroyExceptionInfo (Bug#11558).
225 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
227 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
228 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
229 Set here, not in nt/config.nt.
231 2012-07-13 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
234 cursor overflow into the last glyph on display line when the right
235 fringe is off. (Bug#11832)
237 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
239 * xdisp.c (produce_special_glyphs): Now static.
240 * dispextern.h (produce_special_glyphs): Remove decl.
242 2012-07-13 Glenn Morris <rgm@gnu.org>
244 * s/bsd-common, s/cygwin.h: Remove empty files.
245 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
247 * s/usg5-4-common.h (USG, USG5):
248 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
249 * s/sol2-6.h (SOLARIS2):
250 * s/irix6-5.h (IRIX6_5):
251 * s/hpux10-20.h (USG, USG5, HPUX):
252 * s/gnu-linux.h (USG, GNU_LINUX):
253 * s/freebsd.h (BSD_SYSTEM):
254 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
255 * s/cygwin.h (CYGWIN):
256 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
257 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
259 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
261 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
263 2012-07-13 Glenn Morris <rgm@gnu.org>
265 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
267 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
269 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
270 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
272 2012-07-12 Glenn Morris <rgm@gnu.org>
274 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
276 * process.c (init_process_emacs): Rename from init_process.
277 The old name is also the name of a Mach system call.
278 * lisp.h, emacs.c: Update for this name change.
279 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
282 2012-07-12 Eli Zaretskii <eliz@gnu.org>
284 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
285 memmove call that removes glyphs covered by the left truncation
286 glyph. Improve commentary.
287 (display_line): Fix display of continuation glyphs on GUI frames
288 when the right fringe is turned off and variable-size fonts are
289 used in the window. Move the code that appends a stretch glyph to
290 produce_special_glyphs, so that it could be used for truncation
291 and continuation glyphs alike.
292 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
293 glyph of a suitably computed width, to align the special glyphs at
294 the window margin. Code moved from display_line. (Bug#11832)
296 2012-07-12 Glenn Morris <rgm@gnu.org>
298 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
300 * s/gnu-linux.h, s/hpux10-20.h:
301 Do not unconditionally define HAVE_XRMSETDATABASE.
303 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
305 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
307 Fix typos that broke OS X build.
308 Reported by Randal L. Schwartz in
309 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
310 * nsterm.m (ns_timeout): Add missing local decl.
311 (ns_get_color): snprintf -> sprintf, to fix typo.
313 2012-07-12 Glenn Morris <rgm@gnu.org>
315 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
316 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
317 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
318 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
320 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
321 Move PTY_OPEN to configure.
323 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
324 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
325 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
327 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
329 Use empty_unibyte_string where applicable.
330 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
331 * lread.c (read1): Likewise.
332 * xsettings.c (syms_of_xsettings): Likewise.
334 2012-07-12 Glenn Morris <rgm@gnu.org>
336 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
337 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
338 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
339 * s/hpux10-20.h (RUN_TIME_REMAP):
340 * s/bsd-common.h (TABDLY): Move to configure.
342 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
344 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
346 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
347 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
349 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
351 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
352 * s/template.h: Move NARROWPROTO to configure.
354 2012-07-11 Glenn Morris <rgm@gnu.org>
356 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
357 unused since 2011-01-17 change to systty.h.
359 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
360 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
361 Move HAVE_PTYS and HAVE_SOCKETS to configure.
363 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
365 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
367 2012-07-11 Glenn Morris <rgm@gnu.org>
369 * s/darwin.h, s/gnu-linux.h, s/template.h:
370 Move INTERRUPT_INPUT to configure.
372 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
374 Minor adjustments to interning code.
375 * lisp.h (intern, intern_c_string): Redefine as static inline
376 wrappers for intern_1 and intern_c_string_1, respectively.
377 (intern_1, intern_c_string_1): Rename prototypes.
378 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
380 * font.c (font_intern_prop): Likewise. Adjust comment.
381 * w32font.c (intern_font_name): Likewise.
383 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
385 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
387 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
388 of Fcar/Fcdr if possible.
389 * font.c (check_otf_features): Likewise.
390 * fontset.c (Fnew_fontset): Likewise.
391 * gnutls.c (Fgnutls_boot): Likewise.
392 * minibuf.c (read_minibuf): Likewise.
393 * msdos.c (IT_set_frame_parameters): Likewise.
394 * xmenu.c (Fx_popup_dialog): Likewise.
395 * w32menu.c (Fx_popup_dialog): Likewise.
397 2012-07-11 Glenn Morris <rgm@gnu.org>
399 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
400 since nothing has defined it on these platforms.
402 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
403 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
405 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
406 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
407 Move CLASH_DETECTION to configure.
409 * s/gnu.h: Remove file, which is now empty.
411 * s/gnu.h, s/gnu-linux.h:
412 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
414 2012-07-11 John Wiegley <johnw@newartisans.com>
416 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
417 function attribute, so we only use it if it exists in the
420 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
422 Avoid call to strlen in fast_c_string_match_ignore_case.
423 * search.c (fast_c_string_match_ignore_case): Change to use
424 length argument. Adjust users accordingly.
425 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
427 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
430 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
431 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
434 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
437 * s/hpux10-20.h (HAVE_PERROR): Remove.
438 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
439 Remove dummy definition, as this problem was obsolete long ago.
442 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
444 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
446 Avoid calls to strlen in font processing functions.
447 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
448 (font_open_by_name): Change to use length argument. Adjust
450 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
452 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
453 Change to return ptrdiff_t.
454 (xfont_list_pattern, xfont_match): Use length returned by
455 xfont_decode_coding_xlfd.
456 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
458 2012-07-11 Glenn Morris <rgm@gnu.org>
460 * s/darwin.h, s/freebsd.h, s/netbsd.h:
461 Move DONT_REOPEN_PTY to configure.
463 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
464 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
466 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
468 Remove "#define unix" that is no longer needed (Bug#11905).
469 * s/aix4-2.h (unix): Remove; no longer needed.
471 EMACS_TIME simplification (Bug#11875).
472 This replaces macros (which typically do not work in GDB)
473 with functions, typedefs and enums, making the code easier to debug.
474 The functional style also makes code easier to read and maintain.
475 * systime.h: Include <sys/time.h> on all hosts, not just if
476 WINDOWSNT, since 'struct timeval' is needed in general.
477 (EMACS_TIME): Now a typedef, not a macro.
478 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
480 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
481 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
482 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
483 (EMACS_TIME_LE): Now functions, not macros.
484 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
485 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
486 which are not functions. All uses rewritten to use:
487 (make_emacs_time): New function.
488 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
489 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
490 not functions. All uses rewritten to use the following, respectively:
491 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
492 (add_emacs_time, sub_emacs_time): New functions.
493 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
494 * fileio.c (Fcopy_file):
495 * xterm.c (XTflash): Get the current time closer to when it's used.
496 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
498 * bytecode.c (targets): Suppress -Woverride-init warnings.
500 Simplify by avoiding confusing use of strncpy etc.
501 * doc.c (Fsnarf_documentation):
502 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
503 * frame.c (Fmake_terminal_frame):
504 * gtkutil.c (get_utf8_string):
506 * nsmenu.m (ns_update_menubar):
507 * regex.c (regerror):
508 Prefer memcpy to strncpy and strncat when either will do.
509 * fileio.c (Fsubstitute_in_file_name):
510 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
511 (menu_separator_name_p):
512 * nsmenu.m (ns_update_menubar):
513 Prefer memcmp to strncmp when either will do.
514 * nsterm.m: Include <ftoastr.h>.
516 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
517 Prefer snprintf to strncpy.
518 * nsterm.m (ns_term_init):
519 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
520 * nsterm.m (ns_term_init):
521 Avoid the need for strncpy, by using build_string or
522 make_unibyte_string directly. Use dtoastr, not snprintf.
523 * process.c (Fmake_network_process): Diagnose service names that
524 are too long, rather than silently truncating them or creating
525 non-null-terminated names.
526 (Fnetwork_interface_info): Likewise, for interface names.
527 * sysdep.c (system_process_attributes) [GNU_LINUX]:
528 Prefer sprintf to strncat.
529 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
530 Prefer vsnprintf to vsprintf + strncpy.
532 2012-07-10 Glenn Morris <rgm@gnu.org>
534 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
535 Clarify fallback case.
537 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
539 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
540 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
541 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
542 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
543 where argument type is known to be a Lisp_Cons.
545 2012-07-10 Tom Tromey <tromey@redhat.com>
547 * bytecode.c (BYTE_CODE_THREADED): New macro.
548 (BYTE_CODES): New macro. Replaces all old byte-code defines.
549 (enum byte_code_op): New type.
550 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
551 (exec_byte_code): Use them. Use token threading when applicable.
553 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
555 Optimize pure C strings initialization.
556 * lisp.h (make_pure_string): Fix prototype.
557 (build_pure_c_string): New function, defined as static inline. This
558 provides a better opportunity to optimize away calls to strlen when
559 the function is called with compile-time constant argument.
560 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
561 argument, adjust users accordingly. Use build_pure_c_string where
563 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
564 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
565 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
567 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
569 Avoid calls to strlen in miscellaneous functions.
570 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
571 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
572 * lread.c (openp): Likewise.
574 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
576 Avoid calls to strlen in path processing functions.
577 * fileio.c (file_name_as_directory): Add comment. Change to add
578 srclen argument and return the length of result. Adjust users
580 (directory_file_name): Fix comment. Change to add srclen argument,
581 swap 1st and 2nd arguments to obey the common convention. Adjust
583 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
585 2012-07-10 Glenn Morris <rgm@gnu.org>
587 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
588 Move PENDING_OUTPUT_COUNT definition to configure.
590 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
591 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
592 * s/gnu.h (DATA_START): Move definitions to configure.
594 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
595 We include usg5-4-common.h, which defines them both.
597 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
598 O_RDONLY already includes it).
600 Stop ns builds setting the EMACSLOADPATH environment variable.
601 * nsterm.m (ns_load_path): Rename from ns_init_paths.
602 Now it does not set EMACSLOADPATH, just returns the load-path string.
603 * nsterm.h: Update accordingly.
604 * lread.c [HAVE_NS]: Include nsterm.h.
605 (init_lread) [HAVE_NS]: Use ns_load_path.
606 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
608 2012-07-09 Glenn Morris <rgm@gnu.org>
610 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
611 since the included bsd-common.h does so.
613 Stop ns builds setting the EMACSPATH environment variable.
614 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
615 (ns_init_paths): Do not set EMACSPATH.
616 * nsterm.h (ns_exec_path): Add it.
617 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
620 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
622 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
624 * process.c (wait_reading_process_output): 'waitchannels' was unset
625 when read_kbd || !NILP (wait_for_cell); fix this.
627 Add GCC-style 'const' attribute to functions that can use it.
628 * character.h (char_resolve_modifier_mask):
629 * keyboard.h (make_ctrl_char):
630 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
631 (init_character_once, next_almost_prime, init_fns, init_image)
632 (flush_pending_output, init_sound):
633 * mem-limits.h (start_of_data):
634 * menu.h (finish_menu_items):
636 * emacs.c (DEFINE_DUMMY_FUNCTION):
637 Declare the dummy function with ATTRIBUTE_CONST.
638 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
639 Add decls with ATTRIBUTE_CONST.
641 Minor improvements to make_formatted_string.
642 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
643 where int is good enough, as vsprintf returns an int.
644 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
646 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
648 Use make_formatted_string to avoid double length calculation.
649 * lisp.h (make_formatted_string): New prototype.
650 * alloc.c (make_formatted_string): New function.
651 * buffer.c (Fgenerate_new_buffer_name): Use it.
652 * dbus.c (syms_of_dbusbind): Likewise.
653 * editfns.c (Fcurrent_time_zone): Likewise.
654 * filelock.c (get_boot_time): Likewise.
655 * frame.c (make_terminal_frame, set_term_frame_name)
656 (x_report_frame_params): Likewise.
657 * image.c (gs_load): Likewise.
658 * minibuf.c (get_minibuffer): Likewise.
659 * msdos.c (dos_set_window_size): Likewise.
660 * process.c (make_process): Likewise.
661 * xdisp.c (ensure_echo_area_buffers): Likewise.
662 * xsettings.c (apply_xft_settings): Likewise.
664 2012-07-09 Glenn Morris <rgm@gnu.org>
666 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
667 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
668 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
669 * nsterm.h (ns_etc_directory): Add it.
670 * callproc.c [HAVE_NS]: Include nsterm.h.
671 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
673 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
675 Move marker debugging code under MARKER_DEBUG.
676 * marker.c (MARKER_DEBUG): Move marker debugging code under
677 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
678 for bootstrap with --enable-checking (~3x slowdown reported
679 by Juanma Barranquero <lekktu@gmail.com>).
680 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
682 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
684 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
685 See <http://bugs.gnu.org/11825#29>.
687 2012-07-08 Eli Zaretskii <eliz@gnu.org>
689 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
690 has no font, use the frame's font. (Bug#11813)
691 (display_line): Add commentary about displaying truncation glyphs
693 (produce_special_glyphs): Move here from term.c.
695 * term.c (produce_special_glyphs): Move to xdisp.c.
697 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
700 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
702 * xdisp.c (display_line): Avoid warning about implicit declaration
705 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
707 * lisp.h: Remove empty conditional.
709 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
711 * lread.c (load_path_check): Now static.
713 Fix some minor --with-ns problems found by static checking.
714 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
715 (x_set_font) [!HAVE_X_WINDOWS]:
716 * image.c (xpm_load_image) [HAVE_NS]:
717 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
718 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
720 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
721 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
722 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
723 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
724 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
725 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
726 Fix pointer signedness problem.
727 * xfaces.c (FRAME_X_FONT_TABLE):
728 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
730 2012-07-07 Glenn Morris <rgm@gnu.org>
732 * lread.c (load_path_check): New function, split from init_lread.
733 (init_lread): Reorganize. Motivation:
734 If EMACSLOADPATH is set, check/warn about that rather than the
735 defaults, which we are not going to use. Hence we can remove
736 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
737 Don't warn if site-lisp directories are missing.
738 If not installed, start from a blank load-path, since
739 PATH_LOADSEARCH refers to the eventual installation directories.
741 2012-07-07 Eli Zaretskii <eliz@gnu.org>
743 Support truncation and continuation glyphs on GUI frames, when
744 fringes are disabled. (Bug#11832)
745 * xdisp.c (init_iterator): Get dimensions of truncation and
746 continuation glyphs even if on GUI frames. Adjust
747 it->last_visible_x on GUI frames when the left or right fringes,
749 (start_display, move_it_in_display_line_to): Handle the case of a
750 GUI frame without a fringe to display continuation or truncation
752 (insert_left_trunc_glyphs): Support GUI frames: make sure
753 truncation glyphs overwrite enough glyphs from the current line to
754 have sufficient space in pixels.
755 (display_line): Support truncation and continuation glyphs on GUI
756 frames. If some spare pixels are left on the line after inserting
757 the truncation glyphs, fill that space with a stretch glyph of a
758 suitably computed width.
760 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
761 produce_glyphs, to support GUI sessions.
763 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
765 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
767 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
769 Do not require float-time's arg to fit in time_t (Bug#11825).
770 This works better on hosts where time_t is unsigned, and where
771 float-time is applied to the (negative) difference between two times.
772 * editfns.c (decode_time_components): Last arg is now double *,
773 not int *, and means to store all the result as a double, without
774 worrying about whether the seconds part fits in time_t.
776 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
778 (Ffloat_time): Do not fail merely because the specified time falls
779 outside of time_t range.
781 2012-07-07 Glenn Morris <rgm@gnu.org>
783 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
784 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
785 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
787 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
789 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
792 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
794 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
796 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
797 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
798 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
799 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
800 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
801 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
803 * xfont.c (compare_font_names): Redo to omit the need for casts.
805 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
807 * xfns.c (Fx_change_window_property): Doc fix.
808 * w32fns.c (Fx_change_window_property): Doc fix.
810 * w32fns.c (Fx_window_property): Accept the same arguments as the
811 X Windows version. Doc fix.
812 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
814 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
815 Eli Zaretskii <eliz@gnu.org>
817 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
818 Windows-specific code from nt/config.nt moved here.
819 Obsolete settings removed.
821 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
823 * process.c: Avoid unnecessary calls to gettime.
824 (wait_reading_process_output): Don't get the time of day
825 when gobbling data immediately and not waiting, as there's no need
826 for it in that case. This removes a FIXME.
828 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
830 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
831 is defined (Bug#11768).
833 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
835 Fix marker debugging code.
836 * marker.c (byte_char_debug_check): Do not perform the check
837 if buffer is not multibyte.
838 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
839 Call byte_char_debug_check with correct arguments.
841 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
843 Compile marker debugging code only if ENABLE_CHECKING is defined.
844 * marker.c (byte_char_debug_check, count_markers):
845 Use only if ENABLE_CHECKING is defined.
846 (byte_debug_flag): Remove.
847 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
848 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
850 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
852 Avoid code repetition in marker-related functions.
853 * marker.c (attach_marker): New function.
854 (Fset_marker, set_marker_restricted, set_marker_both)
855 (set_marker_restricted_both): Use it.
856 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
857 Consistently rename charno to charpos.
858 (marker_position): Add eassert.
859 (marker_byte_position): Convert to eassert.
861 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
863 Simplify list operations in unchain_overlay and unchain_marker.
864 * buffer.c (unchain_overlay): Simplify. Add comment.
865 * marker.c (unchain_marker): Simplify. Fix comments.
867 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
869 Introduce fast path for the widely used marker operation.
870 * alloc.c (build_marker): New function.
871 * lisp.h (build_marker): New prototype.
872 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
873 * composite.c (autocmp_chars): Likewise.
874 * editfns.c (buildmark): Remove.
875 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
876 (save_restriction_save): Use build_marker.
877 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
878 * window.c (save_window_save): Likewise.
880 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
882 Do not use Fdelete_overlay in delete_all_overlays
883 to avoid redundant calls to unchain_overlay.
884 * buffer.c (drop_overlay): New function.
885 (delete_all_overlays, Fdelete_overlay): Use it.
886 * minibuf.c (get_minibuffer): Fix comment.
888 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
890 Port to OpenBSD 5.1 amd64.
891 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
892 This is needed for OpenBSD, and should be harmless on all BSD systems.
893 Also, include <sys/sysctl.h>, as it should be available on all
894 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
895 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
896 use p_pid member, not kp_proc.pid.
898 2012-07-06 Glenn Morris <rgm@gnu.org>
900 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
902 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
904 More xmalloc and related cleanup.
905 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
906 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
907 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
908 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
909 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
910 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
911 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
912 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
913 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
915 Omit needless casts involving void * pointers and allocation.
916 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
917 as the former is more robust if P's type is changed.
918 Prefer xzalloc to xmalloc + memset 0.
919 Simplify malloc-or-realloc to realloc.
920 Don't worry about xmalloc returning a null pointer.
921 Prefer xstrdup to xmalloc + strcpy.
922 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
924 * keyboard.c (apply_modifiers_uncached): Prefer local array to
925 alloca of a constant.
927 2012-07-05 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (display_line): Fix horizontal pixel coordinates when
930 hscroll is larger than the line width. Fixes long and futile
931 looping inside extend_face_to_end_of_line (on a TTY) producing
932 glyphs that are not needed and thrown away.
934 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
936 * marker.c (set_marker_restricted_both): Simplify by using
939 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
941 * editfns.c (region_limit): Simplify by using clip_to_bounds.
943 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
945 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
946 not defined (Bug#11768).
947 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
948 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
949 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
950 followed by gtk_box_set_homogeneous (Bug#11768).
951 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
952 (update_theme_scrollbar_width, xg_create_scroll_bar):
953 Use gtk_scrollbar_new (Bug#11768).
954 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
955 (is_box_type): New function (Bug#11768).
956 (xg_tool_item_stale_p): Call is_box_type.
957 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
958 with default display (Bug#11768).
960 2012-07-05 Eli Zaretskii <eliz@gnu.org>
962 * xdisp.c (window_hscroll_limited): New function.
963 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
964 coordinates when window's hscroll is set to insanely large
967 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
969 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
970 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
972 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
975 * lisp.h (xzalloc): New prototype. Omit needless casts.
976 * alloc.c (xzalloc): New function. Omit needless casts.
977 * charset.c: Omit needless casts. Convert all calls to
978 xmalloc with following memset to xzalloc.
979 * dispnew.c: Likewise.
980 * fringe.c: Likewise.
984 * w32fns.c: Likewise.
985 * w32font.c: Likewise.
986 * w32term.c: Likewise.
987 * xfaces.c: Likewise.
990 * atimer.c: Omit needless casts.
991 * buffer.c: Likewise.
992 * callproc.c: Likewise.
994 * coding.c: Likewise.
995 * composite.c: Likewise.
997 * doprnt.c: Likewise.
998 * editfns.c: Likewise.
1001 * filelock.c: Likewise.
1003 * gtkutil.c: Likewise.
1004 * keyboard.c: Likewise.
1006 * lread.c: Likewise.
1007 * minibuf.c: Likewise.
1008 * msdos.c: Likewise.
1009 * print.c: Likewise.
1010 * process.c: Likewise.
1011 * region-cache.c: Likewise.
1012 * search.c: Likewise.
1013 * sysdep.c: Likewise.
1014 * termcap.c: Likewise.
1015 * terminal.c: Likewise.
1016 * tparam.c: Likewise.
1017 * w16select.c: Likewise.
1019 * w32reg.c: Likewise.
1020 * w32select.c: Likewise.
1021 * w32uniscribe.c: Likewise.
1022 * widget.c: Likewise.
1023 * xdisp.c: Likewise.
1024 * xmenu.c: Likewise.
1026 * xselect.c: Likewise.
1028 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1030 * fileio.c (time_error_value): Check the right error number.
1031 Problem reported by Troels Nielsen in
1032 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1034 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1036 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1037 This should be fixed in a better way; see Eli Zaretskii in
1038 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1039 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1041 * fileio.c (time_error_value): Rename from special_mtime.
1042 The old name's problems were noted by Eli Zaretskii in
1043 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1045 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1046 This variable's comment says Emacs needs at least one GDB-visible
1047 symbol of type enum pvec_type, to work around GDB problems.
1048 The symbol's value doesn't matter.
1050 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1051 that causes compilation to fail on pre-C99 compilers.
1053 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1055 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1056 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1058 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1060 * buffer.c (init_buffer_once): Fix initialization of
1061 headers for buffer_defaults and buffer_local_symbols.
1062 Reported by Juanma Barranquero <lekktu@gmail.com>.
1064 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1066 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1067 * lisp.h (enum pvec_type): Use fewer bits.
1068 (PSEUDOVECTOR_SIZE_BITS): New constant.
1069 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1070 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1071 change in pvec_type.
1072 (PSEUDOVECTOR_TYPEP): New macro.
1073 (TYPED_PSEUDOVECTORP): Use it.
1074 * fns.c (internal_equal): Adapt code to extract pvectype.
1075 * emacs.c (gdb_pvec_type): Update type.
1076 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1077 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1078 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1079 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1080 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1081 abusing vector->header.next.nbytes.
1082 (live_vector_p): Use PVEC_TYPE.
1083 (mark_object): Adapt code to extract pvectype. Use switch.
1085 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1087 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1088 Tighten new eassert a bit.
1090 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1092 Fix compilation with --enable-gcc-warnings and -O1
1094 * doprnt.c (doprnt): Change type of tem to int, initialize
1095 to avoid compiler warning. Add eassert.
1096 * search.c (simple_search): Initialize match_byte to avoid
1097 compiler warning. Add eassert.
1099 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1101 Avoid weird behavior with large horizontal scrolls.
1102 Without this change, for example, large hscroll values would
1103 mess up Emacs's display on Fedora 15 x86, presumably due to
1104 overflows in int calculations in the display code.
1105 Also, if buffers had long lines, Emacs would freeze.
1106 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1107 (set_window_hscroll): New function, containing the old guts of
1108 Fset_window_hscroll. Return the clipped value.
1109 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1110 This avoids the need to check against PTRDIFF_MAX.
1112 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1114 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1116 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1118 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1120 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1121 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1122 since GCC 4.4.6 issues a bogus warning for them.
1124 Fix bugs in file timestamp newness comparisons.
1125 * fileio.c (Ffile_newer_than_file_p):
1126 * lread.c (Fload): Use full timestamp resolution of files,
1127 not just the 1-second resolution, so that files that are only
1128 slightly newer still count as newer.
1129 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1130 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1132 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1134 * fileio.c: Improve handling of file time marker. (Bug#11852)
1135 (special_mtime): New function.
1136 (Finsert_file_contents, Fverify_visited_file_modtime):
1137 Use it to set special mtime values consistently.
1139 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1141 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1142 marker for non-existing file. (Bug#11852)
1144 2012-07-03 Glenn Morris <rgm@gnu.org>
1146 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1147 and did not make it into globals.h).
1149 2012-07-03 Tom Tromey <tromey@redhat.com>
1151 * window.c (Fset_window_margins, Fset_window_fringes)
1152 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1153 * textprop.c (Fprevious_property_change): No longer static.
1154 * syntax.c (Fsyntax_table_p): No longer static.
1155 * process.c (Fget_process, Fprocess_datagram_address): No longer
1157 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1158 * keyboard.c (Fcommand_execute): No longer static.
1160 * insdel.c (Fcombine_after_change_execute): No longer static.
1161 * image.c (Finit_image_library): No longer static.
1162 * fileio.c (Fmake_symbolic_link): No longer static.
1163 * eval.c (Ffetch_bytecode): No longer static.
1164 * editfns.c (Fuser_full_name): No longer static.
1165 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1167 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1169 * dired.c (Ffile_attributes): No longer static.
1170 * composite.c (Fcomposition_get_gstring): No longer static.
1171 * callproc.c (Fgetenv_internal): No longer static.
1173 * ccl.h: Remove EXFUNs.
1174 * buffer.h: Remove EXFUNs.
1175 * dispextern.h: Remove EXFUNs.
1176 * intervals.h: Remove EXFUNs.
1177 * fontset.h: Remove EXFUN.
1178 * font.h: Remove EXFUNs.
1179 * dosfns.c (system_process_attributes): Remove EXFUN.
1180 * keymap.h: Remove EXFUNs.
1181 * lisp.h: Remove EXFUNs.
1182 * w32term.h: Remove EXFUNs.
1183 * window.h: Remove EXFUNs.
1184 * xsettings.h: Remove EXFUN.
1185 * xterm.h: Remove EXFUN.
1187 2012-07-03 Glenn Morris <rgm@gnu.org>
1189 * lisp.h (Frandom): Make it visible to C.
1190 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1191 buffer for invisible buffers. (Bug#1229)
1193 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1195 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1196 values which aren't power of 2.
1197 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1198 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1201 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1203 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1205 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1207 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1209 * alloc.c (allocate_vector_block): Remove redundant
1210 calls to mallopt if DOUG_LEA_MALLOC is defined.
1211 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1212 avoid calls to mallopt if zero_vector is returned.
1214 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1216 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1217 is enabled, avoid dereferencing NULL current_sblock if
1220 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1222 Cleanup basic buffer management.
1223 * buffer.h (struct buffer): Change layout to use generic vector
1224 marking code. Fix some comments. Change type of 'clip_changed'
1225 to bitfield. Remove unused #ifndef old.
1226 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1227 (GET_OVERLAYS_AT): Fix indentation.
1228 (for_each_per_buffer_object_at): New macro.
1229 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1230 (Fbuffer_local_variables): Use it.
1231 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1232 * alloc.c (allocate_buffer): Adjust to match new layout of
1233 struct buffer. Fix comment.
1234 (mark_overlay): New function.
1235 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1236 Lisp area of struct buffer.
1237 (mark_object): Use it. Adjust marking of misc objects
1238 and related comments.
1240 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1242 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1243 wrapper that is not needed because the wrapped code is a no-op (zero
1244 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1245 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1247 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1249 * alloc.c (mark_buffer): Simplify. Remove prototype.
1250 (mark_object): Add comment. Reorganize marking of vector-like
1251 objects. Use CHECK_LIVE for all vector-like objects except buffers
1252 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1253 redundant calls to mark_vectorlike for bool vectors.
1255 2012-06-30 Glenn Morris <rgm@gnu.org>
1257 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1259 * epaths.in (PATH_SITELOADSEARCH): New.
1260 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1261 This is rather than relying on --enable-locallisppath elements
1262 having "site-lisp" in their names. (Bug#10208#25, 11658)
1264 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1266 * w32proc.c (sys_select): Accept and ignore one more argument.
1268 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1270 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1271 (pselect) [!MS_DOS]: Redirect to sys_select.
1273 * sysdep.c: Don't include dos.h and dosfns.h.
1275 * process.c (sys_select):
1276 * msdos.c (sys_select): Accept one more argument and ignore it.
1278 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1279 adapt data types and code to that.
1282 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1283 which clashes with the gnulib function of the same name.
1285 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1287 * font.c (font_style_to_value, font_style_symbolic)
1288 (font_prop_validate_style): Add type checks for values in
1291 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1293 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1296 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1298 * xdisp.c (try_window_id): Undo last change.
1300 * w32.c (getwd): Adjust commentary about startup_dir.
1301 (init_environment): Always call sys_access, even in non-MSVC
1302 builds. Don't chdir to the directory of the Emacs executable.
1303 This undoes code from 1997 which was justified by the need to
1304 "avoid conflicts when removing and renaming directories". But its
1305 downside was that every relative file name was being interpreted
1306 relative to the directory of the Emacs executable, which can never
1307 be TRT. In particular, it broke sys_access when called with
1308 relative file names.
1309 (sys_access): Map GetLastError to errno.
1311 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1313 * window.h (struct window): Change type of 'fringes_outside_margins'
1314 to bitfield. Fix comment. Adjust users accordingly.
1315 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1317 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1320 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1322 * gnutls.c (emacs_gnutls_handshake):
1323 Add QUIT to make the loop interruptible.
1325 2012-06-29 Glenn Morris <rgm@gnu.org>
1327 * charset.c (init_charset): Make lack of etc/charsets fatal.
1329 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1331 * editfns.c (region_limit): Fix type mismatch.
1333 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1335 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1336 undefined. Convert from xassert to eassert.
1337 * nsmenu.m: Convert from xassert to eassert.
1338 * nsterm.m: Likewise.
1340 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1342 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1344 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1346 Avoid integer overflow on scroll-left and scroll-right.
1347 * window.c (HSCROLL_MAX): New macro.
1348 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1349 overflow when requested scroll falls outside ptrdiff_t range.
1351 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1353 * window.h (struct window): Change type of 'hscroll',
1354 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1355 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1356 Adjust users accordingly.
1357 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1358 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1359 from EMACS_INT to ptrdiff_t.
1360 (make_window): Omit redundant initialization.
1362 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1364 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1366 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1368 * window.h (struct window): Change type of 'use_time' and
1369 'sequence_number' from Lisp_Object to int.
1370 * frame.c (make_frame): Adjust users accordingly.
1371 * print.c (print_object): Likewise.
1372 * window.c (select_window, Fwindow_use_time, make_parent_window)
1373 (make_window): Likewise.
1375 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1377 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1378 enabled with --enable-checking=[all,glyphs] configure option.
1379 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1380 adjust comments accordingly.
1381 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1382 undefined, adjust comments accordingly.
1383 * image.c: Likewise.
1384 * scroll.c: Likewise.
1385 * w32fns.c: Likewise.
1386 * w32term.c: Likewise.
1387 * xdisp.c: Likewise.
1388 * xfaces.c: Likewise.
1390 * xterm.c: Likewise.
1392 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1394 Generalize run-time debugging checks.
1395 * dispextern.h (XASSERTS): Remove.
1396 * fontset.c (xassert): Remove.
1397 Convert from xassert to eassert.
1398 * alloc.c: Convert from xassert to eassert.
1400 * dispnew.c: Likewise.
1402 * fringe.c: Likewise.
1403 * ftfont.c: Likewise.
1404 * gtkutil.c: Likewise.
1405 * image.c: Likewise.
1406 * keyboard.c: Likewise.
1408 * process.c: Likewise.
1409 * scroll.c: Likewise.
1410 * sound.c: Likewise.
1412 * w32console.c: Likewise.
1413 * w32fns.c: Likewise.
1414 * w32term.c: Likewise.
1415 * window.c: Likewise.
1416 * xdisp.c: Likewise.
1417 * xfaces.c: Likewise.
1419 * xselect.c: Likewise.
1420 * xterm.c: Likewise.
1422 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1424 * fns.c (maybe_resize_hash_table): Output message when growing the
1427 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1429 * alloc.c (allocate_string_data): Remove dead code.
1430 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1431 avoid GCC warning about unused macro.
1433 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1435 * alloc.c (allocate_string): Omit intervals initialization.
1436 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1437 as in make_pure_string and make_pure_c_string.
1439 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1441 * alloc.c (allocate_string): Fix last change.
1443 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1445 * alloc.c (allocate_string): Remove two redundant calls
1446 to memset, add explicit initialization where appropriate.
1448 2012-06-27 Glenn Morris <rgm@gnu.org>
1450 * lisp.mk (lisp): Remove paths.elc.
1452 2012-06-27 Chong Yidong <cyd@gnu.org>
1454 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1456 2012-06-26 John Wiegley <johnw@newartisans.com>
1458 * unexmacosx.c (copy_data_segment): Add two section names used
1459 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1461 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1462 when building with Clang.
1464 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1466 * eval.c (Fapply): Allow calling it with a single argument.
1468 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1470 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1471 _stricmp and _strnicmp.
1472 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1474 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1476 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1478 (allocate_process): Likewise for new process.
1479 (allocate_terminal): Change to use offsetof.
1480 (allocate_frame): Likewise.
1481 * frame.c (make_frame): Omit redundant initialization.
1482 * window.c (make_parent_window): Use memset.
1483 (make_window): Omit redundant initialization.
1484 * process.c (make_process): Omit redundant initialization.
1485 * terminal.c (create_terminal): Likewise.
1487 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1489 * term.c (delete_tty): Remove redundant call to memset.
1491 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1493 * alloc.c: Remove build_string.
1494 * lisp.h: Define build_string as static inline. This provides
1495 a better opportunity to optimize away calls to strlen when the
1496 function is called with compile-time constant argument.
1497 * image.c (imagemagick_error): Convert to build_string.
1498 * w32proc.c (sys_spawnve): Likewise.
1499 * xterm.c (x_term_init): Likewise.
1501 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1503 Use sprintf return value instead of invoking strlen on result.
1504 In the old days this wasn't portable, since some sprintf
1505 implementations returned char *. But they died out years ago and
1506 Emacs already assumes sprintf returns int.
1507 Similarly for float_to_string.
1508 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1509 * ccl.c (ccl_driver):
1510 * character.c (string_escape_byte8):
1511 * data.c (Fnumber_to_string):
1512 * doprnt.c (doprnt):
1513 * print.c (print_object):
1514 * xdisp.c (message_dolog):
1515 * xfns.c (syms_of_xfns):
1516 Use sprintf or float_to_string result to avoid need to call strlen.
1517 * data.c (Fnumber_to_string):
1518 Use make_unibyte_string, since the string must be ASCII.
1519 * lisp.h, print.c (float_to_string): Now returns int length.
1520 * term.c (produce_glyphless_glyph):
1521 Use sprintf result rather than recomputing it.
1523 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1524 * Makefile.in (ALL_CFLAGS):
1525 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1526 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1528 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1530 * dispextern.h (xstrcasecmp): Define to library function
1531 strcasecmp if available.
1532 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1534 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1536 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1537 Avoid comma operator.
1538 * menu.c (push_submenu_start, push_submenu_end)
1539 (push_left_right_boundary, push_menu_pane): Likewise.
1540 * msdos.c (dos_rawgetc): Likewise.
1542 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1544 * xfns.c (xic_create_fontsetname): Remove redundant calls
1547 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1549 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1550 sprintf already null-terminates its output.
1552 * xfns.c (x_window): Remove redundant cast.
1554 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1556 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1557 `const char *' to `char *' to avoid compiler warning.
1559 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1561 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1562 instead of truncating it to 63 (admittedly a generous limit).
1564 * process.c: Fix spelling and caps in comments.
1566 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1568 * emacs.c (setpgrp): Remove definition, unused.
1569 * sysdep.c (setpgrp): Remove definition, not used in this file.
1571 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1573 * makefile.w32-in: Update dependencies.
1575 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1577 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1578 (SYSTIME_H): Add nt/inc/sys/time.h.
1580 * systime.h [WINDOWSNT]: Include sys/time.h.
1582 * s/ms-w32.h (struct timespec): Definition moved from
1583 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1585 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1587 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1588 * buffer.h (buffer_slot_type_mismatch):
1589 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1590 * eval.c (unwind_to_catch):
1591 * image.c (my_png_error, my_error_exit):
1592 * keyboard.c (quit_throw_to_read_char, user_error)
1593 (Fexit_recursive_edit, Fabort_recursive_edit):
1594 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1595 (wrong_type_argument, buffer_overflow, __executable_start)
1596 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1597 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1598 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1600 (child_setup) [!DOS_NT]:
1601 * lread.c (end_of_file_error, invalid_syntax):
1602 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1603 * puresize.h (pure_write_error):
1604 * search.c (matcher_overflow):
1605 * sound.c (sound_perror, alsa_sound_perror):
1606 * sysdep.c, syssignal.h (croak):
1607 * term.c (maybe_fatal, vfatal):
1608 * textprop.c (text_read_only):
1609 * undo.c (user_error):
1610 * unexmacosx.c (unexec_error):
1611 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1612 Use _Noreturn rather than NO_RETURN.
1613 No need for separate decl merely because of _Noreturn.
1614 * sound.c (sound_warning, parse_sound):
1615 Remove unnecessary forward decls.
1617 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1619 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1620 * lisp.h (WAIT_READING_MAX): New macro.
1621 * dispnew.c (Fsleep_for, sit_for):
1622 * keyboard.c (kbd_buffer_get_event):
1623 * process.c (Faccept_process_output):
1624 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1625 This improves on the previous patch, which introduced a bug
1626 when time_t is unsigned and as wide as intmax_t.
1627 See <http://bugs.gnu.org/9000#51>.
1629 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1631 * dispnew.c (sit_for, Fsleep_for):
1632 * keyboard.c (kbd_buffer_get_event):
1633 * process.c (Faccept_process_output): Avoid compiler warnings when
1634 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1636 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1638 * makefile.w32-in: Update dependencies.
1640 * w32.c (ltime): Add return type and declare static.
1641 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1643 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1645 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1646 Privately reported by Herbert J. Skuhra.
1647 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1649 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1650 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1652 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1654 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1655 last argument of make_unibyte_string.
1657 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1658 language ID in the event parameters.
1660 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1661 event.code, not the obscure "character set ID".
1663 2012-06-23 Chong Yidong <cyd@gnu.org>
1665 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1667 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1669 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1670 * w32.c (fdutimens): New function.
1672 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1674 * s/ms-w32.h (pselect): Redirect to sys_select.
1676 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1678 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1679 in the logic of incrementing and decrementing the value of
1680 use_relocatable_buffers.
1682 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1684 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1685 Privately reported by Herbert J. Skuhra.
1686 [__FreeBSD__]: Remove "*/" typo after "#include".
1687 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1688 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1689 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1690 Don't assume EMACS_TIME and struct timeval are the same type.
1692 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1694 Support higher-resolution time stamps (Bug#9000).
1695 The time stamps are only nanosecond-resolution at the C level,
1696 since that's the best that any real-world system supports now.
1697 But they are picosecond-resolution at the Lisp level, as that's
1698 easy, and leaves room for future OS improvements.
1700 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1703 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1704 Don't get current time unless it's needed.
1706 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1707 now provides it if it's absent.
1708 (start_atimer): Port to higher-res time stamps.
1709 Check for time stamp overflow. Don't get current time more
1710 often than is needed.
1712 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1713 Include systime.h, not time.h.
1714 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1716 * dired.c: Include stat-time.h.
1717 (Ffile-attributes): File times now have higher resolution.
1719 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1720 (struct image): Timestamp now has higher resolution.
1722 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1723 has at least microseconds now. All uses removed.
1724 (update_frame, update_single_window, update_window, update_frame_1)
1725 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1727 * editfns.c (time_overflow): Now extern.
1728 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1729 (float-time, Fformat_time_string, Fcurrent_time_string)
1730 (Fcurrent_time_zone): Accept and generate higher-resolution
1732 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1733 (decode_time_components, lisp_seconds_argument): New functions.
1734 (make_time): Now static.
1735 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1736 Report an error if the time is invalid, rather than having the caller
1739 * fileio.c: Include <stat-time.h>
1740 (Fcopy_file): Copy higher-resolution time stamps.
1741 Prefer to set the time stamp via a file descriptor if that works.
1742 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1743 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1744 (Fvisited_file_modtime, Fset_visited_file_modtime):
1745 Support higher-resolution time stamps.
1747 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1749 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1751 * image.c (prepare_image_for_display, clear_image_cache)
1752 (lookup_image): Port to higer-resolution time stamps.
1754 * keyboard.c (start_polling, bind_polling_period):
1755 Check for time stamp overflow.
1756 (read_char, kbd_buffer_get_event, timer_start_idle)
1757 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1758 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1759 Port to higher-resolution time stamps. Do not assume time_t is signed.
1760 (decode_timer): New function. Timers are now vectors of length 9,
1761 not 8, to accommodate the picosecond component.
1762 (timer_check_2): Use it.
1764 * nsterm.m (select_timeout, timeval_subtract): Remove.
1765 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1766 as they're a bit more accurate and handle overflow better.
1767 (ns_select): Change prototype to be compatible with pselect.
1768 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1769 * nsterm.h (ns_select): Adjust prototype.
1771 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1772 us-resolution time stamps.
1773 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1775 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1777 * lisp.h (time_overflow): New decl.
1778 (wait_reading_process_output): First arg is now intmax_t, not int,
1779 to accommodate larger waits.
1781 * process.h (struct Lisp_Process.read_output_delay):
1782 Now counts nanoseconds, not microseconds.
1783 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1785 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1786 (wait_reading_process_output):
1787 Port to ns-resolution time stamps.
1788 (Faccept_process_output, wait_reading_process_output):
1789 Check for time stamp overflow. Do not assume time_t is signed.
1790 (select_wrapper): Remove; we now use pselect.
1791 (Fprocess_attributes): Now generates ns-resolution time stamps.
1793 * sysdep.c: Include utimens.h. Don't include utime.h
1794 or worry about struct utimbuf; gnulib does that for us now.
1795 (gettimeofday): Remove; gnulib provides a substitute.
1796 (make_timeval): New function.
1797 (set_file_times): Now sets ns-resolution time stamps.
1798 New arg FD; all uses changed.
1799 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1800 (system_process_attributes):
1801 Now returns ns-resolution time stamp. All uses changed.
1802 Check for time stamp overflow.
1804 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1805 provides a substitute now.
1807 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1808 since it guarantees struct timespec.
1809 (EMACS_TIME): Now struct timespec, so that we can support
1810 ns-resolution time stamps.
1811 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1812 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1813 (EMACS_USECS): Remove.
1814 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1815 so multiply the arg by 1000 before storing it.
1816 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1818 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1819 Port to ns-resolution time stamps.
1820 (EMACS_TIME_NEG_P): Remove; replaced by....
1821 (EMACS_TIME_SIGN): New macro.
1822 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1823 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1824 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1825 (make_timeval, make_lisp_time, decode_time_components): New decls.
1826 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1827 that it mishandled time_t overflow. You can't compare by subtracting!
1828 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1829 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1831 * term.c: Include <sys/time.h>.
1832 (timeval_to_Time): New function, for proper overflow wraparound.
1833 (term_mouse_position, term_mouse_click): Use it.
1835 * undo.c (record_first_change): Support higher-resolution time stamps
1837 (Fprimitive_undo): Use them when restoring time stamps.
1839 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1840 (w32_get_internal_run_time):
1841 Port to higher-resolution Emacs time stamps.
1842 (ltime): Now accepts single 64-bit integer, as that's more convenient
1845 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1847 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1848 for compatibility with pselect. Support ns-resolution time stamps.
1850 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1852 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1853 Check for time stamp overflow, and support ns-resolution time stamps.
1855 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1856 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1857 (timeval_subtract): Remove; no longer needed.
1858 (XTflash, XTring_bell, x_wait_for_event):
1859 Port to ns-resolution time stamps. Don't assume time_t is signed.
1861 2012-06-22 Chong Yidong <cyd@gnu.org>
1863 * xdisp.c (x_consider_frame_title): Revert last change.
1865 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1867 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1868 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1869 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1870 staticidx goes up to 1597 out of 1600 = 0x640.)
1872 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1874 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1875 Otherwise, the umask might be mistakenly 0 while handling input signals.
1877 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1879 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1881 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1883 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1884 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1885 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1886 access to `contents' member of Lisp_Vector objects with AREF and ASET
1889 2012-06-19 Chong Yidong <cyd@gnu.org>
1891 * frame.c (delete_frame): When selecting a frame on a different
1892 text terminal, do not alter the terminal's top-frame.
1894 * xdisp.c (format_mode_line_unwind_data): Record the target
1895 frame's selected window and its terminal's top-frame.
1896 (unwind_format_mode_line): Restore them.
1897 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1899 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1900 since tty frames can be explicitly named.
1901 (prepare_menu_bars): Likewise.
1903 * term.c (Ftty_top_frame): New function.
1905 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1907 Port byte-code-meter to modern targets.
1908 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1909 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1910 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1911 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1912 (METER_1, METER_2): Simplify.
1914 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1916 * data.c (Fdefalias): Return `symbol' (bug#11686).
1918 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1920 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1921 gets killed during executing of this function (Bug#11665).
1922 Try to always return Qt when the buffer has been actually killed.
1923 (Vkill_buffer_query_functions): In doc-string say that functions
1924 run by this hook should not change the current buffer.
1926 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1928 Fix recently-introduced process.c problems found by static checking.
1929 * process.c (write_queue_push, write_queue_pop, send_process):
1930 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1931 (write_queue_pop): Fix pointer signedness problem.
1932 (send_process): Remove unused local.
1934 2012-06-17 Chong Yidong <cyd@gnu.org>
1936 * xdisp.c (redisplay_internal): No need to redisplay terminal
1937 frames that are not on top.
1939 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1941 * process.c (make_process): Initialize write_queue.
1942 (write_queue_push, write_queue_pop): New functions.
1943 (send_process): Use them to maintain correct ordering of process
1946 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1948 * lisp.h (eassert): Assume C89 or later.
1949 This removes the need for CHECK.
1950 (CHECK): Remove. Its comments about always evaluating its
1951 argument were confusing, as 'eassert' typically does not evaluate
1954 * coding.c (produce_chars): Use ptrdiff_t, not int.
1956 * xterm.c (x_draw_underwave): Check for integer overflow.
1957 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1959 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1961 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1962 referenced (Bug#11583).
1964 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1966 Implement wave-style variant of underlining.
1967 * dispextern.h (face_underline_type): New enum.
1968 (face): Add field for underline type.
1969 * nsterm.m (ns_draw_underwave): New function.
1970 (ns_draw_text_decoration): Use it.
1971 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1973 (x_draw_glyph_string): Use them.
1974 * xfaces.c (Qline, Qwave): New Lisp objects.
1975 (check_lface_attrs, merge_face_ref)
1976 (Finternal_set_lisp_face_attribute, realize_x_face):
1977 Handle wave-style underline face attributes.
1978 * xterm.c (x_draw_underwave): New function.
1979 (x_draw_glyph_string): Use it.
1981 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1983 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1984 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1985 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1986 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1987 ($(BLD)/w32select.$(O)): Update dependencies.
1989 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1991 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1992 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1993 * character.c (_fetch_multibyte_char_p): Remove.
1994 * alloc.c: Include "character.h" before "buffer.h".
1996 * buffer.c: Likewise.
1997 * bytecode.c: Likewise.
1998 * callint.c: Likewise.
1999 * callproc.c: Likewise.
2000 * casefiddle.c: Likewise.
2001 * casetab.c: Likewise.
2002 * category.c: Likewise.
2004 * coding.c: Likewise.
2005 * composite.c: Likewise.
2006 * dired.c: Likewise.
2007 * dispnew.c: Likewise.
2009 * dosfns.c: Likewise.
2010 * editfns.c: Likewise.
2011 * emacs.c: Likewise.
2012 * fileio.c: Likewise.
2013 * filelock.c: Likewise.
2015 * fontset.c: Likewise.
2016 * fringe.c: Likewise.
2017 * indent.c: Likewise.
2018 * insdel.c: Likewise.
2019 * intervals.c: Likewise.
2020 * keyboard.c: Likewise.
2021 * keymap.c: Likewise.
2022 * lread.c: Likewise.
2023 * macros.c: Likewise.
2024 * marker.c: Likewise.
2025 * minibuf.c: Likewise.
2026 * nsfns.m: Likewise.
2027 * nsmenu.m: Likewise.
2028 * print.c: Likewise.
2029 * process.c: Likewise.
2030 * regex.c: Likewise.
2031 * region-cache.c: Likewise.
2032 * search.c: Likewise.
2033 * syntax.c: Likewise.
2035 * textprop.c: Likewise.
2037 * unexsol.c: Likewise.
2038 * w16select.c: Likewise.
2039 * w32fns.c: Likewise.
2040 * w32menu.c: Likewise.
2041 * window.c: Likewise.
2042 * xdisp.c: Likewise.
2044 * xmenu.c: Likewise.
2046 * xselect.c: Likewise.
2048 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2050 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2051 If all the glyphs of the glyph row came from strings, and we have no
2052 cursor positioning clues, put the cursor on the first glyph of the
2054 (handle_face_prop): Use chunk-relative overlay string index when
2055 indexing into it->string_overlays array. (Bug#11653)
2056 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2057 the rightmost. (Bug#11720)
2059 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2061 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2062 (CATEGORY_MEMBER): Enforce 1/0 value.
2063 * category.c (_temp_category_set): Remove.
2065 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2067 * window.c (Fdelete_other_windows_internal)
2068 (Fdelete_window_internal): Don't access frame's mouse highlight
2069 info of the initial frame. (Bug#11677)
2071 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2073 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2074 Assume USE_2_TAGS_FOR_INTS.
2075 (xreload): Adjust $tagmask width to match recent lisp.h change.
2077 Simplify lisp.h in minor ways that should not affect code.
2078 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2079 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2080 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2081 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2082 (INTTYPEBITS): New macro, for clarity.
2083 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2084 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2085 Simplify now that USE_LSB_TAG is always defined.
2086 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2087 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2089 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2091 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2093 2012-06-13 Glenn Morris <rgm@gnu.org>
2095 * s/bsd-common.h (BSD4_3):
2096 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2098 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2100 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2103 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2105 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2106 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2107 * alloc.c (widen_to_Lisp_Object): Remove.
2108 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2109 * frame.c (delete_frame): Remove outdated comment.
2110 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2111 USE_LISP_UNION_TYPE.
2112 (Fw32_unregister_hot_key): Likewise.
2113 (Fw32_toggle_lock_key): Likewise.
2114 * w32menu.c (add_menu_item): Likewise.
2115 (w32_menu_display_help): Use XIL instead of checking
2116 USE_LISP_UNION_TYPE.
2117 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2118 (init_heap): Likewise.
2119 * w32term.c (w32_read_socket): Update comment.
2121 2012-06-13 Glenn Morris <rgm@gnu.org>
2123 * s/usg5-4-common.h, src/s/unixware.h:
2124 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2126 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2128 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2130 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2131 * alloc.c (make_number) [!defined make_number]:
2132 Remove, as lisp.h always defines this now.
2133 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2134 (roundup_size): Verify that it is a power of 2.
2135 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2136 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2137 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2138 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2139 USE_LSB_TAG now is always defined to be either 0 or 1.
2141 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2142 code works fine either way, and efficiency is not a concern here,
2143 as the union type is for debugging, not for production.
2144 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2145 Use an inline function on all platforms when using the union type,
2146 since this is simpler and 'static inline' can be used portably
2148 (LISP_INITIALLY_ZERO): New macro.
2149 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2150 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2152 2012-06-12 Glenn Morris <rgm@gnu.org>
2154 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2156 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2158 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2159 Move BROKEN_SIGIO to configure.
2161 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2162 Move NO_TERMIO to configure.
2164 2012-06-12 Chong Yidong <cyd@gnu.org>
2166 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2167 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2168 MagickExportImagePixels is undefined.
2170 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2172 * image.c (imagemagick_load_image): Remove unused label.
2174 2012-06-11 Glenn Morris <rgm@gnu.org>
2176 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2177 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2178 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2179 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2181 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2183 * alloc.c (make_byte_code): New function.
2184 (Fmake_byte_code): Use it. Don't purify here.
2185 * lread.c (read1): Use it as well to avoid extra allocation.
2187 2012-06-11 Chong Yidong <cyd@gnu.org>
2189 * image.c (imagemagick_load_image): Implement transparency.
2191 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2193 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2194 account for preceding backslashes. (Bug#11663)
2196 2012-06-09 Chong Yidong <cyd@gnu.org>
2198 * term.c: Support italics in capable terminals (Bug#9652).
2199 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2200 (turn_on_face): Output using TS_enter_italic_mode if available.
2201 Don't handle unused blinking and alt-charset cases.
2202 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2203 and tty_alt_charset_p cases.
2204 (tty_capable_p, init_tty): Support italics.
2206 * termchar.h (struct tty_display_info): Add field for italics.
2207 Remove unused blink field.
2209 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2212 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2213 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2214 tty_alt_charset_p. Add tty_italic_p.
2216 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2218 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2219 dbus_type_is_basic if available.
2220 (xd_extract_signed, xd_extract_unsigned): Rename from
2221 extract_signed and extract_unsigned, respectively. Adapt callers.
2223 2012-06-09 Chong Yidong <cyd@gnu.org>
2225 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2227 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2230 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2232 * xdisp.c (vmessage): Treat frame message as multibyte.
2233 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2234 would generate the diagnostic "Making \302\247 buffer-local while
2237 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2239 * dispnew.c (showing_window_margins_p): Undo last change, which
2240 was done due to an inadvertent commit.
2241 (adjust_frame_glyphs_for_frame_redisplay): Do call
2242 showing_window_margins_p.
2244 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2246 * eval.c (Fmake_var_non_special): New primitive.
2247 (syms_of_eval): Defsubr it.
2248 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2250 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2252 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2253 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2255 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2257 * alloc.c (allocate_vectorlike): Fix last change.
2259 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2261 Block-based vector allocation of small vectors.
2262 * lisp.h (struct vectorlike_header): New field `nbytes',
2263 adjust comment accordingly.
2264 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2265 to denote vector blocks. Adjust users (live_vector_p,
2266 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2267 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2268 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2269 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2270 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2271 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2272 (roundup_size): New constant.
2273 (struct vector_block): New data type.
2274 (vector_blocks, vector_free_lists, zero_vector): New variables.
2275 (all_vectors): Rename to `large_vectors'.
2276 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2277 (sweep_vectors): New functions.
2278 (allocate_vectorlike): Return `zero_vector' as the only vector of
2279 0 items. Allocate new vector from block if vector size is less than
2280 or equal to VBLOCK_BYTES_MAX.
2281 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2282 (init_alloc_once): Add call to init_vectors.
2284 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2286 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2288 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2290 * doprnt.c (doprnt): Truncate multibyte char correctly.
2291 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2292 would mishandle a string argument "Xc" if X was a multibyte
2293 character of length 2: it would truncate after X's first byte
2294 rather than including all of X.
2296 2012-06-06 Chong Yidong <cyd@gnu.org>
2298 * buffer.c (word_wrap): Doc fix.
2300 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2302 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2304 2012-06-03 Glenn Morris <rgm@gnu.org>
2306 * xdisp.c (tool-bar-style): Doc fix.
2308 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2310 * Makefile.in (PAXCTL): Define.
2311 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2312 binary via PaX flags if the paxctl utility is available.
2313 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2314 Restore PaX flags to their default. (Bug#11398)
2316 2012-06-03 Chong Yidong <cyd@gnu.org>
2318 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2321 2012-06-03 Chong Yidong <cyd@gnu.org>
2323 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2324 (note_mode_line_or_margin_highlight): If there is no help echo,
2325 use mode-line-default-help-echo. Handle the case where the mouse
2326 position is past the end of the mode line string.
2328 * buffer.c (buffer_local_value_1): New function, split from
2329 Fbuffer_local_value; can return Qunbound.
2330 (Fbuffer_local_value): Use it.
2331 (Vmode_line_format): Docstring tweaks.
2333 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2335 * sysdep.c (system_process_attributes): Improve comment.
2337 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2339 * keyboard.c: Export real-this-command to Elisp.
2340 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2341 and DEFVAR it. Update all users.
2343 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2345 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2347 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2348 Convert pctcpu and pctmem to Lisp float properly.
2349 Let the compiler fold better, as 100.0/0x8000 is exact.
2351 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2353 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2356 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2358 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2360 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2362 For a 'struct window', replace some Lisp_Object fields to
2363 bitfields where appropriate, remove unused fields.
2364 * window.h (struct window): Remove unused 'last_mark_x' and
2365 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2366 change it's type from Lisp_Object to bitfield.
2367 Change type of 'force_start', 'optional_new_start',
2368 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2369 fields from Lisp_Object to bitfield. Adjust users accordingly.
2371 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2373 Pacify gcc -Wdouble-precision when using Xaw.
2374 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2375 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2376 Use 'float' consistently, rather than 'float' in most places
2377 and 'double' in a couple of places.
2379 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2381 * xdisp.c (handle_stop): Detect whether we have overlay strings
2382 loaded by testing it->current.overlay_string_index to be
2383 non-negative, instead of checking whether n_overlay_strings is
2384 positive. (Bug#11587)
2386 2012-05-31 Chong Yidong <cyd@gnu.org>
2388 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2390 * doc.c (Fsubstitute_command_keys): Doc fix.
2392 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2394 * search.c (search_buffer): Remove calls to
2395 r_alloc_inhibit_buffer_relocation, as it is now called by
2396 maybe_unify_char, which was the cause of relocation of buffer text
2399 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2401 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2402 for the duration of call to load_charset, to avoid problems with
2403 callers of maybe_unify_char that access buffer text through C
2406 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2407 decrement the inhibition flag, instead of just setting or
2410 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2412 Remove obsolete '#define static' cruft.
2413 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2414 This #undef was "temporary" in 2000; it is no longer needed
2415 now that '#define static' has gone away.
2416 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2417 (gray_bitmap_bits): Remove; no longer needed.
2418 All uses replaced with definiens.
2419 * xterm.c: Include "bitmaps/gray.xbm".
2421 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2423 Clean up __executable_start, monstartup when --enable-profiling.
2424 The following changes affect the code only when profiling.
2425 * dispnew.c (__executable_start): Rename from safe_bcopy.
2426 Define only on platforms that need it.
2427 * emacs.c: Include <sys/gmon.h> when profiling.
2428 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2429 (__executable_start): Remove decl, since lisp.h does it now.
2430 (safe_bcopy): Remove decl; no longer has that name.
2431 (main): Coalesce #if into single bit of code, for simplicity.
2432 Cast pointers to uintptr_t, since standard libraries want integers
2434 * lisp.h (__executable_start): New decl.
2436 2012-05-31 Glenn Morris <rgm@gnu.org>
2438 * image.c (Fimagemagick_types): Doc fix.
2440 2012-05-30 Jim Meyering <meyering@redhat.com>
2442 * callproc.c (Fcall_process_region): Include directory component
2443 in mkstemp error message (Bug#11586).
2445 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2447 * alloc.c, lisp.h (make_pure_vector): Now static.
2449 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2451 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2452 Move to byte-run.el.
2453 (Fautoload): Do the hash-doc more carefully.
2454 * data.c (Fdefalias): Purify definition, except for keymaps.
2455 (Qdefun): Move from eval.c.
2456 * lisp.h (Qdefun): Remove.
2457 * lread.c (read1): Tiny simplification.
2459 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2461 Do not create empty overlays with the evaporate property (Bug#9642).
2462 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2463 Bug#9642, but explicitly check that the buffer the overlay would
2464 be moved to is live and rearrange lines to make sure that errors
2465 will not put the overlay in an inconsistent state.
2466 (Fdelete_overlay): Cosmetics.
2468 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2470 * w32term.c (my_bring_window_to_top): New function.
2471 (x_raise_frame): Use handle returned by DeferWindowPos, which
2472 could be different from the original one.
2473 Call my_bring_window_to_top instead of my_set_foreground_window.
2476 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2477 by calling BringWindowToTop.
2479 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2480 (WM_EMACS_END): Increase by one.
2482 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2484 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2485 This avoids undefined behavior that might cause the eassert
2486 to not catch an out-of-range value.
2488 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2490 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2491 Update dependencies.
2493 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2495 * bidi.c (bidi_mirror_char): Fix last change.
2497 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2499 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2500 when referring to sectname field in printf format.
2502 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2504 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2505 Only r_alloc_inhibit_buffer_relocation needed to be added;
2506 the others were already declared.
2508 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2509 before checking whether it's out of range. Put the check inside
2511 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2513 2012-05-27 Ken Brown <kbrown@cornell.edu>
2515 * callproc.c (Fcall_process): Restore a line that was accidentally
2516 commented out in the 2011-02-13 change (bug#11547).
2518 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2520 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2521 defined on ralloc.c.
2523 * buffer.c [REL_ALLOC]: Remove prototypes of
2524 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2525 they are now on lisp.h.
2527 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2529 * search.c (search_buffer): Use it to inhibit relocation of buffer
2530 text while re_search_2 is doing its job, because re_search_2 is
2531 passed C pointers to buffer text. (Bug#11519)
2533 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2536 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2537 state after an additional call to move_it_in_display_line_to, keep
2538 the values of it->max_ascent and it->max_descent found for the
2540 (pos_visible_p): Revert the comparison against bottom_y to what it
2541 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2544 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2546 Fix coding-related core dumps with gcc -ftrapv.
2547 The code was computing A - B, where A and B are pointers, and B is
2548 random garbage. This can lead to core dumps on platforms that
2549 have special pointer registers, and it also leads to core dumps on
2550 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2551 A - B only when B is initialized properly.
2552 * coding.c (coding_set_source, coding_set_destination): Return void.
2553 (coding_change_source, coding_change_destinations): New functions,
2554 with the old behaviors of coding_set_source and coding_set_destination.
2555 All callers that need an offset changed to use these new functions.
2557 2012-05-26 Glenn Morris <rgm@gnu.org>
2559 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2561 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2563 Extend mouse support on W32 text-mode console.
2564 * xdisp.c (draw_row_with_mouse_face):
2565 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2567 * w32console.c: Include window.h.
2568 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2570 (initialize_w32_display): Initialize mouse-highlight data.
2572 * w32inevt.c: Include termchar.h and window.h.
2573 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2574 moves, call note_mouse_highlight. If help_echo changed, call
2575 gen_help_event to produce help-echo message in the echo area.
2576 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2579 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2581 * lread.c (read1): Simplify slightly to avoid an overflow warning
2582 with GCC 4.7.0 on x86-64.
2584 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2586 * bidi.c (bidi_mirror_char): Revert last change: an int is
2587 definitely wide enough here.
2589 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2591 Fix integer width and related bugs (Bug#9874).
2592 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2593 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2594 (string_bytes, check_sblock, allocate_string_data):
2595 (compact_small_strings, Fmake_bool_vector, make_string)
2596 (make_unibyte_string, make_multibyte_string)
2597 (make_string_from_bytes, make_specified_string)
2598 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2599 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (allocate_pseudovector):
2603 Use int, not EMACS_INT, where int is wide enough.
2604 (inhibit_garbage_collection, Fgarbage_collect):
2605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2606 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2607 int might not be wide enough.
2608 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2609 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2610 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2611 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2612 (bidi_level_of_next_char, bidi_move_to_visually_next):
2613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2614 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2615 (Fkill_buffer, Fset_buffer_major_mode)
2616 (advance_to_char_boundary, Fbuffer_swap_text)
2617 (Fset_buffer_multibyte, overlays_at, overlays_in)
2618 (overlay_touches_p, struct sortvec, record_overlay_string)
2619 (overlay_strings, recenter_overlay_lists)
2620 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2621 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2622 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2623 (Foverlay_recenter, last_overlay_modification_hooks_used)
2624 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (validate_region): Omit unnecessary test for b <= e,
2627 since that's guaranteed by the previous test.
2628 (adjust_overlays_for_delete): Avoid pos + length overflow.
2629 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2630 (report_overlay_modification):
2631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2632 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2633 Omit pointer cast, which isn't needed anyway, and doesn't work
2634 after the EMACS_INT -> ptrdiff_t change.
2635 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2636 * buffer.h: Adjust decls to match defn changes elsewhere.
2637 (struct buffer_text, struct buffer):
2638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2639 Use EMACS_INT, not int, where int might not be wide enough.
2640 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2641 not int, to avoid needless 32-bit limit on 64-bit hosts.
2642 (exec_byte_code): Use tighter memory-full test, one that checks
2643 for alloca overflow. Don't compute the address of the object just
2644 before an array, as that's not portable. Use EMACS_INT, not
2645 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2646 * callint.c (Fcall_interactively):
2647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2648 * callproc.c (call_process_kill, Fcall_process):
2649 Don't assume pid_t fits into an Emacs fixnum.
2650 (call_process_cleanup, Fcall_process, child_setup):
2651 Don't assume pid_t fits into int.
2652 (call_process_cleanup, Fcall_process, delete_temp_file)
2653 (Fcall_process_region):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (Fcall_process): Simplify handling of volatile integers.
2656 Use int, not EMACS_INT, where int will do.
2657 * casefiddle.c (casify_object, casify_region, operate_on_word)
2658 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2660 (casify_object): Avoid integer overflow when overallocating buffer.
2661 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2662 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2663 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2664 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2665 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2666 integers are now checked earlier. All uses replaced with XINT.
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 For CCL_MapSingle, check that content and value are in int range.
2670 (ccl_driver, Fregister_code_conversion_map):
2671 Check that Vcode_version_map_vector is a vector.
2672 (resolve_symbol_ccl_program): Check that vector header is in range.
2673 Always copy the vector, so that we can check its contents reliably
2674 now rather than having to recheck each instruction as it's being
2675 executed. Check that vector words fit in 'int'.
2676 (ccl_get_compiled_code, Fregister_ccl_program)
2677 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2678 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2679 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2680 contents are in range.
2681 (Fccl_execute_on_string): Check that status is in range.
2682 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2683 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2684 Accept and return EMACS_INT, not int, because callers can pass values
2686 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2687 (multibyte_chars_in_text, parse_str_as_multibyte)
2688 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2689 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2690 (string_escape_byte8, Fget_byte):
2691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2692 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2693 avoid mishandling large integers.
2694 * character.h: Adjust decls to match defn changes elsewhere.
2695 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2696 (Ffind_charset_region):
2697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2698 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2699 (load_charset_map_from_vector, Fdefine_charset_internal):
2700 Don't assume fixnum fits in int.
2701 (load_charset_map_from_vector, Fmap_charset_chars):
2702 Remove now-unnecessary CHECK_NATNUMs.
2703 (Fdefine_charset_internal): Check ranges here, more carefully.
2704 Don't rely on undefined behavior with signed left shift overflow.
2705 Don't assume unsigned int fits into fixnum, or that fixnum fits
2706 into unsigned int. Don't require max_code to be a valid fixnum;
2707 that's not true for gb10830 4-byte on a 32-bit host. Allow
2708 invalid_code to be a cons, for the same reason. Require code_offset
2709 to be a character. Avoid int overflow if max_char is close
2711 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2712 this is intended anyway and avoids some undefined behavior.
2713 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2714 INDEX_TO_CODE_POINT, as that's what it expects.
2715 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2716 * charset.h (DECODE_CHAR): Return int, not unsigned;
2717 this is what was intended anyway, and it avoids undefined behavior.
2718 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2719 integer-overflow issues.
2720 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2721 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2722 where the argument is EMACS_INT, and this behavior is not intended.
2723 * chartab.c (Fmake_char_table, Fset_char_table_range)
2724 (uniprop_get_decoder, uniprop_get_encoder):
2725 Don't assume fixnum fits in int.
2726 * cmds.c (move_point): New function, that does the gist of
2727 Fforward_char and Fbackward_char, but does so while checking
2728 for integer overflow more accurately.
2729 (Fforward_char, Fbackward_char): Use it.
2730 (Fforward_line, Fend_of_line, internal_self_insert)
2731 (internal_self_insert):
2732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2733 Fix a FIXME, by checking for integer overflow when calculating
2734 target_clm and actual_clm.
2735 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2736 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2737 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2738 (coding_alloc_by_making_gap, alloc_destination)
2739 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2740 (encode_coding_utf_16, detect_coding_emacs_mule)
2741 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2742 (detect_coding_iso_2022, decode_coding_iso_2022)
2743 (encode_invocation_designation, encode_designation_at_bol)
2744 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2745 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2746 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2747 (encode_coding_ccl, encode_coding_raw_text)
2748 (detect_coding_charset, decode_coding_charset)
2749 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2750 (produce_composition, produce_charset, produce_annotation)
2751 (decode_coding, handle_composition_annotation)
2752 (handle_charset_annotation, consume_chars, decode_coding_gap)
2753 (decode_coding_object, encode_coding_object, detect_coding_system)
2754 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2755 (code_convert_region, code_convert_string)
2756 (Fdefine_coding_system_internal)
2757 (coding_set_source, coding_set_destination):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2760 (Fdefine_coding_system_internal):
2761 Don't assume fixnums fit in int.
2762 (decode_coding_gap, decode_coding_object, encode_coding_object)
2763 (Fread_coding_system, Fdetect_coding_region)
2764 (Funencodable_char_position, Fcheck_coding_systems_region)
2765 (get_translation, handle_composition_annotation, consume_chars):
2766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2767 (consume_chars): Rewrite to not calculate an address outside buffer.
2768 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2769 Don't access memory outside of the args array.
2770 (Fdefine_coding_system_internal): Check for charset-id overflow.
2771 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2772 result of ENCODE_CHAR.
2773 * coding.h: Adjust decls to match defn changes elsewhere.
2774 (struct coding_system):
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 * composite.c (get_composition_id, find_composition)
2777 (run_composition_function, update_compositions)
2778 (compose_text, composition_gstring_put_cache)
2779 (composition_gstring_p, composition_gstring_width)
2780 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2781 (composition_compute_stop_pos, composition_reseat_it)
2782 (composition_update_it, struct position_record)
2783 (find_automatic_composition, composition_adjust_point)
2784 (Fcomposition_get_gstring, Ffind_composition_internal):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (update_compositions):
2787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2788 * composite.h: Adjust decls to match defn changes elsewhere.
2789 (struct composition):
2790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2791 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2792 Do not attempt to compute the address of the object just before a
2793 buffer; this is not portable.
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 (Faset): Use int, not EMACS_INT, where int is wide enough.
2797 (Fstring_to_number): Don't assume fixnums fit in int.
2798 (Frem): Don't assume arg is nonnegative.
2799 * dbusbind.c (xd_append_arg): Check for integers out of range.
2800 (Fdbus_call_method): Don't overflow the timeout int.
2801 (extract_signed, extract_unsigned): New functions.
2802 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2803 (xd_get_connection_references): Return ptrdiff_t, not int.
2805 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2806 (xd_read_message_1):
2807 Use int, not unsigned, where the dbus API uses int.
2808 (Fdbus_message_internal): Don't overflow mtype.
2809 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2810 * dired.c (directory_files_internal, file_name_completion, scmp)
2811 (file_name_completion_stat):
2812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2813 (file_name_completion): Don't overflow matchcount.
2814 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2815 * dispextern.h: Adjust decls to match defn changes elsewhere.
2816 (struct text_pos, struct glyph, struct bidi_saved_info)
2817 (struct bidi_string_data, struct bidi_it, struct composition_it)
2819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2820 (struct display_pos, struct composition_it, struct it):
2821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2822 * dispnew.c (increment_matrix_positions)
2823 (increment_row_positions, mode_line_string)
2824 (marginal_area_string):
2825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2826 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2828 (duration_to_sec_usec): New function, to check for overflow better.
2829 (Fsleep_for, sit_for): Use it.
2830 * doc.c (get_doc_string, store_function_docstring):
2831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2832 (get_doc_string, Fsnarf_documentation):
2833 Use int, not EMACS_INT, where int is wide enough.
2835 Use SAFE_ALLOCA, not alloca.
2836 Check for overflow when converting EMACS_INT to off_t.
2837 * doprnt.c (doprnt):
2838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2839 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2840 Don't assume uid_t fits into fixnum.
2841 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2842 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2843 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2844 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2845 (general_insert_function)
2846 (Finsert_char, make_buffer_string, make_buffer_string_both)
2847 (update_buffer_properties, Fbuffer_substring)
2848 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2849 (Fsubst_char_in_region, check_translation)
2850 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2851 (transpose_markers, Ftranspose_regions):
2852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2853 (clip_to_bounds): Move to lisp.h as an inline function).
2854 (Fconstrain_to_field): Don't assume integers are nonnegative.
2855 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2856 (Fsubst_char_in_region, Fsave_restriction):
2857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2858 (Femacs_pid): Don't assume pid_t fits into fixnum.
2859 (lo_time): Use int, not EMACS_INT, when int suffices.
2860 (lisp_time_argument): Check for usec out of range.
2861 (Fencode_time): Don't assume fixnum fits in int.
2862 (Fuser_login_name, Fuser_full_name): Signal an error
2863 if a uid argument is out of range, rather than relying on
2865 (Fformat_time_string): Remove now-unnecessary check.
2866 lisp_time_argument checks for out-of-range usec now.
2867 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2868 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2869 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2870 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2871 (init_cmdargs, Fdump_emacs):
2872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2873 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2874 the bottom (typically) 32 bits of the fixnum.
2875 * eval.c (specpdl_size, call_debugger):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 (when_entered_debugger, Fbacktrace_debug):
2878 Don't assume fixnum can fit in int.
2879 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2880 the object just before a buffer; this is not portable.
2881 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2882 (grow_specpdl, unbind_to):
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2884 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2885 (grow_specpdl): Simplify allocation by using xpalloc.
2886 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2887 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2888 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2890 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2893 (Fcopy_file, non_regular_nbytes, read_non_regular)
2894 (Finsert_file_contents):
2895 Use int, not EMACS_INT, where int is wide enough.
2896 (READ_BUF_SIZE): Verify that it fits in int.
2897 (Finsert_file_contents): Check that counts are in proper range,
2898 rather than assuming fixnums fit into ptrdiff_t etc.
2899 Don't assume fixnums fit into int.
2900 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2901 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2902 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2903 (string_char_to_byte, string_byte_to_char)
2904 (string_make_multibyte, string_to_multibyte)
2905 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2906 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2907 (substring_both, Fdelete, internal_equal, Ffillarray)
2908 (Fclear_string, mapcar1)
2909 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2910 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2911 (larger_vector, make_hash_table, maybe_resize_hash_table)
2912 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2913 (Fmaphash, secure_hash):
2914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2915 (concat): Check for string index and length overflow.
2916 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2919 (larger_vector): New API (vec, incr_min, size_max) replaces old
2920 one (vec, new_size, init). This catches size overflow.
2921 INIT was removed because it was always Qnil.
2922 All callers changed.
2923 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2924 the upper bound on a hash table index size.
2925 (make_hash_table, maybe_resize_hash_table): Use it.
2926 (secure_hash): Computer start_byte and end_byte only after
2927 they're known to be in ptrdiff_t range.
2928 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2929 (Ffont_get_glyphs, Ffont_at):
2930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2931 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2932 (Flist_fonts, Fopen_font):
2933 Don't assume fixnum can fit in int.
2934 (check_gstring): Don't assume index can fit in int.
2935 (font_match_p): Check that fixnum is a character, not a nonnegative
2936 fixnum, since the later code needs to stuff it into an int.
2937 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2938 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2939 conversion overflow issues.
2940 (Fopen_font): Check for integer out of range.
2941 (Ffont_get_glyphs): Don't assume index can fit in int.
2942 * font.h: Adjust decls to match defn changes elsewhere.
2943 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2945 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2946 printmax_t, where ptrdiff_t is wide enough.
2947 (Finternal_char_font):
2948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2949 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2950 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2951 (Fset_frame_position, x_set_frame_parameters)
2952 (x_set_line_spacing, x_set_border_width)
2953 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2954 Check that fixnums are in proper range for system types.
2955 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2957 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2958 Use SAFE_ALLOCA_LISP, not alloca.
2959 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2960 intptr_t is wide enough.
2961 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2962 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2963 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2964 Check for fixnum out of range.
2965 * ftfont.c (ftfont_list): Don't assume index fits in int.
2966 Check that fixnums are in proper range for system types.
2967 (ftfont_shape_by_flt):
2968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2969 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2971 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2972 Check that fixnums are in proper range for system types.
2973 * gnutls.h: Adjust decls to match defn changes elsewhere.
2974 * gtkutil.c (xg_dialog_run):
2975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2976 (update_frame_tool_bar):
2977 Check that fixnums are in proper range for system types.
2978 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2979 (lookup_image): Check that fixnums are in range for system types.
2980 * indent.c (last_known_column, last_known_column_point):
2981 (current_column_bol_cache):
2982 (skip_invisible, current_column, check_display_width):
2983 (check_display_width, scan_for_column, current_column_1)
2984 (Findent_to, Fcurrent_indentation, position_indentation)
2985 (indented_beyond_p, Fmove_to_column, compute_motion):
2986 (Fcompute_motion, Fvertical_motion):
2987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2988 (last_known_column_modified): Use EMACS_INT, not int.
2989 (check_display_width):
2991 Check that fixnums and floats are in proper range for system types.
2992 (compute_motion): Don't assume index or fixnum fits in int.
2993 (compute_motion, Fcompute_motion):
2994 Use int, not EMACS_INT, when it is wide enough.
2995 (vmotion): Omit local var start_hpos that is always 0; that way
2996 we don't need to worry about overflow in expressions involving it.
2997 * indent.h: Adjust decls to match defn changes elsewhere.
2999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3000 Use int, not EMACS_INT, where int is wide enough.
3001 Remove unused members ovstring_chars_done and tab_offset;
3003 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3004 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3005 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3006 (make_gap, copy_text, insert, insert_and_inherit)
3007 (insert_before_markers, insert_before_markers_and_inherit)
3008 (insert_1, count_combining_before, count_combining_after)
3009 (insert_1_both, insert_from_string)
3010 (insert_from_string_before_markers, insert_from_string_1)
3011 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3012 (adjust_after_replace, adjust_after_insert, replace_range)
3013 (replace_range_2, del_range, del_range_1, del_range_byte)
3014 (del_range_both, del_range_2, modify_region)
3015 (prepare_to_modify_buffer, signal_before_change)
3016 (signal_after_change, Fcombine_after_change_execute):
3017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3018 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3019 (balance_an_interval, split_interval_right, split_interval_left)
3020 (find_interval, next_interval, update_interval)
3021 (adjust_intervals_for_insertion, delete_node, delete_interval)
3022 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3023 (static_offset_intervals, offset_intervals)
3024 (merge_interval_right, merge_interval_left, make_new_interval)
3025 (graft_intervals_into_buffer, temp_set_point_both)
3026 (temp_set_point, set_point, adjust_for_invis_intang)
3027 (set_point_both, move_if_not_intangible, get_property_and_range)
3028 (get_local_map, copy_intervals, copy_intervals_to_string)
3029 (compare_string_intervals, set_intervals_multibyte_1):
3030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3031 * intervals.h: Adjust decls to match defn changes elsewhere.
3033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3034 * keyboard.c (this_command_key_count, this_single_command_key_start)
3035 (before_command_key_count, before_command_echo_length, echo_now)
3036 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3037 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3038 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3039 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3041 (last_non_minibuf_size, last_point_position, echo_truncate)
3042 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3043 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3044 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3045 (stuff_buffered_input):
3046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3047 (last_auto_save, command_loop_1, read_char):
3048 Use EMACS_INT, not int, to avoid integer overflow.
3049 (record_char): Avoid overflow in total_keys computation.
3050 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3051 * keyboard.h: Adjust decls to match defn changes elsewhere.
3052 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3053 (Fkey_description, Fdescribe_vector, Flookup_key):
3054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3055 (click_position): New function, to check that positions are in range.
3056 (Fcurrent_active_maps):
3058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3059 (Faccessible_keymaps, Fkey_description):
3060 (preferred_sequence_p):
3061 Don't assume fixnum can fit into int.
3062 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3063 Check for integer overflow in size calculations.
3064 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3065 avoid mishandling large integers.
3066 * lisp.h: Adjust decls to match defn changes elsewhere.
3067 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3068 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3069 (struct Lisp_Marker):
3070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3071 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3072 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3073 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3074 All callers changed.
3075 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3076 Assume the arg has valid form, since it always does.
3077 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3078 unsigned integer system type.
3079 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3080 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3082 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3083 (duration_to_sec_usec): New decl.
3084 * lread.c (read_from_string_index, read_from_string_index_byte)
3085 (read_from_string_limit, readchar, unreadchar, openp)
3086 (read_internal_start, read1, oblookup):
3087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3088 (Fload, readevalloop, Feval_buffer, Feval_region):
3089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3090 (openp): Check for out-of-range argument to 'access'.
3091 (read1): Use int, not EMACS_INT, where int is wide enough.
3092 Don't assume fixnum fits into int.
3093 Fix off-by-one error that can read outside a buffer.
3094 (read_filtered_event): Use duration_to_sec_usec
3095 to do proper overflow checking on durations.
3096 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3097 in size calculation.
3098 (Fexecute_kbd_macro):
3099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3100 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3101 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3102 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3103 (set_marker_both, set_marker_restricted_both, marker_position)
3104 (marker_byte_position, Fbuffer_has_markers_at):
3105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3106 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3107 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3108 It now merely ensures that the menu is large enough, without
3109 necessarily growing it, as this avoids some integer overflow issues.
3110 All callers changed.
3111 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3113 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3114 Use SAFE_ALLOCA_LISP, not alloca.
3115 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3116 to EMACS_INT. Check that fixnums are in proper range for system types.
3117 * minibuf.c (minibuf_prompt_width, string_to_object)
3118 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3119 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3121 (get_minibuffer, read_minibuf_unwind):
3122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3123 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3124 this simplifies overflow checking. All callers changed.
3125 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3128 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3129 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3130 Check that fixnums are in proper range for system types.
3131 (Fx_create_frame, Fx_show_tip):
3132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3133 * nsfont.m (ns_findfonts, nsfont_list_family):
3134 Don't assume fixnum fits in long.
3135 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3137 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3139 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3141 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3142 (PRINTDECLARE, PRINTPREPARE):
3143 (strout, print_string):
3144 (print, print_preprocess, print_check_string_charset_prop)
3146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3148 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3150 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3151 (printchar, strout): Use xpalloc to catch size calculation overflow.
3152 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3153 (print_error_message): Use SAFE_ALLOCA, not alloca.
3154 (print_object): Use int, not EMACS_INT, where int is wide enough.
3155 (print_depth, new_backquote_output, print_number_index):
3156 Use ptrdiff_t, not int, where int might not be wide enough.
3157 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3158 (Fset_process_window_size, Fformat_network_address)
3159 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3161 Check that fixnums are in proper range for system types.
3162 (Fsignal_process): Simplify by avoiding a goto.
3163 Check for process-ids out of pid_t range rather than relying on
3165 (process_tick, update_tick): Use EMACS_INT, not int.
3166 (Fformat_network_address, read_process_output, send_process)
3167 (Fprocess_send_region, status_notify):
3168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3169 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3170 (wait_reading_process_output, read_process_output, exec_sentinel):
3171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3172 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3173 (Faccept_process_output): Use duration_to_sec_usec to do proper
3174 overflow checking on durations.
3175 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3176 Don't assume pid_t fits in int.
3177 * process.h (struct Lisp_Process): Members tick and update_tick
3178 are now of type EMACS_INT, not int.
3179 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3180 configured --with-wide-int.
3181 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3182 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3183 * search.c (looking_at_1, string_match_1):
3184 (fast_string_match, fast_c_string_match_ignore_case)
3185 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3186 (scan_newline, find_before_next_newline, search_command)
3187 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3188 (set_search_regs, wordify):
3191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3192 (string_match_1, search_buffer, set_search_regs):
3194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3195 (wordify): Check for overflow in size calculation.
3196 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3197 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3198 Check that fixnums are in proper range for system types.
3199 * sound.c (struct sound_device)
3200 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 (Fplay_sound_internal):
3203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3204 * syntax.c (struct lisp_parse_state, find_start_modiff)
3205 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3206 (Fparse_partial_sexp):
3207 Don't assume fixnums can fit in int.
3208 (struct lisp_parse_state, find_start_pos, find_start_value)
3209 (find_start_value_byte, find_start_begv)
3210 (update_syntax_table, char_quoted, dec_bytepos)
3211 (find_defun_start, prev_char_comend_first, back_comment):
3212 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3213 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3215 (Finternal_describe_syntax_value): Check that match_lisp is a
3216 character, not an integer, since the code stuffs it into int.
3217 (scan_words, scan_sexps_forward):
3218 Check that fixnums are in proper range for system types.
3220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3221 (scan_sexps_forward):
3222 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3223 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3224 * syntax.h: Adjust decls to match defn changes elsewhere.
3225 (struct gl_state_s):
3226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3227 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3228 MOST_POSITIVE_FIXNUM.
3229 * sysdep.c (wait_for_termination_1, wait_for_termination)
3230 (interruptible_wait_for_termination, mkdir):
3231 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3232 (emacs_read, emacs_write):
3233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3234 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3235 and double all fit in int.
3236 * term.c (set_tty_color_mode):
3237 Check that fixnums are in proper range for system types.
3238 * termhooks.h (struct input_event):
3239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3240 * textprop.c (validate_interval_range, interval_of)
3241 (Fadd_text_properties, set_text_properties_1)
3242 (Fremove_text_properties, Fremove_list_of_text_properties)
3243 (Ftext_property_any, Ftext_property_not_all)
3244 (copy_text_properties, text_property_list, extend_property_ranges)
3245 (verify_interval_modification):
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 (Fnext_single_char_property_change)
3248 (Fprevious_single_char_property_change):
3249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3250 (copy_text_properties):
3251 Check for integer overflow in index calculation.
3252 * undo.c (last_boundary_position, record_point, record_insert)
3253 (record_delete, record_marker_adjustment, record_change)
3254 (record_property_change):
3255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3256 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3258 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3259 (Fx_hide_tip, Fx_file_dialog):
3260 * w32menu.c (set_frame_menubar):
3261 Use ptrdiff_t, not int, for consistency with rest of code.
3262 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3263 (select_window, Fdelete_other_windows_internal)
3264 (window_scroll_pixel_based, window_scroll_line_based)
3265 (Frecenter, Fset_window_configuration):
3266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3267 (Fset_window_hscroll, run_window_configuration_change_hook)
3268 (set_window_buffer, temp_output_buffer_show, scroll_command)
3269 (Fscroll_other_window, Frecenter):
3270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3271 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3272 Don't assume fixnum fits in int.
3273 (Fset_window_scroll_bars):
3274 Check that fixnums are in proper range for system types.
3275 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3276 (string_pos, c_string_pos, number_of_chars, init_iterator)
3277 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3278 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3279 (compute_display_string_end, handle_face_prop)
3280 (face_before_or_after_it_pos, handle_invisible_prop)
3281 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3282 (display_prop_intangible_p, string_buffer_position_lim)
3283 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3284 (get_overlay_strings_1, get_overlay_strings)
3285 (iterate_out_of_display_property, forward_to_next_line_start)
3286 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3287 (get_next_display_element, set_iterator_to_next)
3288 (get_visually_first_element, compute_stop_pos_backwards)
3289 (handle_stop_backwards, next_element_from_buffer)
3290 (move_it_in_display_line_to, move_it_in_display_line)
3291 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3292 (add_to_log, message_dolog, message_log_check_duplicate)
3293 (message2, message2_nolog, message3, message3_nolog
3294 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3295 (current_message_1, truncate_echo_area, truncate_message_1)
3296 (set_message, set_message_1, store_mode_line_noprop)
3297 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3298 (text_outside_line_unchanged_p, check_point_in_composition)
3299 (reconsider_clip_changes)
3300 (redisplay_internal, set_cursor_from_row, try_scrolling)
3301 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3302 (redisplay_window, find_last_unchanged_at_beg_row)
3303 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3304 (trailing_whitespace_p, find_row_edges, display_line)
3305 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3306 (display_mode_element, store_mode_line_string)
3307 (pint2str, pint2hrstr, decode_mode_spec)
3308 (display_count_lines, display_string, draw_glyphs)
3309 (x_produce_glyphs, x_insert_glyphs)
3310 (rows_from_pos_range, mouse_face_from_buffer_pos)
3311 (fast_find_string_pos, mouse_face_from_string_pos)
3312 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3314 (safe_call, init_from_display_pos, handle_fontified_prop)
3315 (handle_single_display_spec, load_overlay_strings)
3316 (with_echo_area_buffer, setup_echo_area_for_printing)
3317 (display_echo_area, echo_area_display)
3318 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3319 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3320 (redisplay_window, dump_glyph_row, display_mode_line)
3321 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3322 (handle_display_spec, display_prop_string_p):
3323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3324 (handle_single_display_spec, build_desired_tool_bar_string)
3325 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3326 (get_specified_cursor_type):
3327 Check that fixnums are in proper range for system types.
3328 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3329 (Flookup_image_map):
3330 Don't assume fixnums fit in int.
3331 (compare_overlay_entries):
3332 Avoid mishandling comparisons due to subtraction overflow.
3333 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3334 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3335 (handle_tool_bar_click):
3336 Use int, not unsigned, since we prefer signed and the signedness
3337 doesn't matter here.
3338 (get_next_display_element, next_element_from_display_vector):
3339 Use int, not EMACS_INT, when int is wide enough.
3340 (start_hourglass): Use duration_to_sec_usec to do proper
3341 overflow checking on durations.
3342 * xfaces.c (Fbitmap_spec_p):
3343 Check that fixnums are in proper range for system types.
3344 (compare_fonts_by_sort_order):
3345 Avoid mishandling comparisons due to subtraction overflow.
3346 (Fx_family_fonts, realize_basic_faces):
3347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3349 Don't assume fixnum fits in int.
3350 Use SAFE_ALLOCA_LISP, not alloca.
3351 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3352 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3353 (face_at_buffer_position, face_for_overlay_string)
3354 (face_at_string_position):
3355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3356 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3357 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3359 Check that fixnums are in proper range for system types.
3360 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3361 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3363 (Fx_change_window_property): Don't assume fixnums fit in int.
3364 * xfont.c (xfont_chars_supported):
3365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3366 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3367 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3369 * xml.c (parse_region):
3370 * xrdb.c (magic_file_p):
3371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3372 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3373 (x_get_local_selection, x_reply_selection_request)
3374 (x_handle_selection_request, wait_for_property_change):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3377 short is wide enough.
3378 (x_send_client_event): Don't assume fixnum fits in int.
3379 * xterm.c (x_x_to_emacs_modifiers):
3380 Don't assume EMACS_INT overflows nicely into int.
3381 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3383 (handle_one_xevent): NATNUMP can eval its arg twice.
3384 (x_connection_closed):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 * xterm.h: Adjust decls to match defn changes elsewhere.
3387 (struct scroll_bar): Use struct vectorlike_header
3388 rather than rolling our own approximation.
3389 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3391 2012-05-25 Glenn Morris <rgm@gnu.org>
3393 * lisp.mk (lisp): Update for more files being compiled now.
3395 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3397 * lread.c: Remove `read_pure' which makes no difference.
3398 (read_pure): Remove var.
3399 (unreadpure): Remove function.
3400 (readevalloop): Don't call read_list with -1 flag.
3401 (read1, read_vector): Don't test read_pure any more.
3402 (read_list): Simplify.
3404 * fileio.c, character.h: Minor style tweaks.
3406 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3408 * window.h (clip_changed): Remove useless declaration.
3410 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3412 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3413 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3415 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3418 This directory predates autoconf and is no longer needed nowadays.
3419 Move its few remaining bits of functionality to where they're needed.
3420 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3421 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3422 * m/template.h: Remove.
3423 * Makefile.in (M_FILE): Remove. All uses removed.
3424 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3425 * lisp.h (USE_LSB_TAG):
3426 * mem-limits.h (EXCEEDS_LISP_PTR):
3427 Use VAL_MAX, not VALBITS, in #if.
3428 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3429 (EMACS_UINT): Define unconditionally now.
3430 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3431 (BITS_PER_EMACS_INT): New constants, replacing
3432 what used to be in config.h, but not useful in #if.
3433 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3434 define them any more.
3435 (VAL_MAX): New macro.
3437 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3438 BITS_PER_EMACS_INT, in #if.
3439 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3440 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3441 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3442 * s/ms-w32.h (DATA_START):
3443 Move here from removed file m/intel386.h.
3444 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3445 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3447 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3449 Assume C89 or later.
3450 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3451 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3453 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3454 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3455 * textprop.c, tparam.c (NULL): Remove.
3456 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3457 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3458 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3459 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3460 * xterm.c (input_signal_count): Assume volatile works.
3462 2012-05-21 Ken Brown <kbrown@cornell.edu>
3464 * xgselect.c (xg_select): Fix first argument in call to 'select'
3467 2012-05-20 Ken Brown <kbrown@cornell.edu>
3469 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3470 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3472 2012-05-19 Ken Brown <kbrown@cornell.edu>
3474 * xfns.c (x_in_use): Remove `static' qualifier.
3475 * xterm.h (x_in_use): Declare.
3476 * xgselect.c: Include xterm.h.
3477 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3478 and `display_arg' (bug#9754).
3480 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3482 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3484 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3485 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3487 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3489 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3491 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3492 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3494 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3495 reference to image_cache->refcount.
3496 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3498 2012-05-17 Juri Linkov <juri@jurta.org>
3500 * search.c (Fword_search_regexp, Fword_search_backward)
3501 (Fword_search_forward, Fword_search_backward_lax)
3502 (Fword_search_forward_lax): Move functions to isearch.el
3503 (bug#10145, bug#11381).
3505 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3507 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3509 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3511 * lread.c (init_obarray): Declare Qt and Qnil as special.
3513 2012-05-14 Glenn Morris <rgm@gnu.org>
3515 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3516 Put "libexec" before "bin", for the sake of init_callproc_1.
3518 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3520 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3522 * unexaix.c: Port to more-recent AIX compilers.
3523 (report_error, report_error_1, make_hdr, copy_sym)
3524 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3525 Make arguments const char *, not char *, to avoid violations of C
3526 standard and to fix some AIX warnings reported by Gilles Pion.
3528 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3530 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3531 already have overlays loaded.
3532 (handle_single_display_spec): Before returning without displaying
3533 fringe bitmap, synchronize the bidi iterator with the main display
3534 iterator, by calling iterate_out_of_display_property.
3535 (iterate_out_of_display_property): Detect buffer iteration by
3536 testing that it->string is a Lisp string.
3537 (get_next_display_element): When the current object is exhausted,
3538 and there's something on it->stack, call set_iterator_to_next to
3539 proceed with what's on the stack, instead of returning zero.
3540 (set_iterator_to_next): If called at the end of a Lisp string,
3541 proceed to consider_string_end without incrementing string
3542 position. Don't increment display vector index past the end of
3543 the display vector. (Bug#11417)
3544 (pos_visible_p): Don't report a position visible when move_it_to
3545 stopped at the last line of window, which happens to be scanned
3546 backwards by the bidi iteration. (Bug#11464)
3548 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3550 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3551 and right-margin display specs even if the spec is invalid or we
3552 are on a TTY, and thus unable to display on the fringes.
3553 That's because the text with the property will not be displayed anyway,
3554 so we need to signal to the caller that this is a "replacing"
3555 display spec. This fixes display when the spec is invalid or we
3558 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3560 * unexaix.c (make_hdr): Fix typo in prototype.
3561 This bug broke the build on AIX. Problem reported by Gilles Pion.
3563 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3565 * keyboard.c (kbd_buffer_get_event): Read special events also in
3566 batch mode. (Bug#11415)
3568 2012-05-12 Glenn Morris <rgm@gnu.org>
3570 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3572 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3574 * lisp.mk (lisp): Add newcomment.elc.
3576 2012-05-12 Glenn Morris <rgm@gnu.org>
3578 * Makefile.in (MKDIR_P): New, set by configure.
3579 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3581 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3583 Remove unused function hourglass_started.
3584 * dispextern.h (hourglass_started):
3585 * w32fns.c (hourglass_started):
3586 * xdisp.c (hourglass_started): Remove.
3588 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3590 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3591 Update dependencies.
3593 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3595 * xgselect.c (xg_select): Put maxfds+1 into a var.
3596 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3598 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3600 2012-05-10 Dave Abrahams <dave@boostpro.com>
3602 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3603 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3605 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3607 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3608 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3609 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3610 Initialize xd_registered_buses.
3612 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3614 Untag more efficiently if USE_LSB_TAG.
3615 This is based on a proposal by YAMAMOTO Mitsuharu in
3616 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3617 For an admittedly artificial (nth 8000 longlist) benchmark on
3618 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3619 Emacs's overall text size by 1%.
3620 * lisp.h (XUNTAG): New macro.
3621 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3622 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3623 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3624 * eval.c (Fautoload):
3625 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3626 * frame.h (XFRAME): Use XUNTAG.
3628 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3629 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3630 Remove unportable assumptions about print widths of types like
3632 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3633 intptr_t when converting between pointer and integer, to avoid GCC
3634 warnings about wrong width.
3636 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3638 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3639 stack for each reader_thread, instead of defaulting to 8MB
3640 determined by the linker. This avoids failures in creating
3641 subprocesses on Windows 7, see the discussion in this thread:
3642 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3644 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3646 Fix up display of the *Minibuf-0* buffer in the mini window.
3647 * keyboard.c (read_char): Don't clear the echo area if there's no
3649 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3650 contents of *Minibuf-0*) if there's no message displayed in its stead.
3652 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3654 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3657 2012-05-06 Chong Yidong <cyd@gnu.org>
3659 * lisp.mk (lisp): Update.
3661 2012-05-05 Jim Meyering <meyering@redhat.com>
3663 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3665 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3667 * data.c (PUT_ERROR): New macro.
3668 (syms_of_data): Use it. Add new error type `user-error'.
3669 * undo.c (user_error): New function.
3670 (Fprimitive_undo): Use it.
3671 * print.c (print_error_message): Adjust print style for `user-error'.
3672 * keyboard.c (user_error): New function.
3673 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3675 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3677 Do not limit current-time-string to years 1000..9999.
3678 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3679 (Fcurrent_time_string): Support any year that is supported by the
3680 underlying localtime representation. Don't use asctime, as it
3681 has undefined behavior for years outside the range -999..9999.
3683 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3685 Fix race conditions involving setenv, gmtime, localtime, asctime.
3686 Without this fix, interrupts could mess up code that uses these
3687 nonreentrant functions, since setting TZ invalidates existing
3688 tm_zone or tzname values, and since most of these functions return
3689 pointers to static storage.
3690 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3691 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3692 Grow the critical sections to include not just invoking
3693 localtime/gmtime, but also accessing these functions' results
3694 including their tm_zone values if any, and any related TZ setting.
3695 (format_time_string): Last arg is now struct tm *, not struct tm **,
3696 so that the struct tm is saved in the critical section.
3697 All callers changed. Simplify allocation of initial buffer, partly
3698 motivated by the fact that memory allocation needs to be outside
3699 the critical section.
3701 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3703 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3704 with RESET_INTERVAL.
3706 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3707 Remove duplicated buffer name initialization.
3709 2012-05-02 Jim Meyering <jim@meyering.net>
3711 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3713 * xfns.c (x_window): Use xstrdup (Bug#11375).
3715 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3717 * xdisp.c (pos_visible_p): If already at a newline from the
3718 display string before the 'while' loop, don't walk back the glyphs
3719 from it3.glyph_row. Solves assertion violation when the display
3720 string begins with a newline (egg.el). (Bug#11367)
3722 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3724 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3727 2012-05-01 Glenn Morris <rgm@gnu.org>
3729 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3730 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3731 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3732 All were removed before 23.1.
3734 * dispnew.c: Remove HAVE_LIBNCURSES test;
3735 it is always true on relevant platforms.
3737 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3738 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3740 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3742 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3744 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3745 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3748 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3750 Do not avoid creating empty evaporating overlays (Bug#9642).
3751 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3752 That is, do not delete an evaporating overlay if it becomes
3753 empty after its bounds are adjusted to fit within its buffer.
3754 This fix caused other problems, and I'm reverting it until we get
3755 to the bottom of them.
3757 2012-04-27 Chong Yidong <cyd@gnu.org>
3759 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3761 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3763 * xdisp.c (pos_visible_p): If the window start position is beyond
3764 ZV, start the display from buffer beginning. Prevents assertion
3765 violation in init_iterator when the minibuffer window is scrolled
3768 * window.c (window_scroll_pixel_based): Likewise.
3770 2012-04-27 Chong Yidong <cyd@gnu.org>
3772 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3774 2012-04-27 Glenn Morris <rgm@gnu.org>
3776 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3777 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3779 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3781 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3782 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3784 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3786 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3787 display element, check also the underlying string or buffer
3788 character. (Bug#11341)
3790 * w32menu.c: Include w32heap.h.
3791 (add_menu_item): If the call to AppendMenuW (via
3792 unicode_append_menu) fails, disable Unicode menus only if we are
3793 running on Windows 9X/Me.
3795 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3797 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3798 (xgetint): Add missing shift for LSB tags.
3800 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3802 * keyboard.c (read_char): Don't wipe echo area for select window
3803 events: These might get delayed via `mouse-autoselect-window'
3806 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3808 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3809 manipulation of :loaded-from data.
3811 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3813 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3814 now a cons (bug#11311).
3816 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3818 Do not create empty overlays with the evaporate property (Bug#9642).
3819 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3820 if it becomes empty after its bounds are adjusted to fit within
3821 its buffer. Without this fix, in a nonempty buffer (let ((o
3822 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3823 yields an empty overlay that has the evaporate property, which is
3824 not supposed to happen.
3826 Fix minor GTK3 problems found by static checking.
3827 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3828 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3829 (struct _EmacsFixedClass, emacs_fixed_get_type):
3830 Move decls here from emacsgtkfixed.h, since they needn't be public.
3831 (emacs_fixed_get_type): Now static.
3832 (emacs_fixed_class_init): Omit unused local.
3833 (emacs_fixed_child_type): Remove; unused.
3834 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3835 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3836 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3837 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3838 (EMACS_FIXED_GET_CLASS): Remove; unused.
3839 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3841 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3842 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3844 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3846 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3847 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3848 (__malloc_size_t, __malloc_ptrdiff_t):
3849 Remove. All uses removed, replaced by the definiens if needed,
3850 since we can assume C89 or better now.
3851 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3852 (protect_malloc_state, align, get_contiguous_space)
3853 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3854 (malloc_atfork_handler_child, malloc_enable_thread)
3855 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3856 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3857 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3858 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3859 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3860 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3861 Define using prototypes, not old style.
3862 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3863 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3864 (align): Don't assume that signed integer overflow wraps around.
3865 Omit unused local var.
3866 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3867 (_free_internal_nolock, memalign, mallochook, reallochook):
3868 Omit no-longer-needed casts.
3869 (valloc): Use getpagesize, not __getpagesize.
3870 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3871 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3873 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3875 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3877 Move functions from C to Lisp. Make non-blocking method calls
3878 the default. Implement further D-Bus standard interfaces.
3880 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3881 (QCdbus_request_name_allow_replacement)
3882 (QCdbus_request_name_replace_existing)
3883 (QCdbus_request_name_do_not_queue)
3884 (QCdbus_request_name_reply_primary_owner)
3885 (QCdbus_request_name_reply_in_queue)
3886 (QCdbus_request_name_reply_exists)
3887 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3888 (QCdbus_registered_serial, QCdbus_registered_method)
3889 (QCdbus_registered_signal): New Lisp objects.
3890 (XD_DEBUG_MESSAGE): Use sizeof.
3891 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3892 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3893 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3894 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3895 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3896 (xd_signature, xd_append_arg): Allow float for integer types.
3897 (xd_get_connection_references): New function.
3898 (xd_get_connection_address): Rename from xd_initialize.
3899 Return cached address.
3900 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3901 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3903 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3904 Return number of refcounts.
3905 (Fdbus_get_unique_name): Make stronger parameter check.
3906 (Fdbus_message_internal): New defun.
3907 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3908 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3909 (Fdbus_send_signal, Fdbus_register_service)
3910 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3911 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3912 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3913 (Vdbus_compiled_version, Vdbus_runtime_version)
3914 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3915 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3916 (Vdbus_message_type_signal): New defvars.
3917 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3920 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3922 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3923 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3924 Do not assume ptrdiff_t is the same width as 'int'.
3926 * alloc.c: Handle unusual debugging option combinations.
3927 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3928 since the two debugging options are incompatible.
3929 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3931 (mem_init, mem_insert, mem_insert_fixup):
3932 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3933 (NEED_MEM_INSERT): Remove; no longer needed.
3935 2012-04-22 Leo Liu <sdl.web@gmail.com>
3937 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3939 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3941 * sysdep.c [__FreeBSD__]: Minor cleanups.
3942 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3943 Use Emacs indenting style more consistently. Avoid some casts.
3944 Use 'double' consistently rather than mixing 'float' and 'double'.
3946 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3948 * sysdep.c (list_system_processes, system_process_attributes):
3949 Add implementation for FreeBSD (Bug#5243).
3951 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3953 * lisp.mk (lisp): Update.
3955 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3957 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3958 It is never used otherwise.
3960 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3962 * print.c (print_preprocess): Only check print_depth if print-circle
3964 (print_object): Check for cycles even when print-circle is nil and
3965 print-gensym is t, but only check print_depth if print-circle is nil.
3967 2012-04-20 Chong Yidong <cyd@gnu.org>
3969 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3970 set the status to "failed" and ensure that sentinel is run.
3972 2012-04-20 Glenn Morris <rgm@gnu.org>
3974 * process.c (Fset_process_inherit_coding_system_flag)
3975 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3976 (Fmake_network_process, Fmake_serial_process): Doc fix.
3978 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3980 * xdisp.c (string_buffer_position_lim): Limit starting position to
3982 (set_cursor_from_row): If called for a mode-line or header-line
3983 row, return zero immediately.
3984 (try_cursor_movement): If inside continuation line, don't back up
3985 farther than the first row after the header line, if any.
3986 Don't consider the header-line row as "partially visible", even if
3987 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3989 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3991 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3994 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3995 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3997 configure: new option --enable-gcc-warnings (Bug#11207)
3998 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3999 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4000 (ALL_CFLAGS): Use new macros rather than old.
4001 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4002 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4003 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4004 -Wunused-result, -Wunused-variable. This should go away once
4005 the Emacs and Gnulib regex code is merged.
4006 (xmalloc, xrealloc): Now static.
4008 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4010 * dired.c (Fsystem_groups): Remove unused local.
4012 2012-04-17 Glenn Morris <rgm@gnu.org>
4014 * dired.c (Fsystem_users): Doc fix.
4016 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4018 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4019 (syms_of_dired): Add them.
4021 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4023 Fix minor alloc.c problems found by static checking.
4024 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4025 New extern decls, to avoid calling undeclared functions.
4026 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4027 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4028 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4029 (NEED_MEM_INSERT): New macro.
4030 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4031 Remove one incorrect comment and fix another.
4033 Fix minor ralloc.c problems found by static checking.
4034 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4035 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4036 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4037 (r_alloc_sbrk): Now static.
4039 Improve ralloc.c interface checking.
4040 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4041 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4042 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4043 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4044 [REL_ALLOC]: ... to here, to check interface.
4045 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4046 Remove decls. This fixes an "It stinks!".
4048 * alloc.c (which_symbols): Fix alignment issue / type clash.
4050 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4052 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4053 (struct Lisp_Misc_Any): Likewise.
4054 (struct Lisp_Free): Likewise.
4055 * alloc.c (union aligned_Lisp_Symbol): Define.
4056 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4057 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4058 (union aligned_Lisp_Misc): Define.
4059 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4060 aligned_Lisp_Misc instead of union Lisp_Misc.
4061 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4063 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4065 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4066 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4067 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4068 * s/netbsd.h, s/sol2-6.h:
4069 Remove definition of GC_MARK_STACK, since the default now works.
4070 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4071 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4072 no longer the default.
4073 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4075 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4077 * lread.c (lisp_file_lexically_bound_p):
4078 Fix hang at ";-*-\n" (bug#11238).
4080 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4082 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4083 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4085 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4087 * nsterm.m (constrainFrameRect): Always constrain when there is only
4088 one screen (Bug#10962).
4090 2012-04-13 Ken Brown <kbrown@cornell.edu>
4092 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4094 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4096 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4098 2012-04-11 Daniel Colascione <dancol@dancol.org>
4100 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4101 against is gone. It's better to use vfork now so that when Cygwin
4102 gains a new, working vfork, we use it automatically (bug#10398).
4104 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4106 * window.c (save_window_save): Obey window-point-insertion-type.
4108 2012-04-11 Glenn Morris <rgm@gnu.org>
4110 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4112 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4114 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4116 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4118 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4119 (force_quit_count): New var.
4120 (handle_interrupt): Use it.
4122 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4124 * w32.c (w32_delayed_load): Record the full path of the library
4125 being loaded (bug#10424).
4127 2012-04-09 Glenn Morris <rgm@gnu.org>
4129 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4130 not just in the obarray, before snarfing them. (Bug#11036)
4132 * Makefile.in ($(leimdir)/leim-list.el):
4133 Pass EMACS rather than BUILT_EMACS.
4135 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4137 * process.c (make_process):
4138 * process.h: Add integer `gnutls_handshakes_tried' member to
4141 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4142 Add convenience `GNUTLS_LOG2i' macro.
4144 * gnutls.c (gnutls_log_function2i): Convenience log function.
4145 (emacs_gnutls_read): Use new log functions,
4146 `gnutls_handshakes_tried' process member, and
4147 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4148 attempts per process (connection).
4150 2012-04-09 Chong Yidong <cyd@gnu.org>
4152 * eval.c (Fuser_variable_p, user_variable_p_eh)
4153 (lisp_indirect_variable): Functions deleted.
4154 (Fdefvar): Caller changed.
4156 * callint.c (Finteractive, Fcall_interactively):
4157 * minibuf.c (Fread_variable): Callers changed.
4159 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4161 * xdisp.c (set_cursor_from_row): If the display string appears in
4162 the buffer at position that is closer to point than the position
4163 after the display string, display the cursor on the first glyph of
4164 the display string. Fixes cursor display when a 'display' text
4165 property immediately follows invisible text. (Bug#11094)
4167 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4169 composite.c: use 'double' consistently
4170 * composite.c (get_composition_id): Use 'double' consistently
4171 instead of converting 'float' to 'double' and vice versa; this is
4172 easier to understand and avoids a GCC warning.
4174 2012-04-09 Glenn Morris <rgm@gnu.org>
4176 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4177 preparation for dumping it with emacs. (Bug#4789)
4178 (leimdir): New variable.
4179 ($(leimdir)/leim-list.el): New rule.
4180 (emacs$(EXEEXT)): Depend on leim-list.el.
4182 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4183 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4184 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4186 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4188 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4191 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4193 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4194 Remove unused local variable.
4196 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4198 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4199 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4200 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4201 objects, as mark_maybe_pointer will catch them otherwise.
4202 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4203 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4205 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4207 Fix typo that broke non-Windows builds.
4208 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4210 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4212 Support building on MS-Windows with libxml2.
4214 * makefile.w32-in (OBJ2): Add xml.$(O).
4215 (GLOBAL_SOURCES): Add xml.c.
4216 ($(BLD)/xml.$(O)): New dependency list.
4218 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4219 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4220 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4221 [!WINDOWSNT]: New macros.
4222 (init_libxml2_functions, libxml2_loaded_p): New functions.
4223 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4224 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4225 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4226 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4228 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4229 Call init_libxml2_functions before calling libxml2 functions.
4230 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4232 * emacs.c: Don't include libxml/parser.h.
4233 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4234 xmlCleanupParser directly.
4236 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4238 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4240 * indent.c (Fvertical_motion): If there is a display string at
4241 point, use it.vpos to compute how many lines to backtrack after
4242 move_it_to point. (Bug#11133)
4244 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4246 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4247 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4248 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4249 macros related to unification of CJK characters. For the details,
4250 see the discussion following the message here:
4251 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4253 2012-04-04 Chong Yidong <cyd@gnu.org>
4255 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4257 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4259 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4260 instead of alloca. (Bug#11138)
4262 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4264 * w32menu.c (is_simple_dialog): Properly check lisp types.
4267 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4269 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4270 position we get to after a call to move_it_to fails the
4271 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4272 only if we wind up in a string from display property. (Bug#11063)
4274 * window.c (Fdelete_other_windows_internal): Invalidate the row
4275 and column information about mouse highlight, so that redisplay
4276 restores it after reallocating the glyph matrices. (Bug#7464)
4278 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4279 string comes from a `display' text property, use the buffer
4280 position of that property as if we actually saw that position in
4282 (move_it_by_lines): Remove the assertion that
4283 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4284 violated when there's a before-string at the beginning of a line.
4287 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4289 * xdisp.c (append_space_for_newline): If the default face was
4290 remapped, use the remapped face for the appended newline.
4291 (extend_face_to_end_of_line): Use the remapped default face for
4292 extending the face to the end of the line.
4293 (display_line): Call extend_face_to_end_of_line when the default
4294 face was remapped. (Bug#11068)
4296 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4298 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4300 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4302 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4304 2012-03-27 Glenn Morris <rgm@gnu.org>
4306 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4309 2012-03-26 Kenichi Handa <handa@m17n.org>
4311 * dispextern.h (struct glyph): Fix previous change. Change the
4312 bit length of glyphless.ch to 25 (Bug#11082).
4314 2012-03-26 Chong Yidong <cyd@gnu.org>
4316 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4317 (command_loop_1): Use it; inhibit selection update for
4318 handle-select-window too (Bug#8996).
4320 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4322 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4324 2012-03-25 Kenichi Handa <handa@m17n.org>
4326 * dispextern.h (struct glyph): Change the bit length of
4327 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4329 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4331 * s/ms-w32.h (tzname): Include time.h before redirecting to
4332 _tzname. Fixes the MSVC build. (Bug#9960)
4334 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4336 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4339 * xterm.c (XTread_socket): Only modify handling_signal if
4340 !SYNC_INPUT. (Bug#11080)
4342 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4344 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4345 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4346 when fetching a multibyte character consumes more bytes than
4347 CHAR_BYTES returns, due to unification of CJK characters in
4348 string_char. (Bug#11073)
4350 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4352 * process.c (wait_reading_process_output): Handle pty disconnect
4353 by refraining from sending oneself a SIGCHLD (bug#10933).
4355 2012-03-22 Chong Yidong <cyd@gnu.org>
4357 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4359 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4360 Mark string as coming from a prefix property.
4361 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4362 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4364 2012-03-21 Chong Yidong <cyd@gnu.org>
4366 * xfaces.c (Vface_remapping_alist): Doc fix.
4368 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4370 * w32proc.c (Fw32_set_console_codepage)
4371 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4374 2012-03-20 Chong Yidong <cyd@gnu.org>
4376 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4377 to reflect default non-nil value of redisplay-dont-pause.
4379 2012-03-19 Kenichi Handa <handa@m17n.org>
4381 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4382 it fit in a valid range (Bug#11003).
4384 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4386 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4387 that is not from display property, accept the row as a "cursor
4388 row" if one of the string's character has a non-nil `cursor'
4389 property. Fixes cursor positioning when there are newlines in
4390 overlay strings, e.g. in icomplete.el. (Bug#11035)
4392 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4394 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4396 2012-03-12 Chong Yidong <cyd@gnu.org>
4398 * eval.c (inhibit_lisp_code): Rename from
4399 inhibit_window_configuration_change_hook; move from window.c.
4401 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4402 * window.c (run_window_configuration_change_hook)
4403 (syms_of_window): Callers changed.
4405 2012-03-11 Chong Yidong <cyd@gnu.org>
4407 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4409 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4411 2012-03-10 Chong Yidong <cyd@gnu.org>
4413 * frame.c (other_visible_frames): Don't assume the selected frame
4414 is visible (Bug#10955).
4416 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4418 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4420 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4422 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4423 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4426 2012-03-03 Glenn Morris <rgm@gnu.org>
4428 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4430 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4432 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4433 position past the first glyph_row that ends at ZV. (Bug#10902)
4434 (redisplay_window, next_element_from_string): Fix typos in
4436 (redisplay_window): Pass to move_it_vertically the margin in
4437 pixels, not in screen lines.
4439 2012-03-02 Glenn Morris <rgm@gnu.org>
4441 * buffer.c (buffer-list-update-hook): Doc fix.
4443 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4445 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4446 push_it before setting up the iterator for the first overlay
4447 string, even if we have an empty string loaded.
4448 (next_overlay_string): If there's an empty string on the iterator
4449 stack, pop the stack. (Bug#10903)
4451 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4453 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4454 Suggested by Stefan Monnier in
4455 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4456 * alloc.c (widen_to_Lisp_Object): New static function.
4457 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4458 and widening them to Lisp_Objects. This would work even if
4459 USE_LSB_TAG is defined and wide integers are used, which might
4460 happen in a future version of Emacs.
4462 2012-02-25 Chong Yidong <cyd@gnu.org>
4464 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4467 * xselect.c (Fx_selection_exists_p): Doc fix.
4468 (x_clipboard_manager_save_all): Print an informative message
4469 before saving to clipboard manager.
4471 2012-02-24 Chong Yidong <cyd@gnu.org>
4473 * keyboard.c (process_special_events): Handle all X selection
4474 requests in kbd_buffer, not just the next one (Bug#8869).
4476 2012-02-23 Chong Yidong <cyd@gnu.org>
4478 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4479 call when setting menu-bar-lines and tool-bar-lines parameters.
4480 (unwind_create_frame_1): New helper function.
4482 * window.c (inhibit_window_configuration_change_hook): New var.
4483 (run_window_configuration_change_hook): Obey it.
4484 (syms_of_window): Initialize it.
4486 2012-02-22 Chong Yidong <cyd@gnu.org>
4488 * xterm.c (x_draw_image_relief): Add missing type check for
4489 Vtool_bar_button_margin (Bug#10743).
4491 2012-02-21 Chong Yidong <cyd@gnu.org>
4493 * fileio.c (Vfile_name_handler_alist): Doc fix.
4495 * buffer.c (Fget_file_buffer): Protect against invalid file
4496 handler return value.
4498 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4500 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4501 when computing $valmask.
4503 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4504 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4505 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4506 It's useless in that case, and it can cause problems on hosts
4507 that allocate halves of EMACS_INT values separately.
4508 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4509 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4510 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4511 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4512 it avoids undefined behavior on hosts where shifting right by more
4513 than the word width has undefined behavior.
4515 2012-02-19 Chong Yidong <cyd@gnu.org>
4517 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4518 (Funhandled_file_name_directory, Ffile_name_as_directory)
4519 (Fdirectory_file_name, Fexpand_file_name)
4520 (Fsubstitute_in_file_name): Protect against invalid file handler
4521 return values (Bug#10845).
4523 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4525 * .gdbinit (pitx): Fix incorrect references to fields of the
4528 2012-02-17 Chong Yidong <cyd@gnu.org>
4530 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4532 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4534 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4535 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4537 2012-02-15 Chong Yidong <cyd@gnu.org>
4539 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4540 marked as special. Also, starting docstrings with * is obsolete.
4542 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4544 * gnutls.c (emacs_gnutls_write): Fix last change.
4546 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4548 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4551 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4553 * keymap.c (Fsingle_key_description): Handle char ranges.
4555 2012-02-12 Chong Yidong <cyd@gnu.org>
4557 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4558 as that creates a dangerous corner case.
4560 * window.c (Fdelete_window_internal): Invalidate the mouse
4561 highlight (Bug#9904).
4563 2012-02-12 Glenn Morris <rgm@gnu.org>
4565 * xselect.c (Fx_own_selection_internal)
4566 (Fx_get_selection_internal, Fx_disown_selection_internal)
4567 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4568 * nsselect.m (Fx_own_selection_internal)
4569 (Fx_disown_selection_internal, Fx_selection_exists_p)
4570 (Fx_selection_owner_p, Fx_get_selection_internal):
4571 Sync docs and argument specs with the xselect.c versions.
4573 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4575 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4577 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4579 * w32select.c (Fx_selection_exists_p): Sync doc string and
4580 argument list with xselect.c. (Bug#10783)
4582 * w16select.c (Fx_selection_exists_p): Sync doc string and
4583 argument list with xselect.c. (Bug#10783)
4585 2012-02-10 Glenn Morris <rgm@gnu.org>
4587 * fns.c (Fsecure_hash): Doc fix.
4589 2012-02-09 Kenichi Handa <handa@m17n.org>
4591 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4593 2012-02-07 Chong Yidong <cyd@gnu.org>
4595 * buffer.c (Fbuffer_local_variables)
4596 (buffer_lisp_local_variables): Handle unbound vars correctly;
4597 don't let Qunbound leak into Lisp.
4599 2012-02-07 Glenn Morris <rgm@gnu.org>
4601 * image.c (Fimagemagick_types): Doc fix.
4603 * image.c (imagemagick-render-type): Change it from a lisp object
4604 to an integer. Move the doc here from the lisp manual.
4605 Treat all values not equal to 0 the same.
4607 2012-02-06 Chong Yidong <cyd@gnu.org>
4609 * doc.c (store_function_docstring): Avoid applying docstring of
4610 alias to base function (Bug#2603).
4612 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4614 * .gdbinit (pp1, pv1): Remove redundant defines.
4617 2012-02-04 Chong Yidong <cyd@gnu.org>
4619 * nsterm.m: Declare a global (Bug#10694).
4621 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4623 * w32.c (get_emacs_configuration_options):
4624 Include --enable-checking, if specified, in the return value.
4626 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4628 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4629 after rounding frame sizes. (Bug#9723)
4631 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4633 * keyboard.c (adjust_point_for_property): Don't position point
4634 before BEGV. (Bug#10696)
4636 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4638 Handle overflow when computing char display width (Bug#9496).
4639 * character.c (char_width): Return EMACS_INT, not int.
4640 (char_width, c_string_width): Check for overflow when
4641 computing the width; this is possible now that individual
4642 characters can have unbounded width. Problem introduced
4643 by merge from Emacs 23 on 2012-01-19.
4645 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4647 * dbusbind.c (Fdbus_register_method): Mention the return value
4648 :ignore in the docstring.
4650 2012-02-02 Glenn Morris <rgm@gnu.org>
4652 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4654 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4655 Unconditionally set to t. (Bug#10673)
4656 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4657 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4658 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4660 2012-02-02 Kenichi Handa <handa@m17n.org>
4662 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4663 0, do not call append_composite_glyph.
4665 2012-02-02 Kenichi Handa <handa@m17n.org>
4667 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4669 (x_produce_glyphs): If the component of a composition is a null
4670 string, set it->pixel_width to 1 to avoid zero-width glyph.
4672 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4674 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4675 first 2 arguments are identical. This makes inserting large
4676 output from a subprocess an order of magnitude faster on
4677 MS-Windows, where all sbrk'ed memory is always contiguous.
4679 2012-01-31 Glenn Morris <rgm@gnu.org>
4681 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4682 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4683 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4685 2012-01-29 Glenn Morris <rgm@gnu.org>
4687 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4689 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4691 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4693 2012-01-28 Chong Yidong <cyd@gnu.org>
4695 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4697 2012-01-26 Chong Yidong <cyd@gnu.org>
4699 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4701 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4702 repeat counts (Bug#10507).
4704 2012-01-26 Glenn Morris <rgm@gnu.org>
4706 * lread.c (syms_of_lread): Doc fix.
4708 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4710 * coding.c (encode_designation_at_bol): Change return value to
4713 2012-01-25 Chong Yidong <cyd@gnu.org>
4715 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4717 2012-01-21 Chong Yidong <cyd@gnu.org>
4719 * floatfns.c (Fcopysign): Make the second argument non-optional,
4720 since nil is not allowed anyway.
4722 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4724 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4725 (send_process): Likewise.
4727 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4729 * window.c (save_window_save, Fcurrent_window_configuration)
4730 (Vwindow_persistent_parameters): Do not use Qstate.
4731 Rewrite doc-strings.
4733 2012-01-19 Kenichi Handa <handa@m17n.org>
4735 * character.c (char_width): New function.
4736 (Fchar_width, c_string_width, lisp_string_width):
4737 Use char_width (Bug#9496).
4739 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4741 * window.c (Vwindow_persistent_parameters): New variable.
4742 (Fset_window_configuration, save_window_save): Handle persistent
4745 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4747 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4748 thrashing the stack of the thread. (Bug#9087)
4750 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4752 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4754 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4756 * xdisp.c (rows_from_pos_range): Handle the case where the
4757 highlight ends on a newline. (Bug#10464)
4758 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4759 he end column for display of highlight that ends on a newline
4762 2012-01-11 Glenn Morris <rgm@gnu.org>
4764 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4765 from load-path also when installation-directory is nil. (Bug#10208)
4767 2012-01-10 Glenn Morris <rgm@gnu.org>
4769 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4771 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4772 Update template values to be closer to their typical values these days.
4774 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4776 * xdisp.c (rows_from_pos_range): Accept additional argument
4777 DISP_STRING, and accept any glyph in a row whose object is that
4778 string as eligible for mouse highlight. Fixes mouse highlight of
4779 display strings from overlays. (Bug#10464)
4781 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4783 emacs: fix an auto-save permissions race condition (Bug#10400)
4784 * fileio.c (auto_saving_dir_umask): New static var.
4785 (Fmake_directory_internal): Use it.
4786 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4787 creating the directory. The old code temporarily assigns
4788 too-generous permissions to the directory.
4789 (do_auto_save_eh): Clear it.
4790 (Fdo_auto_save): Catch all errors, not just file errors, so
4791 that the var is always cleared.
4793 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4795 * search.c (scan_buffer): Pass character positions to
4796 know_region_cache, not byte positions. (Bug#6540)
4798 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4800 * w32.c (sys_rename): Report EXDEV when rename of a directory
4801 fails because the target is on another logical disk. (Bug#10284)
4803 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4805 * xterm.c (x_embed_request_focus): New function.
4807 * xterm.h: Add prototype.
4809 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4811 2012-01-05 Glenn Morris <rgm@gnu.org>
4813 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4815 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4817 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4818 Load gnutls_transport_set_lowat only if GnuTLS version is below
4820 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4821 GnuTLS versions below 2.11.1.
4823 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4825 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4826 to the doc string advising against its use for altering the way
4827 windows are scrolled.
4829 2011-12-28 Kenichi Handa <handa@m17n.org>
4831 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4832 coding-system ASCII compatible only when it does not produce BOM
4833 on encoding (Bug#10383).
4835 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4837 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4839 (create_and_show_popup_menu): Always use menu_position_func for
4842 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4844 * callint.c (Fcall_interactively): Don't truncate prompt string.
4846 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4848 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4849 property that ends at ZV, so that the bidi iteration could be
4850 resumed from there (after widening). (Bug#10360)
4852 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4854 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4856 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4858 * nsterm.m (x_free_frame_resources):
4859 Release f->output_data.ns->miniimage.
4860 (ns_index_color): Fix indentation. Do not retain
4861 color_table->colors[i].
4863 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4866 * nsfns.m (x_set_background_color): Assign return value from
4867 ns_index_color to face-background instead of NSColor*.
4868 (ns_implicitly_set_icon_type): Fix indentation.
4869 Change assignment in for loop to comparison.
4871 * emacs.c (ns_pool): New variable.
4872 (main): Assign ns_pool.
4873 (Fkill_emacs): Call ns_release_autorelease_pool.
4875 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4876 autorelease fdesc, release fdAttrs and tdict.
4877 (ns_get_covering_families): Release charset.
4878 (ns_findfonts): Release NSFontDescriptor created with new.
4879 (ns_uni_to_glyphs): Fix indentation.
4880 (setString): Release attrStr before assigning new value.
4882 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4884 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4886 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4887 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4889 2011-12-18 David Reitter <reitter@cmu.edu>
4891 * nsterm.m (ns_term_init): Subscribe for notifications
4892 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4893 to method trackingNotification in EmacsMenu.
4895 * nsmenu.m (trackingMenu): New variable.
4896 (trackingNotification): New method (from Aquamacs).
4897 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4898 from Aquamacs (Bug#7030).
4900 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4902 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4903 (symbol_to_nsstring): Fix indentation.
4904 (ns_symbol_to_pb): New function.
4905 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4906 (Fns_rotate_cut_buffers_internal): Remove.
4907 (Fns_store_selection_internal): Rename from
4908 Fns_store_cut_buffer_internal.
4909 (ns_get_foreign_selection, Fx_own_selection_internal)
4910 (Fx_disown_selection_internal, Fx_selection_exists_p)
4911 (Fns_get_selection_internal, Fns_store_selection_internal):
4912 Use ns_symbol_to_pb and check if return value is nil.
4913 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4914 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4915 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4916 renamed to Sns_store_selection_internal.
4917 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4918 and remove this function.
4919 (ns_handle_selection_clear): Remove, never used.
4920 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4923 2011-12-17 Ken Brown <kbrown@cornell.edu>
4925 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4926 GID is unknown (Bug#10257).
4928 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4930 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4931 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4932 which caused a build failure on GNU/Linux IA-64. This problem was
4933 introduced by my 2011-10-07 patch.
4935 2011-12-15 Juri Linkov <juri@jurta.org>
4937 * image.c (imagemagick_error): New function. (Bug#10112)
4938 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4939 Use `imagemagick_error' where ImageMagick functions return
4941 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4944 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4946 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4947 fill background (Bug#8992).
4949 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4951 * window.c (Vwindow_combination_resize)
4952 (Vwindow_combination_limit): Use t instead of non-nil in
4954 (Vrecenter_redisplay): Add first sentence of doc-string on
4956 (Frecenter): Fix doc-string typo.
4958 2011-12-11 Kenichi Handa <handa@m17n.org>
4960 * coding.c (Funencodable_char_position): Pay attention to the
4961 buffer text relocation (Bug#9389).
4963 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4965 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4966 gtk_init (Bug#10100).
4968 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4970 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4971 IT->string is nil. (Bug#10263)
4973 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4975 * nsterm.h (x_free_frame_resources): Declare.
4977 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4978 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4980 * nsterm.h (ns_get_defaults_value): Declare.
4982 * nsterm.m (ns_default): Call ns_get_defaults_value.
4984 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4986 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4989 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4991 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4992 that where the value of an _OBJC_* symbol points to is in the .bss
4993 section (Bug#10240).
4995 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4997 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4998 after the loop to call ccl_driver at least once (Bug#8619).
5000 2011-12-08 Kenichi Handa <handa@m17n.org>
5002 * ftfont.c (get_adstyle_property): Fix previous change
5005 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5007 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5008 dirs from the default value of EMACSLOADPATH (bug#10208).
5010 2011-12-07 Glenn Morris <rgm@gnu.org>
5012 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5013 installation and source directories as well. (Bug#10208)
5015 2011-12-06 Chong Yidong <cyd@gnu.org>
5017 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5019 2011-12-06 Glenn Morris <rgm@gnu.org>
5021 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5022 as an error, not just -1. (Bug#10217)
5024 2011-12-05 Chong Yidong <cyd@gnu.org>
5026 * keyboard.c (process_special_events): New function.
5027 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5029 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5031 * coding.c (encode_designation_at_bol): Don't use uninitialized
5032 local variable (Bug#9318).
5034 2011-12-05 Kenichi Handa <handa@m17n.org>
5036 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5037 return Qnil (Bug#8046, Bug#10193).
5039 2011-12-05 Kenichi Handa <handa@m17n.org>
5041 * coding.c (encode_designation_at_bol): New args charbuf_end and
5042 dst. Return the number of produced bytes. Callers changed.
5043 (coding_set_source): Return how many bytes coding->source was
5045 (coding_set_destination): Return how many bytes
5046 coding->destination was relocated.
5047 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5048 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5050 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5052 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5053 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5056 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5058 The following changes are to fix Bug#9318.
5060 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5061 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5062 (encode_coding_iso_2022, encode_coding_sjis)
5063 (encode_coding_big5, encode_coding_charset): Use the above macros.
5065 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5067 * lisp.h (process_quit_flag): Fix external declaration.
5069 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5071 Don't macro-inline non-performance-critical code.
5072 * eval.c (process_quit_flag): New function.
5073 * lisp.h (QUIT): Use it.
5075 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5077 * nsfns.m (get_geometry_from_preferences): New function.
5078 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5080 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5082 * emacs.c (Qkill_emacs): Define.
5083 (syms_of_emacs): Initialize it.
5084 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5085 Qquit_flag to `kill-emacs' instead.
5086 (quit_throw_to_read_char): Add parameter `from_signal'.
5087 All callers changed. Call Fkill_emacs if requested and safe.
5088 * lisp.h (QUIT): Call Fkill_emacs if requested.
5090 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5092 * widget.c (update_wm_hints): Return if wmshell is null.
5093 (widget_update_wm_size_hints): New function.
5095 * widget.h (widget_update_wm_size_hints): Declare.
5097 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5098 widget_update_wm_size_hints (Bug#10104).
5100 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5102 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5103 before a newline, prepare the bidi iterator for consuming the
5104 newline, and keep the current paragraph direction. (Bug#10183)
5105 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5107 2011-12-02 Juri Linkov <juri@jurta.org>
5109 * search.c (Fword_search_regexp): New Lisp function created from
5110 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5111 (Fword_search_backward, Fword_search_forward)
5112 (Fword_search_backward_lax, Fword_search_forward_lax):
5113 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5114 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5116 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5118 * fileio.c (Finsert_file_contents): Move after-change-function call
5119 to before the "handled:" label, since all "goto handled" appear in
5120 cases where the *-change-functions have already been properly called
5123 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5125 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5126 waiting for input. (Bug#10169)
5128 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5130 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5131 verifies glyph row's hash code--we have just reallocated the
5132 glyphs, so their contents can be complete garbage. (Bug#10164)
5134 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5136 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5138 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5140 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5141 attributes are tested _before_ calling verify_row_hash, to protect
5142 against GCC re-ordering of the tests. (Bug#10164)
5144 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5146 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5148 * xterm.c (handle_one_xevent): Only set async_visible and friends
5149 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5150 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5151 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5153 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5155 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5156 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5157 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5158 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5159 All uses changed to use GCPRO1 etc.
5160 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5161 Revert to old implementation (i.e., before 2011-03-11).
5163 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5165 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5166 of scroll runs so as to avoid assigning disabled bogus rows and
5167 unnecessary graphics copy operations.
5169 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5171 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5172 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5173 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5174 (malloc, free, realloc, calloc): Redirect to e_* only when
5177 * lisp.h (GCTYPEBITS): Move before first use.
5178 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5179 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5180 this macro definition.
5182 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5185 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5187 * gtkutil.c (xg_create_frame_widgets):
5188 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5189 present with Gtk+ 2.0.
5191 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5193 * fileio.c (Finsert_file_contents): Undo previous change; see
5194 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5196 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5198 Rename locals to avoid shadowing.
5199 * fileio.c (Finsert_file_contents):
5200 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5201 * process.c (wait_reading_process_output):
5202 Rename inner 'proc' to 'p' to avoid shadowing.
5203 Indent for consistency with usual Emacs style.
5205 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5207 * xdisp.c (redisplay_window): If cursor row is not fully visible
5208 after recentering, and scroll-conservatively is set to a large
5209 number, scroll window by a few more lines to make the cursor fully
5210 visible and out of scroll-margin. (Bug#10105)
5211 (start_display): Don't move to the next line if the display should
5212 start at a newline that is part of a display vector or an overlay
5215 2011-11-24 Juri Linkov <juri@jurta.org>
5217 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5218 after the `MagickPingImage' call. (Bug#10112)
5220 2011-11-23 Chong Yidong <cyd@gnu.org>
5222 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5224 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5226 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5227 making another buffer current. (Bug#10114)
5229 2011-11-23 Glenn Morris <rgm@gnu.org>
5231 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5233 2011-11-23 Chong Yidong <cyd@gnu.org>
5235 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5236 using it (Bug#5984).
5238 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5240 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5241 and header-lines, as they don't have one computed for them.
5244 * .gdbinit (prow): Make displayed values more self-explaining.
5245 Add row's hash code.
5247 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5249 * process.c (wait_reading_process_output): Fix asynchrounous
5250 GnuTLS socket handling on some versions of the GnuTLS library.
5251 (wait_reading_process_output): Add comment and URL.
5253 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5255 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5257 2011-11-21 Chong Yidong <cyd@gnu.org>
5259 * window.c (Fnext_window, Fprevious_window): Doc fix.
5261 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5263 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5265 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5267 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5269 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5271 * window.c (Fset_window_combination_limit): Rename argument
5273 (Vwindow_combination_limit): Remove "status" from doc-string.
5275 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5277 * m/ibms390.h: Remove.
5278 * m/ibms390x.h: Don't include "ibms390.h".
5280 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5282 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5283 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5285 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5287 * casetab.c (Fset_case_table):
5288 * charset.c (Fcharset_after): Fix typos.
5290 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5292 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5293 Otherwise, valgrind does not work on some platforms.
5294 Problem reported by Andreas Schwab in
5295 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5296 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5297 is set, removing the need for VIRT_ADDRESS_VARIES.
5298 (PURE_P): Use a more-efficient implementation that needs just one
5299 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5300 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5301 to 4 (xorl, subq, cmpq, setbe).
5302 * alloc.c (pure): Always extern now, since that's the
5303 VIRT_ADDR_VARIES behavior.
5304 (PURE_POINTER_P): Use a single comparison, not two, for
5305 consistency with the new puresize.h.
5306 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5307 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5308 Remove VIRT_ADDR_VARIES no longer needed.
5310 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5312 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5313 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5314 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5315 behave as if the cursor position were at the window margin.
5317 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5318 and the cursor position is out of bounds, behave as if the cursor
5319 position were at the window margin. (Bug#10075)
5321 2011-11-18 Chong Yidong <cyd@gnu.org>
5323 * window.c (Fwindow_combination_limit): Make first argument
5324 non-optional, since it is meaningless for live windows like the
5327 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5329 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5331 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5333 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5334 (graft_intervals_into_buffer): Simplify.
5336 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5338 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5339 hash values of the two rows.
5340 (copy_row_except_pointers): Preserve the used[] arrays and the
5341 hash values of the two rows. (Bug#10035)
5342 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5344 * xdisp.c (row_hash): New function, body extracted from
5345 compute_line_metrics.
5346 (compute_line_metrics): Call row_hash, instead of computing the
5349 * dispnew.c (verify_row_hash): Call row_hash for computing the
5350 hash code of a row, instead of duplicating code from xdisp.c.
5352 * dispextern.h (row_hash): Add prototype.
5354 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5356 * frame.c (delete_frame): Don't delete the terminal when the last
5357 X frame is closed if emacs is built with GTK toolkit.
5359 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5361 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5363 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5365 * window.c (Vwindow_splits): Rename to
5366 Vwindow_combination_resize. Suggested by Juri Linkov.
5367 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5370 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5372 * nsfns.m (Fns_font_name):
5373 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5375 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5377 * window.h (window): Rename slot "nest" to "combination_limit".
5378 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5379 (Fset_window_nest): Rename to Fset_window_combination_limit.
5380 (Vwindow_nest): Rename to Vwindow_combination_limit.
5381 (recombine_windows, make_parent_window, make_window)
5382 (Fsplit_window_internal, saved_window)
5383 (Fset_window_configuration, save_window_save): Rename all
5384 occurrences of window_nest to window_combination_limit.
5386 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5388 * image.c (imagemagick_load_image): Fix typo.
5390 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5392 * xdisp.c (display_line): Move the call to
5393 highlight_trailing_whitespace before the call to
5394 compute_line_metrics, since the latter needs to see the final
5395 faces of all the glyphs to compute ROW's hash value.
5396 Fixes assertion violations in row_equal_p. (Bug#10035)
5398 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5400 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5401 just return (bug#10044).
5403 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5405 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5406 with user-defined heap size. Bump the default size of the temacs
5407 heap to 27MB, to avoid memory warning when running temacs.
5408 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5410 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5411 current_matrix and desired_matrix. (Bug#9990)
5412 (verify_row_hash) [XASSERTS]: New function.
5413 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5414 that the hash value of glyph rows is correct.
5416 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5418 * window.h (window): Remove splits slot.
5419 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5420 (Fdelete_other_windows_internal, make_parent_window)
5421 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5422 (Fset_window_configuration, save_window_save): Don't deal with
5423 split status of windows.
5424 (saved_window): Remove splits slot.
5425 (Vwindow_splits): Rewrite doc-string.
5427 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5429 * xfns.c (unwind_create_frame):
5430 * nsfns.m (unwind_create_frame):
5431 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5432 Vframe_list (Bug#9999).
5434 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5436 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5438 2011-11-11 Kenichi Handa <handa@m17n.org>
5440 * callproc.c (Fcall_process): Set the member dst_multibyte of
5443 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5445 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5446 avoid a crash (bug#9496).
5448 2011-11-09 Chong Yidong <cyd@gnu.org>
5450 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5451 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5453 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5455 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5457 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5459 Avoid some portability problems by eschewing 'extern inline' functions.
5460 The trivial performance wins aren't worth the portability hassles; see
5461 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5463 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5464 (window_box_width, window_box_left, window_box_left_offset)
5465 (window_box_right, window_box_right_offset): Undo previous change,
5466 by removing the "extern"s.
5467 * intervals.c (adjust_intervals_for_insertion)
5468 (adjust_intervals_for_deletion): Undo previous change,
5469 making these static again.
5470 (offset_intervals, temp_set_point_both, temp_set_point)
5471 (copy_intervals_to_string): No longer inline.
5472 * xdisp.c (window_text_bottom_y, window_box_width)
5473 (window_box_height, window_box_left_offset)
5474 (window_box_right_offset, window_box_left, window_box_right)
5475 (window_box): No longer inline.
5477 2011-11-08 Chong Yidong <cyd@gnu.org>
5479 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5480 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5481 Signal an error if not a live window.
5482 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5483 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5485 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5487 * lisp.h (syms_of_abbrev): Remove declaration.
5488 Reported by CHENG Gao <chenggao@royau.me>.
5490 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5492 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5493 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5494 of temacs in GUI mode.
5496 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5498 * window.h: Declare delete_all_child_windows instead of
5499 delete_all_subwindows.
5500 * window.c (Fwindow_nest, Fset_window_nest)
5501 (Fset_window_new_total, Fset_window_new_normal)
5502 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5503 (delete_all_subwindows): Rename to delete_all_child_windows.
5504 (Fdelete_other_windows_internal, Fset_window_configuration):
5505 Call delete_all_child_windows instead of delete_all_subwindows.
5506 * frame.c (delete_frame): Call delete_all_child_windows instead
5507 of delete_all_subwindows.
5509 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5511 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5512 This is also needed for porting to any host where GC_MARK_STACK is
5513 not GC_MAKE_GCPROS_NOOPS.
5514 (which_symbols): Use it.
5516 2011-11-07 Kenichi Handa <handa@m17n.org>
5518 * coding.c (coding_set_destination): Check coding->src_pos only
5519 when coding->src_object is a buffer (bug#9910).
5521 * process.c (send_process): Set the member src_multibyte of coding
5522 to 0 (bug#9911) when sending a unibyte text.
5524 * callproc.c (Fcall_process): Set the member src_multibyte of
5525 process_coding to 0 (bug#9912).
5527 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5529 * xmenu.c (cleanup_widget_value_tree): New function.
5530 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5531 calling free_menubar_widget_value_tree directly (Bug#9830).
5533 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5535 Fix some portability problems with 'inline'.
5536 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5537 (window_box_width, window_box_left, window_box_left_offset)
5538 (window_box_right, window_box_right_offset): Declare extern.
5539 Otherwise, these inline functions do not conform to C99 and
5540 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5541 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5542 * intervals.c (adjust_intervals_for_insertion)
5543 (adjust_intervals_for_deletion): Now extern, because otherwise the
5544 extern inline functions 'offset_intervals' couldn't refer to it.
5545 (static_offset_intervals): Remove.
5546 (offset_intervals): Rewrite using the old contents of
5547 static_offset_intervals. The old version didn't conform to C99
5548 because an extern inline function contained a reference to an
5549 identifier with static linkage.
5551 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5553 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5556 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5558 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5559 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5560 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5561 return Qleft_to_right.
5563 2011-11-06 Chong Yidong <cyd@gnu.org>
5565 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5566 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5567 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5568 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5569 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5570 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5571 (Fwindow_vscroll): Doc fix.
5572 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5573 argument, since it makes no sense to pass a live window and for
5574 consistency with window-child.
5576 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5578 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5581 2011-11-05 Jason Rumney <jasonr@gnu.org>
5583 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5584 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5586 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5587 bitwise arithmetic preventing use of unicode-sip and non-truetype
5590 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5592 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5595 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5596 initialization code to keep similarity to xfns.c after changes
5599 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5601 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5602 (unwind_create_frame): New function (Bug#9943).
5603 (Fx_create_frame): Restructure code to be more similar to the one in
5604 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5605 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5606 Move terminal->reference_count++ just before making the frame official
5609 * nsterm.m (x_free_frame_resources): New function.
5610 (x_destroy_window): Move code to x_free_frame_resources.
5612 * xfns.c (unwind_create_frame): Fix comment.
5613 (Fx_create_frame, x_create_tip_frame):
5614 Move terminal->reference_count++ just before making the frame
5615 official. Move initialization of image_cache_refcount and
5616 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5618 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5620 Support MSVC build with newer versions of Visual Studio.
5621 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5622 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5625 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5626 which are not supported by MSVC.
5627 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5628 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5630 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5632 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5634 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5636 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5638 Support MSVC build with newer versions of Visual Studio.
5639 * w32.c: Don't include w32api.h for MSVC.
5640 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5642 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5643 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5644 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5645 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5647 (alloca) [_MSC_VER]: Define to _alloca.
5649 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5651 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5653 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5655 * xdisp.c (note_mouse_highlight): If either of
5656 previous/next-single-property-change returns nil, treat that as
5657 the beginning or the end of the buffer. (Bug#9955)
5659 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5661 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5662 label is not null (Bug#9951).
5663 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5666 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5668 * window.c (Fwindow_body_size): Mention in the doc string that the
5669 return value is in frame's canonical units. (Bug#9949)
5671 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5673 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5675 * w32fns.c (unwind_create_frame): If needed, free the glyph
5676 matrices of the partially constructed frame. (Bug#9943)
5677 * xfns.c (unwind_create_frame): Likewise.
5679 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5681 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5682 Don't stop backward scan on the continuation glyph, even though
5683 its CHARPOS is positive.
5684 (mouse_face_from_buffer_pos, note_mouse_highlight):
5685 Rename cover_string to disp_string.
5687 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5689 * window.c (temp_output_buffer_show): Don't use
5690 Vtemp_buffer_show_specifiers.
5691 (Vtemp_buffer_show_specifiers): Remove unused variable.
5693 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5695 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5696 past the beginning of the current glyph matrix.
5698 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5700 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5701 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5702 HAVE_GTK3 (Bug#9869).
5704 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5705 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5707 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5709 * xterm.c: Declare x_handle_net_wm_state to return int.
5710 (handle_one_xevent): Check if we are iconified but don't have
5711 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5712 (get_current_wm_state): Return non-zero if not hidden,
5713 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5714 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5715 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5716 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5718 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5720 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5721 so that this new function doesn't get optimized away by a
5722 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5724 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5726 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5728 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5730 Fix the `xbytecode' command.
5731 * .gdbinit (xprintbytestr): New command.
5732 (xwhichsymbols): Rename from `which'; all callers changed.
5733 (xbytecode): Print the byte-code string as well.
5735 2011-10-29 Kim Storm <storm@cua.dk>
5737 * alloc.c (which_symbols): New function.
5739 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5741 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5744 2011-10-29 Glenn Morris <rgm@gnu.org>
5746 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5747 Not clear what it was for, and it causes various bugs. (Bug#9839)
5749 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5751 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5752 possible random value that matches one of those tested as
5753 condition to clear the mouse face.
5755 2011-10-28 Chong Yidong <cyd@gnu.org>
5757 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5759 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5761 * window.c (make_window): Initialize phys_cursor_on_p.
5763 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5765 * lisp.h (struct Lisp_Symbol): Update comments.
5767 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5769 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5771 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5773 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5774 <oslsachem@gmail.com> for helping to debug this.
5776 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5777 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5778 (g_b_init_get_glyph_outline_w): New static variables.
5779 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5780 (GetGlyphOutlineW_Proc): New typedefs.
5781 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5782 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5784 (w32font_open_internal, compute_metrics):
5785 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5786 instead of calling the "wide" APIs directly.
5788 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5790 * w32.h (syms_of_w32font): Add prototype.
5792 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5794 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5795 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5796 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5797 (Fmove_to_window_line): Doc fix.
5799 2011-10-27 Chong Yidong <cyd@gnu.org>
5801 * process.c (make_process): Set gnutls_state to NULL.
5803 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5804 non-NULL, regardless of GNUTLS_INITSTAGE.
5805 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5806 an error. Set process slots as soon as we allocate them.
5808 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5810 2011-10-27 Chong Yidong <cyd@gnu.org>
5812 * gnutls.c (emacs_gnutls_deinit): New function.
5813 Deallocate credentials structures as well as calling gnutls_deinit.
5814 (Fgnutls_deinit, Fgnutls_boot): Use it.
5816 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5817 (deactivate_process): Call emacs_gnutls_deinit.
5819 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5821 * image.c (x_create_x_image_and_pixmap):
5822 * w32.c (sys_rename, w32_delayed_load):
5823 * w32font.c (fill_in_logfont):
5824 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5826 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5828 * w32fns.c (w32_default_color_map): New function,
5829 extracted from Fw32_default_color_map.
5830 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5832 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5834 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5836 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5838 * keyboard.c (test_undefined): New function (bug#9751).
5839 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5841 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5843 * sysdep.c (init_sys_modes): Fix the check for the controlling
5844 terminal (Bug#6649).
5846 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5848 * dispextern.h (struct bidi_it): New member next_en_type.
5850 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5851 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5852 current character, check also for next_en_type being WEAK_EN.
5853 (bidi_resolve_weak): Don't enter the expensive loop if the current
5854 position is before next_en_pos. Record the bidi type of the first
5855 non-ET, non-BN character we find, in addition to its position.
5856 (bidi_level_of_next_char): Invalidate next_en_type when
5857 next_en_pos is over-stepped.
5859 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5861 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5862 * editfns.c: Rewrite current-time-zone so that it invokes
5863 the equivalent of (format-time-string "%Z") to get the time zone name.
5864 This fixes a bug when the time zone name contains characters that
5865 need converting from the system time locale to Emacs internal format.
5866 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5867 that patch fixed format-time-string to do the conversion, but
5868 I forgot to fix current-time-zone.
5869 (format_time_string): New function, containing most of
5870 what Fformat_time_string used to contain.
5871 (Fformat_time_string): Rewrite in terms of format_time_string.
5872 This doesn't change this function's behavior.
5873 (current-time-zone): Rewrite to use format_time_string.
5874 This fixes the bug reported by Michael Schierl in
5875 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5876 Jason Rumney's 2007-06-07 change worked around this bug, but
5878 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5880 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5882 * xdisp.c (start_display): If the character at POS is displayed
5883 via a display vector, reset IT->current.dpvec_index to zero.
5884 (try_window_reusing_current_matrix): If a line ends in a display
5885 vector or the next line starts in a display vector, continue
5886 redrawing the window even though the character position of
5887 start_row was reached.
5890 2011-10-18 Chong Yidong <cyd@gnu.org>
5892 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5893 with nobreak-char-display too.
5895 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5897 Fix part 3 of bug#9771.
5898 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5899 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5900 non-neutral characters if the current character is a paragraph
5901 separator (a.k.a. Newline). This avoids running the same
5902 expensive loop twice, once when we consume the preceding newline
5903 and the other time when the line actually needs to be displayed.
5904 Avoid the loop when we see neutrals on the base embedding level
5905 following a character whose directionality is the same as the
5906 paragraph's. This avoids running the expensive loop when a line
5907 ends in a long sequence of neutrals, like control characters.
5908 Add assertion against STRONG_AL type. Slightly rearrange code
5909 that determines the type of a neutral given the first non-neutral
5911 (bidi_level_of_next_char): Set next_en_pos to zero when
5912 invalidating its info.
5914 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5916 * xdisp.c (push_display_prop): Determine whether to record string
5917 or buffer position by IT->string, not by IT->method. Allow
5918 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5919 (move_it_vertically_backward): Don't look for character position
5920 immediately after the newline when in a continuation line.
5923 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5925 * window.c (coordinates_in_window): Rewrite and delabelize
5926 vertical border check. (Bug#5357) (Bug#9618)
5928 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5930 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5931 errors in XSetWindowBorder (bug#9310).
5933 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5935 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5936 avoid crash when xmalloc overrun checking is enabled.
5938 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5940 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5941 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5942 cursor motion with <left> and <right> arrow keys.
5944 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5945 some callers set that themselves.
5947 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5949 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5950 display string and the previous row comes from the same string and
5951 is empty. (Bug#9739) (Bug#9738)
5953 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5955 * doc.c (get_doc_string): Encode file name (bug#9735).
5957 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5959 * bidi.c (bidi_level_of_next_char):
5960 * xdisp.c (get_visually_first_element): Remove old incorrect
5961 comments regarding the Unicode Line Separator character.
5963 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5965 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5967 * alloc.c (Fgc_status): Do not access beyond zombies array
5968 boundary if nzombies > MAX_ZOMBIES.
5969 * alloc.c (dump_zombies): Add missing format specifier.
5971 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5973 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5974 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5976 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5977 Some packages use them to denote characters with modifiers.
5979 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5981 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5982 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5983 matching a pp-number. Rename parameter var to var1.
5985 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5987 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5989 2011-10-08 Glenn Morris <rgm@gnu.org>
5991 * callint.c (Fcall_interactively): Give a more explicit error for the
5992 'c' case with a non-character input. (Bug#8479)
5994 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5996 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5998 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5999 lines that are hscrolled on the left.
6001 * dispnew.c (buffer_posn_from_coords): Account for a possible
6002 presence of header-line. (Bug#4426)
6004 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6006 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6007 Don't advertise functionality which we discourage or doesn't work.
6009 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6011 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6012 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6013 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6014 this makes Emacs dump core during garbage collection on rare
6015 occasions. sizeof is obviously inferior to offsetof here, so
6016 stick with offsetof.
6017 (GC_POINTER_ALIGNMENT): New macro.
6018 (mark_memory): Omit 3rd (offset) arg; caller changed.
6019 Don't assume EMACS_INT alignment is the same as pointer alignment.
6021 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6023 * keyboard.c (read_key_sequence_remapped): New var.
6024 (read_key_sequence): Compute remapping in the right buffer.
6025 (command_loop_1): Use read_key_sequence's remapping directly.
6027 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6029 * dired.c (file_name_completion): Don't expand file name.
6030 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6031 before checking file name handler.
6033 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6034 they've been requested explicitly (bug#9591).
6036 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6038 * keymap.c (Fsingle_key_description): Use make_specified_string
6039 instead of build_string to build string from push_key_description.
6042 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6044 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6045 This fixes a Y2038 bug on 64-bit hosts.
6046 * buffer.c (reset_buffer):
6047 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6048 (Fclear_buffer_auto_save_failure):
6049 Use 0, not -1, to represent an unset failure time, since time_t
6050 might not be signed.
6052 Remove dependency on glibc malloc internals.
6053 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6054 Move back here from lisp.h, but with their new implementations.
6055 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6056 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6057 * charset.c (charset_table_init): New static var.
6058 (syms_of_charset): Use it instead of xmalloc. This removes a
6059 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6060 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6061 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6062 Move back to alloc.c.
6063 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6064 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6066 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6068 * nsterm.m (windowDidResize): Call x_set_window_size only when
6069 ns_in_resize is true. Otherwise set pixelwidth/height and
6070 call change_frame_size (Bug#9628).
6072 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6074 Port --enable-checking=all to Fedora 14 x86-64.
6075 * charset.c (syms_of_charset): Also account for glibc malloc's
6076 internal overhead when calculating the initial malloc maximum.
6078 Port --enable-checking=all to Fedora 14 x86.
6079 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6081 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6082 (overrun_check_realloc, overrun_check_free):
6083 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6084 That way, xmalloc returns a properly-aligned pointer even if
6085 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6086 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6087 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6088 into account when calculating the initial malloc maximum.
6089 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6090 Move here from alloc.c, so that charset.c can use it too.
6091 Properly align; the old code wasn't right for common 32-bit hosts
6092 when configured with --enable-checking=all.
6093 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6094 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6096 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6098 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6101 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6103 * xdisp.c (compute_display_string_end): If there's no display
6104 string at CHARPOS, return -1.
6106 * bidi.c (bidi_fetch_char): When compute_display_string_end
6107 returns a negative value, treat the character as a normal
6108 character not covered by a display string. (Bug#9624)
6110 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6112 * lread.c (Fread_from_string): Fix typo in docstring.
6114 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6116 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6117 newline, reseat the iterator instead of bidi-iterating there one
6118 character at a time. (Bug#9610)
6119 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6120 TO_CHARPOS if the bidi iterator is at base embedding level.
6122 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6124 * lread.c (readevalloop): Use correct code for NBSP.
6125 (read1): Likewise. (Bug#9608)
6127 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6129 * dbusbind.c (Fdbus_register_signal): When service is not
6130 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6132 2011-09-25 Glenn Morris <rgm@gnu.org>
6134 * buffer.c (truncate-lines): Doc fix.
6136 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6138 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6139 (Fset_window_next_buffers): Doc fix.
6141 2011-09-24 Glenn Morris <rgm@gnu.org>
6143 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6145 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6147 Fix minor problems found by static checking.
6148 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6149 * indent.c (Fvertical_motion): Fix == vs = typo.
6151 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6153 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6154 Default value is now t. Doc fix.
6156 * indent.c (Fvertical_motion): Compute and apply the overshoot
6157 logic when moving up, not only when moving down. Fix the
6158 confusing name and values of the it_overshoot_expected variable;
6159 logic changes accordingly. (Bug#9254) (Bug#9549)
6161 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6162 CHARPOS is covered by a display string which includes newlines.
6163 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6164 is covered by a display string with embedded newlines.
6166 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6168 * dbusbind.c (Fdbus_register_signal): Add match rule to
6169 Vdbus_registered_objects_table. (Bug#9581)
6170 (Fdbus_register_method, Vdbus_registered_objects_table):
6173 2011-09-24 Jim Meyering <meyering@redhat.com>
6175 do not ignore write error for any output size
6176 The previous change was incomplete.
6177 While it makes emacs --batch detect the vast majority of stdout
6178 write failures, errors were still ignored whenever the output size is
6179 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6180 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6181 && echo FAIL: ignored write error
6182 FAIL: ignored write error
6183 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6184 && echo FAIL: ignored write error
6185 FAIL: ignored write error
6186 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6188 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6190 * emacs.c (Fkill_emacs): In noninteractive mode exit
6191 non-successfully if a write error occurred on stdout. (Bug#9574)
6193 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6195 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6198 * dispextern.h (struct it): Update the comment documenting what
6201 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6203 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6204 a display string, extend search for cursor position to end of row.
6205 (find_row_edges): If the row ends in a newline from a display
6206 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6207 Handle the case of a display string with multiple newlines.
6208 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6209 non-empty line. Fixes confusing cursor motion with arrow keys at
6210 the beginning of a line that starts with whitespace.
6212 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6214 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6217 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6219 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6222 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6224 * xdisp.c (display_line): Record maximum and minimum buffer
6225 positions even if no glyphs were produced (e.g., by a zero-width
6226 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6227 buffer positions that will be removed from the glyph row because
6229 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6230 column is beyond frame width: don't subtract 1 "pixel" when
6231 computing width of the stretch.
6232 (reseat_at_next_visible_line_start): Undo the change made on
6233 2011-09-17 that saved paragraph information and restored it after
6234 the call to `reseat'. (Bug#9545)
6236 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6238 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6239 and turn window cursor on if cleared (Bug#9415).
6241 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6243 * search.c (boyer_moore): Take unibyte characters from pattern
6244 literally. (Bug#9458)
6246 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6248 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6250 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6252 Fix minor problem found by static checking.
6253 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6254 initialized, to pacify gcc -Wuninitialized.
6256 * fileio.c: Report proper errno when syscall falls.
6257 (Finsert_file_contents): Save and restore errno,
6258 so that report_file_error outputs the correct diagnostic.
6259 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6261 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6263 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6265 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6267 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6268 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6270 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6272 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6273 about the current paragraph and restore it after the call to reseat.
6275 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6276 (bidi_find_paragraph_start): Search back for paragraph beginning
6277 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6278 (bidi_move_to_visually_next): Only trigger paragraph-related
6279 computations when the last character is a newline or at EOB, not
6280 just any NEUTRAL_B. (Bug#9470)
6282 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6283 truncated lines if point is covered by a display string. (Bug#9524)
6285 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6287 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6288 (cons_to_x_long): New function.
6289 (lisp_data_to_selection_data): Use it. Correct the test for
6290 short-versus-long data; it was negated. Break out of vector
6291 loop, for efficiency, when a long datum is discovered.
6293 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6295 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6297 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6299 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6300 GCC PR/17406) by declaring this function with external scope.
6302 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6304 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6305 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6307 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6309 * editfns.c (Fformat): Correctly handle text properties on "%%".
6311 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6313 * xterm.c (x_draw_composite_glyph_string_foreground):
6314 * w32term.c (x_draw_composite_glyph_string_foreground):
6315 * term.c (encode_terminal_code):
6316 * composite.c (composition_update_it, get_composition_id):
6317 * xdisp.c (get_next_display_element)
6318 (fill_composite_glyph_string): Add comments about special meaning
6319 of TAB characters in a composition.
6321 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6323 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6324 This occurs when processing a multibyte format.
6325 Problem reported by Wolfgang Jenker.
6327 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6329 * xdisp.c (try_cursor_movement): Only check for exact match if
6330 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6332 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6334 Remove unused external symbols.
6335 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6336 * xdisp.c (calc_pixel_width_or_height): Now static.
6337 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6338 * indent.c (check_display_width):
6339 * w32term.c: Fix comment to match code.
6340 * xterm.c, xterm.h (x_catching_errors): Remove.
6342 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6344 * xselect.c: Use signed conversions more consistently (Bug#9498).
6345 (selection_data_to_lisp_data): Assume incoming selection data are
6346 signed integers, not unsigned. This is to be consistent with
6347 outgoing selection data, which was modified to use signed integers
6348 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6349 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6350 expects long, not unsigned long.
6352 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6354 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6355 computation of loop end. Reported by Johan Bockgård
6358 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6360 * frame.c (Fother_visible_frames_p): Function deleted.
6362 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6364 * indent.c (compute_motion): Process display vector front to back
6365 rather than the other way around. (Bug#2496)
6367 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6369 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6371 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6373 * minibuf.c (Fread_from_minibuffer): Doc fix.
6375 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6377 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6378 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6380 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6382 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6383 value for non-existent files.
6385 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6387 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6388 set its "size" to -1. This will set the modtime_size field of
6389 the corresponding buffer to -1, which is what
6390 verify-visited-file-modtime expects for files that do not exist.
6393 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6395 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6397 * lisp.h: ... from here. push_key_description is no longer
6398 defined in keyboard.c, so its declaration should not be in
6399 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6400 logically belongs with push_key_description.
6402 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6404 * buffer.h: Include <sys/types.h> instead of <time.h>.
6405 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6406 Problem reported by Herbert J. Skuhra.
6408 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6410 * xml.c (parse_region): Make the parsing work for
6411 non-comment-starting XML files again (bug#9144).
6413 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6415 * image.c (gif_load): Fix calculation of bottom and right corner.
6418 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6420 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6421 redisplay in small windows.
6423 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6425 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6427 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6429 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6430 Operate on live windows only.
6432 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6434 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6436 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6438 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6439 only under bidi iteration.
6441 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6443 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6445 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6447 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6448 Without this fix, the command to link temacs failed due to an
6449 undefined symbol __builtin_isnan. This is because
6450 /usr/include/iso/math_c99.h #defines isnan(x) to
6451 __builtin_isnan(x), but the bundled gcc, which identifies itself
6452 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6454 * floatfns.c (isnan): #undef, and then #define to a clone of
6456 (Fisnan): Always define, since it's always available now.
6457 (syms_of_floatfns): Always define isnan at the Lisp level.
6459 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6461 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6463 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6465 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6466 The previous code assumed that file offsets (off_t values) fit in
6467 EMACS_INT variables, which is not true on typical 32-bit hosts.
6468 The code messed up by falsely reporting buffer overflow in cases
6469 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6470 when "big" contains more than 2**29 bytes, even though this
6471 inserts just one byte and does not overflow the buffer.
6472 (Finsert_file_contents): Store file offsets as off_t
6473 values, not as EMACS_INT values. Check for overflow when
6474 converting between EMACS_INT and off_t. When checking for
6475 buffer overflow or for overlap, take the offsets into account.
6476 Don't use EMACS_INT for small values where int suffices.
6477 When checking for overlap, fix a typo: ZV was used where
6478 ZV_BYTE was intended.
6479 (Fwrite_region): Don't assume off_t fits into 'long'.
6480 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6482 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6484 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6486 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6488 sprintf-related integer and memory overflow issues (Bug#9412).
6490 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6491 (esprintf, exprintf, evxprintf): New functions.
6492 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6493 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6494 (modify_event_symbol): Do not assume that the length of
6495 name_alist_or_stem is safe to alloca and fits in int.
6496 (Fexecute_extended_command): Likewise for function name and binding.
6497 (Frecursion_depth): Wrap around reliably on integer overflow.
6498 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6499 since some callers pass EMACS_INT values.
6500 (Fsingle_key_description): Don't crash if symbol name contains more
6501 than MAX_ALLOCA bytes.
6502 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6503 (get_minibuffer): Arg is now EMACS_INT, not int.
6504 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6505 (esprintf, exprintf, evxprintf): New decls.
6506 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6508 * dbusbind.c (signature_cat): New function.
6509 (xd_signature, Fdbus_register_signal):
6510 Do not overrun buffer; instead, report string overflow.
6512 * dispnew.c (add_window_display_history): Don't overrun buffer.
6513 Truncate instead; this is OK since it's just a log.
6515 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6516 even if the time zone offset is outlandishly large.
6517 Don't mishandle offset == INT_MIN.
6519 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6520 when creating daemon; the previous buffer-overflow check was incorrect.
6522 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6523 which has the guts of the old verror function.
6525 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6526 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6528 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6529 (font_unparse_xlfd): Don't blindly alloca long strings.
6530 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6531 fits in int, when using sprintf. Use single snprintf to count
6532 length of string rather than counting it via multiple sprintfs;
6533 that's simpler and more reliable.
6534 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6535 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6536 sprintf, in case result does not fit in int.
6538 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6539 (fontset_from_font): Print it.
6541 * frame.c (tty_frame_count): Now printmax_t, not int.
6542 (make_terminal_frame, set_term_frame_name): Print it.
6543 (x_report_frame_params): In X, window IDs are unsigned long,
6544 not signed long, so print them as unsigned.
6545 (validate_x_resource_name): Check for implausibly long names,
6546 and don't assume name length fits in 'int'.
6547 (x_get_resource_string): Don't blindly alloca invocation name;
6548 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6551 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6552 (xg_check_special_colors, xg_set_geometry):
6553 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6555 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6556 Use esprintf, not sprintf, in case result does not fit in int.
6558 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6559 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6560 it as a large positive number.
6561 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6562 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6564 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6565 in case result does not fit in int.
6567 * print.c (float_to_string): Detect width overflow more reliably.
6568 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6569 buffer overrun. Don't assume list length fits in 'int'. Treat
6570 print length of 0 as 0, not as infinity; to be consistent with other
6571 uses of print length in this function. Don't overflow print length
6572 index. Don't assume hash table size fits in 'long', or that
6573 vectorlike size fits in 'unsigned long'.
6575 * process.c (make_process): Use printmax_t, not int, to format
6576 process-name gensyms.
6578 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6580 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6581 to avoid potential buffer overrun.
6583 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6584 if X resource line is longer than 512 bytes.
6586 * xfns.c (x_window): Make sprintf buffer a bit bigger
6587 to avoid potential buffer overrun.
6589 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6591 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6593 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6595 Integer overflow fixes for scrolling, etc.
6596 Without these, Emacs silently mishandles large integers sometimes.
6597 For example, "C-u 4294967297 M-x recenter" was treated as if
6598 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6600 * xdisp.c (try_window_id): Check Emacs fixnum range before
6601 converting to 'int'.
6603 * window.c (window_scroll_line_based, Frecenter):
6604 Check that an Emacs fixnum is in range before assigning it to 'int'.
6605 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6606 values converted from Emacs fixnums.
6607 (Frecenter): Don't wrap around a line count if it is out of 'int'
6608 range; instead, treat it as an extreme value.
6609 (Fset_window_configuration, compare_window_configurations):
6610 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6612 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6613 that can exceed INT_MAX. Check that EMACS_INT value is in range
6614 before assigning it to the (possibly-narrower) index.
6615 (match_limit): Don't assume that a fixnum can fit in 'int'.
6617 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6620 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6621 (Fvertical_motion): Don't wrap around LINES values that don't fit
6622 in 'int'. Instead, treat them as extreme values. This is good
6623 enough for windows, which can't have more than INT_MAX lines anyway.
6625 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6627 * Require libxml/parser.h to avoid compilation warning.
6629 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6631 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6632 since this reportedly can destroy thread storage.
6634 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6636 * syntax.c (find_defun_start): Update all cache variables if
6637 exiting early (Bug#9401).
6639 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6641 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6643 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6644 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6645 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6647 * term.c (tty_append_glyph): New function.
6648 (produce_stretch_glyph): Static function and its prototype deleted.
6650 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6653 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6655 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6656 when checking :margin (Bug#9390).
6657 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6658 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6659 so that the name doesn't mislead. All uses changed.
6661 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6663 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6666 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6668 * xdisp.c (move_it_to): Don't bail out early when reaching
6669 position beyond to_charpos, if we are scanning backwards.
6670 (move_it_vertically_backward): When DY == 0, make sure we get to
6671 the first character in the line after the newline.
6673 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6675 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6676 (ccl_driver): Do not generate an out-of-range pointer.
6677 (Fccl_execute_on_string): Remove unnecessary check for
6678 integer overflow, noted by Stefan Monnier in
6679 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6680 Remove a FIXME that didn't need fixing.
6681 Simplify the newly-introduced buffer reallocation code.
6683 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6685 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6687 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6689 Integer and memory overflow issues (Bug#9196).
6691 * doc.c (get_doc_string): Rework so that
6692 get_doc_string_buffer_size is the actual buffer size, rather than
6693 being 1 less than the actual buffer size; this makes xpalloc more
6696 * image.c (x_allocate_bitmap_record, cache_image):
6697 * xselect.c (Fx_register_dnd_atom):
6698 Simplify previous changes by using xpalloc.
6700 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6701 since either will do and ptrdiff_t is convenient with xpalloc.
6703 * charset.c (charset_table_size)
6704 (struct charset_sort_data.priority): Now ptrdiff_t.
6705 (charset_compare): Don't overflow if priorities differ greatly.
6706 (Fsort_charsets): Don't assume list length fits in int.
6707 Check for size-calculation overflow when allocating sort data.
6708 (syms_of_charset): Allocate an initial charset table that is
6709 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6711 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6713 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6714 The actual value is always <= INT_MAX, and leaving it unsigned made
6715 overflow checking harder.
6717 * dispextern.h (struct glyph_matrix.rows_allocated)
6718 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6719 with xpalloc. The values are still always <= INT_MAX.
6721 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6723 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6724 (SAFE_NALLOCA): New macro.
6726 * region-cache.c (struct boundary.pos, find_cache_boundary)
6727 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6728 (set_cache_region, invalidate_region_cache)
6729 (revalidate_region_cache, know_region_cache, region_cache_forward)
6730 (region_cache_backward, pp_cache):
6731 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6732 so that ptrdiff_t * can be passed to xpalloc.
6733 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6734 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6735 (pp_cache): Don't assume cache_len fits in int.
6736 * region-cache.h: Adjust extern decls to match.
6738 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6739 EMACS_INT, since either will do, for xpalloc.
6741 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6742 (xnmalloc, xnrealloc, xpalloc): New functions.
6744 * bidi.c (bidi_shelve_header_size): New constant.
6745 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6746 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6748 * bidi.c (bidi_cache_shrink):
6749 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6751 Don't update size of array until after memory allocation succeeds,
6752 because xmalloc/xrealloc may not return.
6753 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6754 now that we have proper integer overflow checking.
6755 (record_overlay_string, overlay_strings): Catch overflows when
6756 calculating size of overlay_str_buf.
6758 * callproc.c (Fcall_process): Check for size overflow when
6759 calculating size of args2.
6760 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6761 Normally we prefer signed values, but sticking with ptrdiff_t would
6762 require adding more-complicated checks.
6764 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6765 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6766 Redo buffer-overflow calculations to avoid integer overflow.
6767 Add a FIXME comment where memory seems to be over-allocated.
6769 * character.c (Fstring): Check for size-calculation overflow.
6771 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6772 unnecessary integer overflow. Check for size overflow.
6773 (encode_coding_object): Don't update size until xmalloc succeeds.
6775 * composite.c (get_composition_id): Check for overflow in glyph
6776 length calculations.
6778 Integer and memory overflow fixes for display code.
6779 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6780 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6781 (scrolling_window): Check for overflow in size calculations.
6782 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6783 Don't assume glyph table len fits in int.
6784 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6785 (row_table_size): Now ptrdiff_t, not int.
6786 (scrolling_window): Avoid overflow in size calculations.
6787 Don't update size until allocation succeeds.
6788 * fns.c (concat): Check for overflow in size calculations.
6789 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6790 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6791 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6793 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6794 (get_doc_string): Check for size calculation overflow.
6795 Don't update size until allocation succeeds.
6796 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6797 EMACS_INT, where ptrdiff_t will do.
6798 (Fsubstitute_command_keys): Check for string overflow.
6800 * editfns.c (set_time_zone_rule): Don't assume environment length
6802 (message_length): Now ptrdiff_t, not int.
6803 (Fmessage_box): Don't update size until allocation succeeds.
6804 Don't assume message length fits in int.
6805 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6807 * emacs.c (main): Do not reallocate argv, since there is a null at
6808 the end that can be overwritten, and this way there's no need to
6809 worry about size-calculation overflow.
6810 (sort_args): Check for size-calculation overflow.
6812 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6814 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6816 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6817 (x_set_scroll_bar_width, x_figure_window_size):
6818 Check for integer overflow.
6819 (x_set_alpha): Do not assume XINT fits in int.
6821 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6822 This is for the members text_lines, text_cols, total_lines, total_cols,
6823 where the system imposes an 'int' limit.
6825 * fringe.c (Fdefine_fringe_bitmap):
6826 Don't update size until alloc works.
6828 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6829 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6831 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6832 Check for size-calculation overflow.
6833 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6834 do, as we prefer signed integers.
6835 (id_to_widget.max_size, id_to_widget.used)
6836 (xg_store_widget_in_map, xg_remove_widget_from_map)
6837 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6838 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6839 Use and return ptrdiff_t, not int.
6840 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6841 * gtkutil.h: Change prototypes to match the above.
6843 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6844 are duplicate now that they've been promoted to lisp.h.
6845 (x_allocate_bitmap_record, x_alloc_image_color)
6846 (make_image_cache, cache_image, xpm_load):
6847 Don't update size until alloc is done.
6848 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6850 Check for size calculation overflow.
6851 (ct_colors_allocated_max): New constant.
6852 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6855 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6856 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6857 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6858 Use ptrdiff_t, not int, to count maps.
6859 (read_char_minibuf_menu_prompt): Check for overflow in size
6860 calculations. Don't update size until allocation succeeds.
6861 Redo calculations to avoid overflow.
6862 * keyboard.h: Change prototypes to match the above.
6864 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6866 (current_minor_maps): Check for size calculation overflow.
6867 * keymap.h: Change prototypes to match the above.
6869 * lread.c (read1, init_obarray): Don't update size until alloc done.
6871 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6872 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6874 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6875 Now ptrdiff_t, not int.
6876 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6877 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6879 * process.c (Fnetwork_interface_list): Check for overflow
6880 in size calculation.
6882 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6884 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6885 overflow. Don't bother calling xmalloc when xrealloc will do.
6887 * search.c (Freplace_match): Check for size calculation overflow.
6888 (Fset_match_data): Don't assume list lengths fit in 'int'.
6890 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6891 for command line length. Do not attempt to address one before the
6892 beginning of an array, as that's not portable.
6894 * term.c (max_frame_lines): Remove; unused.
6895 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6897 (encode_terminal_code, calculate_costs): Check for size
6898 calculation overflow.
6899 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6900 table lengths and related sizes. Don't update size until alloc
6901 done. Redo calculations to avoid overflow.
6902 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6904 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6905 subtracting pointers.
6906 (gobble_line): Check for overflow more carefully. Don't update size
6909 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6910 Don't update size until alloc done.
6911 Redo size calculations to avoid overflow.
6912 Check for size calculation overflow.
6913 (main) [DEBUG]: Fix typo in invoking tparam1.
6915 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6916 Use ptrdiff_t, not int, for sizes.
6917 (store_mode_line_noprop_char): Don't update size until alloc done.
6919 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6920 Use ptrdiff_t, not int, for sizes.
6921 (Finternal_make_lisp_face, cache_face):
6922 Check for size calculation overflow.
6923 (cache_face): Treat size calculation overflows as if they were
6924 memory exhaustion (the usual treatment), rather than aborting.
6926 * xfns.c (x_encode_text, x_set_name_internal)
6927 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6928 sizes, since they can exceed INT_MAX in size. Check for size
6929 calculation overflow.
6931 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6932 (xg_select): Check for size calculation overflow.
6933 Don't update size until alloc done.
6935 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6936 as sprintf is limited to int lengths.
6938 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6939 (X_LONG_MIN): New macros.
6940 Use them to make the following changes clearer.
6941 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6942 This change doesn't affect the value now, but it may help remind
6943 future maintainers not to raise the value too much later.
6944 (SELECTION_QUANTUM): Remove, replacing with ...
6945 (selection_quantum): ... new function, which avoids overflow.
6947 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6948 assumption that selection length fits in 'int'.
6949 (x_reply_selection_request, x_handle_selection_request)
6950 (x_get_window_property, receive_incremental_selection)
6951 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6952 (lisp_data_to_selection_data, clean_local_selection_data):
6953 Use ptrdiff_t, not int, to record length of selection.
6954 (x_reply_selection_request, x_get_window_property)
6955 (receive_incremental_selection, x_property_data_to_lisp):
6956 Redo calculations to avoid overflow.
6957 (x_reply_selection_request): When sending hint, ceiling it at
6958 X_LONG_MAX rather than relying on wraparound overflow to send
6960 (x_get_window_property, receive_incremental_selection)
6961 (lisp_data_to_selection_data, x_property_data_to_lisp):
6962 Check for size-calculation overflow.
6963 (x_get_window_property, receive_incremental_selection)
6964 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6965 Don't store size until memory allocation succeeds.
6966 (x_get_window_property): Plug memory leak on memory exhaustion.
6967 Don't double-block input; malloc is safe here. Don't assume 2**34
6968 - 4 fits in unsigned long. Add an xassert to check
6969 XGetWindowProperty overflow. Be more careful about overflow
6970 calculations, and distinguish size from memory overflow better.
6971 (receive_incremental_selection): When tracing, don't assume
6972 unsigned int is less than INT_MAX.
6973 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6974 harmful) conversions of unsigned short to int.
6975 (lisp_data_to_selection_data): Don't assume that integers
6976 in the range -65535 through -1 fit in an X unsigned short.
6977 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6978 result parameters unless successful. Rely on cons_to_unsigned
6979 to report problems with elements; the old code wasn't right anyway.
6980 (x_check_property_data): Check for int overflow; we cannot use
6981 a wider type due to X limits.
6982 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6984 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6986 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6987 (x_term_init): Check for size calculation overflow.
6988 (x_color_cells): Don't store size until memory allocation succeeds.
6989 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6990 Don't assume alloca size is less than MAX_ALLOCA.
6991 (x_term_init): Don't assume length fits in int (sprintf is limited
6994 Use ptrdiff_t for composition IDs.
6995 * character.c (lisp_string_width):
6996 * composite.c (composition_table_size, n_compositions)
6997 (get_composition_id, composition_gstring_from_id):
6998 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6999 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7000 * window.c (Frecenter):
7001 Use ptrdiff_t, not int, for composition IDs.
7002 * composite.c (get_composition_id): Check for integer overflow.
7003 * composite.h: Adjust prototypes to match the above changes.
7005 Use ptrdiff_t for hash table indexes.
7006 * category.c (hash_get_category_set):
7007 * ccl.c (ccl_driver):
7008 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7009 * coding.c (coding_system_charset_list, detect_coding_system):
7010 * coding.h (struct coding_system.id):
7011 * composite.c (get_composition_id, gstring_lookup_cache):
7012 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7013 * image.c (xpm_get_color_table_h):
7014 * lisp.h (hash_lookup, hash_put):
7015 * minibuf.c (Ftest_completion):
7016 Use ptrdiff_t for hash table indexes, not int (which is too
7017 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7018 32-bit --with-wide-int hosts).
7020 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7021 Add a FIXME comment about memory leaks.
7022 (syms_of_charset): Don't assume xmalloc returns.
7024 Don't assume that stated character widths fit in int.
7025 * character.c (Fchar_width, c_string_width, lisp_string_width):
7026 * character.h (CHAR_WIDTH):
7027 * indent.c (MULTIBYTE_BYTES_WIDTH):
7028 Use sanitize_char_width to avoid undefined and/or bad behavior
7029 with outlandish widths.
7030 * character.h (sanitize_tab_width): Rename from sanitize_width,
7031 now that we have two such functions. All uses changed.
7032 (sanitize_char_width): New inline function.
7034 Don't assume that tab-width fits in int.
7035 * character.h (sanitize_width): New inline function.
7036 (SANE_TAB_WIDTH): New macro.
7037 (ASCII_CHAR_WIDTH): Use it.
7038 * indent.c (sane_tab_width): Remove. All uses replaced by
7039 SANE_TAB_WIDTH (current_buffer).
7040 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7042 * fileio.c: Integer overflow issues with file modes.
7043 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7045 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7046 Remove unreachable code.
7047 (read_hex, load_charset_map_from_file): Check for integer overflow.
7049 * xterm.c: Don't go over XClientMessageEvent limit.
7050 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7051 (x_send_scroll_bar_event): Likewise. Check that the size does not
7052 exceed limits imposed by XClientMessageEvent, as well as the usual
7053 ptrdiff_t and size_t limits.
7055 * keyboard.c: Overflow, signedness and related fixes.
7056 (make_lispy_movement): Use same integer type in forward decl
7057 that is used in the definition.
7058 (read_key_sequence, keyremap_step):
7059 Change bufsize argument back to int, undoing my 2011-03-30 change.
7060 We prefer signed types, and int is wide enough here.
7061 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7062 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7063 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7064 length, not size_t. Use ptrdiff_t for index, not int.
7065 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7066 possibility of integer overflow.
7068 Overflow, signedness and related fixes for images.
7070 * dispextern.h (struct it.stack[0].u.image.image_id)
7071 (struct_it.image_id, struct image.id, struct image_cache.size)
7072 (struct image_cache.used, struct image_cache.ref_count):
7073 * gtkutil.c (update_frame_tool_bar):
7074 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7075 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7076 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7077 * nsmenu.m (update_frame_tool_bar):
7078 * xdisp.c (calc_pixel_width_or_height):
7079 * xfns.c (image_cache_refcount):
7080 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7081 on typical 64-bit hosts.
7083 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7084 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7085 Omit unnecessary casts to int.
7086 (parse_image_spec): Check that integers fall into 'int' range
7087 when the callers expect that.
7088 (image_ascent): Redo ascent calculation to avoid int overflow.
7089 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7090 (lookup_image): Remove unnecessary tests.
7091 (xbm_image_p): Locals are now of int, not EMACS_INT,
7092 since parse_image_check makes sure they fit into int.
7093 (png_load, gif_load, svg_load_image):
7094 Prefer int to unsigned where either will do.
7095 (tiff_handler): New function, combining the cores of the
7096 old tiff_error_handler and tiff_warning_handler.
7097 This function is rewritten to use vsnprintf and thereby avoid
7098 stack buffer overflows. It uses only the features of vsnprintf
7099 that are common to both POSIX and native Microsoft.
7100 (tiff_error_handler, tiff_warning_handler): Use it.
7101 (tiff_load, gif_load, imagemagick_load_image):
7102 Don't assume :index value fits in 'int'.
7103 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7104 (imagemagick_load_image): Check that crop parameters fit into
7105 the integer types that MagickCropImage accepts. Don't assume
7106 Vimagemagick_render_type has a nonnegative value. Don't assume
7107 size_t fits in 'long'.
7108 (gs_load): Use printmax_t to print the widest integers possible.
7109 Check for integer overflow when computing image height and width.
7111 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7113 * xdisp.c (redisplay_window): Don't force window start if point
7114 will be invisible in the resulting window. (Bug#9324)
7116 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7118 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7119 the display spec is of the form `(space ...)'.
7120 (handle_display_spec): Return the value returned by
7121 handle_single_display_spec, not just 1 or zero.
7122 (handle_single_display_spec): If the display spec is of the form
7123 `(space ...)', and specifies display in the text area, return 2
7125 (try_cursor_movement): Check for the need to scroll more
7126 accurately, and prefer exact match for point under bidi.
7127 Don't advance `row' beyond the last row of the window.
7129 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7130 into disp_prop; all users changed.
7132 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7133 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7134 for the text covered by the display property.
7136 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7138 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7139 Change return value to nil.
7140 (Frecord_buffer): Delete unused function.
7142 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7144 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7145 buffers, return left-to-right.
7146 (set_cursor_from_row): Consider candidate row a win if its glyph
7147 represents a newline and point is on that newline. Fixes cursor
7148 positioning on the newline at EOL of R2L text within L2R
7149 paragraph, and vice versa.
7150 (try_cursor_movement): Check continued rows, in addition to
7151 continuation rows. Fixes unwarranted scroll when point enters a
7152 continued line of R2L text within an L2R paragraph, or vice versa.
7153 (cursor_row_p): Consider the case of point being equal to
7154 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7155 from the end of a short line to the beginning of a continued line
7156 of R2L text within L2R paragraph.
7157 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7158 composed characters.
7160 * bidi.c (bidi_check_type): Use xassert.
7161 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7164 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7166 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7169 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7171 * nsfont.m (ns_otf_to_script): Fix typo.
7173 2011-08-22 Kenichi Handa <handa@m17n.org>
7175 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7176 extra slot even if the purpose is char-code-property-table.
7178 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7180 * xdisp.c (redisplay_window): When computing centering_position,
7181 account for the height of the header line. (Bug#8874)
7183 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7184 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7185 candidate is selected by the mouse, and that candidate has a
7186 composed character under the mouse.
7188 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7189 coordinates reported by pos-visible-in-window-p for a composed
7190 character in column zero.
7192 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7194 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7196 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7198 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7199 consider it a hit if to_charpos is anywhere in the range of the
7200 composed buffer positions.
7202 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7204 * image.c (gif_load): Don't assume that each subimage has the same
7205 dimensions as the base image. Handle disposal method that is
7206 "undefined" by the gif spec (Bug#9335).
7208 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7210 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7211 (Fcondition_case): Document `debug' symbol in error handler.
7213 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7215 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7216 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7217 from an Org mode buffer to a Speedbar frame.
7219 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7220 a composition, take its buffer position from IT->cmp_it.charpos.
7221 Fixes cursor positioning at the beginning of a line that begins
7222 with a composed character.
7224 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7226 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7227 character bidirectional type, use STRONG_L instead. Fixes crashes
7228 in a buffer produced by `describe-categories'.
7230 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7231 members before the level stack, so they would be saved and
7232 restored when copying iterator state. Fixes incorrect reordering
7233 around TABs covered by display properties.
7235 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7237 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7239 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7241 * eval.c (internal_condition_case, internal_condition_case_1)
7242 (internal_condition_case_2, internal_condition_case_n):
7243 Remove unnecessary aborts (Bug#9081).
7245 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7247 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7248 has no `load' handler, try opening the file locally. (Bug#9311)
7250 2011-08-16 Ken Brown <kbrown@cornell.edu>
7252 * gmalloc.c: Expand comment.
7254 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7256 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7257 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7259 2011-08-16 Ken Brown <kbrown@cornell.edu>
7261 Fix memory allocation problems in Cygwin build (Bug#9273).
7263 * unexcw.c ( __malloc_initialized): Declare external variable.
7264 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7266 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7268 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7270 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7272 [CYGWIN] (special_realloc): New function.
7273 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7274 requests to realloc storage in the static heap.
7276 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7278 * bidi.c (bidi_initialize): Remove unused local.
7280 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7283 * biditype.h: Remove file.
7284 * makefile.w32-in ($(BLD)/bidi.$(O)):
7285 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7287 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7289 * chartab.c: Improve commentary for the uniprop_table API.
7291 * bidi.c (bidi_paragraph_init): Support zero value of
7292 bidi_ignore_explicit_marks_for_paragraph_level.
7293 (bidi_initialize): Use uniprop_table instead of including
7294 biditype.h and bidimirror.h.
7296 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7297 coordinates of the iterator when restoring from ppos_it.
7300 2011-08-14 Kenichi Handa <handa@m17n.org>
7302 * process.c (create_process): Call setup_process_coding_systems
7303 after the pid of the process is set to -1 (Bug#8162).
7305 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7307 * xdisp.c (move_it_in_display_line_to): Don't invoke
7308 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7309 ppos_it. Fixes vertical cursor motion when line beginning is
7310 covered by an image. (Bug#9296)
7312 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7314 * nsterm.h (ns_run_ascript): Declare.
7315 (NSAPP_DATA2_RUNASSCRIPT): Define.
7317 * nsfns.m (as_script, as_result, as_status): New static variables.
7318 (ns_run_ascript): New function.
7319 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7320 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7321 the event loop. Get status from as_status (Bug#7276).
7323 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7324 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7325 the event loop (Bug#7276).
7327 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7329 * gnutls.c (QCgnutls_bootprop_priority)
7330 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7331 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7332 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7333 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7334 (QCgnutls_bootprop_verify_hostname_error)
7335 (QCgnutls_bootprop_callbacks_verify): Rename from
7336 Qgnutls_bootprop_..., all uses changed.
7338 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7341 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7343 * xfaces.c (Qframe_set_background_mode): Now static.
7344 * dispextern.h (Qframe_set_background_mode): Remove decl.
7346 * process.c (Fnetwork_interface_info): Declare local only if needed.
7348 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7350 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7351 (Fnetwork_interface_list): Allocate in increments of bytes instead
7352 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7353 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7355 (struct ifflag_def): notrailers is smart on OSX.
7356 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7357 Get hardware address with getifaddrs if available.
7359 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7361 * xdisp.c (iterate_out_of_display_property): xassert that
7362 IT->position is set to within IT->object's boundaries. Break from
7363 the loop as soon as EOB is reached; avoids infloops in redisplay
7364 when IT->position is set up wrongly due to some bug.
7365 Set IT->current to match the bidi iterator unconditionally.
7366 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7367 entry. Force push_it to save on the stack the current
7368 buffer/string position, to be restored by pop_it. Fix flags in
7369 the iterator structure wrt the object coming from a display
7370 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7371 properties. (Bug#9284)
7373 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7375 * fontset.c (fontset_get_font_group): Add proper type checks.
7378 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7380 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7381 and LC_VERSION_MIN_MACOSX.
7382 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7383 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7385 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7387 * xdisp.c (forward_to_next_line_start): Allow to use the
7388 no-display-properties-and-no-overlays under bidi display.
7389 Set disp_pos in the bidi iterator to avoid searches for display
7390 properties and overlays.
7392 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7394 * editfns.c (Fset_time_zone_rule): Document relationship with the
7397 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7398 the font entity extracted from the cache (Bug#8109).
7400 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7402 * composite.c (autocmp_chars): Don't reset point. That is done by
7403 restore_point_unwind (Bug#5984).
7405 2011-08-07 Juri Linkov <juri@jurta.org>
7407 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7408 to show the arg `TIME' instead of `TIMEVAL'.
7410 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7412 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7413 display property strides EOL and includes a newline, as in
7414 longlines-mode. (Bug#9254)
7415 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7416 word-wrap under bidirectional display. (Bug#9224)
7418 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7419 is non-zero, even if the data buffer is NULL. Fixes a crash in
7420 vertical-motion with longlines-mode. (Bug#9254)
7422 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7424 * bidi.c <bidi_cache_total_alloc>: Now static.
7425 (bidi_initialize): Initialize bidi_cache_total_alloc.
7427 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7430 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7431 amount allocated this far in `bidi_cache_total_alloc'.
7432 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7433 non-zero, only free the data buffer without restoring the cache
7434 contents. All callers changed.
7436 * dispextern.h (bidi_unshelve_cache): Update prototype.
7438 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7439 (move_it_in_display_line, move_it_to)
7440 (move_it_vertically_backward, move_it_by_lines): Replace the call
7441 to xfree to an equivalent call to bidi_unshelve_cache.
7442 (move_it_in_display_line_to): Fix logic of returning
7443 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7445 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7447 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7448 came from a string character with a `cursor' property. (Bug#9229)
7450 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7452 * Makefile.in (LIB_PTHREAD): New variable.
7453 (LIBES): Add LIB_PTHREAD (Bug#9216).
7455 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7456 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7458 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7460 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7462 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7464 * xterm.c (x_find_topmost_parent): New function.
7465 (x_set_frame_alpha): Find topmost parent window with
7466 x_find_topmost_parent and set the property there also (bug#9181).
7467 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7469 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7471 * callproc.c (Fcall_process): Avoid vfork clobbering
7472 the local vars buffer, coding_systems, current_dir.
7474 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7476 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7478 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7480 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7481 so that it is not optimized away.
7483 * xdisp.c (compute_display_string_pos): Remove unused local.
7485 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7487 Fix slow cursor motion and scrolling in large buffers with
7488 selective display, like Org Mode buffers. (Bug#9218)
7490 * dispextern.h (struct bidi_it): New member disp_prop_p.
7492 * xdisp.c: Remove one-slot cache of display string positions.
7493 (compute_display_string_pos): Accept an additional argument
7494 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7495 for a display string or property. If found, set DISP_PROP_P
7498 * bidi.c (bidi_fetch_char): Accept an additional argument
7499 DISP_PROP_P, and pass it to compute_display_string_pos.
7500 Only handle text covered by a display string if DISP_PROP_P is returned
7501 non-zero. All callers of bidi_fetch_char changed.
7503 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7505 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7507 2010-12-03 Don March <don@ohspite.net>
7509 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7510 last character M-[char] is translated to ESC [char] (bug#7541).
7512 2011-08-02 Kenichi Handa <handa@m17n.org>
7514 * lisp.h (uniprop_table): Extern it.
7516 * chartab.c (uniprop_table): Make it non-static.
7518 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7520 * xdisp.c (forward_to_next_line_start): Accept additional argument
7521 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7523 (reseat_at_next_visible_line_start): Use the bidi iterator state
7524 returned by forward_to_next_line_start to restore the state of
7525 it->bidi_it after backing up to previous newline. (Bug#9212)
7527 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7529 * regex.c (re_comp): Protoize.
7530 (re_exec): Fix return type.
7531 (regexec): Fix type of `ret'. (Bug#9203)
7533 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7535 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7536 This is needed if max-image-size is a floating-point number.
7538 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7540 * print.c (print_object): Print empty symbol as ##.
7542 * lread.c (read1): Read ## as empty symbol.
7544 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7546 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7547 setting frame foreground color (Bug#9175).
7548 (x_set_background_color): Likewise.
7550 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7551 contents (Bug#9176).
7552 (EmacsTooltip -init): Remove bezels and add shadows to
7555 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7556 or scroll bar (Bug#8470).
7558 * nsfont.m (nsfont_open): Remove assignment to voffset and
7559 unnecessary vars hshink, expand, hd, full_height, min_height.
7560 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7562 * nsterm.h (nsfont_info): Remove voffset field.
7564 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7566 Implement strike-through and overline on NextStep (Bug#8863).
7568 * nsfont.m (nsfont_open): Use underline position provided by font,
7569 instead of hard-coded value of 2.
7570 (nsfont_draw): Call ns_draw_text_decoration instead.
7572 * nsterm.h: Add declaration for ns_draw_text_decoration.
7574 * nsterm.m (ns_draw_text_decoration): New function for drawing
7575 underline, overline, and strike-through.
7576 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7577 ns_draw_text_decoration. Change treatment of cursor drawing to
7578 accommodate underlining, etc.
7580 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7582 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7585 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7587 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7588 Without this fix, if a signal arrives just after memory fills up,
7589 'malloc' might be invoked reentrantly.
7591 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7592 In other words, assume that every image size is allowed, on non-X
7593 hosts. This assumption is probably wrong, but it lets Emacs compile.
7595 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7597 * regex.c (re_iswctype): Convert return values to boolean.
7599 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7601 * xdisp.c (compute_display_string_pos): Don't use cached display
7602 string position if the buffer had its restriction changed.
7605 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7607 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7609 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7611 Integer signedness and overflow and related fixes. (Bug#9079)
7613 * bidi.c: Integer size and overflow fixes.
7614 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7615 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7616 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7617 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7618 (bidi_find_other_level_edge):
7619 Use ptrdiff_t instead of EMACS_INT where either will do.
7620 This works better on 32-bit hosts configured --with-wide-int.
7621 (bidi_cache_ensure_space): Check for size-calculation overflow.
7622 Use % rather than repeated addition, for better worst-case speed.
7623 Don't set bidi_cache_size until after xrealloc returns, because it
7625 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7626 (bidi_cache_ensure_space): Also check that the bidi cache size
7627 does not exceed that of the largest Lisp string or buffer. See Eli
7628 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7630 * alloc.c (__malloc_size_t): Remove.
7631 All uses replaced by size_t. See Andreas Schwab's note
7632 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7634 * image.c: Improve checking for integer overflow.
7635 (check_image_size): Assume that f is nonnull, since
7636 it is always nonnull in practice. This is one less thing to
7637 worry about when checking for integer overflow later.
7638 (x_check_image_size): New function, which checks for integer
7639 overflow issues inside X.
7640 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7641 This removes the need for a memory_full check.
7642 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7643 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7644 (xbm_read_bitmap_data): Change locals back to 'int', since
7645 their values must fit in 'int'.
7646 (xpm_load_image, png_load, tiff_load):
7647 Invoke x_create_x_image_and_pixmap earlier,
7648 to avoid much needless work if the image is too large.
7649 (tiff_load): Treat overly large images as if
7650 x_create_x_image_and_pixmap failed, not as malloc failures.
7651 (gs_load): Use x_check_image_size.
7653 * gtkutil.c: Omit integer casts.
7654 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7655 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7657 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7659 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7660 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7661 would wrongly return t on a 64-bit host.
7663 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7664 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7665 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7666 and therefore cause GCC to emit a bogus diagnostic in some cases.
7668 * image.c: Integer signedness and overflow and related fixes.
7669 This is not an exhaustive set of fixes, but it's time to
7670 record what I've got.
7671 (lookup_pixel_color, check_image_size): Remove redundant decls.
7672 (check_image_size): Don't assume that arbitrary EMACS_INT values
7673 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7674 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7675 (tiff_load, imagemagick_load_image):
7676 Check for overflow in size calculations.
7677 (x_create_x_image_and_pixmap): Remove unnecessary test for
7678 xmalloc returning NULL; that can't happen.
7679 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7680 (xpm_color_bucket): Use better integer hashing function.
7681 (xpm_cache_color): Don't possibly over-allocate memory.
7682 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7683 (gif_memory_source):
7684 Use ptrdiff_t, not int or size_t, to record sizes.
7685 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7686 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7687 either works, as we prefer signed integers.
7688 (tiff_read_from_memory, tiff_write_from_memory):
7689 Return tsize_t, not size_t, since that's what the TIFF API wants.
7690 (tiff_read_from_memory): Don't fail simply because the read would
7691 go past EOF; instead, return a short read.
7692 (tiff_load): Omit no-longer-needed casts.
7693 (Fimagemagick_types): Don't assume size fits into 'int'.
7695 Improve hashing quality when configured --with-wide-int.
7696 * fns.c (hash_string): New function, taken from sxhash_string.
7697 Do not discard information about ASCII character case; this
7698 discarding is no longer needed.
7699 (sxhash-string): Use it. Change sig to match it. Caller changed.
7700 * lisp.h: Declare it.
7701 * lread.c (hash_string): Remove, since we now use fns.c's version.
7702 The fns.c version returns a wider integer if --with-wide-int is
7703 specified, so this should help the quality of the hashing a bit.
7705 * emacs.c: Integer overflow minor fix.
7706 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7707 Define only if GNU_LINUX.
7708 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7710 * dispnew.c: Integer signedness and overflow fixes.
7711 Remove unnecessary forward decls, that were a maintenance hassle.
7712 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7714 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7715 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7716 (prepare_desired_row, line_draw_cost):
7717 Use int, not unsigned, where either works.
7718 (save_current_matrix, restore_current_matrix):
7719 Use ptrdiff_t, not size_t, where either works.
7720 (init_display): Check for overflow more accurately, and without
7721 relying on undefined behavior.
7723 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7724 Remove, replacing with the new symbols in lisp.h. All uses changed.
7725 * fileio.c (make_temp_name):
7726 * filelock.c (lock_file_1, lock_file):
7727 * xdisp.c (message_dolog):
7728 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7729 Use pMd etc. instead.
7730 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7731 replacing the pWIDE etc. symbols removed from editfns.c.
7733 * keyboard.h (num_input_events): Now uintmax_t.
7734 This is (very slightly) less likely to mess up due to wraparound.
7737 * buffer.c: Integer signedness fixes.
7738 (alloc_buffer_text, enlarge_buffer_text):
7739 Use ptrdiff_t rather than size_t when either will do, as we prefer
7742 * alloc.c: Integer signedness and overflow fixes.
7743 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7744 (__malloc_size_t): Default to size_t, not to int.
7745 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7746 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7747 Prefer ptrdiff_t to size_t when either would do, as we prefer
7749 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7750 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7751 Now const. Initialize with values that are in range even if char
7753 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7754 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7755 These functions do the right thing with sizes > 2**32.
7756 (check_depth): Now ptrdiff_t, not int.
7757 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7758 Adjust to new way of storing sizes. Check for size overflow bugs
7760 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7761 slightly wrong anyway, as it missed one instance of
7762 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7763 (refill_memory_reserve): Omit needless cast to size_t.
7764 (mark_object_loop_halt): Mark as externally visible.
7766 * xselect.c: Integer signedness and overflow fixes.
7767 (Fx_register_dnd_atom, x_handle_dnd_message):
7768 Use ptrdiff_t, not size_t, since we prefer signed.
7769 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7770 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7771 x_dnd_atoms_size and x_dnd_atoms_length.
7773 * doprnt.c: Prefer signed to unsigned when either works.
7775 * doprnt.c (doprnt):
7777 * xdisp.c (vmessage):
7778 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7779 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7780 prefer signed arithmetic to avoid comparison confusion.
7781 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7782 but is a bit tricky.
7784 Assume freestanding C89 headers, string.h, stdlib.h.
7785 * data.c, doprnt.c, floatfns.c, print.c:
7786 Include float.h unconditionally.
7787 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7788 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7789 * regex.c: Likewise for stddef.h, string.h.
7790 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7791 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7792 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7793 (STDC_HEADERS): Remove obsolete defines.
7794 * sysdep.c: Include limits.h unconditionally.
7796 Assume support for memcmp, memcpy, memmove, memset.
7797 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7798 * regex.c (memcmp, memcpy):
7799 Remove; we assume C89 now.
7801 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7802 (__malloc_safe_bcopy): Remove; no longer needed.
7804 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7805 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7806 well either way, and we prefer signed to unsigned.
7808 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7810 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7811 closes the connection while we're reading (bug#9182).
7813 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7815 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7816 are specified (Bug#9168).
7818 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7820 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7821 Found by GCC static checking and --with-wide-int on a 32-bit host.
7823 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7825 * xdisp.c (compute_display_string_pos): Fix logic of caching
7826 previous display string position. Initialize cached_prev_pos to
7827 -1. Fixes slow-down at the beginning of a buffer.
7829 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7831 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7832 for attrs[LFACE_FONTSET_INDEX].
7834 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7836 * xml.c (parse_region): Remove unused local
7837 that was recently introduced.
7839 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7841 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7842 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7844 * xdisp.c (move_it_in_display_line_to): Record the best matching
7845 position for TO_CHARPOS while scanning the line, and restore it on
7846 exit if none of the characters scanned was an exact match.
7847 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7848 when exact match is impossible due to invisible text, and the
7849 lines are truncated.
7851 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7853 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7856 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7858 Fix a significant slow-down of cursor motion with C-n, C-p,
7859 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7860 auto-repeat under bidi redisplay in fontified buffers.
7861 * xdisp.c (compute_stop_pos_backwards): New function.
7862 (next_element_from_buffer): Call compute_stop_pos_backwards to
7863 find a suitable prev_stop when we find ourselves before
7865 (reseat): Don't look for prev_stop, as that could mean a very long
7867 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7868 <cached_disp_overlay_modiff>: Cache for last found display string
7870 (compute_display_string_pos): Return the cached position if asked
7871 about the same buffer in the same area of character positions, and
7872 the buffer wasn't changed since the time the display string
7873 position was cached.
7875 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7877 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7878 is an integer, which is important for empty lines. (Bug#9149)
7880 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7882 * frame.c (Fmodify_frame_parameters): In tty case, update the
7883 default face if necessary (Bug#4238).
7885 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7887 * editfns.c (Fstring_to_char): No need to explain what a character
7888 is in the docstring (Bug#6576).
7890 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7892 * xml.c (parse_region): Make sure we always return a tree.
7894 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7896 * xml.c (parse_region): If a document contains only comments,
7899 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7901 * xml.c (make_dom): Return comments, too.
7903 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7906 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7907 and the surrounding thread.
7908 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7909 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7910 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7912 * s/openbsd.h (BROKEN_SIGIO): Define.
7913 * unexelf.c (unexec) [__OpenBSD__]:
7914 Don't update the .mdebug section of the Alpha COFF symbol table.
7916 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7918 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7921 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7923 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7924 This fixes some race conditions on the permissions of any newly
7927 * alloc.c (valid_pointer_p): Use pipe, not open.
7928 This fixes some permissions issues when debugging.
7930 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7931 If fchown fails to set both uid and gid, try to set just gid,
7932 as that is sometimes allowed. Adjust the file's mode to eliminate
7933 setuid or setgid bits that are inappropriate if fchown fails.
7935 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7937 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7938 to compare Lisp_Objects.
7939 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7940 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7941 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7943 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7945 * lread.c (read_integer): Unread even EOF character.
7946 (read1): Likewise. Properly record start position of symbol.
7948 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7949 symbol character follows.
7951 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7953 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7954 This works around a problem with the previous change to Fcopy_file.
7955 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7956 and without this change, GCC might complain about discarding
7957 fchown's return value.
7959 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7961 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7963 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7965 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7967 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7969 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7970 it's used from the C level.
7972 * process.c: Use the same condition for POLL_FOR_INPUT in both
7973 keyboard.c and process.c (bug#1858).
7975 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7977 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7978 (Fgnutls_boot): Use it.
7980 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7982 * doc.c (Fsubstitute_command_keys): Revert last change.
7984 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7986 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7987 quotes the next character, and doesn't affect other longer
7988 sequences (bug#8935).
7990 * lread.c (syms_of_lread): Clarify that is isn't only
7991 `eval-buffer' and `eval-defun' that's affected by
7992 `lexical-binding' (bug#8460).
7994 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7996 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7997 bidi redisplay when a line includes both an image and is truncated.
7999 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8001 Fix minor problems found by static checking.
8002 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8003 (elsz): Now a signed constant, not a size_t var. We prefer signed
8004 types to unsigned, to avoid integer comparison confusion. Without
8005 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8006 "cannot optimize loop, the loop counter may overflow", a symptom
8008 * indent.c (Fvertical_motion): Mark locals as initialized.
8009 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8011 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8013 * search.c (Fre_search_backward): Mention `case-fold-search' in
8014 all the re_search_* functions (bug#8138).
8016 * keyboard.c (Fopen_dribble_file): Document when the file is
8019 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8021 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8024 Support bidi reordering of display and overlay strings.
8025 * xdisp.c (compute_display_string_pos)
8026 (compute_display_string_end): Accept additional argument STRING.
8027 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8028 (reseat_to_string): Initialize bidi_it->string.s and
8029 bidi_it->string.schars.
8030 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8031 NULL (avoids a crash in bidi_paragraph_init).
8032 Initialize itb.string.lstring.
8033 (init_iterator): Call bidi_init_it only of a valid
8034 buffer position was specified. Initialize paragraph_embedding to
8036 (reseat_to_string): Initialize the bidi iterator.
8037 (display_string): If we need to ignore text properties of
8038 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8039 original value of -1 will not work with bidi.)
8040 (compute_display_string_pos): First arg is now struct
8041 `text_pos *'; all callers changed. Support display properties on
8043 (compute_display_string_end): Support display properties on Lisp
8045 (init_iterator, reseat_1, reseat_to_string): Initialize the
8046 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8047 when iterating on a string not from display properties).
8048 (compute_display_string_pos, compute_display_string_end):
8049 Fix calculation of the object to scan. Fixes an error when using
8051 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8052 base_level_stop; instead, set base_level_stop to BEGV.
8053 Fixes crashes in vertical-motion.
8054 (next_element_from_buffer): Improve commentary for when
8055 the iterator is before prev_stop.
8056 (init_iterator): Initialize bidi_p from the default value of
8057 bidi-display-reordering, not from buffer-local value. Use the
8058 buffer-local value only if initializing for buffer iteration.
8059 (handle_invisible_prop): Support invisible properties on strings
8060 that are being bidi-reordered.
8061 (set_iterator_to_next): Support bidi reordering of C strings and
8063 (next_element_from_string): Support bidi reordering of Lisp
8065 (handle_stop_backwards): Support Lisp strings as well.
8066 (display_string): Support display of R2L glyph rows.
8067 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8068 (init_iterator): Don't initialize it->bidi_p for strings
8070 (reseat_to_string): Initialize it->bidi_p for strings here.
8071 (next_element_from_string, next_element_from_c_string)
8072 (next_element_from_buffer): Add xassert's for correspondence
8073 between IT's object being iterated and it->bidi_it.string
8075 (face_before_or_after_it_pos): Support bidi iteration.
8076 (next_element_from_c_string): Handle the case of the first string
8077 character that is not the first one in the visual order.
8078 (get_visually_first_element): New function, refactored from common
8079 parts of next_element_from_buffer, next_element_from_string, and
8080 next_element_from_c_string.
8081 (tool_bar_lines_needed, redisplay_tool_bar)
8082 (display_menu_bar): Force left-to-right direction. Add a FIXME
8083 comment for making that be controlled by a user option.
8084 (push_it, pop_it): Save and restore the state of the
8085 bidi iterator. Save and restore the bidi_p flag.
8086 (pop_it): Iterate out of display property for string iteration as
8088 (iterate_out_of_display_property): Support iteration over strings.
8089 (handle_single_display_spec): Set up it->bidi_it for iteration
8090 over a display string, and call bidi_init_it.
8091 (handle_single_display_spec, next_overlay_string)
8092 (get_overlay_strings_1, push_display_prop): Set up the bidi
8093 iterator for displaying display or overlay strings.
8094 (forward_to_next_line_start): Don't use the shortcut if
8096 (back_to_previous_visible_line_start): If handle_display_prop
8097 pushed the iterator stack, restore the internal state of the bidi
8098 iterator by calling bidi_pop_it same number of times.
8099 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8100 and we are bidi-iterating, don't decrement the iterator position;
8101 instead, set the first_elt flag in the bidi iterator, to produce
8103 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8104 (push_display_prop): xassert that we are iterating a buffer.
8105 (push_it, pop_it): Save and restore paragraph_embedding member.
8106 (handle_single_display_spec, next_overlay_string)
8107 (get_overlay_strings_1, reseat_1, reseat_to_string)
8108 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8109 correctly. Don't assume unibyte strings are not bidi-reordered.
8110 (compute_display_string_pos)
8111 (compute_display_string_end): Fix handling the case of C string.
8112 (push_it, pop_it): Save and restore from_disp_prop_p.
8113 (handle_single_display_spec, push_display_prop): Set the
8114 from_disp_prop_p flag.
8115 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8116 (pop_it): Call iterate_out_of_display_property only if we are
8117 popping after iteration over a string that came from a display
8118 property. Fix a typo in popping stretch info. Add an assertion
8119 for verifying that the iterator position is in sync with the bidi
8121 (handle_single_display_spec, get_overlay_strings_1)
8122 (push_display_prop): Fix initialization of paragraph direction for
8123 string when that of the parent object is not yet determined.
8124 (reseat_1): Call bidi_init_it to resync the bidi
8125 iterator with IT's position. (Bug#7616)
8126 (find_row_edges): If ROW->start.pos gives position
8127 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8128 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8129 Reset the from_disp_prop_p flag.
8130 (SAVE_IT, RESTORE_IT): New macros.
8131 (pos_visible_p, face_before_or_after_it_pos)
8132 (back_to_previous_visible_line_start)
8133 (move_it_in_display_line_to, move_it_in_display_line)
8134 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8135 (try_scrolling, redisplay_window, display_line): Use them when
8136 saving a temporary copy of the iterator and restoring it back.
8137 (back_to_previous_visible_line_start, reseat_1)
8138 (init_iterator): Empty the bidi cache "stack".
8139 (move_it_in_display_line_to): If iterator ended up at
8140 EOL, but we never saw any buffer positions smaller than
8141 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8142 motion in bidi-reordered lines.
8143 (move_it_in_display_line_to): Record prev_method and prev_pos
8144 immediately before the call to set_iterator_to_next. Fixes cursor
8145 motion in bidi-reordered lines with stretch glyphs and strings
8146 displayed in margins. (Bug#8133) (Bug#8867)
8147 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8149 (pos_visible_p): Support positions in bidi-reordered lines.
8150 Save and restore bidi cache.
8152 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8153 (bidi_paragraph_info): Delete unused struct.
8154 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8155 (bidi_cache_start): New variable.
8156 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8158 (bidi_cache_fetch_state, bidi_cache_search)
8159 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8160 (bidi_cache_find, bidi_peek_at_next_level)
8161 (bidi_level_of_next_char, bidi_find_other_level_edge)
8162 (bidi_move_to_visually_next): Compare cache index with
8163 bidi_cache_start rather than with zero.
8164 (bidi_fetch_char): Accept new argument STRING; all callers
8165 changed. Support iteration over a string. Support strings with
8166 display properties. Support unibyte strings. Fix the type of
8167 `len' according to what STRING_CHAR_AND_LENGTH expects.
8168 (bidi_paragraph_init, bidi_resolve_explicit_1)
8169 (bidi_resolve_explicit, bidi_resolve_weak)
8170 (bidi_level_of_next_char, bidi_move_to_visually_next):
8171 Support iteration over a string.
8172 (bidi_set_sor_type, bidi_resolve_explicit_1)
8173 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8174 can now be zero (for strings); special values 0 and -1 were
8175 changed to -1 and -2, respectively.
8176 (bidi_char_at_pos): New function.
8177 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8178 Call it instead of FETCH_MULTIBYTE_CHAR.
8179 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8180 initialized to valid values.
8181 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8183 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8184 the test for valid cached positions. Fix the logic for looking up
8185 the sentinel state in the cache. GCPRO the Lisp string we are
8187 (bidi_push_it, bidi_pop_it): New functions.
8188 (bidi_initialize): Initialize the bidi cache start stack pointer.
8189 (bidi_cache_ensure_space): New function, refactored from part of
8190 bidi_cache_iterator_state. Don't assume the required size is just
8191 one BIDI_CACHE_CHUNK away.
8192 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8193 (bidi_count_bytes, bidi_char_at_pos): New functions.
8194 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8195 always valid if bidi_cache_idx is valid.
8196 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8197 is valid if it's going to be used.
8198 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8199 (bidi_cache_fetch_state, bidi_cache_search)
8200 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8201 (bidi_cache_iterator_state, bidi_cache_find)
8202 (bidi_find_other_level_edge, bidi_cache_start_stack):
8203 All variables related to cache indices are now EMACS_INT.
8205 * dispextern.h (struct bidi_string_data): New structure.
8206 (struct bidi_it): New member `string'. Make flag members be 1-bit
8207 fields, and put them last in the struct.
8208 (compute_display_string_pos, compute_display_string_end):
8210 (bidi_push_it, bidi_pop_it): Add prototypes.
8211 (struct iterator_stack_entry): New members bidi_p,
8212 paragraph_embedding, and from_disp_prop_p.
8213 (struct it): Member bidi_p is now a bit field 1 bit wide.
8214 (bidi_shelve_cache, bidi_unshelve_cache):
8217 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8218 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8219 and vector-like objects.
8221 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8222 cache around display iteration.
8224 * window.c (Fwindow_end, window_scroll_pixel_based)
8225 (displayed_window_lines, Frecenter): Save and restore the bidi
8226 cache around display iteration.
8228 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8230 * editfns.c (Fdelete_region): Clarify the use of the named
8231 parameters (bug#6788).
8233 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8235 * indent.c (Fvertical_motion): Set and restore w->pointm when
8236 saving and restoring the window's buffer (Bug#9006).
8238 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8240 * editfns.c (Fstring_to_char): Clarify just what is returned
8241 (bug#6576). Text by Eli Zaretskii.
8243 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8245 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8247 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8249 * buffer.c (mmap_find): Fix a typo.
8251 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8253 Fix execution of x selection hooks.
8254 * xselect.c (Qx_lost_selection_functions)
8255 (Qx_sent_selection_functions): New vars.
8256 (syms_of_xselect): DEFSYM them.
8257 (x_handle_selection_request): Pass Qx_sent_selection_functions
8258 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8259 (x_handle_selection_clear,x_clear_frame_selections):
8260 Pass Qx_lost_selection_functions rather than
8261 Vx_lost_selection_functions to Frun_hook_with_args.
8263 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8265 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8266 The old code sometimes used this field without initializing it.
8268 * alloc.c (gc_sweep): Don't read past end of array.
8269 In theory, the old code could also have corrupted Emacs internals,
8270 though it'd be very unlikely.
8272 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8274 * character.c (Fcharacterp): Don't advertise optional ignored
8275 argument. (Bug#4026)
8277 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8279 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8282 * window.c (Fset_window_start): Doc fix (bug#4199).
8283 (Fset_window_hscroll): Ditto.
8285 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8287 Fix minor new problems caught by GCC 4.6.1.
8288 * term.c (init_tty): Remove unused local.
8289 * xsettings.c (store_monospaced_changed): Define this function only
8290 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8293 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8295 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8297 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8299 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8300 are the mini-buffer and the echo area (bug#3320).
8302 * term.c (init_tty): Remove support for supdup, c10 and perq
8303 terminals, which are no longer supported (bug#1482).
8305 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8307 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8309 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8311 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8312 for non-popups (Bug#3642).
8314 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8316 * alloc.c (reset_malloc_hooks): Protoize.
8317 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8318 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8319 * cm.c (losecursor): Likewise.
8320 * data.c (fmod): Likewise.
8321 * dispnew.c (swap_glyphs_in_rows): Likewise.
8322 * emacs.c (memory_warning_signal): Likewise.
8323 * floatfns.c (float_error): Likewise.
8324 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8325 (otf_open, font_otf_capability, generate_otf_features)
8326 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8328 * image.c (pbm_read_file): Likewise.
8329 * indent.c (string_display_width): Likewise.
8330 * intervals.c (check_for_interval, search_for_interval)
8331 (inc_interval_count, count_intervals, root_interval)
8332 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8333 * lread.c (defalias): Likewise.
8334 * ralloc.c (r_alloc_check): Likewise.
8335 * regex.c (set_image_of_range_1, set_image_of_range)
8336 (regex_grow_registers): Likewise.
8337 * sysdep.c (strerror): Likewise.
8338 * termcap.c (valid_filename_p, tprint, main): Likewise.
8339 * tparam.c (main): Likewise.
8340 * unexhp9k800.c (run_time_remap, save_data_space)
8341 (update_file_ptrs, read_header, write_header, calculate_checksum)
8342 (copy_file, copy_rest, display_header): Likewise.
8343 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8345 * xdisp.c (check_it): Likewise.
8346 * xfaces.c (register_color, unregister_color, unregister_colors):
8348 * xfns.c (print_fontset_result): Likewise.
8349 * xrdb.c (member, fatal, main): Likewise.
8351 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8353 Fix minor problems found by static checking (Bug#9031).
8354 * chartab.c (char_table_set_range, map_sub_char_table):
8355 Remove unused locals.
8356 (uniprop_table): Now static.
8357 * composite.c (_work_char): Remove unused static var.
8359 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8361 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8363 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8365 * gtkutil.c (qttip_cb): Remove code without function.
8367 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8369 * w32.c (pthread_sigmask): New stub.
8371 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8373 Use pthread_sigmask, not sigprocmask (Bug#9010).
8374 sigprocmask is portable only for single-threaded applications, and
8375 Emacs can be multi-threaded when it uses GTK.
8376 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8378 * callproc.c (Fcall_process):
8379 * process.c (create_process):
8380 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8381 Use pthread_sigmask, not sigprocmask.
8383 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8385 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8386 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8389 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8391 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8392 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8393 (xg_hide_tooltip): Fix comment.
8395 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8396 in registerServicesMenuSendTypes.
8397 (validRequestorForSendType): Don't check ns_return_types.
8399 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8402 2011-07-08 Jason Rumney <jasonr@gnu.org>
8404 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8405 SH_SHOW for hidden windows (Bug#5482).
8407 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8408 frame struct members of non-existent frames (Bug#6284).
8410 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8412 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8413 variable firstTime not needed on OSX >= 10.6.
8414 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8415 >= 10.5. Use setKnobProportion, setDoubleValue.
8417 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8418 (MAC_OS_X_VERSION_10_5): Define if not defined.
8419 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8420 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8421 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8423 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8424 cString and lossyCString on OSX >= 10.4.
8426 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8427 sizeToFit on OSX >= 10.2.
8429 * nsimage.m (allocInitFromFile): Don't use deprecated method
8430 bestRepresentationForDevice on OSX >= 10.6.
8432 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8435 * emacs.c: Declare unexec_init_emacs_zone.
8437 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8439 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8441 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8442 on svcsMenu (Bug#8842).
8444 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8446 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8448 * nsterm.m (QUTF8_STRING): Declare.
8449 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8450 (validRequestorForSendType): Return type is (id).
8451 Change indexOfObjectIdenticalTo to indexOfObject.
8452 Check if we have local selection before returning self (Bug#8842).
8453 (writeSelectionToPasteboard): Put local selection into paste board
8454 if we have a local selection (Bug#8842).
8455 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8457 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8458 (ns_get_local_selection): Declare.
8460 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8462 * keymap.c (describe_map_tree): Don't insert a double newline at
8463 the end of the buffer (bug#1169) and return whether we inserted
8466 * callint.c (Fcall_interactively): Change "reading args" to
8467 "providing args" to try to clarify what it does (bug#1010).
8469 2011-07-07 Kenichi Handa <handa@m17n.org>
8471 * composite.c (composition_compute_stop_pos): Ignore a static
8472 composition starting before CHARPOS (Bug#8915).
8474 * xdisp.c (handle_composition_prop): Likewise.
8476 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8478 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8481 2011-07-07 Kenichi Handa <handa@m17n.org>
8483 * character.h (unicode_category_t): New enum type.
8485 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8486 (Qchar_code_property_table): New variable.
8487 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8488 (UNIPROP_COMPRESSED_FORM_P): New macros.
8489 (char_table_ascii): Uncompress the compressed values.
8490 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8491 Uncompress the compressed values.
8492 (sub_char_table_ref_and_range): Likewise.
8493 (char_table_ref_and_range): Uncompress the compressed values.
8494 (sub_char_table_set): New arg is_uniprop. Callers changed.
8495 Uncompress the compressed values.
8496 (sub_char_table_set_range): Args changed. Callers changed.
8497 (char_table_set_range): Adjuted for the above change.
8498 (map_sub_char_table): Delete args default_val and parent. Add arg
8499 top. Give decoded values to a Lisp function.
8500 (map_char_table): Adjust for the above change. Give decoded
8501 values to a Lisp function. Gcpro more variables.
8502 (uniprop_table_uncompress)
8503 (uniprop_decode_value_run_length): New functions.
8504 (uniprop_decoder, uniprop_decoder_count): New variables.
8505 (uniprop_get_decoder, uniprop_encode_value_character)
8506 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8508 (uniprop_encoder, uniprop_encoder_count): New variables.
8509 (uniprop_get_encoder, uniprop_table)
8510 (Funicode_property_table_internal, Fget_unicode_property_internal)
8511 (Fput_unicode_property_internal): New functions.
8512 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8513 Sunicode_property_table_internal, Sget_unicode_property_internal,
8514 and Sput_unicode_property_internal. Defvar_lisp
8515 char-code-property-alist.
8517 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8518 Vunicode_category_table.
8520 * font.c (font_range): Adjust for the change of
8521 Vunicode_category_table.
8523 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8525 * m/iris4d.h: Remove file, move contents ...
8526 * s/irix6-5.h: ... here.
8528 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8530 Remove unportable assumption about struct layout (Bug#8884).
8531 * alloc.c (mark_buffer):
8532 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8533 (clone_per_buffer_values): Don't assume that
8534 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8535 This isn't true in general, and it's particularly not true
8536 if Emacs is configured with --with-wide-int.
8537 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8538 New macros, used in the buffer.c change.
8540 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8542 * xsettings.c: Use both GConf and GSettings if both are available.
8543 (store_config_changed_event): Add comment.
8544 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8545 (store_tool_bar_style_changed): New functions.
8546 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8547 (struct xsettings): Move font inside HAVE_XFT.
8548 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8549 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8550 Move inside HAVE_XFT.
8551 (something_changed_gsettingsCB): Rename from something_changedCB.
8552 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8554 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8555 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8556 (something_changed_gconfCB): Rename from something_changedCB.
8557 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8558 (parse_settings): Move check for font inside HAVE_XFT.
8559 (read_settings, apply_xft_settings): Add comment.
8560 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8561 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8562 call store_font_name_changed.
8563 (xft_settings_event): Add comment.
8564 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8565 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8566 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8567 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8568 (xsettings_initialize): Call init_gsettings last.
8569 (xsettings_get_system_font, xsettings_get_system_normal_font):
8572 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8574 Random fixes. E.g., (random) never returned negative values.
8575 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8576 subseconds part to the entropy, as that's a bit more random.
8577 Prefer signed to unsigned, since the signedness doesn't matter and
8578 in general we prefer signed. When given a limit, use a
8579 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8580 latter isn't right if USE_2_TAGS_FOR_INTS.
8581 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8582 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8584 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8586 * textprop.c (text_property_stickiness):
8587 Obey Vtext_property_default_nonsticky.
8588 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8589 * w32fns.c (syms_of_w32fns):
8590 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8592 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8594 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8595 This is more efficient than Ffile_directory_p and avoids a minor race.
8597 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8599 * buffer.c (Foverlay_put): Say what the return value is
8602 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8603 is a directory before asking whether to use the file name
8605 (barf_or_query_if_file_exists): Make the "File is a directory"
8606 error be more correct.
8608 * fns.c (Frequire): Remove the mention of the .gz files, since
8609 that's installation-specific, but keep the mention of
8610 `get-load-suffixes'.
8612 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8614 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8615 Report string overflow if the output is too long.
8617 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8619 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8620 (syms_of_gnutls): Remove duplicate DEFSYM for
8621 Qgnutls_bootprop_verify_hostname_error, an error for
8622 Qgnutls_bootprop_verify_error (which is no longer used).
8624 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8625 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8626 Also (re)move comments that are misplaced or no longer relevant.
8628 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8630 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8632 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8634 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8635 and background color parameters if they have been changed.
8637 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8639 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8641 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8643 * xsettings.c (SYSTEM_FONT): Define only when used.
8644 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8646 * keymap.c (access_keymap_1): Now static.
8648 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8650 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8651 leave any prefix arg for the up event (Bug#1586).
8653 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8655 * lread.c (syms_of_lread): Mention single symbols defined by
8656 `defvar' or `defconst' (bug#7154).
8658 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8659 (Frequire): Mention get-load-suffixes.
8661 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8663 * window.h (window): Remove clone_number slot.
8664 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8666 (make_parent_window, make_window, saved_window)
8667 (Fset_window_configuration, save_window_save): Don't deal with
8669 * buffer.c (Qclone_number): Remove declaration.
8670 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8672 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8674 Add multiple inheritance to keymaps.
8675 * keymap.c (Fmake_composed_keymap): New function.
8676 (Fset_keymap_parent): Simplify.
8677 (fix_submap_inheritance): Remove.
8678 (access_keymap_1): New function extracted from access_keymap to handle
8679 embedded parents and handle lists of maps.
8680 (access_keymap): Use it.
8681 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8682 (Fcopy_keymap): Handle embedded parents.
8683 (Fcommand_remapping, define_as_prefix): Simplify.
8684 (Fkey_binding): Simplify.
8685 (syms_of_keymap): Move minibuffer-local-completion-map,
8686 minibuffer-local-filename-completion-map,
8687 minibuffer-local-must-match-map, and
8688 minibuffer-local-filename-must-match-map to Elisp.
8689 (syms_of_keymap): Defsubr make-composed-keymap.
8690 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8691 (parse_menu_item): Trivial simplification.
8693 2011-07-01 Glenn Morris <rgm@gnu.org>
8695 * Makefile.in (SETTINGS_LIBS): Fix typo.
8697 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8699 * coding.c (Fencode_coding_string): Record the last coding system
8700 used, as the function doc string says (bug#8738).
8702 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8704 * xsettings.c (store_monospaced_changed): Take new font as arg and
8705 check for change against current_mono_font.
8706 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8707 (emacs_settings_constructor, emacs_settings_get_property)
8708 (emacs_settings_set_property, emacs_settings_class_init)
8709 (emacs_settings_init, gsettings_obj): Remove.
8710 (something_changedCB): New function for HAVE_GSETTINGS.
8711 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8712 with value as argument.
8713 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8714 g_settings_new (Bug#8967). Do not create gsettings_obj.
8715 Remove calls to g_settings_bind. Connect something_changedCB to
8718 * xgselect.c: Add defined (HAVE_GSETTINGS).
8719 (xgselect_initialize): Ditto.
8721 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8722 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8725 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8727 * eval.c (struct backtrace): Simplify and port the data structure.
8728 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8729 signed bit field, as this assumption is not portable and it makes
8730 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8731 "char debug_on_exit : 1" as this is not portable either; instead,
8732 use the portable "unsigned int debug_on_exit : 1". Remove unused
8733 member evalargs. Remove obsolete comments about cc bombing out.
8735 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8737 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8738 Let HAVE_GSETTINGS override HAVE_GCONF.
8739 (store_monospaced_changed): New function.
8740 (EMACS_SETTINGS): A new type derived from GObject to handle
8741 GSettings notifications.
8742 (emacs_settings_constructor, emacs_settings_get_property)
8743 (emacs_settings_set_property, emacs_settings_class_init):
8745 (gsettings_client, gsettings_obj): New variables.
8746 (GSETTINGS_SCHEMA): New define.
8747 (something_changedCB): Call store_monospaced_changed.
8748 (init_gsettings): New function.
8749 (xsettings_initialize): Call init_gsettings.
8750 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8753 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8756 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8758 * window.c (resize_root_window, grow_mini_window)
8759 (shrink_mini_window): Rename Qresize_root_window to
8760 Qwindow_resize_root_window and Qresize_root_window_vertically to
8761 Qwindow_resize_root_window_vertically.
8763 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8765 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8767 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8769 * makefile.w32-in: Redesign dependencies so they reflect more
8770 clearly which files are directly included by each source file,
8771 and not through other includes.
8773 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8775 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8776 (sort_overlays, overlay_strings): When an overlay's clone number
8777 matches the window's clone number process the overlay even if
8778 the overlay's window property doesn't match the current window.
8780 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8781 (Fwindow_hchild): Rename to Fwindow_left_child.
8782 (Fwindow_next): Rename to Fwindow_next_sibling.
8783 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8784 (resize_window_check): Rename to window_resize_check.
8785 (resize_window_apply): Rename to window_resize_apply.
8786 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8787 (Fdelete_other_windows_internal, resize_frame_windows)
8788 (Fsplit_window_internal, Fdelete_window_internal)
8789 (grow_mini_window, shrink_mini_window)
8790 (Fresize_mini_window_internal): Fix callers accordingly.
8792 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8794 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8795 (emacs_fixed_set_min_size): Remove.
8796 (emacs_fixed_new): Take frame as argument.
8798 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8799 (_EmacsFixedPrivate): Remove minwidth/height.
8800 Add struct frame *f.
8801 (emacs_fixed_init): Initialize priv->f.
8802 (get_parent_class, emacs_fixed_set_min_size): Remove.
8803 (emacs_fixed_new): Set priv->f to argument.
8804 (emacs_fixed_get_preferred_width)
8805 (emacs_fixed_get_preferred_height): Use min_width/height from
8806 frames size_hint to set minimum and natural (Bug#8919).
8807 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8808 and use min_width/height from frames size_hint to set
8809 min_width/height (Bug#8919).
8811 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8812 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8815 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8817 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8818 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8821 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8823 * process.c (wait_reading_process_output): Bypass select if
8824 waiting for a cell while ignoring keyboard input, and input is
8825 pending. Suggested by Jan Djärv (Bug#8869).
8827 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8829 Use gnulib's dup2 module instead of rolling our own.
8830 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8832 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8834 * dispnew.c (scrolling_window): Before scrolling, turn off a
8835 mouse-highlight in the window being scrolled.
8837 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8839 Move DEFSYM to lisp.h and use everywhere.
8841 * character.h (DEFSYM): Move declaration...
8842 * lisp.h (DEFSYM): ...here.
8848 * w32select.c: Don't include character.h.
8850 * alloc.c (syms_of_alloc):
8851 * buffer.c (syms_of_buffer):
8852 * bytecode.c (syms_of_bytecode):
8853 * callint.c (syms_of_callint):
8854 * casefiddle.c (syms_of_casefiddle):
8855 * casetab.c (init_casetab_once):
8856 * category.c (init_category_once, syms_of_category):
8857 * ccl.c (syms_of_ccl):
8858 * cmds.c (syms_of_cmds):
8859 * composite.c (syms_of_composite):
8860 * dbusbind.c (syms_of_dbusbind):
8861 * dired.c (syms_of_dired):
8862 * dispnew.c (syms_of_display):
8863 * doc.c (syms_of_doc):
8864 * editfns.c (syms_of_editfns):
8865 * emacs.c (syms_of_emacs):
8866 * eval.c (syms_of_eval):
8867 * fileio.c (syms_of_fileio):
8868 * fns.c (syms_of_fns):
8869 * frame.c (syms_of_frame):
8870 * fringe.c (syms_of_fringe):
8871 * insdel.c (syms_of_insdel):
8872 * keymap.c (syms_of_keymap):
8873 * lread.c (init_obarray, syms_of_lread):
8874 * macros.c (syms_of_macros):
8875 * msdos.c (syms_of_msdos):
8876 * print.c (syms_of_print):
8877 * process.c (syms_of_process):
8878 * search.c (syms_of_search):
8879 * sound.c (syms_of_sound):
8880 * syntax.c (init_syntax_once, syms_of_syntax):
8881 * terminal.c (syms_of_terminal):
8882 * textprop.c (syms_of_textprop):
8883 * undo.c (syms_of_undo):
8884 * w32.c (globals_of_w32):
8885 * window.c (syms_of_window):
8886 * xdisp.c (syms_of_xdisp):
8887 * xfaces.c (syms_of_xfaces):
8888 * xfns.c (syms_of_xfns):
8889 * xmenu.c (syms_of_xmenu):
8890 * xsettings.c (syms_of_xsettings):
8891 * xterm.c (syms_of_xterm): Use DEFSYM.
8893 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8895 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8897 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8899 Integer and buffer overflow fixes (Bug#8873).
8901 * print.c (printchar, strout): Check for string overflow.
8902 (PRINTPREPARE, printchar, strout):
8903 Don't set size unless allocation succeeds.
8905 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8906 for sizes. Check for string overflow more accurately.
8907 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8909 * macros.c: Integer and buffer overflow fixes.
8910 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8911 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8912 Use ptrdiff_t, not int, for sizes.
8913 Don't increment bufsize until after realloc succeeds.
8914 Check for size-calculation overflow.
8915 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8917 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8919 * lread.c: Integer overflow fixes.
8920 (read_integer): Radix is now EMACS_INT, not int,
8921 to improve quality of diagnostics for out-of-range radices.
8922 Calculate buffer size correctly for out-of-range radices.
8923 (read1): Check for integer overflow in radices, and in
8924 read-circle numbers.
8925 (read_escape): Avoid int overflow.
8926 (Fload, openp, read_buffer_size, read1)
8927 (substitute_object_recurse, read_vector, read_list, map_obarray):
8928 Use ptrdiff_t, not int, for sizes.
8929 (read1): Use EMACS_INT, not int, for sizes.
8930 Check for size overflow.
8932 * image.c (cache_image): Check for size arithmetic overflow.
8934 * lread.c: Integer overflow issues.
8935 (saved_doc_string_size, saved_doc_string_length)
8936 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8937 Now ptrdiff_t, not int.
8938 (read1): Don't assume doc string length fits in int. Check for
8939 out-of-range doc string lengths.
8940 (read_list): Don't assume file position fits in int.
8941 (read_escape): Check for hex character overflow.
8943 2011-06-22 Leo Liu <sdl.web@gmail.com>
8945 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8946 Move to minibuffer.el.
8948 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8950 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8951 The following patches are for when GLYPH_DEBUG && !XASSERT.
8952 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8953 * dispnew.c (flush_stdout):
8954 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8955 Mark as externally visible.
8956 * dispnew.c (check_window_matrix_pointers): Now static.
8957 * dispnew.c (window_to_frame_vpos):
8958 * xfns.c (unwind_create_frame):
8959 * xterm.c (x_check_font): Remove unused local.
8960 * scroll.c (CHECK_BOUNDS):
8961 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8962 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8963 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8964 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8965 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8967 (debug_method_add): Use va_list and vsprintf rather than relying
8968 on undefined behavior with wrong number of arguments.
8969 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8970 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8971 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8972 since we're not interested in debugging glyphs with old libraries.
8973 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8974 GCC 4.6.0's static checking.
8976 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8978 Integer overflow and signedness fixes (Bug#8873).
8979 A few related buffer overrun fixes, too.
8981 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8983 * dispextern.h (struct face.stipple):
8984 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8985 (x_bitmap_mask, x_allocate_bitmap_record)
8986 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8987 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8988 (x_create_bitmap_from_xpm_data):
8989 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8990 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8992 * xfaces.c (load_pixmap):
8993 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8994 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8995 (.bitmaps_last, struct x_output.icon_bitmap):
8996 Use ptrdiff_t, not int, for bitmap indexes.
8997 (x_allocate_bitmap_record): Check for size overflow.
8998 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9000 Use ptrdiff_t, not int, for overlay counts.
9001 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9002 * editfns.c (overlays_around, get_pos_property):
9003 * textprop.c (get_char_property_and_overlay):
9004 * xdisp.c (next_overlay_change, note_mouse_highlight):
9005 * xfaces.c (face_at_buffer_position):
9006 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9007 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9008 (Fnext_overlay_change, Fprevious_overlay_change)
9009 (mouse_face_overlay_overlaps, Foverlays_in):
9010 Use ptrdiff_t, not int, for sizes.
9011 (overlays_at, overlays_in): Check for size-calculation overflow.
9013 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9015 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9016 (x_session_initialize): Do not assume string length fits in int.
9018 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9019 This is unlikely, but can occur if DPI is outlandish.
9021 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9022 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9024 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9025 * xrdb.c (magic_file_p, search_magic_path):
9026 Omit last arg SUFFIX; it was always 0. All callers changed.
9027 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9029 * xfont.c (xfont_match): Avoid need for strlen.
9031 * xfns.c: Don't assume strlen fits in int.
9032 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9034 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9035 not unsigned long, as we prefer signed integers. All callers changed.
9036 Detect integer overflow in repeat count.
9037 (message_dolog): Don't assume print length fits in 39 bytes.
9038 (display_mode_element): Don't assume strlen fits in int.
9040 * termcap.c: Don't assume sizes fit in int and never overflow.
9041 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9042 (gobble_line): Check for size-calculation overflow.
9044 * minibuf.c (Fread_buffer):
9045 * lread.c (intern, intern_c_string):
9046 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9047 Don't assume string length fits in int.
9049 * keyboard.c (parse_tool_bar_item):
9050 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9052 * font.c: Don't assume string length fits in int.
9053 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9054 Use ptrdiff_t, not int.
9055 (font_intern_prop): Don't assume string length fits in int.
9056 Don't assume integer property fits in fixnum.
9057 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9059 * filelock.c: Fix some buffer overrun and integer overflow issues.
9060 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9061 Reformulate so as not to need the command string.
9062 Invoke gzip -cd rather than gunzip, as it's more portable.
9063 (lock_info_type, lock_file_1, lock_file):
9064 Don't assume pid_t and time_t fit in unsigned long.
9065 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9066 (current_lock_owner): Prefer signed type for sizes.
9067 Use memcpy, not strncpy, where memcpy is what is really wanted.
9068 Don't assume (via atoi) that time_t and pid_t fit in int.
9069 Check for time_t and/or pid_t out of range, e.g., via a network share.
9070 Don't alloca where an auto var works fine.
9072 * fileio.c: Fix some integer overflow issues.
9073 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9074 Don't assume string length fits in int.
9075 (directory_file_name): Don't assume string length fits in long.
9076 (make_temp_name): Don't assume pid fits in int, or that its print
9077 length is less than 20.
9079 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9081 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9083 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9085 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9086 We prefer signed integers, even for size calculations.
9088 * emacs.c: Don't assume string length fits in 'int'.
9089 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9090 (main): Don't invoke strlen when not needed.
9092 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9093 (XD_DEBUG_MESSAGE): Don't waste a byte.
9095 * callproc.c (getenv_internal_1, getenv_internal)
9097 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9099 * lread.c (invalid_syntax): Omit length argument.
9100 All uses changed. This doesn't fix a bug, but it simplifies the
9101 code away from its former Hollerith-constant appearance, and it's
9102 one less 'int' to worry about when looking at integer-overflow issues.
9103 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9105 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9106 This didn't break anything, but it didn't help either.
9107 It's confusing to put a bogus integer in a place where the actual
9108 value does not matter.
9109 (LIST_END_P): Remove unused macro and its bogus comment.
9110 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9112 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9113 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9115 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9116 We prefer signed types, and the value cannot exceed the EMACS_INT
9117 range anyway (because otherwise the length would not be representable).
9118 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9119 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9120 This avoids a GCC warning when WIDE_EMACS_INT.
9122 * indent.c (sane_tab_width): New function.
9123 (current_column, scan_for_column, Findent_to, position_indentation)
9124 (compute_motion): Use it. This is just for clarity.
9125 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9127 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9129 * lisp.h (lint_assume): New macro.
9130 * composite.c (composition_gstring_put_cache):
9131 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9133 * editfns.c, insdel.c:
9134 Omit unnecessary forward decls, to simplify future changes.
9136 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9138 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9140 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9141 Use much-faster test for byte-length change.
9142 Don't assume string byte-length fits in 'int'.
9143 Check that character arg fits in 'int'.
9144 (mapcar1): Declare byte as byte, for clarity.
9146 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9148 * fns.c (concat): Catch string overflow earlier.
9149 Do not rely on integer wraparound.
9151 * dispextern.h (struct it.overlay_strings_charpos)
9152 (struct it.selective): Now EMACS_INT, not int.
9153 * xdisp.c (forward_to_next_line_start)
9154 (back_to_previous_visible_line_start)
9155 (reseat_at_next_visible_line_start, next_element_from_buffer):
9156 Don't arbitrarily truncate the value of 'selective' to int.
9158 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9160 * composite.c: Don't truncate sizes to 'int'.
9161 (composition_gstring_p, composition_reseat_it)
9162 (composition_adjust_point): Use EMACS_INT, not int.
9163 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9164 not EMACS_UINT, for indexes.
9166 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9168 * buffer.c: Include <verify.h>.
9169 (struct sortvec.priority, struct sortstr.priority):
9170 Now EMACS_INT, not int.
9171 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9172 (struct sortstr.size, record_overlay_string)
9173 (struct sortstrlist.size, struct sortlist.used):
9174 Don't truncate size to int.
9175 (record_overlay_string): Check for size-calculation overflow.
9176 (init_buffer_once): Check at compile-time, not run-time.
9178 2011-06-22 Jim Meyering <meyering@redhat.com>
9180 Don't leak an XBM-image-sized buffer
9181 * image.c (xbm_load): Free the image buffer after using it.
9183 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9186 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9187 that Sun C diagnosed.
9188 * fns.c (secure_hash): Fix pointer signedness issue.
9189 * intervals.c (static_offset_intervals): New function.
9190 (offset_intervals): Use it.
9192 2011-06-21 Leo Liu <sdl.web@gmail.com>
9195 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9198 * fns.c (secure_hash): Rename from crypto_hash_function and change
9199 the first arg to accept symbols.
9200 (Fsecure_hash): New primitive.
9201 (syms_of_fns): New symbols.
9203 2011-06-20 Deniz Dogan <deniz@dogan.se>
9205 * process.c (Fset_process_buffer): Clarify return value in
9208 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9210 * dispnew.c (add_window_display_history): Use BVAR.
9212 * xdisp.c (debug_method_add): Use BVAR.
9213 (check_window_end, dump_glyph_matrix, dump_glyph)
9214 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9216 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9219 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9220 check till after the cache is created in init_frame_faces.
9222 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9224 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9226 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9228 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9229 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9230 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9232 Improve buffer-overflow checking (Bug#8873).
9233 * fileio.c (Finsert_file_contents):
9234 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9235 Remove the old (too-loose) buffer overflow checks.
9236 They weren't needed, since make_gap checks for buffer overflow.
9237 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9238 The old code merely checked for Emacs fixnum overflow, and relied
9239 on undefined (wraparound) behavior. The new code avoids undefined
9240 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9242 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9243 Tune. Don't use wider integers than needed. Don't use alloca.
9244 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9246 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9248 * insdel.c, lisp.h (buffer_overflow): New function.
9249 (insert_from_buffer_1, replace_range, replace_range_2):
9250 * insdel.c (make_gap_larger):
9251 * editfns.c (Finsert_char):
9252 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9254 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9256 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9258 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9260 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9261 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9263 * fileio.c: Don't assume EMACS_INT fits in off_t.
9264 (emacs_lseek): New static function.
9265 (Finsert_file_contents, Fwrite_region): Use it.
9266 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9268 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9270 * fns.c: Don't overflow int when computing a list length.
9271 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9272 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9273 truncation on 64-bit hosts. Check for QUIT every
9274 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9275 faster and is responsive enough.
9276 (Flength): Report an error instead of overflowing an integer.
9277 (Fsafe_length): Return a float if the value is not representable
9278 as a fixnum. This shouldn't happen except in contrived situations.
9279 (Fnthcdr, Fsort): Don't assume list length fits in int.
9280 (Fcopy_sequence): Don't assume vector length fits in int.
9282 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9283 (header_size, word_size): New constants.
9284 (allocate_vectorlike): Don't check size overflow here.
9285 (allocate_vector): Check it here instead, since this is the only
9286 caller of allocate_vectorlike that could cause overflow.
9287 Check that the new vector's length is representable as a fixnum.
9289 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9290 The previous code was bogus. For example, next_almost_prime (32)
9291 returned 39, which is undesirable as it is a multiple of 3; and
9292 next_almost_prime (24) returned 25, which is a multiple of 5 so
9293 why was the code bothering to check for multiples of 7?
9295 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9297 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9299 Variadic C functions now count arguments with ptrdiff_t.
9300 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9301 Back then I didn't know that the Emacs coding style prefers signed int.
9302 Also, in the meantime I found a few more instances where arguments
9303 were being counted with int, which may truncate counts on 64-bit
9304 machines, or EMACS_INT, which may be unnecessarily wide.
9305 * lisp.h (struct Lisp_Subr.function.aMANY)
9306 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9307 Arg counts are now ptrdiff_t, not size_t.
9308 All variadic functions and their callers changed accordingly.
9309 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9310 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9311 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9312 * callint.c (Fcall_interactively): Check arg count for overflow,
9313 to avoid potential buffer overrun. Use signed char, not 'int',
9314 for 'varies' array, so that we needn't bother to check its size
9315 calculation for overflow.
9316 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9317 * eval.c (apply_lambda):
9318 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9319 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9320 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9322 * callint.c (Fcall_interactively): Don't use index var as event count.
9324 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9325 * mem-limits.h (SIZE): Remove; no longer used.
9327 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9329 Remove unnecessary casts.
9330 * xterm.c (x_term_init):
9331 * xfns.c (x_set_border_pixel):
9332 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9333 These aren't needed now that we assume ANSI C.
9335 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9336 It's more likely to cause problems (due to unsigned overflow)
9339 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9341 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9343 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9345 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9347 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9349 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9351 GLYPH_CODE_FACE returns EMACS_INT, not int.
9352 * dispextern.h (merge_faces):
9353 * xfaces.c (merge_faces):
9354 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9355 Don't assume EMACS_INT fits in int.
9357 * character.h (CHAR_VALID_P): Remove unused parameter.
9358 * fontset.c, lisp.h, xdisp.c: All uses changed.
9360 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9362 * fns.c (concat): Minor tuning based on overflow analysis.
9363 This doesn't fix any bugs. Use int to hold character, instead
9364 of constantly refetching from Emacs object. Use XFASTINT, not
9365 XINT, for value known to be a character. Don't bother comparing
9366 a single byte to 0400, as it's always less.
9368 * floatfns.c (Fexpt):
9369 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9371 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9374 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9376 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9377 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9378 incorrectly succeed when S was a string, because 4294967386 was
9379 truncated before it was used.
9381 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9382 Otherwise, an out-of-range integer could cause undefined behavior
9385 * composite.c: Use int, not EMACS_INT, for characters.
9386 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9387 EMACS_INT, for values that are known to be in character range.
9388 This doesn't fix any bugs but is the usual style inside Emacs and
9389 may generate better code on 32-bit machines.
9391 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9392 This is for reasons similar to the recent CHAR_STRING fix.
9393 * charset.c (Fencode_char): Check that character arg is actually
9394 a character. Pass an int to ENCODE_CHAR.
9395 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9396 wider than 'int', as a compile-time check to prevent future regressions
9399 * character.c (char_string): Remove unnecessary casts.
9401 Make sure a 64-bit char is never passed to CHAR_STRING.
9402 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9403 by silently ignoring the top 32 bits, allowing some values
9404 that were far too large to be valid characters.
9405 * character.h: Include <verify.h>.
9406 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9407 arguments are no wider than unsigned, as a compile-time check
9408 to prevent future regressions in this area.
9410 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9411 (Fsubst_char_in_region):
9413 * xdisp.c (decode_mode_spec_coding):
9414 Adjust to CHAR_STRING's new requirement.
9415 * editfns.c (Finsert_char, Fsubst_char_in_region):
9416 * fns.c (concat): Check that character args are actually
9417 characters. Without this test, these functions did the wrong
9418 thing with wildly out-of-range values on 64-bit hosts.
9420 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9421 These casts should not be needed on 32-bit hosts, either.
9422 * keyboard.c (read_char):
9423 * lread.c (Fload): Remove casts to unsigned.
9425 * lisp.h (UNSIGNED_CMP): New macro.
9426 This fixes comparison bugs on 64-bit hosts.
9427 (ASCII_CHAR_P): Use it.
9428 * casefiddle.c (casify_object):
9429 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9430 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9431 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9432 * dispextern.h (FACE_FROM_ID):
9433 * keyboard.c (read_char): Use UNSIGNED_CMP.
9435 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9436 not to EMACS_INT, to avoid GCC warning.
9438 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9440 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9441 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9442 isn't needed on 32-bit machines.
9444 * buffer.c (Fgenerate_new_buffer_name):
9445 Use EMACS_INT for count, not int.
9446 (advance_to_char_boundary): Return EMACS_INT, not int.
9448 * data.c (Qcompiled_function): Now static.
9450 * window.c (window_body_lines): Now static.
9452 * image.c (gif_load): Rename local to avoid shadowing.
9454 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9455 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9456 * alloc.c (make_save_value): Integer argument is now of type
9458 (mark_object): Use ptrdiff_t, not int.
9459 * lisp.h (pD): New macro.
9460 * print.c (print_object): Use it.
9462 * alloc.c: Use EMACS_INT, not int, to count objects.
9463 (total_conses, total_markers, total_symbols, total_vector_size)
9464 (total_free_conses, total_free_markers, total_free_symbols)
9465 (total_free_floats, total_floats, total_free_intervals)
9466 (total_intervals, total_strings, total_free_strings):
9467 Now EMACS_INT, not int. All uses changed.
9468 (Fgarbage_collect): Compute overall total using a double, so that
9469 integer overflow is less likely to be a problem. Check for overflow
9470 when converting back to an integer.
9471 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9472 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9473 These were 'int' variables that could overflow on 64-bit hosts;
9474 they were never used, so remove them instead of repairing them.
9475 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9476 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9477 Previously, this ceilinged at INT_MAX, but that doesn't work on
9479 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9481 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9482 (allocate_vectorlike): Check for ptrdiff_t overflow.
9483 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9484 when a (possibly-narrower) signed value would do just as well.
9485 We prefer using signed arithmetic, to avoid comparison confusion.
9487 * alloc.c: Catch some string size overflows that we were missing.
9488 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9489 for convenience in STRING_BYTES_MAX.
9490 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9491 The definition here is exact; the one in lisp.h was approximate.
9492 (allocate_string_data): Check for string overflow. This catches
9493 some instances we weren't catching before. Also, it catches
9494 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9495 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9496 and ptrdiff_t and EMACS_INT are both 64 bits.
9498 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9499 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9500 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9502 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9504 * alloc.c (Fmake_string): Check for out-of-range init.
9506 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9508 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9510 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9512 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9513 xg_get_default_scrollbar_width.
9515 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9516 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9517 (style_changed_cb): Call update_theme_scrollbar_width and call
9518 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9519 all frames (Bug#8505).
9520 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9521 Call gtk_window_set_resizable if HAVE_GTK3.
9522 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9523 and height if HAVE_GTK3 (Bug#8505).
9524 (scroll_bar_width_for_theme): New variable.
9525 (update_theme_scrollbar_width): New function.
9526 (xg_get_default_scrollbar_width): Move code to
9527 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9528 (xg_initialize): Call update_theme_scrollbar_width.
9530 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9532 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9534 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9536 * frame.c (make_frame): Call other_buffer_safely instead of
9539 * window.c (temp_output_buffer_show): Call display_buffer with
9540 second argument Vtemp_buffer_show_specifiers and reset latter
9541 immediately after the call.
9542 (Vtemp_buffer_show_specifiers): New variable.
9543 (auto_window_vscroll_p, next_screen_context_lines)
9544 (Vscroll_preserve_screen_position): Remove leading asterisks from
9547 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9549 Fix minor problems found by GCC 4.6.0 static checking.
9550 * buffer.c (Qclone_number): Remove for now, as it's unused.
9551 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9552 (record_buffer): Remove unused local.
9553 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9554 (set_frame_buffer_list): Remove; unused.
9555 * frame.h (other_visible_frames): Remove decl.
9556 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9557 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9558 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9560 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9561 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9562 Define only if HAVE_GPM.
9563 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9564 (update_hints_inhibit): Remove; never set. All uses removed.
9565 * widgetprv.h (emacsFrameClassRec): Remove decl.
9566 * window.c (delete_deletable_window): Now returns void, since it
9567 wasn't returning anything.
9568 (compare_window_configurations): Remove unused locals.
9569 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9570 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9571 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9572 the same widths as pointers. This follows up on the 2011-05-06 patch.
9573 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9574 * xterm.h: Likewise.
9575 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9577 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9579 * makefile.w32-in: Update dependencies.
9580 (LISP_H): Add lib/intprops.h.
9582 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9584 * image.c (gif_load): Add animation frame delay to the metadata.
9585 (syms_of_image): Use DEFSYM. New symbol `delay'.
9587 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9589 * window.c (delete_deletable_window): Re-add.
9590 (Fset_window_configuration): Rewrite to handle dead buffers and
9591 consequently deletable windows.
9592 (window_tree, Fwindow_tree): Remove. Supply functionality in
9594 (compare_window_configurations): Simplify code.
9596 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9598 * image.c (imagemagick_load_image): Fix type mismatch.
9599 (Fimagemagick_types): Likewise.
9601 * window.h (replace_buffer_in_windows): Declare.
9603 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9605 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9606 Qclone_number. Remove external declaration of Qdelete_window.
9607 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9609 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9610 Run Qbuffer_list_update_hook if allowed.
9611 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9612 buffer list implementation.
9613 (other_buffer_safely): New function.
9614 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9615 calls to replace_buffer_in_windows and
9616 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9618 (record_buffer): Inhibit quitting and rewrite using quittable
9619 functions. Run Qbuffer_list_update_hook if allowed.
9620 (Frecord_buffer, Funrecord_buffer): New functions.
9621 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9622 Move switch-to-buffer to window.el.
9623 (bury-buffer): Move to window.el.
9624 (Vbuffer_list_update_hook): New variable.
9626 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9629 * window.h (resize_frame_windows): Move up in code.
9630 (Fwindow_frame): Remove EXFUN.
9631 (replace_buffer_in_all_windows): Remove prototype.
9632 (replace_buffer_in_windows_safely): Add prototype.
9634 * window.c: Declare Qdelete_window static again. Move down
9635 declaration of select_count.
9636 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9637 (Fother_window): Move to window.el.
9638 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9639 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9640 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9642 (replace_buffer_in_windows): Implement by calling
9643 Qreplace_buffer_in_windows.
9644 (replace_buffer_in_all_windows): Remove with some functionality
9645 moved into replace_buffer_in_windows_safely.
9646 (replace_buffer_in_windows_safely): New function.
9647 (select_window_norecord, select_frame_norecord): Move in front
9648 of run_window_configuration_change_hook. Remove now obsolete
9650 (Fset_window_buffer): Rewrite doc-string.
9651 Call Qrecord_window_buffer.
9652 (keys_of_window): Move binding for other-window to window.el.
9654 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9656 * dispextern.h (struct image): Replace data member, whose int_val
9657 and ptr_val fields were not used by anything, with a single
9660 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9661 (gif_clear_image, gif_load, imagemagick_load_image)
9662 (gs_clear_image, gs_load): Callers changed.
9664 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9666 * buffer.h: Include <time.h>, for time_t.
9667 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9669 Fix minor problems found by static checking.
9671 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9673 Make identifiers static if they are not used in other modules.
9674 * data.c (Qcompiled_function, Qframe, Qvector):
9675 * image.c (QimageMagick, Qsvg):
9676 * minibuf.c (Qmetadata):
9677 * window.c (resize_window_check, resize_root_window): Now static.
9678 * window.h (resize_window_check, resize_root_window): Remove decls.
9680 * window.c (window_deletion_count, delete_deletable_window):
9682 (window_body_lines): Now static.
9683 (Fdelete_other_windows_internal): Mark vars as initialized.
9684 Make sure 'resize_failed' is initialized.
9685 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9686 (resize_window_apply): Remove unused local.
9687 * window.h (delete_deletable_window): Remove decl.
9689 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9690 (imagemagick_load_image): Fix pointer signedness problem by changing
9691 last arg from unsigned char * to char *. All uses changed.
9692 Also, fix a local for similar reasons.
9693 Remove unused locals. Remove locals to avoid shadowing.
9694 (fn_rsvg_handle_free): Remove; unused.
9695 (svg_load, svg_load_image): Fix pointer signedness problem.
9696 (imagemagick_load_image): Don't use garbage pointer image_wand.
9698 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9700 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9702 * image.c (gif_load): Fix omitted cast error introduced by
9705 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9707 * window.h (resize_proportionally, orig_total_lines)
9708 (orig_top_line): Remove from window structure.
9709 (set_window_height, set_window_width, change_window_heights)
9710 (Fdelete_window): Remove prototypes.
9711 (resize_frame_windows): Remove duplicate declaration.
9713 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9715 * window.h (resize_frame_windows, resize_window_check)
9716 (delete_deletable_window, resize_root_window)
9717 (resize_frame_windows): Declare prototypes.
9719 * window.c (resize_window_apply): Make definition be "static" to
9720 match the prototype.
9722 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9724 * window.c: Remove declarations of Qwindow_size_fixed,
9725 window_min_size_1, window_min_size_2, window_min_size,
9726 size_window, window_fixed_size_p, enlarge_window, delete_window.
9727 Remove static from declaration of Qdelete_window, it's
9728 temporarily needed by Fbury_buffer.
9729 (replace_window): Don't assign orig_top_line and
9731 (Fdelete_window, delete_window): Remove. Window deletion is
9732 handled by window.el.
9733 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9734 Replace Fdelete_window calls with calls to Qdelete_window.
9735 (Fdelete_other_windows): Remove. Deleting other windows is
9736 handled by window.el.
9737 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9738 handled in window.el.
9739 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9740 Window minimum sizes are handled in window.el.
9741 (shrink_windows, size_window, set_window_height)
9742 (set_window_width, change_window_heights, window_height)
9743 (window_width, CURBEG, CURSIZE, enlarge_window)
9744 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9745 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9746 handled in window.el.
9747 (make_dummy_parent): Rename to make_parent_window and give it a
9748 second argument horflag.
9749 (make_window): Don't set resize_proportionally any more.
9750 (Fsplit_window): Remove. Windows are split in window.el.
9751 (save_restore_action, save_restore_orig_size)
9752 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9753 Resize mini windows in window.el.
9754 (grow_mini_window, shrink_mini_window): Implement by calling
9755 Qresize_root_window_vertically, resize_window_check and
9756 resize_window_apply.
9757 (saved_window, Fset_window_configuration, save_window_save):
9758 Do not handle orig_top_line, orig_total_lines, and
9759 resize_proportionally.
9760 (window_min_height, window_min_width): Move to window.el.
9761 (keys_of_window): Move bindings for delete-other-windows,
9762 split-window, delete-window and enlarge-window to window.el.
9764 * buffer.c: Temporarily extern Qdelete_window.
9765 (Fbury_buffer): Temporarily call Qdelete_window instead of
9766 Fdelete_window (Fbury_buffer will move to window.el soon).
9768 * frame.c (set_menu_bar_lines_1): Remove code handling
9769 orig_top_line and orig_total_lines.
9771 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9772 set_window_height but set heights directly.
9773 (change_frame_size_1): Use resize_frame_windows.
9775 * xdisp.c (init_xdisp): Don't use set_window_height but set
9778 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9779 Use resize_frame_windows instead of change_window_heights and run
9780 run_window_configuration_change_hook.
9782 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9783 instead of change_window_heights and run
9784 run_window_configuration_change_hook.
9786 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9788 * window.c (replace_window): Rename second argument REPLACEMENT to
9789 NEW. New third argument SETFLAG. Rewrite.
9790 (delete_window, make_dummy_parent): Call replace_window with
9792 (window_list_1): Move down in code.
9793 (run_window_configuration_change_hook): Move set_buffer part
9794 before select_frame_norecord part in order to unwind correctly.
9795 Rename count1 to count.
9796 (recombine_windows, delete_deletable_window, resize_root_window)
9797 (Fdelete_other_windows_internal)
9798 (Frun_window_configuration_change_hook, make_parent_window)
9799 (resize_window_check, resize_window_apply, Fresize_window_apply)
9800 (resize_frame_windows, Fsplit_window_internal)
9801 (Fdelete_window_internal, Fresize_mini_window_internal):
9803 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9805 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9807 * window.h (window): Add some new members to window structure -
9808 normal_lines, normal_cols, new_total, new_normal, clone_number,
9809 splits, nest, prev_buffers, next_buffers.
9810 (WINDOW_TOTAL_SIZE): Move here from window.c.
9811 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9813 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9815 (make_dummy_parent): Set new members of windows structure.
9816 (make_window): Move down in code. Handle new members of window
9818 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9819 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9820 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9821 (Fset_window_prev_buffers, Fwindow_next_buffers)
9822 (Fset_window_next_buffers, Fset_window_clone_number):
9824 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9825 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9827 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9828 Argument WINDOW can be now internal window too.
9829 (Fwindow_use_time): Move up in code.
9830 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9832 (Fset_window_configuration, saved_window)
9833 (Fcurrent_window_configuration, save_window_save): Handle new
9834 members of window structure.
9835 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9836 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9837 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9838 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9839 Qget_mru_window, Qresize_root_window,
9840 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9841 Qauto_buffer_name; staticpro them.
9843 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9845 * window.c (Fwindow_total_size, Fwindow_left_column)
9846 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9847 (Fwindow_list_1): New functions.
9848 (window_box_text_cols): Replace with window_body_cols.
9849 (Fwindow_width, Fscroll_left, Fscroll_right):
9850 Use window_body_cols instead of window_box_text_cols.
9851 (delete_window, Fset_window_configuration):
9852 Call delete_all_subwindows with window as argument.
9853 (delete_all_subwindows): Take a window as argument and not a
9855 (window_loop): Remove handling of GET_LRU_WINDOW and
9857 (Fget_lru_window, Fget_largest_window): Move to window.el.
9859 * window.h: Extern window_body_cols instead of
9860 window_box_text_cols. delete_all_subwindows now takes a
9861 Lisp_Object as argument.
9863 * indent.c (compute_motion, Fcompute_motion):
9864 Use window_body_cols instead of window_box_text_cols.
9866 * frame.c (delete_frame): Call delete_all_subwindows with root
9869 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9871 * fns.c (Fputhash): Document return value.
9873 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9875 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9877 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9879 Cons<->int and similar integer overflow fixes (Bug#8794).
9881 Check for overflow when converting integer to cons and back.
9882 * charset.c (Fdefine_charset_internal, Fdecode_char):
9883 Use cons_to_unsigned to catch overflow.
9884 (Fencode_char): Use INTEGER_TO_CONS.
9885 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9886 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9887 * data.c (long_to_cons, cons_to_long): Remove.
9888 (cons_to_unsigned, cons_to_signed): New functions.
9889 These signal an error for invalid or out-of-range values.
9890 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9891 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9892 * font.c (Ffont_variation_glyphs):
9893 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9894 * lisp.h: Include <intprops.h>.
9895 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9896 (cons_to_signed, cons_to_unsigned): New decls.
9897 (long_to_cons, cons_to_long): Remove decls.
9898 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9899 (Fprimitive_undo): Use CONS_TO_INTEGER.
9900 * xfns.c (Fx_window_property): Likewise.
9901 * xselect.c: Include <limits.h>.
9902 (x_own_selection, selection_data_to_lisp_data):
9903 Use INTEGER_TO_CONS.
9904 (x_handle_selection_request, x_handle_selection_clear)
9905 (x_get_foreign_selection, Fx_disown_selection_internal)
9906 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9907 (lisp_data_to_selection_data): Use cons_to_unsigned.
9908 (x_fill_property_data): Use cons_to_signed.
9909 Report values out of range.
9911 Check for buffer and string overflow more precisely.
9912 * buffer.h (BUF_BYTES_MAX): New macro.
9913 * lisp.h (STRING_BYTES_MAX): New macro.
9914 * alloc.c (Fmake_string):
9915 * character.c (string_escape_byte8):
9916 * coding.c (coding_alloc_by_realloc):
9917 * doprnt.c (doprnt):
9918 * editfns.c (Fformat):
9920 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9921 since they may not be the same number.
9922 * editfns.c (Finsert_char):
9923 * fileio.c (Finsert_file_contents):
9924 Likewise for BUF_BYTES_MAX.
9926 * image.c: Use ptrdiff_t, not int, for sizes.
9927 (slurp_file): Switch from int to ptrdiff_t.
9929 (slurp_file): Check that file size fits in both size_t (for
9930 malloc) and ptrdiff_t (for sanity and safety).
9932 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9933 if b->modtime has its maximal value.
9935 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9937 Don't assume time_t can fit into int.
9938 * buffer.h (struct buffer.modtime): Now time_t, not int.
9939 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9940 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9942 Minor fixes for signed vs unsigned integers.
9943 * character.h (MAYBE_UNIFY_CHAR):
9944 * charset.c (maybe_unify_char):
9945 * keyboard.c (read_char, reorder_modifiers):
9946 XINT -> XFASTINT, since the integer must be nonnegative.
9947 * ftfont.c (ftfont_spec_pattern):
9948 * keymap.c (access_keymap, silly_event_symbol_error):
9949 XUINT -> XFASTINT, since the integer must be nonnegative.
9950 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9951 since it makes no difference and we prefer signed.
9952 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9953 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9956 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9958 * window.h (Fwindow_frame): Declare.
9960 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9962 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9963 (SPARE_MEMORY): Always define.
9964 (LARGE_REQUEST): Remove.
9965 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9967 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9969 * lisp.h: Move EXFUNS for Fframe_root_window,
9970 Fframe_first_window and Fset_frame_selected_window to window.h.
9972 * window.h: Move EXFUNS for Fframe_root_window,
9973 Fframe_first_window and Fset_frame_selected_window here from
9976 * frame.c (Fwindow_frame, Fframe_first_window)
9977 (Fframe_root_window, Fframe_selected_window)
9978 (Fset_frame_selected_window): Move to window.c.
9979 (Factive_minibuffer_window): Move to minibuf.c.
9980 (Fother_visible_frames_p): New function.
9982 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9984 * window.c (decode_window, decode_any_window): Move up in code.
9985 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9986 (inhibit_frame_unsplittable): Remove unused variable.
9987 (Fwindow_buffer): Move up and rewrite doc-string.
9988 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9989 (Fwindow_prev): New functions.
9990 (Fwindow_frame): Move here from frame.c. Accept any window as
9992 (Fframe_root_window, Fframe_first_window)
9993 (Fframe_selected_window): Move here from frame.c. Accept frame
9994 or arbitrary window as argument. Update doc-strings.
9995 (Fminibuffer_window): Move up in code.
9996 (Fwindow_minibuffer_p): Move up in code and simplify.
9997 (Fset_frame_selected_window): Move here from frame.c.
9999 (Fselected_window, select_window, Fselect_window): Move up in
10000 code. Minor doc-string fixes.
10002 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10004 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10005 Do not assume that spare memory exists; that assumption is valid
10006 only if SYSTEM_MALLOC.
10007 (LARGE_REQUEST): New macro, so that the issue of large requests
10008 is separated from the issue of spare memory.
10010 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10012 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10015 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10017 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10020 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10022 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10024 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10026 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10027 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10029 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10031 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10033 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10035 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10036 (x_clipboard_manager_save): Add return value.
10037 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10038 New error handlers.
10039 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10040 Obey Vx_select_enable_clipboard_manager. Catch errors in
10041 x_clipboard_manager_save (Bug#8779).
10042 (Vx_select_enable_clipboard_manager): New variable.
10043 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10045 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10047 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10049 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10051 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10052 in the current matrix if keep_current_p is non-zero.
10054 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10056 * bidi.c (bidi_level_of_next_char): Fix last change.
10058 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10060 Support bidi reordering of text covered by display properties.
10062 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10063 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10064 (bidi_cache_search, bidi_cache_iterator_state)
10065 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10066 (bidi_level_of_next_char, bidi_move_to_visually_next):
10067 Support character positions inside a run of characters covered by a
10069 (bidi_paragraph_init, bidi_resolve_explicit_1)
10070 (bidi_level_of_next_char): Call bidi_fetch_char and
10071 bidi_fetch_char_advance instead of FETCH_CHAR and
10072 FETCH_CHAR_ADVANCE.
10073 (bidi_init_it): Initialize new members.
10074 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10076 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10077 instead of using explicit *_CHAR codes.
10078 (bidi_resolve_explicit, bidi_resolve_weak):
10079 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10080 bidirectional text is supported only in multibyte buffers.
10081 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10082 it to initialize the frame_window_p member of struct bidi_it.
10083 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10084 (bidi_resolve_explicit, bidi_resolve_weak)
10085 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10086 bidi_it->nchars is non-positive.
10087 (bidi_level_of_next_char): Don't try to lookup the cache for the
10088 next/previous character if nothing is cached there yet, or if we
10089 were just reseat()'ed to a new position.
10091 * xdisp.c (set_cursor_from_row): Set start and stop points
10092 according to the row's direction when priming the loop that looks
10093 for the glyph on which to display cursor.
10094 (single_display_spec_intangible_p): Function deleted.
10095 (display_prop_intangible_p): Reimplement to call
10096 handle_display_spec instead of single_display_spec_intangible_p.
10097 Accept 3 additional arguments needed by handle_display_spec.
10098 This fixes incorrect cursor motion across display property with complex
10099 values: lists, `(when COND...)' forms, etc.
10100 (single_display_spec_string_p): Support property values that are
10101 lists with the argument STRING its top-level element.
10102 (display_prop_string_p): Fix the condition for processing a
10103 property that is a list to be consistent with handle_display_spec.
10104 (handle_display_spec): New function, refactored from the
10105 last portion of handle_display_prop.
10106 (compute_display_string_pos): Accept additional argument
10107 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10108 value of a `display' property is a "replacing spec".
10109 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10110 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10111 the display property, but just return a value indicating whether
10112 the display property will replace the characters it covers.
10113 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10114 frame_window_p members of struct bidi_it.
10115 (compute_display_string_pos, compute_display_string_end):
10117 (push_it): Accept second argument POSITION, where pop_it should
10118 jump to continue iteration.
10119 (reseat_1): Initialize bidi_it.disp_pos.
10121 * keyboard.c (adjust_point_for_property): Adjust the call to
10122 display_prop_intangible_p to its new signature.
10124 * dispextern.h (struct bidi_it): New member frame_window_p.
10125 (bidi_init_it): Update prototypes.
10126 (display_prop_intangible_p): Update prototype.
10127 (compute_display_string_pos, compute_display_string_end):
10128 Declare prototypes.
10129 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10132 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10134 Malloc failure behavior now depends on size of allocation.
10135 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10136 * lisp.h: Change signatures accordingly.
10137 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10138 All callers changed. (Bug#8762)
10140 * gnutls.c: Use Emacs's memory allocators.
10141 Without this change, the gnutls library would invoke malloc etc.
10142 directly, which causes problems on non-SYNC_INPUT hosts, and which
10143 runs afoul of improving memory_full behavior. (Bug#8761)
10144 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10145 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10146 xfree instead of the default malloc, realloc, free.
10147 (Fgnutls_boot): No need to check for memory allocation failure,
10148 since xmalloc does that for us.
10150 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10151 * category.c (hash_get_category_set):
10152 * ccl.c (ccl_driver):
10153 * charset.c (Fdefine_charset_internal):
10154 * charset.h (struct charset.hash_index):
10155 * composite.c (get_composition_id, gstring_lookup_cache)
10156 (composition_gstring_put_cache):
10157 * composite.h (struct composition.hash_index):
10158 * dispextern.h (struct image.hash):
10159 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10160 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10161 (hashfn_equal, hashfn_user_defined, make_hash_table)
10162 (maybe_resize_hash_table, hash_lookup, hash_put)
10163 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10164 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10165 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10166 * image.c (make_image, search_image_cache, lookup_image)
10167 (xpm_put_color_table_h):
10168 * lisp.h (struct Lisp_Hash_Table):
10169 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10170 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10171 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10172 * alloc.c (allocate_vectorlike):
10173 Check for overflow in vector size calculations.
10174 * ccl.c (ccl_driver):
10175 Check for overflow when converting EMACS_INT to int.
10176 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10177 need to be updated by these changes.
10178 * fns.c (make_hash_table, maybe_resize_hash_table):
10179 Check for integer overflow with large hash tables.
10180 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10181 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10182 (SXHASH_REDUCE): New macro.
10183 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10184 Use it instead of discarding useful hash info with large hash values.
10185 (sxhash_float): New function.
10186 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10187 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10188 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10189 Rewrite to use FIXNUM_BITS, as this simplifies things.
10190 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10191 Adjust signatures to match updated version of code.
10192 (consing_since_gc): Now EMACS_INT, since a single hash table can
10193 use more than INT_MAX bytes.
10195 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10197 Make it possible to build with GCC-4.6+ -O2 -flto.
10199 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10201 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10203 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10204 Call minibuffer-inactive-mode.
10206 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10208 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10209 Update dependencies.
10211 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10213 * data.c (init_data): Remove code for UTS, this system is not
10216 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10218 Don't force ./temacs to start in terminal mode.
10220 * frame.c (make_initial_frame): Initialize faces in all cases, not
10221 only when CANNOT_DUMP is defined.
10222 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10224 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10226 * dispnew.c (add_window_display_history): Use const for the string
10227 pointer. Remove declaration, not needed.
10229 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10231 Use 'inline', not 'INLINE'.
10232 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10233 * alloc.c, fontset.c (INLINE): Remove.
10234 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10235 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10236 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10237 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10238 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10240 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10242 Make it possible to run ./temacs.
10244 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10245 syms_of_callproc does the same thing. Remove test for
10246 "initialized", do it in the caller.
10247 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10249 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10251 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10252 (read_minibuf): Use get_minibuffer.
10253 (syms_of_minibuf): Use DEFSYM.
10254 (Qmetadata): New var.
10255 * data.c (Qbuffer): Don't make it static.
10256 (syms_of_data): Use DEFSYM.
10258 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10260 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10261 (CCL_CODE_MIN): New macro.
10263 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10265 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10267 * eval.c (Qdebug): Now static.
10268 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10269 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10270 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10272 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10274 * image.c: Various fixes to ImageMagick code comments.
10275 (Fimagemagick_types): Doc fix.
10277 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10279 Minor fixes prompted by GCC 4.6.0 warnings.
10281 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10283 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10284 (x_clipboard_manager_save_all): Move extern decl to ...
10285 * xterm.h: ... here, so that it can be checked for consistency.
10287 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10289 * xselect.c (x_clipboard_manager_save_frame)
10290 (x_clipboard_manager_save_all): New functions.
10291 (Fx_clipboard_manager_save): Lisp function deleted.
10293 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10294 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10296 * xterm.h: Update prototype.
10298 2011-05-28 William Xu <william.xwl@gmail.com>
10300 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10301 exiting (Bug#8239).
10303 2011-05-28 Jim Meyering <meyering@redhat.com>
10305 Avoid a sign-extension bug in crypto_hash_function.
10306 * fns.c (to_uchar): Define.
10307 (crypto_hash_function): Use it to convert some newly-signed
10308 variables to unsigned, to avoid sign-extension bugs. For example,
10309 without this change, (md5 "truc") would evaluate to
10310 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10311 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10312 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10314 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10316 Integer overflow fixes.
10318 * dbusbind.c: Serial number integer overflow fixes.
10319 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10320 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10321 to hold a serial number that is too large for a fixnum.
10322 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10323 Check for serial numbers out of range. Decode any serial number
10324 that was so large that it became a float. (Bug#8722)
10326 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10327 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10328 Use XFASTINT rather than XUINT when numbers are nonnegative.
10329 (xd_append_arg, Fdbus_method_return_internal):
10330 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10331 arguments, check that Lisp number is nonnegative, rather than
10332 silently wrapping negative numbers around. (Bug#8722)
10333 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10336 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10338 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10340 ccl: Add integer overflow checks.
10341 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10342 (IN_INT_RANGE): New macros.
10343 (ccl_driver): Use them to check for integer overflow when
10344 decoding a CCL program. Many of the new checks are whether XINT (x)
10345 fits in int; it doesn't always, on 64-bit hosts. The new version
10346 doesn't catch all possible integer overflows, but it's an
10347 improvement. (Bug#8719)
10349 * alloc.c (make_event_array): Use XINT, not XUINT.
10350 There's no need for unsigned here.
10352 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10353 This follows up to the 2011-05-06 change that substituted uintptr_t
10354 for EMACS_INT. This case wasn't caught back then.
10356 Rework Fformat to avoid integer overflow issues.
10357 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10358 now (part of C89). Include <verify.h>.
10359 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10360 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10361 (Fformat): Avoid the prepass trying to compute sizes; it was only
10362 approximate and thus did not catch overflow reliably. Instead, walk
10363 through the format just once, formatting and computing sizes as we go,
10364 checking for integer overflow at every step, and allocating a larger
10365 buffer as needed. Keep track separately whether the format is
10366 multibyte. Keep only the most-recently calculated precision, rather
10367 than them all. Record whether each argument has been converted to
10368 string. Use EMACS_INT, not int, for byte and char and arg counts.
10369 Support field widths and precisions larger than INT_MAX. Avoid
10370 sprintf's undefined behavior with conversion specifications such as %#d
10371 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10372 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10373 formatting out-of-range floating point numbers with int
10374 formats. (Bug#8668)
10376 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10378 * data.c: Avoid integer truncation in expressions involving floats.
10379 * data.c: Include <intprops.h>.
10380 (arith_driver): When there's an integer overflow in an expression
10381 involving floating point, convert the integers to floating point
10382 so that the resulting value does not suffer from catastrophic
10383 integer truncation. For example, on a 64-bit host (* 4
10384 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10385 Do not rely on undefined behavior after integer overflow.
10387 merge count_size_as_multibyte, parse_str_to_multibyte
10388 * character.c, character.h (count_size_as_multibyte):
10389 Rename from parse_str_to_multibyte; all uses changed.
10390 Check for integer overflow.
10391 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10392 since it's now a duplicate of the other. This is more of
10393 a character than a buffer op, so better that it's in character.c.
10394 * fns.c, print.c: Adjust to above changes.
10396 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10398 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10400 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10402 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10403 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10404 (x_clipboard_manager_save): Now static.
10405 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10407 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10408 (crypto_hash_function): Now static.
10409 Fix pointer signedness problems. Avoid unnecessary initializations.
10411 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10413 * termhooks.h (Vselection_alist): Make it terminal-local.
10415 * terminal.c (create_terminal): Initialize it.
10417 * xselect.c: Support for clipboard managers.
10418 (Vselection_alist): Move to termhooks.h as terminal-local var.
10419 (LOCAL_SELECTION): New macro.
10420 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10421 (symbol_to_x_atom): Remove gratuitous arg.
10422 (x_handle_selection_request, lisp_data_to_selection_data)
10423 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10424 (x_own_selection, x_get_local_selection, x_convert_selection):
10425 New arg, specifying work frame. Use terminal-local Vselection_alist.
10426 (some_frame_on_display): Delete unused function.
10427 (Fx_own_selection_internal, Fx_get_selection_internal)
10428 (Fx_disown_selection_internal, Fx_selection_owner_p)
10429 (Fx_selection_exists_p): New optional frame arg.
10430 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10431 (x_handle_selection_clear): Don't treat other terminals with the
10432 same keyboard specially. Use the terminal-local Vselection_alist.
10433 (x_clear_frame_selections): Use Frun_hook_with_args.
10435 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10437 * xterm.h: Add support for those atoms.
10439 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10441 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10442 (converted_selections, conversion_fail_tag): New global variables.
10443 (x_selection_request_lisp_error): Free the above.
10444 (x_get_local_selection): Remove unnecessary code.
10445 (x_reply_selection_request): Args changed; handle arbitrary array
10446 of converted selections stored in converted_selections.
10447 Separate the XChangeProperty and SelectionNotify steps.
10448 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10449 (x_convert_selection): New function.
10450 (x_handle_selection_event): Simplify.
10451 (x_get_foreign_selection): Don't ignore incoming requests while
10452 waiting for an answer; this will fail when we implement
10453 SAVE_TARGETS, and seems unnecessary anyway.
10454 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10455 (Vx_sent_selection_functions): Doc fix.
10457 2011-05-26 Leo Liu <sdl.web@gmail.com>
10459 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10461 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10463 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10465 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10466 for fringe update if it has periodic bitmap.
10467 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10468 and fringe_bitmap_periodic_p.
10470 * fringe.c (get_fringe_bitmap_data): New function.
10471 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10472 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10473 row. Mark glyph row for fringe update if periodicity changed.
10475 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10476 for fringe update unless it has periodic bitmap.
10478 2011-05-25 Kenichi Handa <handa@m17n.org>
10480 * xdisp.c (get_next_display_element): Set correct it->face_id for
10481 a static composition.
10483 2011-05-24 Leo Liu <sdl.web@gmail.com>
10486 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10488 * fns.c (crypto_hash_function, Fsha1): New function.
10489 (Fmd5): Use crypto_hash_function.
10490 (syms_of_fns): Add Ssha1.
10492 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10494 * gnutls.c: Remove unused macros.
10495 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10496 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10497 Remove macros that are defined and never used.
10498 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10500 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10502 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10503 (Fx_get_selection_internal): Minor cleanup.
10504 (Fx_own_selection_internal): Rename arguments for consistency with
10507 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10509 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10511 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10513 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10515 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10517 * dispnew.c (scrolling_window): Don't exclude the case that the
10518 last enabled row in the desired matrix touches the bottom boundary.
10520 2011-05-21 Glenn Morris <rgm@gnu.org>
10522 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10523 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10524 and add some more files.
10526 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10528 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10529 report_file_error introduced by the change from 2011-05-07.
10531 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10533 * systime.h (Time): Define only if emacs is defined.
10534 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10535 where the include path doesn't have X11/X.h by default. See
10536 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10538 2011-05-20 Kenichi Handa <handa@m17n.org>
10540 * composite.c (find_automatic_composition): Fix previous change.
10542 2011-05-20 Glenn Morris <rgm@gnu.org>
10544 * lisp.mk: New file, split from Makefile.in.
10545 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10546 (shortlisp): Remove.
10547 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10549 2011-05-19 Glenn Morris <rgm@gnu.org>
10551 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10552 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10553 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10554 (lisp): Set the order to that of loadup.el.
10555 (shortlisp): Make it a copy of $lisp.
10556 (SOME_MACHINE_LISP): Remove.
10557 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10558 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10560 2011-05-18 Kenichi Handa <handa@m17n.org>
10562 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10563 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10564 (find_automatic_composition): Mostly rewrite for efficiency.
10566 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10568 * makefile.w32-in: Update dependencies.
10570 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10572 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10573 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10575 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10577 Fix some integer overflow issues, such as string length overflow.
10579 * insdel.c (count_size_as_multibyte): Check for string overflow.
10581 * character.c (lisp_string_width): Check for string overflow.
10582 Use EMACS_INT, not int, for string indexes and lengths; in
10583 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10584 the resulting string length overflows an EMACS_INT; instead,
10585 report a string overflow if no precision given. When checking for
10586 precision exhaustion, use a check that cannot possibly have
10587 integer overflow. (Bug#8675)
10588 * character.h (lisp_string_width): Adjust to new signature.
10590 * alloc.c (string_overflow): New function.
10591 (Fmake_string): Use it. This doesn't change behavior, but saves
10592 a few bytes and will simplify future changes.
10593 * character.c (string_escape_byte8): Likewise.
10594 * lisp.h (string_overflow): New decl.
10596 Fixups, following up to the user-interface timestamp change.
10597 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10598 for UI timestamps, instead of unsigned long.
10599 * msdos.c (mouse_get_pos): Likewise.
10600 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10601 * w32gui.h (Time): Define by including "systime.h" rather than by
10602 declaring it ourselves. (Bug#8664)
10604 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10605 * image.c (clear_image_cache): Likewise.
10607 * term.c (term_mouse_position): Don't assume time_t wraparound.
10609 Be more systematic about user-interface timestamps.
10610 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10611 and sometimes 'EMACS_UINT', to represent these timestamps.
10612 This change causes it to use 'Time' uniformly, as that's what X uses.
10613 This makes the code easier to follow, and makes it easier to catch
10614 integer overflow bugs such as Bug#8664.
10615 * frame.c (Fmouse_position, Fmouse_pixel_position):
10616 Use Time, not unsigned long, for user-interface timestamps.
10617 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10618 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10619 * keyboard.h (last_event_timestamp): Likewise.
10620 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10621 * menu.h (xmenu_show): Likewise.
10622 * term.c (term_mouse_position): Likewise.
10623 * termhooks.h (struct input_event.timestamp): Likewise.
10624 (struct terminal.mouse_position_hook): Likewise.
10625 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10626 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10627 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10628 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10629 what it was before.
10630 * menu.h, termhooks.h: Include "systime.h", for Time.
10632 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10633 Don't assume that the difference between two unsigned long values
10634 can fit into an integer. At this point, we know button_down_time
10635 <= event->timestamp, so the difference must be nonnegative, so
10636 there's no need to cast the result if double-click-time is
10637 nonnegative, as it should be; check that it's nonnegative, just in
10638 case. This bug is triggered when events are more than 2**31 ms
10639 apart (about 25 days). (Bug#8664)
10641 * xselect.c (last_event_timestamp): Remove duplicate decl.
10642 (x_own_selection): Remove needless cast to unsigned long.
10644 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10645 that always fit in int. Use a sentinel instead of a counter, to
10646 avoid a temp and to allay GCC's concerns about possible int overflow.
10647 * frame.h (struct frame): Use int for menu_bar_items_used
10648 instead of EMACS_INT, since it always fits in int.
10650 * menu.c (grow_menu_items): Check for int overflow.
10652 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10654 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10655 Before, the code was not consistent. These values cannot exceed
10656 2**31 - 1 so there's no need to make them unsigned.
10657 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10658 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10659 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10661 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10663 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10664 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10665 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10666 presumably because the widths might not match.
10668 * window.c (size_window): Avoid needless test at loop start.
10670 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10672 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10674 2011-05-12 Drew Adams <drew.adams@oracle.com>
10676 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10678 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10680 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10681 `width' to `bar_area_x' and `bar_area_width', respectively.
10682 (x_scroll_run): Take account of fringe background extension.
10684 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10685 Rename local vars `left' and `width' to `bar_area_x' and
10686 `bar_area_width', respectively.
10687 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10688 background extension.
10690 2011-05-10 Jim Meyering <meyering@redhat.com>
10692 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10694 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10696 * image.c (Finit_image_library): Return t for built-in image types,
10697 like pbm and xbm. (Bug#8640)
10699 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10701 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10703 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10705 * w32console.c (Fset_screen_color): Doc fix.
10706 (Fget_screen_color): New function.
10707 (syms_of_ntterm): Defsubr it.
10709 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10710 unlink the temporary file if Fcall_process didn't create it in the
10712 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10713 child process will be redirected to a file specified with `:file'.
10714 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10715 cue to call_process_cleanup not to close that handle.
10717 2011-05-07 Ben Key <bkey76@gmail.com>
10719 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10720 one of two shell specific rules, either bootstrap-temacs-CMD or
10721 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10722 to the previous implementation of the bootstrap-temacs rule.
10723 The bootstrap-temacs-CMD rule is similar to the previous
10724 implementation of the bootstrap-temacs rule except that it
10725 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10728 These changes, along with some changes to nt/configure.bat,
10729 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10730 earlier fix to add support for --cflags and --ldflags options
10731 that include quotes so that it works whether make uses cmd or
10734 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10736 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10737 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10739 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10740 a string. Handle both cases.
10741 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10742 (Fdbus_register_method): Use Qinvalid_function.
10744 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10746 * makefile.w32-in: Update dependencies.
10747 (LISP_H): Add inttypes.h and stdin.h.
10748 (PROCESS_H): Add unistd.h.
10750 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10752 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10753 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10755 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10757 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10759 * term.c (vfatal): Remove stray call to va_end.
10760 It's not needed and the C Standard doesn't allow it here anyway.
10762 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10763 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10765 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10768 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10770 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10772 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10774 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10776 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10778 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10779 * charset.c (Fdefine_charset_internal): Don't initialize
10780 charset.code_space[15]. The value was garbage, on hosts with
10781 32-bit int (Bug#8600).
10783 * lread.c (read_integer): Be more consistent with string-to-number.
10784 Use string_to_number to do the actual conversion; this avoids
10785 rounding errors and fixes some other screwups. Without this fix,
10786 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10787 (digit_to_number): Move earlier, for benefit of read_integer.
10788 Return -1 if the digit is out of range for the base, -2 if it is
10789 not a digit in any supported base. (Bug#8602)
10791 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10793 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10794 to match comment at start of function. This also removes a
10795 GCC warning about overflow in a 32+64-bit port.
10797 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10799 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10800 Reported by Stefan Monnier in
10801 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10802 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10803 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10805 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10806 (EMACS_UINTPTR): Likewise, with uintptr_t.
10808 * lisp.h: Prefer 64-bit EMACS_INT if available.
10809 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10810 on 32-bit hosts that have 64-bit int, so that they can access
10812 However, temporarily disable this change unless the temporary
10813 symbol WIDE_EMACS_INT is defined.
10815 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10817 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10818 This removes an assumption that EMACS_INT and long are the same
10819 width as pointers. The assumption is true for Emacs porting targets
10820 now, but we want to make other targets possible.
10821 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10822 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10823 In the rest of the code, change types of integers that hold casted
10824 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10825 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10826 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10827 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10828 No need to cast type when ORing.
10829 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10830 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10831 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10832 assume EMACS_INT is the same width as char *.
10833 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10834 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10835 Remove no-longer-needed casts.
10836 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10837 (xg_tool_bar_help_callback, xg_make_tool_item):
10838 Use EMACS_INTPTR to hold an integer
10839 that will be cast to void *; this can avoid a GCC warning
10840 if EMACS_INT is not the same width as void *.
10841 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10842 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10843 (current_message_1, set_message_1):
10844 Use a local to convert to proper width without a cast.
10845 * xmenu.c (dialog_selection_callback): Likewise.
10847 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10848 Also, don't assume VALBITS / RAND_BITS is less than 5,
10849 and don't rely on undefined behavior when shifting a 1 left into
10851 * lisp.h (get_random): Change signature to match.
10853 * lread.c (hash_string): Use size_t, not int, for hash computation.
10854 Normally we prefer signed values; but hashing is special, because
10855 it's better to use unsigned division on hash table sizes so that
10856 the remainder is nonnegative. Also, size_t is the natural width
10857 for hashing into memory. The previous code used 'int', which doesn't
10858 retain enough info to hash well into very large tables.
10859 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10861 * dbusbind.c: Don't possibly lose pointer info when converting.
10862 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10863 Use XPNTR rather than XHASH, so that the high-order bits of
10864 the pointer aren't lost when converting through void *.
10866 * eval.c (Fautoload): Don't double-shift a pointer.
10868 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10870 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10872 * gnutls.c (DEF_GNUTLS_FN):
10873 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10875 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10877 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10880 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10882 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10883 New version that can reserve upto 2GB of heap space.
10885 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10887 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10889 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10891 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10892 `gnutls_certificate_set_x509_key_file'.
10894 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10896 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10897 Update dependencies.
10899 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10901 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10902 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10903 Remove unused parameter `fildes'.
10904 * process.c (read_process_output, send_process): Don't pass it.
10906 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10908 Fix previous change: the library cache is defined in w32.c.
10909 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10910 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10912 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10914 Implement dynamic loading of GnuTLS on Windows.
10916 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10917 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10918 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10921 * gnutls.c (Qgnutls_dll): Define.
10922 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10923 (gnutls_*): Declare function pointers.
10924 (init_gnutls_functions): New function to initialize function pointers.
10925 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10926 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10927 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10928 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10929 (emacs_gnutls_write, emacs_gnutls_read)
10930 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10931 (Fgnutls_available_p): New function.
10932 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10933 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10934 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10936 * image.c: Include w32.h.
10937 (Vimage_type_cache): Delete.
10938 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10939 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10940 (w32_delayed_load): Move to w32.c.
10942 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10944 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10945 (w32_delayed_load): Move from image.c. When loading a library, record
10946 its filename in the :loaded-from property of the library id.
10947 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10948 Initialize and staticpro them.
10949 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10951 * process.c: Include lisp.h before w32.h, not after.
10952 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10953 instead of gnutls_record_check_pending.
10955 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10957 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10959 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10960 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10963 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10965 * xterm.c (x_set_frame_alpha): Do not set property on anything
10966 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10968 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10970 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10972 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10974 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10975 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10976 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10977 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10978 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10979 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10980 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10981 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10982 (Qgnutls_bootprop_callbacks_verify): Make static.
10984 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10986 * callproc.c: Indentation fixup.
10988 * sysdep.c (wait_for_termination_1): Make static.
10989 (wait_for_termination, interruptible_wait_for_termination):
10990 Move after wait_for_termination_1.
10992 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10994 * sysdep.c (interruptible_wait_for_termination): New function
10995 which is like wait_for_termination, but allows keyboard
10998 * callproc.c (Fcall_process): Add (:file "file") as an option for
11000 (Fcall_process_region): Ditto.
11002 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11004 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11005 rather than `XVECTOR (FOO)->size'.
11007 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11008 inttypes.h, as a gnulib replacement is used if it not available in
11011 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11013 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11014 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11015 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11017 * coding.c (coding_alloc_by_realloc): Error out if destination
11018 will grow beyond MOST_POSITIVE_FIXNUM.
11019 (decode_coding_emacs_mule): Abort if there isn't enough place in
11020 charbuf for the composition carryover bytes. Reserve an extra
11021 space for up to 2 characters produced in a loop.
11022 (decode_coding_iso_2022): Abort if there isn't enough place in
11023 charbuf for the composition carryover bytes.
11025 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11027 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11028 aborting when %lld or %lll format is passed.
11029 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11030 %llo or %llx format is passed. (Bug#8545)
11032 * window.c (window_scroll_line_based): Use a marker instead of
11033 simple variables to record original value of point. (Bug#7952)
11035 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11036 produced by %s or %c overflows available buffer space. (Bug#8545)
11038 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11040 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11041 (SIZE_MAX): Move defn after all includes, as they might #define it.
11043 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11045 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11047 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11049 * keyboard.c (Qdelayed_warnings_hook): Define.
11050 (command_loop_1): Run `delayed-warnings-hook'
11051 if Vdelayed_warnings_list is non-nil.
11052 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11053 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11055 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11057 * doprnt.c (doprnt): Don't return value smaller than the buffer
11058 size if the message was truncated. (Bug#8545).
11060 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11062 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11063 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11065 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11067 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11069 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11071 * makefile.w32-in: Update dependencies.
11073 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11075 Improve `doprnt' and its usage. (Bug#8545)
11076 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11077 `format_end'. Remove support for %l as a conversion specifier.
11078 Don't use xrealloc. Improve diagnostics when the %l size modifier
11079 is used. Update the commentary.
11081 * eval.c (verror): Simplify calculation of size_t.
11083 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11086 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11088 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11091 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11093 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11094 This makes this file independent of the recent pseudovector change.
11096 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11098 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11100 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11101 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11102 Remove unused local.
11103 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11105 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11106 GCC 4.6.0 optimizes based on type-based alias analysis.
11107 For example, if b is of type struct buffer * and v of type struct
11108 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11109 != &v->size, and therefore "v->size = 1; b->size = 2; return
11110 v->size;" must therefore return 1. This assumption is incorrect
11111 for Emacs, since it type-puns struct Lisp_Vector * with many other
11112 types. To fix this problem, this patch adds a new type struct
11113 vectorlike_header that documents the constraints on layout of vectors
11114 and pseudovectors, and helps optimizing compilers not get fooled
11115 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11116 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11117 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11119 (XSETPVECTYPE): Rewrite in terms of new macro.
11120 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11121 This is a bit clearer, and further avoids the possibility of
11122 undesirable aliasing.
11123 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11124 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11125 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11126 since Lisp_Subr is a special case (no "next" field).
11127 (ASIZE): Now uses header.size rather than size.
11128 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11129 to avoid the hassle of writing XVECTOR (foo)->header.size.
11130 (struct vectorlike_header): New type.
11131 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11132 object, to help avoid aliasing.
11133 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11134 (SUBRP): Likewise, since Lisp_Subr is a special case.
11135 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11136 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11137 (struct Lisp_Hash_Table): Combine first two members into a single
11138 struct vectorlike_header member. All uses of "size" and "next" members
11139 changed to be "header.size" and "header.next".
11140 * buffer.h (struct buffer): Likewise.
11141 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11142 * frame.h (struct frame): Likewise.
11143 * process.h (struct Lisp_Process): Likewise.
11144 * termhooks.h (struct terminal): Likewise.
11145 * window.c (struct save_window_data, struct saved_window): Likewise.
11146 * window.h (struct window): Likewise.
11147 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11148 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11149 * buffer.c (init_buffer_once): Likewise.
11150 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11152 * process.c (Fformat_network_address): Use local var for size,
11155 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11157 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11158 * data.c (atof): Remove decl; no longer used or needed.
11159 (digit_to_number): Move to lread.c.
11160 (Fstring_to_number): Use new string_to_number function, to be
11161 consistent with how the Lisp reader treats infinities and NaNs.
11162 Do not assume that floating-point numbers represent EMACS_INT
11163 without losing information; this is not true on most 64-bit hosts.
11164 Avoid double-rounding errors, by insisting on integers when
11165 parsing non-base-10 numbers, as the documentation specifies.
11166 * lisp.h (string_to_number): New decl, replacing ...
11167 (isfloat_string): Remove.
11168 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11169 (read1): Do not accept +. and -. as integers; this
11170 appears to have been a coding error. Similarly, do not accept
11171 strings like +-1e0 as floating point numbers. Do not report
11172 overflow for integer overflows unless the base is not 10 which
11173 means we have no simple and reliable way to continue.
11174 Break out the floating-point parsing into a new
11175 function string_to_number, so that Fstring_to_number parses
11176 floating point numbers consistently with the Lisp reader.
11177 (digit_to_number): Move here from data.c. Make it static inline.
11178 (E_CHAR, EXP_INT): Remove, replacing with ...
11179 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11180 (string_to_number): New function, replacing isfloat_string.
11181 This function checks for valid syntax and produces the resulting
11182 Lisp float number too. Rework it so that string-to-number
11183 no longer mishandles examples like "1.0e+". Use strtoumax,
11184 so that overflow for non-base-10 numbers is reported only when
11185 there's no portable and simple way to convert to floating point.
11187 * textprop.c (set_text_properties_1): Rewrite for clarity,
11188 and to avoid GCC warning about integer overflow.
11190 * intervals.h (struct interval): Use EMACS_INT for members
11191 where EMACS_UINT might cause problems. See
11192 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11193 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11194 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11196 (offset_intervals): Tell GCC not to worry about length overflow
11197 when negating a negative length.
11199 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11200 (overrun_check_free): Likewise.
11202 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11203 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11206 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11207 (gnutls_make_error): Rename local to avoid shadowing.
11208 (gnutls_emacs_global_deinit): ifdef out; not used.
11209 (Fgnutls_boot): Use const for pointer to readonly storage.
11210 Comment out unused local. Fix pointer signedness problems.
11212 * lread.c (openp): Don't stuff size_t into an 'int'.
11213 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11214 about possible signed overflow.
11216 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11217 (GDK_KEY_g): Don't define if already defined.
11218 (xg_prepare_tooltip): Avoid pointer signedness problem.
11219 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11221 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11222 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11224 * xfns.c (Fx_window_property): Simplify a bit,
11225 to make a bit faster and to avoid GCC 4.6.0 warning.
11226 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11228 * fns.c (internal_equal): Don't assume size_t fits in int.
11230 * alloc.c (compact_small_strings): Tighten assertion a little.
11232 Replace pEd with more-general pI, and fix some printf arg casts.
11233 * lisp.h (pI): New macro, generalizing old pEd macro to other
11234 conversion specifiers. For example, use "...%"pI"d..." rather
11235 than "...%"pEd"...".
11236 (pEd): Remove. All uses replaced with similar uses of pI.
11237 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11238 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11239 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11240 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11241 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11242 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11243 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11245 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11246 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11247 * print.c (safe_debug_print, print_object): Likewise.
11248 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11250 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11251 avoiding the 0 flag, which is not portable.
11252 * process.c (Fmake_network_process): Use pI to avoid cast.
11253 * region-cache.c (pp_cache): Likewise.
11254 * xdisp.c (decode_mode_spec): Likewise.
11255 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11256 behavior on 64-bit hosts with printf arg.
11257 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11258 (x_stop_queuing_selection_requests): Likewise.
11259 (x_get_window_property): Don't truncate byte count to an 'int'
11262 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11263 here, since it parses constructs like leading '-' and spaces,
11264 which are not wanted; and it overflows with large numbers.
11265 Instead, simply match F[0-9]+, which is what is wanted anyway.
11267 * alloc.c: Remove unportable assumptions about struct layout.
11268 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11269 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11270 (allocate_vectorlike, make_pure_vector): Use the new macros,
11271 plus offsetof, to remove unportable assumptions about struct layout.
11272 These assumptions hold on all porting targets that I know of, but
11273 they are not guaranteed, they're easy to remove, and removing them
11274 makes further changes easier.
11276 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11277 This doesn't fix a bug but makes the code clearer.
11278 (string_overrun_cookie): Now const. Use initializers that
11279 don't formally overflow signed char, to avoid warnings.
11280 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11281 can cause Emacs to crash when string overrun checking is enabled.
11282 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11283 multiple of sizeof (EMACS_INT); it need not be, if
11284 alignof(EMACS_INT) < sizeof (EMACS_INT).
11285 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11287 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11289 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11291 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11293 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11294 supposed to be handshaking. (Bug#8556)
11295 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11297 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11299 * lisp.h (Qdebug): List symbol.
11300 * eval.c (Qdebug): Restore global linkage.
11301 * keyboard.c (debug-on-event): New variable.
11302 (handle_user_signal): Break into debugger when debug-on-event
11303 matches the current signal symbol.
11305 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11307 * alloc.c (check_sblock, check_string_bytes)
11308 (check_string_free_list): Convert to standard C.
11310 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11312 * w32.c (emacs_gnutls_push): Fix typo.
11314 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11316 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11317 "cast to pointer from integer of different size".
11319 Improve doprnt and its use in verror. (Bug#8545)
11320 * doprnt.c (doprnt): Document the set of format control sequences
11321 supported by the function. Use SAFE_ALLOCA instead of always
11324 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11325 is one byte too soon. Don't use xrealloc; instead xfree and
11328 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11330 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11333 * gnutls.c: Renamed global_initialized to
11334 gnutls_global_initialized. Added internals for the
11335 :verify-hostname-error, :verify-error, and :verify-flags
11336 parameters of `gnutls-boot' and documented those parameters in the
11337 docstring. Start callback support.
11338 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11339 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11340 on error. Return error code.
11341 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11342 (emacs_gnutls_read): Likewise.
11343 (Fgnutls_boot): Return handshake error code.
11344 (emacs_gnutls_handle_error): New function.
11345 (wsaerror_to_errno): Likewise.
11347 * w32.h (emacs_gnutls_pull): Add prototype.
11348 (emacs_gnutls_push): Likewise.
11350 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11351 (emacs_gnutls_push): Likewise.
11353 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11355 * process.c (wait_reading_process_output): Check if GnuTLS
11356 buffered some data internally if no FDs are set for TLS
11359 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11360 (LIBS): Link to USER_LIBS.
11361 ($(BLD)/gnutls.$(0)): New target.
11363 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11365 * xdisp.c (handle_single_display_spec): Rename the
11366 display_replaced_before_p argument into display_replaced_p, to
11367 make it consistent with the commentary. Fix typos in the
11370 * textprop.c (syms_of_textprop): Remove dead code.
11371 (copy_text_properties): Delete obsolete commentary about an
11372 interface that was deleted long ago. Fix typos in the description
11375 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11376 to changes in oldXMenu/XMenu.h from 2011-04-16.
11377 <menu_help_message, prev_menu_help_message>: Constify.
11378 (IT_menu_make_room): menu->help_text is now `const char **';
11381 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11382 to changes in oldXMenu/XMenu.h from 2011-04-16.
11383 (struct XMenu): Declare `help_text' `const char **'.
11385 * xfaces.c <Qunspecified>: Make extern again.
11387 * syntax.c: Include sys/types.h before including regex.h, as
11390 * doc.c (get_doc_string): Improve the format passed to `error'.
11392 * doprnt.c (doprnt): Improve commentary.
11394 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11396 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11399 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11400 changes in globals.h immediately force recompilation.
11401 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11402 $(CURDIR)/s/ms-w32.h.
11403 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11405 * character.c (Fchar_direction): Function deleted.
11406 (syms_of_character): Don't defsubr it.
11407 <char-direction-table>: Deleted.
11409 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11411 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11412 * doprnt.c: Include limits.h.
11413 (SIZE_MAX): New macro.
11414 (doprnt): Return a size_t value. 2nd arg is now size_t.
11415 Many local variables are now size_t instead of int or unsigned.
11416 Improve overflow protection. Support `l' modifier for integer
11417 conversions. Support %l conversion. Don't assume an EMACS_INT
11418 argument for integer conversions and for %c.
11420 * lisp.h (doprnt): Restore prototype.
11422 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11423 $(SRC)/character.h.
11425 * Makefile.in (base_obj): Add back doprnt.o.
11427 * deps.mk (doprnt.o): Add back prerequisites.
11428 (callint.o): Depend on character.h.
11430 * eval.c (internal_lisp_condition_case): Include the handler
11431 representation in the error message.
11432 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11433 when breaking from the loop.
11435 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11437 * callint.c (Fcall_interactively): When displaying error message
11438 about invalid control letter, pass the character's codepoint, not
11439 a pointer to its multibyte form. Improve display of the character
11440 in octal and display also its hex code.
11442 * character.c (char_string): Use %x to display the (unsigned)
11443 codepoint of an invalid character, to avoid displaying a bogus
11446 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11447 `error', not SYMBOL_NAME itself.
11449 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11450 character arguments to `error'.
11452 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11453 to `error' in error message about FINAL_CHAR argument. Make sure
11454 FINAL_CHAR is a character, and use %c when it is passed as
11455 argument to `error'.
11457 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11459 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11461 * w32.c: Include <time.h>.
11462 (sys_localtime): New function.
11464 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11466 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11468 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11470 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11472 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11473 zombies (Bug#8467).
11475 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11477 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11478 gl_state.e_property when gl_state.object is Qt.
11480 * insdel.c (make_gap_larger): Remove limitation of buffer size
11483 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11485 * xdisp.c (lookup_glyphless_char_display)
11486 (produce_glyphless_glyph): Handle cons cell entry in
11487 glyphless-char-display.
11488 (Vglyphless_char_display): Document it.
11490 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11491 glyphless-char-display.
11493 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11495 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11497 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11499 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11500 definition for no-X builds.
11502 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11504 Static checks with GCC 4.6.0 and non-default toolkits.
11506 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11508 * process.c (keyboard_bit_set): Define only if SIGIO.
11509 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11510 (send_process): Repair possible setjmp clobbering.
11512 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11514 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11516 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11518 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11519 Define only if needed.
11521 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11522 by pacifying GCC about it. Maybe it's time to retire it?
11523 * xfaces.c (USG, __TIMEVAL__): Likewise.
11525 * dispextern.h (struct redisplay_interface): Rename param
11526 to avoid shadowing.
11527 * termhooks.h (struct terminal): Likewise.
11528 * xterm.c (xembed_send_message): Likewise.
11530 * insdel.c (make_gap_smaller): Define only if
11531 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11533 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11536 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11537 so that we aren't warned about unused symbols.
11539 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11541 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11543 * xfns.c (x_real_positions): Mark locals as initialized.
11545 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11547 * xterm.c: Fix problems found by static analysis with other toolkits.
11548 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11549 (x_dispatch_event): Declare static if USE_GTK, and
11550 define if USE_GTK || USE_X_TOOLKIT.
11551 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11552 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11553 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11554 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11556 * xmenu.c (menu_help_callback): Pointer type fixes.
11557 Use const pointers when pointing at readonly data. Avoid pointer
11558 signedness clashes.
11559 (FALSE): Remove unused macro.
11560 (update_frame_menubar): Remove unused decl.
11562 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11564 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11565 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11566 (single_menu_item): Rename local to avoid shadowing.
11568 * keyboard.c (make_lispy_event): Remove unused local var.
11570 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11571 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11573 * bitmaps: Change bitmaps from unsigned char back to the X11
11574 compatible char. Avoid the old compiler warnings about
11575 out-of-range initializers by using, for example, '\xab' rather
11578 * xgselect.c (xgselect_initialize): Check vs interface
11579 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11581 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11583 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11584 to read-only memory.
11586 * fns.c (vector): Remove; this old hack is no longer needed.
11588 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11590 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11592 * xrdb.c (x_load_resources): Omit unused local.
11594 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11595 (x_window): Rename locals to avoid shadowing.
11596 (USG): Use the kludged USG macro, to pacify gcc.
11598 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11599 (x_term_init): Remove local to avoid shadowing.
11601 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11603 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11604 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11606 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11608 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11610 Fix regex.c, syntax.c and friends for buffers > 2GB.
11611 * syntax.h (struct gl_state_s): Declare character position members
11614 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11616 * textprop.c (verify_interval_modification, interval_of):
11617 Declare arguments EMACS_INT.
11619 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11622 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11624 * indent.c (Fvertical_motion): Local variable it_start is now
11627 * regex.c (re_match, re_match_2, re_match_2_internal)
11628 (bcmp_translate, regcomp, regexec, print_double_string)
11629 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11630 (re_compile_pattern, re_exec): Declare arguments and local
11631 variables `size_t' and `ssize_t' and return values `regoff_t', as
11633 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11634 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11635 <compile_stack_type>: `size' and `avail' are now `size_t'.
11637 * regex.h <regoff_t>: Use ssize_t, not int.
11638 (re_search, re_search_2, re_match, re_match_2): Arguments that
11639 specify buffer/string position and length are now ssize_t and
11640 size_t. Return type is regoff_t.
11642 2011-04-16 Ben Key <bkey76@gmail.com>
11644 * nsfont.m: Fixed bugs in ns_get_family and
11645 ns_descriptor_to_entity that were caused by using free to
11646 deallocate memory blocks that were allocated by xmalloc (via
11647 xstrdup). This caused Emacs to crash when compiled with
11648 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11649 --enable-checking=xmallocoverrun). xfree is now used to
11650 deallocate these memory blocks.
11652 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11654 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11656 emacs_write: Accept and return EMACS_INT for sizes.
11657 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11659 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11660 Accept and return EMACS_INT.
11661 (emacs_gnutls_write): Return the number of bytes written on
11663 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11664 (emacs_read, emacs_write): Remove check for negative size, as the
11665 Emacs source code has been audited now.
11666 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11667 (emacs_read, emacs_write): Use it.
11668 * process.c (send_process): Adjust to the new signatures of
11669 emacs_write and emacs_gnutls_write. Do not attempt to store
11670 a byte offset into an 'int'; it might overflow.
11671 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11673 * sound.c: Don't assume sizes fit in 'int'.
11674 (struct sound_device.period_size, alsa_period_size):
11675 Return EMACS_INT, not int.
11676 (struct sound_device.write, vox_write, alsa_write):
11677 Accept EMACS_INT, not int.
11678 (wav_play, au_play): Use EMACS_INT to store sizes and to
11679 record read return values.
11681 2011-04-15 Ben Key <bkey76@gmail.com>
11683 * keyboard.c (Qundefined): Don't declare static since it is used
11685 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11686 static since they are used in nsfont.m.
11688 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11690 * process.c (Qprocessp): Don't declare static.
11691 * lisp.h (Qprocessp): Declare again.
11693 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11695 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11697 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11699 Improve C-level modularity by making more things 'static'.
11701 Don't publish debugger-only interfaces to other modules.
11702 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11703 (verify_bytepos, count_markers): Move decls to the only modules
11705 * region-cache.h (pp_cache): Likewise.
11706 * window.h (check_all_windows): Likewise.
11707 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11709 * sysdep.c (croak): Now static, if
11710 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11711 * syssignal.h (croak): Declare only if not static.
11713 * alloc.c (refill_memory_reserve): Now static if
11714 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11715 * lisp.h (refill_memory_reserve): Declare only if not static.
11717 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11718 Define only if USE_LUCID.
11720 * xrdb.c (x_customization_string, x_rm_string): Now static.
11722 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11723 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11725 * xdisp.c (draw_row_with_mouse_face): Now static.
11726 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11728 * window.h (check_all_windows): Mark externally visible.
11730 * window.c (window_deletion_count): Now static.
11732 * undo.c: Make symbols static if they're not exported.
11733 (last_undo_buffer, last_boundary_position, pending_boundary):
11736 * textprop.c (interval_insert_behind_hooks): Now static.
11737 (interval_insert_in_front_hooks): Likewise.
11739 * term.c: Make symbols static if they're not exported.
11740 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11741 (max_frame_lines, tty_set_terminal_modes):
11742 (tty_reset_terminal_modes, tty_turn_off_highlight):
11743 (get_tty_terminal): Now static.
11744 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11745 * termhooks.h (term_mouse_moveto): Do not declare if
11746 HAVE_WINDOW_SYSTEM.
11747 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11748 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11750 * sysdep.c: Make symbols static if they're not exported.
11751 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11753 (sigprocmask_set, full_mask): Remove; unused.
11754 (wait_debugging): Mark as visible.
11755 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11756 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11758 * syntax.c (syntax_temp): Define only if !__GNUC__.
11760 * sound.c (current_sound_device, current_sound): Now static.
11762 * search.c (searchbufs, searchbuf_head): Now static.
11764 * scroll.c (scroll_cost): Remove; unused.
11765 * dispextern.h (scroll_cost): Remove decl.
11767 * region-cache.h (pp_cache): Mark as externally visible.
11769 * process.c: Make symbols static if they're not exported.
11770 (process_tick, update_tick, create_process, chan_process):
11771 (Vprocess_alist, proc_buffered_char, datagram_access):
11772 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11773 (deactivate_process): Mark defn as static, as well as decl.
11774 * lisp.h (create_process): Remove decl.
11775 * process.h (chan_process, Vprocess_alist): Remove decls.
11777 * print.c: Make symbols static if they're not exported.
11778 (print_depth, new_backquote_output, being_printed, print_buffer):
11779 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11780 (print_interval, print_number_index, initial_stderr_stream):
11782 * lisp.h (Fprinc): Remove decl.
11783 (debug_output_compilation_hack): Mark as externally visible.
11785 * sysdep.c (croak): Move decl from here to syssignal.h.
11786 * syssignal.h (croak): Put it here, so the API can be checked when
11787 'croak' is called from dissociate_if_controlling_tty.
11789 * minibuf.c: Make symbols static if they're not exported.
11790 (minibuf_save_list, choose_minibuf_frame): Now static.
11791 * lisp.h (choose_minibuf_frame): Remove decl.
11793 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11795 * lread.c: Make symbols static if they're not exported.
11796 (read_objects, initial_obarray, oblookup_last_bucket_number):
11798 (make_symbol): Remove; unused.
11799 * lisp.h (initial_obarray, make_symbol): Remove decls.
11801 * keyboard.c: Make symbols static if they're not exported.
11802 (single_kboard, recent_keys_index, total_keys, recent_keys):
11803 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11804 (this_single_command_key_start, echoing, last_auto_save):
11805 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11806 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11807 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11808 (Vlispy_mouse_stem, double_click_count):
11810 (force_auto_save_soon): Define only if SIGDANGER.
11811 (ignore_mouse_drag_p): Now static if
11812 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11813 (print_help): Remove; unused.
11814 (stop_character, last_timer_event): Mark as externally visible.
11815 * keyboard.h (ignore_mouse_drag_p): Declare only if
11816 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11817 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11818 * lisp.h (echoing): Remove decl.
11819 (force_auto_save_soon): Declare only if SIGDANGER.
11820 * xdisp.c (redisplay_window): Simplify code, to make it more
11821 obvious that ignore_mouse_drag_p is not accessed if !defined
11822 USE_GTK && !defined HAVE_NS.
11824 * intervals.c: Make symbols static if they're not exported.
11825 (merge_properties_sticky, merge_interval_right, delete_interval):
11827 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11829 * insdel.c: Make symbols static if they're not exported.
11830 However, leave prepare_to_modify_buffer alone. It's never
11831 called from outside this function, but that appears to be a bug.
11832 (combine_after_change_list, combine_after_change_buffer):
11833 (adjust_after_replace, signal_before_change): Now static.
11834 (adjust_after_replace_noundo): Remove; unused.
11835 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11836 (signal_before_change): Remove decls.
11838 * indent.c (val_compute_motion, val_vmotion): Now static.
11840 * image.c: Make symbols static if they're not exported.
11841 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11843 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11844 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11846 * fringe.c (standard_bitmaps): Now static.
11847 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11849 * frame.c: Make symbols static if they're not exported.
11850 (x_report_frame_params, make_terminal_frame): Now static.
11851 (get_frame_param): Now static, unless HAVE_NS.
11852 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11853 (x_get_resource_string): Remove; not used.
11854 * frame.h (make_terminal_frame, x_report_frame_params):
11855 (x_get_resource_string); Remove decls.
11856 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11857 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11859 * font.c, fontset.c: Make symbols static if they're not exported.
11860 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11861 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11862 * font.c (font_close_object): Now static.
11863 * font.h (font_close_object): Remove.
11864 * fontset.c (FONTSET_OBJLIST): Remove.
11865 (free_realized_fontset) #if-0 the body, which does nothing.
11866 (face_suitable_for_char_p): #if-0, as it's never called.
11867 * fontset.h (face_suitable_for_char_p): Remove decl.
11868 * xfaces.c (face_at_string_position):
11869 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11870 since 0 is always ASCII.
11872 * fns.c (weak_hash_tables): Now static.
11874 * fileio.c: Make symbols static if they're not exported.
11875 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11876 (Vwrite_region_annotation_buffers): Now static.
11878 * eval.c: Make symbols static if they're not exported.
11879 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11880 * lisp.h (backtrace_list): Remove decl.
11882 * emacs.c: Make symbols static if they're not exported.
11883 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11884 (fatal_error_code, fatal_error_signal_hook, standard_args):
11886 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11887 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11888 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11889 * lisp.h (fatal_error_signal_hook): Remove decl.
11890 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11892 * editfns.c: Move a (normally-unused) function to its only use.
11893 * editfns.c, lisp.h (get_operating_system_release): Remove.
11894 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11895 worth the hassle of breaking this out.
11897 * xterm.c: Make symbols static if they're not exported.
11898 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11899 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11900 (x_destroy_window, x_delete_display):
11902 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11903 (x_mouse_leave): Remove; unused.
11904 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11905 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11906 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11908 (x_mouse_leave): Declare only if WINDOWSNT.
11909 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11910 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11913 * ftxfont.c: Make symbols static if they're not exported.
11914 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11916 * font.h (ftxfont_driver): Likewise.
11918 * xfns.c: Make symbols static if they're not exported.
11919 (x_last_font_name, x_display_info_for_name):
11920 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11921 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11922 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11923 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11924 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11925 (last_show_tip_args): Now static.
11926 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11927 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11928 (x_screen_planes): Remove; unused.
11929 * dispextern.h (x_screen_planes): Remove decl.
11931 * dispnew.c: Make symbols static if they're not exported.
11932 * dispextern.h (redraw_garbaged_frames, scrolling):
11933 (increment_row_positions): Remove.
11934 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11935 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11937 (redraw_garbaged_frames): Remove; unused.
11939 * xfaces.c: Make symbols static if they're not exported.
11940 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11942 * xterm.h (defined_color): Remove decls.
11943 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11944 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11945 (menu_face_changed_default, defined_color, free_realized_face):
11946 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11947 (ascii_face_of_lisp_face): Remove; unused.
11949 * xdisp.c: Make symbols static if they're not exported.
11950 * dispextern.h (scratch_glyph_row, window_box_edges):
11951 (glyph_to_pixel_coords, set_cursor_from_row):
11952 (get_next_display_element, set_iterator_to_next):
11953 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11954 (show_mouse_face): Remove decls
11955 * frame.h (message_buf_print): Likewise.
11956 * lisp.h (pop_message, set_message, check_point_in_composition):
11958 * xterm.h (set_vertical_scroll_bar): Likewise.
11959 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11960 (message_buf_print, scratch_glyph_row, displayed_buffer):
11961 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11962 (get_next_display_element, show_mouse_face, window_box_edges):
11963 (frame_to_window_pixel_xy, check_point_in_composition):
11964 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11965 (glyph_to_pixel_coords): Remove; unused.
11967 * dired.c (file_name_completion): Now static.
11969 * dbusbind.c (xd_in_read_queued_messages): Now static.
11971 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11972 * data.c (circular_list_error): Remove.
11974 * commands.h (last_point_position, last_point_position_buffer):
11975 (last_point_position_window): Remove decls.
11976 * keyboard.c: Make these variables static.
11978 * coding.h (coding, code_convert_region, encode_coding_gap):
11980 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11981 (iso_code_class, detect_coding, code_convert_region): Now static.
11982 (encode_coding_gap): Remove; unused.
11984 * chartab.c (chartab_chars, chartab_bits): Now static.
11986 * charset.h (charset_iso_8859_1): Remove decl.
11987 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11990 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11991 * ccl.c (Vccl_program_table): Now static.
11992 (check_ccl_update): Remove; unused.
11994 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11995 * category.h: ... from here.
11996 * category.c (check_category_table, set_category_set): Now static.
11998 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11999 * lisp.h: Remove these decls.
12001 * buffer.c (buffer_count): Remove unused var.
12003 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12004 so that it's not optimized away.
12005 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12006 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12007 exported only to the debugger.
12009 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12010 * atimer.h (run_all_atimers): Remove; not exported.
12012 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12013 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12014 was inaccessible from Lisp.
12015 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12016 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12018 alloc.c: Import and export fewer symbols, and remove unused items.
12019 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12021 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12022 it's not optimized away by whole-program optimization.
12023 (message_enable_multibyte, free_misc): Remove.
12024 (catchlist, handlerlist, mark_backtrace):
12025 Declare only if BYTE_MARK_STACK.
12026 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12027 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12028 (message_enable_multibyte): Remove decl.
12029 (free_misc, interval_free_list, float_block, float_block_index):
12030 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12031 (cons_free_list, last_marked_index):
12033 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12034 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12035 (mark_backtrace): Define only if BYTE_MARK_STACK.
12036 * xdisp.c (message_enable_multibyte): Now static.
12038 Declare Lisp_Object Q* variables to be 'static' if not exported.
12039 This makes it easier for human readers (and static analyzers)
12040 to see whether these variables are used from other modules.
12041 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12042 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12043 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12044 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12045 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12046 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12047 * xmenu.c, xselect.c:
12048 Declare Q* vars static if they are not used in other modules.
12049 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12050 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12051 Remove decls of unexported vars.
12052 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12054 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12056 Make Emacs functions such as Fatom 'static' by default.
12057 This makes it easier for human readers (and static analyzers)
12058 to see whether these functions can be called from other modules.
12059 DEFUN now defines a static function. To make the function external
12060 so that it can be used in other C modules, use the new macro DEFUE.
12061 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12062 (Finit_image_library):
12063 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12064 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12065 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12066 Remove decls, since these functions are now static.
12067 (Funintern, Fget_internal_run_time): New decls, since these functions
12068 were already external.
12070 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12071 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12072 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12073 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12074 * keyboard.c, keymap.c, lread.c:
12075 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12076 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12077 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12078 Mark functions with DEFUE instead of DEFUN,
12079 if they are used in other modules.
12080 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12081 decls for now-static functions.
12082 * buffer.h (Fdelete_overlay): Remove decl.
12083 * callproc.c (Fgetenv_internal): Mark as internal.
12084 * composite.c (Fremove_list_of_text_properties): Remove decl.
12085 (Fcomposition_get_gstring): New forward static decl.
12086 * composite.h (Fcomposite_get_gstring): Remove decl.
12087 * dired.c (Ffile_attributes): New forward static decl.
12088 * doc.c (Fdocumntation_property): New forward static decl.
12089 * eval.c (Ffetch_bytecode): New forward static decl.
12090 (Funintern): Remove extern decl; now in .h file where it belongs.
12091 * fileio.c (Fmake_symbolic_link): New forward static decl.
12092 * image.c (Finit_image_library): New forward static decl.
12093 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12094 * intervals.h (Fprevious_property_change):
12095 (Fremove_list_of_text_properties): Remove decls.
12096 * keyboard.c (Fthis_command_keys): Remove decl.
12097 (Fcommand_execute): New forward static decl.
12098 * keymap.c (Flookup_key): New forward static decl.
12099 (Fcopy_keymap): Now static.
12100 * keymap.h (Flookup_key): Remove decl.
12101 * process.c (Fget_process): New forward static decl.
12102 (Fprocess_datagram_address): Mark as internal.
12103 * syntax.c (Fsyntax_table_p): New forward static decl.
12104 (skip_chars): Remove duplicate decl.
12105 * textprop.c (Fprevious_property_change): New forward static decl.
12106 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12108 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12109 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12111 * editfns.c (Fformat): Remove unreachable code.
12113 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12115 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12118 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12120 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12121 when at ZV. (Bug#8487)
12123 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12125 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12127 * keyboard.c (parse_tool_bar_item): Likewise.
12128 * sound.c (sound_cleanup, alsa_close): Likewise.
12129 * termcap.c (tgetent): Likewise.
12130 * xfns.c (x_default_font_parameter): Likewise.
12131 * xsettings.c (read_and_apply_settings): Likewise.
12133 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12134 (overrun_check_free): Protoize.
12136 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12138 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12139 since callers should never pass a negative size.
12140 Change the signature to match that of plain 'read' and 'write'; see
12141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12142 * lisp.h: Update prototypes of emacs_write and emacs_read.
12144 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12146 * xdisp.c (redisplay_window): Don't try to determine the character
12147 position of the scroll margin if the window start point w->startp
12148 is outside the buffer's accessible region. (Bug#8468)
12150 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12152 Fix write-region and its subroutines for buffers > 2GB.
12153 * fileio.c (a_write, e_write): Modify declaration of arguments and
12154 local variables to support buffers larger than 2GB.
12155 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12157 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12158 argument, local variables, and return value.
12160 * lisp.h: Update prototypes of emacs_write and emacs_read.
12162 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12164 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12166 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12168 Fix more problems found by GCC 4.6.0's static checks.
12170 * xdisp.c (vmessage): Use a better test for character truncation.
12172 * charset.c (load_charset_map): <, not <=, for optimization,
12173 and to avoid potential problems with integer overflow.
12174 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12175 * casetab.c (set_identity, shuffle): Likewise.
12176 * editfns.c (Fformat): Likewise.
12177 * syntax.c (skip_chars): Likewise.
12179 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12180 This also lets GCC 4.6.0 generate slightly better loop code.
12182 * callint.c (Fcall_interactively): <, not <=, for optimization.
12183 (Fcall_interactively): Count the number of arguments produced,
12184 not the number of arguments given. This is simpler and lets GCC
12185 4.6.0 generate slightly better code.
12187 * ftfont.c: Distingish more carefully between FcChar8 and char.
12188 The previous code passed unsigned char * to a functions like
12189 strlen and xstrcasecmp that expect char *, which does not
12190 conform to the C standard.
12191 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12192 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12193 char * when the C standard requires it.
12195 * keyboard.c (read_char): Remove unused var.
12197 * eval.c: Port to Windows vsnprintf (Bug#8435).
12198 Include <limits.h>.
12199 (SIZE_MAX): Define if the headers do not.
12200 (verror): Do not give up if vsnprintf returns a negative count.
12201 Instead, grow the buffer. This ports to Windows vsnprintf, which
12202 does not conform to C99. Problem reported by Eli Zaretskii.
12203 Also, simplify the allocation scheme, by avoiding the need for
12204 calling realloc, and removing the ALLOCATED variable.
12206 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12208 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12209 But keep the doprint source code for now, as we might revamp it
12210 and use it again (Bug#8435).
12211 * lisp.h (doprnt): Remove.
12212 * Makefile.in (base_obj): Remove doprnt.o.
12213 * deps.mk (doprnt.o): Remove.
12215 error: Print 32- and 64-bit integers portably (Bug#8435).
12216 Without this change, on typical 64-bit hosts error ("...%d...", N)
12217 was used to print both 32- and 64-bit integers N, which relied on
12218 undefined behavior.
12219 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12220 * lisp.h (error, verror): Mark as printf-like functions.
12221 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12222 Report overflow in size calculations when allocating printf buffer.
12223 Do not truncate output string at its first null byte.
12224 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12225 Truncate the output at a character boundary, since vsnprintf does not
12227 * charset.c (check_iso_charset_parameter): Convert internal
12228 character to string before calling 'error', since %c now has the
12230 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12231 overflow when computing char to be passed to 'error'. Do not
12232 pass Lisp_Object to 'error'; pass the integer instead.
12233 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12234 formatted with plain %d.
12236 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12238 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12240 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12242 * xterm.c (x_catch_errors): Remove duplicate declaration.
12244 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12246 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12248 2011-04-10 Jim Meyering <meyering@redhat.com>
12250 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12251 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12252 return ssize_t not "int", and use size_t as the buffer length.
12253 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12254 * gnutls.h: Update declarations.
12255 * process.c (read_process_output): Use ssize_t, to match.
12256 (send_process): Likewise.
12258 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12260 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12262 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12264 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12265 Use unsigned char, to match FcChar8 type definition.
12267 * xterm.c (handle_one_xevent):
12268 * xmenu.c (create_and_show_popup_menu):
12269 * xselect.c (x_decline_selection_request)
12270 (x_reply_selection_request): Avoid type-punned deref of X events.
12272 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12274 Fix some uses of `int' instead of EMACS_INT.
12275 * search.c (string_match_1, fast_string_match)
12276 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12277 (scan_buffer, find_next_newline_no_quit)
12278 (find_before_next_newline, search_command, Freplace_match)
12279 (Fmatch_data): Make some `int' variables be EMACS_INT.
12281 * xdisp.c (display_count_lines): 3rd argument and return value now
12282 EMACS_INT. All callers changed.
12283 (pint2hrstr): Last argument is now EMACS_INT.
12285 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12286 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12287 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12288 (decode_coding_utf_16, decode_coding_emacs_mule)
12289 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12290 (decode_coding_ccl, decode_coding_charset)
12291 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12292 (decode_coding_iso_2022, decode_coding_emacs_mule)
12293 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12294 <char_offset, last_offset>: Declare EMACS_INT.
12295 (encode_coding_utf_8, encode_coding_utf_16)
12296 (encode_coding_emacs_mule, encode_invocation_designation)
12297 (encode_designation_at_bol, encode_coding_iso_2022)
12298 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12299 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12301 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12302 (encode_invocation_designation): Last argument P_NCHARS is now
12304 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12305 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12307 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12310 * ccl.c (Fccl_execute_on_string): Declare some variables
12313 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12315 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12317 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12319 * process.c (Fformat_network_address): Doc fix.
12321 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12323 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12325 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12327 * keyboard.c (read_char): Call Lisp function help-form-show,
12328 instead of using internal_with_output_to_temp_buffer.
12329 (Qhelp_form_show): New var.
12330 (syms_of_keyboard): Use DEFSYM macro.
12332 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12334 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12336 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12338 * process.c (Flist_processes): Remove to Lisp.
12339 (list_processes_1): Delete.
12341 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12343 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12345 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12347 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12349 Fix more problems found by GCC 4.6.0's static checks.
12351 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12353 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12355 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12357 * xdisp.c (vmessage): Mark as a printf-like function.
12359 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12361 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12363 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12364 printf-like functions.
12365 (tiff_load): Add casts to remove these marks before passing them
12366 to system-supplied API.
12368 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12370 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12371 This avoids several warnings with gcc -Wstrict-overflow.
12372 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12373 directly, rather than having caller test rule sign. This avoids
12374 some unnecessary tests.
12375 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12376 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12377 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12379 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12380 (xfont_open): Avoid unnecessary tests.
12382 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12384 * composite.h, composite.c (composition_gstring_put_cache):
12385 Use EMACS_INT, not int, for length.
12387 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12388 breaking out part of COMPOSITION_DECODE_RULE.
12389 (COMPOSITION_DECODE_RULE): Use it.
12390 * composite.c (get_composition_id): Remove unused local vars,
12391 by using the new macro.
12393 * textprop.c (set_text_properties_1): Change while to do-while,
12394 since the condition is always true at first.
12396 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12397 (interval_deletion_adjustment): Return unsigned value.
12400 * process.c (list_processes_1, create_pty, read_process_output):
12401 (exec_sentinel): Remove vars that were set but not used.
12402 (create_pty): Remove unnecessary "volatile"s.
12403 (Fnetwork_interface_info): Avoid possibility of int overflow.
12404 (read_process_output): Do adaptive read buffering even if carryover.
12405 (read_process_output): Simplify nbytes computation if buffered.
12407 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12409 * syntax.c (scan_words): Remove var that was set but not used.
12410 (update_syntax_table): Use unsigned instead of int.
12412 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12413 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12414 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12416 * print.c (print_error_message): Avoid int overflow.
12418 * font.c (font_list_entities): Redo for clarity,
12419 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12421 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12422 (font_score): Avoid potential overflow in diff calculation.
12424 * fns.c (substring_both): Remove var that is set but not used.
12425 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12427 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12429 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12430 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12431 can always succeed if overflow has undefined behavior.
12433 * search.c (boyer_moore, wordify): Remove vars set but not used.
12434 (wordify): Omit three unnecessary tests.
12436 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12437 All callers changed. This avoids the need for an unused var.
12439 * casefiddle.c (casify_region): Remove var that is set but not used.
12441 * dired.c (file_name_completion): Remove var that is set but not used.
12443 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12445 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12446 (Finsert_file_contents): Remove unnecessary code checking fd.
12448 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12449 Check for integer overflow on size calculations.
12451 * buffer.c (Fprevious_overlay_change): Remove var that is set
12454 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12455 Remove vars that are set but not used.
12456 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12457 (timer_check_2): Mark vars as initialized.
12459 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12461 * image.c (lookup_image): Remove var that is set but not used.
12462 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12464 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12465 that are set but not used.
12467 * xfns.c (make_invisible_cursor): Don't return garbage
12468 if XCreateBitmapFromData fails (Bug#8410).
12470 * xselect.c (x_get_local_selection, x_handle_property_notify):
12471 Remove vars that are set but not used.
12473 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12474 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12476 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12477 Remove var that is set but not used.
12478 (scroll_bar_windows_size): Now size_t, not int.
12479 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12480 Check for overflow.
12482 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12483 (map_tty_color) [!defined MSDOS]: Likewise.
12485 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12487 * coding.c: Remove vars that are set but not used.
12488 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12489 All callers changed.
12490 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12491 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12492 (decode_coding_charset): Remove vars that are set but not used.
12494 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12495 that is set but not used.
12497 * print.c (print_object): Remove var that is set but not used.
12499 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12500 The gnulib version avoids calling malloc in the usual case,
12501 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12502 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12503 * filelock.c (current_lock_owner): Likewise.
12504 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12505 * sysdep.c: Include allocator.h, careadlinkat.h.
12506 (emacs_no_realloc_allocator): New static constant.
12507 (emacs_readlink): New function.
12508 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12509 ../lib/careadlinkat.h.
12511 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12513 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12514 first non-nil return value).
12516 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12518 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12519 if not defined (Bug#8403).
12521 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12523 * xdisp.c (display_count_lines): Remove parameter `start',
12524 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12525 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12526 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12527 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12528 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12529 and thereabouts. All callers changed.
12530 (get_per_char_metric): Remove parameter `f', unused since
12531 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12533 2011-04-02 Jim Meyering <meyering@redhat.com>
12535 do not dereference NULL upon failed strdup
12536 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12537 (ns_get_family): Likewise.
12539 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12541 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12543 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12545 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12548 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12550 Add lexical binding.
12552 * window.c (Ftemp_output_buffer_show): New fun.
12553 (Fsave_window_excursion):
12554 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12556 * lread.c (lisp_file_lexically_bound_p): New function.
12557 (Fload): Bind Qlexical_binding.
12558 (readevalloop): Remove `evalfun' arg.
12559 Bind Qinternal_interpreter_environment.
12560 (Feval_buffer): Bind Qlexical_binding.
12561 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12563 (syms_of_lread): Declare `lexical-binding'.
12565 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12567 * keyboard.c (eval_dyn): New fun.
12568 (menu_item_eval_property): Use it.
12570 * image.c (parse_image_spec): Use Ffunctionp.
12572 * fns.c (concat, mapcar1): Accept byte-code-functions.
12574 * eval.c (Fsetq): Handle lexical vars.
12575 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12576 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12577 (FletX, Flet): Obey lexical binding.
12578 (Fcommandp): Handle closures.
12579 (Feval): New `lexical' arg.
12580 (eval_sub): New function extracted from Feval. Use it almost
12581 everywhere where Feval was used. Look up vars in lexical env.
12583 (Ffunctionp): Move from subr.el.
12584 (Ffuncall): Handle closures.
12585 (apply_lambda): Remove `eval_flags'.
12586 (funcall_lambda): Handle closures and new byte-code-functions.
12587 (Fspecial_variable_p): New function.
12588 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12589 but without exporting it to Lisp.
12591 * doc.c (Fdocumentation, store_function_docstring):
12592 * data.c (Finteractive_form): Handle closures.
12594 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12597 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12599 (exec_byte_code): New function extracted from Fbyte_code to handle new
12600 calling convention for byte-code-functions. Add new byte-codes.
12602 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12604 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12606 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12608 * xdisp.c (redisplay_internal): Fix prototype.
12610 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12612 * xdisp.c (SCROLL_LIMIT): New macro.
12613 (try_scrolling): Use it when setting scroll_limit.
12614 Limit scrolling to 100 screen lines.
12615 (redisplay_window): Even when falling back on "recentering",
12616 position point in the window according to scroll-conservatively,
12617 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12619 (try_scrolling): When point is above the window, allow searching
12620 as far as scroll_max, or one screenful, to compute vertical
12621 distance from PT to the scroll margin position. This prevents
12622 try_scrolling from unnecessarily failing when
12623 scroll-conservatively is set to a value slightly larger than the
12624 window height. Clean up the case of PT below the margin at bottom
12625 of window: scroll_max can no longer be INT_MAX. When aggressive
12626 scrolling is in use, don't let point enter the opposite scroll
12627 margin as result of the scroll.
12628 (syms_of_xdisp) <scroll-conservatively>: Document the
12629 threshold of 100 lines for never-recentering scrolling.
12631 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12633 * dispextern.h (move_it_by_lines):
12634 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12635 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12636 (message_log_check_duplicate): Remove parameters `prev_bol' and
12637 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12638 (redisplay_internal): Remove parameter `preserve_echo_area',
12639 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12641 * indent.c (Fvertical_motion):
12642 * window.c (window_scroll_pixel_based, Frecenter):
12643 Don't pass `need_y_p' to `move_it_by_lines'.
12645 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12647 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12648 steal a few bits to be more compact.
12649 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12650 Remove unneeded casts.
12652 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12654 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12656 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12657 binding" message (bug#7967).
12659 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12661 Fix more problems found by GCC 4.6.0's static checks.
12663 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12664 Remove unused local var.
12666 * editfns.c (Fmessage_box): Remove unused local var.
12668 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12669 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12670 Omit unused local vars.
12671 * window.c (shrink_windows): Omit unused local var.
12672 * menu.c (digest_single_submenu): Omit unused local var.
12673 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12674 Omit unused local var.
12676 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12677 Don't assume string length fits in int.
12678 (keyremap_step, read_key_sequence): Use size_t for sizes.
12679 (read_key_sequence): Don't check last_real_key_start redundantly.
12681 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12682 instead of alloca (Bug#8344).
12684 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12685 (Fbacktrace_frame): Don't assume nframes fits in int.
12687 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12689 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12692 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12694 * cm.c (calccost): Turn while-do into do-while, for clarity.
12696 * keyboard.c (syms_of_keyboard): Use the same style as later
12697 in this function when indexing through an array. This also
12698 works around GCC bug 48267.
12700 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12702 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12704 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12705 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12707 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12708 This avoids undefined behavior on integer overflow, and is a bit
12709 more convenient anyway since it is compared to a size_t variable.
12711 Variadic C functions now count arguments with size_t, not int.
12712 This avoids an unnecessary limitation on 64-bit machines, which
12713 caused (substring ...) to crash on large vectors (Bug#8344).
12714 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12715 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12716 All variadic functions and their callers changed accordingly.
12717 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12718 * data.c (arith_driver, float_arith_driver): Likewise.
12719 * editfns.c (general_insert_function): Likewise.
12720 * eval.c (struct backtrace.nargs, interactive_p)
12721 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12722 (funcall_lambda, mark_backtrace): Likewise.
12723 * fns.c (concat): Likewise.
12724 * frame.c (x_set_frame_parameters): Likewise.
12725 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12726 0 if not found, not -1. All callers changed.
12728 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12729 (stack_copy_size): Now size_t, not int.
12730 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12732 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12734 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12735 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12736 All callers changed.
12738 * lisp.h (multibyte_char_to_unibyte):
12739 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12740 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12741 * character.h (CHAR_TO_BYTE8):
12742 * cmds.c (internal_self_insert):
12743 * editfns.c (general_insert_function):
12744 * keymap.c (push_key_description):
12745 * search.c (Freplace_match):
12746 * xdisp.c (message_dolog, set_message_1): All callers changed.
12748 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12750 * keyboard.c (safe_run_hook_funcall): New function.
12751 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12752 don't set the hook to nil, but remove the offending function instead.
12753 (Qcommand_hook_internal): Remove, unused.
12754 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12755 Vcommand_hook_internal.
12757 * eval.c (enum run_hooks_condition): Remove.
12758 (funcall_nil, funcall_not): New functions.
12759 (run_hook_with_args): Call each function through a `funcall' argument.
12760 Remove `cond' argument, now redundant.
12761 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12762 (Frun_hook_with_args_until_failure): Adjust accordingly.
12763 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12765 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12767 * dispextern.h (string_buffer_position): Remove declaration.
12769 * print.c (strout): Remove parameter `multibyte', unused since
12770 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12772 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12773 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12774 All callers changed.
12776 * w32.c (_wsa_errlist): Use braces for struct initializers.
12778 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12779 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12780 All callers changed.
12781 (string_buffer_position): Likewise. Also, make static (it's never
12782 used outside xdisp.c).
12783 (cursor_row_p): Remove parameter `w', unused since
12784 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12785 (decode_mode_spec): Remove parameter `precision', introduced during
12786 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12787 All callers changed.
12789 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12791 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12793 2011-03-27 Anders Lindgren <andlind@gmail.com>
12795 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12796 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12797 (ns_update_auto_hide_menu_bar): New functions.
12798 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12799 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12800 ns_constrain_all_frames.
12801 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12802 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12804 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12806 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12808 2011-03-27 Glenn Morris <rgm@gnu.org>
12810 * syssignal.h: Replace RETSIGTYPE with void.
12811 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12812 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12813 Replace SIGTYPE with void everywhere.
12814 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12815 * s/template.h (SIGTYPE): Remove commented out definition.
12817 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12819 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12820 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12822 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12824 * w32.c (read_unc_volume): Use parameter `henum', instead of
12825 global variable `wget_enum_handle'.
12827 * keymap.c (describe_vector): Remove parameters `indices' and
12828 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12829 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12831 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12833 * keyboard.c (timer_check): Remove parameter `do_it_now',
12834 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12835 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12836 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12838 * keyboard.c (read_char):
12839 * w32menu.c (w32_menu_display_help):
12840 * xmenu.c (show_help_event, menu_help_callback):
12841 Adjust calls to `show_help_echo'.
12843 * gtkutil.c (xg_maybe_add_timer):
12844 * keyboard.c (readable_events):
12845 * process.c (wait_reading_process_output):
12846 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12848 * insdel.c (adjust_markers_gap_motion):
12849 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12850 (gap_left, gap_right): Don't call it.
12852 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12854 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12855 incurred during fontification.
12857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12859 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12860 (DEFVAR_PER_BUFFER): Don't pass it.
12862 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12863 (scrolling_window): Don't pass it.
12865 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12867 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12869 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12871 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12872 of variables specific to SELinux and computation of `encoded_absname'.
12874 * image.c (XPutPixel): Remove unused variable `height'.
12876 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12878 * unexw32.c (get_section_info): Remove unused variable `section'.
12880 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12881 (system_process_attributes): Remove unused variable `sess'.
12882 (sys_read): Remove unused variable `err'.
12884 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12885 (w32_wnd_proc): Remove unused variable `isdead'.
12886 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12887 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12888 (x_create_tip_frame): Remove unused variable `tem'.
12890 * w32inevt.c (w32_console_read_socket):
12891 Remove unused variable `no_events'.
12893 * w32term.c (x_draw_composite_glyph_string_foreground):
12894 Remove unused variable `width'.
12896 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12898 * w32term.c (x_set_glyph_string_clipping):
12899 Don't pass uninitialized region to CombineRgn.
12901 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12903 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12904 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12905 (Fx_close_connection): Remove unused variable `i'.
12907 * w32font.c (w32font_draw): Return number of glyphs.
12908 (w32font_open_internal): Remove unused variable `i'.
12909 (w32font_driver): Add missing initializer.
12911 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12912 (fill_in_menu): Remove unused variable `items_added'.
12914 * w32term.c (last_mouse_press_frame): Remove static global variable.
12915 (w32_clip_to_row): Remove unused variable `f'.
12916 (x_delete_terminal): Remove unused variable `i'.
12918 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12919 (NOTHING): Remove unused static global variable.
12920 (uniscribe_check_otf): Remove unused variable `table'.
12921 (uniscribe_font_driver): Add missing initializers.
12923 2011-03-23 Julien Danjou <julien@danjou.info>
12925 * term.c (Fsuspend_tty, Fresume_tty):
12926 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12927 * window.c (temp_output_buffer_show):
12928 * insdel.c (signal_before_change):
12929 * frame.c (Fhandle_switch_frame):
12930 * fileio.c (Fdo_auto_save):
12931 * emacs.c (Fkill_emacs):
12932 * editfns.c (save_excursion_restore):
12933 * cmds.c (internal_self_insert):
12934 * callint.c (Fcall_interactively):
12935 * buffer.c (Fkill_all_local_variables):
12936 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12938 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12939 unconditionally since it does the check itself.
12941 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12943 Fix more problems found by GCC 4.5.2's static checks.
12945 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12946 the first time through the loop, since we know p0 < p1 then.
12947 This also avoids a gcc -Wstrict-overflow warning.
12949 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12950 leading to a memory leak, possible in functions like
12951 load_charset_map_from_file that can allocate an unbounded number
12952 of objects (Bug#8318).
12954 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12955 that could (at least in theory) be that large.
12957 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12958 This is less likely to overflow, and avoids undefined behavior if
12959 overflow does occur. All callers changed. Use strtoul to scan
12960 for the unsigned long integer.
12961 (pint2hrstr): Simplify and tune code slightly.
12962 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12964 * scroll.c (do_scrolling): Work around GCC bug 48228.
12965 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12967 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12968 This also avoids a warning with gcc -Wstrict-overflow.
12969 (validate_x_resource_name): Simplify count usage.
12970 This also avoids a warning with gcc -Wstrict-overflow.
12972 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12975 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12977 * process.c (Fmake_network_process): Use socklen_t, not int,
12978 where POSIX says socklen_t is required in portable programs.
12979 This fixes a porting bug on hosts like 64-bit HP-UX, where
12980 socklen_t is wider than int (Bug#8277).
12981 (Fmake_network_process, server_accept_connection):
12982 (wait_reading_process_output, read_process_output):
12985 * process.c: Rename or move locals to avoid shadowing.
12986 (list_processes_1, Fmake_network_process):
12987 (read_process_output_error_handler, exec_sentinel_error_handler):
12988 Rename or move locals.
12989 (Fmake_network_process): Define label "retry_connect" only if needed.
12990 (Fnetwork_interface_info): Fix pointer signedness.
12991 (process_send_signal): Add cast to avoid pointer signedness problem.
12992 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12993 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12995 Make tparam.h and terminfo.c consistent.
12996 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12997 Include tparam.h instead, since it declares them.
12998 * cm.h (PC): Remove extern decl; tparam.h now does this.
12999 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13000 * terminfo.c: Include tparam.h, to check interfaces.
13001 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13002 (tparam): Adjust signature to match interface in tparam.h;
13003 this removes some undefined behavior. Check that outstring and len
13004 are zero, which they always are with Emacs.
13005 * tparam.h (PC, BC, UP): New extern decls.
13007 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13008 (xftfont_open): Rename locals to avoid shadowing.
13010 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13011 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13012 (OTF_TAG_SYM): Omit macro if not needed.
13013 (ftfont_list): Remove unused local.
13014 (get_adstyle_property, ftfont_pattern_entity):
13015 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13016 Rename locals to avoid shadowing.
13018 * xfont.c (xfont_list_family): Mark var as initialized.
13020 * xml.c (make_dom): Now static.
13022 * composite.c (composition_compute_stop_pos): Rename local to
13024 (composition_reseat_it): Remove unused locals.
13025 (find_automatic_composition, composition_adjust_point): Likewise.
13026 (composition_update_it): Mark var as initialized.
13027 (find_automatic_composition): Mark vars as initialized,
13028 with a FIXME (Bug#8290).
13030 character.h: Rename locals to avoid shadowing.
13031 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13032 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13033 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13034 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13035 to avoid shadowing.
13037 * textprop.c (property_change_between_p): Remove; unused.
13039 * intervals.c (interval_start_pos): Now static.
13041 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13043 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13044 Rename locals to avoid shadowing.
13046 * sound.c (wav_play, au_play, Fplay_sound_internal):
13047 Fix pointer signedness.
13048 (alsa_choose_format): Remove unused local var.
13049 (wav_play): Initialize a variable to 0, to prevent undefined
13050 behavior (Bug#8278).
13052 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13054 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13056 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13057 clobbering (Bug#8298).
13058 * sysdep.c (sys_subshell): Likewise.
13059 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13061 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13062 This should get cleaned up, so that child_setup has the
13063 same signature on all platforms.
13065 * callproc.c (call_process_cleanup): Now static.
13066 (relocate_fd): Rename locals to avoid shadowing.
13068 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13070 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13071 not to be necessary, and produces flickering.
13073 2011-03-20 Glenn Morris <rgm@gnu.org>
13075 * config.in: Remove file.
13077 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13079 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13080 are now in src/globals.h.
13081 (syms_of_minibuf): Remove spurious & from previous change.
13083 2011-03-20 Leo Liu <sdl.web@gmail.com>
13085 * minibuf.c (completing-read-function): New variable.
13086 (completing-read-default): Rename from completing-read.
13087 (completing-read): Call completing-read-function.
13089 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13091 * xfaces.c (Fx_load_color_file):
13092 Read color file from absolute filename (bug#8250).
13094 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13096 * makefile.w32-in: Update dependencies.
13098 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13100 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13102 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13104 Fix more problems found by GCC 4.5.2's static checks.
13106 * process.c (make_serial_process_unwind, send_process_trap):
13107 (sigchld_handler): Now static.
13109 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13110 That way, the code declares only the vars that it needs.
13111 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13112 * s/cygwin.h (PTY_ITERATION): Likewise.
13113 * s/darwin.h (PTY_ITERATION): Likewise.
13114 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13116 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13117 * process.c (allocate_pty): Don't declare stb unless it's needed.
13119 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13120 (CONSTANTLIM): Remove; unused.
13121 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13122 Define only if needed.
13124 * unexelf.c (unexec): Name an expression,
13125 to avoid gcc -Wbad-function-cast warning.
13126 Use a different way to cause a compilation error if anyone uses
13127 n rather than nn, a way that does not involve shadowing.
13128 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13130 * deps.mk (unexalpha.o): Remove; unused.
13132 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13133 * unexec.h: New file.
13134 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13135 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13136 Depend on unexec.h.
13137 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13138 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13139 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13140 Change as necessary to match prototype in unexec.h.
13142 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13144 (back_comment, skip_chars): Mark vars as initialized.
13146 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13147 Rename locals to avoid shadowing.
13149 * lread.c (read1): Rewrite so as not to use empty "else".
13150 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13152 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13154 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13155 warning when compiling print.c.
13157 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13158 instead of using an uninitialized var.
13159 (font_sort_entities): Mark var as initialized.
13161 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13163 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13164 pointers to constants.
13165 (font_parse_fcname): Remove unused vars.
13166 (font_delete_unmatched): Now static.
13167 (font_get_spec): Remove; unused.
13168 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13169 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13170 Rename or move locals to avoid shadowing.
13172 * fns.c (require_nesting_list, require_unwind): Now static.
13173 (Ffillarray): Rename locals to avoid shadowing.
13175 * floatfns.c (domain_error2): Define only if needed.
13176 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13178 * alloc.c (mark_backtrace): Move decl from here ...
13179 * lisp.h: ... to here, so that it can be checked.
13181 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13182 (Fdefvar): Rewrite so as not to use empty "else".
13183 (lisp_indirect_variable): Name an expression,
13184 to avoid gcc -Wbad-function-cast warning.
13185 (Fdefvar): Rename locals to avoid shadowing.
13187 * callint.c (quotify_arg, quotify_args): Now static.
13188 (Fcall_interactively): Rename locals to avoid shadowing.
13189 Use const pointer when appropriate.
13191 * lisp.h (get_system_name, get_operating_system_release):
13192 Move decls here, to check interfaces.
13193 * process.c (get_operating_system_release): Move decl to lisp.h.
13194 * xrdb.c (get_system_name): Likewise.
13195 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13196 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13197 some of which prompt warnings from gcc -Wbad-function-cast.
13198 (Fformat_time_string, Fencode_time, Finsert_char):
13199 (Ftranslate_region_internal, Fformat):
13200 Rename or remove local vars to avoid shadowing.
13201 (Ftranslate_region_internal): Mark var as initialized.
13203 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13206 * lisp.h (eassert): Check that the argument compiles, even if
13207 ENABLE_CHECKING is not defined.
13209 * data.c (Findirect_variable): Name an expression, to avoid
13210 gcc -Wbad-function-cast warning.
13211 (default_value, arithcompare, arith_driver, arith_error): Now static.
13212 (store_symval_forwarding): Rename local to avoid shadowing.
13213 (Fmake_variable_buffer_local, Fmake_local_variable):
13214 Mark variables as initialized.
13215 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13217 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13218 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13219 Rename locals to avoid shadowing.
13220 (mark_stack): Move local variables into the #ifdef region where
13222 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13223 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13225 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13226 (GC_STRING_CHARS): Remove; not used.
13227 (Fmemory_limit): Cast sbrk's returned value to char *.
13229 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13230 avoids undefined behavior in theory.
13232 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13234 Use functions, not macros, for up- and down-casing (Bug#8254).
13235 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13236 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13237 to use the following functions instead of these macros.
13238 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13239 EMACS_INT, since callers assume the returned value fits in int.
13240 (upcase1): Likewise, for UPCASE_TABLE.
13241 (uppercasep, lowercasep, upcase): New static inline functions.
13242 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13243 the race-condition problem in the old DOWNCASE.
13245 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13246 Rename locals to avoid shadowing.
13247 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13248 (regex_compile, re_search_2, re_match_2_internal):
13249 Remove unused local vars.
13250 (FREE_VAR): Rewrite so as not to use empty "else",
13251 which gcc can warn about.
13252 (regex_compile, re_match_2_internal): Mark locals as initialized.
13253 (RETALLOC_IF): Define only if needed.
13254 (WORDCHAR_P): Likewise. This one is never needed, but is used
13255 only in a comment talking about a compiler bug, so put inside
13256 the #if 0 of that comment.
13257 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13258 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13261 * search.c (boyer_moore): Rename locals to avoid shadowing.
13262 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13263 (PREV_CHAR_BOUNDARY): Likewise.
13265 * search.c (simple_search): Remove unused var.
13267 * dired.c (compile_pattern): Move decl from here ...
13268 * lisp.h: ... to here, so that it can be checked.
13269 (struct re_registers): New forward decl.
13271 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13273 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13275 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13276 Rename locals to avoid shadowing.
13277 (Fvertical_motion): Mark locals as initialized.
13279 * casefiddle.c (casify_object, casify_region): Now static.
13280 (casify_region): Mark local as initialized.
13282 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13284 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13285 New macros, so that the caller can use some names other than
13286 gcpro1, gcpro2, etc.
13287 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13289 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13290 argument, for consistency with GCPRO2_VAR, etc: it is now the
13291 prefix of the variable, not the variable itself. All uses
13293 * dired.c (directory_files_internal, file_name_completion):
13294 Rename locals to avoid shadowing.
13296 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13297 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13298 dired.c's scmp function, had undefined behavior.
13299 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13300 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13301 * buffer.h: ... to here, because these macros use current_buffer,
13302 and the new implementation with inline functions needs to have
13303 current_buffer in scope now, rather than later when the macros
13305 (downcase, upcase1): New static inline functions.
13306 (DOWNCASE, UPCASE1): Reimplement using these functions.
13307 This avoids undefined behavior in expressions like
13308 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13309 from race conditions in accessing the global variables
13310 case_temp1 and case_temp2.
13311 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13312 * lisp.h (case_temp1, case_temp2): Remove their decls.
13313 * character.h (ASCII_CHAR_P): Move from here ...
13314 * lisp.h: ... to here, so that the inline functions mentioned
13315 above can use them.
13317 * dired.c (directory_files_internal_unwind): Now static.
13319 * fileio.c (file_name_as_directory, directory_file_name):
13320 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13322 (file_name_as_directory): Use const pointers when appropriate.
13323 (Fexpand_file_name): Likewise. In particular, newdir might
13324 point at constant storage, so make it a const pointer.
13325 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13326 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13328 (Fset_file_times, Finsert_file_contents, auto_save_error):
13329 Rename locals to avoid shadowing.
13331 * minibuf.c (choose_minibuf_frame_1): Now static.
13332 (Ftry_completion, Fall_completions): Rename or remove locals
13333 to avoid shadowing.
13335 * marker.c (bytepos_to_charpos): Remove; unused.
13337 * lisp.h (verify_bytepos, count_markers): New decls,
13338 so that gcc does not warn that these functions aren't declared.
13340 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13341 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13342 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13343 (copy_text): Remove unused local var.
13345 * filelock.c (within_one_second): Now static.
13346 (lock_file_1): Rename local to avoid shadowing.
13348 * buffer.c (fix_overlays_before): Mark locals as initialized.
13349 (fix_start_end_in_overlays): Likewise. This function should be
13350 simplified by using pointers-to-pointers, but that's a different
13352 (switch_to_buffer_1): Now static.
13353 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13354 (report_overlay_modification): Rename locals to avoid shadowing.
13356 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13357 Fix pointer signedness issue.
13358 (sys_subshell): Mark local as volatile if checking for lint,
13359 to suppress a gcc -Wclobbered warning that does not seem to be right.
13360 (MAXPATHLEN): Define only if needed.
13362 * process.c (serial_open, serial_configure): Move decls from here ...
13363 * systty.h: ... to here, so that they can be checked.
13365 * fns.c (get_random, seed_random): Move extern decls from here ...
13366 * lisp.h: ... to here, so that they can be checked.
13368 * sysdep.c (reset_io): Now static.
13369 (wait_for_termination_signal): Remove; unused.
13371 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13372 (copy_keymap_item, append_key, push_text_char_description):
13374 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13375 (DENSE_TABLE_SIZE): Remove; unused.
13376 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13377 (describe_map_tree):
13378 Rename locals to avoid shadowing.
13380 * keyboard.c: Declare functions static if they are not used elsewhere.
13381 (echo_char, echo_dash, cmd_error, top_level_2):
13382 (poll_for_input, handle_async_input): Now static.
13383 (read_char, kbd_buffer_get_event, make_lispy_position):
13384 (make_lispy_event, make_lispy_movement, apply_modifiers):
13385 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13386 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13387 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13388 (read_key_sequence, read_char): Mark locals as initialized.
13389 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13391 * keyboard.h (make_ctrl_char): New decl.
13392 (mark_kboards): Move decl here ...
13393 * alloc.c (mark_kboards): ... from here.
13395 * lisp.h (force_auto_save_soon): New decl.
13397 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13398 (DEFINE_DUMMY_FUNCTION): New macro.
13399 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13401 (main): Add casts to avoid warnings
13402 if GCC considers string literals to be constants.
13404 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13406 * dbusbind.c: Pointer signedness fixes.
13407 (xd_signature, xd_append_arg, xd_initialize):
13408 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13409 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13410 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13411 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13413 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13414 if GCC considers string literals to be constants.
13415 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13417 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13419 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13420 (print_preprocess, print_object): New macro to fix last change.
13422 * print.c (print_preprocess): Don't forget font objects.
13424 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13426 * emacs.c (USAGE3): Doc fixes.
13428 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13430 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13433 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13435 * lisp.h (VWindow_system, Qfile_name_history):
13436 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13437 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13438 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13440 * w32select.c: Don't #include "keyboard.h".
13441 (run_protected): Add extern declaration for waiting_for_input.
13443 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13444 * w32console.c (detect_input_pending, read_input_pending)
13445 (encode_terminal_code):
13446 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13447 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13448 (w32_system_caret_y, Qfile_name_history):
13449 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13450 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13451 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13452 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13453 * w32proc.c (Qlocal, report_file_error):
13454 * w32term.c (Vwindow_system, updating_frame):
13455 * w32uniscribe.c (initialized, uniscribe_font_driver):
13456 Remove unneeded extern declarations.
13458 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13460 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13462 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13464 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13465 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13466 These macros can no longer be used for assignment.
13468 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13469 Assign struct members directly, instead of using BUF_BEGV etc.
13470 (record_buffer_markers, fetch_buffer_markers): New functions for
13471 recording and fetching special buffer markers.
13472 (set_buffer_internal_1, set_buffer_temp): Use them.
13474 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13476 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13478 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13479 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13481 * xdisp.c (hscroll_window_tree):
13482 (reconsider_clip_changes): Use PT instead of BUF_PT.
13484 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13486 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13487 $(EMACS_ROOT)/lib/intprops.h.
13489 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13491 Fix more problems found by GCC 4.5.2's static checks.
13493 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13494 to unsigned char * to avoid compiler diagnostic.
13495 (xg_free_frame_widgets): Make it clear that a local variable is
13496 needed only if USE_GTK_TOOLTIP.
13497 (gdk_window_get_screen): Make it clear that this macro is needed
13498 only if USE_GTK_TOOLTIP.
13499 (int_gtk_range_get_value): New function, which avoids a diagnostic
13500 from gcc -Wbad-function-cast.
13501 (xg_set_toolkit_scroll_bar_thumb): Use it.
13502 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13503 diagnostic from gcc -Wbad-function-cast.
13504 (get_utf8_string, xg_get_file_with_chooser):
13505 Rename locals to avoid shadowing.
13506 (create_dialog): Move locals to avoid shadowing.
13508 * xgselect.c (xg_select): Remove unused var.
13510 * image.c (four_corners_best): Mark locals as initialized.
13511 (gif_load): Initialize transparent_p to zero (Bug#8238).
13512 Mark another local as initialized.
13513 (my_png_error, my_error_exit): Mark with NO_RETURN.
13515 * image.c (clear_image_cache): Now static.
13516 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13517 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13518 (x_edge_detection): Remove unnecessary cast that
13519 gcc -Wbad-function-cast diagnoses.
13520 (gif_load): Fix pointer signedness.
13521 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13522 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13524 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13526 Improve quality of tests for time stamp overflow.
13527 For example, without this patch (encode-time 0 0 0 1 1
13528 1152921504606846976) returns the obviously-bogus value (-948597
13529 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13530 reports time overflow. See
13531 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13532 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13533 * editfns.c: Include limits.h and intprops.h.
13534 (TIME_T_MIN, TIME_T_MAX): New macros.
13535 (time_overflow): Move earlier, to before first use.
13536 (hi_time, lo_time): New functions, for an accurate test for
13537 out-of-range times.
13538 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13539 (Fget_internal_run_time): Don't assume time_t fits in int.
13540 (make_time): Use list2 instead of Fcons twice.
13541 (Fdecode_time): More accurate test for out-of-range times.
13542 (check_tm_member): New function.
13543 (Fencode_time): Use it, to test for out-of-range times.
13544 (lisp_time_argument): Don't rely on undefined left-shift and
13545 right-shift behavior when checking for time stamp overflow.
13547 * editfns.c (time_overflow): New function, refactoring common code.
13548 (Fformat_time_string, Fdecode_time, Fencode_time):
13549 (Fcurrent_time_string): Use it.
13551 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13552 * dired.c (make_time): Move to ...
13553 * editfns.c (make_time): ... here.
13554 * systime.h: Note the move.
13556 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13558 * fringe.c (update_window_fringes): Remove unused variables.
13560 * unexmacosx.c (copy_data_segment): Also copy __got section.
13563 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13565 * termcap.c [MSDOS]: Include "msdos.h".
13566 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13567 Constify `char *' arguments and their references according to
13568 prototypes in tparam.h.
13570 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13572 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13573 Adapt all references accordingly.
13575 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13577 2011-03-11 Tom Tromey <tromey@redhat.com>
13579 * buffer.c (syms_of_buffer): Remove obsolete comment.
13581 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13583 * termhooks.h (encode_terminal_code): Declare prototype.
13585 * msdos.c (encode_terminal_code): Don't declare prototype.
13587 * term.c (encode_terminal_code): Now external again, used by
13588 w32console.c and msdos.c.
13590 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13591 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13593 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13595 Fix some minor problems found by GCC 4.5.2's static checks.
13597 * fringe.c (update_window_fringes): Mark locals as initialized
13599 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13601 * alloc.c (mark_fringe_data): Move decl from here ...
13602 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13603 to check its interface.
13604 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13606 * fontset.c (free_realized_fontset): Now static.
13607 (Fset_fontset_font): Rename local to avoid shadowing.
13608 (fontset_font): Mark local as initialized.
13609 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13611 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13613 * xselect.c (x_disown_buffer_selections): Remove; not used.
13614 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13615 (x_own_selection, Fx_disown_selection_internal): Rename locals
13616 to avoid shadowing.
13617 (x_handle_dnd_message): Remove local to avoid shadowing.
13619 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13620 so that the caller can use some name other than gcpro1.
13621 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13622 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13623 (Fx_backspace_delete_keys_p):
13624 Use them to avoid shadowing, and rename vars to avoid shadowing.
13625 (x_decode_color, x_set_name, x_window): Now static.
13626 (Fx_create_frame): Add braces to silence GCC warning.
13627 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13628 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13629 Remove unused locals.
13630 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13631 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13632 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13635 * xterm.h (x_mouse_leave): New decl.
13637 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13638 Remove unused functions.
13639 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13640 (x_calc_absolute_position): Now static.
13641 (XTread_socket): Don't define label "out" unless it's used.
13642 Don't declare local "event" unless it's used.
13643 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13644 unless they are used.
13645 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13646 (x_fatal_error_signal): Remove; not used.
13647 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13648 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13649 (x_error_catcher, x_connection_closed, x_error_handler):
13650 (x_error_quitter, xembed_send_message, x_iconify_frame):
13651 (my_log_handler): Rename locals to avoid shadowing.
13652 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13653 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13655 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13656 Rename or move locals to avoid shadowing.
13657 (tty_defined_color, merge_face_heights): Now static.
13658 (free_realized_faces_for_fontset): Remove; not used.
13659 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13660 does not deduce is never used uninitialized.
13661 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13662 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13664 * terminal.c (store_terminal_param): Now static.
13666 * xmenu.c (menu_highlight_callback): Now static.
13667 (set_frame_menubar): Remove unused local.
13668 (xmenu_show): Rename parameter to avoid shadowing.
13669 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13670 since they might point to immutable storage.
13671 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13672 since it's unused otherwise.
13674 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13675 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13676 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13677 avoids a gcc -Wuninitialized diagnostic.
13678 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13679 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13680 does not deduce are never used uninitialized.
13682 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13684 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13685 * window.c (window_loop, size_window):
13686 (run_window_configuration_change_hook, enlarge_window): Likewise.
13688 * window.c (display_buffer): Now static.
13689 (size_window): Mark variables that gcc -Wuninitialized
13690 does not deduce are never used uninitialized.
13691 * window.h (check_all_windows): New decl, to forestall
13692 gcc -Wmissing-prototypes diagnostic.
13693 * dispextern.h (bidi_dump_cached_states): Likewise.
13695 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13697 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13698 Include <limits.h>.
13699 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13700 and to avoid gcc -Wuninitialized warning.
13701 (load_charset_map): Mark variables that gcc -Wuninitialized
13702 does not deduce are never used uninitialized.
13703 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13705 * coding.c (coding_set_source, coding_set_destination):
13706 Use "else { /* comment */ }" rather than "else /* comment */;"
13707 for clarity, and to avoid gcc -Wempty-body warning.
13708 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13709 a block, when the outer 'i' will do.
13710 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13711 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13712 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13713 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13714 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13715 Rename locals to avoid shadowing.
13716 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13717 * coding.c (emacs_mule_char, encode_invocation_designation):
13718 Now static, since they're not used elsewhere.
13719 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13720 (decode_coding_object, encode_coding_object, detect_coding_system):
13721 (decode_coding_emacs_mule): Mark variables that gcc
13722 -Wuninitialized does not deduce are never used uninitialized.
13723 (detect_coding_iso_2022): Initialize a local variable that might
13724 be used uninitialized. Leave a FIXME because it's not clear that
13725 this initialization is needed. (Bug#8211)
13726 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13727 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13728 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13729 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13730 Remove unused macros.
13732 * category.c (hash_get_category_set): Remove unused local var.
13733 (copy_category_table): Now static, since it's not used elsewhere.
13734 * character.c (string_count_byte8): Likewise.
13736 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13737 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13739 * chartab.c (copy_sub_char_table): Now static, since it's not used
13741 (sub_char_table_ref_and_range, char_table_ref_and_range):
13742 Rename locals to avoid shadowing.
13743 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13745 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13746 (BIDI_BOB): Remove unused macro.
13748 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13749 deduce are never used uninitialized.
13750 * term.c (encode_terminal_code): Likewise.
13752 * term.c (encode_terminal_code): Now static. Remove unused local.
13754 * tparam.h: New file.
13755 * term.c, tparam.h: Include it.
13756 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13757 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13758 Move these decls to tparam.h, and make them agree with what
13759 is actually in tparam.c. The previous trick of using incompatible
13760 decls in different modules does not conform to the C standard.
13761 All callers of tparam changed to use tparam's actual API.
13762 * tparam.c (tparam1, tparam, tgoto):
13763 Use const pointers where appropriate.
13765 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13766 * cm.h (struct cm): Likewise.
13767 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13768 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13769 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13770 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13771 (turn_on_face, init_tty): Likewise.
13772 * termchar.h (struct tty_display_info): Likewise.
13774 * term.c (term_mouse_position): Rename local to avoid shadowing.
13776 * alloc.c (mark_ttys): Move decl from here ...
13777 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13779 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13781 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13783 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13785 * search.c (compile_pattern_1): Remove argument regp, unused since
13786 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13787 (compile_pattern): Don't pass it.
13789 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13791 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13792 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13794 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13796 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13798 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13799 gdk_window_get_screen, gdk_window_get_geometry,
13800 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13801 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13802 (xg_get_pixbuf_from_pixmap): New function.
13803 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13804 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13805 Call xg_get_pixbuf_from_pixmap instead of
13806 gdk_pixbuf_get_from_drawable.
13807 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13808 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13809 (xg_check_special_colors): Use GtkStyleContext and its functions
13811 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13812 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13813 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13814 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13815 Call gtk_widget_get_preferred_size.
13816 (xg_frame_resized): gdk_window_get_geometry only takes 5
13818 (xg_win_to_widget, xg_event_is_for_menubar):
13819 Call gdk_x11_window_lookup_for_display.
13820 (xg_set_widget_bg): New function.
13821 (delete_cb): New function.
13822 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13823 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13824 (xg_set_background_color): Call xg_set_widget_bg.
13825 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13826 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13827 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13828 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13830 (update_frame_tool_bar): Call gtk_widget_hide.
13831 (xg_initialize): Use GDK_KEY_g.
13833 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13835 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13837 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13838 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13839 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13841 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13843 * w32xfns.c (select_palette): Check success of RealizePalette against
13844 GDI_ERROR, not zero.
13846 See ChangeLog.11 for earlier changes.
13848 ;; Local Variables:
13852 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13854 This file is part of GNU Emacs.
13856 GNU Emacs is free software: you can redistribute it and/or modify
13857 it under the terms of the GNU General Public License as published by
13858 the Free Software Foundation, either version 3 of the License, or
13859 (at your option) any later version.
13861 GNU Emacs is distributed in the hope that it will be useful,
13862 but WITHOUT ANY WARRANTY; without even the implied warranty of
13863 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13864 GNU General Public License for more details.
13866 You should have received a copy of the GNU General Public License
13867 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.