1 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (pos_visible_p): If already at a newline from the
4 display string before the 'while' loop, don't walk back the glyphs
5 from it3.glyph_row. Solves assertion violation when the display
6 string begins with a newline (egg.el). (Bug#11367)
8 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
10 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
13 2012-05-01 Glenn Morris <rgm@gnu.org>
15 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
16 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
17 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
18 All were removed before 23.1.
20 * dispnew.c: Remove HAVE_LIBNCURSES test;
21 it is always true on relevant platforms.
23 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
24 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
26 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
28 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
30 * .gdbinit (xpr): Remove checks for no longer existing misc types.
31 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
34 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
36 Do not avoid creating empty evaporating overlays (Bug#9642).
37 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
38 That is, do not delete an evaporating overlay if it becomes
39 empty after its bounds are adjusted to fit within its buffer.
40 This fix caused other problems, and I'm reverting it until we get
41 to the bottom of them.
43 2012-04-27 Chong Yidong <cyd@gnu.org>
45 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
47 2012-04-27 Eli Zaretskii <eliz@gnu.org>
49 * xdisp.c (pos_visible_p): If the window start position is beyond
50 ZV, start the display from buffer beginning. Prevents assertion
51 violation in init_iterator when the minibuffer window is scrolled
54 * window.c (window_scroll_pixel_based): Likewise.
56 2012-04-27 Chong Yidong <cyd@gnu.org>
58 * keymap.c (where_is_internal): Doc fix (Bug#10872).
60 2012-04-27 Glenn Morris <rgm@gnu.org>
62 * fileio.c (Fcopy_file, Fset_file_selinux_context):
63 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
65 2012-04-27 Eli Zaretskii <eliz@gnu.org>
67 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
68 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
70 2012-04-26 Eli Zaretskii <eliz@gnu.org>
72 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
73 display element, check also the underlying string or buffer
74 character. (Bug#11341)
76 * w32menu.c: Include w32heap.h.
77 (add_menu_item): If the call to AppendMenuW (via
78 unicode_append_menu) fails, disable Unicode menus only if we are
79 running on Windows 9X/Me.
81 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
83 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
84 (xgetint): Add missing shift for LSB tags.
86 2012-04-24 Martin Rudalics <rudalics@gmx.at>
88 * keyboard.c (read_char): Don't wipe echo area for select window
89 events: These might get delayed via `mouse-autoselect-window'
92 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
94 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
95 manipulation of :loaded-from data.
97 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
99 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
100 now a cons (bug#11311).
102 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
104 Do not create empty overlays with the evaporate property (Bug#9642).
105 * buffer.c (Fmove_overlay): Delete an evaporating overlay
106 if it becomes empty after its bounds are adjusted to fit within
107 its buffer. Without this fix, in a nonempty buffer (let ((o
108 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
109 yields an empty overlay that has the evaporate property, which is
110 not supposed to happen.
112 Fix minor GTK3 problems found by static checking.
113 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
114 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
115 (struct _EmacsFixedClass, emacs_fixed_get_type):
116 Move decls here from emacsgtkfixed.h, since they needn't be public.
117 (emacs_fixed_get_type): Now static.
118 (emacs_fixed_class_init): Omit unused local.
119 (emacs_fixed_child_type): Remove; unused.
120 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
121 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
122 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
123 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
124 (EMACS_FIXED_GET_CLASS): Remove; unused.
125 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
127 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
128 Problem reported by Juanma Barranquero for Windows -Wunused-function.
130 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
132 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
133 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
134 (__malloc_size_t, __malloc_ptrdiff_t):
135 Remove. All uses removed, replaced by the definiens if needed,
136 since we can assume C89 or better now.
137 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
138 (protect_malloc_state, align, get_contiguous_space)
139 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
140 (malloc_atfork_handler_child, malloc_enable_thread)
141 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
142 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
143 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
144 (special_realloc, _realloc_internal_nolock, _realloc_internal)
145 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
146 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
147 Define using prototypes, not old style.
148 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
149 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
150 (align): Don't assume that signed integer overflow wraps around.
151 Omit unused local var.
152 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
153 (_free_internal_nolock, memalign, mallochook, reallochook):
154 Omit no-longer-needed casts.
155 (valloc): Use getpagesize, not __getpagesize.
156 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
157 (struct hdr): The 'magic' member is now size_t, not unsigned long.
159 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
161 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
163 Move functions from C to Lisp. Make non-blocking method calls
164 the default. Implement further D-Bus standard interfaces.
166 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
167 (QCdbus_request_name_allow_replacement)
168 (QCdbus_request_name_replace_existing)
169 (QCdbus_request_name_do_not_queue)
170 (QCdbus_request_name_reply_primary_owner)
171 (QCdbus_request_name_reply_in_queue)
172 (QCdbus_request_name_reply_exists)
173 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
174 (QCdbus_registered_serial, QCdbus_registered_method)
175 (QCdbus_registered_signal): New Lisp objects.
176 (XD_DEBUG_MESSAGE): Use sizeof.
177 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
178 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
179 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
180 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
181 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
182 (xd_signature, xd_append_arg): Allow float for integer types.
183 (xd_get_connection_references): New function.
184 (xd_get_connection_address): Rename from xd_initialize.
185 Return cached address.
186 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
187 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
189 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
190 Return number of recounts.
191 (Fdbus_get_unique_name): Make stronger parameter check.
192 (Fdbus_message_internal): New defun.
193 (Fdbus_call_method, Fdbus_call_method_asynchronously)
194 (Fdbus_method_return_internal, Fdbus_method_error_internal)
195 (Fdbus_send_signal, Fdbus_register_service)
196 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
197 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
198 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
199 (Vdbus_compiled_version, Vdbus_runtime_version)
200 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
201 (Vdbus_message_type_method_return, Vdbus_message_type_error)
202 (Vdbus_message_type_signal): New defvars.
203 (Vdbus_registered_buses, Vdbus_registered_objects_table):
206 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
208 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
209 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
210 Do not assume ptrdiff_t is the same width as 'int'.
212 * alloc.c: Handle unusual debugging option combinations.
213 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
214 since the two debugging options are incompatible.
215 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
217 (mem_init, mem_insert, mem_insert_fixup):
218 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
219 (NEED_MEM_INSERT): Remove; no longer needed.
221 2012-04-22 Leo Liu <sdl.web@gmail.com>
223 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
225 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
227 * sysdep.c [__FreeBSD__]: Minor cleanups.
228 (list_system_processes, system_process_attributes) [__FreeBSD__]:
229 Use Emacs indenting style more consistently. Avoid some casts.
230 Use 'double' consistently rather than mixing 'float' and 'double'.
232 2012-04-21 Eduard Wiebe <usenet@pusto.de>
234 * sysdep.c (list_system_processes, system_process_attributes):
235 Add implementation for FreeBSD (Bug#5243).
237 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
239 * lisp.mk (lisp): Update.
241 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
243 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
244 It is never used otherwise.
246 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
248 * print.c (print_preprocess): Only check print_depth if print-circle
250 (print_object): Check for cycles even when print-circle is nil and
251 print-gensym is t, but only check print_depth if print-circle is nil.
253 2012-04-20 Chong Yidong <cyd@gnu.org>
255 * process.c (wait_reading_process_output): If EIO occurs on a pty,
256 set the status to "failed" and ensure that sentinel is run.
258 2012-04-20 Glenn Morris <rgm@gnu.org>
260 * process.c (Fset_process_inherit_coding_system_flag)
261 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
262 (Fmake_network_process, Fmake_serial_process): Doc fix.
264 2012-04-20 Eli Zaretskii <eliz@gnu.org>
266 * xdisp.c (string_buffer_position_lim): Limit starting position to
268 (set_cursor_from_row): If called for a mode-line or header-line
269 row, return zero immediately.
270 (try_cursor_movement): If inside continuation line, don't back up
271 farther than the first row after the header line, if any.
272 Don't consider the header-line row as "partially visible", even if
273 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
275 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
277 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
280 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
281 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
283 configure: new option --enable-gcc-warnings (Bug#11207)
284 * Makefile.in (C_WARNINGS_SWITCH): Remove.
285 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
286 (ALL_CFLAGS): Use new macros rather than old.
287 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
288 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
289 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
290 -Wunused-result, -Wunused-variable. This should go away once
291 the Emacs and Gnulib regex code is merged.
292 (xmalloc, xrealloc): Now static.
294 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
296 * dired.c (Fsystem_groups): Remove unused local.
298 2012-04-17 Glenn Morris <rgm@gnu.org>
300 * dired.c (Fsystem_users): Doc fix.
302 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
304 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
305 (syms_of_dired): Add them.
307 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
309 Fix minor alloc.c problems found by static checking.
310 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
311 New extern decls, to avoid calling undeclared functions.
312 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
313 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
314 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
315 (NEED_MEM_INSERT): New macro.
316 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
317 Remove one incorrect comment and fix another.
319 Fix minor ralloc.c problems found by static checking.
320 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
321 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
322 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
323 (r_alloc_sbrk): Now static.
325 Improve ralloc.c interface checking.
326 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
327 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
328 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
329 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
330 [REL_ALLOC]: ... to here, to check interface.
331 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
332 Remove decls. This fixes an "It stinks!".
334 * alloc.c (which_symbols): Fix alignment issue / type clash.
336 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
338 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
339 (struct Lisp_Misc_Any): Likewise.
340 (struct Lisp_Free): Likewise.
341 * alloc.c (union aligned_Lisp_Symbol): Define.
342 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
343 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
344 (union aligned_Lisp_Misc): Define.
345 (MARKER_BLOCK_SIZE, struct marker_block): Use union
346 aligned_Lisp_Misc instead of union Lisp_Misc.
347 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
349 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
351 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
352 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
353 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
354 * s/netbsd.h, s/sol2-6.h:
355 Remove definition of GC_MARK_STACK, since the default now works.
356 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
357 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
358 no longer the default.
359 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
361 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
363 * lread.c (lisp_file_lexically_bound_p):
364 Fix hang at ";-*-\n" (bug#11238).
366 2012-04-14 Eli Zaretskii <eliz@gnu.org>
368 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
369 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
371 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
373 * nsterm.m (constrainFrameRect): Always constrain when there is only
374 one screen (Bug#10962).
376 2012-04-13 Ken Brown <kbrown@cornell.edu>
378 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
380 2012-04-13 Reuben Thomas <rrt@sc3d.org>
382 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
384 2012-04-11 Daniel Colascione <dancol@dancol.org>
386 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
387 against is gone. It's better to use vfork now so that when Cygwin
388 gains a new, working vfork, we use it automatically (bug#10398).
390 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
392 * window.c (save_window_save): Obey window-point-insertion-type.
394 2012-04-11 Glenn Morris <rgm@gnu.org>
396 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
398 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
400 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
402 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
404 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
405 (force_quit_count): New var.
406 (handle_interrupt): Use it.
408 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
410 * w32.c (w32_delayed_load): Record the full path of the library
411 being loaded (bug#10424).
413 2012-04-09 Glenn Morris <rgm@gnu.org>
415 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
416 not just in the obarray, before snarfing them. (Bug#11036)
418 * Makefile.in ($(leimdir)/leim-list.el):
419 Pass EMACS rather than BUILT_EMACS.
421 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
423 * process.c (make_process):
424 * process.h: Add integer `gnutls_handshakes_tried' member to
427 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
428 Add convenience `GNUTLS_LOG2i' macro.
430 * gnutls.c (gnutls_log_function2i): Convenience log function.
431 (emacs_gnutls_read): Use new log functions,
432 `gnutls_handshakes_tried' process member, and
433 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
434 attempts per process (connection).
436 2012-04-09 Chong Yidong <cyd@gnu.org>
438 * eval.c (Fuser_variable_p, user_variable_p_eh)
439 (lisp_indirect_variable): Functions deleted.
440 (Fdefvar): Caller changed.
442 * callint.c (Finteractive, Fcall_interactively):
443 * minibuf.c (Fread_variable): Callers changed.
445 2012-04-09 Eli Zaretskii <eliz@gnu.org>
447 * xdisp.c (set_cursor_from_row): If the display string appears in
448 the buffer at position that is closer to point than the position
449 after the display string, display the cursor on the first glyph of
450 the display string. Fixes cursor display when a 'display' text
451 property immediately follows invisible text. (Bug#11094)
453 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
455 composite.c: use 'double' consistently
456 * composite.c (get_composition_id): Use 'double' consistently
457 instead of converting 'float' to 'double' and vice versa; this is
458 easier to understand and avoids a GCC warning.
460 2012-04-09 Glenn Morris <rgm@gnu.org>
462 * Makefile.in: Generate leim-list with bootstrap-emacs, in
463 preparation for dumping it with emacs. (Bug#4789)
464 (leimdir): New variable.
465 ($(leimdir)/leim-list.el): New rule.
466 (emacs$(EXEEXT)): Depend on leim-list.el.
468 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
469 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
470 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
472 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
474 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
477 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
479 * xml.c (init_libxml2_functions) [WINDOWSNT]:
480 Remove unused local variable.
482 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
484 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
485 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
486 (mark_memory): Mark Lisp_Objects only if pointers might hide in
487 objects, as mark_maybe_pointer will catch them otherwise.
488 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
489 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
491 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
493 Fix typo that broke non-Windows builds.
494 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
496 2012-04-07 Eli Zaretskii <eliz@gnu.org>
498 Support building on MS-Windows with libxml2.
500 * makefile.w32-in (OBJ2): Add xml.$(O).
501 (GLOBAL_SOURCES): Add xml.c.
502 ($(BLD)/xml.$(O)): New dependency list.
504 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
505 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
506 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
507 [!WINDOWSNT]: New macros.
508 (init_libxml2_functions, libxml2_loaded_p): New functions.
509 (parse_region): Call fn_xmlCheckVersion instead of using the macro
510 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
511 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
512 Calls xmlCleanupParser only if libxml2 was loaded (or statically
514 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
515 Call init_libxml2_functions before calling libxml2 functions.
516 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
518 * emacs.c: Don't include libxml/parser.h.
519 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
520 xmlCleanupParser directly.
522 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
524 2012-04-07 Eli Zaretskii <eliz@gnu.org>
526 * indent.c (Fvertical_motion): If there is a display string at
527 point, use it.vpos to compute how many lines to backtrack after
528 move_it_to point. (Bug#11133)
530 2012-04-06 Eli Zaretskii <eliz@gnu.org>
532 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
533 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
534 about subtle differences between FETCH_CHAR* and STRING_CHAR*
535 macros related to unification of CJK characters. For the details,
536 see the discussion following the message here:
537 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
539 2012-04-04 Chong Yidong <cyd@gnu.org>
541 * keyboard.c (Vdelayed_warnings_list): Doc fix.
543 2012-04-01 Eli Zaretskii <eliz@gnu.org>
545 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
546 instead of alloca. (Bug#11138)
548 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
550 * w32menu.c (is_simple_dialog): Properly check lisp types.
553 2012-03-31 Eli Zaretskii <eliz@gnu.org>
555 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
556 position we get to after a call to move_it_to fails the
557 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
558 only if we wind up in a string from display property. (Bug#11063)
560 * window.c (Fdelete_other_windows_internal): Invalidate the row
561 and column information about mouse highlight, so that redisplay
562 restores it after reallocating the glyph matrices. (Bug#7464)
564 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
565 string comes from a `display' text property, use the buffer
566 position of that property as if we actually saw that position in
568 (move_it_by_lines): Remove the assertion that
569 "it->current_x == 0 && it->hpos == 0" which can be legitimately
570 violated when there's a before-string at the beginning of a line.
573 2012-03-30 Eli Zaretskii <eliz@gnu.org>
575 * xdisp.c (append_space_for_newline): If the default face was
576 remapped, use the remapped face for the appended newline.
577 (extend_face_to_end_of_line): Use the remapped default face for
578 extending the face to the end of the line.
579 (display_line): Call extend_face_to_end_of_line when the default
580 face was remapped. (Bug#11068)
582 2012-03-29 Eli Zaretskii <eliz@gnu.org>
584 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
586 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
588 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
590 2012-03-27 Glenn Morris <rgm@gnu.org>
592 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
595 2012-03-26 Kenichi Handa <handa@m17n.org>
597 * dispextern.h (struct glyph): Fix previous change. Change the
598 bit length of glyphless.ch to 25 (Bug#11082).
600 2012-03-26 Chong Yidong <cyd@gnu.org>
602 * keyboard.c (Vselection_inhibit_update_commands): New variable.
603 (command_loop_1): Use it; inhibit selection update for
604 handle-select-window too (Bug#8996).
606 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
608 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
610 2012-03-25 Kenichi Handa <handa@m17n.org>
612 * dispextern.h (struct glyph): Change the bit length of
613 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
615 2012-03-24 Eli Zaretskii <eliz@gnu.org>
617 * s/ms-w32.h (tzname): Include time.h before redirecting to
618 _tzname. Fixes the MSVC build. (Bug#9960)
620 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
622 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
625 * xterm.c (XTread_socket): Only modify handling_signal if
626 !SYNC_INPUT. (Bug#11080)
628 2012-03-23 Eli Zaretskii <eliz@gnu.org>
630 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
631 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
632 when fetching a multibyte character consumes more bytes than
633 CHAR_BYTES returns, due to unification of CJK characters in
634 string_char. (Bug#11073)
636 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
638 * process.c (wait_reading_process_output): Handle pty disconnect
639 by refraining from sending oneself a SIGCHLD (bug#10933).
641 2012-03-22 Chong Yidong <cyd@gnu.org>
643 * dispextern.h (struct it): New member string_from_prefix_prop_p.
645 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
646 Mark string as coming from a prefix property.
647 (handle_face_prop): Use default face for prefix strings (Bug#4281).
648 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
650 2012-03-21 Chong Yidong <cyd@gnu.org>
652 * xfaces.c (Vface_remapping_alist): Doc fix.
654 2012-03-20 Eli Zaretskii <eliz@gnu.org>
656 * w32proc.c (Fw32_set_console_codepage)
657 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
660 2012-03-20 Chong Yidong <cyd@gnu.org>
662 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
663 to reflect default non-nil value of redisplay-dont-pause.
665 2012-03-19 Kenichi Handa <handa@m17n.org>
667 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
668 it fit in a valid range (Bug#11003).
670 2012-03-18 Eli Zaretskii <eliz@gnu.org>
672 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
673 that is not from display property, accept the row as a "cursor
674 row" if one of the string's character has a non-nil `cursor'
675 property. Fixes cursor positioning when there are newlines in
676 overlay strings, e.g. in icomplete.el. (Bug#11035)
678 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
680 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
682 2012-03-12 Chong Yidong <cyd@gnu.org>
684 * eval.c (inhibit_lisp_code): Rename from
685 inhibit_window_configuration_change_hook; move from window.c.
687 * xfns.c (unwind_create_frame_1, Fx_create_frame):
688 * window.c (run_window_configuration_change_hook)
689 (syms_of_window): Callers changed.
691 2012-03-11 Chong Yidong <cyd@gnu.org>
693 * keymap.c (Fkey_description): Doc fix (Bug#9700).
695 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
697 2012-03-10 Chong Yidong <cyd@gnu.org>
699 * frame.c (other_visible_frames): Don't assume the selected frame
700 is visible (Bug#10955).
702 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
704 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
706 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
708 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
709 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
712 2012-03-03 Glenn Morris <rgm@gnu.org>
714 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
716 2012-03-02 Eli Zaretskii <eliz@gnu.org>
718 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
719 position past the first glyph_row that ends at ZV. (Bug#10902)
720 (redisplay_window, next_element_from_string): Fix typos in
722 (redisplay_window): Pass to move_it_vertically the margin in
723 pixels, not in screen lines.
725 2012-03-02 Glenn Morris <rgm@gnu.org>
727 * buffer.c (buffer-list-update-hook): Doc fix.
729 2012-02-29 Eli Zaretskii <eliz@gnu.org>
731 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
732 push_it before setting up the iterator for the first overlay
733 string, even if we have an empty string loaded.
734 (next_overlay_string): If there's an empty string on the iterator
735 stack, pop the stack. (Bug#10903)
737 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
739 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
740 Suggested by Stefan Monnier in
741 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
742 * alloc.c (widen_to_Lisp_Object): New static function.
743 (mark_memory): Also mark Lisp_Objects by fetching pointer words
744 and widening them to Lisp_Objects. This would work even if
745 USE_LSB_TAG is defined and wide integers are used, which might
746 happen in a future version of Emacs.
748 2012-02-25 Chong Yidong <cyd@gnu.org>
750 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
753 * xselect.c (Fx_selection_exists_p): Doc fix.
754 (x_clipboard_manager_save_all): Print an informative message
755 before saving to clipboard manager.
757 2012-02-24 Chong Yidong <cyd@gnu.org>
759 * keyboard.c (process_special_events): Handle all X selection
760 requests in kbd_buffer, not just the next one (Bug#8869).
762 2012-02-23 Chong Yidong <cyd@gnu.org>
764 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
765 call when setting menu-bar-lines and tool-bar-lines parameters.
766 (unwind_create_frame_1): New helper function.
768 * window.c (inhibit_window_configuration_change_hook): New var.
769 (run_window_configuration_change_hook): Obey it.
770 (syms_of_window): Initialize it.
772 2012-02-22 Chong Yidong <cyd@gnu.org>
774 * xterm.c (x_draw_image_relief): Add missing type check for
775 Vtool_bar_button_margin (Bug#10743).
777 2012-02-21 Chong Yidong <cyd@gnu.org>
779 * fileio.c (Vfile_name_handler_alist): Doc fix.
781 * buffer.c (Fget_file_buffer): Protect against invalid file
782 handler return value.
784 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
786 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
787 when computing $valmask.
789 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
790 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
791 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
792 It's useless in that case, and it can cause problems on hosts
793 that allocate halves of EMACS_INT values separately.
794 Reported by Dan Horák. Diagnosed by Andreas Schwab in
795 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
796 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
797 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
798 it avoids undefined behavior on hosts where shifting right by more
799 than the word width has undefined behavior.
801 2012-02-19 Chong Yidong <cyd@gnu.org>
803 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
804 (Funhandled_file_name_directory, Ffile_name_as_directory)
805 (Fdirectory_file_name, Fexpand_file_name)
806 (Fsubstitute_in_file_name): Protect against invalid file handler
807 return values (Bug#10845).
809 2012-02-18 Eli Zaretskii <eliz@gnu.org>
811 * .gdbinit (pitx): Fix incorrect references to fields of the
814 2012-02-17 Chong Yidong <cyd@gnu.org>
816 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
818 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
820 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
821 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
823 2012-02-15 Chong Yidong <cyd@gnu.org>
825 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
826 marked as special. Also, starting docstrings with * is obsolete.
828 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
830 * gnutls.c (emacs_gnutls_write): Fix last change.
832 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
834 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
837 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
839 * keymap.c (Fsingle_key_description): Handle char ranges.
841 2012-02-12 Chong Yidong <cyd@gnu.org>
843 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
844 as that creates a dangerous corner case.
846 * window.c (Fdelete_window_internal): Invalidate the mouse
847 highlight (Bug#9904).
849 2012-02-12 Glenn Morris <rgm@gnu.org>
851 * xselect.c (Fx_own_selection_internal)
852 (Fx_get_selection_internal, Fx_disown_selection_internal)
853 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
854 * nsselect.m (Fx_own_selection_internal)
855 (Fx_disown_selection_internal, Fx_selection_exists_p)
856 (Fx_selection_owner_p, Fx_get_selection_internal):
857 Sync docs and argument specs with the xselect.c versions.
859 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
861 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
863 2012-02-11 Eli Zaretskii <eliz@gnu.org>
865 * w32select.c (Fx_selection_exists_p): Sync doc string and
866 argument list with xselect.c. (Bug#10783)
868 * w16select.c (Fx_selection_exists_p): Sync doc string and
869 argument list with xselect.c. (Bug#10783)
871 2012-02-10 Glenn Morris <rgm@gnu.org>
873 * fns.c (Fsecure_hash): Doc fix.
875 2012-02-09 Kenichi Handa <handa@m17n.org>
877 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
879 2012-02-07 Chong Yidong <cyd@gnu.org>
881 * buffer.c (Fbuffer_local_variables)
882 (buffer_lisp_local_variables): Handle unbound vars correctly;
883 don't let Qunbound leak into Lisp.
885 2012-02-07 Glenn Morris <rgm@gnu.org>
887 * image.c (Fimagemagick_types): Doc fix.
889 * image.c (imagemagick-render-type): Change it from a lisp object
890 to an integer. Move the doc here from the lisp manual.
891 Treat all values not equal to 0 the same.
893 2012-02-06 Chong Yidong <cyd@gnu.org>
895 * doc.c (store_function_docstring): Avoid applying docstring of
896 alias to base function (Bug#2603).
898 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
900 * .gdbinit (pp1, pv1): Remove redundant defines.
903 2012-02-04 Chong Yidong <cyd@gnu.org>
905 * nsterm.m: Declare a global (Bug#10694).
907 2012-02-04 Eli Zaretskii <eliz@gnu.org>
909 * w32.c (get_emacs_configuration_options):
910 Include --enable-checking, if specified, in the return value.
912 2012-02-04 Martin Rudalics <rudalics@gmx.at>
914 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
915 after rounding frame sizes. (Bug#9723)
917 2012-02-04 Eli Zaretskii <eliz@gnu.org>
919 * keyboard.c (adjust_point_for_property): Don't position point
920 before BEGV. (Bug#10696)
922 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
924 Handle overflow when computing char display width (Bug#9496).
925 * character.c (char_width): Return EMACS_INT, not int.
926 (char_width, c_string_width): Check for overflow when
927 computing the width; this is possible now that individual
928 characters can have unbounded width. Problem introduced
929 by merge from Emacs 23 on 2012-01-19.
931 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
933 * dbusbind.c (Fdbus_register_method): Mention the return value
934 :ignore in the docstring.
936 2012-02-02 Glenn Morris <rgm@gnu.org>
938 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
940 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
941 Unconditionally set to t. (Bug#10673)
942 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
943 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
944 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
946 2012-02-02 Kenichi Handa <handa@m17n.org>
948 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
949 0, do not call append_composite_glyph.
951 2012-02-02 Kenichi Handa <handa@m17n.org>
953 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
955 (x_produce_glyphs): If the component of a composition is a null
956 string, set it->pixel_width to 1 to avoid zero-width glyph.
958 2012-02-01 Eli Zaretskii <eliz@gnu.org>
960 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
961 first 2 arguments are identical. This makes inserting large
962 output from a subprocess an order of magnitude faster on
963 MS-Windows, where all sbrk'ed memory is always contiguous.
965 2012-01-31 Glenn Morris <rgm@gnu.org>
967 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
968 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
969 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
971 2012-01-29 Glenn Morris <rgm@gnu.org>
973 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
975 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
977 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
979 2012-01-28 Chong Yidong <cyd@gnu.org>
981 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
983 2012-01-26 Chong Yidong <cyd@gnu.org>
985 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
987 * search.c (Fsearch_forward, Fsearch_backward): Document negative
988 repeat counts (Bug#10507).
990 2012-01-26 Glenn Morris <rgm@gnu.org>
992 * lread.c (syms_of_lread): Doc fix.
994 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
996 * coding.c (encode_designation_at_bol): Change return value to
999 2012-01-25 Chong Yidong <cyd@gnu.org>
1001 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1003 2012-01-21 Chong Yidong <cyd@gnu.org>
1005 * floatfns.c (Fcopysign): Make the second argument non-optional,
1006 since nil is not allowed anyway.
1008 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1010 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1011 (send_process): Likewise.
1013 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1015 * window.c (save_window_save, Fcurrent_window_configuration)
1016 (Vwindow_persistent_parameters): Do not use Qstate.
1017 Rewrite doc-strings.
1019 2012-01-19 Kenichi Handa <handa@m17n.org>
1021 * character.c (char_width): New function.
1022 (Fchar_width, c_string_width, lisp_string_width):
1023 Use char_width (Bug#9496).
1025 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1027 * window.c (Vwindow_persistent_parameters): New variable.
1028 (Fset_window_configuration, save_window_save): Handle persistent
1031 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1033 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1034 thrashing the stack of the thread. (Bug#9087)
1036 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1038 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1040 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1042 * xdisp.c (rows_from_pos_range): Handle the case where the
1043 highlight ends on a newline. (Bug#10464)
1044 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1045 he end column for display of highlight that ends on a newline
1048 2012-01-11 Glenn Morris <rgm@gnu.org>
1050 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1051 from load-path also when installation-directory is nil. (Bug#10208)
1053 2012-01-10 Glenn Morris <rgm@gnu.org>
1055 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1057 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1058 Update template values to be closer to their typical values these days.
1060 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1062 * xdisp.c (rows_from_pos_range): Accept additional argument
1063 DISP_STRING, and accept any glyph in a row whose object is that
1064 string as eligible for mouse highlight. Fixes mouse highlight of
1065 display strings from overlays. (Bug#10464)
1067 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1069 emacs: fix an auto-save permissions race condition (Bug#10400)
1070 * fileio.c (auto_saving_dir_umask): New static var.
1071 (Fmake_directory_internal): Use it.
1072 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1073 creating the directory. The old code temporarily assigns
1074 too-generous permissions to the directory.
1075 (do_auto_save_eh): Clear it.
1076 (Fdo_auto_save): Catch all errors, not just file errors, so
1077 that the var is always cleared.
1079 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1081 * search.c (scan_buffer): Pass character positions to
1082 know_region_cache, not byte positions. (Bug#6540)
1084 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1086 * w32.c (sys_rename): Report EXDEV when rename of a directory
1087 fails because the target is on another logical disk. (Bug#10284)
1089 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1091 * xterm.c (x_embed_request_focus): New function.
1093 * xterm.h: Add prototype.
1095 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1097 2012-01-05 Glenn Morris <rgm@gnu.org>
1099 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1101 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1103 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1104 Load gnutls_transport_set_lowat only if GnuTLS version is below
1106 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1107 GnuTLS versions below 2.11.1.
1109 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1111 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1112 to the doc string advising against its use for altering the way
1113 windows are scrolled.
1115 2011-12-28 Kenichi Handa <handa@m17n.org>
1117 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1118 coding-system ASCII compatible only when it does not produce BOM
1119 on encoding (Bug#10383).
1121 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1123 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1125 (create_and_show_popup_menu): Always use menu_position_func for
1128 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1130 * callint.c (Fcall_interactively): Don't truncate prompt string.
1132 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1134 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1135 property that ends at ZV, so that the bidi iteration could be
1136 resumed from there (after widening). (Bug#10360)
1138 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1140 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1142 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1144 * nsterm.m (x_free_frame_resources):
1145 Release f->output_data.ns->miniimage.
1146 (ns_index_color): Fix indentation. Do not retain
1147 color_table->colors[i].
1149 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1152 * nsfns.m (x_set_background_color): Assign return value from
1153 ns_index_color to face-background instead of NSColor*.
1154 (ns_implicitly_set_icon_type): Fix indentation.
1155 Change assignment in for loop to comparison.
1157 * emacs.c (ns_pool): New variable.
1158 (main): Assign ns_pool.
1159 (Fkill_emacs): Call ns_release_autorelease_pool.
1161 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1162 autorelease fdesc, release fdAttrs and tdict.
1163 (ns_get_covering_families): Release charset.
1164 (ns_findfonts): Release NSFontDescriptor created with new.
1165 (ns_uni_to_glyphs): Fix indentation.
1166 (setString): Release attrStr before assigning new value.
1168 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1170 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1172 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1173 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1175 2011-12-18 David Reitter <reitter@cmu.edu>
1177 * nsterm.m (ns_term_init): Subscribe for notifications
1178 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1179 to method trackingNotification in EmacsMenu.
1181 * nsmenu.m (trackingMenu): New variable.
1182 (trackingNotification): New method (from Aquamacs).
1183 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1184 from Aquamacs (Bug#7030).
1186 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1188 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1189 (symbol_to_nsstring): Fix indentation.
1190 (ns_symbol_to_pb): New function.
1191 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1192 (Fns_rotate_cut_buffers_internal): Remove.
1193 (Fns_store_selection_internal): Rename from
1194 Fns_store_cut_buffer_internal.
1195 (ns_get_foreign_selection, Fx_own_selection_internal)
1196 (Fx_disown_selection_internal, Fx_selection_exists_p)
1197 (Fns_get_selection_internal, Fns_store_selection_internal):
1198 Use ns_symbol_to_pb and check if return value is nil.
1199 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1200 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1201 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1202 renamed to Sns_store_selection_internal.
1203 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1204 and remove this function.
1205 (ns_handle_selection_clear): Remove, never used.
1206 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1209 2011-12-17 Ken Brown <kbrown@cornell.edu>
1211 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1212 GID is unknown (Bug#10257).
1214 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1216 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1217 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1218 which caused a build failure on GNU/Linux IA-64. This problem was
1219 introduced by my 2011-10-07 patch.
1221 2011-12-15 Juri Linkov <juri@jurta.org>
1223 * image.c (imagemagick_error): New function. (Bug#10112)
1224 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1225 Use `imagemagick_error' where ImageMagick functions return
1227 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1230 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1232 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1233 fill background (Bug#8992).
1235 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1237 * window.c (Vwindow_combination_resize)
1238 (Vwindow_combination_limit): Use t instead of non-nil in
1240 (Vrecenter_redisplay): Add first sentence of doc-string on
1242 (Frecenter): Fix doc-string typo.
1244 2011-12-11 Kenichi Handa <handa@m17n.org>
1246 * coding.c (Funencodable_char_position): Pay attention to the
1247 buffer text relocation (Bug#9389).
1249 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1251 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1252 gtk_init (Bug#10100).
1254 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1256 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1257 IT->string is nil. (Bug#10263)
1259 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1261 * nsterm.h (x_free_frame_resources): Declare.
1263 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1264 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1266 * nsterm.h (ns_get_defaults_value): Declare.
1268 * nsterm.m (ns_default): Call ns_get_defaults_value.
1270 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1272 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1275 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1277 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1278 that where the value of an _OBJC_* symbol points to is in the .bss
1279 section (Bug#10240).
1281 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1283 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1284 after the loop to call ccl_driver at least once (Bug#8619).
1286 2011-12-08 Kenichi Handa <handa@m17n.org>
1288 * ftfont.c (get_adstyle_property): Fix previous change
1291 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1293 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1294 dirs from the default value of EMACSLOADPATH (bug#10208).
1296 2011-12-07 Glenn Morris <rgm@gnu.org>
1298 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1299 installation and source directories as well. (Bug#10208)
1301 2011-12-06 Chong Yidong <cyd@gnu.org>
1303 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1305 2011-12-06 Glenn Morris <rgm@gnu.org>
1307 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1308 as an error, not just -1. (Bug#10217)
1310 2011-12-05 Chong Yidong <cyd@gnu.org>
1312 * keyboard.c (process_special_events): New function.
1313 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1315 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1317 * coding.c (encode_designation_at_bol): Don't use uninitialized
1318 local variable (Bug#9318).
1320 2011-12-05 Kenichi Handa <handa@m17n.org>
1322 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1323 return Qnil (Bug#8046, Bug#10193).
1325 2011-12-05 Kenichi Handa <handa@m17n.org>
1327 * coding.c (encode_designation_at_bol): New args charbuf_end and
1328 dst. Return the number of produced bytes. Callers changed.
1329 (coding_set_source): Return how many bytes coding->source was
1331 (coding_set_destination): Return how many bytes
1332 coding->destination was relocated.
1333 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1334 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1336 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1338 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1339 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1342 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1344 The following changes are to fix Bug#9318.
1346 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1347 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1348 (encode_coding_iso_2022, encode_coding_sjis)
1349 (encode_coding_big5, encode_coding_charset): Use the above macros.
1351 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1353 * lisp.h (process_quit_flag): Fix external declaration.
1355 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1357 Don't macro-inline non-performance-critical code.
1358 * eval.c (process_quit_flag): New function.
1359 * lisp.h (QUIT): Use it.
1361 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1363 * nsfns.m (get_geometry_from_preferences): New function.
1364 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1366 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1368 * emacs.c (Qkill_emacs): Define.
1369 (syms_of_emacs): Initialize it.
1370 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1371 Qquit_flag to `kill-emacs' instead.
1372 (quit_throw_to_read_char): Add parameter `from_signal'.
1373 All callers changed. Call Fkill_emacs if requested and safe.
1374 * lisp.h (QUIT): Call Fkill_emacs if requested.
1376 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1378 * widget.c (update_wm_hints): Return if wmshell is null.
1379 (widget_update_wm_size_hints): New function.
1381 * widget.h (widget_update_wm_size_hints): Declare.
1383 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1384 widget_update_wm_size_hints (Bug#10104).
1386 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1388 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1389 before a newline, prepare the bidi iterator for consuming the
1390 newline, and keep the current paragraph direction. (Bug#10183)
1391 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1393 2011-12-02 Juri Linkov <juri@jurta.org>
1395 * search.c (Fword_search_regexp): New Lisp function created from
1396 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1397 (Fword_search_backward, Fword_search_forward)
1398 (Fword_search_backward_lax, Fword_search_forward_lax):
1399 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1400 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1402 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1404 * fileio.c (Finsert_file_contents): Move after-change-function call
1405 to before the "handled:" label, since all "goto handled" appear in
1406 cases where the *-change-functions have already been properly called
1409 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1411 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1412 waiting for input. (Bug#10169)
1414 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1416 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1417 verifies glyph row's hash code--we have just reallocated the
1418 glyphs, so their contents can be complete garbage. (Bug#10164)
1420 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1422 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1424 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1426 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1427 attributes are tested _before_ calling verify_row_hash, to protect
1428 against GCC re-ordering of the tests. (Bug#10164)
1430 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1432 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1434 * xterm.c (handle_one_xevent): Only set async_visible and friends
1435 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1436 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1437 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1439 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1441 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1442 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1443 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1444 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1445 All uses changed to use GCPRO1 etc.
1446 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1447 Revert to old implementation (i.e., before 2011-03-11).
1449 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1451 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1452 of scroll runs so as to avoid assigning disabled bogus rows and
1453 unnecessary graphics copy operations.
1455 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1457 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1458 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1459 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1460 (malloc, free, realloc, calloc): Redirect to e_* only when
1463 * lisp.h (GCTYPEBITS): Move before first use.
1464 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1465 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1466 this macro definition.
1468 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1471 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1473 * gtkutil.c (xg_create_frame_widgets):
1474 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1475 present with Gtk+ 2.0.
1477 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1479 * fileio.c (Finsert_file_contents): Undo previous change; see
1480 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1482 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1484 Rename locals to avoid shadowing.
1485 * fileio.c (Finsert_file_contents):
1486 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1487 * process.c (wait_reading_process_output):
1488 Rename inner 'proc' to 'p' to avoid shadowing.
1489 Indent for consistency with usual Emacs style.
1491 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1493 * xdisp.c (redisplay_window): If cursor row is not fully visible
1494 after recentering, and scroll-conservatively is set to a large
1495 number, scroll window by a few more lines to make the cursor fully
1496 visible and out of scroll-margin. (Bug#10105)
1497 (start_display): Don't move to the next line if the display should
1498 start at a newline that is part of a display vector or an overlay
1501 2011-11-24 Juri Linkov <juri@jurta.org>
1503 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1504 after the `MagickPingImage' call. (Bug#10112)
1506 2011-11-23 Chong Yidong <cyd@gnu.org>
1508 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1510 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1512 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1513 making another buffer current. (Bug#10114)
1515 2011-11-23 Glenn Morris <rgm@gnu.org>
1517 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1519 2011-11-23 Chong Yidong <cyd@gnu.org>
1521 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1522 using it (Bug#5984).
1524 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1526 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1527 and header-lines, as they don't have one computed for them.
1530 * .gdbinit (prow): Make displayed values more self-explaining.
1531 Add row's hash code.
1533 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1535 * process.c (wait_reading_process_output): Fix asynchrounous
1536 GnuTLS socket handling on some versions of the GnuTLS library.
1537 (wait_reading_process_output): Add comment and URL.
1539 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1541 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1543 2011-11-21 Chong Yidong <cyd@gnu.org>
1545 * window.c (Fnext_window, Fprevious_window): Doc fix.
1547 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1549 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1551 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1553 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1555 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1557 * window.c (Fset_window_combination_limit): Rename argument
1559 (Vwindow_combination_limit): Remove "status" from doc-string.
1561 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1563 * m/ibms390.h: Remove.
1564 * m/ibms390x.h: Don't include "ibms390.h".
1566 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1568 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1569 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1571 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1573 * casetab.c (Fset_case_table):
1574 * charset.c (Fcharset_after): Fix typos.
1576 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1578 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1579 Otherwise, valgrind does not work on some platforms.
1580 Problem reported by Andreas Schwab in
1581 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1582 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1583 is set, removing the need for VIRT_ADDRESS_VARIES.
1584 (PURE_P): Use a more-efficient implementation that needs just one
1585 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1586 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1587 to 4 (xorl, subq, cmpq, setbe).
1588 * alloc.c (pure): Always extern now, since that's the
1589 VIRT_ADDR_VARIES behavior.
1590 (PURE_POINTER_P): Use a single comparison, not two, for
1591 consistency with the new puresize.h.
1592 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1593 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1594 Remove VIRT_ADDR_VARIES no longer needed.
1596 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1599 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1600 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1601 behave as if the cursor position were at the window margin.
1603 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1604 and the cursor position is out of bounds, behave as if the cursor
1605 position were at the window margin. (Bug#10075)
1607 2011-11-18 Chong Yidong <cyd@gnu.org>
1609 * window.c (Fwindow_combination_limit): Make first argument
1610 non-optional, since it is meaningless for live windows like the
1613 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1615 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1617 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1620 (graft_intervals_into_buffer): Simplify.
1622 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1624 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1625 hash values of the two rows.
1626 (copy_row_except_pointers): Preserve the used[] arrays and the
1627 hash values of the two rows. (Bug#10035)
1628 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1630 * xdisp.c (row_hash): New function, body extracted from
1631 compute_line_metrics.
1632 (compute_line_metrics): Call row_hash, instead of computing the
1635 * dispnew.c (verify_row_hash): Call row_hash for computing the
1636 hash code of a row, instead of duplicating code from xdisp.c.
1638 * dispextern.h (row_hash): Add prototype.
1640 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1642 * frame.c (delete_frame): Don't delete the terminal when the last
1643 X frame is closed if emacs is built with GTK toolkit.
1645 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1647 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1649 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1651 * window.c (Vwindow_splits): Rename to
1652 Vwindow_combination_resize. Suggested by Juri Linkov.
1653 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1656 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1658 * nsfns.m (Fns_font_name):
1659 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1661 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1663 * window.h (window): Rename slot "nest" to "combination_limit".
1664 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1665 (Fset_window_nest): Rename to Fset_window_combination_limit.
1666 (Vwindow_nest): Rename to Vwindow_combination_limit.
1667 (recombine_windows, make_parent_window, make_window)
1668 (Fsplit_window_internal, saved_window)
1669 (Fset_window_configuration, save_window_save): Rename all
1670 occurrences of window_nest to window_combination_limit.
1672 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1674 * image.c (imagemagick_load_image): Fix typo.
1676 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1678 * xdisp.c (display_line): Move the call to
1679 highlight_trailing_whitespace before the call to
1680 compute_line_metrics, since the latter needs to see the final
1681 faces of all the glyphs to compute ROW's hash value.
1682 Fixes assertion violations in row_equal_p. (Bug#10035)
1684 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1686 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1687 just return (bug#10044).
1689 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1691 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1692 with user-defined heap size. Bump the default size of the temacs
1693 heap to 27MB, to avoid memory warning when running temacs.
1694 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1696 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1697 current_matrix and desired_matrix. (Bug#9990)
1698 (verify_row_hash) [XASSERTS]: New function.
1699 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1700 that the hash value of glyph rows is correct.
1702 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1704 * window.h (window): Remove splits slot.
1705 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1706 (Fdelete_other_windows_internal, make_parent_window)
1707 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1708 (Fset_window_configuration, save_window_save): Don't deal with
1709 split status of windows.
1710 (saved_window): Remove splits slot.
1711 (Vwindow_splits): Rewrite doc-string.
1713 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1715 * xfns.c (unwind_create_frame):
1716 * nsfns.m (unwind_create_frame):
1717 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1718 Vframe_list (Bug#9999).
1720 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1722 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1724 2011-11-11 Kenichi Handa <handa@m17n.org>
1726 * callproc.c (Fcall_process): Set the member dst_multibyte of
1729 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1731 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1732 avoid a crash (bug#9496).
1734 2011-11-09 Chong Yidong <cyd@gnu.org>
1736 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1737 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1739 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1741 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1743 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1745 Avoid some portability problems by eschewing 'extern inline' functions.
1746 The trivial performance wins aren't worth the portability hassles; see
1747 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1749 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1750 (window_box_width, window_box_left, window_box_left_offset)
1751 (window_box_right, window_box_right_offset): Undo previous change,
1752 by removing the "extern"s.
1753 * intervals.c (adjust_intervals_for_insertion)
1754 (adjust_intervals_for_deletion): Undo previous change,
1755 making these static again.
1756 (offset_intervals, temp_set_point_both, temp_set_point)
1757 (copy_intervals_to_string): No longer inline.
1758 * xdisp.c (window_text_bottom_y, window_box_width)
1759 (window_box_height, window_box_left_offset)
1760 (window_box_right_offset, window_box_left, window_box_right)
1761 (window_box): No longer inline.
1763 2011-11-08 Chong Yidong <cyd@gnu.org>
1765 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1766 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1767 Signal an error if not a live window.
1768 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1769 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1771 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1773 * lisp.h (syms_of_abbrev): Remove declaration.
1774 Reported by CHENG Gao <chenggao@royau.me>.
1776 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1778 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1779 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1780 of temacs in GUI mode.
1782 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1784 * window.h: Declare delete_all_child_windows instead of
1785 delete_all_subwindows.
1786 * window.c (Fwindow_nest, Fset_window_nest)
1787 (Fset_window_new_total, Fset_window_new_normal)
1788 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1789 (delete_all_subwindows): Rename to delete_all_child_windows.
1790 (Fdelete_other_windows_internal, Fset_window_configuration):
1791 Call delete_all_child_windows instead of delete_all_subwindows.
1792 * frame.c (delete_frame): Call delete_all_child_windows instead
1793 of delete_all_subwindows.
1795 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1797 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1798 This is also needed for porting to any host where GC_MARK_STACK is
1799 not GC_MAKE_GCPROS_NOOPS.
1800 (which_symbols): Use it.
1802 2011-11-07 Kenichi Handa <handa@m17n.org>
1804 * coding.c (coding_set_destination): Check coding->src_pos only
1805 when coding->src_object is a buffer (bug#9910).
1807 * process.c (send_process): Set the member src_multibyte of coding
1808 to 0 (bug#9911) when sending a unibyte text.
1810 * callproc.c (Fcall_process): Set the member src_multibyte of
1811 process_coding to 0 (bug#9912).
1813 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1815 * xmenu.c (cleanup_widget_value_tree): New function.
1816 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1817 calling free_menubar_widget_value_tree directly (Bug#9830).
1819 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1821 Fix some portability problems with 'inline'.
1822 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1823 (window_box_width, window_box_left, window_box_left_offset)
1824 (window_box_right, window_box_right_offset): Declare extern.
1825 Otherwise, these inline functions do not conform to C99 and
1826 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1827 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1828 * intervals.c (adjust_intervals_for_insertion)
1829 (adjust_intervals_for_deletion): Now extern, because otherwise the
1830 extern inline functions 'offset_intervals' couldn't refer to it.
1831 (static_offset_intervals): Remove.
1832 (offset_intervals): Rewrite using the old contents of
1833 static_offset_intervals. The old version didn't conform to C99
1834 because an extern inline function contained a reference to an
1835 identifier with static linkage.
1837 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1839 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1842 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1844 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1845 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1846 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1847 return Qleft_to_right.
1849 2011-11-06 Chong Yidong <cyd@gnu.org>
1851 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1852 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1853 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1854 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1855 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1856 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1857 (Fwindow_vscroll): Doc fix.
1858 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1859 argument, since it makes no sense to pass a live window and for
1860 consistency with window-child.
1862 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1864 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1867 2011-11-05 Jason Rumney <jasonr@gnu.org>
1869 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1870 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1872 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1873 bitwise arithmetic preventing use of unicode-sip and non-truetype
1876 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1878 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1881 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1882 initialization code to keep similarity to xfns.c after changes
1885 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1887 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1888 (unwind_create_frame): New function (Bug#9943).
1889 (Fx_create_frame): Restructure code to be more similar to the one in
1890 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1891 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1892 Move terminal->reference_count++ just before making the frame official
1895 * nsterm.m (x_free_frame_resources): New function.
1896 (x_destroy_window): Move code to x_free_frame_resources.
1898 * xfns.c (unwind_create_frame): Fix comment.
1899 (Fx_create_frame, x_create_tip_frame):
1900 Move terminal->reference_count++ just before making the frame
1901 official. Move initialization of image_cache_refcount and
1902 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1904 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1906 Support MSVC build with newer versions of Visual Studio.
1907 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1908 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1911 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1912 which are not supported by MSVC.
1913 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1914 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1916 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1918 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1920 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1922 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1924 Support MSVC build with newer versions of Visual Studio.
1925 * w32.c: Don't include w32api.h for MSVC.
1926 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1928 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1929 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1930 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1931 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1933 (alloca) [_MSC_VER]: Define to _alloca.
1935 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1937 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1939 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1941 * xdisp.c (note_mouse_highlight): If either of
1942 previous/next-single-property-change returns nil, treat that as
1943 the beginning or the end of the buffer. (Bug#9955)
1945 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1947 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1948 label is not null (Bug#9951).
1949 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1952 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1954 * window.c (Fwindow_body_size): Mention in the doc string that the
1955 return value is in frame's canonical units. (Bug#9949)
1957 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1961 * w32fns.c (unwind_create_frame): If needed, free the glyph
1962 matrices of the partially constructed frame. (Bug#9943)
1963 * xfns.c (unwind_create_frame): Likewise.
1965 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1967 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1968 Don't stop backward scan on the continuation glyph, even though
1969 its CHARPOS is positive.
1970 (mouse_face_from_buffer_pos, note_mouse_highlight):
1971 Rename cover_string to disp_string.
1973 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1975 * window.c (temp_output_buffer_show): Don't use
1976 Vtemp_buffer_show_specifiers.
1977 (Vtemp_buffer_show_specifiers): Remove unused variable.
1979 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1982 past the beginning of the current glyph matrix.
1984 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1986 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1987 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1988 HAVE_GTK3 (Bug#9869).
1990 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1991 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1993 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1995 * xterm.c: Declare x_handle_net_wm_state to return int.
1996 (handle_one_xevent): Check if we are iconified but don't have
1997 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1998 (get_current_wm_state): Return non-zero if not hidden,
1999 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2000 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2001 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2002 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2004 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2006 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2007 so that this new function doesn't get optimized away by a
2008 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2010 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2012 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2014 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2016 Fix the `xbytecode' command.
2017 * .gdbinit (xprintbytestr): New command.
2018 (xwhichsymbols): Rename from `which'; all callers changed.
2019 (xbytecode): Print the byte-code string as well.
2021 2011-10-29 Kim Storm <storm@cua.dk>
2023 * alloc.c (which_symbols): New function.
2025 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2027 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2030 2011-10-29 Glenn Morris <rgm@gnu.org>
2032 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2033 Not clear what it was for, and it causes various bugs. (Bug#9839)
2035 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2037 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2038 possible random value that matches one of those tested as
2039 condition to clear the mouse face.
2041 2011-10-28 Chong Yidong <cyd@gnu.org>
2043 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2045 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2047 * window.c (make_window): Initialize phys_cursor_on_p.
2049 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2051 * lisp.h (struct Lisp_Symbol): Update comments.
2053 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2055 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2057 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2059 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2060 <oslsachem@gmail.com> for helping to debug this.
2062 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2063 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2064 (g_b_init_get_glyph_outline_w): New static variables.
2065 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2066 (GetGlyphOutlineW_Proc): New typedefs.
2067 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2068 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2070 (w32font_open_internal, compute_metrics):
2071 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2072 instead of calling the "wide" APIs directly.
2074 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2076 * w32.h (syms_of_w32font): Add prototype.
2078 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2080 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2081 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2082 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2083 (Fmove_to_window_line): Doc fix.
2085 2011-10-27 Chong Yidong <cyd@gnu.org>
2087 * process.c (make_process): Set gnutls_state to NULL.
2089 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2090 non-NULL, regardless of GNUTLS_INITSTAGE.
2091 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2092 an error. Set process slots as soon as we allocate them.
2094 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2096 2011-10-27 Chong Yidong <cyd@gnu.org>
2098 * gnutls.c (emacs_gnutls_deinit): New function.
2099 Deallocate credentials structures as well as calling gnutls_deinit.
2100 (Fgnutls_deinit, Fgnutls_boot): Use it.
2102 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2103 (deactivate_process): Call emacs_gnutls_deinit.
2105 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2107 * image.c (x_create_x_image_and_pixmap):
2108 * w32.c (sys_rename, w32_delayed_load):
2109 * w32font.c (fill_in_logfont):
2110 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2112 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2114 * w32fns.c (w32_default_color_map): New function,
2115 extracted from Fw32_default_color_map.
2116 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2118 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2120 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2122 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2124 * keyboard.c (test_undefined): New function (bug#9751).
2125 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2127 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2129 * sysdep.c (init_sys_modes): Fix the check for the controlling
2130 terminal (Bug#6649).
2132 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2134 * dispextern.h (struct bidi_it): New member next_en_type.
2136 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2137 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2138 current character, check also for next_en_type being WEAK_EN.
2139 (bidi_resolve_weak): Don't enter the expensive loop if the current
2140 position is before next_en_pos. Record the bidi type of the first
2141 non-ET, non-BN character we find, in addition to its position.
2142 (bidi_level_of_next_char): Invalidate next_en_type when
2143 next_en_pos is over-stepped.
2145 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2147 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2148 * editfns.c: Rewrite current-time-zone so that it invokes
2149 the equivalent of (format-time-string "%Z") to get the time zone name.
2150 This fixes a bug when the time zone name contains characters that
2151 need converting from the system time locale to Emacs internal format.
2152 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2153 that patch fixed format-time-string to do the conversion, but
2154 I forgot to fix current-time-zone.
2155 (format_time_string): New function, containing most of
2156 what Fformat_time_string used to contain.
2157 (Fformat_time_string): Rewrite in terms of format_time_string.
2158 This doesn't change this function's behavior.
2159 (current-time-zone): Rewrite to use format_time_string.
2160 This fixes the bug reported by Michael Schierl in
2161 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2162 Jason Rumney's 2007-06-07 change worked around this bug, but
2164 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2166 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (start_display): If the character at POS is displayed
2169 via a display vector, reset IT->current.dpvec_index to zero.
2170 (try_window_reusing_current_matrix): If a line ends in a display
2171 vector or the next line starts in a display vector, continue
2172 redrawing the window even though the character position of
2173 start_row was reached.
2176 2011-10-18 Chong Yidong <cyd@gnu.org>
2178 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2179 with nobreak-char-display too.
2181 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2183 Fix part 3 of bug#9771.
2184 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2185 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2186 non-neutral characters if the current character is a paragraph
2187 separator (a.k.a. Newline). This avoids running the same
2188 expensive loop twice, once when we consume the preceding newline
2189 and the other time when the line actually needs to be displayed.
2190 Avoid the loop when we see neutrals on the base embedding level
2191 following a character whose directionality is the same as the
2192 paragraph's. This avoids running the expensive loop when a line
2193 ends in a long sequence of neutrals, like control characters.
2194 Add assertion against STRONG_AL type. Slightly rearrange code
2195 that determines the type of a neutral given the first non-neutral
2197 (bidi_level_of_next_char): Set next_en_pos to zero when
2198 invalidating its info.
2200 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2202 * xdisp.c (push_display_prop): Determine whether to record string
2203 or buffer position by IT->string, not by IT->method. Allow
2204 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2205 (move_it_vertically_backward): Don't look for character position
2206 immediately after the newline when in a continuation line.
2209 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2211 * window.c (coordinates_in_window): Rewrite and delabelize
2212 vertical border check. (Bug#5357) (Bug#9618)
2214 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2216 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2217 errors in XSetWindowBorder (bug#9310).
2219 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2221 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2222 avoid crash when xmalloc overrun checking is enabled.
2224 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2226 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2227 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2228 cursor motion with <left> and <right> arrow keys.
2230 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2231 some callers set that themselves.
2233 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2236 display string and the previous row comes from the same string and
2237 is empty. (Bug#9739) (Bug#9738)
2239 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2241 * doc.c (get_doc_string): Encode file name (bug#9735).
2243 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2245 * bidi.c (bidi_level_of_next_char):
2246 * xdisp.c (get_visually_first_element): Remove old incorrect
2247 comments regarding the Unicode Line Separator character.
2249 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2251 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2253 * alloc.c (Fgc_status): Do not access beyond zombies array
2254 boundary if nzombies > MAX_ZOMBIES.
2255 * alloc.c (dump_zombies): Add missing format specifier.
2257 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2259 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2260 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2262 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2263 Some packages use them to denote characters with modifiers.
2265 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2267 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2268 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2269 matching a pp-number. Rename parameter var to var1.
2271 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2273 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2275 2011-10-08 Glenn Morris <rgm@gnu.org>
2277 * callint.c (Fcall_interactively): Give a more explicit error for the
2278 'c' case with a non-character input. (Bug#8479)
2280 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2282 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2284 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2285 lines that are hscrolled on the left.
2287 * dispnew.c (buffer_posn_from_coords): Account for a possible
2288 presence of header-line. (Bug#4426)
2290 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2292 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2293 Don't advertise functionality which we discourage or doesn't work.
2295 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2297 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2298 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2299 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2300 this makes Emacs dump core during garbage collection on rare
2301 occasions. sizeof is obviously inferior to offsetof here, so
2302 stick with offsetof.
2303 (GC_POINTER_ALIGNMENT): New macro.
2304 (mark_memory): Omit 3rd (offset) arg; caller changed.
2305 Don't assume EMACS_INT alignment is the same as pointer alignment.
2307 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2309 * keyboard.c (read_key_sequence_remapped): New var.
2310 (read_key_sequence): Compute remapping in the right buffer.
2311 (command_loop_1): Use read_key_sequence's remapping directly.
2313 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2315 * dired.c (file_name_completion): Don't expand file name.
2316 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2317 before checking file name handler.
2319 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2320 they've been requested explicitly (bug#9591).
2322 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2324 * keymap.c (Fsingle_key_description): Use make_specified_string
2325 instead of build_string to build string from push_key_description.
2328 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2330 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2331 This fixes a Y2038 bug on 64-bit hosts.
2332 * buffer.c (reset_buffer):
2333 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2334 (Fclear_buffer_auto_save_failure):
2335 Use 0, not -1, to represent an unset failure time, since time_t
2336 might not be signed.
2338 Remove dependency on glibc malloc internals.
2339 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2340 Move back here from lisp.h, but with their new implementations.
2341 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2342 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2343 * charset.c (charset_table_init): New static var.
2344 (syms_of_charset): Use it instead of xmalloc. This removes a
2345 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2346 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2347 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2348 Move back to alloc.c.
2349 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2350 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2352 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2354 * nsterm.m (windowDidResize): Call x_set_window_size only when
2355 ns_in_resize is true. Otherwise set pixelwidth/height and
2356 call change_frame_size (Bug#9628).
2358 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2360 Port --enable-checking=all to Fedora 14 x86-64.
2361 * charset.c (syms_of_charset): Also account for glibc malloc's
2362 internal overhead when calculating the initial malloc maximum.
2364 Port --enable-checking=all to Fedora 14 x86.
2365 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2367 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2368 (overrun_check_realloc, overrun_check_free):
2369 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2370 That way, xmalloc returns a properly-aligned pointer even if
2371 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2372 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2373 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2374 into account when calculating the initial malloc maximum.
2375 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2376 Move here from alloc.c, so that charset.c can use it too.
2377 Properly align; the old code wasn't right for common 32-bit hosts
2378 when configured with --enable-checking=all.
2379 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2380 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2382 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2384 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2387 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2389 * xdisp.c (compute_display_string_end): If there's no display
2390 string at CHARPOS, return -1.
2392 * bidi.c (bidi_fetch_char): When compute_display_string_end
2393 returns a negative value, treat the character as a normal
2394 character not covered by a display string. (Bug#9624)
2396 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2398 * lread.c (Fread_from_string): Fix typo in docstring.
2400 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2402 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2403 newline, reseat the iterator instead of bidi-iterating there one
2404 character at a time. (Bug#9610)
2405 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2406 TO_CHARPOS if the bidi iterator is at base embedding level.
2408 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2410 * lread.c (readevalloop): Use correct code for NBSP.
2411 (read1): Likewise. (Bug#9608)
2413 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2415 * dbusbind.c (Fdbus_register_signal): When service is not
2416 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2418 2011-09-25 Glenn Morris <rgm@gnu.org>
2420 * buffer.c (truncate-lines): Doc fix.
2422 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2424 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2425 (Fset_window_next_buffers): Doc fix.
2427 2011-09-24 Glenn Morris <rgm@gnu.org>
2429 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2431 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2433 Fix minor problems found by static checking.
2434 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2435 * indent.c (Fvertical_motion): Fix == vs = typo.
2437 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2439 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2440 Default value is now t. Doc fix.
2442 * indent.c (Fvertical_motion): Compute and apply the overshoot
2443 logic when moving up, not only when moving down. Fix the
2444 confusing name and values of the it_overshoot_expected variable;
2445 logic changes accordingly. (Bug#9254) (Bug#9549)
2447 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2448 CHARPOS is covered by a display string which includes newlines.
2449 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2450 is covered by a display string with embedded newlines.
2452 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2454 * dbusbind.c (Fdbus_register_signal): Add match rule to
2455 Vdbus_registered_objects_table. (Bug#9581)
2456 (Fdbus_register_method, Vdbus_registered_objects_table):
2459 2011-09-24 Jim Meyering <meyering@redhat.com>
2461 do not ignore write error for any output size
2462 The previous change was incomplete.
2463 While it makes emacs --batch detect the vast majority of stdout
2464 write failures, errors were still ignored whenever the output size is
2465 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2466 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2467 && echo FAIL: ignored write error
2468 FAIL: ignored write error
2469 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2470 && echo FAIL: ignored write error
2471 FAIL: ignored write error
2472 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2474 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2476 * emacs.c (Fkill_emacs): In noninteractive mode exit
2477 non-successfully if a write error occurred on stdout. (Bug#9574)
2479 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2481 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2484 * dispextern.h (struct it): Update the comment documenting what
2487 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2489 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2490 a display string, extend search for cursor position to end of row.
2491 (find_row_edges): If the row ends in a newline from a display
2492 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2493 Handle the case of a display string with multiple newlines.
2494 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2495 non-empty line. Fixes confusing cursor motion with arrow keys at
2496 the beginning of a line that starts with whitespace.
2498 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2500 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2503 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2505 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2508 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2510 * xdisp.c (display_line): Record maximum and minimum buffer
2511 positions even if no glyphs were produced (e.g., by a zero-width
2512 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2513 buffer positions that will be removed from the glyph row because
2515 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2516 column is beyond frame width: don't subtract 1 "pixel" when
2517 computing width of the stretch.
2518 (reseat_at_next_visible_line_start): Undo the change made on
2519 2011-09-17 that saved paragraph information and restored it after
2520 the call to `reseat'. (Bug#9545)
2522 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2524 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2525 and turn window cursor on if cleared (Bug#9415).
2527 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2529 * search.c (boyer_moore): Take unibyte characters from pattern
2530 literally. (Bug#9458)
2532 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2534 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2536 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2538 Fix minor problem found by static checking.
2539 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2540 initialized, to pacify gcc -Wuninitialized.
2542 * fileio.c: Report proper errno when syscall falls.
2543 (Finsert_file_contents): Save and restore errno,
2544 so that report_file_error outputs the correct diagnostic.
2545 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2547 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2549 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2551 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2553 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2554 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2556 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2558 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2559 about the current paragraph and restore it after the call to reseat.
2561 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2562 (bidi_find_paragraph_start): Search back for paragraph beginning
2563 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2564 (bidi_move_to_visually_next): Only trigger paragraph-related
2565 computations when the last character is a newline or at EOB, not
2566 just any NEUTRAL_B. (Bug#9470)
2568 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2569 truncated lines if point is covered by a display string. (Bug#9524)
2571 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2573 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2574 (cons_to_x_long): New function.
2575 (lisp_data_to_selection_data): Use it. Correct the test for
2576 short-versus-long data; it was negated. Break out of vector
2577 loop, for efficiency, when a long datum is discovered.
2579 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2581 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2583 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2585 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2586 GCC PR/17406) by declaring this function with external scope.
2588 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2590 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2591 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2593 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2595 * editfns.c (Fformat): Correctly handle text properties on "%%".
2597 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2599 * xterm.c (x_draw_composite_glyph_string_foreground):
2600 * w32term.c (x_draw_composite_glyph_string_foreground):
2601 * term.c (encode_terminal_code):
2602 * composite.c (composition_update_it, get_composition_id):
2603 * xdisp.c (get_next_display_element)
2604 (fill_composite_glyph_string): Add comments about special meaning
2605 of TAB characters in a composition.
2607 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2609 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2610 This occurs when processing a multibyte format.
2611 Problem reported by Wolfgang Jenker.
2613 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2615 * xdisp.c (try_cursor_movement): Only check for exact match if
2616 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2618 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2620 Remove unused external symbols.
2621 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2622 * xdisp.c (calc_pixel_width_or_height): Now static.
2623 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2624 * indent.c (check_display_width):
2625 * w32term.c: Fix comment to match code.
2626 * xterm.c, xterm.h (x_catching_errors): Remove.
2628 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2630 * xselect.c: Use signed conversions more consistently (Bug#9498).
2631 (selection_data_to_lisp_data): Assume incoming selection data are
2632 signed integers, not unsigned. This is to be consistent with
2633 outgoing selection data, which was modified to use signed integers
2634 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2635 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2636 expects long, not unsigned long.
2638 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2640 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2641 computation of loop end. Reported by Johan Bockgård
2644 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2646 * frame.c (Fother_visible_frames_p): Function deleted.
2648 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2650 * indent.c (compute_motion): Process display vector front to back
2651 rather than the other way around. (Bug#2496)
2653 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2655 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2657 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2659 * minibuf.c (Fread_from_minibuffer): Doc fix.
2661 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2663 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2664 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2666 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2669 value for non-existent files.
2671 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2673 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2674 set its "size" to -1. This will set the modtime_size field of
2675 the corresponding buffer to -1, which is what
2676 verify-visited-file-modtime expects for files that do not exist.
2679 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2681 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2683 * lisp.h: ... from here. push_key_description is no longer
2684 defined in keyboard.c, so its declaration should not be in
2685 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2686 logically belongs with push_key_description.
2688 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2690 * buffer.h: Include <sys/types.h> instead of <time.h>.
2691 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2692 Problem reported by Herbert J. Skuhra.
2694 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2696 * xml.c (parse_region): Make the parsing work for
2697 non-comment-starting XML files again (bug#9144).
2699 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2701 * image.c (gif_load): Fix calculation of bottom and right corner.
2704 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2706 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2707 redisplay in small windows.
2709 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2711 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2713 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2715 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2716 Operate on live windows only.
2718 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2720 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2722 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2724 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2725 only under bidi iteration.
2727 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2729 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2731 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2733 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2734 Without this fix, the command to link temacs failed due to an
2735 undefined symbol __builtin_isnan. This is because
2736 /usr/include/iso/math_c99.h #defines isnan(x) to
2737 __builtin_isnan(x), but the bundled gcc, which identifies itself
2738 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2740 * floatfns.c (isnan): #undef, and then #define to a clone of
2742 (Fisnan): Always define, since it's always available now.
2743 (syms_of_floatfns): Always define isnan at the Lisp level.
2745 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2747 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2749 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2751 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2752 The previous code assumed that file offsets (off_t values) fit in
2753 EMACS_INT variables, which is not true on typical 32-bit hosts.
2754 The code messed up by falsely reporting buffer overflow in cases
2755 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2756 when "big" contains more than 2**29 bytes, even though this
2757 inserts just one byte and does not overflow the buffer.
2758 (Finsert_file_contents): Store file offsets as off_t
2759 values, not as EMACS_INT values. Check for overflow when
2760 converting between EMACS_INT and off_t. When checking for
2761 buffer overflow or for overlap, take the offsets into account.
2762 Don't use EMACS_INT for small values where int suffices.
2763 When checking for overlap, fix a typo: ZV was used where
2764 ZV_BYTE was intended.
2765 (Fwrite_region): Don't assume off_t fits into 'long'.
2766 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2768 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2770 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2772 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2774 sprintf-related integer and memory overflow issues (Bug#9412).
2776 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2777 (esprintf, exprintf, evxprintf): New functions.
2778 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2779 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2780 (modify_event_symbol): Do not assume that the length of
2781 name_alist_or_stem is safe to alloca and fits in int.
2782 (Fexecute_extended_command): Likewise for function name and binding.
2783 (Frecursion_depth): Wrap around reliably on integer overflow.
2784 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2785 since some callers pass EMACS_INT values.
2786 (Fsingle_key_description): Don't crash if symbol name contains more
2787 than MAX_ALLOCA bytes.
2788 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2789 (get_minibuffer): Arg is now EMACS_INT, not int.
2790 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2791 (esprintf, exprintf, evxprintf): New decls.
2792 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2794 * dbusbind.c (signature_cat): New function.
2795 (xd_signature, Fdbus_register_signal):
2796 Do not overrun buffer; instead, report string overflow.
2798 * dispnew.c (add_window_display_history): Don't overrun buffer.
2799 Truncate instead; this is OK since it's just a log.
2801 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2802 even if the time zone offset is outlandishly large.
2803 Don't mishandle offset == INT_MIN.
2805 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2806 when creating daemon; the previous buffer-overflow check was incorrect.
2808 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2809 which has the guts of the old verror function.
2811 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2812 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2814 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2815 (font_unparse_xlfd): Don't blindly alloca long strings.
2816 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2817 fits in int, when using sprintf. Use single snprintf to count
2818 length of string rather than counting it via multiple sprintfs;
2819 that's simpler and more reliable.
2820 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2821 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2822 sprintf, in case result does not fit in int.
2824 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2825 (fontset_from_font): Print it.
2827 * frame.c (tty_frame_count): Now printmax_t, not int.
2828 (make_terminal_frame, set_term_frame_name): Print it.
2829 (x_report_frame_params): In X, window IDs are unsigned long,
2830 not signed long, so print them as unsigned.
2831 (validate_x_resource_name): Check for implausibly long names,
2832 and don't assume name length fits in 'int'.
2833 (x_get_resource_string): Don't blindly alloca invocation name;
2834 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2837 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2838 (xg_check_special_colors, xg_set_geometry):
2839 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2841 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2842 Use esprintf, not sprintf, in case result does not fit in int.
2844 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2845 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2846 it as a large positive number.
2847 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2848 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2850 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2851 in case result does not fit in int.
2853 * print.c (float_to_string): Detect width overflow more reliably.
2854 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2855 buffer overrun. Don't assume list length fits in 'int'. Treat
2856 print length of 0 as 0, not as infinity; to be consistent with other
2857 uses of print length in this function. Don't overflow print length
2858 index. Don't assume hash table size fits in 'long', or that
2859 vectorlike size fits in 'unsigned long'.
2861 * process.c (make_process): Use printmax_t, not int, to format
2862 process-name gensyms.
2864 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2866 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2867 to avoid potential buffer overrun.
2869 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2870 if X resource line is longer than 512 bytes.
2872 * xfns.c (x_window): Make sprintf buffer a bit bigger
2873 to avoid potential buffer overrun.
2875 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2877 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2879 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2881 Integer overflow fixes for scrolling, etc.
2882 Without these, Emacs silently mishandles large integers sometimes.
2883 For example, "C-u 4294967297 M-x recenter" was treated as if
2884 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2886 * xdisp.c (try_window_id): Check Emacs fixnum range before
2887 converting to 'int'.
2889 * window.c (window_scroll_line_based, Frecenter):
2890 Check that an Emacs fixnum is in range before assigning it to 'int'.
2891 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2892 values converted from Emacs fixnums.
2893 (Frecenter): Don't wrap around a line count if it is out of 'int'
2894 range; instead, treat it as an extreme value.
2895 (Fset_window_configuration, compare_window_configurations):
2896 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2898 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2899 that can exceed INT_MAX. Check that EMACS_INT value is in range
2900 before assigning it to the (possibly-narrower) index.
2901 (match_limit): Don't assume that a fixnum can fit in 'int'.
2903 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2906 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2907 (Fvertical_motion): Don't wrap around LINES values that don't fit
2908 in 'int'. Instead, treat them as extreme values. This is good
2909 enough for windows, which can't have more than INT_MAX lines anyway.
2911 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913 * Require libxml/parser.h to avoid compilation warning.
2915 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2917 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2918 since this reportedly can destroy thread storage.
2920 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2922 * syntax.c (find_defun_start): Update all cache variables if
2923 exiting early (Bug#9401).
2925 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2927 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2929 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2930 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2931 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2933 * term.c (tty_append_glyph): New function.
2934 (produce_stretch_glyph): Static function and its prototype deleted.
2936 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2939 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2941 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2942 when checking :margin (Bug#9390).
2943 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2944 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2945 so that the name doesn't mislead. All uses changed.
2947 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2949 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2952 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2954 * xdisp.c (move_it_to): Don't bail out early when reaching
2955 position beyond to_charpos, if we are scanning backwards.
2956 (move_it_vertically_backward): When DY == 0, make sure we get to
2957 the first character in the line after the newline.
2959 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2961 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2962 (ccl_driver): Do not generate an out-of-range pointer.
2963 (Fccl_execute_on_string): Remove unnecessary check for
2964 integer overflow, noted by Stefan Monnier in
2965 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2966 Remove a FIXME that didn't need fixing.
2967 Simplify the newly-introduced buffer reallocation code.
2969 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2971 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2973 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2975 Integer and memory overflow issues (Bug#9196).
2977 * doc.c (get_doc_string): Rework so that
2978 get_doc_string_buffer_size is the actual buffer size, rather than
2979 being 1 less than the actual buffer size; this makes xpalloc more
2982 * image.c (x_allocate_bitmap_record, cache_image):
2983 * xselect.c (Fx_register_dnd_atom):
2984 Simplify previous changes by using xpalloc.
2986 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2987 since either will do and ptrdiff_t is convenient with xpalloc.
2989 * charset.c (charset_table_size)
2990 (struct charset_sort_data.priority): Now ptrdiff_t.
2991 (charset_compare): Don't overflow if priorities differ greatly.
2992 (Fsort_charsets): Don't assume list length fits in int.
2993 Check for size-calculation overflow when allocating sort data.
2994 (syms_of_charset): Allocate an initial charset table that is
2995 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2997 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2999 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3000 The actual value is always <= INT_MAX, and leaving it unsigned made
3001 overflow checking harder.
3003 * dispextern.h (struct glyph_matrix.rows_allocated)
3004 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3005 with xpalloc. The values are still always <= INT_MAX.
3007 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3009 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3010 (SAFE_NALLOCA): New macro.
3012 * region-cache.c (struct boundary.pos, find_cache_boundary)
3013 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3014 (set_cache_region, invalidate_region_cache)
3015 (revalidate_region_cache, know_region_cache, region_cache_forward)
3016 (region_cache_backward, pp_cache):
3017 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3018 so that ptrdiff_t * can be passed to xpalloc.
3019 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3020 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3021 (pp_cache): Don't assume cache_len fits in int.
3022 * region-cache.h: Adjust extern decls to match.
3024 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3025 EMACS_INT, since either will do, for xpalloc.
3027 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3028 (xnmalloc, xnrealloc, xpalloc): New functions.
3030 * bidi.c (bidi_shelve_header_size): New constant.
3031 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3032 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3034 * bidi.c (bidi_cache_shrink):
3035 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3037 Don't update size of array until after memory allocation succeeds,
3038 because xmalloc/xrealloc may not return.
3039 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3040 now that we have proper integer overflow checking.
3041 (record_overlay_string, overlay_strings): Catch overflows when
3042 calculating size of overlay_str_buf.
3044 * callproc.c (Fcall_process): Check for size overflow when
3045 calculating size of args2.
3046 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3047 Normally we prefer signed values, but sticking with ptrdiff_t would
3048 require adding more-complicated checks.
3050 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3051 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3052 Redo buffer-overflow calculations to avoid integer overflow.
3053 Add a FIXME comment where memory seems to be over-allocated.
3055 * character.c (Fstring): Check for size-calculation overflow.
3057 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3058 unnecessary integer overflow. Check for size overflow.
3059 (encode_coding_object): Don't update size until xmalloc succeeds.
3061 * composite.c (get_composition_id): Check for overflow in glyph
3062 length calculations.
3064 Integer and memory overflow fixes for display code.
3065 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3066 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3067 (scrolling_window): Check for overflow in size calculations.
3068 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3069 Don't assume glyph table len fits in int.
3070 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3071 (row_table_size): Now ptrdiff_t, not int.
3072 (scrolling_window): Avoid overflow in size calculations.
3073 Don't update size until allocation succeeds.
3074 * fns.c (concat): Check for overflow in size calculations.
3075 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3076 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3077 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3079 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3080 (get_doc_string): Check for size calculation overflow.
3081 Don't update size until allocation succeeds.
3082 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3083 EMACS_INT, where ptrdiff_t will do.
3084 (Fsubstitute_command_keys): Check for string overflow.
3086 * editfns.c (set_time_zone_rule): Don't assume environment length
3088 (message_length): Now ptrdiff_t, not int.
3089 (Fmessage_box): Don't update size until allocation succeeds.
3090 Don't assume message length fits in int.
3091 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3093 * emacs.c (main): Do not reallocate argv, since there is a null at
3094 the end that can be overwritten, and this way there's no need to
3095 worry about size-calculation overflow.
3096 (sort_args): Check for size-calculation overflow.
3098 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3100 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3102 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3103 (x_set_scroll_bar_width, x_figure_window_size):
3104 Check for integer overflow.
3105 (x_set_alpha): Do not assume XINT fits in int.
3107 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3108 This is for the members text_lines, text_cols, total_lines, total_cols,
3109 where the system imposes an 'int' limit.
3111 * fringe.c (Fdefine_fringe_bitmap):
3112 Don't update size until alloc works.
3114 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3115 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3117 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3118 Check for size-calculation overflow.
3119 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3120 do, as we prefer signed integers.
3121 (id_to_widget.max_size, id_to_widget.used)
3122 (xg_store_widget_in_map, xg_remove_widget_from_map)
3123 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3124 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3125 Use and return ptrdiff_t, not int.
3126 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3127 * gtkutil.h: Change prototypes to match the above.
3129 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3130 are duplicate now that they've been promoted to lisp.h.
3131 (x_allocate_bitmap_record, x_alloc_image_color)
3132 (make_image_cache, cache_image, xpm_load):
3133 Don't update size until alloc is done.
3134 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3136 Check for size calculation overflow.
3137 (ct_colors_allocated_max): New constant.
3138 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3141 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3142 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3143 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3144 Use ptrdiff_t, not int, to count maps.
3145 (read_char_minibuf_menu_prompt): Check for overflow in size
3146 calculations. Don't update size until allocation succeeds.
3147 Redo calculations to avoid overflow.
3148 * keyboard.h: Change prototypes to match the above.
3150 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3152 (current_minor_maps): Check for size calculation overflow.
3153 * keymap.h: Change prototypes to match the above.
3155 * lread.c (read1, init_obarray): Don't update size until alloc done.
3157 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3158 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3160 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3161 Now ptrdiff_t, not int.
3162 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3163 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3165 * process.c (Fnetwork_interface_list): Check for overflow
3166 in size calculation.
3168 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3170 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3171 overflow. Don't bother calling xmalloc when xrealloc will do.
3173 * search.c (Freplace_match): Check for size calculation overflow.
3174 (Fset_match_data): Don't assume list lengths fit in 'int'.
3176 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3177 for command line length. Do not attempt to address one before the
3178 beginning of an array, as that's not portable.
3180 * term.c (max_frame_lines): Remove; unused.
3181 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3183 (encode_terminal_code, calculate_costs): Check for size
3184 calculation overflow.
3185 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3186 table lengths and related sizes. Don't update size until alloc
3187 done. Redo calculations to avoid overflow.
3188 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3190 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3191 subtracting pointers.
3192 (gobble_line): Check for overflow more carefully. Don't update size
3195 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3196 Don't update size until alloc done.
3197 Redo size calculations to avoid overflow.
3198 Check for size calculation overflow.
3199 (main) [DEBUG]: Fix typo in invoking tparam1.
3201 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3202 Use ptrdiff_t, not int, for sizes.
3203 (store_mode_line_noprop_char): Don't update size until alloc done.
3205 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3206 Use ptrdiff_t, not int, for sizes.
3207 (Finternal_make_lisp_face, cache_face):
3208 Check for size calculation overflow.
3209 (cache_face): Treat size calculation overflows as if they were
3210 memory exhaustion (the usual treatment), rather than aborting.
3212 * xfns.c (x_encode_text, x_set_name_internal)
3213 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3214 sizes, since they can exceed INT_MAX in size. Check for size
3215 calculation overflow.
3217 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3218 (xg_select): Check for size calculation overflow.
3219 Don't update size until alloc done.
3221 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3222 as sprintf is limited to int lengths.
3224 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3225 (X_LONG_MIN): New macros.
3226 Use them to make the following changes clearer.
3227 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3228 This change doesn't affect the value now, but it may help remind
3229 future maintainers not to raise the value too much later.
3230 (SELECTION_QUANTUM): Remove, replacing with ...
3231 (selection_quantum): ... new function, which avoids overflow.
3233 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3234 assumption that selection length fits in 'int'.
3235 (x_reply_selection_request, x_handle_selection_request)
3236 (x_get_window_property, receive_incremental_selection)
3237 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3238 (lisp_data_to_selection_data, clean_local_selection_data):
3239 Use ptrdiff_t, not int, to record length of selection.
3240 (x_reply_selection_request, x_get_window_property)
3241 (receive_incremental_selection, x_property_data_to_lisp):
3242 Redo calculations to avoid overflow.
3243 (x_reply_selection_request): When sending hint, ceiling it at
3244 X_LONG_MAX rather than relying on wraparound overflow to send
3246 (x_get_window_property, receive_incremental_selection)
3247 (lisp_data_to_selection_data, x_property_data_to_lisp):
3248 Check for size-calculation overflow.
3249 (x_get_window_property, receive_incremental_selection)
3250 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3251 Don't store size until memory allocation succeeds.
3252 (x_get_window_property): Plug memory leak on memory exhaustion.
3253 Don't double-block input; malloc is safe here. Don't assume 2**34
3254 - 4 fits in unsigned long. Add an xassert to check
3255 XGetWindowProperty overflow. Be more careful about overflow
3256 calculations, and distinguish size from memory overflow better.
3257 (receive_incremental_selection): When tracing, don't assume
3258 unsigned int is less than INT_MAX.
3259 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3260 harmful) conversions of unsigned short to int.
3261 (lisp_data_to_selection_data): Don't assume that integers
3262 in the range -65535 through -1 fit in an X unsigned short.
3263 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3264 result parameters unless successful. Rely on cons_to_unsigned
3265 to report problems with elements; the old code wasn't right anyway.
3266 (x_check_property_data): Check for int overflow; we cannot use
3267 a wider type due to X limits.
3268 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3270 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3272 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3273 (x_term_init): Check for size calculation overflow.
3274 (x_color_cells): Don't store size until memory allocation succeeds.
3275 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3276 Don't assume alloca size is less than MAX_ALLOCA.
3277 (x_term_init): Don't assume length fits in int (sprintf is limited
3280 Use ptrdiff_t for composition IDs.
3281 * character.c (lisp_string_width):
3282 * composite.c (composition_table_size, n_compositions)
3283 (get_composition_id, composition_gstring_from_id):
3284 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3285 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3286 * window.c (Frecenter):
3287 Use ptrdiff_t, not int, for composition IDs.
3288 * composite.c (get_composition_id): Check for integer overflow.
3289 * composite.h: Adjust prototypes to match the above changes.
3291 Use ptrdiff_t for hash table indexes.
3292 * category.c (hash_get_category_set):
3293 * ccl.c (ccl_driver):
3294 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3295 * coding.c (coding_system_charset_list, detect_coding_system):
3296 * coding.h (struct coding_system.id):
3297 * composite.c (get_composition_id, gstring_lookup_cache):
3298 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3299 * image.c (xpm_get_color_table_h):
3300 * lisp.h (hash_lookup, hash_put):
3301 * minibuf.c (Ftest_completion):
3302 Use ptrdiff_t for hash table indexes, not int (which is too
3303 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3304 32-bit --with-wide-int hosts).
3306 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3307 Add a FIXME comment about memory leaks.
3308 (syms_of_charset): Don't assume xmalloc returns.
3310 Don't assume that stated character widths fit in int.
3311 * character.c (Fchar_width, c_string_width, lisp_string_width):
3312 * character.h (CHAR_WIDTH):
3313 * indent.c (MULTIBYTE_BYTES_WIDTH):
3314 Use sanitize_char_width to avoid undefined and/or bad behavior
3315 with outlandish widths.
3316 * character.h (sanitize_tab_width): Rename from sanitize_width,
3317 now that we have two such functions. All uses changed.
3318 (sanitize_char_width): New inline function.
3320 Don't assume that tab-width fits in int.
3321 * character.h (sanitize_width): New inline function.
3322 (SANE_TAB_WIDTH): New macro.
3323 (ASCII_CHAR_WIDTH): Use it.
3324 * indent.c (sane_tab_width): Remove. All uses replaced by
3325 SANE_TAB_WIDTH (current_buffer).
3326 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3328 * fileio.c: Integer overflow issues with file modes.
3329 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3331 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3332 Remove unreachable code.
3333 (read_hex, load_charset_map_from_file): Check for integer overflow.
3335 * xterm.c: Don't go over XClientMessageEvent limit.
3336 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3337 (x_send_scroll_bar_event): Likewise. Check that the size does not
3338 exceed limits imposed by XClientMessageEvent, as well as the usual
3339 ptrdiff_t and size_t limits.
3341 * keyboard.c: Overflow, signedness and related fixes.
3342 (make_lispy_movement): Use same integer type in forward decl
3343 that is used in the definition.
3344 (read_key_sequence, keyremap_step):
3345 Change bufsize argument back to int, undoing my 2011-03-30 change.
3346 We prefer signed types, and int is wide enough here.
3347 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3348 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3349 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3350 length, not size_t. Use ptrdiff_t for index, not int.
3351 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3352 possibility of integer overflow.
3354 Overflow, signedness and related fixes for images.
3356 * dispextern.h (struct it.stack[0].u.image.image_id)
3357 (struct_it.image_id, struct image.id, struct image_cache.size)
3358 (struct image_cache.used, struct image_cache.ref_count):
3359 * gtkutil.c (update_frame_tool_bar):
3360 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3361 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3362 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3363 * nsmenu.m (update_frame_tool_bar):
3364 * xdisp.c (calc_pixel_width_or_height):
3365 * xfns.c (image_cache_refcount):
3366 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3367 on typical 64-bit hosts.
3369 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3370 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3371 Omit unnecessary casts to int.
3372 (parse_image_spec): Check that integers fall into 'int' range
3373 when the callers expect that.
3374 (image_ascent): Redo ascent calculation to avoid int overflow.
3375 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3376 (lookup_image): Remove unnecessary tests.
3377 (xbm_image_p): Locals are now of int, not EMACS_INT,
3378 since parse_image_check makes sure they fit into int.
3379 (png_load, gif_load, svg_load_image):
3380 Prefer int to unsigned where either will do.
3381 (tiff_handler): New function, combining the cores of the
3382 old tiff_error_handler and tiff_warning_handler.
3383 This function is rewritten to use vsnprintf and thereby avoid
3384 stack buffer overflows. It uses only the features of vsnprintf
3385 that are common to both POSIX and native Microsoft.
3386 (tiff_error_handler, tiff_warning_handler): Use it.
3387 (tiff_load, gif_load, imagemagick_load_image):
3388 Don't assume :index value fits in 'int'.
3389 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3390 (imagemagick_load_image): Check that crop parameters fit into
3391 the integer types that MagickCropImage accepts. Don't assume
3392 Vimagemagick_render_type has a nonnegative value. Don't assume
3393 size_t fits in 'long'.
3394 (gs_load): Use printmax_t to print the widest integers possible.
3395 Check for integer overflow when computing image height and width.
3397 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3399 * xdisp.c (redisplay_window): Don't force window start if point
3400 will be invisible in the resulting window. (Bug#9324)
3402 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3404 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3405 the display spec is of the form `(space ...)'.
3406 (handle_display_spec): Return the value returned by
3407 handle_single_display_spec, not just 1 or zero.
3408 (handle_single_display_spec): If the display spec is of the form
3409 `(space ...)', and specifies display in the text area, return 2
3411 (try_cursor_movement): Check for the need to scroll more
3412 accurately, and prefer exact match for point under bidi.
3413 Don't advance `row' beyond the last row of the window.
3415 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3416 into disp_prop; all users changed.
3418 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3419 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3420 for the text covered by the display property.
3422 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3424 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3425 Change return value to nil.
3426 (Frecord_buffer): Delete unused function.
3428 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3430 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3431 buffers, return left-to-right.
3432 (set_cursor_from_row): Consider candidate row a win if its glyph
3433 represents a newline and point is on that newline. Fixes cursor
3434 positioning on the newline at EOL of R2L text within L2R
3435 paragraph, and vice versa.
3436 (try_cursor_movement): Check continued rows, in addition to
3437 continuation rows. Fixes unwarranted scroll when point enters a
3438 continued line of R2L text within an L2R paragraph, or vice versa.
3439 (cursor_row_p): Consider the case of point being equal to
3440 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3441 from the end of a short line to the beginning of a continued line
3442 of R2L text within L2R paragraph.
3443 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3444 composed characters.
3446 * bidi.c (bidi_check_type): Use xassert.
3447 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3450 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3452 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3455 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3457 * nsfont.m (ns_otf_to_script): Fix typo.
3459 2011-08-22 Kenichi Handa <handa@m17n.org>
3461 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3462 extra slot even if the purpose is char-code-property-table.
3464 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3466 * xdisp.c (redisplay_window): When computing centering_position,
3467 account for the height of the header line. (Bug#8874)
3469 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3470 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3471 candidate is selected by the mouse, and that candidate has a
3472 composed character under the mouse.
3474 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3475 coordinates reported by pos-visible-in-window-p for a composed
3476 character in column zero.
3478 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3480 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3482 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3484 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3485 consider it a hit if to_charpos is anywhere in the range of the
3486 composed buffer positions.
3488 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3490 * image.c (gif_load): Don't assume that each subimage has the same
3491 dimensions as the base image. Handle disposal method that is
3492 "undefined" by the gif spec (Bug#9335).
3494 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3496 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3497 (Fcondition_case): Document `debug' symbol in error handler.
3499 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3501 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3502 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3503 from an Org mode buffer to a Speedbar frame.
3505 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3506 a composition, take its buffer position from IT->cmp_it.charpos.
3507 Fixes cursor positioning at the beginning of a line that begins
3508 with a composed character.
3510 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3512 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3513 character bidirectional type, use STRONG_L instead. Fixes crashes
3514 in a buffer produced by `describe-categories'.
3516 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3517 members before the level stack, so they would be saved and
3518 restored when copying iterator state. Fixes incorrect reordering
3519 around TABs covered by display properties.
3521 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3523 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3525 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3527 * eval.c (internal_condition_case, internal_condition_case_1)
3528 (internal_condition_case_2, internal_condition_case_n):
3529 Remove unnecessary aborts (Bug#9081).
3531 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3533 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3534 has no `load' handler, try opening the file locally. (Bug#9311)
3536 2011-08-16 Ken Brown <kbrown@cornell.edu>
3538 * gmalloc.c: Expand comment.
3540 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3542 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3543 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3545 2011-08-16 Ken Brown <kbrown@cornell.edu>
3547 Fix memory allocation problems in Cygwin build (Bug#9273).
3549 * unexcw.c ( __malloc_initialized): Declare external variable.
3550 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3552 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3554 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3556 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3558 [CYGWIN] (special_realloc): New function.
3559 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3560 requests to realloc storage in the static heap.
3562 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3564 * bidi.c (bidi_initialize): Remove unused local.
3566 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3569 * biditype.h: Remove file.
3570 * makefile.w32-in ($(BLD)/bidi.$(O)):
3571 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3573 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3575 * chartab.c: Improve commentary for the uniprop_table API.
3577 * bidi.c (bidi_paragraph_init): Support zero value of
3578 bidi_ignore_explicit_marks_for_paragraph_level.
3579 (bidi_initialize): Use uniprop_table instead of including
3580 biditype.h and bidimirror.h.
3582 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3583 coordinates of the iterator when restoring from ppos_it.
3586 2011-08-14 Kenichi Handa <handa@m17n.org>
3588 * process.c (create_process): Call setup_process_coding_systems
3589 after the pid of the process is set to -1 (Bug#8162).
3591 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3593 * xdisp.c (move_it_in_display_line_to): Don't invoke
3594 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3595 ppos_it. Fixes vertical cursor motion when line beginning is
3596 covered by an image. (Bug#9296)
3598 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3600 * nsterm.h (ns_run_ascript): Declare.
3601 (NSAPP_DATA2_RUNASSCRIPT): Define.
3603 * nsfns.m (as_script, as_result, as_status): New static variables.
3604 (ns_run_ascript): New function.
3605 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3606 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3607 the event loop. Get status from as_status (Bug#7276).
3609 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3610 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3611 the event loop (Bug#7276).
3613 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3615 * gnutls.c (QCgnutls_bootprop_priority)
3616 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3617 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3618 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3619 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3620 (QCgnutls_bootprop_verify_hostname_error)
3621 (QCgnutls_bootprop_callbacks_verify): Rename from
3622 Qgnutls_bootprop_..., all uses changed.
3624 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3627 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3629 * xfaces.c (Qframe_set_background_mode): Now static.
3630 * dispextern.h (Qframe_set_background_mode): Remove decl.
3632 * process.c (Fnetwork_interface_info): Declare local only if needed.
3634 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3636 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3637 (Fnetwork_interface_list): Allocate in increments of bytes instead
3638 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3639 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3641 (struct ifflag_def): notrailers is smart on OSX.
3642 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3643 Get hardware address with getifaddrs if available.
3645 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3647 * xdisp.c (iterate_out_of_display_property): xassert that
3648 IT->position is set to within IT->object's boundaries. Break from
3649 the loop as soon as EOB is reached; avoids infloops in redisplay
3650 when IT->position is set up wrongly due to some bug.
3651 Set IT->current to match the bidi iterator unconditionally.
3652 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3653 entry. Force push_it to save on the stack the current
3654 buffer/string position, to be restored by pop_it. Fix flags in
3655 the iterator structure wrt the object coming from a display
3656 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3657 properties. (Bug#9284)
3659 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3661 * fontset.c (fontset_get_font_group): Add proper type checks.
3664 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3666 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3667 and LC_VERSION_MIN_MACOSX.
3668 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3669 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3671 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3673 * xdisp.c (forward_to_next_line_start): Allow to use the
3674 no-display-properties-and-no-overlays under bidi display.
3675 Set disp_pos in the bidi iterator to avoid searches for display
3676 properties and overlays.
3678 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3680 * editfns.c (Fset_time_zone_rule): Document relationship with the
3683 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3684 the font entity extracted from the cache (Bug#8109).
3686 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3688 * composite.c (autocmp_chars): Don't reset point. That is done by
3689 restore_point_unwind (Bug#5984).
3691 2011-08-07 Juri Linkov <juri@jurta.org>
3693 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3694 to show the arg `TIME' instead of `TIMEVAL'.
3696 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3698 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3699 display property strides EOL and includes a newline, as in
3700 longlines-mode. (Bug#9254)
3701 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3702 word-wrap under bidirectional display. (Bug#9224)
3704 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3705 is non-zero, even if the data buffer is NULL. Fixes a crash in
3706 vertical-motion with longlines-mode. (Bug#9254)
3708 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3710 * bidi.c <bidi_cache_total_alloc>: Now static.
3711 (bidi_initialize): Initialize bidi_cache_total_alloc.
3713 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3716 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3717 amount allocated this far in `bidi_cache_total_alloc'.
3718 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3719 non-zero, only free the data buffer without restoring the cache
3720 contents. All callers changed.
3722 * dispextern.h (bidi_unshelve_cache): Update prototype.
3724 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3725 (move_it_in_display_line, move_it_to)
3726 (move_it_vertically_backward, move_it_by_lines): Replace the call
3727 to xfree to an equivalent call to bidi_unshelve_cache.
3728 (move_it_in_display_line_to): Fix logic of returning
3729 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3731 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3733 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3734 came from a string character with a `cursor' property. (Bug#9229)
3736 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3738 * Makefile.in (LIB_PTHREAD): New variable.
3739 (LIBES): Add LIB_PTHREAD (Bug#9216).
3741 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3742 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3744 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3746 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3748 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3750 * xterm.c (x_find_topmost_parent): New function.
3751 (x_set_frame_alpha): Find topmost parent window with
3752 x_find_topmost_parent and set the property there also (bug#9181).
3753 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3755 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3757 * callproc.c (Fcall_process): Avoid vfork clobbering
3758 the local vars buffer, coding_systems, current_dir.
3760 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3762 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3764 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3766 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3767 so that it is not optimized away.
3769 * xdisp.c (compute_display_string_pos): Remove unused local.
3771 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3773 Fix slow cursor motion and scrolling in large buffers with
3774 selective display, like Org Mode buffers. (Bug#9218)
3776 * dispextern.h (struct bidi_it): New member disp_prop_p.
3778 * xdisp.c: Remove one-slot cache of display string positions.
3779 (compute_display_string_pos): Accept an additional argument
3780 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3781 for a display string or property. If found, set DISP_PROP_P
3784 * bidi.c (bidi_fetch_char): Accept an additional argument
3785 DISP_PROP_P, and pass it to compute_display_string_pos.
3786 Only handle text covered by a display string if DISP_PROP_P is returned
3787 non-zero. All callers of bidi_fetch_char changed.
3789 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3791 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3793 2010-12-03 Don March <don@ohspite.net>
3795 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3796 last character M-[char] is translated to ESC [char] (bug#7541).
3798 2011-08-02 Kenichi Handa <handa@m17n.org>
3800 * lisp.h (uniprop_table): Extern it.
3802 * chartab.c (uniprop_table): Make it non-static.
3804 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3806 * xdisp.c (forward_to_next_line_start): Accept additional argument
3807 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3809 (reseat_at_next_visible_line_start): Use the bidi iterator state
3810 returned by forward_to_next_line_start to restore the state of
3811 it->bidi_it after backing up to previous newline. (Bug#9212)
3813 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3815 * regex.c (re_comp): Protoize.
3816 (re_exec): Fix return type.
3817 (regexec): Fix type of `ret'. (Bug#9203)
3819 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3821 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3822 This is needed if max-image-size is a floating-point number.
3824 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3826 * print.c (print_object): Print empty symbol as ##.
3828 * lread.c (read1): Read ## as empty symbol.
3830 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3832 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3833 setting frame foreground color (Bug#9175).
3834 (x_set_background_color): Likewise.
3836 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3837 contents (Bug#9176).
3838 (EmacsTooltip -init): Remove bezels and add shadows to
3841 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3842 or scroll bar (Bug#8470).
3844 * nsfont.m (nsfont_open): Remove assignment to voffset and
3845 unnecessary vars hshink, expand, hd, full_height, min_height.
3846 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3848 * nsterm.h (nsfont_info): Remove voffset field.
3850 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3852 Implement strike-through and overline on NextStep (Bug#8863).
3854 * nsfont.m (nsfont_open): Use underline position provided by font,
3855 instead of hard-coded value of 2.
3856 (nsfont_draw): Call ns_draw_text_decoration instead.
3858 * nsterm.h: Add declaration for ns_draw_text_decoration.
3860 * nsterm.m (ns_draw_text_decoration): New function for drawing
3861 underline, overline, and strike-through.
3862 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3863 ns_draw_text_decoration. Change treatment of cursor drawing to
3864 accommodate underlining, etc.
3866 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3868 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3871 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3873 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3874 Without this fix, if a signal arrives just after memory fills up,
3875 'malloc' might be invoked reentrantly.
3877 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3878 In other words, assume that every image size is allowed, on non-X
3879 hosts. This assumption is probably wrong, but it lets Emacs compile.
3881 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3883 * regex.c (re_iswctype): Convert return values to boolean.
3885 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3887 * xdisp.c (compute_display_string_pos): Don't use cached display
3888 string position if the buffer had its restriction changed.
3891 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3893 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3895 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3897 Integer signedness and overflow and related fixes. (Bug#9079)
3899 * bidi.c: Integer size and overflow fixes.
3900 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3901 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3902 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3903 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3904 (bidi_find_other_level_edge):
3905 Use ptrdiff_t instead of EMACS_INT where either will do.
3906 This works better on 32-bit hosts configured --with-wide-int.
3907 (bidi_cache_ensure_space): Check for size-calculation overflow.
3908 Use % rather than repeated addition, for better worst-case speed.
3909 Don't set bidi_cache_size until after xrealloc returns, because it
3911 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3912 (bidi_cache_ensure_space): Also check that the bidi cache size
3913 does not exceed that of the largest Lisp string or buffer. See Eli
3914 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3916 * alloc.c (__malloc_size_t): Remove.
3917 All uses replaced by size_t. See Andreas Schwab's note
3918 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3920 * image.c: Improve checking for integer overflow.
3921 (check_image_size): Assume that f is nonnull, since
3922 it is always nonnull in practice. This is one less thing to
3923 worry about when checking for integer overflow later.
3924 (x_check_image_size): New function, which checks for integer
3925 overflow issues inside X.
3926 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3927 This removes the need for a memory_full check.
3928 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3929 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3930 (xbm_read_bitmap_data): Change locals back to 'int', since
3931 their values must fit in 'int'.
3932 (xpm_load_image, png_load, tiff_load):
3933 Invoke x_create_x_image_and_pixmap earlier,
3934 to avoid much needless work if the image is too large.
3935 (tiff_load): Treat overly large images as if
3936 x_create_x_image_and_pixmap failed, not as malloc failures.
3937 (gs_load): Use x_check_image_size.
3939 * gtkutil.c: Omit integer casts.
3940 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3941 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3943 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3945 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3946 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3947 would wrongly return t on a 64-bit host.
3949 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3950 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3951 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3952 and therefore cause GCC to emit a bogus diagnostic in some cases.
3954 * image.c: Integer signedness and overflow and related fixes.
3955 This is not an exhaustive set of fixes, but it's time to
3956 record what I've got.
3957 (lookup_pixel_color, check_image_size): Remove redundant decls.
3958 (check_image_size): Don't assume that arbitrary EMACS_INT values
3959 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3960 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3961 (tiff_load, imagemagick_load_image):
3962 Check for overflow in size calculations.
3963 (x_create_x_image_and_pixmap): Remove unnecessary test for
3964 xmalloc returning NULL; that can't happen.
3965 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3966 (xpm_color_bucket): Use better integer hashing function.
3967 (xpm_cache_color): Don't possibly over-allocate memory.
3968 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3969 (gif_memory_source):
3970 Use ptrdiff_t, not int or size_t, to record sizes.
3971 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3972 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3973 either works, as we prefer signed integers.
3974 (tiff_read_from_memory, tiff_write_from_memory):
3975 Return tsize_t, not size_t, since that's what the TIFF API wants.
3976 (tiff_read_from_memory): Don't fail simply because the read would
3977 go past EOF; instead, return a short read.
3978 (tiff_load): Omit no-longer-needed casts.
3979 (Fimagemagick_types): Don't assume size fits into 'int'.
3981 Improve hashing quality when configured --with-wide-int.
3982 * fns.c (hash_string): New function, taken from sxhash_string.
3983 Do not discard information about ASCII character case; this
3984 discarding is no longer needed.
3985 (sxhash-string): Use it. Change sig to match it. Caller changed.
3986 * lisp.h: Declare it.
3987 * lread.c (hash_string): Remove, since we now use fns.c's version.
3988 The fns.c version returns a wider integer if --with-wide-int is
3989 specified, so this should help the quality of the hashing a bit.
3991 * emacs.c: Integer overflow minor fix.
3992 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3993 Define only if GNU_LINUX.
3994 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3996 * dispnew.c: Integer signedness and overflow fixes.
3997 Remove unnecessary forward decls, that were a maintenance hassle.
3998 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4000 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4001 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4002 (prepare_desired_row, line_draw_cost):
4003 Use int, not unsigned, where either works.
4004 (save_current_matrix, restore_current_matrix):
4005 Use ptrdiff_t, not size_t, where either works.
4006 (init_display): Check for overflow more accurately, and without
4007 relying on undefined behavior.
4009 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4010 Remove, replacing with the new symbols in lisp.h. All uses changed.
4011 * fileio.c (make_temp_name):
4012 * filelock.c (lock_file_1, lock_file):
4013 * xdisp.c (message_dolog):
4014 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4015 Use pMd etc. instead.
4016 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4017 replacing the pWIDE etc. symbols removed from editfns.c.
4019 * keyboard.h (num_input_events): Now uintmax_t.
4020 This is (very slightly) less likely to mess up due to wraparound.
4023 * buffer.c: Integer signedness fixes.
4024 (alloc_buffer_text, enlarge_buffer_text):
4025 Use ptrdiff_t rather than size_t when either will do, as we prefer
4028 * alloc.c: Integer signedness and overflow fixes.
4029 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4030 (__malloc_size_t): Default to size_t, not to int.
4031 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4032 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4033 Prefer ptrdiff_t to size_t when either would do, as we prefer
4035 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4036 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4037 Now const. Initialize with values that are in range even if char
4039 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4040 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4041 These functions do the right thing with sizes > 2**32.
4042 (check_depth): Now ptrdiff_t, not int.
4043 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4044 Adjust to new way of storing sizes. Check for size overflow bugs
4046 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4047 slightly wrong anyway, as it missed one instance of
4048 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4049 (refill_memory_reserve): Omit needless cast to size_t.
4050 (mark_object_loop_halt): Mark as externally visible.
4052 * xselect.c: Integer signedness and overflow fixes.
4053 (Fx_register_dnd_atom, x_handle_dnd_message):
4054 Use ptrdiff_t, not size_t, since we prefer signed.
4055 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4056 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4057 x_dnd_atoms_size and x_dnd_atoms_length.
4059 * doprnt.c: Prefer signed to unsigned when either works.
4061 * doprnt.c (doprnt):
4063 * xdisp.c (vmessage):
4064 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4065 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4066 prefer signed arithmetic to avoid comparison confusion.
4067 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4068 but is a bit tricky.
4070 Assume freestanding C89 headers, string.h, stdlib.h.
4071 * data.c, doprnt.c, floatfns.c, print.c:
4072 Include float.h unconditionally.
4073 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4074 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4075 * regex.c: Likewise for stddef.h, string.h.
4076 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4077 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4078 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4079 (STDC_HEADERS): Remove obsolete defines.
4080 * sysdep.c: Include limits.h unconditionally.
4082 Assume support for memcmp, memcpy, memmove, memset.
4083 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4084 * regex.c (memcmp, memcpy):
4085 Remove; we assume C89 now.
4087 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4088 (__malloc_safe_bcopy): Remove; no longer needed.
4090 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4091 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4092 well either way, and we prefer signed to unsigned.
4094 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4096 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4097 closes the connection while we're reading (bug#9182).
4099 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4101 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4102 are specified (Bug#9168).
4104 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4106 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4107 Found by GCC static checking and --with-wide-int on a 32-bit host.
4109 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4111 * xdisp.c (compute_display_string_pos): Fix logic of caching
4112 previous display string position. Initialize cached_prev_pos to
4113 -1. Fixes slow-down at the beginning of a buffer.
4115 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4117 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4118 for attrs[LFACE_FONTSET_INDEX].
4120 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4122 * xml.c (parse_region): Remove unused local
4123 that was recently introduced.
4125 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4127 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4128 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4130 * xdisp.c (move_it_in_display_line_to): Record the best matching
4131 position for TO_CHARPOS while scanning the line, and restore it on
4132 exit if none of the characters scanned was an exact match.
4133 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4134 when exact match is impossible due to invisible text, and the
4135 lines are truncated.
4137 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4139 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4142 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4144 Fix a significant slow-down of cursor motion with C-n, C-p,
4145 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4146 auto-repeat under bidi redisplay in fontified buffers.
4147 * xdisp.c (compute_stop_pos_backwards): New function.
4148 (next_element_from_buffer): Call compute_stop_pos_backwards to
4149 find a suitable prev_stop when we find ourselves before
4151 (reseat): Don't look for prev_stop, as that could mean a very long
4153 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4154 <cached_disp_overlay_modiff>: Cache for last found display string
4156 (compute_display_string_pos): Return the cached position if asked
4157 about the same buffer in the same area of character positions, and
4158 the buffer wasn't changed since the time the display string
4159 position was cached.
4161 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4163 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4164 is an integer, which is important for empty lines. (Bug#9149)
4166 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4168 * frame.c (Fmodify_frame_parameters): In tty case, update the
4169 default face if necessary (Bug#4238).
4171 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4173 * editfns.c (Fstring_to_char): No need to explain what a character
4174 is in the docstring (Bug#6576).
4176 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4178 * xml.c (parse_region): Make sure we always return a tree.
4180 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4182 * xml.c (parse_region): If a document contains only comments,
4185 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187 * xml.c (make_dom): Return comments, too.
4189 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4192 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4193 and the surrounding thread.
4194 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4195 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4196 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4198 * s/openbsd.h (BROKEN_SIGIO): Define.
4199 * unexelf.c (unexec) [__OpenBSD__]:
4200 Don't update the .mdebug section of the Alpha COFF symbol table.
4202 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4204 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4207 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4209 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4210 This fixes some race conditions on the permissions of any newly
4213 * alloc.c (valid_pointer_p): Use pipe, not open.
4214 This fixes some permissions issues when debugging.
4216 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4217 If fchown fails to set both uid and gid, try to set just gid,
4218 as that is sometimes allowed. Adjust the file's mode to eliminate
4219 setuid or setgid bits that are inappropriate if fchown fails.
4221 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4223 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4224 to compare Lisp_Objects.
4225 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4226 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4227 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4229 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4231 * lread.c (read_integer): Unread even EOF character.
4232 (read1): Likewise. Properly record start position of symbol.
4234 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4235 symbol character follows.
4237 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4239 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4240 This works around a problem with the previous change to Fcopy_file.
4241 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4242 and without this change, GCC might complain about discarding
4243 fchown's return value.
4245 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4247 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4249 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4251 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4253 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4255 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4256 it's used from the C level.
4258 * process.c: Use the same condition for POLL_FOR_INPUT in both
4259 keyboard.c and process.c (bug#1858).
4261 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4263 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4264 (Fgnutls_boot): Use it.
4266 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4268 * doc.c (Fsubstitute_command_keys): Revert last change.
4270 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4272 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4273 quotes the next character, and doesn't affect other longer
4274 sequences (bug#8935).
4276 * lread.c (syms_of_lread): Clarify that is isn't only
4277 `eval-buffer' and `eval-defun' that's affected by
4278 `lexical-binding' (bug#8460).
4280 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4282 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4283 bidi redisplay when a line includes both an image and is truncated.
4285 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4287 Fix minor problems found by static checking.
4288 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4289 (elsz): Now a signed constant, not a size_t var. We prefer signed
4290 types to unsigned, to avoid integer comparison confusion. Without
4291 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4292 "cannot optimize loop, the loop counter may overflow", a symptom
4294 * indent.c (Fvertical_motion): Mark locals as initialized.
4295 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4297 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4299 * search.c (Fre_search_backward): Mention `case-fold-search' in
4300 all the re_search_* functions (bug#8138).
4302 * keyboard.c (Fopen_dribble_file): Document when the file is
4305 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4307 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4310 Support bidi reordering of display and overlay strings.
4311 * xdisp.c (compute_display_string_pos)
4312 (compute_display_string_end): Accept additional argument STRING.
4313 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4314 (reseat_to_string): Initialize bidi_it->string.s and
4315 bidi_it->string.schars.
4316 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4317 NULL (avoids a crash in bidi_paragraph_init).
4318 Initialize itb.string.lstring.
4319 (init_iterator): Call bidi_init_it only of a valid
4320 buffer position was specified. Initialize paragraph_embedding to
4322 (reseat_to_string): Initialize the bidi iterator.
4323 (display_string): If we need to ignore text properties of
4324 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4325 original value of -1 will not work with bidi.)
4326 (compute_display_string_pos): First arg is now struct
4327 `text_pos *'; all callers changed. Support display properties on
4329 (compute_display_string_end): Support display properties on Lisp
4331 (init_iterator, reseat_1, reseat_to_string): Initialize the
4332 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4333 when iterating on a string not from display properties).
4334 (compute_display_string_pos, compute_display_string_end):
4335 Fix calculation of the object to scan. Fixes an error when using
4337 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4338 base_level_stop; instead, set base_level_stop to BEGV.
4339 Fixes crashes in vertical-motion.
4340 (next_element_from_buffer): Improve commentary for when
4341 the iterator is before prev_stop.
4342 (init_iterator): Initialize bidi_p from the default value of
4343 bidi-display-reordering, not from buffer-local value. Use the
4344 buffer-local value only if initializing for buffer iteration.
4345 (handle_invisible_prop): Support invisible properties on strings
4346 that are being bidi-reordered.
4347 (set_iterator_to_next): Support bidi reordering of C strings and
4349 (next_element_from_string): Support bidi reordering of Lisp
4351 (handle_stop_backwards): Support Lisp strings as well.
4352 (display_string): Support display of R2L glyph rows.
4353 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4354 (init_iterator): Don't initialize it->bidi_p for strings
4356 (reseat_to_string): Initialize it->bidi_p for strings here.
4357 (next_element_from_string, next_element_from_c_string)
4358 (next_element_from_buffer): Add xassert's for correspondence
4359 between IT's object being iterated and it->bidi_it.string
4361 (face_before_or_after_it_pos): Support bidi iteration.
4362 (next_element_from_c_string): Handle the case of the first string
4363 character that is not the first one in the visual order.
4364 (get_visually_first_element): New function, refactored from common
4365 parts of next_element_from_buffer, next_element_from_string, and
4366 next_element_from_c_string.
4367 (tool_bar_lines_needed, redisplay_tool_bar)
4368 (display_menu_bar): Force left-to-right direction. Add a FIXME
4369 comment for making that be controlled by a user option.
4370 (push_it, pop_it): Save and restore the state of the
4371 bidi iterator. Save and restore the bidi_p flag.
4372 (pop_it): Iterate out of display property for string iteration as
4374 (iterate_out_of_display_property): Support iteration over strings.
4375 (handle_single_display_spec): Set up it->bidi_it for iteration
4376 over a display string, and call bidi_init_it.
4377 (handle_single_display_spec, next_overlay_string)
4378 (get_overlay_strings_1, push_display_prop): Set up the bidi
4379 iterator for displaying display or overlay strings.
4380 (forward_to_next_line_start): Don't use the shortcut if
4382 (back_to_previous_visible_line_start): If handle_display_prop
4383 pushed the iterator stack, restore the internal state of the bidi
4384 iterator by calling bidi_pop_it same number of times.
4385 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4386 and we are bidi-iterating, don't decrement the iterator position;
4387 instead, set the first_elt flag in the bidi iterator, to produce
4389 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4390 (push_display_prop): xassert that we are iterating a buffer.
4391 (push_it, pop_it): Save and restore paragraph_embedding member.
4392 (handle_single_display_spec, next_overlay_string)
4393 (get_overlay_strings_1, reseat_1, reseat_to_string)
4394 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4395 correctly. Don't assume unibyte strings are not bidi-reordered.
4396 (compute_display_string_pos)
4397 (compute_display_string_end): Fix handling the case of C string.
4398 (push_it, pop_it): Save and restore from_disp_prop_p.
4399 (handle_single_display_spec, push_display_prop): Set the
4400 from_disp_prop_p flag.
4401 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4402 (pop_it): Call iterate_out_of_display_property only if we are
4403 popping after iteration over a string that came from a display
4404 property. Fix a typo in popping stretch info. Add an assertion
4405 for verifying that the iterator position is in sync with the bidi
4407 (handle_single_display_spec, get_overlay_strings_1)
4408 (push_display_prop): Fix initialization of paragraph direction for
4409 string when that of the parent object is not yet determined.
4410 (reseat_1): Call bidi_init_it to resync the bidi
4411 iterator with IT's position. (Bug#7616)
4412 (find_row_edges): If ROW->start.pos gives position
4413 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4414 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4415 Reset the from_disp_prop_p flag.
4416 (SAVE_IT, RESTORE_IT): New macros.
4417 (pos_visible_p, face_before_or_after_it_pos)
4418 (back_to_previous_visible_line_start)
4419 (move_it_in_display_line_to, move_it_in_display_line)
4420 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4421 (try_scrolling, redisplay_window, display_line): Use them when
4422 saving a temporary copy of the iterator and restoring it back.
4423 (back_to_previous_visible_line_start, reseat_1)
4424 (init_iterator): Empty the bidi cache "stack".
4425 (move_it_in_display_line_to): If iterator ended up at
4426 EOL, but we never saw any buffer positions smaller than
4427 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4428 motion in bidi-reordered lines.
4429 (move_it_in_display_line_to): Record prev_method and prev_pos
4430 immediately before the call to set_iterator_to_next. Fixes cursor
4431 motion in bidi-reordered lines with stretch glyphs and strings
4432 displayed in margins. (Bug#8133) (Bug#8867)
4433 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4435 (pos_visible_p): Support positions in bidi-reordered lines.
4436 Save and restore bidi cache.
4438 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4439 (bidi_paragraph_info): Delete unused struct.
4440 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4441 (bidi_cache_start): New variable.
4442 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4444 (bidi_cache_fetch_state, bidi_cache_search)
4445 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4446 (bidi_cache_find, bidi_peek_at_next_level)
4447 (bidi_level_of_next_char, bidi_find_other_level_edge)
4448 (bidi_move_to_visually_next): Compare cache index with
4449 bidi_cache_start rather than with zero.
4450 (bidi_fetch_char): Accept new argument STRING; all callers
4451 changed. Support iteration over a string. Support strings with
4452 display properties. Support unibyte strings. Fix the type of
4453 `len' according to what STRING_CHAR_AND_LENGTH expects.
4454 (bidi_paragraph_init, bidi_resolve_explicit_1)
4455 (bidi_resolve_explicit, bidi_resolve_weak)
4456 (bidi_level_of_next_char, bidi_move_to_visually_next):
4457 Support iteration over a string.
4458 (bidi_set_sor_type, bidi_resolve_explicit_1)
4459 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4460 can now be zero (for strings); special values 0 and -1 were
4461 changed to -1 and -2, respectively.
4462 (bidi_char_at_pos): New function.
4463 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4464 Call it instead of FETCH_MULTIBYTE_CHAR.
4465 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4466 initialized to valid values.
4467 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4469 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4470 the test for valid cached positions. Fix the logic for looking up
4471 the sentinel state in the cache. GCPRO the Lisp string we are
4473 (bidi_push_it, bidi_pop_it): New functions.
4474 (bidi_initialize): Initialize the bidi cache start stack pointer.
4475 (bidi_cache_ensure_space): New function, refactored from part of
4476 bidi_cache_iterator_state. Don't assume the required size is just
4477 one BIDI_CACHE_CHUNK away.
4478 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4479 (bidi_count_bytes, bidi_char_at_pos): New functions.
4480 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4481 always valid if bidi_cache_idx is valid.
4482 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4483 is valid if it's going to be used.
4484 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4485 (bidi_cache_fetch_state, bidi_cache_search)
4486 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4487 (bidi_cache_iterator_state, bidi_cache_find)
4488 (bidi_find_other_level_edge, bidi_cache_start_stack):
4489 All variables related to cache indices are now EMACS_INT.
4491 * dispextern.h (struct bidi_string_data): New structure.
4492 (struct bidi_it): New member `string'. Make flag members be 1-bit
4493 fields, and put them last in the struct.
4494 (compute_display_string_pos, compute_display_string_end):
4496 (bidi_push_it, bidi_pop_it): Add prototypes.
4497 (struct iterator_stack_entry): New members bidi_p,
4498 paragraph_embedding, and from_disp_prop_p.
4499 (struct it): Member bidi_p is now a bit field 1 bit wide.
4500 (bidi_shelve_cache, bidi_unshelve_cache):
4503 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4504 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4505 and vector-like objects.
4507 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4508 cache around display iteration.
4510 * window.c (Fwindow_end, window_scroll_pixel_based)
4511 (displayed_window_lines, Frecenter): Save and restore the bidi
4512 cache around display iteration.
4514 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4516 * editfns.c (Fdelete_region): Clarify the use of the named
4517 parameters (bug#6788).
4519 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4521 * indent.c (Fvertical_motion): Set and restore w->pointm when
4522 saving and restoring the window's buffer (Bug#9006).
4524 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4526 * editfns.c (Fstring_to_char): Clarify just what is returned
4527 (bug#6576). Text by Eli Zaretskii.
4529 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4531 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4533 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4535 * buffer.c (mmap_find): Fix a typo.
4537 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4539 Fix execution of x selection hooks.
4540 * xselect.c (Qx_lost_selection_functions)
4541 (Qx_sent_selection_functions): New vars.
4542 (syms_of_xselect): DEFSYM them.
4543 (x_handle_selection_request): Pass Qx_sent_selection_functions
4544 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4545 (x_handle_selection_clear,x_clear_frame_selections):
4546 Pass Qx_lost_selection_functions rather than
4547 Vx_lost_selection_functions to Frun_hook_with_args.
4549 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4551 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4552 The old code sometimes used this field without initializing it.
4554 * alloc.c (gc_sweep): Don't read past end of array.
4555 In theory, the old code could also have corrupted Emacs internals,
4556 though it'd be very unlikely.
4558 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4560 * character.c (Fcharacterp): Don't advertise optional ignored
4561 argument. (Bug#4026)
4563 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4565 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4568 * window.c (Fset_window_start): Doc fix (bug#4199).
4569 (Fset_window_hscroll): Ditto.
4571 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4573 Fix minor new problems caught by GCC 4.6.1.
4574 * term.c (init_tty): Remove unused local.
4575 * xsettings.c (store_monospaced_changed): Define this function only
4576 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4579 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4581 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4583 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4585 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4586 are the mini-buffer and the echo area (bug#3320).
4588 * term.c (init_tty): Remove support for supdup, c10 and perq
4589 terminals, which are no longer supported (bug#1482).
4591 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4593 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4595 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4597 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4598 for non-popups (Bug#3642).
4600 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4602 * alloc.c (reset_malloc_hooks): Protoize.
4603 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4604 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4605 * cm.c (losecursor): Likewise.
4606 * data.c (fmod): Likewise.
4607 * dispnew.c (swap_glyphs_in_rows): Likewise.
4608 * emacs.c (memory_warning_signal): Likewise.
4609 * floatfns.c (float_error): Likewise.
4610 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4611 (otf_open, font_otf_capability, generate_otf_features)
4612 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4614 * image.c (pbm_read_file): Likewise.
4615 * indent.c (string_display_width): Likewise.
4616 * intervals.c (check_for_interval, search_for_interval)
4617 (inc_interval_count, count_intervals, root_interval)
4618 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4619 * lread.c (defalias): Likewise.
4620 * ralloc.c (r_alloc_check): Likewise.
4621 * regex.c (set_image_of_range_1, set_image_of_range)
4622 (regex_grow_registers): Likewise.
4623 * sysdep.c (strerror): Likewise.
4624 * termcap.c (valid_filename_p, tprint, main): Likewise.
4625 * tparam.c (main): Likewise.
4626 * unexhp9k800.c (run_time_remap, save_data_space)
4627 (update_file_ptrs, read_header, write_header, calculate_checksum)
4628 (copy_file, copy_rest, display_header): Likewise.
4629 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4631 * xdisp.c (check_it): Likewise.
4632 * xfaces.c (register_color, unregister_color, unregister_colors):
4634 * xfns.c (print_fontset_result): Likewise.
4635 * xrdb.c (member, fatal, main): Likewise.
4637 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4639 Fix minor problems found by static checking (Bug#9031).
4640 * chartab.c (char_table_set_range, map_sub_char_table):
4641 Remove unused locals.
4642 (uniprop_table): Now static.
4643 * composite.c (_work_char): Remove unused static var.
4645 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4647 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4649 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4651 * gtkutil.c (qttip_cb): Remove code without function.
4653 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4655 * w32.c (pthread_sigmask): New stub.
4657 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4659 Use pthread_sigmask, not sigprocmask (Bug#9010).
4660 sigprocmask is portable only for single-threaded applications, and
4661 Emacs can be multi-threaded when it uses GTK.
4662 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4664 * callproc.c (Fcall_process):
4665 * process.c (create_process):
4666 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4667 Use pthread_sigmask, not sigprocmask.
4669 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4671 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4672 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4675 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4677 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4678 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4679 (xg_hide_tooltip): Fix comment.
4681 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4682 in registerServicesMenuSendTypes.
4683 (validRequestorForSendType): Don't check ns_return_types.
4685 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4688 2011-07-08 Jason Rumney <jasonr@gnu.org>
4690 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4691 SH_SHOW for hidden windows (Bug#5482).
4693 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4694 frame struct members of non-existent frames (Bug#6284).
4696 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4698 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4699 variable firstTime not needed on OSX >= 10.6.
4700 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4701 >= 10.5. Use setKnobProportion, setDoubleValue.
4703 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4704 (MAC_OS_X_VERSION_10_5): Define if not defined.
4705 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4706 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4707 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4709 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4710 cString and lossyCString on OSX >= 10.4
4712 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4713 sizeToFit on OSX >= 10.2.
4715 * nsimage.m (allocInitFromFile): Don't use deprecated method
4716 bestRepresentationForDevice on OSX >= 10.6.
4718 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4721 * emacs.c: Declare unexec_init_emacs_zone.
4723 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4725 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4727 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4728 on svcsMenu (Bug#8842).
4730 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4732 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4734 * nsterm.m (QUTF8_STRING): Declare.
4735 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4736 (validRequestorForSendType): Return type is (id).
4737 Change indexOfObjectIdenticalTo to indexOfObject.
4738 Check if we have local selection before returning self (Bug#8842).
4739 (writeSelectionToPasteboard): Put local selection into paste board
4740 if we have a local selection (Bug#8842).
4741 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4743 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4744 (ns_get_local_selection): Declare.
4746 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4748 * keymap.c (describe_map_tree): Don't insert a double newline at
4749 the end of the buffer (bug#1169) and return whether we inserted
4752 * callint.c (Fcall_interactively): Change "reading args" to
4753 "providing args" to try to clarify what it does (bug#1010).
4755 2011-07-07 Kenichi Handa <handa@m17n.org>
4757 * composite.c (composition_compute_stop_pos): Ignore a static
4758 composition starting before CHARPOS (Bug#8915).
4760 * xdisp.c (handle_composition_prop): Likewise.
4762 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4764 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4767 2011-07-07 Kenichi Handa <handa@m17n.org>
4769 * character.h (unicode_category_t): New enum type.
4771 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4772 (Qchar_code_property_table): New variable.
4773 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4774 (UNIPROP_COMPRESSED_FORM_P): New macros.
4775 (char_table_ascii): Uncompress the compressed values.
4776 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4777 Uncompress the compressed values.
4778 (sub_char_table_ref_and_range): Likewise.
4779 (char_table_ref_and_range): Uncompress the compressed values.
4780 (sub_char_table_set): New arg is_uniprop. Callers changed.
4781 Uncompress the compressed values.
4782 (sub_char_table_set_range): Args changed. Callers changed.
4783 (char_table_set_range): Adjuted for the above change.
4784 (map_sub_char_table): Delete args default_val and parent. Add arg
4785 top. Give decoded values to a Lisp function.
4786 (map_char_table): Adjust for the above change. Give decoded
4787 values to a Lisp function. Gcpro more variables.
4788 (uniprop_table_uncompress)
4789 (uniprop_decode_value_run_length): New functions.
4790 (uniprop_decoder, uniprop_decoder_count): New variables.
4791 (uniprop_get_decoder, uniprop_encode_value_character)
4792 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4794 (uniprop_encoder, uniprop_encoder_count): New variables.
4795 (uniprop_get_encoder, uniprop_table)
4796 (Funicode_property_table_internal, Fget_unicode_property_internal)
4797 (Fput_unicode_property_internal): New functions.
4798 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4799 Sunicode_property_table_internal, Sget_unicode_property_internal,
4800 and Sput_unicode_property_internal. Defvar_lisp
4801 char-code-property-alist.
4803 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4804 Vunicode_category_table.
4806 * font.c (font_range): Adjust for the change of
4807 Vunicode_category_table.
4809 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4811 * m/iris4d.h: Remove file, move contents ...
4812 * s/irix6-5.h: ... here.
4814 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4816 Remove unportable assumption about struct layout (Bug#8884).
4817 * alloc.c (mark_buffer):
4818 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4819 (clone_per_buffer_values): Don't assume that
4820 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4821 This isn't true in general, and it's particularly not true
4822 if Emacs is configured with --with-wide-int.
4823 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4824 New macros, used in the buffer.c change.
4826 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4828 * xsettings.c: Use both GConf and GSettings if both are available.
4829 (store_config_changed_event): Add comment.
4830 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4831 (store_tool_bar_style_changed): New functions.
4832 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4833 (struct xsettings): Move font inside HAVE_XFT.
4834 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4835 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4836 Move inside HAVE_XFT.
4837 (something_changed_gsettingsCB): Rename from something_changedCB.
4838 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4840 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4841 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4842 (something_changed_gconfCB): Rename from something_changedCB.
4843 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4844 (parse_settings): Move check for font inside HAVE_XFT.
4845 (read_settings, apply_xft_settings): Add comment.
4846 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4847 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4848 call store_font_name_changed.
4849 (xft_settings_event): Add comment.
4850 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4851 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4852 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4853 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4854 (xsettings_initialize): Call init_gsettings last.
4855 (xsettings_get_system_font, xsettings_get_system_normal_font):
4858 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4860 Random fixes. E.g., (random) never returned negative values.
4861 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4862 subseconds part to the entropy, as that's a bit more random.
4863 Prefer signed to unsigned, since the signedness doesn't matter and
4864 in general we prefer signed. When given a limit, use a
4865 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4866 latter isn't right if USE_2_TAGS_FOR_INTS.
4867 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4868 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4870 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4872 * textprop.c (text_property_stickiness):
4873 Obey Vtext_property_default_nonsticky.
4874 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4875 * w32fns.c (syms_of_w32fns):
4876 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4878 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4880 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4881 This is more efficient than Ffile_directory_p and avoids a minor race.
4883 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4885 * buffer.c (Foverlay_put): Say what the return value is
4888 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4889 is a directory before asking whether to use the file name
4891 (barf_or_query_if_file_exists): Make the "File is a directory"
4892 error be more correct.
4894 * fns.c (Frequire): Remove the mention of the .gz files, since
4895 that's installation-specific, but keep the mention of
4896 `get-load-suffixes'.
4898 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4900 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4901 Report string overflow if the output is too long.
4903 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4905 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4906 (syms_of_gnutls): Remove duplicate DEFSYM for
4907 Qgnutls_bootprop_verify_hostname_error, an error for
4908 Qgnutls_bootprop_verify_error (which is no longer used).
4910 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4911 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4912 Also (re)move comments that are misplaced or no longer relevant.
4914 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4916 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4918 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4920 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4921 and background color parameters if they have been changed.
4923 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4925 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4927 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4929 * xsettings.c (SYSTEM_FONT): Define only when used.
4930 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4932 * keymap.c (access_keymap_1): Now static.
4934 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4936 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4937 leave any prefix arg for the up event (Bug#1586).
4939 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4941 * lread.c (syms_of_lread): Mention single symbols defined by
4942 `defvar' or `defconst' (bug#7154).
4944 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4945 (Frequire): Mention get-load-suffixes.
4947 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4949 * window.h (window): Remove clone_number slot.
4950 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4952 (make_parent_window, make_window, saved_window)
4953 (Fset_window_configuration, save_window_save): Don't deal with
4955 * buffer.c (Qclone_number): Remove declaration.
4956 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4958 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4960 Add multiple inheritance to keymaps.
4961 * keymap.c (Fmake_composed_keymap): New function.
4962 (Fset_keymap_parent): Simplify.
4963 (fix_submap_inheritance): Remove.
4964 (access_keymap_1): New function extracted from access_keymap to handle
4965 embedded parents and handle lists of maps.
4966 (access_keymap): Use it.
4967 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4968 (Fcopy_keymap): Handle embedded parents.
4969 (Fcommand_remapping, define_as_prefix): Simplify.
4970 (Fkey_binding): Simplify.
4971 (syms_of_keymap): Move minibuffer-local-completion-map,
4972 minibuffer-local-filename-completion-map,
4973 minibuffer-local-must-match-map, and
4974 minibuffer-local-filename-must-match-map to Elisp.
4975 (syms_of_keymap): Defsubr make-composed-keymap.
4976 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4977 (parse_menu_item): Trivial simplification.
4979 2011-07-01 Glenn Morris <rgm@gnu.org>
4981 * Makefile.in (SETTINGS_LIBS): Fix typo.
4983 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4985 * coding.c (Fencode_coding_string): Record the last coding system
4986 used, as the function doc string says (bug#8738).
4988 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4990 * xsettings.c (store_monospaced_changed): Take new font as arg and
4991 check for change against current_mono_font.
4992 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4993 (emacs_settings_constructor, emacs_settings_get_property)
4994 (emacs_settings_set_property, emacs_settings_class_init)
4995 (emacs_settings_init, gsettings_obj): Remove.
4996 (something_changedCB): New function for HAVE_GSETTINGS.
4997 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4998 with value as argument.
4999 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5000 g_settings_new (Bug#8967). Do not create gsettings_obj.
5001 Remove calls to g_settings_bind. Connect something_changedCB to
5004 * xgselect.c: Add defined (HAVE_GSETTINGS).
5005 (xgselect_initialize): Ditto.
5007 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5008 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5011 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5013 * eval.c (struct backtrace): Simplify and port the data structure.
5014 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5015 signed bit field, as this assumption is not portable and it makes
5016 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5017 "char debug_on_exit : 1" as this is not portable either; instead,
5018 use the portable "unsigned int debug_on_exit : 1". Remove unused
5019 member evalargs. Remove obsolete comments about cc bombing out.
5021 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5023 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5024 Let HAVE_GSETTINGS override HAVE_GCONF.
5025 (store_monospaced_changed): New function.
5026 (EMACS_SETTINGS): A new type derived from GObject to handle
5027 GSettings notifications.
5028 (emacs_settings_constructor, emacs_settings_get_property)
5029 (emacs_settings_set_property, emacs_settings_class_init):
5031 (gsettings_client, gsettings_obj): New variables.
5032 (GSETTINGS_SCHEMA): New define.
5033 (something_changedCB): Call store_monospaced_changed.
5034 (init_gsettings): New function.
5035 (xsettings_initialize): Call init_gsettings.
5036 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5039 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5042 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5044 * window.c (resize_root_window, grow_mini_window)
5045 (shrink_mini_window): Rename Qresize_root_window to
5046 Qwindow_resize_root_window and Qresize_root_window_vertically to
5047 Qwindow_resize_root_window_vertically.
5049 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5051 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5053 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5055 * makefile.w32-in: Redesign dependencies so they reflect more
5056 clearly which files are directly included by each source file,
5057 and not through other includes.
5059 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5061 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5062 (sort_overlays, overlay_strings): When an overlay's clone number
5063 matches the window's clone number process the overlay even if
5064 the overlay's window property doesn't match the current window.
5066 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5067 (Fwindow_hchild): Rename to Fwindow_left_child.
5068 (Fwindow_next): Rename to Fwindow_next_sibling.
5069 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5070 (resize_window_check): Rename to window_resize_check.
5071 (resize_window_apply): Rename to window_resize_apply.
5072 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5073 (Fdelete_other_windows_internal, resize_frame_windows)
5074 (Fsplit_window_internal, Fdelete_window_internal)
5075 (grow_mini_window, shrink_mini_window)
5076 (Fresize_mini_window_internal): Fix callers accordingly.
5078 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5080 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5081 (emacs_fixed_set_min_size): Remove.
5082 (emacs_fixed_new): Take frame as argument.
5084 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5085 (_EmacsFixedPrivate): Remove minwidth/height.
5086 Add struct frame *f.
5087 (emacs_fixed_init): Initialize priv->f.
5088 (get_parent_class, emacs_fixed_set_min_size): Remove.
5089 (emacs_fixed_new): Set priv->f to argument.
5090 (emacs_fixed_get_preferred_width)
5091 (emacs_fixed_get_preferred_height): Use min_width/height from
5092 frames size_hint to set minimum and natural (Bug#8919).
5093 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5094 and use min_width/height from frames size_hint to set
5095 min_width/height (Bug#8919).
5097 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5098 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5101 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5103 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5104 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5107 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5109 * process.c (wait_reading_process_output): Bypass select if
5110 waiting for a cell while ignoring keyboard input, and input is
5111 pending. Suggested by Jan Djärv (Bug#8869).
5113 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5115 Use gnulib's dup2 module instead of rolling our own.
5116 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5118 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5120 * dispnew.c (scrolling_window): Before scrolling, turn off a
5121 mouse-highlight in the window being scrolled.
5123 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5125 Move DEFSYM to lisp.h and use everywhere.
5127 * character.h (DEFSYM): Move declaration...
5128 * lisp.h (DEFSYM): ...here.
5134 * w32select.c: Don't include character.h.
5136 * alloc.c (syms_of_alloc):
5137 * buffer.c (syms_of_buffer):
5138 * bytecode.c (syms_of_bytecode):
5139 * callint.c (syms_of_callint):
5140 * casefiddle.c (syms_of_casefiddle):
5141 * casetab.c (init_casetab_once):
5142 * category.c (init_category_once, syms_of_category):
5143 * ccl.c (syms_of_ccl):
5144 * cmds.c (syms_of_cmds):
5145 * composite.c (syms_of_composite):
5146 * dbusbind.c (syms_of_dbusbind):
5147 * dired.c (syms_of_dired):
5148 * dispnew.c (syms_of_display):
5149 * doc.c (syms_of_doc):
5150 * editfns.c (syms_of_editfns):
5151 * emacs.c (syms_of_emacs):
5152 * eval.c (syms_of_eval):
5153 * fileio.c (syms_of_fileio):
5154 * fns.c (syms_of_fns):
5155 * frame.c (syms_of_frame):
5156 * fringe.c (syms_of_fringe):
5157 * insdel.c (syms_of_insdel):
5158 * keymap.c (syms_of_keymap):
5159 * lread.c (init_obarray, syms_of_lread):
5160 * macros.c (syms_of_macros):
5161 * msdos.c (syms_of_msdos):
5162 * print.c (syms_of_print):
5163 * process.c (syms_of_process):
5164 * search.c (syms_of_search):
5165 * sound.c (syms_of_sound):
5166 * syntax.c (init_syntax_once, syms_of_syntax):
5167 * terminal.c (syms_of_terminal):
5168 * textprop.c (syms_of_textprop):
5169 * undo.c (syms_of_undo):
5170 * w32.c (globals_of_w32):
5171 * window.c (syms_of_window):
5172 * xdisp.c (syms_of_xdisp):
5173 * xfaces.c (syms_of_xfaces):
5174 * xfns.c (syms_of_xfns):
5175 * xmenu.c (syms_of_xmenu):
5176 * xsettings.c (syms_of_xsettings):
5177 * xterm.c (syms_of_xterm): Use DEFSYM.
5179 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5181 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5183 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5185 Integer and buffer overflow fixes (Bug#8873).
5187 * print.c (printchar, strout): Check for string overflow.
5188 (PRINTPREPARE, printchar, strout):
5189 Don't set size unless allocation succeeds.
5191 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5192 for sizes. Check for string overflow more accurately.
5193 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5195 * macros.c: Integer and buffer overflow fixes.
5196 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5197 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5198 Use ptrdiff_t, not int, for sizes.
5199 Don't increment bufsize until after realloc succeeds.
5200 Check for size-calculation overflow.
5201 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5203 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5205 * lread.c: Integer overflow fixes.
5206 (read_integer): Radix is now EMACS_INT, not int,
5207 to improve quality of diagnostics for out-of-range radices.
5208 Calculate buffer size correctly for out-of-range radices.
5209 (read1): Check for integer overflow in radices, and in
5210 read-circle numbers.
5211 (read_escape): Avoid int overflow.
5212 (Fload, openp, read_buffer_size, read1)
5213 (substitute_object_recurse, read_vector, read_list, map_obarray):
5214 Use ptrdiff_t, not int, for sizes.
5215 (read1): Use EMACS_INT, not int, for sizes.
5216 Check for size overflow.
5218 * image.c (cache_image): Check for size arithmetic overflow.
5220 * lread.c: Integer overflow issues.
5221 (saved_doc_string_size, saved_doc_string_length)
5222 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5223 Now ptrdiff_t, not int.
5224 (read1): Don't assume doc string length fits in int. Check for
5225 out-of-range doc string lengths.
5226 (read_list): Don't assume file position fits in int.
5227 (read_escape): Check for hex character overflow.
5229 2011-06-22 Leo Liu <sdl.web@gmail.com>
5231 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5232 Move to minibuffer.el.
5234 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5236 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5237 The following patches are for when GLYPH_DEBUG && !XASSERT.
5238 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5239 * dispnew.c (flush_stdout):
5240 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5241 Mark as externally visible.
5242 * dispnew.c (check_window_matrix_pointers): Now static.
5243 * dispnew.c (window_to_frame_vpos):
5244 * xfns.c (unwind_create_frame):
5245 * xterm.c (x_check_font): Remove unused local.
5246 * scroll.c (CHECK_BOUNDS):
5247 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5248 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5249 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5250 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5251 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5253 (debug_method_add): Use va_list and vsprintf rather than relying
5254 on undefined behavior with wrong number of arguments.
5255 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5256 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5257 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5258 since we're not interested in debugging glyphs with old libraries.
5259 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5260 GCC 4.6.0's static checking.
5262 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5264 Integer overflow and signedness fixes (Bug#8873).
5265 A few related buffer overrun fixes, too.
5267 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5269 * dispextern.h (struct face.stipple):
5270 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5271 (x_bitmap_mask, x_allocate_bitmap_record)
5272 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5273 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5274 (x_create_bitmap_from_xpm_data):
5275 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5276 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5278 * xfaces.c (load_pixmap):
5279 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5280 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5281 (.bitmaps_last, struct x_output.icon_bitmap):
5282 Use ptrdiff_t, not int, for bitmap indexes.
5283 (x_allocate_bitmap_record): Check for size overflow.
5284 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5286 Use ptrdiff_t, not int, for overlay counts.
5287 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5288 * editfns.c (overlays_around, get_pos_property):
5289 * textprop.c (get_char_property_and_overlay):
5290 * xdisp.c (next_overlay_change, note_mouse_highlight):
5291 * xfaces.c (face_at_buffer_position):
5292 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5293 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5294 (Fnext_overlay_change, Fprevious_overlay_change)
5295 (mouse_face_overlay_overlaps, Foverlays_in):
5296 Use ptrdiff_t, not int, for sizes.
5297 (overlays_at, overlays_in): Check for size-calculation overflow.
5299 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5301 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5302 (x_session_initialize): Do not assume string length fits in int.
5304 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5305 This is unlikely, but can occur if DPI is outlandish.
5307 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5308 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5310 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5311 * xrdb.c (magic_file_p, search_magic_path):
5312 Omit last arg SUFFIX; it was always 0. All callers changed.
5313 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5315 * xfont.c (xfont_match): Avoid need for strlen.
5317 * xfns.c: Don't assume strlen fits in int.
5318 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5320 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5321 not unsigned long, as we prefer signed integers. All callers changed.
5322 Detect integer overflow in repeat count.
5323 (message_dolog): Don't assume print length fits in 39 bytes.
5324 (display_mode_element): Don't assume strlen fits in int.
5326 * termcap.c: Don't assume sizes fit in int and never overflow.
5327 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5328 (gobble_line): Check for size-calculation overflow.
5330 * minibuf.c (Fread_buffer):
5331 * lread.c (intern, intern_c_string):
5332 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5333 Don't assume string length fits in int.
5335 * keyboard.c (parse_tool_bar_item):
5336 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5338 * font.c: Don't assume string length fits in int.
5339 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5340 Use ptrdiff_t, not int.
5341 (font_intern_prop): Don't assume string length fits in int.
5342 Don't assume integer property fits in fixnum.
5343 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5345 * filelock.c: Fix some buffer overrun and integer overflow issues.
5346 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5347 Reformulate so as not to need the command string.
5348 Invoke gzip -cd rather than gunzip, as it's more portable.
5349 (lock_info_type, lock_file_1, lock_file):
5350 Don't assume pid_t and time_t fit in unsigned long.
5351 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5352 (current_lock_owner): Prefer signed type for sizes.
5353 Use memcpy, not strncpy, where memcpy is what is really wanted.
5354 Don't assume (via atoi) that time_t and pid_t fit in int.
5355 Check for time_t and/or pid_t out of range, e.g., via a network share.
5356 Don't alloca where an auto var works fine.
5358 * fileio.c: Fix some integer overflow issues.
5359 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5360 Don't assume string length fits in int.
5361 (directory_file_name): Don't assume string length fits in long.
5362 (make_temp_name): Don't assume pid fits in int, or that its print
5363 length is less than 20.
5365 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5367 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5369 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5371 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5372 We prefer signed integers, even for size calculations.
5374 * emacs.c: Don't assume string length fits in 'int'.
5375 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5376 (main): Don't invoke strlen when not needed.
5378 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5379 (XD_DEBUG_MESSAGE): Don't waste a byte.
5381 * callproc.c (getenv_internal_1, getenv_internal)
5383 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5385 * lread.c (invalid_syntax): Omit length argument.
5386 All uses changed. This doesn't fix a bug, but it simplifies the
5387 code away from its former Hollerith-constant appearance, and it's
5388 one less 'int' to worry about when looking at integer-overflow issues.
5389 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5391 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5392 This didn't break anything, but it didn't help either.
5393 It's confusing to put a bogus integer in a place where the actual
5394 value does not matter.
5395 (LIST_END_P): Remove unused macro and its bogus comment.
5396 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5398 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5399 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5401 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5402 We prefer signed types, and the value cannot exceed the EMACS_INT
5403 range anyway (because otherwise the length would not be representable).
5404 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5405 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5406 This avoids a GCC warning when WIDE_EMACS_INT.
5408 * indent.c (sane_tab_width): New function.
5409 (current_column, scan_for_column, Findent_to, position_indentation)
5410 (compute_motion): Use it. This is just for clarity.
5411 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5413 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5415 * lisp.h (lint_assume): New macro.
5416 * composite.c (composition_gstring_put_cache):
5417 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5419 * editfns.c, insdel.c:
5420 Omit unnecessary forward decls, to simplify future changes.
5422 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5424 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5426 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5427 Use much-faster test for byte-length change.
5428 Don't assume string byte-length fits in 'int'.
5429 Check that character arg fits in 'int'.
5430 (mapcar1): Declare byte as byte, for clarity.
5432 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5434 * fns.c (concat): Catch string overflow earlier.
5435 Do not rely on integer wraparound.
5437 * dispextern.h (struct it.overlay_strings_charpos)
5438 (struct it.selective): Now EMACS_INT, not int.
5439 * xdisp.c (forward_to_next_line_start)
5440 (back_to_previous_visible_line_start)
5441 (reseat_at_next_visible_line_start, next_element_from_buffer):
5442 Don't arbitrarily truncate the value of 'selective' to int.
5444 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5446 * composite.c: Don't truncate sizes to 'int'.
5447 (composition_gstring_p, composition_reseat_it)
5448 (composition_adjust_point): Use EMACS_INT, not int.
5449 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5450 not EMACS_UINT, for indexes.
5452 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5454 * buffer.c: Include <verify.h>.
5455 (struct sortvec.priority, struct sortstr.priority):
5456 Now EMACS_INT, not int.
5457 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5458 (struct sortstr.size, record_overlay_string)
5459 (struct sortstrlist.size, struct sortlist.used):
5460 Don't truncate size to int.
5461 (record_overlay_string): Check for size-calculation overflow.
5462 (init_buffer_once): Check at compile-time, not run-time.
5464 2011-06-22 Jim Meyering <meyering@redhat.com>
5466 Don't leak an XBM-image-sized buffer
5467 * image.c (xbm_load): Free the image buffer after using it.
5469 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5472 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5473 that Sun C diagnosed.
5474 * fns.c (secure_hash): Fix pointer signedness issue.
5475 * intervals.c (static_offset_intervals): New function.
5476 (offset_intervals): Use it.
5478 2011-06-21 Leo Liu <sdl.web@gmail.com>
5481 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5484 * fns.c (secure_hash): Rename from crypto_hash_function and change
5485 the first arg to accept symbols.
5486 (Fsecure_hash): New primitive.
5487 (syms_of_fns): New symbols.
5489 2011-06-20 Deniz Dogan <deniz@dogan.se>
5491 * process.c (Fset_process_buffer): Clarify return value in
5494 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5496 * dispnew.c (add_window_display_history): Use BVAR.
5498 * xdisp.c (debug_method_add): Use BVAR.
5499 (check_window_end, dump_glyph_matrix, dump_glyph)
5500 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5502 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5505 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5506 check till after the cache is created in init_frame_faces.
5508 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5510 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5512 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5514 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5515 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5516 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5518 Improve buffer-overflow checking (Bug#8873).
5519 * fileio.c (Finsert_file_contents):
5520 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5521 Remove the old (too-loose) buffer overflow checks.
5522 They weren't needed, since make_gap checks for buffer overflow.
5523 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5524 The old code merely checked for Emacs fixnum overflow, and relied
5525 on undefined (wraparound) behavior. The new code avoids undefined
5526 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5528 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5529 Tune. Don't use wider integers than needed. Don't use alloca.
5530 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5532 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5534 * insdel.c, lisp.h (buffer_overflow): New function.
5535 (insert_from_buffer_1, replace_range, replace_range_2):
5536 * insdel.c (make_gap_larger):
5537 * editfns.c (Finsert_char):
5538 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5540 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5542 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5544 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5546 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5547 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5549 * fileio.c: Don't assume EMACS_INT fits in off_t.
5550 (emacs_lseek): New static function.
5551 (Finsert_file_contents, Fwrite_region): Use it.
5552 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5554 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5556 * fns.c: Don't overflow int when computing a list length.
5557 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5558 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5559 truncation on 64-bit hosts. Check for QUIT every
5560 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5561 faster and is responsive enough.
5562 (Flength): Report an error instead of overflowing an integer.
5563 (Fsafe_length): Return a float if the value is not representable
5564 as a fixnum. This shouldn't happen except in contrived situations.
5565 (Fnthcdr, Fsort): Don't assume list length fits in int.
5566 (Fcopy_sequence): Don't assume vector length fits in int.
5568 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5569 (header_size, word_size): New constants.
5570 (allocate_vectorlike): Don't check size overflow here.
5571 (allocate_vector): Check it here instead, since this is the only
5572 caller of allocate_vectorlike that could cause overflow.
5573 Check that the new vector's length is representable as a fixnum.
5575 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5576 The previous code was bogus. For example, next_almost_prime (32)
5577 returned 39, which is undesirable as it is a multiple of 3; and
5578 next_almost_prime (24) returned 25, which is a multiple of 5 so
5579 why was the code bothering to check for multiples of 7?
5581 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5583 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5585 Variadic C functions now count arguments with ptrdiff_t.
5586 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5587 Back then I didn't know that the Emacs coding style prefers signed int.
5588 Also, in the meantime I found a few more instances where arguments
5589 were being counted with int, which may truncate counts on 64-bit
5590 machines, or EMACS_INT, which may be unnecessarily wide.
5591 * lisp.h (struct Lisp_Subr.function.aMANY)
5592 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5593 Arg counts are now ptrdiff_t, not size_t.
5594 All variadic functions and their callers changed accordingly.
5595 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5596 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5597 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5598 * callint.c (Fcall_interactively): Check arg count for overflow,
5599 to avoid potential buffer overrun. Use signed char, not 'int',
5600 for 'varies' array, so that we needn't bother to check its size
5601 calculation for overflow.
5602 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5603 * eval.c (apply_lambda):
5604 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5605 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5606 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5608 * callint.c (Fcall_interactively): Don't use index var as event count.
5610 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5611 * mem-limits.h (SIZE): Remove; no longer used.
5613 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5615 Remove unnecessary casts.
5616 * xterm.c (x_term_init):
5617 * xfns.c (x_set_border_pixel):
5618 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5619 These aren't needed now that we assume ANSI C.
5621 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5622 It's more likely to cause problems (due to unsigned overflow)
5625 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5627 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5629 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5631 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5633 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5635 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5637 GLYPH_CODE_FACE returns EMACS_INT, not int.
5638 * dispextern.h (merge_faces):
5639 * xfaces.c (merge_faces):
5640 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5641 Don't assume EMACS_INT fits in int.
5643 * character.h (CHAR_VALID_P): Remove unused parameter.
5644 * fontset.c, lisp.h, xdisp.c: All uses changed.
5646 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5648 * fns.c (concat): Minor tuning based on overflow analysis.
5649 This doesn't fix any bugs. Use int to hold character, instead
5650 of constantly refetching from Emacs object. Use XFASTINT, not
5651 XINT, for value known to be a character. Don't bother comparing
5652 a single byte to 0400, as it's always less.
5654 * floatfns.c (Fexpt):
5655 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5657 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5660 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5662 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5663 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5664 incorrectly succeed when S was a string, because 4294967386 was
5665 truncated before it was used.
5667 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5668 Otherwise, an out-of-range integer could cause undefined behavior
5671 * composite.c: Use int, not EMACS_INT, for characters.
5672 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5673 EMACS_INT, for values that are known to be in character range.
5674 This doesn't fix any bugs but is the usual style inside Emacs and
5675 may generate better code on 32-bit machines.
5677 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5678 This is for reasons similar to the recent CHAR_STRING fix.
5679 * charset.c (Fencode_char): Check that character arg is actually
5680 a character. Pass an int to ENCODE_CHAR.
5681 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5682 wider than 'int', as a compile-time check to prevent future regressions
5685 * character.c (char_string): Remove unnecessary casts.
5687 Make sure a 64-bit char is never passed to CHAR_STRING.
5688 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5689 by silently ignoring the top 32 bits, allowing some values
5690 that were far too large to be valid characters.
5691 * character.h: Include <verify.h>.
5692 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5693 arguments are no wider than unsigned, as a compile-time check
5694 to prevent future regressions in this area.
5696 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5697 (Fsubst_char_in_region):
5699 * xdisp.c (decode_mode_spec_coding):
5700 Adjust to CHAR_STRING's new requirement.
5701 * editfns.c (Finsert_char, Fsubst_char_in_region):
5702 * fns.c (concat): Check that character args are actually
5703 characters. Without this test, these functions did the wrong
5704 thing with wildly out-of-range values on 64-bit hosts.
5706 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5707 These casts should not be needed on 32-bit hosts, either.
5708 * keyboard.c (read_char):
5709 * lread.c (Fload): Remove casts to unsigned.
5711 * lisp.h (UNSIGNED_CMP): New macro.
5712 This fixes comparison bugs on 64-bit hosts.
5713 (ASCII_CHAR_P): Use it.
5714 * casefiddle.c (casify_object):
5715 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5716 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5717 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5718 * dispextern.h (FACE_FROM_ID):
5719 * keyboard.c (read_char): Use UNSIGNED_CMP.
5721 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5722 not to EMACS_INT, to avoid GCC warning.
5724 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5726 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5727 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5728 isn't needed on 32-bit machines.
5730 * buffer.c (Fgenerate_new_buffer_name):
5731 Use EMACS_INT for count, not int.
5732 (advance_to_char_boundary): Return EMACS_INT, not int.
5734 * data.c (Qcompiled_function): Now static.
5736 * window.c (window_body_lines): Now static.
5738 * image.c (gif_load): Rename local to avoid shadowing.
5740 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5741 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5742 * alloc.c (make_save_value): Integer argument is now of type
5744 (mark_object): Use ptrdiff_t, not int.
5745 * lisp.h (pD): New macro.
5746 * print.c (print_object): Use it.
5748 * alloc.c: Use EMACS_INT, not int, to count objects.
5749 (total_conses, total_markers, total_symbols, total_vector_size)
5750 (total_free_conses, total_free_markers, total_free_symbols)
5751 (total_free_floats, total_floats, total_free_intervals)
5752 (total_intervals, total_strings, total_free_strings):
5753 Now EMACS_INT, not int. All uses changed.
5754 (Fgarbage_collect): Compute overall total using a double, so that
5755 integer overflow is less likely to be a problem. Check for overflow
5756 when converting back to an integer.
5757 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5758 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5759 These were 'int' variables that could overflow on 64-bit hosts;
5760 they were never used, so remove them instead of repairing them.
5761 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5762 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5763 Previously, this ceilinged at INT_MAX, but that doesn't work on
5765 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5767 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5768 (allocate_vectorlike): Check for ptrdiff_t overflow.
5769 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5770 when a (possibly-narrower) signed value would do just as well.
5771 We prefer using signed arithmetic, to avoid comparison confusion.
5773 * alloc.c: Catch some string size overflows that we were missing.
5774 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5775 for convenience in STRING_BYTES_MAX.
5776 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5777 The definition here is exact; the one in lisp.h was approximate.
5778 (allocate_string_data): Check for string overflow. This catches
5779 some instances we weren't catching before. Also, it catches
5780 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5781 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5782 and ptrdiff_t and EMACS_INT are both 64 bits.
5784 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5785 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5786 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5788 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5790 * alloc.c (Fmake_string): Check for out-of-range init.
5792 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5794 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5796 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5798 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5799 xg_get_default_scrollbar_width.
5801 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5802 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5803 (style_changed_cb): Call update_theme_scrollbar_width and call
5804 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5805 all frames (Bug#8505).
5806 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5807 Call gtk_window_set_resizable if HAVE_GTK3.
5808 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5809 and height if HAVE_GTK3 (Bug#8505).
5810 (scroll_bar_width_for_theme): New variable.
5811 (update_theme_scrollbar_width): New function.
5812 (xg_get_default_scrollbar_width): Move code to
5813 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5814 (xg_initialize): Call update_theme_scrollbar_width.
5816 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5818 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5820 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5822 * frame.c (make_frame): Call other_buffer_safely instead of
5825 * window.c (temp_output_buffer_show): Call display_buffer with
5826 second argument Vtemp_buffer_show_specifiers and reset latter
5827 immediately after the call.
5828 (Vtemp_buffer_show_specifiers): New variable.
5829 (auto_window_vscroll_p, next_screen_context_lines)
5830 (Vscroll_preserve_screen_position): Remove leading asterisks from
5833 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5835 Fix minor problems found by GCC 4.6.0 static checking.
5836 * buffer.c (Qclone_number): Remove for now, as it's unused.
5837 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5838 (record_buffer): Remove unused local.
5839 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5840 (set_frame_buffer_list): Remove; unused.
5841 * frame.h (other_visible_frames): Remove decl.
5842 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5843 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5844 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5846 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5847 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5848 Define only if HAVE_GPM.
5849 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5850 (update_hints_inhibit): Remove; never set. All uses removed.
5851 * widgetprv.h (emacsFrameClassRec): Remove decl.
5852 * window.c (delete_deletable_window): Now returns void, since it
5853 wasn't returning anything.
5854 (compare_window_configurations): Remove unused locals.
5855 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5856 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5857 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5858 the same widths as pointers. This follows up on the 2011-05-06 patch.
5859 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5860 * xterm.h: Likewise.
5861 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5863 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5865 * makefile.w32-in: Update dependencies.
5866 (LISP_H): Add lib/intprops.h.
5868 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5870 * image.c (gif_load): Add animation frame delay to the metadata.
5871 (syms_of_image): Use DEFSYM. New symbol `delay'.
5873 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5875 * window.c (delete_deletable_window): Re-add.
5876 (Fset_window_configuration): Rewrite to handle dead buffers and
5877 consequently deletable windows.
5878 (window_tree, Fwindow_tree): Remove. Supply functionality in
5880 (compare_window_configurations): Simplify code.
5882 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5884 * image.c (imagemagick_load_image): Fix type mismatch.
5885 (Fimagemagick_types): Likewise.
5887 * window.h (replace_buffer_in_windows): Declare.
5889 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5891 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5892 Qclone_number. Remove external declaration of Qdelete_window.
5893 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5895 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5896 Run Qbuffer_list_update_hook if allowed.
5897 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5898 buffer list implementation.
5899 (other_buffer_safely): New function.
5900 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5901 calls to replace_buffer_in_windows and
5902 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5904 (record_buffer): Inhibit quitting and rewrite using quittable
5905 functions. Run Qbuffer_list_update_hook if allowed.
5906 (Frecord_buffer, Funrecord_buffer): New functions.
5907 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5908 Move switch-to-buffer to window.el.
5909 (bury-buffer): Move to window.el.
5910 (Vbuffer_list_update_hook): New variable.
5912 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5915 * window.h (resize_frame_windows): Move up in code.
5916 (Fwindow_frame): Remove EXFUN.
5917 (replace_buffer_in_all_windows): Remove prototype.
5918 (replace_buffer_in_windows_safely): Add prototype.
5920 * window.c: Declare Qdelete_window static again. Move down
5921 declaration of select_count.
5922 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5923 (Fother_window): Move to window.el.
5924 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5925 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5926 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5928 (replace_buffer_in_windows): Implement by calling
5929 Qreplace_buffer_in_windows.
5930 (replace_buffer_in_all_windows): Remove with some functionality
5931 moved into replace_buffer_in_windows_safely.
5932 (replace_buffer_in_windows_safely): New function.
5933 (select_window_norecord, select_frame_norecord): Move in front
5934 of run_window_configuration_change_hook. Remove now obsolete
5936 (Fset_window_buffer): Rewrite doc-string.
5937 Call Qrecord_window_buffer.
5938 (keys_of_window): Move binding for other-window to window.el.
5940 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5942 * dispextern.h (struct image): Replace data member, whose int_val
5943 and ptr_val fields were not used by anything, with a single
5946 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5947 (gif_clear_image, gif_load, imagemagick_load_image)
5948 (gs_clear_image, gs_load): Callers changed.
5950 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5952 * buffer.h: Include <time.h>, for time_t.
5953 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5955 Fix minor problems found by static checking.
5957 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5959 Make identifiers static if they are not used in other modules.
5960 * data.c (Qcompiled_function, Qframe, Qvector):
5961 * image.c (QimageMagick, Qsvg):
5962 * minibuf.c (Qmetadata):
5963 * window.c (resize_window_check, resize_root_window): Now static.
5964 * window.h (resize_window_check, resize_root_window): Remove decls.
5966 * window.c (window_deletion_count, delete_deletable_window):
5968 (window_body_lines): Now static.
5969 (Fdelete_other_windows_internal): Mark vars as initialized.
5970 Make sure 'resize_failed' is initialized.
5971 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5972 (resize_window_apply): Remove unused local.
5973 * window.h (delete_deletable_window): Remove decl.
5975 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5976 (imagemagick_load_image): Fix pointer signedness problem by changing
5977 last arg from unsigned char * to char *. All uses changed.
5978 Also, fix a local for similar reasons.
5979 Remove unused locals. Remove locals to avoid shadowing.
5980 (fn_rsvg_handle_free): Remove; unused.
5981 (svg_load, svg_load_image): Fix pointer signedness problem.
5982 (imagemagick_load_image): Don't use garbage pointer image_wand.
5984 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5986 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5988 * image.c (gif_load): Fix omitted cast error introduced by
5991 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5993 * window.h (resize_proportionally, orig_total_lines)
5994 (orig_top_line): Remove from window structure.
5995 (set_window_height, set_window_width, change_window_heights)
5996 (Fdelete_window): Remove prototypes.
5997 (resize_frame_windows): Remove duplicate declaration.
5999 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6001 * window.h (resize_frame_windows, resize_window_check)
6002 (delete_deletable_window, resize_root_window)
6003 (resize_frame_windows): Declare prototypes.
6005 * window.c (resize_window_apply): Make definition be "static" to
6006 match the prototype.
6008 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6010 * window.c: Remove declarations of Qwindow_size_fixed,
6011 window_min_size_1, window_min_size_2, window_min_size,
6012 size_window, window_fixed_size_p, enlarge_window, delete_window.
6013 Remove static from declaration of Qdelete_window, it's
6014 temporarily needed by Fbury_buffer.
6015 (replace_window): Don't assign orig_top_line and
6017 (Fdelete_window, delete_window): Remove. Window deletion is
6018 handled by window.el.
6019 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6020 Replace Fdelete_window calls with calls to Qdelete_window.
6021 (Fdelete_other_windows): Remove. Deleting other windows is
6022 handled by window.el.
6023 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6024 handled in window.el.
6025 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6026 Window minimum sizes are handled in window.el.
6027 (shrink_windows, size_window, set_window_height)
6028 (set_window_width, change_window_heights, window_height)
6029 (window_width, CURBEG, CURSIZE, enlarge_window)
6030 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6031 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6032 handled in window.el.
6033 (make_dummy_parent): Rename to make_parent_window and give it a
6034 second argument horflag.
6035 (make_window): Don't set resize_proportionally any more.
6036 (Fsplit_window): Remove. Windows are split in window.el.
6037 (save_restore_action, save_restore_orig_size)
6038 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6039 Resize mini windows in window.el.
6040 (grow_mini_window, shrink_mini_window): Implement by calling
6041 Qresize_root_window_vertically, resize_window_check and
6042 resize_window_apply.
6043 (saved_window, Fset_window_configuration, save_window_save):
6044 Do not handle orig_top_line, orig_total_lines, and
6045 resize_proportionally.
6046 (window_min_height, window_min_width): Move to window.el.
6047 (keys_of_window): Move bindings for delete-other-windows,
6048 split-window, delete-window and enlarge-window to window.el.
6050 * buffer.c: Temporarily extern Qdelete_window.
6051 (Fbury_buffer): Temporarily call Qdelete_window instead of
6052 Fdelete_window (Fbury_buffer will move to window.el soon).
6054 * frame.c (set_menu_bar_lines_1): Remove code handling
6055 orig_top_line and orig_total_lines.
6057 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6058 set_window_height but set heights directly.
6059 (change_frame_size_1): Use resize_frame_windows.
6061 * xdisp.c (init_xdisp): Don't use set_window_height but set
6064 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6065 Use resize_frame_windows instead of change_window_heights and run
6066 run_window_configuration_change_hook.
6068 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6069 instead of change_window_heights and run
6070 run_window_configuration_change_hook.
6072 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6074 * window.c (replace_window): Rename second argument REPLACEMENT to
6075 NEW. New third argument SETFLAG. Rewrite.
6076 (delete_window, make_dummy_parent): Call replace_window with
6078 (window_list_1): Move down in code.
6079 (run_window_configuration_change_hook): Move set_buffer part
6080 before select_frame_norecord part in order to unwind correctly.
6081 Rename count1 to count.
6082 (recombine_windows, delete_deletable_window, resize_root_window)
6083 (Fdelete_other_windows_internal)
6084 (Frun_window_configuration_change_hook, make_parent_window)
6085 (resize_window_check, resize_window_apply, Fresize_window_apply)
6086 (resize_frame_windows, Fsplit_window_internal)
6087 (Fdelete_window_internal, Fresize_mini_window_internal):
6089 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6091 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6093 * window.h (window): Add some new members to window structure -
6094 normal_lines, normal_cols, new_total, new_normal, clone_number,
6095 splits, nest, prev_buffers, next_buffers.
6096 (WINDOW_TOTAL_SIZE): Move here from window.c.
6097 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6099 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6101 (make_dummy_parent): Set new members of windows structure.
6102 (make_window): Move down in code. Handle new members of window
6104 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6105 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6106 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6107 (Fset_window_prev_buffers, Fwindow_next_buffers)
6108 (Fset_window_next_buffers, Fset_window_clone_number):
6110 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6111 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6113 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6114 Argument WINDOW can be now internal window too.
6115 (Fwindow_use_time): Move up in code.
6116 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6118 (Fset_window_configuration, saved_window)
6119 (Fcurrent_window_configuration, save_window_save): Handle new
6120 members of window structure.
6121 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6122 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6123 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6124 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6125 Qget_mru_window, Qresize_root_window,
6126 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6127 Qauto_buffer_name; staticpro them.
6129 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6131 * window.c (Fwindow_total_size, Fwindow_left_column)
6132 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6133 (Fwindow_list_1): New functions.
6134 (window_box_text_cols): Replace with window_body_cols.
6135 (Fwindow_width, Fscroll_left, Fscroll_right):
6136 Use window_body_cols instead of window_box_text_cols.
6137 (delete_window, Fset_window_configuration):
6138 Call delete_all_subwindows with window as argument.
6139 (delete_all_subwindows): Take a window as argument and not a
6141 (window_loop): Remove handling of GET_LRU_WINDOW and
6143 (Fget_lru_window, Fget_largest_window): Move to window.el.
6145 * window.h: Extern window_body_cols instead of
6146 window_box_text_cols. delete_all_subwindows now takes a
6147 Lisp_Object as argument.
6149 * indent.c (compute_motion, Fcompute_motion):
6150 Use window_body_cols instead of window_box_text_cols.
6152 * frame.c (delete_frame): Call delete_all_subwindows with root
6155 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6157 * fns.c (Fputhash): Document return value.
6159 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6161 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6163 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6165 Cons<->int and similar integer overflow fixes (Bug#8794).
6167 Check for overflow when converting integer to cons and back.
6168 * charset.c (Fdefine_charset_internal, Fdecode_char):
6169 Use cons_to_unsigned to catch overflow.
6170 (Fencode_char): Use INTEGER_TO_CONS.
6171 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6172 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6173 * data.c (long_to_cons, cons_to_long): Remove.
6174 (cons_to_unsigned, cons_to_signed): New functions.
6175 These signal an error for invalid or out-of-range values.
6176 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6177 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6178 * font.c (Ffont_variation_glyphs):
6179 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6180 * lisp.h: Include <intprops.h>.
6181 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6182 (cons_to_signed, cons_to_unsigned): New decls.
6183 (long_to_cons, cons_to_long): Remove decls.
6184 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6185 (Fprimitive_undo): Use CONS_TO_INTEGER.
6186 * xfns.c (Fx_window_property): Likewise.
6187 * xselect.c: Include <limits.h>.
6188 (x_own_selection, selection_data_to_lisp_data):
6189 Use INTEGER_TO_CONS.
6190 (x_handle_selection_request, x_handle_selection_clear)
6191 (x_get_foreign_selection, Fx_disown_selection_internal)
6192 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6193 (lisp_data_to_selection_data): Use cons_to_unsigned.
6194 (x_fill_property_data): Use cons_to_signed.
6195 Report values out of range.
6197 Check for buffer and string overflow more precisely.
6198 * buffer.h (BUF_BYTES_MAX): New macro.
6199 * lisp.h (STRING_BYTES_MAX): New macro.
6200 * alloc.c (Fmake_string):
6201 * character.c (string_escape_byte8):
6202 * coding.c (coding_alloc_by_realloc):
6203 * doprnt.c (doprnt):
6204 * editfns.c (Fformat):
6206 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6207 since they may not be the same number.
6208 * editfns.c (Finsert_char):
6209 * fileio.c (Finsert_file_contents):
6210 Likewise for BUF_BYTES_MAX.
6212 * image.c: Use ptrdiff_t, not int, for sizes.
6213 (slurp_file): Switch from int to ptrdiff_t.
6215 (slurp_file): Check that file size fits in both size_t (for
6216 malloc) and ptrdiff_t (for sanity and safety).
6218 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6219 if b->modtime has its maximal value.
6221 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6223 Don't assume time_t can fit into int.
6224 * buffer.h (struct buffer.modtime): Now time_t, not int.
6225 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6226 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6228 Minor fixes for signed vs unsigned integers.
6229 * character.h (MAYBE_UNIFY_CHAR):
6230 * charset.c (maybe_unify_char):
6231 * keyboard.c (read_char, reorder_modifiers):
6232 XINT -> XFASTINT, since the integer must be nonnegative.
6233 * ftfont.c (ftfont_spec_pattern):
6234 * keymap.c (access_keymap, silly_event_symbol_error):
6235 XUINT -> XFASTINT, since the integer must be nonnegative.
6236 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6237 since it makes no difference and we prefer signed.
6238 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6239 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6242 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6244 * window.h (Fwindow_frame): Declare.
6246 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6248 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6249 (SPARE_MEMORY): Always define.
6250 (LARGE_REQUEST): Remove.
6251 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6253 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6255 * lisp.h: Move EXFUNS for Fframe_root_window,
6256 Fframe_first_window and Fset_frame_selected_window to window.h.
6258 * window.h: Move EXFUNS for Fframe_root_window,
6259 Fframe_first_window and Fset_frame_selected_window here from
6262 * frame.c (Fwindow_frame, Fframe_first_window)
6263 (Fframe_root_window, Fframe_selected_window)
6264 (Fset_frame_selected_window): Move to window.c.
6265 (Factive_minibuffer_window): Move to minibuf.c.
6266 (Fother_visible_frames_p): New function.
6268 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6270 * window.c (decode_window, decode_any_window): Move up in code.
6271 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6272 (inhibit_frame_unsplittable): Remove unused variable.
6273 (Fwindow_buffer): Move up and rewrite doc-string.
6274 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6275 (Fwindow_prev): New functions.
6276 (Fwindow_frame): Move here from frame.c. Accept any window as
6278 (Fframe_root_window, Fframe_first_window)
6279 (Fframe_selected_window): Move here from frame.c. Accept frame
6280 or arbitrary window as argument. Update doc-strings.
6281 (Fminibuffer_window): Move up in code.
6282 (Fwindow_minibuffer_p): Move up in code and simplify.
6283 (Fset_frame_selected_window): Move here from frame.c.
6285 (Fselected_window, select_window, Fselect_window): Move up in
6286 code. Minor doc-string fixes.
6288 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6290 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6291 Do not assume that spare memory exists; that assumption is valid
6292 only if SYSTEM_MALLOC.
6293 (LARGE_REQUEST): New macro, so that the issue of large requests
6294 is separated from the issue of spare memory.
6296 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6298 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6301 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6303 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6306 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6308 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6310 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6312 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6313 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6315 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6317 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6319 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6321 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6322 (x_clipboard_manager_save): Add return value.
6323 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6325 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6326 Obey Vx_select_enable_clipboard_manager. Catch errors in
6327 x_clipboard_manager_save (Bug#8779).
6328 (Vx_select_enable_clipboard_manager): New variable.
6329 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6331 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6333 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6335 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6337 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6338 in the current matrix if keep_current_p is non-zero.
6340 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6342 * bidi.c (bidi_level_of_next_char): Fix last change.
6344 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6346 Support bidi reordering of text covered by display properties.
6348 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6349 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6350 (bidi_cache_search, bidi_cache_iterator_state)
6351 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6352 (bidi_level_of_next_char, bidi_move_to_visually_next):
6353 Support character positions inside a run of characters covered by a
6355 (bidi_paragraph_init, bidi_resolve_explicit_1)
6356 (bidi_level_of_next_char): Call bidi_fetch_char and
6357 bidi_fetch_char_advance instead of FETCH_CHAR and
6359 (bidi_init_it): Initialize new members.
6360 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6362 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6363 instead of using explicit *_CHAR codes.
6364 (bidi_resolve_explicit, bidi_resolve_weak):
6365 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6366 bidirectional text is supported only in multibyte buffers.
6367 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6368 it to initialize the frame_window_p member of struct bidi_it.
6369 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6370 (bidi_resolve_explicit, bidi_resolve_weak)
6371 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6372 bidi_it->nchars is non-positive.
6373 (bidi_level_of_next_char): Don't try to lookup the cache for the
6374 next/previous character if nothing is cached there yet, or if we
6375 were just reseat()'ed to a new position.
6377 * xdisp.c (set_cursor_from_row): Set start and stop points
6378 according to the row's direction when priming the loop that looks
6379 for the glyph on which to display cursor.
6380 (single_display_spec_intangible_p): Function deleted.
6381 (display_prop_intangible_p): Reimplement to call
6382 handle_display_spec instead of single_display_spec_intangible_p.
6383 Accept 3 additional arguments needed by handle_display_spec.
6384 This fixes incorrect cursor motion across display property with complex
6385 values: lists, `(when COND...)' forms, etc.
6386 (single_display_spec_string_p): Support property values that are
6387 lists with the argument STRING its top-level element.
6388 (display_prop_string_p): Fix the condition for processing a
6389 property that is a list to be consistent with handle_display_spec.
6390 (handle_display_spec): New function, refactored from the
6391 last portion of handle_display_prop.
6392 (compute_display_string_pos): Accept additional argument
6393 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6394 value of a `display' property is a "replacing spec".
6395 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6396 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6397 the display property, but just return a value indicating whether
6398 the display property will replace the characters it covers.
6399 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6400 frame_window_p members of struct bidi_it.
6401 (compute_display_string_pos, compute_display_string_end):
6403 (push_it): Accept second argument POSITION, where pop_it should
6404 jump to continue iteration.
6405 (reseat_1): Initialize bidi_it.disp_pos.
6407 * keyboard.c (adjust_point_for_property): Adjust the call to
6408 display_prop_intangible_p to its new signature.
6410 * dispextern.h (struct bidi_it): New member frame_window_p.
6411 (bidi_init_it): Update prototypes.
6412 (display_prop_intangible_p): Update prototype.
6413 (compute_display_string_pos, compute_display_string_end):
6415 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6418 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6420 Malloc failure behavior now depends on size of allocation.
6421 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6422 * lisp.h: Change signatures accordingly.
6423 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6424 All callers changed. (Bug#8762)
6426 * gnutls.c: Use Emacs's memory allocators.
6427 Without this change, the gnutls library would invoke malloc etc.
6428 directly, which causes problems on non-SYNC_INPUT hosts, and which
6429 runs afoul of improving memory_full behavior. (Bug#8761)
6430 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6431 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6432 xfree instead of the default malloc, realloc, free.
6433 (Fgnutls_boot): No need to check for memory allocation failure,
6434 since xmalloc does that for us.
6436 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6437 * category.c (hash_get_category_set):
6438 * ccl.c (ccl_driver):
6439 * charset.c (Fdefine_charset_internal):
6440 * charset.h (struct charset.hash_index):
6441 * composite.c (get_composition_id, gstring_lookup_cache)
6442 (composition_gstring_put_cache):
6443 * composite.h (struct composition.hash_index):
6444 * dispextern.h (struct image.hash):
6445 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6446 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6447 (hashfn_equal, hashfn_user_defined, make_hash_table)
6448 (maybe_resize_hash_table, hash_lookup, hash_put)
6449 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6450 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6451 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6452 * image.c (make_image, search_image_cache, lookup_image)
6453 (xpm_put_color_table_h):
6454 * lisp.h (struct Lisp_Hash_Table):
6455 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6456 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6457 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6458 * alloc.c (allocate_vectorlike):
6459 Check for overflow in vector size calculations.
6460 * ccl.c (ccl_driver):
6461 Check for overflow when converting EMACS_INT to int.
6462 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6463 need to be updated by these changes.
6464 * fns.c (make_hash_table, maybe_resize_hash_table):
6465 Check for integer overflow with large hash tables.
6466 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6467 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6468 (SXHASH_REDUCE): New macro.
6469 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6470 Use it instead of discarding useful hash info with large hash values.
6471 (sxhash_float): New function.
6472 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6473 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6474 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6475 Rewrite to use FIXNUM_BITS, as this simplifies things.
6476 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6477 Adjust signatures to match updated version of code.
6478 (consing_since_gc): Now EMACS_INT, since a single hash table can
6479 use more than INT_MAX bytes.
6481 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6483 Make it possible to build with GCC-4.6+ -O2 -flto.
6485 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6487 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6489 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6490 Call minibuffer-inactive-mode.
6492 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6494 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6495 Update dependencies.
6497 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6499 * data.c (init_data): Remove code for UTS, this system is not
6502 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6504 Don't force ./temacs to start in terminal mode.
6506 * frame.c (make_initial_frame): Initialize faces in all cases, not
6507 only when CANNOT_DUMP is defined.
6508 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6510 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6512 * dispnew.c (add_window_display_history): Use const for the string
6513 pointer. Remove declaration, not needed.
6515 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6517 Use 'inline', not 'INLINE'.
6518 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6519 * alloc.c, fontset.c (INLINE): Remove.
6520 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6521 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6522 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6523 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6524 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6526 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6528 Make it possible to run ./temacs.
6530 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6531 syms_of_callproc does the same thing. Remove test for
6532 "initialized", do it in the caller.
6533 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6535 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6537 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6538 (read_minibuf): Use get_minibuffer.
6539 (syms_of_minibuf): Use DEFSYM.
6540 (Qmetadata): New var.
6541 * data.c (Qbuffer): Don't make it static.
6542 (syms_of_data): Use DEFSYM.
6544 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6546 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6547 (CCL_CODE_MIN): New macro.
6549 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6551 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6553 * eval.c (Qdebug): Now static.
6554 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6555 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6556 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6558 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6560 * image.c: Various fixes to ImageMagick code comments.
6561 (Fimagemagick_types): Doc fix.
6563 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6565 Minor fixes prompted by GCC 4.6.0 warnings.
6567 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6569 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6570 (x_clipboard_manager_save_all): Move extern decl to ...
6571 * xterm.h: ... here, so that it can be checked for consistency.
6573 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6575 * xselect.c (x_clipboard_manager_save_frame)
6576 (x_clipboard_manager_save_all): New functions.
6577 (Fx_clipboard_manager_save): Lisp function deleted.
6579 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6580 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6582 * xterm.h: Update prototype.
6584 2011-05-28 William Xu <william.xwl@gmail.com>
6586 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6589 2011-05-28 Jim Meyering <meyering@redhat.com>
6591 Avoid a sign-extension bug in crypto_hash_function.
6592 * fns.c (to_uchar): Define.
6593 (crypto_hash_function): Use it to convert some newly-signed
6594 variables to unsigned, to avoid sign-extension bugs. For example,
6595 without this change, (md5 "truc") would evaluate to
6596 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6597 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6598 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6600 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6602 Integer overflow fixes.
6604 * dbusbind.c: Serial number integer overflow fixes.
6605 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6606 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6607 to hold a serial number that is too large for a fixnum.
6608 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6609 Check for serial numbers out of range. Decode any serial number
6610 that was so large that it became a float. (Bug#8722)
6612 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6613 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6614 Use XFASTINT rather than XUINT when numbers are nonnegative.
6615 (xd_append_arg, Fdbus_method_return_internal):
6616 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6617 arguments, check that Lisp number is nonnegative, rather than
6618 silently wrapping negative numbers around. (Bug#8722)
6619 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6622 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6624 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6626 ccl: Add integer overflow checks.
6627 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6628 (IN_INT_RANGE): New macros.
6629 (ccl_driver): Use them to check for integer overflow when
6630 decoding a CCL program. Many of the new checks are whether XINT (x)
6631 fits in int; it doesn't always, on 64-bit hosts. The new version
6632 doesn't catch all possible integer overflows, but it's an
6633 improvement. (Bug#8719)
6635 * alloc.c (make_event_array): Use XINT, not XUINT.
6636 There's no need for unsigned here.
6638 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6639 This follows up to the 2011-05-06 change that substituted uintptr_t
6640 for EMACS_INT. This case wasn't caught back then.
6642 Rework Fformat to avoid integer overflow issues.
6643 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6644 now (part of C89). Include <verify.h>.
6645 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6646 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6647 (Fformat): Avoid the prepass trying to compute sizes; it was only
6648 approximate and thus did not catch overflow reliably. Instead, walk
6649 through the format just once, formatting and computing sizes as we go,
6650 checking for integer overflow at every step, and allocating a larger
6651 buffer as needed. Keep track separately whether the format is
6652 multibyte. Keep only the most-recently calculated precision, rather
6653 than them all. Record whether each argument has been converted to
6654 string. Use EMACS_INT, not int, for byte and char and arg counts.
6655 Support field widths and precisions larger than INT_MAX. Avoid
6656 sprintf's undefined behavior with conversion specifications such as %#d
6657 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6658 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6659 formatting out-of-range floating point numbers with int
6662 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6664 * data.c: Avoid integer truncation in expressions involving floats.
6665 * data.c: Include <intprops.h>.
6666 (arith_driver): When there's an integer overflow in an expression
6667 involving floating point, convert the integers to floating point
6668 so that the resulting value does not suffer from catastrophic
6669 integer truncation. For example, on a 64-bit host (* 4
6670 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6671 Do not rely on undefined behavior after integer overflow.
6673 merge count_size_as_multibyte, parse_str_to_multibyte
6674 * character.c, character.h (count_size_as_multibyte):
6675 Rename from parse_str_to_multibyte; all uses changed.
6676 Check for integer overflow.
6677 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6678 since it's now a duplicate of the other. This is more of
6679 a character than a buffer op, so better that it's in character.c.
6680 * fns.c, print.c: Adjust to above changes.
6682 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6684 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6686 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6688 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6689 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6690 (x_clipboard_manager_save): Now static.
6691 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6693 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6694 (crypto_hash_function): Now static.
6695 Fix pointer signedness problems. Avoid unnecessary initializations.
6697 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6699 * termhooks.h (Vselection_alist): Make it terminal-local.
6701 * terminal.c (create_terminal): Initialize it.
6703 * xselect.c: Support for clipboard managers.
6704 (Vselection_alist): Move to termhooks.h as terminal-local var.
6705 (LOCAL_SELECTION): New macro.
6706 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6707 (symbol_to_x_atom): Remove gratuitous arg.
6708 (x_handle_selection_request, lisp_data_to_selection_data)
6709 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6710 (x_own_selection, x_get_local_selection, x_convert_selection):
6711 New arg, specifying work frame. Use terminal-local Vselection_alist.
6712 (some_frame_on_display): Delete unused function.
6713 (Fx_own_selection_internal, Fx_get_selection_internal)
6714 (Fx_disown_selection_internal, Fx_selection_owner_p)
6715 (Fx_selection_exists_p): New optional frame arg.
6716 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6717 (x_handle_selection_clear): Don't treat other terminals with the
6718 same keyboard specially. Use the terminal-local Vselection_alist.
6719 (x_clear_frame_selections): Use Frun_hook_with_args.
6721 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6723 * xterm.h: Add support for those atoms.
6725 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6727 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6728 (converted_selections, conversion_fail_tag): New global variables.
6729 (x_selection_request_lisp_error): Free the above.
6730 (x_get_local_selection): Remove unnecessary code.
6731 (x_reply_selection_request): Args changed; handle arbitrary array
6732 of converted selections stored in converted_selections.
6733 Separate the XChangeProperty and SelectionNotify steps.
6734 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6735 (x_convert_selection): New function.
6736 (x_handle_selection_event): Simplify.
6737 (x_get_foreign_selection): Don't ignore incoming requests while
6738 waiting for an answer; this will fail when we implement
6739 SAVE_TARGETS, and seems unnecessary anyway.
6740 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6741 (Vx_sent_selection_functions): Doc fix.
6743 2011-05-26 Leo Liu <sdl.web@gmail.com>
6745 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6747 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6749 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6751 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6752 for fringe update if it has periodic bitmap.
6753 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6754 and fringe_bitmap_periodic_p.
6756 * fringe.c (get_fringe_bitmap_data): New function.
6757 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6758 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6759 row. Mark glyph row for fringe update if periodicity changed.
6761 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6762 for fringe update unless it has periodic bitmap.
6764 2011-05-25 Kenichi Handa <handa@m17n.org>
6766 * xdisp.c (get_next_display_element): Set correct it->face_id for
6767 a static composition.
6769 2011-05-24 Leo Liu <sdl.web@gmail.com>
6772 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6774 * fns.c (crypto_hash_function, Fsha1): New function.
6775 (Fmd5): Use crypto_hash_function.
6776 (syms_of_fns): Add Ssha1.
6778 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6780 * gnutls.c: Remove unused macros.
6781 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6782 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6783 Remove macros that are defined and never used.
6784 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6786 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6788 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6789 (Fx_get_selection_internal): Minor cleanup.
6790 (Fx_own_selection_internal): Rename arguments for consistency with
6793 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6795 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6797 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6799 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6801 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6803 * dispnew.c (scrolling_window): Don't exclude the case that the
6804 last enabled row in the desired matrix touches the bottom boundary.
6806 2011-05-21 Glenn Morris <rgm@gnu.org>
6808 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6809 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6810 and add some more files.
6812 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6814 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6815 report_file_error introduced by the change from 2011-05-07.
6817 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6819 * systime.h (Time): Define only if emacs is defined.
6820 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6821 where the include path doesn't have X11/X.h by default. See
6822 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6824 2011-05-20 Kenichi Handa <handa@m17n.org>
6826 * composite.c (find_automatic_composition): Fix previous change.
6828 2011-05-20 Glenn Morris <rgm@gnu.org>
6830 * lisp.mk: New file, split from Makefile.in.
6831 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6832 (shortlisp): Remove.
6833 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6835 2011-05-19 Glenn Morris <rgm@gnu.org>
6837 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6838 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6839 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6840 (lisp): Set the order to that of loadup.el.
6841 (shortlisp): Make it a copy of $lisp.
6842 (SOME_MACHINE_LISP): Remove.
6843 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6844 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6846 2011-05-18 Kenichi Handa <handa@m17n.org>
6848 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6849 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6850 (find_automatic_composition): Mostly rewrite for efficiency.
6852 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6854 * makefile.w32-in: Update dependencies.
6856 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6858 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6859 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6861 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6863 Fix some integer overflow issues, such as string length overflow.
6865 * insdel.c (count_size_as_multibyte): Check for string overflow.
6867 * character.c (lisp_string_width): Check for string overflow.
6868 Use EMACS_INT, not int, for string indexes and lengths; in
6869 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6870 the resulting string length overflows an EMACS_INT; instead,
6871 report a string overflow if no precision given. When checking for
6872 precision exhaustion, use a check that cannot possibly have
6873 integer overflow. (Bug#8675)
6874 * character.h (lisp_string_width): Adjust to new signature.
6876 * alloc.c (string_overflow): New function.
6877 (Fmake_string): Use it. This doesn't change behavior, but saves
6878 a few bytes and will simplify future changes.
6879 * character.c (string_escape_byte8): Likewise.
6880 * lisp.h (string_overflow): New decl.
6882 Fixups, following up to the user-interface timestamp change.
6883 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6884 for UI timestamps, instead of unsigned long.
6885 * msdos.c (mouse_get_pos): Likewise.
6886 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6887 * w32gui.h (Time): Define by including "systime.h" rather than by
6888 declaring it ourselves. (Bug#8664)
6890 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6891 * image.c (clear_image_cache): Likewise.
6893 * term.c (term_mouse_position): Don't assume time_t wraparound.
6895 Be more systematic about user-interface timestamps.
6896 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6897 and sometimes 'EMACS_UINT', to represent these timestamps.
6898 This change causes it to use 'Time' uniformly, as that's what X uses.
6899 This makes the code easier to follow, and makes it easier to catch
6900 integer overflow bugs such as Bug#8664.
6901 * frame.c (Fmouse_position, Fmouse_pixel_position):
6902 Use Time, not unsigned long, for user-interface timestamps.
6903 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6904 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6905 * keyboard.h (last_event_timestamp): Likewise.
6906 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6907 * menu.h (xmenu_show): Likewise.
6908 * term.c (term_mouse_position): Likewise.
6909 * termhooks.h (struct input_event.timestamp): Likewise.
6910 (struct terminal.mouse_position_hook): Likewise.
6911 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6912 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6913 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6914 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6916 * menu.h, termhooks.h: Include "systime.h", for Time.
6918 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6919 Don't assume that the difference between two unsigned long values
6920 can fit into an integer. At this point, we know button_down_time
6921 <= event->timestamp, so the difference must be nonnegative, so
6922 there's no need to cast the result if double-click-time is
6923 nonnegative, as it should be; check that it's nonnegative, just in
6924 case. This bug is triggered when events are more than 2**31 ms
6925 apart (about 25 days). (Bug#8664)
6927 * xselect.c (last_event_timestamp): Remove duplicate decl.
6928 (x_own_selection): Remove needless cast to unsigned long.
6930 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6931 that always fit in int. Use a sentinel instead of a counter, to
6932 avoid a temp and to allay GCC's concerns about possible int overflow.
6933 * frame.h (struct frame): Use int for menu_bar_items_used
6934 instead of EMACS_INT, since it always fits in int.
6936 * menu.c (grow_menu_items): Check for int overflow.
6938 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6940 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6941 Before, the code was not consistent. These values cannot exceed
6942 2**31 - 1 so there's no need to make them unsigned.
6943 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6944 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6945 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6947 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6949 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6950 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6951 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6952 presumably because the widths might not match.
6954 * window.c (size_window): Avoid needless test at loop start.
6956 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6958 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6960 2011-05-12 Drew Adams <drew.adams@oracle.com>
6962 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6964 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6966 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6967 `width' to `bar_area_x' and `bar_area_width', respectively.
6968 (x_scroll_run): Take account of fringe background extension.
6970 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6971 Rename local vars `left' and `width' to `bar_area_x' and
6972 `bar_area_width', respectively.
6973 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6974 background extension.
6976 2011-05-10 Jim Meyering <meyering@redhat.com>
6978 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6980 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6982 * image.c (Finit_image_library): Return t for built-in image types,
6983 like pbm and xbm. (Bug#8640)
6985 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6987 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6989 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6991 * w32console.c (Fset_screen_color): Doc fix.
6992 (Fget_screen_color): New function.
6993 (syms_of_ntterm): Defsubr it.
6995 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6996 unlink the temporary file if Fcall_process didn't create it in the
6998 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6999 child process will be redirected to a file specified with `:file'.
7000 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7001 cue to call_process_cleanup not to close that handle.
7003 2011-05-07 Ben Key <bkey76@gmail.com>
7005 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7006 one of two shell specific rules, either bootstrap-temacs-CMD or
7007 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7008 to the previous implementation of the bootstrap-temacs rule.
7009 The bootstrap-temacs-CMD rule is similar to the previous
7010 implementation of the bootstrap-temacs rule except that it
7011 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7014 These changes, along with some changes to nt/configure.bat,
7015 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7016 earlier fix to add support for --cflags and --ldflags options
7017 that include quotes so that it works whether make uses cmd or
7020 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7022 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7023 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7025 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7026 a string. Handle both cases.
7027 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7028 (Fdbus_register_method): Use Qinvalid_function.
7030 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7032 * makefile.w32-in: Update dependencies.
7033 (LISP_H): Add inttypes.h and stdin.h.
7034 (PROCESS_H): Add unistd.h.
7036 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7038 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7039 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7041 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7043 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7045 * term.c (vfatal): Remove stray call to va_end.
7046 It's not needed and the C Standard doesn't allow it here anyway.
7048 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7049 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7051 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7054 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7056 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7058 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7060 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7062 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7064 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7065 * charset.c (Fdefine_charset_internal): Don't initialize
7066 charset.code_space[15]. The value was garbage, on hosts with
7067 32-bit int (Bug#8600).
7069 * lread.c (read_integer): Be more consistent with string-to-number.
7070 Use string_to_number to do the actual conversion; this avoids
7071 rounding errors and fixes some other screwups. Without this fix,
7072 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7073 (digit_to_number): Move earlier, for benefit of read_integer.
7074 Return -1 if the digit is out of range for the base, -2 if it is
7075 not a digit in any supported base. (Bug#8602)
7077 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7079 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7080 to match comment at start of function. This also removes a
7081 GCC warning about overflow in a 32+64-bit port.
7083 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7085 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7086 Reported by Stefan Monnier in
7087 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7088 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7089 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7091 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7092 (EMACS_UINTPTR): Likewise, with uintptr_t.
7094 * lisp.h: Prefer 64-bit EMACS_INT if available.
7095 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7096 on 32-bit hosts that have 64-bit int, so that they can access
7098 However, temporarily disable this change unless the temporary
7099 symbol WIDE_EMACS_INT is defined.
7101 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7103 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7104 This removes an assumption that EMACS_INT and long are the same
7105 width as pointers. The assumption is true for Emacs porting targets
7106 now, but we want to make other targets possible.
7107 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7108 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7109 In the rest of the code, change types of integers that hold casted
7110 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7111 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7112 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7113 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7114 No need to cast type when ORing.
7115 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7116 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7117 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7118 assume EMACS_INT is the same width as char *.
7119 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7120 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7121 Remove no-longer-needed casts.
7122 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7123 (xg_tool_bar_help_callback, xg_make_tool_item):
7124 Use EMACS_INTPTR to hold an integer
7125 that will be cast to void *; this can avoid a GCC warning
7126 if EMACS_INT is not the same width as void *.
7127 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7128 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7129 (current_message_1, set_message_1):
7130 Use a local to convert to proper width without a cast.
7131 * xmenu.c (dialog_selection_callback): Likewise.
7133 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7134 Also, don't assume VALBITS / RAND_BITS is less than 5,
7135 and don't rely on undefined behavior when shifting a 1 left into
7137 * lisp.h (get_random): Change signature to match.
7139 * lread.c (hash_string): Use size_t, not int, for hash computation.
7140 Normally we prefer signed values; but hashing is special, because
7141 it's better to use unsigned division on hash table sizes so that
7142 the remainder is nonnegative. Also, size_t is the natural width
7143 for hashing into memory. The previous code used 'int', which doesn't
7144 retain enough info to hash well into very large tables.
7145 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7147 * dbusbind.c: Don't possibly lose pointer info when converting.
7148 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7149 Use XPNTR rather than XHASH, so that the high-order bits of
7150 the pointer aren't lost when converting through void *.
7152 * eval.c (Fautoload): Don't double-shift a pointer.
7154 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7156 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7158 * gnutls.c (DEF_GNUTLS_FN):
7159 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7161 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7163 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7166 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7168 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7169 New version that can reserve upto 2GB of heap space.
7171 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7173 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7175 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7177 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7178 `gnutls_certificate_set_x509_key_file'.
7180 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7182 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7183 Update dependencies.
7185 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7187 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7188 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7189 Remove unused parameter `fildes'.
7190 * process.c (read_process_output, send_process): Don't pass it.
7192 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7194 Fix previous change: the library cache is defined in w32.c.
7195 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7196 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7198 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7200 Implement dynamic loading of GnuTLS on Windows.
7202 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7203 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7204 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7207 * gnutls.c (Qgnutls_dll): Define.
7208 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7209 (gnutls_*): Declare function pointers.
7210 (init_gnutls_functions): New function to initialize function pointers.
7211 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7212 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7213 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7214 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7215 (emacs_gnutls_write, emacs_gnutls_read)
7216 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7217 (Fgnutls_available_p): New function.
7218 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7219 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7220 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7222 * image.c: Include w32.h.
7223 (Vimage_type_cache): Delete.
7224 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7225 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7226 (w32_delayed_load): Move to w32.c.
7228 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7230 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7231 (w32_delayed_load): Move from image.c. When loading a library, record
7232 its filename in the :loaded-from property of the library id.
7233 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7234 Initialize and staticpro them.
7235 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7237 * process.c: Include lisp.h before w32.h, not after.
7238 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7239 instead of gnutls_record_check_pending.
7241 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7243 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7245 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7246 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7249 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7251 * xterm.c (x_set_frame_alpha): Do not set property on anything
7252 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7254 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7256 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7258 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7260 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7261 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7262 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7263 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7264 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7265 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7266 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7267 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7268 (Qgnutls_bootprop_callbacks_verify): Make static.
7270 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7272 * callproc.c: Indentation fixup.
7274 * sysdep.c (wait_for_termination_1): Make static.
7275 (wait_for_termination, interruptible_wait_for_termination):
7276 Move after wait_for_termination_1.
7278 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7280 * sysdep.c (interruptible_wait_for_termination): New function
7281 which is like wait_for_termination, but allows keyboard
7284 * callproc.c (Fcall_process): Add (:file "file") as an option for
7286 (Fcall_process_region): Ditto.
7288 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7290 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7291 rather than `XVECTOR (FOO)->size'.
7293 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7294 inttypes.h, as a gnulib replacement is used if it not available in
7297 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7299 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7300 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7301 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7303 * coding.c (coding_alloc_by_realloc): Error out if destination
7304 will grow beyond MOST_POSITIVE_FIXNUM.
7305 (decode_coding_emacs_mule): Abort if there isn't enough place in
7306 charbuf for the composition carryover bytes. Reserve an extra
7307 space for up to 2 characters produced in a loop.
7308 (decode_coding_iso_2022): Abort if there isn't enough place in
7309 charbuf for the composition carryover bytes.
7311 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7313 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7314 aborting when %lld or %lll format is passed.
7315 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7316 %llo or %llx format is passed. (Bug#8545)
7318 * window.c (window_scroll_line_based): Use a marker instead of
7319 simple variables to record original value of point. (Bug#7952)
7321 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7322 produced by %s or %c overflows available buffer space. (Bug#8545)
7324 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7326 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7327 (SIZE_MAX): Move defn after all includes, as they might #define it.
7329 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7331 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7333 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7335 * keyboard.c (Qdelayed_warnings_hook): Define.
7336 (command_loop_1): Run `delayed-warnings-hook'
7337 if Vdelayed_warnings_list is non-nil.
7338 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7339 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7341 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7343 * doprnt.c (doprnt): Don't return value smaller than the buffer
7344 size if the message was truncated. (Bug#8545).
7346 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7348 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7349 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7351 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7353 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7355 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7357 * makefile.w32-in: Update dependencies.
7359 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7361 Improve `doprnt' and its usage. (Bug#8545)
7362 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7363 `format_end'. Remove support for %l as a conversion specifier.
7364 Don't use xrealloc. Improve diagnostics when the %l size modifier
7365 is used. Update the commentary.
7367 * eval.c (verror): Simplify calculation of size_t.
7369 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7372 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7374 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7377 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7379 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7380 This makes this file independent of the recent pseudovector change.
7382 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7384 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7386 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7387 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7388 Remove unused local.
7389 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7391 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7392 GCC 4.6.0 optimizes based on type-based alias analysis.
7393 For example, if b is of type struct buffer * and v of type struct
7394 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7395 != &v->size, and therefore "v->size = 1; b->size = 2; return
7396 v->size;" must therefore return 1. This assumption is incorrect
7397 for Emacs, since it type-puns struct Lisp_Vector * with many other
7398 types. To fix this problem, this patch adds a new type struct
7399 vectorlike_header that documents the constraints on layout of vectors
7400 and pseudovectors, and helps optimizing compilers not get fooled
7401 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7402 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7403 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7405 (XSETPVECTYPE): Rewrite in terms of new macro.
7406 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7407 This is a bit clearer, and further avoids the possibility of
7408 undesirable aliasing.
7409 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7410 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7411 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7412 since Lisp_Subr is a special case (no "next" field).
7413 (ASIZE): Now uses header.size rather than size.
7414 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7415 to avoid the hassle of writing XVECTOR (foo)->header.size.
7416 (struct vectorlike_header): New type.
7417 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7418 object, to help avoid aliasing.
7419 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7420 (SUBRP): Likewise, since Lisp_Subr is a special case.
7421 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7422 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7423 (struct Lisp_Hash_Table): Combine first two members into a single
7424 struct vectorlike_header member. All uses of "size" and "next" members
7425 changed to be "header.size" and "header.next".
7426 * buffer.h (struct buffer): Likewise.
7427 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7428 * frame.h (struct frame): Likewise.
7429 * process.h (struct Lisp_Process): Likewise.
7430 * termhooks.h (struct terminal): Likewise.
7431 * window.c (struct save_window_data, struct saved_window): Likewise.
7432 * window.h (struct window): Likewise.
7433 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7434 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7435 * buffer.c (init_buffer_once): Likewise.
7436 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7438 * process.c (Fformat_network_address): Use local var for size,
7441 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7443 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7444 * data.c (atof): Remove decl; no longer used or needed.
7445 (digit_to_number): Move to lread.c.
7446 (Fstring_to_number): Use new string_to_number function, to be
7447 consistent with how the Lisp reader treats infinities and NaNs.
7448 Do not assume that floating-point numbers represent EMACS_INT
7449 without losing information; this is not true on most 64-bit hosts.
7450 Avoid double-rounding errors, by insisting on integers when
7451 parsing non-base-10 numbers, as the documentation specifies.
7452 * lisp.h (string_to_number): New decl, replacing ...
7453 (isfloat_string): Remove.
7454 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7455 (read1): Do not accept +. and -. as integers; this
7456 appears to have been a coding error. Similarly, do not accept
7457 strings like +-1e0 as floating point numbers. Do not report
7458 overflow for integer overflows unless the base is not 10 which
7459 means we have no simple and reliable way to continue.
7460 Break out the floating-point parsing into a new
7461 function string_to_number, so that Fstring_to_number parses
7462 floating point numbers consistently with the Lisp reader.
7463 (digit_to_number): Move here from data.c. Make it static inline.
7464 (E_CHAR, EXP_INT): Remove, replacing with ...
7465 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7466 (string_to_number): New function, replacing isfloat_string.
7467 This function checks for valid syntax and produces the resulting
7468 Lisp float number too. Rework it so that string-to-number
7469 no longer mishandles examples like "1.0e+". Use strtoumax,
7470 so that overflow for non-base-10 numbers is reported only when
7471 there's no portable and simple way to convert to floating point.
7473 * textprop.c (set_text_properties_1): Rewrite for clarity,
7474 and to avoid GCC warning about integer overflow.
7476 * intervals.h (struct interval): Use EMACS_INT for members
7477 where EMACS_UINT might cause problems. See
7478 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7479 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7480 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7482 (offset_intervals): Tell GCC not to worry about length overflow
7483 when negating a negative length.
7485 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7486 (overrun_check_free): Likewise.
7488 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7489 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7492 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7493 (gnutls_make_error): Rename local to avoid shadowing.
7494 (gnutls_emacs_global_deinit): ifdef out; not used.
7495 (Fgnutls_boot): Use const for pointer to readonly storage.
7496 Comment out unused local. Fix pointer signedness problems.
7498 * lread.c (openp): Don't stuff size_t into an 'int'.
7499 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7500 about possible signed overflow.
7502 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7503 (GDK_KEY_g): Don't define if already defined.
7504 (xg_prepare_tooltip): Avoid pointer signedness problem.
7505 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7507 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7508 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7510 * xfns.c (Fx_window_property): Simplify a bit,
7511 to make a bit faster and to avoid GCC 4.6.0 warning.
7512 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7514 * fns.c (internal_equal): Don't assume size_t fits in int.
7516 * alloc.c (compact_small_strings): Tighten assertion a little.
7518 Replace pEd with more-general pI, and fix some printf arg casts.
7519 * lisp.h (pI): New macro, generalizing old pEd macro to other
7520 conversion specifiers. For example, use "...%"pI"d..." rather
7521 than "...%"pEd"...".
7522 (pEd): Remove. All uses replaced with similar uses of pI.
7523 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7524 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7525 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7526 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7527 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7528 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7529 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7531 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7532 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7533 * print.c (safe_debug_print, print_object): Likewise.
7534 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7536 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7537 avoiding the 0 flag, which is not portable.
7538 * process.c (Fmake_network_process): Use pI to avoid cast.
7539 * region-cache.c (pp_cache): Likewise.
7540 * xdisp.c (decode_mode_spec): Likewise.
7541 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7542 behavior on 64-bit hosts with printf arg.
7543 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7544 (x_stop_queuing_selection_requests): Likewise.
7545 (x_get_window_property): Don't truncate byte count to an 'int'
7548 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7549 here, since it parses constructs like leading '-' and spaces,
7550 which are not wanted; and it overflows with large numbers.
7551 Instead, simply match F[0-9]+, which is what is wanted anyway.
7553 * alloc.c: Remove unportable assumptions about struct layout.
7554 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7555 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7556 (allocate_vectorlike, make_pure_vector): Use the new macros,
7557 plus offsetof, to remove unportable assumptions about struct layout.
7558 These assumptions hold on all porting targets that I know of, but
7559 they are not guaranteed, they're easy to remove, and removing them
7560 makes further changes easier.
7562 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7563 This doesn't fix a bug but makes the code clearer.
7564 (string_overrun_cookie): Now const. Use initializers that
7565 don't formally overflow signed char, to avoid warnings.
7566 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7567 can cause Emacs to crash when string overrun checking is enabled.
7568 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7569 multiple of sizeof (EMACS_INT); it need not be, if
7570 alignof(EMACS_INT) < sizeof (EMACS_INT).
7571 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7573 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7575 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7577 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7579 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7580 supposed to be handshaking. (Bug#8556)
7581 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7583 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7585 * lisp.h (Qdebug): List symbol.
7586 * eval.c (Qdebug): Restore global linkage.
7587 * keyboard.c (debug-on-event): New variable.
7588 (handle_user_signal): Break into debugger when debug-on-event
7589 matches the current signal symbol.
7591 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7593 * alloc.c (check_sblock, check_string_bytes)
7594 (check_string_free_list): Convert to standard C.
7596 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7598 * w32.c (emacs_gnutls_push): Fix typo.
7600 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7602 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7603 "cast to pointer from integer of different size".
7605 Improve doprnt and its use in verror. (Bug#8545)
7606 * doprnt.c (doprnt): Document the set of format control sequences
7607 supported by the function. Use SAFE_ALLOCA instead of always
7610 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7611 is one byte too soon. Don't use xrealloc; instead xfree and
7614 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7616 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7619 * gnutls.c: Renamed global_initialized to
7620 gnutls_global_initialized. Added internals for the
7621 :verify-hostname-error, :verify-error, and :verify-flags
7622 parameters of `gnutls-boot' and documented those parameters in the
7623 docstring. Start callback support.
7624 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7625 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7626 on error. Return error code.
7627 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7628 (emacs_gnutls_read): Likewise.
7629 (Fgnutls_boot): Return handshake error code.
7630 (emacs_gnutls_handle_error): New function.
7631 (wsaerror_to_errno): Likewise.
7633 * w32.h (emacs_gnutls_pull): Add prototype.
7634 (emacs_gnutls_push): Likewise.
7636 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7637 (emacs_gnutls_push): Likewise.
7639 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7641 * process.c (wait_reading_process_output): Check if GnuTLS
7642 buffered some data internally if no FDs are set for TLS
7645 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7646 (LIBS): Link to USER_LIBS.
7647 ($(BLD)/gnutls.$(0)): New target.
7649 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7651 * xdisp.c (handle_single_display_spec): Rename the
7652 display_replaced_before_p argument into display_replaced_p, to
7653 make it consistent with the commentary. Fix typos in the
7656 * textprop.c (syms_of_textprop): Remove dead code.
7657 (copy_text_properties): Delete obsolete commentary about an
7658 interface that was deleted long ago. Fix typos in the description
7661 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7662 to changes in oldXMenu/XMenu.h from 2011-04-16.
7663 <menu_help_message, prev_menu_help_message>: Constify.
7664 (IT_menu_make_room): menu->help_text is now `const char **';
7667 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7668 to changes in oldXMenu/XMenu.h from 2011-04-16.
7669 (struct XMenu): Declare `help_text' `const char **'.
7671 * xfaces.c <Qunspecified>: Make extern again.
7673 * syntax.c: Include sys/types.h before including regex.h, as
7676 * doc.c (get_doc_string): Improve the format passed to `error'.
7678 * doprnt.c (doprnt): Improve commentary.
7680 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7682 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7685 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7686 changes in globals.h immediately force recompilation.
7687 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7688 $(CURDIR)/s/ms-w32.h.
7689 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7691 * character.c (Fchar_direction): Function deleted.
7692 (syms_of_character): Don't defsubr it.
7693 <char-direction-table>: Deleted.
7695 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7697 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7698 * doprnt.c: Include limits.h.
7699 (SIZE_MAX): New macro.
7700 (doprnt): Return a size_t value. 2nd arg is now size_t.
7701 Many local variables are now size_t instead of int or unsigned.
7702 Improve overflow protection. Support `l' modifier for integer
7703 conversions. Support %l conversion. Don't assume an EMACS_INT
7704 argument for integer conversions and for %c.
7706 * lisp.h (doprnt): Restore prototype.
7708 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7711 * Makefile.in (base_obj): Add back doprnt.o.
7713 * deps.mk (doprnt.o): Add back prerequisites.
7714 (callint.o): Depend on character.h.
7716 * eval.c (internal_lisp_condition_case): Include the handler
7717 representation in the error message.
7718 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7719 when breaking from the loop.
7721 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7723 * callint.c (Fcall_interactively): When displaying error message
7724 about invalid control letter, pass the character's codepoint, not
7725 a pointer to its multibyte form. Improve display of the character
7726 in octal and display also its hex code.
7728 * character.c (char_string): Use %x to display the (unsigned)
7729 codepoint of an invalid character, to avoid displaying a bogus
7732 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7733 `error', not SYMBOL_NAME itself.
7735 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7736 character arguments to `error'.
7738 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7739 to `error' in error message about FINAL_CHAR argument. Make sure
7740 FINAL_CHAR is a character, and use %c when it is passed as
7741 argument to `error'.
7743 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7745 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7747 * w32.c: Include <time.h>.
7748 (sys_localtime): New function.
7750 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7752 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7754 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7756 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7758 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7761 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7763 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7764 gl_state.e_property when gl_state.object is Qt.
7766 * insdel.c (make_gap_larger): Remove limitation of buffer size
7769 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7771 * xdisp.c (lookup_glyphless_char_display)
7772 (produce_glyphless_glyph): Handle cons cell entry in
7773 glyphless-char-display.
7774 (Vglyphless_char_display): Document it.
7776 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7777 glyphless-char-display.
7779 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7781 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7783 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7785 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7786 definition for no-X builds.
7788 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7790 Static checks with GCC 4.6.0 and non-default toolkits.
7792 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7794 * process.c (keyboard_bit_set): Define only if SIGIO.
7795 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7796 (send_process): Repair possible setjmp clobbering.
7798 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7800 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7802 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7804 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7805 Define only if needed.
7807 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7808 by pacifying GCC about it. Maybe it's time to retire it?
7809 * xfaces.c (USG, __TIMEVAL__): Likewise.
7811 * dispextern.h (struct redisplay_interface): Rename param
7813 * termhooks.h (struct terminal): Likewise.
7814 * xterm.c (xembed_send_message): Likewise.
7816 * insdel.c (make_gap_smaller): Define only if
7817 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7819 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7822 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7823 so that we aren't warned about unused symbols.
7825 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7827 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7829 * xfns.c (x_real_positions): Mark locals as initialized.
7831 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7833 * xterm.c: Fix problems found by static analysis with other toolkits.
7834 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7835 (x_dispatch_event): Declare static if USE_GTK, and
7836 define if USE_GTK || USE_X_TOOLKIT.
7837 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7838 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7839 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7840 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7842 * xmenu.c (menu_help_callback): Pointer type fixes.
7843 Use const pointers when pointing at readonly data. Avoid pointer
7845 (FALSE): Remove unused macro.
7846 (update_frame_menubar): Remove unused decl.
7848 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7850 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7851 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7852 (single_menu_item): Rename local to avoid shadowing.
7854 * keyboard.c (make_lispy_event): Remove unused local var.
7856 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7857 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7859 * bitmaps: Change bitmaps from unsigned char back to the X11
7860 compatible char. Avoid the old compiler warnings about
7861 out-of-range initializers by using, for example, '\xab' rather
7864 * xgselect.c (xgselect_initialize): Check vs interface
7865 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7867 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7869 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7870 to read-only memory.
7872 * fns.c (vector): Remove; this old hack is no longer needed.
7874 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7876 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7878 * xrdb.c (x_load_resources): Omit unused local.
7880 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7881 (x_window): Rename locals to avoid shadowing.
7882 (USG): Use the kludged USG macro, to pacify gcc.
7884 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7885 (x_term_init): Remove local to avoid shadowing.
7887 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7889 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7890 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7892 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7894 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7896 Fix regex.c, syntax.c and friends for buffers > 2GB.
7897 * syntax.h (struct gl_state_s): Declare character position members
7900 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7902 * textprop.c (verify_interval_modification, interval_of):
7903 Declare arguments EMACS_INT.
7905 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7908 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7910 * indent.c (Fvertical_motion): Local variable it_start is now
7913 * regex.c (re_match, re_match_2, re_match_2_internal)
7914 (bcmp_translate, regcomp, regexec, print_double_string)
7915 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7916 (re_compile_pattern, re_exec): Declare arguments and local
7917 variables `size_t' and `ssize_t' and return values `regoff_t', as
7919 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7920 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7921 <compile_stack_type>: `size' and `avail' are now `size_t'.
7923 * regex.h <regoff_t>: Use ssize_t, not int.
7924 (re_search, re_search_2, re_match, re_match_2): Arguments that
7925 specify buffer/string position and length are now ssize_t and
7926 size_t. Return type is regoff_t.
7928 2011-04-16 Ben Key <bkey76@gmail.com>
7930 * nsfont.m: Fixed bugs in ns_get_family and
7931 ns_descriptor_to_entity that were caused by using free to
7932 deallocate memory blocks that were allocated by xmalloc (via
7933 xstrdup). This caused Emacs to crash when compiled with
7934 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7935 --enable-checking=xmallocoverrun). xfree is now used to
7936 deallocate these memory blocks.
7938 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7940 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7942 emacs_write: Accept and return EMACS_INT for sizes.
7943 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7945 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7946 Accept and return EMACS_INT.
7947 (emacs_gnutls_write): Return the number of bytes written on
7949 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7950 (emacs_read, emacs_write): Remove check for negative size, as the
7951 Emacs source code has been audited now.
7952 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7953 (emacs_read, emacs_write): Use it.
7954 * process.c (send_process): Adjust to the new signatures of
7955 emacs_write and emacs_gnutls_write. Do not attempt to store
7956 a byte offset into an 'int'; it might overflow.
7957 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7959 * sound.c: Don't assume sizes fit in 'int'.
7960 (struct sound_device.period_size, alsa_period_size):
7961 Return EMACS_INT, not int.
7962 (struct sound_device.write, vox_write, alsa_write):
7963 Accept EMACS_INT, not int.
7964 (wav_play, au_play): Use EMACS_INT to store sizes and to
7965 record read return values.
7967 2011-04-15 Ben Key <bkey76@gmail.com>
7969 * keyboard.c (Qundefined): Don't declare static since it is used
7971 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7972 static since they are used in nsfont.m.
7974 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7976 * process.c (Qprocessp): Don't declare static.
7977 * lisp.h (Qprocessp): Declare again.
7979 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7981 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7983 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7985 Improve C-level modularity by making more things 'static'.
7987 Don't publish debugger-only interfaces to other modules.
7988 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7989 (verify_bytepos, count_markers): Move decls to the only modules
7991 * region-cache.h (pp_cache): Likewise.
7992 * window.h (check_all_windows): Likewise.
7993 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7995 * sysdep.c (croak): Now static, if
7996 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7997 * syssignal.h (croak): Declare only if not static.
7999 * alloc.c (refill_memory_reserve): Now static if
8000 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8001 * lisp.h (refill_memory_reserve): Declare only if not static.
8003 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8004 Define only if USE_LUCID.
8006 * xrdb.c (x_customization_string, x_rm_string): Now static.
8008 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8009 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8011 * xdisp.c (draw_row_with_mouse_face): Now static.
8012 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8014 * window.h (check_all_windows): Mark externally visible.
8016 * window.c (window_deletion_count): Now static.
8018 * undo.c: Make symbols static if they're not exported.
8019 (last_undo_buffer, last_boundary_position, pending_boundary):
8022 * textprop.c (interval_insert_behind_hooks): Now static.
8023 (interval_insert_in_front_hooks): Likewise.
8025 * term.c: Make symbols static if they're not exported.
8026 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8027 (max_frame_lines, tty_set_terminal_modes):
8028 (tty_reset_terminal_modes, tty_turn_off_highlight):
8029 (get_tty_terminal): Now static.
8030 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8031 * termhooks.h (term_mouse_moveto): Do not declare if
8033 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8034 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8036 * sysdep.c: Make symbols static if they're not exported.
8037 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8039 (sigprocmask_set, full_mask): Remove; unused.
8040 (wait_debugging): Mark as visible.
8041 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8042 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8044 * syntax.c (syntax_temp): Define only if !__GNUC__.
8046 * sound.c (current_sound_device, current_sound): Now static.
8048 * search.c (searchbufs, searchbuf_head): Now static.
8050 * scroll.c (scroll_cost): Remove; unused.
8051 * dispextern.h (scroll_cost): Remove decl.
8053 * region-cache.h (pp_cache): Mark as externally visible.
8055 * process.c: Make symbols static if they're not exported.
8056 (process_tick, update_tick, create_process, chan_process):
8057 (Vprocess_alist, proc_buffered_char, datagram_access):
8058 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8059 (deactivate_process): Mark defn as static, as well as decl.
8060 * lisp.h (create_process): Remove decl.
8061 * process.h (chan_process, Vprocess_alist): Remove decls.
8063 * print.c: Make symbols static if they're not exported.
8064 (print_depth, new_backquote_output, being_printed, print_buffer):
8065 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8066 (print_interval, print_number_index, initial_stderr_stream):
8068 * lisp.h (Fprinc): Remove decl.
8069 (debug_output_compilation_hack): Mark as externally visible.
8071 * sysdep.c (croak): Move decl from here to syssignal.h.
8072 * syssignal.h (croak): Put it here, so the API can be checked when
8073 'croak' is called from dissociate_if_controlling_tty.
8075 * minibuf.c: Make symbols static if they're not exported.
8076 (minibuf_save_list, choose_minibuf_frame): Now static.
8077 * lisp.h (choose_minibuf_frame): Remove decl.
8079 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8081 * lread.c: Make symbols static if they're not exported.
8082 (read_objects, initial_obarray, oblookup_last_bucket_number):
8084 (make_symbol): Remove; unused.
8085 * lisp.h (initial_obarray, make_symbol): Remove decls.
8087 * keyboard.c: Make symbols static if they're not exported.
8088 (single_kboard, recent_keys_index, total_keys, recent_keys):
8089 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8090 (this_single_command_key_start, echoing, last_auto_save):
8091 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8092 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8093 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8094 (Vlispy_mouse_stem, double_click_count):
8096 (force_auto_save_soon): Define only if SIGDANGER.
8097 (ignore_mouse_drag_p): Now static if
8098 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8099 (print_help): Remove; unused.
8100 (stop_character, last_timer_event): Mark as externally visible.
8101 * keyboard.h (ignore_mouse_drag_p): Declare only if
8102 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8103 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8104 * lisp.h (echoing): Remove decl.
8105 (force_auto_save_soon): Declare only if SIGDANGER.
8106 * xdisp.c (redisplay_window): Simplify code, to make it more
8107 obvious that ignore_mouse_drag_p is not accessed if !defined
8108 USE_GTK && !defined HAVE_NS.
8110 * intervals.c: Make symbols static if they're not exported.
8111 (merge_properties_sticky, merge_interval_right, delete_interval):
8113 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8115 * insdel.c: Make symbols static if they're not exported.
8116 However, leave prepare_to_modify_buffer alone. It's never
8117 called from outside this function, but that appears to be a bug.
8118 (combine_after_change_list, combine_after_change_buffer):
8119 (adjust_after_replace, signal_before_change): Now static.
8120 (adjust_after_replace_noundo): Remove; unused.
8121 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8122 (signal_before_change): Remove decls.
8124 * indent.c (val_compute_motion, val_vmotion): Now static.
8126 * image.c: Make symbols static if they're not exported.
8127 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8129 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8130 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8132 * fringe.c (standard_bitmaps): Now static.
8133 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8135 * frame.c: Make symbols static if they're not exported.
8136 (x_report_frame_params, make_terminal_frame): Now static.
8137 (get_frame_param): Now static, unless HAVE_NS.
8138 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8139 (x_get_resource_string): Remove; not used.
8140 * frame.h (make_terminal_frame, x_report_frame_params):
8141 (x_get_resource_string); Remove decls.
8142 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8143 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8145 * font.c, fontset.c: Make symbols static if they're not exported.
8146 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8147 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8148 * font.c (font_close_object): Now static.
8149 * font.h (font_close_object): Remove.
8150 * fontset.c (FONTSET_OBJLIST): Remove.
8151 (free_realized_fontset) #if-0 the body, which does nothing.
8152 (face_suitable_for_char_p): #if-0, as it's never called.
8153 * fontset.h (face_suitable_for_char_p): Remove decl.
8154 * xfaces.c (face_at_string_position):
8155 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8156 since 0 is always ASCII.
8158 * fns.c (weak_hash_tables): Now static.
8160 * fileio.c: Make symbols static if they're not exported.
8161 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8162 (Vwrite_region_annotation_buffers): Now static.
8164 * eval.c: Make symbols static if they're not exported.
8165 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8166 * lisp.h (backtrace_list): Remove decl.
8168 * emacs.c: Make symbols static if they're not exported.
8169 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8170 (fatal_error_code, fatal_error_signal_hook, standard_args):
8172 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8173 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8174 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8175 * lisp.h (fatal_error_signal_hook): Remove decl.
8176 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8178 * editfns.c: Move a (normally-unused) function to its only use.
8179 * editfns.c, lisp.h (get_operating_system_release): Remove.
8180 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8181 worth the hassle of breaking this out.
8183 * xterm.c: Make symbols static if they're not exported.
8184 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8185 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8186 (x_destroy_window, x_delete_display):
8188 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8189 (x_mouse_leave): Remove; unused.
8190 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8191 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8192 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8194 (x_mouse_leave): Declare only if WINDOWSNT.
8195 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8196 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8199 * ftxfont.c: Make symbols static if they're not exported.
8200 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8202 * font.h (ftxfont_driver): Likewise.
8204 * xfns.c: Make symbols static if they're not exported.
8205 (x_last_font_name, x_display_info_for_name):
8206 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8207 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8208 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8209 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8210 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8211 (last_show_tip_args): Now static.
8212 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8213 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8214 (x_screen_planes): Remove; unused.
8215 * dispextern.h (x_screen_planes): Remove decl.
8217 * dispnew.c: Make symbols static if they're not exported.
8218 * dispextern.h (redraw_garbaged_frames, scrolling):
8219 (increment_row_positions): Remove.
8220 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8221 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8223 (redraw_garbaged_frames): Remove; unused.
8225 * xfaces.c: Make symbols static if they're not exported.
8226 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8228 * xterm.h (defined_color): Remove decls.
8229 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8230 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8231 (menu_face_changed_default, defined_color, free_realized_face):
8232 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8233 (ascii_face_of_lisp_face): Remove; unused.
8235 * xdisp.c: Make symbols static if they're not exported.
8236 * dispextern.h (scratch_glyph_row, window_box_edges):
8237 (glyph_to_pixel_coords, set_cursor_from_row):
8238 (get_next_display_element, set_iterator_to_next):
8239 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8240 (show_mouse_face): Remove decls
8241 * frame.h (message_buf_print): Likewise.
8242 * lisp.h (pop_message, set_message, check_point_in_composition):
8244 * xterm.h (set_vertical_scroll_bar): Likewise.
8245 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8246 (message_buf_print, scratch_glyph_row, displayed_buffer):
8247 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8248 (get_next_display_element, show_mouse_face, window_box_edges):
8249 (frame_to_window_pixel_xy, check_point_in_composition):
8250 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8251 (glyph_to_pixel_coords): Remove; unused.
8253 * dired.c (file_name_completion): Now static.
8255 * dbusbind.c (xd_in_read_queued_messages): Now static.
8257 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8258 * data.c (circular_list_error): Remove.
8260 * commands.h (last_point_position, last_point_position_buffer):
8261 (last_point_position_window): Remove decls.
8262 * keyboard.c: Make these variables static.
8264 * coding.h (coding, code_convert_region, encode_coding_gap):
8266 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8267 (iso_code_class, detect_coding, code_convert_region): Now static.
8268 (encode_coding_gap): Remove; unused.
8270 * chartab.c (chartab_chars, chartab_bits): Now static.
8272 * charset.h (charset_iso_8859_1): Remove decl.
8273 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8276 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8277 * ccl.c (Vccl_program_table): Now static.
8278 (check_ccl_update): Remove; unused.
8280 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8281 * category.h: ... from here.
8282 * category.c (check_category_table, set_category_set): Now static.
8284 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8285 * lisp.h: Remove these decls.
8287 * buffer.c (buffer_count): Remove unused var.
8289 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8290 so that it's not optimized away.
8291 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8292 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8293 exported only to the debugger.
8295 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8296 * atimer.h (run_all_atimers): Remove; not exported.
8298 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8299 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8300 was inaccessible from Lisp.
8301 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8302 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8304 alloc.c: Import and export fewer symbols, and remove unused items.
8305 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8307 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8308 it's not optimized away by whole-program optimization.
8309 (message_enable_multibyte, free_misc): Remove.
8310 (catchlist, handlerlist, mark_backtrace):
8311 Declare only if BYTE_MARK_STACK.
8312 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8313 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8314 (message_enable_multibyte): Remove decl.
8315 (free_misc, interval_free_list, float_block, float_block_index):
8316 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8317 (cons_free_list, last_marked_index):
8319 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8320 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8321 (mark_backtrace): Define only if BYTE_MARK_STACK.
8322 * xdisp.c (message_enable_multibyte): Now static.
8324 Declare Lisp_Object Q* variables to be 'static' if not exported.
8325 This makes it easier for human readers (and static analyzers)
8326 to see whether these variables are used from other modules.
8327 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8328 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8329 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8330 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8331 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8332 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8333 * xmenu.c, xselect.c:
8334 Declare Q* vars static if they are not used in other modules.
8335 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8336 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8337 Remove decls of unexported vars.
8338 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8340 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8342 Make Emacs functions such as Fatom 'static' by default.
8343 This makes it easier for human readers (and static analyzers)
8344 to see whether these functions can be called from other modules.
8345 DEFUN now defines a static function. To make the function external
8346 so that it can be used in other C modules, use the new macro DEFUE.
8347 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8348 (Finit_image_library):
8349 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8350 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8351 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8352 Remove decls, since these functions are now static.
8353 (Funintern, Fget_internal_run_time): New decls, since these functions
8354 were already external.
8356 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8357 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8358 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8359 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8360 * keyboard.c, keymap.c, lread.c:
8361 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8362 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8363 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8364 Mark functions with DEFUE instead of DEFUN,
8365 if they are used in other modules.
8366 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8367 decls for now-static functions.
8368 * buffer.h (Fdelete_overlay): Remove decl.
8369 * callproc.c (Fgetenv_internal): Mark as internal.
8370 * composite.c (Fremove_list_of_text_properties): Remove decl.
8371 (Fcomposition_get_gstring): New forward static decl.
8372 * composite.h (Fcomposite_get_gstring): Remove decl.
8373 * dired.c (Ffile_attributes): New forward static decl.
8374 * doc.c (Fdocumntation_property): New forward static decl.
8375 * eval.c (Ffetch_bytecode): New forward static decl.
8376 (Funintern): Remove extern decl; now in .h file where it belongs.
8377 * fileio.c (Fmake_symbolic_link): New forward static decl.
8378 * image.c (Finit_image_library): New forward static decl.
8379 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8380 * intervals.h (Fprevious_property_change):
8381 (Fremove_list_of_text_properties): Remove decls.
8382 * keyboard.c (Fthis_command_keys): Remove decl.
8383 (Fcommand_execute): New forward static decl.
8384 * keymap.c (Flookup_key): New forward static decl.
8385 (Fcopy_keymap): Now static.
8386 * keymap.h (Flookup_key): Remove decl.
8387 * process.c (Fget_process): New forward static decl.
8388 (Fprocess_datagram_address): Mark as internal.
8389 * syntax.c (Fsyntax_table_p): New forward static decl.
8390 (skip_chars): Remove duplicate decl.
8391 * textprop.c (Fprevious_property_change): New forward static decl.
8392 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8394 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8395 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8397 * editfns.c (Fformat): Remove unreachable code.
8399 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8401 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8404 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8406 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8407 when at ZV. (Bug#8487)
8409 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8411 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8413 * keyboard.c (parse_tool_bar_item): Likewise.
8414 * sound.c (sound_cleanup, alsa_close): Likewise.
8415 * termcap.c (tgetent): Likewise.
8416 * xfns.c (x_default_font_parameter): Likewise.
8417 * xsettings.c (read_and_apply_settings): Likewise.
8419 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8420 (overrun_check_free): Protoize.
8422 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8424 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8425 since callers should never pass a negative size.
8426 Change the signature to match that of plain 'read' and 'write'; see
8427 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8428 * lisp.h: Update prototypes of emacs_write and emacs_read.
8430 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8432 * xdisp.c (redisplay_window): Don't try to determine the character
8433 position of the scroll margin if the window start point w->startp
8434 is outside the buffer's accessible region. (Bug#8468)
8436 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8438 Fix write-region and its subroutines for buffers > 2GB.
8439 * fileio.c (a_write, e_write): Modify declaration of arguments and
8440 local variables to support buffers larger than 2GB.
8441 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8443 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8444 argument, local variables, and return value.
8446 * lisp.h: Update prototypes of emacs_write and emacs_read.
8448 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8450 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8452 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8454 Fix more problems found by GCC 4.6.0's static checks.
8456 * xdisp.c (vmessage): Use a better test for character truncation.
8458 * charset.c (load_charset_map): <, not <=, for optimization,
8459 and to avoid potential problems with integer overflow.
8460 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8461 * casetab.c (set_identity, shuffle): Likewise.
8462 * editfns.c (Fformat): Likewise.
8463 * syntax.c (skip_chars): Likewise.
8465 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8466 This also lets GCC 4.6.0 generate slightly better loop code.
8468 * callint.c (Fcall_interactively): <, not <=, for optimization.
8469 (Fcall_interactively): Count the number of arguments produced,
8470 not the number of arguments given. This is simpler and lets GCC
8471 4.6.0 generate slightly better code.
8473 * ftfont.c: Distingish more carefully between FcChar8 and char.
8474 The previous code passed unsigned char * to a functions like
8475 strlen and xstrcasecmp that expect char *, which does not
8476 conform to the C standard.
8477 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8478 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8479 char * when the C standard requires it.
8481 * keyboard.c (read_char): Remove unused var.
8483 * eval.c: Port to Windows vsnprintf (Bug#8435).
8485 (SIZE_MAX): Define if the headers do not.
8486 (verror): Do not give up if vsnprintf returns a negative count.
8487 Instead, grow the buffer. This ports to Windows vsnprintf, which
8488 does not conform to C99. Problem reported by Eli Zaretskii.
8489 Also, simplify the allocation scheme, by avoiding the need for
8490 calling realloc, and removing the ALLOCATED variable.
8492 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8494 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8495 But keep the doprint source code for now, as we might revamp it
8496 and use it again (Bug#8435).
8497 * lisp.h (doprnt): Remove.
8498 * Makefile.in (base_obj): Remove doprnt.o.
8499 * deps.mk (doprnt.o): Remove.
8501 error: Print 32- and 64-bit integers portably (Bug#8435).
8502 Without this change, on typical 64-bit hosts error ("...%d...", N)
8503 was used to print both 32- and 64-bit integers N, which relied on
8505 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8506 * lisp.h (error, verror): Mark as printf-like functions.
8507 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8508 Report overflow in size calculations when allocating printf buffer.
8509 Do not truncate output string at its first null byte.
8510 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8511 Truncate the output at a character boundary, since vsnprintf does not
8513 * charset.c (check_iso_charset_parameter): Convert internal
8514 character to string before calling 'error', since %c now has the
8516 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8517 overflow when computing char to be passed to 'error'. Do not
8518 pass Lisp_Object to 'error'; pass the integer instead.
8519 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8520 formatted with plain %d.
8522 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8524 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8526 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8528 * xterm.c (x_catch_errors): Remove duplicate declaration.
8530 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8532 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8534 2011-04-10 Jim Meyering <meyering@redhat.com>
8536 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8537 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8538 return ssize_t not "int", and use size_t as the buffer length.
8539 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8540 * gnutls.h: Update declarations.
8541 * process.c (read_process_output): Use ssize_t, to match.
8542 (send_process): Likewise.
8544 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8546 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8548 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8550 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8551 Use unsigned char, to match FcChar8 type definition.
8553 * xterm.c (handle_one_xevent):
8554 * xmenu.c (create_and_show_popup_menu):
8555 * xselect.c (x_decline_selection_request)
8556 (x_reply_selection_request): Avoid type-punned deref of X events.
8558 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8560 Fix some uses of `int' instead of EMACS_INT.
8561 * search.c (string_match_1, fast_string_match)
8562 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8563 (scan_buffer, find_next_newline_no_quit)
8564 (find_before_next_newline, search_command, Freplace_match)
8565 (Fmatch_data): Make some `int' variables be EMACS_INT.
8567 * xdisp.c (display_count_lines): 3rd argument and return value now
8568 EMACS_INT. All callers changed.
8569 (pint2hrstr): Last argument is now EMACS_INT.
8571 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8572 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8573 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8574 (decode_coding_utf_16, decode_coding_emacs_mule)
8575 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8576 (decode_coding_ccl, decode_coding_charset)
8577 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8578 (decode_coding_iso_2022, decode_coding_emacs_mule)
8579 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8580 <char_offset, last_offset>: Declare EMACS_INT.
8581 (encode_coding_utf_8, encode_coding_utf_16)
8582 (encode_coding_emacs_mule, encode_invocation_designation)
8583 (encode_designation_at_bol, encode_coding_iso_2022)
8584 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8585 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8587 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8588 (encode_invocation_designation): Last argument P_NCHARS is now
8590 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8591 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8593 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8596 * ccl.c (Fccl_execute_on_string): Declare some variables
8599 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8601 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8603 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8605 * process.c (Fformat_network_address): Doc fix.
8607 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8609 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8611 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8613 * keyboard.c (read_char): Call Lisp function help-form-show,
8614 instead of using internal_with_output_to_temp_buffer.
8615 (Qhelp_form_show): New var.
8616 (syms_of_keyboard): Use DEFSYM macro.
8618 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8620 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8622 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8624 * process.c (Flist_processes): Remove to Lisp.
8625 (list_processes_1): Delete.
8627 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8629 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8631 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8633 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8635 Fix more problems found by GCC 4.6.0's static checks.
8637 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8639 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8641 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8643 * xdisp.c (vmessage): Mark as a printf-like function.
8645 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8647 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8649 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8650 printf-like functions.
8651 (tiff_load): Add casts to remove these marks before passing them
8652 to system-supplied API.
8654 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8656 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8657 This avoids several warnings with gcc -Wstrict-overflow.
8658 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8659 directly, rather than having caller test rule sign. This avoids
8660 some unnecessary tests.
8661 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8662 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8663 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8665 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8666 (xfont_open): Avoid unnecessary tests.
8668 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8670 * composite.h, composite.c (composition_gstring_put_cache):
8671 Use EMACS_INT, not int, for length.
8673 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8674 breaking out part of COMPOSITION_DECODE_RULE.
8675 (COMPOSITION_DECODE_RULE): Use it.
8676 * composite.c (get_composition_id): Remove unused local vars,
8677 by using the new macro.
8679 * textprop.c (set_text_properties_1): Change while to do-while,
8680 since the condition is always true at first.
8682 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8683 (interval_deletion_adjustment): Return unsigned value.
8686 * process.c (list_processes_1, create_pty, read_process_output):
8687 (exec_sentinel): Remove vars that were set but not used.
8688 (create_pty): Remove unnecessary "volatile"s.
8689 (Fnetwork_interface_info): Avoid possibility of int overflow.
8690 (read_process_output): Do adaptive read buffering even if carryover.
8691 (read_process_output): Simplify nbytes computation if buffered.
8693 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8695 * syntax.c (scan_words): Remove var that was set but not used.
8696 (update_syntax_table): Use unsigned instead of int.
8698 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8699 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8700 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8702 * print.c (print_error_message): Avoid int overflow.
8704 * font.c (font_list_entities): Redo for clarity,
8705 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8707 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8708 (font_score): Avoid potential overflow in diff calculation.
8710 * fns.c (substring_both): Remove var that is set but not used.
8711 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8713 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8715 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8716 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8717 can always succeed if overflow has undefined behavior.
8719 * search.c (boyer_moore, wordify): Remove vars set but not used.
8720 (wordify): Omit three unnecessary tests.
8722 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8723 All callers changed. This avoids the need for an unused var.
8725 * casefiddle.c (casify_region): Remove var that is set but not used.
8727 * dired.c (file_name_completion): Remove var that is set but not used.
8729 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8731 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8732 (Finsert_file_contents): Remove unnecessary code checking fd.
8734 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8735 Check for integer overflow on size calculations.
8737 * buffer.c (Fprevious_overlay_change): Remove var that is set
8740 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8741 Remove vars that are set but not used.
8742 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8743 (timer_check_2): Mark vars as initialized.
8745 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8747 * image.c (lookup_image): Remove var that is set but not used.
8748 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8750 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8751 that are set but not used.
8753 * xfns.c (make_invisible_cursor): Don't return garbage
8754 if XCreateBitmapFromData fails (Bug#8410).
8756 * xselect.c (x_get_local_selection, x_handle_property_notify):
8757 Remove vars that are set but not used.
8759 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8760 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8762 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8763 Remove var that is set but not used.
8764 (scroll_bar_windows_size): Now size_t, not int.
8765 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8768 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8769 (map_tty_color) [!defined MSDOS]: Likewise.
8771 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8773 * coding.c: Remove vars that are set but not used.
8774 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8775 All callers changed.
8776 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8777 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8778 (decode_coding_charset): Remove vars that are set but not used.
8780 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8781 that is set but not used.
8783 * print.c (print_object): Remove var that is set but not used.
8785 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8786 The gnulib version avoids calling malloc in the usual case,
8787 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8788 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8789 * filelock.c (current_lock_owner): Likewise.
8790 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8791 * sysdep.c: Include allocator.h, careadlinkat.h.
8792 (emacs_no_realloc_allocator): New static constant.
8793 (emacs_readlink): New function.
8794 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8795 ../lib/careadlinkat.h.
8797 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8799 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8800 first non-nil return value).
8802 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8804 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8805 if not defined (Bug#8403).
8807 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8809 * xdisp.c (display_count_lines): Remove parameter `start',
8810 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8811 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8812 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8813 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8814 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8815 and thereabouts. All callers changed.
8816 (get_per_char_metric): Remove parameter `f', unused since
8817 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8819 2011-04-02 Jim Meyering <meyering@redhat.com>
8821 do not dereference NULL upon failed strdup
8822 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8823 (ns_get_family): Likewise.
8825 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8827 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8829 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8831 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8834 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8836 Add lexical binding.
8838 * window.c (Ftemp_output_buffer_show): New fun.
8839 (Fsave_window_excursion):
8840 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8842 * lread.c (lisp_file_lexically_bound_p): New function.
8843 (Fload): Bind Qlexical_binding.
8844 (readevalloop): Remove `evalfun' arg.
8845 Bind Qinternal_interpreter_environment.
8846 (Feval_buffer): Bind Qlexical_binding.
8847 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8849 (syms_of_lread): Declare `lexical-binding'.
8851 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8853 * keyboard.c (eval_dyn): New fun.
8854 (menu_item_eval_property): Use it.
8856 * image.c (parse_image_spec): Use Ffunctionp.
8858 * fns.c (concat, mapcar1): Accept byte-code-functions.
8860 * eval.c (Fsetq): Handle lexical vars.
8861 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8862 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8863 (FletX, Flet): Obey lexical binding.
8864 (Fcommandp): Handle closures.
8865 (Feval): New `lexical' arg.
8866 (eval_sub): New function extracted from Feval. Use it almost
8867 everywhere where Feval was used. Look up vars in lexical env.
8869 (Ffunctionp): Move from subr.el.
8870 (Ffuncall): Handle closures.
8871 (apply_lambda): Remove `eval_flags'.
8872 (funcall_lambda): Handle closures and new byte-code-functions.
8873 (Fspecial_variable_p): New function.
8874 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8875 but without exporting it to Lisp.
8877 * doc.c (Fdocumentation, store_function_docstring):
8878 * data.c (Finteractive_form): Handle closures.
8880 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8883 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8885 (exec_byte_code): New function extracted from Fbyte_code to handle new
8886 calling convention for byte-code-functions. Add new byte-codes.
8888 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8890 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8892 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8894 * xdisp.c (redisplay_internal): Fix prototype.
8896 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8898 * xdisp.c (SCROLL_LIMIT): New macro.
8899 (try_scrolling): Use it when setting scroll_limit.
8900 Limit scrolling to 100 screen lines.
8901 (redisplay_window): Even when falling back on "recentering",
8902 position point in the window according to scroll-conservatively,
8903 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8905 (try_scrolling): When point is above the window, allow searching
8906 as far as scroll_max, or one screenful, to compute vertical
8907 distance from PT to the scroll margin position. This prevents
8908 try_scrolling from unnecessarily failing when
8909 scroll-conservatively is set to a value slightly larger than the
8910 window height. Clean up the case of PT below the margin at bottom
8911 of window: scroll_max can no longer be INT_MAX. When aggressive
8912 scrolling is in use, don't let point enter the opposite scroll
8913 margin as result of the scroll.
8914 (syms_of_xdisp) <scroll-conservatively>: Document the
8915 threshold of 100 lines for never-recentering scrolling.
8917 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8919 * dispextern.h (move_it_by_lines):
8920 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8921 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8922 (message_log_check_duplicate): Remove parameters `prev_bol' and
8923 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8924 (redisplay_internal): Remove parameter `preserve_echo_area',
8925 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8927 * indent.c (Fvertical_motion):
8928 * window.c (window_scroll_pixel_based, Frecenter):
8929 Don't pass `need_y_p' to `move_it_by_lines'.
8931 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8933 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8934 steal a few bits to be more compact.
8935 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8936 Remove unneeded casts.
8938 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8940 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8942 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8943 binding" message (bug#7967).
8945 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8947 Fix more problems found by GCC 4.6.0's static checks.
8949 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8950 Remove unused local var.
8952 * editfns.c (Fmessage_box): Remove unused local var.
8954 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8955 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8956 Omit unused local vars.
8957 * window.c (shrink_windows): Omit unused local var.
8958 * menu.c (digest_single_submenu): Omit unused local var.
8959 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8960 Omit unused local var.
8962 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8963 Don't assume string length fits in int.
8964 (keyremap_step, read_key_sequence): Use size_t for sizes.
8965 (read_key_sequence): Don't check last_real_key_start redundantly.
8967 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8968 instead of alloca (Bug#8344).
8970 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8971 (Fbacktrace_frame): Don't assume nframes fits in int.
8973 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8975 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8978 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8980 * cm.c (calccost): Turn while-do into do-while, for clarity.
8982 * keyboard.c (syms_of_keyboard): Use the same style as later
8983 in this function when indexing through an array. This also
8984 works around GCC bug 48267.
8986 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8988 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8990 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8991 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8993 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8994 This avoids undefined behavior on integer overflow, and is a bit
8995 more convenient anyway since it is compared to a size_t variable.
8997 Variadic C functions now count arguments with size_t, not int.
8998 This avoids an unnecessary limitation on 64-bit machines, which
8999 caused (substring ...) to crash on large vectors (Bug#8344).
9000 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9001 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9002 All variadic functions and their callers changed accordingly.
9003 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9004 * data.c (arith_driver, float_arith_driver): Likewise.
9005 * editfns.c (general_insert_function): Likewise.
9006 * eval.c (struct backtrace.nargs, interactive_p)
9007 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9008 (funcall_lambda, mark_backtrace): Likewise.
9009 * fns.c (concat): Likewise.
9010 * frame.c (x_set_frame_parameters): Likewise.
9011 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9012 0 if not found, not -1. All callers changed.
9014 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9015 (stack_copy_size): Now size_t, not int.
9016 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9018 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9020 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9021 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9022 All callers changed.
9024 * lisp.h (multibyte_char_to_unibyte):
9025 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9026 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9027 * character.h (CHAR_TO_BYTE8):
9028 * cmds.c (internal_self_insert):
9029 * editfns.c (general_insert_function):
9030 * keymap.c (push_key_description):
9031 * search.c (Freplace_match):
9032 * xdisp.c (message_dolog, set_message_1): All callers changed.
9034 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9036 * keyboard.c (safe_run_hook_funcall): New function.
9037 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9038 don't set the hook to nil, but remove the offending function instead.
9039 (Qcommand_hook_internal): Remove, unused.
9040 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9041 Vcommand_hook_internal.
9043 * eval.c (enum run_hooks_condition): Remove.
9044 (funcall_nil, funcall_not): New functions.
9045 (run_hook_with_args): Call each function through a `funcall' argument.
9046 Remove `cond' argument, now redundant.
9047 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9048 (Frun_hook_with_args_until_failure): Adjust accordingly.
9049 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9051 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9053 * dispextern.h (string_buffer_position): Remove declaration.
9055 * print.c (strout): Remove parameter `multibyte', unused since
9056 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9058 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9059 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9060 All callers changed.
9062 * w32.c (_wsa_errlist): Use braces for struct initializers.
9064 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9065 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9066 All callers changed.
9067 (string_buffer_position): Likewise. Also, make static (it's never
9068 used outside xdisp.c).
9069 (cursor_row_p): Remove parameter `w', unused since
9070 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9071 (decode_mode_spec): Remove parameter `precision', introduced during
9072 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9073 All callers changed.
9075 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9077 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9079 2011-03-27 Anders Lindgren <andlind@gmail.com>
9081 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9082 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9083 (ns_update_auto_hide_menu_bar): New functions.
9084 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9085 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9086 ns_constrain_all_frames.
9087 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9088 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9090 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9092 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9094 2011-03-27 Glenn Morris <rgm@gnu.org>
9096 * syssignal.h: Replace RETSIGTYPE with void.
9097 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9098 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9099 Replace SIGTYPE with void everywhere.
9100 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9101 * s/template.h (SIGTYPE): Remove commented out definition.
9103 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9105 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9106 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9108 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9110 * w32.c (read_unc_volume): Use parameter `henum', instead of
9111 global variable `wget_enum_handle'.
9113 * keymap.c (describe_vector): Remove parameters `indices' and
9114 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9115 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9117 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9119 * keyboard.c (timer_check): Remove parameter `do_it_now',
9120 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9121 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9122 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9124 * keyboard.c (read_char):
9125 * w32menu.c (w32_menu_display_help):
9126 * xmenu.c (show_help_event, menu_help_callback):
9127 Adjust calls to `show_help_echo'.
9129 * gtkutil.c (xg_maybe_add_timer):
9130 * keyboard.c (readable_events):
9131 * process.c (wait_reading_process_output):
9132 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9134 * insdel.c (adjust_markers_gap_motion):
9135 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9136 (gap_left, gap_right): Don't call it.
9138 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9140 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9141 incurred during fontification.
9143 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9145 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9146 (DEFVAR_PER_BUFFER): Don't pass it.
9148 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9149 (scrolling_window): Don't pass it.
9151 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9153 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9155 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9157 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9158 of variables specific to SELinux and computation of `encoded_absname'.
9160 * image.c (XPutPixel): Remove unused variable `height'.
9162 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9164 * unexw32.c (get_section_info): Remove unused variable `section'.
9166 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9167 (system_process_attributes): Remove unused variable `sess'.
9168 (sys_read): Remove unused variable `err'.
9170 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9171 (w32_wnd_proc): Remove unused variable `isdead'.
9172 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9173 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9174 (x_create_tip_frame): Remove unused variable `tem'.
9176 * w32inevt.c (w32_console_read_socket):
9177 Remove unused variable `no_events'.
9179 * w32term.c (x_draw_composite_glyph_string_foreground):
9180 Remove unused variable `width'.
9182 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9184 * w32term.c (x_set_glyph_string_clipping):
9185 Don't pass uninitialized region to CombineRgn.
9187 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9189 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9190 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9191 (Fx_close_connection): Remove unused variable `i'.
9193 * w32font.c (w32font_draw): Return number of glyphs.
9194 (w32font_open_internal): Remove unused variable `i'.
9195 (w32font_driver): Add missing initializer.
9197 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9198 (fill_in_menu): Remove unused variable `items_added'.
9200 * w32term.c (last_mouse_press_frame): Remove static global variable.
9201 (w32_clip_to_row): Remove unused variable `f'.
9202 (x_delete_terminal): Remove unused variable `i'.
9204 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9205 (NOTHING): Remove unused static global variable.
9206 (uniscribe_check_otf): Remove unused variable `table'.
9207 (uniscribe_font_driver): Add missing initializers.
9209 2011-03-23 Julien Danjou <julien@danjou.info>
9211 * term.c (Fsuspend_tty, Fresume_tty):
9212 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9213 * window.c (temp_output_buffer_show):
9214 * insdel.c (signal_before_change):
9215 * frame.c (Fhandle_switch_frame):
9216 * fileio.c (Fdo_auto_save):
9217 * emacs.c (Fkill_emacs):
9218 * editfns.c (save_excursion_restore):
9219 * cmds.c (internal_self_insert):
9220 * callint.c (Fcall_interactively):
9221 * buffer.c (Fkill_all_local_variables):
9222 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9224 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9225 unconditionally since it does the check itself.
9227 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9229 Fix more problems found by GCC 4.5.2's static checks.
9231 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9232 the first time through the loop, since we know p0 < p1 then.
9233 This also avoids a gcc -Wstrict-overflow warning.
9235 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9236 leading to a memory leak, possible in functions like
9237 load_charset_map_from_file that can allocate an unbounded number
9238 of objects (Bug#8318).
9240 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9241 that could (at least in theory) be that large.
9243 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9244 This is less likely to overflow, and avoids undefined behavior if
9245 overflow does occur. All callers changed. Use strtoul to scan
9246 for the unsigned long integer.
9247 (pint2hrstr): Simplify and tune code slightly.
9248 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9250 * scroll.c (do_scrolling): Work around GCC bug 48228.
9251 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9253 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9254 This also avoids a warning with gcc -Wstrict-overflow.
9255 (validate_x_resource_name): Simplify count usage.
9256 This also avoids a warning with gcc -Wstrict-overflow.
9258 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9261 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9263 * process.c (Fmake_network_process): Use socklen_t, not int,
9264 where POSIX says socklen_t is required in portable programs.
9265 This fixes a porting bug on hosts like 64-bit HP-UX, where
9266 socklen_t is wider than int (Bug#8277).
9267 (Fmake_network_process, server_accept_connection):
9268 (wait_reading_process_output, read_process_output):
9271 * process.c: Rename or move locals to avoid shadowing.
9272 (list_processes_1, Fmake_network_process):
9273 (read_process_output_error_handler, exec_sentinel_error_handler):
9274 Rename or move locals.
9275 (Fmake_network_process): Define label "retry_connect" only if needed.
9276 (Fnetwork_interface_info): Fix pointer signedness.
9277 (process_send_signal): Add cast to avoid pointer signedness problem.
9278 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9279 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9281 Make tparam.h and terminfo.c consistent.
9282 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9283 Include tparam.h instead, since it declares them.
9284 * cm.h (PC): Remove extern decl; tparam.h now does this.
9285 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9286 * terminfo.c: Include tparam.h, to check interfaces.
9287 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9288 (tparam): Adjust signature to match interface in tparam.h;
9289 this removes some undefined behavior. Check that outstring and len
9290 are zero, which they always are with Emacs.
9291 * tparam.h (PC, BC, UP): New extern decls.
9293 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9294 (xftfont_open): Rename locals to avoid shadowing.
9296 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9297 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9298 (OTF_TAG_SYM): Omit macro if not needed.
9299 (ftfont_list): Remove unused local.
9300 (get_adstyle_property, ftfont_pattern_entity):
9301 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9302 Rename locals to avoid shadowing.
9304 * xfont.c (xfont_list_family): Mark var as initialized.
9306 * xml.c (make_dom): Now static.
9308 * composite.c (composition_compute_stop_pos): Rename local to
9310 (composition_reseat_it): Remove unused locals.
9311 (find_automatic_composition, composition_adjust_point): Likewise.
9312 (composition_update_it): Mark var as initialized.
9313 (find_automatic_composition): Mark vars as initialized,
9314 with a FIXME (Bug#8290).
9316 character.h: Rename locals to avoid shadowing.
9317 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9318 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9319 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9320 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9323 * textprop.c (property_change_between_p): Remove; unused.
9325 * intervals.c (interval_start_pos): Now static.
9327 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9329 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9330 Rename locals to avoid shadowing.
9332 * sound.c (wav_play, au_play, Fplay_sound_internal):
9333 Fix pointer signedness.
9334 (alsa_choose_format): Remove unused local var.
9335 (wav_play): Initialize a variable to 0, to prevent undefined
9336 behavior (Bug#8278).
9338 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9340 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9342 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9343 clobbering (Bug#8298).
9344 * sysdep.c (sys_subshell): Likewise.
9345 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9347 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9348 This should get cleaned up, so that child_setup has the
9349 same signature on all platforms.
9351 * callproc.c (call_process_cleanup): Now static.
9352 (relocate_fd): Rename locals to avoid shadowing.
9354 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9356 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9357 not to be necessary, and produces flickering.
9359 2011-03-20 Glenn Morris <rgm@gnu.org>
9361 * config.in: Remove file.
9363 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9365 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9366 are now in src/globals.h.
9367 (syms_of_minibuf): Remove spurious & from previous change.
9369 2011-03-20 Leo Liu <sdl.web@gmail.com>
9371 * minibuf.c (completing-read-function): New variable.
9372 (completing-read-default): Rename from completing-read.
9373 (completing-read): Call completing-read-function.
9375 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9377 * xfaces.c (Fx_load_color_file):
9378 Read color file from absolute filename (bug#8250).
9380 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9382 * makefile.w32-in: Update dependencies.
9384 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9386 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9388 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9390 Fix more problems found by GCC 4.5.2's static checks.
9392 * process.c (make_serial_process_unwind, send_process_trap):
9393 (sigchld_handler): Now static.
9395 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9396 That way, the code declares only the vars that it needs.
9397 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9398 * s/cygwin.h (PTY_ITERATION): Likewise.
9399 * s/darwin.h (PTY_ITERATION): Likewise.
9400 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9402 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9403 * process.c (allocate_pty): Don't declare stb unless it's needed.
9405 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9406 (CONSTANTLIM): Remove; unused.
9407 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9408 Define only if needed.
9410 * unexelf.c (unexec): Name an expression,
9411 to avoid gcc -Wbad-function-cast warning.
9412 Use a different way to cause a compilation error if anyone uses
9413 n rather than nn, a way that does not involve shadowing.
9414 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9416 * deps.mk (unexalpha.o): Remove; unused.
9418 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9419 * unexec.h: New file.
9420 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9421 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9423 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9424 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9425 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9426 Change as necessary to match prototype in unexec.h.
9428 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9430 (back_comment, skip_chars): Mark vars as initialized.
9432 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9433 Rename locals to avoid shadowing.
9435 * lread.c (read1): Rewrite so as not to use empty "else".
9436 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9438 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9440 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9441 warning when compiling print.c.
9443 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9444 instead of using an uninitialized var.
9445 (font_sort_entities): Mark var as initialized.
9447 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9449 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9450 pointers to constants.
9451 (font_parse_fcname): Remove unused vars.
9452 (font_delete_unmatched): Now static.
9453 (font_get_spec): Remove; unused.
9454 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9455 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9456 Rename or move locals to avoid shadowing.
9458 * fns.c (require_nesting_list, require_unwind): Now static.
9459 (Ffillarray): Rename locals to avoid shadowing.
9461 * floatfns.c (domain_error2): Define only if needed.
9462 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9464 * alloc.c (mark_backtrace): Move decl from here ...
9465 * lisp.h: ... to here, so that it can be checked.
9467 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9468 (Fdefvar): Rewrite so as not to use empty "else".
9469 (lisp_indirect_variable): Name an expression,
9470 to avoid gcc -Wbad-function-cast warning.
9471 (Fdefvar): Rename locals to avoid shadowing.
9473 * callint.c (quotify_arg, quotify_args): Now static.
9474 (Fcall_interactively): Rename locals to avoid shadowing.
9475 Use const pointer when appropriate.
9477 * lisp.h (get_system_name, get_operating_system_release):
9478 Move decls here, to check interfaces.
9479 * process.c (get_operating_system_release): Move decl to lisp.h.
9480 * xrdb.c (get_system_name): Likewise.
9481 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9482 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9483 some of which prompt warnings from gcc -Wbad-function-cast.
9484 (Fformat_time_string, Fencode_time, Finsert_char):
9485 (Ftranslate_region_internal, Fformat):
9486 Rename or remove local vars to avoid shadowing.
9487 (Ftranslate_region_internal): Mark var as initialized.
9489 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9492 * lisp.h (eassert): Check that the argument compiles, even if
9493 ENABLE_CHECKING is not defined.
9495 * data.c (Findirect_variable): Name an expression, to avoid
9496 gcc -Wbad-function-cast warning.
9497 (default_value, arithcompare, arith_driver, arith_error): Now static.
9498 (store_symval_forwarding): Rename local to avoid shadowing.
9499 (Fmake_variable_buffer_local, Fmake_local_variable):
9500 Mark variables as initialized.
9501 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9503 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9504 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9505 Rename locals to avoid shadowing.
9506 (mark_stack): Move local variables into the #ifdef region where
9508 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9509 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9511 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9512 (GC_STRING_CHARS): Remove; not used.
9513 (Fmemory_limit): Cast sbrk's returned value to char *.
9515 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9516 avoids undefined behavior in theory.
9518 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9520 Use functions, not macros, for up- and down-casing (Bug#8254).
9521 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9522 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9523 to use the following functions instead of these macros.
9524 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9525 EMACS_INT, since callers assume the returned value fits in int.
9526 (upcase1): Likewise, for UPCASE_TABLE.
9527 (uppercasep, lowercasep, upcase): New static inline functions.
9528 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9529 the race-condition problem in the old DOWNCASE.
9531 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9532 Rename locals to avoid shadowing.
9533 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9534 (regex_compile, re_search_2, re_match_2_internal):
9535 Remove unused local vars.
9536 (FREE_VAR): Rewrite so as not to use empty "else",
9537 which gcc can warn about.
9538 (regex_compile, re_match_2_internal): Mark locals as initialized.
9539 (RETALLOC_IF): Define only if needed.
9540 (WORDCHAR_P): Likewise. This one is never needed, but is used
9541 only in a comment talking about a compiler bug, so put inside
9542 the #if 0 of that comment.
9543 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9544 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9547 * search.c (boyer_moore): Rename locals to avoid shadowing.
9548 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9549 (PREV_CHAR_BOUNDARY): Likewise.
9551 * search.c (simple_search): Remove unused var.
9553 * dired.c (compile_pattern): Move decl from here ...
9554 * lisp.h: ... to here, so that it can be checked.
9555 (struct re_registers): New forward decl.
9557 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9559 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9561 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9562 Rename locals to avoid shadowing.
9563 (Fvertical_motion): Mark locals as initialized.
9565 * casefiddle.c (casify_object, casify_region): Now static.
9566 (casify_region): Mark local as initialized.
9568 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9570 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9571 New macros, so that the caller can use some names other than
9572 gcpro1, gcpro2, etc.
9573 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9575 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9576 argument, for consistency with GCPRO2_VAR, etc: it is now the
9577 prefix of the variable, not the variable itself. All uses
9579 * dired.c (directory_files_internal, file_name_completion):
9580 Rename locals to avoid shadowing.
9582 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9583 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9584 dired.c's scmp function, had undefined behavior.
9585 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9586 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9587 * buffer.h: ... to here, because these macros use current_buffer,
9588 and the new implementation with inline functions needs to have
9589 current_buffer in scope now, rather than later when the macros
9591 (downcase, upcase1): New static inline functions.
9592 (DOWNCASE, UPCASE1): Reimplement using these functions.
9593 This avoids undefined behavior in expressions like
9594 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9595 from race conditions in accessing the global variables
9596 case_temp1 and case_temp2.
9597 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9598 * lisp.h (case_temp1, case_temp2): Remove their decls.
9599 * character.h (ASCII_CHAR_P): Move from here ...
9600 * lisp.h: ... to here, so that the inline functions mentioned
9603 * dired.c (directory_files_internal_unwind): Now static.
9605 * fileio.c (file_name_as_directory, directory_file_name):
9606 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9608 (file_name_as_directory): Use const pointers when appropriate.
9609 (Fexpand_file_name): Likewise. In particular, newdir might
9610 point at constant storage, so make it a const pointer.
9611 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9612 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9614 (Fset_file_times, Finsert_file_contents, auto_save_error):
9615 Rename locals to avoid shadowing.
9617 * minibuf.c (choose_minibuf_frame_1): Now static.
9618 (Ftry_completion, Fall_completions): Rename or remove locals
9621 * marker.c (bytepos_to_charpos): Remove; unused.
9623 * lisp.h (verify_bytepos, count_markers): New decls,
9624 so that gcc does not warn that these functions aren't declared.
9626 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9627 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9628 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9629 (copy_text): Remove unused local var.
9631 * filelock.c (within_one_second): Now static.
9632 (lock_file_1): Rename local to avoid shadowing.
9634 * buffer.c (fix_overlays_before): Mark locals as initialized.
9635 (fix_start_end_in_overlays): Likewise. This function should be
9636 simplified by using pointers-to-pointers, but that's a different
9638 (switch_to_buffer_1): Now static.
9639 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9640 (report_overlay_modification): Rename locals to avoid shadowing.
9642 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9643 Fix pointer signedness issue.
9644 (sys_subshell): Mark local as volatile if checking for lint,
9645 to suppress a gcc -Wclobbered warning that does not seem to be right.
9646 (MAXPATHLEN): Define only if needed.
9648 * process.c (serial_open, serial_configure): Move decls from here ...
9649 * systty.h: ... to here, so that they can be checked.
9651 * fns.c (get_random, seed_random): Move extern decls from here ...
9652 * lisp.h: ... to here, so that they can be checked.
9654 * sysdep.c (reset_io): Now static.
9655 (wait_for_termination_signal): Remove; unused.
9657 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9658 (copy_keymap_item, append_key, push_text_char_description):
9660 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9661 (DENSE_TABLE_SIZE): Remove; unused.
9662 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9663 (describe_map_tree):
9664 Rename locals to avoid shadowing.
9666 * keyboard.c: Declare functions static if they are not used elsewhere.
9667 (echo_char, echo_dash, cmd_error, top_level_2):
9668 (poll_for_input, handle_async_input): Now static.
9669 (read_char, kbd_buffer_get_event, make_lispy_position):
9670 (make_lispy_event, make_lispy_movement, apply_modifiers):
9671 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9672 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9673 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9674 (read_key_sequence, read_char): Mark locals as initialized.
9675 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9677 * keyboard.h (make_ctrl_char): New decl.
9678 (mark_kboards): Move decl here ...
9679 * alloc.c (mark_kboards): ... from here.
9681 * lisp.h (force_auto_save_soon): New decl.
9683 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9684 (DEFINE_DUMMY_FUNCTION): New macro.
9685 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9687 (main): Add casts to avoid warnings
9688 if GCC considers string literals to be constants.
9690 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9692 * dbusbind.c: Pointer signedness fixes.
9693 (xd_signature, xd_append_arg, xd_initialize):
9694 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9695 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9696 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9697 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9699 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9700 if GCC considers string literals to be constants.
9701 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9703 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9705 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9706 (print_preprocess, print_object): New macro to fix last change.
9708 * print.c (print_preprocess): Don't forget font objects.
9710 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9712 * emacs.c (USAGE3): Doc fixes.
9714 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9716 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9719 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9721 * lisp.h (VWindow_system, Qfile_name_history):
9722 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9723 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9724 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9726 * w32select.c: Don't #include "keyboard.h".
9727 (run_protected): Add extern declaration for waiting_for_input.
9729 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9730 * w32console.c (detect_input_pending, read_input_pending)
9731 (encode_terminal_code):
9732 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9733 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9734 (w32_system_caret_y, Qfile_name_history):
9735 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9736 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9737 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9738 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9739 * w32proc.c (Qlocal, report_file_error):
9740 * w32term.c (Vwindow_system, updating_frame):
9741 * w32uniscribe.c (initialized, uniscribe_font_driver):
9742 Remove unneeded extern declarations.
9744 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9746 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9748 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9750 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9751 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9752 These macros can no longer be used for assignment.
9754 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9755 Assign struct members directly, instead of using BUF_BEGV etc.
9756 (record_buffer_markers, fetch_buffer_markers): New functions for
9757 recording and fetching special buffer markers.
9758 (set_buffer_internal_1, set_buffer_temp): Use them.
9760 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9762 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9764 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9765 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9767 * xdisp.c (hscroll_window_tree):
9768 (reconsider_clip_changes): Use PT instead of BUF_PT.
9770 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9772 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9773 $(EMACS_ROOT)/lib/intprops.h.
9775 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9777 Fix more problems found by GCC 4.5.2's static checks.
9779 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9780 to unsigned char * to avoid compiler diagnostic.
9781 (xg_free_frame_widgets): Make it clear that a local variable is
9782 needed only if USE_GTK_TOOLTIP.
9783 (gdk_window_get_screen): Make it clear that this macro is needed
9784 only if USE_GTK_TOOLTIP.
9785 (int_gtk_range_get_value): New function, which avoids a diagnostic
9786 from gcc -Wbad-function-cast.
9787 (xg_set_toolkit_scroll_bar_thumb): Use it.
9788 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9789 diagnostic from gcc -Wbad-function-cast.
9790 (get_utf8_string, xg_get_file_with_chooser):
9791 Rename locals to avoid shadowing.
9792 (create_dialog): Move locals to avoid shadowing.
9794 * xgselect.c (xg_select): Remove unused var.
9796 * image.c (four_corners_best): Mark locals as initialized.
9797 (gif_load): Initialize transparent_p to zero (Bug#8238).
9798 Mark another local as initialized.
9799 (my_png_error, my_error_exit): Mark with NO_RETURN.
9801 * image.c (clear_image_cache): Now static.
9802 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9803 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9804 (x_edge_detection): Remove unnecessary cast that
9805 gcc -Wbad-function-cast diagnoses.
9806 (gif_load): Fix pointer signedness.
9807 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9808 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9810 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9812 Improve quality of tests for time stamp overflow.
9813 For example, without this patch (encode-time 0 0 0 1 1
9814 1152921504606846976) returns the obviously-bogus value (-948597
9815 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9816 reports time overflow. See
9817 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9818 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9819 * editfns.c: Include limits.h and intprops.h.
9820 (TIME_T_MIN, TIME_T_MAX): New macros.
9821 (time_overflow): Move earlier, to before first use.
9822 (hi_time, lo_time): New functions, for an accurate test for
9824 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9825 (Fget_internal_run_time): Don't assume time_t fits in int.
9826 (make_time): Use list2 instead of Fcons twice.
9827 (Fdecode_time): More accurate test for out-of-range times.
9828 (check_tm_member): New function.
9829 (Fencode_time): Use it, to test for out-of-range times.
9830 (lisp_time_argument): Don't rely on undefined left-shift and
9831 right-shift behavior when checking for time stamp overflow.
9833 * editfns.c (time_overflow): New function, refactoring common code.
9834 (Fformat_time_string, Fdecode_time, Fencode_time):
9835 (Fcurrent_time_string): Use it.
9837 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9838 * dired.c (make_time): Move to ...
9839 * editfns.c (make_time): ... here.
9840 * systime.h: Note the move.
9842 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9844 * fringe.c (update_window_fringes): Remove unused variables.
9846 * unexmacosx.c (copy_data_segment): Also copy __got section.
9849 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9851 * termcap.c [MSDOS]: Include "msdos.h".
9852 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9853 Constify `char *' arguments and their references according to
9854 prototypes in tparam.h.
9856 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9858 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9859 Adapt all references accordingly.
9861 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9863 2011-03-11 Tom Tromey <tromey@redhat.com>
9865 * buffer.c (syms_of_buffer): Remove obsolete comment.
9867 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9869 * termhooks.h (encode_terminal_code): Declare prototype.
9871 * msdos.c (encode_terminal_code): Don't declare prototype.
9873 * term.c (encode_terminal_code): Now external again, used by
9874 w32console.c and msdos.c.
9876 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9877 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9879 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9881 Fix some minor problems found by GCC 4.5.2's static checks.
9883 * fringe.c (update_window_fringes): Mark locals as initialized
9885 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9887 * alloc.c (mark_fringe_data): Move decl from here ...
9888 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9889 to check its interface.
9890 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9892 * fontset.c (free_realized_fontset): Now static.
9893 (Fset_fontset_font): Rename local to avoid shadowing.
9894 (fontset_font): Mark local as initialized.
9895 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9897 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9899 * xselect.c (x_disown_buffer_selections): Remove; not used.
9900 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9901 (x_own_selection, Fx_disown_selection_internal): Rename locals
9903 (x_handle_dnd_message): Remove local to avoid shadowing.
9905 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9906 so that the caller can use some name other than gcpro1.
9907 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9908 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9909 (Fx_backspace_delete_keys_p):
9910 Use them to avoid shadowing, and rename vars to avoid shadowing.
9911 (x_decode_color, x_set_name, x_window): Now static.
9912 (Fx_create_frame): Add braces to silence GCC warning.
9913 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9914 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9915 Remove unused locals.
9916 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9917 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9918 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9921 * xterm.h (x_mouse_leave): New decl.
9923 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9924 Remove unused functions.
9925 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9926 (x_calc_absolute_position): Now static.
9927 (XTread_socket): Don't define label "out" unless it's used.
9928 Don't declare local "event" unless it's used.
9929 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9930 unless they are used.
9931 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9932 (x_fatal_error_signal): Remove; not used.
9933 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9934 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9935 (x_error_catcher, x_connection_closed, x_error_handler):
9936 (x_error_quitter, xembed_send_message, x_iconify_frame):
9937 (my_log_handler): Rename locals to avoid shadowing.
9938 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9939 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9941 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9942 Rename or move locals to avoid shadowing.
9943 (tty_defined_color, merge_face_heights): Now static.
9944 (free_realized_faces_for_fontset): Remove; not used.
9945 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9946 does not deduce is never used uninitialized.
9947 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9948 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9950 * terminal.c (store_terminal_param): Now static.
9952 * xmenu.c (menu_highlight_callback): Now static.
9953 (set_frame_menubar): Remove unused local.
9954 (xmenu_show): Rename parameter to avoid shadowing.
9955 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9956 since they might point to immutable storage.
9957 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9958 since it's unused otherwise.
9960 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9961 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9962 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9963 avoids a gcc -Wuninitialized diagnostic.
9964 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9965 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9966 does not deduce are never used uninitialized.
9968 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9970 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9971 * window.c (window_loop, size_window):
9972 (run_window_configuration_change_hook, enlarge_window): Likewise.
9974 * window.c (display_buffer): Now static.
9975 (size_window): Mark variables that gcc -Wuninitialized
9976 does not deduce are never used uninitialized.
9977 * window.h (check_all_windows): New decl, to forestall
9978 gcc -Wmissing-prototypes diagnostic.
9979 * dispextern.h (bidi_dump_cached_states): Likewise.
9981 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9983 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9985 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9986 and to avoid gcc -Wuninitialized warning.
9987 (load_charset_map): Mark variables that gcc -Wuninitialized
9988 does not deduce are never used uninitialized.
9989 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9991 * coding.c (coding_set_source, coding_set_destination):
9992 Use "else { /* comment */ }" rather than "else /* comment */;"
9993 for clarity, and to avoid gcc -Wempty-body warning.
9994 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9995 a block, when the outer 'i' will do.
9996 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9997 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9998 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9999 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10000 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10001 Rename locals to avoid shadowing.
10002 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10003 * coding.c (emacs_mule_char, encode_invocation_designation):
10004 Now static, since they're not used elsewhere.
10005 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10006 (decode_coding_object, encode_coding_object, detect_coding_system):
10007 (decode_coding_emacs_mule): Mark variables that gcc
10008 -Wuninitialized does not deduce are never used uninitialized.
10009 (detect_coding_iso_2022): Initialize a local variable that might
10010 be used uninitialized. Leave a FIXME because it's not clear that
10011 this initialization is needed. (Bug#8211)
10012 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10013 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10014 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10015 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10016 Remove unused macros.
10018 * category.c (hash_get_category_set): Remove unused local var.
10019 (copy_category_table): Now static, since it's not used elsewhere.
10020 * character.c (string_count_byte8): Likewise.
10022 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10023 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10025 * chartab.c (copy_sub_char_table): Now static, since it's not used
10027 (sub_char_table_ref_and_range, char_table_ref_and_range):
10028 Rename locals to avoid shadowing.
10029 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10031 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10032 (BIDI_BOB): Remove unused macro.
10034 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10035 deduce are never used uninitialized.
10036 * term.c (encode_terminal_code): Likewise.
10038 * term.c (encode_terminal_code): Now static. Remove unused local.
10040 * tparam.h: New file.
10041 * term.c, tparam.h: Include it.
10042 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10043 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10044 Move these decls to tparam.h, and make them agree with what
10045 is actually in tparam.c. The previous trick of using incompatible
10046 decls in different modules does not conform to the C standard.
10047 All callers of tparam changed to use tparam's actual API.
10048 * tparam.c (tparam1, tparam, tgoto):
10049 Use const pointers where appropriate.
10051 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10052 * cm.h (struct cm): Likewise.
10053 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10054 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10055 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10056 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10057 (turn_on_face, init_tty): Likewise.
10058 * termchar.h (struct tty_display_info): Likewise.
10060 * term.c (term_mouse_position): Rename local to avoid shadowing.
10062 * alloc.c (mark_ttys): Move decl from here ...
10063 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10065 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10067 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10069 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10071 * search.c (compile_pattern_1): Remove argument regp, unused since
10072 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10073 (compile_pattern): Don't pass it.
10075 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10077 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10078 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10080 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10082 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10084 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10085 gdk_window_get_screen, gdk_window_get_geometry,
10086 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10087 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10088 (xg_get_pixbuf_from_pixmap): New function.
10089 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10090 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10091 Call xg_get_pixbuf_from_pixmap instead of
10092 gdk_pixbuf_get_from_drawable.
10093 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10094 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10095 (xg_check_special_colors): Use GtkStyleContext and its functions
10097 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10098 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10099 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10100 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10101 Call gtk_widget_get_preferred_size.
10102 (xg_frame_resized): gdk_window_get_geometry only takes 5
10104 (xg_win_to_widget, xg_event_is_for_menubar):
10105 Call gdk_x11_window_lookup_for_display.
10106 (xg_set_widget_bg): New function.
10107 (delete_cb): New function.
10108 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10109 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10110 (xg_set_background_color): Call xg_set_widget_bg.
10111 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10112 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10113 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10114 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10116 (update_frame_tool_bar): Call gtk_widget_hide.
10117 (xg_initialize): Use GDK_KEY_g.
10119 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10121 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10123 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10124 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10125 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10127 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10129 * w32xfns.c (select_palette): Check success of RealizePalette against
10130 GDI_ERROR, not zero.
10132 See ChangeLog.11 for earlier changes.
10134 ;; Local Variables:
10138 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10140 This file is part of GNU Emacs.
10142 GNU Emacs is free software: you can redistribute it and/or modify
10143 it under the terms of the GNU General Public License as published by
10144 the Free Software Foundation, either version 3 of the License, or
10145 (at your option) any later version.
10147 GNU Emacs is distributed in the hope that it will be useful,
10148 but WITHOUT ANY WARRANTY; without even the implied warranty of
10149 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10150 GNU General Public License for more details.
10152 You should have received a copy of the GNU General Public License
10153 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.