1 2012-08-14 Glenn Morris <rgm@gnu.org>
3 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
5 2012-08-14 Ulrich Mueller <ulm@gentoo.org>
7 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
10 2012-08-13 Eli Zaretskii <eliz@gnu.org>
12 * w32menu.c: Include w32heap.h.
13 (add_menu_item): If the call to AppendMenuW (via
14 unicode_append_menu) fails, disable Unicode menus only if we are
15 running on Windows 9X/Me.
17 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
19 * window.c (Fdelete_other_windows_internal)
20 (Fdelete_window_internal): Don't access frame's mouse highlight
21 info of the initial frame. (Bug#11677)
23 2012-08-12 Jan Djärv <jan.h.d@swipnet.se>
25 * nsterm.m (ns_read_socket): Return early if there is a modal
28 * nsmenu.m (Popdown_data): New struct.
29 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
31 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
32 (initWithContentRect): Make imgView and contentView non-static
33 and autorelease them. Also autorelease img and matrix (Bug#12005).
34 (dealloc): Remove (Bug#12005).
36 * nsterm.m (keyDown:): Interpret flags without left/right bits
37 as the left key (Bug#11670).
39 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
41 2012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
43 * unexmacosx.c (copy_data_segment): Copy initialized data in
44 statically linked libraries from input file rather than memory.
46 2012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
48 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
49 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
50 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
52 2012-07-19 Chong Yidong <cyd@gnu.org>
54 * window.c (Fwindow_absolute_pixel_edges)
55 (Fdelete_other_windows_internal): Signal an error if the window is
56 on a dead frame (Bug#11984).
58 2012-07-14 Eli Zaretskii <eliz@gnu.org>
60 Remove FILE_SYSTEM_CASE.
61 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
63 * fileio.c (FILE_SYSTEM_CASE): Don't define.
64 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
65 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
66 call-process-region passes it through expand-file-name.
68 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
70 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
72 Fix crash when creating indirect buffer (Bug#11917)
73 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
74 Don't handle unbound variables specially if non-zero.
75 (Fbuffer_local_variables): Pass zero.
76 (clone_per_buffer_values): Pass non-zero.
78 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
80 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
81 to make the loop interruptible.
83 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
85 * gnutls.c (emacs_gnutls_handshake): Only retry if
88 2012-06-23 Eli Zaretskii <eliz@gnu.org>
90 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
91 in the logic of incrementing and decrementing the value of
92 use_relocatable_buffers.
94 2012-06-21 Glenn Morris <rgm@gnu.org>
96 * charset.c (init_charset): Make lack of etc/charsets fatal.
98 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
100 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
101 referenced (Bug#11583).
103 2012-06-01 Chong Yidong <cyd@gnu.org>
105 * Version 24.1 released.
107 2012-05-30 Eli Zaretskii <eliz@gnu.org>
109 * xdisp.c (handle_stop): Detect whether we have overlay strings
110 loaded by testing it->current.overlay_string_index to be
111 non-negative, instead of checking whether n_overlay_strings is
112 positive. (Bug#11587)
114 2012-05-30 Chong Yidong <cyd@gnu.org>
116 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
118 * doc.c (Fsubstitute_command_keys): Doc fix.
120 2012-05-29 Eli Zaretskii <eliz@gnu.org>
122 * search.c (search_buffer): Remove calls to
123 r_alloc_inhibit_buffer_relocation, as it is now called by
124 maybe_unify_char, which was the cause of relocation of buffer text
127 2012-05-23 Eli Zaretskii <eliz@gnu.org>
129 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
130 for the duration of call to load_charset, to avoid problems with
131 callers of maybe_unify_char that access buffer text through C
134 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
135 decrement the inhibition flag, instead of just setting or
138 2012-05-24 Ken Brown <kbrown@cornell.edu>
140 * callproc.c (Fcall_process): Restore a line that was accidentally
141 commented out in the 2011-02-13 change (bug#11547).
143 2012-05-23 Eli Zaretskii <eliz@gnu.org>
145 * lisp.h [REL_ALLOC]: Add prototypes for external functions
148 * buffer.c [REL_ALLOC]: Remove prototypes of
149 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
150 they are now on lisp.h.
152 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
154 * search.c (search_buffer): Use it to inhibit relocation of buffer
155 text while re_search_2 is doing its job, because re_search_2 is
156 passed C pointers to buffer text. (Bug#11519)
158 2012-05-21 Eli Zaretskii <eliz@gnu.org>
160 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
163 2012-05-19 Eli Zaretskii <eliz@gnu.org>
165 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
166 state after an additional call to move_it_in_display_line_to, keep
167 the values of it->max_ascent and it->max_descent found for the
169 (pos_visible_p): Revert the comparison against bottom_y to what it
170 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
173 2012-05-15 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
177 2012-05-13 Eli Zaretskii <eliz@gnu.org>
179 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
180 already have overlays loaded.
181 (handle_single_display_spec): Before returning without displaying
182 fringe bitmap, synchronize the bidi iterator with the main display
183 iterator, by calling iterate_out_of_display_property.
184 (iterate_out_of_display_property): Detect buffer iteration by
185 testing that it->string is a Lisp string.
186 (get_next_display_element): When the current object is exhausted,
187 and there's something on it->stack, call set_iterator_to_next to
188 proceed with what's on the stack, instead of returning zero.
189 (set_iterator_to_next): If called at the end of a Lisp string,
190 proceed to consider_string_end without incrementing string
191 position. Don't increment display vector index past the end of
192 the display vector. (Bug#11417)
193 (pos_visible_p): Don't report a position visible when move_it_to
194 stopped at the last line of window, which happens to be scanned
195 backwards by the bidi iteration. (Bug#11464)
197 2012-05-11 Eli Zaretskii <eliz@gnu.org>
199 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
200 and right-margin display specs even if the spec is invalid or we
201 are on a TTY, and thus unable to display on the fringes. That's
202 because the text with the property will not be displayed anyway,
203 so we need to signal to the caller that this is a "replacing"
204 display spec. This fixes display when the spec is invalid or we
207 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
209 * unexaix.c (make_hdr): Fix typo in prototype.
210 This bug broke the build on AIX. Problem reported by Gilles Pion.
212 2012-05-05 Eli Zaretskii <eliz@gnu.org>
214 * w32proc.c (new_child): Force Windows to reserve only 64KB of
215 stack for each reader_thread, instead of defaulting to 8MB
216 determined by the linker. This avoids failures in creating
217 subprocesses on Windows 7, see the discussion in this thread:
218 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
220 2012-05-02 Jim Meyering <meyering@redhat.com>
222 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
224 2012-04-29 Eli Zaretskii <eliz@gnu.org>
226 * xdisp.c (pos_visible_p): If already at a newline from the
227 display string before the 'while' loop, don't walk back the glyphs
228 from it3.glyph_row. Solves assertion violation when the display
229 string begins with a newline (egg.el). (Bug#11367)
231 2012-04-24 Chong Yidong <cyd@gnu.org>
233 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
235 2012-04-23 Eli Zaretskii <eliz@gnu.org>
237 * xdisp.c (pos_visible_p): If the window start position is beyond
238 ZV, start the display from buffer beginning. Prevents assertion
239 violation in init_iterator when the minibuffer window is scrolled
242 * window.c (window_scroll_pixel_based): Likewise.
244 2012-04-23 Chong Yidong <cyd@gnu.org>
246 * keymap.c (where_is_internal): Doc fix (Bug#10872).
248 2012-04-20 Glenn Morris <rgm@gnu.org>
250 * fileio.c (Fcopy_file, Fset_file_selinux_context):
251 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
253 2012-04-20 Eli Zaretskii <eliz@gnu.org>
255 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
256 overrun array limits of glyph row's used[] array. (Bug#11288)
258 2012-04-20 Chong Yidong <cyd@gnu.org>
260 * process.c (wait_reading_process_output): If EIO occurs on a pty,
261 set the status to "failed" and ensure that sentinel is run.
263 2012-04-18 Glenn Morris <rgm@gnu.org>
265 * process.c (Fset_process_inherit_coding_system_flag)
266 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
267 (Fmake_network_process, Fmake_serial_process): Doc fix.
269 2012-04-17 Eli Zaretskii <eliz@gnu.org>
271 * xdisp.c (string_buffer_position_lim): Limit starting position to
273 (set_cursor_from_row): If called for a mode-line or header-line
274 row, return zero immediately.
275 (try_cursor_movement): If inside continuation line, don't back up
276 farther than the first row after the header line, if any. Don't
277 consider the header-line row as "partially visible", even if
278 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
280 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
282 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
284 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
286 * process.c (make_process):
287 * process.h: Add integer `gnutls_handshakes_tried' member to
290 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
291 Add convenience `GNUTLS_LOG2i' macro.
293 * gnutls.c (gnutls_log_function2i): Convenience log function.
294 (emacs_gnutls_read): Use new log functions,
295 `gnutls_handshakes_tried' process member, and
296 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
297 attempts per process (connection).
299 2012-04-09 Eli Zaretskii <eliz@gnu.org>
301 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
302 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
304 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
306 * nsterm.m (constrainFrameRect): Always constrain when there is only
307 one screen (Bug#10962).
309 2012-04-06 Eli Zaretskii <eliz@gnu.org>
311 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
312 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
313 about subtle differences between FETCH_CHAR* and STRING_CHAR*
314 macros related to unification of CJK characters. For the details,
315 see the discussion following the message here:
316 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
318 2012-04-04 Chong Yidong <cyd@gnu.org>
320 * keyboard.c (Vdelayed_warnings_list): Doc fix.
322 2012-04-01 Eli Zaretskii <eliz@gnu.org>
324 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
325 instead of alloca. (Bug#11138)
327 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
329 * w32menu.c (is_simple_dialog): Properly check lisp types.
332 2012-03-31 Eli Zaretskii <eliz@gnu.org>
334 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
335 position we get to after a call to move_it_to fails the
336 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
337 only if we wind up in a string from display property. (Bug#11063)
339 * window.c (Fdelete_other_windows_internal): Invalidate the row
340 and column information about mouse highlight, so that redisplay
341 restores it after reallocating the glyph matrices. (Bug#7464)
343 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
344 string comes from a `display' text property, use the buffer
345 position of that property as if we actually saw that position in
347 (move_it_by_lines): Remove the assertion that
348 "it->current_x == 0 && it->hpos == 0" which can be legitimately
349 violated when there's a before-string at the beginning of a line.
352 2012-03-30 Eli Zaretskii <eliz@gnu.org>
354 * xdisp.c (append_space_for_newline): If the default face was
355 remapped, use the remapped face for the appended newline.
356 (extend_face_to_end_of_line): Use the remapped default face for
357 extending the face to the end of the line.
358 (display_line): Call extend_face_to_end_of_line when the default
359 face was remapped. (Bug#11068)
361 2012-03-29 Eli Zaretskii <eliz@gnu.org>
363 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
365 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
367 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
369 2012-03-27 Glenn Morris <rgm@gnu.org>
371 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
374 2012-03-26 Kenichi Handa <handa@m17n.org>
376 * dispextern.h (struct glyph): Fix previous change. Change the
377 bit length of glyphless.ch to 25 (Bug#11082).
379 2012-03-26 Chong Yidong <cyd@gnu.org>
381 * keyboard.c (Vselection_inhibit_update_commands): New variable.
382 (command_loop_1): Use it; inhibit selection update for
383 handle-select-window too (Bug#8996).
385 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
387 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
389 2012-03-25 Kenichi Handa <handa@m17n.org>
391 * dispextern.h (struct glyph): Change the bit length of
392 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
394 2012-03-24 Eli Zaretskii <eliz@gnu.org>
396 * s/ms-w32.h (tzname): Include time.h before redirecting to
397 _tzname. Fixes the MSVC build. (Bug#9960)
399 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
401 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
404 * xterm.c (XTread_socket): Only modify handling_signal if
405 !SYNC_INPUT. (Bug#11080)
407 2012-03-23 Eli Zaretskii <eliz@gnu.org>
409 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
410 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
411 when fetching a multibyte character consumes more bytes than
412 CHAR_BYTES returns, due to unification of CJK characters in
413 string_char. (Bug#11073)
415 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
417 * process.c (wait_reading_process_output): Handle pty disconnect
418 by refraining from sending oneself a SIGCHLD (bug#10933).
420 2012-03-22 Chong Yidong <cyd@gnu.org>
422 * dispextern.h (struct it): New member string_from_prefix_prop_p.
424 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
425 Mark string as coming from a prefix property.
426 (handle_face_prop): Use default face for prefix strings (Bug#4281).
427 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
429 2012-03-21 Chong Yidong <cyd@gnu.org>
431 * xfaces.c (Vface_remapping_alist): Doc fix.
433 2012-03-20 Eli Zaretskii <eliz@gnu.org>
435 * w32proc.c (Fw32_set_console_codepage)
436 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
439 2012-03-20 Chong Yidong <cyd@gnu.org>
441 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
442 to reflect default non-nil value of redisplay-dont-pause.
444 2012-03-19 Kenichi Handa <handa@m17n.org>
446 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
447 it fit in a valid range (Bug#11003).
449 2012-03-18 Eli Zaretskii <eliz@gnu.org>
451 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
452 that is not from display property, accept the row as a "cursor
453 row" if one of the string's character has a non-nil `cursor'
454 property. Fixes cursor positioning when there are newlines in
455 overlay strings, e.g. in icomplete.el. (Bug#11035)
457 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
459 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
461 2012-03-12 Chong Yidong <cyd@gnu.org>
463 * eval.c (inhibit_lisp_code): Rename from
464 inhibit_window_configuration_change_hook; move from window.c.
466 * xfns.c (unwind_create_frame_1, Fx_create_frame):
467 * window.c (run_window_configuration_change_hook)
468 (syms_of_window): Callers changed.
470 2012-03-11 Chong Yidong <cyd@gnu.org>
472 * keymap.c (Fkey_description): Doc fix (Bug#9700).
474 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
476 2012-03-10 Chong Yidong <cyd@gnu.org>
478 * frame.c (other_visible_frames): Don't assume the selected frame
479 is visible (Bug#10955).
481 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
483 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
485 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
487 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
488 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
491 2012-03-03 Glenn Morris <rgm@gnu.org>
493 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
495 2012-03-02 Eli Zaretskii <eliz@gnu.org>
497 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
498 position past the first glyph_row that ends at ZV. (Bug#10902)
499 (redisplay_window, next_element_from_string): Fix typos in
501 (redisplay_window): Pass to move_it_vertically the margin in
502 pixels, not in screen lines.
504 2012-03-02 Glenn Morris <rgm@gnu.org>
506 * buffer.c (buffer-list-update-hook): Doc fix.
508 2012-02-29 Eli Zaretskii <eliz@gnu.org>
510 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
511 push_it before setting up the iterator for the first overlay
512 string, even if we have an empty string loaded.
513 (next_overlay_string): If there's an empty string on the iterator
514 stack, pop the stack. (Bug#10903)
516 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
518 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
519 Suggested by Stefan Monnier in
520 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
521 * alloc.c (widen_to_Lisp_Object): New static function.
522 (mark_memory): Also mark Lisp_Objects by fetching pointer words
523 and widening them to Lisp_Objects. This would work even if
524 USE_LSB_TAG is defined and wide integers are used, which might
525 happen in a future version of Emacs.
527 2012-02-25 Chong Yidong <cyd@gnu.org>
529 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
532 * xselect.c (Fx_selection_exists_p): Doc fix.
533 (x_clipboard_manager_save_all): Print an informative message
534 before saving to clipboard manager.
536 2012-02-24 Chong Yidong <cyd@gnu.org>
538 * keyboard.c (process_special_events): Handle all X selection
539 requests in kbd_buffer, not just the next one (Bug#8869).
541 2012-02-23 Chong Yidong <cyd@gnu.org>
543 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
544 call when setting menu-bar-lines and tool-bar-lines parameters.
545 (unwind_create_frame_1): New helper function.
547 * window.c (inhibit_window_configuration_change_hook): New var.
548 (run_window_configuration_change_hook): Obey it.
549 (syms_of_window): Initialize it.
551 2012-02-22 Chong Yidong <cyd@gnu.org>
553 * xterm.c (x_draw_image_relief): Add missing type check for
554 Vtool_bar_button_margin (Bug#10743).
556 2012-02-21 Chong Yidong <cyd@gnu.org>
558 * fileio.c (Vfile_name_handler_alist): Doc fix.
560 * buffer.c (Fget_file_buffer): Protect against invalid file
561 handler return value.
563 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
565 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
566 when computing $valmask.
568 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
569 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
570 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
571 It's useless in that case, and it can cause problems on hosts
572 that allocate halves of EMACS_INT values separately.
573 Reported by Dan Horák. Diagnosed by Andreas Schwab in
574 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
575 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
576 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
577 it avoids undefined behavior on hosts where shifting right by more
578 than the word width has undefined behavior.
580 2012-02-19 Chong Yidong <cyd@gnu.org>
582 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
583 (Funhandled_file_name_directory, Ffile_name_as_directory)
584 (Fdirectory_file_name, Fexpand_file_name)
585 (Fsubstitute_in_file_name): Protect against invalid file handler
586 return values (Bug#10845).
588 2012-02-18 Eli Zaretskii <eliz@gnu.org>
590 * .gdbinit (pitx): Fix incorrect references to fields of the
593 2012-02-17 Chong Yidong <cyd@gnu.org>
595 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
597 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
599 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
600 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
602 2012-02-15 Chong Yidong <cyd@gnu.org>
604 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
605 marked as special. Also, starting docstrings with * is obsolete.
607 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
609 * gnutls.c (emacs_gnutls_write): Fix last change.
611 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
613 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
616 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
618 * keymap.c (Fsingle_key_description): Handle char ranges.
620 2012-02-12 Chong Yidong <cyd@gnu.org>
622 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
623 as that creates a dangerous corner case.
625 * window.c (Fdelete_window_internal): Invalidate the mouse
626 highlight (Bug#9904).
628 2012-02-12 Glenn Morris <rgm@gnu.org>
630 * xselect.c (Fx_own_selection_internal)
631 (Fx_get_selection_internal, Fx_disown_selection_internal)
632 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
633 * nsselect.m (Fx_own_selection_internal)
634 (Fx_disown_selection_internal, Fx_selection_exists_p)
635 (Fx_selection_owner_p, Fx_get_selection_internal):
636 Sync docs and argument specs with the xselect.c versions.
638 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
640 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
642 2012-02-11 Eli Zaretskii <eliz@gnu.org>
644 * w32select.c (Fx_selection_exists_p): Sync doc string and
645 argument list with xselect.c. (Bug#10783)
647 * w16select.c (Fx_selection_exists_p): Sync doc string and
648 argument list with xselect.c. (Bug#10783)
650 2012-02-10 Glenn Morris <rgm@gnu.org>
652 * fns.c (Fsecure_hash): Doc fix.
654 2012-02-09 Kenichi Handa <handa@m17n.org>
656 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
658 2012-02-07 Chong Yidong <cyd@gnu.org>
660 * buffer.c (Fbuffer_local_variables)
661 (buffer_lisp_local_variables): Handle unbound vars correctly;
662 don't let Qunbound leak into Lisp.
664 2012-02-07 Glenn Morris <rgm@gnu.org>
666 * image.c (Fimagemagick_types): Doc fix.
668 * image.c (imagemagick-render-type): Change it from a lisp object
669 to an integer. Move the doc here from the lisp manual.
670 Treat all values not equal to 0 the same.
672 2012-02-06 Chong Yidong <cyd@gnu.org>
674 * doc.c (store_function_docstring): Avoid applying docstring of
675 alias to base function (Bug#2603).
677 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
679 * .gdbinit (pp1, pv1): Remove redundant defines.
682 2012-02-04 Chong Yidong <cyd@gnu.org>
684 * nsterm.m: Declare a global (Bug#10694).
686 2012-02-04 Eli Zaretskii <eliz@gnu.org>
688 * w32.c (get_emacs_configuration_options):
689 Include --enable-checking, if specified, in the return value.
691 2012-02-04 Martin Rudalics <rudalics@gmx.at>
693 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
694 after rounding frame sizes. (Bug#9723)
696 2012-02-04 Eli Zaretskii <eliz@gnu.org>
698 * keyboard.c (adjust_point_for_property): Don't position point
699 before BEGV. (Bug#10696)
701 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
703 Handle overflow when computing char display width (Bug#9496).
704 * character.c (char_width): Return EMACS_INT, not int.
705 (char_width, c_string_width): Check for overflow when
706 computing the width; this is possible now that individual
707 characters can have unbounded width. Problem introduced
708 by merge from Emacs 23 on 2012-01-19.
710 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
712 * dbusbind.c (Fdbus_register_method): Mention the return value
713 :ignore in the docstring.
715 2012-02-02 Glenn Morris <rgm@gnu.org>
717 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
719 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
720 Unconditionally set to t. (Bug#10673)
721 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
722 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
723 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
725 2012-02-02 Kenichi Handa <handa@m17n.org>
727 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
728 0, do not call append_composite_glyph.
730 2012-02-02 Kenichi Handa <handa@m17n.org>
732 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
734 (x_produce_glyphs): If the component of a composition is a null
735 string, set it->pixel_width to 1 to avoid zero-width glyph.
737 2012-02-01 Eli Zaretskii <eliz@gnu.org>
739 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
740 first 2 arguments are identical. This makes inserting large
741 output from a subprocess an order of magnitude faster on
742 MS-Windows, where all sbrk'ed memory is always contiguous.
744 2012-01-31 Glenn Morris <rgm@gnu.org>
746 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
747 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
748 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
750 2012-01-29 Glenn Morris <rgm@gnu.org>
752 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
754 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
756 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
758 2012-01-28 Chong Yidong <cyd@gnu.org>
760 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
762 2012-01-26 Chong Yidong <cyd@gnu.org>
764 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
766 * search.c (Fsearch_forward, Fsearch_backward): Document negative
767 repeat counts (Bug#10507).
769 2012-01-26 Glenn Morris <rgm@gnu.org>
771 * lread.c (syms_of_lread): Doc fix.
773 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
775 * coding.c (encode_designation_at_bol): Change return value to
778 2012-01-25 Chong Yidong <cyd@gnu.org>
780 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
782 2012-01-21 Chong Yidong <cyd@gnu.org>
784 * floatfns.c (Fcopysign): Make the second argument non-optional,
785 since nil is not allowed anyway.
787 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
789 * process.c (read_process_output): Use p instead of XPROCESS (proc).
790 (send_process): Likewise.
792 2012-01-19 Martin Rudalics <rudalics@gmx.at>
794 * window.c (save_window_save, Fcurrent_window_configuration)
795 (Vwindow_persistent_parameters): Do not use Qstate.
798 2012-01-19 Kenichi Handa <handa@m17n.org>
800 * character.c (char_width): New function.
801 (Fchar_width, c_string_width, lisp_string_width):
802 Use char_width (Bug#9496).
804 2012-01-16 Martin Rudalics <rudalics@gmx.at>
806 * window.c (Vwindow_persistent_parameters): New variable.
807 (Fset_window_configuration, save_window_save): Handle persistent
810 2012-01-14 Eli Zaretskii <eliz@gnu.org>
812 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
813 thrashing the stack of the thread. (Bug#9087)
815 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
817 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
819 2012-01-11 Eli Zaretskii <eliz@gnu.org>
821 * xdisp.c (rows_from_pos_range): Handle the case where the
822 highlight ends on a newline. (Bug#10464)
823 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
824 he end column for display of highlight that ends on a newline
827 2012-01-11 Glenn Morris <rgm@gnu.org>
829 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
830 from load-path also when installation-directory is nil. (Bug#10208)
832 2012-01-10 Glenn Morris <rgm@gnu.org>
834 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
836 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
837 Update template values to be closer to their typical values these days.
839 2012-01-09 Eli Zaretskii <eliz@gnu.org>
841 * xdisp.c (rows_from_pos_range): Accept additional argument
842 DISP_STRING, and accept any glyph in a row whose object is that
843 string as eligible for mouse highlight. Fixes mouse highlight of
844 display strings from overlays. (Bug#10464)
846 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
848 emacs: fix an auto-save permissions race condition (Bug#10400)
849 * fileio.c (auto_saving_dir_umask): New static var.
850 (Fmake_directory_internal): Use it.
851 (do_auto_save_make_dir): Set it, instead of invoking chmod after
852 creating the directory. The old code temporarily assigns
853 too-generous permissions to the directory.
854 (do_auto_save_eh): Clear it.
855 (Fdo_auto_save): Catch all errors, not just file errors, so
856 that the var is always cleared.
858 2012-01-07 Eli Zaretskii <eliz@gnu.org>
860 * search.c (scan_buffer): Pass character positions to
861 know_region_cache, not byte positions. (Bug#6540)
863 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
865 * w32.c (sys_rename): Report EXDEV when rename of a directory
866 fails because the target is on another logical disk. (Bug#10284)
868 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
870 * xterm.c (x_embed_request_focus): New function.
872 * xterm.h: Add prototype.
874 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
876 2012-01-05 Glenn Morris <rgm@gnu.org>
878 * emacs.c (emacs_copyright): Update short copyright year to 2012.
880 2012-01-01 Eli Zaretskii <eliz@gnu.org>
882 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
883 Load gnutls_transport_set_lowat only if GnuTLS version is below
885 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
886 GnuTLS versions below 2.11.1.
888 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
890 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
891 to the doc string advising against its use for altering the way
892 windows are scrolled.
894 2011-12-28 Kenichi Handa <handa@m17n.org>
896 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
897 coding-system ASCII compatible only when it does not produce BOM
898 on encoding (Bug#10383).
900 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
902 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
904 (create_and_show_popup_menu): Always use menu_position_func for
907 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
909 * callint.c (Fcall_interactively): Don't truncate prompt string.
911 2011-12-23 Eli Zaretskii <eliz@gnu.org>
913 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
914 property that ends at ZV, so that the bidi iteration could be
915 resumed from there (after widening). (Bug#10360)
917 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
919 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
921 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
923 * nsterm.m (x_free_frame_resources):
924 Release f->output_data.ns->miniimage.
925 (ns_index_color): Fix indentation. Do not retain
926 color_table->colors[i].
928 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
931 * nsfns.m (x_set_background_color): Assign return value from
932 ns_index_color to face-background instead of NSColor*.
933 (ns_implicitly_set_icon_type): Fix indentation.
934 Change assignment in for loop to comparison.
936 * emacs.c (ns_pool): New variable.
937 (main): Assign ns_pool.
938 (Fkill_emacs): Call ns_release_autorelease_pool.
940 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
941 autorelease fdesc, release fdAttrs and tdict.
942 (ns_get_covering_families): Release charset.
943 (ns_findfonts): Release NSFontDescriptor created with new.
944 (ns_uni_to_glyphs): Fix indentation.
945 (setString): Release attrStr before assigning new value.
947 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
949 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
951 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
952 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
954 2011-12-18 David Reitter <reitter@cmu.edu>
956 * nsterm.m (ns_term_init): Subscribe for notifications
957 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
958 to method trackingNotification in EmacsMenu.
960 * nsmenu.m (trackingMenu): New variable.
961 (trackingNotification): New method (from Aquamacs).
962 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
963 from Aquamacs (Bug#7030).
965 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
967 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
968 (symbol_to_nsstring): Fix indentation.
969 (ns_symbol_to_pb): New function.
970 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
971 (Fns_rotate_cut_buffers_internal): Remove.
972 (Fns_store_selection_internal): Rename from
973 Fns_store_cut_buffer_internal.
974 (ns_get_foreign_selection, Fx_own_selection_internal)
975 (Fx_disown_selection_internal, Fx_selection_exists_p)
976 (Fns_get_selection_internal, Fns_store_selection_internal):
977 Use ns_symbol_to_pb and check if return value is nil.
978 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
979 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
980 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
981 renamed to Sns_store_selection_internal.
982 (ns_handle_selection_request): Move code to Fx_own_selection_internal
983 and remove this function.
984 (ns_handle_selection_clear): Remove, never used.
985 (Fx_own_selection_internal): Move code from ns_handle_selection_request
988 2011-12-17 Ken Brown <kbrown@cornell.edu>
990 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
991 GID is unknown (Bug#10257).
993 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
995 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
996 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
997 which caused a build failure on GNU/Linux IA-64. This problem was
998 introduced by my 2011-10-07 patch.
1000 2011-12-15 Juri Linkov <juri@jurta.org>
1002 * image.c (imagemagick_error): New function. (Bug#10112)
1003 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1004 Use `imagemagick_error' where ImageMagick functions return
1006 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1009 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1011 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1012 fill background (Bug#8992).
1014 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1016 * window.c (Vwindow_combination_resize)
1017 (Vwindow_combination_limit): Use t instead of non-nil in
1019 (Vrecenter_redisplay): Add first sentence of doc-string on
1021 (Frecenter): Fix doc-string typo.
1023 2011-12-11 Kenichi Handa <handa@m17n.org>
1025 * coding.c (Funencodable_char_position): Pay attention to the
1026 buffer text relocation (Bug#9389).
1028 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1030 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1031 gtk_init (Bug#10100).
1033 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1035 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1036 IT->string is nil. (Bug#10263)
1038 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1040 * nsterm.h (x_free_frame_resources): Declare.
1042 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1043 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1045 * nsterm.h (ns_get_defaults_value): Declare.
1047 * nsterm.m (ns_default): Call ns_get_defaults_value.
1049 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1051 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1054 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1056 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1057 that where the value of an _OBJC_* symbol points to is in the .bss
1058 section (Bug#10240).
1060 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1062 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1063 after the loop to call ccl_driver at least once (Bug#8619).
1065 2011-12-08 Kenichi Handa <handa@m17n.org>
1067 * ftfont.c (get_adstyle_property): Fix previous change
1070 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1072 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1073 dirs from the default value of EMACSLOADPATH (bug#10208).
1075 2011-12-07 Glenn Morris <rgm@gnu.org>
1077 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1078 installation and source directories as well. (Bug#10208)
1080 2011-12-06 Chong Yidong <cyd@gnu.org>
1082 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1084 2011-12-06 Glenn Morris <rgm@gnu.org>
1086 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1087 as an error, not just -1. (Bug#10217)
1089 2011-12-05 Chong Yidong <cyd@gnu.org>
1091 * keyboard.c (process_special_events): New function.
1092 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1094 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1096 * coding.c (encode_designation_at_bol): Don't use uninitialized
1097 local variable (Bug#9318).
1099 2011-12-05 Kenichi Handa <handa@m17n.org>
1101 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1102 return Qnil (Bug#8046, Bug#10193).
1104 2011-12-05 Kenichi Handa <handa@m17n.org>
1106 * coding.c (encode_designation_at_bol): New args charbuf_end and
1107 dst. Return the number of produced bytes. Callers changed.
1108 (coding_set_source): Return how many bytes coding->source was
1110 (coding_set_destination): Return how many bytes
1111 coding->destination was relocated.
1112 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1113 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1115 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1117 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1118 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1121 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1123 The following changes are to fix Bug#9318.
1125 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1126 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1127 (encode_coding_iso_2022, encode_coding_sjis)
1128 (encode_coding_big5, encode_coding_charset): Use the above macros.
1130 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1132 * lisp.h (process_quit_flag): Fix external declaration.
1134 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1136 Don't macro-inline non-performance-critical code.
1137 * eval.c (process_quit_flag): New function.
1138 * lisp.h (QUIT): Use it.
1140 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1142 * nsfns.m (get_geometry_from_preferences): New function.
1143 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1145 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1147 * emacs.c (Qkill_emacs): Define.
1148 (syms_of_emacs): Initialize it.
1149 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1150 Qquit_flag to `kill-emacs' instead.
1151 (quit_throw_to_read_char): Add parameter `from_signal'.
1152 All callers changed. Call Fkill_emacs if requested and safe.
1153 * lisp.h (QUIT): Call Fkill_emacs if requested.
1155 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1157 * widget.c (update_wm_hints): Return if wmshell is null.
1158 (widget_update_wm_size_hints): New function.
1160 * widget.h (widget_update_wm_size_hints): Declare.
1162 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1163 widget_update_wm_size_hints (Bug#10104).
1165 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1167 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1168 before a newline, prepare the bidi iterator for consuming the
1169 newline, and keep the current paragraph direction. (Bug#10183)
1170 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1172 2011-12-02 Juri Linkov <juri@jurta.org>
1174 * search.c (Fword_search_regexp): New Lisp function created from
1175 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1176 (Fword_search_backward, Fword_search_forward)
1177 (Fword_search_backward_lax, Fword_search_forward_lax):
1178 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1179 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1181 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1183 * fileio.c (Finsert_file_contents): Move after-change-function call
1184 to before the "handled:" label, since all "goto handled" appear in
1185 cases where the *-change-functions have already been properly called
1188 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1190 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1191 waiting for input. (Bug#10169)
1193 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1195 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1196 verifies glyph row's hash code--we have just reallocated the
1197 glyphs, so their contents can be complete garbage. (Bug#10164)
1199 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1201 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1203 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1205 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1206 attributes are tested _before_ calling verify_row_hash, to protect
1207 against GCC re-ordering of the tests. (Bug#10164)
1209 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1211 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1213 * xterm.c (handle_one_xevent): Only set async_visible and friends
1214 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1215 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1216 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1218 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1220 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1221 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1222 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1223 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1224 All uses changed to use GCPRO1 etc.
1225 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1226 Revert to old implementation (i.e., before 2011-03-11).
1228 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1230 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1231 of scroll runs so as to avoid assigning disabled bogus rows and
1232 unnecessary graphics copy operations.
1234 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1236 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1237 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1238 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1239 (malloc, free, realloc, calloc): Redirect to e_* only when
1242 * lisp.h (GCTYPEBITS): Move before first use.
1243 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1244 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1245 this macro definition.
1247 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1250 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1252 * gtkutil.c (xg_create_frame_widgets):
1253 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1254 present with Gtk+ 2.0.
1256 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1258 * fileio.c (Finsert_file_contents): Undo previous change; see
1259 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1261 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1263 Rename locals to avoid shadowing.
1264 * fileio.c (Finsert_file_contents):
1265 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1266 * process.c (wait_reading_process_output):
1267 Rename inner 'proc' to 'p' to avoid shadowing.
1268 Indent for consistency with usual Emacs style.
1270 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1272 * xdisp.c (redisplay_window): If cursor row is not fully visible
1273 after recentering, and scroll-conservatively is set to a large
1274 number, scroll window by a few more lines to make the cursor fully
1275 visible and out of scroll-margin. (Bug#10105)
1276 (start_display): Don't move to the next line if the display should
1277 start at a newline that is part of a display vector or an overlay
1280 2011-11-24 Juri Linkov <juri@jurta.org>
1282 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1283 after the `MagickPingImage' call. (Bug#10112)
1285 2011-11-23 Chong Yidong <cyd@gnu.org>
1287 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1289 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1291 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1292 making another buffer current. (Bug#10114)
1294 2011-11-23 Glenn Morris <rgm@gnu.org>
1296 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1298 2011-11-23 Chong Yidong <cyd@gnu.org>
1300 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1301 using it (Bug#5984).
1303 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1305 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1306 and header-lines, as they don't have one computed for them.
1309 * .gdbinit (prow): Make displayed values more self-explaining.
1310 Add row's hash code.
1312 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1314 * process.c (wait_reading_process_output): Fix asynchrounous
1315 GnuTLS socket handling on some versions of the GnuTLS library.
1316 (wait_reading_process_output): Add comment and URL.
1318 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1320 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1322 2011-11-21 Chong Yidong <cyd@gnu.org>
1324 * window.c (Fnext_window, Fprevious_window): Doc fix.
1326 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1328 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1330 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1332 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1334 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1336 * window.c (Fset_window_combination_limit): Rename argument
1338 (Vwindow_combination_limit): Remove "status" from doc-string.
1340 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1342 * m/ibms390.h: Remove.
1343 * m/ibms390x.h: Don't include "ibms390.h".
1345 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1347 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1348 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1350 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1352 * casetab.c (Fset_case_table):
1353 * charset.c (Fcharset_after): Fix typos.
1355 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1357 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1358 Otherwise, valgrind does not work on some platforms.
1359 Problem reported by Andreas Schwab in
1360 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1361 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1362 is set, removing the need for VIRT_ADDRESS_VARIES.
1363 (PURE_P): Use a more-efficient implementation that needs just one
1364 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1365 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1366 to 4 (xorl, subq, cmpq, setbe).
1367 * alloc.c (pure): Always extern now, since that's the
1368 VIRT_ADDR_VARIES behavior.
1369 (PURE_POINTER_P): Use a single comparison, not two, for
1370 consistency with the new puresize.h.
1371 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1372 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1373 Remove VIRT_ADDR_VARIES no longer needed.
1375 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1377 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1378 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1379 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1380 behave as if the cursor position were at the window margin.
1382 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1383 and the cursor position is out of bounds, behave as if the cursor
1384 position were at the window margin. (Bug#10075)
1386 2011-11-18 Chong Yidong <cyd@gnu.org>
1388 * window.c (Fwindow_combination_limit): Make first argument
1389 non-optional, since it is meaningless for live windows like the
1392 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1394 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1396 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1398 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1399 (graft_intervals_into_buffer): Simplify.
1401 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1403 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1404 hash values of the two rows.
1405 (copy_row_except_pointers): Preserve the used[] arrays and the
1406 hash values of the two rows. (Bug#10035)
1407 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1409 * xdisp.c (row_hash): New function, body extracted from
1410 compute_line_metrics.
1411 (compute_line_metrics): Call row_hash, instead of computing the
1414 * dispnew.c (verify_row_hash): Call row_hash for computing the
1415 hash code of a row, instead of duplicating code from xdisp.c.
1417 * dispextern.h (row_hash): Add prototype.
1419 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1421 * frame.c (delete_frame): Don't delete the terminal when the last
1422 X frame is closed if emacs is built with GTK toolkit.
1424 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1426 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1428 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1430 * window.c (Vwindow_splits): Rename to
1431 Vwindow_combination_resize. Suggested by Juri Linkov.
1432 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1435 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1437 * nsfns.m (Fns_font_name):
1438 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1440 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1442 * window.h (window): Rename slot "nest" to "combination_limit".
1443 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1444 (Fset_window_nest): Rename to Fset_window_combination_limit.
1445 (Vwindow_nest): Rename to Vwindow_combination_limit.
1446 (recombine_windows, make_parent_window, make_window)
1447 (Fsplit_window_internal, saved_window)
1448 (Fset_window_configuration, save_window_save): Rename all
1449 occurrences of window_nest to window_combination_limit.
1451 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1453 * image.c (imagemagick_load_image): Fix typo.
1455 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1457 * xdisp.c (display_line): Move the call to
1458 highlight_trailing_whitespace before the call to
1459 compute_line_metrics, since the latter needs to see the final
1460 faces of all the glyphs to compute ROW's hash value.
1461 Fixes assertion violations in row_equal_p. (Bug#10035)
1463 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1465 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1466 just return (bug#10044).
1468 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1470 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1471 with user-defined heap size. Bump the default size of the temacs
1472 heap to 27MB, to avoid memory warning when running temacs.
1473 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1475 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1476 current_matrix and desired_matrix. (Bug#9990)
1477 (verify_row_hash) [XASSERTS]: New function.
1478 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1479 that the hash value of glyph rows is correct.
1481 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1483 * window.h (window): Remove splits slot.
1484 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1485 (Fdelete_other_windows_internal, make_parent_window)
1486 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1487 (Fset_window_configuration, save_window_save): Don't deal with
1488 split status of windows.
1489 (saved_window): Remove splits slot.
1490 (Vwindow_splits): Rewrite doc-string.
1492 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1494 * xfns.c (unwind_create_frame):
1495 * nsfns.m (unwind_create_frame):
1496 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1497 Vframe_list (Bug#9999).
1499 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1501 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1503 2011-11-11 Kenichi Handa <handa@m17n.org>
1505 * callproc.c (Fcall_process): Set the member dst_multibyte of
1508 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1510 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1511 avoid a crash (bug#9496).
1513 2011-11-09 Chong Yidong <cyd@gnu.org>
1515 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1516 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1518 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1520 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1522 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1524 Avoid some portability problems by eschewing 'extern inline' functions.
1525 The trivial performance wins aren't worth the portability hassles; see
1526 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1528 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1529 (window_box_width, window_box_left, window_box_left_offset)
1530 (window_box_right, window_box_right_offset): Undo previous change,
1531 by removing the "extern"s.
1532 * intervals.c (adjust_intervals_for_insertion)
1533 (adjust_intervals_for_deletion): Undo previous change,
1534 making these static again.
1535 (offset_intervals, temp_set_point_both, temp_set_point)
1536 (copy_intervals_to_string): No longer inline.
1537 * xdisp.c (window_text_bottom_y, window_box_width)
1538 (window_box_height, window_box_left_offset)
1539 (window_box_right_offset, window_box_left, window_box_right)
1540 (window_box): No longer inline.
1542 2011-11-08 Chong Yidong <cyd@gnu.org>
1544 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1545 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1546 Signal an error if not a live window.
1547 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1548 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1550 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1552 * lisp.h (syms_of_abbrev): Remove declaration.
1553 Reported by CHENG Gao <chenggao@royau.me>.
1555 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1557 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1558 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1559 of temacs in GUI mode.
1561 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1563 * window.h: Declare delete_all_child_windows instead of
1564 delete_all_subwindows.
1565 * window.c (Fwindow_nest, Fset_window_nest)
1566 (Fset_window_new_total, Fset_window_new_normal)
1567 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1568 (delete_all_subwindows): Rename to delete_all_child_windows.
1569 (Fdelete_other_windows_internal, Fset_window_configuration):
1570 Call delete_all_child_windows instead of delete_all_subwindows.
1571 * frame.c (delete_frame): Call delete_all_child_windows instead
1572 of delete_all_subwindows.
1574 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1576 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1577 This is also needed for porting to any host where GC_MARK_STACK is
1578 not GC_MAKE_GCPROS_NOOPS.
1579 (which_symbols): Use it.
1581 2011-11-07 Kenichi Handa <handa@m17n.org>
1583 * coding.c (coding_set_destination): Check coding->src_pos only
1584 when coding->src_object is a buffer (bug#9910).
1586 * process.c (send_process): Set the member src_multibyte of coding
1587 to 0 (bug#9911) when sending a unibyte text.
1589 * callproc.c (Fcall_process): Set the member src_multibyte of
1590 process_coding to 0 (bug#9912).
1592 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1594 * xmenu.c (cleanup_widget_value_tree): New function.
1595 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1596 calling free_menubar_widget_value_tree directly (Bug#9830).
1598 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1600 Fix some portability problems with 'inline'.
1601 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1602 (window_box_width, window_box_left, window_box_left_offset)
1603 (window_box_right, window_box_right_offset): Declare extern.
1604 Otherwise, these inline functions do not conform to C99 and
1605 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1606 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1607 * intervals.c (adjust_intervals_for_insertion)
1608 (adjust_intervals_for_deletion): Now extern, because otherwise the
1609 extern inline functions 'offset_intervals' couldn't refer to it.
1610 (static_offset_intervals): Remove.
1611 (offset_intervals): Rewrite using the old contents of
1612 static_offset_intervals. The old version didn't conform to C99
1613 because an extern inline function contained a reference to an
1614 identifier with static linkage.
1616 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1618 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1621 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1623 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1624 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1625 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1626 return Qleft_to_right.
1628 2011-11-06 Chong Yidong <cyd@gnu.org>
1630 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1631 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1632 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1633 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1634 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1635 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1636 (Fwindow_vscroll): Doc fix.
1637 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1638 argument, since it makes no sense to pass a live window and for
1639 consistency with window-child.
1641 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1643 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1646 2011-11-05 Jason Rumney <jasonr@gnu.org>
1648 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1649 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1651 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1652 bitwise arithmetic preventing use of unicode-sip and non-truetype
1655 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1657 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1660 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1661 initialization code to keep similarity to xfns.c after changes
1664 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1666 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1667 (unwind_create_frame): New function (Bug#9943).
1668 (Fx_create_frame): Restructure code to be more similar to the one in
1669 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1670 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1671 Move terminal->reference_count++ just before making the frame official
1674 * nsterm.m (x_free_frame_resources): New function.
1675 (x_destroy_window): Move code to x_free_frame_resources.
1677 * xfns.c (unwind_create_frame): Fix comment.
1678 (Fx_create_frame, x_create_tip_frame):
1679 Move terminal->reference_count++ just before making the frame
1680 official. Move initialization of image_cache_refcount and
1681 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1683 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1685 Support MSVC build with newer versions of Visual Studio.
1686 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1687 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1690 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1691 which are not supported by MSVC.
1692 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1693 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1695 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1697 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1699 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1701 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1703 Support MSVC build with newer versions of Visual Studio.
1704 * w32.c: Don't include w32api.h for MSVC.
1705 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1707 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1708 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1709 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1710 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1712 (alloca) [_MSC_VER]: Define to _alloca.
1714 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1716 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1718 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1720 * xdisp.c (note_mouse_highlight): If either of
1721 previous/next-single-property-change returns nil, treat that as
1722 the beginning or the end of the buffer. (Bug#9955)
1724 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1726 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1727 label is not null (Bug#9951).
1728 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1731 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1733 * window.c (Fwindow_body_size): Mention in the doc string that the
1734 return value is in frame's canonical units. (Bug#9949)
1736 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1738 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1740 * w32fns.c (unwind_create_frame): If needed, free the glyph
1741 matrices of the partially constructed frame. (Bug#9943)
1742 * xfns.c (unwind_create_frame): Likewise.
1744 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1746 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1747 Don't stop backward scan on the continuation glyph, even though
1748 its CHARPOS is positive.
1749 (mouse_face_from_buffer_pos, note_mouse_highlight):
1750 Rename cover_string to disp_string.
1752 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1754 * window.c (temp_output_buffer_show): Don't use
1755 Vtemp_buffer_show_specifiers.
1756 (Vtemp_buffer_show_specifiers): Remove unused variable.
1758 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1760 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1761 past the beginning of the current glyph matrix.
1763 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1765 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1766 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1767 HAVE_GTK3 (Bug#9869).
1769 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1770 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1772 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1774 * xterm.c: Declare x_handle_net_wm_state to return int.
1775 (handle_one_xevent): Check if we are iconified but don't have
1776 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1777 (get_current_wm_state): Return non-zero if not hidden,
1778 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1779 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1780 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1781 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1783 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1785 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1786 so that this new function doesn't get optimized away by a
1787 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1789 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1791 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1793 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1795 Fix the `xbytecode' command.
1796 * .gdbinit (xprintbytestr): New command.
1797 (xwhichsymbols): Rename from `which'; all callers changed.
1798 (xbytecode): Print the byte-code string as well.
1800 2011-10-29 Kim Storm <storm@cua.dk>
1802 * alloc.c (which_symbols): New function.
1804 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1806 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1809 2011-10-29 Glenn Morris <rgm@gnu.org>
1811 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1812 Not clear what it was for, and it causes various bugs. (Bug#9839)
1814 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1816 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1817 possible random value that matches one of those tested as
1818 condition to clear the mouse face.
1820 2011-10-28 Chong Yidong <cyd@gnu.org>
1822 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1824 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1826 * window.c (make_window): Initialize phys_cursor_on_p.
1828 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1830 * lisp.h (struct Lisp_Symbol): Update comments.
1832 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1834 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1836 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1838 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1839 <oslsachem@gmail.com> for helping to debug this.
1841 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1842 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1843 (g_b_init_get_glyph_outline_w): New static variables.
1844 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1845 (GetGlyphOutlineW_Proc): New typedefs.
1846 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1847 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1849 (w32font_open_internal, compute_metrics):
1850 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1851 instead of calling the "wide" APIs directly.
1853 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1855 * w32.h (syms_of_w32font): Add prototype.
1857 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1859 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1860 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1861 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1862 (Fmove_to_window_line): Doc fix.
1864 2011-10-27 Chong Yidong <cyd@gnu.org>
1866 * process.c (make_process): Set gnutls_state to NULL.
1868 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1869 non-NULL, regardless of GNUTLS_INITSTAGE.
1870 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1871 an error. Set process slots as soon as we allocate them.
1873 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1875 2011-10-27 Chong Yidong <cyd@gnu.org>
1877 * gnutls.c (emacs_gnutls_deinit): New function.
1878 Deallocate credentials structures as well as calling gnutls_deinit.
1879 (Fgnutls_deinit, Fgnutls_boot): Use it.
1881 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1882 (deactivate_process): Call emacs_gnutls_deinit.
1884 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1886 * image.c (x_create_x_image_and_pixmap):
1887 * w32.c (sys_rename, w32_delayed_load):
1888 * w32font.c (fill_in_logfont):
1889 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1891 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1893 * w32fns.c (w32_default_color_map): New function,
1894 extracted from Fw32_default_color_map.
1895 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1897 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1899 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1901 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1903 * keyboard.c (test_undefined): New function (bug#9751).
1904 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1906 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1908 * sysdep.c (init_sys_modes): Fix the check for the controlling
1909 terminal (Bug#6649).
1911 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1913 * dispextern.h (struct bidi_it): New member next_en_type.
1915 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1916 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1917 current character, check also for next_en_type being WEAK_EN.
1918 (bidi_resolve_weak): Don't enter the expensive loop if the current
1919 position is before next_en_pos. Record the bidi type of the first
1920 non-ET, non-BN character we find, in addition to its position.
1921 (bidi_level_of_next_char): Invalidate next_en_type when
1922 next_en_pos is over-stepped.
1924 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1926 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1927 * editfns.c: Rewrite current-time-zone so that it invokes
1928 the equivalent of (format-time-string "%Z") to get the time zone name.
1929 This fixes a bug when the time zone name contains characters that
1930 need converting from the system time locale to Emacs internal format.
1931 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1932 that patch fixed format-time-string to do the conversion, but
1933 I forgot to fix current-time-zone.
1934 (format_time_string): New function, containing most of
1935 what Fformat_time_string used to contain.
1936 (Fformat_time_string): Rewrite in terms of format_time_string.
1937 This doesn't change this function's behavior.
1938 (current-time-zone): Rewrite to use format_time_string.
1939 This fixes the bug reported by Michael Schierl in
1940 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1941 Jason Rumney's 2007-06-07 change worked around this bug, but
1943 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1945 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (start_display): If the character at POS is displayed
1948 via a display vector, reset IT->current.dpvec_index to zero.
1949 (try_window_reusing_current_matrix): If a line ends in a display
1950 vector or the next line starts in a display vector, continue
1951 redrawing the window even though the character position of
1952 start_row was reached.
1955 2011-10-18 Chong Yidong <cyd@gnu.org>
1957 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1958 with nobreak-char-display too.
1960 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1962 Fix part 3 of bug#9771.
1963 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1964 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1965 non-neutral characters if the current character is a paragraph
1966 separator (a.k.a. Newline). This avoids running the same
1967 expensive loop twice, once when we consume the preceding newline
1968 and the other time when the line actually needs to be displayed.
1969 Avoid the loop when we see neutrals on the base embedding level
1970 following a character whose directionality is the same as the
1971 paragraph's. This avoids running the expensive loop when a line
1972 ends in a long sequence of neutrals, like control characters.
1973 Add assertion against STRONG_AL type. Slightly rearrange code
1974 that determines the type of a neutral given the first non-neutral
1976 (bidi_level_of_next_char): Set next_en_pos to zero when
1977 invalidating its info.
1979 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (push_display_prop): Determine whether to record string
1982 or buffer position by IT->string, not by IT->method. Allow
1983 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1984 (move_it_vertically_backward): Don't look for character position
1985 immediately after the newline when in a continuation line.
1988 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1990 * window.c (coordinates_in_window): Rewrite and delabelize
1991 vertical border check. (Bug#5357) (Bug#9618)
1993 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1995 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1996 errors in XSetWindowBorder (bug#9310).
1998 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2000 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2001 avoid crash when xmalloc overrun checking is enabled.
2003 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2005 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2006 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2007 cursor motion with <left> and <right> arrow keys.
2009 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2010 some callers set that themselves.
2012 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2015 display string and the previous row comes from the same string and
2016 is empty. (Bug#9739) (Bug#9738)
2018 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2020 * doc.c (get_doc_string): Encode file name (bug#9735).
2022 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2024 * bidi.c (bidi_level_of_next_char):
2025 * xdisp.c (get_visually_first_element): Remove old incorrect
2026 comments regarding the Unicode Line Separator character.
2028 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2030 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2032 * alloc.c (Fgc_status): Do not access beyond zombies array
2033 boundary if nzombies > MAX_ZOMBIES.
2034 * alloc.c (dump_zombies): Add missing format specifier.
2036 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2038 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2039 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2041 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2042 Some packages use them to denote characters with modifiers.
2044 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2046 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2047 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2048 matching a pp-number. Rename parameter var to var1.
2050 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2052 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2054 2011-10-08 Glenn Morris <rgm@gnu.org>
2056 * callint.c (Fcall_interactively): Give a more explicit error for the
2057 'c' case with a non-character input. (Bug#8479)
2059 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2061 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2063 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2064 lines that are hscrolled on the left.
2066 * dispnew.c (buffer_posn_from_coords): Account for a possible
2067 presence of header-line. (Bug#4426)
2069 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2071 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2072 Don't advertise functionality which we discourage or doesn't work.
2074 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2076 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2077 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2078 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2079 this makes Emacs dump core during garbage collection on rare
2080 occasions. sizeof is obviously inferior to offsetof here, so
2081 stick with offsetof.
2082 (GC_POINTER_ALIGNMENT): New macro.
2083 (mark_memory): Omit 3rd (offset) arg; caller changed.
2084 Don't assume EMACS_INT alignment is the same as pointer alignment.
2086 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2088 * keyboard.c (read_key_sequence_remapped): New var.
2089 (read_key_sequence): Compute remapping in the right buffer.
2090 (command_loop_1): Use read_key_sequence's remapping directly.
2092 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2094 * dired.c (file_name_completion): Don't expand file name.
2095 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2096 before checking file name handler.
2098 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2099 they've been requested explicitly (bug#9591).
2101 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2103 * keymap.c (Fsingle_key_description): Use make_specified_string
2104 instead of build_string to build string from push_key_description.
2107 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2109 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2110 This fixes a Y2038 bug on 64-bit hosts.
2111 * buffer.c (reset_buffer):
2112 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2113 (Fclear_buffer_auto_save_failure):
2114 Use 0, not -1, to represent an unset failure time, since time_t
2115 might not be signed.
2117 Remove dependency on glibc malloc internals.
2118 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2119 Move back here from lisp.h, but with their new implementations.
2120 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2121 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2122 * charset.c (charset_table_init): New static var.
2123 (syms_of_charset): Use it instead of xmalloc. This removes a
2124 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2125 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2126 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2127 Move back to alloc.c.
2128 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2129 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2131 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2133 * nsterm.m (windowDidResize): Call x_set_window_size only when
2134 ns_in_resize is true. Otherwise set pixelwidth/height and
2135 call change_frame_size (Bug#9628).
2137 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2139 Port --enable-checking=all to Fedora 14 x86-64.
2140 * charset.c (syms_of_charset): Also account for glibc malloc's
2141 internal overhead when calculating the initial malloc maximum.
2143 Port --enable-checking=all to Fedora 14 x86.
2144 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2146 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2147 (overrun_check_realloc, overrun_check_free):
2148 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2149 That way, xmalloc returns a properly-aligned pointer even if
2150 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2151 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2152 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2153 into account when calculating the initial malloc maximum.
2154 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2155 Move here from alloc.c, so that charset.c can use it too.
2156 Properly align; the old code wasn't right for common 32-bit hosts
2157 when configured with --enable-checking=all.
2158 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2159 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2161 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2163 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2166 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (compute_display_string_end): If there's no display
2169 string at CHARPOS, return -1.
2171 * bidi.c (bidi_fetch_char): When compute_display_string_end
2172 returns a negative value, treat the character as a normal
2173 character not covered by a display string. (Bug#9624)
2175 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2177 * lread.c (Fread_from_string): Fix typo in docstring.
2179 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2181 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2182 newline, reseat the iterator instead of bidi-iterating there one
2183 character at a time. (Bug#9610)
2184 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2185 TO_CHARPOS if the bidi iterator is at base embedding level.
2187 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2189 * lread.c (readevalloop): Use correct code for NBSP.
2190 (read1): Likewise. (Bug#9608)
2192 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2194 * dbusbind.c (Fdbus_register_signal): When service is not
2195 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2197 2011-09-25 Glenn Morris <rgm@gnu.org>
2199 * buffer.c (truncate-lines): Doc fix.
2201 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2203 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2204 (Fset_window_next_buffers): Doc fix.
2206 2011-09-24 Glenn Morris <rgm@gnu.org>
2208 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2210 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2212 Fix minor problems found by static checking.
2213 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2214 * indent.c (Fvertical_motion): Fix == vs = typo.
2216 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2218 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2219 Default value is now t. Doc fix.
2221 * indent.c (Fvertical_motion): Compute and apply the overshoot
2222 logic when moving up, not only when moving down. Fix the
2223 confusing name and values of the it_overshoot_expected variable;
2224 logic changes accordingly. (Bug#9254) (Bug#9549)
2226 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2227 CHARPOS is covered by a display string which includes newlines.
2228 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2229 is covered by a display string with embedded newlines.
2231 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2233 * dbusbind.c (Fdbus_register_signal): Add match rule to
2234 Vdbus_registered_objects_table. (Bug#9581)
2235 (Fdbus_register_method, Vdbus_registered_objects_table):
2238 2011-09-24 Jim Meyering <meyering@redhat.com>
2240 do not ignore write error for any output size
2241 The previous change was incomplete.
2242 While it makes emacs --batch detect the vast majority of stdout
2243 write failures, errors were still ignored whenever the output size is
2244 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2245 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2246 && echo FAIL: ignored write error
2247 FAIL: ignored write error
2248 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2249 && echo FAIL: ignored write error
2250 FAIL: ignored write error
2251 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2253 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2255 * emacs.c (Fkill_emacs): In noninteractive mode exit
2256 non-successfully if a write error occurred on stdout. (Bug#9574)
2258 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2263 * dispextern.h (struct it): Update the comment documenting what
2266 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2268 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2269 a display string, extend search for cursor position to end of row.
2270 (find_row_edges): If the row ends in a newline from a display
2271 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2272 Handle the case of a display string with multiple newlines.
2273 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2274 non-empty line. Fixes confusing cursor motion with arrow keys at
2275 the beginning of a line that starts with whitespace.
2277 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2279 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2282 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2284 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2287 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2289 * xdisp.c (display_line): Record maximum and minimum buffer
2290 positions even if no glyphs were produced (e.g., by a zero-width
2291 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2292 buffer positions that will be removed from the glyph row because
2294 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2295 column is beyond frame width: don't subtract 1 "pixel" when
2296 computing width of the stretch.
2297 (reseat_at_next_visible_line_start): Undo the change made on
2298 2011-09-17 that saved paragraph information and restored it after
2299 the call to `reseat'. (Bug#9545)
2301 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2303 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2304 and turn window cursor on if cleared (Bug#9415).
2306 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2308 * search.c (boyer_moore): Take unibyte characters from pattern
2309 literally. (Bug#9458)
2311 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2313 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2315 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2317 Fix minor problem found by static checking.
2318 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2319 initialized, to pacify gcc -Wuninitialized.
2321 * fileio.c: Report proper errno when syscall falls.
2322 (Finsert_file_contents): Save and restore errno,
2323 so that report_file_error outputs the correct diagnostic.
2324 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2326 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2328 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2330 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2332 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2333 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2335 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2337 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2338 about the current paragraph and restore it after the call to reseat.
2340 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2341 (bidi_find_paragraph_start): Search back for paragraph beginning
2342 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2343 (bidi_move_to_visually_next): Only trigger paragraph-related
2344 computations when the last character is a newline or at EOB, not
2345 just any NEUTRAL_B. (Bug#9470)
2347 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2348 truncated lines if point is covered by a display string. (Bug#9524)
2350 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2352 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2353 (cons_to_x_long): New function.
2354 (lisp_data_to_selection_data): Use it. Correct the test for
2355 short-versus-long data; it was negated. Break out of vector
2356 loop, for efficiency, when a long datum is discovered.
2358 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2360 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2362 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2364 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2365 GCC PR/17406) by declaring this function with external scope.
2367 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2369 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2370 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2372 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2374 * editfns.c (Fformat): Correctly handle text properties on "%%".
2376 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2378 * xterm.c (x_draw_composite_glyph_string_foreground):
2379 * w32term.c (x_draw_composite_glyph_string_foreground):
2380 * term.c (encode_terminal_code):
2381 * composite.c (composition_update_it, get_composition_id):
2382 * xdisp.c (get_next_display_element)
2383 (fill_composite_glyph_string): Add comments about special meaning
2384 of TAB characters in a composition.
2386 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2388 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2389 This occurs when processing a multibyte format.
2390 Problem reported by Wolfgang Jenker.
2392 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2394 * xdisp.c (try_cursor_movement): Only check for exact match if
2395 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2397 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2399 Remove unused external symbols.
2400 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2401 * xdisp.c (calc_pixel_width_or_height): Now static.
2402 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2403 * indent.c (check_display_width):
2404 * w32term.c: Fix comment to match code.
2405 * xterm.c, xterm.h (x_catching_errors): Remove.
2407 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2409 * xselect.c: Use signed conversions more consistently (Bug#9498).
2410 (selection_data_to_lisp_data): Assume incoming selection data are
2411 signed integers, not unsigned. This is to be consistent with
2412 outgoing selection data, which was modified to use signed integers
2413 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2414 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2415 expects long, not unsigned long.
2417 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2419 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2420 computation of loop end. Reported by Johan Bockgård
2423 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2425 * frame.c (Fother_visible_frames_p): Function deleted.
2427 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2429 * indent.c (compute_motion): Process display vector front to back
2430 rather than the other way around. (Bug#2496)
2432 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2434 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2436 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2438 * minibuf.c (Fread_from_minibuffer): Doc fix.
2440 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2442 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2443 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2445 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2447 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2448 value for non-existent files.
2450 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2452 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2453 set its "size" to -1. This will set the modtime_size field of
2454 the corresponding buffer to -1, which is what
2455 verify-visited-file-modtime expects for files that do not exist.
2458 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2460 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2462 * lisp.h: ... from here. push_key_description is no longer
2463 defined in keyboard.c, so its declaration should not be in
2464 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2465 logically belongs with push_key_description.
2467 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2469 * buffer.h: Include <sys/types.h> instead of <time.h>.
2470 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2471 Problem reported by Herbert J. Skuhra.
2473 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2475 * xml.c (parse_region): Make the parsing work for
2476 non-comment-starting XML files again (bug#9144).
2478 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2480 * image.c (gif_load): Fix calculation of bottom and right corner.
2483 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2485 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2486 redisplay in small windows.
2488 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2490 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2492 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2494 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2495 Operate on live windows only.
2497 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2499 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2501 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2503 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2504 only under bidi iteration.
2506 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2508 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2510 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2512 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2513 Without this fix, the command to link temacs failed due to an
2514 undefined symbol __builtin_isnan. This is because
2515 /usr/include/iso/math_c99.h #defines isnan(x) to
2516 __builtin_isnan(x), but the bundled gcc, which identifies itself
2517 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2519 * floatfns.c (isnan): #undef, and then #define to a clone of
2521 (Fisnan): Always define, since it's always available now.
2522 (syms_of_floatfns): Always define isnan at the Lisp level.
2524 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2526 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2528 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2530 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2531 The previous code assumed that file offsets (off_t values) fit in
2532 EMACS_INT variables, which is not true on typical 32-bit hosts.
2533 The code messed up by falsely reporting buffer overflow in cases
2534 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2535 when "big" contains more than 2**29 bytes, even though this
2536 inserts just one byte and does not overflow the buffer.
2537 (Finsert_file_contents): Store file offsets as off_t
2538 values, not as EMACS_INT values. Check for overflow when
2539 converting between EMACS_INT and off_t. When checking for
2540 buffer overflow or for overlap, take the offsets into account.
2541 Don't use EMACS_INT for small values where int suffices.
2542 When checking for overlap, fix a typo: ZV was used where
2543 ZV_BYTE was intended.
2544 (Fwrite_region): Don't assume off_t fits into 'long'.
2545 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2547 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2549 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2551 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2553 sprintf-related integer and memory overflow issues (Bug#9412).
2555 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2556 (esprintf, exprintf, evxprintf): New functions.
2557 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2558 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2559 (modify_event_symbol): Do not assume that the length of
2560 name_alist_or_stem is safe to alloca and fits in int.
2561 (Fexecute_extended_command): Likewise for function name and binding.
2562 (Frecursion_depth): Wrap around reliably on integer overflow.
2563 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2564 since some callers pass EMACS_INT values.
2565 (Fsingle_key_description): Don't crash if symbol name contains more
2566 than MAX_ALLOCA bytes.
2567 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2568 (get_minibuffer): Arg is now EMACS_INT, not int.
2569 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2570 (esprintf, exprintf, evxprintf): New decls.
2571 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2573 * dbusbind.c (signature_cat): New function.
2574 (xd_signature, Fdbus_register_signal):
2575 Do not overrun buffer; instead, report string overflow.
2577 * dispnew.c (add_window_display_history): Don't overrun buffer.
2578 Truncate instead; this is OK since it's just a log.
2580 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2581 even if the time zone offset is outlandishly large.
2582 Don't mishandle offset == INT_MIN.
2584 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2585 when creating daemon; the previous buffer-overflow check was incorrect.
2587 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2588 which has the guts of the old verror function.
2590 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2591 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2593 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2594 (font_unparse_xlfd): Don't blindly alloca long strings.
2595 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2596 fits in int, when using sprintf. Use single snprintf to count
2597 length of string rather than counting it via multiple sprintfs;
2598 that's simpler and more reliable.
2599 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2600 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2601 sprintf, in case result does not fit in int.
2603 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2604 (fontset_from_font): Print it.
2606 * frame.c (tty_frame_count): Now printmax_t, not int.
2607 (make_terminal_frame, set_term_frame_name): Print it.
2608 (x_report_frame_params): In X, window IDs are unsigned long,
2609 not signed long, so print them as unsigned.
2610 (validate_x_resource_name): Check for implausibly long names,
2611 and don't assume name length fits in 'int'.
2612 (x_get_resource_string): Don't blindly alloca invocation name;
2613 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2616 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2617 (xg_check_special_colors, xg_set_geometry):
2618 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2620 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2621 Use esprintf, not sprintf, in case result does not fit in int.
2623 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2624 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2625 it as a large positive number.
2626 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2627 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2629 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2630 in case result does not fit in int.
2632 * print.c (float_to_string): Detect width overflow more reliably.
2633 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2634 buffer overrun. Don't assume list length fits in 'int'. Treat
2635 print length of 0 as 0, not as infinity; to be consistent with other
2636 uses of print length in this function. Don't overflow print length
2637 index. Don't assume hash table size fits in 'long', or that
2638 vectorlike size fits in 'unsigned long'.
2640 * process.c (make_process): Use printmax_t, not int, to format
2641 process-name gensyms.
2643 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2645 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2646 to avoid potential buffer overrun.
2648 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2649 if X resource line is longer than 512 bytes.
2651 * xfns.c (x_window): Make sprintf buffer a bit bigger
2652 to avoid potential buffer overrun.
2654 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2656 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2658 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2660 Integer overflow fixes for scrolling, etc.
2661 Without these, Emacs silently mishandles large integers sometimes.
2662 For example, "C-u 4294967297 M-x recenter" was treated as if
2663 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2665 * xdisp.c (try_window_id): Check Emacs fixnum range before
2666 converting to 'int'.
2668 * window.c (window_scroll_line_based, Frecenter):
2669 Check that an Emacs fixnum is in range before assigning it to 'int'.
2670 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2671 values converted from Emacs fixnums.
2672 (Frecenter): Don't wrap around a line count if it is out of 'int'
2673 range; instead, treat it as an extreme value.
2674 (Fset_window_configuration, compare_window_configurations):
2675 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2677 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2678 that can exceed INT_MAX. Check that EMACS_INT value is in range
2679 before assigning it to the (possibly-narrower) index.
2680 (match_limit): Don't assume that a fixnum can fit in 'int'.
2682 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2685 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2686 (Fvertical_motion): Don't wrap around LINES values that don't fit
2687 in 'int'. Instead, treat them as extreme values. This is good
2688 enough for windows, which can't have more than INT_MAX lines anyway.
2690 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2692 * Require libxml/parser.h to avoid compilation warning.
2694 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2696 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2697 since this reportedly can destroy thread storage.
2699 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2701 * syntax.c (find_defun_start): Update all cache variables if
2702 exiting early (Bug#9401).
2704 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2706 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2708 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2709 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2710 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2712 * term.c (tty_append_glyph): New function.
2713 (produce_stretch_glyph): Static function and its prototype deleted.
2715 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2718 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2720 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2721 when checking :margin (Bug#9390).
2722 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2723 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2724 so that the name doesn't mislead. All uses changed.
2726 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2728 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2731 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2733 * xdisp.c (move_it_to): Don't bail out early when reaching
2734 position beyond to_charpos, if we are scanning backwards.
2735 (move_it_vertically_backward): When DY == 0, make sure we get to
2736 the first character in the line after the newline.
2738 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2740 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2741 (ccl_driver): Do not generate an out-of-range pointer.
2742 (Fccl_execute_on_string): Remove unnecessary check for
2743 integer overflow, noted by Stefan Monnier in
2744 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2745 Remove a FIXME that didn't need fixing.
2746 Simplify the newly-introduced buffer reallocation code.
2748 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2750 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2752 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2754 Integer and memory overflow issues (Bug#9196).
2756 * doc.c (get_doc_string): Rework so that
2757 get_doc_string_buffer_size is the actual buffer size, rather than
2758 being 1 less than the actual buffer size; this makes xpalloc more
2761 * image.c (x_allocate_bitmap_record, cache_image):
2762 * xselect.c (Fx_register_dnd_atom):
2763 Simplify previous changes by using xpalloc.
2765 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2766 since either will do and ptrdiff_t is convenient with xpalloc.
2768 * charset.c (charset_table_size)
2769 (struct charset_sort_data.priority): Now ptrdiff_t.
2770 (charset_compare): Don't overflow if priorities differ greatly.
2771 (Fsort_charsets): Don't assume list length fits in int.
2772 Check for size-calculation overflow when allocating sort data.
2773 (syms_of_charset): Allocate an initial charset table that is
2774 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2776 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2778 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2779 The actual value is always <= INT_MAX, and leaving it unsigned made
2780 overflow checking harder.
2782 * dispextern.h (struct glyph_matrix.rows_allocated)
2783 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2784 with xpalloc. The values are still always <= INT_MAX.
2786 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2788 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2789 (SAFE_NALLOCA): New macro.
2791 * region-cache.c (struct boundary.pos, find_cache_boundary)
2792 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2793 (set_cache_region, invalidate_region_cache)
2794 (revalidate_region_cache, know_region_cache, region_cache_forward)
2795 (region_cache_backward, pp_cache):
2796 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2797 so that ptrdiff_t * can be passed to xpalloc.
2798 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2799 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2800 (pp_cache): Don't assume cache_len fits in int.
2801 * region-cache.h: Adjust extern decls to match.
2803 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2804 EMACS_INT, since either will do, for xpalloc.
2806 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2807 (xnmalloc, xnrealloc, xpalloc): New functions.
2809 * bidi.c (bidi_shelve_header_size): New constant.
2810 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2811 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2813 * bidi.c (bidi_cache_shrink):
2814 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2816 Don't update size of array until after memory allocation succeeds,
2817 because xmalloc/xrealloc may not return.
2818 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2819 now that we have proper integer overflow checking.
2820 (record_overlay_string, overlay_strings): Catch overflows when
2821 calculating size of overlay_str_buf.
2823 * callproc.c (Fcall_process): Check for size overflow when
2824 calculating size of args2.
2825 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2826 Normally we prefer signed values, but sticking with ptrdiff_t would
2827 require adding more-complicated checks.
2829 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2830 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2831 Redo buffer-overflow calculations to avoid integer overflow.
2832 Add a FIXME comment where memory seems to be over-allocated.
2834 * character.c (Fstring): Check for size-calculation overflow.
2836 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2837 unnecessary integer overflow. Check for size overflow.
2838 (encode_coding_object): Don't update size until xmalloc succeeds.
2840 * composite.c (get_composition_id): Check for overflow in glyph
2841 length calculations.
2843 Integer and memory overflow fixes for display code.
2844 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2845 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2846 (scrolling_window): Check for overflow in size calculations.
2847 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2848 Don't assume glyph table len fits in int.
2849 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2850 (row_table_size): Now ptrdiff_t, not int.
2851 (scrolling_window): Avoid overflow in size calculations.
2852 Don't update size until allocation succeeds.
2853 * fns.c (concat): Check for overflow in size calculations.
2854 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2855 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2856 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2858 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2859 (get_doc_string): Check for size calculation overflow.
2860 Don't update size until allocation succeeds.
2861 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2862 EMACS_INT, where ptrdiff_t will do.
2863 (Fsubstitute_command_keys): Check for string overflow.
2865 * editfns.c (set_time_zone_rule): Don't assume environment length
2867 (message_length): Now ptrdiff_t, not int.
2868 (Fmessage_box): Don't update size until allocation succeeds.
2869 Don't assume message length fits in int.
2870 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2872 * emacs.c (main): Do not reallocate argv, since there is a null at
2873 the end that can be overwritten, and this way there's no need to
2874 worry about size-calculation overflow.
2875 (sort_args): Check for size-calculation overflow.
2877 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2879 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2881 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2882 (x_set_scroll_bar_width, x_figure_window_size):
2883 Check for integer overflow.
2884 (x_set_alpha): Do not assume XINT fits in int.
2886 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2887 This is for the members text_lines, text_cols, total_lines, total_cols,
2888 where the system imposes an 'int' limit.
2890 * fringe.c (Fdefine_fringe_bitmap):
2891 Don't update size until alloc works.
2893 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2894 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2896 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2897 Check for size-calculation overflow.
2898 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2899 do, as we prefer signed integers.
2900 (id_to_widget.max_size, id_to_widget.used)
2901 (xg_store_widget_in_map, xg_remove_widget_from_map)
2902 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2903 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2904 Use and return ptrdiff_t, not int.
2905 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2906 * gtkutil.h: Change prototypes to match the above.
2908 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2909 are duplicate now that they've been promoted to lisp.h.
2910 (x_allocate_bitmap_record, x_alloc_image_color)
2911 (make_image_cache, cache_image, xpm_load):
2912 Don't update size until alloc is done.
2913 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2915 Check for size calculation overflow.
2916 (ct_colors_allocated_max): New constant.
2917 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2920 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2921 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2922 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2923 Use ptrdiff_t, not int, to count maps.
2924 (read_char_minibuf_menu_prompt): Check for overflow in size
2925 calculations. Don't update size until allocation succeeds.
2926 Redo calculations to avoid overflow.
2927 * keyboard.h: Change prototypes to match the above.
2929 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2931 (current_minor_maps): Check for size calculation overflow.
2932 * keymap.h: Change prototypes to match the above.
2934 * lread.c (read1, init_obarray): Don't update size until alloc done.
2936 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2937 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2939 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2940 Now ptrdiff_t, not int.
2941 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2942 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2944 * process.c (Fnetwork_interface_list): Check for overflow
2945 in size calculation.
2947 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2949 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2950 overflow. Don't bother calling xmalloc when xrealloc will do.
2952 * search.c (Freplace_match): Check for size calculation overflow.
2953 (Fset_match_data): Don't assume list lengths fit in 'int'.
2955 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2956 for command line length. Do not attempt to address one before the
2957 beginning of an array, as that's not portable.
2959 * term.c (max_frame_lines): Remove; unused.
2960 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2962 (encode_terminal_code, calculate_costs): Check for size
2963 calculation overflow.
2964 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2965 table lengths and related sizes. Don't update size until alloc
2966 done. Redo calculations to avoid overflow.
2967 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2969 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2970 subtracting pointers.
2971 (gobble_line): Check for overflow more carefully. Don't update size
2974 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2975 Don't update size until alloc done.
2976 Redo size calculations to avoid overflow.
2977 Check for size calculation overflow.
2978 (main) [DEBUG]: Fix typo in invoking tparam1.
2980 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2981 Use ptrdiff_t, not int, for sizes.
2982 (store_mode_line_noprop_char): Don't update size until alloc done.
2984 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2985 Use ptrdiff_t, not int, for sizes.
2986 (Finternal_make_lisp_face, cache_face):
2987 Check for size calculation overflow.
2988 (cache_face): Treat size calculation overflows as if they were
2989 memory exhaustion (the usual treatment), rather than aborting.
2991 * xfns.c (x_encode_text, x_set_name_internal)
2992 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2993 sizes, since they can exceed INT_MAX in size. Check for size
2994 calculation overflow.
2996 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2997 (xg_select): Check for size calculation overflow.
2998 Don't update size until alloc done.
3000 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3001 as sprintf is limited to int lengths.
3003 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3004 (X_LONG_MIN): New macros.
3005 Use them to make the following changes clearer.
3006 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3007 This change doesn't affect the value now, but it may help remind
3008 future maintainers not to raise the value too much later.
3009 (SELECTION_QUANTUM): Remove, replacing with ...
3010 (selection_quantum): ... new function, which avoids overflow.
3012 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3013 assumption that selection length fits in 'int'.
3014 (x_reply_selection_request, x_handle_selection_request)
3015 (x_get_window_property, receive_incremental_selection)
3016 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3017 (lisp_data_to_selection_data, clean_local_selection_data):
3018 Use ptrdiff_t, not int, to record length of selection.
3019 (x_reply_selection_request, x_get_window_property)
3020 (receive_incremental_selection, x_property_data_to_lisp):
3021 Redo calculations to avoid overflow.
3022 (x_reply_selection_request): When sending hint, ceiling it at
3023 X_LONG_MAX rather than relying on wraparound overflow to send
3025 (x_get_window_property, receive_incremental_selection)
3026 (lisp_data_to_selection_data, x_property_data_to_lisp):
3027 Check for size-calculation overflow.
3028 (x_get_window_property, receive_incremental_selection)
3029 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3030 Don't store size until memory allocation succeeds.
3031 (x_get_window_property): Plug memory leak on memory exhaustion.
3032 Don't double-block input; malloc is safe here. Don't assume 2**34
3033 - 4 fits in unsigned long. Add an xassert to check
3034 XGetWindowProperty overflow. Be more careful about overflow
3035 calculations, and distinguish size from memory overflow better.
3036 (receive_incremental_selection): When tracing, don't assume
3037 unsigned int is less than INT_MAX.
3038 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3039 harmful) conversions of unsigned short to int.
3040 (lisp_data_to_selection_data): Don't assume that integers
3041 in the range -65535 through -1 fit in an X unsigned short.
3042 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3043 result parameters unless successful. Rely on cons_to_unsigned
3044 to report problems with elements; the old code wasn't right anyway.
3045 (x_check_property_data): Check for int overflow; we cannot use
3046 a wider type due to X limits.
3047 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3049 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3051 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3052 (x_term_init): Check for size calculation overflow.
3053 (x_color_cells): Don't store size until memory allocation succeeds.
3054 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3055 Don't assume alloca size is less than MAX_ALLOCA.
3056 (x_term_init): Don't assume length fits in int (sprintf is limited
3059 Use ptrdiff_t for composition IDs.
3060 * character.c (lisp_string_width):
3061 * composite.c (composition_table_size, n_compositions)
3062 (get_composition_id, composition_gstring_from_id):
3063 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3064 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3065 * window.c (Frecenter):
3066 Use ptrdiff_t, not int, for composition IDs.
3067 * composite.c (get_composition_id): Check for integer overflow.
3068 * composite.h: Adjust prototypes to match the above changes.
3070 Use ptrdiff_t for hash table indexes.
3071 * category.c (hash_get_category_set):
3072 * ccl.c (ccl_driver):
3073 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3074 * coding.c (coding_system_charset_list, detect_coding_system):
3075 * coding.h (struct coding_system.id):
3076 * composite.c (get_composition_id, gstring_lookup_cache):
3077 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3078 * image.c (xpm_get_color_table_h):
3079 * lisp.h (hash_lookup, hash_put):
3080 * minibuf.c (Ftest_completion):
3081 Use ptrdiff_t for hash table indexes, not int (which is too
3082 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3083 32-bit --with-wide-int hosts).
3085 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3086 Add a FIXME comment about memory leaks.
3087 (syms_of_charset): Don't assume xmalloc returns.
3089 Don't assume that stated character widths fit in int.
3090 * character.c (Fchar_width, c_string_width, lisp_string_width):
3091 * character.h (CHAR_WIDTH):
3092 * indent.c (MULTIBYTE_BYTES_WIDTH):
3093 Use sanitize_char_width to avoid undefined and/or bad behavior
3094 with outlandish widths.
3095 * character.h (sanitize_tab_width): Rename from sanitize_width,
3096 now that we have two such functions. All uses changed.
3097 (sanitize_char_width): New inline function.
3099 Don't assume that tab-width fits in int.
3100 * character.h (sanitize_width): New inline function.
3101 (SANE_TAB_WIDTH): New macro.
3102 (ASCII_CHAR_WIDTH): Use it.
3103 * indent.c (sane_tab_width): Remove. All uses replaced by
3104 SANE_TAB_WIDTH (current_buffer).
3105 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3107 * fileio.c: Integer overflow issues with file modes.
3108 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3110 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3111 Remove unreachable code.
3112 (read_hex, load_charset_map_from_file): Check for integer overflow.
3114 * xterm.c: Don't go over XClientMessageEvent limit.
3115 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3116 (x_send_scroll_bar_event): Likewise. Check that the size does not
3117 exceed limits imposed by XClientMessageEvent, as well as the usual
3118 ptrdiff_t and size_t limits.
3120 * keyboard.c: Overflow, signedness and related fixes.
3121 (make_lispy_movement): Use same integer type in forward decl
3122 that is used in the definition.
3123 (read_key_sequence, keyremap_step):
3124 Change bufsize argument back to int, undoing my 2011-03-30 change.
3125 We prefer signed types, and int is wide enough here.
3126 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3127 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3128 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3129 length, not size_t. Use ptrdiff_t for index, not int.
3130 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3131 possibility of integer overflow.
3133 Overflow, signedness and related fixes for images.
3135 * dispextern.h (struct it.stack[0].u.image.image_id)
3136 (struct_it.image_id, struct image.id, struct image_cache.size)
3137 (struct image_cache.used, struct image_cache.ref_count):
3138 * gtkutil.c (update_frame_tool_bar):
3139 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3140 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3141 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3142 * nsmenu.m (update_frame_tool_bar):
3143 * xdisp.c (calc_pixel_width_or_height):
3144 * xfns.c (image_cache_refcount):
3145 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3146 on typical 64-bit hosts.
3148 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3149 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3150 Omit unnecessary casts to int.
3151 (parse_image_spec): Check that integers fall into 'int' range
3152 when the callers expect that.
3153 (image_ascent): Redo ascent calculation to avoid int overflow.
3154 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3155 (lookup_image): Remove unnecessary tests.
3156 (xbm_image_p): Locals are now of int, not EMACS_INT,
3157 since parse_image_check makes sure they fit into int.
3158 (png_load, gif_load, svg_load_image):
3159 Prefer int to unsigned where either will do.
3160 (tiff_handler): New function, combining the cores of the
3161 old tiff_error_handler and tiff_warning_handler.
3162 This function is rewritten to use vsnprintf and thereby avoid
3163 stack buffer overflows. It uses only the features of vsnprintf
3164 that are common to both POSIX and native Microsoft.
3165 (tiff_error_handler, tiff_warning_handler): Use it.
3166 (tiff_load, gif_load, imagemagick_load_image):
3167 Don't assume :index value fits in 'int'.
3168 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3169 (imagemagick_load_image): Check that crop parameters fit into
3170 the integer types that MagickCropImage accepts. Don't assume
3171 Vimagemagick_render_type has a nonnegative value. Don't assume
3172 size_t fits in 'long'.
3173 (gs_load): Use printmax_t to print the widest integers possible.
3174 Check for integer overflow when computing image height and width.
3176 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3178 * xdisp.c (redisplay_window): Don't force window start if point
3179 will be invisible in the resulting window. (Bug#9324)
3181 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3183 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3184 the display spec is of the form `(space ...)'.
3185 (handle_display_spec): Return the value returned by
3186 handle_single_display_spec, not just 1 or zero.
3187 (handle_single_display_spec): If the display spec is of the form
3188 `(space ...)', and specifies display in the text area, return 2
3190 (try_cursor_movement): Check for the need to scroll more
3191 accurately, and prefer exact match for point under bidi.
3192 Don't advance `row' beyond the last row of the window.
3194 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3195 into disp_prop; all users changed.
3197 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3198 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3199 for the text covered by the display property.
3201 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3203 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3204 Change return value to nil.
3205 (Frecord_buffer): Delete unused function.
3207 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3209 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3210 buffers, return left-to-right.
3211 (set_cursor_from_row): Consider candidate row a win if its glyph
3212 represents a newline and point is on that newline. Fixes cursor
3213 positioning on the newline at EOL of R2L text within L2R
3214 paragraph, and vice versa.
3215 (try_cursor_movement): Check continued rows, in addition to
3216 continuation rows. Fixes unwarranted scroll when point enters a
3217 continued line of R2L text within an L2R paragraph, or vice versa.
3218 (cursor_row_p): Consider the case of point being equal to
3219 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3220 from the end of a short line to the beginning of a continued line
3221 of R2L text within L2R paragraph.
3222 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3223 composed characters.
3225 * bidi.c (bidi_check_type): Use xassert.
3226 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3229 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3231 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3234 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3236 * nsfont.m (ns_otf_to_script): Fix typo.
3238 2011-08-22 Kenichi Handa <handa@m17n.org>
3240 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3241 extra slot even if the purpose is char-code-property-table.
3243 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3245 * xdisp.c (redisplay_window): When computing centering_position,
3246 account for the height of the header line. (Bug#8874)
3248 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3249 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3250 candidate is selected by the mouse, and that candidate has a
3251 composed character under the mouse.
3253 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3254 coordinates reported by pos-visible-in-window-p for a composed
3255 character in column zero.
3257 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3259 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3261 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3263 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3264 consider it a hit if to_charpos is anywhere in the range of the
3265 composed buffer positions.
3267 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3269 * image.c (gif_load): Don't assume that each subimage has the same
3270 dimensions as the base image. Handle disposal method that is
3271 "undefined" by the gif spec (Bug#9335).
3273 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3275 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3276 (Fcondition_case): Document `debug' symbol in error handler.
3278 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3280 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3281 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3282 from an Org mode buffer to a Speedbar frame.
3284 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3285 a composition, take its buffer position from IT->cmp_it.charpos.
3286 Fixes cursor positioning at the beginning of a line that begins
3287 with a composed character.
3289 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3291 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3292 character bidirectional type, use STRONG_L instead. Fixes crashes
3293 in a buffer produced by `describe-categories'.
3295 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3296 members before the level stack, so they would be saved and
3297 restored when copying iterator state. Fixes incorrect reordering
3298 around TABs covered by display properties.
3300 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3302 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3304 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3306 * eval.c (internal_condition_case, internal_condition_case_1)
3307 (internal_condition_case_2, internal_condition_case_n):
3308 Remove unnecessary aborts (Bug#9081).
3310 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3312 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3313 has no `load' handler, try opening the file locally. (Bug#9311)
3315 2011-08-16 Ken Brown <kbrown@cornell.edu>
3317 * gmalloc.c: Expand comment.
3319 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3321 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3322 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3324 2011-08-16 Ken Brown <kbrown@cornell.edu>
3326 Fix memory allocation problems in Cygwin build (Bug#9273).
3328 * unexcw.c ( __malloc_initialized): Declare external variable.
3329 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3331 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3333 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3335 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3337 [CYGWIN] (special_realloc): New function.
3338 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3339 requests to realloc storage in the static heap.
3341 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3343 * bidi.c (bidi_initialize): Remove unused local.
3345 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3348 * biditype.h: Remove file.
3349 * makefile.w32-in ($(BLD)/bidi.$(O)):
3350 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3352 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3354 * chartab.c: Improve commentary for the uniprop_table API.
3356 * bidi.c (bidi_paragraph_init): Support zero value of
3357 bidi_ignore_explicit_marks_for_paragraph_level.
3358 (bidi_initialize): Use uniprop_table instead of including
3359 biditype.h and bidimirror.h.
3361 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3362 coordinates of the iterator when restoring from ppos_it.
3365 2011-08-14 Kenichi Handa <handa@m17n.org>
3367 * process.c (create_process): Call setup_process_coding_systems
3368 after the pid of the process is set to -1 (Bug#8162).
3370 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3372 * xdisp.c (move_it_in_display_line_to): Don't invoke
3373 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3374 ppos_it. Fixes vertical cursor motion when line beginning is
3375 covered by an image. (Bug#9296)
3377 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3379 * nsterm.h (ns_run_ascript): Declare.
3380 (NSAPP_DATA2_RUNASSCRIPT): Define.
3382 * nsfns.m (as_script, as_result, as_status): New static variables.
3383 (ns_run_ascript): New function.
3384 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3385 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3386 the event loop. Get status from as_status (Bug#7276).
3388 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3389 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3390 the event loop (Bug#7276).
3392 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3394 * gnutls.c (QCgnutls_bootprop_priority)
3395 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3396 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3397 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3398 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3399 (QCgnutls_bootprop_verify_hostname_error)
3400 (QCgnutls_bootprop_callbacks_verify): Rename from
3401 Qgnutls_bootprop_..., all uses changed.
3403 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3406 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3408 * xfaces.c (Qframe_set_background_mode): Now static.
3409 * dispextern.h (Qframe_set_background_mode): Remove decl.
3411 * process.c (Fnetwork_interface_info): Declare local only if needed.
3413 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3415 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3416 (Fnetwork_interface_list): Allocate in increments of bytes instead
3417 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3418 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3420 (struct ifflag_def): notrailers is smart on OSX.
3421 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3422 Get hardware address with getifaddrs if available.
3424 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3426 * xdisp.c (iterate_out_of_display_property): xassert that
3427 IT->position is set to within IT->object's boundaries. Break from
3428 the loop as soon as EOB is reached; avoids infloops in redisplay
3429 when IT->position is set up wrongly due to some bug.
3430 Set IT->current to match the bidi iterator unconditionally.
3431 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3432 entry. Force push_it to save on the stack the current
3433 buffer/string position, to be restored by pop_it. Fix flags in
3434 the iterator structure wrt the object coming from a display
3435 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3436 properties. (Bug#9284)
3438 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3440 * fontset.c (fontset_get_font_group): Add proper type checks.
3443 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3445 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3446 and LC_VERSION_MIN_MACOSX.
3447 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3448 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3450 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3452 * xdisp.c (forward_to_next_line_start): Allow to use the
3453 no-display-properties-and-no-overlays under bidi display.
3454 Set disp_pos in the bidi iterator to avoid searches for display
3455 properties and overlays.
3457 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3459 * editfns.c (Fset_time_zone_rule): Document relationship with the
3462 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3463 the font entity extracted from the cache (Bug#8109).
3465 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3467 * composite.c (autocmp_chars): Don't reset point. That is done by
3468 restore_point_unwind (Bug#5984).
3470 2011-08-07 Juri Linkov <juri@jurta.org>
3472 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3473 to show the arg `TIME' instead of `TIMEVAL'.
3475 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3477 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3478 display property strides EOL and includes a newline, as in
3479 longlines-mode. (Bug#9254)
3480 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3481 word-wrap under bidirectional display. (Bug#9224)
3483 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3484 is non-zero, even if the data buffer is NULL. Fixes a crash in
3485 vertical-motion with longlines-mode. (Bug#9254)
3487 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3489 * bidi.c <bidi_cache_total_alloc>: Now static.
3490 (bidi_initialize): Initialize bidi_cache_total_alloc.
3492 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3495 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3496 amount allocated this far in `bidi_cache_total_alloc'.
3497 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3498 non-zero, only free the data buffer without restoring the cache
3499 contents. All callers changed.
3501 * dispextern.h (bidi_unshelve_cache): Update prototype.
3503 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3504 (move_it_in_display_line, move_it_to)
3505 (move_it_vertically_backward, move_it_by_lines): Replace the call
3506 to xfree to an equivalent call to bidi_unshelve_cache.
3507 (move_it_in_display_line_to): Fix logic of returning
3508 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3510 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3512 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3513 came from a string character with a `cursor' property. (Bug#9229)
3515 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3517 * Makefile.in (LIB_PTHREAD): New variable.
3518 (LIBES): Add LIB_PTHREAD (Bug#9216).
3520 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3521 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3523 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3525 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3527 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3529 * xterm.c (x_find_topmost_parent): New function.
3530 (x_set_frame_alpha): Find topmost parent window with
3531 x_find_topmost_parent and set the property there also (bug#9181).
3532 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3534 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3536 * callproc.c (Fcall_process): Avoid vfork clobbering
3537 the local vars buffer, coding_systems, current_dir.
3539 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3541 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3543 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3545 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3546 so that it is not optimized away.
3548 * xdisp.c (compute_display_string_pos): Remove unused local.
3550 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3552 Fix slow cursor motion and scrolling in large buffers with
3553 selective display, like Org Mode buffers. (Bug#9218)
3555 * dispextern.h (struct bidi_it): New member disp_prop_p.
3557 * xdisp.c: Remove one-slot cache of display string positions.
3558 (compute_display_string_pos): Accept an additional argument
3559 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3560 for a display string or property. If found, set DISP_PROP_P
3563 * bidi.c (bidi_fetch_char): Accept an additional argument
3564 DISP_PROP_P, and pass it to compute_display_string_pos.
3565 Only handle text covered by a display string if DISP_PROP_P is returned
3566 non-zero. All callers of bidi_fetch_char changed.
3568 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3570 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3572 2010-12-03 Don March <don@ohspite.net>
3574 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3575 last character M-[char] is translated to ESC [char] (bug#7541).
3577 2011-08-02 Kenichi Handa <handa@m17n.org>
3579 * lisp.h (uniprop_table): Extern it.
3581 * chartab.c (uniprop_table): Make it non-static.
3583 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (forward_to_next_line_start): Accept additional argument
3586 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3588 (reseat_at_next_visible_line_start): Use the bidi iterator state
3589 returned by forward_to_next_line_start to restore the state of
3590 it->bidi_it after backing up to previous newline. (Bug#9212)
3592 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3594 * regex.c (re_comp): Protoize.
3595 (re_exec): Fix return type.
3596 (regexec): Fix type of `ret'. (Bug#9203)
3598 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3600 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3601 This is needed if max-image-size is a floating-point number.
3603 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3605 * print.c (print_object): Print empty symbol as ##.
3607 * lread.c (read1): Read ## as empty symbol.
3609 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3611 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3612 setting frame foreground color (Bug#9175).
3613 (x_set_background_color): Likewise.
3615 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3616 contents (Bug#9176).
3617 (EmacsTooltip -init): Remove bezels and add shadows to
3620 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3621 or scroll bar (Bug#8470).
3623 * nsfont.m (nsfont_open): Remove assignment to voffset and
3624 unnecessary vars hshink, expand, hd, full_height, min_height.
3625 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3627 * nsterm.h (nsfont_info): Remove voffset field.
3629 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3631 Implement strike-through and overline on NextStep (Bug#8863).
3633 * nsfont.m (nsfont_open): Use underline position provided by font,
3634 instead of hard-coded value of 2.
3635 (nsfont_draw): Call ns_draw_text_decoration instead.
3637 * nsterm.h: Add declaration for ns_draw_text_decoration.
3639 * nsterm.m (ns_draw_text_decoration): New function for drawing
3640 underline, overline, and strike-through.
3641 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3642 ns_draw_text_decoration. Change treatment of cursor drawing to
3643 accommodate underlining, etc.
3645 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3647 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3650 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3652 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3653 Without this fix, if a signal arrives just after memory fills up,
3654 'malloc' might be invoked reentrantly.
3656 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3657 In other words, assume that every image size is allowed, on non-X
3658 hosts. This assumption is probably wrong, but it lets Emacs compile.
3660 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3662 * regex.c (re_iswctype): Convert return values to boolean.
3664 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3666 * xdisp.c (compute_display_string_pos): Don't use cached display
3667 string position if the buffer had its restriction changed.
3670 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3672 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3674 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3676 Integer signedness and overflow and related fixes. (Bug#9079)
3678 * bidi.c: Integer size and overflow fixes.
3679 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3680 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3681 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3682 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3683 (bidi_find_other_level_edge):
3684 Use ptrdiff_t instead of EMACS_INT where either will do.
3685 This works better on 32-bit hosts configured --with-wide-int.
3686 (bidi_cache_ensure_space): Check for size-calculation overflow.
3687 Use % rather than repeated addition, for better worst-case speed.
3688 Don't set bidi_cache_size until after xrealloc returns, because it
3690 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3691 (bidi_cache_ensure_space): Also check that the bidi cache size
3692 does not exceed that of the largest Lisp string or buffer. See Eli
3693 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3695 * alloc.c (__malloc_size_t): Remove.
3696 All uses replaced by size_t. See Andreas Schwab's note
3697 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3699 * image.c: Improve checking for integer overflow.
3700 (check_image_size): Assume that f is nonnull, since
3701 it is always nonnull in practice. This is one less thing to
3702 worry about when checking for integer overflow later.
3703 (x_check_image_size): New function, which checks for integer
3704 overflow issues inside X.
3705 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3706 This removes the need for a memory_full check.
3707 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3708 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3709 (xbm_read_bitmap_data): Change locals back to 'int', since
3710 their values must fit in 'int'.
3711 (xpm_load_image, png_load, tiff_load):
3712 Invoke x_create_x_image_and_pixmap earlier,
3713 to avoid much needless work if the image is too large.
3714 (tiff_load): Treat overly large images as if
3715 x_create_x_image_and_pixmap failed, not as malloc failures.
3716 (gs_load): Use x_check_image_size.
3718 * gtkutil.c: Omit integer casts.
3719 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3720 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3722 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3724 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3725 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3726 would wrongly return t on a 64-bit host.
3728 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3729 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3730 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3731 and therefore cause GCC to emit a bogus diagnostic in some cases.
3733 * image.c: Integer signedness and overflow and related fixes.
3734 This is not an exhaustive set of fixes, but it's time to
3735 record what I've got.
3736 (lookup_pixel_color, check_image_size): Remove redundant decls.
3737 (check_image_size): Don't assume that arbitrary EMACS_INT values
3738 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3739 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3740 (tiff_load, imagemagick_load_image):
3741 Check for overflow in size calculations.
3742 (x_create_x_image_and_pixmap): Remove unnecessary test for
3743 xmalloc returning NULL; that can't happen.
3744 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3745 (xpm_color_bucket): Use better integer hashing function.
3746 (xpm_cache_color): Don't possibly over-allocate memory.
3747 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3748 (gif_memory_source):
3749 Use ptrdiff_t, not int or size_t, to record sizes.
3750 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3751 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3752 either works, as we prefer signed integers.
3753 (tiff_read_from_memory, tiff_write_from_memory):
3754 Return tsize_t, not size_t, since that's what the TIFF API wants.
3755 (tiff_read_from_memory): Don't fail simply because the read would
3756 go past EOF; instead, return a short read.
3757 (tiff_load): Omit no-longer-needed casts.
3758 (Fimagemagick_types): Don't assume size fits into 'int'.
3760 Improve hashing quality when configured --with-wide-int.
3761 * fns.c (hash_string): New function, taken from sxhash_string.
3762 Do not discard information about ASCII character case; this
3763 discarding is no longer needed.
3764 (sxhash-string): Use it. Change sig to match it. Caller changed.
3765 * lisp.h: Declare it.
3766 * lread.c (hash_string): Remove, since we now use fns.c's version.
3767 The fns.c version returns a wider integer if --with-wide-int is
3768 specified, so this should help the quality of the hashing a bit.
3770 * emacs.c: Integer overflow minor fix.
3771 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3772 Define only if GNU_LINUX.
3773 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3775 * dispnew.c: Integer signedness and overflow fixes.
3776 Remove unnecessary forward decls, that were a maintenance hassle.
3777 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3779 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3780 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3781 (prepare_desired_row, line_draw_cost):
3782 Use int, not unsigned, where either works.
3783 (save_current_matrix, restore_current_matrix):
3784 Use ptrdiff_t, not size_t, where either works.
3785 (init_display): Check for overflow more accurately, and without
3786 relying on undefined behavior.
3788 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3789 Remove, replacing with the new symbols in lisp.h. All uses changed.
3790 * fileio.c (make_temp_name):
3791 * filelock.c (lock_file_1, lock_file):
3792 * xdisp.c (message_dolog):
3793 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3794 Use pMd etc. instead.
3795 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3796 replacing the pWIDE etc. symbols removed from editfns.c.
3798 * keyboard.h (num_input_events): Now uintmax_t.
3799 This is (very slightly) less likely to mess up due to wraparound.
3802 * buffer.c: Integer signedness fixes.
3803 (alloc_buffer_text, enlarge_buffer_text):
3804 Use ptrdiff_t rather than size_t when either will do, as we prefer
3807 * alloc.c: Integer signedness and overflow fixes.
3808 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3809 (__malloc_size_t): Default to size_t, not to int.
3810 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3811 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3812 Prefer ptrdiff_t to size_t when either would do, as we prefer
3814 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3815 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3816 Now const. Initialize with values that are in range even if char
3818 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3819 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3820 These functions do the right thing with sizes > 2**32.
3821 (check_depth): Now ptrdiff_t, not int.
3822 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3823 Adjust to new way of storing sizes. Check for size overflow bugs
3825 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3826 slightly wrong anyway, as it missed one instance of
3827 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3828 (refill_memory_reserve): Omit needless cast to size_t.
3829 (mark_object_loop_halt): Mark as externally visible.
3831 * xselect.c: Integer signedness and overflow fixes.
3832 (Fx_register_dnd_atom, x_handle_dnd_message):
3833 Use ptrdiff_t, not size_t, since we prefer signed.
3834 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3835 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3836 x_dnd_atoms_size and x_dnd_atoms_length.
3838 * doprnt.c: Prefer signed to unsigned when either works.
3840 * doprnt.c (doprnt):
3842 * xdisp.c (vmessage):
3843 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3844 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3845 prefer signed arithmetic to avoid comparison confusion.
3846 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3847 but is a bit tricky.
3849 Assume freestanding C89 headers, string.h, stdlib.h.
3850 * data.c, doprnt.c, floatfns.c, print.c:
3851 Include float.h unconditionally.
3852 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3853 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3854 * regex.c: Likewise for stddef.h, string.h.
3855 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3856 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3857 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3858 (STDC_HEADERS): Remove obsolete defines.
3859 * sysdep.c: Include limits.h unconditionally.
3861 Assume support for memcmp, memcpy, memmove, memset.
3862 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3863 * regex.c (memcmp, memcpy):
3864 Remove; we assume C89 now.
3866 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3867 (__malloc_safe_bcopy): Remove; no longer needed.
3869 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3870 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3871 well either way, and we prefer signed to unsigned.
3873 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3876 closes the connection while we're reading (bug#9182).
3878 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3880 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3881 are specified (Bug#9168).
3883 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3885 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3886 Found by GCC static checking and --with-wide-int on a 32-bit host.
3888 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3890 * xdisp.c (compute_display_string_pos): Fix logic of caching
3891 previous display string position. Initialize cached_prev_pos to
3892 -1. Fixes slow-down at the beginning of a buffer.
3894 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3896 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3897 for attrs[LFACE_FONTSET_INDEX].
3899 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3901 * xml.c (parse_region): Remove unused local
3902 that was recently introduced.
3904 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3906 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3907 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3909 * xdisp.c (move_it_in_display_line_to): Record the best matching
3910 position for TO_CHARPOS while scanning the line, and restore it on
3911 exit if none of the characters scanned was an exact match.
3912 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3913 when exact match is impossible due to invisible text, and the
3914 lines are truncated.
3916 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3918 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3921 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3923 Fix a significant slow-down of cursor motion with C-n, C-p,
3924 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3925 auto-repeat under bidi redisplay in fontified buffers.
3926 * xdisp.c (compute_stop_pos_backwards): New function.
3927 (next_element_from_buffer): Call compute_stop_pos_backwards to
3928 find a suitable prev_stop when we find ourselves before
3930 (reseat): Don't look for prev_stop, as that could mean a very long
3932 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3933 <cached_disp_overlay_modiff>: Cache for last found display string
3935 (compute_display_string_pos): Return the cached position if asked
3936 about the same buffer in the same area of character positions, and
3937 the buffer wasn't changed since the time the display string
3938 position was cached.
3940 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3942 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3943 is an integer, which is important for empty lines. (Bug#9149)
3945 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3947 * frame.c (Fmodify_frame_parameters): In tty case, update the
3948 default face if necessary (Bug#4238).
3950 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3952 * editfns.c (Fstring_to_char): No need to explain what a character
3953 is in the docstring (Bug#6576).
3955 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3957 * xml.c (parse_region): Make sure we always return a tree.
3959 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3961 * xml.c (parse_region): If a document contains only comments,
3964 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3966 * xml.c (make_dom): Return comments, too.
3968 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3971 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3972 and the surrounding thread.
3973 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3974 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3975 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3977 * s/openbsd.h (BROKEN_SIGIO): Define.
3978 * unexelf.c (unexec) [__OpenBSD__]:
3979 Don't update the .mdebug section of the Alpha COFF symbol table.
3981 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3986 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3988 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3989 This fixes some race conditions on the permissions of any newly
3992 * alloc.c (valid_pointer_p): Use pipe, not open.
3993 This fixes some permissions issues when debugging.
3995 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3996 If fchown fails to set both uid and gid, try to set just gid,
3997 as that is sometimes allowed. Adjust the file's mode to eliminate
3998 setuid or setgid bits that are inappropriate if fchown fails.
4000 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4002 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4003 to compare Lisp_Objects.
4004 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4005 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4006 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4008 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4010 * lread.c (read_integer): Unread even EOF character.
4011 (read1): Likewise. Properly record start position of symbol.
4013 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4014 symbol character follows.
4016 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4018 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4019 This works around a problem with the previous change to Fcopy_file.
4020 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4021 and without this change, GCC might complain about discarding
4022 fchown's return value.
4024 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4026 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4028 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4030 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4032 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4035 it's used from the C level.
4037 * process.c: Use the same condition for POLL_FOR_INPUT in both
4038 keyboard.c and process.c (bug#1858).
4040 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4042 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4043 (Fgnutls_boot): Use it.
4045 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4047 * doc.c (Fsubstitute_command_keys): Revert last change.
4049 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4051 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4052 quotes the next character, and doesn't affect other longer
4053 sequences (bug#8935).
4055 * lread.c (syms_of_lread): Clarify that is isn't only
4056 `eval-buffer' and `eval-defun' that's affected by
4057 `lexical-binding' (bug#8460).
4059 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4061 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4062 bidi redisplay when a line includes both an image and is truncated.
4064 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4066 Fix minor problems found by static checking.
4067 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4068 (elsz): Now a signed constant, not a size_t var. We prefer signed
4069 types to unsigned, to avoid integer comparison confusion. Without
4070 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4071 "cannot optimize loop, the loop counter may overflow", a symptom
4073 * indent.c (Fvertical_motion): Mark locals as initialized.
4074 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4076 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078 * search.c (Fre_search_backward): Mention `case-fold-search' in
4079 all the re_search_* functions (bug#8138).
4081 * keyboard.c (Fopen_dribble_file): Document when the file is
4084 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4086 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4089 Support bidi reordering of display and overlay strings.
4090 * xdisp.c (compute_display_string_pos)
4091 (compute_display_string_end): Accept additional argument STRING.
4092 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4093 (reseat_to_string): Initialize bidi_it->string.s and
4094 bidi_it->string.schars.
4095 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4096 NULL (avoids a crash in bidi_paragraph_init).
4097 Initialize itb.string.lstring.
4098 (init_iterator): Call bidi_init_it only of a valid
4099 buffer position was specified. Initialize paragraph_embedding to
4101 (reseat_to_string): Initialize the bidi iterator.
4102 (display_string): If we need to ignore text properties of
4103 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4104 original value of -1 will not work with bidi.)
4105 (compute_display_string_pos): First arg is now struct
4106 `text_pos *'; all callers changed. Support display properties on
4108 (compute_display_string_end): Support display properties on Lisp
4110 (init_iterator, reseat_1, reseat_to_string): Initialize the
4111 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4112 when iterating on a string not from display properties).
4113 (compute_display_string_pos, compute_display_string_end):
4114 Fix calculation of the object to scan. Fixes an error when using
4116 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4117 base_level_stop; instead, set base_level_stop to BEGV.
4118 Fixes crashes in vertical-motion.
4119 (next_element_from_buffer): Improve commentary for when
4120 the iterator is before prev_stop.
4121 (init_iterator): Initialize bidi_p from the default value of
4122 bidi-display-reordering, not from buffer-local value. Use the
4123 buffer-local value only if initializing for buffer iteration.
4124 (handle_invisible_prop): Support invisible properties on strings
4125 that are being bidi-reordered.
4126 (set_iterator_to_next): Support bidi reordering of C strings and
4128 (next_element_from_string): Support bidi reordering of Lisp
4130 (handle_stop_backwards): Support Lisp strings as well.
4131 (display_string): Support display of R2L glyph rows.
4132 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4133 (init_iterator): Don't initialize it->bidi_p for strings
4135 (reseat_to_string): Initialize it->bidi_p for strings here.
4136 (next_element_from_string, next_element_from_c_string)
4137 (next_element_from_buffer): Add xassert's for correspondence
4138 between IT's object being iterated and it->bidi_it.string
4140 (face_before_or_after_it_pos): Support bidi iteration.
4141 (next_element_from_c_string): Handle the case of the first string
4142 character that is not the first one in the visual order.
4143 (get_visually_first_element): New function, refactored from common
4144 parts of next_element_from_buffer, next_element_from_string, and
4145 next_element_from_c_string.
4146 (tool_bar_lines_needed, redisplay_tool_bar)
4147 (display_menu_bar): Force left-to-right direction. Add a FIXME
4148 comment for making that be controlled by a user option.
4149 (push_it, pop_it): Save and restore the state of the
4150 bidi iterator. Save and restore the bidi_p flag.
4151 (pop_it): Iterate out of display property for string iteration as
4153 (iterate_out_of_display_property): Support iteration over strings.
4154 (handle_single_display_spec): Set up it->bidi_it for iteration
4155 over a display string, and call bidi_init_it.
4156 (handle_single_display_spec, next_overlay_string)
4157 (get_overlay_strings_1, push_display_prop): Set up the bidi
4158 iterator for displaying display or overlay strings.
4159 (forward_to_next_line_start): Don't use the shortcut if
4161 (back_to_previous_visible_line_start): If handle_display_prop
4162 pushed the iterator stack, restore the internal state of the bidi
4163 iterator by calling bidi_pop_it same number of times.
4164 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4165 and we are bidi-iterating, don't decrement the iterator position;
4166 instead, set the first_elt flag in the bidi iterator, to produce
4168 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4169 (push_display_prop): xassert that we are iterating a buffer.
4170 (push_it, pop_it): Save and restore paragraph_embedding member.
4171 (handle_single_display_spec, next_overlay_string)
4172 (get_overlay_strings_1, reseat_1, reseat_to_string)
4173 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4174 correctly. Don't assume unibyte strings are not bidi-reordered.
4175 (compute_display_string_pos)
4176 (compute_display_string_end): Fix handling the case of C string.
4177 (push_it, pop_it): Save and restore from_disp_prop_p.
4178 (handle_single_display_spec, push_display_prop): Set the
4179 from_disp_prop_p flag.
4180 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4181 (pop_it): Call iterate_out_of_display_property only if we are
4182 popping after iteration over a string that came from a display
4183 property. Fix a typo in popping stretch info. Add an assertion
4184 for verifying that the iterator position is in sync with the bidi
4186 (handle_single_display_spec, get_overlay_strings_1)
4187 (push_display_prop): Fix initialization of paragraph direction for
4188 string when that of the parent object is not yet determined.
4189 (reseat_1): Call bidi_init_it to resync the bidi
4190 iterator with IT's position. (Bug#7616)
4191 (find_row_edges): If ROW->start.pos gives position
4192 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4193 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4194 Reset the from_disp_prop_p flag.
4195 (SAVE_IT, RESTORE_IT): New macros.
4196 (pos_visible_p, face_before_or_after_it_pos)
4197 (back_to_previous_visible_line_start)
4198 (move_it_in_display_line_to, move_it_in_display_line)
4199 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4200 (try_scrolling, redisplay_window, display_line): Use them when
4201 saving a temporary copy of the iterator and restoring it back.
4202 (back_to_previous_visible_line_start, reseat_1)
4203 (init_iterator): Empty the bidi cache "stack".
4204 (move_it_in_display_line_to): If iterator ended up at
4205 EOL, but we never saw any buffer positions smaller than
4206 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4207 motion in bidi-reordered lines.
4208 (move_it_in_display_line_to): Record prev_method and prev_pos
4209 immediately before the call to set_iterator_to_next. Fixes cursor
4210 motion in bidi-reordered lines with stretch glyphs and strings
4211 displayed in margins. (Bug#8133) (Bug#8867)
4212 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4214 (pos_visible_p): Support positions in bidi-reordered lines.
4215 Save and restore bidi cache.
4217 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4218 (bidi_paragraph_info): Delete unused struct.
4219 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4220 (bidi_cache_start): New variable.
4221 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4223 (bidi_cache_fetch_state, bidi_cache_search)
4224 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4225 (bidi_cache_find, bidi_peek_at_next_level)
4226 (bidi_level_of_next_char, bidi_find_other_level_edge)
4227 (bidi_move_to_visually_next): Compare cache index with
4228 bidi_cache_start rather than with zero.
4229 (bidi_fetch_char): Accept new argument STRING; all callers
4230 changed. Support iteration over a string. Support strings with
4231 display properties. Support unibyte strings. Fix the type of
4232 `len' according to what STRING_CHAR_AND_LENGTH expects.
4233 (bidi_paragraph_init, bidi_resolve_explicit_1)
4234 (bidi_resolve_explicit, bidi_resolve_weak)
4235 (bidi_level_of_next_char, bidi_move_to_visually_next):
4236 Support iteration over a string.
4237 (bidi_set_sor_type, bidi_resolve_explicit_1)
4238 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4239 can now be zero (for strings); special values 0 and -1 were
4240 changed to -1 and -2, respectively.
4241 (bidi_char_at_pos): New function.
4242 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4243 Call it instead of FETCH_MULTIBYTE_CHAR.
4244 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4245 initialized to valid values.
4246 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4248 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4249 the test for valid cached positions. Fix the logic for looking up
4250 the sentinel state in the cache. GCPRO the Lisp string we are
4252 (bidi_push_it, bidi_pop_it): New functions.
4253 (bidi_initialize): Initialize the bidi cache start stack pointer.
4254 (bidi_cache_ensure_space): New function, refactored from part of
4255 bidi_cache_iterator_state. Don't assume the required size is just
4256 one BIDI_CACHE_CHUNK away.
4257 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4258 (bidi_count_bytes, bidi_char_at_pos): New functions.
4259 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4260 always valid if bidi_cache_idx is valid.
4261 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4262 is valid if it's going to be used.
4263 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4264 (bidi_cache_fetch_state, bidi_cache_search)
4265 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4266 (bidi_cache_iterator_state, bidi_cache_find)
4267 (bidi_find_other_level_edge, bidi_cache_start_stack):
4268 All variables related to cache indices are now EMACS_INT.
4270 * dispextern.h (struct bidi_string_data): New structure.
4271 (struct bidi_it): New member `string'. Make flag members be 1-bit
4272 fields, and put them last in the struct.
4273 (compute_display_string_pos, compute_display_string_end):
4275 (bidi_push_it, bidi_pop_it): Add prototypes.
4276 (struct iterator_stack_entry): New members bidi_p,
4277 paragraph_embedding, and from_disp_prop_p.
4278 (struct it): Member bidi_p is now a bit field 1 bit wide.
4279 (bidi_shelve_cache, bidi_unshelve_cache):
4282 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4283 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4284 and vector-like objects.
4286 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4287 cache around display iteration.
4289 * window.c (Fwindow_end, window_scroll_pixel_based)
4290 (displayed_window_lines, Frecenter): Save and restore the bidi
4291 cache around display iteration.
4293 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4295 * editfns.c (Fdelete_region): Clarify the use of the named
4296 parameters (bug#6788).
4298 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4300 * indent.c (Fvertical_motion): Set and restore w->pointm when
4301 saving and restoring the window's buffer (Bug#9006).
4303 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4305 * editfns.c (Fstring_to_char): Clarify just what is returned
4306 (bug#6576). Text by Eli Zaretskii.
4308 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4310 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4312 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4314 * buffer.c (mmap_find): Fix a typo.
4316 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4318 Fix execution of x selection hooks.
4319 * xselect.c (Qx_lost_selection_functions)
4320 (Qx_sent_selection_functions): New vars.
4321 (syms_of_xselect): DEFSYM them.
4322 (x_handle_selection_request): Pass Qx_sent_selection_functions
4323 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4324 (x_handle_selection_clear,x_clear_frame_selections):
4325 Pass Qx_lost_selection_functions rather than
4326 Vx_lost_selection_functions to Frun_hook_with_args.
4328 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4330 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4331 The old code sometimes used this field without initializing it.
4333 * alloc.c (gc_sweep): Don't read past end of array.
4334 In theory, the old code could also have corrupted Emacs internals,
4335 though it'd be very unlikely.
4337 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4339 * character.c (Fcharacterp): Don't advertise optional ignored
4340 argument. (Bug#4026)
4342 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4344 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4347 * window.c (Fset_window_start): Doc fix (bug#4199).
4348 (Fset_window_hscroll): Ditto.
4350 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4352 Fix minor new problems caught by GCC 4.6.1.
4353 * term.c (init_tty): Remove unused local.
4354 * xsettings.c (store_monospaced_changed): Define this function only
4355 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4358 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4360 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4362 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4364 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4365 are the mini-buffer and the echo area (bug#3320).
4367 * term.c (init_tty): Remove support for supdup, c10 and perq
4368 terminals, which are no longer supported (bug#1482).
4370 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4372 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4374 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4376 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4377 for non-popups (Bug#3642).
4379 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4381 * alloc.c (reset_malloc_hooks): Protoize.
4382 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4383 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4384 * cm.c (losecursor): Likewise.
4385 * data.c (fmod): Likewise.
4386 * dispnew.c (swap_glyphs_in_rows): Likewise.
4387 * emacs.c (memory_warning_signal): Likewise.
4388 * floatfns.c (float_error): Likewise.
4389 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4390 (otf_open, font_otf_capability, generate_otf_features)
4391 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4393 * image.c (pbm_read_file): Likewise.
4394 * indent.c (string_display_width): Likewise.
4395 * intervals.c (check_for_interval, search_for_interval)
4396 (inc_interval_count, count_intervals, root_interval)
4397 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4398 * lread.c (defalias): Likewise.
4399 * ralloc.c (r_alloc_check): Likewise.
4400 * regex.c (set_image_of_range_1, set_image_of_range)
4401 (regex_grow_registers): Likewise.
4402 * sysdep.c (strerror): Likewise.
4403 * termcap.c (valid_filename_p, tprint, main): Likewise.
4404 * tparam.c (main): Likewise.
4405 * unexhp9k800.c (run_time_remap, save_data_space)
4406 (update_file_ptrs, read_header, write_header, calculate_checksum)
4407 (copy_file, copy_rest, display_header): Likewise.
4408 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4410 * xdisp.c (check_it): Likewise.
4411 * xfaces.c (register_color, unregister_color, unregister_colors):
4413 * xfns.c (print_fontset_result): Likewise.
4414 * xrdb.c (member, fatal, main): Likewise.
4416 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4418 Fix minor problems found by static checking (Bug#9031).
4419 * chartab.c (char_table_set_range, map_sub_char_table):
4420 Remove unused locals.
4421 (uniprop_table): Now static.
4422 * composite.c (_work_char): Remove unused static var.
4424 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4426 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4428 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4430 * gtkutil.c (qttip_cb): Remove code without function.
4432 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4434 * w32.c (pthread_sigmask): New stub.
4436 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4438 Use pthread_sigmask, not sigprocmask (Bug#9010).
4439 sigprocmask is portable only for single-threaded applications, and
4440 Emacs can be multi-threaded when it uses GTK.
4441 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4443 * callproc.c (Fcall_process):
4444 * process.c (create_process):
4445 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4446 Use pthread_sigmask, not sigprocmask.
4448 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4450 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4451 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4454 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4456 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4457 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4458 (xg_hide_tooltip): Fix comment.
4460 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4461 in registerServicesMenuSendTypes.
4462 (validRequestorForSendType): Don't check ns_return_types.
4464 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4467 2011-07-08 Jason Rumney <jasonr@gnu.org>
4469 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4470 SH_SHOW for hidden windows (Bug#5482).
4472 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4473 frame struct members of non-existent frames (Bug#6284).
4475 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4477 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4478 variable firstTime not needed on OSX >= 10.6.
4479 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4480 >= 10.5. Use setKnobProportion, setDoubleValue.
4482 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4483 (MAC_OS_X_VERSION_10_5): Define if not defined.
4484 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4485 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4486 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4488 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4489 cString and lossyCString on OSX >= 10.4
4491 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4492 sizeToFit on OSX >= 10.2.
4494 * nsimage.m (allocInitFromFile): Don't use deprecated method
4495 bestRepresentationForDevice on OSX >= 10.6.
4497 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4500 * emacs.c: Declare unexec_init_emacs_zone.
4502 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4504 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4506 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4507 on svcsMenu (Bug#8842).
4509 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4511 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4513 * nsterm.m (QUTF8_STRING): Declare.
4514 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4515 (validRequestorForSendType): Return type is (id).
4516 Change indexOfObjectIdenticalTo to indexOfObject.
4517 Check if we have local selection before returning self (Bug#8842).
4518 (writeSelectionToPasteboard): Put local selection into paste board
4519 if we have a local selection (Bug#8842).
4520 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4522 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4523 (ns_get_local_selection): Declare.
4525 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4527 * keymap.c (describe_map_tree): Don't insert a double newline at
4528 the end of the buffer (bug#1169) and return whether we inserted
4531 * callint.c (Fcall_interactively): Change "reading args" to
4532 "providing args" to try to clarify what it does (bug#1010).
4534 2011-07-07 Kenichi Handa <handa@m17n.org>
4536 * composite.c (composition_compute_stop_pos): Ignore a static
4537 composition starting before CHARPOS (Bug#8915).
4539 * xdisp.c (handle_composition_prop): Likewise.
4541 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4543 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4546 2011-07-07 Kenichi Handa <handa@m17n.org>
4548 * character.h (unicode_category_t): New enum type.
4550 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4551 (Qchar_code_property_table): New variable.
4552 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4553 (UNIPROP_COMPRESSED_FORM_P): New macros.
4554 (char_table_ascii): Uncompress the compressed values.
4555 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4556 Uncompress the compressed values.
4557 (sub_char_table_ref_and_range): Likewise.
4558 (char_table_ref_and_range): Uncompress the compressed values.
4559 (sub_char_table_set): New arg is_uniprop. Callers changed.
4560 Uncompress the compressed values.
4561 (sub_char_table_set_range): Args changed. Callers changed.
4562 (char_table_set_range): Adjuted for the above change.
4563 (map_sub_char_table): Delete args default_val and parent. Add arg
4564 top. Give decoded values to a Lisp function.
4565 (map_char_table): Adjust for the above change. Give decoded
4566 values to a Lisp function. Gcpro more variables.
4567 (uniprop_table_uncompress)
4568 (uniprop_decode_value_run_length): New functions.
4569 (uniprop_decoder, uniprop_decoder_count): New variables.
4570 (uniprop_get_decoder, uniprop_encode_value_character)
4571 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4573 (uniprop_encoder, uniprop_encoder_count): New variables.
4574 (uniprop_get_encoder, uniprop_table)
4575 (Funicode_property_table_internal, Fget_unicode_property_internal)
4576 (Fput_unicode_property_internal): New functions.
4577 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4578 Sunicode_property_table_internal, Sget_unicode_property_internal,
4579 and Sput_unicode_property_internal. Defvar_lisp
4580 char-code-property-alist.
4582 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4583 Vunicode_category_table.
4585 * font.c (font_range): Adjust for the change of
4586 Vunicode_category_table.
4588 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4590 * m/iris4d.h: Remove file, move contents ...
4591 * s/irix6-5.h: ... here.
4593 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4595 Remove unportable assumption about struct layout (Bug#8884).
4596 * alloc.c (mark_buffer):
4597 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4598 (clone_per_buffer_values): Don't assume that
4599 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4600 This isn't true in general, and it's particularly not true
4601 if Emacs is configured with --with-wide-int.
4602 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4603 New macros, used in the buffer.c change.
4605 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4607 * xsettings.c: Use both GConf and GSettings if both are available.
4608 (store_config_changed_event): Add comment.
4609 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4610 (store_tool_bar_style_changed): New functions.
4611 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4612 (struct xsettings): Move font inside HAVE_XFT.
4613 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4614 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4615 Move inside HAVE_XFT.
4616 (something_changed_gsettingsCB): Rename from something_changedCB.
4617 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4619 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4620 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4621 (something_changed_gconfCB): Rename from something_changedCB.
4622 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4623 (parse_settings): Move check for font inside HAVE_XFT.
4624 (read_settings, apply_xft_settings): Add comment.
4625 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4626 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4627 call store_font_name_changed.
4628 (xft_settings_event): Add comment.
4629 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4630 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4631 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4632 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4633 (xsettings_initialize): Call init_gsettings last.
4634 (xsettings_get_system_font, xsettings_get_system_normal_font):
4637 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4639 Random fixes. E.g., (random) never returned negative values.
4640 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4641 subseconds part to the entropy, as that's a bit more random.
4642 Prefer signed to unsigned, since the signedness doesn't matter and
4643 in general we prefer signed. When given a limit, use a
4644 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4645 latter isn't right if USE_2_TAGS_FOR_INTS.
4646 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4647 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4649 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4651 * textprop.c (text_property_stickiness):
4652 Obey Vtext_property_default_nonsticky.
4653 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4654 * w32fns.c (syms_of_w32fns):
4655 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4657 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4659 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4660 This is more efficient than Ffile_directory_p and avoids a minor race.
4662 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4664 * buffer.c (Foverlay_put): Say what the return value is
4667 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4668 is a directory before asking whether to use the file name
4670 (barf_or_query_if_file_exists): Make the "File is a directory"
4671 error be more correct.
4673 * fns.c (Frequire): Remove the mention of the .gz files, since
4674 that's installation-specific, but keep the mention of
4675 `get-load-suffixes'.
4677 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4679 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4680 Report string overflow if the output is too long.
4682 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4684 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4685 (syms_of_gnutls): Remove duplicate DEFSYM for
4686 Qgnutls_bootprop_verify_hostname_error, an error for
4687 Qgnutls_bootprop_verify_error (which is no longer used).
4689 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4690 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4691 Also (re)move comments that are misplaced or no longer relevant.
4693 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4695 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4697 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4699 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4700 and background color parameters if they have been changed.
4702 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4704 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4706 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4708 * xsettings.c (SYSTEM_FONT): Define only when used.
4709 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4711 * keymap.c (access_keymap_1): Now static.
4713 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4715 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4716 leave any prefix arg for the up event (Bug#1586).
4718 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4720 * lread.c (syms_of_lread): Mention single symbols defined by
4721 `defvar' or `defconst' (bug#7154).
4723 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4724 (Frequire): Mention get-load-suffixes.
4726 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4728 * window.h (window): Remove clone_number slot.
4729 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4731 (make_parent_window, make_window, saved_window)
4732 (Fset_window_configuration, save_window_save): Don't deal with
4734 * buffer.c (Qclone_number): Remove declaration.
4735 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4737 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4739 Add multiple inheritance to keymaps.
4740 * keymap.c (Fmake_composed_keymap): New function.
4741 (Fset_keymap_parent): Simplify.
4742 (fix_submap_inheritance): Remove.
4743 (access_keymap_1): New function extracted from access_keymap to handle
4744 embedded parents and handle lists of maps.
4745 (access_keymap): Use it.
4746 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4747 (Fcopy_keymap): Handle embedded parents.
4748 (Fcommand_remapping, define_as_prefix): Simplify.
4749 (Fkey_binding): Simplify.
4750 (syms_of_keymap): Move minibuffer-local-completion-map,
4751 minibuffer-local-filename-completion-map,
4752 minibuffer-local-must-match-map, and
4753 minibuffer-local-filename-must-match-map to Elisp.
4754 (syms_of_keymap): Defsubr make-composed-keymap.
4755 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4756 (parse_menu_item): Trivial simplification.
4758 2011-07-01 Glenn Morris <rgm@gnu.org>
4760 * Makefile.in (SETTINGS_LIBS): Fix typo.
4762 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4764 * coding.c (Fencode_coding_string): Record the last coding system
4765 used, as the function doc string says (bug#8738).
4767 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4769 * xsettings.c (store_monospaced_changed): Take new font as arg and
4770 check for change against current_mono_font.
4771 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4772 (emacs_settings_constructor, emacs_settings_get_property)
4773 (emacs_settings_set_property, emacs_settings_class_init)
4774 (emacs_settings_init, gsettings_obj): Remove.
4775 (something_changedCB): New function for HAVE_GSETTINGS.
4776 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4777 with value as argument.
4778 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4779 g_settings_new (Bug#8967). Do not create gsettings_obj.
4780 Remove calls to g_settings_bind. Connect something_changedCB to
4783 * xgselect.c: Add defined (HAVE_GSETTINGS).
4784 (xgselect_initialize): Ditto.
4786 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4787 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4790 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4792 * eval.c (struct backtrace): Simplify and port the data structure.
4793 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4794 signed bit field, as this assumption is not portable and it makes
4795 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4796 "char debug_on_exit : 1" as this is not portable either; instead,
4797 use the portable "unsigned int debug_on_exit : 1". Remove unused
4798 member evalargs. Remove obsolete comments about cc bombing out.
4800 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4802 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4803 Let HAVE_GSETTINGS override HAVE_GCONF.
4804 (store_monospaced_changed): New function.
4805 (EMACS_SETTINGS): A new type derived from GObject to handle
4806 GSettings notifications.
4807 (emacs_settings_constructor, emacs_settings_get_property)
4808 (emacs_settings_set_property, emacs_settings_class_init):
4810 (gsettings_client, gsettings_obj): New variables.
4811 (GSETTINGS_SCHEMA): New define.
4812 (something_changedCB): Call store_monospaced_changed.
4813 (init_gsettings): New function.
4814 (xsettings_initialize): Call init_gsettings.
4815 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4818 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4821 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4823 * window.c (resize_root_window, grow_mini_window)
4824 (shrink_mini_window): Rename Qresize_root_window to
4825 Qwindow_resize_root_window and Qresize_root_window_vertically to
4826 Qwindow_resize_root_window_vertically.
4828 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4830 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4832 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4834 * makefile.w32-in: Redesign dependencies so they reflect more
4835 clearly which files are directly included by each source file,
4836 and not through other includes.
4838 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4840 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4841 (sort_overlays, overlay_strings): When an overlay's clone number
4842 matches the window's clone number process the overlay even if
4843 the overlay's window property doesn't match the current window.
4845 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4846 (Fwindow_hchild): Rename to Fwindow_left_child.
4847 (Fwindow_next): Rename to Fwindow_next_sibling.
4848 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4849 (resize_window_check): Rename to window_resize_check.
4850 (resize_window_apply): Rename to window_resize_apply.
4851 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4852 (Fdelete_other_windows_internal, resize_frame_windows)
4853 (Fsplit_window_internal, Fdelete_window_internal)
4854 (grow_mini_window, shrink_mini_window)
4855 (Fresize_mini_window_internal): Fix callers accordingly.
4857 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4859 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4860 (emacs_fixed_set_min_size): Remove.
4861 (emacs_fixed_new): Take frame as argument.
4863 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4864 (_EmacsFixedPrivate): Remove minwidth/height.
4865 Add struct frame *f.
4866 (emacs_fixed_init): Initialize priv->f.
4867 (get_parent_class, emacs_fixed_set_min_size): Remove.
4868 (emacs_fixed_new): Set priv->f to argument.
4869 (emacs_fixed_get_preferred_width)
4870 (emacs_fixed_get_preferred_height): Use min_width/height from
4871 frames size_hint to set minimum and natural (Bug#8919).
4872 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4873 and use min_width/height from frames size_hint to set
4874 min_width/height (Bug#8919).
4876 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4877 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4880 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4882 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4883 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4886 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4888 * process.c (wait_reading_process_output): Bypass select if
4889 waiting for a cell while ignoring keyboard input, and input is
4890 pending. Suggested by Jan Djärv (Bug#8869).
4892 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4894 Use gnulib's dup2 module instead of rolling our own.
4895 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4897 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4899 * dispnew.c (scrolling_window): Before scrolling, turn off a
4900 mouse-highlight in the window being scrolled.
4902 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4904 Move DEFSYM to lisp.h and use everywhere.
4906 * character.h (DEFSYM): Move declaration...
4907 * lisp.h (DEFSYM): ...here.
4913 * w32select.c: Don't include character.h.
4915 * alloc.c (syms_of_alloc):
4916 * buffer.c (syms_of_buffer):
4917 * bytecode.c (syms_of_bytecode):
4918 * callint.c (syms_of_callint):
4919 * casefiddle.c (syms_of_casefiddle):
4920 * casetab.c (init_casetab_once):
4921 * category.c (init_category_once, syms_of_category):
4922 * ccl.c (syms_of_ccl):
4923 * cmds.c (syms_of_cmds):
4924 * composite.c (syms_of_composite):
4925 * dbusbind.c (syms_of_dbusbind):
4926 * dired.c (syms_of_dired):
4927 * dispnew.c (syms_of_display):
4928 * doc.c (syms_of_doc):
4929 * editfns.c (syms_of_editfns):
4930 * emacs.c (syms_of_emacs):
4931 * eval.c (syms_of_eval):
4932 * fileio.c (syms_of_fileio):
4933 * fns.c (syms_of_fns):
4934 * frame.c (syms_of_frame):
4935 * fringe.c (syms_of_fringe):
4936 * insdel.c (syms_of_insdel):
4937 * keymap.c (syms_of_keymap):
4938 * lread.c (init_obarray, syms_of_lread):
4939 * macros.c (syms_of_macros):
4940 * msdos.c (syms_of_msdos):
4941 * print.c (syms_of_print):
4942 * process.c (syms_of_process):
4943 * search.c (syms_of_search):
4944 * sound.c (syms_of_sound):
4945 * syntax.c (init_syntax_once, syms_of_syntax):
4946 * terminal.c (syms_of_terminal):
4947 * textprop.c (syms_of_textprop):
4948 * undo.c (syms_of_undo):
4949 * w32.c (globals_of_w32):
4950 * window.c (syms_of_window):
4951 * xdisp.c (syms_of_xdisp):
4952 * xfaces.c (syms_of_xfaces):
4953 * xfns.c (syms_of_xfns):
4954 * xmenu.c (syms_of_xmenu):
4955 * xsettings.c (syms_of_xsettings):
4956 * xterm.c (syms_of_xterm): Use DEFSYM.
4958 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4960 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4962 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4964 Integer and buffer overflow fixes (Bug#8873).
4966 * print.c (printchar, strout): Check for string overflow.
4967 (PRINTPREPARE, printchar, strout):
4968 Don't set size unless allocation succeeds.
4970 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4971 for sizes. Check for string overflow more accurately.
4972 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4974 * macros.c: Integer and buffer overflow fixes.
4975 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4976 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4977 Use ptrdiff_t, not int, for sizes.
4978 Don't increment bufsize until after realloc succeeds.
4979 Check for size-calculation overflow.
4980 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4982 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4984 * lread.c: Integer overflow fixes.
4985 (read_integer): Radix is now EMACS_INT, not int,
4986 to improve quality of diagnostics for out-of-range radices.
4987 Calculate buffer size correctly for out-of-range radices.
4988 (read1): Check for integer overflow in radices, and in
4989 read-circle numbers.
4990 (read_escape): Avoid int overflow.
4991 (Fload, openp, read_buffer_size, read1)
4992 (substitute_object_recurse, read_vector, read_list, map_obarray):
4993 Use ptrdiff_t, not int, for sizes.
4994 (read1): Use EMACS_INT, not int, for sizes.
4995 Check for size overflow.
4997 * image.c (cache_image): Check for size arithmetic overflow.
4999 * lread.c: Integer overflow issues.
5000 (saved_doc_string_size, saved_doc_string_length)
5001 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5002 Now ptrdiff_t, not int.
5003 (read1): Don't assume doc string length fits in int. Check for
5004 out-of-range doc string lengths.
5005 (read_list): Don't assume file position fits in int.
5006 (read_escape): Check for hex character overflow.
5008 2011-06-22 Leo Liu <sdl.web@gmail.com>
5010 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5011 Move to minibuffer.el.
5013 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5015 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5016 The following patches are for when GLYPH_DEBUG && !XASSERT.
5017 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5018 * dispnew.c (flush_stdout):
5019 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5020 Mark as externally visible.
5021 * dispnew.c (check_window_matrix_pointers): Now static.
5022 * dispnew.c (window_to_frame_vpos):
5023 * xfns.c (unwind_create_frame):
5024 * xterm.c (x_check_font): Remove unused local.
5025 * scroll.c (CHECK_BOUNDS):
5026 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5027 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5028 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5029 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5030 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5032 (debug_method_add): Use va_list and vsprintf rather than relying
5033 on undefined behavior with wrong number of arguments.
5034 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5035 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5036 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5037 since we're not interested in debugging glyphs with old libraries.
5038 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5039 GCC 4.6.0's static checking.
5041 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5043 Integer overflow and signedness fixes (Bug#8873).
5044 A few related buffer overrun fixes, too.
5046 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5048 * dispextern.h (struct face.stipple):
5049 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5050 (x_bitmap_mask, x_allocate_bitmap_record)
5051 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5052 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5053 (x_create_bitmap_from_xpm_data):
5054 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5055 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5057 * xfaces.c (load_pixmap):
5058 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5059 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5060 (.bitmaps_last, struct x_output.icon_bitmap):
5061 Use ptrdiff_t, not int, for bitmap indexes.
5062 (x_allocate_bitmap_record): Check for size overflow.
5063 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5065 Use ptrdiff_t, not int, for overlay counts.
5066 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5067 * editfns.c (overlays_around, get_pos_property):
5068 * textprop.c (get_char_property_and_overlay):
5069 * xdisp.c (next_overlay_change, note_mouse_highlight):
5070 * xfaces.c (face_at_buffer_position):
5071 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5072 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5073 (Fnext_overlay_change, Fprevious_overlay_change)
5074 (mouse_face_overlay_overlaps, Foverlays_in):
5075 Use ptrdiff_t, not int, for sizes.
5076 (overlays_at, overlays_in): Check for size-calculation overflow.
5078 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5080 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5081 (x_session_initialize): Do not assume string length fits in int.
5083 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5084 This is unlikely, but can occur if DPI is outlandish.
5086 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5087 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5089 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5090 * xrdb.c (magic_file_p, search_magic_path):
5091 Omit last arg SUFFIX; it was always 0. All callers changed.
5092 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5094 * xfont.c (xfont_match): Avoid need for strlen.
5096 * xfns.c: Don't assume strlen fits in int.
5097 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5099 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5100 not unsigned long, as we prefer signed integers. All callers changed.
5101 Detect integer overflow in repeat count.
5102 (message_dolog): Don't assume print length fits in 39 bytes.
5103 (display_mode_element): Don't assume strlen fits in int.
5105 * termcap.c: Don't assume sizes fit in int and never overflow.
5106 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5107 (gobble_line): Check for size-calculation overflow.
5109 * minibuf.c (Fread_buffer):
5110 * lread.c (intern, intern_c_string):
5111 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5112 Don't assume string length fits in int.
5114 * keyboard.c (parse_tool_bar_item):
5115 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5117 * font.c: Don't assume string length fits in int.
5118 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5119 Use ptrdiff_t, not int.
5120 (font_intern_prop): Don't assume string length fits in int.
5121 Don't assume integer property fits in fixnum.
5122 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5124 * filelock.c: Fix some buffer overrun and integer overflow issues.
5125 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5126 Reformulate so as not to need the command string.
5127 Invoke gzip -cd rather than gunzip, as it's more portable.
5128 (lock_info_type, lock_file_1, lock_file):
5129 Don't assume pid_t and time_t fit in unsigned long.
5130 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5131 (current_lock_owner): Prefer signed type for sizes.
5132 Use memcpy, not strncpy, where memcpy is what is really wanted.
5133 Don't assume (via atoi) that time_t and pid_t fit in int.
5134 Check for time_t and/or pid_t out of range, e.g., via a network share.
5135 Don't alloca where an auto var works fine.
5137 * fileio.c: Fix some integer overflow issues.
5138 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5139 Don't assume string length fits in int.
5140 (directory_file_name): Don't assume string length fits in long.
5141 (make_temp_name): Don't assume pid fits in int, or that its print
5142 length is less than 20.
5144 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5146 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5148 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5150 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5151 We prefer signed integers, even for size calculations.
5153 * emacs.c: Don't assume string length fits in 'int'.
5154 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5155 (main): Don't invoke strlen when not needed.
5157 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5158 (XD_DEBUG_MESSAGE): Don't waste a byte.
5160 * callproc.c (getenv_internal_1, getenv_internal)
5162 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5164 * lread.c (invalid_syntax): Omit length argument.
5165 All uses changed. This doesn't fix a bug, but it simplifies the
5166 code away from its former Hollerith-constant appearance, and it's
5167 one less 'int' to worry about when looking at integer-overflow issues.
5168 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5170 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5171 This didn't break anything, but it didn't help either.
5172 It's confusing to put a bogus integer in a place where the actual
5173 value does not matter.
5174 (LIST_END_P): Remove unused macro and its bogus comment.
5175 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5177 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5178 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5180 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5181 We prefer signed types, and the value cannot exceed the EMACS_INT
5182 range anyway (because otherwise the length would not be representable).
5183 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5184 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5185 This avoids a GCC warning when WIDE_EMACS_INT.
5187 * indent.c (sane_tab_width): New function.
5188 (current_column, scan_for_column, Findent_to, position_indentation)
5189 (compute_motion): Use it. This is just for clarity.
5190 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5192 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5194 * lisp.h (lint_assume): New macro.
5195 * composite.c (composition_gstring_put_cache):
5196 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5198 * editfns.c, insdel.c:
5199 Omit unnecessary forward decls, to simplify future changes.
5201 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5203 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5205 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5206 Use much-faster test for byte-length change.
5207 Don't assume string byte-length fits in 'int'.
5208 Check that character arg fits in 'int'.
5209 (mapcar1): Declare byte as byte, for clarity.
5211 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5213 * fns.c (concat): Catch string overflow earlier.
5214 Do not rely on integer wraparound.
5216 * dispextern.h (struct it.overlay_strings_charpos)
5217 (struct it.selective): Now EMACS_INT, not int.
5218 * xdisp.c (forward_to_next_line_start)
5219 (back_to_previous_visible_line_start)
5220 (reseat_at_next_visible_line_start, next_element_from_buffer):
5221 Don't arbitrarily truncate the value of 'selective' to int.
5223 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5225 * composite.c: Don't truncate sizes to 'int'.
5226 (composition_gstring_p, composition_reseat_it)
5227 (composition_adjust_point): Use EMACS_INT, not int.
5228 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5229 not EMACS_UINT, for indexes.
5231 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5233 * buffer.c: Include <verify.h>.
5234 (struct sortvec.priority, struct sortstr.priority):
5235 Now EMACS_INT, not int.
5236 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5237 (struct sortstr.size, record_overlay_string)
5238 (struct sortstrlist.size, struct sortlist.used):
5239 Don't truncate size to int.
5240 (record_overlay_string): Check for size-calculation overflow.
5241 (init_buffer_once): Check at compile-time, not run-time.
5243 2011-06-22 Jim Meyering <meyering@redhat.com>
5245 Don't leak an XBM-image-sized buffer
5246 * image.c (xbm_load): Free the image buffer after using it.
5248 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5251 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5252 that Sun C diagnosed.
5253 * fns.c (secure_hash): Fix pointer signedness issue.
5254 * intervals.c (static_offset_intervals): New function.
5255 (offset_intervals): Use it.
5257 2011-06-21 Leo Liu <sdl.web@gmail.com>
5260 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5263 * fns.c (secure_hash): Rename from crypto_hash_function and change
5264 the first arg to accept symbols.
5265 (Fsecure_hash): New primitive.
5266 (syms_of_fns): New symbols.
5268 2011-06-20 Deniz Dogan <deniz@dogan.se>
5270 * process.c (Fset_process_buffer): Clarify return value in
5273 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5275 * dispnew.c (add_window_display_history): Use BVAR.
5277 * xdisp.c (debug_method_add): Use BVAR.
5278 (check_window_end, dump_glyph_matrix, dump_glyph)
5279 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5281 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5284 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5285 check till after the cache is created in init_frame_faces.
5287 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5289 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5291 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5293 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5294 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5295 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5297 Improve buffer-overflow checking (Bug#8873).
5298 * fileio.c (Finsert_file_contents):
5299 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5300 Remove the old (too-loose) buffer overflow checks.
5301 They weren't needed, since make_gap checks for buffer overflow.
5302 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5303 The old code merely checked for Emacs fixnum overflow, and relied
5304 on undefined (wraparound) behavior. The new code avoids undefined
5305 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5307 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5308 Tune. Don't use wider integers than needed. Don't use alloca.
5309 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5311 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5313 * insdel.c, lisp.h (buffer_overflow): New function.
5314 (insert_from_buffer_1, replace_range, replace_range_2):
5315 * insdel.c (make_gap_larger):
5316 * editfns.c (Finsert_char):
5317 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5319 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5321 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5323 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5325 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5326 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5328 * fileio.c: Don't assume EMACS_INT fits in off_t.
5329 (emacs_lseek): New static function.
5330 (Finsert_file_contents, Fwrite_region): Use it.
5331 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5333 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5335 * fns.c: Don't overflow int when computing a list length.
5336 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5337 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5338 truncation on 64-bit hosts. Check for QUIT every
5339 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5340 faster and is responsive enough.
5341 (Flength): Report an error instead of overflowing an integer.
5342 (Fsafe_length): Return a float if the value is not representable
5343 as a fixnum. This shouldn't happen except in contrived situations.
5344 (Fnthcdr, Fsort): Don't assume list length fits in int.
5345 (Fcopy_sequence): Don't assume vector length fits in int.
5347 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5348 (header_size, word_size): New constants.
5349 (allocate_vectorlike): Don't check size overflow here.
5350 (allocate_vector): Check it here instead, since this is the only
5351 caller of allocate_vectorlike that could cause overflow.
5352 Check that the new vector's length is representable as a fixnum.
5354 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5355 The previous code was bogus. For example, next_almost_prime (32)
5356 returned 39, which is undesirable as it is a multiple of 3; and
5357 next_almost_prime (24) returned 25, which is a multiple of 5 so
5358 why was the code bothering to check for multiples of 7?
5360 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5362 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5364 Variadic C functions now count arguments with ptrdiff_t.
5365 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5366 Back then I didn't know that the Emacs coding style prefers signed int.
5367 Also, in the meantime I found a few more instances where arguments
5368 were being counted with int, which may truncate counts on 64-bit
5369 machines, or EMACS_INT, which may be unnecessarily wide.
5370 * lisp.h (struct Lisp_Subr.function.aMANY)
5371 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5372 Arg counts are now ptrdiff_t, not size_t.
5373 All variadic functions and their callers changed accordingly.
5374 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5375 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5376 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5377 * callint.c (Fcall_interactively): Check arg count for overflow,
5378 to avoid potential buffer overrun. Use signed char, not 'int',
5379 for 'varies' array, so that we needn't bother to check its size
5380 calculation for overflow.
5381 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5382 * eval.c (apply_lambda):
5383 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5384 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5385 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5387 * callint.c (Fcall_interactively): Don't use index var as event count.
5389 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5390 * mem-limits.h (SIZE): Remove; no longer used.
5392 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5394 Remove unnecessary casts.
5395 * xterm.c (x_term_init):
5396 * xfns.c (x_set_border_pixel):
5397 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5398 These aren't needed now that we assume ANSI C.
5400 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5401 It's more likely to cause problems (due to unsigned overflow)
5404 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5406 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5408 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5410 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5412 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5414 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5416 GLYPH_CODE_FACE returns EMACS_INT, not int.
5417 * dispextern.h (merge_faces):
5418 * xfaces.c (merge_faces):
5419 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5420 Don't assume EMACS_INT fits in int.
5422 * character.h (CHAR_VALID_P): Remove unused parameter.
5423 * fontset.c, lisp.h, xdisp.c: All uses changed.
5425 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5427 * fns.c (concat): Minor tuning based on overflow analysis.
5428 This doesn't fix any bugs. Use int to hold character, instead
5429 of constantly refetching from Emacs object. Use XFASTINT, not
5430 XINT, for value known to be a character. Don't bother comparing
5431 a single byte to 0400, as it's always less.
5433 * floatfns.c (Fexpt):
5434 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5436 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5439 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5441 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5442 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5443 incorrectly succeed when S was a string, because 4294967386 was
5444 truncated before it was used.
5446 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5447 Otherwise, an out-of-range integer could cause undefined behavior
5450 * composite.c: Use int, not EMACS_INT, for characters.
5451 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5452 EMACS_INT, for values that are known to be in character range.
5453 This doesn't fix any bugs but is the usual style inside Emacs and
5454 may generate better code on 32-bit machines.
5456 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5457 This is for reasons similar to the recent CHAR_STRING fix.
5458 * charset.c (Fencode_char): Check that character arg is actually
5459 a character. Pass an int to ENCODE_CHAR.
5460 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5461 wider than 'int', as a compile-time check to prevent future regressions
5464 * character.c (char_string): Remove unnecessary casts.
5466 Make sure a 64-bit char is never passed to CHAR_STRING.
5467 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5468 by silently ignoring the top 32 bits, allowing some values
5469 that were far too large to be valid characters.
5470 * character.h: Include <verify.h>.
5471 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5472 arguments are no wider than unsigned, as a compile-time check
5473 to prevent future regressions in this area.
5475 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5476 (Fsubst_char_in_region):
5478 * xdisp.c (decode_mode_spec_coding):
5479 Adjust to CHAR_STRING's new requirement.
5480 * editfns.c (Finsert_char, Fsubst_char_in_region):
5481 * fns.c (concat): Check that character args are actually
5482 characters. Without this test, these functions did the wrong
5483 thing with wildly out-of-range values on 64-bit hosts.
5485 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5486 These casts should not be needed on 32-bit hosts, either.
5487 * keyboard.c (read_char):
5488 * lread.c (Fload): Remove casts to unsigned.
5490 * lisp.h (UNSIGNED_CMP): New macro.
5491 This fixes comparison bugs on 64-bit hosts.
5492 (ASCII_CHAR_P): Use it.
5493 * casefiddle.c (casify_object):
5494 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5495 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5496 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5497 * dispextern.h (FACE_FROM_ID):
5498 * keyboard.c (read_char): Use UNSIGNED_CMP.
5500 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5501 not to EMACS_INT, to avoid GCC warning.
5503 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5505 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5506 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5507 isn't needed on 32-bit machines.
5509 * buffer.c (Fgenerate_new_buffer_name):
5510 Use EMACS_INT for count, not int.
5511 (advance_to_char_boundary): Return EMACS_INT, not int.
5513 * data.c (Qcompiled_function): Now static.
5515 * window.c (window_body_lines): Now static.
5517 * image.c (gif_load): Rename local to avoid shadowing.
5519 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5520 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5521 * alloc.c (make_save_value): Integer argument is now of type
5523 (mark_object): Use ptrdiff_t, not int.
5524 * lisp.h (pD): New macro.
5525 * print.c (print_object): Use it.
5527 * alloc.c: Use EMACS_INT, not int, to count objects.
5528 (total_conses, total_markers, total_symbols, total_vector_size)
5529 (total_free_conses, total_free_markers, total_free_symbols)
5530 (total_free_floats, total_floats, total_free_intervals)
5531 (total_intervals, total_strings, total_free_strings):
5532 Now EMACS_INT, not int. All uses changed.
5533 (Fgarbage_collect): Compute overall total using a double, so that
5534 integer overflow is less likely to be a problem. Check for overflow
5535 when converting back to an integer.
5536 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5537 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5538 These were 'int' variables that could overflow on 64-bit hosts;
5539 they were never used, so remove them instead of repairing them.
5540 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5541 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5542 Previously, this ceilinged at INT_MAX, but that doesn't work on
5544 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5546 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5547 (allocate_vectorlike): Check for ptrdiff_t overflow.
5548 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5549 when a (possibly-narrower) signed value would do just as well.
5550 We prefer using signed arithmetic, to avoid comparison confusion.
5552 * alloc.c: Catch some string size overflows that we were missing.
5553 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5554 for convenience in STRING_BYTES_MAX.
5555 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5556 The definition here is exact; the one in lisp.h was approximate.
5557 (allocate_string_data): Check for string overflow. This catches
5558 some instances we weren't catching before. Also, it catches
5559 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5560 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5561 and ptrdiff_t and EMACS_INT are both 64 bits.
5563 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5564 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5565 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5567 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5569 * alloc.c (Fmake_string): Check for out-of-range init.
5571 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5573 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5575 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5577 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5578 xg_get_default_scrollbar_width.
5580 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5581 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5582 (style_changed_cb): Call update_theme_scrollbar_width and call
5583 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5584 all frames (Bug#8505).
5585 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5586 Call gtk_window_set_resizable if HAVE_GTK3.
5587 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5588 and height if HAVE_GTK3 (Bug#8505).
5589 (scroll_bar_width_for_theme): New variable.
5590 (update_theme_scrollbar_width): New function.
5591 (xg_get_default_scrollbar_width): Move code to
5592 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5593 (xg_initialize): Call update_theme_scrollbar_width.
5595 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5597 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5599 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5601 * frame.c (make_frame): Call other_buffer_safely instead of
5604 * window.c (temp_output_buffer_show): Call display_buffer with
5605 second argument Vtemp_buffer_show_specifiers and reset latter
5606 immediately after the call.
5607 (Vtemp_buffer_show_specifiers): New variable.
5608 (auto_window_vscroll_p, next_screen_context_lines)
5609 (Vscroll_preserve_screen_position): Remove leading asterisks from
5612 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5614 Fix minor problems found by GCC 4.6.0 static checking.
5615 * buffer.c (Qclone_number): Remove for now, as it's unused.
5616 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5617 (record_buffer): Remove unused local.
5618 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5619 (set_frame_buffer_list): Remove; unused.
5620 * frame.h (other_visible_frames): Remove decl.
5621 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5622 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5623 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5625 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5626 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5627 Define only if HAVE_GPM.
5628 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5629 (update_hints_inhibit): Remove; never set. All uses removed.
5630 * widgetprv.h (emacsFrameClassRec): Remove decl.
5631 * window.c (delete_deletable_window): Now returns void, since it
5632 wasn't returning anything.
5633 (compare_window_configurations): Remove unused locals.
5634 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5635 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5636 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5637 the same widths as pointers. This follows up on the 2011-05-06 patch.
5638 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5639 * xterm.h: Likewise.
5640 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5642 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5644 * makefile.w32-in: Update dependencies.
5645 (LISP_H): Add lib/intprops.h.
5647 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5649 * image.c (gif_load): Add animation frame delay to the metadata.
5650 (syms_of_image): Use DEFSYM. New symbol `delay'.
5652 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5654 * window.c (delete_deletable_window): Re-add.
5655 (Fset_window_configuration): Rewrite to handle dead buffers and
5656 consequently deletable windows.
5657 (window_tree, Fwindow_tree): Remove. Supply functionality in
5659 (compare_window_configurations): Simplify code.
5661 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5663 * image.c (imagemagick_load_image): Fix type mismatch.
5664 (Fimagemagick_types): Likewise.
5666 * window.h (replace_buffer_in_windows): Declare.
5668 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5670 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5671 Qclone_number. Remove external declaration of Qdelete_window.
5672 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5674 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5675 Run Qbuffer_list_update_hook if allowed.
5676 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5677 buffer list implementation.
5678 (other_buffer_safely): New function.
5679 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5680 calls to replace_buffer_in_windows and
5681 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5683 (record_buffer): Inhibit quitting and rewrite using quittable
5684 functions. Run Qbuffer_list_update_hook if allowed.
5685 (Frecord_buffer, Funrecord_buffer): New functions.
5686 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5687 Move switch-to-buffer to window.el.
5688 (bury-buffer): Move to window.el.
5689 (Vbuffer_list_update_hook): New variable.
5691 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5694 * window.h (resize_frame_windows): Move up in code.
5695 (Fwindow_frame): Remove EXFUN.
5696 (replace_buffer_in_all_windows): Remove prototype.
5697 (replace_buffer_in_windows_safely): Add prototype.
5699 * window.c: Declare Qdelete_window static again. Move down
5700 declaration of select_count.
5701 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5702 (Fother_window): Move to window.el.
5703 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5704 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5705 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5707 (replace_buffer_in_windows): Implement by calling
5708 Qreplace_buffer_in_windows.
5709 (replace_buffer_in_all_windows): Remove with some functionality
5710 moved into replace_buffer_in_windows_safely.
5711 (replace_buffer_in_windows_safely): New function.
5712 (select_window_norecord, select_frame_norecord): Move in front
5713 of run_window_configuration_change_hook. Remove now obsolete
5715 (Fset_window_buffer): Rewrite doc-string.
5716 Call Qrecord_window_buffer.
5717 (keys_of_window): Move binding for other-window to window.el.
5719 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5721 * dispextern.h (struct image): Replace data member, whose int_val
5722 and ptr_val fields were not used by anything, with a single
5725 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5726 (gif_clear_image, gif_load, imagemagick_load_image)
5727 (gs_clear_image, gs_load): Callers changed.
5729 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5731 * buffer.h: Include <time.h>, for time_t.
5732 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5734 Fix minor problems found by static checking.
5736 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5738 Make identifiers static if they are not used in other modules.
5739 * data.c (Qcompiled_function, Qframe, Qvector):
5740 * image.c (QimageMagick, Qsvg):
5741 * minibuf.c (Qmetadata):
5742 * window.c (resize_window_check, resize_root_window): Now static.
5743 * window.h (resize_window_check, resize_root_window): Remove decls.
5745 * window.c (window_deletion_count, delete_deletable_window):
5747 (window_body_lines): Now static.
5748 (Fdelete_other_windows_internal): Mark vars as initialized.
5749 Make sure 'resize_failed' is initialized.
5750 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5751 (resize_window_apply): Remove unused local.
5752 * window.h (delete_deletable_window): Remove decl.
5754 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5755 (imagemagick_load_image): Fix pointer signedness problem by changing
5756 last arg from unsigned char * to char *. All uses changed.
5757 Also, fix a local for similar reasons.
5758 Remove unused locals. Remove locals to avoid shadowing.
5759 (fn_rsvg_handle_free): Remove; unused.
5760 (svg_load, svg_load_image): Fix pointer signedness problem.
5761 (imagemagick_load_image): Don't use garbage pointer image_wand.
5763 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5765 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5767 * image.c (gif_load): Fix omitted cast error introduced by
5770 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5772 * window.h (resize_proportionally, orig_total_lines)
5773 (orig_top_line): Remove from window structure.
5774 (set_window_height, set_window_width, change_window_heights)
5775 (Fdelete_window): Remove prototypes.
5776 (resize_frame_windows): Remove duplicate declaration.
5778 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5780 * window.h (resize_frame_windows, resize_window_check)
5781 (delete_deletable_window, resize_root_window)
5782 (resize_frame_windows): Declare prototypes.
5784 * window.c (resize_window_apply): Make definition be "static" to
5785 match the prototype.
5787 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5789 * window.c: Remove declarations of Qwindow_size_fixed,
5790 window_min_size_1, window_min_size_2, window_min_size,
5791 size_window, window_fixed_size_p, enlarge_window, delete_window.
5792 Remove static from declaration of Qdelete_window, it's
5793 temporarily needed by Fbury_buffer.
5794 (replace_window): Don't assign orig_top_line and
5796 (Fdelete_window, delete_window): Remove. Window deletion is
5797 handled by window.el.
5798 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5799 Replace Fdelete_window calls with calls to Qdelete_window.
5800 (Fdelete_other_windows): Remove. Deleting other windows is
5801 handled by window.el.
5802 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5803 handled in window.el.
5804 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5805 Window minimum sizes are handled in window.el.
5806 (shrink_windows, size_window, set_window_height)
5807 (set_window_width, change_window_heights, window_height)
5808 (window_width, CURBEG, CURSIZE, enlarge_window)
5809 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5810 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5811 handled in window.el.
5812 (make_dummy_parent): Rename to make_parent_window and give it a
5813 second argument horflag.
5814 (make_window): Don't set resize_proportionally any more.
5815 (Fsplit_window): Remove. Windows are split in window.el.
5816 (save_restore_action, save_restore_orig_size)
5817 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5818 Resize mini windows in window.el.
5819 (grow_mini_window, shrink_mini_window): Implement by calling
5820 Qresize_root_window_vertically, resize_window_check and
5821 resize_window_apply.
5822 (saved_window, Fset_window_configuration, save_window_save):
5823 Do not handle orig_top_line, orig_total_lines, and
5824 resize_proportionally.
5825 (window_min_height, window_min_width): Move to window.el.
5826 (keys_of_window): Move bindings for delete-other-windows,
5827 split-window, delete-window and enlarge-window to window.el.
5829 * buffer.c: Temporarily extern Qdelete_window.
5830 (Fbury_buffer): Temporarily call Qdelete_window instead of
5831 Fdelete_window (Fbury_buffer will move to window.el soon).
5833 * frame.c (set_menu_bar_lines_1): Remove code handling
5834 orig_top_line and orig_total_lines.
5836 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5837 set_window_height but set heights directly.
5838 (change_frame_size_1): Use resize_frame_windows.
5840 * xdisp.c (init_xdisp): Don't use set_window_height but set
5843 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5844 Use resize_frame_windows instead of change_window_heights and run
5845 run_window_configuration_change_hook.
5847 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5848 instead of change_window_heights and run
5849 run_window_configuration_change_hook.
5851 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5853 * window.c (replace_window): Rename second argument REPLACEMENT to
5854 NEW. New third argument SETFLAG. Rewrite.
5855 (delete_window, make_dummy_parent): Call replace_window with
5857 (window_list_1): Move down in code.
5858 (run_window_configuration_change_hook): Move set_buffer part
5859 before select_frame_norecord part in order to unwind correctly.
5860 Rename count1 to count.
5861 (recombine_windows, delete_deletable_window, resize_root_window)
5862 (Fdelete_other_windows_internal)
5863 (Frun_window_configuration_change_hook, make_parent_window)
5864 (resize_window_check, resize_window_apply, Fresize_window_apply)
5865 (resize_frame_windows, Fsplit_window_internal)
5866 (Fdelete_window_internal, Fresize_mini_window_internal):
5868 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5870 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5872 * window.h (window): Add some new members to window structure -
5873 normal_lines, normal_cols, new_total, new_normal, clone_number,
5874 splits, nest, prev_buffers, next_buffers.
5875 (WINDOW_TOTAL_SIZE): Move here from window.c.
5876 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5878 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5880 (make_dummy_parent): Set new members of windows structure.
5881 (make_window): Move down in code. Handle new members of window
5883 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5884 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5885 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5886 (Fset_window_prev_buffers, Fwindow_next_buffers)
5887 (Fset_window_next_buffers, Fset_window_clone_number):
5889 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5890 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5892 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5893 Argument WINDOW can be now internal window too.
5894 (Fwindow_use_time): Move up in code.
5895 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5897 (Fset_window_configuration, saved_window)
5898 (Fcurrent_window_configuration, save_window_save): Handle new
5899 members of window structure.
5900 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5901 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5902 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5903 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5904 Qget_mru_window, Qresize_root_window,
5905 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5906 Qauto_buffer_name; staticpro them.
5908 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5910 * window.c (Fwindow_total_size, Fwindow_left_column)
5911 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5912 (Fwindow_list_1): New functions.
5913 (window_box_text_cols): Replace with window_body_cols.
5914 (Fwindow_width, Fscroll_left, Fscroll_right):
5915 Use window_body_cols instead of window_box_text_cols.
5916 (delete_window, Fset_window_configuration):
5917 Call delete_all_subwindows with window as argument.
5918 (delete_all_subwindows): Take a window as argument and not a
5920 (window_loop): Remove handling of GET_LRU_WINDOW and
5922 (Fget_lru_window, Fget_largest_window): Move to window.el.
5924 * window.h: Extern window_body_cols instead of
5925 window_box_text_cols. delete_all_subwindows now takes a
5926 Lisp_Object as argument.
5928 * indent.c (compute_motion, Fcompute_motion):
5929 Use window_body_cols instead of window_box_text_cols.
5931 * frame.c (delete_frame): Call delete_all_subwindows with root
5934 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5936 * fns.c (Fputhash): Document return value.
5938 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5940 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5942 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5944 Cons<->int and similar integer overflow fixes (Bug#8794).
5946 Check for overflow when converting integer to cons and back.
5947 * charset.c (Fdefine_charset_internal, Fdecode_char):
5948 Use cons_to_unsigned to catch overflow.
5949 (Fencode_char): Use INTEGER_TO_CONS.
5950 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5951 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5952 * data.c (long_to_cons, cons_to_long): Remove.
5953 (cons_to_unsigned, cons_to_signed): New functions.
5954 These signal an error for invalid or out-of-range values.
5955 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5956 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5957 * font.c (Ffont_variation_glyphs):
5958 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5959 * lisp.h: Include <intprops.h>.
5960 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5961 (cons_to_signed, cons_to_unsigned): New decls.
5962 (long_to_cons, cons_to_long): Remove decls.
5963 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5964 (Fprimitive_undo): Use CONS_TO_INTEGER.
5965 * xfns.c (Fx_window_property): Likewise.
5966 * xselect.c: Include <limits.h>.
5967 (x_own_selection, selection_data_to_lisp_data):
5968 Use INTEGER_TO_CONS.
5969 (x_handle_selection_request, x_handle_selection_clear)
5970 (x_get_foreign_selection, Fx_disown_selection_internal)
5971 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5972 (lisp_data_to_selection_data): Use cons_to_unsigned.
5973 (x_fill_property_data): Use cons_to_signed.
5974 Report values out of range.
5976 Check for buffer and string overflow more precisely.
5977 * buffer.h (BUF_BYTES_MAX): New macro.
5978 * lisp.h (STRING_BYTES_MAX): New macro.
5979 * alloc.c (Fmake_string):
5980 * character.c (string_escape_byte8):
5981 * coding.c (coding_alloc_by_realloc):
5982 * doprnt.c (doprnt):
5983 * editfns.c (Fformat):
5985 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5986 since they may not be the same number.
5987 * editfns.c (Finsert_char):
5988 * fileio.c (Finsert_file_contents):
5989 Likewise for BUF_BYTES_MAX.
5991 * image.c: Use ptrdiff_t, not int, for sizes.
5992 (slurp_file): Switch from int to ptrdiff_t.
5994 (slurp_file): Check that file size fits in both size_t (for
5995 malloc) and ptrdiff_t (for sanity and safety).
5997 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5998 if b->modtime has its maximal value.
6000 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6002 Don't assume time_t can fit into int.
6003 * buffer.h (struct buffer.modtime): Now time_t, not int.
6004 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6005 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6007 Minor fixes for signed vs unsigned integers.
6008 * character.h (MAYBE_UNIFY_CHAR):
6009 * charset.c (maybe_unify_char):
6010 * keyboard.c (read_char, reorder_modifiers):
6011 XINT -> XFASTINT, since the integer must be nonnegative.
6012 * ftfont.c (ftfont_spec_pattern):
6013 * keymap.c (access_keymap, silly_event_symbol_error):
6014 XUINT -> XFASTINT, since the integer must be nonnegative.
6015 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6016 since it makes no difference and we prefer signed.
6017 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6018 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6021 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6023 * window.h (Fwindow_frame): Declare.
6025 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6027 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6028 (SPARE_MEMORY): Always define.
6029 (LARGE_REQUEST): Remove.
6030 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6032 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6034 * lisp.h: Move EXFUNS for Fframe_root_window,
6035 Fframe_first_window and Fset_frame_selected_window to window.h.
6037 * window.h: Move EXFUNS for Fframe_root_window,
6038 Fframe_first_window and Fset_frame_selected_window here from
6041 * frame.c (Fwindow_frame, Fframe_first_window)
6042 (Fframe_root_window, Fframe_selected_window)
6043 (Fset_frame_selected_window): Move to window.c.
6044 (Factive_minibuffer_window): Move to minibuf.c.
6045 (Fother_visible_frames_p): New function.
6047 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6049 * window.c (decode_window, decode_any_window): Move up in code.
6050 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6051 (inhibit_frame_unsplittable): Remove unused variable.
6052 (Fwindow_buffer): Move up and rewrite doc-string.
6053 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6054 (Fwindow_prev): New functions.
6055 (Fwindow_frame): Move here from frame.c. Accept any window as
6057 (Fframe_root_window, Fframe_first_window)
6058 (Fframe_selected_window): Move here from frame.c. Accept frame
6059 or arbitrary window as argument. Update doc-strings.
6060 (Fminibuffer_window): Move up in code.
6061 (Fwindow_minibuffer_p): Move up in code and simplify.
6062 (Fset_frame_selected_window): Move here from frame.c.
6064 (Fselected_window, select_window, Fselect_window): Move up in
6065 code. Minor doc-string fixes.
6067 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6069 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6070 Do not assume that spare memory exists; that assumption is valid
6071 only if SYSTEM_MALLOC.
6072 (LARGE_REQUEST): New macro, so that the issue of large requests
6073 is separated from the issue of spare memory.
6075 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6077 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6080 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6082 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6085 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6087 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6089 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6091 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6092 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6094 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6096 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6098 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6100 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6101 (x_clipboard_manager_save): Add return value.
6102 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6104 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6105 Obey Vx_select_enable_clipboard_manager. Catch errors in
6106 x_clipboard_manager_save (Bug#8779).
6107 (Vx_select_enable_clipboard_manager): New variable.
6108 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6110 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6112 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6114 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6116 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6117 in the current matrix if keep_current_p is non-zero.
6119 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6121 * bidi.c (bidi_level_of_next_char): Fix last change.
6123 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6125 Support bidi reordering of text covered by display properties.
6127 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6128 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6129 (bidi_cache_search, bidi_cache_iterator_state)
6130 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6131 (bidi_level_of_next_char, bidi_move_to_visually_next):
6132 Support character positions inside a run of characters covered by a
6134 (bidi_paragraph_init, bidi_resolve_explicit_1)
6135 (bidi_level_of_next_char): Call bidi_fetch_char and
6136 bidi_fetch_char_advance instead of FETCH_CHAR and
6138 (bidi_init_it): Initialize new members.
6139 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6141 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6142 instead of using explicit *_CHAR codes.
6143 (bidi_resolve_explicit, bidi_resolve_weak):
6144 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6145 bidirectional text is supported only in multibyte buffers.
6146 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6147 it to initialize the frame_window_p member of struct bidi_it.
6148 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6149 (bidi_resolve_explicit, bidi_resolve_weak)
6150 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6151 bidi_it->nchars is non-positive.
6152 (bidi_level_of_next_char): Don't try to lookup the cache for the
6153 next/previous character if nothing is cached there yet, or if we
6154 were just reseat()'ed to a new position.
6156 * xdisp.c (set_cursor_from_row): Set start and stop points
6157 according to the row's direction when priming the loop that looks
6158 for the glyph on which to display cursor.
6159 (single_display_spec_intangible_p): Function deleted.
6160 (display_prop_intangible_p): Reimplement to call
6161 handle_display_spec instead of single_display_spec_intangible_p.
6162 Accept 3 additional arguments needed by handle_display_spec.
6163 This fixes incorrect cursor motion across display property with complex
6164 values: lists, `(when COND...)' forms, etc.
6165 (single_display_spec_string_p): Support property values that are
6166 lists with the argument STRING its top-level element.
6167 (display_prop_string_p): Fix the condition for processing a
6168 property that is a list to be consistent with handle_display_spec.
6169 (handle_display_spec): New function, refactored from the
6170 last portion of handle_display_prop.
6171 (compute_display_string_pos): Accept additional argument
6172 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6173 value of a `display' property is a "replacing spec".
6174 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6175 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6176 the display property, but just return a value indicating whether
6177 the display property will replace the characters it covers.
6178 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6179 frame_window_p members of struct bidi_it.
6180 (compute_display_string_pos, compute_display_string_end):
6182 (push_it): Accept second argument POSITION, where pop_it should
6183 jump to continue iteration.
6184 (reseat_1): Initialize bidi_it.disp_pos.
6186 * keyboard.c (adjust_point_for_property): Adjust the call to
6187 display_prop_intangible_p to its new signature.
6189 * dispextern.h (struct bidi_it): New member frame_window_p.
6190 (bidi_init_it): Update prototypes.
6191 (display_prop_intangible_p): Update prototype.
6192 (compute_display_string_pos, compute_display_string_end):
6194 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6197 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6199 Malloc failure behavior now depends on size of allocation.
6200 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6201 * lisp.h: Change signatures accordingly.
6202 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6203 All callers changed. (Bug#8762)
6205 * gnutls.c: Use Emacs's memory allocators.
6206 Without this change, the gnutls library would invoke malloc etc.
6207 directly, which causes problems on non-SYNC_INPUT hosts, and which
6208 runs afoul of improving memory_full behavior. (Bug#8761)
6209 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6210 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6211 xfree instead of the default malloc, realloc, free.
6212 (Fgnutls_boot): No need to check for memory allocation failure,
6213 since xmalloc does that for us.
6215 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6216 * category.c (hash_get_category_set):
6217 * ccl.c (ccl_driver):
6218 * charset.c (Fdefine_charset_internal):
6219 * charset.h (struct charset.hash_index):
6220 * composite.c (get_composition_id, gstring_lookup_cache)
6221 (composition_gstring_put_cache):
6222 * composite.h (struct composition.hash_index):
6223 * dispextern.h (struct image.hash):
6224 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6225 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6226 (hashfn_equal, hashfn_user_defined, make_hash_table)
6227 (maybe_resize_hash_table, hash_lookup, hash_put)
6228 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6229 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6230 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6231 * image.c (make_image, search_image_cache, lookup_image)
6232 (xpm_put_color_table_h):
6233 * lisp.h (struct Lisp_Hash_Table):
6234 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6235 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6236 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6237 * alloc.c (allocate_vectorlike):
6238 Check for overflow in vector size calculations.
6239 * ccl.c (ccl_driver):
6240 Check for overflow when converting EMACS_INT to int.
6241 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6242 need to be updated by these changes.
6243 * fns.c (make_hash_table, maybe_resize_hash_table):
6244 Check for integer overflow with large hash tables.
6245 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6246 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6247 (SXHASH_REDUCE): New macro.
6248 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6249 Use it instead of discarding useful hash info with large hash values.
6250 (sxhash_float): New function.
6251 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6252 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6253 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6254 Rewrite to use FIXNUM_BITS, as this simplifies things.
6255 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6256 Adjust signatures to match updated version of code.
6257 (consing_since_gc): Now EMACS_INT, since a single hash table can
6258 use more than INT_MAX bytes.
6260 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6262 Make it possible to build with GCC-4.6+ -O2 -flto.
6264 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6266 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6268 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6269 Call minibuffer-inactive-mode.
6271 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6273 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6274 Update dependencies.
6276 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6278 * data.c (init_data): Remove code for UTS, this system is not
6281 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6283 Don't force ./temacs to start in terminal mode.
6285 * frame.c (make_initial_frame): Initialize faces in all cases, not
6286 only when CANNOT_DUMP is defined.
6287 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6289 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6291 * dispnew.c (add_window_display_history): Use const for the string
6292 pointer. Remove declaration, not needed.
6294 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6296 Use 'inline', not 'INLINE'.
6297 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6298 * alloc.c, fontset.c (INLINE): Remove.
6299 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6300 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6301 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6302 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6303 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6305 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6307 Make it possible to run ./temacs.
6309 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6310 syms_of_callproc does the same thing. Remove test for
6311 "initialized", do it in the caller.
6312 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6314 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6316 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6317 (read_minibuf): Use get_minibuffer.
6318 (syms_of_minibuf): Use DEFSYM.
6319 (Qmetadata): New var.
6320 * data.c (Qbuffer): Don't make it static.
6321 (syms_of_data): Use DEFSYM.
6323 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6325 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6326 (CCL_CODE_MIN): New macro.
6328 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6330 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6332 * eval.c (Qdebug): Now static.
6333 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6334 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6335 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6337 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6339 * image.c: Various fixes to ImageMagick code comments.
6340 (Fimagemagick_types): Doc fix.
6342 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6344 Minor fixes prompted by GCC 4.6.0 warnings.
6346 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6348 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6349 (x_clipboard_manager_save_all): Move extern decl to ...
6350 * xterm.h: ... here, so that it can be checked for consistency.
6352 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6354 * xselect.c (x_clipboard_manager_save_frame)
6355 (x_clipboard_manager_save_all): New functions.
6356 (Fx_clipboard_manager_save): Lisp function deleted.
6358 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6359 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6361 * xterm.h: Update prototype.
6363 2011-05-28 William Xu <william.xwl@gmail.com>
6365 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6368 2011-05-28 Jim Meyering <meyering@redhat.com>
6370 Avoid a sign-extension bug in crypto_hash_function.
6371 * fns.c (to_uchar): Define.
6372 (crypto_hash_function): Use it to convert some newly-signed
6373 variables to unsigned, to avoid sign-extension bugs. For example,
6374 without this change, (md5 "truc") would evaluate to
6375 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6376 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6377 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6379 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6381 Integer overflow fixes.
6383 * dbusbind.c: Serial number integer overflow fixes.
6384 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6385 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6386 to hold a serial number that is too large for a fixnum.
6387 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6388 Check for serial numbers out of range. Decode any serial number
6389 that was so large that it became a float. (Bug#8722)
6391 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6392 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6393 Use XFASTINT rather than XUINT when numbers are nonnegative.
6394 (xd_append_arg, Fdbus_method_return_internal):
6395 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6396 arguments, check that Lisp number is nonnegative, rather than
6397 silently wrapping negative numbers around. (Bug#8722)
6398 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6401 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6403 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6405 ccl: Add integer overflow checks.
6406 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6407 (IN_INT_RANGE): New macros.
6408 (ccl_driver): Use them to check for integer overflow when
6409 decoding a CCL program. Many of the new checks are whether XINT (x)
6410 fits in int; it doesn't always, on 64-bit hosts. The new version
6411 doesn't catch all possible integer overflows, but it's an
6412 improvement. (Bug#8719)
6414 * alloc.c (make_event_array): Use XINT, not XUINT.
6415 There's no need for unsigned here.
6417 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6418 This follows up to the 2011-05-06 change that substituted uintptr_t
6419 for EMACS_INT. This case wasn't caught back then.
6421 Rework Fformat to avoid integer overflow issues.
6422 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6423 now (part of C89). Include <verify.h>.
6424 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6425 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6426 (Fformat): Avoid the prepass trying to compute sizes; it was only
6427 approximate and thus did not catch overflow reliably. Instead, walk
6428 through the format just once, formatting and computing sizes as we go,
6429 checking for integer overflow at every step, and allocating a larger
6430 buffer as needed. Keep track separately whether the format is
6431 multibyte. Keep only the most-recently calculated precision, rather
6432 than them all. Record whether each argument has been converted to
6433 string. Use EMACS_INT, not int, for byte and char and arg counts.
6434 Support field widths and precisions larger than INT_MAX. Avoid
6435 sprintf's undefined behavior with conversion specifications such as %#d
6436 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6437 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6438 formatting out-of-range floating point numbers with int
6441 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6443 * data.c: Avoid integer truncation in expressions involving floats.
6444 * data.c: Include <intprops.h>.
6445 (arith_driver): When there's an integer overflow in an expression
6446 involving floating point, convert the integers to floating point
6447 so that the resulting value does not suffer from catastrophic
6448 integer truncation. For example, on a 64-bit host (* 4
6449 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6450 Do not rely on undefined behavior after integer overflow.
6452 merge count_size_as_multibyte, parse_str_to_multibyte
6453 * character.c, character.h (count_size_as_multibyte):
6454 Rename from parse_str_to_multibyte; all uses changed.
6455 Check for integer overflow.
6456 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6457 since it's now a duplicate of the other. This is more of
6458 a character than a buffer op, so better that it's in character.c.
6459 * fns.c, print.c: Adjust to above changes.
6461 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6463 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6465 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6467 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6468 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6469 (x_clipboard_manager_save): Now static.
6470 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6472 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6473 (crypto_hash_function): Now static.
6474 Fix pointer signedness problems. Avoid unnecessary initializations.
6476 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6478 * termhooks.h (Vselection_alist): Make it terminal-local.
6480 * terminal.c (create_terminal): Initialize it.
6482 * xselect.c: Support for clipboard managers.
6483 (Vselection_alist): Move to termhooks.h as terminal-local var.
6484 (LOCAL_SELECTION): New macro.
6485 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6486 (symbol_to_x_atom): Remove gratuitous arg.
6487 (x_handle_selection_request, lisp_data_to_selection_data)
6488 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6489 (x_own_selection, x_get_local_selection, x_convert_selection):
6490 New arg, specifying work frame. Use terminal-local Vselection_alist.
6491 (some_frame_on_display): Delete unused function.
6492 (Fx_own_selection_internal, Fx_get_selection_internal)
6493 (Fx_disown_selection_internal, Fx_selection_owner_p)
6494 (Fx_selection_exists_p): New optional frame arg.
6495 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6496 (x_handle_selection_clear): Don't treat other terminals with the
6497 same keyboard specially. Use the terminal-local Vselection_alist.
6498 (x_clear_frame_selections): Use Frun_hook_with_args.
6500 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6502 * xterm.h: Add support for those atoms.
6504 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6506 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6507 (converted_selections, conversion_fail_tag): New global variables.
6508 (x_selection_request_lisp_error): Free the above.
6509 (x_get_local_selection): Remove unnecessary code.
6510 (x_reply_selection_request): Args changed; handle arbitrary array
6511 of converted selections stored in converted_selections.
6512 Separate the XChangeProperty and SelectionNotify steps.
6513 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6514 (x_convert_selection): New function.
6515 (x_handle_selection_event): Simplify.
6516 (x_get_foreign_selection): Don't ignore incoming requests while
6517 waiting for an answer; this will fail when we implement
6518 SAVE_TARGETS, and seems unnecessary anyway.
6519 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6520 (Vx_sent_selection_functions): Doc fix.
6522 2011-05-26 Leo Liu <sdl.web@gmail.com>
6524 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6526 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6528 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6530 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6531 for fringe update if it has periodic bitmap.
6532 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6533 and fringe_bitmap_periodic_p.
6535 * fringe.c (get_fringe_bitmap_data): New function.
6536 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6537 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6538 row. Mark glyph row for fringe update if periodicity changed.
6540 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6541 for fringe update unless it has periodic bitmap.
6543 2011-05-25 Kenichi Handa <handa@m17n.org>
6545 * xdisp.c (get_next_display_element): Set correct it->face_id for
6546 a static composition.
6548 2011-05-24 Leo Liu <sdl.web@gmail.com>
6551 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6553 * fns.c (crypto_hash_function, Fsha1): New function.
6554 (Fmd5): Use crypto_hash_function.
6555 (syms_of_fns): Add Ssha1.
6557 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6559 * gnutls.c: Remove unused macros.
6560 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6561 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6562 Remove macros that are defined and never used.
6563 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6565 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6567 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6568 (Fx_get_selection_internal): Minor cleanup.
6569 (Fx_own_selection_internal): Rename arguments for consistency with
6572 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6574 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6576 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6578 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6580 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6582 * dispnew.c (scrolling_window): Don't exclude the case that the
6583 last enabled row in the desired matrix touches the bottom boundary.
6585 2011-05-21 Glenn Morris <rgm@gnu.org>
6587 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6588 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6589 and add some more files.
6591 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6593 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6594 report_file_error introduced by the change from 2011-05-07.
6596 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6598 * systime.h (Time): Define only if emacs is defined.
6599 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6600 where the include path doesn't have X11/X.h by default. See
6601 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6603 2011-05-20 Kenichi Handa <handa@m17n.org>
6605 * composite.c (find_automatic_composition): Fix previous change.
6607 2011-05-20 Glenn Morris <rgm@gnu.org>
6609 * lisp.mk: New file, split from Makefile.in.
6610 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6611 (shortlisp): Remove.
6612 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6614 2011-05-19 Glenn Morris <rgm@gnu.org>
6616 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6617 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6618 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6619 (lisp): Set the order to that of loadup.el.
6620 (shortlisp): Make it a copy of $lisp.
6621 (SOME_MACHINE_LISP): Remove.
6622 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6623 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6625 2011-05-18 Kenichi Handa <handa@m17n.org>
6627 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6628 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6629 (find_automatic_composition): Mostly rewrite for efficiency.
6631 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6633 * makefile.w32-in: Update dependencies.
6635 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6637 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6638 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6640 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6642 Fix some integer overflow issues, such as string length overflow.
6644 * insdel.c (count_size_as_multibyte): Check for string overflow.
6646 * character.c (lisp_string_width): Check for string overflow.
6647 Use EMACS_INT, not int, for string indexes and lengths; in
6648 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6649 the resulting string length overflows an EMACS_INT; instead,
6650 report a string overflow if no precision given. When checking for
6651 precision exhaustion, use a check that cannot possibly have
6652 integer overflow. (Bug#8675)
6653 * character.h (lisp_string_width): Adjust to new signature.
6655 * alloc.c (string_overflow): New function.
6656 (Fmake_string): Use it. This doesn't change behavior, but saves
6657 a few bytes and will simplify future changes.
6658 * character.c (string_escape_byte8): Likewise.
6659 * lisp.h (string_overflow): New decl.
6661 Fixups, following up to the user-interface timestamp change.
6662 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6663 for UI timestamps, instead of unsigned long.
6664 * msdos.c (mouse_get_pos): Likewise.
6665 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6666 * w32gui.h (Time): Define by including "systime.h" rather than by
6667 declaring it ourselves. (Bug#8664)
6669 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6670 * image.c (clear_image_cache): Likewise.
6672 * term.c (term_mouse_position): Don't assume time_t wraparound.
6674 Be more systematic about user-interface timestamps.
6675 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6676 and sometimes 'EMACS_UINT', to represent these timestamps.
6677 This change causes it to use 'Time' uniformly, as that's what X uses.
6678 This makes the code easier to follow, and makes it easier to catch
6679 integer overflow bugs such as Bug#8664.
6680 * frame.c (Fmouse_position, Fmouse_pixel_position):
6681 Use Time, not unsigned long, for user-interface timestamps.
6682 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6683 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6684 * keyboard.h (last_event_timestamp): Likewise.
6685 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6686 * menu.h (xmenu_show): Likewise.
6687 * term.c (term_mouse_position): Likewise.
6688 * termhooks.h (struct input_event.timestamp): Likewise.
6689 (struct terminal.mouse_position_hook): Likewise.
6690 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6691 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6692 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6693 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6695 * menu.h, termhooks.h: Include "systime.h", for Time.
6697 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6698 Don't assume that the difference between two unsigned long values
6699 can fit into an integer. At this point, we know button_down_time
6700 <= event->timestamp, so the difference must be nonnegative, so
6701 there's no need to cast the result if double-click-time is
6702 nonnegative, as it should be; check that it's nonnegative, just in
6703 case. This bug is triggered when events are more than 2**31 ms
6704 apart (about 25 days). (Bug#8664)
6706 * xselect.c (last_event_timestamp): Remove duplicate decl.
6707 (x_own_selection): Remove needless cast to unsigned long.
6709 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6710 that always fit in int. Use a sentinel instead of a counter, to
6711 avoid a temp and to allay GCC's concerns about possible int overflow.
6712 * frame.h (struct frame): Use int for menu_bar_items_used
6713 instead of EMACS_INT, since it always fits in int.
6715 * menu.c (grow_menu_items): Check for int overflow.
6717 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6719 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6720 Before, the code was not consistent. These values cannot exceed
6721 2**31 - 1 so there's no need to make them unsigned.
6722 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6723 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6724 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6726 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6728 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6729 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6730 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6731 presumably because the widths might not match.
6733 * window.c (size_window): Avoid needless test at loop start.
6735 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6737 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6739 2011-05-12 Drew Adams <drew.adams@oracle.com>
6741 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6743 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6745 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6746 `width' to `bar_area_x' and `bar_area_width', respectively.
6747 (x_scroll_run): Take account of fringe background extension.
6749 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6750 Rename local vars `left' and `width' to `bar_area_x' and
6751 `bar_area_width', respectively.
6752 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6753 background extension.
6755 2011-05-10 Jim Meyering <meyering@redhat.com>
6757 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6759 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6761 * image.c (Finit_image_library): Return t for built-in image types,
6762 like pbm and xbm. (Bug#8640)
6764 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6766 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6768 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6770 * w32console.c (Fset_screen_color): Doc fix.
6771 (Fget_screen_color): New function.
6772 (syms_of_ntterm): Defsubr it.
6774 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6775 unlink the temporary file if Fcall_process didn't create it in the
6777 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6778 child process will be redirected to a file specified with `:file'.
6779 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6780 cue to call_process_cleanup not to close that handle.
6782 2011-05-07 Ben Key <bkey76@gmail.com>
6784 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6785 one of two shell specific rules, either bootstrap-temacs-CMD or
6786 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6787 to the previous implementation of the bootstrap-temacs rule.
6788 The bootstrap-temacs-CMD rule is similar to the previous
6789 implementation of the bootstrap-temacs rule except that it
6790 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6793 These changes, along with some changes to nt/configure.bat,
6794 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6795 earlier fix to add support for --cflags and --ldflags options
6796 that include quotes so that it works whether make uses cmd or
6799 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6801 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6802 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6804 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6805 a string. Handle both cases.
6806 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6807 (Fdbus_register_method): Use Qinvalid_function.
6809 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6811 * makefile.w32-in: Update dependencies.
6812 (LISP_H): Add inttypes.h and stdin.h.
6813 (PROCESS_H): Add unistd.h.
6815 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6817 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6818 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6820 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6822 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6824 * term.c (vfatal): Remove stray call to va_end.
6825 It's not needed and the C Standard doesn't allow it here anyway.
6827 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6828 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6830 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6833 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6835 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6837 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6839 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6841 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6843 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6844 * charset.c (Fdefine_charset_internal): Don't initialize
6845 charset.code_space[15]. The value was garbage, on hosts with
6846 32-bit int (Bug#8600).
6848 * lread.c (read_integer): Be more consistent with string-to-number.
6849 Use string_to_number to do the actual conversion; this avoids
6850 rounding errors and fixes some other screwups. Without this fix,
6851 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6852 (digit_to_number): Move earlier, for benefit of read_integer.
6853 Return -1 if the digit is out of range for the base, -2 if it is
6854 not a digit in any supported base. (Bug#8602)
6856 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6858 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6859 to match comment at start of function. This also removes a
6860 GCC warning about overflow in a 32+64-bit port.
6862 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6864 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6865 Reported by Stefan Monnier in
6866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6867 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6868 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6870 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6871 (EMACS_UINTPTR): Likewise, with uintptr_t.
6873 * lisp.h: Prefer 64-bit EMACS_INT if available.
6874 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6875 on 32-bit hosts that have 64-bit int, so that they can access
6877 However, temporarily disable this change unless the temporary
6878 symbol WIDE_EMACS_INT is defined.
6880 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6882 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6883 This removes an assumption that EMACS_INT and long are the same
6884 width as pointers. The assumption is true for Emacs porting targets
6885 now, but we want to make other targets possible.
6886 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6887 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6888 In the rest of the code, change types of integers that hold casted
6889 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6890 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6891 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6892 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6893 No need to cast type when ORing.
6894 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6895 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6896 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6897 assume EMACS_INT is the same width as char *.
6898 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6899 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6900 Remove no-longer-needed casts.
6901 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6902 (xg_tool_bar_help_callback, xg_make_tool_item):
6903 Use EMACS_INTPTR to hold an integer
6904 that will be cast to void *; this can avoid a GCC warning
6905 if EMACS_INT is not the same width as void *.
6906 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6907 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6908 (current_message_1, set_message_1):
6909 Use a local to convert to proper width without a cast.
6910 * xmenu.c (dialog_selection_callback): Likewise.
6912 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6913 Also, don't assume VALBITS / RAND_BITS is less than 5,
6914 and don't rely on undefined behavior when shifting a 1 left into
6916 * lisp.h (get_random): Change signature to match.
6918 * lread.c (hash_string): Use size_t, not int, for hash computation.
6919 Normally we prefer signed values; but hashing is special, because
6920 it's better to use unsigned division on hash table sizes so that
6921 the remainder is nonnegative. Also, size_t is the natural width
6922 for hashing into memory. The previous code used 'int', which doesn't
6923 retain enough info to hash well into very large tables.
6924 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6926 * dbusbind.c: Don't possibly lose pointer info when converting.
6927 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6928 Use XPNTR rather than XHASH, so that the high-order bits of
6929 the pointer aren't lost when converting through void *.
6931 * eval.c (Fautoload): Don't double-shift a pointer.
6933 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6935 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6937 * gnutls.c (DEF_GNUTLS_FN):
6938 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6940 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6942 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6945 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6947 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6948 New version that can reserve upto 2GB of heap space.
6950 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6952 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6954 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6956 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6957 `gnutls_certificate_set_x509_key_file'.
6959 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6961 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6962 Update dependencies.
6964 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6966 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6967 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6968 Remove unused parameter `fildes'.
6969 * process.c (read_process_output, send_process): Don't pass it.
6971 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6973 Fix previous change: the library cache is defined in w32.c.
6974 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6975 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6977 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6979 Implement dynamic loading of GnuTLS on Windows.
6981 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6982 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6983 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6986 * gnutls.c (Qgnutls_dll): Define.
6987 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6988 (gnutls_*): Declare function pointers.
6989 (init_gnutls_functions): New function to initialize function pointers.
6990 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6991 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6992 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6993 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6994 (emacs_gnutls_write, emacs_gnutls_read)
6995 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6996 (Fgnutls_available_p): New function.
6997 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6998 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6999 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7001 * image.c: Include w32.h.
7002 (Vimage_type_cache): Delete.
7003 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7004 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7005 (w32_delayed_load): Move to w32.c.
7007 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7009 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7010 (w32_delayed_load): Move from image.c. When loading a library, record
7011 its filename in the :loaded-from property of the library id.
7012 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7013 Initialize and staticpro them.
7014 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7016 * process.c: Include lisp.h before w32.h, not after.
7017 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7018 instead of gnutls_record_check_pending.
7020 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7022 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7024 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7025 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7028 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7030 * xterm.c (x_set_frame_alpha): Do not set property on anything
7031 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7033 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7035 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7037 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7039 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7040 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7041 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7042 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7043 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7044 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7045 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7046 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7047 (Qgnutls_bootprop_callbacks_verify): Make static.
7049 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7051 * callproc.c: Indentation fixup.
7053 * sysdep.c (wait_for_termination_1): Make static.
7054 (wait_for_termination, interruptible_wait_for_termination):
7055 Move after wait_for_termination_1.
7057 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7059 * sysdep.c (interruptible_wait_for_termination): New function
7060 which is like wait_for_termination, but allows keyboard
7063 * callproc.c (Fcall_process): Add (:file "file") as an option for
7065 (Fcall_process_region): Ditto.
7067 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7069 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7070 rather than `XVECTOR (FOO)->size'.
7072 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7073 inttypes.h, as a gnulib replacement is used if it not available in
7076 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7078 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7079 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7080 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7082 * coding.c (coding_alloc_by_realloc): Error out if destination
7083 will grow beyond MOST_POSITIVE_FIXNUM.
7084 (decode_coding_emacs_mule): Abort if there isn't enough place in
7085 charbuf for the composition carryover bytes. Reserve an extra
7086 space for up to 2 characters produced in a loop.
7087 (decode_coding_iso_2022): Abort if there isn't enough place in
7088 charbuf for the composition carryover bytes.
7090 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7092 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7093 aborting when %lld or %lll format is passed.
7094 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7095 %llo or %llx format is passed. (Bug#8545)
7097 * window.c (window_scroll_line_based): Use a marker instead of
7098 simple variables to record original value of point. (Bug#7952)
7100 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7101 produced by %s or %c overflows available buffer space. (Bug#8545)
7103 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7105 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7106 (SIZE_MAX): Move defn after all includes, as they might #define it.
7108 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7110 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7112 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7114 * keyboard.c (Qdelayed_warnings_hook): Define.
7115 (command_loop_1): Run `delayed-warnings-hook'
7116 if Vdelayed_warnings_list is non-nil.
7117 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7118 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7120 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7122 * doprnt.c (doprnt): Don't return value smaller than the buffer
7123 size if the message was truncated. (Bug#8545).
7125 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7127 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7128 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7130 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7132 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7134 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7136 * makefile.w32-in: Update dependencies.
7138 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7140 Improve `doprnt' and its usage. (Bug#8545)
7141 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7142 `format_end'. Remove support for %l as a conversion specifier.
7143 Don't use xrealloc. Improve diagnostics when the %l size modifier
7144 is used. Update the commentary.
7146 * eval.c (verror): Simplify calculation of size_t.
7148 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7151 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7153 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7156 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7158 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7159 This makes this file independent of the recent pseudovector change.
7161 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7163 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7165 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7166 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7167 Remove unused local.
7168 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7170 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7171 GCC 4.6.0 optimizes based on type-based alias analysis.
7172 For example, if b is of type struct buffer * and v of type struct
7173 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7174 != &v->size, and therefore "v->size = 1; b->size = 2; return
7175 v->size;" must therefore return 1. This assumption is incorrect
7176 for Emacs, since it type-puns struct Lisp_Vector * with many other
7177 types. To fix this problem, this patch adds a new type struct
7178 vectorlike_header that documents the constraints on layout of vectors
7179 and pseudovectors, and helps optimizing compilers not get fooled
7180 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7181 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7182 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7184 (XSETPVECTYPE): Rewrite in terms of new macro.
7185 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7186 This is a bit clearer, and further avoids the possibility of
7187 undesirable aliasing.
7188 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7189 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7190 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7191 since Lisp_Subr is a special case (no "next" field).
7192 (ASIZE): Now uses header.size rather than size.
7193 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7194 to avoid the hassle of writing XVECTOR (foo)->header.size.
7195 (struct vectorlike_header): New type.
7196 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7197 object, to help avoid aliasing.
7198 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7199 (SUBRP): Likewise, since Lisp_Subr is a special case.
7200 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7201 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7202 (struct Lisp_Hash_Table): Combine first two members into a single
7203 struct vectorlike_header member. All uses of "size" and "next" members
7204 changed to be "header.size" and "header.next".
7205 * buffer.h (struct buffer): Likewise.
7206 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7207 * frame.h (struct frame): Likewise.
7208 * process.h (struct Lisp_Process): Likewise.
7209 * termhooks.h (struct terminal): Likewise.
7210 * window.c (struct save_window_data, struct saved_window): Likewise.
7211 * window.h (struct window): Likewise.
7212 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7213 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7214 * buffer.c (init_buffer_once): Likewise.
7215 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7217 * process.c (Fformat_network_address): Use local var for size,
7220 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7222 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7223 * data.c (atof): Remove decl; no longer used or needed.
7224 (digit_to_number): Move to lread.c.
7225 (Fstring_to_number): Use new string_to_number function, to be
7226 consistent with how the Lisp reader treats infinities and NaNs.
7227 Do not assume that floating-point numbers represent EMACS_INT
7228 without losing information; this is not true on most 64-bit hosts.
7229 Avoid double-rounding errors, by insisting on integers when
7230 parsing non-base-10 numbers, as the documentation specifies.
7231 * lisp.h (string_to_number): New decl, replacing ...
7232 (isfloat_string): Remove.
7233 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7234 (read1): Do not accept +. and -. as integers; this
7235 appears to have been a coding error. Similarly, do not accept
7236 strings like +-1e0 as floating point numbers. Do not report
7237 overflow for integer overflows unless the base is not 10 which
7238 means we have no simple and reliable way to continue.
7239 Break out the floating-point parsing into a new
7240 function string_to_number, so that Fstring_to_number parses
7241 floating point numbers consistently with the Lisp reader.
7242 (digit_to_number): Move here from data.c. Make it static inline.
7243 (E_CHAR, EXP_INT): Remove, replacing with ...
7244 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7245 (string_to_number): New function, replacing isfloat_string.
7246 This function checks for valid syntax and produces the resulting
7247 Lisp float number too. Rework it so that string-to-number
7248 no longer mishandles examples like "1.0e+". Use strtoumax,
7249 so that overflow for non-base-10 numbers is reported only when
7250 there's no portable and simple way to convert to floating point.
7252 * textprop.c (set_text_properties_1): Rewrite for clarity,
7253 and to avoid GCC warning about integer overflow.
7255 * intervals.h (struct interval): Use EMACS_INT for members
7256 where EMACS_UINT might cause problems. See
7257 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7258 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7259 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7261 (offset_intervals): Tell GCC not to worry about length overflow
7262 when negating a negative length.
7264 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7265 (overrun_check_free): Likewise.
7267 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7268 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7271 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7272 (gnutls_make_error): Rename local to avoid shadowing.
7273 (gnutls_emacs_global_deinit): ifdef out; not used.
7274 (Fgnutls_boot): Use const for pointer to readonly storage.
7275 Comment out unused local. Fix pointer signedness problems.
7277 * lread.c (openp): Don't stuff size_t into an 'int'.
7278 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7279 about possible signed overflow.
7281 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7282 (GDK_KEY_g): Don't define if already defined.
7283 (xg_prepare_tooltip): Avoid pointer signedness problem.
7284 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7286 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7287 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7289 * xfns.c (Fx_window_property): Simplify a bit,
7290 to make a bit faster and to avoid GCC 4.6.0 warning.
7291 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7293 * fns.c (internal_equal): Don't assume size_t fits in int.
7295 * alloc.c (compact_small_strings): Tighten assertion a little.
7297 Replace pEd with more-general pI, and fix some printf arg casts.
7298 * lisp.h (pI): New macro, generalizing old pEd macro to other
7299 conversion specifiers. For example, use "...%"pI"d..." rather
7300 than "...%"pEd"...".
7301 (pEd): Remove. All uses replaced with similar uses of pI.
7302 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7303 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7304 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7305 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7306 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7307 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7308 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7310 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7311 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7312 * print.c (safe_debug_print, print_object): Likewise.
7313 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7315 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7316 avoiding the 0 flag, which is not portable.
7317 * process.c (Fmake_network_process): Use pI to avoid cast.
7318 * region-cache.c (pp_cache): Likewise.
7319 * xdisp.c (decode_mode_spec): Likewise.
7320 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7321 behavior on 64-bit hosts with printf arg.
7322 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7323 (x_stop_queuing_selection_requests): Likewise.
7324 (x_get_window_property): Don't truncate byte count to an 'int'
7327 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7328 here, since it parses constructs like leading '-' and spaces,
7329 which are not wanted; and it overflows with large numbers.
7330 Instead, simply match F[0-9]+, which is what is wanted anyway.
7332 * alloc.c: Remove unportable assumptions about struct layout.
7333 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7334 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7335 (allocate_vectorlike, make_pure_vector): Use the new macros,
7336 plus offsetof, to remove unportable assumptions about struct layout.
7337 These assumptions hold on all porting targets that I know of, but
7338 they are not guaranteed, they're easy to remove, and removing them
7339 makes further changes easier.
7341 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7342 This doesn't fix a bug but makes the code clearer.
7343 (string_overrun_cookie): Now const. Use initializers that
7344 don't formally overflow signed char, to avoid warnings.
7345 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7346 can cause Emacs to crash when string overrun checking is enabled.
7347 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7348 multiple of sizeof (EMACS_INT); it need not be, if
7349 alignof(EMACS_INT) < sizeof (EMACS_INT).
7350 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7352 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7354 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7356 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7358 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7359 supposed to be handshaking. (Bug#8556)
7360 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7362 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7364 * lisp.h (Qdebug): List symbol.
7365 * eval.c (Qdebug): Restore global linkage.
7366 * keyboard.c (debug-on-event): New variable.
7367 (handle_user_signal): Break into debugger when debug-on-event
7368 matches the current signal symbol.
7370 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7372 * alloc.c (check_sblock, check_string_bytes)
7373 (check_string_free_list): Convert to standard C.
7375 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7377 * w32.c (emacs_gnutls_push): Fix typo.
7379 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7381 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7382 "cast to pointer from integer of different size".
7384 Improve doprnt and its use in verror. (Bug#8545)
7385 * doprnt.c (doprnt): Document the set of format control sequences
7386 supported by the function. Use SAFE_ALLOCA instead of always
7389 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7390 is one byte too soon. Don't use xrealloc; instead xfree and
7393 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7395 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7398 * gnutls.c: Renamed global_initialized to
7399 gnutls_global_initialized. Added internals for the
7400 :verify-hostname-error, :verify-error, and :verify-flags
7401 parameters of `gnutls-boot' and documented those parameters in the
7402 docstring. Start callback support.
7403 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7404 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7405 on error. Return error code.
7406 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7407 (emacs_gnutls_read): Likewise.
7408 (Fgnutls_boot): Return handshake error code.
7409 (emacs_gnutls_handle_error): New function.
7410 (wsaerror_to_errno): Likewise.
7412 * w32.h (emacs_gnutls_pull): Add prototype.
7413 (emacs_gnutls_push): Likewise.
7415 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7416 (emacs_gnutls_push): Likewise.
7418 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7420 * process.c (wait_reading_process_output): Check if GnuTLS
7421 buffered some data internally if no FDs are set for TLS
7424 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7425 (LIBS): Link to USER_LIBS.
7426 ($(BLD)/gnutls.$(0)): New target.
7428 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7430 * xdisp.c (handle_single_display_spec): Rename the
7431 display_replaced_before_p argument into display_replaced_p, to
7432 make it consistent with the commentary. Fix typos in the
7435 * textprop.c (syms_of_textprop): Remove dead code.
7436 (copy_text_properties): Delete obsolete commentary about an
7437 interface that was deleted long ago. Fix typos in the description
7440 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7441 to changes in oldXMenu/XMenu.h from 2011-04-16.
7442 <menu_help_message, prev_menu_help_message>: Constify.
7443 (IT_menu_make_room): menu->help_text is now `const char **';
7446 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7447 to changes in oldXMenu/XMenu.h from 2011-04-16.
7448 (struct XMenu): Declare `help_text' `const char **'.
7450 * xfaces.c <Qunspecified>: Make extern again.
7452 * syntax.c: Include sys/types.h before including regex.h, as
7455 * doc.c (get_doc_string): Improve the format passed to `error'.
7457 * doprnt.c (doprnt): Improve commentary.
7459 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7461 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7464 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7465 changes in globals.h immediately force recompilation.
7466 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7467 $(CURDIR)/s/ms-w32.h.
7468 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7470 * character.c (Fchar_direction): Function deleted.
7471 (syms_of_character): Don't defsubr it.
7472 <char-direction-table>: Deleted.
7474 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7476 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7477 * doprnt.c: Include limits.h.
7478 (SIZE_MAX): New macro.
7479 (doprnt): Return a size_t value. 2nd arg is now size_t.
7480 Many local variables are now size_t instead of int or unsigned.
7481 Improve overflow protection. Support `l' modifier for integer
7482 conversions. Support %l conversion. Don't assume an EMACS_INT
7483 argument for integer conversions and for %c.
7485 * lisp.h (doprnt): Restore prototype.
7487 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7490 * Makefile.in (base_obj): Add back doprnt.o.
7492 * deps.mk (doprnt.o): Add back prerequisites.
7493 (callint.o): Depend on character.h.
7495 * eval.c (internal_lisp_condition_case): Include the handler
7496 representation in the error message.
7497 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7498 when breaking from the loop.
7500 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7502 * callint.c (Fcall_interactively): When displaying error message
7503 about invalid control letter, pass the character's codepoint, not
7504 a pointer to its multibyte form. Improve display of the character
7505 in octal and display also its hex code.
7507 * character.c (char_string): Use %x to display the (unsigned)
7508 codepoint of an invalid character, to avoid displaying a bogus
7511 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7512 `error', not SYMBOL_NAME itself.
7514 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7515 character arguments to `error'.
7517 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7518 to `error' in error message about FINAL_CHAR argument. Make sure
7519 FINAL_CHAR is a character, and use %c when it is passed as
7520 argument to `error'.
7522 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7524 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7526 * w32.c: Include <time.h>.
7527 (sys_localtime): New function.
7529 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7531 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7533 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7535 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7537 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7540 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7542 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7543 gl_state.e_property when gl_state.object is Qt.
7545 * insdel.c (make_gap_larger): Remove limitation of buffer size
7548 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7550 * xdisp.c (lookup_glyphless_char_display)
7551 (produce_glyphless_glyph): Handle cons cell entry in
7552 glyphless-char-display.
7553 (Vglyphless_char_display): Document it.
7555 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7556 glyphless-char-display.
7558 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7560 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7562 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7564 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7565 definition for no-X builds.
7567 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7569 Static checks with GCC 4.6.0 and non-default toolkits.
7571 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7573 * process.c (keyboard_bit_set): Define only if SIGIO.
7574 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7575 (send_process): Repair possible setjmp clobbering.
7577 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7579 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7581 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7583 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7584 Define only if needed.
7586 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7587 by pacifying GCC about it. Maybe it's time to retire it?
7588 * xfaces.c (USG, __TIMEVAL__): Likewise.
7590 * dispextern.h (struct redisplay_interface): Rename param
7592 * termhooks.h (struct terminal): Likewise.
7593 * xterm.c (xembed_send_message): Likewise.
7595 * insdel.c (make_gap_smaller): Define only if
7596 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7598 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7601 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7602 so that we aren't warned about unused symbols.
7604 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7606 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7608 * xfns.c (x_real_positions): Mark locals as initialized.
7610 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7612 * xterm.c: Fix problems found by static analysis with other toolkits.
7613 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7614 (x_dispatch_event): Declare static if USE_GTK, and
7615 define if USE_GTK || USE_X_TOOLKIT.
7616 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7617 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7618 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7619 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7621 * xmenu.c (menu_help_callback): Pointer type fixes.
7622 Use const pointers when pointing at readonly data. Avoid pointer
7624 (FALSE): Remove unused macro.
7625 (update_frame_menubar): Remove unused decl.
7627 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7629 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7630 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7631 (single_menu_item): Rename local to avoid shadowing.
7633 * keyboard.c (make_lispy_event): Remove unused local var.
7635 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7636 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7638 * bitmaps: Change bitmaps from unsigned char back to the X11
7639 compatible char. Avoid the old compiler warnings about
7640 out-of-range initializers by using, for example, '\xab' rather
7643 * xgselect.c (xgselect_initialize): Check vs interface
7644 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7646 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7648 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7649 to read-only memory.
7651 * fns.c (vector): Remove; this old hack is no longer needed.
7653 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7655 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7657 * xrdb.c (x_load_resources): Omit unused local.
7659 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7660 (x_window): Rename locals to avoid shadowing.
7661 (USG): Use the kludged USG macro, to pacify gcc.
7663 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7664 (x_term_init): Remove local to avoid shadowing.
7666 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7668 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7669 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7671 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7673 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7675 Fix regex.c, syntax.c and friends for buffers > 2GB.
7676 * syntax.h (struct gl_state_s): Declare character position members
7679 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7681 * textprop.c (verify_interval_modification, interval_of):
7682 Declare arguments EMACS_INT.
7684 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7687 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7689 * indent.c (Fvertical_motion): Local variable it_start is now
7692 * regex.c (re_match, re_match_2, re_match_2_internal)
7693 (bcmp_translate, regcomp, regexec, print_double_string)
7694 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7695 (re_compile_pattern, re_exec): Declare arguments and local
7696 variables `size_t' and `ssize_t' and return values `regoff_t', as
7698 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7699 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7700 <compile_stack_type>: `size' and `avail' are now `size_t'.
7702 * regex.h <regoff_t>: Use ssize_t, not int.
7703 (re_search, re_search_2, re_match, re_match_2): Arguments that
7704 specify buffer/string position and length are now ssize_t and
7705 size_t. Return type is regoff_t.
7707 2011-04-16 Ben Key <bkey76@gmail.com>
7709 * nsfont.m: Fixed bugs in ns_get_family and
7710 ns_descriptor_to_entity that were caused by using free to
7711 deallocate memory blocks that were allocated by xmalloc (via
7712 xstrdup). This caused Emacs to crash when compiled with
7713 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7714 --enable-checking=xmallocoverrun). xfree is now used to
7715 deallocate these memory blocks.
7717 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7719 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7721 emacs_write: Accept and return EMACS_INT for sizes.
7722 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7724 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7725 Accept and return EMACS_INT.
7726 (emacs_gnutls_write): Return the number of bytes written on
7728 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7729 (emacs_read, emacs_write): Remove check for negative size, as the
7730 Emacs source code has been audited now.
7731 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7732 (emacs_read, emacs_write): Use it.
7733 * process.c (send_process): Adjust to the new signatures of
7734 emacs_write and emacs_gnutls_write. Do not attempt to store
7735 a byte offset into an 'int'; it might overflow.
7736 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7738 * sound.c: Don't assume sizes fit in 'int'.
7739 (struct sound_device.period_size, alsa_period_size):
7740 Return EMACS_INT, not int.
7741 (struct sound_device.write, vox_write, alsa_write):
7742 Accept EMACS_INT, not int.
7743 (wav_play, au_play): Use EMACS_INT to store sizes and to
7744 record read return values.
7746 2011-04-15 Ben Key <bkey76@gmail.com>
7748 * keyboard.c (Qundefined): Don't declare static since it is used
7750 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7751 static since they are used in nsfont.m.
7753 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7755 * process.c (Qprocessp): Don't declare static.
7756 * lisp.h (Qprocessp): Declare again.
7758 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7760 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7762 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7764 Improve C-level modularity by making more things 'static'.
7766 Don't publish debugger-only interfaces to other modules.
7767 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7768 (verify_bytepos, count_markers): Move decls to the only modules
7770 * region-cache.h (pp_cache): Likewise.
7771 * window.h (check_all_windows): Likewise.
7772 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7774 * sysdep.c (croak): Now static, if
7775 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7776 * syssignal.h (croak): Declare only if not static.
7778 * alloc.c (refill_memory_reserve): Now static if
7779 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7780 * lisp.h (refill_memory_reserve): Declare only if not static.
7782 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7783 Define only if USE_LUCID.
7785 * xrdb.c (x_customization_string, x_rm_string): Now static.
7787 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7788 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7790 * xdisp.c (draw_row_with_mouse_face): Now static.
7791 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7793 * window.h (check_all_windows): Mark externally visible.
7795 * window.c (window_deletion_count): Now static.
7797 * undo.c: Make symbols static if they're not exported.
7798 (last_undo_buffer, last_boundary_position, pending_boundary):
7801 * textprop.c (interval_insert_behind_hooks): Now static.
7802 (interval_insert_in_front_hooks): Likewise.
7804 * term.c: Make symbols static if they're not exported.
7805 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7806 (max_frame_lines, tty_set_terminal_modes):
7807 (tty_reset_terminal_modes, tty_turn_off_highlight):
7808 (get_tty_terminal): Now static.
7809 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7810 * termhooks.h (term_mouse_moveto): Do not declare if
7812 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7813 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7815 * sysdep.c: Make symbols static if they're not exported.
7816 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7818 (sigprocmask_set, full_mask): Remove; unused.
7819 (wait_debugging): Mark as visible.
7820 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7821 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7823 * syntax.c (syntax_temp): Define only if !__GNUC__.
7825 * sound.c (current_sound_device, current_sound): Now static.
7827 * search.c (searchbufs, searchbuf_head): Now static.
7829 * scroll.c (scroll_cost): Remove; unused.
7830 * dispextern.h (scroll_cost): Remove decl.
7832 * region-cache.h (pp_cache): Mark as externally visible.
7834 * process.c: Make symbols static if they're not exported.
7835 (process_tick, update_tick, create_process, chan_process):
7836 (Vprocess_alist, proc_buffered_char, datagram_access):
7837 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7838 (deactivate_process): Mark defn as static, as well as decl.
7839 * lisp.h (create_process): Remove decl.
7840 * process.h (chan_process, Vprocess_alist): Remove decls.
7842 * print.c: Make symbols static if they're not exported.
7843 (print_depth, new_backquote_output, being_printed, print_buffer):
7844 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7845 (print_interval, print_number_index, initial_stderr_stream):
7847 * lisp.h (Fprinc): Remove decl.
7848 (debug_output_compilation_hack): Mark as externally visible.
7850 * sysdep.c (croak): Move decl from here to syssignal.h.
7851 * syssignal.h (croak): Put it here, so the API can be checked when
7852 'croak' is called from dissociate_if_controlling_tty.
7854 * minibuf.c: Make symbols static if they're not exported.
7855 (minibuf_save_list, choose_minibuf_frame): Now static.
7856 * lisp.h (choose_minibuf_frame): Remove decl.
7858 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7860 * lread.c: Make symbols static if they're not exported.
7861 (read_objects, initial_obarray, oblookup_last_bucket_number):
7863 (make_symbol): Remove; unused.
7864 * lisp.h (initial_obarray, make_symbol): Remove decls.
7866 * keyboard.c: Make symbols static if they're not exported.
7867 (single_kboard, recent_keys_index, total_keys, recent_keys):
7868 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7869 (this_single_command_key_start, echoing, last_auto_save):
7870 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7871 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7872 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7873 (Vlispy_mouse_stem, double_click_count):
7875 (force_auto_save_soon): Define only if SIGDANGER.
7876 (ignore_mouse_drag_p): Now static if
7877 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7878 (print_help): Remove; unused.
7879 (stop_character, last_timer_event): Mark as externally visible.
7880 * keyboard.h (ignore_mouse_drag_p): Declare only if
7881 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7882 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7883 * lisp.h (echoing): Remove decl.
7884 (force_auto_save_soon): Declare only if SIGDANGER.
7885 * xdisp.c (redisplay_window): Simplify code, to make it more
7886 obvious that ignore_mouse_drag_p is not accessed if !defined
7887 USE_GTK && !defined HAVE_NS.
7889 * intervals.c: Make symbols static if they're not exported.
7890 (merge_properties_sticky, merge_interval_right, delete_interval):
7892 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7894 * insdel.c: Make symbols static if they're not exported.
7895 However, leave prepare_to_modify_buffer alone. It's never
7896 called from outside this function, but that appears to be a bug.
7897 (combine_after_change_list, combine_after_change_buffer):
7898 (adjust_after_replace, signal_before_change): Now static.
7899 (adjust_after_replace_noundo): Remove; unused.
7900 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7901 (signal_before_change): Remove decls.
7903 * indent.c (val_compute_motion, val_vmotion): Now static.
7905 * image.c: Make symbols static if they're not exported.
7906 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7908 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7909 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7911 * fringe.c (standard_bitmaps): Now static.
7912 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7914 * frame.c: Make symbols static if they're not exported.
7915 (x_report_frame_params, make_terminal_frame): Now static.
7916 (get_frame_param): Now static, unless HAVE_NS.
7917 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7918 (x_get_resource_string): Remove; not used.
7919 * frame.h (make_terminal_frame, x_report_frame_params):
7920 (x_get_resource_string); Remove decls.
7921 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7922 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7924 * font.c, fontset.c: Make symbols static if they're not exported.
7925 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7926 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7927 * font.c (font_close_object): Now static.
7928 * font.h (font_close_object): Remove.
7929 * fontset.c (FONTSET_OBJLIST): Remove.
7930 (free_realized_fontset) #if-0 the body, which does nothing.
7931 (face_suitable_for_char_p): #if-0, as it's never called.
7932 * fontset.h (face_suitable_for_char_p): Remove decl.
7933 * xfaces.c (face_at_string_position):
7934 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7935 since 0 is always ASCII.
7937 * fns.c (weak_hash_tables): Now static.
7939 * fileio.c: Make symbols static if they're not exported.
7940 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7941 (Vwrite_region_annotation_buffers): Now static.
7943 * eval.c: Make symbols static if they're not exported.
7944 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7945 * lisp.h (backtrace_list): Remove decl.
7947 * emacs.c: Make symbols static if they're not exported.
7948 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7949 (fatal_error_code, fatal_error_signal_hook, standard_args):
7951 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7952 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7953 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7954 * lisp.h (fatal_error_signal_hook): Remove decl.
7955 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7957 * editfns.c: Move a (normally-unused) function to its only use.
7958 * editfns.c, lisp.h (get_operating_system_release): Remove.
7959 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7960 worth the hassle of breaking this out.
7962 * xterm.c: Make symbols static if they're not exported.
7963 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7964 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7965 (x_destroy_window, x_delete_display):
7967 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7968 (x_mouse_leave): Remove; unused.
7969 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7970 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7971 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7973 (x_mouse_leave): Declare only if WINDOWSNT.
7974 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7975 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7978 * ftxfont.c: Make symbols static if they're not exported.
7979 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7981 * font.h (ftxfont_driver): Likewise.
7983 * xfns.c: Make symbols static if they're not exported.
7984 (x_last_font_name, x_display_info_for_name):
7985 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7986 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7987 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7988 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7989 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7990 (last_show_tip_args): Now static.
7991 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7992 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7993 (x_screen_planes): Remove; unused.
7994 * dispextern.h (x_screen_planes): Remove decl.
7996 * dispnew.c: Make symbols static if they're not exported.
7997 * dispextern.h (redraw_garbaged_frames, scrolling):
7998 (increment_row_positions): Remove.
7999 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8000 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8002 (redraw_garbaged_frames): Remove; unused.
8004 * xfaces.c: Make symbols static if they're not exported.
8005 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8007 * xterm.h (defined_color): Remove decls.
8008 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8009 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8010 (menu_face_changed_default, defined_color, free_realized_face):
8011 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8012 (ascii_face_of_lisp_face): Remove; unused.
8014 * xdisp.c: Make symbols static if they're not exported.
8015 * dispextern.h (scratch_glyph_row, window_box_edges):
8016 (glyph_to_pixel_coords, set_cursor_from_row):
8017 (get_next_display_element, set_iterator_to_next):
8018 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8019 (show_mouse_face): Remove decls
8020 * frame.h (message_buf_print): Likewise.
8021 * lisp.h (pop_message, set_message, check_point_in_composition):
8023 * xterm.h (set_vertical_scroll_bar): Likewise.
8024 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8025 (message_buf_print, scratch_glyph_row, displayed_buffer):
8026 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8027 (get_next_display_element, show_mouse_face, window_box_edges):
8028 (frame_to_window_pixel_xy, check_point_in_composition):
8029 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8030 (glyph_to_pixel_coords): Remove; unused.
8032 * dired.c (file_name_completion): Now static.
8034 * dbusbind.c (xd_in_read_queued_messages): Now static.
8036 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8037 * data.c (circular_list_error): Remove.
8039 * commands.h (last_point_position, last_point_position_buffer):
8040 (last_point_position_window): Remove decls.
8041 * keyboard.c: Make these variables static.
8043 * coding.h (coding, code_convert_region, encode_coding_gap):
8045 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8046 (iso_code_class, detect_coding, code_convert_region): Now static.
8047 (encode_coding_gap): Remove; unused.
8049 * chartab.c (chartab_chars, chartab_bits): Now static.
8051 * charset.h (charset_iso_8859_1): Remove decl.
8052 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8055 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8056 * ccl.c (Vccl_program_table): Now static.
8057 (check_ccl_update): Remove; unused.
8059 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8060 * category.h: ... from here.
8061 * category.c (check_category_table, set_category_set): Now static.
8063 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8064 * lisp.h: Remove these decls.
8066 * buffer.c (buffer_count): Remove unused var.
8068 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8069 so that it's not optimized away.
8070 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8071 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8072 exported only to the debugger.
8074 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8075 * atimer.h (run_all_atimers): Remove; not exported.
8077 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8078 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8079 was inaccessible from Lisp.
8080 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8081 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8083 alloc.c: Import and export fewer symbols, and remove unused items.
8084 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8086 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8087 it's not optimized away by whole-program optimization.
8088 (message_enable_multibyte, free_misc): Remove.
8089 (catchlist, handlerlist, mark_backtrace):
8090 Declare only if BYTE_MARK_STACK.
8091 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8092 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8093 (message_enable_multibyte): Remove decl.
8094 (free_misc, interval_free_list, float_block, float_block_index):
8095 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8096 (cons_free_list, last_marked_index):
8098 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8099 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8100 (mark_backtrace): Define only if BYTE_MARK_STACK.
8101 * xdisp.c (message_enable_multibyte): Now static.
8103 Declare Lisp_Object Q* variables to be 'static' if not exported.
8104 This makes it easier for human readers (and static analyzers)
8105 to see whether these variables are used from other modules.
8106 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8107 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8108 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8109 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8110 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8111 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8112 * xmenu.c, xselect.c:
8113 Declare Q* vars static if they are not used in other modules.
8114 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8115 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8116 Remove decls of unexported vars.
8117 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8119 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8121 Make Emacs functions such as Fatom 'static' by default.
8122 This makes it easier for human readers (and static analyzers)
8123 to see whether these functions can be called from other modules.
8124 DEFUN now defines a static function. To make the function external
8125 so that it can be used in other C modules, use the new macro DEFUE.
8126 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8127 (Finit_image_library):
8128 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8129 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8130 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8131 Remove decls, since these functions are now static.
8132 (Funintern, Fget_internal_run_time): New decls, since these functions
8133 were already external.
8135 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8136 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8137 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8138 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8139 * keyboard.c, keymap.c, lread.c:
8140 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8141 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8142 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8143 Mark functions with DEFUE instead of DEFUN,
8144 if they are used in other modules.
8145 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8146 decls for now-static functions.
8147 * buffer.h (Fdelete_overlay): Remove decl.
8148 * callproc.c (Fgetenv_internal): Mark as internal.
8149 * composite.c (Fremove_list_of_text_properties): Remove decl.
8150 (Fcomposition_get_gstring): New forward static decl.
8151 * composite.h (Fcomposite_get_gstring): Remove decl.
8152 * dired.c (Ffile_attributes): New forward static decl.
8153 * doc.c (Fdocumntation_property): New forward static decl.
8154 * eval.c (Ffetch_bytecode): New forward static decl.
8155 (Funintern): Remove extern decl; now in .h file where it belongs.
8156 * fileio.c (Fmake_symbolic_link): New forward static decl.
8157 * image.c (Finit_image_library): New forward static decl.
8158 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8159 * intervals.h (Fprevious_property_change):
8160 (Fremove_list_of_text_properties): Remove decls.
8161 * keyboard.c (Fthis_command_keys): Remove decl.
8162 (Fcommand_execute): New forward static decl.
8163 * keymap.c (Flookup_key): New forward static decl.
8164 (Fcopy_keymap): Now static.
8165 * keymap.h (Flookup_key): Remove decl.
8166 * process.c (Fget_process): New forward static decl.
8167 (Fprocess_datagram_address): Mark as internal.
8168 * syntax.c (Fsyntax_table_p): New forward static decl.
8169 (skip_chars): Remove duplicate decl.
8170 * textprop.c (Fprevious_property_change): New forward static decl.
8171 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8173 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8174 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8176 * editfns.c (Fformat): Remove unreachable code.
8178 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8180 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8183 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8185 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8186 when at ZV. (Bug#8487)
8188 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8190 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8192 * keyboard.c (parse_tool_bar_item): Likewise.
8193 * sound.c (sound_cleanup, alsa_close): Likewise.
8194 * termcap.c (tgetent): Likewise.
8195 * xfns.c (x_default_font_parameter): Likewise.
8196 * xsettings.c (read_and_apply_settings): Likewise.
8198 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8199 (overrun_check_free): Protoize.
8201 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8203 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8204 since callers should never pass a negative size.
8205 Change the signature to match that of plain 'read' and 'write'; see
8206 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8207 * lisp.h: Update prototypes of emacs_write and emacs_read.
8209 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8211 * xdisp.c (redisplay_window): Don't try to determine the character
8212 position of the scroll margin if the window start point w->startp
8213 is outside the buffer's accessible region. (Bug#8468)
8215 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8217 Fix write-region and its subroutines for buffers > 2GB.
8218 * fileio.c (a_write, e_write): Modify declaration of arguments and
8219 local variables to support buffers larger than 2GB.
8220 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8222 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8223 argument, local variables, and return value.
8225 * lisp.h: Update prototypes of emacs_write and emacs_read.
8227 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8229 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8231 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8233 Fix more problems found by GCC 4.6.0's static checks.
8235 * xdisp.c (vmessage): Use a better test for character truncation.
8237 * charset.c (load_charset_map): <, not <=, for optimization,
8238 and to avoid potential problems with integer overflow.
8239 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8240 * casetab.c (set_identity, shuffle): Likewise.
8241 * editfns.c (Fformat): Likewise.
8242 * syntax.c (skip_chars): Likewise.
8244 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8245 This also lets GCC 4.6.0 generate slightly better loop code.
8247 * callint.c (Fcall_interactively): <, not <=, for optimization.
8248 (Fcall_interactively): Count the number of arguments produced,
8249 not the number of arguments given. This is simpler and lets GCC
8250 4.6.0 generate slightly better code.
8252 * ftfont.c: Distingish more carefully between FcChar8 and char.
8253 The previous code passed unsigned char * to a functions like
8254 strlen and xstrcasecmp that expect char *, which does not
8255 conform to the C standard.
8256 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8257 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8258 char * when the C standard requires it.
8260 * keyboard.c (read_char): Remove unused var.
8262 * eval.c: Port to Windows vsnprintf (Bug#8435).
8264 (SIZE_MAX): Define if the headers do not.
8265 (verror): Do not give up if vsnprintf returns a negative count.
8266 Instead, grow the buffer. This ports to Windows vsnprintf, which
8267 does not conform to C99. Problem reported by Eli Zaretskii.
8268 Also, simplify the allocation scheme, by avoiding the need for
8269 calling realloc, and removing the ALLOCATED variable.
8271 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8273 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8274 But keep the doprint source code for now, as we might revamp it
8275 and use it again (Bug#8435).
8276 * lisp.h (doprnt): Remove.
8277 * Makefile.in (base_obj): Remove doprnt.o.
8278 * deps.mk (doprnt.o): Remove.
8280 error: Print 32- and 64-bit integers portably (Bug#8435).
8281 Without this change, on typical 64-bit hosts error ("...%d...", N)
8282 was used to print both 32- and 64-bit integers N, which relied on
8284 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8285 * lisp.h (error, verror): Mark as printf-like functions.
8286 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8287 Report overflow in size calculations when allocating printf buffer.
8288 Do not truncate output string at its first null byte.
8289 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8290 Truncate the output at a character boundary, since vsnprintf does not
8292 * charset.c (check_iso_charset_parameter): Convert internal
8293 character to string before calling 'error', since %c now has the
8295 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8296 overflow when computing char to be passed to 'error'. Do not
8297 pass Lisp_Object to 'error'; pass the integer instead.
8298 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8299 formatted with plain %d.
8301 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8303 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8305 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8307 * xterm.c (x_catch_errors): Remove duplicate declaration.
8309 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8311 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8313 2011-04-10 Jim Meyering <meyering@redhat.com>
8315 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8316 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8317 return ssize_t not "int", and use size_t as the buffer length.
8318 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8319 * gnutls.h: Update declarations.
8320 * process.c (read_process_output): Use ssize_t, to match.
8321 (send_process): Likewise.
8323 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8325 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8327 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8329 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8330 Use unsigned char, to match FcChar8 type definition.
8332 * xterm.c (handle_one_xevent):
8333 * xmenu.c (create_and_show_popup_menu):
8334 * xselect.c (x_decline_selection_request)
8335 (x_reply_selection_request): Avoid type-punned deref of X events.
8337 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8339 Fix some uses of `int' instead of EMACS_INT.
8340 * search.c (string_match_1, fast_string_match)
8341 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8342 (scan_buffer, find_next_newline_no_quit)
8343 (find_before_next_newline, search_command, Freplace_match)
8344 (Fmatch_data): Make some `int' variables be EMACS_INT.
8346 * xdisp.c (display_count_lines): 3rd argument and return value now
8347 EMACS_INT. All callers changed.
8348 (pint2hrstr): Last argument is now EMACS_INT.
8350 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8351 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8352 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8353 (decode_coding_utf_16, decode_coding_emacs_mule)
8354 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8355 (decode_coding_ccl, decode_coding_charset)
8356 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8357 (decode_coding_iso_2022, decode_coding_emacs_mule)
8358 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8359 <char_offset, last_offset>: Declare EMACS_INT.
8360 (encode_coding_utf_8, encode_coding_utf_16)
8361 (encode_coding_emacs_mule, encode_invocation_designation)
8362 (encode_designation_at_bol, encode_coding_iso_2022)
8363 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8364 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8366 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8367 (encode_invocation_designation): Last argument P_NCHARS is now
8369 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8370 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8372 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8375 * ccl.c (Fccl_execute_on_string): Declare some variables
8378 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8380 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8382 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8384 * process.c (Fformat_network_address): Doc fix.
8386 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8388 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8390 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8392 * keyboard.c (read_char): Call Lisp function help-form-show,
8393 instead of using internal_with_output_to_temp_buffer.
8394 (Qhelp_form_show): New var.
8395 (syms_of_keyboard): Use DEFSYM macro.
8397 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8399 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8401 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8403 * process.c (Flist_processes): Remove to Lisp.
8404 (list_processes_1): Delete.
8406 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8408 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8410 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8412 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8414 Fix more problems found by GCC 4.6.0's static checks.
8416 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8418 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8420 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8422 * xdisp.c (vmessage): Mark as a printf-like function.
8424 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8426 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8428 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8429 printf-like functions.
8430 (tiff_load): Add casts to remove these marks before passing them
8431 to system-supplied API.
8433 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8435 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8436 This avoids several warnings with gcc -Wstrict-overflow.
8437 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8438 directly, rather than having caller test rule sign. This avoids
8439 some unnecessary tests.
8440 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8441 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8442 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8444 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8445 (xfont_open): Avoid unnecessary tests.
8447 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8449 * composite.h, composite.c (composition_gstring_put_cache):
8450 Use EMACS_INT, not int, for length.
8452 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8453 breaking out part of COMPOSITION_DECODE_RULE.
8454 (COMPOSITION_DECODE_RULE): Use it.
8455 * composite.c (get_composition_id): Remove unused local vars,
8456 by using the new macro.
8458 * textprop.c (set_text_properties_1): Change while to do-while,
8459 since the condition is always true at first.
8461 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8462 (interval_deletion_adjustment): Return unsigned value.
8465 * process.c (list_processes_1, create_pty, read_process_output):
8466 (exec_sentinel): Remove vars that were set but not used.
8467 (create_pty): Remove unnecessary "volatile"s.
8468 (Fnetwork_interface_info): Avoid possibility of int overflow.
8469 (read_process_output): Do adaptive read buffering even if carryover.
8470 (read_process_output): Simplify nbytes computation if buffered.
8472 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8474 * syntax.c (scan_words): Remove var that was set but not used.
8475 (update_syntax_table): Use unsigned instead of int.
8477 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8478 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8479 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8481 * print.c (print_error_message): Avoid int overflow.
8483 * font.c (font_list_entities): Redo for clarity,
8484 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8486 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8487 (font_score): Avoid potential overflow in diff calculation.
8489 * fns.c (substring_both): Remove var that is set but not used.
8490 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8492 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8494 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8495 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8496 can always succeed if overflow has undefined behavior.
8498 * search.c (boyer_moore, wordify): Remove vars set but not used.
8499 (wordify): Omit three unnecessary tests.
8501 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8502 All callers changed. This avoids the need for an unused var.
8504 * casefiddle.c (casify_region): Remove var that is set but not used.
8506 * dired.c (file_name_completion): Remove var that is set but not used.
8508 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8510 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8511 (Finsert_file_contents): Remove unnecessary code checking fd.
8513 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8514 Check for integer overflow on size calculations.
8516 * buffer.c (Fprevious_overlay_change): Remove var that is set
8519 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8520 Remove vars that are set but not used.
8521 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8522 (timer_check_2): Mark vars as initialized.
8524 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8526 * image.c (lookup_image): Remove var that is set but not used.
8527 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8529 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8530 that are set but not used.
8532 * xfns.c (make_invisible_cursor): Don't return garbage
8533 if XCreateBitmapFromData fails (Bug#8410).
8535 * xselect.c (x_get_local_selection, x_handle_property_notify):
8536 Remove vars that are set but not used.
8538 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8539 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8541 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8542 Remove var that is set but not used.
8543 (scroll_bar_windows_size): Now size_t, not int.
8544 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8547 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8548 (map_tty_color) [!defined MSDOS]: Likewise.
8550 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8552 * coding.c: Remove vars that are set but not used.
8553 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8554 All callers changed.
8555 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8556 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8557 (decode_coding_charset): Remove vars that are set but not used.
8559 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8560 that is set but not used.
8562 * print.c (print_object): Remove var that is set but not used.
8564 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8565 The gnulib version avoids calling malloc in the usual case,
8566 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8567 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8568 * filelock.c (current_lock_owner): Likewise.
8569 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8570 * sysdep.c: Include allocator.h, careadlinkat.h.
8571 (emacs_no_realloc_allocator): New static constant.
8572 (emacs_readlink): New function.
8573 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8574 ../lib/careadlinkat.h.
8576 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8578 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8579 first non-nil return value).
8581 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8583 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8584 if not defined (Bug#8403).
8586 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8588 * xdisp.c (display_count_lines): Remove parameter `start',
8589 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8590 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8591 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8592 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8593 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8594 and thereabouts. All callers changed.
8595 (get_per_char_metric): Remove parameter `f', unused since
8596 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8598 2011-04-02 Jim Meyering <meyering@redhat.com>
8600 do not dereference NULL upon failed strdup
8601 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8602 (ns_get_family): Likewise.
8604 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8606 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8608 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8610 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8613 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8615 Add lexical binding.
8617 * window.c (Ftemp_output_buffer_show): New fun.
8618 (Fsave_window_excursion):
8619 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8621 * lread.c (lisp_file_lexically_bound_p): New function.
8622 (Fload): Bind Qlexical_binding.
8623 (readevalloop): Remove `evalfun' arg.
8624 Bind Qinternal_interpreter_environment.
8625 (Feval_buffer): Bind Qlexical_binding.
8626 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8628 (syms_of_lread): Declare `lexical-binding'.
8630 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8632 * keyboard.c (eval_dyn): New fun.
8633 (menu_item_eval_property): Use it.
8635 * image.c (parse_image_spec): Use Ffunctionp.
8637 * fns.c (concat, mapcar1): Accept byte-code-functions.
8639 * eval.c (Fsetq): Handle lexical vars.
8640 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8641 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8642 (FletX, Flet): Obey lexical binding.
8643 (Fcommandp): Handle closures.
8644 (Feval): New `lexical' arg.
8645 (eval_sub): New function extracted from Feval. Use it almost
8646 everywhere where Feval was used. Look up vars in lexical env.
8648 (Ffunctionp): Move from subr.el.
8649 (Ffuncall): Handle closures.
8650 (apply_lambda): Remove `eval_flags'.
8651 (funcall_lambda): Handle closures and new byte-code-functions.
8652 (Fspecial_variable_p): New function.
8653 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8654 but without exporting it to Lisp.
8656 * doc.c (Fdocumentation, store_function_docstring):
8657 * data.c (Finteractive_form): Handle closures.
8659 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8662 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8664 (exec_byte_code): New function extracted from Fbyte_code to handle new
8665 calling convention for byte-code-functions. Add new byte-codes.
8667 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8669 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8671 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8673 * xdisp.c (redisplay_internal): Fix prototype.
8675 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8677 * xdisp.c (SCROLL_LIMIT): New macro.
8678 (try_scrolling): Use it when setting scroll_limit.
8679 Limit scrolling to 100 screen lines.
8680 (redisplay_window): Even when falling back on "recentering",
8681 position point in the window according to scroll-conservatively,
8682 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8684 (try_scrolling): When point is above the window, allow searching
8685 as far as scroll_max, or one screenful, to compute vertical
8686 distance from PT to the scroll margin position. This prevents
8687 try_scrolling from unnecessarily failing when
8688 scroll-conservatively is set to a value slightly larger than the
8689 window height. Clean up the case of PT below the margin at bottom
8690 of window: scroll_max can no longer be INT_MAX. When aggressive
8691 scrolling is in use, don't let point enter the opposite scroll
8692 margin as result of the scroll.
8693 (syms_of_xdisp) <scroll-conservatively>: Document the
8694 threshold of 100 lines for never-recentering scrolling.
8696 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8698 * dispextern.h (move_it_by_lines):
8699 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8700 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8701 (message_log_check_duplicate): Remove parameters `prev_bol' and
8702 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8703 (redisplay_internal): Remove parameter `preserve_echo_area',
8704 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8706 * indent.c (Fvertical_motion):
8707 * window.c (window_scroll_pixel_based, Frecenter):
8708 Don't pass `need_y_p' to `move_it_by_lines'.
8710 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8712 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8713 steal a few bits to be more compact.
8714 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8715 Remove unneeded casts.
8717 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8719 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8721 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8722 binding" message (bug#7967).
8724 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8726 Fix more problems found by GCC 4.6.0's static checks.
8728 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8729 Remove unused local var.
8731 * editfns.c (Fmessage_box): Remove unused local var.
8733 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8734 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8735 Omit unused local vars.
8736 * window.c (shrink_windows): Omit unused local var.
8737 * menu.c (digest_single_submenu): Omit unused local var.
8738 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8739 Omit unused local var.
8741 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8742 Don't assume string length fits in int.
8743 (keyremap_step, read_key_sequence): Use size_t for sizes.
8744 (read_key_sequence): Don't check last_real_key_start redundantly.
8746 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8747 instead of alloca (Bug#8344).
8749 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8750 (Fbacktrace_frame): Don't assume nframes fits in int.
8752 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8754 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8757 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8759 * cm.c (calccost): Turn while-do into do-while, for clarity.
8761 * keyboard.c (syms_of_keyboard): Use the same style as later
8762 in this function when indexing through an array. This also
8763 works around GCC bug 48267.
8765 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8767 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8769 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8770 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8772 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8773 This avoids undefined behavior on integer overflow, and is a bit
8774 more convenient anyway since it is compared to a size_t variable.
8776 Variadic C functions now count arguments with size_t, not int.
8777 This avoids an unnecessary limitation on 64-bit machines, which
8778 caused (substring ...) to crash on large vectors (Bug#8344).
8779 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8780 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8781 All variadic functions and their callers changed accordingly.
8782 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8783 * data.c (arith_driver, float_arith_driver): Likewise.
8784 * editfns.c (general_insert_function): Likewise.
8785 * eval.c (struct backtrace.nargs, interactive_p)
8786 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8787 (funcall_lambda, mark_backtrace): Likewise.
8788 * fns.c (concat): Likewise.
8789 * frame.c (x_set_frame_parameters): Likewise.
8790 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8791 0 if not found, not -1. All callers changed.
8793 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8794 (stack_copy_size): Now size_t, not int.
8795 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8797 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8799 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8800 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8801 All callers changed.
8803 * lisp.h (multibyte_char_to_unibyte):
8804 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8805 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8806 * character.h (CHAR_TO_BYTE8):
8807 * cmds.c (internal_self_insert):
8808 * editfns.c (general_insert_function):
8809 * keymap.c (push_key_description):
8810 * search.c (Freplace_match):
8811 * xdisp.c (message_dolog, set_message_1): All callers changed.
8813 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8815 * keyboard.c (safe_run_hook_funcall): New function.
8816 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8817 don't set the hook to nil, but remove the offending function instead.
8818 (Qcommand_hook_internal): Remove, unused.
8819 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8820 Vcommand_hook_internal.
8822 * eval.c (enum run_hooks_condition): Remove.
8823 (funcall_nil, funcall_not): New functions.
8824 (run_hook_with_args): Call each function through a `funcall' argument.
8825 Remove `cond' argument, now redundant.
8826 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8827 (Frun_hook_with_args_until_failure): Adjust accordingly.
8828 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8830 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8832 * dispextern.h (string_buffer_position): Remove declaration.
8834 * print.c (strout): Remove parameter `multibyte', unused since
8835 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8837 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8838 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8839 All callers changed.
8841 * w32.c (_wsa_errlist): Use braces for struct initializers.
8843 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8844 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8845 All callers changed.
8846 (string_buffer_position): Likewise. Also, make static (it's never
8847 used outside xdisp.c).
8848 (cursor_row_p): Remove parameter `w', unused since
8849 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8850 (decode_mode_spec): Remove parameter `precision', introduced during
8851 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8852 All callers changed.
8854 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8856 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8858 2011-03-27 Anders Lindgren <andlind@gmail.com>
8860 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8861 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8862 (ns_update_auto_hide_menu_bar): New functions.
8863 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8864 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8865 ns_constrain_all_frames.
8866 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8867 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8869 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8871 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8873 2011-03-27 Glenn Morris <rgm@gnu.org>
8875 * syssignal.h: Replace RETSIGTYPE with void.
8876 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8877 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8878 Replace SIGTYPE with void everywhere.
8879 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8880 * s/template.h (SIGTYPE): Remove commented out definition.
8882 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8884 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8885 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8887 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8889 * w32.c (read_unc_volume): Use parameter `henum', instead of
8890 global variable `wget_enum_handle'.
8892 * keymap.c (describe_vector): Remove parameters `indices' and
8893 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8894 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8896 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8898 * keyboard.c (timer_check): Remove parameter `do_it_now',
8899 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8900 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8901 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8903 * keyboard.c (read_char):
8904 * w32menu.c (w32_menu_display_help):
8905 * xmenu.c (show_help_event, menu_help_callback):
8906 Adjust calls to `show_help_echo'.
8908 * gtkutil.c (xg_maybe_add_timer):
8909 * keyboard.c (readable_events):
8910 * process.c (wait_reading_process_output):
8911 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8913 * insdel.c (adjust_markers_gap_motion):
8914 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8915 (gap_left, gap_right): Don't call it.
8917 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8919 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8920 incurred during fontification.
8922 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8924 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8925 (DEFVAR_PER_BUFFER): Don't pass it.
8927 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8928 (scrolling_window): Don't pass it.
8930 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8932 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8934 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8936 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8937 of variables specific to SELinux and computation of `encoded_absname'.
8939 * image.c (XPutPixel): Remove unused variable `height'.
8941 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8943 * unexw32.c (get_section_info): Remove unused variable `section'.
8945 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8946 (system_process_attributes): Remove unused variable `sess'.
8947 (sys_read): Remove unused variable `err'.
8949 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8950 (w32_wnd_proc): Remove unused variable `isdead'.
8951 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8952 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8953 (x_create_tip_frame): Remove unused variable `tem'.
8955 * w32inevt.c (w32_console_read_socket):
8956 Remove unused variable `no_events'.
8958 * w32term.c (x_draw_composite_glyph_string_foreground):
8959 Remove unused variable `width'.
8961 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8963 * w32term.c (x_set_glyph_string_clipping):
8964 Don't pass uninitialized region to CombineRgn.
8966 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8968 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8969 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8970 (Fx_close_connection): Remove unused variable `i'.
8972 * w32font.c (w32font_draw): Return number of glyphs.
8973 (w32font_open_internal): Remove unused variable `i'.
8974 (w32font_driver): Add missing initializer.
8976 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8977 (fill_in_menu): Remove unused variable `items_added'.
8979 * w32term.c (last_mouse_press_frame): Remove static global variable.
8980 (w32_clip_to_row): Remove unused variable `f'.
8981 (x_delete_terminal): Remove unused variable `i'.
8983 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8984 (NOTHING): Remove unused static global variable.
8985 (uniscribe_check_otf): Remove unused variable `table'.
8986 (uniscribe_font_driver): Add missing initializers.
8988 2011-03-23 Julien Danjou <julien@danjou.info>
8990 * term.c (Fsuspend_tty, Fresume_tty):
8991 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8992 * window.c (temp_output_buffer_show):
8993 * insdel.c (signal_before_change):
8994 * frame.c (Fhandle_switch_frame):
8995 * fileio.c (Fdo_auto_save):
8996 * emacs.c (Fkill_emacs):
8997 * editfns.c (save_excursion_restore):
8998 * cmds.c (internal_self_insert):
8999 * callint.c (Fcall_interactively):
9000 * buffer.c (Fkill_all_local_variables):
9001 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9003 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9004 unconditionally since it does the check itself.
9006 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9008 Fix more problems found by GCC 4.5.2's static checks.
9010 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9011 the first time through the loop, since we know p0 < p1 then.
9012 This also avoids a gcc -Wstrict-overflow warning.
9014 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9015 leading to a memory leak, possible in functions like
9016 load_charset_map_from_file that can allocate an unbounded number
9017 of objects (Bug#8318).
9019 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9020 that could (at least in theory) be that large.
9022 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9023 This is less likely to overflow, and avoids undefined behavior if
9024 overflow does occur. All callers changed. Use strtoul to scan
9025 for the unsigned long integer.
9026 (pint2hrstr): Simplify and tune code slightly.
9027 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9029 * scroll.c (do_scrolling): Work around GCC bug 48228.
9030 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9032 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9033 This also avoids a warning with gcc -Wstrict-overflow.
9034 (validate_x_resource_name): Simplify count usage.
9035 This also avoids a warning with gcc -Wstrict-overflow.
9037 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9040 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9042 * process.c (Fmake_network_process): Use socklen_t, not int,
9043 where POSIX says socklen_t is required in portable programs.
9044 This fixes a porting bug on hosts like 64-bit HP-UX, where
9045 socklen_t is wider than int (Bug#8277).
9046 (Fmake_network_process, server_accept_connection):
9047 (wait_reading_process_output, read_process_output):
9050 * process.c: Rename or move locals to avoid shadowing.
9051 (list_processes_1, Fmake_network_process):
9052 (read_process_output_error_handler, exec_sentinel_error_handler):
9053 Rename or move locals.
9054 (Fmake_network_process): Define label "retry_connect" only if needed.
9055 (Fnetwork_interface_info): Fix pointer signedness.
9056 (process_send_signal): Add cast to avoid pointer signedness problem.
9057 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9058 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9060 Make tparam.h and terminfo.c consistent.
9061 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9062 Include tparam.h instead, since it declares them.
9063 * cm.h (PC): Remove extern decl; tparam.h now does this.
9064 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9065 * terminfo.c: Include tparam.h, to check interfaces.
9066 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9067 (tparam): Adjust signature to match interface in tparam.h;
9068 this removes some undefined behavior. Check that outstring and len
9069 are zero, which they always are with Emacs.
9070 * tparam.h (PC, BC, UP): New extern decls.
9072 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9073 (xftfont_open): Rename locals to avoid shadowing.
9075 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9076 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9077 (OTF_TAG_SYM): Omit macro if not needed.
9078 (ftfont_list): Remove unused local.
9079 (get_adstyle_property, ftfont_pattern_entity):
9080 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9081 Rename locals to avoid shadowing.
9083 * xfont.c (xfont_list_family): Mark var as initialized.
9085 * xml.c (make_dom): Now static.
9087 * composite.c (composition_compute_stop_pos): Rename local to
9089 (composition_reseat_it): Remove unused locals.
9090 (find_automatic_composition, composition_adjust_point): Likewise.
9091 (composition_update_it): Mark var as initialized.
9092 (find_automatic_composition): Mark vars as initialized,
9093 with a FIXME (Bug#8290).
9095 character.h: Rename locals to avoid shadowing.
9096 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9097 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9098 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9099 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9102 * textprop.c (property_change_between_p): Remove; unused.
9104 * intervals.c (interval_start_pos): Now static.
9106 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9108 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9109 Rename locals to avoid shadowing.
9111 * sound.c (wav_play, au_play, Fplay_sound_internal):
9112 Fix pointer signedness.
9113 (alsa_choose_format): Remove unused local var.
9114 (wav_play): Initialize a variable to 0, to prevent undefined
9115 behavior (Bug#8278).
9117 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9119 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9121 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9122 clobbering (Bug#8298).
9123 * sysdep.c (sys_subshell): Likewise.
9124 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9126 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9127 This should get cleaned up, so that child_setup has the
9128 same signature on all platforms.
9130 * callproc.c (call_process_cleanup): Now static.
9131 (relocate_fd): Rename locals to avoid shadowing.
9133 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9135 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9136 not to be necessary, and produces flickering.
9138 2011-03-20 Glenn Morris <rgm@gnu.org>
9140 * config.in: Remove file.
9142 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9144 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9145 are now in src/globals.h.
9146 (syms_of_minibuf): Remove spurious & from previous change.
9148 2011-03-20 Leo Liu <sdl.web@gmail.com>
9150 * minibuf.c (completing-read-function): New variable.
9151 (completing-read-default): Rename from completing-read.
9152 (completing-read): Call completing-read-function.
9154 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9156 * xfaces.c (Fx_load_color_file):
9157 Read color file from absolute filename (bug#8250).
9159 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9161 * makefile.w32-in: Update dependencies.
9163 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9165 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9167 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9169 Fix more problems found by GCC 4.5.2's static checks.
9171 * process.c (make_serial_process_unwind, send_process_trap):
9172 (sigchld_handler): Now static.
9174 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9175 That way, the code declares only the vars that it needs.
9176 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9177 * s/cygwin.h (PTY_ITERATION): Likewise.
9178 * s/darwin.h (PTY_ITERATION): Likewise.
9179 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9181 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9182 * process.c (allocate_pty): Don't declare stb unless it's needed.
9184 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9185 (CONSTANTLIM): Remove; unused.
9186 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9187 Define only if needed.
9189 * unexelf.c (unexec): Name an expression,
9190 to avoid gcc -Wbad-function-cast warning.
9191 Use a different way to cause a compilation error if anyone uses
9192 n rather than nn, a way that does not involve shadowing.
9193 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9195 * deps.mk (unexalpha.o): Remove; unused.
9197 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9198 * unexec.h: New file.
9199 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9200 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9202 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9203 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9204 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9205 Change as necessary to match prototype in unexec.h.
9207 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9209 (back_comment, skip_chars): Mark vars as initialized.
9211 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9212 Rename locals to avoid shadowing.
9214 * lread.c (read1): Rewrite so as not to use empty "else".
9215 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9217 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9219 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9220 warning when compiling print.c.
9222 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9223 instead of using an uninitialized var.
9224 (font_sort_entities): Mark var as initialized.
9226 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9228 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9229 pointers to constants.
9230 (font_parse_fcname): Remove unused vars.
9231 (font_delete_unmatched): Now static.
9232 (font_get_spec): Remove; unused.
9233 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9234 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9235 Rename or move locals to avoid shadowing.
9237 * fns.c (require_nesting_list, require_unwind): Now static.
9238 (Ffillarray): Rename locals to avoid shadowing.
9240 * floatfns.c (domain_error2): Define only if needed.
9241 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9243 * alloc.c (mark_backtrace): Move decl from here ...
9244 * lisp.h: ... to here, so that it can be checked.
9246 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9247 (Fdefvar): Rewrite so as not to use empty "else".
9248 (lisp_indirect_variable): Name an expression,
9249 to avoid gcc -Wbad-function-cast warning.
9250 (Fdefvar): Rename locals to avoid shadowing.
9252 * callint.c (quotify_arg, quotify_args): Now static.
9253 (Fcall_interactively): Rename locals to avoid shadowing.
9254 Use const pointer when appropriate.
9256 * lisp.h (get_system_name, get_operating_system_release):
9257 Move decls here, to check interfaces.
9258 * process.c (get_operating_system_release): Move decl to lisp.h.
9259 * xrdb.c (get_system_name): Likewise.
9260 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9261 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9262 some of which prompt warnings from gcc -Wbad-function-cast.
9263 (Fformat_time_string, Fencode_time, Finsert_char):
9264 (Ftranslate_region_internal, Fformat):
9265 Rename or remove local vars to avoid shadowing.
9266 (Ftranslate_region_internal): Mark var as initialized.
9268 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9271 * lisp.h (eassert): Check that the argument compiles, even if
9272 ENABLE_CHECKING is not defined.
9274 * data.c (Findirect_variable): Name an expression, to avoid
9275 gcc -Wbad-function-cast warning.
9276 (default_value, arithcompare, arith_driver, arith_error): Now static.
9277 (store_symval_forwarding): Rename local to avoid shadowing.
9278 (Fmake_variable_buffer_local, Fmake_local_variable):
9279 Mark variables as initialized.
9280 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9282 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9283 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9284 Rename locals to avoid shadowing.
9285 (mark_stack): Move local variables into the #ifdef region where
9287 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9288 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9290 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9291 (GC_STRING_CHARS): Remove; not used.
9292 (Fmemory_limit): Cast sbrk's returned value to char *.
9294 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9295 avoids undefined behavior in theory.
9297 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9299 Use functions, not macros, for up- and down-casing (Bug#8254).
9300 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9301 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9302 to use the following functions instead of these macros.
9303 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9304 EMACS_INT, since callers assume the returned value fits in int.
9305 (upcase1): Likewise, for UPCASE_TABLE.
9306 (uppercasep, lowercasep, upcase): New static inline functions.
9307 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9308 the race-condition problem in the old DOWNCASE.
9310 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9311 Rename locals to avoid shadowing.
9312 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9313 (regex_compile, re_search_2, re_match_2_internal):
9314 Remove unused local vars.
9315 (FREE_VAR): Rewrite so as not to use empty "else",
9316 which gcc can warn about.
9317 (regex_compile, re_match_2_internal): Mark locals as initialized.
9318 (RETALLOC_IF): Define only if needed.
9319 (WORDCHAR_P): Likewise. This one is never needed, but is used
9320 only in a comment talking about a compiler bug, so put inside
9321 the #if 0 of that comment.
9322 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9323 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9326 * search.c (boyer_moore): Rename locals to avoid shadowing.
9327 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9328 (PREV_CHAR_BOUNDARY): Likewise.
9330 * search.c (simple_search): Remove unused var.
9332 * dired.c (compile_pattern): Move decl from here ...
9333 * lisp.h: ... to here, so that it can be checked.
9334 (struct re_registers): New forward decl.
9336 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9338 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9340 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9341 Rename locals to avoid shadowing.
9342 (Fvertical_motion): Mark locals as initialized.
9344 * casefiddle.c (casify_object, casify_region): Now static.
9345 (casify_region): Mark local as initialized.
9347 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9349 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9350 New macros, so that the caller can use some names other than
9351 gcpro1, gcpro2, etc.
9352 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9354 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9355 argument, for consistency with GCPRO2_VAR, etc: it is now the
9356 prefix of the variable, not the variable itself. All uses
9358 * dired.c (directory_files_internal, file_name_completion):
9359 Rename locals to avoid shadowing.
9361 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9362 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9363 dired.c's scmp function, had undefined behavior.
9364 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9365 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9366 * buffer.h: ... to here, because these macros use current_buffer,
9367 and the new implementation with inline functions needs to have
9368 current_buffer in scope now, rather than later when the macros
9370 (downcase, upcase1): New static inline functions.
9371 (DOWNCASE, UPCASE1): Reimplement using these functions.
9372 This avoids undefined behavior in expressions like
9373 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9374 from race conditions in accessing the global variables
9375 case_temp1 and case_temp2.
9376 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9377 * lisp.h (case_temp1, case_temp2): Remove their decls.
9378 * character.h (ASCII_CHAR_P): Move from here ...
9379 * lisp.h: ... to here, so that the inline functions mentioned
9382 * dired.c (directory_files_internal_unwind): Now static.
9384 * fileio.c (file_name_as_directory, directory_file_name):
9385 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9387 (file_name_as_directory): Use const pointers when appropriate.
9388 (Fexpand_file_name): Likewise. In particular, newdir might
9389 point at constant storage, so make it a const pointer.
9390 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9391 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9393 (Fset_file_times, Finsert_file_contents, auto_save_error):
9394 Rename locals to avoid shadowing.
9396 * minibuf.c (choose_minibuf_frame_1): Now static.
9397 (Ftry_completion, Fall_completions): Rename or remove locals
9400 * marker.c (bytepos_to_charpos): Remove; unused.
9402 * lisp.h (verify_bytepos, count_markers): New decls,
9403 so that gcc does not warn that these functions aren't declared.
9405 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9406 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9407 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9408 (copy_text): Remove unused local var.
9410 * filelock.c (within_one_second): Now static.
9411 (lock_file_1): Rename local to avoid shadowing.
9413 * buffer.c (fix_overlays_before): Mark locals as initialized.
9414 (fix_start_end_in_overlays): Likewise. This function should be
9415 simplified by using pointers-to-pointers, but that's a different
9417 (switch_to_buffer_1): Now static.
9418 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9419 (report_overlay_modification): Rename locals to avoid shadowing.
9421 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9422 Fix pointer signedness issue.
9423 (sys_subshell): Mark local as volatile if checking for lint,
9424 to suppress a gcc -Wclobbered warning that does not seem to be right.
9425 (MAXPATHLEN): Define only if needed.
9427 * process.c (serial_open, serial_configure): Move decls from here ...
9428 * systty.h: ... to here, so that they can be checked.
9430 * fns.c (get_random, seed_random): Move extern decls from here ...
9431 * lisp.h: ... to here, so that they can be checked.
9433 * sysdep.c (reset_io): Now static.
9434 (wait_for_termination_signal): Remove; unused.
9436 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9437 (copy_keymap_item, append_key, push_text_char_description):
9439 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9440 (DENSE_TABLE_SIZE): Remove; unused.
9441 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9442 (describe_map_tree):
9443 Rename locals to avoid shadowing.
9445 * keyboard.c: Declare functions static if they are not used elsewhere.
9446 (echo_char, echo_dash, cmd_error, top_level_2):
9447 (poll_for_input, handle_async_input): Now static.
9448 (read_char, kbd_buffer_get_event, make_lispy_position):
9449 (make_lispy_event, make_lispy_movement, apply_modifiers):
9450 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9451 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9452 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9453 (read_key_sequence, read_char): Mark locals as initialized.
9454 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9456 * keyboard.h (make_ctrl_char): New decl.
9457 (mark_kboards): Move decl here ...
9458 * alloc.c (mark_kboards): ... from here.
9460 * lisp.h (force_auto_save_soon): New decl.
9462 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9463 (DEFINE_DUMMY_FUNCTION): New macro.
9464 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9466 (main): Add casts to avoid warnings
9467 if GCC considers string literals to be constants.
9469 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9471 * dbusbind.c: Pointer signedness fixes.
9472 (xd_signature, xd_append_arg, xd_initialize):
9473 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9474 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9475 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9476 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9478 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9479 if GCC considers string literals to be constants.
9480 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9482 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9484 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9485 (print_preprocess, print_object): New macro to fix last change.
9487 * print.c (print_preprocess): Don't forget font objects.
9489 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9491 * emacs.c (USAGE3): Doc fixes.
9493 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9495 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9498 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9500 * lisp.h (VWindow_system, Qfile_name_history):
9501 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9502 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9503 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9505 * w32select.c: Don't #include "keyboard.h".
9506 (run_protected): Add extern declaration for waiting_for_input.
9508 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9509 * w32console.c (detect_input_pending, read_input_pending)
9510 (encode_terminal_code):
9511 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9512 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9513 (w32_system_caret_y, Qfile_name_history):
9514 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9515 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9516 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9517 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9518 * w32proc.c (Qlocal, report_file_error):
9519 * w32term.c (Vwindow_system, updating_frame):
9520 * w32uniscribe.c (initialized, uniscribe_font_driver):
9521 Remove unneeded extern declarations.
9523 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9525 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9527 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9529 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9530 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9531 These macros can no longer be used for assignment.
9533 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9534 Assign struct members directly, instead of using BUF_BEGV etc.
9535 (record_buffer_markers, fetch_buffer_markers): New functions for
9536 recording and fetching special buffer markers.
9537 (set_buffer_internal_1, set_buffer_temp): Use them.
9539 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9541 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9543 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9544 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9546 * xdisp.c (hscroll_window_tree):
9547 (reconsider_clip_changes): Use PT instead of BUF_PT.
9549 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9551 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9552 $(EMACS_ROOT)/lib/intprops.h.
9554 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9556 Fix more problems found by GCC 4.5.2's static checks.
9558 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9559 to unsigned char * to avoid compiler diagnostic.
9560 (xg_free_frame_widgets): Make it clear that a local variable is
9561 needed only if USE_GTK_TOOLTIP.
9562 (gdk_window_get_screen): Make it clear that this macro is needed
9563 only if USE_GTK_TOOLTIP.
9564 (int_gtk_range_get_value): New function, which avoids a diagnostic
9565 from gcc -Wbad-function-cast.
9566 (xg_set_toolkit_scroll_bar_thumb): Use it.
9567 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9568 diagnostic from gcc -Wbad-function-cast.
9569 (get_utf8_string, xg_get_file_with_chooser):
9570 Rename locals to avoid shadowing.
9571 (create_dialog): Move locals to avoid shadowing.
9573 * xgselect.c (xg_select): Remove unused var.
9575 * image.c (four_corners_best): Mark locals as initialized.
9576 (gif_load): Initialize transparent_p to zero (Bug#8238).
9577 Mark another local as initialized.
9578 (my_png_error, my_error_exit): Mark with NO_RETURN.
9580 * image.c (clear_image_cache): Now static.
9581 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9582 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9583 (x_edge_detection): Remove unnecessary cast that
9584 gcc -Wbad-function-cast diagnoses.
9585 (gif_load): Fix pointer signedness.
9586 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9587 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9589 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9591 Improve quality of tests for time stamp overflow.
9592 For example, without this patch (encode-time 0 0 0 1 1
9593 1152921504606846976) returns the obviously-bogus value (-948597
9594 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9595 reports time overflow. See
9596 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9597 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9598 * editfns.c: Include limits.h and intprops.h.
9599 (TIME_T_MIN, TIME_T_MAX): New macros.
9600 (time_overflow): Move earlier, to before first use.
9601 (hi_time, lo_time): New functions, for an accurate test for
9603 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9604 (Fget_internal_run_time): Don't assume time_t fits in int.
9605 (make_time): Use list2 instead of Fcons twice.
9606 (Fdecode_time): More accurate test for out-of-range times.
9607 (check_tm_member): New function.
9608 (Fencode_time): Use it, to test for out-of-range times.
9609 (lisp_time_argument): Don't rely on undefined left-shift and
9610 right-shift behavior when checking for time stamp overflow.
9612 * editfns.c (time_overflow): New function, refactoring common code.
9613 (Fformat_time_string, Fdecode_time, Fencode_time):
9614 (Fcurrent_time_string): Use it.
9616 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9617 * dired.c (make_time): Move to ...
9618 * editfns.c (make_time): ... here.
9619 * systime.h: Note the move.
9621 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9623 * fringe.c (update_window_fringes): Remove unused variables.
9625 * unexmacosx.c (copy_data_segment): Also copy __got section.
9628 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9630 * termcap.c [MSDOS]: Include "msdos.h".
9631 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9632 Constify `char *' arguments and their references according to
9633 prototypes in tparam.h.
9635 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9637 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9638 Adapt all references accordingly.
9640 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9642 2011-03-11 Tom Tromey <tromey@redhat.com>
9644 * buffer.c (syms_of_buffer): Remove obsolete comment.
9646 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9648 * termhooks.h (encode_terminal_code): Declare prototype.
9650 * msdos.c (encode_terminal_code): Don't declare prototype.
9652 * term.c (encode_terminal_code): Now external again, used by
9653 w32console.c and msdos.c.
9655 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9656 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9658 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9660 Fix some minor problems found by GCC 4.5.2's static checks.
9662 * fringe.c (update_window_fringes): Mark locals as initialized
9664 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9666 * alloc.c (mark_fringe_data): Move decl from here ...
9667 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9668 to check its interface.
9669 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9671 * fontset.c (free_realized_fontset): Now static.
9672 (Fset_fontset_font): Rename local to avoid shadowing.
9673 (fontset_font): Mark local as initialized.
9674 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9676 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9678 * xselect.c (x_disown_buffer_selections): Remove; not used.
9679 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9680 (x_own_selection, Fx_disown_selection_internal): Rename locals
9682 (x_handle_dnd_message): Remove local to avoid shadowing.
9684 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9685 so that the caller can use some name other than gcpro1.
9686 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9687 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9688 (Fx_backspace_delete_keys_p):
9689 Use them to avoid shadowing, and rename vars to avoid shadowing.
9690 (x_decode_color, x_set_name, x_window): Now static.
9691 (Fx_create_frame): Add braces to silence GCC warning.
9692 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9693 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9694 Remove unused locals.
9695 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9696 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9697 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9700 * xterm.h (x_mouse_leave): New decl.
9702 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9703 Remove unused functions.
9704 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9705 (x_calc_absolute_position): Now static.
9706 (XTread_socket): Don't define label "out" unless it's used.
9707 Don't declare local "event" unless it's used.
9708 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9709 unless they are used.
9710 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9711 (x_fatal_error_signal): Remove; not used.
9712 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9713 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9714 (x_error_catcher, x_connection_closed, x_error_handler):
9715 (x_error_quitter, xembed_send_message, x_iconify_frame):
9716 (my_log_handler): Rename locals to avoid shadowing.
9717 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9718 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9720 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9721 Rename or move locals to avoid shadowing.
9722 (tty_defined_color, merge_face_heights): Now static.
9723 (free_realized_faces_for_fontset): Remove; not used.
9724 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9725 does not deduce is never used uninitialized.
9726 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9727 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9729 * terminal.c (store_terminal_param): Now static.
9731 * xmenu.c (menu_highlight_callback): Now static.
9732 (set_frame_menubar): Remove unused local.
9733 (xmenu_show): Rename parameter to avoid shadowing.
9734 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9735 since they might point to immutable storage.
9736 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9737 since it's unused otherwise.
9739 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9740 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9741 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9742 avoids a gcc -Wuninitialized diagnostic.
9743 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9744 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9745 does not deduce are never used uninitialized.
9747 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9749 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9750 * window.c (window_loop, size_window):
9751 (run_window_configuration_change_hook, enlarge_window): Likewise.
9753 * window.c (display_buffer): Now static.
9754 (size_window): Mark variables that gcc -Wuninitialized
9755 does not deduce are never used uninitialized.
9756 * window.h (check_all_windows): New decl, to forestall
9757 gcc -Wmissing-prototypes diagnostic.
9758 * dispextern.h (bidi_dump_cached_states): Likewise.
9760 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9762 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9764 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9765 and to avoid gcc -Wuninitialized warning.
9766 (load_charset_map): Mark variables that gcc -Wuninitialized
9767 does not deduce are never used uninitialized.
9768 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9770 * coding.c (coding_set_source, coding_set_destination):
9771 Use "else { /* comment */ }" rather than "else /* comment */;"
9772 for clarity, and to avoid gcc -Wempty-body warning.
9773 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9774 a block, when the outer 'i' will do.
9775 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9776 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9778 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9779 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9780 Rename locals to avoid shadowing.
9781 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9782 * coding.c (emacs_mule_char, encode_invocation_designation):
9783 Now static, since they're not used elsewhere.
9784 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9785 (decode_coding_object, encode_coding_object, detect_coding_system):
9786 (decode_coding_emacs_mule): Mark variables that gcc
9787 -Wuninitialized does not deduce are never used uninitialized.
9788 (detect_coding_iso_2022): Initialize a local variable that might
9789 be used uninitialized. Leave a FIXME because it's not clear that
9790 this initialization is needed. (Bug#8211)
9791 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9792 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9793 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9794 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9795 Remove unused macros.
9797 * category.c (hash_get_category_set): Remove unused local var.
9798 (copy_category_table): Now static, since it's not used elsewhere.
9799 * character.c (string_count_byte8): Likewise.
9801 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9802 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9804 * chartab.c (copy_sub_char_table): Now static, since it's not used
9806 (sub_char_table_ref_and_range, char_table_ref_and_range):
9807 Rename locals to avoid shadowing.
9808 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9810 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9811 (BIDI_BOB): Remove unused macro.
9813 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9814 deduce are never used uninitialized.
9815 * term.c (encode_terminal_code): Likewise.
9817 * term.c (encode_terminal_code): Now static. Remove unused local.
9819 * tparam.h: New file.
9820 * term.c, tparam.h: Include it.
9821 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9822 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9823 Move these decls to tparam.h, and make them agree with what
9824 is actually in tparam.c. The previous trick of using incompatible
9825 decls in different modules does not conform to the C standard.
9826 All callers of tparam changed to use tparam's actual API.
9827 * tparam.c (tparam1, tparam, tgoto):
9828 Use const pointers where appropriate.
9830 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9831 * cm.h (struct cm): Likewise.
9832 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9833 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9834 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9835 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9836 (turn_on_face, init_tty): Likewise.
9837 * termchar.h (struct tty_display_info): Likewise.
9839 * term.c (term_mouse_position): Rename local to avoid shadowing.
9841 * alloc.c (mark_ttys): Move decl from here ...
9842 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9844 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9846 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9848 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9850 * search.c (compile_pattern_1): Remove argument regp, unused since
9851 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9852 (compile_pattern): Don't pass it.
9854 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9856 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9857 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9859 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9861 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9863 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9864 gdk_window_get_screen, gdk_window_get_geometry,
9865 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9866 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9867 (xg_get_pixbuf_from_pixmap): New function.
9868 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9869 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9870 Call xg_get_pixbuf_from_pixmap instead of
9871 gdk_pixbuf_get_from_drawable.
9872 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9873 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9874 (xg_check_special_colors): Use GtkStyleContext and its functions
9876 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9877 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9878 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9879 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9880 Call gtk_widget_get_preferred_size.
9881 (xg_frame_resized): gdk_window_get_geometry only takes 5
9883 (xg_win_to_widget, xg_event_is_for_menubar):
9884 Call gdk_x11_window_lookup_for_display.
9885 (xg_set_widget_bg): New function.
9886 (delete_cb): New function.
9887 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9888 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9889 (xg_set_background_color): Call xg_set_widget_bg.
9890 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9891 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9892 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9893 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9895 (update_frame_tool_bar): Call gtk_widget_hide.
9896 (xg_initialize): Use GDK_KEY_g.
9898 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9900 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9902 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9903 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9904 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9906 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9908 * w32xfns.c (select_palette): Check success of RealizePalette against
9909 GDI_ERROR, not zero.
9911 See ChangeLog.11 for earlier changes.
9917 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9919 This file is part of GNU Emacs.
9921 GNU Emacs is free software: you can redistribute it and/or modify
9922 it under the terms of the GNU General Public License as published by
9923 the Free Software Foundation, either version 3 of the License, or
9924 (at your option) any later version.
9926 GNU Emacs is distributed in the hope that it will be useful,
9927 but WITHOUT ANY WARRANTY; without even the implied warranty of
9928 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9929 GNU General Public License for more details.
9931 You should have received a copy of the GNU General Public License
9932 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.