| blob | 84c00d0d0bad74e4ffd0c73e6b4644eb6532d5e7 |
1 ;;; checkdoc.el --- check documentation strings for style requirements
3 ;; Copyright (C) 1997, 1998, 2001, 2002, 2003, 2004, 2005, 2006, 2007,
4 ;; 2008, 2009, 2010, 2011 Free Software Foundation, Inc.
6 ;; Author: Eric M. Ludlam <zappo@gnu.org>
7 ;; Version: 0.6.2
8 ;; Keywords: docs, maint, lisp
10 ;; This file is part of GNU Emacs.
12 ;; GNU Emacs is free software: you can redistribute it and/or modify
13 ;; it under the terms of the GNU General Public License as published by
14 ;; the Free Software Foundation, either version 3 of the License, or
15 ;; (at your option) any later version.
17 ;; GNU Emacs is distributed in the hope that it will be useful,
18 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
19 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20 ;; GNU General Public License for more details.
22 ;; You should have received a copy of the GNU General Public License
23 ;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
25 ;;; Commentary:
26 ;;
27 ;; The Emacs Lisp manual has a nice chapter on how to write
28 ;; documentation strings. Many stylistic suggestions are fairly
29 ;; deterministic and easy to check for syntactically, but also easy
30 ;; to forget. The main checkdoc engine will perform the stylistic
31 ;; checks needed to make sure these styles are remembered.
32 ;;
33 ;; There are two ways to use checkdoc:
34 ;; 1) Periodically use `checkdoc' or `checkdoc-current-buffer'.
35 ;; `checkdoc' is a more interactive version of
36 ;; `checkdoc-current-buffer'
37 ;; 2) Use `checkdoc-minor-mode' to automatically check your
38 ;; documentation whenever you evaluate Lisp code with C-M-x
39 ;; or [menu-bar emacs-lisp eval-buffer]. Additional key-bindings
40 ;; are also provided under C-c ? KEY
41 ;; (require 'checkdoc)
42 ;; (add-hook 'emacs-lisp-mode-hook
43 ;; '(lambda () (checkdoc-minor-mode 1)))
44 ;;
45 ;; Using `checkdoc':
46 ;;
47 ;; The commands `checkdoc' and `checkdoc-ispell' are the top-level
48 ;; entry points to all of the different checks that are available. It
49 ;; breaks examination of your Lisp file into four sections (comments,
50 ;; documentation, messages, and spacing) and indicates its current
51 ;; state in a status buffer.
52 ;;
53 ;; The Comments check examines your headers, footers, and
54 ;; various tags (such as "Code:") to make sure that your code is ready
55 ;; for easy integration into existing systems.
56 ;;
57 ;; The Documentation check deals with documentation strings
58 ;; and their elements that help make Emacs easier to use.
59 ;;
60 ;; The Messages check ensures that the strings displayed in the
61 ;; minibuffer by some commands (such as `error' and `y-or-n-p')
62 ;; are consistent with the Emacs environment.
63 ;;
64 ;; The Spacing check cleans up white-space at the end of lines.
65 ;;
66 ;; The interface while working with documentation and messages is
67 ;; slightly different when being run in the interactive mode. The
68 ;; interface offers several options, including the ability to skip to
69 ;; the next error, or back up to previous errors. Auto-fixing is
70 ;; turned off at this stage, but you can use the `f' or `F' key to fix
71 ;; a given error (if the fix is available.)
72 ;;
73 ;; Auto-fixing:
74 ;;
75 ;; There are four classifications of style errors in terms of how
76 ;; easy they are to fix. They are simple, complex, really complex,
77 ;; and impossible. (Impossible really means that checkdoc does not
78 ;; have a fixing routine yet.) Typically white-space errors are
79 ;; classified as simple, and are auto-fixed by default. Typographic
80 ;; changes are considered complex, and the user is asked if they want
81 ;; the problem fixed before checkdoc makes the change. These changes
82 ;; can be done without asking if `checkdoc-autofix-flag' is properly
83 ;; set. Potentially redundant changes are considered really complex,
84 ;; and the user is always asked before a change is inserted. The
85 ;; variable `checkdoc-autofix-flag' controls how these types of errors
86 ;; are fixed.
87 ;;
88 ;; Spell checking text:
89 ;;
90 ;; The variable `checkdoc-spellcheck-documentation-flag' can be set
91 ;; to customize how spell checking is to be done. Since spell
92 ;; checking can be quite slow, you can optimize how best you want your
93 ;; checking done. The default is `defun', which spell checks each time
94 ;; `checkdoc-defun' or `checkdoc-eval-defun' is used. Setting to nil
95 ;; prevents spell checking during normal usage.
96 ;; Setting this variable to nil does not mean you cannot take
97 ;; advantage of the spell checking. You can instead use the
98 ;; interactive functions `checkdoc-ispell-*' to check the spelling of
99 ;; your documentation.
100 ;; There is a list of Lisp-specific words which checkdoc will
101 ;; install into Ispell on the fly, but only if Ispell is not already
102 ;; running. Use `ispell-kill-ispell' to make checkdoc restart it with
103 ;; these words enabled.
104 ;;
105 ;; Checking parameters:
106 ;;
107 ;; You might not always want a function to have its parameters listed
108 ;; in order. When this is the case, put the following comment just in
109 ;; front of the documentation string: "; checkdoc-order: nil" This
110 ;; overrides the value of `checkdoc-arguments-in-order-flag'.
111 ;;
112 ;; If you specifically wish to avoid mentioning a parameter of a
113 ;; function in the doc string (such as a hidden parameter, or a
114 ;; parameter which is very obvious like events), you can have checkdoc
115 ;; skip looking for it by putting the following comment just in front
116 ;; of the documentation string: "; checkdoc-params: (args go here)"
117 ;;
118 ;; Checking message strings:
119 ;;
120 ;; The text that follows the `error' and `y-or-n-p' commands is
121 ;; also checked. The documentation for `error' clearly states some
122 ;; simple style rules to follow which checkdoc will auto-fix for you.
123 ;; `y-or-n-p' also states that it should end in a space. I added that
124 ;; it should end in "? " since that is almost always used.
125 ;;
126 ;; Adding your own checks:
127 ;;
128 ;; You can experiment with adding your own checks by setting the
129 ;; hooks `checkdoc-style-hooks' and `checkdoc-comment-style-hooks'.
130 ;; Return a string which is the error you wish to report. The cursor
131 ;; position should be preserved.
132 ;;
133 ;; Error errors:
134 ;;
135 ;; Checkdoc does not always flag errors correctly. There are a
136 ;; couple ways you can coax your file into passing all of checkdoc's
137 ;; tests through buffer local variables.
138 ;;
139 ;; The variable `checkdoc-verb-check-experimental-flag' can be used
140 ;; to turn off the check for verb-voice in case you use words that are
141 ;; not semantically verbs, but are still in the incomplete list.
142 ;;
143 ;; The variable `checkdoc-symbol-words' can be a list of words that
144 ;; happen to also be symbols. This is not a problem for one-word
145 ;; symbols, but if you use a hyphenated word that is also a symbol,
146 ;; then you may need this.
147 ;;
148 ;; The symbol `checkdoc-force-docstrings-flag' can be set to nil if
149 ;; you have many undocumented functions you don't wish to document.
150 ;;
151 ;; See the above section "Checking Parameters" for details about
152 ;; parameter checking.
153 ;;
154 ;; Dependencies:
155 ;;
156 ;; This file requires lisp-mnt (Lisp maintenance routines) for the
157 ;; comment checkers.
158 ;;
159 ;; Requires custom for Emacs v20.
161 ;;; TO DO:
162 ;; Hook into the byte compiler on a defun/defvar level to generate
163 ;; warnings in the byte-compiler's warning/error buffer.
164 ;; Better ways to override more typical `eval' functions. Advice
165 ;; might be good but hard to turn on/off as a minor mode.
166 ;;
167 ;;; Maybe Do:
168 ;; Code sweep checks for "forbidden functions", proper use of hooks,
169 ;; proper keybindings, and other items from the manual that are
170 ;; not specifically docstring related. Would this even be useful?
172 ;;; Code:
183 "Support for doc string checking in Emacs Lisp."
189 "String to display in mode line when Checkdoc mode is enabled; nil for none."
195 "Non-nil means attempt auto-fixing of doc strings.
196 If this value is the symbol `query', then the user is queried before
197 any change is made. If the value is `automatic', then all changes are
198 made without asking unless the change is very-complex. If the value
199 is `semiautomatic' or any other value, then simple fixes are made
200 without asking, and complex changes are made by asking the user first.
201 The value `never' is the same as nil, never ask or change anything."
210 Setting this to nil will silently make fixes that require no user
211 interaction. See `checkdoc-autofix-flag' for auto-fixing details."
216 "Non-nil means that all checkable definitions should have documentation.
217 Style guide dictates that interactive functions MUST have documentation,
218 and that it's good but not required practice to make non user visible items
219 have doc strings."
222 ;;;###autoload(put 'checkdoc-force-docstrings-flag 'safe-local-variable 'booleanp)
225 "Non-nil means that files should have a History section or ChangeLog file.
226 This helps document the evolution of, and recent changes to, the package."
229 ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp)
232 "Non-nil means the first line of a docstring may end with a comma.
233 Ordinarily, a full sentence is required. This may be misleading when
234 there is a substantial caveat to the one-line description -- the comma
235 should be used when the first part could stand alone as a sentence, but
236 it indicates that a modifying clause follows."
239 ;;;###autoload(put 'checkdoc-permit-comma-termination-flag 'safe-local-variable 'booleanp)
242 "Non-nil means run Ispell on text based on value.
243 This is automatically set to nil if Ispell does not exist on your
244 system. Possible values are:
246 nil - Don't spell-check during basic style checks.
247 defun - Spell-check when style checking a single defun
248 buffer - Spell-check when style checking the whole buffer
249 interactive - Spell-check during any interactive check.
250 t - Always spell-check"
264 Any more than this and a warning is generated suggesting that the construct
270 "Non-nil means warn if arguments appear out of order.
271 Setting this to nil will mean only checking that all the arguments
272 appear in the proper form in the documentation, not that they are in
273 the same order as they appear in the argument list. No mention is
274 made in the style guide relating to order."
277 ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp)
280 "Hooks called after the standard style check is completed.
281 All hooks must return nil or a string representing the error found.
282 Useful for adding new user implemented commands.
284 Each hook is called with two parameters, (DEFUNINFO ENDPOINT).
285 DEFUNINFO is the return value of `checkdoc-defun-info'. ENDPOINT is the
289 "Hooks called after the standard comment style check is completed.
290 Must return nil if no errors are found, or a string describing the
299 "Regular expression used to identify a defun.
303 "Non-nil means to attempt to check the voice of the doc string.
304 This check keys off some words which are commonly misused. See the
305 variable `checkdoc-common-verbs-wrong-voice' if you wish to add your own."
310 "Non-nil means generate warnings in a buffer for browsing.
311 Do not set this by hand, use a function like `checkdoc-current-buffer'
315 "A list of symbol names (strings) which also happen to make good words.
316 These words are ignored when unquoted symbols are searched for.
317 This should be set in an Emacs Lisp file's local variables."
320 ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p)
322 ;;;###autoload
324 ;; this is a function so it might be shared by checkdoc-proper-noun-list
325 ;; and/or checkdoc-ispell-lisp-words in the future
334 ;; "[.!?]" is for noun at end of a sentence, since those chars
335 ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
336 ;; The \" allows it to be the last sentence in a docstring too.
425 )
426 "Alist of common words in the wrong voice and what should be used instead.
427 Set `checkdoc-verb-check-experimental-flag' to nil to avoid this costly
428 and experimental check. Do not modify this list without setting
429 the value of `checkdoc-common-verbs-regexp' to nil which cause it to
434 ;; When dealing with syntax in doc strings, make sure that - are
435 ;; encompassed in words so we can use cheap \\> to get the end of a symbol,
436 ;; not the end of a word in a conglomerate.
438 st)
441 ;;; Compatibility
442 ;;
458 ;;; User level commands
459 ;;
460 ;;;###autoload
462 "Interactively check the entire buffer for style errors.
463 The current status of the check will be displayed in a buffer which
464 the users will view as each check is completed."
470 ;; if the user set autofix to never, then that breaks the
471 ;; obviously requested asking implied by using this function.
472 ;; Set it to paranoia level.
475 'query
476 checkdoc-autofix-flag))
477 tmp)
479 ;; check the comments
487 ;; Check the documentation
494 ;; Check the message text
500 ;; Rogue spacing
509 "Display and update the status buffer for the current checkdoc mode.
510 CHECK is a list of four strings stating the current status of each
511 test; the nth string describes the status of the nth test."
524 ;;;###autoload
526 "Interactively check the current buffer for doc string errors.
527 Prefix argument START-HERE will start the checking from the current
528 point, otherwise the check starts at the beginning of the current
529 buffer. Allows navigation forward and backwards through document
530 errors. Does not check for comment or space warnings.
531 Optional argument SHOWSTATUS indicates that we should update the
532 checkdoc status window instead of the usual behavior."
538 ;; Due to a design flaw, this will never spell check
539 ;; docstrings.
542 ;; This is a workaround to perform spell checking.
545 ;;;###autoload
547 "Interactively check the current buffer for message string errors.
548 Prefix argument START-HERE will start the checking from the current
549 point, otherwise the check starts at the beginning of the current
550 buffer. Allows navigation forward and backwards through document
551 errors. Does not check for comment or space warnings.
552 Optional argument SHOWSTATUS indicates that we should update the
553 checkdoc status window instead of the usual behavior."
559 ;; Due to a design flaw, this will never spell check messages.
562 ;; This is a workaround to perform spell checking.
566 "Interactively loop over all errors that can be found by a given method.
568 If START-HERE is nil, searching starts at the beginning of the current
569 buffer, otherwise searching starts at START-HERE. SHOWSTATUS
570 expresses the verbosity of the search, and whether ending the search
571 will auto-exit this function.
573 FINDFUNC is a symbol representing a function that will position the
574 cursor, and return error message text to present to the user. It is
575 assumed that the cursor will stop just before a major sexp, which will
576 be highlighted to present the user with feedback as to the offending
577 style."
578 ;; Determine where to start the test
581 ;; Assign a flag to spellcheck flag
585 ;; Fetch the error list
589 c)
592 ;; Include whatever function point is in for good measure.
596 ;; The cursor should be just in front of the offending doc string
607 ;; Make sure the whole doc string is visible if possible.
631 ;; Exit condition
633 ;; Request an auto-fix
638 ;; `automatic-then-never' tells the autofix function
639 ;; to only allow one fix to be automatic. The autofix
640 ;; function will then set the flag to 'never, allowing
641 ;; the checker to return a different error.
663 ;; Move to the next error (if available)
669 err-list nil)
675 ;; Go backwards in the list of errors
684 ;; Edit the buffer recursively.
695 err-list nil)
699 ;; Quit checkdoc
702 err-list nil
704 ;; Goofy stuff
715 ""
717 "f, y - auto Fix this warning without asking (if\
720 )
732 returnme))
735 "Interactively spell check doc strings in the current buffer.
736 If START-HERE is nil, searching starts at the beginning of the current
737 buffer, otherwise searching starts at START-HERE."
740 ;; Move point to where we need to start.
742 ;; Include whatever function point is in for good measure.
745 ;; Loop over docstrings.
755 "Interactively spell check messages in the current buffer.
756 If START-HERE is nil, searching starts at the beginning of the current
757 buffer, otherwise searching starts at START-HERE."
760 ;; Move point to where we need to start.
762 ;; Include whatever function point is in for good measure.
765 ;; Loop over message strings.
776 "Find and return the next checkdoc error list, or nil.
777 Only documentation strings are checked.
778 An error list is of the form (WARNING . POSITION) where WARNING is the
779 warning text, and POSITION is the point in the buffer where the error
780 was found. We can use points and not markers because we promise not
781 to edit the buffer before point without re-executing this check.
782 Argument ENABLE-FIX will enable auto-fixing while looking for the next
783 error. This argument assumes that the cursor is already positioned to
784 perform the fix."
795 ;; Quit.. restore position, Other errors, leave alone
797 msg)))
800 "Find and return the next checkdoc message related error list, or nil.
801 Only text for error and `y-or-n-p' strings are checked. See
802 `checkdoc-next-error' for details on the return value.
803 Argument ENABLE-FIX turns on the auto-fix feature. This argument
804 assumes that the cursor is already positioned to perform the fix."
817 ;; Quit.. restore position, Other errors, leave alone
819 msg)))
822 "Enter recursive edit to permit a user to fix some error checkdoc has found.
823 MSG is the error that was found, which is displayed in a help buffer."
838 ;;;###autoload
840 "Evaluate and check documentation for the current buffer.
841 Evaluation is done first because good documentation for something that
842 doesn't work is just not useful. Comments, doc strings, and rogue
843 spacing are all verified."
848 ;;;###autoload
850 "Check current buffer for document, comment, error style, and rogue spaces.
851 With a prefix argument (in Lisp, the argument TAKE-NOTES),
852 store all errors found in a warnings buffer,
853 otherwise stop after the first error."
857 ;; Assign a flag to spellcheck flag
862 checkdoc-autofix-flag))
867 ;; every test is responsible for returning the cursor.
877 ;;;###autoload
879 "Start scanning the current buffer for documentation string style errors.
880 Only documentation strings are checked.
881 Use `checkdoc-continue' to continue checking if an error cannot be fixed.
882 Prefix argument TAKE-NOTES means to collect all the warning messages into
883 a separate buffer."
890 ;; Go back since we can't be here without success above.
892 nil))
894 ;;;###autoload
896 "Find the next doc string in the current buffer which has a style error.
897 Prefix argument TAKE-NOTES means to continue through the whole buffer and
898 save warnings in a separate buffer. Second optional argument START-POINT
899 is the starting location. If this is nil, `point-min' is used instead."
902 ;; Assign a flag to spellcheck flag
907 checkdoc-autofix-flag))
911 ;; If we are taking notes, encompass the whole buffer, otherwise
912 ;; the user is navigating down through the buffer.
914 ;; OK, let's look at the doc string.
927 "Move to the next doc string after point, and return t.
928 Return nil if there are no more doc strings."
930 nil
931 ;; search drops us after the identifier. The next sexp is either
932 ;; the argument list or the value of the variable. skip it.
935 t))
937 ;;;###autoload
939 "Find missing comment sections in the current Emacs Lisp file.
940 Prefix argument TAKE-NOTES non-nil means to save warnings in a
941 separate buffer. Otherwise print a message. This returns the error
942 if there is one."
956 e))
958 ;;;###autoload
960 "Find extra spaces at the end of lines in the current file.
961 Prefix argument TAKE-NOTES non-nil means to save warnings in a
962 separate buffer. Otherwise print a message. This returns the error
963 if there is one.
964 Optional argument INTERACT permits more interactive fixing."
972 e
978 ;;;###autoload
980 "Scan the buffer for occurrences of the error function, and verify text.
981 Optional argument TAKE-NOTES causes all errors to be logged."
990 e
998 ;;;###autoload
1000 "Evaluate the current form with `eval-defun' and check its documentation.
1001 Evaluation is done first so the form will be read before the
1002 documentation is checked. If there is a documentation error, then the display
1003 of what was evaluated will be overwritten by the diagnostic message."
1008 ;;;###autoload
1010 "Examine the doc string of the function or variable under point.
1011 Call `error' if the doc string has problems. If NO-ERROR is
1012 non-nil, then do not call error, but call `message' instead.
1013 If the doc string passes the test, then check the function for rogue white
1014 space at the end of each line."
1019 ;; I found this more annoying than useful.
1020 ;;(if (not no-error)
1021 ;; (message "Cannot check this sexp's doc string."))
1022 nil
1023 ;; search drops us after the identifier. The next sexp is either
1024 ;; the argument list or the value of the variable. skip it.
1048 ;;; Ispell interface for forcing a spell check
1049 ;;
1051 ;;;###autoload
1053 "Check the style and spelling of everything interactively.
1054 Calls `checkdoc' with spell-checking turned on.
1055 Prefix argument TAKE-NOTES is the same as for `checkdoc'"
1060 ;;;###autoload
1062 "Check the style and spelling of the current buffer.
1063 Calls `checkdoc-current-buffer' with spell-checking turned on.
1064 Prefix argument TAKE-NOTES is the same as for `checkdoc-current-buffer'"
1069 ;;;###autoload
1071 "Check the style and spelling of the current buffer interactively.
1072 Calls `checkdoc-interactive' with spell-checking turned on.
1073 Prefix argument TAKE-NOTES is the same as for `checkdoc-interactive'"
1078 ;;;###autoload
1080 "Check the style and spelling of message text interactively.
1081 Calls `checkdoc-message-interactive' with spell-checking turned on.
1082 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-interactive'"
1087 ;;;###autoload
1089 "Check the style and spelling of message text interactively.
1090 Calls `checkdoc-message-text' with spell-checking turned on.
1091 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-text'"
1096 ;;;###autoload
1098 "Check the style and spelling of the current buffer.
1099 Calls `checkdoc-start' with spell-checking turned on.
1100 Prefix argument TAKE-NOTES is the same as for `checkdoc-start'"
1105 ;;;###autoload
1107 "Check the style and spelling of the current buffer after point.
1108 Calls `checkdoc-continue' with spell-checking turned on.
1109 Prefix argument TAKE-NOTES is the same as for `checkdoc-continue'"
1114 ;;;###autoload
1116 "Check the style and spelling of the current buffer's comments.
1117 Calls `checkdoc-comments' with spell-checking turned on.
1118 Prefix argument TAKE-NOTES is the same as for `checkdoc-comments'"
1123 ;;;###autoload
1125 "Check the style and spelling of the current defun with Ispell.
1126 Calls `checkdoc-defun' with spell-checking turned on.
1127 Prefix argument TAKE-NOTES is the same as for `checkdoc-defun'"
1132 ;;; Error Management
1133 ;;
1134 ;; Errors returned from checkdoc functions can have various
1135 ;; features and behaviors, so we need some ways of specifying
1136 ;; them, and making them easier to use in the wacked-out interfaces
1137 ;; people are requesting
1139 "Used to create the return error text returned from all engines.
1140 TEXT is the descriptive text of the error. START and END define the region
1141 it is sensible to highlight when describing the problem.
1142 Optional argument UNFIXABLE means that the error has no auto-fix available.
1144 A list of the form (TEXT START END UNFIXABLE) is returned if we are not
1145 generating a buffered list of errors."
1148 nil)
1152 "Return the text specified in the checkdoc ERR."
1153 ;; string-p part is for backwards compatibility
1157 "Return the start point specified in the checkdoc ERR."
1158 ;; string-p part is for backwards compatibility
1162 "Return the end point specified in the checkdoc ERR."
1163 ;; string-p part is for backwards compatibility
1167 "Return the t if we cannot autofix the error specified in the checkdoc ERR."
1168 ;; string-p part is for backwards compatibility
1171 ;;; Minor Mode specification
1172 ;;
1177 ;; Override some bindings
1183 ;; Add some new bindings under C-c ?
1201 ;; bind our submap into map
1203 map)
1206 ;; Add in a menubar with easy-menu
1209 nil checkdoc-minor-mode-map "Checkdoc Minor Mode Menu"
1215 "---"
1224 checkdoc-ispell-message-interactive t]
1229 buffer-file-name]
1231 "---"
1236 ))
1237 ;; XEmacs requires some weird stuff to add this menu in a minor mode.
1238 ;; What is it?
1240 ;;;###autoload
1242 "Toggle Checkdoc minor mode, a mode for checking Lisp doc strings.
1243 With prefix ARG, turn Checkdoc minor mode on if ARG is positive, otherwise
1244 turn it off.
1246 In Checkdoc minor mode, the usual bindings for `eval-defun' which is
1247 bound to \\<checkdoc-minor-mode-map>\\[checkdoc-eval-defun] and `checkdoc-eval-current-buffer' are overridden to include
1248 checking of documentation strings.
1251 nil checkdoc-minor-mode-string nil
1254 ;;; Subst utils
1255 ;;
1257 "Run hooks in HOOKVAR with ARGS."
1260 ;; This method was similar to above. We ignore the warning
1261 ;; since we will use the above for future Emacs versions
1265 "Rebuild the contents of `checkdoc-common-verbs-regexp'."
1273 ;; Profiler says this is not yet faster than just calling assoc
1274 ;;(defun checkdoc-word-in-alist-vector (word vector)
1275 ;; "Check to see if WORD is in the car of an element of VECTOR.
1276 ;;VECTOR must be sorted. The CDR should be a replacement. Since the
1277 ;;word list is getting bigger, it is time for a quick bisecting search."
1278 ;; (let ((max (length vector)) (min 0) i
1279 ;; (found nil) (fw nil))
1280 ;; (setq i (/ max 2))
1281 ;; (while (and (not found) (/= min max))
1282 ;; (setq fw (car (aref vector i)))
1283 ;; (cond ((string= word fw) (setq found (cdr (aref vector i))))
1284 ;; ((string< word fw) (setq max i))
1285 ;; (t (setq min i)))
1286 ;; (setq i (/ (+ max min) 2))
1287 ;; )
1288 ;; found))
1290 ;;; Checking engines
1291 ;;
1293 "Return a message string if the current doc string is invalid.
1294 Check for style only, such as the first line always being a complete
1295 sentence, whitespace restrictions, and making sure there are no
1296 hard-coded key-codes such as C-[char] or mouse-[number] in the comment.
1297 See the style guide in the Emacs Lisp manual for more details."
1299 ;; Jump over comments between the last object and the doc string
1308 err
1309 ;; * Every command, function, or variable intended for users to know
1310 ;; about should have a documentation string.
1311 ;;
1312 ;; * An internal variable or subroutine of a Lisp program might as well
1313 ;; have a documentation string. In earlier Emacs versions, you could
1314 ;; save space by using a comment instead of a documentation string,
1315 ;; but that is no longer the case.
1320 ;; Sometimes old code has comments where the documentation should
1321 ;; be. Let's see if we can find the comment, and offer to turn it
1322 ;; into documentation for them.
1338 ;; Our point is at the beginning of the comment!
1339 ;; Insert a quote, then remove the comment chars.
1358 ;; quote any double-quote characters in the comment.
1364 "You should convert this comment to documentation"
1368 "All interactive functions should have documentation"
1369 "All variables and subroutines might as well have a \
1375 err)))
1378 "Return an error list or string if the current doc string is invalid.
1379 Depends on `checkdoc-this-string-valid' to reset the syntax table so that
1380 regexp short cuts work. FP is the function defun information."
1382 ;; Use a marker so if an early check modifies the text,
1383 ;; we won't accidentally lose our place. This could cause
1384 ;; end-of doc string whitespace to also delete the " char.
1390 ;; * *Do not* indent subsequent lines of a documentation string so that
1391 ;; the text is lined up in the source code with the text of the first
1392 ;; line. This looks nice in the source code, but looks bizarre when
1393 ;; users view the documentation. Remember that the indentation
1394 ;; before the starting double-quote is not part of the string!
1402 "Remove this whitespace? "
1404 nil
1406 "Second line should not have indentation"
1409 ;; * Check for '(' in column 0.
1414 "Escape this '('? "
1416 nil
1418 "Open parenthesis in column 0 should be escaped"
1420 ;; * Do not start or end a documentation string with whitespace.
1433 nil
1435 "Documentation strings should not start or end with whitespace"
1436 start end))))
1437 ;; * The first line of the documentation string should consist of one
1438 ;; or two complete sentences that stand on their own as a summary.
1439 ;; `M-x apropos' displays just the first line, and if it doesn't
1440 ;; stand on its own, the result looks bad. In particular, start the
1441 ;; first line with a capital letter and end with a period.
1449 ;; A backslashed double quote at the end of a sentence
1451 ;; We might have to add a period in this case
1454 nil
1459 nil
1461 "First sentence should end with punctuation"
1464 ;; These are ok
1465 nil)
1467 nil)
1469 ;; If it is not a complete sentence, let's see if we can
1470 ;; predict a clever way to make it one.
1475 ;; Here we have found a complete sentence, but no break.
1478 "First line not a complete sentence. Add RET here? "
1489 ;; We can merge these lines! Replace this CR
1490 ;; with a space.
1493 ;; Let's see if there is enough room to draw the next
1494 ;; line's sentence up here. I often get hit w/
1495 ;; auto-fill moving my words around.
1505 "1st line not a complete sentence. Join these lines? "
1508 ;; They said yes. We have more fill work to do...
1517 ;; Continuation of above. Make sure our sentence is capitalized.
1524 t)
1525 nil
1527 "First line should be capitalized"
1529 nil))
1530 ;; * Don't write key sequences directly in documentation strings.
1531 ;; Instead, use the `\\[...]' construct to stand for them.
1536 ;; Find the first key sequence not in a sample
1546 ;; It is not practical to use `\\[...]' very many times, because
1547 ;; display of the documentation string will become slow. So use this
1548 ;; to describe the most important commands in your major mode, and
1549 ;; then use `\\{...}' to display the rest of the mode's keymap.
1557 ;; Ambiguous quoted symbol. When a symbol is both bound and fbound,
1558 ;; and is referred to in documentation, it should be prefixed with
1559 ;; something to disambiguate it. This check must be before the
1560 ;; 80 column check because it will probably break that.
1578 ;; We didn't actually replace anything. Here we find
1579 ;; out what special word form they wish to use as
1580 ;; a prefix.
1583 "Disambiguating Keyword (default variable): "
1595 nil)))
1596 ;; * Format the documentation string so that it fits in an
1597 ;; Emacs window on an 80-column screen. It is a good idea
1598 ;; for most lines to be no wider than 60 characters. The
1599 ;; first line can be wider if necessary to fit the
1600 ;; information that ought to be there.
1609 eol t))
1615 "Some lines are over 80 columns wide"
1617 ;; Here we deviate to tests based on a variable or function.
1618 ;; We must do this before checking for symbols in quotes because there
1619 ;; is a chance that just such a symbol might really be an argument.
1621 ;; This is if we are in a variable
1623 ;; * The documentation string for a variable that is a
1624 ;; yes-or-no flag should start with words such as Non-nil
1625 ;; means..., to make it clear that all non-`nil' values are
1626 ;; equivalent and indicate explicitly what `nil' and non-`nil'
1627 ;; mean.
1628 ;; * If a user option variable records a true-or-false
1629 ;; condition, give it a name that ends in `-flag'.
1631 ;; If the variable has -flag in the name, make sure
1635 "Flag variable doc strings should usually start: Non-nil means"
1637 ;; Don't rename variable to "foo-flag". This is unnecessary
1638 ;; and such names often end up inconvenient when the variable
1639 ;; is later expanded to non-boolean values. --Stef
1640 ;; If the doc string starts with "Non-nil means"
1641 ;; (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
1642 ;; (not (string-match "-flag$" (car fp))))
1643 ;; (let ((newname
1644 ;; (if (string-match "-p$" (car fp))
1645 ;; (concat (substring (car fp) 0 -2) "-flag")
1646 ;; (concat (car fp) "-flag"))))
1647 ;; (if (checkdoc-y-or-n-p
1648 ;; (format
1649 ;; "Rename to %s and Query-Replace all occurrences? "
1650 ;; newname))
1651 ;; (progn
1652 ;; (beginning-of-defun)
1653 ;; (query-replace-regexp
1654 ;; (concat "\\<" (regexp-quote (car fp)) "\\>")
1655 ;; newname))
1656 ;; (checkdoc-create-error
1657 ;; "Flag variable names should normally end in `-flag'" s
1658 ;; (marker-position e)))))
1659 ;; Done with variables
1660 ))
1662 ;; This if we are in a function definition
1664 ;; * When a function's documentation string mentions the value
1665 ;; of an argument of the function, use the argument name in
1666 ;; capital letters as if it were a name for that value. Thus,
1667 ;; the documentation string of the function `/' refers to its
1668 ;; second argument as `DIVISOR', because the actual argument
1669 ;; name is `divisor'.
1671 ;; Addendum: Make sure they appear in the doc in the same
1672 ;; order that they are found in the arg list.
1682 inopts t)
1687 ;; Require whitespace OR
1688 ;; ITEMth<space> OR
1689 ;; ITEMs<space>
1691 e t)))
1694 ;; If the symbol was not found, let's see if we
1695 ;; can find it with a different capitalization
1696 ;; and see if the user wants to capitalize it.
1700 ;; Require whitespace OR
1701 ;; ITEMth<space> OR
1702 ;; ITEMs<space>
1704 e t))
1708 "If this is the argument `%s', it should appear as %s. Fix? "
1714 ;; It wasn't found at all! Offer to attach this new symbol
1715 ;; to the end of the documentation string.
1718 "Add %s documentation to end of doc string? "
1720 ;; Now do some magic and invent a doc string.
1731 nil)
1734 "Argument `%s' should appear (as %s) in the doc string"
1741 "Arguments occur in the doc string out of order"
1743 ;; * For consistency, phrase the verb in the first sentence of a
1744 ;; documentation string for functions as an imperative.
1745 ;; For instance, use `Return the cons of A and
1746 ;; B.' in preference to `Returns the cons of A and B.'
1747 ;; Usually it looks good to do likewise for the rest of the
1748 ;; first paragraph. Subsequent paragraphs usually look better
1749 ;; if they have proper subjects.
1750 ;;
1751 ;; This is the least important of the above tests. Make sure
1752 ;; it occurs last.
1755 ;; Maybe rebuild the monster-regexp
1759 ;; check string-continuation
1766 checkdoc-common-verbs-regexp
1767 lim t))
1771 checkdoc-common-verbs-wrong-voice))
1781 replace t)
1784 ;; there was a match, but no replace
1788 original replace)
1790 ;; Done with functions
1791 )))
1792 ;;* When a documentation string refers to a Lisp symbol, write it as
1793 ;; it would be printed (which usually means in lower case), with
1794 ;; single-quotes around it. For example: `lambda'. There are two
1795 ;; exceptions: write t and nil without single-quotes. (In this
1796 ;; manual, we normally do use single-quotes for those symbols.)
1801 ;; Ignore manual page refereces like
1802 ;; git-config(1).
1804 e t))
1806 ;; A . is a \s_ char, so we must remove periods from
1807 ;; sentences more carefully.
1817 ms))
1825 ms))))))
1830 nil)))
1831 ;; t and nil case
1839 nil
1841 "Symbols t and nil should not appear in `...' quotes"
1843 ;; Here is some basic sentence formatting
1845 ;; Here are common proper nouns that should always appear capitalized.
1847 ;; Make sure the doc string has correctly spelled English words
1848 ;; in it. This function is extracted due to its complexity,
1849 ;; and reliance on the Ispell program.
1851 ;; User supplied checks
1853 ;; Done!
1854 )))
1857 "Return a list of details about the current sexp.
1858 It is a list of the form:
1859 (NAME VARIABLE INTERACTIVE NODOCPARAMS PARAMETERS ...)
1860 where NAME is the name, VARIABLE is t if this is a `defvar',
1861 INTERACTIVE is nil if this is not an interactive function, otherwise
1862 it is the position of the `interactive' call, and PARAMETERS is a
1863 string which is the name of each variable in the function's argument
1864 list. The NODOCPARAMS is a sublist of parameters specified by a checkdoc
1865 comment for a given defun. If the first element is not a string, then
1866 the token checkdoc-order: <TOKEN> exists, and TOKEN is a symbol read
1867 from the comment."
1883 ;; The variable spot
1885 ;; Interactive
1890 t)
1891 ret)))
1895 ;; Overload th main obarray so read doesn't intern the
1896 ;; local symbols of the function we are checking.
1897 ;; Without this we end up cluttering the symbol space w/
1898 ;; useless symbols.
1900 ;; Ok, check for checkdoc parameter comment here
1908 t)
1914 t)
1928 sl1)
1929 ret)))
1930 ;; Read the list of parameters, but do not put the symbols in
1931 ;; the standard obarray.
1933 ;; This is because read will intern nil if it doesn't into the
1934 ;; new obarray.
1943 "Return non-nil if the current point is in a code fragment.
1944 A code fragment is identified by an open parenthesis followed by a
1945 symbol which is a valid function or a word in all CAPS, or a parenthesis
1946 that is quoted with the ' character. Only the region from START to LIMIT
1947 is is allowed while searching for the bounding parenthesis."
1958 ;; if this string is function bound, we are in
1959 ;; sample code. If it has a - or : character in
1960 ;; the name, then it is probably supposed to be bound
1961 ;; but isn't yet.
1970 The text checked is between START and LIMIT."
1981 "Check all text between BEGIN and END for lower case proper nouns.
1982 These are Emacs centric proper nouns which should be capitalized for
1983 consistency. Return an error list if any are not fixed, but
1984 internally skip over no answers.
1985 If the offending word is in a piece of quoted text, then it is skipped."
1999 ;; surrounded by /, as in a URL or filename: /emacs/
2003 ;; info or url links left alone
2005 help-xref-info-regexp))
2007 help-xref-url-regexp)))
2010 text)
2012 nil
2014 ;; If there is already an error, then generate
2015 ;; the warning output if applicable
2019 "Name %s should appear capitalized as %s"
2021 b e))
2024 "Name %s should appear capitalized as %s"
2026 bb b be e)))))))
2030 "Make sure all sentences have double spaces between BEGIN and END."
2047 ;; piece of an abbreviation
2048 ;; FIXME etc
2053 b e
2054 "There should be two spaces after a period. Fix? "
2056 nil
2058 ;; If there is already an error, then generate
2059 ;; the warning output if applicable
2062 "There should be two spaces after a period"
2063 b e))
2065 "There should be two spaces after a period"
2066 bb b be e)))))))
2069 ;;; Ispell engine
2070 ;;
2074 "Initialize Ispell process (default version) with Lisp words.
2075 The words used are from `checkdoc-ispell-lisp-words'. If `ispell'
2076 cannot be loaded, then set `checkdoc-spellcheck-documentation-flag' to
2077 nil."
2083 ;; This code copied in part from ispell.el Emacs 19.34
2087 ;; Silence byte compiler
2094 "Run the Ispell tools on the doc string between point and END.
2095 Since Ispell isn't Lisp-smart, we must pre-process the doc string
2096 before using the Ispell engine on it."
2098 ;; If the user wants no questions or fixing, then we must
2099 ;; disable spell checking as not useful.
2102 nil
2109 ;; Skip lists describing meta-syntax, or bound variables
2117 ;; This is probably repetitive in most cases, but not always.
2118 nil
2119 ;; Find out how we spell-check this word.
2121 ;; All caps w/ option th, or s tacked on the end
2122 ;; for pluralization or numberthness.
2125 )
2126 nil
2135 ;; Nothing here.
2136 )))))
2138 err))))
2140 ;;; Rogue space checking engine
2141 ;;
2143 "Return a message list if there is a line with white space at the end.
2144 If `checkdoc-autofix-flag' permits, delete that whitespace instead.
2145 If optional arguments START and END are non-nil, bound the check to
2146 this region.
2147 Optional argument INTERACT may permit the user to fix problems on the fly."
2151 ;; If end is nil, it means end of buffer to search anyway
2153 ;; Check for an error if `? ' or `?\ ' is used at the end of a line.
2154 ;; (It's dangerous)
2159 "Don't use `? ' at the end of a line. \
2160 News agents may remove it"
2162 ;; If interactive is passed down, give them a chance to fix things.
2169 ;; Check for, and potentially remove whitespace appearing at the
2170 ;; end of different lines.
2173 ;; There is no documentation in the Emacs Lisp manual about this check,
2174 ;; it is intended to help clean up messy code and reduce the file size.
2176 ;; This is not a complex activity
2180 nil
2183 ;; Return an error and leave the cursor at that spot, or restore
2184 ;; the cursor.
2188 nil)))
2190 ;;; Comment checking engine
2191 ;;
2193 ;; We must load this to:
2194 ;; a) get symbols for compile and
2195 ;; b) determine if we have lm-history symbol which doesn't always exist
2201 "Return a message list if this file does not match the Emacs standard.
2202 This checks for style only, such as the first line, Commentary:,
2203 Code:, and others referenced in the style guide."
2205 nil
2207 ;; Old XEmacs don't have `lm-commentary-mark'
2216 ;; This file has been set up where ERR is a variable. Each check is
2217 ;; asked, and the function will make sure that if the user does not
2218 ;; auto-fix some error, that we still move on to the next auto-fix,
2219 ;; AND we remember the past errors.
2221 err
2222 ;; Lisp Maintenance checks first
2223 ;; Was: (lm-verify) -> not flexible enough for some people
2224 ;; * Summary at the beginning of the file:
2226 ;; This certifies as very complex so always ask unless
2227 ;; it's set to never
2236 nil))
2238 err
2240 ;; * Commentary Section
2247 nil t)
2260 nil nil t)))
2261 nil)
2262 err))
2264 err
2266 ;; * History section. Say nothing if there is a file ChangeLog
2272 nil
2278 nil t)
2290 err))
2292 err
2294 ;; * Code section
2297 pos)
2299 ;; match ";;;###autoload" cookie to keep it with the form
2306 nil t))
2314 nil)
2318 nil)
2319 err))
2321 err
2323 ;; * A footer. Not compartmentalized from lm-verify: too bad.
2324 ;; The following is partially clipped from lm-verify
2332 nil t))
2339 fn fn fe)
2341 err))
2342 ;; The below checks will not return errors if the user says NO
2344 ;; Let's spellcheck the commentary section. This is the only
2345 ;; section that is easy to pick out, and it is also the most
2346 ;; visible section (with the finder).
2352 ;; Since the comments talk about Lisp, use the
2353 ;; specialized spell-checker we also used for doc
2354 ;; strings.
2359 err
2361 ;; Generic Full-file checks (should be comment related)
2363 err))
2364 ;; Done with full file comment checks
2365 err)))
2368 "Return t if point is outside the bounds of a valid sexp."
2375 ;;; `error' and `message' text verifier.
2376 ;;
2378 "Search between BEG and END for a style error with message text.
2379 Optional arguments BEG and END represent the boundary of the check.
2380 The default boundary is the entire buffer."
2387 e))
2390 "Move cursor to the next checkable message string after point.
2391 Return the message classification.
2392 Argument END is the maximum bounds to search in."
2411 nil
2413 return))
2416 "Return or fix errors found in strings passed to a message display function.
2417 According to the documentation for the function `error', the error list
2418 should not end with a period, and should start with a capital letter.
2419 The function `y-or-n-p' has similar constraints.
2420 Argument TYPE specifies the type of question, such as `error or `y-or-n-p."
2421 ;; If type is nil, then attempt to derive it.
2433 ;; From the documentation of the symbol `error':
2434 ;; In Emacs, the convention is that error messages start with a capital
2435 ;; letter but *do not* end with a period. Please follow this convention
2436 ;; for the sake of consistency.
2441 "Capitalize your message text? "
2443 t)))
2445 "Messages should start with a capital letter"
2447 nil)
2448 ;; In general, sentences should have two spaces after the period.
2452 ;; Look for proper nouns in this region too.
2456 ;; Here are message type specific questions.
2463 "Remove period from error? "
2464 ""
2465 t)))
2467 "Error messages should *not* end with a period"
2469 nil)
2470 ;; `y-or-n-p' documentation explicitly says:
2471 ;; It should end in a space; `y-or-n-p' adds `(y or n) ' to it.
2472 ;; I added the ? requirement. Without it, it is unclear that we
2473 ;; ask a question and it appears to be an undocumented style.
2478 nil
2482 ;; If we see a ?, then replace with "? ".
2487 nil
2498 nil
2510 nil
2514 ;; Now, let's just run the spell checker on this guy.
2517 )))
2519 ;;; Auto-fix helper functions
2520 ;;
2522 "Like `y-or-n-p', but pays attention to `checkdoc-autofix-flag'.
2523 Argument QUESTION is the prompt passed to `y-or-n-p'."
2527 nil
2534 "Highlight between START and END and queries the user with QUESTION.
2535 If the user says yes, or if `checkdoc-autofix-flag' permits, replace
2536 the region marked by START and END with REPLACEWITH. If optional flag
2537 COMPLEX is non-nil, then we may ask the user a question. See the
2538 documentation for `checkdoc-autofix-flag' for details.
2540 If a section is auto-replaced without asking the user, this function
2541 will pause near the fixed code so the user will briefly see what
2542 happened.
2544 This function returns non-nil if the text was replaced.
2546 This function will not modify `match-data'."
2563 ;; On the off chance this is automatic, display
2564 ;; the question anyway so the user knows what's
2565 ;; going on.
2577 ret)))
2579 ;;; Warning management
2580 ;;
2594 "Set up the major mode for the buffer containing the list of errors."
2596 checkdoc-output-error-regex-alist)
2598 checkdoc-output-font-lock-keywords))
2601 "The name to use for a checkdoc buffer in the error list."
2607 "Initialize the checkdoc diagnostic buffer for a pass.
2608 Create the header so that the string CHECK-TYPE is displayed as the
2609 function called to create the messages."
2621 "Store POINT and MSG as errors in the checkdoc diagnostic buffer."
2633 "Display the checkdoc diagnostic buffer in a temporary window."
2644 nil)))
2656 ;;; checkdoc.el ends here