1 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5 2012-01-28 Chong Yidong <cyd@gnu.org>
8 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
10 2012-01-26 Chong Yidong <cyd@gnu.org>
12 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
14 * search.c (Fsearch_forward, Fsearch_backward): Document negative
15 repeat counts (Bug#10507).
17 2012-01-26 Glenn Morris <rgm@gnu.org>
19 * lread.c (syms_of_lread): Doc fix.
21 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
23 * coding.c (encode_designation_at_bol): Change return value to
26 2012-01-25 Chong Yidong <cyd@gnu.org>
28 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
30 2012-01-21 Chong Yidong <cyd@gnu.org>
32 * floatfns.c (Fcopysign): Make the second argument non-optional,
33 since nil is not allowed anyway.
35 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
37 * process.c (read_process_output): Use p instead of XPROCESS (proc).
38 (send_process): Likewise.
40 2012-01-19 Martin Rudalics <rudalics@gmx.at>
42 * window.c (save_window_save, Fcurrent_window_configuration)
43 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
46 2012-01-19 Kenichi Handa <handa@m17n.org>
48 * character.c (char_width): New function.
49 (Fchar_width, c_string_width, lisp_string_width):
50 Use char_width (Bug#9496).
52 2012-01-16 Martin Rudalics <rudalics@gmx.at>
54 * window.c (Vwindow_persistent_parameters): New variable.
55 (Fset_window_configuration, save_window_save): Handle persistent
58 2012-01-14 Eli Zaretskii <eliz@gnu.org>
60 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
61 thrashing the stack of the thread. (Bug#9087)
63 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
65 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
67 2012-01-11 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (rows_from_pos_range): Handle the case where the
70 highlight ends on a newline. (Bug#10464)
71 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
72 he end column for display of highlight that ends on a newline
75 2012-01-11 Glenn Morris <rgm@gnu.org>
77 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
78 from load-path also when installation-directory is nil. (Bug#10208)
80 2012-01-10 Glenn Morris <rgm@gnu.org>
82 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
84 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
85 Update template values to be closer to their typical values these days.
87 2012-01-09 Eli Zaretskii <eliz@gnu.org>
89 * xdisp.c (rows_from_pos_range): Accept additional argument
90 DISP_STRING, and accept any glyph in a row whose object is that
91 string as eligible for mouse highlight. Fixes mouse highlight of
92 display strings from overlays. (Bug#10464)
94 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
96 emacs: fix an auto-save permissions race condition (Bug#10400)
97 * fileio.c (auto_saving_dir_umask): New static var.
98 (Fmake_directory_internal): Use it.
99 (do_auto_save_make_dir): Set it, instead of invoking chmod after
100 creating the directory. The old code temporarily assigns
101 too-generous permissions to the directory.
102 (do_auto_save_eh): Clear it.
103 (Fdo_auto_save): Catch all errors, not just file errors, so
104 that the var is always cleared.
106 2012-01-07 Eli Zaretskii <eliz@gnu.org>
108 * search.c (scan_buffer): Pass character positions to
109 know_region_cache, not byte positions. (Bug#6540)
111 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
113 * w32.c (sys_rename): Report EXDEV when rename of a directory
114 fails because the target is on another logical disk. (Bug#10284)
116 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
118 * xterm.c (x_embed_request_focus): New function.
120 * xterm.h: Add prototype.
122 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
124 2012-01-05 Glenn Morris <rgm@gnu.org>
126 * emacs.c (emacs_copyright): Update short copyright year to 2012.
128 2012-01-01 Eli Zaretskii <eliz@gnu.org>
130 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
131 Load gnutls_transport_set_lowat only if GnuTLS version is below
133 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
134 GnuTLS versions below 2.11.1.
136 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
138 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
139 to the doc string advising against its use for altering the way
140 windows are scrolled.
142 2011-12-28 Kenichi Handa <handa@m17n.org>
144 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
145 coding-system ASCII compatible only when it does not produce BOM
146 on encoding (Bug#10383).
148 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
150 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
152 (create_and_show_popup_menu): Always use menu_position_func for
155 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
157 * callint.c (Fcall_interactively): Don't truncate prompt string.
159 2011-12-23 Eli Zaretskii <eliz@gnu.org>
161 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
162 property that ends at ZV, so that the bidi iteration could be
163 resumed from there (after widening). (Bug#10360)
165 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
167 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
169 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
171 * nsterm.m (x_free_frame_resources):
172 Release f->output_data.ns->miniimage.
173 (ns_index_color): Fix indentation. Do not retain
174 color_table->colors[i].
176 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
179 * nsfns.m (x_set_background_color): Assign return value from
180 ns_index_color to face-background instead of NSColor*.
181 (ns_implicitly_set_icon_type): Fix indentation.
182 Change assignment in for loop to comparison.
184 * emacs.c (ns_pool): New variable.
185 (main): Assign ns_pool.
186 (Fkill_emacs): Call ns_release_autorelease_pool.
188 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
189 autorelease fdesc, release fdAttrs and tdict.
190 (ns_get_covering_families): Release charset.
191 (ns_findfonts): Release NSFontDescriptor created with new.
192 (ns_uni_to_glyphs): Fix indentation.
193 (setString): Release attrStr before assigning new value.
195 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
197 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
199 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
200 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
202 2011-12-18 David Reitter <reitter@cmu.edu>
204 * nsterm.m (ns_term_init): Subscribe for notifications
205 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
206 to method trackingNotification in EmacsMenu.
208 * nsmenu.m (trackingMenu): New variable.
209 (trackingNotification): New method (from Aquamacs).
210 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
211 from Aquamacs (Bug#7030).
213 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
215 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
216 (symbol_to_nsstring): Fix indentation.
217 (ns_symbol_to_pb): New function.
218 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
219 (Fns_rotate_cut_buffers_internal): Removed.
220 (Fns_store_selection_internal): Renamed from
221 Fns_store_cut_buffer_internal.
222 (ns_get_foreign_selection, Fx_own_selection_internal)
223 (Fx_disown_selection_internal, Fx_selection_exists_p)
224 (Fns_get_selection_internal, Fns_store_selection_internal):
225 Use ns_symbol_to_pb and check if return value is nil.
226 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
227 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
228 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
229 renamed to Sns_store_selection_internal.
230 (ns_handle_selection_request): Move code to Fx_own_selection_internal
231 and remove this function.
232 (ns_handle_selection_clear): Remove, never used.
233 (Fx_own_selection_internal): Move code from ns_handle_selection_request
236 2011-12-17 Ken Brown <kbrown@cornell.edu>
238 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
239 GID is unknown (Bug#10257).
241 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
243 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
244 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
245 which caused a build failure on GNU/Linux IA-64. This problem was
246 introduced by my 2011-10-07 patch.
248 2011-12-15 Juri Linkov <juri@jurta.org>
250 * image.c (imagemagick_error): New function. (Bug#10112)
251 (imagemagick_load_image): Comment out `MagickSetResolution' call.
252 Use `imagemagick_error' where ImageMagick functions return
254 (Fimagemagick_types): Add `Fnreverse' to return the list in the
257 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
259 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
260 fill background (Bug#8992).
262 2011-12-13 Martin Rudalics <rudalics@gmx.at>
264 * window.c (Vwindow_combination_resize)
265 (Vwindow_combination_limit): Use t instead of non-nil in
267 (Vrecenter_redisplay): Add first sentence of doc-string on
269 (Frecenter): Fix doc-string typo.
271 2011-12-11 Kenichi Handa <handa@m17n.org>
273 * coding.c (Funencodable_char_position): Pay attention to the
274 buffer text relocation (Bug#9389).
276 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
278 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
279 gtk_init (Bug#10100).
281 2011-12-10 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
284 IT->string is nil. (Bug#10263)
286 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
288 * nsterm.h (x_free_frame_resources): Declare.
290 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
291 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
293 * nsterm.h (ns_get_defaults_value): Declare.
295 * nsterm.m (ns_default): Call ns_get_defaults_value.
297 2011-12-09 Eli Zaretskii <eliz@gnu.org>
299 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
302 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
304 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
305 that where the value of an _OBJC_* symbol points to is in the .bss
308 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
310 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
311 after the loop to call ccl_driver at least once (Bug#8619).
313 2011-12-08 Kenichi Handa <handa@m17n.org>
315 * ftfont.c (get_adstyle_property): Fix previous change
318 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
320 * w32.c (init_environment): If no_site_lisp, remove site-lisp
321 dirs from the default value of EMACSLOADPATH (bug#10208).
323 2011-12-07 Glenn Morris <rgm@gnu.org>
325 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
326 installation and source directories as well. (Bug#10208)
328 2011-12-06 Chong Yidong <cyd@gnu.org>
330 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
332 2011-12-06 Glenn Morris <rgm@gnu.org>
334 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
335 as an error, not just -1. (Bug#10217)
337 2011-12-05 Chong Yidong <cyd@gnu.org>
339 * keyboard.c (process_special_events): New function.
340 (swallow_events, Finput_pending_p): Use it (Bug#10195).
342 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
344 * coding.c (encode_designation_at_bol): Don't use uninitialized
345 local variable (Bug#9318).
347 2011-12-05 Kenichi Handa <handa@m17n.org>
349 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
350 return Qnil (Bug#8046, Bug#10193).
352 2011-12-05 Kenichi Handa <handa@m17n.org>
354 * coding.c (encode_designation_at_bol): New args charbuf_end and
355 dst. Return the number of produced bytes. Callers changed.
356 (coding_set_source): Return how many bytes coding->source was
358 (coding_set_destination): Return how many bytes
359 coding->destination was relocated.
360 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
361 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
363 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
365 * coding.c (CODING_CHAR_CHARSET_P): New macro.
366 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
369 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
371 The following changes are to fix Bug#9318.
373 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
374 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
375 (encode_coding_iso_2022, encode_coding_sjis)
376 (encode_coding_big5, encode_coding_charset): Use the above macros.
378 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
380 * lisp.h (process_quit_flag): Fix external declaration.
382 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
384 Don't macro-inline non-performance-critical code.
385 * eval.c (process_quit_flag): New function.
386 * lisp.h (QUIT): Use it.
388 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
390 * nsfns.m (get_geometry_from_preferences): New function.
391 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
393 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
395 * emacs.c (Qkill_emacs): Define.
396 (syms_of_emacs): Initialize it.
397 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
398 Qquit_flag to `kill-emacs' instead.
399 (quit_throw_to_read_char): Add parameter `from_signal'.
400 All callers changed. Call Fkill_emacs if requested and safe.
401 * lisp.h (QUIT): Call Fkill_emacs if requested.
403 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
405 * widget.c (update_wm_hints): Return if wmshell is null.
406 (widget_update_wm_size_hints): New function.
408 * widget.h (widget_update_wm_size_hints): Declare.
410 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
411 widget_update_wm_size_hints (Bug#10104).
413 2011-12-03 Eli Zaretskii <eliz@gnu.org>
415 * xdisp.c (handle_invisible_prop): If the invisible text ends just
416 before a newline, prepare the bidi iterator for consuming the
417 newline, and keep the current paragraph direction. (Bug#10183)
418 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
420 2011-12-02 Juri Linkov <juri@jurta.org>
422 * search.c (Fword_search_regexp): New Lisp function created from
423 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
424 (Fword_search_backward, Fword_search_forward)
425 (Fword_search_backward_lax, Fword_search_forward_lax):
426 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
427 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
429 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
431 * fileio.c (Finsert_file_contents): Move after-change-function call
432 to before the "handled:" label, since all "goto handled" appear in
433 cases where the *-change-functions have already been properly called
436 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
438 * keyboard.c (interrupt_signal): Don't call kill-emacs when
439 waiting for input. (Bug#10169)
441 2011-11-30 Eli Zaretskii <eliz@gnu.org>
443 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
444 verifies glyph row's hash code--we have just reallocated the
445 glyphs, so their contents can be complete garbage. (Bug#10164)
447 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
449 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
451 2011-11-30 Eli Zaretskii <eliz@gnu.org>
453 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
454 attributes are tested _before_ calling verify_row_hash, to protect
455 against GCC re-ordering of the tests. (Bug#10164)
457 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
459 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
461 * xterm.c (handle_one_xevent): Only set async_visible and friends
462 if net_wm_state_hidden_seen is non-zero (Bug#10002)
463 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
464 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
466 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
468 Remove GCPRO-related macros that exist only to avoid shadowing locals.
469 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
470 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
471 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
472 All uses changed to use GCPRO1 etc.
473 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
474 Revert to old implementation (i.e., before 2011-03-11).
476 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
478 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
479 of scroll runs so as to avoid assigning disabled bogus rows and
480 unnecessary graphics copy operations.
482 2011-11-27 Eli Zaretskii <eliz@gnu.org>
484 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
485 (snprintf) [_MSC_VER]: Redirect to _snprintf.
486 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
487 (malloc, free, realloc, calloc): Redirect to e_* only when
490 * lisp.h (GCTYPEBITS): Move before first use.
491 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
492 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
493 this macro definition.
495 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
498 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
500 * gtkutil.c (xg_create_frame_widgets):
501 Call gtk_window_set_has_resize_grip (FALSE) if that function is
502 present with Gtk+ 2.0.
504 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
506 * fileio.c (Finsert_file_contents): Undo previous change; see
507 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
509 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
511 Rename locals to avoid shadowing.
512 * fileio.c (Finsert_file_contents):
513 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
514 * process.c (wait_reading_process_output):
515 Rename inner 'proc' to 'p' to avoid shadowing.
516 Indent for consistency with usual Emacs style.
518 2011-11-25 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (redisplay_window): If cursor row is not fully visible
521 after recentering, and scroll-conservatively is set to a large
522 number, scroll window by a few more lines to make the cursor fully
523 visible and out of scroll-margin. (Bug#10105)
524 (start_display): Don't move to the next line if the display should
525 start at a newline that is part of a display vector or an overlay
528 2011-11-24 Juri Linkov <juri@jurta.org>
530 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
531 after the `MagickPingImage' call. (Bug#10112)
533 2011-11-23 Chong Yidong <cyd@gnu.org>
535 * window.c (Fcoordinates_in_window_p): Accept only live windows.
537 2011-11-23 Martin Rudalics <rudalics@gmx.at>
539 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
540 making another buffer current. (Bug#10114)
542 2011-11-23 Glenn Morris <rgm@gnu.org>
544 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
546 2011-11-23 Chong Yidong <cyd@gnu.org>
548 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
551 2011-11-22 Eli Zaretskii <eliz@gnu.org>
553 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
554 and header-lines, as they don't have one computed for them.
557 * .gdbinit (prow): Make displayed values more self-explaining.
560 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
562 * process.c (wait_reading_process_output): Fix asynchrounous
563 GnuTLS socket handling on some versions of the GnuTLS library.
564 (wait_reading_process_output): Add comment and URL.
566 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
568 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
570 2011-11-21 Chong Yidong <cyd@gnu.org>
572 * window.c (Fnext_window, Fprevious_window): Doc fix.
574 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
576 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
578 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
580 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
582 2011-11-20 Martin Rudalics <rudalics@gmx.at>
584 * window.c (Fset_window_combination_limit): Rename argument
586 (Vwindow_combination_limit): Remove "status" from doc-string.
588 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
590 * m/ibms390.h: Remove.
591 * m/ibms390x.h: Don't include "ibms390.h".
593 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
595 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
596 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
598 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
600 * casetab.c (Fset_case_table):
601 * charset.c (Fcharset_after): Fix typos.
603 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
605 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
606 Otherwise, valgrind does not work on some platforms.
607 Problem reported by Andreas Schwab in
608 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
609 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
610 is set, removing the need for VIRT_ADDRESS_VARIES.
611 (PURE_P): Use a more-efficient implementation that needs just one
612 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
613 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
614 to 4 (xorl, subq, cmpq, setbe).
615 * alloc.c (pure): Always extern now, since that's the
616 VIRT_ADDR_VARIES behavior.
617 (PURE_POINTER_P): Use a single comparison, not two, for
618 consistency with the new puresize.h.
619 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
620 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
621 Remove VIRT_ADDR_VARIES no longer needed.
623 2011-11-19 Eli Zaretskii <eliz@gnu.org>
625 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
626 (erase_phys_cursor, update_window_cursor, show_mouse_face)
627 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
628 behave as if the cursor position were at the window margin.
630 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
631 and the cursor position is out of bounds, behave as if the cursor
632 position were at the window margin. (Bug#10075)
634 2011-11-18 Chong Yidong <cyd@gnu.org>
636 * window.c (Fwindow_combination_limit): Make first argument
637 non-optional, since it is meaningless for live windows like the
640 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
642 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
644 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
646 * intervals.c: Fix grafting over the whole buffer (bug#10071).
647 (graft_intervals_into_buffer): Simplify.
649 2011-11-18 Eli Zaretskii <eliz@gnu.org>
651 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
652 hash values of the two rows.
653 (copy_row_except_pointers): Preserve the used[] arrays and the
654 hash values of the two rows. (Bug#10035)
655 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
657 * xdisp.c (row_hash): New function, body extracted from
658 compute_line_metrics.
659 (compute_line_metrics): Call row_hash, instead of computing the
662 * dispnew.c (verify_row_hash): Call row_hash for computing the
663 hash code of a row, instead of duplicating code from xdisp.c.
665 * dispextern.h (row_hash): Add prototype.
667 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
669 * frame.c (delete_frame): Don't delete the terminal when the last
670 X frame is closed if emacs is built with GTK toolkit.
672 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
674 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
676 2011-11-17 Martin Rudalics <rudalics@gmx.at>
678 * window.c (Vwindow_splits): Rename to
679 Vwindow_combination_resize. Suggested by Juri Linkov.
680 (Fsplit_window_internal): Use Vwindow_combination_resize instead
683 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
685 * nsfns.m (Fns_font_name):
686 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
688 2011-11-16 Martin Rudalics <rudalics@gmx.at>
690 * window.h (window): Rename slot "nest" to "combination_limit".
691 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
692 (Fset_window_nest): Rename to Fset_window_combination_limit.
693 (Vwindow_nest): Rename to Vwindow_combination_limit.
694 (recombine_windows, make_parent_window, make_window)
695 (Fsplit_window_internal, saved_window)
696 (Fset_window_configuration, save_window_save): Rename all
697 occurrences of window_nest to window_combination_limit.
699 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
701 * image.c (imagemagick_load_image): Fix typo.
703 2011-11-14 Eli Zaretskii <eliz@gnu.org>
705 * xdisp.c (display_line): Move the call to
706 highlight_trailing_whitespace before the call to
707 compute_line_metrics, since the latter needs to see the final
708 faces of all the glyphs to compute ROW's hash value.
709 Fixes assertion violations in row_equal_p. (Bug#10035)
711 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
713 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
714 just return (bug#10044).
716 2011-11-12 Eli Zaretskii <eliz@gnu.org>
718 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
719 with user-defined heap size. Bump the default size of the temacs
720 heap to 27MB, to avoid memory warning when running temacs.
721 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
723 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
724 current_matrix and desired_matrix. (Bug#9990)
725 (verify_row_hash) [XASSERTS]: New function.
726 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
727 that the hash value of glyph rows is correct.
729 2011-11-12 Martin Rudalics <rudalics@gmx.at>
731 * window.h (window): Remove splits slot.
732 * window.c (Fwindow_splits, Fset_window_splits): Remove.
733 (Fdelete_other_windows_internal, make_parent_window)
734 (make_window, Fsplit_window_internal, Fdelete_window_internal)
735 (Fset_window_configuration, save_window_save): Don't deal with
736 split status of windows.
737 (saved_window): Remove splits slot.
738 (Vwindow_splits): Rewrite doc-string.
740 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
742 * xfns.c (unwind_create_frame):
743 * nsfns.m (unwind_create_frame):
744 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
745 Vframe_list (Bug#9999).
747 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
749 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
751 2011-11-11 Kenichi Handa <handa@m17n.org>
753 * callproc.c (Fcall_process): Set the member dst_multibyte of
756 2011-11-11 Johan Bockgård <bojohan@gnu.org>
758 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
759 avoid a crash (bug#9496).
761 2011-11-09 Chong Yidong <cyd@gnu.org>
763 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
764 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
766 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
768 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
770 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
772 Avoid some portability problems by eschewing 'extern inline' functions.
773 The trivial performance wins aren't worth the portability hassles; see
774 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
776 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
777 (window_box_width, window_box_left, window_box_left_offset)
778 (window_box_right, window_box_right_offset): Undo previous change,
779 by removing the "extern"s.
780 * intervals.c (adjust_intervals_for_insertion)
781 (adjust_intervals_for_deletion): Undo previous change,
782 making these static again.
783 (offset_intervals, temp_set_point_both, temp_set_point)
784 (copy_intervals_to_string): No longer inline.
785 * xdisp.c (window_text_bottom_y, window_box_width)
786 (window_box_height, window_box_left_offset)
787 (window_box_right_offset, window_box_left, window_box_right)
788 (window_box): No longer inline.
790 2011-11-08 Chong Yidong <cyd@gnu.org>
792 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
793 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
794 Signal an error if not a live window.
795 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
796 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
798 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
800 * lisp.h (syms_of_abbrev): Remove declaration.
801 Reported by CHENG Gao <chenggao@royau.me>.
803 2011-11-07 Eli Zaretskii <eliz@gnu.org>
805 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
806 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
807 of temacs in GUI mode.
809 2011-11-07 Martin Rudalics <rudalics@gmx.at>
811 * window.h: Declare delete_all_child_windows instead of
812 delete_all_subwindows.
813 * window.c (Fwindow_nest, Fset_window_nest)
814 (Fset_window_new_total, Fset_window_new_normal)
815 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
816 (delete_all_subwindows): Rename to delete_all_child_windows.
817 (Fdelete_other_windows_internal, Fset_window_configuration):
818 Call delete_all_child_windows instead of delete_all_subwindows.
819 * frame.c (delete_frame): Call delete_all_child_windows instead
820 of delete_all_subwindows.
822 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
824 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
825 This is also needed for porting to any host where GC_MARK_STACK is
826 not GC_MAKE_GCPROS_NOOPS.
827 (which_symbols): Use it.
829 2011-11-07 Kenichi Handa <handa@m17n.org>
831 * coding.c (coding_set_destination): Check coding->src_pos only
832 when coding->src_object is a buffer (bug#9910).
834 * process.c (send_process): Set the member src_multibyte of coding
835 to 0 (bug#9911) when sending a unibyte text.
837 * callproc.c (Fcall_process): Set the member src_multibyte of
838 process_coding to 0 (bug#9912).
840 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
842 * xmenu.c (cleanup_widget_value_tree): New function.
843 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
844 calling free_menubar_widget_value_tree directly (Bug#9830).
846 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
848 Fix some portability problems with 'inline'.
849 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
850 (window_box_width, window_box_left, window_box_left_offset)
851 (window_box_right, window_box_right_offset): Declare extern.
852 Otherwise, these inline functions do not conform to C99 and
853 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
854 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
855 * intervals.c (adjust_intervals_for_insertion)
856 (adjust_intervals_for_deletion): Now extern, because otherwise the
857 extern inline functions 'offset_intervals' couldn't refer to it.
858 (static_offset_intervals): Remove.
859 (offset_intervals): Rewrite using the old contents of
860 static_offset_intervals. The old version didn't conform to C99
861 because an extern inline function contained a reference to an
862 identifier with static linkage.
864 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
866 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
869 2011-11-06 Eli Zaretskii <eliz@gnu.org>
871 * xdisp.c (init_iterator, reseat_to_string): Don't set the
872 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
873 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
874 return Qleft_to_right.
876 2011-11-06 Chong Yidong <cyd@gnu.org>
878 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
879 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
880 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
881 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
882 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
883 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
884 (Fwindow_vscroll): Doc fix.
885 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
886 argument, since it makes no sense to pass a live window and for
887 consistency with window-child.
889 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
891 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
894 2011-11-05 Jason Rumney <jasonr@gnu.org>
896 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
897 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
899 (add_font_entity_to_list): Fix logic errors in mixed boolean and
900 bitwise arithmetic preventing use of unicode-sip and non-truetype
903 2011-11-05 Eli Zaretskii <eliz@gnu.org>
905 * s/ms-w32.h (fstat, stat, utime): Move redirections to
908 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
909 initialization code to keep similarity to xfns.c after changes
912 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
914 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
915 (unwind_create_frame): New function (Bug#9943).
916 (Fx_create_frame): Restructure code to be more similar to the one in
917 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
918 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
919 Move terminal->reference_count++ just before making the frame official
922 * nsterm.m (x_free_frame_resources): New function.
923 (x_destroy_window): Move code to x_free_frame_resources.
925 * xfns.c (unwind_create_frame): Fix comment.
926 (Fx_create_frame, x_create_tip_frame):
927 Move terminal->reference_count++ just before making the frame
928 official. Move initialization of image_cache_refcount and
929 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
931 2011-11-05 Eli Zaretskii <eliz@gnu.org>
933 Support MSVC build with newer versions of Visual Studio.
934 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
935 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
938 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
939 which are not supported by MSVC.
940 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
941 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
943 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
945 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
947 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
949 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
951 Support MSVC build with newer versions of Visual Studio.
952 * w32.c: Don't include w32api.h for MSVC.
953 (init_environment) [_MSC_VER]: Call sys_access, not _access.
955 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
956 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
957 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
958 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
960 (alloca) [_MSC_VER]: Define to _alloca.
962 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
964 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
966 2011-11-04 Eli Zaretskii <eliz@gnu.org>
968 * xdisp.c (note_mouse_highlight): If either of
969 previous/next-single-property-change returns nil, treat that as
970 the beginning or the end of the buffer. (Bug#9955)
972 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
974 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
975 label is not null (Bug#9951).
976 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
979 2011-11-04 Eli Zaretskii <eliz@gnu.org>
981 * window.c (Fwindow_body_size): Mention in the doc string that the
982 return value is in frame's canonical units. (Bug#9949)
984 2011-11-03 Eli Zaretskii <eliz@gnu.org>
986 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
988 * w32fns.c (unwind_create_frame): If needed, free the glyph
989 matrices of the partially constructed frame. (Bug#9943)
990 * xfns.c (unwind_create_frame): Likewise.
992 2011-11-01 Eli Zaretskii <eliz@gnu.org>
994 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
995 Don't stop backward scan on the continuation glyph, even though
996 its CHARPOS is positive.
997 (mouse_face_from_buffer_pos, note_mouse_highlight):
998 Rename cover_string to disp_string.
1000 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1002 * window.c (temp_output_buffer_show): Don't use
1003 Vtemp_buffer_show_specifiers.
1004 (Vtemp_buffer_show_specifiers): Remove unused variable.
1006 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1008 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1009 past the beginning of the current glyph matrix.
1011 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1013 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1014 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1015 HAVE_GTK3 (Bug#9869).
1017 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1018 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1020 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1022 * xterm.c: Declare x_handle_net_wm_state to return int.
1023 (handle_one_xevent): Check if we are iconified but don't have
1024 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1025 (get_current_wm_state): Return non-zero if not hidden,
1026 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1027 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1028 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1029 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1031 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1033 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1034 so that this new function doesn't get optimized away by a
1035 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1037 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1039 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1041 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1043 Fix the `xbytecode' command.
1044 * .gdbinit (xprintbytestr): New command.
1045 (xwhichsymbols): Rename from `which'; all callers changed.
1046 (xbytecode): Print the byte-code string as well.
1048 2011-10-29 Kim Storm <storm@cua.dk>
1050 * alloc.c (which_symbols): New function.
1052 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1054 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1057 2011-10-29 Glenn Morris <rgm@gnu.org>
1059 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1060 Not clear what it was for, and it causes various bugs. (Bug#9839)
1062 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1064 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1065 possible random value that matches one of those tested as
1066 condition to clear the mouse face.
1068 2011-10-28 Chong Yidong <cyd@gnu.org>
1070 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1072 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1074 * window.c (make_window): Initialize phys_cursor_on_p.
1076 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1078 * lisp.h (struct Lisp_Symbol): Update comments.
1080 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1082 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1084 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1086 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1087 <oslsachem@gmail.com> for helping to debug this.
1089 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1090 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1091 (g_b_init_get_glyph_outline_w): New static variables.
1092 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1093 (GetGlyphOutlineW_Proc): New typedefs.
1094 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1095 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1097 (w32font_open_internal, compute_metrics):
1098 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1099 instead of calling the "wide" APIs directly.
1101 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1103 * w32.h (syms_of_w32font): Add prototype.
1105 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1107 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1108 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1109 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1110 (Fmove_to_window_line): Doc fix.
1112 2011-10-27 Chong Yidong <cyd@gnu.org>
1114 * process.c (make_process): Set gnutls_state to NULL.
1116 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1117 non-NULL, regardless of GNUTLS_INITSTAGE.
1118 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1119 an error. Set process slots as soon as we allocate them.
1121 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1123 2011-10-27 Chong Yidong <cyd@gnu.org>
1125 * gnutls.c (emacs_gnutls_deinit): New function.
1126 Deallocate credentials structures as well as calling gnutls_deinit.
1127 (Fgnutls_deinit, Fgnutls_boot): Use it.
1129 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1130 (deactivate_process): Call emacs_gnutls_deinit.
1132 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1134 * image.c (x_create_x_image_and_pixmap):
1135 * w32.c (sys_rename, w32_delayed_load):
1136 * w32font.c (fill_in_logfont):
1137 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1139 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1141 * w32fns.c (w32_default_color_map): New function,
1142 extracted from Fw32_default_color_map.
1143 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1145 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1147 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1149 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1151 * keyboard.c (test_undefined): New function (bug#9751).
1152 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1154 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1156 * sysdep.c (init_sys_modes): Fix the check for the controlling
1157 terminal (Bug#6649).
1159 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1161 * dispextern.h (struct bidi_it): New member next_en_type.
1163 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1164 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1165 current character, check also for next_en_type being WEAK_EN.
1166 (bidi_resolve_weak): Don't enter the expensive loop if the current
1167 position is before next_en_pos. Record the bidi type of the first
1168 non-ET, non-BN character we find, in addition to its position.
1169 (bidi_level_of_next_char): Invalidate next_en_type when
1170 next_en_pos is over-stepped.
1172 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1174 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1175 * editfns.c: Rewrite current-time-zone so that it invokes
1176 the equivalent of (format-time-string "%Z") to get the time zone name.
1177 This fixes a bug when the time zone name contains characters that
1178 need converting from the system time locale to Emacs internal format.
1179 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1180 that patch fixed format-time-string to do the conversion, but
1181 I forgot to fix current-time-zone.
1182 (format_time_string): New function, containing most of
1183 what Fformat_time_string used to contain.
1184 (Fformat_time_string): Rewrite in terms of format_time_string.
1185 This doesn't change this function's behavior.
1186 (current-time-zone): Rewrite to use format_time_string.
1187 This fixes the bug reported by Michael Schierl in
1188 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1189 Jason Rumney's 2007-06-07 change worked around this bug, but
1191 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1193 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1195 * xdisp.c (start_display): If the character at POS is displayed
1196 via a display vector, reset IT->current.dpvec_index to zero.
1197 (try_window_reusing_current_matrix): If a line ends in a display
1198 vector or the next line starts in a display vector, continue
1199 redrawing the window even though the character position of
1200 start_row was reached.
1203 2011-10-18 Chong Yidong <cyd@gnu.org>
1205 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1206 with nobreak-char-display too.
1208 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1210 Fix part 3 of bug#9771.
1211 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1212 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1213 non-neutral characters if the current character is a paragraph
1214 separator (a.k.a. Newline). This avoids running the same
1215 expensive loop twice, once when we consume the preceding newline
1216 and the other time when the line actually needs to be displayed.
1217 Avoid the loop when we see neutrals on the base embedding level
1218 following a character whose directionality is the same as the
1219 paragraph's. This avoids running the expensive loop when a line
1220 ends in a long sequence of neutrals, like control characters.
1221 Add assertion against STRONG_AL type. Slightly rearrange code
1222 that determines the type of a neutral given the first non-neutral
1224 (bidi_level_of_next_char): Set next_en_pos to zero when
1225 invalidating its info.
1227 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1229 * xdisp.c (push_display_prop): Determine whether to record string
1230 or buffer position by IT->string, not by IT->method. Allow
1231 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1232 (move_it_vertically_backward): Don't look for character position
1233 immediately after the newline when in a continuation line.
1236 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1238 * window.c (coordinates_in_window): Rewrite and delabelize
1239 vertical border check. (Bug#5357) (Bug#9618)
1241 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1243 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1244 errors in XSetWindowBorder (bug#9310).
1246 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1248 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1249 avoid crash when xmalloc overrun checking is enabled.
1251 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1253 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1254 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1255 cursor motion with <left> and <right> arrow keys.
1257 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1258 some callers set that themselves.
1260 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1263 display string and the previous row comes from the same string and
1264 is empty. (Bug#9739) (Bug#9738)
1266 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1268 * doc.c (get_doc_string): Encode file name (bug#9735).
1270 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1272 * bidi.c (bidi_level_of_next_char):
1273 * xdisp.c (get_visually_first_element): Remove old incorrect
1274 comments regarding the Unicode Line Separator character.
1276 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1278 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1280 * alloc.c (Fgc_status): Do not access beyond zombies array
1281 boundary if nzombies > MAX_ZOMBIES.
1282 * alloc.c (dump_zombies): Add missing format specifier.
1284 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1286 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1287 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1289 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1290 Some packages use them to denote characters with modifiers.
1292 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1294 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1295 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1296 matching a pp-number. Rename parameter var to var1.
1298 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1300 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1302 2011-10-08 Glenn Morris <rgm@gnu.org>
1304 * callint.c (Fcall_interactively): Give a more explicit error for the
1305 'c' case with a non-character input. (Bug#8479)
1307 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1309 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1311 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1312 lines that are hscrolled on the left.
1314 * dispnew.c (buffer_posn_from_coords): Account for a possible
1315 presence of header-line. (Bug#4426)
1317 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1319 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1320 Don't advertise functionality which we discourage or doesn't work.
1322 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1324 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1325 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1326 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1327 this makes Emacs dump core during garbage collection on rare
1328 occasions. sizeof is obviously inferior to offsetof here, so
1329 stick with offsetof.
1330 (GC_POINTER_ALIGNMENT): New macro.
1331 (mark_memory): Omit 3rd (offset) arg; caller changed.
1332 Don't assume EMACS_INT alignment is the same as pointer alignment.
1334 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1336 * keyboard.c (read_key_sequence_remapped): New var.
1337 (read_key_sequence): Compute remapping in the right buffer.
1338 (command_loop_1): Use read_key_sequence's remapping directly.
1340 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1342 * dired.c (file_name_completion): Don't expand file name.
1343 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1344 before checking file name handler.
1346 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1347 they've been requested explicitly (bug#9591).
1349 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1351 * keymap.c (Fsingle_key_description): Use make_specified_string
1352 instead of build_string to build string from push_key_description.
1355 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1357 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1358 This fixes a Y2038 bug on 64-bit hosts.
1359 * buffer.c (reset_buffer):
1360 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1361 (Fclear_buffer_auto_save_failure):
1362 Use 0, not -1, to represent an unset failure time, since time_t
1363 might not be signed.
1365 Remove dependency on glibc malloc internals.
1366 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1367 Move back here from lisp.h, but with their new implementations.
1368 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1369 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1370 * charset.c (charset_table_init): New static var.
1371 (syms_of_charset): Use it instead of xmalloc. This removes a
1372 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1373 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1374 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1375 Move back to alloc.c.
1376 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1377 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1379 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1381 * nsterm.m (windowDidResize): Call x_set_window_size only when
1382 ns_in_resize is true. Otherwise set pixelwidth/height and
1383 call change_frame_size (Bug#9628).
1385 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1387 Port --enable-checking=all to Fedora 14 x86-64.
1388 * charset.c (syms_of_charset): Also account for glibc malloc's
1389 internal overhead when calculating the initial malloc maximum.
1391 Port --enable-checking=all to Fedora 14 x86.
1392 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1394 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1395 (overrun_check_realloc, overrun_check_free):
1396 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1397 That way, xmalloc returns a properly-aligned pointer even if
1398 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1399 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1400 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1401 into account when calculating the initial malloc maximum.
1402 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1403 Move here from alloc.c, so that charset.c can use it too.
1404 Properly align; the old code wasn't right for common 32-bit hosts
1405 when configured with --enable-checking=all.
1406 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1407 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1409 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1411 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1414 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1416 * xdisp.c (compute_display_string_end): If there's no display
1417 string at CHARPOS, return -1.
1419 * bidi.c (bidi_fetch_char): When compute_display_string_end
1420 returns a negative value, treat the character as a normal
1421 character not covered by a display string. (Bug#9624)
1423 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1425 * lread.c (Fread_from_string): Fix typo in docstring.
1427 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1429 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1430 newline, reseat the iterator instead of bidi-iterating there one
1431 character at a time. (Bug#9610)
1432 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1433 TO_CHARPOS if the bidi iterator is at base embedding level.
1435 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1437 * lread.c (readevalloop): Use correct code for NBSP.
1438 (read1): Likewise. (Bug#9608)
1440 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1442 * dbusbind.c (Fdbus_register_signal): When service is not
1443 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1445 2011-09-25 Glenn Morris <rgm@gnu.org>
1447 * buffer.c (truncate-lines): Doc fix.
1449 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1451 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1452 (Fset_window_next_buffers): Doc fix.
1454 2011-09-24 Glenn Morris <rgm@gnu.org>
1456 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1458 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1460 Fix minor problems found by static checking.
1461 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1462 * indent.c (Fvertical_motion): Fix == vs = typo.
1464 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1466 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1467 Default value is now t. Doc fix.
1469 * indent.c (Fvertical_motion): Compute and apply the overshoot
1470 logic when moving up, not only when moving down. Fix the
1471 confusing name and values of the it_overshoot_expected variable;
1472 logic changes accordingly. (Bug#9254) (Bug#9549)
1474 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1475 CHARPOS is covered by a display string which includes newlines.
1476 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1477 is covered by a display string with embedded newlines.
1479 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1481 * dbusbind.c (Fdbus_register_signal): Add match rule to
1482 Vdbus_registered_objects_table. (Bug#9581)
1483 (Fdbus_register_method, Vdbus_registered_objects_table):
1486 2011-09-24 Jim Meyering <meyering@redhat.com>
1488 do not ignore write error for any output size
1489 The previous change was incomplete.
1490 While it makes emacs --batch detect the vast majority of stdout
1491 write failures, errors were still ignored whenever the output size is
1492 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1493 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1494 && echo FAIL: ignored write error
1495 FAIL: ignored write error
1496 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1497 && echo FAIL: ignored write error
1498 FAIL: ignored write error
1499 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1501 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1503 * emacs.c (Fkill_emacs): In noninteractive mode exit
1504 non-successfully if a write error occurred on stdout. (Bug#9574)
1506 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1508 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1511 * dispextern.h (struct it): Update the comment documenting what
1514 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1516 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1517 a display string, extend search for cursor position to end of row.
1518 (find_row_edges): If the row ends in a newline from a display
1519 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1520 Handle the case of a display string with multiple newlines.
1521 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1522 non-empty line. Fixes confusing cursor motion with arrow keys at
1523 the beginning of a line that starts with whitespace.
1525 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1527 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1530 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1532 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1535 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1537 * xdisp.c (display_line): Record maximum and minimum buffer
1538 positions even if no glyphs were produced (e.g., by a zero-width
1539 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1540 buffer positions that will be removed from the glyph row because
1542 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1543 column is beyond frame width: don't subtract 1 "pixel" when
1544 computing width of the stretch.
1545 (reseat_at_next_visible_line_start): Undo the change made on
1546 2011-09-17 that saved paragraph information and restored it after
1547 the call to `reseat'. (Bug#9545)
1549 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1551 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1552 and turn window cursor on if cleared (Bug#9415).
1554 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1556 * search.c (boyer_moore): Take unibyte characters from pattern
1557 literally. (Bug#9458)
1559 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1561 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1563 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1565 Fix minor problem found by static checking.
1566 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1567 initialized, to pacify gcc -Wuninitialized.
1569 * fileio.c: Report proper errno when syscall falls.
1570 (Finsert_file_contents): Save and restore errno,
1571 so that report_file_error outputs the correct diagnostic.
1572 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1574 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1576 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1578 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1580 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1581 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1583 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1585 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1586 about the current paragraph and restore it after the call to reseat.
1588 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1589 (bidi_find_paragraph_start): Search back for paragraph beginning
1590 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1591 (bidi_move_to_visually_next): Only trigger paragraph-related
1592 computations when the last character is a newline or at EOB, not
1593 just any NEUTRAL_B. (Bug#9470)
1595 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1596 truncated lines if point is covered by a display string. (Bug#9524)
1598 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1600 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1601 (cons_to_x_long): New function.
1602 (lisp_data_to_selection_data): Use it. Correct the test for
1603 short-versus-long data; it was negated. Break out of vector
1604 loop, for efficiency, when a long datum is discovered.
1606 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1610 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1612 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1613 GCC PR/17406) by declaring this function with external scope.
1615 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1617 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1618 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1620 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1622 * editfns.c (Fformat): Correctly handle text properties on "%%".
1624 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1626 * xterm.c (x_draw_composite_glyph_string_foreground):
1627 * w32term.c (x_draw_composite_glyph_string_foreground):
1628 * term.c (encode_terminal_code):
1629 * composite.c (composition_update_it, get_composition_id):
1630 * xdisp.c (get_next_display_element)
1631 (fill_composite_glyph_string): Add comments about special meaning
1632 of TAB characters in a composition.
1634 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1636 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1637 This occurs when processing a multibyte format.
1638 Problem reported by Wolfgang Jenker.
1640 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1642 * xdisp.c (try_cursor_movement): Only check for exact match if
1643 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1645 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1647 Remove unused external symbols.
1648 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1649 * xdisp.c (calc_pixel_width_or_height): Now static.
1650 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1651 * indent.c (check_display_width):
1652 * w32term.c: Fix comment to match code.
1653 * xterm.c, xterm.h (x_catching_errors): Remove.
1655 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1657 * xselect.c: Use signed conversions more consistently (Bug#9498).
1658 (selection_data_to_lisp_data): Assume incoming selection data are
1659 signed integers, not unsigned. This is to be consistent with
1660 outgoing selection data, which was modified to use signed integers
1661 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1662 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1663 expects long, not unsigned long.
1665 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1667 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1668 computation of loop end. Reported by Johan Bockgård
1671 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1673 * frame.c (Fother_visible_frames_p): Function deleted.
1675 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1677 * indent.c (compute_motion): Process display vector front to back
1678 rather than the other way around. (Bug#2496)
1680 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1682 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1684 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1686 * minibuf.c (Fread_from_minibuffer): Doc fix.
1688 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1690 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1691 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1693 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1695 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1696 value for non-existent files.
1698 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1700 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1701 set its "size" to -1. This will set the modtime_size field of
1702 the corresponding buffer to -1, which is what
1703 verify-visited-file-modtime expects for files that do not exist.
1706 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1708 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1710 * lisp.h: ... from here. push_key_description is no longer
1711 defined in keyboard.c, so its declaration should not be in
1712 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1713 logically belongs with push_key_description.
1715 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1717 * buffer.h: Include <sys/types.h> instead of <time.h>.
1718 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1719 Problem reported by Herbert J. Skuhra.
1721 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1723 * xml.c (parse_region): Make the parsing work for
1724 non-comment-starting XML files again (bug#9144).
1726 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1728 * image.c (gif_load): Fix calculation of bottom and right corner.
1731 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1734 redisplay in small windows.
1736 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1738 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1740 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1742 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1743 Operate on live windows only.
1745 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1747 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1749 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1751 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1752 only under bidi iteration.
1754 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1756 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1758 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1760 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1761 Without this fix, the command to link temacs failed due to an
1762 undefined symbol __builtin_isnan. This is because
1763 /usr/include/iso/math_c99.h #defines isnan(x) to
1764 __builtin_isnan(x), but the bundled gcc, which identifies itself
1765 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1767 * floatfns.c (isnan): #undef, and then #define to a clone of
1769 (Fisnan): Always define, since it's always available now.
1770 (syms_of_floatfns): Always define isnan at the Lisp level.
1772 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1774 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1776 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1778 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1779 The previous code assumed that file offsets (off_t values) fit in
1780 EMACS_INT variables, which is not true on typical 32-bit hosts.
1781 The code messed up by falsely reporting buffer overflow in cases
1782 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1783 when "big" contains more than 2**29 bytes, even though this
1784 inserts just one byte and does not overflow the buffer.
1785 (Finsert_file_contents): Store file offsets as off_t
1786 values, not as EMACS_INT values. Check for overflow when
1787 converting between EMACS_INT and off_t. When checking for
1788 buffer overflow or for overlap, take the offsets into account.
1789 Don't use EMACS_INT for small values where int suffices.
1790 When checking for overlap, fix a typo: ZV was used where
1791 ZV_BYTE was intended.
1792 (Fwrite_region): Don't assume off_t fits into 'long'.
1793 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1795 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1797 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1799 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1801 sprintf-related integer and memory overflow issues (Bug#9412).
1803 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1804 (esprintf, exprintf, evxprintf): New functions.
1805 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1806 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1807 (modify_event_symbol): Do not assume that the length of
1808 name_alist_or_stem is safe to alloca and fits in int.
1809 (Fexecute_extended_command): Likewise for function name and binding.
1810 (Frecursion_depth): Wrap around reliably on integer overflow.
1811 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1812 since some callers pass EMACS_INT values.
1813 (Fsingle_key_description): Don't crash if symbol name contains more
1814 than MAX_ALLOCA bytes.
1815 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1816 (get_minibuffer): Arg is now EMACS_INT, not int.
1817 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1818 (esprintf, exprintf, evxprintf): New decls.
1819 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1821 * dbusbind.c (signature_cat): New function.
1822 (xd_signature, Fdbus_register_signal):
1823 Do not overrun buffer; instead, report string overflow.
1825 * dispnew.c (add_window_display_history): Don't overrun buffer.
1826 Truncate instead; this is OK since it's just a log.
1828 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1829 even if the time zone offset is outlandishly large.
1830 Don't mishandle offset == INT_MIN.
1832 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1833 when creating daemon; the previous buffer-overflow check was incorrect.
1835 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1836 which has the guts of the old verror function.
1838 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1839 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1841 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1842 (font_unparse_xlfd): Don't blindly alloca long strings.
1843 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1844 fits in int, when using sprintf. Use single snprintf to count
1845 length of string rather than counting it via multiple sprintfs;
1846 that's simpler and more reliable.
1847 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1848 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1849 sprintf, in case result does not fit in int.
1851 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1852 (fontset_from_font): Print it.
1854 * frame.c (tty_frame_count): Now printmax_t, not int.
1855 (make_terminal_frame, set_term_frame_name): Print it.
1856 (x_report_frame_params): In X, window IDs are unsigned long,
1857 not signed long, so print them as unsigned.
1858 (validate_x_resource_name): Check for implausibly long names,
1859 and don't assume name length fits in 'int'.
1860 (x_get_resource_string): Don't blindly alloca invocation name;
1861 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1864 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1865 (xg_check_special_colors, xg_set_geometry):
1866 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1868 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1869 Use esprintf, not sprintf, in case result does not fit in int.
1871 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1872 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1873 it as a large positive number.
1874 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1875 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1877 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1878 in case result does not fit in int.
1880 * print.c (float_to_string): Detect width overflow more reliably.
1881 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1882 buffer overrun. Don't assume list length fits in 'int'. Treat
1883 print length of 0 as 0, not as infinity; to be consistent with other
1884 uses of print length in this function. Don't overflow print length
1885 index. Don't assume hash table size fits in 'long', or that
1886 vectorlike size fits in 'unsigned long'.
1888 * process.c (make_process): Use printmax_t, not int, to format
1889 process-name gensyms.
1891 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1893 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1894 to avoid potential buffer overrun.
1896 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1897 if X resource line is longer than 512 bytes.
1899 * xfns.c (x_window): Make sprintf buffer a bit bigger
1900 to avoid potential buffer overrun.
1902 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1904 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1906 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1908 Integer overflow fixes for scrolling, etc.
1909 Without these, Emacs silently mishandles large integers sometimes.
1910 For example, "C-u 4294967297 M-x recenter" was treated as if
1911 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1913 * xdisp.c (try_window_id): Check Emacs fixnum range before
1914 converting to 'int'.
1916 * window.c (window_scroll_line_based, Frecenter):
1917 Check that an Emacs fixnum is in range before assigning it to 'int'.
1918 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1919 values converted from Emacs fixnums.
1920 (Frecenter): Don't wrap around a line count if it is out of 'int'
1921 range; instead, treat it as an extreme value.
1922 (Fset_window_configuration, compare_window_configurations):
1923 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1925 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1926 that can exceed INT_MAX. Check that EMACS_INT value is in range
1927 before assigning it to the (possibly-narrower) index.
1928 (match_limit): Don't assume that a fixnum can fit in 'int'.
1930 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1933 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1934 (Fvertical_motion): Don't wrap around LINES values that don't fit
1935 in 'int'. Instead, treat them as extreme values. This is good
1936 enough for windows, which can't have more than INT_MAX lines anyway.
1938 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940 * Require libxml/parser.h to avoid compilation warning.
1942 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1944 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1945 since this reportedly can destroy thread storage.
1947 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1949 * syntax.c (find_defun_start): Update all cache variables if
1950 exiting early (Bug#9401).
1952 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1954 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1956 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1957 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1958 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1960 * term.c (tty_append_glyph): New function.
1961 (produce_stretch_glyph): Static function and its prototype deleted.
1963 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1966 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1968 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1969 when checking :margin (Bug#9390).
1970 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1971 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1972 so that the name doesn't mislead. All uses changed.
1974 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1976 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1979 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (move_it_to): Don't bail out early when reaching
1982 position beyond to_charpos, if we are scanning backwards.
1983 (move_it_vertically_backward): When DY == 0, make sure we get to
1984 the first character in the line after the newline.
1986 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1988 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1989 (ccl_driver): Do not generate an out-of-range pointer.
1990 (Fccl_execute_on_string): Remove unnecessary check for
1991 integer overflow, noted by Stefan Monnier in
1992 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1993 Remove a FIXME that didn't need fixing.
1994 Simplify the newly-introduced buffer reallocation code.
1996 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1998 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2000 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2002 Integer and memory overflow issues (Bug#9196).
2004 * doc.c (get_doc_string): Rework so that
2005 get_doc_string_buffer_size is the actual buffer size, rather than
2006 being 1 less than the actual buffer size; this makes xpalloc more
2009 * image.c (x_allocate_bitmap_record, cache_image):
2010 * xselect.c (Fx_register_dnd_atom):
2011 Simplify previous changes by using xpalloc.
2013 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2014 since either will do and ptrdiff_t is convenient with xpalloc.
2016 * charset.c (charset_table_size)
2017 (struct charset_sort_data.priority): Now ptrdiff_t.
2018 (charset_compare): Don't overflow if priorities differ greatly.
2019 (Fsort_charsets): Don't assume list length fits in int.
2020 Check for size-calculation overflow when allocating sort data.
2021 (syms_of_charset): Allocate an initial charset table that is
2022 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2024 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2026 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2027 The actual value is always <= INT_MAX, and leaving it unsigned made
2028 overflow checking harder.
2030 * dispextern.h (struct glyph_matrix.rows_allocated)
2031 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2032 with xpalloc. The values are still always <= INT_MAX.
2034 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2036 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2037 (SAFE_NALLOCA): New macro.
2039 * region-cache.c (struct boundary.pos, find_cache_boundary)
2040 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2041 (set_cache_region, invalidate_region_cache)
2042 (revalidate_region_cache, know_region_cache, region_cache_forward)
2043 (region_cache_backward, pp_cache):
2044 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2045 so that ptrdiff_t * can be passed to xpalloc.
2046 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2047 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2048 (pp_cache): Don't assume cache_len fits in int.
2049 * region-cache.h: Adjust extern decls to match.
2051 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2052 EMACS_INT, since either will do, for xpalloc.
2054 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2055 (xnmalloc, xnrealloc, xpalloc): New functions.
2057 * bidi.c (bidi_shelve_header_size): New constant.
2058 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2059 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2061 * bidi.c (bidi_cache_shrink):
2062 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2064 Don't update size of array until after memory allocation succeeds,
2065 because xmalloc/xrealloc may not return.
2066 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2067 now that we have proper integer overflow checking.
2068 (record_overlay_string, overlay_strings): Catch overflows when
2069 calculating size of overlay_str_buf.
2071 * callproc.c (Fcall_process): Check for size overflow when
2072 calculating size of args2.
2073 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2074 Normally we prefer signed values, but sticking with ptrdiff_t would
2075 require adding more-complicated checks.
2077 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2078 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2079 Redo buffer-overflow calculations to avoid integer overflow.
2080 Add a FIXME comment where memory seems to be over-allocated.
2082 * character.c (Fstring): Check for size-calculation overflow.
2084 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2085 unnecessary integer overflow. Check for size overflow.
2086 (encode_coding_object): Don't update size until xmalloc succeeds.
2088 * composite.c (get_composition_id): Check for overflow in glyph
2089 length calculations.
2091 Integer and memory overflow fixes for display code.
2092 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2093 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2094 (scrolling_window): Check for overflow in size calculations.
2095 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2096 Don't assume glyph table len fits in int.
2097 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2098 (row_table_size): Now ptrdiff_t, not int.
2099 (scrolling_window): Avoid overflow in size calculations.
2100 Don't update size until allocation succeeds.
2101 * fns.c (concat): Check for overflow in size calculations.
2102 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2103 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2104 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2106 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2107 (get_doc_string): Check for size calculation overflow.
2108 Don't update size until allocation succeeds.
2109 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2110 EMACS_INT, where ptrdiff_t will do.
2111 (Fsubstitute_command_keys): Check for string overflow.
2113 * editfns.c (set_time_zone_rule): Don't assume environment length
2115 (message_length): Now ptrdiff_t, not int.
2116 (Fmessage_box): Don't update size until allocation succeeds.
2117 Don't assume message length fits in int.
2118 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2120 * emacs.c (main): Do not reallocate argv, since there is a null at
2121 the end that can be overwritten, and this way there's no need to
2122 worry about size-calculation overflow.
2123 (sort_args): Check for size-calculation overflow.
2125 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2127 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2129 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2130 (x_set_scroll_bar_width, x_figure_window_size):
2131 Check for integer overflow.
2132 (x_set_alpha): Do not assume XINT fits in int.
2134 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2135 This is for the members text_lines, text_cols, total_lines, total_cols,
2136 where the system imposes an 'int' limit.
2138 * fringe.c (Fdefine_fringe_bitmap):
2139 Don't update size until alloc works.
2141 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2142 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2144 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2145 Check for size-calculation overflow.
2146 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2147 do, as we prefer signed integers.
2148 (id_to_widget.max_size, id_to_widget.used)
2149 (xg_store_widget_in_map, xg_remove_widget_from_map)
2150 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2151 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2152 Use and return ptrdiff_t, not int.
2153 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2154 * gtkutil.h: Change prototypes to match the above.
2156 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2157 are duplicate now that they've been promoted to lisp.h.
2158 (x_allocate_bitmap_record, x_alloc_image_color)
2159 (make_image_cache, cache_image, xpm_load):
2160 Don't update size until alloc is done.
2161 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2163 Check for size calculation overflow.
2164 (ct_colors_allocated_max): New constant.
2165 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2168 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2169 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2170 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2171 Use ptrdiff_t, not int, to count maps.
2172 (read_char_minibuf_menu_prompt): Check for overflow in size
2173 calculations. Don't update size until allocation succeeds.
2174 Redo calculations to avoid overflow.
2175 * keyboard.h: Change prototypes to match the above.
2177 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2179 (current_minor_maps): Check for size calculation overflow.
2180 * keymap.h: Change prototypes to match the above.
2182 * lread.c (read1, init_obarray): Don't update size until alloc done.
2184 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2185 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2187 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2188 Now ptrdiff_t, not int.
2189 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2190 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2192 * process.c (Fnetwork_interface_list): Check for overflow
2193 in size calculation.
2195 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2197 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2198 overflow. Don't bother calling xmalloc when xrealloc will do.
2200 * search.c (Freplace_match): Check for size calculation overflow.
2201 (Fset_match_data): Don't assume list lengths fit in 'int'.
2203 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2204 for command line length. Do not attempt to address one before the
2205 beginning of an array, as that's not portable.
2207 * term.c (max_frame_lines): Remove; unused.
2208 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2210 (encode_terminal_code, calculate_costs): Check for size
2211 calculation overflow.
2212 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2213 table lengths and related sizes. Don't update size until alloc
2214 done. Redo calculations to avoid overflow.
2215 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2217 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2218 subtracting pointers.
2219 (gobble_line): Check for overflow more carefully. Don't update size
2222 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2223 Don't update size until alloc done.
2224 Redo size calculations to avoid overflow.
2225 Check for size calculation overflow.
2226 (main) [DEBUG]: Fix typo in invoking tparam1.
2228 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2229 Use ptrdiff_t, not int, for sizes.
2230 (store_mode_line_noprop_char): Don't update size until alloc done.
2232 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2233 Use ptrdiff_t, not int, for sizes.
2234 (Finternal_make_lisp_face, cache_face):
2235 Check for size calculation overflow.
2236 (cache_face): Treat size calculation overflows as if they were
2237 memory exhaustion (the usual treatment), rather than aborting.
2239 * xfns.c (x_encode_text, x_set_name_internal)
2240 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2241 sizes, since they can exceed INT_MAX in size. Check for size
2242 calculation overflow.
2244 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2245 (xg_select): Check for size calculation overflow.
2246 Don't update size until alloc done.
2248 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2249 as sprintf is limited to int lengths.
2251 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2252 (X_LONG_MIN): New macros.
2253 Use them to make the following changes clearer.
2254 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2255 This change doesn't affect the value now, but it may help remind
2256 future maintainers not to raise the value too much later.
2257 (SELECTION_QUANTUM): Remove, replacing with ...
2258 (selection_quantum): ... new function, which avoids overflow.
2260 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2261 assumption that selection length fits in 'int'.
2262 (x_reply_selection_request, x_handle_selection_request)
2263 (x_get_window_property, receive_incremental_selection)
2264 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2265 (lisp_data_to_selection_data, clean_local_selection_data):
2266 Use ptrdiff_t, not int, to record length of selection.
2267 (x_reply_selection_request, x_get_window_property)
2268 (receive_incremental_selection, x_property_data_to_lisp):
2269 Redo calculations to avoid overflow.
2270 (x_reply_selection_request): When sending hint, ceiling it at
2271 X_LONG_MAX rather than relying on wraparound overflow to send
2273 (x_get_window_property, receive_incremental_selection)
2274 (lisp_data_to_selection_data, x_property_data_to_lisp):
2275 Check for size-calculation overflow.
2276 (x_get_window_property, receive_incremental_selection)
2277 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2278 Don't store size until memory allocation succeeds.
2279 (x_get_window_property): Plug memory leak on memory exhaustion.
2280 Don't double-block input; malloc is safe here. Don't assume 2**34
2281 - 4 fits in unsigned long. Add an xassert to check
2282 XGetWindowProperty overflow. Be more careful about overflow
2283 calculations, and distinguish size from memory overflow better.
2284 (receive_incremental_selection): When tracing, don't assume
2285 unsigned int is less than INT_MAX.
2286 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2287 harmful) conversions of unsigned short to int.
2288 (lisp_data_to_selection_data): Don't assume that integers
2289 in the range -65535 through -1 fit in an X unsigned short.
2290 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2291 result parameters unless successful. Rely on cons_to_unsigned
2292 to report problems with elements; the old code wasn't right anyway.
2293 (x_check_property_data): Check for int overflow; we cannot use
2294 a wider type due to X limits.
2295 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2297 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2299 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2300 (x_term_init): Check for size calculation overflow.
2301 (x_color_cells): Don't store size until memory allocation succeeds.
2302 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2303 Don't assume alloca size is less than MAX_ALLOCA.
2304 (x_term_init): Don't assume length fits in int (sprintf is limited
2307 Use ptrdiff_t for composition IDs.
2308 * character.c (lisp_string_width):
2309 * composite.c (composition_table_size, n_compositions)
2310 (get_composition_id, composition_gstring_from_id):
2311 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2312 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2313 * window.c (Frecenter):
2314 Use ptrdiff_t, not int, for composition IDs.
2315 * composite.c (get_composition_id): Check for integer overflow.
2316 * composite.h: Adjust prototypes to match the above changes.
2318 Use ptrdiff_t for hash table indexes.
2319 * category.c (hash_get_category_set):
2320 * ccl.c (ccl_driver):
2321 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2322 * coding.c (coding_system_charset_list, detect_coding_system):
2323 * coding.h (struct coding_system.id):
2324 * composite.c (get_composition_id, gstring_lookup_cache):
2325 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2326 * image.c (xpm_get_color_table_h):
2327 * lisp.h (hash_lookup, hash_put):
2328 * minibuf.c (Ftest_completion):
2329 Use ptrdiff_t for hash table indexes, not int (which is too
2330 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2331 32-bit --with-wide-int hosts).
2333 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2334 Add a FIXME comment about memory leaks.
2335 (syms_of_charset): Don't assume xmalloc returns.
2337 Don't assume that stated character widths fit in int.
2338 * character.c (Fchar_width, c_string_width, lisp_string_width):
2339 * character.h (CHAR_WIDTH):
2340 * indent.c (MULTIBYTE_BYTES_WIDTH):
2341 Use sanitize_char_width to avoid undefined and/or bad behavior
2342 with outlandish widths.
2343 * character.h (sanitize_tab_width): Rename from sanitize_width,
2344 now that we have two such functions. All uses changed.
2345 (sanitize_char_width): New inline function.
2347 Don't assume that tab-width fits in int.
2348 * character.h (sanitize_width): New inline function.
2349 (SANE_TAB_WIDTH): New macro.
2350 (ASCII_CHAR_WIDTH): Use it.
2351 * indent.c (sane_tab_width): Remove. All uses replaced by
2352 SANE_TAB_WIDTH (current_buffer).
2353 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2355 * fileio.c: Integer overflow issues with file modes.
2356 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2358 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2359 Remove unreachable code.
2360 (read_hex, load_charset_map_from_file): Check for integer overflow.
2362 * xterm.c: don't go over XClientMessageEvent limit
2363 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2364 (x_send_scroll_bar_event): Likewise. Check that the size does not
2365 exceed limits imposed by XClientMessageEvent, as well as the usual
2366 ptrdiff_t and size_t limits.
2368 * keyboard.c: Overflow, signedness and related fixes.
2369 (make_lispy_movement): Use same integer type in forward decl
2370 that is used in the definition.
2371 (read_key_sequence, keyremap_step):
2372 Change bufsize argument back to int, undoing my 2011-03-30 change.
2373 We prefer signed types, and int is wide enough here.
2374 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2375 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2376 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2377 length, not size_t. Use ptrdiff_t for index, not int.
2378 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2379 possibility of integer overflow.
2381 Overflow, signedness and related fixes for images.
2383 * dispextern.h (struct it.stack[0].u.image.image_id)
2384 (struct_it.image_id, struct image.id, struct image_cache.size)
2385 (struct image_cache.used, struct image_cache.ref_count):
2386 * gtkutil.c (update_frame_tool_bar):
2387 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2388 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2389 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2390 * nsmenu.m (update_frame_tool_bar):
2391 * xdisp.c (calc_pixel_width_or_height):
2392 * xfns.c (image_cache_refcount):
2393 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2394 on typical 64-bit hosts.
2396 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2397 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2398 Omit unnecessary casts to int.
2399 (parse_image_spec): Check that integers fall into 'int' range
2400 when the callers expect that.
2401 (image_ascent): Redo ascent calculation to avoid int overflow.
2402 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2403 (lookup_image): Remove unnecessary tests.
2404 (xbm_image_p): Locals are now of int, not EMACS_INT,
2405 since parse_image_check makes sure they fit into int.
2406 (png_load, gif_load, svg_load_image):
2407 Prefer int to unsigned where either will do.
2408 (tiff_handler): New function, combining the cores of the
2409 old tiff_error_handler and tiff_warning_handler.
2410 This function is rewritten to use vsnprintf and thereby avoid
2411 stack buffer overflows. It uses only the features of vsnprintf
2412 that are common to both POSIX and native Microsoft.
2413 (tiff_error_handler, tiff_warning_handler): Use it.
2414 (tiff_load, gif_load, imagemagick_load_image):
2415 Don't assume :index value fits in 'int'.
2416 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2417 (imagemagick_load_image): Check that crop parameters fit into
2418 the integer types that MagickCropImage accepts. Don't assume
2419 Vimagemagick_render_type has a nonnegative value. Don't assume
2420 size_t fits in 'long'.
2421 (gs_load): Use printmax_t to print the widest integers possible.
2422 Check for integer overflow when computing image height and width.
2424 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2426 * xdisp.c (redisplay_window): Don't force window start if point
2427 will be invisible in the resulting window. (Bug#9324)
2429 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2431 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2432 the display spec is of the form `(space ...)'.
2433 (handle_display_spec): Return the value returned by
2434 handle_single_display_spec, not just 1 or zero.
2435 (handle_single_display_spec): If the display spec is of the form
2436 `(space ...)', and specifies display in the text area, return 2
2438 (try_cursor_movement): Check for the need to scroll more
2439 accurately, and prefer exact match for point under bidi.
2440 Don't advance `row' beyond the last row of the window.
2442 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2443 into disp_prop; all users changed.
2445 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2446 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2447 for the text covered by the display property.
2449 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2451 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2452 Change return value to nil.
2453 (Frecord_buffer): Delete unused function.
2455 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2457 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2458 buffers, return left-to-right.
2459 (set_cursor_from_row): Consider candidate row a win if its glyph
2460 represents a newline and point is on that newline. Fixes cursor
2461 positioning on the newline at EOL of R2L text within L2R
2462 paragraph, and vice versa.
2463 (try_cursor_movement): Check continued rows, in addition to
2464 continuation rows. Fixes unwarranted scroll when point enters a
2465 continued line of R2L text within an L2R paragraph, or vice versa.
2466 (cursor_row_p): Consider the case of point being equal to
2467 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2468 from the end of a short line to the beginning of a continued line
2469 of R2L text within L2R paragraph.
2470 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2471 composed characters.
2473 * bidi.c (bidi_check_type): Use xassert.
2474 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2477 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2479 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2482 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2484 * nsfont.m (ns_otf_to_script): Fix typo.
2486 2011-08-22 Kenichi Handa <handa@m17n.org>
2488 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2489 extra slot even if the purpose is char-code-property-table.
2491 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2493 * xdisp.c (redisplay_window): When computing centering_position,
2494 account for the height of the header line. (Bug#8874)
2496 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2497 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2498 candidate is selected by the mouse, and that candidate has a
2499 composed character under the mouse.
2501 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2502 coordinates reported by pos-visible-in-window-p for a composed
2503 character in column zero.
2505 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2507 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2509 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2511 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2512 consider it a hit if to_charpos is anywhere in the range of the
2513 composed buffer positions.
2515 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2517 * image.c (gif_load): Don't assume that each subimage has the same
2518 dimensions as the base image. Handle disposal method that is
2519 "undefined" by the gif spec (Bug#9335).
2521 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2523 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2524 (Fcondition_case): Document `debug' symbol in error handler.
2526 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2528 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2529 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2530 from an Org mode buffer to a Speedbar frame.
2532 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2533 a composition, take its buffer position from IT->cmp_it.charpos.
2534 Fixes cursor positioning at the beginning of a line that begins
2535 with a composed character.
2537 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2539 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2540 character bidirectional type, use STRONG_L instead. Fixes crashes
2541 in a buffer produced by `describe-categories'.
2543 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2544 members before the level stack, so they would be saved and
2545 restored when copying iterator state. Fixes incorrect reordering
2546 around TABs covered by display properties.
2548 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2550 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2552 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2554 * eval.c (internal_condition_case, internal_condition_case_1)
2555 (internal_condition_case_2, internal_condition_case_n):
2556 Remove unnecessary aborts (Bug#9081).
2558 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2560 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2561 has no `load' handler, try opening the file locally. (Bug#9311)
2563 2011-08-16 Ken Brown <kbrown@cornell.edu>
2565 * gmalloc.c: Expand comment.
2567 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2569 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2570 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2572 2011-08-16 Ken Brown <kbrown@cornell.edu>
2574 Fix memory allocation problems in Cygwin build (Bug#9273).
2576 * unexcw.c ( __malloc_initialized): Declare external variable.
2577 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2579 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2581 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2583 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2585 [CYGWIN] (special_realloc): New function.
2586 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2587 requests to realloc storage in the static heap.
2589 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2591 * bidi.c (bidi_initialize): Remove unused local.
2593 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2596 * biditype.h: Remove file.
2597 * makefile.w32-in ($(BLD)/bidi.$(O)):
2598 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2600 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2602 * chartab.c: Improve commentary for the uniprop_table API.
2604 * bidi.c (bidi_paragraph_init): Support zero value of
2605 bidi_ignore_explicit_marks_for_paragraph_level.
2606 (bidi_initialize): Use uniprop_table instead of including
2607 biditype.h and bidimirror.h.
2609 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2610 coordinates of the iterator when restoring from ppos_it.
2613 2011-08-14 Kenichi Handa <handa@m17n.org>
2615 * process.c (create_process): Call setup_process_coding_systems
2616 after the pid of the process is set to -1 (Bug#8162).
2618 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2620 * xdisp.c (move_it_in_display_line_to): Don't invoke
2621 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2622 ppos_it. Fixes vertical cursor motion when line beginning is
2623 covered by an image. (Bug#9296)
2625 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2627 * nsterm.h (ns_run_ascript): Declare.
2628 (NSAPP_DATA2_RUNASSCRIPT): Define.
2630 * nsfns.m (as_script, as_result, as_status): New static variables.
2631 (ns_run_ascript): New function.
2632 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2633 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2634 the event loop. Get status from as_status (Bug#7276).
2636 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2637 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2638 the event loop (Bug#7276).
2640 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2642 * gnutls.c (QCgnutls_bootprop_priority)
2643 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2644 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2645 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2646 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2647 (QCgnutls_bootprop_verify_hostname_error)
2648 (QCgnutls_bootprop_callbacks_verify): Rename from
2649 Qgnutls_bootprop_..., all uses changed.
2651 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2654 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2656 * xfaces.c (Qframe_set_background_mode): Now static.
2657 * dispextern.h (Qframe_set_background_mode): Remove decl.
2659 * process.c (Fnetwork_interface_info): Declare local only if needed.
2661 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2663 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2664 (Fnetwork_interface_list): Allocate in increments of bytes instead
2665 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2666 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2668 (struct ifflag_def): notrailers is smart on OSX.
2669 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2670 Get hardware address with getifaddrs if available.
2672 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2674 * xdisp.c (iterate_out_of_display_property): xassert that
2675 IT->position is set to within IT->object's boundaries. Break from
2676 the loop as soon as EOB is reached; avoids infloops in redisplay
2677 when IT->position is set up wrongly due to some bug.
2678 Set IT->current to match the bidi iterator unconditionally.
2679 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2680 entry. Force push_it to save on the stack the current
2681 buffer/string position, to be restored by pop_it. Fix flags in
2682 the iterator structure wrt the object coming from a display
2683 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2684 properties. (Bug#9284)
2686 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2688 * fontset.c (fontset_get_font_group): Add proper type checks.
2691 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2693 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2694 and LC_VERSION_MIN_MACOSX.
2695 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2696 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2698 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2700 * xdisp.c (forward_to_next_line_start): Allow to use the
2701 no-display-properties-and-no-overlays under bidi display.
2702 Set disp_pos in the bidi iterator to avoid searches for display
2703 properties and overlays.
2705 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2707 * editfns.c (Fset_time_zone_rule): Document relationship with the
2710 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2711 the font entity extracted from the cache (Bug#8109).
2713 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2715 * composite.c (autocmp_chars): Don't reset point. That is done by
2716 restore_point_unwind (Bug#5984).
2718 2011-08-07 Juri Linkov <juri@jurta.org>
2720 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2721 to show the arg `TIME' instead of `TIMEVAL'.
2723 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2725 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2726 display property strides EOL and includes a newline, as in
2727 longlines-mode. (Bug#9254)
2728 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2729 word-wrap under bidirectional display. (Bug#9224)
2731 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2732 is non-zero, even if the data buffer is NULL. Fixes a crash in
2733 vertical-motion with longlines-mode. (Bug#9254)
2735 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2737 * bidi.c <bidi_cache_total_alloc>: Now static.
2738 (bidi_initialize): Initialize bidi_cache_total_alloc.
2740 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2743 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2744 amount allocated this far in `bidi_cache_total_alloc'.
2745 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2746 non-zero, only free the data buffer without restoring the cache
2747 contents. All callers changed.
2749 * dispextern.h (bidi_unshelve_cache): Update prototype.
2751 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2752 (move_it_in_display_line, move_it_to)
2753 (move_it_vertically_backward, move_it_by_lines): Replace the call
2754 to xfree to an equivalent call to bidi_unshelve_cache.
2755 (move_it_in_display_line_to): Fix logic of returning
2756 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2758 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2760 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2761 came from a string character with a `cursor' property. (Bug#9229)
2763 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2765 * Makefile.in (LIB_PTHREAD): New variable.
2766 (LIBES): Add LIB_PTHREAD (Bug#9216).
2768 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2769 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2771 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2773 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2775 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2777 * xterm.c (x_find_topmost_parent): New function.
2778 (x_set_frame_alpha): Find topmost parent window with
2779 x_find_topmost_parent and set the property there also (bug#9181).
2780 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2782 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2784 * callproc.c (Fcall_process): Avoid vfork clobbering
2785 the local vars buffer, coding_systems, current_dir.
2787 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2789 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2791 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2793 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2794 so that it is not optimized away.
2796 * xdisp.c (compute_display_string_pos): Remove unused local.
2798 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2800 Fix slow cursor motion and scrolling in large buffers with
2801 selective display, like Org Mode buffers. (Bug#9218)
2803 * dispextern.h (struct bidi_it): New member disp_prop_p.
2805 * xdisp.c: Remove one-slot cache of display string positions.
2806 (compute_display_string_pos): Accept an additional argument
2807 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2808 for a display string or property. If found, set DISP_PROP_P
2811 * bidi.c (bidi_fetch_char): Accept an additional argument
2812 DISP_PROP_P, and pass it to compute_display_string_pos.
2813 Only handle text covered by a display string if DISP_PROP_P is returned
2814 non-zero. All callers of bidi_fetch_char changed.
2816 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2818 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2820 2010-12-03 Don March <don@ohspite.net>
2822 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2823 last character M-[char] is translated to ESC [char] (bug#7541).
2825 2011-08-02 Kenichi Handa <handa@m17n.org>
2827 * lisp.h (uniprop_table): Extern it.
2829 * chartab.c (uniprop_table): Make it non-static.
2831 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2833 * xdisp.c (forward_to_next_line_start): Accept additional argument
2834 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2836 (reseat_at_next_visible_line_start): Use the bidi iterator state
2837 returned by forward_to_next_line_start to restore the state of
2838 it->bidi_it after backing up to previous newline. (Bug#9212)
2840 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2842 * regex.c (re_comp): Protoize.
2843 (re_exec): Fix return type.
2844 (regexec): Fix type of `ret'. (Bug#9203)
2846 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2848 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2849 This is needed if max-image-size is a floating-point number.
2851 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2853 * print.c (print_object): Print empty symbol as ##.
2855 * lread.c (read1): Read ## as empty symbol.
2857 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2859 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2860 setting frame foreground color (Bug#9175).
2861 (x_set_background_color): Likewise.
2863 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2864 contents (Bug#9176).
2865 (EmacsTooltip -init): Remove bezels and add shadows to
2868 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2869 or scroll bar (Bug#8470).
2871 * nsfont.m (nsfont_open): Remove assignment to voffset and
2872 unnecessary vars hshink, expand, hd, full_height, min_height.
2873 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2875 * nsterm.h (nsfont_info): Remove voffset field.
2877 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2879 Implement strike-through and overline on NextStep (Bug#8863).
2881 * nsfont.m (nsfont_open): Use underline position provided by font,
2882 instead of hard-coded value of 2.
2883 (nsfont_draw): Call ns_draw_text_decoration instead.
2885 * nsterm.h: Add declaration for ns_draw_text_decoration.
2887 * nsterm.m (ns_draw_text_decoration): New function for drawing
2888 underline, overline, and strike-through.
2889 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2890 ns_draw_text_decoration. Change treatment of cursor drawing to
2891 accommodate underlining, etc.
2893 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2895 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2898 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2900 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2901 Without this fix, if a signal arrives just after memory fills up,
2902 'malloc' might be invoked reentrantly.
2904 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2905 In other words, assume that every image size is allowed, on non-X
2906 hosts. This assumption is probably wrong, but it lets Emacs compile.
2908 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2910 * regex.c (re_iswctype): Convert return values to boolean.
2912 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2914 * xdisp.c (compute_display_string_pos): Don't use cached display
2915 string position if the buffer had its restriction changed.
2918 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2920 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2922 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2924 Integer signedness and overflow and related fixes. (Bug#9079)
2926 * bidi.c: Integer size and overflow fixes.
2927 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2928 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2929 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2930 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2931 (bidi_find_other_level_edge):
2932 Use ptrdiff_t instead of EMACS_INT where either will do.
2933 This works better on 32-bit hosts configured --with-wide-int.
2934 (bidi_cache_ensure_space): Check for size-calculation overflow.
2935 Use % rather than repeated addition, for better worst-case speed.
2936 Don't set bidi_cache_size until after xrealloc returns, because it
2938 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2939 (bidi_cache_ensure_space): Also check that the bidi cache size
2940 does not exceed that of the largest Lisp string or buffer. See Eli
2941 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2943 * alloc.c (__malloc_size_t): Remove.
2944 All uses replaced by size_t. See Andreas Schwab's note
2945 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2947 * image.c: Improve checking for integer overflow.
2948 (check_image_size): Assume that f is nonnull, since
2949 it is always nonnull in practice. This is one less thing to
2950 worry about when checking for integer overflow later.
2951 (x_check_image_size): New function, which checks for integer
2952 overflow issues inside X.
2953 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2954 This removes the need for a memory_full check.
2955 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2956 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2957 (xbm_read_bitmap_data): Change locals back to 'int', since
2958 their values must fit in 'int'.
2959 (xpm_load_image, png_load, tiff_load):
2960 Invoke x_create_x_image_and_pixmap earlier,
2961 to avoid much needless work if the image is too large.
2962 (tiff_load): Treat overly large images as if
2963 x_create_x_image_and_pixmap failed, not as malloc failures.
2964 (gs_load): Use x_check_image_size.
2966 * gtkutil.c: Omit integer casts.
2967 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2968 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2970 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2972 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2973 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2974 would wrongly return t on a 64-bit host.
2976 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2977 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2978 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2979 and therefore cause GCC to emit a bogus diagnostic in some cases.
2981 * image.c: Integer signedness and overflow and related fixes.
2982 This is not an exhaustive set of fixes, but it's time to
2983 record what I've got.
2984 (lookup_pixel_color, check_image_size): Remove redundant decls.
2985 (check_image_size): Don't assume that arbitrary EMACS_INT values
2986 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2987 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2988 (tiff_load, imagemagick_load_image):
2989 Check for overflow in size calculations.
2990 (x_create_x_image_and_pixmap): Remove unnecessary test for
2991 xmalloc returning NULL; that can't happen.
2992 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2993 (xpm_color_bucket): Use better integer hashing function.
2994 (xpm_cache_color): Don't possibly over-allocate memory.
2995 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2996 (gif_memory_source):
2997 Use ptrdiff_t, not int or size_t, to record sizes.
2998 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2999 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3000 either works, as we prefer signed integers.
3001 (tiff_read_from_memory, tiff_write_from_memory):
3002 Return tsize_t, not size_t, since that's what the TIFF API wants.
3003 (tiff_read_from_memory): Don't fail simply because the read would
3004 go past EOF; instead, return a short read.
3005 (tiff_load): Omit no-longer-needed casts.
3006 (Fimagemagick_types): Don't assume size fits into 'int'.
3008 Improve hashing quality when configured --with-wide-int.
3009 * fns.c (hash_string): New function, taken from sxhash_string.
3010 Do not discard information about ASCII character case; this
3011 discarding is no longer needed.
3012 (sxhash-string): Use it. Change sig to match it. Caller changed.
3013 * lisp.h: Declare it.
3014 * lread.c (hash_string): Remove, since we now use fns.c's version.
3015 The fns.c version returns a wider integer if --with-wide-int is
3016 specified, so this should help the quality of the hashing a bit.
3018 * emacs.c: Integer overflow minor fix.
3019 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3020 Define only if GNU_LINUX.
3021 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3023 * dispnew.c: Integer signedness and overflow fixes.
3024 Remove unnecessary forward decls, that were a maintenance hassle.
3025 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3027 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3028 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3029 (prepare_desired_row, line_draw_cost):
3030 Use int, not unsigned, where either works.
3031 (save_current_matrix, restore_current_matrix):
3032 Use ptrdiff_t, not size_t, where either works.
3033 (init_display): Check for overflow more accurately, and without
3034 relying on undefined behavior.
3036 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3037 Remove, replacing with the new symbols in lisp.h. All uses changed.
3038 * fileio.c (make_temp_name):
3039 * filelock.c (lock_file_1, lock_file):
3040 * xdisp.c (message_dolog):
3041 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3042 Use pMd etc. instead.
3043 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3044 replacing the pWIDE etc. symbols removed from editfns.c.
3046 * keyboard.h (num_input_events): Now uintmax_t.
3047 This is (very slightly) less likely to mess up due to wraparound.
3050 * buffer.c: Integer signedness fixes.
3051 (alloc_buffer_text, enlarge_buffer_text):
3052 Use ptrdiff_t rather than size_t when either will do, as we prefer
3055 * alloc.c: Integer signedness and overflow fixes.
3056 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3057 (__malloc_size_t): Default to size_t, not to int.
3058 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3059 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3060 Prefer ptrdiff_t to size_t when either would do, as we prefer
3062 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3063 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3064 Now const. Initialize with values that are in range even if char
3066 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3067 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3068 These functions do the right thing with sizes > 2**32.
3069 (check_depth): Now ptrdiff_t, not int.
3070 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3071 Adjust to new way of storing sizes. Check for size overflow bugs
3073 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3074 slightly wrong anyway, as it missed one instance of
3075 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3076 (refill_memory_reserve): Omit needless cast to size_t.
3077 (mark_object_loop_halt): Mark as externally visible.
3079 * xselect.c: Integer signedness and overflow fixes.
3080 (Fx_register_dnd_atom, x_handle_dnd_message):
3081 Use ptrdiff_t, not size_t, since we prefer signed.
3082 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3083 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3084 x_dnd_atoms_size and x_dnd_atoms_length.
3086 * doprnt.c: Prefer signed to unsigned when either works.
3088 * doprnt.c (doprnt):
3090 * xdisp.c (vmessage):
3091 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3092 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3093 prefer signed arithmetic to avoid comparison confusion.
3094 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3095 but is a bit tricky.
3097 Assume freestanding C89 headers, string.h, stdlib.h.
3098 * data.c, doprnt.c, floatfns.c, print.c:
3099 Include float.h unconditionally.
3100 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3101 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3102 * regex.c: Likewise for stddef.h, string.h.
3103 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3104 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3105 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3106 (STDC_HEADERS): Remove obsolete defines.
3107 * sysdep.c: Include limits.h unconditionally.
3109 Assume support for memcmp, memcpy, memmove, memset.
3110 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3111 * regex.c (memcmp, memcpy):
3112 Remove; we assume C89 now.
3114 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3115 (__malloc_safe_bcopy): Remove; no longer needed.
3117 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3118 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3119 well either way, and we prefer signed to unsigned.
3121 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3123 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3124 closes the connection while we're reading (bug#9182).
3126 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3128 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3129 are specified (Bug#9168).
3131 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3133 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3134 Found by GCC static checking and --with-wide-int on a 32-bit host.
3136 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3138 * xdisp.c (compute_display_string_pos): Fix logic of caching
3139 previous display string position. Initialize cached_prev_pos to
3140 -1. Fixes slow-down at the beginning of a buffer.
3142 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3144 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3145 for attrs[LFACE_FONTSET_INDEX].
3147 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3149 * xml.c (parse_region): Remove unused local
3150 that was recently introduced.
3152 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3154 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3155 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3157 * xdisp.c (move_it_in_display_line_to): Record the best matching
3158 position for TO_CHARPOS while scanning the line, and restore it on
3159 exit if none of the characters scanned was an exact match.
3160 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3161 when exact match is impossible due to invisible text, and the
3162 lines are truncated.
3164 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3166 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3169 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3171 Fix a significant slow-down of cursor motion with C-n, C-p,
3172 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3173 auto-repeat under bidi redisplay in fontified buffers.
3174 * xdisp.c (compute_stop_pos_backwards): New function.
3175 (next_element_from_buffer): Call compute_stop_pos_backwards to
3176 find a suitable prev_stop when we find ourselves before
3178 (reseat): Don't look for prev_stop, as that could mean a very long
3180 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3181 <cached_disp_overlay_modiff>: Cache for last found display string
3183 (compute_display_string_pos): Return the cached position if asked
3184 about the same buffer in the same area of character positions, and
3185 the buffer wasn't changed since the time the display string
3186 position was cached.
3188 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3190 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3191 is an integer, which is important for empty lines. (Bug#9149)
3193 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3195 * frame.c (Fmodify_frame_parameters): In tty case, update the
3196 default face if necessary (Bug#4238).
3198 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3200 * editfns.c (Fstring_to_char): No need to explain what a character
3201 is in the docstring (Bug#6576).
3203 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3205 * xml.c (parse_region): Make sure we always return a tree.
3207 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3209 * xml.c (parse_region): If a document contains only comments,
3212 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3214 * xml.c (make_dom): Return comments, too.
3216 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3219 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3220 and the surrounding thread.
3221 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3222 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3223 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3225 * s/openbsd.h (BROKEN_SIGIO): Define.
3226 * unexelf.c (unexec) [__OpenBSD__]:
3227 Don't update the .mdebug section of the Alpha COFF symbol table.
3229 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3231 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3234 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3236 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3237 This fixes some race conditions on the permissions of any newly
3240 * alloc.c (valid_pointer_p): Use pipe, not open.
3241 This fixes some permissions issues when debugging.
3243 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3244 If fchown fails to set both uid and gid, try to set just gid,
3245 as that is sometimes allowed. Adjust the file's mode to eliminate
3246 setuid or setgid bits that are inappropriate if fchown fails.
3248 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3250 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3251 to compare Lisp_Objects.
3252 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3253 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3254 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3256 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3258 * lread.c (read_integer): Unread even EOF character.
3259 (read1): Likewise. Properly record start position of symbol.
3261 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3262 symbol character follows.
3264 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3266 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3267 This works around a problem with the previous change to Fcopy_file.
3268 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3269 and without this change, GCC might complain about discarding
3270 fchown's return value.
3272 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3274 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3276 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3278 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3280 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3282 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3283 it's used from the C level.
3285 * process.c: Use the same condition for POLL_FOR_INPUT in both
3286 keyboard.c and process.c (bug#1858).
3288 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3290 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3291 (Fgnutls_boot): Use it.
3293 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3295 * doc.c (Fsubstitute_command_keys): Revert last change.
3297 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3299 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3300 quotes the next character, and doesn't affect other longer
3301 sequences (bug#8935).
3303 * lread.c (syms_of_lread): Clarify that is isn't only
3304 `eval-buffer' and `eval-defun' that's affected by
3305 `lexical-binding' (bug#8460).
3307 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3309 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3310 bidi redisplay when a line includes both an image and is truncated.
3312 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3314 Fix minor problems found by static checking.
3315 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3316 (elsz): Now a signed constant, not a size_t var. We prefer signed
3317 types to unsigned, to avoid integer comparison confusion. Without
3318 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3319 "cannot optimize loop, the loop counter may overflow", a symptom
3321 * indent.c (Fvertical_motion): Mark locals as initialized.
3322 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3324 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3326 * search.c (Fre_search_backward): Mention `case-fold-search' in
3327 all the re_search_* functions (bug#8138).
3329 * keyboard.c (Fopen_dribble_file): Document when the file is
3332 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3334 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3337 Support bidi reordering of display and overlay strings.
3338 * xdisp.c (compute_display_string_pos)
3339 (compute_display_string_end): Accept additional argument STRING.
3340 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3341 (reseat_to_string): Initialize bidi_it->string.s and
3342 bidi_it->string.schars.
3343 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3344 NULL (avoids a crash in bidi_paragraph_init).
3345 Initialize itb.string.lstring.
3346 (init_iterator): Call bidi_init_it only of a valid
3347 buffer position was specified. Initialize paragraph_embedding to
3349 (reseat_to_string): Initialize the bidi iterator.
3350 (display_string): If we need to ignore text properties of
3351 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3352 original value of -1 will not work with bidi.)
3353 (compute_display_string_pos): First arg is now struct
3354 `text_pos *'; all callers changed. Support display properties on
3356 (compute_display_string_end): Support display properties on Lisp
3358 (init_iterator, reseat_1, reseat_to_string): Initialize the
3359 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3360 when iterating on a string not from display properties).
3361 (compute_display_string_pos, compute_display_string_end):
3362 Fix calculation of the object to scan. Fixes an error when using
3364 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3365 base_level_stop; instead, set base_level_stop to BEGV.
3366 Fixes crashes in vertical-motion.
3367 (next_element_from_buffer): Improve commentary for when
3368 the iterator is before prev_stop.
3369 (init_iterator): Initialize bidi_p from the default value of
3370 bidi-display-reordering, not from buffer-local value. Use the
3371 buffer-local value only if initializing for buffer iteration.
3372 (handle_invisible_prop): Support invisible properties on strings
3373 that are being bidi-reordered.
3374 (set_iterator_to_next): Support bidi reordering of C strings and
3376 (next_element_from_string): Support bidi reordering of Lisp
3378 (handle_stop_backwards): Support Lisp strings as well.
3379 (display_string): Support display of R2L glyph rows.
3380 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3381 (init_iterator): Don't initialize it->bidi_p for strings
3383 (reseat_to_string): Initialize it->bidi_p for strings here.
3384 (next_element_from_string, next_element_from_c_string)
3385 (next_element_from_buffer): Add xassert's for correspondence
3386 between IT's object being iterated and it->bidi_it.string
3388 (face_before_or_after_it_pos): Support bidi iteration.
3389 (next_element_from_c_string): Handle the case of the first string
3390 character that is not the first one in the visual order.
3391 (get_visually_first_element): New function, refactored from common
3392 parts of next_element_from_buffer, next_element_from_string, and
3393 next_element_from_c_string.
3394 (tool_bar_lines_needed, redisplay_tool_bar)
3395 (display_menu_bar): Force left-to-right direction. Add a FIXME
3396 comment for making that be controlled by a user option.
3397 (push_it, pop_it): Save and restore the state of the
3398 bidi iterator. Save and restore the bidi_p flag.
3399 (pop_it): Iterate out of display property for string iteration as
3401 (iterate_out_of_display_property): Support iteration over strings.
3402 (handle_single_display_spec): Set up it->bidi_it for iteration
3403 over a display string, and call bidi_init_it.
3404 (handle_single_display_spec, next_overlay_string)
3405 (get_overlay_strings_1, push_display_prop): Set up the bidi
3406 iterator for displaying display or overlay strings.
3407 (forward_to_next_line_start): Don't use the shortcut if
3409 (back_to_previous_visible_line_start): If handle_display_prop
3410 pushed the iterator stack, restore the internal state of the bidi
3411 iterator by calling bidi_pop_it same number of times.
3412 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3413 and we are bidi-iterating, don't decrement the iterator position;
3414 instead, set the first_elt flag in the bidi iterator, to produce
3416 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3417 (push_display_prop): xassert that we are iterating a buffer.
3418 (push_it, pop_it): Save and restore paragraph_embedding member.
3419 (handle_single_display_spec, next_overlay_string)
3420 (get_overlay_strings_1, reseat_1, reseat_to_string)
3421 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3422 correctly. Don't assume unibyte strings are not bidi-reordered.
3423 (compute_display_string_pos)
3424 (compute_display_string_end): Fix handling the case of C string.
3425 (push_it, pop_it): Save and restore from_disp_prop_p.
3426 (handle_single_display_spec, push_display_prop): Set the
3427 from_disp_prop_p flag.
3428 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3429 (pop_it): Call iterate_out_of_display_property only if we are
3430 popping after iteration over a string that came from a display
3431 property. Fix a typo in popping stretch info. Add an assertion
3432 for verifying that the iterator position is in sync with the bidi
3434 (handle_single_display_spec, get_overlay_strings_1)
3435 (push_display_prop): Fix initialization of paragraph direction for
3436 string when that of the parent object is not yet determined.
3437 (reseat_1): Call bidi_init_it to resync the bidi
3438 iterator with IT's position. (Bug#7616)
3439 (find_row_edges): If ROW->start.pos gives position
3440 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3441 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3442 Reset the from_disp_prop_p flag.
3443 (SAVE_IT, RESTORE_IT): New macros.
3444 (pos_visible_p, face_before_or_after_it_pos)
3445 (back_to_previous_visible_line_start)
3446 (move_it_in_display_line_to, move_it_in_display_line)
3447 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3448 (try_scrolling, redisplay_window, display_line): Use them when
3449 saving a temporary copy of the iterator and restoring it back.
3450 (back_to_previous_visible_line_start, reseat_1)
3451 (init_iterator): Empty the bidi cache "stack".
3452 (move_it_in_display_line_to): If iterator ended up at
3453 EOL, but we never saw any buffer positions smaller than
3454 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3455 motion in bidi-reordered lines.
3456 (move_it_in_display_line_to): Record prev_method and prev_pos
3457 immediately before the call to set_iterator_to_next. Fixes cursor
3458 motion in bidi-reordered lines with stretch glyphs and strings
3459 displayed in margins. (Bug#8133) (Bug#8867)
3460 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3462 (pos_visible_p): Support positions in bidi-reordered lines.
3463 Save and restore bidi cache.
3465 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3466 (bidi_paragraph_info): Delete unused struct.
3467 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3468 (bidi_cache_start): New variable.
3469 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3471 (bidi_cache_fetch_state, bidi_cache_search)
3472 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3473 (bidi_cache_find, bidi_peek_at_next_level)
3474 (bidi_level_of_next_char, bidi_find_other_level_edge)
3475 (bidi_move_to_visually_next): Compare cache index with
3476 bidi_cache_start rather than with zero.
3477 (bidi_fetch_char): Accept new argument STRING; all callers
3478 changed. Support iteration over a string. Support strings with
3479 display properties. Support unibyte strings. Fix the type of
3480 `len' according to what STRING_CHAR_AND_LENGTH expects.
3481 (bidi_paragraph_init, bidi_resolve_explicit_1)
3482 (bidi_resolve_explicit, bidi_resolve_weak)
3483 (bidi_level_of_next_char, bidi_move_to_visually_next):
3484 Support iteration over a string.
3485 (bidi_set_sor_type, bidi_resolve_explicit_1)
3486 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3487 can now be zero (for strings); special values 0 and -1 were
3488 changed to -1 and -2, respectively.
3489 (bidi_char_at_pos): New function.
3490 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3491 Call it instead of FETCH_MULTIBYTE_CHAR.
3492 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3493 initialized to valid values.
3494 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3496 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3497 the test for valid cached positions. Fix the logic for looking up
3498 the sentinel state in the cache. GCPRO the Lisp string we are
3500 (bidi_push_it, bidi_pop_it): New functions.
3501 (bidi_initialize): Initialize the bidi cache start stack pointer.
3502 (bidi_cache_ensure_space): New function, refactored from part of
3503 bidi_cache_iterator_state. Don't assume the required size is just
3504 one BIDI_CACHE_CHUNK away.
3505 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3506 (bidi_count_bytes, bidi_char_at_pos): New functions.
3507 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3508 always valid if bidi_cache_idx is valid.
3509 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3510 is valid if it's going to be used.
3511 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3512 (bidi_cache_fetch_state, bidi_cache_search)
3513 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3514 (bidi_cache_iterator_state, bidi_cache_find)
3515 (bidi_find_other_level_edge, bidi_cache_start_stack):
3516 All variables related to cache indices are now EMACS_INT.
3518 * dispextern.h (struct bidi_string_data): New structure.
3519 (struct bidi_it): New member `string'. Make flag members be 1-bit
3520 fields, and put them last in the struct.
3521 (compute_display_string_pos, compute_display_string_end):
3523 (bidi_push_it, bidi_pop_it): Add prototypes.
3524 (struct iterator_stack_entry): New members bidi_p,
3525 paragraph_embedding, and from_disp_prop_p.
3526 (struct it): Member bidi_p is now a bit field 1 bit wide.
3527 (bidi_shelve_cache, bidi_unshelve_cache):
3530 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3531 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3532 and vector-like objects.
3534 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3535 cache around display iteration.
3537 * window.c (Fwindow_end, window_scroll_pixel_based)
3538 (displayed_window_lines, Frecenter): Save and restore the bidi
3539 cache around display iteration.
3541 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543 * editfns.c (Fdelete_region): Clarify the use of the named
3544 parameters (bug#6788).
3546 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3548 * indent.c (Fvertical_motion): Set and restore w->pointm when
3549 saving and restoring the window's buffer (Bug#9006).
3551 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3553 * editfns.c (Fstring_to_char): Clarify just what is returned
3554 (bug#6576). Text by Eli Zaretskii.
3556 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3558 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3560 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3562 * buffer.c (mmap_find): Fix a typo.
3564 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3566 Fix execution of x selection hooks.
3567 * xselect.c (Qx_lost_selection_functions)
3568 (Qx_sent_selection_functions): New vars.
3569 (syms_of_xselect): DEFSYM them.
3570 (x_handle_selection_request): Pass Qx_sent_selection_functions
3571 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3572 (x_handle_selection_clear,x_clear_frame_selections):
3573 Pass Qx_lost_selection_functions rather than
3574 Vx_lost_selection_functions to Frun_hook_with_args.
3576 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3578 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3579 The old code sometimes used this field without initializing it.
3581 * alloc.c (gc_sweep): Don't read past end of array.
3582 In theory, the old code could also have corrupted Emacs internals,
3583 though it'd be very unlikely.
3585 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3587 * character.c (Fcharacterp): Don't advertise optional ignored
3588 argument. (Bug#4026)
3590 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3592 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3595 * window.c (Fset_window_start): Doc fix (bug#4199).
3596 (Fset_window_hscroll): Ditto.
3598 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3600 Fix minor new problems caught by GCC 4.6.1.
3601 * term.c (init_tty): Remove unused local.
3602 * xsettings.c (store_monospaced_changed): Define this function only
3603 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3606 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3608 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3610 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3612 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3613 are the mini-buffer and the echo area (bug#3320).
3615 * term.c (init_tty): Remove support for supdup, c10 and perq
3616 terminals, which are no longer supported (bug#1482).
3618 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3620 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3622 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3624 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3625 for non-popups (Bug#3642).
3627 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3629 * alloc.c (reset_malloc_hooks): Protoize.
3630 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3631 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3632 * cm.c (losecursor): Likewise.
3633 * data.c (fmod): Likewise.
3634 * dispnew.c (swap_glyphs_in_rows): Likewise.
3635 * emacs.c (memory_warning_signal): Likewise.
3636 * floatfns.c (float_error): Likewise.
3637 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3638 (otf_open, font_otf_capability, generate_otf_features)
3639 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3641 * image.c (pbm_read_file): Likewise.
3642 * indent.c (string_display_width): Likewise.
3643 * intervals.c (check_for_interval, search_for_interval)
3644 (inc_interval_count, count_intervals, root_interval)
3645 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3646 * lread.c (defalias): Likewise.
3647 * ralloc.c (r_alloc_check): Likewise.
3648 * regex.c (set_image_of_range_1, set_image_of_range)
3649 (regex_grow_registers): Likewise.
3650 * sysdep.c (strerror): Likewise.
3651 * termcap.c (valid_filename_p, tprint, main): Likewise.
3652 * tparam.c (main): Likewise.
3653 * unexhp9k800.c (run_time_remap, save_data_space)
3654 (update_file_ptrs, read_header, write_header, calculate_checksum)
3655 (copy_file, copy_rest, display_header): Likewise.
3656 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3658 * xdisp.c (check_it): Likewise.
3659 * xfaces.c (register_color, unregister_color, unregister_colors):
3661 * xfns.c (print_fontset_result): Likewise.
3662 * xrdb.c (member, fatal, main): Likewise.
3664 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3666 Fix minor problems found by static checking (Bug#9031).
3667 * chartab.c (char_table_set_range, map_sub_char_table):
3668 Remove unused locals.
3669 (uniprop_table): Now static.
3670 * composite.c (_work_char): Remove unused static var.
3672 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3674 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3676 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3678 * gtkutil.c (qttip_cb): Remove code without function.
3680 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3682 * w32.c (pthread_sigmask): New stub.
3684 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3686 Use pthread_sigmask, not sigprocmask (Bug#9010).
3687 sigprocmask is portable only for single-threaded applications, and
3688 Emacs can be multi-threaded when it uses GTK.
3689 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3691 * callproc.c (Fcall_process):
3692 * process.c (create_process):
3693 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3694 Use pthread_sigmask, not sigprocmask.
3696 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3698 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3699 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3702 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3704 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3705 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3706 (xg_hide_tooltip): Fix comment.
3708 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3709 in registerServicesMenuSendTypes.
3710 (validRequestorForSendType): Don't check ns_return_types.
3712 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3715 2011-07-08 Jason Rumney <jasonr@gnu.org>
3717 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3718 SH_SHOW for hidden windows (Bug#5482).
3720 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3721 frame struct members of non-existent frames (Bug#6284).
3723 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3725 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3726 variable firstTime not needed on OSX >= 10.6.
3727 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3728 >= 10.5. Use setKnobProportion, setDoubleValue.
3730 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3731 (MAC_OS_X_VERSION_10_5): Define if not defined.
3732 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3733 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3734 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3736 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3737 cString and lossyCString on OSX >= 10.4
3739 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3740 sizeToFit on OSX >= 10.2.
3742 * nsimage.m (allocInitFromFile): Don't use deprecated method
3743 bestRepresentationForDevice on OSX >= 10.6.
3745 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3748 * emacs.c: Declare unexec_init_emacs_zone.
3750 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3752 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3754 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3755 on svcsMenu (Bug#8842).
3757 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3759 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3761 * nsterm.m (QUTF8_STRING): Declare.
3762 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3763 (validRequestorForSendType): Return type is (id).
3764 Change indexOfObjectIdenticalTo to indexOfObject.
3765 Check if we have local selection before returning self (Bug#8842).
3766 (writeSelectionToPasteboard): Put local selection into paste board
3767 if we have a local selection (Bug#8842).
3768 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3770 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3771 (ns_get_local_selection): Declare.
3773 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775 * keymap.c (describe_map_tree): Don't insert a double newline at
3776 the end of the buffer (bug#1169) and return whether we inserted
3779 * callint.c (Fcall_interactively): Change "reading args" to
3780 "providing args" to try to clarify what it does (bug#1010).
3782 2011-07-07 Kenichi Handa <handa@m17n.org>
3784 * composite.c (composition_compute_stop_pos): Ignore a static
3785 composition starting before CHARPOS (Bug#8915).
3787 * xdisp.c (handle_composition_prop): Likewise.
3789 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3791 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3794 2011-07-07 Kenichi Handa <handa@m17n.org>
3796 * character.h (unicode_category_t): New enum type.
3798 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3799 (Qchar_code_property_table): New variable.
3800 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3801 (UNIPROP_COMPRESSED_FORM_P): New macros.
3802 (char_table_ascii): Uncompress the compressed values.
3803 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3804 Uncompress the compressed values.
3805 (sub_char_table_ref_and_range): Likewise.
3806 (char_table_ref_and_range): Uncompress the compressed values.
3807 (sub_char_table_set): New arg is_uniprop. Callers changed.
3808 Uncompress the compressed values.
3809 (sub_char_table_set_range): Args changed. Callers changed.
3810 (char_table_set_range): Adjuted for the above change.
3811 (map_sub_char_table): Delete args default_val and parent. Add arg
3812 top. Give decoded values to a Lisp function.
3813 (map_char_table): Adjust for the above change. Give decoded
3814 values to a Lisp function. Gcpro more variables.
3815 (uniprop_table_uncompress)
3816 (uniprop_decode_value_run_length): New functions.
3817 (uniprop_decoder, uniprop_decoder_count): New variables.
3818 (uniprop_get_decoder, uniprop_encode_value_character)
3819 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3821 (uniprop_encoder, uniprop_encoder_count): New variables.
3822 (uniprop_get_encoder, uniprop_table)
3823 (Funicode_property_table_internal, Fget_unicode_property_internal)
3824 (Fput_unicode_property_internal): New functions.
3825 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3826 Sunicode_property_table_internal, Sget_unicode_property_internal,
3827 and Sput_unicode_property_internal. Defvar_lisp
3828 char-code-property-alist.
3830 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3831 Vunicode_category_table.
3833 * font.c (font_range): Adjust for the change of
3834 Vunicode_category_table.
3836 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3838 * m/iris4d.h: Remove file, move contents ...
3839 * s/irix6-5.h: ... here.
3841 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3843 Remove unportable assumption about struct layout (Bug#8884).
3844 * alloc.c (mark_buffer):
3845 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3846 (clone_per_buffer_values): Don't assume that
3847 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3848 This isn't true in general, and it's particularly not true
3849 if Emacs is configured with --with-wide-int.
3850 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3851 New macros, used in the buffer.c change.
3853 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3855 * xsettings.c: Use both GConf and GSettings if both are available.
3856 (store_config_changed_event): Add comment.
3857 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3858 (store_tool_bar_style_changed): New functions.
3859 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3860 (struct xsettings): Move font inside HAVE_XFT.
3861 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3862 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3863 Move inside HAVE_XFT.
3864 (something_changed_gsettingsCB): Rename from something_changedCB.
3865 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3867 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3868 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3869 (something_changed_gconfCB): Rename from something_changedCB.
3870 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3871 (parse_settings): Move check for font inside HAVE_XFT.
3872 (read_settings, apply_xft_settings): Add comment.
3873 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3874 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3875 call store_font_name_changed.
3876 (xft_settings_event): Add comment.
3877 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3878 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3879 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3880 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3881 (xsettings_initialize): Call init_gsettings last.
3882 (xsettings_get_system_font, xsettings_get_system_normal_font):
3885 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3887 Random fixes. E.g., (random) never returned negative values.
3888 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3889 subseconds part to the entropy, as that's a bit more random.
3890 Prefer signed to unsigned, since the signedness doesn't matter and
3891 in general we prefer signed. When given a limit, use a
3892 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3893 latter isn't right if USE_2_TAGS_FOR_INTS.
3894 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3895 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3897 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3899 * textprop.c (text_property_stickiness):
3900 Obey Vtext_property_default_nonsticky.
3901 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3902 * w32fns.c (syms_of_w32fns):
3903 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3905 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3907 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3908 This is more efficient than Ffile_directory_p and avoids a minor race.
3910 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3912 * buffer.c (Foverlay_put): Say what the return value is
3915 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3916 is a directory before asking whether to use the file name
3918 (barf_or_query_if_file_exists): Make the "File is a directory"
3919 error be more correct.
3921 * fns.c (Frequire): Remove the mention of the .gz files, since
3922 that's installation-specific, but keep the mention of
3923 `get-load-suffixes'.
3925 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3927 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3928 Report string overflow if the output is too long.
3930 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3932 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3933 (syms_of_gnutls): Remove duplicate DEFSYM for
3934 Qgnutls_bootprop_verify_hostname_error, an error for
3935 Qgnutls_bootprop_verify_error (which is no longer used).
3937 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3938 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3939 Also (re)move comments that are misplaced or no longer relevant.
3941 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3945 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3947 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3948 and background color parameters if they have been changed.
3950 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3954 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3956 * xsettings.c (SYSTEM_FONT): Define only when used.
3957 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3959 * keymap.c (access_keymap_1): Now static.
3961 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3963 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3964 leave any prefix arg for the up event (Bug#1586).
3966 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3968 * lread.c (syms_of_lread): Mention single symbols defined by
3969 `defvar' or `defconst' (bug#7154).
3971 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3972 (Frequire): Mention get-load-suffixes.
3974 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3976 * window.h (window): Remove clone_number slot.
3977 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3979 (make_parent_window, make_window, saved_window)
3980 (Fset_window_configuration, save_window_save): Don't deal with
3982 * buffer.c (Qclone_number): Remove declaration.
3983 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3985 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3987 Add multiple inheritance to keymaps.
3988 * keymap.c (Fmake_composed_keymap): New function.
3989 (Fset_keymap_parent): Simplify.
3990 (fix_submap_inheritance): Remove.
3991 (access_keymap_1): New function extracted from access_keymap to handle
3992 embedded parents and handle lists of maps.
3993 (access_keymap): Use it.
3994 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3995 (Fcopy_keymap): Handle embedded parents.
3996 (Fcommand_remapping, define_as_prefix): Simplify.
3997 (Fkey_binding): Simplify.
3998 (syms_of_keymap): Move minibuffer-local-completion-map,
3999 minibuffer-local-filename-completion-map,
4000 minibuffer-local-must-match-map, and
4001 minibuffer-local-filename-must-match-map to Elisp.
4002 (syms_of_keymap): Defsubr make-composed-keymap.
4003 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4004 (parse_menu_item): Trivial simplification.
4006 2011-07-01 Glenn Morris <rgm@gnu.org>
4008 * Makefile.in (SETTINGS_LIBS): Fix typo.
4010 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4012 * coding.c (Fencode_coding_string): Record the last coding system
4013 used, as the function doc string says (bug#8738).
4015 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4017 * xsettings.c (store_monospaced_changed): Take new font as arg and
4018 check for change against current_mono_font.
4019 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4020 (emacs_settings_constructor, emacs_settings_get_property)
4021 (emacs_settings_set_property, emacs_settings_class_init)
4022 (emacs_settings_init, gsettings_obj): Remove.
4023 (something_changedCB): New function for HAVE_GSETTINGS.
4024 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4025 with value as argument.
4026 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4027 g_settings_new (Bug#8967). Do not create gsettings_obj.
4028 Remove calls to g_settings_bind. Connect something_changedCB to
4031 * xgselect.c: Add defined (HAVE_GSETTINGS).
4032 (xgselect_initialize): Ditto.
4034 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4035 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4038 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4040 * eval.c (struct backtrace): Simplify and port the data structure.
4041 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4042 signed bit field, as this assumption is not portable and it makes
4043 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4044 "char debug_on_exit : 1" as this is not portable either; instead,
4045 use the portable "unsigned int debug_on_exit : 1". Remove unused
4046 member evalargs. Remove obsolete comments about cc bombing out.
4048 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4050 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4051 Let HAVE_GSETTINGS override HAVE_GCONF.
4052 (store_monospaced_changed): New function.
4053 (EMACS_SETTINGS): A new type derived from GObject to handle
4054 GSettings notifications.
4055 (emacs_settings_constructor, emacs_settings_get_property)
4056 (emacs_settings_set_property, emacs_settings_class_init):
4058 (gsettings_client, gsettings_obj): New variables.
4059 (GSETTINGS_SCHEMA): New define.
4060 (something_changedCB): Call store_monospaced_changed.
4061 (init_gsettings): New function.
4062 (xsettings_initialize): Call init_gsettings.
4063 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4066 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4069 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4071 * window.c (resize_root_window, grow_mini_window)
4072 (shrink_mini_window): Rename Qresize_root_window to
4073 Qwindow_resize_root_window and Qresize_root_window_vertically to
4074 Qwindow_resize_root_window_vertically.
4076 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4078 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4080 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4082 * makefile.w32-in: Redesign dependencies so they reflect more
4083 clearly which files are directly included by each source file,
4084 and not through other includes.
4086 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4088 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4089 (sort_overlays, overlay_strings): When an overlay's clone number
4090 matches the window's clone number process the overlay even if
4091 the overlay's window property doesn't match the current window.
4093 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4094 (Fwindow_hchild): Rename to Fwindow_left_child.
4095 (Fwindow_next): Rename to Fwindow_next_sibling.
4096 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4097 (resize_window_check): Rename to window_resize_check.
4098 (resize_window_apply): Rename to window_resize_apply.
4099 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4100 (Fdelete_other_windows_internal, resize_frame_windows)
4101 (Fsplit_window_internal, Fdelete_window_internal)
4102 (grow_mini_window, shrink_mini_window)
4103 (Fresize_mini_window_internal): Fix callers accordingly.
4105 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4107 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4108 (emacs_fixed_set_min_size): Remove.
4109 (emacs_fixed_new): Take frame as argument.
4111 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4112 (_EmacsFixedPrivate): Remove minwidth/height.
4113 Add struct frame *f.
4114 (emacs_fixed_init): Initialize priv->f.
4115 (get_parent_class, emacs_fixed_set_min_size): Remove.
4116 (emacs_fixed_new): Set priv->f to argument.
4117 (emacs_fixed_get_preferred_width)
4118 (emacs_fixed_get_preferred_height): Use min_width/height from
4119 frames size_hint to set minimum and natural (Bug#8919).
4120 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4121 and use min_width/height from frames size_hint to set
4122 min_width/height (Bug#8919).
4124 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4125 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4128 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4130 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4131 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4134 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4136 * process.c (wait_reading_process_output): Bypass select if
4137 waiting for a cell while ignoring keyboard input, and input is
4138 pending. Suggested by Jan Djärv (Bug#8869).
4140 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4142 Use gnulib's dup2 module instead of rolling our own.
4143 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4145 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4147 * dispnew.c (scrolling_window): Before scrolling, turn off a
4148 mouse-highlight in the window being scrolled.
4150 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4152 Move DEFSYM to lisp.h and use everywhere.
4154 * character.h (DEFSYM): Move declaration...
4155 * lisp.h (DEFSYM): ...here.
4161 * w32select.c: Don't include character.h.
4163 * alloc.c (syms_of_alloc):
4164 * buffer.c (syms_of_buffer):
4165 * bytecode.c (syms_of_bytecode):
4166 * callint.c (syms_of_callint):
4167 * casefiddle.c (syms_of_casefiddle):
4168 * casetab.c (init_casetab_once):
4169 * category.c (init_category_once, syms_of_category):
4170 * ccl.c (syms_of_ccl):
4171 * cmds.c (syms_of_cmds):
4172 * composite.c (syms_of_composite):
4173 * dbusbind.c (syms_of_dbusbind):
4174 * dired.c (syms_of_dired):
4175 * dispnew.c (syms_of_display):
4176 * doc.c (syms_of_doc):
4177 * editfns.c (syms_of_editfns):
4178 * emacs.c (syms_of_emacs):
4179 * eval.c (syms_of_eval):
4180 * fileio.c (syms_of_fileio):
4181 * fns.c (syms_of_fns):
4182 * frame.c (syms_of_frame):
4183 * fringe.c (syms_of_fringe):
4184 * insdel.c (syms_of_insdel):
4185 * keymap.c (syms_of_keymap):
4186 * lread.c (init_obarray, syms_of_lread):
4187 * macros.c (syms_of_macros):
4188 * msdos.c (syms_of_msdos):
4189 * print.c (syms_of_print):
4190 * process.c (syms_of_process):
4191 * search.c (syms_of_search):
4192 * sound.c (syms_of_sound):
4193 * syntax.c (init_syntax_once, syms_of_syntax):
4194 * terminal.c (syms_of_terminal):
4195 * textprop.c (syms_of_textprop):
4196 * undo.c (syms_of_undo):
4197 * w32.c (globals_of_w32):
4198 * window.c (syms_of_window):
4199 * xdisp.c (syms_of_xdisp):
4200 * xfaces.c (syms_of_xfaces):
4201 * xfns.c (syms_of_xfns):
4202 * xmenu.c (syms_of_xmenu):
4203 * xsettings.c (syms_of_xsettings):
4204 * xterm.c (syms_of_xterm): Use DEFSYM.
4206 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4208 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4210 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4212 Integer and buffer overflow fixes (Bug#8873).
4214 * print.c (printchar, strout): Check for string overflow.
4215 (PRINTPREPARE, printchar, strout):
4216 Don't set size unless allocation succeeds.
4218 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4219 for sizes. Check for string overflow more accurately.
4220 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4222 * macros.c: Integer and buffer overflow fixes.
4223 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4224 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4225 Use ptrdiff_t, not int, for sizes.
4226 Don't increment bufsize until after realloc succeeds.
4227 Check for size-calculation overflow.
4228 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4230 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4232 * lread.c: Integer overflow fixes.
4233 (read_integer): Radix is now EMACS_INT, not int,
4234 to improve quality of diagnostics for out-of-range radices.
4235 Calculate buffer size correctly for out-of-range radices.
4236 (read1): Check for integer overflow in radices, and in
4237 read-circle numbers.
4238 (read_escape): Avoid int overflow.
4239 (Fload, openp, read_buffer_size, read1)
4240 (substitute_object_recurse, read_vector, read_list, map_obarray):
4241 Use ptrdiff_t, not int, for sizes.
4242 (read1): Use EMACS_INT, not int, for sizes.
4243 Check for size overflow.
4245 * image.c (cache_image): Check for size arithmetic overflow.
4247 * lread.c: Integer overflow issues.
4248 (saved_doc_string_size, saved_doc_string_length)
4249 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4250 Now ptrdiff_t, not int.
4251 (read1): Don't assume doc string length fits in int. Check for
4252 out-of-range doc string lengths.
4253 (read_list): Don't assume file position fits in int.
4254 (read_escape): Check for hex character overflow.
4256 2011-06-22 Leo Liu <sdl.web@gmail.com>
4258 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4259 Move to minibuffer.el.
4261 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4263 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4264 The following patches are for when GLYPH_DEBUG && !XASSERT.
4265 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4266 * dispnew.c (flush_stdout):
4267 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4268 Mark as externally visible.
4269 * dispnew.c (check_window_matrix_pointers): Now static.
4270 * dispnew.c (window_to_frame_vpos):
4271 * xfns.c (unwind_create_frame):
4272 * xterm.c (x_check_font): Remove unused local.
4273 * scroll.c (CHECK_BOUNDS):
4274 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4275 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4276 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4277 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4278 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4280 (debug_method_add): Use va_list and vsprintf rather than relying
4281 on undefined behavior with wrong number of arguments.
4282 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4283 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4284 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4285 since we're not interested in debugging glyphs with old libraries.
4286 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4287 GCC 4.6.0's static checking.
4289 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4291 Integer overflow and signedness fixes (Bug#8873).
4292 A few related buffer overrun fixes, too.
4294 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4296 * dispextern.h (struct face.stipple):
4297 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4298 (x_bitmap_mask, x_allocate_bitmap_record)
4299 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4300 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4301 (x_create_bitmap_from_xpm_data):
4302 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4303 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4305 * xfaces.c (load_pixmap):
4306 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4307 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4308 (.bitmaps_last, struct x_output.icon_bitmap):
4309 Use ptrdiff_t, not int, for bitmap indexes.
4310 (x_allocate_bitmap_record): Check for size overflow.
4311 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4313 Use ptrdiff_t, not int, for overlay counts.
4314 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4315 * editfns.c (overlays_around, get_pos_property):
4316 * textprop.c (get_char_property_and_overlay):
4317 * xdisp.c (next_overlay_change, note_mouse_highlight):
4318 * xfaces.c (face_at_buffer_position):
4319 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4320 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4321 (Fnext_overlay_change, Fprevious_overlay_change)
4322 (mouse_face_overlay_overlaps, Foverlays_in):
4323 Use ptrdiff_t, not int, for sizes.
4324 (overlays_at, overlays_in): Check for size-calculation overflow.
4326 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4328 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4329 (x_session_initialize): Do not assume string length fits in int.
4331 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4332 This is unlikely, but can occur if DPI is outlandish.
4334 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4335 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4337 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4338 * xrdb.c (magic_file_p, search_magic_path):
4339 Omit last arg SUFFIX; it was always 0. All callers changed.
4340 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4342 * xfont.c (xfont_match): Avoid need for strlen.
4344 * xfns.c: Don't assume strlen fits in int.
4345 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4347 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4348 not unsigned long, as we prefer signed integers. All callers changed.
4349 Detect integer overflow in repeat count.
4350 (message_dolog): Don't assume print length fits in 39 bytes.
4351 (display_mode_element): Don't assume strlen fits in int.
4353 * termcap.c: Don't assume sizes fit in int and never overflow.
4354 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4355 (gobble_line): Check for size-calculation overflow.
4357 * minibuf.c (Fread_buffer):
4358 * lread.c (intern, intern_c_string):
4359 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4360 Don't assume string length fits in int.
4362 * keyboard.c (parse_tool_bar_item):
4363 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4365 * font.c: Don't assume string length fits in int.
4366 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4367 Use ptrdiff_t, not int.
4368 (font_intern_prop): Don't assume string length fits in int.
4369 Don't assume integer property fits in fixnum.
4370 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4372 * filelock.c: Fix some buffer overrun and integer overflow issues.
4373 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4374 Reformulate so as not to need the command string.
4375 Invoke gzip -cd rather than gunzip, as it's more portable.
4376 (lock_info_type, lock_file_1, lock_file):
4377 Don't assume pid_t and time_t fit in unsigned long.
4378 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4379 (current_lock_owner): Prefer signed type for sizes.
4380 Use memcpy, not strncpy, where memcpy is what is really wanted.
4381 Don't assume (via atoi) that time_t and pid_t fit in int.
4382 Check for time_t and/or pid_t out of range, e.g., via a network share.
4383 Don't alloca where an auto var works fine.
4385 * fileio.c: Fix some integer overflow issues.
4386 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4387 Don't assume string length fits in int.
4388 (directory_file_name): Don't assume string length fits in long.
4389 (make_temp_name): Don't assume pid fits in int, or that its print
4390 length is less than 20.
4392 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4394 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4396 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4398 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4399 We prefer signed integers, even for size calculations.
4401 * emacs.c: Don't assume string length fits in 'int'.
4402 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4403 (main): Don't invoke strlen when not needed.
4405 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4406 (XD_DEBUG_MESSAGE): Don't waste a byte.
4408 * callproc.c (getenv_internal_1, getenv_internal)
4410 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4412 * lread.c (invalid_syntax): Omit length argument.
4413 All uses changed. This doesn't fix a bug, but it simplifies the
4414 code away from its former Hollerith-constant appearance, and it's
4415 one less 'int' to worry about when looking at integer-overflow issues.
4416 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4418 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4419 This didn't break anything, but it didn't help either.
4420 It's confusing to put a bogus integer in a place where the actual
4421 value does not matter.
4422 (LIST_END_P): Remove unused macro and its bogus comment.
4423 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4425 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4426 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4428 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4429 We prefer signed types, and the value cannot exceed the EMACS_INT
4430 range anyway (because otherwise the length would not be representable).
4431 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4432 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4433 This avoids a GCC warning when WIDE_EMACS_INT.
4435 * indent.c (sane_tab_width): New function.
4436 (current_column, scan_for_column, Findent_to, position_indentation)
4437 (compute_motion): Use it. This is just for clarity.
4438 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4440 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4442 * lisp.h (lint_assume): New macro.
4443 * composite.c (composition_gstring_put_cache):
4444 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4446 * editfns.c, insdel.c:
4447 Omit unnecessary forward decls, to simplify future changes.
4449 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4451 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4453 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4454 Use much-faster test for byte-length change.
4455 Don't assume string byte-length fits in 'int'.
4456 Check that character arg fits in 'int'.
4457 (mapcar1): Declare byte as byte, for clarity.
4459 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4461 * fns.c (concat): Catch string overflow earlier.
4462 Do not rely on integer wraparound.
4464 * dispextern.h (struct it.overlay_strings_charpos)
4465 (struct it.selective): Now EMACS_INT, not int.
4466 * xdisp.c (forward_to_next_line_start)
4467 (back_to_previous_visible_line_start)
4468 (reseat_at_next_visible_line_start, next_element_from_buffer):
4469 Don't arbitrarily truncate the value of 'selective' to int.
4471 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4473 * composite.c: Don't truncate sizes to 'int'.
4474 (composition_gstring_p, composition_reseat_it)
4475 (composition_adjust_point): Use EMACS_INT, not int.
4476 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4477 not EMACS_UINT, for indexes.
4479 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4481 * buffer.c: Include <verify.h>.
4482 (struct sortvec.priority, struct sortstr.priority):
4483 Now EMACS_INT, not int.
4484 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4485 (struct sortstr.size, record_overlay_string)
4486 (struct sortstrlist.size, struct sortlist.used):
4487 Don't truncate size to int.
4488 (record_overlay_string): Check for size-calculation overflow.
4489 (init_buffer_once): Check at compile-time, not run-time.
4491 2011-06-22 Jim Meyering <meyering@redhat.com>
4493 Don't leak an XBM-image-sized buffer
4494 * image.c (xbm_load): Free the image buffer after using it.
4496 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4499 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4500 that Sun C diagnosed.
4501 * fns.c (secure_hash): Fix pointer signedness issue.
4502 * intervals.c (static_offset_intervals): New function.
4503 (offset_intervals): Use it.
4505 2011-06-21 Leo Liu <sdl.web@gmail.com>
4508 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4511 * fns.c (secure_hash): Rename from crypto_hash_function and change
4512 the first arg to accept symbols.
4513 (Fsecure_hash): New primitive.
4514 (syms_of_fns): New symbols.
4516 2011-06-20 Deniz Dogan <deniz@dogan.se>
4518 * process.c (Fset_process_buffer): Clarify return value in
4521 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4523 * dispnew.c (add_window_display_history): Use BVAR.
4525 * xdisp.c (debug_method_add): Use BVAR.
4526 (check_window_end, dump_glyph_matrix, dump_glyph)
4527 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4529 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4532 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4533 check till after the cache is created in init_frame_faces.
4535 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4537 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4539 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4541 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4542 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4543 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4545 Improve buffer-overflow checking (Bug#8873).
4546 * fileio.c (Finsert_file_contents):
4547 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4548 Remove the old (too-loose) buffer overflow checks.
4549 They weren't needed, since make_gap checks for buffer overflow.
4550 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4551 The old code merely checked for Emacs fixnum overflow, and relied
4552 on undefined (wraparound) behavior. The new code avoids undefined
4553 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4555 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4556 Tune. Don't use wider integers than needed. Don't use alloca.
4557 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4559 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4561 * insdel.c, lisp.h (buffer_overflow): New function.
4562 (insert_from_buffer_1, replace_range, replace_range_2):
4563 * insdel.c (make_gap_larger):
4564 * editfns.c (Finsert_char):
4565 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4567 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4569 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4571 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4573 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4574 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4576 * fileio.c: Don't assume EMACS_INT fits in off_t.
4577 (emacs_lseek): New static function.
4578 (Finsert_file_contents, Fwrite_region): Use it.
4579 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4581 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4583 * fns.c: Don't overflow int when computing a list length.
4584 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4585 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4586 truncation on 64-bit hosts. Check for QUIT every
4587 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4588 faster and is responsive enough.
4589 (Flength): Report an error instead of overflowing an integer.
4590 (Fsafe_length): Return a float if the value is not representable
4591 as a fixnum. This shouldn't happen except in contrived situations.
4592 (Fnthcdr, Fsort): Don't assume list length fits in int.
4593 (Fcopy_sequence): Don't assume vector length fits in int.
4595 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4596 (header_size, word_size): New constants.
4597 (allocate_vectorlike): Don't check size overflow here.
4598 (allocate_vector): Check it here instead, since this is the only
4599 caller of allocate_vectorlike that could cause overflow.
4600 Check that the new vector's length is representable as a fixnum.
4602 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4603 The previous code was bogus. For example, next_almost_prime (32)
4604 returned 39, which is undesirable as it is a multiple of 3; and
4605 next_almost_prime (24) returned 25, which is a multiple of 5 so
4606 why was the code bothering to check for multiples of 7?
4608 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4610 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4612 Variadic C functions now count arguments with ptrdiff_t.
4613 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4614 Back then I didn't know that the Emacs coding style prefers signed int.
4615 Also, in the meantime I found a few more instances where arguments
4616 were being counted with int, which may truncate counts on 64-bit
4617 machines, or EMACS_INT, which may be unnecessarily wide.
4618 * lisp.h (struct Lisp_Subr.function.aMANY)
4619 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4620 Arg counts are now ptrdiff_t, not size_t.
4621 All variadic functions and their callers changed accordingly.
4622 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4623 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4624 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4625 * callint.c (Fcall_interactively): Check arg count for overflow,
4626 to avoid potential buffer overrun. Use signed char, not 'int',
4627 for 'varies' array, so that we needn't bother to check its size
4628 calculation for overflow.
4629 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4630 * eval.c (apply_lambda):
4631 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4632 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4633 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4635 * callint.c (Fcall_interactively): Don't use index var as event count.
4637 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4638 * mem-limits.h (SIZE): Remove; no longer used.
4640 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4642 Remove unnecessary casts.
4643 * xterm.c (x_term_init):
4644 * xfns.c (x_set_border_pixel):
4645 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4646 These aren't needed now that we assume ANSI C.
4648 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4649 It's more likely to cause problems (due to unsigned overflow)
4652 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4654 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4656 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4658 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4660 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4662 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4664 GLYPH_CODE_FACE returns EMACS_INT, not int.
4665 * dispextern.h (merge_faces):
4666 * xfaces.c (merge_faces):
4667 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4668 Don't assume EMACS_INT fits in int.
4670 * character.h (CHAR_VALID_P): Remove unused parameter.
4671 * fontset.c, lisp.h, xdisp.c: All uses changed.
4673 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4675 * fns.c (concat): Minor tuning based on overflow analysis.
4676 This doesn't fix any bugs. Use int to hold character, instead
4677 of constantly refetching from Emacs object. Use XFASTINT, not
4678 XINT, for value known to be a character. Don't bother comparing
4679 a single byte to 0400, as it's always less.
4681 * floatfns.c (Fexpt):
4682 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4684 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4687 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4689 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4690 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4691 incorrectly succeed when S was a string, because 4294967386 was
4692 truncated before it was used.
4694 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4695 Otherwise, an out-of-range integer could cause undefined behavior
4698 * composite.c: Use int, not EMACS_INT, for characters.
4699 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4700 EMACS_INT, for values that are known to be in character range.
4701 This doesn't fix any bugs but is the usual style inside Emacs and
4702 may generate better code on 32-bit machines.
4704 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4705 This is for reasons similar to the recent CHAR_STRING fix.
4706 * charset.c (Fencode_char): Check that character arg is actually
4707 a character. Pass an int to ENCODE_CHAR.
4708 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4709 wider than 'int', as a compile-time check to prevent future regressions
4712 * character.c (char_string): Remove unnecessary casts.
4714 Make sure a 64-bit char is never passed to CHAR_STRING.
4715 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4716 by silently ignoring the top 32 bits, allowing some values
4717 that were far too large to be valid characters.
4718 * character.h: Include <verify.h>.
4719 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4720 arguments are no wider than unsigned, as a compile-time check
4721 to prevent future regressions in this area.
4723 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4724 (Fsubst_char_in_region):
4726 * xdisp.c (decode_mode_spec_coding):
4727 Adjust to CHAR_STRING's new requirement.
4728 * editfns.c (Finsert_char, Fsubst_char_in_region):
4729 * fns.c (concat): Check that character args are actually
4730 characters. Without this test, these functions did the wrong
4731 thing with wildly out-of-range values on 64-bit hosts.
4733 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4734 These casts should not be needed on 32-bit hosts, either.
4735 * keyboard.c (read_char):
4736 * lread.c (Fload): Remove casts to unsigned.
4738 * lisp.h (UNSIGNED_CMP): New macro.
4739 This fixes comparison bugs on 64-bit hosts.
4740 (ASCII_CHAR_P): Use it.
4741 * casefiddle.c (casify_object):
4742 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4743 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4744 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4745 * dispextern.h (FACE_FROM_ID):
4746 * keyboard.c (read_char): Use UNSIGNED_CMP.
4748 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4749 not to EMACS_INT, to avoid GCC warning.
4751 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4753 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4754 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4755 isn't needed on 32-bit machines.
4757 * buffer.c (Fgenerate_new_buffer_name):
4758 Use EMACS_INT for count, not int.
4759 (advance_to_char_boundary): Return EMACS_INT, not int.
4761 * data.c (Qcompiled_function): Now static.
4763 * window.c (window_body_lines): Now static.
4765 * image.c (gif_load): Rename local to avoid shadowing.
4767 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4768 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4769 * alloc.c (make_save_value): Integer argument is now of type
4771 (mark_object): Use ptrdiff_t, not int.
4772 * lisp.h (pD): New macro.
4773 * print.c (print_object): Use it.
4775 * alloc.c: Use EMACS_INT, not int, to count objects.
4776 (total_conses, total_markers, total_symbols, total_vector_size)
4777 (total_free_conses, total_free_markers, total_free_symbols)
4778 (total_free_floats, total_floats, total_free_intervals)
4779 (total_intervals, total_strings, total_free_strings):
4780 Now EMACS_INT, not int. All uses changed.
4781 (Fgarbage_collect): Compute overall total using a double, so that
4782 integer overflow is less likely to be a problem. Check for overflow
4783 when converting back to an integer.
4784 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4785 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4786 These were 'int' variables that could overflow on 64-bit hosts;
4787 they were never used, so remove them instead of repairing them.
4788 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4789 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4790 Previously, this ceilinged at INT_MAX, but that doesn't work on
4792 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4794 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4795 (allocate_vectorlike): Check for ptrdiff_t overflow.
4796 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4797 when a (possibly-narrower) signed value would do just as well.
4798 We prefer using signed arithmetic, to avoid comparison confusion.
4800 * alloc.c: Catch some string size overflows that we were missing.
4801 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4802 for convenience in STRING_BYTES_MAX.
4803 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4804 The definition here is exact; the one in lisp.h was approximate.
4805 (allocate_string_data): Check for string overflow. This catches
4806 some instances we weren't catching before. Also, it catches
4807 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4808 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4809 and ptrdiff_t and EMACS_INT are both 64 bits.
4811 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4812 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4813 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4815 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4817 * alloc.c (Fmake_string): Check for out-of-range init.
4819 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4821 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4823 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4825 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4826 xg_get_default_scrollbar_width.
4828 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4829 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4830 (style_changed_cb): Call update_theme_scrollbar_width and call
4831 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4832 all frames (Bug#8505).
4833 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4834 Call gtk_window_set_resizable if HAVE_GTK3.
4835 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4836 and height if HAVE_GTK3 (Bug#8505).
4837 (scroll_bar_width_for_theme): New variable.
4838 (update_theme_scrollbar_width): New function.
4839 (xg_get_default_scrollbar_width): Move code to
4840 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4841 (xg_initialize): Call update_theme_scrollbar_width.
4843 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4845 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4847 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4849 * frame.c (make_frame): Call other_buffer_safely instead of
4852 * window.c (temp_output_buffer_show): Call display_buffer with
4853 second argument Vtemp_buffer_show_specifiers and reset latter
4854 immediately after the call.
4855 (Vtemp_buffer_show_specifiers): New variable.
4856 (auto_window_vscroll_p, next_screen_context_lines)
4857 (Vscroll_preserve_screen_position): Remove leading asterisks from
4860 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4862 Fix minor problems found by GCC 4.6.0 static checking.
4863 * buffer.c (Qclone_number): Remove for now, as it's unused.
4864 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4865 (record_buffer): Remove unused local.
4866 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4867 (set_frame_buffer_list): Remove; unused.
4868 * frame.h (other_visible_frames): Remove decl.
4869 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4870 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4871 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4873 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4874 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4875 Define only if HAVE_GPM.
4876 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4877 (update_hints_inhibit): Remove; never set. All uses removed.
4878 * widgetprv.h (emacsFrameClassRec): Remove decl.
4879 * window.c (delete_deletable_window): Now returns void, since it
4880 wasn't returning anything.
4881 (compare_window_configurations): Remove unused locals.
4882 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4883 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4884 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4885 the same widths as pointers. This follows up on the 2011-05-06 patch.
4886 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4887 * xterm.h: Likewise.
4888 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4890 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4892 * makefile.w32-in: Update dependencies.
4893 (LISP_H): Add lib/intprops.h.
4895 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4897 * image.c (gif_load): Add animation frame delay to the metadata.
4898 (syms_of_image): Use DEFSYM. New symbol `delay'.
4900 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4902 * window.c (delete_deletable_window): Re-add.
4903 (Fset_window_configuration): Rewrite to handle dead buffers and
4904 consequently deletable windows.
4905 (window_tree, Fwindow_tree): Remove. Supply functionality in
4907 (compare_window_configurations): Simplify code.
4909 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4911 * image.c (imagemagick_load_image): Fix type mismatch.
4912 (Fimagemagick_types): Likewise.
4914 * window.h (replace_buffer_in_windows): Declare.
4916 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4918 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4919 Qclone_number. Remove external declaration of Qdelete_window.
4920 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4922 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4923 Run Qbuffer_list_update_hook if allowed.
4924 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4925 buffer list implementation.
4926 (other_buffer_safely): New function.
4927 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4928 calls to replace_buffer_in_windows and
4929 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4931 (record_buffer): Inhibit quitting and rewrite using quittable
4932 functions. Run Qbuffer_list_update_hook if allowed.
4933 (Frecord_buffer, Funrecord_buffer): New functions.
4934 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4935 Move switch-to-buffer to window.el.
4936 (bury-buffer): Move to window.el.
4937 (Vbuffer_list_update_hook): New variable.
4939 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4942 * window.h (resize_frame_windows): Move up in code.
4943 (Fwindow_frame): Remove EXFUN.
4944 (replace_buffer_in_all_windows): Remove prototype.
4945 (replace_buffer_in_windows_safely): Add prototype.
4947 * window.c: Declare Qdelete_window static again. Move down
4948 declaration of select_count.
4949 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4950 (Fother_window): Move to window.el.
4951 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4952 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4953 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4955 (replace_buffer_in_windows): Implement by calling
4956 Qreplace_buffer_in_windows.
4957 (replace_buffer_in_all_windows): Remove with some functionality
4958 moved into replace_buffer_in_windows_safely.
4959 (replace_buffer_in_windows_safely): New function.
4960 (select_window_norecord, select_frame_norecord): Move in front
4961 of run_window_configuration_change_hook. Remove now obsolete
4963 (Fset_window_buffer): Rewrite doc-string.
4964 Call Qrecord_window_buffer.
4965 (keys_of_window): Move binding for other-window to window.el.
4967 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4969 * dispextern.h (struct image): Replace data member, whose int_val
4970 and ptr_val fields were not used by anything, with a single
4973 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4974 (gif_clear_image, gif_load, imagemagick_load_image)
4975 (gs_clear_image, gs_load): Callers changed.
4977 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4979 * buffer.h: Include <time.h>, for time_t.
4980 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4982 Fix minor problems found by static checking.
4984 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4986 Make identifiers static if they are not used in other modules.
4987 * data.c (Qcompiled_function, Qframe, Qvector):
4988 * image.c (QimageMagick, Qsvg):
4989 * minibuf.c (Qmetadata):
4990 * window.c (resize_window_check, resize_root_window): Now static.
4991 * window.h (resize_window_check, resize_root_window): Remove decls.
4993 * window.c (window_deletion_count, delete_deletable_window):
4995 (window_body_lines): Now static.
4996 (Fdelete_other_windows_internal): Mark vars as initialized.
4997 Make sure 'resize_failed' is initialized.
4998 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4999 (resize_window_apply): Remove unused local.
5000 * window.h (delete_deletable_window): Remove decl.
5002 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5003 (imagemagick_load_image): Fix pointer signedness problem by changing
5004 last arg from unsigned char * to char *. All uses changed.
5005 Also, fix a local for similar reasons.
5006 Remove unused locals. Remove locals to avoid shadowing.
5007 (fn_rsvg_handle_free): Remove; unused.
5008 (svg_load, svg_load_image): Fix pointer signedness problem.
5009 (imagemagick_load_image): Don't use garbage pointer image_wand.
5011 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5013 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5015 * image.c (gif_load): Fix omitted cast error introduced by
5018 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5020 * window.h (resize_proportionally, orig_total_lines)
5021 (orig_top_line): Remove from window structure.
5022 (set_window_height, set_window_width, change_window_heights)
5023 (Fdelete_window): Remove prototypes.
5024 (resize_frame_windows): Remove duplicate declaration.
5026 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5028 * window.h (resize_frame_windows, resize_window_check)
5029 (delete_deletable_window, resize_root_window)
5030 (resize_frame_windows): Declare prototypes.
5032 * window.c (resize_window_apply): Make definition be "static" to
5033 match the prototype.
5035 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5037 * window.c: Remove declarations of Qwindow_size_fixed,
5038 window_min_size_1, window_min_size_2, window_min_size,
5039 size_window, window_fixed_size_p, enlarge_window, delete_window.
5040 Remove static from declaration of Qdelete_window, it's
5041 temporarily needed by Fbury_buffer.
5042 (replace_window): Don't assign orig_top_line and
5044 (Fdelete_window, delete_window): Remove. Window deletion is
5045 handled by window.el.
5046 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5047 Replace Fdelete_window calls with calls to Qdelete_window.
5048 (Fdelete_other_windows): Remove. Deleting other windows is
5049 handled by window.el.
5050 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5051 handled in window.el.
5052 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5053 Window minimum sizes are handled in window.el.
5054 (shrink_windows, size_window, set_window_height)
5055 (set_window_width, change_window_heights, window_height)
5056 (window_width, CURBEG, CURSIZE, enlarge_window)
5057 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5058 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5059 handled in window.el.
5060 (make_dummy_parent): Rename to make_parent_window and give it a
5061 second argument horflag.
5062 (make_window): Don't set resize_proportionally any more.
5063 (Fsplit_window): Remove. Windows are split in window.el.
5064 (save_restore_action, save_restore_orig_size)
5065 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5066 Resize mini windows in window.el.
5067 (grow_mini_window, shrink_mini_window): Implement by calling
5068 Qresize_root_window_vertically, resize_window_check and
5069 resize_window_apply.
5070 (saved_window, Fset_window_configuration, save_window_save):
5071 Do not handle orig_top_line, orig_total_lines, and
5072 resize_proportionally.
5073 (window_min_height, window_min_width): Move to window.el.
5074 (keys_of_window): Move bindings for delete-other-windows,
5075 split-window, delete-window and enlarge-window to window.el.
5077 * buffer.c: Temporarily extern Qdelete_window.
5078 (Fbury_buffer): Temporarily call Qdelete_window instead of
5079 Fdelete_window (Fbury_buffer will move to window.el soon).
5081 * frame.c (set_menu_bar_lines_1): Remove code handling
5082 orig_top_line and orig_total_lines.
5084 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5085 set_window_height but set heights directly.
5086 (change_frame_size_1): Use resize_frame_windows.
5088 * xdisp.c (init_xdisp): Don't use set_window_height but set
5091 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5092 Use resize_frame_windows instead of change_window_heights and run
5093 run_window_configuration_change_hook.
5095 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5096 instead of change_window_heights and run
5097 run_window_configuration_change_hook.
5099 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5101 * window.c (replace_window): Rename second argument REPLACEMENT to
5102 NEW. New third argument SETFLAG. Rewrite.
5103 (delete_window, make_dummy_parent): Call replace_window with
5105 (window_list_1): Move down in code.
5106 (run_window_configuration_change_hook): Move set_buffer part
5107 before select_frame_norecord part in order to unwind correctly.
5108 Rename count1 to count.
5109 (recombine_windows, delete_deletable_window, resize_root_window)
5110 (Fdelete_other_windows_internal)
5111 (Frun_window_configuration_change_hook, make_parent_window)
5112 (resize_window_check, resize_window_apply, Fresize_window_apply)
5113 (resize_frame_windows, Fsplit_window_internal)
5114 (Fdelete_window_internal, Fresize_mini_window_internal):
5116 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5118 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5120 * window.h (window): Add some new members to window structure -
5121 normal_lines, normal_cols, new_total, new_normal, clone_number,
5122 splits, nest, prev_buffers, next_buffers.
5123 (WINDOW_TOTAL_SIZE): Move here from window.c.
5124 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5126 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5128 (make_dummy_parent): Set new members of windows structure.
5129 (make_window): Move down in code. Handle new members of window
5131 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5132 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5133 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5134 (Fset_window_prev_buffers, Fwindow_next_buffers)
5135 (Fset_window_next_buffers, Fset_window_clone_number):
5137 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5138 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5140 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5141 Argument WINDOW can be now internal window too.
5142 (Fwindow_use_time): Move up in code.
5143 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5145 (Fset_window_configuration, saved_window)
5146 (Fcurrent_window_configuration, save_window_save): Handle new
5147 members of window structure.
5148 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5149 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5150 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5151 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5152 Qget_mru_window, Qresize_root_window,
5153 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5154 Qauto_buffer_name; staticpro them.
5156 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5158 * window.c (Fwindow_total_size, Fwindow_left_column)
5159 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5160 (Fwindow_list_1): New functions.
5161 (window_box_text_cols): Replace with window_body_cols.
5162 (Fwindow_width, Fscroll_left, Fscroll_right):
5163 Use window_body_cols instead of window_box_text_cols.
5164 (delete_window, Fset_window_configuration):
5165 Call delete_all_subwindows with window as argument.
5166 (delete_all_subwindows): Take a window as argument and not a
5168 (window_loop): Remove handling of GET_LRU_WINDOW and
5170 (Fget_lru_window, Fget_largest_window): Move to window.el.
5172 * window.h: Extern window_body_cols instead of
5173 window_box_text_cols. delete_all_subwindows now takes a
5174 Lisp_Object as argument.
5176 * indent.c (compute_motion, Fcompute_motion):
5177 Use window_body_cols instead of window_box_text_cols.
5179 * frame.c (delete_frame): Call delete_all_subwindows with root
5182 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5184 * fns.c (Fputhash): Document return value.
5186 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5188 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5190 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5192 Cons<->int and similar integer overflow fixes (Bug#8794).
5194 Check for overflow when converting integer to cons and back.
5195 * charset.c (Fdefine_charset_internal, Fdecode_char):
5196 Use cons_to_unsigned to catch overflow.
5197 (Fencode_char): Use INTEGER_TO_CONS.
5198 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5199 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5200 * data.c (long_to_cons, cons_to_long): Remove.
5201 (cons_to_unsigned, cons_to_signed): New functions.
5202 These signal an error for invalid or out-of-range values.
5203 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5204 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5205 * font.c (Ffont_variation_glyphs):
5206 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5207 * lisp.h: Include <intprops.h>.
5208 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5209 (cons_to_signed, cons_to_unsigned): New decls.
5210 (long_to_cons, cons_to_long): Remove decls.
5211 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5212 (Fprimitive_undo): Use CONS_TO_INTEGER.
5213 * xfns.c (Fx_window_property): Likewise.
5214 * xselect.c: Include <limits.h>.
5215 (x_own_selection, selection_data_to_lisp_data):
5216 Use INTEGER_TO_CONS.
5217 (x_handle_selection_request, x_handle_selection_clear)
5218 (x_get_foreign_selection, Fx_disown_selection_internal)
5219 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5220 (lisp_data_to_selection_data): Use cons_to_unsigned.
5221 (x_fill_property_data): Use cons_to_signed.
5222 Report values out of range.
5224 Check for buffer and string overflow more precisely.
5225 * buffer.h (BUF_BYTES_MAX): New macro.
5226 * lisp.h (STRING_BYTES_MAX): New macro.
5227 * alloc.c (Fmake_string):
5228 * character.c (string_escape_byte8):
5229 * coding.c (coding_alloc_by_realloc):
5230 * doprnt.c (doprnt):
5231 * editfns.c (Fformat):
5233 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5234 since they may not be the same number.
5235 * editfns.c (Finsert_char):
5236 * fileio.c (Finsert_file_contents):
5237 Likewise for BUF_BYTES_MAX.
5239 * image.c: Use ptrdiff_t, not int, for sizes.
5240 (slurp_file): Switch from int to ptrdiff_t.
5242 (slurp_file): Check that file size fits in both size_t (for
5243 malloc) and ptrdiff_t (for sanity and safety).
5245 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5246 if b->modtime has its maximal value.
5248 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5250 Don't assume time_t can fit into int.
5251 * buffer.h (struct buffer.modtime): Now time_t, not int.
5252 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5253 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5255 Minor fixes for signed vs unsigned integers.
5256 * character.h (MAYBE_UNIFY_CHAR):
5257 * charset.c (maybe_unify_char):
5258 * keyboard.c (read_char, reorder_modifiers):
5259 XINT -> XFASTINT, since the integer must be nonnegative.
5260 * ftfont.c (ftfont_spec_pattern):
5261 * keymap.c (access_keymap, silly_event_symbol_error):
5262 XUINT -> XFASTINT, since the integer must be nonnegative.
5263 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5264 since it makes no difference and we prefer signed.
5265 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5266 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5269 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5271 * window.h (Fwindow_frame): Declare.
5273 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5275 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5276 (SPARE_MEMORY): Always define.
5277 (LARGE_REQUEST): Remove.
5278 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5280 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5282 * lisp.h: Move EXFUNS for Fframe_root_window,
5283 Fframe_first_window and Fset_frame_selected_window to window.h.
5285 * window.h: Move EXFUNS for Fframe_root_window,
5286 Fframe_first_window and Fset_frame_selected_window here from
5289 * frame.c (Fwindow_frame, Fframe_first_window)
5290 (Fframe_root_window, Fframe_selected_window)
5291 (Fset_frame_selected_window): Move to window.c.
5292 (Factive_minibuffer_window): Move to minibuf.c.
5293 (Fother_visible_frames_p): New function.
5295 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5297 * window.c (decode_window, decode_any_window): Move up in code.
5298 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5299 (inhibit_frame_unsplittable): Remove unused variable.
5300 (Fwindow_buffer): Move up and rewrite doc-string.
5301 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5302 (Fwindow_prev): New functions.
5303 (Fwindow_frame): Move here from frame.c. Accept any window as
5305 (Fframe_root_window, Fframe_first_window)
5306 (Fframe_selected_window): Move here from frame.c. Accept frame
5307 or arbitrary window as argument. Update doc-strings.
5308 (Fminibuffer_window): Move up in code.
5309 (Fwindow_minibuffer_p): Move up in code and simplify.
5310 (Fset_frame_selected_window): Move here from frame.c.
5312 (Fselected_window, select_window, Fselect_window): Move up in
5313 code. Minor doc-string fixes.
5315 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5317 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5318 Do not assume that spare memory exists; that assumption is valid
5319 only if SYSTEM_MALLOC.
5320 (LARGE_REQUEST): New macro, so that the issue of large requests
5321 is separated from the issue of spare memory.
5323 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5325 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5328 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5330 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5333 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5335 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5337 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5339 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5340 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5342 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5344 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5346 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5348 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5349 (x_clipboard_manager_save): Add return value.
5350 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5352 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5353 Obey Vx_select_enable_clipboard_manager. Catch errors in
5354 x_clipboard_manager_save (Bug#8779).
5355 (Vx_select_enable_clipboard_manager): New variable.
5356 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5358 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5360 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5362 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5364 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5365 in the current matrix if keep_current_p is non-zero.
5367 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5369 * bidi.c (bidi_level_of_next_char): Fix last change.
5371 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5373 Support bidi reordering of text covered by display properties.
5375 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5376 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5377 (bidi_cache_search, bidi_cache_iterator_state)
5378 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5379 (bidi_level_of_next_char, bidi_move_to_visually_next):
5380 Support character positions inside a run of characters covered by a
5382 (bidi_paragraph_init, bidi_resolve_explicit_1)
5383 (bidi_level_of_next_char): Call bidi_fetch_char and
5384 bidi_fetch_char_advance instead of FETCH_CHAR and
5386 (bidi_init_it): Initialize new members.
5387 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5389 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5390 instead of using explicit *_CHAR codes.
5391 (bidi_resolve_explicit, bidi_resolve_weak):
5392 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5393 bidirectional text is supported only in multibyte buffers.
5394 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5395 it to initialize the frame_window_p member of struct bidi_it.
5396 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5397 (bidi_resolve_explicit, bidi_resolve_weak)
5398 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5399 bidi_it->nchars is non-positive.
5400 (bidi_level_of_next_char): Don't try to lookup the cache for the
5401 next/previous character if nothing is cached there yet, or if we
5402 were just reseat()'ed to a new position.
5404 * xdisp.c (set_cursor_from_row): Set start and stop points
5405 according to the row's direction when priming the loop that looks
5406 for the glyph on which to display cursor.
5407 (single_display_spec_intangible_p): Function deleted.
5408 (display_prop_intangible_p): Reimplement to call
5409 handle_display_spec instead of single_display_spec_intangible_p.
5410 Accept 3 additional arguments needed by handle_display_spec.
5411 This fixes incorrect cursor motion across display property with complex
5412 values: lists, `(when COND...)' forms, etc.
5413 (single_display_spec_string_p): Support property values that are
5414 lists with the argument STRING its top-level element.
5415 (display_prop_string_p): Fix the condition for processing a
5416 property that is a list to be consistent with handle_display_spec.
5417 (handle_display_spec): New function, refactored from the
5418 last portion of handle_display_prop.
5419 (compute_display_string_pos): Accept additional argument
5420 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5421 value of a `display' property is a "replacing spec".
5422 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5423 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5424 the display property, but just return a value indicating whether
5425 the display property will replace the characters it covers.
5426 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5427 frame_window_p members of struct bidi_it.
5428 (compute_display_string_pos, compute_display_string_end):
5430 (push_it): Accept second argument POSITION, where pop_it should
5431 jump to continue iteration.
5432 (reseat_1): Initialize bidi_it.disp_pos.
5434 * keyboard.c (adjust_point_for_property): Adjust the call to
5435 display_prop_intangible_p to its new signature.
5437 * dispextern.h (struct bidi_it): New member frame_window_p.
5438 (bidi_init_it): Update prototypes.
5439 (display_prop_intangible_p): Update prototype.
5440 (compute_display_string_pos, compute_display_string_end):
5442 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5445 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5447 Malloc failure behavior now depends on size of allocation.
5448 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5449 * lisp.h: Change signatures accordingly.
5450 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5451 All callers changed. (Bug#8762)
5453 * gnutls.c: Use Emacs's memory allocators.
5454 Without this change, the gnutls library would invoke malloc etc.
5455 directly, which causes problems on non-SYNC_INPUT hosts, and which
5456 runs afoul of improving memory_full behavior. (Bug#8761)
5457 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5458 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5459 xfree instead of the default malloc, realloc, free.
5460 (Fgnutls_boot): No need to check for memory allocation failure,
5461 since xmalloc does that for us.
5463 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5464 * category.c (hash_get_category_set):
5465 * ccl.c (ccl_driver):
5466 * charset.c (Fdefine_charset_internal):
5467 * charset.h (struct charset.hash_index):
5468 * composite.c (get_composition_id, gstring_lookup_cache)
5469 (composition_gstring_put_cache):
5470 * composite.h (struct composition.hash_index):
5471 * dispextern.h (struct image.hash):
5472 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5473 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5474 (hashfn_equal, hashfn_user_defined, make_hash_table)
5475 (maybe_resize_hash_table, hash_lookup, hash_put)
5476 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5477 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5478 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5479 * image.c (make_image, search_image_cache, lookup_image)
5480 (xpm_put_color_table_h):
5481 * lisp.h (struct Lisp_Hash_Table):
5482 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5483 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5484 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5485 * alloc.c (allocate_vectorlike):
5486 Check for overflow in vector size calculations.
5487 * ccl.c (ccl_driver):
5488 Check for overflow when converting EMACS_INT to int.
5489 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5490 need to be updated by these changes.
5491 * fns.c (make_hash_table, maybe_resize_hash_table):
5492 Check for integer overflow with large hash tables.
5493 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5494 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5495 (SXHASH_REDUCE): New macro.
5496 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5497 Use it instead of discarding useful hash info with large hash values.
5498 (sxhash_float): New function.
5499 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5500 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5501 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5502 Rewrite to use FIXNUM_BITS, as this simplifies things.
5503 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5504 Adjust signatures to match updated version of code.
5505 (consing_since_gc): Now EMACS_INT, since a single hash table can
5506 use more than INT_MAX bytes.
5508 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5510 Make it possible to build with GCC-4.6+ -O2 -flto.
5512 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5514 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5516 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5517 Call minibuffer-inactive-mode.
5519 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5521 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5522 Update dependencies.
5524 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5526 * data.c (init_data): Remove code for UTS, this system is not
5529 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5531 Don't force ./temacs to start in terminal mode.
5533 * frame.c (make_initial_frame): Initialize faces in all cases, not
5534 only when CANNOT_DUMP is defined.
5535 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5537 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5539 * dispnew.c (add_window_display_history): Use const for the string
5540 pointer. Remove declaration, not needed.
5542 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5544 Use 'inline', not 'INLINE'.
5545 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5546 * alloc.c, fontset.c (INLINE): Remove.
5547 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5548 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5549 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5550 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5551 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5553 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5555 Make it possible to run ./temacs.
5557 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5558 syms_of_callproc does the same thing. Remove test for
5559 "initialized", do it in the caller.
5560 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5562 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5564 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5565 (read_minibuf): Use get_minibuffer.
5566 (syms_of_minibuf): Use DEFSYM.
5567 (Qmetadata): New var.
5568 * data.c (Qbuffer): Don't make it static.
5569 (syms_of_data): Use DEFSYM.
5571 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5573 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5574 (CCL_CODE_MIN): New macro.
5576 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5578 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5580 * eval.c (Qdebug): Now static.
5581 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5582 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5583 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5585 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5587 * image.c: Various fixes to ImageMagick code comments.
5588 (Fimagemagick_types): Doc fix.
5590 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5592 Minor fixes prompted by GCC 4.6.0 warnings.
5594 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5596 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5597 (x_clipboard_manager_save_all): Move extern decl to ...
5598 * xterm.h: ... here, so that it can be checked for consistency.
5600 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5602 * xselect.c (x_clipboard_manager_save_frame)
5603 (x_clipboard_manager_save_all): New functions.
5604 (Fx_clipboard_manager_save): Lisp function deleted.
5606 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5607 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5609 * xterm.h: Update prototype.
5611 2011-05-28 William Xu <william.xwl@gmail.com>
5613 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5616 2011-05-28 Jim Meyering <meyering@redhat.com>
5618 Avoid a sign-extension bug in crypto_hash_function.
5619 * fns.c (to_uchar): Define.
5620 (crypto_hash_function): Use it to convert some newly-signed
5621 variables to unsigned, to avoid sign-extension bugs. For example,
5622 without this change, (md5 "truc") would evaluate to
5623 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5624 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5625 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5627 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5629 Integer overflow fixes.
5631 * dbusbind.c: Serial number integer overflow fixes.
5632 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5633 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5634 to hold a serial number that is too large for a fixnum.
5635 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5636 Check for serial numbers out of range. Decode any serial number
5637 that was so large that it became a float. (Bug#8722)
5639 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5640 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5641 Use XFASTINT rather than XUINT when numbers are nonnegative.
5642 (xd_append_arg, Fdbus_method_return_internal):
5643 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5644 arguments, check that Lisp number is nonnegative, rather than
5645 silently wrapping negative numbers around. (Bug#8722)
5646 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5649 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5651 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5653 ccl: add integer overflow checks
5654 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5655 (IN_INT_RANGE): New macros.
5656 (ccl_driver): Use them to check for integer overflow when
5657 decoding a CCL program. Many of the new checks are whether XINT (x)
5658 fits in int; it doesn't always, on 64-bit hosts. The new version
5659 doesn't catch all possible integer overflows, but it's an
5660 improvement. (Bug#8719)
5662 * alloc.c (make_event_array): Use XINT, not XUINT.
5663 There's no need for unsigned here.
5665 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5666 This follows up to the 2011-05-06 change that substituted uintptr_t
5667 for EMACS_INT. This case wasn't caught back then.
5669 Rework Fformat to avoid integer overflow issues.
5670 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5671 now (part of C89). Include <verify.h>.
5672 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5673 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5674 (Fformat): Avoid the prepass trying to compute sizes; it was only
5675 approximate and thus did not catch overflow reliably. Instead, walk
5676 through the format just once, formatting and computing sizes as we go,
5677 checking for integer overflow at every step, and allocating a larger
5678 buffer as needed. Keep track separately whether the format is
5679 multibyte. Keep only the most-recently calculated precision, rather
5680 than them all. Record whether each argument has been converted to
5681 string. Use EMACS_INT, not int, for byte and char and arg counts.
5682 Support field widths and precisions larger than INT_MAX. Avoid
5683 sprintf's undefined behavior with conversion specifications such as %#d
5684 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5685 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5686 formatting out-of-range floating point numbers with int
5689 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5691 * data.c: Avoid integer truncation in expressions involving floats.
5692 * data.c: Include <intprops.h>.
5693 (arith_driver): When there's an integer overflow in an expression
5694 involving floating point, convert the integers to floating point
5695 so that the resulting value does not suffer from catastrophic
5696 integer truncation. For example, on a 64-bit host (* 4
5697 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5698 Do not rely on undefined behavior after integer overflow.
5700 merge count_size_as_multibyte, parse_str_to_multibyte
5701 * character.c, character.h (count_size_as_multibyte):
5702 Rename from parse_str_to_multibyte; all uses changed.
5703 Check for integer overflow.
5704 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5705 since it's now a duplicate of the other. This is more of
5706 a character than a buffer op, so better that it's in character.c.
5707 * fns.c, print.c: Adjust to above changes.
5709 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5711 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5713 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5715 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5716 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5717 (x_clipboard_manager_save): Now static.
5718 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5720 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5721 (crypto_hash_function): Now static.
5722 Fix pointer signedness problems. Avoid unnecessary initializations.
5724 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5726 * termhooks.h (Vselection_alist): Make it terminal-local.
5728 * terminal.c (create_terminal): Initialize it.
5730 * xselect.c: Support for clipboard managers.
5731 (Vselection_alist): Move to termhooks.h as terminal-local var.
5732 (LOCAL_SELECTION): New macro.
5733 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5734 (symbol_to_x_atom): Remove gratuitous arg.
5735 (x_handle_selection_request, lisp_data_to_selection_data)
5736 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5737 (x_own_selection, x_get_local_selection, x_convert_selection):
5738 New arg, specifying work frame. Use terminal-local Vselection_alist.
5739 (some_frame_on_display): Delete unused function.
5740 (Fx_own_selection_internal, Fx_get_selection_internal)
5741 (Fx_disown_selection_internal, Fx_selection_owner_p)
5742 (Fx_selection_exists_p): New optional frame arg.
5743 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5744 (x_handle_selection_clear): Don't treat other terminals with the
5745 same keyboard specially. Use the terminal-local Vselection_alist.
5746 (x_clear_frame_selections): Use Frun_hook_with_args.
5748 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5750 * xterm.h: Add support for those atoms.
5752 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5754 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5755 (converted_selections, conversion_fail_tag): New global variables.
5756 (x_selection_request_lisp_error): Free the above.
5757 (x_get_local_selection): Remove unnecessary code.
5758 (x_reply_selection_request): Args changed; handle arbitrary array
5759 of converted selections stored in converted_selections.
5760 Separate the XChangeProperty and SelectionNotify steps.
5761 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5762 (x_convert_selection): New function.
5763 (x_handle_selection_event): Simplify.
5764 (x_get_foreign_selection): Don't ignore incoming requests while
5765 waiting for an answer; this will fail when we implement
5766 SAVE_TARGETS, and seems unnecessary anyway.
5767 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5768 (Vx_sent_selection_functions): Doc fix.
5770 2011-05-26 Leo Liu <sdl.web@gmail.com>
5772 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5774 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5776 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5778 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5779 for fringe update if it has periodic bitmap.
5780 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5781 and fringe_bitmap_periodic_p.
5783 * fringe.c (get_fringe_bitmap_data): New function.
5784 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5785 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5786 row. Mark glyph row for fringe update if periodicity changed.
5788 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5789 for fringe update unless it has periodic bitmap.
5791 2011-05-25 Kenichi Handa <handa@m17n.org>
5793 * xdisp.c (get_next_display_element): Set correct it->face_id for
5794 a static composition.
5796 2011-05-24 Leo Liu <sdl.web@gmail.com>
5799 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5801 * fns.c (crypto_hash_function, Fsha1): New function.
5802 (Fmd5): Use crypto_hash_function.
5803 (syms_of_fns): Add Ssha1.
5805 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5807 * gnutls.c: Remove unused macros.
5808 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5809 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5810 Remove macros that are defined and never used.
5811 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5813 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5815 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5816 (Fx_get_selection_internal): Minor cleanup.
5817 (Fx_own_selection_internal): Rename arguments for consistency with
5820 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5822 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5824 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5826 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5828 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5830 * dispnew.c (scrolling_window): Don't exclude the case that the
5831 last enabled row in the desired matrix touches the bottom boundary.
5833 2011-05-21 Glenn Morris <rgm@gnu.org>
5835 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5836 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5837 and add some more files.
5839 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5841 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5842 report_file_error introduced by the change from 2011-05-07.
5844 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5846 * systime.h (Time): Define only if emacs is defined.
5847 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5848 where the include path doesn't have X11/X.h by default. See
5849 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5851 2011-05-20 Kenichi Handa <handa@m17n.org>
5853 * composite.c (find_automatic_composition): Fix previous change.
5855 2011-05-20 Glenn Morris <rgm@gnu.org>
5857 * lisp.mk: New file, split from Makefile.in.
5858 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5859 (shortlisp): Remove.
5860 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5862 2011-05-19 Glenn Morris <rgm@gnu.org>
5864 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5865 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5866 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5867 (lisp): Set the order to that of loadup.el.
5868 (shortlisp): Make it a copy of $lisp.
5869 (SOME_MACHINE_LISP): Remove.
5870 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5871 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5873 2011-05-18 Kenichi Handa <handa@m17n.org>
5875 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5876 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5877 (find_automatic_composition): Mostly rewrite for efficiency.
5879 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5881 * makefile.w32-in: Update dependencies.
5883 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5885 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5886 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5888 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5890 Fix some integer overflow issues, such as string length overflow.
5892 * insdel.c (count_size_as_multibyte): Check for string overflow.
5894 * character.c (lisp_string_width): Check for string overflow.
5895 Use EMACS_INT, not int, for string indexes and lengths; in
5896 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5897 the resulting string length overflows an EMACS_INT; instead,
5898 report a string overflow if no precision given. When checking for
5899 precision exhaustion, use a check that cannot possibly have
5900 integer overflow. (Bug#8675)
5901 * character.h (lisp_string_width): Adjust to new signature.
5903 * alloc.c (string_overflow): New function.
5904 (Fmake_string): Use it. This doesn't change behavior, but saves
5905 a few bytes and will simplify future changes.
5906 * character.c (string_escape_byte8): Likewise.
5907 * lisp.h (string_overflow): New decl.
5909 Fixups, following up to the user-interface timestamp change.
5910 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5911 for UI timestamps, instead of unsigned long.
5912 * msdos.c (mouse_get_pos): Likewise.
5913 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5914 * w32gui.h (Time): Define by including "systime.h" rather than by
5915 declaring it ourselves. (Bug#8664)
5917 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5918 * image.c (clear_image_cache): Likewise.
5920 * term.c (term_mouse_position): Don't assume time_t wraparound.
5922 Be more systematic about user-interface timestamps.
5923 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5924 and sometimes 'EMACS_UINT', to represent these timestamps.
5925 This change causes it to use 'Time' uniformly, as that's what X uses.
5926 This makes the code easier to follow, and makes it easier to catch
5927 integer overflow bugs such as Bug#8664.
5928 * frame.c (Fmouse_position, Fmouse_pixel_position):
5929 Use Time, not unsigned long, for user-interface timestamps.
5930 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5931 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5932 * keyboard.h (last_event_timestamp): Likewise.
5933 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5934 * menu.h (xmenu_show): Likewise.
5935 * term.c (term_mouse_position): Likewise.
5936 * termhooks.h (struct input_event.timestamp): Likewise.
5937 (struct terminal.mouse_position_hook): Likewise.
5938 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5939 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5940 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5941 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5943 * menu.h, termhooks.h: Include "systime.h", for Time.
5945 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5946 Don't assume that the difference between two unsigned long values
5947 can fit into an integer. At this point, we know button_down_time
5948 <= event->timestamp, so the difference must be nonnegative, so
5949 there's no need to cast the result if double-click-time is
5950 nonnegative, as it should be; check that it's nonnegative, just in
5951 case. This bug is triggered when events are more than 2**31 ms
5952 apart (about 25 days). (Bug#8664)
5954 * xselect.c (last_event_timestamp): Remove duplicate decl.
5955 (x_own_selection): Remove needless cast to unsigned long.
5957 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5958 that always fit in int. Use a sentinel instead of a counter, to
5959 avoid a temp and to allay GCC's concerns about possible int overflow.
5960 * frame.h (struct frame): Use int for menu_bar_items_used
5961 instead of EMACS_INT, since it always fits in int.
5963 * menu.c (grow_menu_items): Check for int overflow.
5965 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5967 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5968 Before, the code was not consistent. These values cannot exceed
5969 2**31 - 1 so there's no need to make them unsigned.
5970 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5971 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5972 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5974 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5976 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5977 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5978 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5979 presumably because the widths might not match.
5981 * window.c (size_window): Avoid needless test at loop start.
5983 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5985 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5987 2011-05-12 Drew Adams <drew.adams@oracle.com>
5989 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5991 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5993 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5994 `width' to `bar_area_x' and `bar_area_width', respectively.
5995 (x_scroll_run): Take account of fringe background extension.
5997 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5998 Rename local vars `left' and `width' to `bar_area_x' and
5999 `bar_area_width', respectively.
6000 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6001 background extension.
6003 2011-05-10 Jim Meyering <meyering@redhat.com>
6005 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6007 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6009 * image.c (Finit_image_library): Return t for built-in image types,
6010 like pbm and xbm. (Bug#8640)
6012 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6014 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6016 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6018 * w32console.c (Fset_screen_color): Doc fix.
6019 (Fget_screen_color): New function.
6020 (syms_of_ntterm): Defsubr it.
6022 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6023 unlink the temporary file if Fcall_process didn't create it in the
6025 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6026 child process will be redirected to a file specified with `:file'.
6027 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6028 cue to call_process_cleanup not to close that handle.
6030 2011-05-07 Ben Key <bkey76@gmail.com>
6032 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6033 one of two shell specific rules, either bootstrap-temacs-CMD or
6034 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6035 to the previous implementation of the bootstrap-temacs rule.
6036 The bootstrap-temacs-CMD rule is similar to the previous
6037 implementation of the bootstrap-temacs rule except that it
6038 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6041 These changes, along with some changes to nt/configure.bat,
6042 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6043 earlier fix to add support for --cflags and --ldflags options
6044 that include quotes so that it works whether make uses cmd or
6047 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6049 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6050 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6052 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6053 a string. Handle both cases.
6054 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6055 (Fdbus_register_method): Use Qinvalid_function.
6057 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6059 * makefile.w32-in: Update dependencies.
6060 (LISP_H): Add inttypes.h and stdin.h.
6061 (PROCESS_H): Add unistd.h.
6063 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6065 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6066 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6068 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6070 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6072 * term.c (vfatal): Remove stray call to va_end.
6073 It's not needed and the C Standard doesn't allow it here anyway.
6075 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6076 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6078 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6081 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6083 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6085 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6087 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6089 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6091 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6092 * charset.c (Fdefine_charset_internal): Don't initialize
6093 charset.code_space[15]. The value was garbage, on hosts with
6094 32-bit int (Bug#8600).
6096 * lread.c (read_integer): Be more consistent with string-to-number.
6097 Use string_to_number to do the actual conversion; this avoids
6098 rounding errors and fixes some other screwups. Without this fix,
6099 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6100 (digit_to_number): Move earlier, for benefit of read_integer.
6101 Return -1 if the digit is out of range for the base, -2 if it is
6102 not a digit in any supported base. (Bug#8602)
6104 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6106 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6107 to match comment at start of function. This also removes a
6108 GCC warning about overflow in a 32+64-bit port.
6110 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6112 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6113 Reported by Stefan Monnier in
6114 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6115 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6116 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6118 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6119 (EMACS_UINTPTR): Likewise, with uintptr_t.
6121 * lisp.h: Prefer 64-bit EMACS_INT if available.
6122 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6123 on 32-bit hosts that have 64-bit int, so that they can access
6125 However, temporarily disable this change unless the temporary
6126 symbol WIDE_EMACS_INT is defined.
6128 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6130 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6131 This removes an assumption that EMACS_INT and long are the same
6132 width as pointers. The assumption is true for Emacs porting targets
6133 now, but we want to make other targets possible.
6134 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6135 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6136 In the rest of the code, change types of integers that hold casted
6137 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6138 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6139 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6140 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6141 No need to cast type when ORing.
6142 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6143 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6144 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6145 assume EMACS_INT is the same width as char *.
6146 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6147 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6148 Remove no-longer-needed casts.
6149 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6150 (xg_tool_bar_help_callback, xg_make_tool_item):
6151 Use EMACS_INTPTR to hold an integer
6152 that will be cast to void *; this can avoid a GCC warning
6153 if EMACS_INT is not the same width as void *.
6154 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6155 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6156 (current_message_1, set_message_1):
6157 Use a local to convert to proper width without a cast.
6158 * xmenu.c (dialog_selection_callback): Likewise.
6160 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6161 Also, don't assume VALBITS / RAND_BITS is less than 5,
6162 and don't rely on undefined behavior when shifting a 1 left into
6164 * lisp.h (get_random): Change signature to match.
6166 * lread.c (hash_string): Use size_t, not int, for hash computation.
6167 Normally we prefer signed values; but hashing is special, because
6168 it's better to use unsigned division on hash table sizes so that
6169 the remainder is nonnegative. Also, size_t is the natural width
6170 for hashing into memory. The previous code used 'int', which doesn't
6171 retain enough info to hash well into very large tables.
6172 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6174 * dbusbind.c: Don't possibly lose pointer info when converting.
6175 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6176 Use XPNTR rather than XHASH, so that the high-order bits of
6177 the pointer aren't lost when converting through void *.
6179 * eval.c (Fautoload): Don't double-shift a pointer.
6181 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6183 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6185 * gnutls.c (DEF_GNUTLS_FN):
6186 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6188 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6190 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6193 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6195 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6196 New version that can reserve upto 2GB of heap space.
6198 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6200 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6202 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6204 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6205 `gnutls_certificate_set_x509_key_file'.
6207 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6209 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6210 Update dependencies.
6212 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6214 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6215 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6216 Remove unused parameter `fildes'.
6217 * process.c (read_process_output, send_process): Don't pass it.
6219 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6221 Fix previous change: the library cache is defined in w32.c.
6222 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6223 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6225 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6227 Implement dynamic loading of GnuTLS on Windows.
6229 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6230 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6231 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6234 * gnutls.c (Qgnutls_dll): Define.
6235 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6236 (gnutls_*): Declare function pointers.
6237 (init_gnutls_functions): New function to initialize function pointers.
6238 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6239 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6240 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6241 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6242 (emacs_gnutls_write, emacs_gnutls_read)
6243 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6244 (Fgnutls_available_p): New function.
6245 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6246 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6247 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6249 * image.c: Include w32.h.
6250 (Vimage_type_cache): Delete.
6251 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6252 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6253 (w32_delayed_load): Move to w32.c.
6255 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6257 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6258 (w32_delayed_load): Move from image.c. When loading a library, record
6259 its filename in the :loaded-from property of the library id.
6260 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6261 Initialize and staticpro them.
6262 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6264 * process.c: Include lisp.h before w32.h, not after.
6265 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6266 instead of gnutls_record_check_pending.
6268 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6270 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6272 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6273 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6276 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6278 * xterm.c (x_set_frame_alpha): Do not set property on anything
6279 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6281 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6283 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6285 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6287 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6288 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6289 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6290 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6291 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6292 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6293 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6294 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6295 (Qgnutls_bootprop_callbacks_verify): Make static.
6297 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6299 * callproc.c: Indentation fixup.
6301 * sysdep.c (wait_for_termination_1): Make static.
6302 (wait_for_termination, interruptible_wait_for_termination):
6303 Move after wait_for_termination_1.
6305 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6307 * sysdep.c (interruptible_wait_for_termination): New function
6308 which is like wait_for_termination, but allows keyboard
6311 * callproc.c (Fcall_process): Add (:file "file") as an option for
6313 (Fcall_process_region): Ditto.
6315 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6317 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6318 rather than `XVECTOR (FOO)->size'.
6320 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6321 inttypes.h, as a gnulib replacement is used if it not available in
6324 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6326 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6327 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6328 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6330 * coding.c (coding_alloc_by_realloc): Error out if destination
6331 will grow beyond MOST_POSITIVE_FIXNUM.
6332 (decode_coding_emacs_mule): Abort if there isn't enough place in
6333 charbuf for the composition carryover bytes. Reserve an extra
6334 space for up to 2 characters produced in a loop.
6335 (decode_coding_iso_2022): Abort if there isn't enough place in
6336 charbuf for the composition carryover bytes.
6338 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6340 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6341 aborting when %lld or %lll format is passed.
6342 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6343 %llo or %llx format is passed. (Bug#8545)
6345 * window.c (window_scroll_line_based): Use a marker instead of
6346 simple variables to record original value of point. (Bug#7952)
6348 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6349 produced by %s or %c overflows available buffer space. (Bug#8545)
6351 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6353 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6354 (SIZE_MAX): Move defn after all includes, as they might #define it.
6356 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6358 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6360 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6362 * keyboard.c (Qdelayed_warnings_hook): Define.
6363 (command_loop_1): Run `delayed-warnings-hook'
6364 if Vdelayed_warnings_list is non-nil.
6365 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6366 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6368 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6370 * doprnt.c (doprnt): Don't return value smaller than the buffer
6371 size if the message was truncated. (Bug#8545).
6373 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6375 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6376 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6378 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6380 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6382 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6384 * makefile.w32-in: Update dependencies.
6386 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6388 Improve `doprnt' and its usage. (Bug#8545)
6389 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6390 `format_end'. Remove support for %l as a conversion specifier.
6391 Don't use xrealloc. Improve diagnostics when the %l size modifier
6392 is used. Update the commentary.
6394 * eval.c (verror): Simplify calculation of size_t.
6396 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6399 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6401 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6404 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6406 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6407 This makes this file independent of the recent pseudovector change.
6409 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6411 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6413 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6414 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6415 Remove unused local.
6416 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6418 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6419 GCC 4.6.0 optimizes based on type-based alias analysis.
6420 For example, if b is of type struct buffer * and v of type struct
6421 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6422 != &v->size, and therefore "v->size = 1; b->size = 2; return
6423 v->size;" must therefore return 1. This assumption is incorrect
6424 for Emacs, since it type-puns struct Lisp_Vector * with many other
6425 types. To fix this problem, this patch adds a new type struct
6426 vectorlike_header that documents the constraints on layout of vectors
6427 and pseudovectors, and helps optimizing compilers not get fooled
6428 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6429 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6430 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6432 (XSETPVECTYPE): Rewrite in terms of new macro.
6433 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6434 This is a bit clearer, and further avoids the possibility of
6435 undesirable aliasing.
6436 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6437 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6438 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6439 since Lisp_Subr is a special case (no "next" field).
6440 (ASIZE): Now uses header.size rather than size.
6441 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6442 to avoid the hassle of writing XVECTOR (foo)->header.size.
6443 (struct vectorlike_header): New type.
6444 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6445 object, to help avoid aliasing.
6446 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6447 (SUBRP): Likewise, since Lisp_Subr is a special case.
6448 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6449 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6450 (struct Lisp_Hash_Table): Combine first two members into a single
6451 struct vectorlike_header member. All uses of "size" and "next" members
6452 changed to be "header.size" and "header.next".
6453 * buffer.h (struct buffer): Likewise.
6454 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6455 * frame.h (struct frame): Likewise.
6456 * process.h (struct Lisp_Process): Likewise.
6457 * termhooks.h (struct terminal): Likewise.
6458 * window.c (struct save_window_data, struct saved_window): Likewise.
6459 * window.h (struct window): Likewise.
6460 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6461 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6462 * buffer.c (init_buffer_once): Likewise.
6463 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6465 * process.c (Fformat_network_address): Use local var for size,
6468 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6470 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6471 * data.c (atof): Remove decl; no longer used or needed.
6472 (digit_to_number): Move to lread.c.
6473 (Fstring_to_number): Use new string_to_number function, to be
6474 consistent with how the Lisp reader treats infinities and NaNs.
6475 Do not assume that floating-point numbers represent EMACS_INT
6476 without losing information; this is not true on most 64-bit hosts.
6477 Avoid double-rounding errors, by insisting on integers when
6478 parsing non-base-10 numbers, as the documentation specifies.
6479 * lisp.h (string_to_number): New decl, replacing ...
6480 (isfloat_string): Remove.
6481 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6482 (read1): Do not accept +. and -. as integers; this
6483 appears to have been a coding error. Similarly, do not accept
6484 strings like +-1e0 as floating point numbers. Do not report
6485 overflow for integer overflows unless the base is not 10 which
6486 means we have no simple and reliable way to continue.
6487 Break out the floating-point parsing into a new
6488 function string_to_number, so that Fstring_to_number parses
6489 floating point numbers consistently with the Lisp reader.
6490 (digit_to_number): Move here from data.c. Make it static inline.
6491 (E_CHAR, EXP_INT): Remove, replacing with ...
6492 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6493 (string_to_number): New function, replacing isfloat_string.
6494 This function checks for valid syntax and produces the resulting
6495 Lisp float number too. Rework it so that string-to-number
6496 no longer mishandles examples like "1.0e+". Use strtoumax,
6497 so that overflow for non-base-10 numbers is reported only when
6498 there's no portable and simple way to convert to floating point.
6500 * textprop.c (set_text_properties_1): Rewrite for clarity,
6501 and to avoid GCC warning about integer overflow.
6503 * intervals.h (struct interval): Use EMACS_INT for members
6504 where EMACS_UINT might cause problems. See
6505 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6506 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6507 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6509 (offset_intervals): Tell GCC not to worry about length overflow
6510 when negating a negative length.
6512 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6513 (overrun_check_free): Likewise.
6515 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6516 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6519 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6520 (gnutls_make_error): Rename local to avoid shadowing.
6521 (gnutls_emacs_global_deinit): ifdef out; not used.
6522 (Fgnutls_boot): Use const for pointer to readonly storage.
6523 Comment out unused local. Fix pointer signedness problems.
6525 * lread.c (openp): Don't stuff size_t into an 'int'.
6526 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6527 about possible signed overflow.
6529 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6530 (GDK_KEY_g): Don't define if already defined.
6531 (xg_prepare_tooltip): Avoid pointer signedness problem.
6532 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6534 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6535 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6537 * xfns.c (Fx_window_property): Simplify a bit,
6538 to make a bit faster and to avoid GCC 4.6.0 warning.
6539 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6541 * fns.c (internal_equal): Don't assume size_t fits in int.
6543 * alloc.c (compact_small_strings): Tighten assertion a little.
6545 Replace pEd with more-general pI, and fix some printf arg casts.
6546 * lisp.h (pI): New macro, generalizing old pEd macro to other
6547 conversion specifiers. For example, use "...%"pI"d..." rather
6548 than "...%"pEd"...".
6549 (pEd): Remove. All uses replaced with similar uses of pI.
6550 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6551 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6552 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6553 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6554 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6555 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6556 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6558 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6559 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6560 * print.c (safe_debug_print, print_object): Likewise.
6561 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6563 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6564 avoiding the 0 flag, which is not portable.
6565 * process.c (Fmake_network_process): Use pI to avoid cast.
6566 * region-cache.c (pp_cache): Likewise.
6567 * xdisp.c (decode_mode_spec): Likewise.
6568 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6569 behavior on 64-bit hosts with printf arg.
6570 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6571 (x_stop_queuing_selection_requests): Likewise.
6572 (x_get_window_property): Don't truncate byte count to an 'int'
6575 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6576 here, since it parses constructs like leading '-' and spaces,
6577 which are not wanted; and it overflows with large numbers.
6578 Instead, simply match F[0-9]+, which is what is wanted anyway.
6580 * alloc.c: Remove unportable assumptions about struct layout.
6581 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6582 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6583 (allocate_vectorlike, make_pure_vector): Use the new macros,
6584 plus offsetof, to remove unportable assumptions about struct layout.
6585 These assumptions hold on all porting targets that I know of, but
6586 they are not guaranteed, they're easy to remove, and removing them
6587 makes further changes easier.
6589 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6590 This doesn't fix a bug but makes the code clearer.
6591 (string_overrun_cookie): Now const. Use initializers that
6592 don't formally overflow signed char, to avoid warnings.
6593 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6594 can cause Emacs to crash when string overrun checking is enabled.
6595 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6596 multiple of sizeof (EMACS_INT); it need not be, if
6597 alignof(EMACS_INT) < sizeof (EMACS_INT).
6598 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6600 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6602 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6604 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6606 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6607 supposed to be handshaking. (Bug#8556)
6608 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6610 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6612 * lisp.h (Qdebug): List symbol.
6613 * eval.c (Qdebug): Restore global linkage.
6614 * keyboard.c (debug-on-event): New variable.
6615 (handle_user_signal): Break into debugger when debug-on-event
6616 matches the current signal symbol.
6618 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6620 * alloc.c (check_sblock, check_string_bytes)
6621 (check_string_free_list): Convert to standard C.
6623 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6625 * w32.c (emacs_gnutls_push): Fix typo.
6627 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6629 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6630 "cast to pointer from integer of different size".
6632 Improve doprnt and its use in verror. (Bug#8545)
6633 * doprnt.c (doprnt): Document the set of format control sequences
6634 supported by the function. Use SAFE_ALLOCA instead of always
6637 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6638 is one byte too soon. Don't use xrealloc; instead xfree and
6641 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6643 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6646 * gnutls.c: Renamed global_initialized to
6647 gnutls_global_initialized. Added internals for the
6648 :verify-hostname-error, :verify-error, and :verify-flags
6649 parameters of `gnutls-boot' and documented those parameters in the
6650 docstring. Start callback support.
6651 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6652 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6653 on error. Return error code.
6654 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6655 (emacs_gnutls_read): Likewise.
6656 (Fgnutls_boot): Return handshake error code.
6657 (emacs_gnutls_handle_error): New function.
6658 (wsaerror_to_errno): Likewise.
6660 * w32.h (emacs_gnutls_pull): Add prototype.
6661 (emacs_gnutls_push): Likewise.
6663 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6664 (emacs_gnutls_push): Likewise.
6666 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6668 * process.c (wait_reading_process_output): Check if GnuTLS
6669 buffered some data internally if no FDs are set for TLS
6672 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6673 (LIBS): Link to USER_LIBS.
6674 ($(BLD)/gnutls.$(0)): New target.
6676 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6678 * xdisp.c (handle_single_display_spec): Rename the
6679 display_replaced_before_p argument into display_replaced_p, to
6680 make it consistent with the commentary. Fix typos in the
6683 * textprop.c (syms_of_textprop): Remove dead code.
6684 (copy_text_properties): Delete obsolete commentary about an
6685 interface that was deleted long ago. Fix typos in the description
6688 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6689 to changes in oldXMenu/XMenu.h from 2011-04-16.
6690 <menu_help_message, prev_menu_help_message>: Constify.
6691 (IT_menu_make_room): menu->help_text is now `const char **';
6694 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6695 to changes in oldXMenu/XMenu.h from 2011-04-16.
6696 (struct XMenu): Declare `help_text' `const char **'.
6698 * xfaces.c <Qunspecified>: Make extern again.
6700 * syntax.c: Include sys/types.h before including regex.h, as
6703 * doc.c (get_doc_string): Improve the format passed to `error'.
6705 * doprnt.c (doprnt): Improve commentary.
6707 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6709 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6712 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6713 changes in globals.h immediately force recompilation.
6714 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6715 $(CURDIR)/s/ms-w32.h.
6716 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6718 * character.c (Fchar_direction): Function deleted.
6719 (syms_of_character): Don't defsubr it.
6720 <char-direction-table>: Deleted.
6722 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6724 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6725 * doprnt.c: Include limits.h.
6726 (SIZE_MAX): New macro.
6727 (doprnt): Return a size_t value. 2nd arg is now size_t.
6728 Many local variables are now size_t instead of int or unsigned.
6729 Improve overflow protection. Support `l' modifier for integer
6730 conversions. Support %l conversion. Don't assume an EMACS_INT
6731 argument for integer conversions and for %c.
6733 * lisp.h (doprnt): Restore prototype.
6735 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6738 * Makefile.in (base_obj): Add back doprnt.o.
6740 * deps.mk (doprnt.o): Add back prerequisites.
6741 (callint.o): Depend on character.h.
6743 * eval.c (internal_lisp_condition_case): Include the handler
6744 representation in the error message.
6745 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6746 when breaking from the loop.
6748 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6750 * callint.c (Fcall_interactively): When displaying error message
6751 about invalid control letter, pass the character's codepoint, not
6752 a pointer to its multibyte form. Improve display of the character
6753 in octal and display also its hex code.
6755 * character.c (char_string): Use %x to display the (unsigned)
6756 codepoint of an invalid character, to avoid displaying a bogus
6759 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6760 `error', not SYMBOL_NAME itself.
6762 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6763 character arguments to `error'.
6765 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6766 to `error' in error message about FINAL_CHAR argument. Make sure
6767 FINAL_CHAR is a character, and use %c when it is passed as
6768 argument to `error'.
6770 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6772 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6774 * w32.c: Include <time.h>.
6775 (sys_localtime): New function.
6777 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6779 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6781 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6783 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6785 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6788 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6790 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6791 gl_state.e_property when gl_state.object is Qt.
6793 * insdel.c (make_gap_larger): Remove limitation of buffer size
6796 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6798 * xdisp.c (lookup_glyphless_char_display)
6799 (produce_glyphless_glyph): Handle cons cell entry in
6800 glyphless-char-display.
6801 (Vglyphless_char_display): Document it.
6803 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6804 glyphless-char-display.
6806 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6808 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6810 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6812 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6813 definition for no-X builds.
6815 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6817 Static checks with GCC 4.6.0 and non-default toolkits.
6819 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6821 * process.c (keyboard_bit_set): Define only if SIGIO.
6822 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6823 (send_process): Repair possible setjmp clobbering.
6825 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6827 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6829 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6831 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6832 Define only if needed.
6834 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6835 by pacifying GCC about it. Maybe it's time to retire it?
6836 * xfaces.c (USG, __TIMEVAL__): Likewise.
6838 * dispextern.h (struct redisplay_interface): Rename param
6840 * termhooks.h (struct terminal): Likewise.
6841 * xterm.c (xembed_send_message): Likewise.
6843 * insdel.c (make_gap_smaller): Define only if
6844 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6846 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6849 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6850 so that we aren't warned about unused symbols.
6852 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6854 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6856 * xfns.c (x_real_positions): Mark locals as initialized.
6858 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6860 * xterm.c: Fix problems found by static analysis with other toolkits.
6861 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6862 (x_dispatch_event): Declare static if USE_GTK, and
6863 define if USE_GTK || USE_X_TOOLKIT.
6864 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6865 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6866 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6867 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6869 * xmenu.c (menu_help_callback): Pointer type fixes.
6870 Use const pointers when pointing at readonly data. Avoid pointer
6872 (FALSE): Remove unused macro.
6873 (update_frame_menubar): Remove unused decl.
6875 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6877 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6878 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6879 (single_menu_item): Rename local to avoid shadowing.
6881 * keyboard.c (make_lispy_event): Remove unused local var.
6883 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6884 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6886 * bitmaps: Change bitmaps from unsigned char back to the X11
6887 compatible char. Avoid the old compiler warnings about
6888 out-of-range initializers by using, for example, '\xab' rather
6891 * xgselect.c (xgselect_initialize): Check vs interface
6892 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6894 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6896 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6897 to read-only memory.
6899 * fns.c (vector): Remove; this old hack is no longer needed.
6901 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6903 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6905 * xrdb.c (x_load_resources): Omit unused local.
6907 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6908 (x_window): Rename locals to avoid shadowing.
6909 (USG): Use the kludged USG macro, to pacify gcc.
6911 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6912 (x_term_init): Remove local to avoid shadowing.
6914 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6916 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6917 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6919 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6921 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6923 Fix regex.c, syntax.c and friends for buffers > 2GB.
6924 * syntax.h (struct gl_state_s): Declare character position members
6927 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6929 * textprop.c (verify_interval_modification, interval_of):
6930 Declare arguments EMACS_INT.
6932 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6935 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6937 * indent.c (Fvertical_motion): Local variable it_start is now
6940 * regex.c (re_match, re_match_2, re_match_2_internal)
6941 (bcmp_translate, regcomp, regexec, print_double_string)
6942 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6943 (re_compile_pattern, re_exec): Declare arguments and local
6944 variables `size_t' and `ssize_t' and return values `regoff_t', as
6946 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6947 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6948 <compile_stack_type>: `size' and `avail' are now `size_t'.
6950 * regex.h <regoff_t>: Use ssize_t, not int.
6951 (re_search, re_search_2, re_match, re_match_2): Arguments that
6952 specify buffer/string position and length are now ssize_t and
6953 size_t. Return type is regoff_t.
6955 2011-04-16 Ben Key <bkey76@gmail.com>
6957 * nsfont.m: Fixed bugs in ns_get_family and
6958 ns_descriptor_to_entity that were caused by using free to
6959 deallocate memory blocks that were allocated by xmalloc (via
6960 xstrdup). This caused Emacs to crash when compiled with
6961 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6962 --enable-checking=xmallocoverrun). xfree is now used to
6963 deallocate these memory blocks.
6965 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6967 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6969 emacs_write: Accept and return EMACS_INT for sizes.
6970 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6972 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6973 Accept and return EMACS_INT.
6974 (emacs_gnutls_write): Return the number of bytes written on
6976 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6977 (emacs_read, emacs_write): Remove check for negative size, as the
6978 Emacs source code has been audited now.
6979 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6980 (emacs_read, emacs_write): Use it.
6981 * process.c (send_process): Adjust to the new signatures of
6982 emacs_write and emacs_gnutls_write. Do not attempt to store
6983 a byte offset into an 'int'; it might overflow.
6984 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6986 * sound.c: Don't assume sizes fit in 'int'.
6987 (struct sound_device.period_size, alsa_period_size):
6988 Return EMACS_INT, not int.
6989 (struct sound_device.write, vox_write, alsa_write):
6990 Accept EMACS_INT, not int.
6991 (wav_play, au_play): Use EMACS_INT to store sizes and to
6992 record read return values.
6994 2011-04-15 Ben Key <bkey76@gmail.com>
6996 * keyboard.c (Qundefined): Don't declare static since it is used
6998 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6999 static since they are used in nsfont.m.
7001 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7003 * process.c (Qprocessp): Don't declare static.
7004 * lisp.h (Qprocessp): Declare again.
7006 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7008 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7010 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7012 Improve C-level modularity by making more things 'static'.
7014 Don't publish debugger-only interfaces to other modules.
7015 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7016 (verify_bytepos, count_markers): Move decls to the only modules
7018 * region-cache.h (pp_cache): Likewise.
7019 * window.h (check_all_windows): Likewise.
7020 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7022 * sysdep.c (croak): Now static, if
7023 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7024 * syssignal.h (croak): Declare only if not static.
7026 * alloc.c (refill_memory_reserve): Now static if
7027 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7028 * lisp.h (refill_memory_reserve): Declare only if not static.
7030 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7031 Define only if USE_LUCID.
7033 * xrdb.c (x_customization_string, x_rm_string): Now static.
7035 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7036 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7038 * xdisp.c (draw_row_with_mouse_face): Now static.
7039 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7041 * window.h (check_all_windows): Mark externally visible.
7043 * window.c (window_deletion_count): Now static.
7045 * undo.c: Make symbols static if they're not exported.
7046 (last_undo_buffer, last_boundary_position, pending_boundary):
7049 * textprop.c (interval_insert_behind_hooks): Now static.
7050 (interval_insert_in_front_hooks): Likewise.
7052 * term.c: Make symbols static if they're not exported.
7053 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7054 (max_frame_lines, tty_set_terminal_modes):
7055 (tty_reset_terminal_modes, tty_turn_off_highlight):
7056 (get_tty_terminal): Now static.
7057 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7058 * termhooks.h (term_mouse_moveto): Do not declare if
7060 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7061 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7063 * sysdep.c: Make symbols static if they're not exported.
7064 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7066 (sigprocmask_set, full_mask): Remove; unused.
7067 (wait_debugging): Mark as visible.
7068 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7069 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7071 * syntax.c (syntax_temp): Define only if !__GNUC__.
7073 * sound.c (current_sound_device, current_sound): Now static.
7075 * search.c (searchbufs, searchbuf_head): Now static.
7077 * scroll.c (scroll_cost): Remove; unused.
7078 * dispextern.h (scroll_cost): Remove decl.
7080 * region-cache.h (pp_cache): Mark as externally visible.
7082 * process.c: Make symbols static if they're not exported.
7083 (process_tick, update_tick, create_process, chan_process):
7084 (Vprocess_alist, proc_buffered_char, datagram_access):
7085 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7086 (deactivate_process): Mark defn as static, as well as decl.
7087 * lisp.h (create_process): Remove decl.
7088 * process.h (chan_process, Vprocess_alist): Remove decls.
7090 * print.c: Make symbols static if they're not exported.
7091 (print_depth, new_backquote_output, being_printed, print_buffer):
7092 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7093 (print_interval, print_number_index, initial_stderr_stream):
7095 * lisp.h (Fprinc): Remove decl.
7096 (debug_output_compilation_hack): Mark as externally visible.
7098 * sysdep.c (croak): Move decl from here to syssignal.h.
7099 * syssignal.h (croak): Put it here, so the API can be checked when
7100 'croak' is called from dissociate_if_controlling_tty.
7102 * minibuf.c: Make symbols static if they're not exported.
7103 (minibuf_save_list, choose_minibuf_frame): Now static.
7104 * lisp.h (choose_minibuf_frame): Remove decl.
7106 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7108 * lread.c: Make symbols static if they're not exported.
7109 (read_objects, initial_obarray, oblookup_last_bucket_number):
7111 (make_symbol): Remove; unused.
7112 * lisp.h (initial_obarray, make_symbol): Remove decls.
7114 * keyboard.c: Make symbols static if they're not exported.
7115 (single_kboard, recent_keys_index, total_keys, recent_keys):
7116 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7117 (this_single_command_key_start, echoing, last_auto_save):
7118 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7119 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7120 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7121 (Vlispy_mouse_stem, double_click_count):
7123 (force_auto_save_soon): Define only if SIGDANGER.
7124 (ignore_mouse_drag_p): Now static if
7125 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7126 (print_help): Remove; unused.
7127 (stop_character, last_timer_event): Mark as externally visible.
7128 * keyboard.h (ignore_mouse_drag_p): Declare only if
7129 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7130 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7131 * lisp.h (echoing): Remove decl.
7132 (force_auto_save_soon): Declare only if SIGDANGER.
7133 * xdisp.c (redisplay_window): Simplify code, to make it more
7134 obvious that ignore_mouse_drag_p is not accessed if !defined
7135 USE_GTK && !defined HAVE_NS.
7137 * intervals.c: Make symbols static if they're not exported.
7138 (merge_properties_sticky, merge_interval_right, delete_interval):
7140 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7142 * insdel.c: Make symbols static if they're not exported.
7143 However, leave prepare_to_modify_buffer alone. It's never
7144 called from outside this function, but that appears to be a bug.
7145 (combine_after_change_list, combine_after_change_buffer):
7146 (adjust_after_replace, signal_before_change): Now static.
7147 (adjust_after_replace_noundo): Remove; unused.
7148 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7149 (signal_before_change): Remove decls.
7151 * indent.c (val_compute_motion, val_vmotion): Now static.
7153 * image.c: Make symbols static if they're not exported.
7154 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7156 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7157 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7159 * fringe.c (standard_bitmaps): Now static.
7160 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7162 * frame.c: Make symbols static if they're not exported.
7163 (x_report_frame_params, make_terminal_frame): Now static.
7164 (get_frame_param): Now static, unless HAVE_NS.
7165 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7166 (x_get_resource_string): Remove; not used.
7167 * frame.h (make_terminal_frame, x_report_frame_params):
7168 (x_get_resource_string); Remove decls.
7169 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7170 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7172 * font.c, fontset.c: Make symbols static if they're not exported.
7173 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7174 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7175 * font.c (font_close_object): Now static.
7176 * font.h (font_close_object): Remove.
7177 * fontset.c (FONTSET_OBJLIST): Remove.
7178 (free_realized_fontset) #if-0 the body, which does nothing.
7179 (face_suitable_for_char_p): #if-0, as it's never called.
7180 * fontset.h (face_suitable_for_char_p): Remove decl.
7181 * xfaces.c (face_at_string_position):
7182 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7183 since 0 is always ASCII.
7185 * fns.c (weak_hash_tables): Now static.
7187 * fileio.c: Make symbols static if they're not exported.
7188 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7189 (Vwrite_region_annotation_buffers): Now static.
7191 * eval.c: Make symbols static if they're not exported.
7192 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7193 * lisp.h (backtrace_list): Remove decl.
7195 * emacs.c: Make symbols static if they're not exported.
7196 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7197 (fatal_error_code, fatal_error_signal_hook, standard_args):
7199 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7200 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7201 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7202 * lisp.h (fatal_error_signal_hook): Remove decl.
7203 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7205 * editfns.c: Move a (normally-unused) function to its only use.
7206 * editfns.c, lisp.h (get_operating_system_release): Remove.
7207 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7208 worth the hassle of breaking this out.
7210 * xterm.c: Make symbols static if they're not exported.
7211 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7212 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7213 (x_destroy_window, x_delete_display):
7215 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7216 (x_mouse_leave): Remove; unused.
7217 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7218 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7219 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7221 (x_mouse_leave): Declare only if WINDOWSNT.
7222 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7223 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7226 * ftxfont.c: Make symbols static if they're not exported.
7227 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7229 * font.h (ftxfont_driver): Likewise.
7231 * xfns.c: Make symbols static if they're not exported.
7232 (x_last_font_name, x_display_info_for_name):
7233 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7234 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7235 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7236 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7237 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7238 (last_show_tip_args): Now static.
7239 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7240 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7241 (x_screen_planes): Remove; unused.
7242 * dispextern.h (x_screen_planes): Remove decl.
7244 * dispnew.c: Make symbols static if they're not exported.
7245 * dispextern.h (redraw_garbaged_frames, scrolling):
7246 (increment_row_positions): Remove.
7247 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7248 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7250 (redraw_garbaged_frames): Remove; unused.
7252 * xfaces.c: Make symbols static if they're not exported.
7253 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7255 * xterm.h (defined_color): Remove decls.
7256 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7257 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7258 (menu_face_changed_default, defined_color, free_realized_face):
7259 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7260 (ascii_face_of_lisp_face): Remove; unused.
7262 * xdisp.c: Make symbols static if they're not exported.
7263 * dispextern.h (scratch_glyph_row, window_box_edges):
7264 (glyph_to_pixel_coords, set_cursor_from_row):
7265 (get_next_display_element, set_iterator_to_next):
7266 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7267 (show_mouse_face): Remove decls
7268 * frame.h (message_buf_print): Likewise.
7269 * lisp.h (pop_message, set_message, check_point_in_composition):
7271 * xterm.h (set_vertical_scroll_bar): Likewise.
7272 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7273 (message_buf_print, scratch_glyph_row, displayed_buffer):
7274 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7275 (get_next_display_element, show_mouse_face, window_box_edges):
7276 (frame_to_window_pixel_xy, check_point_in_composition):
7277 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7278 (glyph_to_pixel_coords): Remove; unused.
7280 * dired.c (file_name_completion): Now static.
7282 * dbusbind.c (xd_in_read_queued_messages): Now static.
7284 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7285 * data.c (circular_list_error): Remove.
7287 * commands.h (last_point_position, last_point_position_buffer):
7288 (last_point_position_window): Remove decls.
7289 * keyboard.c: Make these variables static.
7291 * coding.h (coding, code_convert_region, encode_coding_gap):
7293 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7294 (iso_code_class, detect_coding, code_convert_region): Now static.
7295 (encode_coding_gap): Remove; unused.
7297 * chartab.c (chartab_chars, chartab_bits): Now static.
7299 * charset.h (charset_iso_8859_1): Remove decl.
7300 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7303 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7304 * ccl.c (Vccl_program_table): Now static.
7305 (check_ccl_update): Remove; unused.
7307 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7308 * category.h: ... from here.
7309 * category.c (check_category_table, set_category_set): Now static.
7311 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7312 * lisp.h: Remove these decls.
7314 * buffer.c (buffer_count): Remove unused var.
7316 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7317 so that it's not optimized away.
7318 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7319 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7320 exported only to the debugger.
7322 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7323 * atimer.h (run_all_atimers): Remove; not exported.
7325 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7326 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7327 was inaccessible from Lisp.
7328 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7329 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7331 alloc.c: Import and export fewer symbols, and remove unused items.
7332 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7334 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7335 it's not optimized away by whole-program optimization.
7336 (message_enable_multibyte, free_misc): Remove.
7337 (catchlist, handlerlist, mark_backtrace):
7338 Declare only if BYTE_MARK_STACK.
7339 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7340 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7341 (message_enable_multibyte): Remove decl.
7342 (free_misc, interval_free_list, float_block, float_block_index):
7343 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7344 (cons_free_list, last_marked_index):
7346 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7347 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7348 (mark_backtrace): Define only if BYTE_MARK_STACK.
7349 * xdisp.c (message_enable_multibyte): Now static.
7351 Declare Lisp_Object Q* variables to be 'static' if not exported.
7352 This makes it easier for human readers (and static analyzers)
7353 to see whether these variables are used from other modules.
7354 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7355 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7356 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7357 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7358 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7359 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7360 * xmenu.c, xselect.c:
7361 Declare Q* vars static if they are not used in other modules.
7362 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7363 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7364 Remove decls of unexported vars.
7365 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7367 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7369 Make Emacs functions such as Fatom 'static' by default.
7370 This makes it easier for human readers (and static analyzers)
7371 to see whether these functions can be called from other modules.
7372 DEFUN now defines a static function. To make the function external
7373 so that it can be used in other C modules, use the new macro DEFUE.
7374 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7375 (Finit_image_library):
7376 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7377 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7378 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7379 Remove decls, since these functions are now static.
7380 (Funintern, Fget_internal_run_time): New decls, since these functions
7381 were already external.
7383 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7384 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7385 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7386 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7387 * keyboard.c, keymap.c, lread.c:
7388 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7389 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7390 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7391 Mark functions with DEFUE instead of DEFUN,
7392 if they are used in other modules.
7393 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7394 decls for now-static functions.
7395 * buffer.h (Fdelete_overlay): Remove decl.
7396 * callproc.c (Fgetenv_internal): Mark as internal.
7397 * composite.c (Fremove_list_of_text_properties): Remove decl.
7398 (Fcomposition_get_gstring): New forward static decl.
7399 * composite.h (Fcomposite_get_gstring): Remove decl.
7400 * dired.c (Ffile_attributes): New forward static decl.
7401 * doc.c (Fdocumntation_property): New forward static decl.
7402 * eval.c (Ffetch_bytecode): New forward static decl.
7403 (Funintern): Remove extern decl; now in .h file where it belongs.
7404 * fileio.c (Fmake_symbolic_link): New forward static decl.
7405 * image.c (Finit_image_library): New forward static decl.
7406 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7407 * intervals.h (Fprevious_property_change):
7408 (Fremove_list_of_text_properties): Remove decls.
7409 * keyboard.c (Fthis_command_keys): Remove decl.
7410 (Fcommand_execute): New forward static decl.
7411 * keymap.c (Flookup_key): New forward static decl.
7412 (Fcopy_keymap): Now static.
7413 * keymap.h (Flookup_key): Remove decl.
7414 * process.c (Fget_process): New forward static decl.
7415 (Fprocess_datagram_address): Mark as internal.
7416 * syntax.c (Fsyntax_table_p): New forward static decl.
7417 (skip_chars): Remove duplicate decl.
7418 * textprop.c (Fprevious_property_change): New forward static decl.
7419 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7421 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7422 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7424 * editfns.c (Fformat): Remove unreachable code.
7426 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7428 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7431 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7433 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7434 when at ZV. (Bug#8487)
7436 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7438 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7440 * keyboard.c (parse_tool_bar_item): Likewise.
7441 * sound.c (sound_cleanup, alsa_close): Likewise.
7442 * termcap.c (tgetent): Likewise.
7443 * xfns.c (x_default_font_parameter): Likewise.
7444 * xsettings.c (read_and_apply_settings): Likewise.
7446 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7447 (overrun_check_free): Protoize.
7449 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7451 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7452 since callers should never pass a negative size.
7453 Change the signature to match that of plain 'read' and 'write'; see
7454 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7455 * lisp.h: Update prototypes of emacs_write and emacs_read.
7457 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7459 * xdisp.c (redisplay_window): Don't try to determine the character
7460 position of the scroll margin if the window start point w->startp
7461 is outside the buffer's accessible region. (Bug#8468)
7463 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7465 Fix write-region and its subroutines for buffers > 2GB.
7466 * fileio.c (a_write, e_write): Modify declaration of arguments and
7467 local variables to support buffers larger than 2GB.
7468 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7470 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7471 argument, local variables, and return value.
7473 * lisp.h: Update prototypes of emacs_write and emacs_read.
7475 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7477 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7479 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7481 Fix more problems found by GCC 4.6.0's static checks.
7483 * xdisp.c (vmessage): Use a better test for character truncation.
7485 * charset.c (load_charset_map): <, not <=, for optimization,
7486 and to avoid potential problems with integer overflow.
7487 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7488 * casetab.c (set_identity, shuffle): Likewise.
7489 * editfns.c (Fformat): Likewise.
7490 * syntax.c (skip_chars): Likewise.
7492 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7493 This also lets GCC 4.6.0 generate slightly better loop code.
7495 * callint.c (Fcall_interactively): <, not <=, for optimization.
7496 (Fcall_interactively): Count the number of arguments produced,
7497 not the number of arguments given. This is simpler and lets GCC
7498 4.6.0 generate slightly better code.
7500 * ftfont.c: Distingish more carefully between FcChar8 and char.
7501 The previous code passed unsigned char * to a functions like
7502 strlen and xstrcasecmp that expect char *, which does not
7503 conform to the C standard.
7504 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7505 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7506 char * when the C standard requires it.
7508 * keyboard.c (read_char): Remove unused var.
7510 * eval.c: Port to Windows vsnprintf (Bug#8435).
7512 (SIZE_MAX): Define if the headers do not.
7513 (verror): Do not give up if vsnprintf returns a negative count.
7514 Instead, grow the buffer. This ports to Windows vsnprintf, which
7515 does not conform to C99. Problem reported by Eli Zaretskii.
7516 Also, simplify the allocation scheme, by avoiding the need for
7517 calling realloc, and removing the ALLOCATED variable.
7519 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7521 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7522 But keep the doprint source code for now, as we might revamp it
7523 and use it again (Bug#8435).
7524 * lisp.h (doprnt): Remove.
7525 * Makefile.in (base_obj): Remove doprnt.o.
7526 * deps.mk (doprnt.o): Remove.
7528 error: Print 32- and 64-bit integers portably (Bug#8435).
7529 Without this change, on typical 64-bit hosts error ("...%d...", N)
7530 was used to print both 32- and 64-bit integers N, which relied on
7532 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7534 * lisp.h (error, verror): Mark as printf-like functions.
7535 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7536 Report overflow in size calculations when allocating printf buffer.
7537 Do not truncate output string at its first null byte.
7538 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7539 Truncate the output at a character boundary, since vsnprintf does not
7541 * charset.c (check_iso_charset_parameter): Convert internal
7542 character to string before calling 'error', since %c now has the
7544 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7545 overflow when computing char to be passed to 'error'. Do not
7546 pass Lisp_Object to 'error'; pass the integer instead.
7547 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7548 formatted with plain %d.
7550 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7552 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7554 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7556 * xterm.c (x_catch_errors): Remove duplicate declaration.
7558 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7560 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7562 2011-04-10 Jim Meyering <meyering@redhat.com>
7564 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7565 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7566 return ssize_t not "int", and use size_t as the buffer length.
7567 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7568 * gnutls.h: Update declarations.
7569 * process.c (read_process_output): Use ssize_t, to match.
7570 (send_process): Likewise.
7572 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7574 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7576 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7578 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7579 Use unsigned char, to match FcChar8 type definition.
7581 * xterm.c (handle_one_xevent):
7582 * xmenu.c (create_and_show_popup_menu):
7583 * xselect.c (x_decline_selection_request)
7584 (x_reply_selection_request): Avoid type-punned deref of X events.
7586 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7588 Fix some uses of `int' instead of EMACS_INT.
7589 * search.c (string_match_1, fast_string_match)
7590 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7591 (scan_buffer, find_next_newline_no_quit)
7592 (find_before_next_newline, search_command, Freplace_match)
7593 (Fmatch_data): Make some `int' variables be EMACS_INT.
7595 * xdisp.c (display_count_lines): 3rd argument and return value now
7596 EMACS_INT. All callers changed.
7597 (pint2hrstr): Last argument is now EMACS_INT.
7599 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7600 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7601 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7602 (decode_coding_utf_16, decode_coding_emacs_mule)
7603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7604 (decode_coding_ccl, decode_coding_charset)
7605 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7606 (decode_coding_iso_2022, decode_coding_emacs_mule)
7607 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7608 <char_offset, last_offset>: Declare EMACS_INT.
7609 (encode_coding_utf_8, encode_coding_utf_16)
7610 (encode_coding_emacs_mule, encode_invocation_designation)
7611 (encode_designation_at_bol, encode_coding_iso_2022)
7612 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7613 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7615 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7616 (encode_invocation_designation): Last argument P_NCHARS is now
7618 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7619 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7621 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7624 * ccl.c (Fccl_execute_on_string): Declare some variables
7627 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7629 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7631 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7633 * process.c (Fformat_network_address): Doc fix.
7635 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7637 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7639 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7641 * keyboard.c (read_char): Call Lisp function help-form-show,
7642 instead of using internal_with_output_to_temp_buffer.
7643 (Qhelp_form_show): New var.
7644 (syms_of_keyboard): Use DEFSYM macro.
7646 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7648 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7650 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7652 * process.c (Flist_processes): Remove to Lisp.
7653 (list_processes_1): Delete.
7655 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7657 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7659 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7661 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7663 Fix more problems found by GCC 4.6.0's static checks.
7665 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7667 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7669 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7671 * xdisp.c (vmessage): Mark as a printf-like function.
7673 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7675 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7677 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7678 printf-like functions.
7679 (tiff_load): Add casts to remove these marks before passing them
7680 to system-supplied API.
7682 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7684 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7685 This avoids several warnings with gcc -Wstrict-overflow.
7686 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7687 directly, rather than having caller test rule sign. This avoids
7688 some unnecessary tests.
7689 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7690 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7691 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7693 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7694 (xfont_open): Avoid unnecessary tests.
7696 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7698 * composite.h, composite.c (composition_gstring_put_cache):
7699 Use EMACS_INT, not int, for length.
7701 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7702 breaking out part of COMPOSITION_DECODE_RULE.
7703 (COMPOSITION_DECODE_RULE): Use it.
7704 * composite.c (get_composition_id): Remove unused local vars,
7705 by using the new macro.
7707 * textprop.c (set_text_properties_1): Change while to do-while,
7708 since the condition is always true at first.
7710 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7711 (interval_deletion_adjustment): Return unsigned value.
7714 * process.c (list_processes_1, create_pty, read_process_output):
7715 (exec_sentinel): Remove vars that were set but not used.
7716 (create_pty): Remove unnecessary "volatile"s.
7717 (Fnetwork_interface_info): Avoid possibility of int overflow.
7718 (read_process_output): Do adaptive read buffering even if carryover.
7719 (read_process_output): Simplify nbytes computation if buffered.
7721 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7723 * syntax.c (scan_words): Remove var that was set but not used.
7724 (update_syntax_table): Use unsigned instead of int.
7726 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7727 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7728 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7730 * print.c (print_error_message): Avoid int overflow.
7732 * font.c (font_list_entities): Redo for clarity,
7733 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7735 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7736 (font_score): Avoid potential overflow in diff calculation.
7738 * fns.c (substring_both): Remove var that is set but not used.
7739 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7741 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7743 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7744 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7745 can always succeed if overflow has undefined behavior.
7747 * search.c (boyer_moore, wordify): Remove vars set but not used.
7748 (wordify): Omit three unnecessary tests.
7750 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7751 All callers changed. This avoids the need for an unused var.
7753 * casefiddle.c (casify_region): Remove var that is set but not used.
7755 * dired.c (file_name_completion): Remove var that is set but not used.
7757 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7759 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7760 (Finsert_file_contents): Remove unnecessary code checking fd.
7762 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7763 Check for integer overflow on size calculations.
7765 * buffer.c (Fprevious_overlay_change): Remove var that is set
7768 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7769 Remove vars that are set but not used.
7770 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7771 (timer_check_2): Mark vars as initialized.
7773 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7775 * image.c (lookup_image): Remove var that is set but not used.
7776 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7778 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7779 that are set but not used.
7781 * xfns.c (make_invisible_cursor): Don't return garbage
7782 if XCreateBitmapFromData fails (Bug#8410).
7784 * xselect.c (x_get_local_selection, x_handle_property_notify):
7785 Remove vars that are set but not used.
7787 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7788 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7790 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7791 Remove var that is set but not used.
7792 (scroll_bar_windows_size): Now size_t, not int.
7793 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7796 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7797 (map_tty_color) [!defined MSDOS]: Likewise.
7799 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7801 * coding.c: Remove vars that are set but not used.
7802 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7803 All callers changed.
7804 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7805 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7806 (decode_coding_charset): Remove vars that are set but not used.
7808 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7809 that is set but not used.
7811 * print.c (print_object): Remove var that is set but not used.
7813 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7814 The gnulib version avoids calling malloc in the usual case,
7815 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7816 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7817 * filelock.c (current_lock_owner): Likewise.
7818 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7819 * sysdep.c: Include allocator.h, careadlinkat.h.
7820 (emacs_no_realloc_allocator): New static constant.
7821 (emacs_readlink): New function.
7822 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7823 ../lib/careadlinkat.h.
7825 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7827 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7828 first non-nil return value).
7830 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7832 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7833 if not defined (Bug#8403).
7835 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7837 * xdisp.c (display_count_lines): Remove parameter `start',
7838 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7839 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7840 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7841 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7842 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7843 and thereabouts. All callers changed.
7844 (get_per_char_metric): Remove parameter `f', unused since
7845 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7847 2011-04-02 Jim Meyering <meyering@redhat.com>
7849 do not dereference NULL upon failed strdup
7850 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7851 (ns_get_family): Likewise.
7853 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7855 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7857 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7859 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7862 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7864 Add lexical binding.
7866 * window.c (Ftemp_output_buffer_show): New fun.
7867 (Fsave_window_excursion):
7868 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7870 * lread.c (lisp_file_lexically_bound_p): New function.
7871 (Fload): Bind Qlexical_binding.
7872 (readevalloop): Remove `evalfun' arg.
7873 Bind Qinternal_interpreter_environment.
7874 (Feval_buffer): Bind Qlexical_binding.
7875 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7877 (syms_of_lread): Declare `lexical-binding'.
7879 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7881 * keyboard.c (eval_dyn): New fun.
7882 (menu_item_eval_property): Use it.
7884 * image.c (parse_image_spec): Use Ffunctionp.
7886 * fns.c (concat, mapcar1): Accept byte-code-functions.
7888 * eval.c (Fsetq): Handle lexical vars.
7889 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7890 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7891 (FletX, Flet): Obey lexical binding.
7892 (Fcommandp): Handle closures.
7893 (Feval): New `lexical' arg.
7894 (eval_sub): New function extracted from Feval. Use it almost
7895 everywhere where Feval was used. Look up vars in lexical env.
7897 (Ffunctionp): Move from subr.el.
7898 (Ffuncall): Handle closures.
7899 (apply_lambda): Remove `eval_flags'.
7900 (funcall_lambda): Handle closures and new byte-code-functions.
7901 (Fspecial_variable_p): New function.
7902 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7903 but without exporting it to Lisp.
7905 * doc.c (Fdocumentation, store_function_docstring):
7906 * data.c (Finteractive_form): Handle closures.
7908 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7911 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7913 (exec_byte_code): New function extracted from Fbyte_code to handle new
7914 calling convention for byte-code-functions. Add new byte-codes.
7916 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7918 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7920 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7922 * xdisp.c (redisplay_internal): Fix prototype.
7924 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7926 * xdisp.c (SCROLL_LIMIT): New macro.
7927 (try_scrolling): Use it when setting scroll_limit.
7928 Limit scrolling to 100 screen lines.
7929 (redisplay_window): Even when falling back on "recentering",
7930 position point in the window according to scroll-conservatively,
7931 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7933 (try_scrolling): When point is above the window, allow searching
7934 as far as scroll_max, or one screenful, to compute vertical
7935 distance from PT to the scroll margin position. This prevents
7936 try_scrolling from unnecessarily failing when
7937 scroll-conservatively is set to a value slightly larger than the
7938 window height. Clean up the case of PT below the margin at bottom
7939 of window: scroll_max can no longer be INT_MAX. When aggressive
7940 scrolling is in use, don't let point enter the opposite scroll
7941 margin as result of the scroll.
7942 (syms_of_xdisp) <scroll-conservatively>: Document the
7943 threshold of 100 lines for never-recentering scrolling.
7945 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7947 * dispextern.h (move_it_by_lines):
7948 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7949 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7950 (message_log_check_duplicate): Remove parameters `prev_bol' and
7951 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7952 (redisplay_internal): Remove parameter `preserve_echo_area',
7953 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7955 * indent.c (Fvertical_motion):
7956 * window.c (window_scroll_pixel_based, Frecenter):
7957 Don't pass `need_y_p' to `move_it_by_lines'.
7959 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7961 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7962 steal a few bits to be more compact.
7963 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7964 Remove unneeded casts.
7966 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7968 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7970 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7971 binding" message (bug#7967).
7973 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7975 Fix more problems found by GCC 4.6.0's static checks.
7977 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7978 Remove unused local var.
7980 * editfns.c (Fmessage_box): Remove unused local var.
7982 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7983 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7984 Omit unused local vars.
7985 * window.c (shrink_windows): Omit unused local var.
7986 * menu.c (digest_single_submenu): Omit unused local var.
7987 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7988 Omit unused local var.
7990 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7991 Don't assume string length fits in int.
7992 (keyremap_step, read_key_sequence): Use size_t for sizes.
7993 (read_key_sequence): Don't check last_real_key_start redundantly.
7995 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7996 instead of alloca (Bug#8344).
7998 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7999 (Fbacktrace_frame): Don't assume nframes fits in int.
8001 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8003 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8006 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8008 * cm.c (calccost): Turn while-do into do-while, for clarity.
8010 * keyboard.c (syms_of_keyboard): Use the same style as later
8011 in this function when indexing through an array. This also
8012 works around GCC bug 48267.
8014 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8016 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8018 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8019 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8021 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8022 This avoids undefined behavior on integer overflow, and is a bit
8023 more convenient anyway since it is compared to a size_t variable.
8025 Variadic C functions now count arguments with size_t, not int.
8026 This avoids an unnecessary limitation on 64-bit machines, which
8027 caused (substring ...) to crash on large vectors (Bug#8344).
8028 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8029 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8030 All variadic functions and their callers changed accordingly.
8031 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8032 * data.c (arith_driver, float_arith_driver): Likewise.
8033 * editfns.c (general_insert_function): Likewise.
8034 * eval.c (struct backtrace.nargs, interactive_p)
8035 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8036 (funcall_lambda, mark_backtrace): Likewise.
8037 * fns.c (concat): Likewise.
8038 * frame.c (x_set_frame_parameters): Likewise.
8039 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8040 0 if not found, not -1. All callers changed.
8042 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8043 (stack_copy_size): Now size_t, not int.
8044 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8046 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8048 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8049 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8050 All callers changed.
8052 * lisp.h (multibyte_char_to_unibyte):
8053 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8054 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8055 * character.h (CHAR_TO_BYTE8):
8056 * cmds.c (internal_self_insert):
8057 * editfns.c (general_insert_function):
8058 * keymap.c (push_key_description):
8059 * search.c (Freplace_match):
8060 * xdisp.c (message_dolog, set_message_1): All callers changed.
8062 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8064 * keyboard.c (safe_run_hook_funcall): New function.
8065 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8066 don't set the hook to nil, but remove the offending function instead.
8067 (Qcommand_hook_internal): Remove, unused.
8068 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8069 Vcommand_hook_internal.
8071 * eval.c (enum run_hooks_condition): Remove.
8072 (funcall_nil, funcall_not): New functions.
8073 (run_hook_with_args): Call each function through a `funcall' argument.
8074 Remove `cond' argument, now redundant.
8075 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8076 (Frun_hook_with_args_until_failure): Adjust accordingly.
8077 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8079 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8081 * dispextern.h (string_buffer_position): Remove declaration.
8083 * print.c (strout): Remove parameter `multibyte', unused since
8084 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8086 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8087 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8088 All callers changed.
8090 * w32.c (_wsa_errlist): Use braces for struct initializers.
8092 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8093 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8094 All callers changed.
8095 (string_buffer_position): Likewise. Also, make static (it's never
8096 used outside xdisp.c).
8097 (cursor_row_p): Remove parameter `w', unused since
8098 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8099 (decode_mode_spec): Remove parameter `precision', introduced during
8100 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8101 All callers changed.
8103 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8105 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8107 2011-03-27 Anders Lindgren <andlind@gmail.com>
8109 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8110 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8111 (ns_update_auto_hide_menu_bar): New functions.
8112 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8113 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8114 ns_constrain_all_frames.
8115 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8116 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8118 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8120 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8122 2011-03-27 Glenn Morris <rgm@gnu.org>
8124 * syssignal.h: Replace RETSIGTYPE with void.
8125 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8126 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8127 Replace SIGTYPE with void everywhere.
8128 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8129 * s/template.h (SIGTYPE): Remove commented out definition.
8131 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8133 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8134 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8136 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8138 * w32.c (read_unc_volume): Use parameter `henum', instead of
8139 global variable `wget_enum_handle'.
8141 * keymap.c (describe_vector): Remove parameters `indices' and
8142 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8143 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8145 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8147 * keyboard.c (timer_check): Remove parameter `do_it_now',
8148 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8149 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8150 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8152 * keyboard.c (read_char):
8153 * w32menu.c (w32_menu_display_help):
8154 * xmenu.c (show_help_event, menu_help_callback):
8155 Adjust calls to `show_help_echo'.
8157 * gtkutil.c (xg_maybe_add_timer):
8158 * keyboard.c (readable_events):
8159 * process.c (wait_reading_process_output):
8160 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8162 * insdel.c (adjust_markers_gap_motion):
8163 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8164 (gap_left, gap_right): Don't call it.
8166 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8168 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8169 incurred during fontification.
8171 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8173 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8174 (DEFVAR_PER_BUFFER): Don't pass it.
8176 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8177 (scrolling_window): Don't pass it.
8179 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8181 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8183 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8185 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8186 of variables specific to SELinux and computation of `encoded_absname'.
8188 * image.c (XPutPixel): Remove unused variable `height'.
8190 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8192 * unexw32.c (get_section_info): Remove unused variable `section'.
8194 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8195 (system_process_attributes): Remove unused variable `sess'.
8196 (sys_read): Remove unused variable `err'.
8198 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8199 (w32_wnd_proc): Remove unused variable `isdead'.
8200 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8201 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8202 (x_create_tip_frame): Remove unused variable `tem'.
8204 * w32inevt.c (w32_console_read_socket):
8205 Remove unused variable `no_events'.
8207 * w32term.c (x_draw_composite_glyph_string_foreground):
8208 Remove unused variable `width'.
8210 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8212 * w32term.c (x_set_glyph_string_clipping):
8213 Don't pass uninitialized region to CombineRgn.
8215 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8217 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8218 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8219 (Fx_close_connection): Remove unused variable `i'.
8221 * w32font.c (w32font_draw): Return number of glyphs.
8222 (w32font_open_internal): Remove unused variable `i'.
8223 (w32font_driver): Add missing initializer.
8225 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8226 (fill_in_menu): Remove unused variable `items_added'.
8228 * w32term.c (last_mouse_press_frame): Remove static global variable.
8229 (w32_clip_to_row): Remove unused variable `f'.
8230 (x_delete_terminal): Remove unused variable `i'.
8232 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8233 (NOTHING): Remove unused static global variable.
8234 (uniscribe_check_otf): Remove unused variable `table'.
8235 (uniscribe_font_driver): Add missing initializers.
8237 2011-03-23 Julien Danjou <julien@danjou.info>
8239 * term.c (Fsuspend_tty, Fresume_tty):
8240 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8241 * window.c (temp_output_buffer_show):
8242 * insdel.c (signal_before_change):
8243 * frame.c (Fhandle_switch_frame):
8244 * fileio.c (Fdo_auto_save):
8245 * emacs.c (Fkill_emacs):
8246 * editfns.c (save_excursion_restore):
8247 * cmds.c (internal_self_insert):
8248 * callint.c (Fcall_interactively):
8249 * buffer.c (Fkill_all_local_variables):
8250 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8252 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8253 unconditionally since it does the check itself.
8255 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8257 Fix more problems found by GCC 4.5.2's static checks.
8259 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8260 the first time through the loop, since we know p0 < p1 then.
8261 This also avoids a gcc -Wstrict-overflow warning.
8263 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8264 leading to a memory leak, possible in functions like
8265 load_charset_map_from_file that can allocate an unbounded number
8266 of objects (Bug#8318).
8268 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8269 that could (at least in theory) be that large.
8271 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8272 This is less likely to overflow, and avoids undefined behavior if
8273 overflow does occur. All callers changed. Use strtoul to scan
8274 for the unsigned long integer.
8275 (pint2hrstr): Simplify and tune code slightly.
8276 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8278 * scroll.c (do_scrolling): Work around GCC bug 48228.
8279 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8281 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8282 This also avoids a warning with gcc -Wstrict-overflow.
8283 (validate_x_resource_name): Simplify count usage.
8284 This also avoids a warning with gcc -Wstrict-overflow.
8286 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8289 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8291 * process.c (Fmake_network_process): Use socklen_t, not int,
8292 where POSIX says socklen_t is required in portable programs.
8293 This fixes a porting bug on hosts like 64-bit HP-UX, where
8294 socklen_t is wider than int (Bug#8277).
8295 (Fmake_network_process, server_accept_connection):
8296 (wait_reading_process_output, read_process_output):
8299 * process.c: Rename or move locals to avoid shadowing.
8300 (list_processes_1, Fmake_network_process):
8301 (read_process_output_error_handler, exec_sentinel_error_handler):
8302 Rename or move locals.
8303 (Fmake_network_process): Define label "retry_connect" only if needed.
8304 (Fnetwork_interface_info): Fix pointer signedness.
8305 (process_send_signal): Add cast to avoid pointer signedness problem.
8306 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8307 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8309 Make tparam.h and terminfo.c consistent.
8310 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8311 Include tparam.h instead, since it declares them.
8312 * cm.h (PC): Remove extern decl; tparam.h now does this.
8313 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8314 * terminfo.c: Include tparam.h, to check interfaces.
8315 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8316 (tparam): Adjust signature to match interface in tparam.h;
8317 this removes some undefined behavior. Check that outstring and len
8318 are zero, which they always are with Emacs.
8319 * tparam.h (PC, BC, UP): New extern decls.
8321 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8322 (xftfont_open): Rename locals to avoid shadowing.
8324 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8325 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8326 (OTF_TAG_SYM): Omit macro if not needed.
8327 (ftfont_list): Remove unused local.
8328 (get_adstyle_property, ftfont_pattern_entity):
8329 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8330 Rename locals to avoid shadowing.
8332 * xfont.c (xfont_list_family): Mark var as initialized.
8334 * xml.c (make_dom): Now static.
8336 * composite.c (composition_compute_stop_pos): Rename local to
8338 (composition_reseat_it): Remove unused locals.
8339 (find_automatic_composition, composition_adjust_point): Likewise.
8340 (composition_update_it): Mark var as initialized.
8341 (find_automatic_composition): Mark vars as initialized,
8342 with a FIXME (Bug#8290).
8344 character.h: Rename locals to avoid shadowing.
8345 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8346 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8347 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8348 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8351 * textprop.c (property_change_between_p): Remove; unused.
8353 * intervals.c (interval_start_pos): Now static.
8355 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8357 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8358 Rename locals to avoid shadowing.
8360 * sound.c (wav_play, au_play, Fplay_sound_internal):
8361 Fix pointer signedness.
8362 (alsa_choose_format): Remove unused local var.
8363 (wav_play): Initialize a variable to 0, to prevent undefined
8364 behavior (Bug#8278).
8366 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8368 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8370 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8371 clobbering (Bug#8298).
8372 * sysdep.c (sys_subshell): Likewise.
8373 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8375 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8376 This should get cleaned up, so that child_setup has the
8377 same signature on all platforms.
8379 * callproc.c (call_process_cleanup): Now static.
8380 (relocate_fd): Rename locals to avoid shadowing.
8382 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8384 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8385 not to be necessary, and produces flickering.
8387 2011-03-20 Glenn Morris <rgm@gnu.org>
8389 * config.in: Remove file.
8391 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8393 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8394 are now in src/globals.h.
8395 (syms_of_minibuf): Remove spurious & from previous change.
8397 2011-03-20 Leo Liu <sdl.web@gmail.com>
8399 * minibuf.c (completing-read-function): New variable.
8400 (completing-read-default): Rename from completing-read.
8401 (completing-read): Call completing-read-function.
8403 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8405 * xfaces.c (Fx_load_color_file):
8406 Read color file from absolute filename (bug#8250).
8408 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8410 * makefile.w32-in: Update dependencies.
8412 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8414 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8416 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8418 Fix more problems found by GCC 4.5.2's static checks.
8420 * process.c (make_serial_process_unwind, send_process_trap):
8421 (sigchld_handler): Now static.
8423 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8424 That way, the code declares only the vars that it needs.
8425 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8426 * s/cygwin.h (PTY_ITERATION): Likewise.
8427 * s/darwin.h (PTY_ITERATION): Likewise.
8428 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8430 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8431 * process.c (allocate_pty): Don't declare stb unless it's needed.
8433 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8434 (CONSTANTLIM): Remove; unused.
8435 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8436 Define only if needed.
8438 * unexelf.c (unexec): Name an expression,
8439 to avoid gcc -Wbad-function-cast warning.
8440 Use a different way to cause a compilation error if anyone uses
8441 n rather than nn, a way that does not involve shadowing.
8442 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8444 * deps.mk (unexalpha.o): Remove; unused.
8446 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8447 * unexec.h: New file.
8448 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8449 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8451 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8452 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8453 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8454 Change as necessary to match prototype in unexec.h.
8456 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8458 (back_comment, skip_chars): Mark vars as initialized.
8460 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8461 Rename locals to avoid shadowing.
8463 * lread.c (read1): Rewrite so as not to use empty "else".
8464 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8466 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8468 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8469 warning when compiling print.c.
8471 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8472 instead of using an uninitialized var.
8473 (font_sort_entities): Mark var as initialized.
8475 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8477 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8478 pointers to constants.
8479 (font_parse_fcname): Remove unused vars.
8480 (font_delete_unmatched): Now static.
8481 (font_get_spec): Remove; unused.
8482 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8483 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8484 Rename or move locals to avoid shadowing.
8486 * fns.c (require_nesting_list, require_unwind): Now static.
8487 (Ffillarray): Rename locals to avoid shadowing.
8489 * floatfns.c (domain_error2): Define only if needed.
8490 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8492 * alloc.c (mark_backtrace): Move decl from here ...
8493 * lisp.h: ... to here, so that it can be checked.
8495 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8496 (Fdefvar): Rewrite so as not to use empty "else".
8497 (lisp_indirect_variable): Name an expression,
8498 to avoid gcc -Wbad-function-cast warning.
8499 (Fdefvar): Rename locals to avoid shadowing.
8501 * callint.c (quotify_arg, quotify_args): Now static.
8502 (Fcall_interactively): Rename locals to avoid shadowing.
8503 Use const pointer when appropriate.
8505 * lisp.h (get_system_name, get_operating_system_release):
8506 Move decls here, to check interfaces.
8507 * process.c (get_operating_system_release): Move decl to lisp.h.
8508 * xrdb.c (get_system_name): Likewise.
8509 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8510 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8511 some of which prompt warnings from gcc -Wbad-function-cast.
8512 (Fformat_time_string, Fencode_time, Finsert_char):
8513 (Ftranslate_region_internal, Fformat):
8514 Rename or remove local vars to avoid shadowing.
8515 (Ftranslate_region_internal): Mark var as initialized.
8517 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8520 * lisp.h (eassert): Check that the argument compiles, even if
8521 ENABLE_CHECKING is not defined.
8523 * data.c (Findirect_variable): Name an expression, to avoid
8524 gcc -Wbad-function-cast warning.
8525 (default_value, arithcompare, arith_driver, arith_error): Now static.
8526 (store_symval_forwarding): Rename local to avoid shadowing.
8527 (Fmake_variable_buffer_local, Fmake_local_variable):
8528 Mark variables as initialized.
8529 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8531 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8532 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8533 Rename locals to avoid shadowing.
8534 (mark_stack): Move local variables into the #ifdef region where
8536 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8537 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8539 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8540 (GC_STRING_CHARS): Remove; not used.
8541 (Fmemory_limit): Cast sbrk's returned value to char *.
8543 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8544 avoids undefined behavior in theory.
8546 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8548 Use functions, not macros, for up- and down-casing (Bug#8254).
8549 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8550 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8551 to use the following functions instead of these macros.
8552 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8553 EMACS_INT, since callers assume the returned value fits in int.
8554 (upcase1): Likewise, for UPCASE_TABLE.
8555 (uppercasep, lowercasep, upcase): New static inline functions.
8556 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8557 the race-condition problem in the old DOWNCASE.
8559 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8560 Rename locals to avoid shadowing.
8561 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8562 (regex_compile, re_search_2, re_match_2_internal):
8563 Remove unused local vars.
8564 (FREE_VAR): Rewrite so as not to use empty "else",
8565 which gcc can warn about.
8566 (regex_compile, re_match_2_internal): Mark locals as initialized.
8567 (RETALLOC_IF): Define only if needed.
8568 (WORDCHAR_P): Likewise. This one is never needed, but is used
8569 only in a comment talking about a compiler bug, so put inside
8570 the #if 0 of that comment.
8571 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8572 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8575 * search.c (boyer_moore): Rename locals to avoid shadowing.
8576 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8577 (PREV_CHAR_BOUNDARY): Likewise.
8579 * search.c (simple_search): Remove unused var.
8581 * dired.c (compile_pattern): Move decl from here ...
8582 * lisp.h: ... to here, so that it can be checked.
8583 (struct re_registers): New forward decl.
8585 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8587 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8589 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8590 Rename locals to avoid shadowing.
8591 (Fvertical_motion): Mark locals as initialized.
8593 * casefiddle.c (casify_object, casify_region): Now static.
8594 (casify_region): Mark local as initialized.
8596 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8598 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8599 New macros, so that the caller can use some names other than
8600 gcpro1, gcpro2, etc.
8601 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8603 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8604 argument, for consistency with GCPRO2_VAR, etc: it is now the
8605 prefix of the variable, not the variable itself. All uses
8607 * dired.c (directory_files_internal, file_name_completion):
8608 Rename locals to avoid shadowing.
8610 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8611 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8612 dired.c's scmp function, had undefined behavior.
8613 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8614 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8615 * buffer.h: ... to here, because these macros use current_buffer,
8616 and the new implementation with inline functions needs to have
8617 current_buffer in scope now, rather than later when the macros
8619 (downcase, upcase1): New static inline functions.
8620 (DOWNCASE, UPCASE1): Reimplement using these functions.
8621 This avoids undefined behavior in expressions like
8622 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8623 from race conditions in accessing the global variables
8624 case_temp1 and case_temp2.
8625 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8626 * lisp.h (case_temp1, case_temp2): Remove their decls.
8627 * character.h (ASCII_CHAR_P): Move from here ...
8628 * lisp.h: ... to here, so that the inline functions mentioned
8631 * dired.c (directory_files_internal_unwind): Now static.
8633 * fileio.c (file_name_as_directory, directory_file_name):
8634 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8636 (file_name_as_directory): Use const pointers when appropriate.
8637 (Fexpand_file_name): Likewise. In particular, newdir might
8638 point at constant storage, so make it a const pointer.
8639 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8640 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8642 (Fset_file_times, Finsert_file_contents, auto_save_error):
8643 Rename locals to avoid shadowing.
8645 * minibuf.c (choose_minibuf_frame_1): Now static.
8646 (Ftry_completion, Fall_completions): Rename or remove locals
8649 * marker.c (bytepos_to_charpos): Remove; unused.
8651 * lisp.h (verify_bytepos, count_markers): New decls,
8652 so that gcc does not warn that these functions aren't declared.
8654 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8655 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8656 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8657 (copy_text): Remove unused local var.
8659 * filelock.c (within_one_second): Now static.
8660 (lock_file_1): Rename local to avoid shadowing.
8662 * buffer.c (fix_overlays_before): Mark locals as initialized.
8663 (fix_start_end_in_overlays): Likewise. This function should be
8664 simplified by using pointers-to-pointers, but that's a different
8666 (switch_to_buffer_1): Now static.
8667 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8668 (report_overlay_modification): Rename locals to avoid shadowing.
8670 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8671 Fix pointer signedness issue.
8672 (sys_subshell): Mark local as volatile if checking for lint,
8673 to suppress a gcc -Wclobbered warning that does not seem to be right.
8674 (MAXPATHLEN): Define only if needed.
8676 * process.c (serial_open, serial_configure): Move decls from here ...
8677 * systty.h: ... to here, so that they can be checked.
8679 * fns.c (get_random, seed_random): Move extern decls from here ...
8680 * lisp.h: ... to here, so that they can be checked.
8682 * sysdep.c (reset_io): Now static.
8683 (wait_for_termination_signal): Remove; unused.
8685 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8686 (copy_keymap_item, append_key, push_text_char_description):
8688 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8689 (DENSE_TABLE_SIZE): Remove; unused.
8690 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8691 (describe_map_tree):
8692 Rename locals to avoid shadowing.
8694 * keyboard.c: Declare functions static if they are not used elsewhere.
8695 (echo_char, echo_dash, cmd_error, top_level_2):
8696 (poll_for_input, handle_async_input): Now static.
8697 (read_char, kbd_buffer_get_event, make_lispy_position):
8698 (make_lispy_event, make_lispy_movement, apply_modifiers):
8699 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8700 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8701 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8702 (read_key_sequence, read_char): Mark locals as initialized.
8703 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8705 * keyboard.h (make_ctrl_char): New decl.
8706 (mark_kboards): Move decl here ...
8707 * alloc.c (mark_kboards): ... from here.
8709 * lisp.h (force_auto_save_soon): New decl.
8711 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8712 (DEFINE_DUMMY_FUNCTION): New macro.
8713 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8715 (main): Add casts to avoid warnings
8716 if GCC considers string literals to be constants.
8718 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8720 * dbusbind.c: Pointer signedness fixes.
8721 (xd_signature, xd_append_arg, xd_initialize):
8722 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8723 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8724 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8725 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8727 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8728 if GCC considers string literals to be constants.
8729 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8731 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8733 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8734 (print_preprocess, print_object): New macro to fix last change.
8736 * print.c (print_preprocess): Don't forget font objects.
8738 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8740 * emacs.c (USAGE3): Doc fixes.
8742 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8744 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8747 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8749 * lisp.h (VWindow_system, Qfile_name_history):
8750 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8751 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8752 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8754 * w32select.c: Don't #include "keyboard.h".
8755 (run_protected): Add extern declaration for waiting_for_input.
8757 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8758 * w32console.c (detect_input_pending, read_input_pending)
8759 (encode_terminal_code):
8760 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8761 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8762 (w32_system_caret_y, Qfile_name_history):
8763 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8764 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8765 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8766 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8767 * w32proc.c (Qlocal, report_file_error):
8768 * w32term.c (Vwindow_system, updating_frame):
8769 * w32uniscribe.c (initialized, uniscribe_font_driver):
8770 Remove unneeded extern declarations.
8772 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8774 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8776 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8778 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8779 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8780 These macros can no longer be used for assignment.
8782 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8783 Assign struct members directly, instead of using BUF_BEGV etc.
8784 (record_buffer_markers, fetch_buffer_markers): New functions for
8785 recording and fetching special buffer markers.
8786 (set_buffer_internal_1, set_buffer_temp): Use them.
8788 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8790 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8792 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8793 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8795 * xdisp.c (hscroll_window_tree):
8796 (reconsider_clip_changes): Use PT instead of BUF_PT.
8798 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8800 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8801 $(EMACS_ROOT)/lib/intprops.h.
8803 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8805 Fix more problems found by GCC 4.5.2's static checks.
8807 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8808 to unsigned char * to avoid compiler diagnostic.
8809 (xg_free_frame_widgets): Make it clear that a local variable is
8810 needed only if USE_GTK_TOOLTIP.
8811 (gdk_window_get_screen): Make it clear that this macro is needed
8812 only if USE_GTK_TOOLTIP.
8813 (int_gtk_range_get_value): New function, which avoids a diagnostic
8814 from gcc -Wbad-function-cast.
8815 (xg_set_toolkit_scroll_bar_thumb): Use it.
8816 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8817 diagnostic from gcc -Wbad-function-cast.
8818 (get_utf8_string, xg_get_file_with_chooser):
8819 Rename locals to avoid shadowing.
8820 (create_dialog): Move locals to avoid shadowing.
8822 * xgselect.c (xg_select): Remove unused var.
8824 * image.c (four_corners_best): Mark locals as initialized.
8825 (gif_load): Initialize transparent_p to zero (Bug#8238).
8826 Mark another local as initialized.
8827 (my_png_error, my_error_exit): Mark with NO_RETURN.
8829 * image.c (clear_image_cache): Now static.
8830 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8831 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8832 (x_edge_detection): Remove unnecessary cast that
8833 gcc -Wbad-function-cast diagnoses.
8834 (gif_load): Fix pointer signedness.
8835 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8836 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8838 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8840 Improve quality of tests for time stamp overflow.
8841 For example, without this patch (encode-time 0 0 0 1 1
8842 1152921504606846976) returns the obviously-bogus value (-948597
8843 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8844 reports time overflow. See
8845 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8846 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8847 * editfns.c: Include limits.h and intprops.h.
8848 (TIME_T_MIN, TIME_T_MAX): New macros.
8849 (time_overflow): Move earlier, to before first use.
8850 (hi_time, lo_time): New functions, for an accurate test for
8852 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8853 (Fget_internal_run_time): Don't assume time_t fits in int.
8854 (make_time): Use list2 instead of Fcons twice.
8855 (Fdecode_time): More accurate test for out-of-range times.
8856 (check_tm_member): New function.
8857 (Fencode_time): Use it, to test for out-of-range times.
8858 (lisp_time_argument): Don't rely on undefined left-shift and
8859 right-shift behavior when checking for time stamp overflow.
8861 * editfns.c (time_overflow): New function, refactoring common code.
8862 (Fformat_time_string, Fdecode_time, Fencode_time):
8863 (Fcurrent_time_string): Use it.
8865 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8866 * dired.c (make_time): Move to ...
8867 * editfns.c (make_time): ... here.
8868 * systime.h: Note the move.
8870 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8872 * fringe.c (update_window_fringes): Remove unused variables.
8874 * unexmacosx.c (copy_data_segment): Also copy __got section.
8877 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8879 * termcap.c [MSDOS]: Include "msdos.h".
8880 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8881 Constify `char *' arguments and their references according to
8882 prototypes in tparam.h.
8884 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8886 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8887 Adapt all references accordingly.
8889 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8891 2011-03-11 Tom Tromey <tromey@redhat.com>
8893 * buffer.c (syms_of_buffer): Remove obsolete comment.
8895 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8897 * termhooks.h (encode_terminal_code): Declare prototype.
8899 * msdos.c (encode_terminal_code): Don't declare prototype.
8901 * term.c (encode_terminal_code): Now external again, used by
8902 w32console.c and msdos.c.
8904 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8905 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8907 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8909 Fix some minor problems found by GCC 4.5.2's static checks.
8911 * fringe.c (update_window_fringes): Mark locals as initialized
8913 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8915 * alloc.c (mark_fringe_data): Move decl from here ...
8916 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8917 to check its interface.
8918 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8920 * fontset.c (free_realized_fontset): Now static.
8921 (Fset_fontset_font): Rename local to avoid shadowing.
8922 (fontset_font): Mark local as initialized.
8923 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8925 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8927 * xselect.c (x_disown_buffer_selections): Remove; not used.
8928 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8929 (x_own_selection, Fx_disown_selection_internal): Rename locals
8931 (x_handle_dnd_message): Remove local to avoid shadowing.
8933 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8934 so that the caller can use some name other than gcpro1.
8935 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8936 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8937 (Fx_backspace_delete_keys_p):
8938 Use them to avoid shadowing, and rename vars to avoid shadowing.
8939 (x_decode_color, x_set_name, x_window): Now static.
8940 (Fx_create_frame): Add braces to silence GCC warning.
8941 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8942 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8943 Remove unused locals.
8944 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8945 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8946 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8949 * xterm.h (x_mouse_leave): New decl.
8951 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8952 Remove unused functions.
8953 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8954 (x_calc_absolute_position): Now static.
8955 (XTread_socket): Don't define label "out" unless it's used.
8956 Don't declare local "event" unless it's used.
8957 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8958 unless they are used.
8959 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8960 (x_fatal_error_signal): Remove; not used.
8961 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8962 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8963 (x_error_catcher, x_connection_closed, x_error_handler):
8964 (x_error_quitter, xembed_send_message, x_iconify_frame):
8965 (my_log_handler): Rename locals to avoid shadowing.
8966 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8967 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8969 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8970 Rename or move locals to avoid shadowing.
8971 (tty_defined_color, merge_face_heights): Now static.
8972 (free_realized_faces_for_fontset): Remove; not used.
8973 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8974 does not deduce is never used uninitialized.
8975 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8976 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8978 * terminal.c (store_terminal_param): Now static.
8980 * xmenu.c (menu_highlight_callback): Now static.
8981 (set_frame_menubar): Remove unused local.
8982 (xmenu_show): Rename parameter to avoid shadowing.
8983 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8984 since they might point to immutable storage.
8985 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8986 since it's unused otherwise.
8988 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8989 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8990 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8991 avoids a gcc -Wuninitialized diagnostic.
8992 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8993 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8994 does not deduce are never used uninitialized.
8996 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8998 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8999 * window.c (window_loop, size_window):
9000 (run_window_configuration_change_hook, enlarge_window): Likewise.
9002 * window.c (display_buffer): Now static.
9003 (size_window): Mark variables that gcc -Wuninitialized
9004 does not deduce are never used uninitialized.
9005 * window.h (check_all_windows): New decl, to forestall
9006 gcc -Wmissing-prototypes diagnostic.
9007 * dispextern.h (bidi_dump_cached_states): Likewise.
9009 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9011 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9013 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9014 and to avoid gcc -Wuninitialized warning.
9015 (load_charset_map): Mark variables that gcc -Wuninitialized
9016 does not deduce are never used uninitialized.
9017 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9019 * coding.c (coding_set_source, coding_set_destination):
9020 Use "else { /* comment */ }" rather than "else /* comment */;"
9021 for clarity, and to avoid gcc -Wempty-body warning.
9022 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9023 a block, when the outer 'i' will do.
9024 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9025 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9026 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9027 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9028 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9029 Rename locals to avoid shadowing.
9030 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9031 * coding.c (emacs_mule_char, encode_invocation_designation):
9032 Now static, since they're not used elsewhere.
9033 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9034 (decode_coding_object, encode_coding_object, detect_coding_system):
9035 (decode_coding_emacs_mule): Mark variables that gcc
9036 -Wuninitialized does not deduce are never used uninitialized.
9037 (detect_coding_iso_2022): Initialize a local variable that might
9038 be used uninitialized. Leave a FIXME because it's not clear that
9039 this initialization is needed. (Bug#8211)
9040 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9041 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9042 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9043 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9044 Remove unused macros.
9046 * category.c (hash_get_category_set): Remove unused local var.
9047 (copy_category_table): Now static, since it's not used elsewhere.
9048 * character.c (string_count_byte8): Likewise.
9050 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9051 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9053 * chartab.c (copy_sub_char_table): Now static, since it's not used
9055 (sub_char_table_ref_and_range, char_table_ref_and_range):
9056 Rename locals to avoid shadowing.
9057 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9059 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9060 (BIDI_BOB): Remove unused macro.
9062 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9063 deduce are never used uninitialized.
9064 * term.c (encode_terminal_code): Likewise.
9066 * term.c (encode_terminal_code): Now static. Remove unused local.
9068 * tparam.h: New file.
9069 * term.c, tparam.h: Include it.
9070 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9071 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9072 Move these decls to tparam.h, and make them agree with what
9073 is actually in tparam.c. The previous trick of using incompatible
9074 decls in different modules does not conform to the C standard.
9075 All callers of tparam changed to use tparam's actual API.
9076 * tparam.c (tparam1, tparam, tgoto):
9077 Use const pointers where appropriate.
9079 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9080 * cm.h (struct cm): Likewise.
9081 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9082 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9083 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9084 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9085 (turn_on_face, init_tty): Likewise.
9086 * termchar.h (struct tty_display_info): Likewise.
9088 * term.c (term_mouse_position): Rename local to avoid shadowing.
9090 * alloc.c (mark_ttys): Move decl from here ...
9091 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9093 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9095 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9097 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9099 * search.c (compile_pattern_1): Remove argument regp, unused since
9100 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9101 (compile_pattern): Don't pass it.
9103 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9105 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9106 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9108 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9110 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9112 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9113 gdk_window_get_screen, gdk_window_get_geometry,
9114 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9115 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9116 (xg_get_pixbuf_from_pixmap): New function.
9117 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9118 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9119 Call xg_get_pixbuf_from_pixmap instead of
9120 gdk_pixbuf_get_from_drawable.
9121 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9122 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9123 (xg_check_special_colors): Use GtkStyleContext and its functions
9125 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9126 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9127 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9128 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9129 Call gtk_widget_get_preferred_size.
9130 (xg_frame_resized): gdk_window_get_geometry only takes 5
9132 (xg_win_to_widget, xg_event_is_for_menubar):
9133 Call gdk_x11_window_lookup_for_display.
9134 (xg_set_widget_bg): New function.
9135 (delete_cb): New function.
9136 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9137 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9138 (xg_set_background_color): Call xg_set_widget_bg.
9139 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9140 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9141 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9142 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9144 (update_frame_tool_bar): Call gtk_widget_hide.
9145 (xg_initialize): Use GDK_KEY_g.
9147 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9149 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9151 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9152 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9153 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9155 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9157 * w32xfns.c (select_palette): Check success of RealizePalette against
9158 GDI_ERROR, not zero.
9160 See ChangeLog.11 for earlier changes.
9166 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9168 This file is part of GNU Emacs.
9170 GNU Emacs is free software: you can redistribute it and/or modify
9171 it under the terms of the GNU General Public License as published by
9172 the Free Software Foundation, either version 3 of the License, or
9173 (at your option) any later version.
9175 GNU Emacs is distributed in the hope that it will be useful,
9176 but WITHOUT ANY WARRANTY; without even the implied warranty of
9177 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9178 GNU General Public License for more details.
9180 You should have received a copy of the GNU General Public License
9181 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.