1 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3 Malloc failure behavior now depends on size of allocation.
4 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5 * lisp.h: Change signatures accordingly.
6 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9 * gnutls.c: Use Emacs's memory allocators.
10 Without this change, the gnutls library would invoke malloc etc.
11 directly, which causes problems on non-SYNC_INPUT hosts, and which
12 runs afoul of improving memory_full behavior. (Bug#8761)
13 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
15 xfree instead of the default malloc, realloc, free.
16 (Fgnutls_boot): No need to check for memory allocation failure,
17 since xmalloc does that for us.
19 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
21 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
23 * eval.c (Qdebug): Now static.
24 * lisp.h (Qdebug): Remove decl. This reverts a part of the
25 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
26 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
28 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
30 * image.c: Various fixes to ImageMagick code comments.
31 (Fimagemagick_types): Doc fix.
33 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
35 Minor fixes prompted by GCC 4.6.0 warnings.
37 * xselect.c (converted_selections, conversion_fail_tag): Now static.
39 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
40 (x_clipboard_manager_save_all): Move extern decl to ...
41 * xterm.h: ... here, so that it can be checked for consistency.
43 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
45 * xselect.c (x_clipboard_manager_save_frame)
46 (x_clipboard_manager_save_all): New functions.
47 (Fx_clipboard_manager_save): Lisp function deleted.
49 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
50 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
52 * xterm.h: Update prototype.
54 2011-05-28 William Xu <william.xwl@gmail.com>
56 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
59 2011-05-28 Jim Meyering <meyering@redhat.com>
61 Avoid a sign-extension bug in crypto_hash_function.
62 * fns.c (to_uchar): Define.
63 (crypto_hash_function): Use it to convert some newly-signed
64 variables to unsigned, to avoid sign-extension bugs. For example,
65 without this change, (md5 "truc") would evaluate to
66 45723a2aff78ff4fff7fff1114760e62 rather than the expected
67 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
68 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
70 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
72 Integer overflow fixes.
74 * dbusbind.c: Serial number integer overflow fixes.
75 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
76 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
77 to hold a serial number that is too large for a fixnum.
78 (Fdbus_method_return_internal, Fdbus_method_error_internal):
79 Check for serial numbers out of range. Decode any serial number
80 that was so large that it became a float. (Bug#8722)
82 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
83 (Fdbus_call_method, Fdbus_call_method_asynchronously):
84 Use XFASTINT rather than XUINT when numbers are nonnegative.
85 (xd_append_arg, Fdbus_method_return_internal):
86 (Fdbus_method_error_internal): Likewise. Also, for unsigned
87 arguments, check that Lisp number is nonnegative, rather than
88 silently wrapping negative numbers around. (Bug#8722)
89 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
92 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
94 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
96 ccl: add integer overflow checks
97 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
98 (IN_INT_RANGE): New macros.
99 (ccl_driver): Use them to check for integer overflow when
100 decoding a CCL program. Many of the new checks are whether XINT (x)
101 fits in int; it doesn't always, on 64-bit hosts. The new version
102 doesn't catch all possible integer overflows, but it's an
103 improvement. (Bug#8719)
105 * alloc.c (make_event_array): Use XINT, not XUINT.
106 There's no need for unsigned here.
108 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
109 This follows up to the 2011-05-06 change that substituted uintptr_t
110 for EMACS_INT. This case wasn't caught back then.
112 Rework Fformat to avoid integer overflow issues.
113 * editfns.c: Include <float.h> unconditionally, as it's everywhere
114 now (part of C89). Include <verify.h>.
115 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
116 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
117 (Fformat): Avoid the prepass trying to compute sizes; it was only
118 approximate and thus did not catch overflow reliably. Instead, walk
119 through the format just once, formatting and computing sizes as we go,
120 checking for integer overflow at every step, and allocating a larger
121 buffer as needed. Keep track separately whether the format is
122 multibyte. Keep only the most-recently calculated precision, rather
123 than them all. Record whether each argument has been converted to
124 string. Use EMACS_INT, not int, for byte and char and arg counts.
125 Support field widths and precisions larger than INT_MAX. Avoid
126 sprintf's undefined behavior with conversion specifications such as %#d
127 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
128 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
129 formatting out-of-range floating point numbers with int
132 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
134 * data.c: Avoid integer truncation in expressions involving floats.
135 * data.c: Include <intprops.h>.
136 (arith_driver): When there's an integer overflow in an expression
137 involving floating point, convert the integers to floating point
138 so that the resulting value does not suffer from catastrophic
139 integer truncation. For example, on a 64-bit host (* 4
140 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
141 Do not rely on undefined behavior after integer overflow.
143 merge count_size_as_multibyte, parse_str_to_multibyte
144 * character.c, character.h (count_size_as_multibyte):
145 Renamed from parse_str_to_multibyte; all uses changed.
146 Check for integer overflow.
147 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
148 since it's now a duplicate of the other. This is more of
149 a character than a buffer op, so better that it's in character.c.
150 * fns.c, print.c: Adjust to above changes.
152 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
154 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
156 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
158 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
159 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
160 (x_clipboard_manager_save): Now static.
161 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
163 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
164 (crypto_hash_function): Now static.
165 Fix pointer signedness problems. Avoid unnecessary initializations.
167 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
169 * termhooks.h (Vselection_alist): Make it terminal-local.
171 * terminal.c (create_terminal): Initialize it.
173 * xselect.c: Support for clipboard managers.
174 (Vselection_alist): Move to termhooks.h as terminal-local var.
175 (LOCAL_SELECTION): New macro.
176 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
177 (symbol_to_x_atom): Remove gratuitous arg.
178 (x_handle_selection_request, lisp_data_to_selection_data)
179 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
180 (x_own_selection, x_get_local_selection, x_convert_selection): New
181 arg, specifying work frame. Use terminal-local Vselection_alist.
182 (some_frame_on_display): Delete unused function.
183 (Fx_own_selection_internal, Fx_get_selection_internal)
184 (Fx_disown_selection_internal, Fx_selection_owner_p)
185 (Fx_selection_exists_p): New optional frame arg.
186 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
187 (x_handle_selection_clear): Don't treat other terminals with the
188 same keyboard specially. Use the terminal-local Vselection_alist.
189 (x_clear_frame_selections): Use Frun_hook_with_args.
191 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
193 * xterm.h: Add support for those atoms.
195 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
197 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
198 (converted_selections, conversion_fail_tag): New global variables.
199 (x_selection_request_lisp_error): Free the above.
200 (x_get_local_selection): Remove unnecessary code.
201 (x_reply_selection_request): Args changed; handle arbitrary array
202 of converted selections stored in converted_selections. Separate
203 the XChangeProperty and SelectionNotify steps.
204 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
205 (x_convert_selection): New function.
206 (x_handle_selection_event): Simplify.
207 (x_get_foreign_selection): Don't ignore incoming requests while
208 waiting for an answer; this will fail when we implement
209 SAVE_TARGETS, and seems unnecessary anyway.
210 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
211 (Vx_sent_selection_functions): Doc fix.
213 2011-05-26 Leo Liu <sdl.web@gmail.com>
215 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
217 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
219 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
221 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
222 for fringe update if it has periodic bitmap.
223 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
224 and fringe_bitmap_periodic_p.
226 * fringe.c (get_fringe_bitmap_data): New function.
227 (draw_fringe_bitmap_1, update_window_fringes): Use it.
228 (update_window_fringes): Record periodicity of fringe bitmap in glyph
229 row. Mark glyph row for fringe update if periodicity changed.
231 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
232 for fringe update unless it has periodic bitmap.
234 2011-05-25 Kenichi Handa <handa@m17n.org>
236 * xdisp.c (get_next_display_element): Set correct it->face_id for
237 a static composition.
239 2011-05-24 Leo Liu <sdl.web@gmail.com>
242 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
244 * fns.c (crypto_hash_function, Fsha1): New function.
245 (Fmd5): Use crypto_hash_function.
246 (syms_of_fns): Add Ssha1.
248 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
250 * gnutls.c: Remove unused macros.
251 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
252 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
253 Remove macros that are defined and never used.
254 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
256 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
258 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
259 (Fx_get_selection_internal): Minor cleanup.
260 (Fx_own_selection_internal): Rename arguments for consistency with
263 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
265 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
267 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
269 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
271 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
273 * dispnew.c (scrolling_window): Don't exclude the case that the
274 last enabled row in the desired matrix touches the bottom boundary.
276 2011-05-21 Glenn Morris <rgm@gnu.org>
278 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
279 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
280 and add some more files.
282 2011-05-20 Eli Zaretskii <eliz@gnu.org>
284 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
285 report_file_error introduced by the change from 2011-05-07.
287 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
289 * systime.h (Time): Define only if emacs is defined.
290 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
291 where the include path doesn't have X11/X.h by default. See
292 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
294 2011-05-20 Kenichi Handa <handa@m17n.org>
296 * composite.c (find_automatic_composition): Fix previous change.
298 2011-05-20 Glenn Morris <rgm@gnu.org>
300 * lisp.mk: New file, split from Makefile.in.
301 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
303 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
305 2011-05-19 Glenn Morris <rgm@gnu.org>
307 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
308 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
309 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
310 (lisp): Set the order to that of loadup.el.
311 (shortlisp): Make it a copy of $lisp.
312 (SOME_MACHINE_LISP): Remove.
313 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
314 Use just $shortlisp, not $SOME_MACHINE_LISP too.
316 2011-05-18 Kenichi Handa <handa@m17n.org>
318 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
319 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
320 (find_automatic_composition): Mostly rewrite for efficiency.
322 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
324 * makefile.w32-in: Update dependencies.
326 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
328 * menu.c: Include limits.h (fixes the MS-Windows build broken by
331 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
333 Fix some integer overflow issues, such as string length overflow.
335 * insdel.c (count_size_as_multibyte): Check for string overflow.
337 * character.c (lisp_string_width): Check for string overflow.
338 Use EMACS_INT, not int, for string indexes and lengths; in
339 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
340 the resulting string length overflows an EMACS_INT; instead,
341 report a string overflow if no precision given. When checking for
342 precision exhaustion, use a check that cannot possibly have
343 integer overflow. (Bug#8675)
344 * character.h (lisp_string_width): Adjust to new signature.
346 * alloc.c (string_overflow): New function.
347 (Fmake_string): Use it. This doesn't change behavior, but saves
348 a few bytes and will simplify future changes.
349 * character.c (string_escape_byte8): Likewise.
350 * lisp.h (string_overflow): New decl.
352 Fixups, following up to the user-interface timestamp change.
353 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
354 for UI timestamps, instead of unsigned long.
355 * msdos.c (mouse_get_pos): Likewise.
356 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
357 * w32gui.h (Time): Define by including "systime.h" rather than by
358 declaring it ourselves. (Bug#8664)
360 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
361 * image.c (clear_image_cache): Likewise.
363 * term.c (term_mouse_position): Don't assume time_t wraparound.
365 Be more systematic about user-interface timestamps.
366 Before, the code sometimes used 'Time', sometimes 'unsigned long',
367 and sometimes 'EMACS_UINT', to represent these timestamps. This
368 change causes it to use 'Time' uniformly, as that's what X uses.
369 This makes the code easier to follow, and makes it easier to catch
370 integer overflow bugs such as Bug#8664.
371 * frame.c (Fmouse_position, Fmouse_pixel_position):
372 Use Time, not unsigned long, for user-interface timestamps.
373 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
374 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
375 * keyboard.h (last_event_timestamp): Likewise.
376 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
377 * menu.h (xmenu_show): Likewise.
378 * term.c (term_mouse_position): Likewise.
379 * termhooks.h (struct input_event.timestamp): Likewise.
380 (struct terminal.mouse_position_hook): Likewise.
381 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
382 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
383 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
384 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
386 * menu.h, termhooks.h: Include "systime.h", for Time.
388 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
389 Don't assume that the difference between two unsigned long values
390 can fit into an integer. At this point, we know button_down_time
391 <= event->timestamp, so the difference must be nonnegative, so
392 there's no need to cast the result if double-click-time is
393 nonnegative, as it should be; check that it's nonnegative, just in
394 case. This bug is triggered when events are more than 2**31 ms
395 apart (about 25 days). (Bug#8664)
397 * xselect.c (last_event_timestamp): Remove duplicate decl.
398 (x_own_selection): Remove needless cast to unsigned long.
400 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
401 that always fit in int. Use a sentinel instead of a counter, to
402 avoid a temp and to allay GCC's concerns about possible int overflow.
403 * frame.h (struct frame): Use int for menu_bar_items_used
404 instead of EMACS_INT, since it always fits in int.
406 * menu.c (grow_menu_items): Check for int overflow.
408 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
410 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
411 Before, the code was not consistent. These values cannot exceed
412 2**31 - 1 so there's no need to make them unsigned.
413 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
414 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
415 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
417 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
419 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
420 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
421 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
422 presumably because the widths might not match.
424 * window.c (size_window): Avoid needless test at loop start.
426 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
428 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
430 2011-05-12 Drew Adams <drew.adams@oracle.com>
432 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
434 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
436 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
437 `width' to `bar_area_x' and `bar_area_width', respectively.
438 (x_scroll_run): Take account of fringe background extension.
440 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
441 Rename local vars `left' and `width' to `bar_area_x' and
442 `bar_area_width', respectively.
443 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
444 background extension.
446 2011-05-10 Jim Meyering <meyering@redhat.com>
448 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
450 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
452 * image.c (Finit_image_library): Return t for built-in image types,
453 like pbm and xbm. (Bug#8640)
455 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
457 * w32menu.c (set_frame_menubar): Fix submenu allocation.
459 2011-05-07 Eli Zaretskii <eliz@gnu.org>
461 * w32console.c (Fset_screen_color): Doc fix.
462 (Fget_screen_color): New function.
463 (syms_of_ntterm): Defsubr it.
465 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
466 unlink the temporary file if Fcall_process didn't create it in the
468 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
469 child process will be redirected to a file specified with `:file'.
470 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
471 cue to call_process_cleanup not to close that handle.
473 2011-05-07 Ben Key <bkey76@gmail.com>
475 * makefile.w32-in: The bootstrap-temacs rule now makes use of
476 one of two shell specific rules, either bootstrap-temacs-CMD or
477 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
478 to the previous implementation of the bootstrap-temacs rule.
479 The bootstrap-temacs-CMD rule is similar to the previous
480 implementation of the bootstrap-temacs rule except that it
481 makes use of the ESC_CFLAGS variable instead of the CFLAGS
484 These changes, along with some changes to nt/configure.bat,
485 nt/gmake.defs, and nt/nmake.defs, are required to extend my
486 earlier fix to add support for --cflags and --ldflags options
487 that include quotes so that it works whether make uses cmd or
490 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
492 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
493 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
495 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
496 a string. Handle both cases.
497 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
498 (Fdbus_register_method): Use Qinvalid_function.
500 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
502 * makefile.w32-in: Update dependencies.
503 (LISP_H): Add inttypes.h and stdin.h.
504 (PROCESS_H): Add unistd.h.
506 2011-05-06 Eli Zaretskii <eliz@gnu.org>
508 * lread.c: Include limits.h (fixes the MS-Windows build broken by
509 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
511 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
513 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
515 * term.c (vfatal): Remove stray call to va_end.
516 It's not needed and the C Standard doesn't allow it here anyway.
518 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
519 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
521 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
524 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
526 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
528 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
530 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
532 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
534 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
535 * charset.c (Fdefine_charset_internal): Don't initialize
536 charset.code_space[15]. The value was garbage, on hosts with
537 32-bit int (Bug#8600).
539 * lread.c (read_integer): Be more consistent with string-to-number.
540 Use string_to_number to do the actual conversion; this avoids
541 rounding errors and fixes some other screwups. Without this fix,
542 for example, #x1fffffffffffffff was misread as -2305843009213693952.
543 (digit_to_number): Move earlier, for benefit of read_integer.
544 Return -1 if the digit is out of range for the base, -2 if it is
545 not a digit in any supported base. (Bug#8602)
547 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
549 * dispnew.c (scrolling_window): Return 1 if we scrolled,
550 to match comment at start of function. This also removes a
551 GCC warning about overflow in a 32+64-bit port.
553 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
555 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
556 Reported by Stefan Monnier in
557 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
558 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
559 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
561 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
562 (EMACS_UINTPTR): Likewise, with uintptr_t.
564 * lisp.h: Prefer 64-bit EMACS_INT if available.
565 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
566 on 32-bit hosts that have 64-bit int, so that they can access
568 However, temporarily disable this change unless the temporary
569 symbol WIDE_EMACS_INT is defined.
571 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
573 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
574 This removes an assumption that EMACS_INT and long are the same
575 width as pointers. The assumption is true for Emacs porting targets
576 now, but we want to make other targets possible.
577 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
578 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
579 In the rest of the code, change types of integers that hold casted
580 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
581 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
582 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
583 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
584 No need to cast type when ORing.
585 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
586 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
587 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
588 assume EMACS_INT is the same width as char *.
589 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
590 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
591 Remove no-longer-needed casts.
592 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
593 (xg_tool_bar_help_callback, xg_make_tool_item):
594 Use EMACS_INTPTR to hold an integer
595 that will be cast to void *; this can avoid a GCC warning
596 if EMACS_INT is not the same width as void *.
597 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
598 * xdisp.c (display_echo_area_1, resize_mini_window_1):
599 (current_message_1, set_message_1):
600 Use a local to convert to proper width without a cast.
601 * xmenu.c (dialog_selection_callback): Likewise.
603 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
604 Also, don't assume VALBITS / RAND_BITS is less than 5,
605 and don't rely on undefined behavior when shifting a 1 left into
607 * lisp.h (get_random): Change signature to match.
609 * lread.c (hash_string): Use size_t, not int, for hash computation.
610 Normally we prefer signed values; but hashing is special, because
611 it's better to use unsigned division on hash table sizes so that
612 the remainder is nonnegative. Also, size_t is the natural width
613 for hashing into memory. The previous code used 'int', which doesn't
614 retain enough info to hash well into very large tables.
615 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
617 * dbusbind.c: Don't possibly lose pointer info when converting.
618 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
619 Use XPNTR rather than XHASH, so that the high-order bits of
620 the pointer aren't lost when converting through void *.
622 * eval.c (Fautoload): Don't double-shift a pointer.
624 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
626 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
628 * gnutls.c (DEF_GNUTLS_FN):
629 * image.c (DEF_IMGLIB_FN): Make function pointers static.
631 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
633 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
636 2011-05-05 Eli Zaretskii <eliz@gnu.org>
638 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
639 New version that can reserve upto 2GB of heap space.
641 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
643 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
645 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
647 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
648 `gnutls_certificate_set_x509_key_file'.
650 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
652 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
655 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
657 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
658 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
659 Remove unused parameter `fildes'.
660 * process.c (read_process_output, send_process): Don't pass it.
662 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
664 Fix previous change: the library cache is defined in w32.c.
665 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
666 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
668 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
670 Implement dynamic loading of GnuTLS on Windows.
672 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
673 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
674 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
677 * gnutls.c (Qgnutls_dll): Define.
678 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
679 (gnutls_*): Declare function pointers.
680 (init_gnutls_functions): New function to initialize function pointers.
681 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
682 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
683 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
684 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
685 (emacs_gnutls_write, emacs_gnutls_read)
686 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
687 (Fgnutls_available_p): New function.
688 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
689 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
690 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
692 * image.c: Include w32.h.
693 (Vimage_type_cache): Delete.
694 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
695 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
696 (w32_delayed_load): Move to w32.c.
698 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
700 * w32.c (QCloaded_from, Vlibrary_cache): Define.
701 (w32_delayed_load): Move from image.c. When loading a library, record
702 its filename in the :loaded-from property of the library id.
703 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
704 Initialize and staticpro them.
705 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
707 * process.c: Include lisp.h before w32.h, not after.
708 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
709 instead of gnutls_record_check_pending.
711 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
713 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
715 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
716 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
719 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
721 * xterm.c (x_set_frame_alpha): Do not set property on anything
722 else than FRAME_X_OUTER_WINDOW (Bug#8608).
724 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
726 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
728 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
730 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
731 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
732 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
733 (gnutls_global_initialized, Qgnutls_bootprop_priority)
734 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
735 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
736 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
737 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
738 (Qgnutls_bootprop_callbacks_verify): Make static.
740 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
742 * callproc.c: Indentation fixup.
744 * sysdep.c (wait_for_termination_1): Make static.
745 (wait_for_termination, interruptible_wait_for_termination):
746 Move after wait_for_termination_1.
748 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
750 * sysdep.c (interruptible_wait_for_termination): New function
751 which is like wait_for_termination, but allows keyboard
754 * callproc.c (Fcall_process): Add (:file "file") as an option for
756 (Fcall_process_region): Ditto.
758 2011-04-30 Eli Zaretskii <eliz@gnu.org>
760 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
761 rather than `XVECTOR (FOO)->size'.
763 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
764 inttypes.h, as a gnulib replacement is used if it not available in
767 2011-04-21 Eli Zaretskii <eliz@gnu.org>
769 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
770 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
771 of MOST_POSITIVE_FIXNUM. (Bug#8528)
773 * coding.c (coding_alloc_by_realloc): Error out if destination
774 will grow beyond MOST_POSITIVE_FIXNUM.
775 (decode_coding_emacs_mule): Abort if there isn't enough place in
776 charbuf for the composition carryover bytes. Reserve an extra
777 space for up to 2 characters produced in a loop.
778 (decode_coding_iso_2022): Abort if there isn't enough place in
779 charbuf for the composition carryover bytes.
781 2011-04-21 Eli Zaretskii <eliz@gnu.org>
783 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
784 aborting when %lld or %lll format is passed.
785 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
786 %llo or %llx format is passed. (Bug#8545)
788 * window.c (window_scroll_line_based): Use a marker instead of
789 simple variables to record original value of point. (Bug#7952)
791 * doprnt.c (doprnt): Fix the case where a multibyte sequence
792 produced by %s or %c overflows available buffer space. (Bug#8545)
794 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
796 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
797 (SIZE_MAX): Move defn after all includes, as they might #define it.
799 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
801 * w32.c (init_environment): Warn about defaulting HOME to C:\.
803 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
805 * keyboard.c (Qdelayed_warnings_hook): Define.
806 (command_loop_1): Run `delayed-warnings-hook'
807 if Vdelayed_warnings_list is non-nil.
808 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
809 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
811 2011-04-28 Eli Zaretskii <eliz@gnu.org>
813 * doprnt.c (doprnt): Don't return value smaller than the buffer
814 size if the message was truncated. (Bug#8545).
816 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
818 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
819 (Fx_window_property): #if-0 the whole functions, not just the bodies.
821 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
823 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
825 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
827 * makefile.w32-in: Update dependencies.
829 2011-04-27 Eli Zaretskii <eliz@gnu.org>
831 Improve `doprnt' and its usage. (Bug#8545)
832 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
833 `format_end'. Remove support for %l as a conversion specifier.
834 Don't use xrealloc. Improve diagnostics when the %l size modifier
835 is used. Update the commentary.
837 * eval.c (verror): Simplify calculation of size_t.
839 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
842 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
844 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
847 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
849 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
850 This makes this file independent of the recent pseudovector change.
852 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
854 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
856 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
857 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
859 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
861 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
862 GCC 4.6.0 optimizes based on type-based alias analysis.
863 For example, if b is of type struct buffer * and v of type struct
864 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
865 != &v->size, and therefore "v->size = 1; b->size = 2; return
866 v->size;" must therefore return 1. This assumption is incorrect
867 for Emacs, since it type-puns struct Lisp_Vector * with many other
868 types. To fix this problem, this patch adds a new type struct
869 vectorlike_header that documents the constraints on layout of vectors
870 and pseudovectors, and helps optimizing compilers not get fooled
871 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
872 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
873 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
875 (XSETPVECTYPE): Rewrite in terms of new macro.
876 (XSETPVECTYPESIZE): New macro, specifying both type and size.
877 This is a bit clearer, and further avoids the possibility of
878 undesirable aliasing.
879 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
880 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
881 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
882 since Lisp_Subr is a special case (no "next" field).
883 (ASIZE): Now uses header.size rather than size.
884 All previous uses of XVECTOR (foo)->size replaced to use this macro,
885 to avoid the hassle of writing XVECTOR (foo)->header.size.
886 (struct vectorlike_header): New type.
887 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
888 object, to help avoid aliasing.
889 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
890 (SUBRP): Likewise, since Lisp_Subr is a special case.
891 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
892 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
893 (struct Lisp_Hash_Table): Combine first two members into a single
894 struct vectorlike_header member. All uses of "size" and "next" members
895 changed to be "header.size" and "header.next".
896 * buffer.h (struct buffer): Likewise.
897 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
898 * frame.h (struct frame): Likewise.
899 * process.h (struct Lisp_Process): Likewise.
900 * termhooks.h (struct terminal): Likewise.
901 * window.c (struct save_window_data, struct saved_window): Likewise.
902 * window.h (struct window): Likewise.
903 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
904 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
905 * buffer.c (init_buffer_once): Likewise.
906 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
908 * process.c (Fformat_network_address): Use local var for size,
911 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
913 Make the Lisp reader and string-to-float more consistent (Bug#8525)
914 * data.c (atof): Remove decl; no longer used or needed.
915 (digit_to_number): Move to lread.c.
916 (Fstring_to_number): Use new string_to_number function, to be
917 consistent with how the Lisp reader treats infinities and NaNs.
918 Do not assume that floating-point numbers represent EMACS_INT
919 without losing information; this is not true on most 64-bit hosts.
920 Avoid double-rounding errors, by insisting on integers when
921 parsing non-base-10 numbers, as the documentation specifies.
922 * lisp.h (string_to_number): New decl, replacing ...
923 (isfloat_string): Remove.
924 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
925 (read1): Do not accept +. and -. as integers; this
926 appears to have been a coding error. Similarly, do not accept
927 strings like +-1e0 as floating point numbers. Do not report
928 overflow for integer overflows unless the base is not 10 which
929 means we have no simple and reliable way to continue.
930 Break out the floating-point parsing into a new
931 function string_to_number, so that Fstring_to_number parses
932 floating point numbers consistently with the Lisp reader.
933 (digit_to_number): Move here from data.c. Make it static inline.
934 (E_CHAR, EXP_INT): Remove, replacing with ...
935 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
936 (string_to_number): New function, replacing isfloat_string.
937 This function checks for valid syntax and produces the resulting
938 Lisp float number too. Rework it so that string-to-number
939 no longer mishandles examples like "1.0e+". Use strtoumax,
940 so that overflow for non-base-10 numbers is reported only when
941 there's no portable and simple way to convert to floating point.
943 * textprop.c (set_text_properties_1): Rewrite for clarity,
944 and to avoid GCC warning about integer overflow.
946 * intervals.h (struct interval): Use EMACS_INT for members
947 where EMACS_UINT might cause problems. See
948 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
949 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
950 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
952 (offset_intervals): Tell GCC not to worry about length overflow
953 when negating a negative length.
955 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
956 (overrun_check_free): Likewise.
958 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
959 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
962 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
963 (gnutls_make_error): Rename local to avoid shadowing.
964 (gnutls_emacs_global_deinit): ifdef out; not used.
965 (Fgnutls_boot): Use const for pointer to readonly storage.
966 Comment out unused local. Fix pointer signedness problems.
968 * lread.c (openp): Don't stuff size_t into an 'int'.
969 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
970 about possible signed overflow.
972 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
973 (GDK_KEY_g): Don't define if already defined.
974 (xg_prepare_tooltip): Avoid pointer signedness problem.
975 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
977 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
978 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
980 * xfns.c (Fx_window_property): Simplify a bit,
981 to make a bit faster and to avoid GCC 4.6.0 warning.
982 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
984 * fns.c (internal_equal): Don't assume size_t fits in int.
986 * alloc.c (compact_small_strings): Tighten assertion a little.
988 Replace pEd with more-general pI, and fix some printf arg casts.
989 * lisp.h (pI): New macro, generalizing old pEd macro to other
990 conversion specifiers. For example, use "...%"pI"d..." rather
992 (pEd): Remove. All uses replaced with similar uses of pI.
993 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
994 * alloc.c (check_pure_size): Don't overflow by converting size to int.
995 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
996 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
997 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
998 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
999 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1001 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1002 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1003 * print.c (safe_debug_print, print_object): Likewise.
1004 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1006 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1007 avoiding the 0 flag, which is not portable.
1008 * process.c (Fmake_network_process): Use pI to avoid cast.
1009 * region-cache.c (pp_cache): Likewise.
1010 * xdisp.c (decode_mode_spec): Likewise.
1011 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1012 behavior on 64-bit hosts with printf arg.
1013 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1014 (x_stop_queuing_selection_requests): Likewise.
1015 (x_get_window_property): Don't truncate byte count to an 'int'
1018 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1019 here, since it parses constructs like leading '-' and spaces,
1020 which are not wanted; and it overflows with large numbers.
1021 Instead, simply match F[0-9]+, which is what is wanted anyway.
1023 * alloc.c: Remove unportable assumptions about struct layout.
1024 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1025 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1026 (allocate_vectorlike, make_pure_vector): Use the new macros,
1027 plus offsetof, to remove unportable assumptions about struct layout.
1028 These assumptions hold on all porting targets that I know of, but
1029 they are not guaranteed, they're easy to remove, and removing them
1030 makes further changes easier.
1032 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1033 This doesn't fix a bug but makes the code clearer.
1034 (string_overrun_cookie): Now const. Use initializers that
1035 don't formally overflow signed char, to avoid warnings.
1036 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1037 can cause Emacs to crash when string overrun checking is enabled.
1038 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1039 multiple of sizeof (EMACS_INT); it need not be, if
1040 alignof(EMACS_INT) < sizeof (EMACS_INT).
1041 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1043 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1045 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1047 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1049 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1050 supposed to be handshaking. (Bug#8556)
1051 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1053 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1055 * lisp.h (Qdebug): List symbol.
1056 * eval.c (Qdebug): Restore global linkage.
1057 * keyboard.c (debug-on-event): New variable.
1058 (handle_user_signal): Break into debugger when debug-on-event
1059 matches the current signal symbol.
1061 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1063 * alloc.c (check_sblock, check_string_bytes)
1064 (check_string_free_list): Convert to standard C.
1066 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1068 * w32.c (emacs_gnutls_push): Fix typo.
1070 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1072 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1073 "cast to pointer from integer of different size".
1075 Improve doprnt and its use in verror. (Bug#8545)
1076 * doprnt.c (doprnt): Document the set of format control sequences
1077 supported by the function. Use SAFE_ALLOCA instead of always
1080 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1081 is one byte too soon. Don't use xrealloc; instead xfree and
1084 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1086 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1089 * gnutls.c: Renamed global_initialized to
1090 gnutls_global_initialized. Added internals for the
1091 :verify-hostname-error, :verify-error, and :verify-flags
1092 parameters of `gnutls-boot' and documented those parameters in the
1093 docstring. Start callback support.
1094 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1095 unless a fatal error occured. Call gnutls_alert_send_appropriate
1096 on error. Return error code.
1097 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1098 (emacs_gnutls_read): Likewise.
1099 (Fgnutls_boot): Return handshake error code.
1100 (emacs_gnutls_handle_error): New function.
1101 (wsaerror_to_errno): Likewise.
1103 * w32.h (emacs_gnutls_pull): Add prototype.
1104 (emacs_gnutls_push): Likewise.
1106 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1107 (emacs_gnutls_push): Likewise.
1109 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1111 * process.c (wait_reading_process_output): Check if GnuTLS
1112 buffered some data internally if no FDs are set for TLS
1115 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1116 (LIBS): Link to USER_LIBS.
1117 ($(BLD)/gnutls.$(0)): New target.
1119 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1121 * xdisp.c (handle_single_display_spec): Rename the
1122 display_replaced_before_p argument into display_replaced_p, to
1123 make it consistent with the commentary. Fix typos in the
1126 * textprop.c (syms_of_textprop): Remove dead code.
1127 (copy_text_properties): Delete obsolete commentary about an
1128 interface that was deleted long ago. Fix typos in the description
1131 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1132 to changes in oldXMenu/XMenu.h from 2011-04-16.
1133 <menu_help_message, prev_menu_help_message>: Constify.
1134 (IT_menu_make_room): menu->help_text is now `const char **';
1137 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1138 to changes in oldXMenu/XMenu.h from 2011-04-16.
1139 (struct XMenu): Declare `help_text' `const char **'.
1141 * xfaces.c <Qunspecified>: Make extern again.
1143 * syntax.c: Include sys/types.h before including regex.h, as
1146 * doc.c (get_doc_string): Improve the format passed to `error'.
1148 * doprnt.c (doprnt): Improve commentary.
1150 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1152 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1155 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1156 changes in globals.h immediately force recompilation.
1157 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1158 $(CURDIR)/s/ms-w32.h.
1159 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1161 * character.c (Fchar_direction): Function deleted.
1162 (syms_of_character): Don't defsubr it.
1163 <char-direction-table>: Deleted.
1165 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1167 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1168 * doprnt.c: Include limits.h.
1169 (SIZE_MAX): New macro.
1170 (doprnt): Return a size_t value. 2nd arg is now size_t.
1171 Many local variables are now size_t instead of int or unsigned.
1172 Improve overflow protection. Support `l' modifier for integer
1173 conversions. Support %l conversion. Don't assume an EMACS_INT
1174 argument for integer conversions and for %c.
1176 * lisp.h (doprnt): Restore prototype.
1178 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1181 * Makefile.in (base_obj): Add back doprnt.o.
1183 * deps.mk (doprnt.o): Add back prerequisites.
1184 (callint.o): Depend on character.h.
1186 * eval.c (internal_lisp_condition_case): Include the handler
1187 representation in the error message.
1188 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1189 when breaking from the loop.
1191 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1193 * callint.c (Fcall_interactively): When displaying error message
1194 about invalid control letter, pass the character's codepoint, not
1195 a pointer to its multibyte form. Improve display of the character
1196 in octal and display also its hex code.
1198 * character.c (char_string): Use %x to display the (unsigned)
1199 codepoint of an invalid character, to avoid displaying a bogus
1202 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1203 `error', not SYMBOL_NAME itself.
1205 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1206 character arguments to `error'.
1208 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1209 to `error' in error message about FINAL_CHAR argument. Make sure
1210 FINAL_CHAR is a character, and use %c when it is passed as
1211 argument to `error'.
1213 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1215 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1217 * w32.c: Include <time.h>.
1218 (sys_localtime): New function.
1220 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1222 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1224 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1226 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1228 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1231 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1233 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1234 gl_state.e_property when gl_state.object is Qt.
1236 * insdel.c (make_gap_larger): Remove limitation of buffer size
1239 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1241 * xdisp.c (lookup_glyphless_char_display)
1242 (produce_glyphless_glyph): Handle cons cell entry in
1243 glyphless-char-display.
1244 (Vglyphless_char_display): Document it.
1246 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1247 glyphless-char-display.
1249 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1251 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1253 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1255 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1256 definition for no-X builds.
1258 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1260 Static checks with GCC 4.6.0 and non-default toolkits.
1262 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1264 * process.c (keyboard_bit_set): Define only if SIGIO.
1265 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1266 (send_process): Repair possible setjmp clobbering.
1268 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1270 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1272 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1274 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1275 Define only if needed.
1277 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1278 by pacifying GCC about it. Maybe it's time to retire it?
1279 * xfaces.c (USG, __TIMEVAL__): Likewise.
1281 * dispextern.h (struct redisplay_interface): Rename param
1283 * termhooks.h (struct terminal): Likewise.
1284 * xterm.c (xembed_send_message): Likewise.
1286 * insdel.c (make_gap_smaller): Define only if
1287 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1289 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1292 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1293 so that we aren't warned about unused symbols.
1295 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1297 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1299 * xfns.c (x_real_positions): Mark locals as initialized.
1301 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1303 * xterm.c: Fix problems found by static analysis with other toolkits.
1304 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1305 (x_dispatch_event): Declare static if USE_GTK, and
1306 define if USE_GTK || USE_X_TOOLKIT.
1307 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1308 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1309 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1310 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1312 * xmenu.c (menu_help_callback): Pointer type fixes.
1313 Use const pointers when pointing at readonly data. Avoid pointer
1315 (FALSE): Remove unused macro.
1316 (update_frame_menubar): Remove unused decl.
1318 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1320 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1321 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1322 (single_menu_item): Rename local to avoid shadowing.
1324 * keyboard.c (make_lispy_event): Remove unused local var.
1326 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1327 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1329 * bitmaps: Change bitmaps from unsigned char back to the X11
1330 compatible char. Avoid the old compiler warnings about
1331 out-of-range initializers by using, for example, '\xab' rather
1334 * xgselect.c (xgselect_initialize): Check vs interface
1335 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1337 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1339 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1340 to read-only memory.
1342 * fns.c (vector): Remove; this old hack is no longer needed.
1344 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1346 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1348 * xrdb.c (x_load_resources): Omit unused local.
1350 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1351 (x_window): Rename locals to avoid shadowing.
1352 (USG): Use the kludged USG macro, to pacify gcc.
1354 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1355 (x_term_init): Remove local to avoid shadowing.
1357 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1359 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1360 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1362 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1364 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1366 Fix regex.c, syntax.c and friends for buffers > 2GB.
1367 * syntax.h (struct gl_state_s): Declare character position members
1370 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1372 * textprop.c (verify_interval_modification, interval_of):
1373 Declare arguments EMACS_INT.
1375 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1378 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1380 * indent.c (Fvertical_motion): Local variable it_start is now
1383 * regex.c (re_match, re_match_2, re_match_2_internal)
1384 (bcmp_translate, regcomp, regexec, print_double_string)
1385 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1386 (re_compile_pattern, re_exec): Declare arguments and local
1387 variables `size_t' and `ssize_t' and return values `regoff_t', as
1389 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1390 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1391 <compile_stack_type>: `size' and `avail' are now `size_t'.
1393 * regex.h <regoff_t>: Use ssize_t, not int.
1394 (re_search, re_search_2, re_match, re_match_2): Arguments that
1395 specify buffer/string position and length are now ssize_t and
1396 size_t. Return type is regoff_t.
1398 2011-04-16 Ben Key <bkey76@gmail.com>
1400 * nsfont.m: Fixed bugs in ns_get_family and
1401 ns_descriptor_to_entity that were caused by using free to
1402 deallocate memory blocks that were allocated by xmalloc (via
1403 xstrdup). This caused Emacs to crash when compiled with
1404 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1405 --enable-checking=xmallocoverrun). xfree is now used to
1406 deallocate these memory blocks.
1408 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1410 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1412 emacs_write: Accept and return EMACS_INT for sizes.
1413 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1415 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1416 Accept and return EMACS_INT.
1417 (emacs_gnutls_write): Return the number of bytes written on
1419 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1420 (emacs_read, emacs_write): Remove check for negative size, as the
1421 Emacs source code has been audited now.
1422 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1423 (emacs_read, emacs_write): Use it.
1424 * process.c (send_process): Adjust to the new signatures of
1425 emacs_write and emacs_gnutls_write. Do not attempt to store
1426 a byte offset into an 'int'; it might overflow.
1427 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1429 * sound.c: Don't assume sizes fit in 'int'.
1430 (struct sound_device.period_size, alsa_period_size):
1431 Return EMACS_INT, not int.
1432 (struct sound_device.write, vox_write, alsa_write):
1433 Accept EMACS_INT, not int.
1434 (wav_play, au_play): Use EMACS_INT to store sizes and to
1435 record read return values.
1437 2011-04-15 Ben Key <bkey76@gmail.com>
1439 * keyboard.c (Qundefined): Don't declare static since it is used
1441 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1442 static since they are used in nsfont.m.
1444 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1446 * process.c (Qprocessp): Don't declare static.
1447 * lisp.h (Qprocessp): Declare again.
1449 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1451 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1453 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1455 Improve C-level modularity by making more things 'static'.
1457 Don't publish debugger-only interfaces to other modules.
1458 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1459 (verify_bytepos, count_markers): Move decls to the only modules
1461 * region-cache.h (pp_cache): Likewise.
1462 * window.h (check_all_windows): Likewise.
1463 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1465 * sysdep.c (croak): Now static, if
1466 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1467 * syssignal.h (croak): Declare only if not static.
1469 * alloc.c (refill_memory_reserve): Now static if
1470 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1471 * lisp.h (refill_memory_reserve): Declare only if not static.
1473 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1474 Define only if USE_LUCID.
1476 * xrdb.c (x_customization_string, x_rm_string): Now static.
1478 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1479 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1481 * xdisp.c (draw_row_with_mouse_face): Now static.
1482 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1484 * window.h (check_all_windows): Mark externally visible.
1486 * window.c (window_deletion_count): Now static.
1488 * undo.c: Make symbols static if they're not exported.
1489 (last_undo_buffer, last_boundary_position, pending_boundary):
1492 * textprop.c (interval_insert_behind_hooks): Now static.
1493 (interval_insert_in_front_hooks): Likewise.
1495 * term.c: Make symbols static if they're not exported.
1496 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1497 (max_frame_lines, tty_set_terminal_modes):
1498 (tty_reset_terminal_modes, tty_turn_off_highlight):
1499 (get_tty_terminal): Now static.
1500 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1501 * termhooks.h (term_mouse_moveto): Do not declare if
1503 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1504 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1506 * sysdep.c: Make symbols static if they're not exported.
1507 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1509 (sigprocmask_set, full_mask): Remove; unused.
1510 (wait_debugging): Mark as visible.
1511 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1512 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1514 * syntax.c (syntax_temp): Define only if !__GNUC__.
1516 * sound.c (current_sound_device, current_sound): Now static.
1518 * search.c (searchbufs, searchbuf_head): Now static.
1520 * scroll.c (scroll_cost): Remove; unused.
1521 * dispextern.h (scroll_cost): Remove decl.
1523 * region-cache.h (pp_cache): Mark as externally visible.
1525 * process.c: Make symbols static if they're not exported.
1526 (process_tick, update_tick, create_process, chan_process):
1527 (Vprocess_alist, proc_buffered_char, datagram_access):
1528 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1529 (deactivate_process): Mark defn as static, as well as decl.
1530 * lisp.h (create_process): Remove decl.
1531 * process.h (chan_process, Vprocess_alist): Remove decls.
1533 * print.c: Make symbols static if they're not exported.
1534 (print_depth, new_backquote_output, being_printed, print_buffer):
1535 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1536 (print_interval, print_number_index, initial_stderr_stream):
1538 * lisp.h (Fprinc): Remove decl.
1539 (debug_output_compilation_hack): Mark as externally visible.
1541 * sysdep.c (croak): Move decl from here to syssignal.h.
1542 * syssignal.h (croak): Put it here, so the API can be checked when
1543 'croak' is called from dissociate_if_controlling_tty.
1545 * minibuf.c: Make symbols static if they're not exported.
1546 (minibuf_save_list, choose_minibuf_frame): Now static.
1547 * lisp.h (choose_minibuf_frame): Remove decl.
1549 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1551 * lread.c: Make symbols static if they're not exported.
1552 (read_objects, initial_obarray, oblookup_last_bucket_number):
1554 (make_symbol): Remove; unused.
1555 * lisp.h (initial_obarray, make_symbol): Remove decls.
1557 * keyboard.c: Make symbols static if they're not exported.
1558 (single_kboard, recent_keys_index, total_keys, recent_keys):
1559 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1560 (this_single_command_key_start, echoing, last_auto_save):
1561 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1562 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1563 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1564 (Vlispy_mouse_stem, double_click_count):
1566 (force_auto_save_soon): Define only if SIGDANGER.
1567 (ignore_mouse_drag_p): Now static if
1568 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1569 (print_help): Remove; unused.
1570 (stop_character, last_timer_event): Mark as externally visible.
1571 * keyboard.h (ignore_mouse_drag_p): Declare only if
1572 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1573 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1574 * lisp.h (echoing): Remove decl.
1575 (force_auto_save_soon): Declare only if SIGDANGER.
1576 * xdisp.c (redisplay_window): Simplify code, to make it more
1577 obvious that ignore_mouse_drag_p is not accessed if !defined
1578 USE_GTK && !defined HAVE_NS.
1580 * intervals.c: Make symbols static if they're not exported.
1581 (merge_properties_sticky, merge_interval_right, delete_interval):
1583 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1585 * insdel.c: Make symbols static if they're not exported.
1586 However, leave prepare_to_modify_buffer alone. It's never
1587 called from outside this function, but that appears to be a bug.
1588 (combine_after_change_list, combine_after_change_buffer):
1589 (adjust_after_replace, signal_before_change): Now static.
1590 (adjust_after_replace_noundo): Remove; unused.
1591 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1592 (signal_before_change): Remove decls.
1594 * indent.c (val_compute_motion, val_vmotion): Now static.
1596 * image.c: Make symbols static if they're not exported.
1597 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1599 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1600 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1602 * fringe.c (standard_bitmaps): Now static.
1603 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1605 * frame.c: Make symbols static if they're not exported.
1606 (x_report_frame_params, make_terminal_frame): Now static.
1607 (get_frame_param): Now static, unless HAVE_NS.
1608 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1609 (x_get_resource_string): Remove; not used.
1610 * frame.h (make_terminal_frame, x_report_frame_params):
1611 (x_get_resource_string); Remove decls.
1612 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1613 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1615 * font.c, fontset.c: Make symbols static if they're not exported.
1616 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1617 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1618 * font.c (font_close_object): Now static.
1619 * font.h (font_close_object): Remove.
1620 * fontset.c (FONTSET_OBJLIST): Remove.
1621 (free_realized_fontset) #if-0 the body, which does nothing.
1622 (face_suitable_for_char_p): #if-0, as it's never called.
1623 * fontset.h (face_suitable_for_char_p): Remove decl.
1624 * xfaces.c (face_at_string_position):
1625 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1626 since 0 is always ASCII.
1628 * fns.c (weak_hash_tables): Now static.
1630 * fileio.c: Make symbols static if they're not exported.
1631 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1632 (Vwrite_region_annotation_buffers): Now static.
1634 * eval.c: Make symbols static if they're not exported.
1635 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1636 * lisp.h (backtrace_list): Remove decl.
1638 * emacs.c: Make symbols static if they're not exported.
1639 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1640 (fatal_error_code, fatal_error_signal_hook, standard_args):
1642 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1643 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1644 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1645 * lisp.h (fatal_error_signal_hook): Remove decl.
1646 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1648 * editfns.c: Move a (normally-unused) function to its only use.
1649 * editfns.c, lisp.h (get_operating_system_release): Remove.
1650 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1651 worth the hassle of breaking this out.
1653 * xterm.c: Make symbols static if they're not exported.
1654 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1655 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1656 (x_destroy_window, x_delete_display):
1658 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1659 (x_mouse_leave): Remove; unused.
1660 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1661 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1662 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1664 (x_mouse_leave): Declare only if WINDOWSNT.
1665 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1666 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1669 * ftxfont.c: Make symbols static if they're not exported.
1670 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1672 * font.h (ftxfont_driver): Likewise.
1674 * xfns.c: Make symbols static if they're not exported.
1675 (x_last_font_name, x_display_info_for_name):
1676 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1677 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1678 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1679 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1680 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1681 (last_show_tip_args): Now static.
1682 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1683 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1684 (x_screen_planes): Remove; unused.
1685 * dispextern.h (x_screen_planes): Remove decl.
1687 * dispnew.c: Make symbols static if they're not exported.
1688 * dispextern.h (redraw_garbaged_frames, scrolling):
1689 (increment_row_positions): Remove.
1690 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1691 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1693 (redraw_garbaged_frames): Remove; unused.
1695 * xfaces.c: Make symbols static if they're not exported.
1696 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1698 * xterm.h (defined_color): Remove decls.
1699 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1700 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1701 (menu_face_changed_default, defined_color, free_realized_face):
1702 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1703 (ascii_face_of_lisp_face): Remove; unused.
1705 * xdisp.c: Make symbols static if they're not exported.
1706 * dispextern.h (scratch_glyph_row, window_box_edges):
1707 (glyph_to_pixel_coords, set_cursor_from_row):
1708 (get_next_display_element, set_iterator_to_next):
1709 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1710 (show_mouse_face): Remove decls
1711 * frame.h (message_buf_print): Likewise.
1712 * lisp.h (pop_message, set_message, check_point_in_composition):
1714 * xterm.h (set_vertical_scroll_bar): Likewise.
1715 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1716 (message_buf_print, scratch_glyph_row, displayed_buffer):
1717 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1718 (get_next_display_element, show_mouse_face, window_box_edges):
1719 (frame_to_window_pixel_xy, check_point_in_composition):
1720 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1721 (glyph_to_pixel_coords): Remove; unused.
1723 * dired.c (file_name_completion): Now static.
1725 * dbusbind.c (xd_in_read_queued_messages): Now static.
1727 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1728 * data.c (circular_list_error): Remove.
1730 * commands.h (last_point_position, last_point_position_buffer):
1731 (last_point_position_window): Remove decls.
1732 * keyboard.c: Make these variables static.
1734 * coding.h (coding, code_convert_region, encode_coding_gap):
1736 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1737 (iso_code_class, detect_coding, code_convert_region): Now static.
1738 (encode_coding_gap): Remove; unused.
1740 * chartab.c (chartab_chars, chartab_bits): Now static.
1742 * charset.h (charset_iso_8859_1): Remove decl.
1743 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1746 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1747 * ccl.c (Vccl_program_table): Now static.
1748 (check_ccl_update): Remove; unused.
1750 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1751 * category.h: ... from here.
1752 * category.c (check_category_table, set_category_set): Now static.
1754 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1755 * lisp.h: Remove these decls.
1757 * buffer.c (buffer_count): Remove unused var.
1759 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1760 so that it's not optimized away.
1761 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1762 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1763 exported only to the debugger.
1765 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1766 * atimer.h (run_all_atimers): Remove; not exported.
1768 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1769 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1770 was inaccessible from Lisp.
1771 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1772 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1774 alloc.c: Import and export fewer symbols, and remove unused items.
1775 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1777 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1778 it's not optimized away by whole-program optimization.
1779 (message_enable_multibyte, free_misc): Remove.
1780 (catchlist, handlerlist, mark_backtrace):
1781 Declare only if BYTE_MARK_STACK.
1782 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1783 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1784 (message_enable_multibyte): Remove decl.
1785 (free_misc, interval_free_list, float_block, float_block_index):
1786 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1787 (cons_free_list, last_marked_index):
1789 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1790 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1791 (mark_backtrace): Define only if BYTE_MARK_STACK.
1792 * xdisp.c (message_enable_multibyte): Now static.
1794 Declare Lisp_Object Q* variables to be 'static' if not exported.
1795 This makes it easier for human readers (and static analyzers)
1796 to see whether these variables are used from other modules.
1797 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1798 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1799 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1800 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1801 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1802 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1803 * xmenu.c, xselect.c:
1804 Declare Q* vars static if they are not used in other modules.
1805 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1806 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1807 Remove decls of unexported vars.
1808 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1810 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1812 Make Emacs functions such as Fatom 'static' by default.
1813 This makes it easier for human readers (and static analyzers)
1814 to see whether these functions can be called from other modules.
1815 DEFUN now defines a static function. To make the function external
1816 so that it can be used in other C modules, use the new macro DEFUE.
1817 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1818 (Finit_image_library):
1819 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1820 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1821 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1822 Remove decls, since these functions are now static.
1823 (Funintern, Fget_internal_run_time): New decls, since these functions
1824 were already external.
1826 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1827 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1828 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1829 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1830 * keyboard.c, keymap.c, lread.c:
1831 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1832 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1833 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1834 Mark functions with DEFUE instead of DEFUN,
1835 if they are used in other modules.
1836 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1837 decls for now-static functions.
1838 * buffer.h (Fdelete_overlay): Remove decl.
1839 * callproc.c (Fgetenv_internal): Mark as internal.
1840 * composite.c (Fremove_list_of_text_properties): Remove decl.
1841 (Fcomposition_get_gstring): New forward static decl.
1842 * composite.h (Fcomposite_get_gstring): Remove decl.
1843 * dired.c (Ffile_attributes): New forward static decl.
1844 * doc.c (Fdocumntation_property): New forward static decl.
1845 * eval.c (Ffetch_bytecode): New forward static decl.
1846 (Funintern): Remove extern decl; now in .h file where it belongs.
1847 * fileio.c (Fmake_symbolic_link): New forward static decl.
1848 * image.c (Finit_image_library): New forward static decl.
1849 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1850 * intervals.h (Fprevious_property_change):
1851 (Fremove_list_of_text_properties): Remove decls.
1852 * keyboard.c (Fthis_command_keys): Remove decl.
1853 (Fcommand_execute): New forward static decl.
1854 * keymap.c (Flookup_key): New forward static decl.
1855 (Fcopy_keymap): Now static.
1856 * keymap.h (Flookup_key): Remove decl.
1857 * process.c (Fget_process): New forward static decl.
1858 (Fprocess_datagram_address): Mark as internal.
1859 * syntax.c (Fsyntax_table_p): New forward static decl.
1860 (skip_chars): Remove duplicate decl.
1861 * textprop.c (Fprevious_property_change): New forward static decl.
1862 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1864 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1865 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1867 * editfns.c (Fformat): Remove unreachable code.
1869 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1871 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1874 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1876 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1877 when at ZV. (Bug#8487)
1879 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1881 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1883 * keyboard.c (parse_tool_bar_item): Likewise.
1884 * sound.c (sound_cleanup, alsa_close): Likewise.
1885 * termcap.c (tgetent): Likewise.
1886 * xfns.c (x_default_font_parameter): Likewise.
1887 * xsettings.c (read_and_apply_settings): Likewise.
1889 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1890 (overrun_check_free): Protoize.
1892 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1894 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1895 since callers should never pass a negative size.
1896 Change the signature to match that of plain 'read' and 'write'; see
1897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1898 * lisp.h: Update prototypes of emacs_write and emacs_read.
1900 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1902 * xdisp.c (redisplay_window): Don't try to determine the character
1903 position of the scroll margin if the window start point w->startp
1904 is outside the buffer's accessible region. (Bug#8468)
1906 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1908 Fix write-region and its subroutines for buffers > 2GB.
1909 * fileio.c (a_write, e_write): Modify declaration of arguments and
1910 local variables to support buffers larger than 2GB.
1911 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1913 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1914 argument, local variables, and return value.
1916 * lisp.h: Update prototypes of emacs_write and emacs_read.
1918 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1920 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1922 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1924 Fix more problems found by GCC 4.6.0's static checks.
1926 * xdisp.c (vmessage): Use a better test for character truncation.
1928 * charset.c (load_charset_map): <, not <=, for optimization,
1929 and to avoid potential problems with integer overflow.
1930 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1931 * casetab.c (set_identity, shuffle): Likewise.
1932 * editfns.c (Fformat): Likewise.
1933 * syntax.c (skip_chars): Likewise.
1935 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1936 This also lets GCC 4.6.0 generate slightly better loop code.
1938 * callint.c (Fcall_interactively): <, not <=, for optimization.
1939 (Fcall_interactively): Count the number of arguments produced,
1940 not the number of arguments given. This is simpler and lets GCC
1941 4.6.0 generate slightly better code.
1943 * ftfont.c: Distingish more carefully between FcChar8 and char.
1944 The previous code passed unsigned char * to a functions like
1945 strlen and xstrcasecmp that expect char *, which does not
1946 conform to the C standard.
1947 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1948 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1949 char * when the C standard requires it.
1951 * keyboard.c (read_char): Remove unused var.
1953 * eval.c: Port to Windows vsnprintf (Bug#8435).
1955 (SIZE_MAX): Define if the headers do not.
1956 (verror): Do not give up if vsnprintf returns a negative count.
1957 Instead, grow the buffer. This ports to Windows vsnprintf, which
1958 does not conform to C99. Problem reported by Eli Zaretskii.
1959 Also, simplify the allocation scheme, by avoiding the need for
1960 calling realloc, and removing the ALLOCATED variable.
1962 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1964 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1965 But keep the doprint source code for now, as we might revamp it
1966 and use it again (Bug#8435).
1967 * lisp.h (doprnt): Remove.
1968 * Makefile.in (base_obj): Remove doprnt.o.
1969 * deps.mk (doprnt.o): Remove.
1971 error: Print 32- and 64-bit integers portably (Bug#8435).
1972 Without this change, on typical 64-bit hosts error ("...%d...", N)
1973 was used to print both 32- and 64-bit integers N, which relied on
1975 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1977 * lisp.h (error, verror): Mark as printf-like functions.
1978 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1979 Report overflow in size calculations when allocating printf buffer.
1980 Do not truncate output string at its first null byte.
1981 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1982 Truncate the output at a character boundary, since vsnprintf does not
1984 * charset.c (check_iso_charset_parameter): Convert internal
1985 character to string before calling 'error', since %c now has the
1987 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1988 overflow when computing char to be passed to 'error'. Do not
1989 pass Lisp_Object to 'error'; pass the integer instead.
1990 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1991 formatted with plain %d.
1993 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1995 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1997 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1999 * xterm.c (x_catch_errors): Remove duplicate declaration.
2001 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2003 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2005 2011-04-10 Jim Meyering <meyering@redhat.com>
2007 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2008 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2009 return ssize_t not "int", and use size_t as the buffer length.
2010 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2011 * gnutls.h: Update declarations.
2012 * process.c (read_process_output): Use ssize_t, to match.
2013 (send_process): Likewise.
2015 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2017 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2019 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2021 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2022 Use unsigned char, to match FcChar8 type definition.
2024 * xterm.c (handle_one_xevent):
2025 * xmenu.c (create_and_show_popup_menu):
2026 * xselect.c (x_decline_selection_request)
2027 (x_reply_selection_request): Avoid type-punned deref of X events.
2029 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2031 Fix some uses of `int' instead of EMACS_INT.
2032 * search.c (string_match_1, fast_string_match)
2033 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2034 (scan_buffer, find_next_newline_no_quit)
2035 (find_before_next_newline, search_command, Freplace_match)
2036 (Fmatch_data): Make some `int' variables be EMACS_INT.
2038 * xdisp.c (display_count_lines): 3rd argument and return value now
2039 EMACS_INT. All callers changed.
2040 (pint2hrstr): Last argument is now EMACS_INT.
2042 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2043 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2044 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2045 (decode_coding_utf_16, decode_coding_emacs_mule)
2046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2047 (decode_coding_ccl, decode_coding_charset)
2048 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2049 (decode_coding_iso_2022, decode_coding_emacs_mule)
2050 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2051 <char_offset, last_offset>: Declare EMACS_INT.
2052 (encode_coding_utf_8, encode_coding_utf_16)
2053 (encode_coding_emacs_mule, encode_invocation_designation)
2054 (encode_designation_at_bol, encode_coding_iso_2022)
2055 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2056 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2058 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2059 (encode_invocation_designation): Last argument P_NCHARS is now
2061 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2062 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2064 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2067 * ccl.c (Fccl_execute_on_string): Declare some variables
2070 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2072 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2074 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2076 * process.c (Fformat_network_address): Doc fix.
2078 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2080 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2082 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2084 * keyboard.c (read_char): Call Lisp function help-form-show,
2085 instead of using internal_with_output_to_temp_buffer.
2086 (Qhelp_form_show): New var.
2087 (syms_of_keyboard): Use DEFSYM macro.
2089 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2091 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2093 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2095 * process.c (Flist_processes): Remove to Lisp.
2096 (list_processes_1): Delete.
2098 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2100 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2102 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2104 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2106 Fix more problems found by GCC 4.6.0's static checks.
2108 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2110 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2112 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2114 * xdisp.c (vmessage): Mark as a printf-like function.
2116 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2118 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2120 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2121 printf-like functions.
2122 (tiff_load): Add casts to remove these marks before passing them
2123 to system-supplied API.
2125 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2127 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2128 This avoids several warnings with gcc -Wstrict-overflow.
2129 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2130 directly, rather than having caller test rule sign. This avoids
2131 some unnecessary tests.
2132 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2133 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2134 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2136 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2137 (xfont_open): Avoid unnecessary tests.
2139 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2141 * composite.h, composite.c (composition_gstring_put_cache):
2142 Use EMACS_INT, not int, for length.
2144 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2145 breaking out part of COMPOSITION_DECODE_RULE.
2146 (COMPOSITION_DECODE_RULE): Use it.
2147 * composite.c (get_composition_id): Remove unused local vars,
2148 by using the new macro.
2150 * textprop.c (set_text_properties_1): Change while to do-while,
2151 since the condition is always true at first.
2153 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2154 (interval_deletion_adjustment): Return unsigned value.
2157 * process.c (list_processes_1, create_pty, read_process_output):
2158 (exec_sentinel): Remove vars that were set but not used.
2159 (create_pty): Remove unnecessary "volatile"s.
2160 (Fnetwork_interface_info): Avoid possibility of int overflow.
2161 (read_process_output): Do adaptive read buffering even if carryover.
2162 (read_process_output): Simplify nbytes computation if buffered.
2164 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2166 * syntax.c (scan_words): Remove var that was set but not used.
2167 (update_syntax_table): Use unsigned instead of int.
2169 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2170 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2171 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2173 * print.c (print_error_message): Avoid int overflow.
2175 * font.c (font_list_entities): Redo for clarity,
2176 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2178 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2179 (font_score): Avoid potential overflow in diff calculation.
2181 * fns.c (substring_both): Remove var that is set but not used.
2182 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2184 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2186 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2187 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2188 can always succeed if overflow has undefined behavior.
2190 * search.c (boyer_moore, wordify): Remove vars set but not used.
2191 (wordify): Omit three unnecessary tests.
2193 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2194 All callers changed. This avoids the need for an unused var.
2196 * casefiddle.c (casify_region): Remove var that is set but not used.
2198 * dired.c (file_name_completion): Remove var that is set but not used.
2200 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2202 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2203 (Finsert_file_contents): Remove unnecessary code checking fd.
2205 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2206 Check for integer overflow on size calculations.
2208 * buffer.c (Fprevious_overlay_change): Remove var that is set
2211 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2212 Remove vars that are set but not used.
2213 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2214 (timer_check_2): Mark vars as initialized.
2216 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2218 * image.c (lookup_image): Remove var that is set but not used.
2219 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2221 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2222 that are set but not used.
2224 * xfns.c (make_invisible_cursor): Don't return garbage
2225 if XCreateBitmapFromData fails (Bug#8410).
2227 * xselect.c (x_get_local_selection, x_handle_property_notify):
2228 Remove vars that are set but not used.
2230 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2231 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2233 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2234 Remove var that is set but not used.
2235 (scroll_bar_windows_size): Now size_t, not int.
2236 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2239 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2240 (map_tty_color) [!defined MSDOS]: Likewise.
2242 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2244 * coding.c: Remove vars that are set but not used.
2245 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2246 All callers changed.
2247 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2248 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2249 (decode_coding_charset): Remove vars that are set but not used.
2251 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2252 that is set but not used.
2254 * print.c (print_object): Remove var that is set but not used.
2256 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2257 The gnulib version avoids calling malloc in the usual case,
2258 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2259 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2260 * filelock.c (current_lock_owner): Likewise.
2261 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2262 * sysdep.c: Include allocator.h, careadlinkat.h.
2263 (emacs_no_realloc_allocator): New static constant.
2264 (emacs_readlink): New function.
2265 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2266 ../lib/careadlinkat.h.
2268 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2270 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2271 first non-nil return value).
2273 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2275 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2276 if not defined (Bug#8403).
2278 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2280 * xdisp.c (display_count_lines): Remove parameter `start',
2281 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2282 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2283 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2284 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2285 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2286 and thereabouts. All callers changed.
2287 (get_per_char_metric): Remove parameter `f', unused since
2288 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2290 2011-04-02 Jim Meyering <meyering@redhat.com>
2292 do not dereference NULL upon failed strdup
2293 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2294 (ns_get_family): Likewise.
2296 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2298 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2300 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2302 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2305 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2307 Add lexical binding.
2309 * window.c (Ftemp_output_buffer_show): New fun.
2310 (Fsave_window_excursion):
2311 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2313 * lread.c (lisp_file_lexically_bound_p): New function.
2314 (Fload): Bind Qlexical_binding.
2315 (readevalloop): Remove `evalfun' arg.
2316 Bind Qinternal_interpreter_environment.
2317 (Feval_buffer): Bind Qlexical_binding.
2318 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2320 (syms_of_lread): Declare `lexical-binding'.
2322 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2324 * keyboard.c (eval_dyn): New fun.
2325 (menu_item_eval_property): Use it.
2327 * image.c (parse_image_spec): Use Ffunctionp.
2329 * fns.c (concat, mapcar1): Accept byte-code-functions.
2331 * eval.c (Fsetq): Handle lexical vars.
2332 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2333 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2334 (FletX, Flet): Obey lexical binding.
2335 (Fcommandp): Handle closures.
2336 (Feval): New `lexical' arg.
2337 (eval_sub): New function extracted from Feval. Use it almost
2338 everywhere where Feval was used. Look up vars in lexical env.
2340 (Ffunctionp): Move from subr.el.
2341 (Ffuncall): Handle closures.
2342 (apply_lambda): Remove `eval_flags'.
2343 (funcall_lambda): Handle closures and new byte-code-functions.
2344 (Fspecial_variable_p): New function.
2345 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2346 but without exporting it to Lisp.
2348 * doc.c (Fdocumentation, store_function_docstring):
2349 * data.c (Finteractive_form): Handle closures.
2351 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2354 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2356 (exec_byte_code): New function extracted from Fbyte_code to handle new
2357 calling convention for byte-code-functions. Add new byte-codes.
2359 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2361 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2363 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2365 * xdisp.c (redisplay_internal): Fix prototype.
2367 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2369 * xdisp.c (SCROLL_LIMIT): New macro.
2370 (try_scrolling): Use it when setting scroll_limit.
2371 Limit scrolling to 100 screen lines.
2372 (redisplay_window): Even when falling back on "recentering",
2373 position point in the window according to scroll-conservatively,
2374 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2376 (try_scrolling): When point is above the window, allow searching
2377 as far as scroll_max, or one screenful, to compute vertical
2378 distance from PT to the scroll margin position. This prevents
2379 try_scrolling from unnecessarily failing when
2380 scroll-conservatively is set to a value slightly larger than the
2381 window height. Clean up the case of PT below the margin at bottom
2382 of window: scroll_max can no longer be INT_MAX. When aggressive
2383 scrolling is in use, don't let point enter the opposite scroll
2384 margin as result of the scroll.
2385 (syms_of_xdisp) <scroll-conservatively>: Document the
2386 threshold of 100 lines for never-recentering scrolling.
2388 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2390 * dispextern.h (move_it_by_lines):
2391 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2392 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2393 (message_log_check_duplicate): Remove parameters `prev_bol' and
2394 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2395 (redisplay_internal): Remove parameter `preserve_echo_area',
2396 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2398 * indent.c (Fvertical_motion):
2399 * window.c (window_scroll_pixel_based, Frecenter):
2400 Don't pass `need_y_p' to `move_it_by_lines'.
2402 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2404 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2405 steal a few bits to be more compact.
2406 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2407 Remove unneeded casts.
2409 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2411 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2413 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2414 binding" message (bug#7967).
2416 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2418 Fix more problems found by GCC 4.6.0's static checks.
2420 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2421 Remove unused local var.
2423 * editfns.c (Fmessage_box): Remove unused local var.
2425 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2426 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2427 Omit unused local vars.
2428 * window.c (shrink_windows): Omit unused local var.
2429 * menu.c (digest_single_submenu): Omit unused local var.
2430 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2431 Omit unused local var.
2433 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2434 Don't assume string length fits in int.
2435 (keyremap_step, read_key_sequence): Use size_t for sizes.
2436 (read_key_sequence): Don't check last_real_key_start redundantly.
2438 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2439 instead of alloca (Bug#8344).
2441 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2442 (Fbacktrace_frame): Don't assume nframes fits in int.
2444 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2446 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2449 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2451 * cm.c (calccost): Turn while-do into do-while, for clarity.
2453 * keyboard.c (syms_of_keyboard): Use the same style as later
2454 in this function when indexing through an array. This also
2455 works around GCC bug 48267.
2457 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2459 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2461 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2462 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2464 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2465 This avoids undefined behavior on integer overflow, and is a bit
2466 more convenient anyway since it is compared to a size_t variable.
2468 Variadic C functions now count arguments with size_t, not int.
2469 This avoids an unnecessary limitation on 64-bit machines, which
2470 caused (substring ...) to crash on large vectors (Bug#8344).
2471 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2472 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2473 All variadic functions and their callers changed accordingly.
2474 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2475 * data.c (arith_driver, float_arith_driver): Likewise.
2476 * editfns.c (general_insert_function): Likewise.
2477 * eval.c (struct backtrace.nargs, interactive_p)
2478 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2479 (funcall_lambda, mark_backtrace): Likewise.
2480 * fns.c (concat): Likewise.
2481 * frame.c (x_set_frame_parameters): Likewise.
2482 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2483 0 if not found, not -1. All callers changed.
2485 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2486 (stack_copy_size): Now size_t, not int.
2487 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2489 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2491 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2492 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2493 All callers changed.
2495 * lisp.h (multibyte_char_to_unibyte):
2496 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2497 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2498 * character.h (CHAR_TO_BYTE8):
2499 * cmds.c (internal_self_insert):
2500 * editfns.c (general_insert_function):
2501 * keymap.c (push_key_description):
2502 * search.c (Freplace_match):
2503 * xdisp.c (message_dolog, set_message_1): All callers changed.
2505 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2507 * keyboard.c (safe_run_hook_funcall): New function.
2508 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2509 don't set the hook to nil, but remove the offending function instead.
2510 (Qcommand_hook_internal): Remove, unused.
2511 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2512 Vcommand_hook_internal.
2514 * eval.c (enum run_hooks_condition): Remove.
2515 (funcall_nil, funcall_not): New functions.
2516 (run_hook_with_args): Call each function through a `funcall' argument.
2517 Remove `cond' argument, now redundant.
2518 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2519 (Frun_hook_with_args_until_failure): Adjust accordingly.
2520 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2522 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2524 * dispextern.h (string_buffer_position): Remove declaration.
2526 * print.c (strout): Remove parameter `multibyte', unused since
2527 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2529 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2530 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2531 All callers changed.
2533 * w32.c (_wsa_errlist): Use braces for struct initializers.
2535 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2536 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2537 All callers changed.
2538 (string_buffer_position): Likewise. Also, make static (it's never
2539 used outside xdisp.c).
2540 (cursor_row_p): Remove parameter `w', unused since
2541 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2542 (decode_mode_spec): Remove parameter `precision', introduced during
2543 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2544 All callers changed.
2546 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2548 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2550 2011-03-27 Anders Lindgren <andlind@gmail.com>
2552 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2553 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2554 (ns_update_auto_hide_menu_bar): New functions.
2555 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2556 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2557 ns_constrain_all_frames.
2558 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2559 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2561 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2563 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2565 2011-03-27 Glenn Morris <rgm@gnu.org>
2567 * syssignal.h: Replace RETSIGTYPE with void.
2568 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2569 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2570 Replace SIGTYPE with void everywhere.
2571 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2572 * s/template.h (SIGTYPE): Remove commented out definition.
2574 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2576 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2577 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2579 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2581 * w32.c (read_unc_volume): Use parameter `henum', instead of
2582 global variable `wget_enum_handle'.
2584 * keymap.c (describe_vector): Remove parameters `indices' and
2585 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2586 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2588 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2590 * keyboard.c (timer_check): Remove parameter `do_it_now',
2591 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2592 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2593 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2595 * keyboard.c (read_char):
2596 * w32menu.c (w32_menu_display_help):
2597 * xmenu.c (show_help_event, menu_help_callback):
2598 Adjust calls to `show_help_echo'.
2600 * gtkutil.c (xg_maybe_add_timer):
2601 * keyboard.c (readable_events):
2602 * process.c (wait_reading_process_output):
2603 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2605 * insdel.c (adjust_markers_gap_motion):
2606 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2607 (gap_left, gap_right): Don't call it.
2609 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2611 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2612 incurred during fontification.
2614 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2616 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2617 (DEFVAR_PER_BUFFER): Don't pass it.
2619 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2620 (scrolling_window): Don't pass it.
2622 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2624 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2626 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2628 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2629 of variables specific to SELinux and computation of `encoded_absname'.
2631 * image.c (XPutPixel): Remove unused variable `height'.
2633 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2635 * unexw32.c (get_section_info): Remove unused variable `section'.
2637 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2638 (system_process_attributes): Remove unused variable `sess'.
2639 (sys_read): Remove unused variable `err'.
2641 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2642 (w32_wnd_proc): Remove unused variable `isdead'.
2643 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2644 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2645 (x_create_tip_frame): Remove unused variable `tem'.
2647 * w32inevt.c (w32_console_read_socket):
2648 Remove unused variable `no_events'.
2650 * w32term.c (x_draw_composite_glyph_string_foreground):
2651 Remove unused variable `width'.
2653 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2655 * w32term.c (x_set_glyph_string_clipping):
2656 Don't pass uninitialized region to CombineRgn.
2658 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2660 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2661 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2662 (Fx_close_connection): Remove unused variable `i'.
2664 * w32font.c (w32font_draw): Return number of glyphs.
2665 (w32font_open_internal): Remove unused variable `i'.
2666 (w32font_driver): Add missing initializer.
2668 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2669 (fill_in_menu): Remove unused variable `items_added'.
2671 * w32term.c (last_mouse_press_frame): Remove static global variable.
2672 (w32_clip_to_row): Remove unused variable `f'.
2673 (x_delete_terminal): Remove unused variable `i'.
2675 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2676 (NOTHING): Remove unused static global variable.
2677 (uniscribe_check_otf): Remove unused variable `table'.
2678 (uniscribe_font_driver): Add missing initializers.
2680 2011-03-23 Julien Danjou <julien@danjou.info>
2682 * term.c (Fsuspend_tty, Fresume_tty):
2683 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2684 * window.c (temp_output_buffer_show):
2685 * insdel.c (signal_before_change):
2686 * frame.c (Fhandle_switch_frame):
2687 * fileio.c (Fdo_auto_save):
2688 * emacs.c (Fkill_emacs):
2689 * editfns.c (save_excursion_restore):
2690 * cmds.c (internal_self_insert):
2691 * callint.c (Fcall_interactively):
2692 * buffer.c (Fkill_all_local_variables):
2693 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2695 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2696 unconditionnaly since it does the check itself.
2698 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2700 Fix more problems found by GCC 4.5.2's static checks.
2702 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2703 the first time through the loop, since we know p0 < p1 then.
2704 This also avoids a gcc -Wstrict-overflow warning.
2706 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2707 leading to a memory leak, possible in functions like
2708 load_charset_map_from_file that can allocate an unbounded number
2709 of objects (Bug#8318).
2711 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2712 that could (at least in theory) be that large.
2714 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2715 This is less likely to overflow, and avoids undefined behavior if
2716 overflow does occur. All callers changed. Use strtoul to scan
2717 for the unsigned long integer.
2718 (pint2hrstr): Simplify and tune code slightly.
2719 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2721 * scroll.c (do_scrolling): Work around GCC bug 48228.
2722 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2724 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2725 This also avoids a warning with gcc -Wstrict-overflow.
2726 (validate_x_resource_name): Simplify count usage.
2727 This also avoids a warning with gcc -Wstrict-overflow.
2729 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2732 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2734 * process.c (Fmake_network_process): Use socklen_t, not int,
2735 where POSIX says socklen_t is required in portable programs.
2736 This fixes a porting bug on hosts like 64-bit HP-UX, where
2737 socklen_t is wider than int (Bug#8277).
2738 (Fmake_network_process, server_accept_connection):
2739 (wait_reading_process_output, read_process_output):
2742 * process.c: Rename or move locals to avoid shadowing.
2743 (list_processes_1, Fmake_network_process):
2744 (read_process_output_error_handler, exec_sentinel_error_handler):
2745 Rename or move locals.
2746 (Fmake_network_process): Define label "retry_connect" only if needed.
2747 (Fnetwork_interface_info): Fix pointer signedness.
2748 (process_send_signal): Add cast to avoid pointer signedness problem.
2749 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2750 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2752 Make tparam.h and terminfo.c consistent.
2753 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2754 Include tparam.h instead, since it declares them.
2755 * cm.h (PC): Remove extern decl; tparam.h now does this.
2756 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2757 * terminfo.c: Include tparam.h, to check interfaces.
2758 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2759 (tparam): Adjust signature to match interface in tparam.h;
2760 this removes some undefined behavior. Check that outstring and len
2761 are zero, which they always are with Emacs.
2762 * tparam.h (PC, BC, UP): New extern decls.
2764 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2765 (xftfont_open): Rename locals to avoid shadowing.
2767 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2768 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2769 (OTF_TAG_SYM): Omit macro if not needed.
2770 (ftfont_list): Remove unused local.
2771 (get_adstyle_property, ftfont_pattern_entity):
2772 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2773 Rename locals to avoid shadowing.
2775 * xfont.c (xfont_list_family): Mark var as initialized.
2777 * xml.c (make_dom): Now static.
2779 * composite.c (composition_compute_stop_pos): Rename local to
2781 (composition_reseat_it): Remove unused locals.
2782 (find_automatic_composition, composition_adjust_point): Likewise.
2783 (composition_update_it): Mark var as initialized.
2784 (find_automatic_composition): Mark vars as initialized,
2785 with a FIXME (Bug#8290).
2787 character.h: Rename locals to avoid shadowing.
2788 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2789 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2790 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2791 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2794 * textprop.c (property_change_between_p): Remove; unused.
2796 * intervals.c (interval_start_pos): Now static.
2798 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2800 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2801 Rename locals to avoid shadowing.
2803 * sound.c (wav_play, au_play, Fplay_sound_internal):
2804 Fix pointer signedness.
2805 (alsa_choose_format): Remove unused local var.
2806 (wav_play): Initialize a variable to 0, to prevent undefined
2807 behavior (Bug#8278).
2809 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2811 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2814 clobbering (Bug#8298).
2815 * sysdep.c (sys_subshell): Likewise.
2816 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2818 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2819 This should get cleaned up, so that child_setup has the
2820 same signature on all platforms.
2822 * callproc.c (call_process_cleanup): Now static.
2823 (relocate_fd): Rename locals to avoid shadowing.
2825 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2827 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2828 not to be necessary, and produces flickering.
2830 2011-03-20 Glenn Morris <rgm@gnu.org>
2832 * config.in: Remove file.
2834 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2836 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2837 are now in src/globals.h.
2838 (syms_of_minibuf): Remove spurious & from previous change.
2840 2011-03-20 Leo <sdl.web@gmail.com>
2842 * minibuf.c (completing-read-function): New variable.
2843 (completing-read-default): Rename from completing-read.
2844 (completing-read): Call completing-read-function.
2846 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2848 * xfaces.c (Fx_load_color_file):
2849 Read color file from absolute filename (bug#8250).
2851 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2853 * makefile.w32-in: Update dependencies.
2855 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2857 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2859 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2861 Fix more problems found by GCC 4.5.2's static checks.
2863 * process.c (make_serial_process_unwind, send_process_trap):
2864 (sigchld_handler): Now static.
2866 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2867 That way, the code declares only the vars that it needs.
2868 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2869 * s/cygwin.h (PTY_ITERATION): Likewise.
2870 * s/darwin.h (PTY_ITERATION): Likewise.
2871 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2873 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2874 * process.c (allocate_pty): Don't declare stb unless it's needed.
2876 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2877 (CONSTANTLIM): Remove; unused.
2878 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2879 Define only if needed.
2881 * unexelf.c (unexec): Name an expression,
2882 to avoid gcc -Wbad-function-cast warning.
2883 Use a different way to cause a compilation error if anyone uses
2884 n rather than nn, a way that does not involve shadowing.
2885 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2887 * deps.mk (unexalpha.o): Remove; unused.
2889 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2890 * unexec.h: New file.
2891 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2892 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2894 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2895 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2896 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2897 Change as necessary to match prototype in unexec.h.
2899 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2901 (back_comment, skip_chars): Mark vars as initialized.
2903 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2904 Rename locals to avoid shadowing.
2906 * lread.c (read1): Rewrite so as not to use empty "else".
2907 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2909 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2911 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2912 warning when compiling print.c.
2914 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2915 instead of using an uninitialized var.
2916 (font_sort_entities): Mark var as initialized.
2918 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2920 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2921 pointers to constants.
2922 (font_parse_fcname): Remove unused vars.
2923 (font_delete_unmatched): Now static.
2924 (font_get_spec): Remove; unused.
2925 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2926 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2927 Rename or move locals to avoid shadowing.
2929 * fns.c (require_nesting_list, require_unwind): Now static.
2930 (Ffillarray): Rename locals to avoid shadowing.
2932 * floatfns.c (domain_error2): Define only if needed.
2933 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2935 * alloc.c (mark_backtrace): Move decl from here ...
2936 * lisp.h: ... to here, so that it can be checked.
2938 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2939 (Fdefvar): Rewrite so as not to use empty "else".
2940 (lisp_indirect_variable): Name an expression,
2941 to avoid gcc -Wbad-function-cast warning.
2942 (Fdefvar): Rename locals to avoid shadowing.
2944 * callint.c (quotify_arg, quotify_args): Now static.
2945 (Fcall_interactively): Rename locals to avoid shadowing.
2946 Use const pointer when appropriate.
2948 * lisp.h (get_system_name, get_operating_system_release):
2949 Move decls here, to check interfaces.
2950 * process.c (get_operating_system_release): Move decl to lisp.h.
2951 * xrdb.c (get_system_name): Likewise.
2952 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2953 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2954 some of which prompt warnings from gcc -Wbad-function-cast.
2955 (Fformat_time_string, Fencode_time, Finsert_char):
2956 (Ftranslate_region_internal, Fformat):
2957 Rename or remove local vars to avoid shadowing.
2958 (Ftranslate_region_internal): Mark var as initialized.
2960 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2963 * lisp.h (eassert): Check that the argument compiles, even if
2964 ENABLE_CHECKING is not defined.
2966 * data.c (Findirect_variable): Name an expression, to avoid
2967 gcc -Wbad-function-cast warning.
2968 (default_value, arithcompare, arith_driver, arith_error): Now static.
2969 (store_symval_forwarding): Rename local to avoid shadowing.
2970 (Fmake_variable_buffer_local, Fmake_local_variable):
2971 Mark variables as initialized.
2972 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2974 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2975 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2976 Rename locals to avoid shadowing.
2977 (mark_stack): Move local variables into the #ifdef region where
2979 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2980 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2982 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2983 (GC_STRING_CHARS): Remove; not used.
2984 (Fmemory_limit): Cast sbrk's returned value to char *.
2986 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2987 avoids undefined behavior in theory.
2989 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2991 Use functions, not macros, for up- and down-casing (Bug#8254).
2992 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2994 to use the following functions instead of these macros.
2995 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2996 EMACS_INT, since callers assume the returned value fits in int.
2997 (upcase1): Likewise, for UPCASE_TABLE.
2998 (uppercasep, lowercasep, upcase): New static inline functions.
2999 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3000 the race-condition problem in the old DOWNCASE.
3002 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3003 Rename locals to avoid shadowing.
3004 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3005 (regex_compile, re_search_2, re_match_2_internal):
3006 Remove unused local vars.
3007 (FREE_VAR): Rewrite so as not to use empty "else",
3008 which gcc can warn about.
3009 (regex_compile, re_match_2_internal): Mark locals as initialized.
3010 (RETALLOC_IF): Define only if needed.
3011 (WORDCHAR_P): Likewise. This one is never needed, but is used
3012 only in a comment talking about a compiler bug, so put inside
3013 the #if 0 of that comment.
3014 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3015 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3018 * search.c (boyer_moore): Rename locals to avoid shadowing.
3019 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3020 (PREV_CHAR_BOUNDARY): Likewise.
3022 * search.c (simple_search): Remove unused var.
3024 * dired.c (compile_pattern): Move decl from here ...
3025 * lisp.h: ... to here, so that it can be checked.
3026 (struct re_registers): New forward decl.
3028 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3030 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3032 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3033 Rename locals to avoid shadowing.
3034 (Fvertical_motion): Mark locals as initialized.
3036 * casefiddle.c (casify_object, casify_region): Now static.
3037 (casify_region): Mark local as initialized.
3039 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3041 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3042 New macros, so that the caller can use some names other than
3043 gcpro1, gcpro2, etc.
3044 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3046 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3047 argument, for consistency with GCPRO2_VAR, etc: it is now the
3048 prefix of the variable, not the variable itself. All uses
3050 * dired.c (directory_files_internal, file_name_completion):
3051 Rename locals to avoid shadowing.
3053 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3054 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3055 dired.c's scmp function, had undefined behavior.
3056 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3057 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3058 * buffer.h: ... to here, because these macros use current_buffer,
3059 and the new implementation with inline functions needs to have
3060 current_buffer in scope now, rather than later when the macros
3062 (downcase, upcase1): New static inline functions.
3063 (DOWNCASE, UPCASE1): Reimplement using these functions.
3064 This avoids undefined behavior in expressions like
3065 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3066 from race conditions in accessing the global variables
3067 case_temp1 and case_temp2.
3068 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3069 * lisp.h (case_temp1, case_temp2): Remove their decls.
3070 * character.h (ASCII_CHAR_P): Move from here ...
3071 * lisp.h: ... to here, so that the inline functions mentioned
3074 * dired.c (directory_files_internal_unwind): Now static.
3076 * fileio.c (file_name_as_directory, directory_file_name):
3077 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3079 (file_name_as_directory): Use const pointers when appropriate.
3080 (Fexpand_file_name): Likewise. In particular, newdir might
3081 point at constant storage, so make it a const pointer.
3082 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3083 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3085 (Fset_file_times, Finsert_file_contents, auto_save_error):
3086 Rename locals to avoid shadowing.
3088 * minibuf.c (choose_minibuf_frame_1): Now static.
3089 (Ftry_completion, Fall_completions): Rename or remove locals
3092 * marker.c (bytepos_to_charpos): Remove; unused.
3094 * lisp.h (verify_bytepos, count_markers): New decls,
3095 so that gcc does not warn that these functions aren't declared.
3097 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3098 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3099 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3100 (copy_text): Remove unused local var.
3102 * filelock.c (within_one_second): Now static.
3103 (lock_file_1): Rename local to avoid shadowing.
3105 * buffer.c (fix_overlays_before): Mark locals as initialized.
3106 (fix_start_end_in_overlays): Likewise. This function should be
3107 simplified by using pointers-to-pointers, but that's a different
3109 (switch_to_buffer_1): Now static.
3110 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3111 (report_overlay_modification): Rename locals to avoid shadowing.
3113 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3114 Fix pointer signedness issue.
3115 (sys_subshell): Mark local as volatile if checking for lint,
3116 to suppress a gcc -Wclobbered warning that does not seem to be right.
3117 (MAXPATHLEN): Define only if needed.
3119 * process.c (serial_open, serial_configure): Move decls from here ...
3120 * systty.h: ... to here, so that they can be checked.
3122 * fns.c (get_random, seed_random): Move extern decls from here ...
3123 * lisp.h: ... to here, so that they can be checked.
3125 * sysdep.c (reset_io): Now static.
3126 (wait_for_termination_signal): Remove; unused.
3128 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3129 (copy_keymap_item, append_key, push_text_char_description):
3131 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3132 (DENSE_TABLE_SIZE): Remove; unused.
3133 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3134 (describe_map_tree):
3135 Rename locals to avoid shadowing.
3137 * keyboard.c: Declare functions static if they are not used elsewhere.
3138 (echo_char, echo_dash, cmd_error, top_level_2):
3139 (poll_for_input, handle_async_input): Now static.
3140 (read_char, kbd_buffer_get_event, make_lispy_position):
3141 (make_lispy_event, make_lispy_movement, apply_modifiers):
3142 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3143 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3144 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3145 (read_key_sequence, read_char): Mark locals as initialized.
3146 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3148 * keyboard.h (make_ctrl_char): New decl.
3149 (mark_kboards): Move decl here ...
3150 * alloc.c (mark_kboards): ... from here.
3152 * lisp.h (force_auto_save_soon): New decl.
3154 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3155 (DEFINE_DUMMY_FUNCTION): New macro.
3156 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3158 (main): Add casts to avoid warnings
3159 if GCC considers string literals to be constants.
3161 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3163 * dbusbind.c: Pointer signedness fixes.
3164 (xd_signature, xd_append_arg, xd_initialize):
3165 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3166 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3167 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3168 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3170 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3171 if GCC considers string literals to be constants.
3172 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3174 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3177 (print_preprocess, print_object): New macro to fix last change.
3179 * print.c (print_preprocess): Don't forget font objects.
3181 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3183 * emacs.c (USAGE3): Doc fixes.
3185 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3187 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3190 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3192 * lisp.h (VWindow_system, Qfile_name_history):
3193 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3194 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3195 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3197 * w32select.c: Don't #include "keyboard.h".
3198 (run_protected): Add extern declaration for waiting_for_input.
3200 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3201 * w32console.c (detect_input_pending, read_input_pending)
3202 (encode_terminal_code):
3203 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3204 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3205 (w32_system_caret_y, Qfile_name_history):
3206 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3207 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3208 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3209 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3210 * w32proc.c (Qlocal, report_file_error):
3211 * w32term.c (Vwindow_system, updating_frame):
3212 * w32uniscribe.c (initialized, uniscribe_font_driver):
3213 Remove unneeded extern declarations.
3215 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3217 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3219 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3221 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3222 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3223 These macros can no longer be used for assignment.
3225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3226 Assign struct members directly, instead of using BUF_BEGV etc.
3227 (record_buffer_markers, fetch_buffer_markers): New functions for
3228 recording and fetching special buffer markers.
3229 (set_buffer_internal_1, set_buffer_temp): Use them.
3231 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3233 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3235 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3236 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3238 * xdisp.c (hscroll_window_tree):
3239 (reconsider_clip_changes): Use PT instead of BUF_PT.
3241 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3243 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3244 $(EMACS_ROOT)/lib/intprops.h.
3246 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3248 Fix more problems found by GCC 4.5.2's static checks.
3250 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3251 to unsigned char * to avoid compiler diagnostic.
3252 (xg_free_frame_widgets): Make it clear that a local variable is
3253 needed only if USE_GTK_TOOLTIP.
3254 (gdk_window_get_screen): Make it clear that this macro is needed
3255 only if USE_GTK_TOOLTIP.
3256 (int_gtk_range_get_value): New function, which avoids a diagnostic
3257 from gcc -Wbad-function-cast.
3258 (xg_set_toolkit_scroll_bar_thumb): Use it.
3259 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3260 diagnostic from gcc -Wbad-function-cast.
3261 (get_utf8_string, xg_get_file_with_chooser):
3262 Rename locals to avoid shadowing.
3263 (create_dialog): Move locals to avoid shadowing.
3265 * xgselect.c (xg_select): Remove unused var.
3267 * image.c (four_corners_best): Mark locals as initialized.
3268 (gif_load): Initialize transparent_p to zero (Bug#8238).
3269 Mark another local as initialized.
3270 (my_png_error, my_error_exit): Mark with NO_RETURN.
3272 * image.c (clear_image_cache): Now static.
3273 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3274 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3275 (x_edge_detection): Remove unnecessary cast that
3276 gcc -Wbad-function-cast diagnoses.
3277 (gif_load): Fix pointer signedness.
3278 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3279 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3281 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3283 Improve quality of tests for time stamp overflow.
3284 For example, without this patch (encode-time 0 0 0 1 1
3285 1152921504606846976) returns the obviously-bogus value (-948597
3286 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3287 reports time overflow. See
3288 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3289 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3290 * editfns.c: Include limits.h and intprops.h.
3291 (TIME_T_MIN, TIME_T_MAX): New macros.
3292 (time_overflow): Move earlier, to before first use.
3293 (hi_time, lo_time): New functions, for an accurate test for
3295 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3296 (Fget_internal_run_time): Don't assume time_t fits in int.
3297 (make_time): Use list2 instead of Fcons twice.
3298 (Fdecode_time): More accurate test for out-of-range times.
3299 (check_tm_member): New function.
3300 (Fencode_time): Use it, to test for out-of-range times.
3301 (lisp_time_argument): Don't rely on undefined left-shift and
3302 right-shift behavior when checking for time stamp overflow.
3304 * editfns.c (time_overflow): New function, refactoring common code.
3305 (Fformat_time_string, Fdecode_time, Fencode_time):
3306 (Fcurrent_time_string): Use it.
3308 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3309 * dired.c (make_time): Move to ...
3310 * editfns.c (make_time): ... here.
3311 * systime.h: Note the move.
3313 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3315 * fringe.c (update_window_fringes): Remove unused variables.
3317 * unexmacosx.c (copy_data_segment): Also copy __got section.
3320 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3322 * termcap.c [MSDOS]: Include "msdos.h".
3323 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3324 Constify `char *' arguments and their references according to
3325 prototypes in tparam.h.
3327 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3329 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3330 Adapt all references accordingly.
3332 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3334 2011-03-11 Tom Tromey <tromey@redhat.com>
3336 * buffer.c (syms_of_buffer): Remove obsolete comment.
3338 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3340 * termhooks.h (encode_terminal_code): Declare prototype.
3342 * msdos.c (encode_terminal_code): Don't declare prototype.
3344 * term.c (encode_terminal_code): Now external again, used by
3345 w32console.c and msdos.c.
3347 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3348 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3350 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3352 Fix some minor problems found by GCC 4.5.2's static checks.
3354 * fringe.c (update_window_fringes): Mark locals as initialized
3356 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3358 * alloc.c (mark_fringe_data): Move decl from here ...
3359 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3360 to check its interface.
3361 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3363 * fontset.c (free_realized_fontset): Now static.
3364 (Fset_fontset_font): Rename local to avoid shadowing.
3365 (fontset_font): Mark local as initialized.
3366 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3368 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3370 * xselect.c (x_disown_buffer_selections): Remove; not used.
3371 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3372 (x_own_selection, Fx_disown_selection_internal): Rename locals
3374 (x_handle_dnd_message): Remove local to avoid shadowing.
3376 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3377 so that the caller can use some name other than gcpro1.
3378 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3379 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3380 (Fx_backspace_delete_keys_p):
3381 Use them to avoid shadowing, and rename vars to avoid shadowing.
3382 (x_decode_color, x_set_name, x_window): Now static.
3383 (Fx_create_frame): Add braces to silence GCC warning.
3384 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3385 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3386 Remove unused locals.
3387 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3388 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3389 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3392 * xterm.h (x_mouse_leave): New decl.
3394 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3395 Remove unused functions.
3396 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3397 (x_calc_absolute_position): Now static.
3398 (XTread_socket): Don't define label "out" unless it's used.
3399 Don't declare local "event" unless it's used.
3400 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3401 unless they are used.
3402 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3403 (x_fatal_error_signal): Remove; not used.
3404 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3405 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3406 (x_error_catcher, x_connection_closed, x_error_handler):
3407 (x_error_quitter, xembed_send_message, x_iconify_frame):
3408 (my_log_handler): Rename locals to avoid shadowing.
3409 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3410 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3412 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3413 Rename or move locals to avoid shadowing.
3414 (tty_defined_color, merge_face_heights): Now static.
3415 (free_realized_faces_for_fontset): Remove; not used.
3416 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3417 does not deduce is never used uninitialized.
3418 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3419 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3421 * terminal.c (store_terminal_param): Now static.
3423 * xmenu.c (menu_highlight_callback): Now static.
3424 (set_frame_menubar): Remove unused local.
3425 (xmenu_show): Rename parameter to avoid shadowing.
3426 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3427 since they might point to immutable storage.
3428 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3429 since it's unused otherwise.
3431 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3432 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3433 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3434 avoids a gcc -Wuninitialized diagnostic.
3435 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3436 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3437 does not deduce are never used uninitialized.
3439 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3441 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3442 * window.c (window_loop, size_window):
3443 (run_window_configuration_change_hook, enlarge_window): Likewise.
3445 * window.c (display_buffer): Now static.
3446 (size_window): Mark variables that gcc -Wuninitialized
3447 does not deduce are never used uninitialized.
3448 * window.h (check_all_windows): New decl, to forestall
3449 gcc -Wmissing-prototypes diagnostic.
3450 * dispextern.h (bidi_dump_cached_states): Likewise.
3452 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3454 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3456 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3457 and to avoid gcc -Wuninitialized warning.
3458 (load_charset_map): Mark variables that gcc -Wuninitialized
3459 does not deduce are never used uninitialized.
3460 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3462 * coding.c (coding_set_source, coding_set_destination):
3463 Use "else { /* comment */ }" rather than "else /* comment */;"
3464 for clarity, and to avoid gcc -Wempty-body warning.
3465 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3466 a block, when the outer 'i' will do.
3467 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3468 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3469 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3470 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3471 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3472 Rename locals to avoid shadowing.
3473 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3474 * coding.c (emacs_mule_char, encode_invocation_designation):
3475 Now static, since they're not used elsewhere.
3476 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3477 (decode_coding_object, encode_coding_object, detect_coding_system):
3478 (decode_coding_emacs_mule): Mark variables that gcc
3479 -Wuninitialized does not deduce are never used uninitialized.
3480 (detect_coding_iso_2022): Initialize a local variable that might
3481 be used uninitialized. Leave a FIXME because it's not clear that
3482 this initialization is needed. (Bug#8211)
3483 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3484 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3485 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3486 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3487 Remove unused macros.
3489 * category.c (hash_get_category_set): Remove unused local var.
3490 (copy_category_table): Now static, since it's not used elsewhere.
3491 * character.c (string_count_byte8): Likewise.
3493 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3494 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3496 * chartab.c (copy_sub_char_table): Now static, since it's not used
3498 (sub_char_table_ref_and_range, char_table_ref_and_range):
3499 Rename locals to avoid shadowing.
3500 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3502 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3503 (BIDI_BOB): Remove unused macro.
3505 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3506 deduce are never used uninitialized.
3507 * term.c (encode_terminal_code): Likewise.
3509 * term.c (encode_terminal_code): Now static. Remove unused local.
3511 * tparam.h: New file.
3512 * term.c, tparam.h: Include it.
3513 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3514 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3515 Move these decls to tparam.h, and make them agree with what
3516 is actually in tparam.c. The previous trick of using incompatible
3517 decls in different modules does not conform to the C standard.
3518 All callers of tparam changed to use tparam's actual API.
3519 * tparam.c (tparam1, tparam, tgoto):
3520 Use const pointers where appropriate.
3522 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3523 * cm.h (struct cm): Likewise.
3524 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3525 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3526 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3527 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3528 (turn_on_face, init_tty): Likewise.
3529 * termchar.h (struct tty_display_info): Likewise.
3531 * term.c (term_mouse_position): Rename local to avoid shadowing.
3533 * alloc.c (mark_ttys): Move decl from here ...
3534 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3536 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3538 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3540 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3542 * search.c (compile_pattern_1): Remove argument regp, unused since
3543 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3544 (compile_pattern): Don't pass it.
3546 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3548 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3549 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3551 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3553 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3555 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3556 gdk_window_get_screen, gdk_window_get_geometry,
3557 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3558 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3559 (xg_get_pixbuf_from_pixmap): New function.
3560 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3561 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3562 Call xg_get_pixbuf_from_pixmap instead of
3563 gdk_pixbuf_get_from_drawable.
3564 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3565 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3566 (xg_check_special_colors): Use GtkStyleContext and its functions
3568 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3569 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3570 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3571 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3572 Call gtk_widget_get_preferred_size.
3573 (xg_frame_resized): gdk_window_get_geometry only takes 5
3575 (xg_win_to_widget, xg_event_is_for_menubar):
3576 Call gdk_x11_window_lookup_for_display.
3577 (xg_set_widget_bg): New function.
3578 (delete_cb): New function.
3579 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3580 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3581 (xg_set_background_color): Call xg_set_widget_bg.
3582 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3583 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3584 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3585 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3587 (update_frame_tool_bar): Call gtk_widget_hide.
3588 (xg_initialize): Use GDK_KEY_g.
3590 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3592 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3594 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3595 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3596 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3598 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3600 * w32xfns.c (select_palette): Check success of RealizePalette against
3601 GDI_ERROR, not zero.
3603 See ChangeLog.11 for earlier changes.
3609 Copyright (C) 2011 Free Software Foundation, Inc.
3611 This file is part of GNU Emacs.
3613 GNU Emacs is free software: you can redistribute it and/or modify
3614 it under the terms of the GNU General Public License as published by
3615 the Free Software Foundation, either version 3 of the License, or
3616 (at your option) any later version.
3618 GNU Emacs is distributed in the hope that it will be useful,
3619 but WITHOUT ANY WARRANTY; without even the implied warranty of
3620 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3621 GNU General Public License for more details.
3623 You should have received a copy of the GNU General Public License
3624 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.