1 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4 referenced (Bug#11583).
6 2012-06-01 Chong Yidong <cyd@gnu.org>
8 * Version 24.1 released.
10 2012-05-30 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (handle_stop): Detect whether we have overlay strings
13 loaded by testing it->current.overlay_string_index to be
14 non-negative, instead of checking whether n_overlay_strings is
17 2012-05-30 Chong Yidong <cyd@gnu.org>
19 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
21 * doc.c (Fsubstitute_command_keys): Doc fix.
23 2012-05-29 Eli Zaretskii <eliz@gnu.org>
25 * search.c (search_buffer): Remove calls to
26 r_alloc_inhibit_buffer_relocation, as it is now called by
27 maybe_unify_char, which was the cause of relocation of buffer text
30 2012-05-23 Eli Zaretskii <eliz@gnu.org>
32 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
33 for the duration of call to load_charset, to avoid problems with
34 callers of maybe_unify_char that access buffer text through C
37 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
38 decrement the inhibition flag, instead of just setting or
41 2012-05-24 Ken Brown <kbrown@cornell.edu>
43 * callproc.c (Fcall_process): Restore a line that was accidentally
44 commented out in the 2011-02-13 change (bug#11547).
46 2012-05-23 Eli Zaretskii <eliz@gnu.org>
48 * lisp.h [REL_ALLOC]: Add prototypes for external functions
51 * buffer.c [REL_ALLOC]: Remove prototypes of
52 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
53 they are now on lisp.h.
55 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
57 * search.c (search_buffer): Use it to inhibit relocation of buffer
58 text while re_search_2 is doing its job, because re_search_2 is
59 passed C pointers to buffer text. (Bug#11519)
61 2012-05-21 Eli Zaretskii <eliz@gnu.org>
63 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
66 2012-05-19 Eli Zaretskii <eliz@gnu.org>
68 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
69 state after an additional call to move_it_in_display_line_to, keep
70 the values of it->max_ascent and it->max_descent found for the
72 (pos_visible_p): Revert the comparison against bottom_y to what it
73 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
76 2012-05-15 Eli Zaretskii <eliz@gnu.org>
78 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
80 2012-05-13 Eli Zaretskii <eliz@gnu.org>
82 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
83 already have overlays loaded.
84 (handle_single_display_spec): Before returning without displaying
85 fringe bitmap, synchronize the bidi iterator with the main display
86 iterator, by calling iterate_out_of_display_property.
87 (iterate_out_of_display_property): Detect buffer iteration by
88 testing that it->string is a Lisp string.
89 (get_next_display_element): When the current object is exhausted,
90 and there's something on it->stack, call set_iterator_to_next to
91 proceed with what's on the stack, instead of returning zero.
92 (set_iterator_to_next): If called at the end of a Lisp string,
93 proceed to consider_string_end without incrementing string
94 position. Don't increment display vector index past the end of
95 the display vector. (Bug#11417)
96 (pos_visible_p): Don't report a position visible when move_it_to
97 stopped at the last line of window, which happens to be scanned
98 backwards by the bidi iteration. (Bug#11464)
100 2012-05-11 Eli Zaretskii <eliz@gnu.org>
102 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
103 and right-margin display specs even if the spec is invalid or we
104 are on a TTY, and thus unable to display on the fringes. That's
105 because the text with the property will not be displayed anyway,
106 so we need to signal to the caller that this is a "replacing"
107 display spec. This fixes display when the spec is invalid or we
110 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
112 * unexaix.c (make_hdr): Fix typo in prototype.
113 This bug broke the build on AIX. Problem reported by Gilles Pion.
115 2012-05-05 Eli Zaretskii <eliz@gnu.org>
117 * w32proc.c (new_child): Force Windows to reserve only 64KB of
118 stack for each reader_thread, instead of defaulting to 8MB
119 determined by the linker. This avoids failures in creating
120 subprocesses on Windows 7, see the discussion in this thread:
121 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
123 2012-05-02 Jim Meyering <meyering@redhat.com>
125 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
127 2012-04-29 Eli Zaretskii <eliz@gnu.org>
129 * xdisp.c (pos_visible_p): If already at a newline from the
130 display string before the 'while' loop, don't walk back the glyphs
131 from it3.glyph_row. Solves assertion violation when the display
132 string begins with a newline (egg.el). (Bug#11367)
134 2012-04-24 Chong Yidong <cyd@gnu.org>
136 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
138 2012-04-23 Eli Zaretskii <eliz@gnu.org>
140 * xdisp.c (pos_visible_p): If the window start position is beyond
141 ZV, start the display from buffer beginning. Prevents assertion
142 violation in init_iterator when the minibuffer window is scrolled
145 * window.c (window_scroll_pixel_based): Likewise.
147 2012-04-23 Chong Yidong <cyd@gnu.org>
149 * keymap.c (where_is_internal): Doc fix (Bug#10872).
151 2012-04-20 Glenn Morris <rgm@gnu.org>
153 * fileio.c (Fcopy_file, Fset_file_selinux_context):
154 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
156 2012-04-20 Eli Zaretskii <eliz@gnu.org>
158 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
159 overrun array limits of glyph row's used[] array. (Bug#11288)
161 2012-04-20 Chong Yidong <cyd@gnu.org>
163 * process.c (wait_reading_process_output): If EIO occurs on a pty,
164 set the status to "failed" and ensure that sentinel is run.
166 2012-04-18 Glenn Morris <rgm@gnu.org>
168 * process.c (Fset_process_inherit_coding_system_flag)
169 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
170 (Fmake_network_process, Fmake_serial_process): Doc fix.
172 2012-04-17 Eli Zaretskii <eliz@gnu.org>
174 * xdisp.c (string_buffer_position_lim): Limit starting position to
176 (set_cursor_from_row): If called for a mode-line or header-line
177 row, return zero immediately.
178 (try_cursor_movement): If inside continuation line, don't back up
179 farther than the first row after the header line, if any. Don't
180 consider the header-line row as "partially visible", even if
181 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
183 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
185 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
187 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
189 * process.c (make_process):
190 * process.h: Add integer `gnutls_handshakes_tried' member to
193 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
194 Add convenience `GNUTLS_LOG2i' macro.
196 * gnutls.c (gnutls_log_function2i): Convenience log function.
197 (emacs_gnutls_read): Use new log functions,
198 `gnutls_handshakes_tried' process member, and
199 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
200 attempts per process (connection).
202 2012-04-09 Eli Zaretskii <eliz@gnu.org>
204 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
205 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
207 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
209 * nsterm.m (constrainFrameRect): Always constrain when there is only
210 one screen (Bug#10962).
212 2012-04-06 Eli Zaretskii <eliz@gnu.org>
214 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
215 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
216 about subtle differences between FETCH_CHAR* and STRING_CHAR*
217 macros related to unification of CJK characters. For the details,
218 see the discussion following the message here:
219 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
221 2012-04-04 Chong Yidong <cyd@gnu.org>
223 * keyboard.c (Vdelayed_warnings_list): Doc fix.
225 2012-04-01 Eli Zaretskii <eliz@gnu.org>
227 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
228 instead of alloca. (Bug#11138)
230 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
232 * w32menu.c (is_simple_dialog): Properly check lisp types.
235 2012-03-31 Eli Zaretskii <eliz@gnu.org>
237 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
238 position we get to after a call to move_it_to fails the
239 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
240 only if we wind up in a string from display property. (Bug#11063)
242 * window.c (Fdelete_other_windows_internal): Invalidate the row
243 and column information about mouse highlight, so that redisplay
244 restores it after reallocating the glyph matrices. (Bug#7464)
246 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
247 string comes from a `display' text property, use the buffer
248 position of that property as if we actually saw that position in
250 (move_it_by_lines): Remove the assertion that
251 "it->current_x == 0 && it->hpos == 0" which can be legitimately
252 violated when there's a before-string at the beginning of a line.
255 2012-03-30 Eli Zaretskii <eliz@gnu.org>
257 * xdisp.c (append_space_for_newline): If the default face was
258 remapped, use the remapped face for the appended newline.
259 (extend_face_to_end_of_line): Use the remapped default face for
260 extending the face to the end of the line.
261 (display_line): Call extend_face_to_end_of_line when the default
262 face was remapped. (Bug#11068)
264 2012-03-29 Eli Zaretskii <eliz@gnu.org>
266 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
268 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
270 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
272 2012-03-27 Glenn Morris <rgm@gnu.org>
274 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
277 2012-03-26 Kenichi Handa <handa@m17n.org>
279 * dispextern.h (struct glyph): Fix previous change. Change the
280 bit length of glyphless.ch to 25 (Bug#11082).
282 2012-03-26 Chong Yidong <cyd@gnu.org>
284 * keyboard.c (Vselection_inhibit_update_commands): New variable.
285 (command_loop_1): Use it; inhibit selection update for
286 handle-select-window too (Bug#8996).
288 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
290 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
292 2012-03-25 Kenichi Handa <handa@m17n.org>
294 * dispextern.h (struct glyph): Change the bit length of
295 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
297 2012-03-24 Eli Zaretskii <eliz@gnu.org>
299 * s/ms-w32.h (tzname): Include time.h before redirecting to
300 _tzname. Fixes the MSVC build. (Bug#9960)
302 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
304 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
307 * xterm.c (XTread_socket): Only modify handling_signal if
308 !SYNC_INPUT. (Bug#11080)
310 2012-03-23 Eli Zaretskii <eliz@gnu.org>
312 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
313 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
314 when fetching a multibyte character consumes more bytes than
315 CHAR_BYTES returns, due to unification of CJK characters in
316 string_char. (Bug#11073)
318 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
320 * process.c (wait_reading_process_output): Handle pty disconnect
321 by refraining from sending oneself a SIGCHLD (bug#10933).
323 2012-03-22 Chong Yidong <cyd@gnu.org>
325 * dispextern.h (struct it): New member string_from_prefix_prop_p.
327 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
328 Mark string as coming from a prefix property.
329 (handle_face_prop): Use default face for prefix strings (Bug#4281).
330 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
332 2012-03-21 Chong Yidong <cyd@gnu.org>
334 * xfaces.c (Vface_remapping_alist): Doc fix.
336 2012-03-20 Eli Zaretskii <eliz@gnu.org>
338 * w32proc.c (Fw32_set_console_codepage)
339 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
342 2012-03-20 Chong Yidong <cyd@gnu.org>
344 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
345 to reflect default non-nil value of redisplay-dont-pause.
347 2012-03-19 Kenichi Handa <handa@m17n.org>
349 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
350 it fit in a valid range (Bug#11003).
352 2012-03-18 Eli Zaretskii <eliz@gnu.org>
354 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
355 that is not from display property, accept the row as a "cursor
356 row" if one of the string's character has a non-nil `cursor'
357 property. Fixes cursor positioning when there are newlines in
358 overlay strings, e.g. in icomplete.el. (Bug#11035)
360 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
362 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
364 2012-03-12 Chong Yidong <cyd@gnu.org>
366 * eval.c (inhibit_lisp_code): Rename from
367 inhibit_window_configuration_change_hook; move from window.c.
369 * xfns.c (unwind_create_frame_1, Fx_create_frame):
370 * window.c (run_window_configuration_change_hook)
371 (syms_of_window): Callers changed.
373 2012-03-11 Chong Yidong <cyd@gnu.org>
375 * keymap.c (Fkey_description): Doc fix (Bug#9700).
377 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
379 2012-03-10 Chong Yidong <cyd@gnu.org>
381 * frame.c (other_visible_frames): Don't assume the selected frame
382 is visible (Bug#10955).
384 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
386 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
388 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
390 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
391 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
394 2012-03-03 Glenn Morris <rgm@gnu.org>
396 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
398 2012-03-02 Eli Zaretskii <eliz@gnu.org>
400 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
401 position past the first glyph_row that ends at ZV. (Bug#10902)
402 (redisplay_window, next_element_from_string): Fix typos in
404 (redisplay_window): Pass to move_it_vertically the margin in
405 pixels, not in screen lines.
407 2012-03-02 Glenn Morris <rgm@gnu.org>
409 * buffer.c (buffer-list-update-hook): Doc fix.
411 2012-02-29 Eli Zaretskii <eliz@gnu.org>
413 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
414 push_it before setting up the iterator for the first overlay
415 string, even if we have an empty string loaded.
416 (next_overlay_string): If there's an empty string on the iterator
417 stack, pop the stack. (Bug#10903)
419 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
421 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
422 Suggested by Stefan Monnier in
423 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
424 * alloc.c (widen_to_Lisp_Object): New static function.
425 (mark_memory): Also mark Lisp_Objects by fetching pointer words
426 and widening them to Lisp_Objects. This would work even if
427 USE_LSB_TAG is defined and wide integers are used, which might
428 happen in a future version of Emacs.
430 2012-02-25 Chong Yidong <cyd@gnu.org>
432 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
435 * xselect.c (Fx_selection_exists_p): Doc fix.
436 (x_clipboard_manager_save_all): Print an informative message
437 before saving to clipboard manager.
439 2012-02-24 Chong Yidong <cyd@gnu.org>
441 * keyboard.c (process_special_events): Handle all X selection
442 requests in kbd_buffer, not just the next one (Bug#8869).
444 2012-02-23 Chong Yidong <cyd@gnu.org>
446 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
447 call when setting menu-bar-lines and tool-bar-lines parameters.
448 (unwind_create_frame_1): New helper function.
450 * window.c (inhibit_window_configuration_change_hook): New var.
451 (run_window_configuration_change_hook): Obey it.
452 (syms_of_window): Initialize it.
454 2012-02-22 Chong Yidong <cyd@gnu.org>
456 * xterm.c (x_draw_image_relief): Add missing type check for
457 Vtool_bar_button_margin (Bug#10743).
459 2012-02-21 Chong Yidong <cyd@gnu.org>
461 * fileio.c (Vfile_name_handler_alist): Doc fix.
463 * buffer.c (Fget_file_buffer): Protect against invalid file
464 handler return value.
466 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
468 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
469 when computing $valmask.
471 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
472 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
473 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
474 It's useless in that case, and it can cause problems on hosts
475 that allocate halves of EMACS_INT values separately.
476 Reported by Dan Horák. Diagnosed by Andreas Schwab in
477 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
478 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
479 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
480 it avoids undefined behavior on hosts where shifting right by more
481 than the word width has undefined behavior.
483 2012-02-19 Chong Yidong <cyd@gnu.org>
485 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
486 (Funhandled_file_name_directory, Ffile_name_as_directory)
487 (Fdirectory_file_name, Fexpand_file_name)
488 (Fsubstitute_in_file_name): Protect against invalid file handler
489 return values (Bug#10845).
491 2012-02-18 Eli Zaretskii <eliz@gnu.org>
493 * .gdbinit (pitx): Fix incorrect references to fields of the
496 2012-02-17 Chong Yidong <cyd@gnu.org>
498 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
500 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
502 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
503 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
505 2012-02-15 Chong Yidong <cyd@gnu.org>
507 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
508 marked as special. Also, starting docstrings with * is obsolete.
510 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
512 * gnutls.c (emacs_gnutls_write): Fix last change.
514 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
516 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
519 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
521 * keymap.c (Fsingle_key_description): Handle char ranges.
523 2012-02-12 Chong Yidong <cyd@gnu.org>
525 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
526 as that creates a dangerous corner case.
528 * window.c (Fdelete_window_internal): Invalidate the mouse
529 highlight (Bug#9904).
531 2012-02-12 Glenn Morris <rgm@gnu.org>
533 * xselect.c (Fx_own_selection_internal)
534 (Fx_get_selection_internal, Fx_disown_selection_internal)
535 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
536 * nsselect.m (Fx_own_selection_internal)
537 (Fx_disown_selection_internal, Fx_selection_exists_p)
538 (Fx_selection_owner_p, Fx_get_selection_internal):
539 Sync docs and argument specs with the xselect.c versions.
541 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
543 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
545 2012-02-11 Eli Zaretskii <eliz@gnu.org>
547 * w32select.c (Fx_selection_exists_p): Sync doc string and
548 argument list with xselect.c. (Bug#10783)
550 * w16select.c (Fx_selection_exists_p): Sync doc string and
551 argument list with xselect.c. (Bug#10783)
553 2012-02-10 Glenn Morris <rgm@gnu.org>
555 * fns.c (Fsecure_hash): Doc fix.
557 2012-02-09 Kenichi Handa <handa@m17n.org>
559 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
561 2012-02-07 Chong Yidong <cyd@gnu.org>
563 * buffer.c (Fbuffer_local_variables)
564 (buffer_lisp_local_variables): Handle unbound vars correctly;
565 don't let Qunbound leak into Lisp.
567 2012-02-07 Glenn Morris <rgm@gnu.org>
569 * image.c (Fimagemagick_types): Doc fix.
571 * image.c (imagemagick-render-type): Change it from a lisp object
572 to an integer. Move the doc here from the lisp manual.
573 Treat all values not equal to 0 the same.
575 2012-02-06 Chong Yidong <cyd@gnu.org>
577 * doc.c (store_function_docstring): Avoid applying docstring of
578 alias to base function (Bug#2603).
580 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
582 * .gdbinit (pp1, pv1): Remove redundant defines.
585 2012-02-04 Chong Yidong <cyd@gnu.org>
587 * nsterm.m: Declare a global (Bug#10694).
589 2012-02-04 Eli Zaretskii <eliz@gnu.org>
591 * w32.c (get_emacs_configuration_options):
592 Include --enable-checking, if specified, in the return value.
594 2012-02-04 Martin Rudalics <rudalics@gmx.at>
596 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
597 after rounding frame sizes. (Bug#9723)
599 2012-02-04 Eli Zaretskii <eliz@gnu.org>
601 * keyboard.c (adjust_point_for_property): Don't position point
602 before BEGV. (Bug#10696)
604 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
606 Handle overflow when computing char display width (Bug#9496).
607 * character.c (char_width): Return EMACS_INT, not int.
608 (char_width, c_string_width): Check for overflow when
609 computing the width; this is possible now that individual
610 characters can have unbounded width. Problem introduced
611 by merge from Emacs 23 on 2012-01-19.
613 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
615 * dbusbind.c (Fdbus_register_method): Mention the return value
616 :ignore in the docstring.
618 2012-02-02 Glenn Morris <rgm@gnu.org>
620 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
622 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
623 Unconditionally set to t. (Bug#10673)
624 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
625 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
626 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
628 2012-02-02 Kenichi Handa <handa@m17n.org>
630 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
631 0, do not call append_composite_glyph.
633 2012-02-02 Kenichi Handa <handa@m17n.org>
635 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
637 (x_produce_glyphs): If the component of a composition is a null
638 string, set it->pixel_width to 1 to avoid zero-width glyph.
640 2012-02-01 Eli Zaretskii <eliz@gnu.org>
642 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
643 first 2 arguments are identical. This makes inserting large
644 output from a subprocess an order of magnitude faster on
645 MS-Windows, where all sbrk'ed memory is always contiguous.
647 2012-01-31 Glenn Morris <rgm@gnu.org>
649 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
650 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
651 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
653 2012-01-29 Glenn Morris <rgm@gnu.org>
655 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
657 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
659 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
661 2012-01-28 Chong Yidong <cyd@gnu.org>
663 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
665 2012-01-26 Chong Yidong <cyd@gnu.org>
667 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
669 * search.c (Fsearch_forward, Fsearch_backward): Document negative
670 repeat counts (Bug#10507).
672 2012-01-26 Glenn Morris <rgm@gnu.org>
674 * lread.c (syms_of_lread): Doc fix.
676 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
678 * coding.c (encode_designation_at_bol): Change return value to
681 2012-01-25 Chong Yidong <cyd@gnu.org>
683 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
685 2012-01-21 Chong Yidong <cyd@gnu.org>
687 * floatfns.c (Fcopysign): Make the second argument non-optional,
688 since nil is not allowed anyway.
690 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
692 * process.c (read_process_output): Use p instead of XPROCESS (proc).
693 (send_process): Likewise.
695 2012-01-19 Martin Rudalics <rudalics@gmx.at>
697 * window.c (save_window_save, Fcurrent_window_configuration)
698 (Vwindow_persistent_parameters): Do not use Qstate.
701 2012-01-19 Kenichi Handa <handa@m17n.org>
703 * character.c (char_width): New function.
704 (Fchar_width, c_string_width, lisp_string_width):
705 Use char_width (Bug#9496).
707 2012-01-16 Martin Rudalics <rudalics@gmx.at>
709 * window.c (Vwindow_persistent_parameters): New variable.
710 (Fset_window_configuration, save_window_save): Handle persistent
713 2012-01-14 Eli Zaretskii <eliz@gnu.org>
715 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
716 thrashing the stack of the thread. (Bug#9087)
718 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
720 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
722 2012-01-11 Eli Zaretskii <eliz@gnu.org>
724 * xdisp.c (rows_from_pos_range): Handle the case where the
725 highlight ends on a newline. (Bug#10464)
726 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
727 he end column for display of highlight that ends on a newline
730 2012-01-11 Glenn Morris <rgm@gnu.org>
732 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
733 from load-path also when installation-directory is nil. (Bug#10208)
735 2012-01-10 Glenn Morris <rgm@gnu.org>
737 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
739 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
740 Update template values to be closer to their typical values these days.
742 2012-01-09 Eli Zaretskii <eliz@gnu.org>
744 * xdisp.c (rows_from_pos_range): Accept additional argument
745 DISP_STRING, and accept any glyph in a row whose object is that
746 string as eligible for mouse highlight. Fixes mouse highlight of
747 display strings from overlays. (Bug#10464)
749 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
751 emacs: fix an auto-save permissions race condition (Bug#10400)
752 * fileio.c (auto_saving_dir_umask): New static var.
753 (Fmake_directory_internal): Use it.
754 (do_auto_save_make_dir): Set it, instead of invoking chmod after
755 creating the directory. The old code temporarily assigns
756 too-generous permissions to the directory.
757 (do_auto_save_eh): Clear it.
758 (Fdo_auto_save): Catch all errors, not just file errors, so
759 that the var is always cleared.
761 2012-01-07 Eli Zaretskii <eliz@gnu.org>
763 * search.c (scan_buffer): Pass character positions to
764 know_region_cache, not byte positions. (Bug#6540)
766 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
768 * w32.c (sys_rename): Report EXDEV when rename of a directory
769 fails because the target is on another logical disk. (Bug#10284)
771 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
773 * xterm.c (x_embed_request_focus): New function.
775 * xterm.h: Add prototype.
777 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
779 2012-01-05 Glenn Morris <rgm@gnu.org>
781 * emacs.c (emacs_copyright): Update short copyright year to 2012.
783 2012-01-01 Eli Zaretskii <eliz@gnu.org>
785 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
786 Load gnutls_transport_set_lowat only if GnuTLS version is below
788 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
789 GnuTLS versions below 2.11.1.
791 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
793 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
794 to the doc string advising against its use for altering the way
795 windows are scrolled.
797 2011-12-28 Kenichi Handa <handa@m17n.org>
799 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
800 coding-system ASCII compatible only when it does not produce BOM
801 on encoding (Bug#10383).
803 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
805 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
807 (create_and_show_popup_menu): Always use menu_position_func for
810 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
812 * callint.c (Fcall_interactively): Don't truncate prompt string.
814 2011-12-23 Eli Zaretskii <eliz@gnu.org>
816 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
817 property that ends at ZV, so that the bidi iteration could be
818 resumed from there (after widening). (Bug#10360)
820 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
822 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
824 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
826 * nsterm.m (x_free_frame_resources):
827 Release f->output_data.ns->miniimage.
828 (ns_index_color): Fix indentation. Do not retain
829 color_table->colors[i].
831 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
834 * nsfns.m (x_set_background_color): Assign return value from
835 ns_index_color to face-background instead of NSColor*.
836 (ns_implicitly_set_icon_type): Fix indentation.
837 Change assignment in for loop to comparison.
839 * emacs.c (ns_pool): New variable.
840 (main): Assign ns_pool.
841 (Fkill_emacs): Call ns_release_autorelease_pool.
843 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
844 autorelease fdesc, release fdAttrs and tdict.
845 (ns_get_covering_families): Release charset.
846 (ns_findfonts): Release NSFontDescriptor created with new.
847 (ns_uni_to_glyphs): Fix indentation.
848 (setString): Release attrStr before assigning new value.
850 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
852 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
854 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
855 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
857 2011-12-18 David Reitter <reitter@cmu.edu>
859 * nsterm.m (ns_term_init): Subscribe for notifications
860 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
861 to method trackingNotification in EmacsMenu.
863 * nsmenu.m (trackingMenu): New variable.
864 (trackingNotification): New method (from Aquamacs).
865 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
866 from Aquamacs (Bug#7030).
868 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
870 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
871 (symbol_to_nsstring): Fix indentation.
872 (ns_symbol_to_pb): New function.
873 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
874 (Fns_rotate_cut_buffers_internal): Remove.
875 (Fns_store_selection_internal): Rename from
876 Fns_store_cut_buffer_internal.
877 (ns_get_foreign_selection, Fx_own_selection_internal)
878 (Fx_disown_selection_internal, Fx_selection_exists_p)
879 (Fns_get_selection_internal, Fns_store_selection_internal):
880 Use ns_symbol_to_pb and check if return value is nil.
881 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
882 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
883 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
884 renamed to Sns_store_selection_internal.
885 (ns_handle_selection_request): Move code to Fx_own_selection_internal
886 and remove this function.
887 (ns_handle_selection_clear): Remove, never used.
888 (Fx_own_selection_internal): Move code from ns_handle_selection_request
891 2011-12-17 Ken Brown <kbrown@cornell.edu>
893 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
894 GID is unknown (Bug#10257).
896 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
898 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
899 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
900 which caused a build failure on GNU/Linux IA-64. This problem was
901 introduced by my 2011-10-07 patch.
903 2011-12-15 Juri Linkov <juri@jurta.org>
905 * image.c (imagemagick_error): New function. (Bug#10112)
906 (imagemagick_load_image): Comment out `MagickSetResolution' call.
907 Use `imagemagick_error' where ImageMagick functions return
909 (Fimagemagick_types): Add `Fnreverse' to return the list in the
912 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
914 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
915 fill background (Bug#8992).
917 2011-12-13 Martin Rudalics <rudalics@gmx.at>
919 * window.c (Vwindow_combination_resize)
920 (Vwindow_combination_limit): Use t instead of non-nil in
922 (Vrecenter_redisplay): Add first sentence of doc-string on
924 (Frecenter): Fix doc-string typo.
926 2011-12-11 Kenichi Handa <handa@m17n.org>
928 * coding.c (Funencodable_char_position): Pay attention to the
929 buffer text relocation (Bug#9389).
931 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
933 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
934 gtk_init (Bug#10100).
936 2011-12-10 Eli Zaretskii <eliz@gnu.org>
938 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
939 IT->string is nil. (Bug#10263)
941 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
943 * nsterm.h (x_free_frame_resources): Declare.
945 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
946 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
948 * nsterm.h (ns_get_defaults_value): Declare.
950 * nsterm.m (ns_default): Call ns_get_defaults_value.
952 2011-12-09 Eli Zaretskii <eliz@gnu.org>
954 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
957 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
959 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
960 that where the value of an _OBJC_* symbol points to is in the .bss
963 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
965 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
966 after the loop to call ccl_driver at least once (Bug#8619).
968 2011-12-08 Kenichi Handa <handa@m17n.org>
970 * ftfont.c (get_adstyle_property): Fix previous change
973 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
975 * w32.c (init_environment): If no_site_lisp, remove site-lisp
976 dirs from the default value of EMACSLOADPATH (bug#10208).
978 2011-12-07 Glenn Morris <rgm@gnu.org>
980 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
981 installation and source directories as well. (Bug#10208)
983 2011-12-06 Chong Yidong <cyd@gnu.org>
985 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
987 2011-12-06 Glenn Morris <rgm@gnu.org>
989 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
990 as an error, not just -1. (Bug#10217)
992 2011-12-05 Chong Yidong <cyd@gnu.org>
994 * keyboard.c (process_special_events): New function.
995 (swallow_events, Finput_pending_p): Use it (Bug#10195).
997 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
999 * coding.c (encode_designation_at_bol): Don't use uninitialized
1000 local variable (Bug#9318).
1002 2011-12-05 Kenichi Handa <handa@m17n.org>
1004 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1005 return Qnil (Bug#8046, Bug#10193).
1007 2011-12-05 Kenichi Handa <handa@m17n.org>
1009 * coding.c (encode_designation_at_bol): New args charbuf_end and
1010 dst. Return the number of produced bytes. Callers changed.
1011 (coding_set_source): Return how many bytes coding->source was
1013 (coding_set_destination): Return how many bytes
1014 coding->destination was relocated.
1015 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1016 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1018 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1020 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1021 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1024 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1026 The following changes are to fix Bug#9318.
1028 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1029 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1030 (encode_coding_iso_2022, encode_coding_sjis)
1031 (encode_coding_big5, encode_coding_charset): Use the above macros.
1033 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1035 * lisp.h (process_quit_flag): Fix external declaration.
1037 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1039 Don't macro-inline non-performance-critical code.
1040 * eval.c (process_quit_flag): New function.
1041 * lisp.h (QUIT): Use it.
1043 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1045 * nsfns.m (get_geometry_from_preferences): New function.
1046 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1048 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1050 * emacs.c (Qkill_emacs): Define.
1051 (syms_of_emacs): Initialize it.
1052 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1053 Qquit_flag to `kill-emacs' instead.
1054 (quit_throw_to_read_char): Add parameter `from_signal'.
1055 All callers changed. Call Fkill_emacs if requested and safe.
1056 * lisp.h (QUIT): Call Fkill_emacs if requested.
1058 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1060 * widget.c (update_wm_hints): Return if wmshell is null.
1061 (widget_update_wm_size_hints): New function.
1063 * widget.h (widget_update_wm_size_hints): Declare.
1065 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1066 widget_update_wm_size_hints (Bug#10104).
1068 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1070 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1071 before a newline, prepare the bidi iterator for consuming the
1072 newline, and keep the current paragraph direction. (Bug#10183)
1073 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1075 2011-12-02 Juri Linkov <juri@jurta.org>
1077 * search.c (Fword_search_regexp): New Lisp function created from
1078 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1079 (Fword_search_backward, Fword_search_forward)
1080 (Fword_search_backward_lax, Fword_search_forward_lax):
1081 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1082 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1084 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1086 * fileio.c (Finsert_file_contents): Move after-change-function call
1087 to before the "handled:" label, since all "goto handled" appear in
1088 cases where the *-change-functions have already been properly called
1091 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1093 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1094 waiting for input. (Bug#10169)
1096 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1098 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1099 verifies glyph row's hash code--we have just reallocated the
1100 glyphs, so their contents can be complete garbage. (Bug#10164)
1102 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1104 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1106 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1108 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1109 attributes are tested _before_ calling verify_row_hash, to protect
1110 against GCC re-ordering of the tests. (Bug#10164)
1112 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1114 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1116 * xterm.c (handle_one_xevent): Only set async_visible and friends
1117 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1118 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1119 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1121 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1123 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1124 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1125 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1126 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1127 All uses changed to use GCPRO1 etc.
1128 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1129 Revert to old implementation (i.e., before 2011-03-11).
1131 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1133 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1134 of scroll runs so as to avoid assigning disabled bogus rows and
1135 unnecessary graphics copy operations.
1137 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1139 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1140 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1141 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1142 (malloc, free, realloc, calloc): Redirect to e_* only when
1145 * lisp.h (GCTYPEBITS): Move before first use.
1146 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1147 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1148 this macro definition.
1150 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1153 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1155 * gtkutil.c (xg_create_frame_widgets):
1156 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1157 present with Gtk+ 2.0.
1159 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1161 * fileio.c (Finsert_file_contents): Undo previous change; see
1162 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1164 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1166 Rename locals to avoid shadowing.
1167 * fileio.c (Finsert_file_contents):
1168 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1169 * process.c (wait_reading_process_output):
1170 Rename inner 'proc' to 'p' to avoid shadowing.
1171 Indent for consistency with usual Emacs style.
1173 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1175 * xdisp.c (redisplay_window): If cursor row is not fully visible
1176 after recentering, and scroll-conservatively is set to a large
1177 number, scroll window by a few more lines to make the cursor fully
1178 visible and out of scroll-margin. (Bug#10105)
1179 (start_display): Don't move to the next line if the display should
1180 start at a newline that is part of a display vector or an overlay
1183 2011-11-24 Juri Linkov <juri@jurta.org>
1185 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1186 after the `MagickPingImage' call. (Bug#10112)
1188 2011-11-23 Chong Yidong <cyd@gnu.org>
1190 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1192 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1194 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1195 making another buffer current. (Bug#10114)
1197 2011-11-23 Glenn Morris <rgm@gnu.org>
1199 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1201 2011-11-23 Chong Yidong <cyd@gnu.org>
1203 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1204 using it (Bug#5984).
1206 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1208 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1209 and header-lines, as they don't have one computed for them.
1212 * .gdbinit (prow): Make displayed values more self-explaining.
1213 Add row's hash code.
1215 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1217 * process.c (wait_reading_process_output): Fix asynchrounous
1218 GnuTLS socket handling on some versions of the GnuTLS library.
1219 (wait_reading_process_output): Add comment and URL.
1221 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1223 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1225 2011-11-21 Chong Yidong <cyd@gnu.org>
1227 * window.c (Fnext_window, Fprevious_window): Doc fix.
1229 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1231 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1233 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1235 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1237 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1239 * window.c (Fset_window_combination_limit): Rename argument
1241 (Vwindow_combination_limit): Remove "status" from doc-string.
1243 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1245 * m/ibms390.h: Remove.
1246 * m/ibms390x.h: Don't include "ibms390.h".
1248 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1250 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1251 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1253 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1255 * casetab.c (Fset_case_table):
1256 * charset.c (Fcharset_after): Fix typos.
1258 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1260 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1261 Otherwise, valgrind does not work on some platforms.
1262 Problem reported by Andreas Schwab in
1263 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1264 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1265 is set, removing the need for VIRT_ADDRESS_VARIES.
1266 (PURE_P): Use a more-efficient implementation that needs just one
1267 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1268 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1269 to 4 (xorl, subq, cmpq, setbe).
1270 * alloc.c (pure): Always extern now, since that's the
1271 VIRT_ADDR_VARIES behavior.
1272 (PURE_POINTER_P): Use a single comparison, not two, for
1273 consistency with the new puresize.h.
1274 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1275 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1276 Remove VIRT_ADDR_VARIES no longer needed.
1278 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1280 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1281 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1282 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1283 behave as if the cursor position were at the window margin.
1285 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1286 and the cursor position is out of bounds, behave as if the cursor
1287 position were at the window margin. (Bug#10075)
1289 2011-11-18 Chong Yidong <cyd@gnu.org>
1291 * window.c (Fwindow_combination_limit): Make first argument
1292 non-optional, since it is meaningless for live windows like the
1295 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1297 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1299 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1301 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1302 (graft_intervals_into_buffer): Simplify.
1304 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1306 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1307 hash values of the two rows.
1308 (copy_row_except_pointers): Preserve the used[] arrays and the
1309 hash values of the two rows. (Bug#10035)
1310 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1312 * xdisp.c (row_hash): New function, body extracted from
1313 compute_line_metrics.
1314 (compute_line_metrics): Call row_hash, instead of computing the
1317 * dispnew.c (verify_row_hash): Call row_hash for computing the
1318 hash code of a row, instead of duplicating code from xdisp.c.
1320 * dispextern.h (row_hash): Add prototype.
1322 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1324 * frame.c (delete_frame): Don't delete the terminal when the last
1325 X frame is closed if emacs is built with GTK toolkit.
1327 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1329 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1331 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1333 * window.c (Vwindow_splits): Rename to
1334 Vwindow_combination_resize. Suggested by Juri Linkov.
1335 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1338 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1340 * nsfns.m (Fns_font_name):
1341 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1343 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1345 * window.h (window): Rename slot "nest" to "combination_limit".
1346 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1347 (Fset_window_nest): Rename to Fset_window_combination_limit.
1348 (Vwindow_nest): Rename to Vwindow_combination_limit.
1349 (recombine_windows, make_parent_window, make_window)
1350 (Fsplit_window_internal, saved_window)
1351 (Fset_window_configuration, save_window_save): Rename all
1352 occurrences of window_nest to window_combination_limit.
1354 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1356 * image.c (imagemagick_load_image): Fix typo.
1358 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1360 * xdisp.c (display_line): Move the call to
1361 highlight_trailing_whitespace before the call to
1362 compute_line_metrics, since the latter needs to see the final
1363 faces of all the glyphs to compute ROW's hash value.
1364 Fixes assertion violations in row_equal_p. (Bug#10035)
1366 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1368 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1369 just return (bug#10044).
1371 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1373 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1374 with user-defined heap size. Bump the default size of the temacs
1375 heap to 27MB, to avoid memory warning when running temacs.
1376 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1378 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1379 current_matrix and desired_matrix. (Bug#9990)
1380 (verify_row_hash) [XASSERTS]: New function.
1381 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1382 that the hash value of glyph rows is correct.
1384 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1386 * window.h (window): Remove splits slot.
1387 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1388 (Fdelete_other_windows_internal, make_parent_window)
1389 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1390 (Fset_window_configuration, save_window_save): Don't deal with
1391 split status of windows.
1392 (saved_window): Remove splits slot.
1393 (Vwindow_splits): Rewrite doc-string.
1395 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1397 * xfns.c (unwind_create_frame):
1398 * nsfns.m (unwind_create_frame):
1399 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1400 Vframe_list (Bug#9999).
1402 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1404 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1406 2011-11-11 Kenichi Handa <handa@m17n.org>
1408 * callproc.c (Fcall_process): Set the member dst_multibyte of
1411 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1413 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1414 avoid a crash (bug#9496).
1416 2011-11-09 Chong Yidong <cyd@gnu.org>
1418 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1419 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1421 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1423 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1425 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1427 Avoid some portability problems by eschewing 'extern inline' functions.
1428 The trivial performance wins aren't worth the portability hassles; see
1429 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1431 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1432 (window_box_width, window_box_left, window_box_left_offset)
1433 (window_box_right, window_box_right_offset): Undo previous change,
1434 by removing the "extern"s.
1435 * intervals.c (adjust_intervals_for_insertion)
1436 (adjust_intervals_for_deletion): Undo previous change,
1437 making these static again.
1438 (offset_intervals, temp_set_point_both, temp_set_point)
1439 (copy_intervals_to_string): No longer inline.
1440 * xdisp.c (window_text_bottom_y, window_box_width)
1441 (window_box_height, window_box_left_offset)
1442 (window_box_right_offset, window_box_left, window_box_right)
1443 (window_box): No longer inline.
1445 2011-11-08 Chong Yidong <cyd@gnu.org>
1447 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1448 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1449 Signal an error if not a live window.
1450 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1451 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1453 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1455 * lisp.h (syms_of_abbrev): Remove declaration.
1456 Reported by CHENG Gao <chenggao@royau.me>.
1458 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1460 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1461 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1462 of temacs in GUI mode.
1464 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1466 * window.h: Declare delete_all_child_windows instead of
1467 delete_all_subwindows.
1468 * window.c (Fwindow_nest, Fset_window_nest)
1469 (Fset_window_new_total, Fset_window_new_normal)
1470 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1471 (delete_all_subwindows): Rename to delete_all_child_windows.
1472 (Fdelete_other_windows_internal, Fset_window_configuration):
1473 Call delete_all_child_windows instead of delete_all_subwindows.
1474 * frame.c (delete_frame): Call delete_all_child_windows instead
1475 of delete_all_subwindows.
1477 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1479 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1480 This is also needed for porting to any host where GC_MARK_STACK is
1481 not GC_MAKE_GCPROS_NOOPS.
1482 (which_symbols): Use it.
1484 2011-11-07 Kenichi Handa <handa@m17n.org>
1486 * coding.c (coding_set_destination): Check coding->src_pos only
1487 when coding->src_object is a buffer (bug#9910).
1489 * process.c (send_process): Set the member src_multibyte of coding
1490 to 0 (bug#9911) when sending a unibyte text.
1492 * callproc.c (Fcall_process): Set the member src_multibyte of
1493 process_coding to 0 (bug#9912).
1495 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1497 * xmenu.c (cleanup_widget_value_tree): New function.
1498 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1499 calling free_menubar_widget_value_tree directly (Bug#9830).
1501 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1503 Fix some portability problems with 'inline'.
1504 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1505 (window_box_width, window_box_left, window_box_left_offset)
1506 (window_box_right, window_box_right_offset): Declare extern.
1507 Otherwise, these inline functions do not conform to C99 and
1508 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1509 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1510 * intervals.c (adjust_intervals_for_insertion)
1511 (adjust_intervals_for_deletion): Now extern, because otherwise the
1512 extern inline functions 'offset_intervals' couldn't refer to it.
1513 (static_offset_intervals): Remove.
1514 (offset_intervals): Rewrite using the old contents of
1515 static_offset_intervals. The old version didn't conform to C99
1516 because an extern inline function contained a reference to an
1517 identifier with static linkage.
1519 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1521 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1524 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1527 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1528 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1529 return Qleft_to_right.
1531 2011-11-06 Chong Yidong <cyd@gnu.org>
1533 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1534 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1535 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1536 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1537 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1538 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1539 (Fwindow_vscroll): Doc fix.
1540 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1541 argument, since it makes no sense to pass a live window and for
1542 consistency with window-child.
1544 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1546 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1549 2011-11-05 Jason Rumney <jasonr@gnu.org>
1551 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1552 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1554 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1555 bitwise arithmetic preventing use of unicode-sip and non-truetype
1558 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1560 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1563 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1564 initialization code to keep similarity to xfns.c after changes
1567 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1569 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1570 (unwind_create_frame): New function (Bug#9943).
1571 (Fx_create_frame): Restructure code to be more similar to the one in
1572 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1573 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1574 Move terminal->reference_count++ just before making the frame official
1577 * nsterm.m (x_free_frame_resources): New function.
1578 (x_destroy_window): Move code to x_free_frame_resources.
1580 * xfns.c (unwind_create_frame): Fix comment.
1581 (Fx_create_frame, x_create_tip_frame):
1582 Move terminal->reference_count++ just before making the frame
1583 official. Move initialization of image_cache_refcount and
1584 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1586 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1588 Support MSVC build with newer versions of Visual Studio.
1589 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1590 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1593 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1594 which are not supported by MSVC.
1595 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1596 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1598 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1600 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1602 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1604 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1606 Support MSVC build with newer versions of Visual Studio.
1607 * w32.c: Don't include w32api.h for MSVC.
1608 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1610 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1611 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1612 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1613 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1615 (alloca) [_MSC_VER]: Define to _alloca.
1617 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1619 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1621 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1623 * xdisp.c (note_mouse_highlight): If either of
1624 previous/next-single-property-change returns nil, treat that as
1625 the beginning or the end of the buffer. (Bug#9955)
1627 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1629 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1630 label is not null (Bug#9951).
1631 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1634 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1636 * window.c (Fwindow_body_size): Mention in the doc string that the
1637 return value is in frame's canonical units. (Bug#9949)
1639 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1641 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1643 * w32fns.c (unwind_create_frame): If needed, free the glyph
1644 matrices of the partially constructed frame. (Bug#9943)
1645 * xfns.c (unwind_create_frame): Likewise.
1647 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1649 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1650 Don't stop backward scan on the continuation glyph, even though
1651 its CHARPOS is positive.
1652 (mouse_face_from_buffer_pos, note_mouse_highlight):
1653 Rename cover_string to disp_string.
1655 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1657 * window.c (temp_output_buffer_show): Don't use
1658 Vtemp_buffer_show_specifiers.
1659 (Vtemp_buffer_show_specifiers): Remove unused variable.
1661 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1663 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1664 past the beginning of the current glyph matrix.
1666 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1668 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1669 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1670 HAVE_GTK3 (Bug#9869).
1672 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1673 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1675 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1677 * xterm.c: Declare x_handle_net_wm_state to return int.
1678 (handle_one_xevent): Check if we are iconified but don't have
1679 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1680 (get_current_wm_state): Return non-zero if not hidden,
1681 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1682 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1683 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1684 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1686 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1688 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1689 so that this new function doesn't get optimized away by a
1690 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1692 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1694 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1696 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1698 Fix the `xbytecode' command.
1699 * .gdbinit (xprintbytestr): New command.
1700 (xwhichsymbols): Rename from `which'; all callers changed.
1701 (xbytecode): Print the byte-code string as well.
1703 2011-10-29 Kim Storm <storm@cua.dk>
1705 * alloc.c (which_symbols): New function.
1707 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1709 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1712 2011-10-29 Glenn Morris <rgm@gnu.org>
1714 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1715 Not clear what it was for, and it causes various bugs. (Bug#9839)
1717 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1719 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1720 possible random value that matches one of those tested as
1721 condition to clear the mouse face.
1723 2011-10-28 Chong Yidong <cyd@gnu.org>
1725 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1727 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1729 * window.c (make_window): Initialize phys_cursor_on_p.
1731 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1733 * lisp.h (struct Lisp_Symbol): Update comments.
1735 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1737 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1739 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1741 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1742 <oslsachem@gmail.com> for helping to debug this.
1744 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1745 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1746 (g_b_init_get_glyph_outline_w): New static variables.
1747 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1748 (GetGlyphOutlineW_Proc): New typedefs.
1749 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1750 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1752 (w32font_open_internal, compute_metrics):
1753 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1754 instead of calling the "wide" APIs directly.
1756 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1758 * w32.h (syms_of_w32font): Add prototype.
1760 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1762 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1763 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1764 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1765 (Fmove_to_window_line): Doc fix.
1767 2011-10-27 Chong Yidong <cyd@gnu.org>
1769 * process.c (make_process): Set gnutls_state to NULL.
1771 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1772 non-NULL, regardless of GNUTLS_INITSTAGE.
1773 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1774 an error. Set process slots as soon as we allocate them.
1776 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1778 2011-10-27 Chong Yidong <cyd@gnu.org>
1780 * gnutls.c (emacs_gnutls_deinit): New function.
1781 Deallocate credentials structures as well as calling gnutls_deinit.
1782 (Fgnutls_deinit, Fgnutls_boot): Use it.
1784 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1785 (deactivate_process): Call emacs_gnutls_deinit.
1787 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1789 * image.c (x_create_x_image_and_pixmap):
1790 * w32.c (sys_rename, w32_delayed_load):
1791 * w32font.c (fill_in_logfont):
1792 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1794 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1796 * w32fns.c (w32_default_color_map): New function,
1797 extracted from Fw32_default_color_map.
1798 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1800 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1802 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1804 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1806 * keyboard.c (test_undefined): New function (bug#9751).
1807 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1809 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1811 * sysdep.c (init_sys_modes): Fix the check for the controlling
1812 terminal (Bug#6649).
1814 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1816 * dispextern.h (struct bidi_it): New member next_en_type.
1818 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1819 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1820 current character, check also for next_en_type being WEAK_EN.
1821 (bidi_resolve_weak): Don't enter the expensive loop if the current
1822 position is before next_en_pos. Record the bidi type of the first
1823 non-ET, non-BN character we find, in addition to its position.
1824 (bidi_level_of_next_char): Invalidate next_en_type when
1825 next_en_pos is over-stepped.
1827 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1829 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1830 * editfns.c: Rewrite current-time-zone so that it invokes
1831 the equivalent of (format-time-string "%Z") to get the time zone name.
1832 This fixes a bug when the time zone name contains characters that
1833 need converting from the system time locale to Emacs internal format.
1834 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1835 that patch fixed format-time-string to do the conversion, but
1836 I forgot to fix current-time-zone.
1837 (format_time_string): New function, containing most of
1838 what Fformat_time_string used to contain.
1839 (Fformat_time_string): Rewrite in terms of format_time_string.
1840 This doesn't change this function's behavior.
1841 (current-time-zone): Rewrite to use format_time_string.
1842 This fixes the bug reported by Michael Schierl in
1843 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1844 Jason Rumney's 2007-06-07 change worked around this bug, but
1846 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1848 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (start_display): If the character at POS is displayed
1851 via a display vector, reset IT->current.dpvec_index to zero.
1852 (try_window_reusing_current_matrix): If a line ends in a display
1853 vector or the next line starts in a display vector, continue
1854 redrawing the window even though the character position of
1855 start_row was reached.
1858 2011-10-18 Chong Yidong <cyd@gnu.org>
1860 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1861 with nobreak-char-display too.
1863 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1865 Fix part 3 of bug#9771.
1866 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1867 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1868 non-neutral characters if the current character is a paragraph
1869 separator (a.k.a. Newline). This avoids running the same
1870 expensive loop twice, once when we consume the preceding newline
1871 and the other time when the line actually needs to be displayed.
1872 Avoid the loop when we see neutrals on the base embedding level
1873 following a character whose directionality is the same as the
1874 paragraph's. This avoids running the expensive loop when a line
1875 ends in a long sequence of neutrals, like control characters.
1876 Add assertion against STRONG_AL type. Slightly rearrange code
1877 that determines the type of a neutral given the first non-neutral
1879 (bidi_level_of_next_char): Set next_en_pos to zero when
1880 invalidating its info.
1882 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (push_display_prop): Determine whether to record string
1885 or buffer position by IT->string, not by IT->method. Allow
1886 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1887 (move_it_vertically_backward): Don't look for character position
1888 immediately after the newline when in a continuation line.
1891 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1893 * window.c (coordinates_in_window): Rewrite and delabelize
1894 vertical border check. (Bug#5357) (Bug#9618)
1896 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1898 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1899 errors in XSetWindowBorder (bug#9310).
1901 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1903 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1904 avoid crash when xmalloc overrun checking is enabled.
1906 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1908 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1909 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1910 cursor motion with <left> and <right> arrow keys.
1912 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1913 some callers set that themselves.
1915 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1917 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1918 display string and the previous row comes from the same string and
1919 is empty. (Bug#9739) (Bug#9738)
1921 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1923 * doc.c (get_doc_string): Encode file name (bug#9735).
1925 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1927 * bidi.c (bidi_level_of_next_char):
1928 * xdisp.c (get_visually_first_element): Remove old incorrect
1929 comments regarding the Unicode Line Separator character.
1931 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1933 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1935 * alloc.c (Fgc_status): Do not access beyond zombies array
1936 boundary if nzombies > MAX_ZOMBIES.
1937 * alloc.c (dump_zombies): Add missing format specifier.
1939 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1941 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1942 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1944 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1945 Some packages use them to denote characters with modifiers.
1947 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1949 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1950 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1951 matching a pp-number. Rename parameter var to var1.
1953 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1955 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1957 2011-10-08 Glenn Morris <rgm@gnu.org>
1959 * callint.c (Fcall_interactively): Give a more explicit error for the
1960 'c' case with a non-character input. (Bug#8479)
1962 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1964 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1966 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1967 lines that are hscrolled on the left.
1969 * dispnew.c (buffer_posn_from_coords): Account for a possible
1970 presence of header-line. (Bug#4426)
1972 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1974 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1975 Don't advertise functionality which we discourage or doesn't work.
1977 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1979 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1980 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1981 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1982 this makes Emacs dump core during garbage collection on rare
1983 occasions. sizeof is obviously inferior to offsetof here, so
1984 stick with offsetof.
1985 (GC_POINTER_ALIGNMENT): New macro.
1986 (mark_memory): Omit 3rd (offset) arg; caller changed.
1987 Don't assume EMACS_INT alignment is the same as pointer alignment.
1989 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1991 * keyboard.c (read_key_sequence_remapped): New var.
1992 (read_key_sequence): Compute remapping in the right buffer.
1993 (command_loop_1): Use read_key_sequence's remapping directly.
1995 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1997 * dired.c (file_name_completion): Don't expand file name.
1998 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1999 before checking file name handler.
2001 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2002 they've been requested explicitly (bug#9591).
2004 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2006 * keymap.c (Fsingle_key_description): Use make_specified_string
2007 instead of build_string to build string from push_key_description.
2010 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2012 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2013 This fixes a Y2038 bug on 64-bit hosts.
2014 * buffer.c (reset_buffer):
2015 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2016 (Fclear_buffer_auto_save_failure):
2017 Use 0, not -1, to represent an unset failure time, since time_t
2018 might not be signed.
2020 Remove dependency on glibc malloc internals.
2021 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2022 Move back here from lisp.h, but with their new implementations.
2023 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2024 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2025 * charset.c (charset_table_init): New static var.
2026 (syms_of_charset): Use it instead of xmalloc. This removes a
2027 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2028 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2029 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2030 Move back to alloc.c.
2031 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2032 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2034 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2036 * nsterm.m (windowDidResize): Call x_set_window_size only when
2037 ns_in_resize is true. Otherwise set pixelwidth/height and
2038 call change_frame_size (Bug#9628).
2040 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2042 Port --enable-checking=all to Fedora 14 x86-64.
2043 * charset.c (syms_of_charset): Also account for glibc malloc's
2044 internal overhead when calculating the initial malloc maximum.
2046 Port --enable-checking=all to Fedora 14 x86.
2047 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2049 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2050 (overrun_check_realloc, overrun_check_free):
2051 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2052 That way, xmalloc returns a properly-aligned pointer even if
2053 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2054 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2055 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2056 into account when calculating the initial malloc maximum.
2057 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2058 Move here from alloc.c, so that charset.c can use it too.
2059 Properly align; the old code wasn't right for common 32-bit hosts
2060 when configured with --enable-checking=all.
2061 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2062 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2064 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2066 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2069 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2071 * xdisp.c (compute_display_string_end): If there's no display
2072 string at CHARPOS, return -1.
2074 * bidi.c (bidi_fetch_char): When compute_display_string_end
2075 returns a negative value, treat the character as a normal
2076 character not covered by a display string. (Bug#9624)
2078 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2080 * lread.c (Fread_from_string): Fix typo in docstring.
2082 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2084 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2085 newline, reseat the iterator instead of bidi-iterating there one
2086 character at a time. (Bug#9610)
2087 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2088 TO_CHARPOS if the bidi iterator is at base embedding level.
2090 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2092 * lread.c (readevalloop): Use correct code for NBSP.
2093 (read1): Likewise. (Bug#9608)
2095 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2097 * dbusbind.c (Fdbus_register_signal): When service is not
2098 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2100 2011-09-25 Glenn Morris <rgm@gnu.org>
2102 * buffer.c (truncate-lines): Doc fix.
2104 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2106 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2107 (Fset_window_next_buffers): Doc fix.
2109 2011-09-24 Glenn Morris <rgm@gnu.org>
2111 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2113 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2115 Fix minor problems found by static checking.
2116 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2117 * indent.c (Fvertical_motion): Fix == vs = typo.
2119 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2121 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2122 Default value is now t. Doc fix.
2124 * indent.c (Fvertical_motion): Compute and apply the overshoot
2125 logic when moving up, not only when moving down. Fix the
2126 confusing name and values of the it_overshoot_expected variable;
2127 logic changes accordingly. (Bug#9254) (Bug#9549)
2129 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2130 CHARPOS is covered by a display string which includes newlines.
2131 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2132 is covered by a display string with embedded newlines.
2134 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2136 * dbusbind.c (Fdbus_register_signal): Add match rule to
2137 Vdbus_registered_objects_table. (Bug#9581)
2138 (Fdbus_register_method, Vdbus_registered_objects_table):
2141 2011-09-24 Jim Meyering <meyering@redhat.com>
2143 do not ignore write error for any output size
2144 The previous change was incomplete.
2145 While it makes emacs --batch detect the vast majority of stdout
2146 write failures, errors were still ignored whenever the output size is
2147 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2148 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2149 && echo FAIL: ignored write error
2150 FAIL: ignored write error
2151 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2152 && echo FAIL: ignored write error
2153 FAIL: ignored write error
2154 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2156 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2158 * emacs.c (Fkill_emacs): In noninteractive mode exit
2159 non-successfully if a write error occurred on stdout. (Bug#9574)
2161 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2163 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2166 * dispextern.h (struct it): Update the comment documenting what
2169 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2171 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2172 a display string, extend search for cursor position to end of row.
2173 (find_row_edges): If the row ends in a newline from a display
2174 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2175 Handle the case of a display string with multiple newlines.
2176 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2177 non-empty line. Fixes confusing cursor motion with arrow keys at
2178 the beginning of a line that starts with whitespace.
2180 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2182 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2185 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2187 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2190 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2192 * xdisp.c (display_line): Record maximum and minimum buffer
2193 positions even if no glyphs were produced (e.g., by a zero-width
2194 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2195 buffer positions that will be removed from the glyph row because
2197 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2198 column is beyond frame width: don't subtract 1 "pixel" when
2199 computing width of the stretch.
2200 (reseat_at_next_visible_line_start): Undo the change made on
2201 2011-09-17 that saved paragraph information and restored it after
2202 the call to `reseat'. (Bug#9545)
2204 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2206 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2207 and turn window cursor on if cleared (Bug#9415).
2209 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2211 * search.c (boyer_moore): Take unibyte characters from pattern
2212 literally. (Bug#9458)
2214 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2216 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2218 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2220 Fix minor problem found by static checking.
2221 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2222 initialized, to pacify gcc -Wuninitialized.
2224 * fileio.c: Report proper errno when syscall falls.
2225 (Finsert_file_contents): Save and restore errno,
2226 so that report_file_error outputs the correct diagnostic.
2227 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2229 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2231 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2233 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2236 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2238 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2240 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2241 about the current paragraph and restore it after the call to reseat.
2243 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2244 (bidi_find_paragraph_start): Search back for paragraph beginning
2245 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2246 (bidi_move_to_visually_next): Only trigger paragraph-related
2247 computations when the last character is a newline or at EOB, not
2248 just any NEUTRAL_B. (Bug#9470)
2250 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2251 truncated lines if point is covered by a display string. (Bug#9524)
2253 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2255 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2256 (cons_to_x_long): New function.
2257 (lisp_data_to_selection_data): Use it. Correct the test for
2258 short-versus-long data; it was negated. Break out of vector
2259 loop, for efficiency, when a long datum is discovered.
2261 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2263 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2265 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2267 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2268 GCC PR/17406) by declaring this function with external scope.
2270 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2272 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2273 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2275 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2277 * editfns.c (Fformat): Correctly handle text properties on "%%".
2279 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2281 * xterm.c (x_draw_composite_glyph_string_foreground):
2282 * w32term.c (x_draw_composite_glyph_string_foreground):
2283 * term.c (encode_terminal_code):
2284 * composite.c (composition_update_it, get_composition_id):
2285 * xdisp.c (get_next_display_element)
2286 (fill_composite_glyph_string): Add comments about special meaning
2287 of TAB characters in a composition.
2289 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2291 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2292 This occurs when processing a multibyte format.
2293 Problem reported by Wolfgang Jenker.
2295 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2297 * xdisp.c (try_cursor_movement): Only check for exact match if
2298 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2300 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2302 Remove unused external symbols.
2303 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2304 * xdisp.c (calc_pixel_width_or_height): Now static.
2305 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2306 * indent.c (check_display_width):
2307 * w32term.c: Fix comment to match code.
2308 * xterm.c, xterm.h (x_catching_errors): Remove.
2310 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2312 * xselect.c: Use signed conversions more consistently (Bug#9498).
2313 (selection_data_to_lisp_data): Assume incoming selection data are
2314 signed integers, not unsigned. This is to be consistent with
2315 outgoing selection data, which was modified to use signed integers
2316 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2317 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2318 expects long, not unsigned long.
2320 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2323 computation of loop end. Reported by Johan Bockgård
2326 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2328 * frame.c (Fother_visible_frames_p): Function deleted.
2330 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2332 * indent.c (compute_motion): Process display vector front to back
2333 rather than the other way around. (Bug#2496)
2335 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2337 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2339 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2341 * minibuf.c (Fread_from_minibuffer): Doc fix.
2343 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2345 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2346 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2348 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2350 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2351 value for non-existent files.
2353 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2355 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2356 set its "size" to -1. This will set the modtime_size field of
2357 the corresponding buffer to -1, which is what
2358 verify-visited-file-modtime expects for files that do not exist.
2361 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2363 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2365 * lisp.h: ... from here. push_key_description is no longer
2366 defined in keyboard.c, so its declaration should not be in
2367 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2368 logically belongs with push_key_description.
2370 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2372 * buffer.h: Include <sys/types.h> instead of <time.h>.
2373 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2374 Problem reported by Herbert J. Skuhra.
2376 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2378 * xml.c (parse_region): Make the parsing work for
2379 non-comment-starting XML files again (bug#9144).
2381 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2383 * image.c (gif_load): Fix calculation of bottom and right corner.
2386 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2388 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2389 redisplay in small windows.
2391 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2393 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2395 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2397 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2398 Operate on live windows only.
2400 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2402 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2404 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2406 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2407 only under bidi iteration.
2409 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2411 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2413 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2415 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2416 Without this fix, the command to link temacs failed due to an
2417 undefined symbol __builtin_isnan. This is because
2418 /usr/include/iso/math_c99.h #defines isnan(x) to
2419 __builtin_isnan(x), but the bundled gcc, which identifies itself
2420 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2422 * floatfns.c (isnan): #undef, and then #define to a clone of
2424 (Fisnan): Always define, since it's always available now.
2425 (syms_of_floatfns): Always define isnan at the Lisp level.
2427 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2429 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2431 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2433 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2434 The previous code assumed that file offsets (off_t values) fit in
2435 EMACS_INT variables, which is not true on typical 32-bit hosts.
2436 The code messed up by falsely reporting buffer overflow in cases
2437 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2438 when "big" contains more than 2**29 bytes, even though this
2439 inserts just one byte and does not overflow the buffer.
2440 (Finsert_file_contents): Store file offsets as off_t
2441 values, not as EMACS_INT values. Check for overflow when
2442 converting between EMACS_INT and off_t. When checking for
2443 buffer overflow or for overlap, take the offsets into account.
2444 Don't use EMACS_INT for small values where int suffices.
2445 When checking for overlap, fix a typo: ZV was used where
2446 ZV_BYTE was intended.
2447 (Fwrite_region): Don't assume off_t fits into 'long'.
2448 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2450 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2452 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2454 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2456 sprintf-related integer and memory overflow issues (Bug#9412).
2458 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2459 (esprintf, exprintf, evxprintf): New functions.
2460 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2461 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2462 (modify_event_symbol): Do not assume that the length of
2463 name_alist_or_stem is safe to alloca and fits in int.
2464 (Fexecute_extended_command): Likewise for function name and binding.
2465 (Frecursion_depth): Wrap around reliably on integer overflow.
2466 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2467 since some callers pass EMACS_INT values.
2468 (Fsingle_key_description): Don't crash if symbol name contains more
2469 than MAX_ALLOCA bytes.
2470 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2471 (get_minibuffer): Arg is now EMACS_INT, not int.
2472 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2473 (esprintf, exprintf, evxprintf): New decls.
2474 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2476 * dbusbind.c (signature_cat): New function.
2477 (xd_signature, Fdbus_register_signal):
2478 Do not overrun buffer; instead, report string overflow.
2480 * dispnew.c (add_window_display_history): Don't overrun buffer.
2481 Truncate instead; this is OK since it's just a log.
2483 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2484 even if the time zone offset is outlandishly large.
2485 Don't mishandle offset == INT_MIN.
2487 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2488 when creating daemon; the previous buffer-overflow check was incorrect.
2490 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2491 which has the guts of the old verror function.
2493 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2494 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2496 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2497 (font_unparse_xlfd): Don't blindly alloca long strings.
2498 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2499 fits in int, when using sprintf. Use single snprintf to count
2500 length of string rather than counting it via multiple sprintfs;
2501 that's simpler and more reliable.
2502 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2503 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2504 sprintf, in case result does not fit in int.
2506 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2507 (fontset_from_font): Print it.
2509 * frame.c (tty_frame_count): Now printmax_t, not int.
2510 (make_terminal_frame, set_term_frame_name): Print it.
2511 (x_report_frame_params): In X, window IDs are unsigned long,
2512 not signed long, so print them as unsigned.
2513 (validate_x_resource_name): Check for implausibly long names,
2514 and don't assume name length fits in 'int'.
2515 (x_get_resource_string): Don't blindly alloca invocation name;
2516 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2519 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2520 (xg_check_special_colors, xg_set_geometry):
2521 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2523 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2524 Use esprintf, not sprintf, in case result does not fit in int.
2526 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2527 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2528 it as a large positive number.
2529 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2530 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2532 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2533 in case result does not fit in int.
2535 * print.c (float_to_string): Detect width overflow more reliably.
2536 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2537 buffer overrun. Don't assume list length fits in 'int'. Treat
2538 print length of 0 as 0, not as infinity; to be consistent with other
2539 uses of print length in this function. Don't overflow print length
2540 index. Don't assume hash table size fits in 'long', or that
2541 vectorlike size fits in 'unsigned long'.
2543 * process.c (make_process): Use printmax_t, not int, to format
2544 process-name gensyms.
2546 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2548 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2549 to avoid potential buffer overrun.
2551 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2552 if X resource line is longer than 512 bytes.
2554 * xfns.c (x_window): Make sprintf buffer a bit bigger
2555 to avoid potential buffer overrun.
2557 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2559 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2561 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2563 Integer overflow fixes for scrolling, etc.
2564 Without these, Emacs silently mishandles large integers sometimes.
2565 For example, "C-u 4294967297 M-x recenter" was treated as if
2566 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2568 * xdisp.c (try_window_id): Check Emacs fixnum range before
2569 converting to 'int'.
2571 * window.c (window_scroll_line_based, Frecenter):
2572 Check that an Emacs fixnum is in range before assigning it to 'int'.
2573 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2574 values converted from Emacs fixnums.
2575 (Frecenter): Don't wrap around a line count if it is out of 'int'
2576 range; instead, treat it as an extreme value.
2577 (Fset_window_configuration, compare_window_configurations):
2578 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2580 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2581 that can exceed INT_MAX. Check that EMACS_INT value is in range
2582 before assigning it to the (possibly-narrower) index.
2583 (match_limit): Don't assume that a fixnum can fit in 'int'.
2585 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2588 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2589 (Fvertical_motion): Don't wrap around LINES values that don't fit
2590 in 'int'. Instead, treat them as extreme values. This is good
2591 enough for windows, which can't have more than INT_MAX lines anyway.
2593 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2595 * Require libxml/parser.h to avoid compilation warning.
2597 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2599 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2600 since this reportedly can destroy thread storage.
2602 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2604 * syntax.c (find_defun_start): Update all cache variables if
2605 exiting early (Bug#9401).
2607 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2609 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2611 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2612 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2613 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2615 * term.c (tty_append_glyph): New function.
2616 (produce_stretch_glyph): Static function and its prototype deleted.
2618 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2621 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2623 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2624 when checking :margin (Bug#9390).
2625 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2626 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2627 so that the name doesn't mislead. All uses changed.
2629 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2631 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2634 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2636 * xdisp.c (move_it_to): Don't bail out early when reaching
2637 position beyond to_charpos, if we are scanning backwards.
2638 (move_it_vertically_backward): When DY == 0, make sure we get to
2639 the first character in the line after the newline.
2641 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2643 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2644 (ccl_driver): Do not generate an out-of-range pointer.
2645 (Fccl_execute_on_string): Remove unnecessary check for
2646 integer overflow, noted by Stefan Monnier in
2647 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2648 Remove a FIXME that didn't need fixing.
2649 Simplify the newly-introduced buffer reallocation code.
2651 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2653 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2655 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2657 Integer and memory overflow issues (Bug#9196).
2659 * doc.c (get_doc_string): Rework so that
2660 get_doc_string_buffer_size is the actual buffer size, rather than
2661 being 1 less than the actual buffer size; this makes xpalloc more
2664 * image.c (x_allocate_bitmap_record, cache_image):
2665 * xselect.c (Fx_register_dnd_atom):
2666 Simplify previous changes by using xpalloc.
2668 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2669 since either will do and ptrdiff_t is convenient with xpalloc.
2671 * charset.c (charset_table_size)
2672 (struct charset_sort_data.priority): Now ptrdiff_t.
2673 (charset_compare): Don't overflow if priorities differ greatly.
2674 (Fsort_charsets): Don't assume list length fits in int.
2675 Check for size-calculation overflow when allocating sort data.
2676 (syms_of_charset): Allocate an initial charset table that is
2677 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2679 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2681 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2682 The actual value is always <= INT_MAX, and leaving it unsigned made
2683 overflow checking harder.
2685 * dispextern.h (struct glyph_matrix.rows_allocated)
2686 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2687 with xpalloc. The values are still always <= INT_MAX.
2689 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2691 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2692 (SAFE_NALLOCA): New macro.
2694 * region-cache.c (struct boundary.pos, find_cache_boundary)
2695 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2696 (set_cache_region, invalidate_region_cache)
2697 (revalidate_region_cache, know_region_cache, region_cache_forward)
2698 (region_cache_backward, pp_cache):
2699 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2700 so that ptrdiff_t * can be passed to xpalloc.
2701 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2702 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2703 (pp_cache): Don't assume cache_len fits in int.
2704 * region-cache.h: Adjust extern decls to match.
2706 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2707 EMACS_INT, since either will do, for xpalloc.
2709 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2710 (xnmalloc, xnrealloc, xpalloc): New functions.
2712 * bidi.c (bidi_shelve_header_size): New constant.
2713 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2714 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2716 * bidi.c (bidi_cache_shrink):
2717 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2719 Don't update size of array until after memory allocation succeeds,
2720 because xmalloc/xrealloc may not return.
2721 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2722 now that we have proper integer overflow checking.
2723 (record_overlay_string, overlay_strings): Catch overflows when
2724 calculating size of overlay_str_buf.
2726 * callproc.c (Fcall_process): Check for size overflow when
2727 calculating size of args2.
2728 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2729 Normally we prefer signed values, but sticking with ptrdiff_t would
2730 require adding more-complicated checks.
2732 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2733 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2734 Redo buffer-overflow calculations to avoid integer overflow.
2735 Add a FIXME comment where memory seems to be over-allocated.
2737 * character.c (Fstring): Check for size-calculation overflow.
2739 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2740 unnecessary integer overflow. Check for size overflow.
2741 (encode_coding_object): Don't update size until xmalloc succeeds.
2743 * composite.c (get_composition_id): Check for overflow in glyph
2744 length calculations.
2746 Integer and memory overflow fixes for display code.
2747 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2748 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2749 (scrolling_window): Check for overflow in size calculations.
2750 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2751 Don't assume glyph table len fits in int.
2752 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2753 (row_table_size): Now ptrdiff_t, not int.
2754 (scrolling_window): Avoid overflow in size calculations.
2755 Don't update size until allocation succeeds.
2756 * fns.c (concat): Check for overflow in size calculations.
2757 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2758 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2759 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2761 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2762 (get_doc_string): Check for size calculation overflow.
2763 Don't update size until allocation succeeds.
2764 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2765 EMACS_INT, where ptrdiff_t will do.
2766 (Fsubstitute_command_keys): Check for string overflow.
2768 * editfns.c (set_time_zone_rule): Don't assume environment length
2770 (message_length): Now ptrdiff_t, not int.
2771 (Fmessage_box): Don't update size until allocation succeeds.
2772 Don't assume message length fits in int.
2773 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2775 * emacs.c (main): Do not reallocate argv, since there is a null at
2776 the end that can be overwritten, and this way there's no need to
2777 worry about size-calculation overflow.
2778 (sort_args): Check for size-calculation overflow.
2780 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2782 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2784 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2785 (x_set_scroll_bar_width, x_figure_window_size):
2786 Check for integer overflow.
2787 (x_set_alpha): Do not assume XINT fits in int.
2789 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2790 This is for the members text_lines, text_cols, total_lines, total_cols,
2791 where the system imposes an 'int' limit.
2793 * fringe.c (Fdefine_fringe_bitmap):
2794 Don't update size until alloc works.
2796 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2797 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2799 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2800 Check for size-calculation overflow.
2801 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2802 do, as we prefer signed integers.
2803 (id_to_widget.max_size, id_to_widget.used)
2804 (xg_store_widget_in_map, xg_remove_widget_from_map)
2805 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2806 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2807 Use and return ptrdiff_t, not int.
2808 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2809 * gtkutil.h: Change prototypes to match the above.
2811 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2812 are duplicate now that they've been promoted to lisp.h.
2813 (x_allocate_bitmap_record, x_alloc_image_color)
2814 (make_image_cache, cache_image, xpm_load):
2815 Don't update size until alloc is done.
2816 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2818 Check for size calculation overflow.
2819 (ct_colors_allocated_max): New constant.
2820 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2823 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2824 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2825 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2826 Use ptrdiff_t, not int, to count maps.
2827 (read_char_minibuf_menu_prompt): Check for overflow in size
2828 calculations. Don't update size until allocation succeeds.
2829 Redo calculations to avoid overflow.
2830 * keyboard.h: Change prototypes to match the above.
2832 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2834 (current_minor_maps): Check for size calculation overflow.
2835 * keymap.h: Change prototypes to match the above.
2837 * lread.c (read1, init_obarray): Don't update size until alloc done.
2839 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2840 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2842 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2843 Now ptrdiff_t, not int.
2844 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2845 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2847 * process.c (Fnetwork_interface_list): Check for overflow
2848 in size calculation.
2850 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2852 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2853 overflow. Don't bother calling xmalloc when xrealloc will do.
2855 * search.c (Freplace_match): Check for size calculation overflow.
2856 (Fset_match_data): Don't assume list lengths fit in 'int'.
2858 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2859 for command line length. Do not attempt to address one before the
2860 beginning of an array, as that's not portable.
2862 * term.c (max_frame_lines): Remove; unused.
2863 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2865 (encode_terminal_code, calculate_costs): Check for size
2866 calculation overflow.
2867 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2868 table lengths and related sizes. Don't update size until alloc
2869 done. Redo calculations to avoid overflow.
2870 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2872 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2873 subtracting pointers.
2874 (gobble_line): Check for overflow more carefully. Don't update size
2877 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2878 Don't update size until alloc done.
2879 Redo size calculations to avoid overflow.
2880 Check for size calculation overflow.
2881 (main) [DEBUG]: Fix typo in invoking tparam1.
2883 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2884 Use ptrdiff_t, not int, for sizes.
2885 (store_mode_line_noprop_char): Don't update size until alloc done.
2887 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2888 Use ptrdiff_t, not int, for sizes.
2889 (Finternal_make_lisp_face, cache_face):
2890 Check for size calculation overflow.
2891 (cache_face): Treat size calculation overflows as if they were
2892 memory exhaustion (the usual treatment), rather than aborting.
2894 * xfns.c (x_encode_text, x_set_name_internal)
2895 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2896 sizes, since they can exceed INT_MAX in size. Check for size
2897 calculation overflow.
2899 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2900 (xg_select): Check for size calculation overflow.
2901 Don't update size until alloc done.
2903 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2904 as sprintf is limited to int lengths.
2906 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2907 (X_LONG_MIN): New macros.
2908 Use them to make the following changes clearer.
2909 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2910 This change doesn't affect the value now, but it may help remind
2911 future maintainers not to raise the value too much later.
2912 (SELECTION_QUANTUM): Remove, replacing with ...
2913 (selection_quantum): ... new function, which avoids overflow.
2915 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2916 assumption that selection length fits in 'int'.
2917 (x_reply_selection_request, x_handle_selection_request)
2918 (x_get_window_property, receive_incremental_selection)
2919 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2920 (lisp_data_to_selection_data, clean_local_selection_data):
2921 Use ptrdiff_t, not int, to record length of selection.
2922 (x_reply_selection_request, x_get_window_property)
2923 (receive_incremental_selection, x_property_data_to_lisp):
2924 Redo calculations to avoid overflow.
2925 (x_reply_selection_request): When sending hint, ceiling it at
2926 X_LONG_MAX rather than relying on wraparound overflow to send
2928 (x_get_window_property, receive_incremental_selection)
2929 (lisp_data_to_selection_data, x_property_data_to_lisp):
2930 Check for size-calculation overflow.
2931 (x_get_window_property, receive_incremental_selection)
2932 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2933 Don't store size until memory allocation succeeds.
2934 (x_get_window_property): Plug memory leak on memory exhaustion.
2935 Don't double-block input; malloc is safe here. Don't assume 2**34
2936 - 4 fits in unsigned long. Add an xassert to check
2937 XGetWindowProperty overflow. Be more careful about overflow
2938 calculations, and distinguish size from memory overflow better.
2939 (receive_incremental_selection): When tracing, don't assume
2940 unsigned int is less than INT_MAX.
2941 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2942 harmful) conversions of unsigned short to int.
2943 (lisp_data_to_selection_data): Don't assume that integers
2944 in the range -65535 through -1 fit in an X unsigned short.
2945 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2946 result parameters unless successful. Rely on cons_to_unsigned
2947 to report problems with elements; the old code wasn't right anyway.
2948 (x_check_property_data): Check for int overflow; we cannot use
2949 a wider type due to X limits.
2950 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2952 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2954 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2955 (x_term_init): Check for size calculation overflow.
2956 (x_color_cells): Don't store size until memory allocation succeeds.
2957 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2958 Don't assume alloca size is less than MAX_ALLOCA.
2959 (x_term_init): Don't assume length fits in int (sprintf is limited
2962 Use ptrdiff_t for composition IDs.
2963 * character.c (lisp_string_width):
2964 * composite.c (composition_table_size, n_compositions)
2965 (get_composition_id, composition_gstring_from_id):
2966 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2967 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2968 * window.c (Frecenter):
2969 Use ptrdiff_t, not int, for composition IDs.
2970 * composite.c (get_composition_id): Check for integer overflow.
2971 * composite.h: Adjust prototypes to match the above changes.
2973 Use ptrdiff_t for hash table indexes.
2974 * category.c (hash_get_category_set):
2975 * ccl.c (ccl_driver):
2976 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2977 * coding.c (coding_system_charset_list, detect_coding_system):
2978 * coding.h (struct coding_system.id):
2979 * composite.c (get_composition_id, gstring_lookup_cache):
2980 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2981 * image.c (xpm_get_color_table_h):
2982 * lisp.h (hash_lookup, hash_put):
2983 * minibuf.c (Ftest_completion):
2984 Use ptrdiff_t for hash table indexes, not int (which is too
2985 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2986 32-bit --with-wide-int hosts).
2988 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2989 Add a FIXME comment about memory leaks.
2990 (syms_of_charset): Don't assume xmalloc returns.
2992 Don't assume that stated character widths fit in int.
2993 * character.c (Fchar_width, c_string_width, lisp_string_width):
2994 * character.h (CHAR_WIDTH):
2995 * indent.c (MULTIBYTE_BYTES_WIDTH):
2996 Use sanitize_char_width to avoid undefined and/or bad behavior
2997 with outlandish widths.
2998 * character.h (sanitize_tab_width): Rename from sanitize_width,
2999 now that we have two such functions. All uses changed.
3000 (sanitize_char_width): New inline function.
3002 Don't assume that tab-width fits in int.
3003 * character.h (sanitize_width): New inline function.
3004 (SANE_TAB_WIDTH): New macro.
3005 (ASCII_CHAR_WIDTH): Use it.
3006 * indent.c (sane_tab_width): Remove. All uses replaced by
3007 SANE_TAB_WIDTH (current_buffer).
3008 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3010 * fileio.c: Integer overflow issues with file modes.
3011 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3013 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3014 Remove unreachable code.
3015 (read_hex, load_charset_map_from_file): Check for integer overflow.
3017 * xterm.c: Don't go over XClientMessageEvent limit.
3018 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3019 (x_send_scroll_bar_event): Likewise. Check that the size does not
3020 exceed limits imposed by XClientMessageEvent, as well as the usual
3021 ptrdiff_t and size_t limits.
3023 * keyboard.c: Overflow, signedness and related fixes.
3024 (make_lispy_movement): Use same integer type in forward decl
3025 that is used in the definition.
3026 (read_key_sequence, keyremap_step):
3027 Change bufsize argument back to int, undoing my 2011-03-30 change.
3028 We prefer signed types, and int is wide enough here.
3029 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3030 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3031 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3032 length, not size_t. Use ptrdiff_t for index, not int.
3033 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3034 possibility of integer overflow.
3036 Overflow, signedness and related fixes for images.
3038 * dispextern.h (struct it.stack[0].u.image.image_id)
3039 (struct_it.image_id, struct image.id, struct image_cache.size)
3040 (struct image_cache.used, struct image_cache.ref_count):
3041 * gtkutil.c (update_frame_tool_bar):
3042 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3043 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3044 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3045 * nsmenu.m (update_frame_tool_bar):
3046 * xdisp.c (calc_pixel_width_or_height):
3047 * xfns.c (image_cache_refcount):
3048 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3049 on typical 64-bit hosts.
3051 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3052 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3053 Omit unnecessary casts to int.
3054 (parse_image_spec): Check that integers fall into 'int' range
3055 when the callers expect that.
3056 (image_ascent): Redo ascent calculation to avoid int overflow.
3057 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3058 (lookup_image): Remove unnecessary tests.
3059 (xbm_image_p): Locals are now of int, not EMACS_INT,
3060 since parse_image_check makes sure they fit into int.
3061 (png_load, gif_load, svg_load_image):
3062 Prefer int to unsigned where either will do.
3063 (tiff_handler): New function, combining the cores of the
3064 old tiff_error_handler and tiff_warning_handler.
3065 This function is rewritten to use vsnprintf and thereby avoid
3066 stack buffer overflows. It uses only the features of vsnprintf
3067 that are common to both POSIX and native Microsoft.
3068 (tiff_error_handler, tiff_warning_handler): Use it.
3069 (tiff_load, gif_load, imagemagick_load_image):
3070 Don't assume :index value fits in 'int'.
3071 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3072 (imagemagick_load_image): Check that crop parameters fit into
3073 the integer types that MagickCropImage accepts. Don't assume
3074 Vimagemagick_render_type has a nonnegative value. Don't assume
3075 size_t fits in 'long'.
3076 (gs_load): Use printmax_t to print the widest integers possible.
3077 Check for integer overflow when computing image height and width.
3079 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3081 * xdisp.c (redisplay_window): Don't force window start if point
3082 will be invisible in the resulting window. (Bug#9324)
3084 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3086 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3087 the display spec is of the form `(space ...)'.
3088 (handle_display_spec): Return the value returned by
3089 handle_single_display_spec, not just 1 or zero.
3090 (handle_single_display_spec): If the display spec is of the form
3091 `(space ...)', and specifies display in the text area, return 2
3093 (try_cursor_movement): Check for the need to scroll more
3094 accurately, and prefer exact match for point under bidi.
3095 Don't advance `row' beyond the last row of the window.
3097 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3098 into disp_prop; all users changed.
3100 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3101 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3102 for the text covered by the display property.
3104 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3106 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3107 Change return value to nil.
3108 (Frecord_buffer): Delete unused function.
3110 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3112 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3113 buffers, return left-to-right.
3114 (set_cursor_from_row): Consider candidate row a win if its glyph
3115 represents a newline and point is on that newline. Fixes cursor
3116 positioning on the newline at EOL of R2L text within L2R
3117 paragraph, and vice versa.
3118 (try_cursor_movement): Check continued rows, in addition to
3119 continuation rows. Fixes unwarranted scroll when point enters a
3120 continued line of R2L text within an L2R paragraph, or vice versa.
3121 (cursor_row_p): Consider the case of point being equal to
3122 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3123 from the end of a short line to the beginning of a continued line
3124 of R2L text within L2R paragraph.
3125 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3126 composed characters.
3128 * bidi.c (bidi_check_type): Use xassert.
3129 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3132 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3134 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3137 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3139 * nsfont.m (ns_otf_to_script): Fix typo.
3141 2011-08-22 Kenichi Handa <handa@m17n.org>
3143 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3144 extra slot even if the purpose is char-code-property-table.
3146 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3148 * xdisp.c (redisplay_window): When computing centering_position,
3149 account for the height of the header line. (Bug#8874)
3151 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3152 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3153 candidate is selected by the mouse, and that candidate has a
3154 composed character under the mouse.
3156 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3157 coordinates reported by pos-visible-in-window-p for a composed
3158 character in column zero.
3160 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3162 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3164 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3166 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3167 consider it a hit if to_charpos is anywhere in the range of the
3168 composed buffer positions.
3170 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3172 * image.c (gif_load): Don't assume that each subimage has the same
3173 dimensions as the base image. Handle disposal method that is
3174 "undefined" by the gif spec (Bug#9335).
3176 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3178 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3179 (Fcondition_case): Document `debug' symbol in error handler.
3181 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3183 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3184 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3185 from an Org mode buffer to a Speedbar frame.
3187 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3188 a composition, take its buffer position from IT->cmp_it.charpos.
3189 Fixes cursor positioning at the beginning of a line that begins
3190 with a composed character.
3192 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3194 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3195 character bidirectional type, use STRONG_L instead. Fixes crashes
3196 in a buffer produced by `describe-categories'.
3198 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3199 members before the level stack, so they would be saved and
3200 restored when copying iterator state. Fixes incorrect reordering
3201 around TABs covered by display properties.
3203 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3205 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3207 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3209 * eval.c (internal_condition_case, internal_condition_case_1)
3210 (internal_condition_case_2, internal_condition_case_n):
3211 Remove unnecessary aborts (Bug#9081).
3213 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3215 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3216 has no `load' handler, try opening the file locally. (Bug#9311)
3218 2011-08-16 Ken Brown <kbrown@cornell.edu>
3220 * gmalloc.c: Expand comment.
3222 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3224 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3225 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3227 2011-08-16 Ken Brown <kbrown@cornell.edu>
3229 Fix memory allocation problems in Cygwin build (Bug#9273).
3231 * unexcw.c ( __malloc_initialized): Declare external variable.
3232 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3234 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3236 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3238 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3240 [CYGWIN] (special_realloc): New function.
3241 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3242 requests to realloc storage in the static heap.
3244 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3246 * bidi.c (bidi_initialize): Remove unused local.
3248 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3251 * biditype.h: Remove file.
3252 * makefile.w32-in ($(BLD)/bidi.$(O)):
3253 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3255 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3257 * chartab.c: Improve commentary for the uniprop_table API.
3259 * bidi.c (bidi_paragraph_init): Support zero value of
3260 bidi_ignore_explicit_marks_for_paragraph_level.
3261 (bidi_initialize): Use uniprop_table instead of including
3262 biditype.h and bidimirror.h.
3264 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3265 coordinates of the iterator when restoring from ppos_it.
3268 2011-08-14 Kenichi Handa <handa@m17n.org>
3270 * process.c (create_process): Call setup_process_coding_systems
3271 after the pid of the process is set to -1 (Bug#8162).
3273 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3275 * xdisp.c (move_it_in_display_line_to): Don't invoke
3276 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3277 ppos_it. Fixes vertical cursor motion when line beginning is
3278 covered by an image. (Bug#9296)
3280 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3282 * nsterm.h (ns_run_ascript): Declare.
3283 (NSAPP_DATA2_RUNASSCRIPT): Define.
3285 * nsfns.m (as_script, as_result, as_status): New static variables.
3286 (ns_run_ascript): New function.
3287 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3288 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3289 the event loop. Get status from as_status (Bug#7276).
3291 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3292 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3293 the event loop (Bug#7276).
3295 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3297 * gnutls.c (QCgnutls_bootprop_priority)
3298 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3299 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3300 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3301 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3302 (QCgnutls_bootprop_verify_hostname_error)
3303 (QCgnutls_bootprop_callbacks_verify): Rename from
3304 Qgnutls_bootprop_..., all uses changed.
3306 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3309 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3311 * xfaces.c (Qframe_set_background_mode): Now static.
3312 * dispextern.h (Qframe_set_background_mode): Remove decl.
3314 * process.c (Fnetwork_interface_info): Declare local only if needed.
3316 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3318 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3319 (Fnetwork_interface_list): Allocate in increments of bytes instead
3320 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3321 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3323 (struct ifflag_def): notrailers is smart on OSX.
3324 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3325 Get hardware address with getifaddrs if available.
3327 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3329 * xdisp.c (iterate_out_of_display_property): xassert that
3330 IT->position is set to within IT->object's boundaries. Break from
3331 the loop as soon as EOB is reached; avoids infloops in redisplay
3332 when IT->position is set up wrongly due to some bug.
3333 Set IT->current to match the bidi iterator unconditionally.
3334 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3335 entry. Force push_it to save on the stack the current
3336 buffer/string position, to be restored by pop_it. Fix flags in
3337 the iterator structure wrt the object coming from a display
3338 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3339 properties. (Bug#9284)
3341 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3343 * fontset.c (fontset_get_font_group): Add proper type checks.
3346 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3348 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3349 and LC_VERSION_MIN_MACOSX.
3350 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3351 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3353 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (forward_to_next_line_start): Allow to use the
3356 no-display-properties-and-no-overlays under bidi display.
3357 Set disp_pos in the bidi iterator to avoid searches for display
3358 properties and overlays.
3360 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3362 * editfns.c (Fset_time_zone_rule): Document relationship with the
3365 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3366 the font entity extracted from the cache (Bug#8109).
3368 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3370 * composite.c (autocmp_chars): Don't reset point. That is done by
3371 restore_point_unwind (Bug#5984).
3373 2011-08-07 Juri Linkov <juri@jurta.org>
3375 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3376 to show the arg `TIME' instead of `TIMEVAL'.
3378 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3380 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3381 display property strides EOL and includes a newline, as in
3382 longlines-mode. (Bug#9254)
3383 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3384 word-wrap under bidirectional display. (Bug#9224)
3386 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3387 is non-zero, even if the data buffer is NULL. Fixes a crash in
3388 vertical-motion with longlines-mode. (Bug#9254)
3390 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3392 * bidi.c <bidi_cache_total_alloc>: Now static.
3393 (bidi_initialize): Initialize bidi_cache_total_alloc.
3395 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3398 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3399 amount allocated this far in `bidi_cache_total_alloc'.
3400 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3401 non-zero, only free the data buffer without restoring the cache
3402 contents. All callers changed.
3404 * dispextern.h (bidi_unshelve_cache): Update prototype.
3406 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3407 (move_it_in_display_line, move_it_to)
3408 (move_it_vertically_backward, move_it_by_lines): Replace the call
3409 to xfree to an equivalent call to bidi_unshelve_cache.
3410 (move_it_in_display_line_to): Fix logic of returning
3411 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3413 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3415 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3416 came from a string character with a `cursor' property. (Bug#9229)
3418 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3420 * Makefile.in (LIB_PTHREAD): New variable.
3421 (LIBES): Add LIB_PTHREAD (Bug#9216).
3423 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3424 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3426 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3428 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3430 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3432 * xterm.c (x_find_topmost_parent): New function.
3433 (x_set_frame_alpha): Find topmost parent window with
3434 x_find_topmost_parent and set the property there also (bug#9181).
3435 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3437 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3439 * callproc.c (Fcall_process): Avoid vfork clobbering
3440 the local vars buffer, coding_systems, current_dir.
3442 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3444 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3446 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3448 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3449 so that it is not optimized away.
3451 * xdisp.c (compute_display_string_pos): Remove unused local.
3453 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3455 Fix slow cursor motion and scrolling in large buffers with
3456 selective display, like Org Mode buffers. (Bug#9218)
3458 * dispextern.h (struct bidi_it): New member disp_prop_p.
3460 * xdisp.c: Remove one-slot cache of display string positions.
3461 (compute_display_string_pos): Accept an additional argument
3462 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3463 for a display string or property. If found, set DISP_PROP_P
3466 * bidi.c (bidi_fetch_char): Accept an additional argument
3467 DISP_PROP_P, and pass it to compute_display_string_pos.
3468 Only handle text covered by a display string if DISP_PROP_P is returned
3469 non-zero. All callers of bidi_fetch_char changed.
3471 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3473 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3475 2010-12-03 Don March <don@ohspite.net>
3477 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3478 last character M-[char] is translated to ESC [char] (bug#7541).
3480 2011-08-02 Kenichi Handa <handa@m17n.org>
3482 * lisp.h (uniprop_table): Extern it.
3484 * chartab.c (uniprop_table): Make it non-static.
3486 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3488 * xdisp.c (forward_to_next_line_start): Accept additional argument
3489 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3491 (reseat_at_next_visible_line_start): Use the bidi iterator state
3492 returned by forward_to_next_line_start to restore the state of
3493 it->bidi_it after backing up to previous newline. (Bug#9212)
3495 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3497 * regex.c (re_comp): Protoize.
3498 (re_exec): Fix return type.
3499 (regexec): Fix type of `ret'. (Bug#9203)
3501 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3503 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3504 This is needed if max-image-size is a floating-point number.
3506 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3508 * print.c (print_object): Print empty symbol as ##.
3510 * lread.c (read1): Read ## as empty symbol.
3512 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3514 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3515 setting frame foreground color (Bug#9175).
3516 (x_set_background_color): Likewise.
3518 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3519 contents (Bug#9176).
3520 (EmacsTooltip -init): Remove bezels and add shadows to
3523 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3524 or scroll bar (Bug#8470).
3526 * nsfont.m (nsfont_open): Remove assignment to voffset and
3527 unnecessary vars hshink, expand, hd, full_height, min_height.
3528 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3530 * nsterm.h (nsfont_info): Remove voffset field.
3532 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3534 Implement strike-through and overline on NextStep (Bug#8863).
3536 * nsfont.m (nsfont_open): Use underline position provided by font,
3537 instead of hard-coded value of 2.
3538 (nsfont_draw): Call ns_draw_text_decoration instead.
3540 * nsterm.h: Add declaration for ns_draw_text_decoration.
3542 * nsterm.m (ns_draw_text_decoration): New function for drawing
3543 underline, overline, and strike-through.
3544 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3545 ns_draw_text_decoration. Change treatment of cursor drawing to
3546 accommodate underlining, etc.
3548 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3550 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3553 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3555 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3556 Without this fix, if a signal arrives just after memory fills up,
3557 'malloc' might be invoked reentrantly.
3559 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3560 In other words, assume that every image size is allowed, on non-X
3561 hosts. This assumption is probably wrong, but it lets Emacs compile.
3563 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3565 * regex.c (re_iswctype): Convert return values to boolean.
3567 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3569 * xdisp.c (compute_display_string_pos): Don't use cached display
3570 string position if the buffer had its restriction changed.
3573 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3577 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3579 Integer signedness and overflow and related fixes. (Bug#9079)
3581 * bidi.c: Integer size and overflow fixes.
3582 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3583 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3584 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3585 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3586 (bidi_find_other_level_edge):
3587 Use ptrdiff_t instead of EMACS_INT where either will do.
3588 This works better on 32-bit hosts configured --with-wide-int.
3589 (bidi_cache_ensure_space): Check for size-calculation overflow.
3590 Use % rather than repeated addition, for better worst-case speed.
3591 Don't set bidi_cache_size until after xrealloc returns, because it
3593 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3594 (bidi_cache_ensure_space): Also check that the bidi cache size
3595 does not exceed that of the largest Lisp string or buffer. See Eli
3596 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3598 * alloc.c (__malloc_size_t): Remove.
3599 All uses replaced by size_t. See Andreas Schwab's note
3600 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3602 * image.c: Improve checking for integer overflow.
3603 (check_image_size): Assume that f is nonnull, since
3604 it is always nonnull in practice. This is one less thing to
3605 worry about when checking for integer overflow later.
3606 (x_check_image_size): New function, which checks for integer
3607 overflow issues inside X.
3608 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3609 This removes the need for a memory_full check.
3610 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3611 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3612 (xbm_read_bitmap_data): Change locals back to 'int', since
3613 their values must fit in 'int'.
3614 (xpm_load_image, png_load, tiff_load):
3615 Invoke x_create_x_image_and_pixmap earlier,
3616 to avoid much needless work if the image is too large.
3617 (tiff_load): Treat overly large images as if
3618 x_create_x_image_and_pixmap failed, not as malloc failures.
3619 (gs_load): Use x_check_image_size.
3621 * gtkutil.c: Omit integer casts.
3622 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3623 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3625 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3627 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3628 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3629 would wrongly return t on a 64-bit host.
3631 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3632 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3633 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3634 and therefore cause GCC to emit a bogus diagnostic in some cases.
3636 * image.c: Integer signedness and overflow and related fixes.
3637 This is not an exhaustive set of fixes, but it's time to
3638 record what I've got.
3639 (lookup_pixel_color, check_image_size): Remove redundant decls.
3640 (check_image_size): Don't assume that arbitrary EMACS_INT values
3641 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3642 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3643 (tiff_load, imagemagick_load_image):
3644 Check for overflow in size calculations.
3645 (x_create_x_image_and_pixmap): Remove unnecessary test for
3646 xmalloc returning NULL; that can't happen.
3647 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3648 (xpm_color_bucket): Use better integer hashing function.
3649 (xpm_cache_color): Don't possibly over-allocate memory.
3650 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3651 (gif_memory_source):
3652 Use ptrdiff_t, not int or size_t, to record sizes.
3653 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3654 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3655 either works, as we prefer signed integers.
3656 (tiff_read_from_memory, tiff_write_from_memory):
3657 Return tsize_t, not size_t, since that's what the TIFF API wants.
3658 (tiff_read_from_memory): Don't fail simply because the read would
3659 go past EOF; instead, return a short read.
3660 (tiff_load): Omit no-longer-needed casts.
3661 (Fimagemagick_types): Don't assume size fits into 'int'.
3663 Improve hashing quality when configured --with-wide-int.
3664 * fns.c (hash_string): New function, taken from sxhash_string.
3665 Do not discard information about ASCII character case; this
3666 discarding is no longer needed.
3667 (sxhash-string): Use it. Change sig to match it. Caller changed.
3668 * lisp.h: Declare it.
3669 * lread.c (hash_string): Remove, since we now use fns.c's version.
3670 The fns.c version returns a wider integer if --with-wide-int is
3671 specified, so this should help the quality of the hashing a bit.
3673 * emacs.c: Integer overflow minor fix.
3674 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3675 Define only if GNU_LINUX.
3676 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3678 * dispnew.c: Integer signedness and overflow fixes.
3679 Remove unnecessary forward decls, that were a maintenance hassle.
3680 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3682 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3683 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3684 (prepare_desired_row, line_draw_cost):
3685 Use int, not unsigned, where either works.
3686 (save_current_matrix, restore_current_matrix):
3687 Use ptrdiff_t, not size_t, where either works.
3688 (init_display): Check for overflow more accurately, and without
3689 relying on undefined behavior.
3691 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3692 Remove, replacing with the new symbols in lisp.h. All uses changed.
3693 * fileio.c (make_temp_name):
3694 * filelock.c (lock_file_1, lock_file):
3695 * xdisp.c (message_dolog):
3696 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3697 Use pMd etc. instead.
3698 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3699 replacing the pWIDE etc. symbols removed from editfns.c.
3701 * keyboard.h (num_input_events): Now uintmax_t.
3702 This is (very slightly) less likely to mess up due to wraparound.
3705 * buffer.c: Integer signedness fixes.
3706 (alloc_buffer_text, enlarge_buffer_text):
3707 Use ptrdiff_t rather than size_t when either will do, as we prefer
3710 * alloc.c: Integer signedness and overflow fixes.
3711 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3712 (__malloc_size_t): Default to size_t, not to int.
3713 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3714 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3715 Prefer ptrdiff_t to size_t when either would do, as we prefer
3717 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3718 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3719 Now const. Initialize with values that are in range even if char
3721 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3722 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3723 These functions do the right thing with sizes > 2**32.
3724 (check_depth): Now ptrdiff_t, not int.
3725 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3726 Adjust to new way of storing sizes. Check for size overflow bugs
3728 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3729 slightly wrong anyway, as it missed one instance of
3730 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3731 (refill_memory_reserve): Omit needless cast to size_t.
3732 (mark_object_loop_halt): Mark as externally visible.
3734 * xselect.c: Integer signedness and overflow fixes.
3735 (Fx_register_dnd_atom, x_handle_dnd_message):
3736 Use ptrdiff_t, not size_t, since we prefer signed.
3737 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3738 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3739 x_dnd_atoms_size and x_dnd_atoms_length.
3741 * doprnt.c: Prefer signed to unsigned when either works.
3743 * doprnt.c (doprnt):
3745 * xdisp.c (vmessage):
3746 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3747 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3748 prefer signed arithmetic to avoid comparison confusion.
3749 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3750 but is a bit tricky.
3752 Assume freestanding C89 headers, string.h, stdlib.h.
3753 * data.c, doprnt.c, floatfns.c, print.c:
3754 Include float.h unconditionally.
3755 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3756 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3757 * regex.c: Likewise for stddef.h, string.h.
3758 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3759 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3760 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3761 (STDC_HEADERS): Remove obsolete defines.
3762 * sysdep.c: Include limits.h unconditionally.
3764 Assume support for memcmp, memcpy, memmove, memset.
3765 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3766 * regex.c (memcmp, memcpy):
3767 Remove; we assume C89 now.
3769 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3770 (__malloc_safe_bcopy): Remove; no longer needed.
3772 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3773 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3774 well either way, and we prefer signed to unsigned.
3776 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3778 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3779 closes the connection while we're reading (bug#9182).
3781 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3783 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3784 are specified (Bug#9168).
3786 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3788 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3789 Found by GCC static checking and --with-wide-int on a 32-bit host.
3791 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3793 * xdisp.c (compute_display_string_pos): Fix logic of caching
3794 previous display string position. Initialize cached_prev_pos to
3795 -1. Fixes slow-down at the beginning of a buffer.
3797 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3799 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3800 for attrs[LFACE_FONTSET_INDEX].
3802 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3804 * xml.c (parse_region): Remove unused local
3805 that was recently introduced.
3807 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3809 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3810 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3812 * xdisp.c (move_it_in_display_line_to): Record the best matching
3813 position for TO_CHARPOS while scanning the line, and restore it on
3814 exit if none of the characters scanned was an exact match.
3815 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3816 when exact match is impossible due to invisible text, and the
3817 lines are truncated.
3819 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3821 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3824 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3826 Fix a significant slow-down of cursor motion with C-n, C-p,
3827 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3828 auto-repeat under bidi redisplay in fontified buffers.
3829 * xdisp.c (compute_stop_pos_backwards): New function.
3830 (next_element_from_buffer): Call compute_stop_pos_backwards to
3831 find a suitable prev_stop when we find ourselves before
3833 (reseat): Don't look for prev_stop, as that could mean a very long
3835 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3836 <cached_disp_overlay_modiff>: Cache for last found display string
3838 (compute_display_string_pos): Return the cached position if asked
3839 about the same buffer in the same area of character positions, and
3840 the buffer wasn't changed since the time the display string
3841 position was cached.
3843 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3845 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3846 is an integer, which is important for empty lines. (Bug#9149)
3848 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3850 * frame.c (Fmodify_frame_parameters): In tty case, update the
3851 default face if necessary (Bug#4238).
3853 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3855 * editfns.c (Fstring_to_char): No need to explain what a character
3856 is in the docstring (Bug#6576).
3858 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3860 * xml.c (parse_region): Make sure we always return a tree.
3862 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3864 * xml.c (parse_region): If a document contains only comments,
3867 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869 * xml.c (make_dom): Return comments, too.
3871 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3874 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3875 and the surrounding thread.
3876 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3877 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3878 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3880 * s/openbsd.h (BROKEN_SIGIO): Define.
3881 * unexelf.c (unexec) [__OpenBSD__]:
3882 Don't update the .mdebug section of the Alpha COFF symbol table.
3884 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3886 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3889 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3891 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3892 This fixes some race conditions on the permissions of any newly
3895 * alloc.c (valid_pointer_p): Use pipe, not open.
3896 This fixes some permissions issues when debugging.
3898 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3899 If fchown fails to set both uid and gid, try to set just gid,
3900 as that is sometimes allowed. Adjust the file's mode to eliminate
3901 setuid or setgid bits that are inappropriate if fchown fails.
3903 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3905 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3906 to compare Lisp_Objects.
3907 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3908 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3909 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3911 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3913 * lread.c (read_integer): Unread even EOF character.
3914 (read1): Likewise. Properly record start position of symbol.
3916 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3917 symbol character follows.
3919 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3921 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3922 This works around a problem with the previous change to Fcopy_file.
3923 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3924 and without this change, GCC might complain about discarding
3925 fchown's return value.
3927 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3929 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3931 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3933 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3935 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3937 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3938 it's used from the C level.
3940 * process.c: Use the same condition for POLL_FOR_INPUT in both
3941 keyboard.c and process.c (bug#1858).
3943 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3945 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3946 (Fgnutls_boot): Use it.
3948 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3950 * doc.c (Fsubstitute_command_keys): Revert last change.
3952 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3955 quotes the next character, and doesn't affect other longer
3956 sequences (bug#8935).
3958 * lread.c (syms_of_lread): Clarify that is isn't only
3959 `eval-buffer' and `eval-defun' that's affected by
3960 `lexical-binding' (bug#8460).
3962 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3964 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3965 bidi redisplay when a line includes both an image and is truncated.
3967 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3969 Fix minor problems found by static checking.
3970 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3971 (elsz): Now a signed constant, not a size_t var. We prefer signed
3972 types to unsigned, to avoid integer comparison confusion. Without
3973 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3974 "cannot optimize loop, the loop counter may overflow", a symptom
3976 * indent.c (Fvertical_motion): Mark locals as initialized.
3977 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3979 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3981 * search.c (Fre_search_backward): Mention `case-fold-search' in
3982 all the re_search_* functions (bug#8138).
3984 * keyboard.c (Fopen_dribble_file): Document when the file is
3987 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3989 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3992 Support bidi reordering of display and overlay strings.
3993 * xdisp.c (compute_display_string_pos)
3994 (compute_display_string_end): Accept additional argument STRING.
3995 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3996 (reseat_to_string): Initialize bidi_it->string.s and
3997 bidi_it->string.schars.
3998 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3999 NULL (avoids a crash in bidi_paragraph_init).
4000 Initialize itb.string.lstring.
4001 (init_iterator): Call bidi_init_it only of a valid
4002 buffer position was specified. Initialize paragraph_embedding to
4004 (reseat_to_string): Initialize the bidi iterator.
4005 (display_string): If we need to ignore text properties of
4006 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4007 original value of -1 will not work with bidi.)
4008 (compute_display_string_pos): First arg is now struct
4009 `text_pos *'; all callers changed. Support display properties on
4011 (compute_display_string_end): Support display properties on Lisp
4013 (init_iterator, reseat_1, reseat_to_string): Initialize the
4014 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4015 when iterating on a string not from display properties).
4016 (compute_display_string_pos, compute_display_string_end):
4017 Fix calculation of the object to scan. Fixes an error when using
4019 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4020 base_level_stop; instead, set base_level_stop to BEGV.
4021 Fixes crashes in vertical-motion.
4022 (next_element_from_buffer): Improve commentary for when
4023 the iterator is before prev_stop.
4024 (init_iterator): Initialize bidi_p from the default value of
4025 bidi-display-reordering, not from buffer-local value. Use the
4026 buffer-local value only if initializing for buffer iteration.
4027 (handle_invisible_prop): Support invisible properties on strings
4028 that are being bidi-reordered.
4029 (set_iterator_to_next): Support bidi reordering of C strings and
4031 (next_element_from_string): Support bidi reordering of Lisp
4033 (handle_stop_backwards): Support Lisp strings as well.
4034 (display_string): Support display of R2L glyph rows.
4035 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4036 (init_iterator): Don't initialize it->bidi_p for strings
4038 (reseat_to_string): Initialize it->bidi_p for strings here.
4039 (next_element_from_string, next_element_from_c_string)
4040 (next_element_from_buffer): Add xassert's for correspondence
4041 between IT's object being iterated and it->bidi_it.string
4043 (face_before_or_after_it_pos): Support bidi iteration.
4044 (next_element_from_c_string): Handle the case of the first string
4045 character that is not the first one in the visual order.
4046 (get_visually_first_element): New function, refactored from common
4047 parts of next_element_from_buffer, next_element_from_string, and
4048 next_element_from_c_string.
4049 (tool_bar_lines_needed, redisplay_tool_bar)
4050 (display_menu_bar): Force left-to-right direction. Add a FIXME
4051 comment for making that be controlled by a user option.
4052 (push_it, pop_it): Save and restore the state of the
4053 bidi iterator. Save and restore the bidi_p flag.
4054 (pop_it): Iterate out of display property for string iteration as
4056 (iterate_out_of_display_property): Support iteration over strings.
4057 (handle_single_display_spec): Set up it->bidi_it for iteration
4058 over a display string, and call bidi_init_it.
4059 (handle_single_display_spec, next_overlay_string)
4060 (get_overlay_strings_1, push_display_prop): Set up the bidi
4061 iterator for displaying display or overlay strings.
4062 (forward_to_next_line_start): Don't use the shortcut if
4064 (back_to_previous_visible_line_start): If handle_display_prop
4065 pushed the iterator stack, restore the internal state of the bidi
4066 iterator by calling bidi_pop_it same number of times.
4067 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4068 and we are bidi-iterating, don't decrement the iterator position;
4069 instead, set the first_elt flag in the bidi iterator, to produce
4071 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4072 (push_display_prop): xassert that we are iterating a buffer.
4073 (push_it, pop_it): Save and restore paragraph_embedding member.
4074 (handle_single_display_spec, next_overlay_string)
4075 (get_overlay_strings_1, reseat_1, reseat_to_string)
4076 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4077 correctly. Don't assume unibyte strings are not bidi-reordered.
4078 (compute_display_string_pos)
4079 (compute_display_string_end): Fix handling the case of C string.
4080 (push_it, pop_it): Save and restore from_disp_prop_p.
4081 (handle_single_display_spec, push_display_prop): Set the
4082 from_disp_prop_p flag.
4083 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4084 (pop_it): Call iterate_out_of_display_property only if we are
4085 popping after iteration over a string that came from a display
4086 property. Fix a typo in popping stretch info. Add an assertion
4087 for verifying that the iterator position is in sync with the bidi
4089 (handle_single_display_spec, get_overlay_strings_1)
4090 (push_display_prop): Fix initialization of paragraph direction for
4091 string when that of the parent object is not yet determined.
4092 (reseat_1): Call bidi_init_it to resync the bidi
4093 iterator with IT's position. (Bug#7616)
4094 (find_row_edges): If ROW->start.pos gives position
4095 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4096 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4097 Reset the from_disp_prop_p flag.
4098 (SAVE_IT, RESTORE_IT): New macros.
4099 (pos_visible_p, face_before_or_after_it_pos)
4100 (back_to_previous_visible_line_start)
4101 (move_it_in_display_line_to, move_it_in_display_line)
4102 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4103 (try_scrolling, redisplay_window, display_line): Use them when
4104 saving a temporary copy of the iterator and restoring it back.
4105 (back_to_previous_visible_line_start, reseat_1)
4106 (init_iterator): Empty the bidi cache "stack".
4107 (move_it_in_display_line_to): If iterator ended up at
4108 EOL, but we never saw any buffer positions smaller than
4109 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4110 motion in bidi-reordered lines.
4111 (move_it_in_display_line_to): Record prev_method and prev_pos
4112 immediately before the call to set_iterator_to_next. Fixes cursor
4113 motion in bidi-reordered lines with stretch glyphs and strings
4114 displayed in margins. (Bug#8133) (Bug#8867)
4115 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4117 (pos_visible_p): Support positions in bidi-reordered lines.
4118 Save and restore bidi cache.
4120 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4121 (bidi_paragraph_info): Delete unused struct.
4122 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4123 (bidi_cache_start): New variable.
4124 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4126 (bidi_cache_fetch_state, bidi_cache_search)
4127 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4128 (bidi_cache_find, bidi_peek_at_next_level)
4129 (bidi_level_of_next_char, bidi_find_other_level_edge)
4130 (bidi_move_to_visually_next): Compare cache index with
4131 bidi_cache_start rather than with zero.
4132 (bidi_fetch_char): Accept new argument STRING; all callers
4133 changed. Support iteration over a string. Support strings with
4134 display properties. Support unibyte strings. Fix the type of
4135 `len' according to what STRING_CHAR_AND_LENGTH expects.
4136 (bidi_paragraph_init, bidi_resolve_explicit_1)
4137 (bidi_resolve_explicit, bidi_resolve_weak)
4138 (bidi_level_of_next_char, bidi_move_to_visually_next):
4139 Support iteration over a string.
4140 (bidi_set_sor_type, bidi_resolve_explicit_1)
4141 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4142 can now be zero (for strings); special values 0 and -1 were
4143 changed to -1 and -2, respectively.
4144 (bidi_char_at_pos): New function.
4145 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4146 Call it instead of FETCH_MULTIBYTE_CHAR.
4147 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4148 initialized to valid values.
4149 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4151 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4152 the test for valid cached positions. Fix the logic for looking up
4153 the sentinel state in the cache. GCPRO the Lisp string we are
4155 (bidi_push_it, bidi_pop_it): New functions.
4156 (bidi_initialize): Initialize the bidi cache start stack pointer.
4157 (bidi_cache_ensure_space): New function, refactored from part of
4158 bidi_cache_iterator_state. Don't assume the required size is just
4159 one BIDI_CACHE_CHUNK away.
4160 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4161 (bidi_count_bytes, bidi_char_at_pos): New functions.
4162 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4163 always valid if bidi_cache_idx is valid.
4164 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4165 is valid if it's going to be used.
4166 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4167 (bidi_cache_fetch_state, bidi_cache_search)
4168 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4169 (bidi_cache_iterator_state, bidi_cache_find)
4170 (bidi_find_other_level_edge, bidi_cache_start_stack):
4171 All variables related to cache indices are now EMACS_INT.
4173 * dispextern.h (struct bidi_string_data): New structure.
4174 (struct bidi_it): New member `string'. Make flag members be 1-bit
4175 fields, and put them last in the struct.
4176 (compute_display_string_pos, compute_display_string_end):
4178 (bidi_push_it, bidi_pop_it): Add prototypes.
4179 (struct iterator_stack_entry): New members bidi_p,
4180 paragraph_embedding, and from_disp_prop_p.
4181 (struct it): Member bidi_p is now a bit field 1 bit wide.
4182 (bidi_shelve_cache, bidi_unshelve_cache):
4185 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4186 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4187 and vector-like objects.
4189 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4190 cache around display iteration.
4192 * window.c (Fwindow_end, window_scroll_pixel_based)
4193 (displayed_window_lines, Frecenter): Save and restore the bidi
4194 cache around display iteration.
4196 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4198 * editfns.c (Fdelete_region): Clarify the use of the named
4199 parameters (bug#6788).
4201 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4203 * indent.c (Fvertical_motion): Set and restore w->pointm when
4204 saving and restoring the window's buffer (Bug#9006).
4206 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4208 * editfns.c (Fstring_to_char): Clarify just what is returned
4209 (bug#6576). Text by Eli Zaretskii.
4211 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4213 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4215 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4217 * buffer.c (mmap_find): Fix a typo.
4219 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4221 Fix execution of x selection hooks.
4222 * xselect.c (Qx_lost_selection_functions)
4223 (Qx_sent_selection_functions): New vars.
4224 (syms_of_xselect): DEFSYM them.
4225 (x_handle_selection_request): Pass Qx_sent_selection_functions
4226 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4227 (x_handle_selection_clear,x_clear_frame_selections):
4228 Pass Qx_lost_selection_functions rather than
4229 Vx_lost_selection_functions to Frun_hook_with_args.
4231 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4233 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4234 The old code sometimes used this field without initializing it.
4236 * alloc.c (gc_sweep): Don't read past end of array.
4237 In theory, the old code could also have corrupted Emacs internals,
4238 though it'd be very unlikely.
4240 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4242 * character.c (Fcharacterp): Don't advertise optional ignored
4243 argument. (Bug#4026)
4245 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4247 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4250 * window.c (Fset_window_start): Doc fix (bug#4199).
4251 (Fset_window_hscroll): Ditto.
4253 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4255 Fix minor new problems caught by GCC 4.6.1.
4256 * term.c (init_tty): Remove unused local.
4257 * xsettings.c (store_monospaced_changed): Define this function only
4258 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4261 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4263 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4265 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4268 are the mini-buffer and the echo area (bug#3320).
4270 * term.c (init_tty): Remove support for supdup, c10 and perq
4271 terminals, which are no longer supported (bug#1482).
4273 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4275 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4277 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4279 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4280 for non-popups (Bug#3642).
4282 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4284 * alloc.c (reset_malloc_hooks): Protoize.
4285 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4286 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4287 * cm.c (losecursor): Likewise.
4288 * data.c (fmod): Likewise.
4289 * dispnew.c (swap_glyphs_in_rows): Likewise.
4290 * emacs.c (memory_warning_signal): Likewise.
4291 * floatfns.c (float_error): Likewise.
4292 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4293 (otf_open, font_otf_capability, generate_otf_features)
4294 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4296 * image.c (pbm_read_file): Likewise.
4297 * indent.c (string_display_width): Likewise.
4298 * intervals.c (check_for_interval, search_for_interval)
4299 (inc_interval_count, count_intervals, root_interval)
4300 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4301 * lread.c (defalias): Likewise.
4302 * ralloc.c (r_alloc_check): Likewise.
4303 * regex.c (set_image_of_range_1, set_image_of_range)
4304 (regex_grow_registers): Likewise.
4305 * sysdep.c (strerror): Likewise.
4306 * termcap.c (valid_filename_p, tprint, main): Likewise.
4307 * tparam.c (main): Likewise.
4308 * unexhp9k800.c (run_time_remap, save_data_space)
4309 (update_file_ptrs, read_header, write_header, calculate_checksum)
4310 (copy_file, copy_rest, display_header): Likewise.
4311 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4313 * xdisp.c (check_it): Likewise.
4314 * xfaces.c (register_color, unregister_color, unregister_colors):
4316 * xfns.c (print_fontset_result): Likewise.
4317 * xrdb.c (member, fatal, main): Likewise.
4319 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4321 Fix minor problems found by static checking (Bug#9031).
4322 * chartab.c (char_table_set_range, map_sub_char_table):
4323 Remove unused locals.
4324 (uniprop_table): Now static.
4325 * composite.c (_work_char): Remove unused static var.
4327 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4329 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4331 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4333 * gtkutil.c (qttip_cb): Remove code without function.
4335 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4337 * w32.c (pthread_sigmask): New stub.
4339 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4341 Use pthread_sigmask, not sigprocmask (Bug#9010).
4342 sigprocmask is portable only for single-threaded applications, and
4343 Emacs can be multi-threaded when it uses GTK.
4344 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4346 * callproc.c (Fcall_process):
4347 * process.c (create_process):
4348 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4349 Use pthread_sigmask, not sigprocmask.
4351 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4353 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4354 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4357 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4359 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4360 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4361 (xg_hide_tooltip): Fix comment.
4363 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4364 in registerServicesMenuSendTypes.
4365 (validRequestorForSendType): Don't check ns_return_types.
4367 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4370 2011-07-08 Jason Rumney <jasonr@gnu.org>
4372 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4373 SH_SHOW for hidden windows (Bug#5482).
4375 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4376 frame struct members of non-existent frames (Bug#6284).
4378 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4380 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4381 variable firstTime not needed on OSX >= 10.6.
4382 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4383 >= 10.5. Use setKnobProportion, setDoubleValue.
4385 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4386 (MAC_OS_X_VERSION_10_5): Define if not defined.
4387 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4388 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4389 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4391 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4392 cString and lossyCString on OSX >= 10.4
4394 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4395 sizeToFit on OSX >= 10.2.
4397 * nsimage.m (allocInitFromFile): Don't use deprecated method
4398 bestRepresentationForDevice on OSX >= 10.6.
4400 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4403 * emacs.c: Declare unexec_init_emacs_zone.
4405 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4407 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4409 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4410 on svcsMenu (Bug#8842).
4412 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4414 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4416 * nsterm.m (QUTF8_STRING): Declare.
4417 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4418 (validRequestorForSendType): Return type is (id).
4419 Change indexOfObjectIdenticalTo to indexOfObject.
4420 Check if we have local selection before returning self (Bug#8842).
4421 (writeSelectionToPasteboard): Put local selection into paste board
4422 if we have a local selection (Bug#8842).
4423 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4425 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4426 (ns_get_local_selection): Declare.
4428 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4430 * keymap.c (describe_map_tree): Don't insert a double newline at
4431 the end of the buffer (bug#1169) and return whether we inserted
4434 * callint.c (Fcall_interactively): Change "reading args" to
4435 "providing args" to try to clarify what it does (bug#1010).
4437 2011-07-07 Kenichi Handa <handa@m17n.org>
4439 * composite.c (composition_compute_stop_pos): Ignore a static
4440 composition starting before CHARPOS (Bug#8915).
4442 * xdisp.c (handle_composition_prop): Likewise.
4444 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4446 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4449 2011-07-07 Kenichi Handa <handa@m17n.org>
4451 * character.h (unicode_category_t): New enum type.
4453 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4454 (Qchar_code_property_table): New variable.
4455 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4456 (UNIPROP_COMPRESSED_FORM_P): New macros.
4457 (char_table_ascii): Uncompress the compressed values.
4458 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4459 Uncompress the compressed values.
4460 (sub_char_table_ref_and_range): Likewise.
4461 (char_table_ref_and_range): Uncompress the compressed values.
4462 (sub_char_table_set): New arg is_uniprop. Callers changed.
4463 Uncompress the compressed values.
4464 (sub_char_table_set_range): Args changed. Callers changed.
4465 (char_table_set_range): Adjuted for the above change.
4466 (map_sub_char_table): Delete args default_val and parent. Add arg
4467 top. Give decoded values to a Lisp function.
4468 (map_char_table): Adjust for the above change. Give decoded
4469 values to a Lisp function. Gcpro more variables.
4470 (uniprop_table_uncompress)
4471 (uniprop_decode_value_run_length): New functions.
4472 (uniprop_decoder, uniprop_decoder_count): New variables.
4473 (uniprop_get_decoder, uniprop_encode_value_character)
4474 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4476 (uniprop_encoder, uniprop_encoder_count): New variables.
4477 (uniprop_get_encoder, uniprop_table)
4478 (Funicode_property_table_internal, Fget_unicode_property_internal)
4479 (Fput_unicode_property_internal): New functions.
4480 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4481 Sunicode_property_table_internal, Sget_unicode_property_internal,
4482 and Sput_unicode_property_internal. Defvar_lisp
4483 char-code-property-alist.
4485 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4486 Vunicode_category_table.
4488 * font.c (font_range): Adjust for the change of
4489 Vunicode_category_table.
4491 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4493 * m/iris4d.h: Remove file, move contents ...
4494 * s/irix6-5.h: ... here.
4496 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4498 Remove unportable assumption about struct layout (Bug#8884).
4499 * alloc.c (mark_buffer):
4500 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4501 (clone_per_buffer_values): Don't assume that
4502 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4503 This isn't true in general, and it's particularly not true
4504 if Emacs is configured with --with-wide-int.
4505 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4506 New macros, used in the buffer.c change.
4508 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4510 * xsettings.c: Use both GConf and GSettings if both are available.
4511 (store_config_changed_event): Add comment.
4512 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4513 (store_tool_bar_style_changed): New functions.
4514 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4515 (struct xsettings): Move font inside HAVE_XFT.
4516 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4517 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4518 Move inside HAVE_XFT.
4519 (something_changed_gsettingsCB): Rename from something_changedCB.
4520 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4522 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4523 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4524 (something_changed_gconfCB): Rename from something_changedCB.
4525 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4526 (parse_settings): Move check for font inside HAVE_XFT.
4527 (read_settings, apply_xft_settings): Add comment.
4528 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4529 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4530 call store_font_name_changed.
4531 (xft_settings_event): Add comment.
4532 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4533 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4534 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4535 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4536 (xsettings_initialize): Call init_gsettings last.
4537 (xsettings_get_system_font, xsettings_get_system_normal_font):
4540 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4542 Random fixes. E.g., (random) never returned negative values.
4543 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4544 subseconds part to the entropy, as that's a bit more random.
4545 Prefer signed to unsigned, since the signedness doesn't matter and
4546 in general we prefer signed. When given a limit, use a
4547 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4548 latter isn't right if USE_2_TAGS_FOR_INTS.
4549 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4550 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4552 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4554 * textprop.c (text_property_stickiness):
4555 Obey Vtext_property_default_nonsticky.
4556 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4557 * w32fns.c (syms_of_w32fns):
4558 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4560 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4562 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4563 This is more efficient than Ffile_directory_p and avoids a minor race.
4565 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4567 * buffer.c (Foverlay_put): Say what the return value is
4570 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4571 is a directory before asking whether to use the file name
4573 (barf_or_query_if_file_exists): Make the "File is a directory"
4574 error be more correct.
4576 * fns.c (Frequire): Remove the mention of the .gz files, since
4577 that's installation-specific, but keep the mention of
4578 `get-load-suffixes'.
4580 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4582 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4583 Report string overflow if the output is too long.
4585 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4587 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4588 (syms_of_gnutls): Remove duplicate DEFSYM for
4589 Qgnutls_bootprop_verify_hostname_error, an error for
4590 Qgnutls_bootprop_verify_error (which is no longer used).
4592 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4593 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4594 Also (re)move comments that are misplaced or no longer relevant.
4596 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4598 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4600 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4602 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4603 and background color parameters if they have been changed.
4605 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4607 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4609 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4611 * xsettings.c (SYSTEM_FONT): Define only when used.
4612 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4614 * keymap.c (access_keymap_1): Now static.
4616 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4618 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4619 leave any prefix arg for the up event (Bug#1586).
4621 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4623 * lread.c (syms_of_lread): Mention single symbols defined by
4624 `defvar' or `defconst' (bug#7154).
4626 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4627 (Frequire): Mention get-load-suffixes.
4629 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4631 * window.h (window): Remove clone_number slot.
4632 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4634 (make_parent_window, make_window, saved_window)
4635 (Fset_window_configuration, save_window_save): Don't deal with
4637 * buffer.c (Qclone_number): Remove declaration.
4638 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4640 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4642 Add multiple inheritance to keymaps.
4643 * keymap.c (Fmake_composed_keymap): New function.
4644 (Fset_keymap_parent): Simplify.
4645 (fix_submap_inheritance): Remove.
4646 (access_keymap_1): New function extracted from access_keymap to handle
4647 embedded parents and handle lists of maps.
4648 (access_keymap): Use it.
4649 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4650 (Fcopy_keymap): Handle embedded parents.
4651 (Fcommand_remapping, define_as_prefix): Simplify.
4652 (Fkey_binding): Simplify.
4653 (syms_of_keymap): Move minibuffer-local-completion-map,
4654 minibuffer-local-filename-completion-map,
4655 minibuffer-local-must-match-map, and
4656 minibuffer-local-filename-must-match-map to Elisp.
4657 (syms_of_keymap): Defsubr make-composed-keymap.
4658 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4659 (parse_menu_item): Trivial simplification.
4661 2011-07-01 Glenn Morris <rgm@gnu.org>
4663 * Makefile.in (SETTINGS_LIBS): Fix typo.
4665 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4667 * coding.c (Fencode_coding_string): Record the last coding system
4668 used, as the function doc string says (bug#8738).
4670 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4672 * xsettings.c (store_monospaced_changed): Take new font as arg and
4673 check for change against current_mono_font.
4674 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4675 (emacs_settings_constructor, emacs_settings_get_property)
4676 (emacs_settings_set_property, emacs_settings_class_init)
4677 (emacs_settings_init, gsettings_obj): Remove.
4678 (something_changedCB): New function for HAVE_GSETTINGS.
4679 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4680 with value as argument.
4681 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4682 g_settings_new (Bug#8967). Do not create gsettings_obj.
4683 Remove calls to g_settings_bind. Connect something_changedCB to
4686 * xgselect.c: Add defined (HAVE_GSETTINGS).
4687 (xgselect_initialize): Ditto.
4689 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4690 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4693 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4695 * eval.c (struct backtrace): Simplify and port the data structure.
4696 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4697 signed bit field, as this assumption is not portable and it makes
4698 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4699 "char debug_on_exit : 1" as this is not portable either; instead,
4700 use the portable "unsigned int debug_on_exit : 1". Remove unused
4701 member evalargs. Remove obsolete comments about cc bombing out.
4703 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4705 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4706 Let HAVE_GSETTINGS override HAVE_GCONF.
4707 (store_monospaced_changed): New function.
4708 (EMACS_SETTINGS): A new type derived from GObject to handle
4709 GSettings notifications.
4710 (emacs_settings_constructor, emacs_settings_get_property)
4711 (emacs_settings_set_property, emacs_settings_class_init):
4713 (gsettings_client, gsettings_obj): New variables.
4714 (GSETTINGS_SCHEMA): New define.
4715 (something_changedCB): Call store_monospaced_changed.
4716 (init_gsettings): New function.
4717 (xsettings_initialize): Call init_gsettings.
4718 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4721 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4724 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4726 * window.c (resize_root_window, grow_mini_window)
4727 (shrink_mini_window): Rename Qresize_root_window to
4728 Qwindow_resize_root_window and Qresize_root_window_vertically to
4729 Qwindow_resize_root_window_vertically.
4731 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4733 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4735 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4737 * makefile.w32-in: Redesign dependencies so they reflect more
4738 clearly which files are directly included by each source file,
4739 and not through other includes.
4741 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4743 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4744 (sort_overlays, overlay_strings): When an overlay's clone number
4745 matches the window's clone number process the overlay even if
4746 the overlay's window property doesn't match the current window.
4748 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4749 (Fwindow_hchild): Rename to Fwindow_left_child.
4750 (Fwindow_next): Rename to Fwindow_next_sibling.
4751 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4752 (resize_window_check): Rename to window_resize_check.
4753 (resize_window_apply): Rename to window_resize_apply.
4754 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4755 (Fdelete_other_windows_internal, resize_frame_windows)
4756 (Fsplit_window_internal, Fdelete_window_internal)
4757 (grow_mini_window, shrink_mini_window)
4758 (Fresize_mini_window_internal): Fix callers accordingly.
4760 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4762 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4763 (emacs_fixed_set_min_size): Remove.
4764 (emacs_fixed_new): Take frame as argument.
4766 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4767 (_EmacsFixedPrivate): Remove minwidth/height.
4768 Add struct frame *f.
4769 (emacs_fixed_init): Initialize priv->f.
4770 (get_parent_class, emacs_fixed_set_min_size): Remove.
4771 (emacs_fixed_new): Set priv->f to argument.
4772 (emacs_fixed_get_preferred_width)
4773 (emacs_fixed_get_preferred_height): Use min_width/height from
4774 frames size_hint to set minimum and natural (Bug#8919).
4775 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4776 and use min_width/height from frames size_hint to set
4777 min_width/height (Bug#8919).
4779 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4780 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4783 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4785 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4786 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4789 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4791 * process.c (wait_reading_process_output): Bypass select if
4792 waiting for a cell while ignoring keyboard input, and input is
4793 pending. Suggested by Jan Djärv (Bug#8869).
4795 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4797 Use gnulib's dup2 module instead of rolling our own.
4798 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4800 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4802 * dispnew.c (scrolling_window): Before scrolling, turn off a
4803 mouse-highlight in the window being scrolled.
4805 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4807 Move DEFSYM to lisp.h and use everywhere.
4809 * character.h (DEFSYM): Move declaration...
4810 * lisp.h (DEFSYM): ...here.
4816 * w32select.c: Don't include character.h.
4818 * alloc.c (syms_of_alloc):
4819 * buffer.c (syms_of_buffer):
4820 * bytecode.c (syms_of_bytecode):
4821 * callint.c (syms_of_callint):
4822 * casefiddle.c (syms_of_casefiddle):
4823 * casetab.c (init_casetab_once):
4824 * category.c (init_category_once, syms_of_category):
4825 * ccl.c (syms_of_ccl):
4826 * cmds.c (syms_of_cmds):
4827 * composite.c (syms_of_composite):
4828 * dbusbind.c (syms_of_dbusbind):
4829 * dired.c (syms_of_dired):
4830 * dispnew.c (syms_of_display):
4831 * doc.c (syms_of_doc):
4832 * editfns.c (syms_of_editfns):
4833 * emacs.c (syms_of_emacs):
4834 * eval.c (syms_of_eval):
4835 * fileio.c (syms_of_fileio):
4836 * fns.c (syms_of_fns):
4837 * frame.c (syms_of_frame):
4838 * fringe.c (syms_of_fringe):
4839 * insdel.c (syms_of_insdel):
4840 * keymap.c (syms_of_keymap):
4841 * lread.c (init_obarray, syms_of_lread):
4842 * macros.c (syms_of_macros):
4843 * msdos.c (syms_of_msdos):
4844 * print.c (syms_of_print):
4845 * process.c (syms_of_process):
4846 * search.c (syms_of_search):
4847 * sound.c (syms_of_sound):
4848 * syntax.c (init_syntax_once, syms_of_syntax):
4849 * terminal.c (syms_of_terminal):
4850 * textprop.c (syms_of_textprop):
4851 * undo.c (syms_of_undo):
4852 * w32.c (globals_of_w32):
4853 * window.c (syms_of_window):
4854 * xdisp.c (syms_of_xdisp):
4855 * xfaces.c (syms_of_xfaces):
4856 * xfns.c (syms_of_xfns):
4857 * xmenu.c (syms_of_xmenu):
4858 * xsettings.c (syms_of_xsettings):
4859 * xterm.c (syms_of_xterm): Use DEFSYM.
4861 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4863 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4865 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4867 Integer and buffer overflow fixes (Bug#8873).
4869 * print.c (printchar, strout): Check for string overflow.
4870 (PRINTPREPARE, printchar, strout):
4871 Don't set size unless allocation succeeds.
4873 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4874 for sizes. Check for string overflow more accurately.
4875 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4877 * macros.c: Integer and buffer overflow fixes.
4878 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4879 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4880 Use ptrdiff_t, not int, for sizes.
4881 Don't increment bufsize until after realloc succeeds.
4882 Check for size-calculation overflow.
4883 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4885 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4887 * lread.c: Integer overflow fixes.
4888 (read_integer): Radix is now EMACS_INT, not int,
4889 to improve quality of diagnostics for out-of-range radices.
4890 Calculate buffer size correctly for out-of-range radices.
4891 (read1): Check for integer overflow in radices, and in
4892 read-circle numbers.
4893 (read_escape): Avoid int overflow.
4894 (Fload, openp, read_buffer_size, read1)
4895 (substitute_object_recurse, read_vector, read_list, map_obarray):
4896 Use ptrdiff_t, not int, for sizes.
4897 (read1): Use EMACS_INT, not int, for sizes.
4898 Check for size overflow.
4900 * image.c (cache_image): Check for size arithmetic overflow.
4902 * lread.c: Integer overflow issues.
4903 (saved_doc_string_size, saved_doc_string_length)
4904 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4905 Now ptrdiff_t, not int.
4906 (read1): Don't assume doc string length fits in int. Check for
4907 out-of-range doc string lengths.
4908 (read_list): Don't assume file position fits in int.
4909 (read_escape): Check for hex character overflow.
4911 2011-06-22 Leo Liu <sdl.web@gmail.com>
4913 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4914 Move to minibuffer.el.
4916 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4918 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4919 The following patches are for when GLYPH_DEBUG && !XASSERT.
4920 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4921 * dispnew.c (flush_stdout):
4922 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4923 Mark as externally visible.
4924 * dispnew.c (check_window_matrix_pointers): Now static.
4925 * dispnew.c (window_to_frame_vpos):
4926 * xfns.c (unwind_create_frame):
4927 * xterm.c (x_check_font): Remove unused local.
4928 * scroll.c (CHECK_BOUNDS):
4929 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4930 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4931 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4932 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4933 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4935 (debug_method_add): Use va_list and vsprintf rather than relying
4936 on undefined behavior with wrong number of arguments.
4937 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4938 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4939 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4940 since we're not interested in debugging glyphs with old libraries.
4941 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4942 GCC 4.6.0's static checking.
4944 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4946 Integer overflow and signedness fixes (Bug#8873).
4947 A few related buffer overrun fixes, too.
4949 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4951 * dispextern.h (struct face.stipple):
4952 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4953 (x_bitmap_mask, x_allocate_bitmap_record)
4954 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4955 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4956 (x_create_bitmap_from_xpm_data):
4957 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4958 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4960 * xfaces.c (load_pixmap):
4961 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4962 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4963 (.bitmaps_last, struct x_output.icon_bitmap):
4964 Use ptrdiff_t, not int, for bitmap indexes.
4965 (x_allocate_bitmap_record): Check for size overflow.
4966 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4968 Use ptrdiff_t, not int, for overlay counts.
4969 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4970 * editfns.c (overlays_around, get_pos_property):
4971 * textprop.c (get_char_property_and_overlay):
4972 * xdisp.c (next_overlay_change, note_mouse_highlight):
4973 * xfaces.c (face_at_buffer_position):
4974 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4975 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4976 (Fnext_overlay_change, Fprevious_overlay_change)
4977 (mouse_face_overlay_overlaps, Foverlays_in):
4978 Use ptrdiff_t, not int, for sizes.
4979 (overlays_at, overlays_in): Check for size-calculation overflow.
4981 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4983 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4984 (x_session_initialize): Do not assume string length fits in int.
4986 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4987 This is unlikely, but can occur if DPI is outlandish.
4989 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4990 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4992 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4993 * xrdb.c (magic_file_p, search_magic_path):
4994 Omit last arg SUFFIX; it was always 0. All callers changed.
4995 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4997 * xfont.c (xfont_match): Avoid need for strlen.
4999 * xfns.c: Don't assume strlen fits in int.
5000 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5002 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5003 not unsigned long, as we prefer signed integers. All callers changed.
5004 Detect integer overflow in repeat count.
5005 (message_dolog): Don't assume print length fits in 39 bytes.
5006 (display_mode_element): Don't assume strlen fits in int.
5008 * termcap.c: Don't assume sizes fit in int and never overflow.
5009 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5010 (gobble_line): Check for size-calculation overflow.
5012 * minibuf.c (Fread_buffer):
5013 * lread.c (intern, intern_c_string):
5014 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5015 Don't assume string length fits in int.
5017 * keyboard.c (parse_tool_bar_item):
5018 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5020 * font.c: Don't assume string length fits in int.
5021 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5022 Use ptrdiff_t, not int.
5023 (font_intern_prop): Don't assume string length fits in int.
5024 Don't assume integer property fits in fixnum.
5025 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5027 * filelock.c: Fix some buffer overrun and integer overflow issues.
5028 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5029 Reformulate so as not to need the command string.
5030 Invoke gzip -cd rather than gunzip, as it's more portable.
5031 (lock_info_type, lock_file_1, lock_file):
5032 Don't assume pid_t and time_t fit in unsigned long.
5033 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5034 (current_lock_owner): Prefer signed type for sizes.
5035 Use memcpy, not strncpy, where memcpy is what is really wanted.
5036 Don't assume (via atoi) that time_t and pid_t fit in int.
5037 Check for time_t and/or pid_t out of range, e.g., via a network share.
5038 Don't alloca where an auto var works fine.
5040 * fileio.c: Fix some integer overflow issues.
5041 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5042 Don't assume string length fits in int.
5043 (directory_file_name): Don't assume string length fits in long.
5044 (make_temp_name): Don't assume pid fits in int, or that its print
5045 length is less than 20.
5047 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5049 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5051 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5053 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5054 We prefer signed integers, even for size calculations.
5056 * emacs.c: Don't assume string length fits in 'int'.
5057 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5058 (main): Don't invoke strlen when not needed.
5060 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5061 (XD_DEBUG_MESSAGE): Don't waste a byte.
5063 * callproc.c (getenv_internal_1, getenv_internal)
5065 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5067 * lread.c (invalid_syntax): Omit length argument.
5068 All uses changed. This doesn't fix a bug, but it simplifies the
5069 code away from its former Hollerith-constant appearance, and it's
5070 one less 'int' to worry about when looking at integer-overflow issues.
5071 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5073 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5074 This didn't break anything, but it didn't help either.
5075 It's confusing to put a bogus integer in a place where the actual
5076 value does not matter.
5077 (LIST_END_P): Remove unused macro and its bogus comment.
5078 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5080 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5081 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5083 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5084 We prefer signed types, and the value cannot exceed the EMACS_INT
5085 range anyway (because otherwise the length would not be representable).
5086 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5087 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5088 This avoids a GCC warning when WIDE_EMACS_INT.
5090 * indent.c (sane_tab_width): New function.
5091 (current_column, scan_for_column, Findent_to, position_indentation)
5092 (compute_motion): Use it. This is just for clarity.
5093 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5095 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5097 * lisp.h (lint_assume): New macro.
5098 * composite.c (composition_gstring_put_cache):
5099 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5101 * editfns.c, insdel.c:
5102 Omit unnecessary forward decls, to simplify future changes.
5104 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5106 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5108 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5109 Use much-faster test for byte-length change.
5110 Don't assume string byte-length fits in 'int'.
5111 Check that character arg fits in 'int'.
5112 (mapcar1): Declare byte as byte, for clarity.
5114 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5116 * fns.c (concat): Catch string overflow earlier.
5117 Do not rely on integer wraparound.
5119 * dispextern.h (struct it.overlay_strings_charpos)
5120 (struct it.selective): Now EMACS_INT, not int.
5121 * xdisp.c (forward_to_next_line_start)
5122 (back_to_previous_visible_line_start)
5123 (reseat_at_next_visible_line_start, next_element_from_buffer):
5124 Don't arbitrarily truncate the value of 'selective' to int.
5126 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5128 * composite.c: Don't truncate sizes to 'int'.
5129 (composition_gstring_p, composition_reseat_it)
5130 (composition_adjust_point): Use EMACS_INT, not int.
5131 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5132 not EMACS_UINT, for indexes.
5134 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5136 * buffer.c: Include <verify.h>.
5137 (struct sortvec.priority, struct sortstr.priority):
5138 Now EMACS_INT, not int.
5139 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5140 (struct sortstr.size, record_overlay_string)
5141 (struct sortstrlist.size, struct sortlist.used):
5142 Don't truncate size to int.
5143 (record_overlay_string): Check for size-calculation overflow.
5144 (init_buffer_once): Check at compile-time, not run-time.
5146 2011-06-22 Jim Meyering <meyering@redhat.com>
5148 Don't leak an XBM-image-sized buffer
5149 * image.c (xbm_load): Free the image buffer after using it.
5151 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5154 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5155 that Sun C diagnosed.
5156 * fns.c (secure_hash): Fix pointer signedness issue.
5157 * intervals.c (static_offset_intervals): New function.
5158 (offset_intervals): Use it.
5160 2011-06-21 Leo Liu <sdl.web@gmail.com>
5163 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5166 * fns.c (secure_hash): Rename from crypto_hash_function and change
5167 the first arg to accept symbols.
5168 (Fsecure_hash): New primitive.
5169 (syms_of_fns): New symbols.
5171 2011-06-20 Deniz Dogan <deniz@dogan.se>
5173 * process.c (Fset_process_buffer): Clarify return value in
5176 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5178 * dispnew.c (add_window_display_history): Use BVAR.
5180 * xdisp.c (debug_method_add): Use BVAR.
5181 (check_window_end, dump_glyph_matrix, dump_glyph)
5182 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5184 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5187 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5188 check till after the cache is created in init_frame_faces.
5190 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5192 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5194 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5196 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5197 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5198 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5200 Improve buffer-overflow checking (Bug#8873).
5201 * fileio.c (Finsert_file_contents):
5202 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5203 Remove the old (too-loose) buffer overflow checks.
5204 They weren't needed, since make_gap checks for buffer overflow.
5205 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5206 The old code merely checked for Emacs fixnum overflow, and relied
5207 on undefined (wraparound) behavior. The new code avoids undefined
5208 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5210 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5211 Tune. Don't use wider integers than needed. Don't use alloca.
5212 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5214 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5216 * insdel.c, lisp.h (buffer_overflow): New function.
5217 (insert_from_buffer_1, replace_range, replace_range_2):
5218 * insdel.c (make_gap_larger):
5219 * editfns.c (Finsert_char):
5220 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5222 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5224 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5226 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5228 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5229 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5231 * fileio.c: Don't assume EMACS_INT fits in off_t.
5232 (emacs_lseek): New static function.
5233 (Finsert_file_contents, Fwrite_region): Use it.
5234 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5236 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5238 * fns.c: Don't overflow int when computing a list length.
5239 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5240 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5241 truncation on 64-bit hosts. Check for QUIT every
5242 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5243 faster and is responsive enough.
5244 (Flength): Report an error instead of overflowing an integer.
5245 (Fsafe_length): Return a float if the value is not representable
5246 as a fixnum. This shouldn't happen except in contrived situations.
5247 (Fnthcdr, Fsort): Don't assume list length fits in int.
5248 (Fcopy_sequence): Don't assume vector length fits in int.
5250 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5251 (header_size, word_size): New constants.
5252 (allocate_vectorlike): Don't check size overflow here.
5253 (allocate_vector): Check it here instead, since this is the only
5254 caller of allocate_vectorlike that could cause overflow.
5255 Check that the new vector's length is representable as a fixnum.
5257 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5258 The previous code was bogus. For example, next_almost_prime (32)
5259 returned 39, which is undesirable as it is a multiple of 3; and
5260 next_almost_prime (24) returned 25, which is a multiple of 5 so
5261 why was the code bothering to check for multiples of 7?
5263 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5265 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5267 Variadic C functions now count arguments with ptrdiff_t.
5268 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5269 Back then I didn't know that the Emacs coding style prefers signed int.
5270 Also, in the meantime I found a few more instances where arguments
5271 were being counted with int, which may truncate counts on 64-bit
5272 machines, or EMACS_INT, which may be unnecessarily wide.
5273 * lisp.h (struct Lisp_Subr.function.aMANY)
5274 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5275 Arg counts are now ptrdiff_t, not size_t.
5276 All variadic functions and their callers changed accordingly.
5277 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5278 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5279 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5280 * callint.c (Fcall_interactively): Check arg count for overflow,
5281 to avoid potential buffer overrun. Use signed char, not 'int',
5282 for 'varies' array, so that we needn't bother to check its size
5283 calculation for overflow.
5284 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5285 * eval.c (apply_lambda):
5286 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5287 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5288 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5290 * callint.c (Fcall_interactively): Don't use index var as event count.
5292 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5293 * mem-limits.h (SIZE): Remove; no longer used.
5295 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5297 Remove unnecessary casts.
5298 * xterm.c (x_term_init):
5299 * xfns.c (x_set_border_pixel):
5300 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5301 These aren't needed now that we assume ANSI C.
5303 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5304 It's more likely to cause problems (due to unsigned overflow)
5307 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5309 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5311 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5313 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5315 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5317 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5319 GLYPH_CODE_FACE returns EMACS_INT, not int.
5320 * dispextern.h (merge_faces):
5321 * xfaces.c (merge_faces):
5322 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5323 Don't assume EMACS_INT fits in int.
5325 * character.h (CHAR_VALID_P): Remove unused parameter.
5326 * fontset.c, lisp.h, xdisp.c: All uses changed.
5328 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5330 * fns.c (concat): Minor tuning based on overflow analysis.
5331 This doesn't fix any bugs. Use int to hold character, instead
5332 of constantly refetching from Emacs object. Use XFASTINT, not
5333 XINT, for value known to be a character. Don't bother comparing
5334 a single byte to 0400, as it's always less.
5336 * floatfns.c (Fexpt):
5337 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5339 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5342 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5344 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5345 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5346 incorrectly succeed when S was a string, because 4294967386 was
5347 truncated before it was used.
5349 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5350 Otherwise, an out-of-range integer could cause undefined behavior
5353 * composite.c: Use int, not EMACS_INT, for characters.
5354 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5355 EMACS_INT, for values that are known to be in character range.
5356 This doesn't fix any bugs but is the usual style inside Emacs and
5357 may generate better code on 32-bit machines.
5359 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5360 This is for reasons similar to the recent CHAR_STRING fix.
5361 * charset.c (Fencode_char): Check that character arg is actually
5362 a character. Pass an int to ENCODE_CHAR.
5363 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5364 wider than 'int', as a compile-time check to prevent future regressions
5367 * character.c (char_string): Remove unnecessary casts.
5369 Make sure a 64-bit char is never passed to CHAR_STRING.
5370 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5371 by silently ignoring the top 32 bits, allowing some values
5372 that were far too large to be valid characters.
5373 * character.h: Include <verify.h>.
5374 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5375 arguments are no wider than unsigned, as a compile-time check
5376 to prevent future regressions in this area.
5378 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5379 (Fsubst_char_in_region):
5381 * xdisp.c (decode_mode_spec_coding):
5382 Adjust to CHAR_STRING's new requirement.
5383 * editfns.c (Finsert_char, Fsubst_char_in_region):
5384 * fns.c (concat): Check that character args are actually
5385 characters. Without this test, these functions did the wrong
5386 thing with wildly out-of-range values on 64-bit hosts.
5388 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5389 These casts should not be needed on 32-bit hosts, either.
5390 * keyboard.c (read_char):
5391 * lread.c (Fload): Remove casts to unsigned.
5393 * lisp.h (UNSIGNED_CMP): New macro.
5394 This fixes comparison bugs on 64-bit hosts.
5395 (ASCII_CHAR_P): Use it.
5396 * casefiddle.c (casify_object):
5397 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5398 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5399 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5400 * dispextern.h (FACE_FROM_ID):
5401 * keyboard.c (read_char): Use UNSIGNED_CMP.
5403 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5404 not to EMACS_INT, to avoid GCC warning.
5406 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5408 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5409 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5410 isn't needed on 32-bit machines.
5412 * buffer.c (Fgenerate_new_buffer_name):
5413 Use EMACS_INT for count, not int.
5414 (advance_to_char_boundary): Return EMACS_INT, not int.
5416 * data.c (Qcompiled_function): Now static.
5418 * window.c (window_body_lines): Now static.
5420 * image.c (gif_load): Rename local to avoid shadowing.
5422 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5423 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5424 * alloc.c (make_save_value): Integer argument is now of type
5426 (mark_object): Use ptrdiff_t, not int.
5427 * lisp.h (pD): New macro.
5428 * print.c (print_object): Use it.
5430 * alloc.c: Use EMACS_INT, not int, to count objects.
5431 (total_conses, total_markers, total_symbols, total_vector_size)
5432 (total_free_conses, total_free_markers, total_free_symbols)
5433 (total_free_floats, total_floats, total_free_intervals)
5434 (total_intervals, total_strings, total_free_strings):
5435 Now EMACS_INT, not int. All uses changed.
5436 (Fgarbage_collect): Compute overall total using a double, so that
5437 integer overflow is less likely to be a problem. Check for overflow
5438 when converting back to an integer.
5439 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5440 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5441 These were 'int' variables that could overflow on 64-bit hosts;
5442 they were never used, so remove them instead of repairing them.
5443 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5444 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5445 Previously, this ceilinged at INT_MAX, but that doesn't work on
5447 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5449 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5450 (allocate_vectorlike): Check for ptrdiff_t overflow.
5451 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5452 when a (possibly-narrower) signed value would do just as well.
5453 We prefer using signed arithmetic, to avoid comparison confusion.
5455 * alloc.c: Catch some string size overflows that we were missing.
5456 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5457 for convenience in STRING_BYTES_MAX.
5458 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5459 The definition here is exact; the one in lisp.h was approximate.
5460 (allocate_string_data): Check for string overflow. This catches
5461 some instances we weren't catching before. Also, it catches
5462 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5463 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5464 and ptrdiff_t and EMACS_INT are both 64 bits.
5466 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5467 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5468 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5470 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5472 * alloc.c (Fmake_string): Check for out-of-range init.
5474 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5476 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5478 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5480 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5481 xg_get_default_scrollbar_width.
5483 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5484 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5485 (style_changed_cb): Call update_theme_scrollbar_width and call
5486 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5487 all frames (Bug#8505).
5488 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5489 Call gtk_window_set_resizable if HAVE_GTK3.
5490 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5491 and height if HAVE_GTK3 (Bug#8505).
5492 (scroll_bar_width_for_theme): New variable.
5493 (update_theme_scrollbar_width): New function.
5494 (xg_get_default_scrollbar_width): Move code to
5495 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5496 (xg_initialize): Call update_theme_scrollbar_width.
5498 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5500 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5502 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5504 * frame.c (make_frame): Call other_buffer_safely instead of
5507 * window.c (temp_output_buffer_show): Call display_buffer with
5508 second argument Vtemp_buffer_show_specifiers and reset latter
5509 immediately after the call.
5510 (Vtemp_buffer_show_specifiers): New variable.
5511 (auto_window_vscroll_p, next_screen_context_lines)
5512 (Vscroll_preserve_screen_position): Remove leading asterisks from
5515 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5517 Fix minor problems found by GCC 4.6.0 static checking.
5518 * buffer.c (Qclone_number): Remove for now, as it's unused.
5519 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5520 (record_buffer): Remove unused local.
5521 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5522 (set_frame_buffer_list): Remove; unused.
5523 * frame.h (other_visible_frames): Remove decl.
5524 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5525 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5526 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5528 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5529 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5530 Define only if HAVE_GPM.
5531 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5532 (update_hints_inhibit): Remove; never set. All uses removed.
5533 * widgetprv.h (emacsFrameClassRec): Remove decl.
5534 * window.c (delete_deletable_window): Now returns void, since it
5535 wasn't returning anything.
5536 (compare_window_configurations): Remove unused locals.
5537 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5538 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5539 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5540 the same widths as pointers. This follows up on the 2011-05-06 patch.
5541 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5542 * xterm.h: Likewise.
5543 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5545 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5547 * makefile.w32-in: Update dependencies.
5548 (LISP_H): Add lib/intprops.h.
5550 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5552 * image.c (gif_load): Add animation frame delay to the metadata.
5553 (syms_of_image): Use DEFSYM. New symbol `delay'.
5555 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5557 * window.c (delete_deletable_window): Re-add.
5558 (Fset_window_configuration): Rewrite to handle dead buffers and
5559 consequently deletable windows.
5560 (window_tree, Fwindow_tree): Remove. Supply functionality in
5562 (compare_window_configurations): Simplify code.
5564 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5566 * image.c (imagemagick_load_image): Fix type mismatch.
5567 (Fimagemagick_types): Likewise.
5569 * window.h (replace_buffer_in_windows): Declare.
5571 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5573 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5574 Qclone_number. Remove external declaration of Qdelete_window.
5575 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5577 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5578 Run Qbuffer_list_update_hook if allowed.
5579 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5580 buffer list implementation.
5581 (other_buffer_safely): New function.
5582 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5583 calls to replace_buffer_in_windows and
5584 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5586 (record_buffer): Inhibit quitting and rewrite using quittable
5587 functions. Run Qbuffer_list_update_hook if allowed.
5588 (Frecord_buffer, Funrecord_buffer): New functions.
5589 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5590 Move switch-to-buffer to window.el.
5591 (bury-buffer): Move to window.el.
5592 (Vbuffer_list_update_hook): New variable.
5594 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5597 * window.h (resize_frame_windows): Move up in code.
5598 (Fwindow_frame): Remove EXFUN.
5599 (replace_buffer_in_all_windows): Remove prototype.
5600 (replace_buffer_in_windows_safely): Add prototype.
5602 * window.c: Declare Qdelete_window static again. Move down
5603 declaration of select_count.
5604 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5605 (Fother_window): Move to window.el.
5606 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5607 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5608 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5610 (replace_buffer_in_windows): Implement by calling
5611 Qreplace_buffer_in_windows.
5612 (replace_buffer_in_all_windows): Remove with some functionality
5613 moved into replace_buffer_in_windows_safely.
5614 (replace_buffer_in_windows_safely): New function.
5615 (select_window_norecord, select_frame_norecord): Move in front
5616 of run_window_configuration_change_hook. Remove now obsolete
5618 (Fset_window_buffer): Rewrite doc-string.
5619 Call Qrecord_window_buffer.
5620 (keys_of_window): Move binding for other-window to window.el.
5622 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5624 * dispextern.h (struct image): Replace data member, whose int_val
5625 and ptr_val fields were not used by anything, with a single
5628 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5629 (gif_clear_image, gif_load, imagemagick_load_image)
5630 (gs_clear_image, gs_load): Callers changed.
5632 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5634 * buffer.h: Include <time.h>, for time_t.
5635 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5637 Fix minor problems found by static checking.
5639 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5641 Make identifiers static if they are not used in other modules.
5642 * data.c (Qcompiled_function, Qframe, Qvector):
5643 * image.c (QimageMagick, Qsvg):
5644 * minibuf.c (Qmetadata):
5645 * window.c (resize_window_check, resize_root_window): Now static.
5646 * window.h (resize_window_check, resize_root_window): Remove decls.
5648 * window.c (window_deletion_count, delete_deletable_window):
5650 (window_body_lines): Now static.
5651 (Fdelete_other_windows_internal): Mark vars as initialized.
5652 Make sure 'resize_failed' is initialized.
5653 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5654 (resize_window_apply): Remove unused local.
5655 * window.h (delete_deletable_window): Remove decl.
5657 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5658 (imagemagick_load_image): Fix pointer signedness problem by changing
5659 last arg from unsigned char * to char *. All uses changed.
5660 Also, fix a local for similar reasons.
5661 Remove unused locals. Remove locals to avoid shadowing.
5662 (fn_rsvg_handle_free): Remove; unused.
5663 (svg_load, svg_load_image): Fix pointer signedness problem.
5664 (imagemagick_load_image): Don't use garbage pointer image_wand.
5666 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5668 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5670 * image.c (gif_load): Fix omitted cast error introduced by
5673 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5675 * window.h (resize_proportionally, orig_total_lines)
5676 (orig_top_line): Remove from window structure.
5677 (set_window_height, set_window_width, change_window_heights)
5678 (Fdelete_window): Remove prototypes.
5679 (resize_frame_windows): Remove duplicate declaration.
5681 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5683 * window.h (resize_frame_windows, resize_window_check)
5684 (delete_deletable_window, resize_root_window)
5685 (resize_frame_windows): Declare prototypes.
5687 * window.c (resize_window_apply): Make definition be "static" to
5688 match the prototype.
5690 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5692 * window.c: Remove declarations of Qwindow_size_fixed,
5693 window_min_size_1, window_min_size_2, window_min_size,
5694 size_window, window_fixed_size_p, enlarge_window, delete_window.
5695 Remove static from declaration of Qdelete_window, it's
5696 temporarily needed by Fbury_buffer.
5697 (replace_window): Don't assign orig_top_line and
5699 (Fdelete_window, delete_window): Remove. Window deletion is
5700 handled by window.el.
5701 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5702 Replace Fdelete_window calls with calls to Qdelete_window.
5703 (Fdelete_other_windows): Remove. Deleting other windows is
5704 handled by window.el.
5705 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5706 handled in window.el.
5707 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5708 Window minimum sizes are handled in window.el.
5709 (shrink_windows, size_window, set_window_height)
5710 (set_window_width, change_window_heights, window_height)
5711 (window_width, CURBEG, CURSIZE, enlarge_window)
5712 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5713 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5714 handled in window.el.
5715 (make_dummy_parent): Rename to make_parent_window and give it a
5716 second argument horflag.
5717 (make_window): Don't set resize_proportionally any more.
5718 (Fsplit_window): Remove. Windows are split in window.el.
5719 (save_restore_action, save_restore_orig_size)
5720 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5721 Resize mini windows in window.el.
5722 (grow_mini_window, shrink_mini_window): Implement by calling
5723 Qresize_root_window_vertically, resize_window_check and
5724 resize_window_apply.
5725 (saved_window, Fset_window_configuration, save_window_save):
5726 Do not handle orig_top_line, orig_total_lines, and
5727 resize_proportionally.
5728 (window_min_height, window_min_width): Move to window.el.
5729 (keys_of_window): Move bindings for delete-other-windows,
5730 split-window, delete-window and enlarge-window to window.el.
5732 * buffer.c: Temporarily extern Qdelete_window.
5733 (Fbury_buffer): Temporarily call Qdelete_window instead of
5734 Fdelete_window (Fbury_buffer will move to window.el soon).
5736 * frame.c (set_menu_bar_lines_1): Remove code handling
5737 orig_top_line and orig_total_lines.
5739 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5740 set_window_height but set heights directly.
5741 (change_frame_size_1): Use resize_frame_windows.
5743 * xdisp.c (init_xdisp): Don't use set_window_height but set
5746 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5747 Use resize_frame_windows instead of change_window_heights and run
5748 run_window_configuration_change_hook.
5750 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5751 instead of change_window_heights and run
5752 run_window_configuration_change_hook.
5754 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5756 * window.c (replace_window): Rename second argument REPLACEMENT to
5757 NEW. New third argument SETFLAG. Rewrite.
5758 (delete_window, make_dummy_parent): Call replace_window with
5760 (window_list_1): Move down in code.
5761 (run_window_configuration_change_hook): Move set_buffer part
5762 before select_frame_norecord part in order to unwind correctly.
5763 Rename count1 to count.
5764 (recombine_windows, delete_deletable_window, resize_root_window)
5765 (Fdelete_other_windows_internal)
5766 (Frun_window_configuration_change_hook, make_parent_window)
5767 (resize_window_check, resize_window_apply, Fresize_window_apply)
5768 (resize_frame_windows, Fsplit_window_internal)
5769 (Fdelete_window_internal, Fresize_mini_window_internal):
5771 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5773 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5775 * window.h (window): Add some new members to window structure -
5776 normal_lines, normal_cols, new_total, new_normal, clone_number,
5777 splits, nest, prev_buffers, next_buffers.
5778 (WINDOW_TOTAL_SIZE): Move here from window.c.
5779 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5781 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5783 (make_dummy_parent): Set new members of windows structure.
5784 (make_window): Move down in code. Handle new members of window
5786 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5787 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5788 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5789 (Fset_window_prev_buffers, Fwindow_next_buffers)
5790 (Fset_window_next_buffers, Fset_window_clone_number):
5792 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5793 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5795 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5796 Argument WINDOW can be now internal window too.
5797 (Fwindow_use_time): Move up in code.
5798 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5800 (Fset_window_configuration, saved_window)
5801 (Fcurrent_window_configuration, save_window_save): Handle new
5802 members of window structure.
5803 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5804 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5805 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5806 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5807 Qget_mru_window, Qresize_root_window,
5808 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5809 Qauto_buffer_name; staticpro them.
5811 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5813 * window.c (Fwindow_total_size, Fwindow_left_column)
5814 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5815 (Fwindow_list_1): New functions.
5816 (window_box_text_cols): Replace with window_body_cols.
5817 (Fwindow_width, Fscroll_left, Fscroll_right):
5818 Use window_body_cols instead of window_box_text_cols.
5819 (delete_window, Fset_window_configuration):
5820 Call delete_all_subwindows with window as argument.
5821 (delete_all_subwindows): Take a window as argument and not a
5823 (window_loop): Remove handling of GET_LRU_WINDOW and
5825 (Fget_lru_window, Fget_largest_window): Move to window.el.
5827 * window.h: Extern window_body_cols instead of
5828 window_box_text_cols. delete_all_subwindows now takes a
5829 Lisp_Object as argument.
5831 * indent.c (compute_motion, Fcompute_motion):
5832 Use window_body_cols instead of window_box_text_cols.
5834 * frame.c (delete_frame): Call delete_all_subwindows with root
5837 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5839 * fns.c (Fputhash): Document return value.
5841 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5843 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5845 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5847 Cons<->int and similar integer overflow fixes (Bug#8794).
5849 Check for overflow when converting integer to cons and back.
5850 * charset.c (Fdefine_charset_internal, Fdecode_char):
5851 Use cons_to_unsigned to catch overflow.
5852 (Fencode_char): Use INTEGER_TO_CONS.
5853 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5854 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5855 * data.c (long_to_cons, cons_to_long): Remove.
5856 (cons_to_unsigned, cons_to_signed): New functions.
5857 These signal an error for invalid or out-of-range values.
5858 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5859 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5860 * font.c (Ffont_variation_glyphs):
5861 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5862 * lisp.h: Include <intprops.h>.
5863 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5864 (cons_to_signed, cons_to_unsigned): New decls.
5865 (long_to_cons, cons_to_long): Remove decls.
5866 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5867 (Fprimitive_undo): Use CONS_TO_INTEGER.
5868 * xfns.c (Fx_window_property): Likewise.
5869 * xselect.c: Include <limits.h>.
5870 (x_own_selection, selection_data_to_lisp_data):
5871 Use INTEGER_TO_CONS.
5872 (x_handle_selection_request, x_handle_selection_clear)
5873 (x_get_foreign_selection, Fx_disown_selection_internal)
5874 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5875 (lisp_data_to_selection_data): Use cons_to_unsigned.
5876 (x_fill_property_data): Use cons_to_signed.
5877 Report values out of range.
5879 Check for buffer and string overflow more precisely.
5880 * buffer.h (BUF_BYTES_MAX): New macro.
5881 * lisp.h (STRING_BYTES_MAX): New macro.
5882 * alloc.c (Fmake_string):
5883 * character.c (string_escape_byte8):
5884 * coding.c (coding_alloc_by_realloc):
5885 * doprnt.c (doprnt):
5886 * editfns.c (Fformat):
5888 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5889 since they may not be the same number.
5890 * editfns.c (Finsert_char):
5891 * fileio.c (Finsert_file_contents):
5892 Likewise for BUF_BYTES_MAX.
5894 * image.c: Use ptrdiff_t, not int, for sizes.
5895 (slurp_file): Switch from int to ptrdiff_t.
5897 (slurp_file): Check that file size fits in both size_t (for
5898 malloc) and ptrdiff_t (for sanity and safety).
5900 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5901 if b->modtime has its maximal value.
5903 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5905 Don't assume time_t can fit into int.
5906 * buffer.h (struct buffer.modtime): Now time_t, not int.
5907 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5908 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5910 Minor fixes for signed vs unsigned integers.
5911 * character.h (MAYBE_UNIFY_CHAR):
5912 * charset.c (maybe_unify_char):
5913 * keyboard.c (read_char, reorder_modifiers):
5914 XINT -> XFASTINT, since the integer must be nonnegative.
5915 * ftfont.c (ftfont_spec_pattern):
5916 * keymap.c (access_keymap, silly_event_symbol_error):
5917 XUINT -> XFASTINT, since the integer must be nonnegative.
5918 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5919 since it makes no difference and we prefer signed.
5920 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5921 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5924 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5926 * window.h (Fwindow_frame): Declare.
5928 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5930 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5931 (SPARE_MEMORY): Always define.
5932 (LARGE_REQUEST): Remove.
5933 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5935 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5937 * lisp.h: Move EXFUNS for Fframe_root_window,
5938 Fframe_first_window and Fset_frame_selected_window to window.h.
5940 * window.h: Move EXFUNS for Fframe_root_window,
5941 Fframe_first_window and Fset_frame_selected_window here from
5944 * frame.c (Fwindow_frame, Fframe_first_window)
5945 (Fframe_root_window, Fframe_selected_window)
5946 (Fset_frame_selected_window): Move to window.c.
5947 (Factive_minibuffer_window): Move to minibuf.c.
5948 (Fother_visible_frames_p): New function.
5950 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5952 * window.c (decode_window, decode_any_window): Move up in code.
5953 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5954 (inhibit_frame_unsplittable): Remove unused variable.
5955 (Fwindow_buffer): Move up and rewrite doc-string.
5956 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5957 (Fwindow_prev): New functions.
5958 (Fwindow_frame): Move here from frame.c. Accept any window as
5960 (Fframe_root_window, Fframe_first_window)
5961 (Fframe_selected_window): Move here from frame.c. Accept frame
5962 or arbitrary window as argument. Update doc-strings.
5963 (Fminibuffer_window): Move up in code.
5964 (Fwindow_minibuffer_p): Move up in code and simplify.
5965 (Fset_frame_selected_window): Move here from frame.c.
5967 (Fselected_window, select_window, Fselect_window): Move up in
5968 code. Minor doc-string fixes.
5970 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5972 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5973 Do not assume that spare memory exists; that assumption is valid
5974 only if SYSTEM_MALLOC.
5975 (LARGE_REQUEST): New macro, so that the issue of large requests
5976 is separated from the issue of spare memory.
5978 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5980 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5983 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5985 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5988 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5990 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5992 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5994 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5995 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5997 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5999 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6001 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6003 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6004 (x_clipboard_manager_save): Add return value.
6005 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6007 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6008 Obey Vx_select_enable_clipboard_manager. Catch errors in
6009 x_clipboard_manager_save (Bug#8779).
6010 (Vx_select_enable_clipboard_manager): New variable.
6011 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6013 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6015 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6017 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6019 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6020 in the current matrix if keep_current_p is non-zero.
6022 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6024 * bidi.c (bidi_level_of_next_char): Fix last change.
6026 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6028 Support bidi reordering of text covered by display properties.
6030 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6031 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6032 (bidi_cache_search, bidi_cache_iterator_state)
6033 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6034 (bidi_level_of_next_char, bidi_move_to_visually_next):
6035 Support character positions inside a run of characters covered by a
6037 (bidi_paragraph_init, bidi_resolve_explicit_1)
6038 (bidi_level_of_next_char): Call bidi_fetch_char and
6039 bidi_fetch_char_advance instead of FETCH_CHAR and
6041 (bidi_init_it): Initialize new members.
6042 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6044 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6045 instead of using explicit *_CHAR codes.
6046 (bidi_resolve_explicit, bidi_resolve_weak):
6047 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6048 bidirectional text is supported only in multibyte buffers.
6049 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6050 it to initialize the frame_window_p member of struct bidi_it.
6051 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6052 (bidi_resolve_explicit, bidi_resolve_weak)
6053 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6054 bidi_it->nchars is non-positive.
6055 (bidi_level_of_next_char): Don't try to lookup the cache for the
6056 next/previous character if nothing is cached there yet, or if we
6057 were just reseat()'ed to a new position.
6059 * xdisp.c (set_cursor_from_row): Set start and stop points
6060 according to the row's direction when priming the loop that looks
6061 for the glyph on which to display cursor.
6062 (single_display_spec_intangible_p): Function deleted.
6063 (display_prop_intangible_p): Reimplement to call
6064 handle_display_spec instead of single_display_spec_intangible_p.
6065 Accept 3 additional arguments needed by handle_display_spec.
6066 This fixes incorrect cursor motion across display property with complex
6067 values: lists, `(when COND...)' forms, etc.
6068 (single_display_spec_string_p): Support property values that are
6069 lists with the argument STRING its top-level element.
6070 (display_prop_string_p): Fix the condition for processing a
6071 property that is a list to be consistent with handle_display_spec.
6072 (handle_display_spec): New function, refactored from the
6073 last portion of handle_display_prop.
6074 (compute_display_string_pos): Accept additional argument
6075 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6076 value of a `display' property is a "replacing spec".
6077 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6078 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6079 the display property, but just return a value indicating whether
6080 the display property will replace the characters it covers.
6081 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6082 frame_window_p members of struct bidi_it.
6083 (compute_display_string_pos, compute_display_string_end):
6085 (push_it): Accept second argument POSITION, where pop_it should
6086 jump to continue iteration.
6087 (reseat_1): Initialize bidi_it.disp_pos.
6089 * keyboard.c (adjust_point_for_property): Adjust the call to
6090 display_prop_intangible_p to its new signature.
6092 * dispextern.h (struct bidi_it): New member frame_window_p.
6093 (bidi_init_it): Update prototypes.
6094 (display_prop_intangible_p): Update prototype.
6095 (compute_display_string_pos, compute_display_string_end):
6097 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6100 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6102 Malloc failure behavior now depends on size of allocation.
6103 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6104 * lisp.h: Change signatures accordingly.
6105 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6106 All callers changed. (Bug#8762)
6108 * gnutls.c: Use Emacs's memory allocators.
6109 Without this change, the gnutls library would invoke malloc etc.
6110 directly, which causes problems on non-SYNC_INPUT hosts, and which
6111 runs afoul of improving memory_full behavior. (Bug#8761)
6112 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6113 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6114 xfree instead of the default malloc, realloc, free.
6115 (Fgnutls_boot): No need to check for memory allocation failure,
6116 since xmalloc does that for us.
6118 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6119 * category.c (hash_get_category_set):
6120 * ccl.c (ccl_driver):
6121 * charset.c (Fdefine_charset_internal):
6122 * charset.h (struct charset.hash_index):
6123 * composite.c (get_composition_id, gstring_lookup_cache)
6124 (composition_gstring_put_cache):
6125 * composite.h (struct composition.hash_index):
6126 * dispextern.h (struct image.hash):
6127 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6128 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6129 (hashfn_equal, hashfn_user_defined, make_hash_table)
6130 (maybe_resize_hash_table, hash_lookup, hash_put)
6131 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6132 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6133 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6134 * image.c (make_image, search_image_cache, lookup_image)
6135 (xpm_put_color_table_h):
6136 * lisp.h (struct Lisp_Hash_Table):
6137 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6138 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6139 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6140 * alloc.c (allocate_vectorlike):
6141 Check for overflow in vector size calculations.
6142 * ccl.c (ccl_driver):
6143 Check for overflow when converting EMACS_INT to int.
6144 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6145 need to be updated by these changes.
6146 * fns.c (make_hash_table, maybe_resize_hash_table):
6147 Check for integer overflow with large hash tables.
6148 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6149 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6150 (SXHASH_REDUCE): New macro.
6151 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6152 Use it instead of discarding useful hash info with large hash values.
6153 (sxhash_float): New function.
6154 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6155 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6156 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6157 Rewrite to use FIXNUM_BITS, as this simplifies things.
6158 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6159 Adjust signatures to match updated version of code.
6160 (consing_since_gc): Now EMACS_INT, since a single hash table can
6161 use more than INT_MAX bytes.
6163 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6165 Make it possible to build with GCC-4.6+ -O2 -flto.
6167 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6169 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6171 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6172 Call minibuffer-inactive-mode.
6174 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6176 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6177 Update dependencies.
6179 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6181 * data.c (init_data): Remove code for UTS, this system is not
6184 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6186 Don't force ./temacs to start in terminal mode.
6188 * frame.c (make_initial_frame): Initialize faces in all cases, not
6189 only when CANNOT_DUMP is defined.
6190 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6192 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6194 * dispnew.c (add_window_display_history): Use const for the string
6195 pointer. Remove declaration, not needed.
6197 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6199 Use 'inline', not 'INLINE'.
6200 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6201 * alloc.c, fontset.c (INLINE): Remove.
6202 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6203 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6204 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6205 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6206 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6208 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6210 Make it possible to run ./temacs.
6212 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6213 syms_of_callproc does the same thing. Remove test for
6214 "initialized", do it in the caller.
6215 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6217 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6219 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6220 (read_minibuf): Use get_minibuffer.
6221 (syms_of_minibuf): Use DEFSYM.
6222 (Qmetadata): New var.
6223 * data.c (Qbuffer): Don't make it static.
6224 (syms_of_data): Use DEFSYM.
6226 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6228 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6229 (CCL_CODE_MIN): New macro.
6231 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6233 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6235 * eval.c (Qdebug): Now static.
6236 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6237 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6238 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6240 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6242 * image.c: Various fixes to ImageMagick code comments.
6243 (Fimagemagick_types): Doc fix.
6245 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6247 Minor fixes prompted by GCC 4.6.0 warnings.
6249 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6251 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6252 (x_clipboard_manager_save_all): Move extern decl to ...
6253 * xterm.h: ... here, so that it can be checked for consistency.
6255 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6257 * xselect.c (x_clipboard_manager_save_frame)
6258 (x_clipboard_manager_save_all): New functions.
6259 (Fx_clipboard_manager_save): Lisp function deleted.
6261 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6262 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6264 * xterm.h: Update prototype.
6266 2011-05-28 William Xu <william.xwl@gmail.com>
6268 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6271 2011-05-28 Jim Meyering <meyering@redhat.com>
6273 Avoid a sign-extension bug in crypto_hash_function.
6274 * fns.c (to_uchar): Define.
6275 (crypto_hash_function): Use it to convert some newly-signed
6276 variables to unsigned, to avoid sign-extension bugs. For example,
6277 without this change, (md5 "truc") would evaluate to
6278 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6279 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6280 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6282 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6284 Integer overflow fixes.
6286 * dbusbind.c: Serial number integer overflow fixes.
6287 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6288 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6289 to hold a serial number that is too large for a fixnum.
6290 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6291 Check for serial numbers out of range. Decode any serial number
6292 that was so large that it became a float. (Bug#8722)
6294 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6295 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6296 Use XFASTINT rather than XUINT when numbers are nonnegative.
6297 (xd_append_arg, Fdbus_method_return_internal):
6298 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6299 arguments, check that Lisp number is nonnegative, rather than
6300 silently wrapping negative numbers around. (Bug#8722)
6301 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6304 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6306 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6308 ccl: Add integer overflow checks.
6309 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6310 (IN_INT_RANGE): New macros.
6311 (ccl_driver): Use them to check for integer overflow when
6312 decoding a CCL program. Many of the new checks are whether XINT (x)
6313 fits in int; it doesn't always, on 64-bit hosts. The new version
6314 doesn't catch all possible integer overflows, but it's an
6315 improvement. (Bug#8719)
6317 * alloc.c (make_event_array): Use XINT, not XUINT.
6318 There's no need for unsigned here.
6320 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6321 This follows up to the 2011-05-06 change that substituted uintptr_t
6322 for EMACS_INT. This case wasn't caught back then.
6324 Rework Fformat to avoid integer overflow issues.
6325 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6326 now (part of C89). Include <verify.h>.
6327 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6328 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6329 (Fformat): Avoid the prepass trying to compute sizes; it was only
6330 approximate and thus did not catch overflow reliably. Instead, walk
6331 through the format just once, formatting and computing sizes as we go,
6332 checking for integer overflow at every step, and allocating a larger
6333 buffer as needed. Keep track separately whether the format is
6334 multibyte. Keep only the most-recently calculated precision, rather
6335 than them all. Record whether each argument has been converted to
6336 string. Use EMACS_INT, not int, for byte and char and arg counts.
6337 Support field widths and precisions larger than INT_MAX. Avoid
6338 sprintf's undefined behavior with conversion specifications such as %#d
6339 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6340 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6341 formatting out-of-range floating point numbers with int
6344 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6346 * data.c: Avoid integer truncation in expressions involving floats.
6347 * data.c: Include <intprops.h>.
6348 (arith_driver): When there's an integer overflow in an expression
6349 involving floating point, convert the integers to floating point
6350 so that the resulting value does not suffer from catastrophic
6351 integer truncation. For example, on a 64-bit host (* 4
6352 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6353 Do not rely on undefined behavior after integer overflow.
6355 merge count_size_as_multibyte, parse_str_to_multibyte
6356 * character.c, character.h (count_size_as_multibyte):
6357 Rename from parse_str_to_multibyte; all uses changed.
6358 Check for integer overflow.
6359 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6360 since it's now a duplicate of the other. This is more of
6361 a character than a buffer op, so better that it's in character.c.
6362 * fns.c, print.c: Adjust to above changes.
6364 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6366 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6368 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6370 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6371 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6372 (x_clipboard_manager_save): Now static.
6373 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6375 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6376 (crypto_hash_function): Now static.
6377 Fix pointer signedness problems. Avoid unnecessary initializations.
6379 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6381 * termhooks.h (Vselection_alist): Make it terminal-local.
6383 * terminal.c (create_terminal): Initialize it.
6385 * xselect.c: Support for clipboard managers.
6386 (Vselection_alist): Move to termhooks.h as terminal-local var.
6387 (LOCAL_SELECTION): New macro.
6388 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6389 (symbol_to_x_atom): Remove gratuitous arg.
6390 (x_handle_selection_request, lisp_data_to_selection_data)
6391 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6392 (x_own_selection, x_get_local_selection, x_convert_selection):
6393 New arg, specifying work frame. Use terminal-local Vselection_alist.
6394 (some_frame_on_display): Delete unused function.
6395 (Fx_own_selection_internal, Fx_get_selection_internal)
6396 (Fx_disown_selection_internal, Fx_selection_owner_p)
6397 (Fx_selection_exists_p): New optional frame arg.
6398 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6399 (x_handle_selection_clear): Don't treat other terminals with the
6400 same keyboard specially. Use the terminal-local Vselection_alist.
6401 (x_clear_frame_selections): Use Frun_hook_with_args.
6403 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6405 * xterm.h: Add support for those atoms.
6407 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6409 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6410 (converted_selections, conversion_fail_tag): New global variables.
6411 (x_selection_request_lisp_error): Free the above.
6412 (x_get_local_selection): Remove unnecessary code.
6413 (x_reply_selection_request): Args changed; handle arbitrary array
6414 of converted selections stored in converted_selections.
6415 Separate the XChangeProperty and SelectionNotify steps.
6416 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6417 (x_convert_selection): New function.
6418 (x_handle_selection_event): Simplify.
6419 (x_get_foreign_selection): Don't ignore incoming requests while
6420 waiting for an answer; this will fail when we implement
6421 SAVE_TARGETS, and seems unnecessary anyway.
6422 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6423 (Vx_sent_selection_functions): Doc fix.
6425 2011-05-26 Leo Liu <sdl.web@gmail.com>
6427 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6429 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6431 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6433 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6434 for fringe update if it has periodic bitmap.
6435 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6436 and fringe_bitmap_periodic_p.
6438 * fringe.c (get_fringe_bitmap_data): New function.
6439 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6440 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6441 row. Mark glyph row for fringe update if periodicity changed.
6443 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6444 for fringe update unless it has periodic bitmap.
6446 2011-05-25 Kenichi Handa <handa@m17n.org>
6448 * xdisp.c (get_next_display_element): Set correct it->face_id for
6449 a static composition.
6451 2011-05-24 Leo Liu <sdl.web@gmail.com>
6454 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6456 * fns.c (crypto_hash_function, Fsha1): New function.
6457 (Fmd5): Use crypto_hash_function.
6458 (syms_of_fns): Add Ssha1.
6460 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6462 * gnutls.c: Remove unused macros.
6463 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6464 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6465 Remove macros that are defined and never used.
6466 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6468 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6470 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6471 (Fx_get_selection_internal): Minor cleanup.
6472 (Fx_own_selection_internal): Rename arguments for consistency with
6475 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6477 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6479 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6481 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6483 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6485 * dispnew.c (scrolling_window): Don't exclude the case that the
6486 last enabled row in the desired matrix touches the bottom boundary.
6488 2011-05-21 Glenn Morris <rgm@gnu.org>
6490 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6491 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6492 and add some more files.
6494 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6496 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6497 report_file_error introduced by the change from 2011-05-07.
6499 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6501 * systime.h (Time): Define only if emacs is defined.
6502 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6503 where the include path doesn't have X11/X.h by default. See
6504 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6506 2011-05-20 Kenichi Handa <handa@m17n.org>
6508 * composite.c (find_automatic_composition): Fix previous change.
6510 2011-05-20 Glenn Morris <rgm@gnu.org>
6512 * lisp.mk: New file, split from Makefile.in.
6513 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6514 (shortlisp): Remove.
6515 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6517 2011-05-19 Glenn Morris <rgm@gnu.org>
6519 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6520 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6521 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6522 (lisp): Set the order to that of loadup.el.
6523 (shortlisp): Make it a copy of $lisp.
6524 (SOME_MACHINE_LISP): Remove.
6525 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6526 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6528 2011-05-18 Kenichi Handa <handa@m17n.org>
6530 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6531 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6532 (find_automatic_composition): Mostly rewrite for efficiency.
6534 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6536 * makefile.w32-in: Update dependencies.
6538 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6540 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6541 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6543 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6545 Fix some integer overflow issues, such as string length overflow.
6547 * insdel.c (count_size_as_multibyte): Check for string overflow.
6549 * character.c (lisp_string_width): Check for string overflow.
6550 Use EMACS_INT, not int, for string indexes and lengths; in
6551 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6552 the resulting string length overflows an EMACS_INT; instead,
6553 report a string overflow if no precision given. When checking for
6554 precision exhaustion, use a check that cannot possibly have
6555 integer overflow. (Bug#8675)
6556 * character.h (lisp_string_width): Adjust to new signature.
6558 * alloc.c (string_overflow): New function.
6559 (Fmake_string): Use it. This doesn't change behavior, but saves
6560 a few bytes and will simplify future changes.
6561 * character.c (string_escape_byte8): Likewise.
6562 * lisp.h (string_overflow): New decl.
6564 Fixups, following up to the user-interface timestamp change.
6565 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6566 for UI timestamps, instead of unsigned long.
6567 * msdos.c (mouse_get_pos): Likewise.
6568 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6569 * w32gui.h (Time): Define by including "systime.h" rather than by
6570 declaring it ourselves. (Bug#8664)
6572 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6573 * image.c (clear_image_cache): Likewise.
6575 * term.c (term_mouse_position): Don't assume time_t wraparound.
6577 Be more systematic about user-interface timestamps.
6578 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6579 and sometimes 'EMACS_UINT', to represent these timestamps.
6580 This change causes it to use 'Time' uniformly, as that's what X uses.
6581 This makes the code easier to follow, and makes it easier to catch
6582 integer overflow bugs such as Bug#8664.
6583 * frame.c (Fmouse_position, Fmouse_pixel_position):
6584 Use Time, not unsigned long, for user-interface timestamps.
6585 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6586 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6587 * keyboard.h (last_event_timestamp): Likewise.
6588 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6589 * menu.h (xmenu_show): Likewise.
6590 * term.c (term_mouse_position): Likewise.
6591 * termhooks.h (struct input_event.timestamp): Likewise.
6592 (struct terminal.mouse_position_hook): Likewise.
6593 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6594 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6595 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6596 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6598 * menu.h, termhooks.h: Include "systime.h", for Time.
6600 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6601 Don't assume that the difference between two unsigned long values
6602 can fit into an integer. At this point, we know button_down_time
6603 <= event->timestamp, so the difference must be nonnegative, so
6604 there's no need to cast the result if double-click-time is
6605 nonnegative, as it should be; check that it's nonnegative, just in
6606 case. This bug is triggered when events are more than 2**31 ms
6607 apart (about 25 days). (Bug#8664)
6609 * xselect.c (last_event_timestamp): Remove duplicate decl.
6610 (x_own_selection): Remove needless cast to unsigned long.
6612 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6613 that always fit in int. Use a sentinel instead of a counter, to
6614 avoid a temp and to allay GCC's concerns about possible int overflow.
6615 * frame.h (struct frame): Use int for menu_bar_items_used
6616 instead of EMACS_INT, since it always fits in int.
6618 * menu.c (grow_menu_items): Check for int overflow.
6620 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6622 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6623 Before, the code was not consistent. These values cannot exceed
6624 2**31 - 1 so there's no need to make them unsigned.
6625 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6626 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6627 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6629 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6631 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6632 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6633 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6634 presumably because the widths might not match.
6636 * window.c (size_window): Avoid needless test at loop start.
6638 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6640 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6642 2011-05-12 Drew Adams <drew.adams@oracle.com>
6644 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6646 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6648 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6649 `width' to `bar_area_x' and `bar_area_width', respectively.
6650 (x_scroll_run): Take account of fringe background extension.
6652 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6653 Rename local vars `left' and `width' to `bar_area_x' and
6654 `bar_area_width', respectively.
6655 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6656 background extension.
6658 2011-05-10 Jim Meyering <meyering@redhat.com>
6660 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6662 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6664 * image.c (Finit_image_library): Return t for built-in image types,
6665 like pbm and xbm. (Bug#8640)
6667 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6669 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6671 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6673 * w32console.c (Fset_screen_color): Doc fix.
6674 (Fget_screen_color): New function.
6675 (syms_of_ntterm): Defsubr it.
6677 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6678 unlink the temporary file if Fcall_process didn't create it in the
6680 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6681 child process will be redirected to a file specified with `:file'.
6682 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6683 cue to call_process_cleanup not to close that handle.
6685 2011-05-07 Ben Key <bkey76@gmail.com>
6687 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6688 one of two shell specific rules, either bootstrap-temacs-CMD or
6689 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6690 to the previous implementation of the bootstrap-temacs rule.
6691 The bootstrap-temacs-CMD rule is similar to the previous
6692 implementation of the bootstrap-temacs rule except that it
6693 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6696 These changes, along with some changes to nt/configure.bat,
6697 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6698 earlier fix to add support for --cflags and --ldflags options
6699 that include quotes so that it works whether make uses cmd or
6702 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6704 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6705 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6707 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6708 a string. Handle both cases.
6709 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6710 (Fdbus_register_method): Use Qinvalid_function.
6712 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6714 * makefile.w32-in: Update dependencies.
6715 (LISP_H): Add inttypes.h and stdin.h.
6716 (PROCESS_H): Add unistd.h.
6718 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6720 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6721 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6723 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6725 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6727 * term.c (vfatal): Remove stray call to va_end.
6728 It's not needed and the C Standard doesn't allow it here anyway.
6730 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6731 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6733 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6736 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6738 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6740 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6742 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6744 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6746 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6747 * charset.c (Fdefine_charset_internal): Don't initialize
6748 charset.code_space[15]. The value was garbage, on hosts with
6749 32-bit int (Bug#8600).
6751 * lread.c (read_integer): Be more consistent with string-to-number.
6752 Use string_to_number to do the actual conversion; this avoids
6753 rounding errors and fixes some other screwups. Without this fix,
6754 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6755 (digit_to_number): Move earlier, for benefit of read_integer.
6756 Return -1 if the digit is out of range for the base, -2 if it is
6757 not a digit in any supported base. (Bug#8602)
6759 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6761 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6762 to match comment at start of function. This also removes a
6763 GCC warning about overflow in a 32+64-bit port.
6765 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6767 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6768 Reported by Stefan Monnier in
6769 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6770 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6771 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6773 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6774 (EMACS_UINTPTR): Likewise, with uintptr_t.
6776 * lisp.h: Prefer 64-bit EMACS_INT if available.
6777 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6778 on 32-bit hosts that have 64-bit int, so that they can access
6780 However, temporarily disable this change unless the temporary
6781 symbol WIDE_EMACS_INT is defined.
6783 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6785 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6786 This removes an assumption that EMACS_INT and long are the same
6787 width as pointers. The assumption is true for Emacs porting targets
6788 now, but we want to make other targets possible.
6789 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6790 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6791 In the rest of the code, change types of integers that hold casted
6792 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6793 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6794 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6795 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6796 No need to cast type when ORing.
6797 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6798 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6799 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6800 assume EMACS_INT is the same width as char *.
6801 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6802 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6803 Remove no-longer-needed casts.
6804 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6805 (xg_tool_bar_help_callback, xg_make_tool_item):
6806 Use EMACS_INTPTR to hold an integer
6807 that will be cast to void *; this can avoid a GCC warning
6808 if EMACS_INT is not the same width as void *.
6809 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6810 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6811 (current_message_1, set_message_1):
6812 Use a local to convert to proper width without a cast.
6813 * xmenu.c (dialog_selection_callback): Likewise.
6815 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6816 Also, don't assume VALBITS / RAND_BITS is less than 5,
6817 and don't rely on undefined behavior when shifting a 1 left into
6819 * lisp.h (get_random): Change signature to match.
6821 * lread.c (hash_string): Use size_t, not int, for hash computation.
6822 Normally we prefer signed values; but hashing is special, because
6823 it's better to use unsigned division on hash table sizes so that
6824 the remainder is nonnegative. Also, size_t is the natural width
6825 for hashing into memory. The previous code used 'int', which doesn't
6826 retain enough info to hash well into very large tables.
6827 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6829 * dbusbind.c: Don't possibly lose pointer info when converting.
6830 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6831 Use XPNTR rather than XHASH, so that the high-order bits of
6832 the pointer aren't lost when converting through void *.
6834 * eval.c (Fautoload): Don't double-shift a pointer.
6836 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6838 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6840 * gnutls.c (DEF_GNUTLS_FN):
6841 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6843 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6845 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6848 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6850 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6851 New version that can reserve upto 2GB of heap space.
6853 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6855 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6857 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6859 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6860 `gnutls_certificate_set_x509_key_file'.
6862 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6864 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6865 Update dependencies.
6867 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6869 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6870 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6871 Remove unused parameter `fildes'.
6872 * process.c (read_process_output, send_process): Don't pass it.
6874 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6876 Fix previous change: the library cache is defined in w32.c.
6877 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6878 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6880 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6882 Implement dynamic loading of GnuTLS on Windows.
6884 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6885 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6886 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6889 * gnutls.c (Qgnutls_dll): Define.
6890 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6891 (gnutls_*): Declare function pointers.
6892 (init_gnutls_functions): New function to initialize function pointers.
6893 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6894 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6895 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6896 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6897 (emacs_gnutls_write, emacs_gnutls_read)
6898 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6899 (Fgnutls_available_p): New function.
6900 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6901 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6902 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6904 * image.c: Include w32.h.
6905 (Vimage_type_cache): Delete.
6906 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6907 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6908 (w32_delayed_load): Move to w32.c.
6910 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6912 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6913 (w32_delayed_load): Move from image.c. When loading a library, record
6914 its filename in the :loaded-from property of the library id.
6915 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6916 Initialize and staticpro them.
6917 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6919 * process.c: Include lisp.h before w32.h, not after.
6920 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6921 instead of gnutls_record_check_pending.
6923 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6925 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6927 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6928 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6931 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6933 * xterm.c (x_set_frame_alpha): Do not set property on anything
6934 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6936 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6938 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6940 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6942 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6943 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6944 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6945 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6946 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6947 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6948 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6949 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6950 (Qgnutls_bootprop_callbacks_verify): Make static.
6952 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6954 * callproc.c: Indentation fixup.
6956 * sysdep.c (wait_for_termination_1): Make static.
6957 (wait_for_termination, interruptible_wait_for_termination):
6958 Move after wait_for_termination_1.
6960 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6962 * sysdep.c (interruptible_wait_for_termination): New function
6963 which is like wait_for_termination, but allows keyboard
6966 * callproc.c (Fcall_process): Add (:file "file") as an option for
6968 (Fcall_process_region): Ditto.
6970 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6972 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6973 rather than `XVECTOR (FOO)->size'.
6975 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6976 inttypes.h, as a gnulib replacement is used if it not available in
6979 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6981 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6982 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6983 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6985 * coding.c (coding_alloc_by_realloc): Error out if destination
6986 will grow beyond MOST_POSITIVE_FIXNUM.
6987 (decode_coding_emacs_mule): Abort if there isn't enough place in
6988 charbuf for the composition carryover bytes. Reserve an extra
6989 space for up to 2 characters produced in a loop.
6990 (decode_coding_iso_2022): Abort if there isn't enough place in
6991 charbuf for the composition carryover bytes.
6993 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6995 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6996 aborting when %lld or %lll format is passed.
6997 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6998 %llo or %llx format is passed. (Bug#8545)
7000 * window.c (window_scroll_line_based): Use a marker instead of
7001 simple variables to record original value of point. (Bug#7952)
7003 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7004 produced by %s or %c overflows available buffer space. (Bug#8545)
7006 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7008 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7009 (SIZE_MAX): Move defn after all includes, as they might #define it.
7011 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7013 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7015 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7017 * keyboard.c (Qdelayed_warnings_hook): Define.
7018 (command_loop_1): Run `delayed-warnings-hook'
7019 if Vdelayed_warnings_list is non-nil.
7020 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7021 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7023 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7025 * doprnt.c (doprnt): Don't return value smaller than the buffer
7026 size if the message was truncated. (Bug#8545).
7028 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7030 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7031 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7033 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7035 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7037 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7039 * makefile.w32-in: Update dependencies.
7041 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7043 Improve `doprnt' and its usage. (Bug#8545)
7044 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7045 `format_end'. Remove support for %l as a conversion specifier.
7046 Don't use xrealloc. Improve diagnostics when the %l size modifier
7047 is used. Update the commentary.
7049 * eval.c (verror): Simplify calculation of size_t.
7051 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7054 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7056 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7059 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7061 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7062 This makes this file independent of the recent pseudovector change.
7064 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7066 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7068 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7069 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7070 Remove unused local.
7071 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7073 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7074 GCC 4.6.0 optimizes based on type-based alias analysis.
7075 For example, if b is of type struct buffer * and v of type struct
7076 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7077 != &v->size, and therefore "v->size = 1; b->size = 2; return
7078 v->size;" must therefore return 1. This assumption is incorrect
7079 for Emacs, since it type-puns struct Lisp_Vector * with many other
7080 types. To fix this problem, this patch adds a new type struct
7081 vectorlike_header that documents the constraints on layout of vectors
7082 and pseudovectors, and helps optimizing compilers not get fooled
7083 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7084 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7085 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7087 (XSETPVECTYPE): Rewrite in terms of new macro.
7088 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7089 This is a bit clearer, and further avoids the possibility of
7090 undesirable aliasing.
7091 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7092 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7093 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7094 since Lisp_Subr is a special case (no "next" field).
7095 (ASIZE): Now uses header.size rather than size.
7096 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7097 to avoid the hassle of writing XVECTOR (foo)->header.size.
7098 (struct vectorlike_header): New type.
7099 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7100 object, to help avoid aliasing.
7101 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7102 (SUBRP): Likewise, since Lisp_Subr is a special case.
7103 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7104 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7105 (struct Lisp_Hash_Table): Combine first two members into a single
7106 struct vectorlike_header member. All uses of "size" and "next" members
7107 changed to be "header.size" and "header.next".
7108 * buffer.h (struct buffer): Likewise.
7109 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7110 * frame.h (struct frame): Likewise.
7111 * process.h (struct Lisp_Process): Likewise.
7112 * termhooks.h (struct terminal): Likewise.
7113 * window.c (struct save_window_data, struct saved_window): Likewise.
7114 * window.h (struct window): Likewise.
7115 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7116 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7117 * buffer.c (init_buffer_once): Likewise.
7118 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7120 * process.c (Fformat_network_address): Use local var for size,
7123 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7125 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7126 * data.c (atof): Remove decl; no longer used or needed.
7127 (digit_to_number): Move to lread.c.
7128 (Fstring_to_number): Use new string_to_number function, to be
7129 consistent with how the Lisp reader treats infinities and NaNs.
7130 Do not assume that floating-point numbers represent EMACS_INT
7131 without losing information; this is not true on most 64-bit hosts.
7132 Avoid double-rounding errors, by insisting on integers when
7133 parsing non-base-10 numbers, as the documentation specifies.
7134 * lisp.h (string_to_number): New decl, replacing ...
7135 (isfloat_string): Remove.
7136 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7137 (read1): Do not accept +. and -. as integers; this
7138 appears to have been a coding error. Similarly, do not accept
7139 strings like +-1e0 as floating point numbers. Do not report
7140 overflow for integer overflows unless the base is not 10 which
7141 means we have no simple and reliable way to continue.
7142 Break out the floating-point parsing into a new
7143 function string_to_number, so that Fstring_to_number parses
7144 floating point numbers consistently with the Lisp reader.
7145 (digit_to_number): Move here from data.c. Make it static inline.
7146 (E_CHAR, EXP_INT): Remove, replacing with ...
7147 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7148 (string_to_number): New function, replacing isfloat_string.
7149 This function checks for valid syntax and produces the resulting
7150 Lisp float number too. Rework it so that string-to-number
7151 no longer mishandles examples like "1.0e+". Use strtoumax,
7152 so that overflow for non-base-10 numbers is reported only when
7153 there's no portable and simple way to convert to floating point.
7155 * textprop.c (set_text_properties_1): Rewrite for clarity,
7156 and to avoid GCC warning about integer overflow.
7158 * intervals.h (struct interval): Use EMACS_INT for members
7159 where EMACS_UINT might cause problems. See
7160 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7161 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7162 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7164 (offset_intervals): Tell GCC not to worry about length overflow
7165 when negating a negative length.
7167 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7168 (overrun_check_free): Likewise.
7170 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7171 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7174 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7175 (gnutls_make_error): Rename local to avoid shadowing.
7176 (gnutls_emacs_global_deinit): ifdef out; not used.
7177 (Fgnutls_boot): Use const for pointer to readonly storage.
7178 Comment out unused local. Fix pointer signedness problems.
7180 * lread.c (openp): Don't stuff size_t into an 'int'.
7181 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7182 about possible signed overflow.
7184 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7185 (GDK_KEY_g): Don't define if already defined.
7186 (xg_prepare_tooltip): Avoid pointer signedness problem.
7187 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7189 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7190 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7192 * xfns.c (Fx_window_property): Simplify a bit,
7193 to make a bit faster and to avoid GCC 4.6.0 warning.
7194 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7196 * fns.c (internal_equal): Don't assume size_t fits in int.
7198 * alloc.c (compact_small_strings): Tighten assertion a little.
7200 Replace pEd with more-general pI, and fix some printf arg casts.
7201 * lisp.h (pI): New macro, generalizing old pEd macro to other
7202 conversion specifiers. For example, use "...%"pI"d..." rather
7203 than "...%"pEd"...".
7204 (pEd): Remove. All uses replaced with similar uses of pI.
7205 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7206 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7207 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7208 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7209 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7210 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7211 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7213 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7214 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7215 * print.c (safe_debug_print, print_object): Likewise.
7216 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7218 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7219 avoiding the 0 flag, which is not portable.
7220 * process.c (Fmake_network_process): Use pI to avoid cast.
7221 * region-cache.c (pp_cache): Likewise.
7222 * xdisp.c (decode_mode_spec): Likewise.
7223 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7224 behavior on 64-bit hosts with printf arg.
7225 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7226 (x_stop_queuing_selection_requests): Likewise.
7227 (x_get_window_property): Don't truncate byte count to an 'int'
7230 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7231 here, since it parses constructs like leading '-' and spaces,
7232 which are not wanted; and it overflows with large numbers.
7233 Instead, simply match F[0-9]+, which is what is wanted anyway.
7235 * alloc.c: Remove unportable assumptions about struct layout.
7236 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7237 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7238 (allocate_vectorlike, make_pure_vector): Use the new macros,
7239 plus offsetof, to remove unportable assumptions about struct layout.
7240 These assumptions hold on all porting targets that I know of, but
7241 they are not guaranteed, they're easy to remove, and removing them
7242 makes further changes easier.
7244 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7245 This doesn't fix a bug but makes the code clearer.
7246 (string_overrun_cookie): Now const. Use initializers that
7247 don't formally overflow signed char, to avoid warnings.
7248 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7249 can cause Emacs to crash when string overrun checking is enabled.
7250 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7251 multiple of sizeof (EMACS_INT); it need not be, if
7252 alignof(EMACS_INT) < sizeof (EMACS_INT).
7253 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7255 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7257 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7259 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7261 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7262 supposed to be handshaking. (Bug#8556)
7263 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7265 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7267 * lisp.h (Qdebug): List symbol.
7268 * eval.c (Qdebug): Restore global linkage.
7269 * keyboard.c (debug-on-event): New variable.
7270 (handle_user_signal): Break into debugger when debug-on-event
7271 matches the current signal symbol.
7273 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7275 * alloc.c (check_sblock, check_string_bytes)
7276 (check_string_free_list): Convert to standard C.
7278 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7280 * w32.c (emacs_gnutls_push): Fix typo.
7282 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7284 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7285 "cast to pointer from integer of different size".
7287 Improve doprnt and its use in verror. (Bug#8545)
7288 * doprnt.c (doprnt): Document the set of format control sequences
7289 supported by the function. Use SAFE_ALLOCA instead of always
7292 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7293 is one byte too soon. Don't use xrealloc; instead xfree and
7296 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7298 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7301 * gnutls.c: Renamed global_initialized to
7302 gnutls_global_initialized. Added internals for the
7303 :verify-hostname-error, :verify-error, and :verify-flags
7304 parameters of `gnutls-boot' and documented those parameters in the
7305 docstring. Start callback support.
7306 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7307 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7308 on error. Return error code.
7309 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7310 (emacs_gnutls_read): Likewise.
7311 (Fgnutls_boot): Return handshake error code.
7312 (emacs_gnutls_handle_error): New function.
7313 (wsaerror_to_errno): Likewise.
7315 * w32.h (emacs_gnutls_pull): Add prototype.
7316 (emacs_gnutls_push): Likewise.
7318 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7319 (emacs_gnutls_push): Likewise.
7321 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7323 * process.c (wait_reading_process_output): Check if GnuTLS
7324 buffered some data internally if no FDs are set for TLS
7327 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7328 (LIBS): Link to USER_LIBS.
7329 ($(BLD)/gnutls.$(0)): New target.
7331 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7333 * xdisp.c (handle_single_display_spec): Rename the
7334 display_replaced_before_p argument into display_replaced_p, to
7335 make it consistent with the commentary. Fix typos in the
7338 * textprop.c (syms_of_textprop): Remove dead code.
7339 (copy_text_properties): Delete obsolete commentary about an
7340 interface that was deleted long ago. Fix typos in the description
7343 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7344 to changes in oldXMenu/XMenu.h from 2011-04-16.
7345 <menu_help_message, prev_menu_help_message>: Constify.
7346 (IT_menu_make_room): menu->help_text is now `const char **';
7349 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7350 to changes in oldXMenu/XMenu.h from 2011-04-16.
7351 (struct XMenu): Declare `help_text' `const char **'.
7353 * xfaces.c <Qunspecified>: Make extern again.
7355 * syntax.c: Include sys/types.h before including regex.h, as
7358 * doc.c (get_doc_string): Improve the format passed to `error'.
7360 * doprnt.c (doprnt): Improve commentary.
7362 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7364 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7367 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7368 changes in globals.h immediately force recompilation.
7369 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7370 $(CURDIR)/s/ms-w32.h.
7371 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7373 * character.c (Fchar_direction): Function deleted.
7374 (syms_of_character): Don't defsubr it.
7375 <char-direction-table>: Deleted.
7377 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7379 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7380 * doprnt.c: Include limits.h.
7381 (SIZE_MAX): New macro.
7382 (doprnt): Return a size_t value. 2nd arg is now size_t.
7383 Many local variables are now size_t instead of int or unsigned.
7384 Improve overflow protection. Support `l' modifier for integer
7385 conversions. Support %l conversion. Don't assume an EMACS_INT
7386 argument for integer conversions and for %c.
7388 * lisp.h (doprnt): Restore prototype.
7390 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7393 * Makefile.in (base_obj): Add back doprnt.o.
7395 * deps.mk (doprnt.o): Add back prerequisites.
7396 (callint.o): Depend on character.h.
7398 * eval.c (internal_lisp_condition_case): Include the handler
7399 representation in the error message.
7400 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7401 when breaking from the loop.
7403 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7405 * callint.c (Fcall_interactively): When displaying error message
7406 about invalid control letter, pass the character's codepoint, not
7407 a pointer to its multibyte form. Improve display of the character
7408 in octal and display also its hex code.
7410 * character.c (char_string): Use %x to display the (unsigned)
7411 codepoint of an invalid character, to avoid displaying a bogus
7414 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7415 `error', not SYMBOL_NAME itself.
7417 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7418 character arguments to `error'.
7420 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7421 to `error' in error message about FINAL_CHAR argument. Make sure
7422 FINAL_CHAR is a character, and use %c when it is passed as
7423 argument to `error'.
7425 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7427 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7429 * w32.c: Include <time.h>.
7430 (sys_localtime): New function.
7432 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7434 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7436 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7438 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7440 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7443 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7445 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7446 gl_state.e_property when gl_state.object is Qt.
7448 * insdel.c (make_gap_larger): Remove limitation of buffer size
7451 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7453 * xdisp.c (lookup_glyphless_char_display)
7454 (produce_glyphless_glyph): Handle cons cell entry in
7455 glyphless-char-display.
7456 (Vglyphless_char_display): Document it.
7458 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7459 glyphless-char-display.
7461 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7463 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7465 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7467 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7468 definition for no-X builds.
7470 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7472 Static checks with GCC 4.6.0 and non-default toolkits.
7474 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7476 * process.c (keyboard_bit_set): Define only if SIGIO.
7477 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7478 (send_process): Repair possible setjmp clobbering.
7480 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7482 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7484 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7486 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7487 Define only if needed.
7489 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7490 by pacifying GCC about it. Maybe it's time to retire it?
7491 * xfaces.c (USG, __TIMEVAL__): Likewise.
7493 * dispextern.h (struct redisplay_interface): Rename param
7495 * termhooks.h (struct terminal): Likewise.
7496 * xterm.c (xembed_send_message): Likewise.
7498 * insdel.c (make_gap_smaller): Define only if
7499 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7501 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7504 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7505 so that we aren't warned about unused symbols.
7507 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7509 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7511 * xfns.c (x_real_positions): Mark locals as initialized.
7513 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7515 * xterm.c: Fix problems found by static analysis with other toolkits.
7516 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7517 (x_dispatch_event): Declare static if USE_GTK, and
7518 define if USE_GTK || USE_X_TOOLKIT.
7519 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7520 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7521 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7522 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7524 * xmenu.c (menu_help_callback): Pointer type fixes.
7525 Use const pointers when pointing at readonly data. Avoid pointer
7527 (FALSE): Remove unused macro.
7528 (update_frame_menubar): Remove unused decl.
7530 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7532 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7533 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7534 (single_menu_item): Rename local to avoid shadowing.
7536 * keyboard.c (make_lispy_event): Remove unused local var.
7538 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7539 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7541 * bitmaps: Change bitmaps from unsigned char back to the X11
7542 compatible char. Avoid the old compiler warnings about
7543 out-of-range initializers by using, for example, '\xab' rather
7546 * xgselect.c (xgselect_initialize): Check vs interface
7547 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7549 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7551 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7552 to read-only memory.
7554 * fns.c (vector): Remove; this old hack is no longer needed.
7556 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7558 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7560 * xrdb.c (x_load_resources): Omit unused local.
7562 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7563 (x_window): Rename locals to avoid shadowing.
7564 (USG): Use the kludged USG macro, to pacify gcc.
7566 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7567 (x_term_init): Remove local to avoid shadowing.
7569 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7571 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7572 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7574 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7576 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7578 Fix regex.c, syntax.c and friends for buffers > 2GB.
7579 * syntax.h (struct gl_state_s): Declare character position members
7582 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7584 * textprop.c (verify_interval_modification, interval_of):
7585 Declare arguments EMACS_INT.
7587 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7590 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7592 * indent.c (Fvertical_motion): Local variable it_start is now
7595 * regex.c (re_match, re_match_2, re_match_2_internal)
7596 (bcmp_translate, regcomp, regexec, print_double_string)
7597 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7598 (re_compile_pattern, re_exec): Declare arguments and local
7599 variables `size_t' and `ssize_t' and return values `regoff_t', as
7601 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7602 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7603 <compile_stack_type>: `size' and `avail' are now `size_t'.
7605 * regex.h <regoff_t>: Use ssize_t, not int.
7606 (re_search, re_search_2, re_match, re_match_2): Arguments that
7607 specify buffer/string position and length are now ssize_t and
7608 size_t. Return type is regoff_t.
7610 2011-04-16 Ben Key <bkey76@gmail.com>
7612 * nsfont.m: Fixed bugs in ns_get_family and
7613 ns_descriptor_to_entity that were caused by using free to
7614 deallocate memory blocks that were allocated by xmalloc (via
7615 xstrdup). This caused Emacs to crash when compiled with
7616 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7617 --enable-checking=xmallocoverrun). xfree is now used to
7618 deallocate these memory blocks.
7620 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7622 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7624 emacs_write: Accept and return EMACS_INT for sizes.
7625 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7627 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7628 Accept and return EMACS_INT.
7629 (emacs_gnutls_write): Return the number of bytes written on
7631 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7632 (emacs_read, emacs_write): Remove check for negative size, as the
7633 Emacs source code has been audited now.
7634 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7635 (emacs_read, emacs_write): Use it.
7636 * process.c (send_process): Adjust to the new signatures of
7637 emacs_write and emacs_gnutls_write. Do not attempt to store
7638 a byte offset into an 'int'; it might overflow.
7639 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7641 * sound.c: Don't assume sizes fit in 'int'.
7642 (struct sound_device.period_size, alsa_period_size):
7643 Return EMACS_INT, not int.
7644 (struct sound_device.write, vox_write, alsa_write):
7645 Accept EMACS_INT, not int.
7646 (wav_play, au_play): Use EMACS_INT to store sizes and to
7647 record read return values.
7649 2011-04-15 Ben Key <bkey76@gmail.com>
7651 * keyboard.c (Qundefined): Don't declare static since it is used
7653 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7654 static since they are used in nsfont.m.
7656 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7658 * process.c (Qprocessp): Don't declare static.
7659 * lisp.h (Qprocessp): Declare again.
7661 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7663 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7665 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7667 Improve C-level modularity by making more things 'static'.
7669 Don't publish debugger-only interfaces to other modules.
7670 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7671 (verify_bytepos, count_markers): Move decls to the only modules
7673 * region-cache.h (pp_cache): Likewise.
7674 * window.h (check_all_windows): Likewise.
7675 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7677 * sysdep.c (croak): Now static, if
7678 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7679 * syssignal.h (croak): Declare only if not static.
7681 * alloc.c (refill_memory_reserve): Now static if
7682 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7683 * lisp.h (refill_memory_reserve): Declare only if not static.
7685 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7686 Define only if USE_LUCID.
7688 * xrdb.c (x_customization_string, x_rm_string): Now static.
7690 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7691 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7693 * xdisp.c (draw_row_with_mouse_face): Now static.
7694 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7696 * window.h (check_all_windows): Mark externally visible.
7698 * window.c (window_deletion_count): Now static.
7700 * undo.c: Make symbols static if they're not exported.
7701 (last_undo_buffer, last_boundary_position, pending_boundary):
7704 * textprop.c (interval_insert_behind_hooks): Now static.
7705 (interval_insert_in_front_hooks): Likewise.
7707 * term.c: Make symbols static if they're not exported.
7708 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7709 (max_frame_lines, tty_set_terminal_modes):
7710 (tty_reset_terminal_modes, tty_turn_off_highlight):
7711 (get_tty_terminal): Now static.
7712 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7713 * termhooks.h (term_mouse_moveto): Do not declare if
7715 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7716 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7718 * sysdep.c: Make symbols static if they're not exported.
7719 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7721 (sigprocmask_set, full_mask): Remove; unused.
7722 (wait_debugging): Mark as visible.
7723 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7724 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7726 * syntax.c (syntax_temp): Define only if !__GNUC__.
7728 * sound.c (current_sound_device, current_sound): Now static.
7730 * search.c (searchbufs, searchbuf_head): Now static.
7732 * scroll.c (scroll_cost): Remove; unused.
7733 * dispextern.h (scroll_cost): Remove decl.
7735 * region-cache.h (pp_cache): Mark as externally visible.
7737 * process.c: Make symbols static if they're not exported.
7738 (process_tick, update_tick, create_process, chan_process):
7739 (Vprocess_alist, proc_buffered_char, datagram_access):
7740 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7741 (deactivate_process): Mark defn as static, as well as decl.
7742 * lisp.h (create_process): Remove decl.
7743 * process.h (chan_process, Vprocess_alist): Remove decls.
7745 * print.c: Make symbols static if they're not exported.
7746 (print_depth, new_backquote_output, being_printed, print_buffer):
7747 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7748 (print_interval, print_number_index, initial_stderr_stream):
7750 * lisp.h (Fprinc): Remove decl.
7751 (debug_output_compilation_hack): Mark as externally visible.
7753 * sysdep.c (croak): Move decl from here to syssignal.h.
7754 * syssignal.h (croak): Put it here, so the API can be checked when
7755 'croak' is called from dissociate_if_controlling_tty.
7757 * minibuf.c: Make symbols static if they're not exported.
7758 (minibuf_save_list, choose_minibuf_frame): Now static.
7759 * lisp.h (choose_minibuf_frame): Remove decl.
7761 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7763 * lread.c: Make symbols static if they're not exported.
7764 (read_objects, initial_obarray, oblookup_last_bucket_number):
7766 (make_symbol): Remove; unused.
7767 * lisp.h (initial_obarray, make_symbol): Remove decls.
7769 * keyboard.c: Make symbols static if they're not exported.
7770 (single_kboard, recent_keys_index, total_keys, recent_keys):
7771 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7772 (this_single_command_key_start, echoing, last_auto_save):
7773 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7774 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7775 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7776 (Vlispy_mouse_stem, double_click_count):
7778 (force_auto_save_soon): Define only if SIGDANGER.
7779 (ignore_mouse_drag_p): Now static if
7780 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7781 (print_help): Remove; unused.
7782 (stop_character, last_timer_event): Mark as externally visible.
7783 * keyboard.h (ignore_mouse_drag_p): Declare only if
7784 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7785 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7786 * lisp.h (echoing): Remove decl.
7787 (force_auto_save_soon): Declare only if SIGDANGER.
7788 * xdisp.c (redisplay_window): Simplify code, to make it more
7789 obvious that ignore_mouse_drag_p is not accessed if !defined
7790 USE_GTK && !defined HAVE_NS.
7792 * intervals.c: Make symbols static if they're not exported.
7793 (merge_properties_sticky, merge_interval_right, delete_interval):
7795 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7797 * insdel.c: Make symbols static if they're not exported.
7798 However, leave prepare_to_modify_buffer alone. It's never
7799 called from outside this function, but that appears to be a bug.
7800 (combine_after_change_list, combine_after_change_buffer):
7801 (adjust_after_replace, signal_before_change): Now static.
7802 (adjust_after_replace_noundo): Remove; unused.
7803 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7804 (signal_before_change): Remove decls.
7806 * indent.c (val_compute_motion, val_vmotion): Now static.
7808 * image.c: Make symbols static if they're not exported.
7809 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7811 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7812 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7814 * fringe.c (standard_bitmaps): Now static.
7815 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7817 * frame.c: Make symbols static if they're not exported.
7818 (x_report_frame_params, make_terminal_frame): Now static.
7819 (get_frame_param): Now static, unless HAVE_NS.
7820 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7821 (x_get_resource_string): Remove; not used.
7822 * frame.h (make_terminal_frame, x_report_frame_params):
7823 (x_get_resource_string); Remove decls.
7824 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7825 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7827 * font.c, fontset.c: Make symbols static if they're not exported.
7828 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7829 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7830 * font.c (font_close_object): Now static.
7831 * font.h (font_close_object): Remove.
7832 * fontset.c (FONTSET_OBJLIST): Remove.
7833 (free_realized_fontset) #if-0 the body, which does nothing.
7834 (face_suitable_for_char_p): #if-0, as it's never called.
7835 * fontset.h (face_suitable_for_char_p): Remove decl.
7836 * xfaces.c (face_at_string_position):
7837 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7838 since 0 is always ASCII.
7840 * fns.c (weak_hash_tables): Now static.
7842 * fileio.c: Make symbols static if they're not exported.
7843 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7844 (Vwrite_region_annotation_buffers): Now static.
7846 * eval.c: Make symbols static if they're not exported.
7847 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7848 * lisp.h (backtrace_list): Remove decl.
7850 * emacs.c: Make symbols static if they're not exported.
7851 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7852 (fatal_error_code, fatal_error_signal_hook, standard_args):
7854 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7855 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7856 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7857 * lisp.h (fatal_error_signal_hook): Remove decl.
7858 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7860 * editfns.c: Move a (normally-unused) function to its only use.
7861 * editfns.c, lisp.h (get_operating_system_release): Remove.
7862 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7863 worth the hassle of breaking this out.
7865 * xterm.c: Make symbols static if they're not exported.
7866 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7867 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7868 (x_destroy_window, x_delete_display):
7870 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7871 (x_mouse_leave): Remove; unused.
7872 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7873 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7874 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7876 (x_mouse_leave): Declare only if WINDOWSNT.
7877 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7878 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7881 * ftxfont.c: Make symbols static if they're not exported.
7882 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7884 * font.h (ftxfont_driver): Likewise.
7886 * xfns.c: Make symbols static if they're not exported.
7887 (x_last_font_name, x_display_info_for_name):
7888 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7889 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7890 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7891 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7892 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7893 (last_show_tip_args): Now static.
7894 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7895 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7896 (x_screen_planes): Remove; unused.
7897 * dispextern.h (x_screen_planes): Remove decl.
7899 * dispnew.c: Make symbols static if they're not exported.
7900 * dispextern.h (redraw_garbaged_frames, scrolling):
7901 (increment_row_positions): Remove.
7902 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7903 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7905 (redraw_garbaged_frames): Remove; unused.
7907 * xfaces.c: Make symbols static if they're not exported.
7908 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7910 * xterm.h (defined_color): Remove decls.
7911 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7912 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7913 (menu_face_changed_default, defined_color, free_realized_face):
7914 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7915 (ascii_face_of_lisp_face): Remove; unused.
7917 * xdisp.c: Make symbols static if they're not exported.
7918 * dispextern.h (scratch_glyph_row, window_box_edges):
7919 (glyph_to_pixel_coords, set_cursor_from_row):
7920 (get_next_display_element, set_iterator_to_next):
7921 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7922 (show_mouse_face): Remove decls
7923 * frame.h (message_buf_print): Likewise.
7924 * lisp.h (pop_message, set_message, check_point_in_composition):
7926 * xterm.h (set_vertical_scroll_bar): Likewise.
7927 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7928 (message_buf_print, scratch_glyph_row, displayed_buffer):
7929 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7930 (get_next_display_element, show_mouse_face, window_box_edges):
7931 (frame_to_window_pixel_xy, check_point_in_composition):
7932 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7933 (glyph_to_pixel_coords): Remove; unused.
7935 * dired.c (file_name_completion): Now static.
7937 * dbusbind.c (xd_in_read_queued_messages): Now static.
7939 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7940 * data.c (circular_list_error): Remove.
7942 * commands.h (last_point_position, last_point_position_buffer):
7943 (last_point_position_window): Remove decls.
7944 * keyboard.c: Make these variables static.
7946 * coding.h (coding, code_convert_region, encode_coding_gap):
7948 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7949 (iso_code_class, detect_coding, code_convert_region): Now static.
7950 (encode_coding_gap): Remove; unused.
7952 * chartab.c (chartab_chars, chartab_bits): Now static.
7954 * charset.h (charset_iso_8859_1): Remove decl.
7955 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7958 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7959 * ccl.c (Vccl_program_table): Now static.
7960 (check_ccl_update): Remove; unused.
7962 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7963 * category.h: ... from here.
7964 * category.c (check_category_table, set_category_set): Now static.
7966 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7967 * lisp.h: Remove these decls.
7969 * buffer.c (buffer_count): Remove unused var.
7971 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7972 so that it's not optimized away.
7973 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7974 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7975 exported only to the debugger.
7977 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7978 * atimer.h (run_all_atimers): Remove; not exported.
7980 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7981 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7982 was inaccessible from Lisp.
7983 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7984 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7986 alloc.c: Import and export fewer symbols, and remove unused items.
7987 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7989 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7990 it's not optimized away by whole-program optimization.
7991 (message_enable_multibyte, free_misc): Remove.
7992 (catchlist, handlerlist, mark_backtrace):
7993 Declare only if BYTE_MARK_STACK.
7994 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7995 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7996 (message_enable_multibyte): Remove decl.
7997 (free_misc, interval_free_list, float_block, float_block_index):
7998 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7999 (cons_free_list, last_marked_index):
8001 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8002 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8003 (mark_backtrace): Define only if BYTE_MARK_STACK.
8004 * xdisp.c (message_enable_multibyte): Now static.
8006 Declare Lisp_Object Q* variables to be 'static' if not exported.
8007 This makes it easier for human readers (and static analyzers)
8008 to see whether these variables are used from other modules.
8009 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8010 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8011 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8012 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8013 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8014 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8015 * xmenu.c, xselect.c:
8016 Declare Q* vars static if they are not used in other modules.
8017 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8018 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8019 Remove decls of unexported vars.
8020 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8022 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8024 Make Emacs functions such as Fatom 'static' by default.
8025 This makes it easier for human readers (and static analyzers)
8026 to see whether these functions can be called from other modules.
8027 DEFUN now defines a static function. To make the function external
8028 so that it can be used in other C modules, use the new macro DEFUE.
8029 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8030 (Finit_image_library):
8031 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8032 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8033 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8034 Remove decls, since these functions are now static.
8035 (Funintern, Fget_internal_run_time): New decls, since these functions
8036 were already external.
8038 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8039 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8040 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8041 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8042 * keyboard.c, keymap.c, lread.c:
8043 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8044 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8045 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8046 Mark functions with DEFUE instead of DEFUN,
8047 if they are used in other modules.
8048 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8049 decls for now-static functions.
8050 * buffer.h (Fdelete_overlay): Remove decl.
8051 * callproc.c (Fgetenv_internal): Mark as internal.
8052 * composite.c (Fremove_list_of_text_properties): Remove decl.
8053 (Fcomposition_get_gstring): New forward static decl.
8054 * composite.h (Fcomposite_get_gstring): Remove decl.
8055 * dired.c (Ffile_attributes): New forward static decl.
8056 * doc.c (Fdocumntation_property): New forward static decl.
8057 * eval.c (Ffetch_bytecode): New forward static decl.
8058 (Funintern): Remove extern decl; now in .h file where it belongs.
8059 * fileio.c (Fmake_symbolic_link): New forward static decl.
8060 * image.c (Finit_image_library): New forward static decl.
8061 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8062 * intervals.h (Fprevious_property_change):
8063 (Fremove_list_of_text_properties): Remove decls.
8064 * keyboard.c (Fthis_command_keys): Remove decl.
8065 (Fcommand_execute): New forward static decl.
8066 * keymap.c (Flookup_key): New forward static decl.
8067 (Fcopy_keymap): Now static.
8068 * keymap.h (Flookup_key): Remove decl.
8069 * process.c (Fget_process): New forward static decl.
8070 (Fprocess_datagram_address): Mark as internal.
8071 * syntax.c (Fsyntax_table_p): New forward static decl.
8072 (skip_chars): Remove duplicate decl.
8073 * textprop.c (Fprevious_property_change): New forward static decl.
8074 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8076 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8077 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8079 * editfns.c (Fformat): Remove unreachable code.
8081 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8083 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8086 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8088 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8089 when at ZV. (Bug#8487)
8091 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8093 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8095 * keyboard.c (parse_tool_bar_item): Likewise.
8096 * sound.c (sound_cleanup, alsa_close): Likewise.
8097 * termcap.c (tgetent): Likewise.
8098 * xfns.c (x_default_font_parameter): Likewise.
8099 * xsettings.c (read_and_apply_settings): Likewise.
8101 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8102 (overrun_check_free): Protoize.
8104 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8106 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8107 since callers should never pass a negative size.
8108 Change the signature to match that of plain 'read' and 'write'; see
8109 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8110 * lisp.h: Update prototypes of emacs_write and emacs_read.
8112 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8114 * xdisp.c (redisplay_window): Don't try to determine the character
8115 position of the scroll margin if the window start point w->startp
8116 is outside the buffer's accessible region. (Bug#8468)
8118 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8120 Fix write-region and its subroutines for buffers > 2GB.
8121 * fileio.c (a_write, e_write): Modify declaration of arguments and
8122 local variables to support buffers larger than 2GB.
8123 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8125 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8126 argument, local variables, and return value.
8128 * lisp.h: Update prototypes of emacs_write and emacs_read.
8130 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8132 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8134 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8136 Fix more problems found by GCC 4.6.0's static checks.
8138 * xdisp.c (vmessage): Use a better test for character truncation.
8140 * charset.c (load_charset_map): <, not <=, for optimization,
8141 and to avoid potential problems with integer overflow.
8142 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8143 * casetab.c (set_identity, shuffle): Likewise.
8144 * editfns.c (Fformat): Likewise.
8145 * syntax.c (skip_chars): Likewise.
8147 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8148 This also lets GCC 4.6.0 generate slightly better loop code.
8150 * callint.c (Fcall_interactively): <, not <=, for optimization.
8151 (Fcall_interactively): Count the number of arguments produced,
8152 not the number of arguments given. This is simpler and lets GCC
8153 4.6.0 generate slightly better code.
8155 * ftfont.c: Distingish more carefully between FcChar8 and char.
8156 The previous code passed unsigned char * to a functions like
8157 strlen and xstrcasecmp that expect char *, which does not
8158 conform to the C standard.
8159 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8160 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8161 char * when the C standard requires it.
8163 * keyboard.c (read_char): Remove unused var.
8165 * eval.c: Port to Windows vsnprintf (Bug#8435).
8167 (SIZE_MAX): Define if the headers do not.
8168 (verror): Do not give up if vsnprintf returns a negative count.
8169 Instead, grow the buffer. This ports to Windows vsnprintf, which
8170 does not conform to C99. Problem reported by Eli Zaretskii.
8171 Also, simplify the allocation scheme, by avoiding the need for
8172 calling realloc, and removing the ALLOCATED variable.
8174 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8176 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8177 But keep the doprint source code for now, as we might revamp it
8178 and use it again (Bug#8435).
8179 * lisp.h (doprnt): Remove.
8180 * Makefile.in (base_obj): Remove doprnt.o.
8181 * deps.mk (doprnt.o): Remove.
8183 error: Print 32- and 64-bit integers portably (Bug#8435).
8184 Without this change, on typical 64-bit hosts error ("...%d...", N)
8185 was used to print both 32- and 64-bit integers N, which relied on
8187 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8188 * lisp.h (error, verror): Mark as printf-like functions.
8189 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8190 Report overflow in size calculations when allocating printf buffer.
8191 Do not truncate output string at its first null byte.
8192 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8193 Truncate the output at a character boundary, since vsnprintf does not
8195 * charset.c (check_iso_charset_parameter): Convert internal
8196 character to string before calling 'error', since %c now has the
8198 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8199 overflow when computing char to be passed to 'error'. Do not
8200 pass Lisp_Object to 'error'; pass the integer instead.
8201 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8202 formatted with plain %d.
8204 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8206 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8208 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8210 * xterm.c (x_catch_errors): Remove duplicate declaration.
8212 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8214 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8216 2011-04-10 Jim Meyering <meyering@redhat.com>
8218 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8219 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8220 return ssize_t not "int", and use size_t as the buffer length.
8221 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8222 * gnutls.h: Update declarations.
8223 * process.c (read_process_output): Use ssize_t, to match.
8224 (send_process): Likewise.
8226 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8228 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8230 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8232 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8233 Use unsigned char, to match FcChar8 type definition.
8235 * xterm.c (handle_one_xevent):
8236 * xmenu.c (create_and_show_popup_menu):
8237 * xselect.c (x_decline_selection_request)
8238 (x_reply_selection_request): Avoid type-punned deref of X events.
8240 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8242 Fix some uses of `int' instead of EMACS_INT.
8243 * search.c (string_match_1, fast_string_match)
8244 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8245 (scan_buffer, find_next_newline_no_quit)
8246 (find_before_next_newline, search_command, Freplace_match)
8247 (Fmatch_data): Make some `int' variables be EMACS_INT.
8249 * xdisp.c (display_count_lines): 3rd argument and return value now
8250 EMACS_INT. All callers changed.
8251 (pint2hrstr): Last argument is now EMACS_INT.
8253 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8254 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8255 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8256 (decode_coding_utf_16, decode_coding_emacs_mule)
8257 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8258 (decode_coding_ccl, decode_coding_charset)
8259 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8260 (decode_coding_iso_2022, decode_coding_emacs_mule)
8261 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8262 <char_offset, last_offset>: Declare EMACS_INT.
8263 (encode_coding_utf_8, encode_coding_utf_16)
8264 (encode_coding_emacs_mule, encode_invocation_designation)
8265 (encode_designation_at_bol, encode_coding_iso_2022)
8266 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8267 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8269 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8270 (encode_invocation_designation): Last argument P_NCHARS is now
8272 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8273 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8275 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8278 * ccl.c (Fccl_execute_on_string): Declare some variables
8281 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8283 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8285 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8287 * process.c (Fformat_network_address): Doc fix.
8289 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8291 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8293 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8295 * keyboard.c (read_char): Call Lisp function help-form-show,
8296 instead of using internal_with_output_to_temp_buffer.
8297 (Qhelp_form_show): New var.
8298 (syms_of_keyboard): Use DEFSYM macro.
8300 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8302 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8304 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8306 * process.c (Flist_processes): Remove to Lisp.
8307 (list_processes_1): Delete.
8309 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8311 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8313 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8315 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8317 Fix more problems found by GCC 4.6.0's static checks.
8319 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8321 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8323 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8325 * xdisp.c (vmessage): Mark as a printf-like function.
8327 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8329 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8331 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8332 printf-like functions.
8333 (tiff_load): Add casts to remove these marks before passing them
8334 to system-supplied API.
8336 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8338 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8339 This avoids several warnings with gcc -Wstrict-overflow.
8340 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8341 directly, rather than having caller test rule sign. This avoids
8342 some unnecessary tests.
8343 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8344 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8345 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8347 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8348 (xfont_open): Avoid unnecessary tests.
8350 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8352 * composite.h, composite.c (composition_gstring_put_cache):
8353 Use EMACS_INT, not int, for length.
8355 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8356 breaking out part of COMPOSITION_DECODE_RULE.
8357 (COMPOSITION_DECODE_RULE): Use it.
8358 * composite.c (get_composition_id): Remove unused local vars,
8359 by using the new macro.
8361 * textprop.c (set_text_properties_1): Change while to do-while,
8362 since the condition is always true at first.
8364 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8365 (interval_deletion_adjustment): Return unsigned value.
8368 * process.c (list_processes_1, create_pty, read_process_output):
8369 (exec_sentinel): Remove vars that were set but not used.
8370 (create_pty): Remove unnecessary "volatile"s.
8371 (Fnetwork_interface_info): Avoid possibility of int overflow.
8372 (read_process_output): Do adaptive read buffering even if carryover.
8373 (read_process_output): Simplify nbytes computation if buffered.
8375 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8377 * syntax.c (scan_words): Remove var that was set but not used.
8378 (update_syntax_table): Use unsigned instead of int.
8380 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8381 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8382 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8384 * print.c (print_error_message): Avoid int overflow.
8386 * font.c (font_list_entities): Redo for clarity,
8387 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8389 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8390 (font_score): Avoid potential overflow in diff calculation.
8392 * fns.c (substring_both): Remove var that is set but not used.
8393 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8395 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8397 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8398 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8399 can always succeed if overflow has undefined behavior.
8401 * search.c (boyer_moore, wordify): Remove vars set but not used.
8402 (wordify): Omit three unnecessary tests.
8404 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8405 All callers changed. This avoids the need for an unused var.
8407 * casefiddle.c (casify_region): Remove var that is set but not used.
8409 * dired.c (file_name_completion): Remove var that is set but not used.
8411 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8413 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8414 (Finsert_file_contents): Remove unnecessary code checking fd.
8416 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8417 Check for integer overflow on size calculations.
8419 * buffer.c (Fprevious_overlay_change): Remove var that is set
8422 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8423 Remove vars that are set but not used.
8424 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8425 (timer_check_2): Mark vars as initialized.
8427 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8429 * image.c (lookup_image): Remove var that is set but not used.
8430 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8432 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8433 that are set but not used.
8435 * xfns.c (make_invisible_cursor): Don't return garbage
8436 if XCreateBitmapFromData fails (Bug#8410).
8438 * xselect.c (x_get_local_selection, x_handle_property_notify):
8439 Remove vars that are set but not used.
8441 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8442 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8444 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8445 Remove var that is set but not used.
8446 (scroll_bar_windows_size): Now size_t, not int.
8447 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8450 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8451 (map_tty_color) [!defined MSDOS]: Likewise.
8453 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8455 * coding.c: Remove vars that are set but not used.
8456 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8457 All callers changed.
8458 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8459 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8460 (decode_coding_charset): Remove vars that are set but not used.
8462 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8463 that is set but not used.
8465 * print.c (print_object): Remove var that is set but not used.
8467 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8468 The gnulib version avoids calling malloc in the usual case,
8469 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8470 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8471 * filelock.c (current_lock_owner): Likewise.
8472 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8473 * sysdep.c: Include allocator.h, careadlinkat.h.
8474 (emacs_no_realloc_allocator): New static constant.
8475 (emacs_readlink): New function.
8476 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8477 ../lib/careadlinkat.h.
8479 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8481 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8482 first non-nil return value).
8484 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8486 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8487 if not defined (Bug#8403).
8489 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8491 * xdisp.c (display_count_lines): Remove parameter `start',
8492 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8493 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8494 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8495 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8496 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8497 and thereabouts. All callers changed.
8498 (get_per_char_metric): Remove parameter `f', unused since
8499 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8501 2011-04-02 Jim Meyering <meyering@redhat.com>
8503 do not dereference NULL upon failed strdup
8504 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8505 (ns_get_family): Likewise.
8507 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8509 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8511 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8513 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8516 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8518 Add lexical binding.
8520 * window.c (Ftemp_output_buffer_show): New fun.
8521 (Fsave_window_excursion):
8522 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8524 * lread.c (lisp_file_lexically_bound_p): New function.
8525 (Fload): Bind Qlexical_binding.
8526 (readevalloop): Remove `evalfun' arg.
8527 Bind Qinternal_interpreter_environment.
8528 (Feval_buffer): Bind Qlexical_binding.
8529 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8531 (syms_of_lread): Declare `lexical-binding'.
8533 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8535 * keyboard.c (eval_dyn): New fun.
8536 (menu_item_eval_property): Use it.
8538 * image.c (parse_image_spec): Use Ffunctionp.
8540 * fns.c (concat, mapcar1): Accept byte-code-functions.
8542 * eval.c (Fsetq): Handle lexical vars.
8543 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8544 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8545 (FletX, Flet): Obey lexical binding.
8546 (Fcommandp): Handle closures.
8547 (Feval): New `lexical' arg.
8548 (eval_sub): New function extracted from Feval. Use it almost
8549 everywhere where Feval was used. Look up vars in lexical env.
8551 (Ffunctionp): Move from subr.el.
8552 (Ffuncall): Handle closures.
8553 (apply_lambda): Remove `eval_flags'.
8554 (funcall_lambda): Handle closures and new byte-code-functions.
8555 (Fspecial_variable_p): New function.
8556 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8557 but without exporting it to Lisp.
8559 * doc.c (Fdocumentation, store_function_docstring):
8560 * data.c (Finteractive_form): Handle closures.
8562 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8565 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8567 (exec_byte_code): New function extracted from Fbyte_code to handle new
8568 calling convention for byte-code-functions. Add new byte-codes.
8570 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8572 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8574 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8576 * xdisp.c (redisplay_internal): Fix prototype.
8578 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8580 * xdisp.c (SCROLL_LIMIT): New macro.
8581 (try_scrolling): Use it when setting scroll_limit.
8582 Limit scrolling to 100 screen lines.
8583 (redisplay_window): Even when falling back on "recentering",
8584 position point in the window according to scroll-conservatively,
8585 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8587 (try_scrolling): When point is above the window, allow searching
8588 as far as scroll_max, or one screenful, to compute vertical
8589 distance from PT to the scroll margin position. This prevents
8590 try_scrolling from unnecessarily failing when
8591 scroll-conservatively is set to a value slightly larger than the
8592 window height. Clean up the case of PT below the margin at bottom
8593 of window: scroll_max can no longer be INT_MAX. When aggressive
8594 scrolling is in use, don't let point enter the opposite scroll
8595 margin as result of the scroll.
8596 (syms_of_xdisp) <scroll-conservatively>: Document the
8597 threshold of 100 lines for never-recentering scrolling.
8599 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8601 * dispextern.h (move_it_by_lines):
8602 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8603 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8604 (message_log_check_duplicate): Remove parameters `prev_bol' and
8605 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8606 (redisplay_internal): Remove parameter `preserve_echo_area',
8607 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8609 * indent.c (Fvertical_motion):
8610 * window.c (window_scroll_pixel_based, Frecenter):
8611 Don't pass `need_y_p' to `move_it_by_lines'.
8613 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8615 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8616 steal a few bits to be more compact.
8617 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8618 Remove unneeded casts.
8620 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8622 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8624 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8625 binding" message (bug#7967).
8627 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8629 Fix more problems found by GCC 4.6.0's static checks.
8631 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8632 Remove unused local var.
8634 * editfns.c (Fmessage_box): Remove unused local var.
8636 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8637 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8638 Omit unused local vars.
8639 * window.c (shrink_windows): Omit unused local var.
8640 * menu.c (digest_single_submenu): Omit unused local var.
8641 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8642 Omit unused local var.
8644 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8645 Don't assume string length fits in int.
8646 (keyremap_step, read_key_sequence): Use size_t for sizes.
8647 (read_key_sequence): Don't check last_real_key_start redundantly.
8649 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8650 instead of alloca (Bug#8344).
8652 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8653 (Fbacktrace_frame): Don't assume nframes fits in int.
8655 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8657 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8660 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8662 * cm.c (calccost): Turn while-do into do-while, for clarity.
8664 * keyboard.c (syms_of_keyboard): Use the same style as later
8665 in this function when indexing through an array. This also
8666 works around GCC bug 48267.
8668 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8670 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8672 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8673 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8675 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8676 This avoids undefined behavior on integer overflow, and is a bit
8677 more convenient anyway since it is compared to a size_t variable.
8679 Variadic C functions now count arguments with size_t, not int.
8680 This avoids an unnecessary limitation on 64-bit machines, which
8681 caused (substring ...) to crash on large vectors (Bug#8344).
8682 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8683 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8684 All variadic functions and their callers changed accordingly.
8685 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8686 * data.c (arith_driver, float_arith_driver): Likewise.
8687 * editfns.c (general_insert_function): Likewise.
8688 * eval.c (struct backtrace.nargs, interactive_p)
8689 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8690 (funcall_lambda, mark_backtrace): Likewise.
8691 * fns.c (concat): Likewise.
8692 * frame.c (x_set_frame_parameters): Likewise.
8693 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8694 0 if not found, not -1. All callers changed.
8696 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8697 (stack_copy_size): Now size_t, not int.
8698 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8700 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8702 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8703 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8704 All callers changed.
8706 * lisp.h (multibyte_char_to_unibyte):
8707 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8708 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8709 * character.h (CHAR_TO_BYTE8):
8710 * cmds.c (internal_self_insert):
8711 * editfns.c (general_insert_function):
8712 * keymap.c (push_key_description):
8713 * search.c (Freplace_match):
8714 * xdisp.c (message_dolog, set_message_1): All callers changed.
8716 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8718 * keyboard.c (safe_run_hook_funcall): New function.
8719 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8720 don't set the hook to nil, but remove the offending function instead.
8721 (Qcommand_hook_internal): Remove, unused.
8722 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8723 Vcommand_hook_internal.
8725 * eval.c (enum run_hooks_condition): Remove.
8726 (funcall_nil, funcall_not): New functions.
8727 (run_hook_with_args): Call each function through a `funcall' argument.
8728 Remove `cond' argument, now redundant.
8729 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8730 (Frun_hook_with_args_until_failure): Adjust accordingly.
8731 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8733 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8735 * dispextern.h (string_buffer_position): Remove declaration.
8737 * print.c (strout): Remove parameter `multibyte', unused since
8738 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8740 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8741 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8742 All callers changed.
8744 * w32.c (_wsa_errlist): Use braces for struct initializers.
8746 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8747 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8748 All callers changed.
8749 (string_buffer_position): Likewise. Also, make static (it's never
8750 used outside xdisp.c).
8751 (cursor_row_p): Remove parameter `w', unused since
8752 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8753 (decode_mode_spec): Remove parameter `precision', introduced during
8754 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8755 All callers changed.
8757 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8759 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8761 2011-03-27 Anders Lindgren <andlind@gmail.com>
8763 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8764 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8765 (ns_update_auto_hide_menu_bar): New functions.
8766 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8767 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8768 ns_constrain_all_frames.
8769 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8770 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8772 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8774 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8776 2011-03-27 Glenn Morris <rgm@gnu.org>
8778 * syssignal.h: Replace RETSIGTYPE with void.
8779 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8780 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8781 Replace SIGTYPE with void everywhere.
8782 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8783 * s/template.h (SIGTYPE): Remove commented out definition.
8785 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8787 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8788 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8790 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8792 * w32.c (read_unc_volume): Use parameter `henum', instead of
8793 global variable `wget_enum_handle'.
8795 * keymap.c (describe_vector): Remove parameters `indices' and
8796 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8797 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8799 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8801 * keyboard.c (timer_check): Remove parameter `do_it_now',
8802 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8803 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8804 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8806 * keyboard.c (read_char):
8807 * w32menu.c (w32_menu_display_help):
8808 * xmenu.c (show_help_event, menu_help_callback):
8809 Adjust calls to `show_help_echo'.
8811 * gtkutil.c (xg_maybe_add_timer):
8812 * keyboard.c (readable_events):
8813 * process.c (wait_reading_process_output):
8814 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8816 * insdel.c (adjust_markers_gap_motion):
8817 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8818 (gap_left, gap_right): Don't call it.
8820 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8822 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8823 incurred during fontification.
8825 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8827 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8828 (DEFVAR_PER_BUFFER): Don't pass it.
8830 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8831 (scrolling_window): Don't pass it.
8833 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8835 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8837 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8839 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8840 of variables specific to SELinux and computation of `encoded_absname'.
8842 * image.c (XPutPixel): Remove unused variable `height'.
8844 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8846 * unexw32.c (get_section_info): Remove unused variable `section'.
8848 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8849 (system_process_attributes): Remove unused variable `sess'.
8850 (sys_read): Remove unused variable `err'.
8852 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8853 (w32_wnd_proc): Remove unused variable `isdead'.
8854 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8855 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8856 (x_create_tip_frame): Remove unused variable `tem'.
8858 * w32inevt.c (w32_console_read_socket):
8859 Remove unused variable `no_events'.
8861 * w32term.c (x_draw_composite_glyph_string_foreground):
8862 Remove unused variable `width'.
8864 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8866 * w32term.c (x_set_glyph_string_clipping):
8867 Don't pass uninitialized region to CombineRgn.
8869 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8871 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8872 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8873 (Fx_close_connection): Remove unused variable `i'.
8875 * w32font.c (w32font_draw): Return number of glyphs.
8876 (w32font_open_internal): Remove unused variable `i'.
8877 (w32font_driver): Add missing initializer.
8879 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8880 (fill_in_menu): Remove unused variable `items_added'.
8882 * w32term.c (last_mouse_press_frame): Remove static global variable.
8883 (w32_clip_to_row): Remove unused variable `f'.
8884 (x_delete_terminal): Remove unused variable `i'.
8886 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8887 (NOTHING): Remove unused static global variable.
8888 (uniscribe_check_otf): Remove unused variable `table'.
8889 (uniscribe_font_driver): Add missing initializers.
8891 2011-03-23 Julien Danjou <julien@danjou.info>
8893 * term.c (Fsuspend_tty, Fresume_tty):
8894 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8895 * window.c (temp_output_buffer_show):
8896 * insdel.c (signal_before_change):
8897 * frame.c (Fhandle_switch_frame):
8898 * fileio.c (Fdo_auto_save):
8899 * emacs.c (Fkill_emacs):
8900 * editfns.c (save_excursion_restore):
8901 * cmds.c (internal_self_insert):
8902 * callint.c (Fcall_interactively):
8903 * buffer.c (Fkill_all_local_variables):
8904 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8906 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8907 unconditionally since it does the check itself.
8909 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8911 Fix more problems found by GCC 4.5.2's static checks.
8913 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8914 the first time through the loop, since we know p0 < p1 then.
8915 This also avoids a gcc -Wstrict-overflow warning.
8917 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8918 leading to a memory leak, possible in functions like
8919 load_charset_map_from_file that can allocate an unbounded number
8920 of objects (Bug#8318).
8922 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8923 that could (at least in theory) be that large.
8925 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8926 This is less likely to overflow, and avoids undefined behavior if
8927 overflow does occur. All callers changed. Use strtoul to scan
8928 for the unsigned long integer.
8929 (pint2hrstr): Simplify and tune code slightly.
8930 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8932 * scroll.c (do_scrolling): Work around GCC bug 48228.
8933 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8935 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8936 This also avoids a warning with gcc -Wstrict-overflow.
8937 (validate_x_resource_name): Simplify count usage.
8938 This also avoids a warning with gcc -Wstrict-overflow.
8940 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8943 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8945 * process.c (Fmake_network_process): Use socklen_t, not int,
8946 where POSIX says socklen_t is required in portable programs.
8947 This fixes a porting bug on hosts like 64-bit HP-UX, where
8948 socklen_t is wider than int (Bug#8277).
8949 (Fmake_network_process, server_accept_connection):
8950 (wait_reading_process_output, read_process_output):
8953 * process.c: Rename or move locals to avoid shadowing.
8954 (list_processes_1, Fmake_network_process):
8955 (read_process_output_error_handler, exec_sentinel_error_handler):
8956 Rename or move locals.
8957 (Fmake_network_process): Define label "retry_connect" only if needed.
8958 (Fnetwork_interface_info): Fix pointer signedness.
8959 (process_send_signal): Add cast to avoid pointer signedness problem.
8960 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8961 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8963 Make tparam.h and terminfo.c consistent.
8964 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8965 Include tparam.h instead, since it declares them.
8966 * cm.h (PC): Remove extern decl; tparam.h now does this.
8967 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8968 * terminfo.c: Include tparam.h, to check interfaces.
8969 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8970 (tparam): Adjust signature to match interface in tparam.h;
8971 this removes some undefined behavior. Check that outstring and len
8972 are zero, which they always are with Emacs.
8973 * tparam.h (PC, BC, UP): New extern decls.
8975 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8976 (xftfont_open): Rename locals to avoid shadowing.
8978 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8979 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8980 (OTF_TAG_SYM): Omit macro if not needed.
8981 (ftfont_list): Remove unused local.
8982 (get_adstyle_property, ftfont_pattern_entity):
8983 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8984 Rename locals to avoid shadowing.
8986 * xfont.c (xfont_list_family): Mark var as initialized.
8988 * xml.c (make_dom): Now static.
8990 * composite.c (composition_compute_stop_pos): Rename local to
8992 (composition_reseat_it): Remove unused locals.
8993 (find_automatic_composition, composition_adjust_point): Likewise.
8994 (composition_update_it): Mark var as initialized.
8995 (find_automatic_composition): Mark vars as initialized,
8996 with a FIXME (Bug#8290).
8998 character.h: Rename locals to avoid shadowing.
8999 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9000 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9001 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9002 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9005 * textprop.c (property_change_between_p): Remove; unused.
9007 * intervals.c (interval_start_pos): Now static.
9009 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9011 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9012 Rename locals to avoid shadowing.
9014 * sound.c (wav_play, au_play, Fplay_sound_internal):
9015 Fix pointer signedness.
9016 (alsa_choose_format): Remove unused local var.
9017 (wav_play): Initialize a variable to 0, to prevent undefined
9018 behavior (Bug#8278).
9020 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9022 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9025 clobbering (Bug#8298).
9026 * sysdep.c (sys_subshell): Likewise.
9027 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9029 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9030 This should get cleaned up, so that child_setup has the
9031 same signature on all platforms.
9033 * callproc.c (call_process_cleanup): Now static.
9034 (relocate_fd): Rename locals to avoid shadowing.
9036 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9038 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9039 not to be necessary, and produces flickering.
9041 2011-03-20 Glenn Morris <rgm@gnu.org>
9043 * config.in: Remove file.
9045 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9047 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9048 are now in src/globals.h.
9049 (syms_of_minibuf): Remove spurious & from previous change.
9051 2011-03-20 Leo Liu <sdl.web@gmail.com>
9053 * minibuf.c (completing-read-function): New variable.
9054 (completing-read-default): Rename from completing-read.
9055 (completing-read): Call completing-read-function.
9057 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9059 * xfaces.c (Fx_load_color_file):
9060 Read color file from absolute filename (bug#8250).
9062 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9064 * makefile.w32-in: Update dependencies.
9066 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9068 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9070 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9072 Fix more problems found by GCC 4.5.2's static checks.
9074 * process.c (make_serial_process_unwind, send_process_trap):
9075 (sigchld_handler): Now static.
9077 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9078 That way, the code declares only the vars that it needs.
9079 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9080 * s/cygwin.h (PTY_ITERATION): Likewise.
9081 * s/darwin.h (PTY_ITERATION): Likewise.
9082 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9084 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9085 * process.c (allocate_pty): Don't declare stb unless it's needed.
9087 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9088 (CONSTANTLIM): Remove; unused.
9089 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9090 Define only if needed.
9092 * unexelf.c (unexec): Name an expression,
9093 to avoid gcc -Wbad-function-cast warning.
9094 Use a different way to cause a compilation error if anyone uses
9095 n rather than nn, a way that does not involve shadowing.
9096 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9098 * deps.mk (unexalpha.o): Remove; unused.
9100 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9101 * unexec.h: New file.
9102 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9103 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9105 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9106 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9107 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9108 Change as necessary to match prototype in unexec.h.
9110 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9112 (back_comment, skip_chars): Mark vars as initialized.
9114 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9115 Rename locals to avoid shadowing.
9117 * lread.c (read1): Rewrite so as not to use empty "else".
9118 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9120 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9122 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9123 warning when compiling print.c.
9125 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9126 instead of using an uninitialized var.
9127 (font_sort_entities): Mark var as initialized.
9129 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9131 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9132 pointers to constants.
9133 (font_parse_fcname): Remove unused vars.
9134 (font_delete_unmatched): Now static.
9135 (font_get_spec): Remove; unused.
9136 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9137 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9138 Rename or move locals to avoid shadowing.
9140 * fns.c (require_nesting_list, require_unwind): Now static.
9141 (Ffillarray): Rename locals to avoid shadowing.
9143 * floatfns.c (domain_error2): Define only if needed.
9144 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9146 * alloc.c (mark_backtrace): Move decl from here ...
9147 * lisp.h: ... to here, so that it can be checked.
9149 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9150 (Fdefvar): Rewrite so as not to use empty "else".
9151 (lisp_indirect_variable): Name an expression,
9152 to avoid gcc -Wbad-function-cast warning.
9153 (Fdefvar): Rename locals to avoid shadowing.
9155 * callint.c (quotify_arg, quotify_args): Now static.
9156 (Fcall_interactively): Rename locals to avoid shadowing.
9157 Use const pointer when appropriate.
9159 * lisp.h (get_system_name, get_operating_system_release):
9160 Move decls here, to check interfaces.
9161 * process.c (get_operating_system_release): Move decl to lisp.h.
9162 * xrdb.c (get_system_name): Likewise.
9163 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9164 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9165 some of which prompt warnings from gcc -Wbad-function-cast.
9166 (Fformat_time_string, Fencode_time, Finsert_char):
9167 (Ftranslate_region_internal, Fformat):
9168 Rename or remove local vars to avoid shadowing.
9169 (Ftranslate_region_internal): Mark var as initialized.
9171 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9174 * lisp.h (eassert): Check that the argument compiles, even if
9175 ENABLE_CHECKING is not defined.
9177 * data.c (Findirect_variable): Name an expression, to avoid
9178 gcc -Wbad-function-cast warning.
9179 (default_value, arithcompare, arith_driver, arith_error): Now static.
9180 (store_symval_forwarding): Rename local to avoid shadowing.
9181 (Fmake_variable_buffer_local, Fmake_local_variable):
9182 Mark variables as initialized.
9183 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9185 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9186 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9187 Rename locals to avoid shadowing.
9188 (mark_stack): Move local variables into the #ifdef region where
9190 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9191 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9193 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9194 (GC_STRING_CHARS): Remove; not used.
9195 (Fmemory_limit): Cast sbrk's returned value to char *.
9197 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9198 avoids undefined behavior in theory.
9200 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9202 Use functions, not macros, for up- and down-casing (Bug#8254).
9203 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9204 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9205 to use the following functions instead of these macros.
9206 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9207 EMACS_INT, since callers assume the returned value fits in int.
9208 (upcase1): Likewise, for UPCASE_TABLE.
9209 (uppercasep, lowercasep, upcase): New static inline functions.
9210 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9211 the race-condition problem in the old DOWNCASE.
9213 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9214 Rename locals to avoid shadowing.
9215 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9216 (regex_compile, re_search_2, re_match_2_internal):
9217 Remove unused local vars.
9218 (FREE_VAR): Rewrite so as not to use empty "else",
9219 which gcc can warn about.
9220 (regex_compile, re_match_2_internal): Mark locals as initialized.
9221 (RETALLOC_IF): Define only if needed.
9222 (WORDCHAR_P): Likewise. This one is never needed, but is used
9223 only in a comment talking about a compiler bug, so put inside
9224 the #if 0 of that comment.
9225 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9226 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9229 * search.c (boyer_moore): Rename locals to avoid shadowing.
9230 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9231 (PREV_CHAR_BOUNDARY): Likewise.
9233 * search.c (simple_search): Remove unused var.
9235 * dired.c (compile_pattern): Move decl from here ...
9236 * lisp.h: ... to here, so that it can be checked.
9237 (struct re_registers): New forward decl.
9239 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9241 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9243 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9244 Rename locals to avoid shadowing.
9245 (Fvertical_motion): Mark locals as initialized.
9247 * casefiddle.c (casify_object, casify_region): Now static.
9248 (casify_region): Mark local as initialized.
9250 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9252 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9253 New macros, so that the caller can use some names other than
9254 gcpro1, gcpro2, etc.
9255 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9257 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9258 argument, for consistency with GCPRO2_VAR, etc: it is now the
9259 prefix of the variable, not the variable itself. All uses
9261 * dired.c (directory_files_internal, file_name_completion):
9262 Rename locals to avoid shadowing.
9264 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9265 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9266 dired.c's scmp function, had undefined behavior.
9267 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9268 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9269 * buffer.h: ... to here, because these macros use current_buffer,
9270 and the new implementation with inline functions needs to have
9271 current_buffer in scope now, rather than later when the macros
9273 (downcase, upcase1): New static inline functions.
9274 (DOWNCASE, UPCASE1): Reimplement using these functions.
9275 This avoids undefined behavior in expressions like
9276 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9277 from race conditions in accessing the global variables
9278 case_temp1 and case_temp2.
9279 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9280 * lisp.h (case_temp1, case_temp2): Remove their decls.
9281 * character.h (ASCII_CHAR_P): Move from here ...
9282 * lisp.h: ... to here, so that the inline functions mentioned
9285 * dired.c (directory_files_internal_unwind): Now static.
9287 * fileio.c (file_name_as_directory, directory_file_name):
9288 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9290 (file_name_as_directory): Use const pointers when appropriate.
9291 (Fexpand_file_name): Likewise. In particular, newdir might
9292 point at constant storage, so make it a const pointer.
9293 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9294 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9296 (Fset_file_times, Finsert_file_contents, auto_save_error):
9297 Rename locals to avoid shadowing.
9299 * minibuf.c (choose_minibuf_frame_1): Now static.
9300 (Ftry_completion, Fall_completions): Rename or remove locals
9303 * marker.c (bytepos_to_charpos): Remove; unused.
9305 * lisp.h (verify_bytepos, count_markers): New decls,
9306 so that gcc does not warn that these functions aren't declared.
9308 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9309 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9310 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9311 (copy_text): Remove unused local var.
9313 * filelock.c (within_one_second): Now static.
9314 (lock_file_1): Rename local to avoid shadowing.
9316 * buffer.c (fix_overlays_before): Mark locals as initialized.
9317 (fix_start_end_in_overlays): Likewise. This function should be
9318 simplified by using pointers-to-pointers, but that's a different
9320 (switch_to_buffer_1): Now static.
9321 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9322 (report_overlay_modification): Rename locals to avoid shadowing.
9324 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9325 Fix pointer signedness issue.
9326 (sys_subshell): Mark local as volatile if checking for lint,
9327 to suppress a gcc -Wclobbered warning that does not seem to be right.
9328 (MAXPATHLEN): Define only if needed.
9330 * process.c (serial_open, serial_configure): Move decls from here ...
9331 * systty.h: ... to here, so that they can be checked.
9333 * fns.c (get_random, seed_random): Move extern decls from here ...
9334 * lisp.h: ... to here, so that they can be checked.
9336 * sysdep.c (reset_io): Now static.
9337 (wait_for_termination_signal): Remove; unused.
9339 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9340 (copy_keymap_item, append_key, push_text_char_description):
9342 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9343 (DENSE_TABLE_SIZE): Remove; unused.
9344 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9345 (describe_map_tree):
9346 Rename locals to avoid shadowing.
9348 * keyboard.c: Declare functions static if they are not used elsewhere.
9349 (echo_char, echo_dash, cmd_error, top_level_2):
9350 (poll_for_input, handle_async_input): Now static.
9351 (read_char, kbd_buffer_get_event, make_lispy_position):
9352 (make_lispy_event, make_lispy_movement, apply_modifiers):
9353 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9354 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9355 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9356 (read_key_sequence, read_char): Mark locals as initialized.
9357 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9359 * keyboard.h (make_ctrl_char): New decl.
9360 (mark_kboards): Move decl here ...
9361 * alloc.c (mark_kboards): ... from here.
9363 * lisp.h (force_auto_save_soon): New decl.
9365 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9366 (DEFINE_DUMMY_FUNCTION): New macro.
9367 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9369 (main): Add casts to avoid warnings
9370 if GCC considers string literals to be constants.
9372 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9374 * dbusbind.c: Pointer signedness fixes.
9375 (xd_signature, xd_append_arg, xd_initialize):
9376 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9377 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9378 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9379 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9381 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9382 if GCC considers string literals to be constants.
9383 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9385 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9387 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9388 (print_preprocess, print_object): New macro to fix last change.
9390 * print.c (print_preprocess): Don't forget font objects.
9392 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9394 * emacs.c (USAGE3): Doc fixes.
9396 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9398 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9401 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9403 * lisp.h (VWindow_system, Qfile_name_history):
9404 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9405 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9406 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9408 * w32select.c: Don't #include "keyboard.h".
9409 (run_protected): Add extern declaration for waiting_for_input.
9411 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9412 * w32console.c (detect_input_pending, read_input_pending)
9413 (encode_terminal_code):
9414 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9415 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9416 (w32_system_caret_y, Qfile_name_history):
9417 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9418 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9419 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9420 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9421 * w32proc.c (Qlocal, report_file_error):
9422 * w32term.c (Vwindow_system, updating_frame):
9423 * w32uniscribe.c (initialized, uniscribe_font_driver):
9424 Remove unneeded extern declarations.
9426 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9428 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9430 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9432 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9433 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9434 These macros can no longer be used for assignment.
9436 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9437 Assign struct members directly, instead of using BUF_BEGV etc.
9438 (record_buffer_markers, fetch_buffer_markers): New functions for
9439 recording and fetching special buffer markers.
9440 (set_buffer_internal_1, set_buffer_temp): Use them.
9442 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9444 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9446 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9447 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9449 * xdisp.c (hscroll_window_tree):
9450 (reconsider_clip_changes): Use PT instead of BUF_PT.
9452 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9454 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9455 $(EMACS_ROOT)/lib/intprops.h.
9457 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9459 Fix more problems found by GCC 4.5.2's static checks.
9461 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9462 to unsigned char * to avoid compiler diagnostic.
9463 (xg_free_frame_widgets): Make it clear that a local variable is
9464 needed only if USE_GTK_TOOLTIP.
9465 (gdk_window_get_screen): Make it clear that this macro is needed
9466 only if USE_GTK_TOOLTIP.
9467 (int_gtk_range_get_value): New function, which avoids a diagnostic
9468 from gcc -Wbad-function-cast.
9469 (xg_set_toolkit_scroll_bar_thumb): Use it.
9470 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9471 diagnostic from gcc -Wbad-function-cast.
9472 (get_utf8_string, xg_get_file_with_chooser):
9473 Rename locals to avoid shadowing.
9474 (create_dialog): Move locals to avoid shadowing.
9476 * xgselect.c (xg_select): Remove unused var.
9478 * image.c (four_corners_best): Mark locals as initialized.
9479 (gif_load): Initialize transparent_p to zero (Bug#8238).
9480 Mark another local as initialized.
9481 (my_png_error, my_error_exit): Mark with NO_RETURN.
9483 * image.c (clear_image_cache): Now static.
9484 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9485 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9486 (x_edge_detection): Remove unnecessary cast that
9487 gcc -Wbad-function-cast diagnoses.
9488 (gif_load): Fix pointer signedness.
9489 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9490 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9492 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9494 Improve quality of tests for time stamp overflow.
9495 For example, without this patch (encode-time 0 0 0 1 1
9496 1152921504606846976) returns the obviously-bogus value (-948597
9497 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9498 reports time overflow. See
9499 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9500 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9501 * editfns.c: Include limits.h and intprops.h.
9502 (TIME_T_MIN, TIME_T_MAX): New macros.
9503 (time_overflow): Move earlier, to before first use.
9504 (hi_time, lo_time): New functions, for an accurate test for
9506 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9507 (Fget_internal_run_time): Don't assume time_t fits in int.
9508 (make_time): Use list2 instead of Fcons twice.
9509 (Fdecode_time): More accurate test for out-of-range times.
9510 (check_tm_member): New function.
9511 (Fencode_time): Use it, to test for out-of-range times.
9512 (lisp_time_argument): Don't rely on undefined left-shift and
9513 right-shift behavior when checking for time stamp overflow.
9515 * editfns.c (time_overflow): New function, refactoring common code.
9516 (Fformat_time_string, Fdecode_time, Fencode_time):
9517 (Fcurrent_time_string): Use it.
9519 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9520 * dired.c (make_time): Move to ...
9521 * editfns.c (make_time): ... here.
9522 * systime.h: Note the move.
9524 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9526 * fringe.c (update_window_fringes): Remove unused variables.
9528 * unexmacosx.c (copy_data_segment): Also copy __got section.
9531 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9533 * termcap.c [MSDOS]: Include "msdos.h".
9534 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9535 Constify `char *' arguments and their references according to
9536 prototypes in tparam.h.
9538 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9540 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9541 Adapt all references accordingly.
9543 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9545 2011-03-11 Tom Tromey <tromey@redhat.com>
9547 * buffer.c (syms_of_buffer): Remove obsolete comment.
9549 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9551 * termhooks.h (encode_terminal_code): Declare prototype.
9553 * msdos.c (encode_terminal_code): Don't declare prototype.
9555 * term.c (encode_terminal_code): Now external again, used by
9556 w32console.c and msdos.c.
9558 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9559 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9561 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9563 Fix some minor problems found by GCC 4.5.2's static checks.
9565 * fringe.c (update_window_fringes): Mark locals as initialized
9567 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9569 * alloc.c (mark_fringe_data): Move decl from here ...
9570 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9571 to check its interface.
9572 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9574 * fontset.c (free_realized_fontset): Now static.
9575 (Fset_fontset_font): Rename local to avoid shadowing.
9576 (fontset_font): Mark local as initialized.
9577 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9579 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9581 * xselect.c (x_disown_buffer_selections): Remove; not used.
9582 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9583 (x_own_selection, Fx_disown_selection_internal): Rename locals
9585 (x_handle_dnd_message): Remove local to avoid shadowing.
9587 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9588 so that the caller can use some name other than gcpro1.
9589 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9590 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9591 (Fx_backspace_delete_keys_p):
9592 Use them to avoid shadowing, and rename vars to avoid shadowing.
9593 (x_decode_color, x_set_name, x_window): Now static.
9594 (Fx_create_frame): Add braces to silence GCC warning.
9595 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9596 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9597 Remove unused locals.
9598 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9599 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9600 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9603 * xterm.h (x_mouse_leave): New decl.
9605 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9606 Remove unused functions.
9607 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9608 (x_calc_absolute_position): Now static.
9609 (XTread_socket): Don't define label "out" unless it's used.
9610 Don't declare local "event" unless it's used.
9611 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9612 unless they are used.
9613 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9614 (x_fatal_error_signal): Remove; not used.
9615 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9616 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9617 (x_error_catcher, x_connection_closed, x_error_handler):
9618 (x_error_quitter, xembed_send_message, x_iconify_frame):
9619 (my_log_handler): Rename locals to avoid shadowing.
9620 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9621 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9623 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9624 Rename or move locals to avoid shadowing.
9625 (tty_defined_color, merge_face_heights): Now static.
9626 (free_realized_faces_for_fontset): Remove; not used.
9627 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9628 does not deduce is never used uninitialized.
9629 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9630 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9632 * terminal.c (store_terminal_param): Now static.
9634 * xmenu.c (menu_highlight_callback): Now static.
9635 (set_frame_menubar): Remove unused local.
9636 (xmenu_show): Rename parameter to avoid shadowing.
9637 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9638 since they might point to immutable storage.
9639 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9640 since it's unused otherwise.
9642 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9643 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9644 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9645 avoids a gcc -Wuninitialized diagnostic.
9646 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9647 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9648 does not deduce are never used uninitialized.
9650 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9652 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9653 * window.c (window_loop, size_window):
9654 (run_window_configuration_change_hook, enlarge_window): Likewise.
9656 * window.c (display_buffer): Now static.
9657 (size_window): Mark variables that gcc -Wuninitialized
9658 does not deduce are never used uninitialized.
9659 * window.h (check_all_windows): New decl, to forestall
9660 gcc -Wmissing-prototypes diagnostic.
9661 * dispextern.h (bidi_dump_cached_states): Likewise.
9663 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9665 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9667 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9668 and to avoid gcc -Wuninitialized warning.
9669 (load_charset_map): Mark variables that gcc -Wuninitialized
9670 does not deduce are never used uninitialized.
9671 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9673 * coding.c (coding_set_source, coding_set_destination):
9674 Use "else { /* comment */ }" rather than "else /* comment */;"
9675 for clarity, and to avoid gcc -Wempty-body warning.
9676 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9677 a block, when the outer 'i' will do.
9678 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9679 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9680 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9681 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9682 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9683 Rename locals to avoid shadowing.
9684 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9685 * coding.c (emacs_mule_char, encode_invocation_designation):
9686 Now static, since they're not used elsewhere.
9687 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9688 (decode_coding_object, encode_coding_object, detect_coding_system):
9689 (decode_coding_emacs_mule): Mark variables that gcc
9690 -Wuninitialized does not deduce are never used uninitialized.
9691 (detect_coding_iso_2022): Initialize a local variable that might
9692 be used uninitialized. Leave a FIXME because it's not clear that
9693 this initialization is needed. (Bug#8211)
9694 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9695 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9696 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9697 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9698 Remove unused macros.
9700 * category.c (hash_get_category_set): Remove unused local var.
9701 (copy_category_table): Now static, since it's not used elsewhere.
9702 * character.c (string_count_byte8): Likewise.
9704 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9705 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9707 * chartab.c (copy_sub_char_table): Now static, since it's not used
9709 (sub_char_table_ref_and_range, char_table_ref_and_range):
9710 Rename locals to avoid shadowing.
9711 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9713 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9714 (BIDI_BOB): Remove unused macro.
9716 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9717 deduce are never used uninitialized.
9718 * term.c (encode_terminal_code): Likewise.
9720 * term.c (encode_terminal_code): Now static. Remove unused local.
9722 * tparam.h: New file.
9723 * term.c, tparam.h: Include it.
9724 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9725 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9726 Move these decls to tparam.h, and make them agree with what
9727 is actually in tparam.c. The previous trick of using incompatible
9728 decls in different modules does not conform to the C standard.
9729 All callers of tparam changed to use tparam's actual API.
9730 * tparam.c (tparam1, tparam, tgoto):
9731 Use const pointers where appropriate.
9733 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9734 * cm.h (struct cm): Likewise.
9735 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9736 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9737 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9738 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9739 (turn_on_face, init_tty): Likewise.
9740 * termchar.h (struct tty_display_info): Likewise.
9742 * term.c (term_mouse_position): Rename local to avoid shadowing.
9744 * alloc.c (mark_ttys): Move decl from here ...
9745 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9747 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9749 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9751 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9753 * search.c (compile_pattern_1): Remove argument regp, unused since
9754 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9755 (compile_pattern): Don't pass it.
9757 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9759 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9760 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9762 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9764 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9766 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9767 gdk_window_get_screen, gdk_window_get_geometry,
9768 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9769 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9770 (xg_get_pixbuf_from_pixmap): New function.
9771 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9772 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9773 Call xg_get_pixbuf_from_pixmap instead of
9774 gdk_pixbuf_get_from_drawable.
9775 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9776 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9777 (xg_check_special_colors): Use GtkStyleContext and its functions
9779 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9780 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9781 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9782 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9783 Call gtk_widget_get_preferred_size.
9784 (xg_frame_resized): gdk_window_get_geometry only takes 5
9786 (xg_win_to_widget, xg_event_is_for_menubar):
9787 Call gdk_x11_window_lookup_for_display.
9788 (xg_set_widget_bg): New function.
9789 (delete_cb): New function.
9790 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9791 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9792 (xg_set_background_color): Call xg_set_widget_bg.
9793 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9794 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9795 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9796 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9798 (update_frame_tool_bar): Call gtk_widget_hide.
9799 (xg_initialize): Use GDK_KEY_g.
9801 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9803 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9805 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9806 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9807 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9809 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9811 * w32xfns.c (select_palette): Check success of RealizePalette against
9812 GDI_ERROR, not zero.
9814 See ChangeLog.11 for earlier changes.
9820 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9822 This file is part of GNU Emacs.
9824 GNU Emacs is free software: you can redistribute it and/or modify
9825 it under the terms of the GNU General Public License as published by
9826 the Free Software Foundation, either version 3 of the License, or
9827 (at your option) any later version.
9829 GNU Emacs is distributed in the hope that it will be useful,
9830 but WITHOUT ANY WARRANTY; without even the implied warranty of
9831 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9832 GNU General Public License for more details.
9834 You should have received a copy of the GNU General Public License
9835 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.