1 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
3 * callproc.c: Fix race that killed background processes (Bug#15144).
4 (call_process): New arg TEMPFILE_INDEX. Callers changed.
5 Record deleted process-id in critical section, not afterwards.
6 Don't mistakenly kill process created by a call-process invocation
7 that discards output and does not wait.
9 2013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
11 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
12 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
13 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
14 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
15 to shut up compiler in mark_object.
16 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
18 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
20 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
21 We can't portably rely on PTY_OPEN doing that, even if
22 it calls posix_openpt with O_CLOEXEC.
24 2013-08-20 Kenichi Handa <handa@gnu.org>
26 * character.c (string_char): Improve commentary.
28 2013-08-20 Paul Eggert <eggert@cs.ucla.edu>
30 * image.c (SIGNATURE_DIGESTSIZE): Remove.
31 (struct animation_cache): Make signature a flexible array member.
32 All uses changed. This is a tad slower but may insulate us better
33 from future changes to ImageMagick.
35 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
37 * image.c: Shrink memory needed for animation cache.
38 (SIGNATURE_DIGESTSIZE): New constant.
39 (struct animation_cache): Make 'signature' a fixed size array of bytes.
40 (imagemagick_create_cache): Copy the signature. This saves
41 several KB of memory that ImageMagick wastes per signature.
42 Don't bother updating the update_time, as the caller does that now.
43 (imagemagick_prune_animation_cache): Don't destroy the signature, as
44 it's a fixed size struct member now.
45 (imagemagick_get_animation_cache): Always destroy the signature,
46 as it's now imagemagick_create_cache's responsibility to copy it.
47 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
48 and use memcmp rather than strcmp.
49 eassert that ImageMagick returns a signature of the specified length.
51 2013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
53 * image.c (imagemagick_get_animation_cache): Don't segfault on
55 (imagemagick_get_animation_cache): Revert to previous definition
56 so that it actually works. But keep the memory leak fix.
57 (imagemagick_get_animation_cache): Fix memory leak.
59 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
61 * image.c: Fix animation cache signature memory leak.
62 Fix some other minor performance problems while we're at it.
63 (imagemagick_create_cache): Clear just the members that
64 need clearing. Don't set update_time, as caller does that now.
65 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
66 Simplify by using pointer-to-pointer instead of a prev pointer.
67 (imagemagick_prune_animation_cache): Use make_emacs_time rather
68 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
69 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
70 it's already a copy. Free the signature probe unless it's cached.
72 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
73 This was introduced by my 2013-08-12 fix for Bug#15035.
75 2013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
77 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
78 (imagemagick_prune_animation_cache): Now static.
80 2013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
82 * image.c (imagemagick_get_animation_cache): Don't segfault when
85 2013-08-18 Ken Brown <kbrown@cornell.edu>
87 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
88 static heap if ENABLE_CHECKING is defined.
89 (max_bss_sbrk_ptr): New variable.
91 (report_sheap_usage): Report maximum static heap usage instead of
92 ending static heap usage.
94 2013-08-17 Eli Zaretskii <eliz@gnu.org>
96 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
97 of zlib_initialized according to the results of calling
100 2013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
102 * image.c: Implement an ImageMagick per-image cache.
103 (imagemagick_get_animation_cache): Fix a double-free error.
104 (imagemagick_load_image): Remove the ping_wand code, which only
105 apparently saved time on invalid animated images, and slowed down
106 everything else. Optimise for the common case.
108 2013-08-16 Xue Fuqiao <xfq.free@gmail.com>
110 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
112 * editfns.c (insert_before_markers): Mention overlay in the doc string.
114 * marker.c (set_marker): Remove documentation of undefined behavior.
116 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
118 * image.c (imagemagick_compute_animated_image): Animate correctly
119 when sub-images are smaller than the main image.
120 (imagemagick_compute_animated_image): Setting the iterator row to
121 zero is apparently not allowed.
122 (imagemagick_compute_animated_image): Allow images that say they
123 have sub-images that are bigger than the main image, but just crop
126 2013-08-15 Jan Djärv <jan.h.d@swipnet.se>
128 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
130 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
132 * image.c (imagemagick_compute_animated_image): Respect the GIF
135 2013-08-15 Ken Brown <kbrown@cornell.edu>
137 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
138 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
141 2013-08-15 Paul Eggert <eggert@cs.ucla.edu>
143 Fix minor problems found by static checking.
144 * frame.c (delete_frame):
145 * xdisp.c (next_element_from_display_vector):
146 Avoid uninitialized local.
147 * image.c (imagemagick_compute_animated_image): Port to C89.
148 Prefer usual GNU indentation style for loops.
149 Be more careful about bizarrely large sizes, by using ptrdiff_t
152 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
154 Fix infinite frame selection loop (Bug#15025).
155 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
157 2013-08-15 Eli Zaretskii <eliz@gnu.org>
159 * xdisp.c (compute_window_start_on_continuation_line): When
160 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
161 to make sure we end up setting the window start at the leftmost
162 visible character of the display line. This avoids funky
163 horizontal shifting because the window start is not kept on the
164 same position. (Bug#15090)
165 (next_element_from_display_vector): Support 'box' face attribute
166 in the face definitions of a display vector. (Bug#15099)
168 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
170 * image.c (imagemagick_compute_animated_image): Implement animated
172 (imagemagick_compute_animated_image): Fix some compilation
173 warnings. Implement a very simple cache to make the animation
174 usable at all, but it should be replaced with a per-image cache.
176 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
178 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
179 to do `for' loops over alist values.
180 * buffer.h (FOR_EACH_BUFFER):
181 * process.c (FOR_EACH_PROCESS): Use it.
182 (handle_child_signal, status_notify, Fget_buffer_process)
183 (kill_buffer_processes): Use FOR_EACH_PROCESS.
185 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
187 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
188 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
189 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
190 to xzalloc and so avoid redundant call to memset.
191 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
192 members because it is allocated with xzalloc and so already zeroed.
194 2013-08-14 Ken Brown <kbrown@cornell.edu>
196 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
199 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
201 Utility function and macro to copy Lisp string to C string.
202 * lisp.h (xlispstrdupa): New macro.
203 (xlispstrdup): New prototype.
204 * alloc.c (xlispstrdup): New function.
205 * callint.c (Fcall_interactively):
206 * fileio.c (Ffile_name_directory, Fexpand_file_name)
207 (Fsubstitute_in_file_name):
208 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
209 * image.c (x_create_bitmap_from_file):
210 * w32term.c (w32_term_init):
211 * xterm.c (x_term_init): Use xlispstrdup.
213 2013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
215 * image.c (imagemagick_load_image): Make animated pictures work.
216 There's still some problems with background color settings, though
219 * decompress.c (unwind_decompress): Always restore point.
221 2013-08-14 Xue Fuqiao <xfq.free@gmail.com>
223 * marker.c (set_marker): Reformat documentation.
225 2013-08-14 Paul Eggert <eggert@cs.ucla.edu>
227 * xdisp.c (cursor_type_changed): Now static.
229 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
230 Use changed. This avoids the need to call xmalloc and for the
231 caller to call xfree, and avoids memory leaks in some situations.
233 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
235 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
236 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
237 (redisplay_window): If window_end_valid is cleared due to non-zero
238 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
239 so do not call to try_cursor_movement for that window.
241 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
243 * window.h (struct window): Convert window_end_pos and
244 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
245 (wset_window_end_pos, wset_window_end_vpos): Remove.
246 * dispnew.c (adjust_glyph_matrix):
247 * window.c (Fwindow_end, replace_window, set_window_buffer)
249 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
250 (set_vertical_scroll_bar, redisplay_window, try_window)
251 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
252 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
253 (note_mouse_highlight): Adjust users.
254 (try_cursor_movement): Likewise. Convert old precondition to eassert.
257 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
259 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
260 * image.c (imagemagick_filename_hint): Use `const char *' and
261 prefer SSDATA to SDATA to avoid warnings.
263 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
265 Cleanup window fringes, margins and scroll bars adjustments.
266 * window.c (set_window_fringes, set_window_margins)
267 (set_window_scroll_bars, apply_window_adjustment): New functions.
268 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
269 (Fset_window_scroll_bars): Use them.
271 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
273 * window.h (struct window): Convert scroll_bar_width
274 from Lisp_Object to integer. Adjust comment.
275 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
277 * window.c (wset_scroll_bar_width): Remove.
278 (make_window): Initialize scroll_bar_width.
279 (Fsplit_window_internal): Use direct assignment.
280 (Fset_window_configuration, save_window_save):
281 Convert Lisp_Object to integer and back where appropriate.
282 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
283 bar was actually changed, and mention this in docstring.
285 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
287 * decompress.c: Minor simplifications.
288 (Fzlib_decompress_region): Don't bother verifying
289 that avail_out <= UINT_MAX, as that was confusing.
290 Mention the restriction in a comment instead.
291 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
293 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
295 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
296 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
298 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
300 * image.c (imagemagick_filename_hint): Check for errors in the
303 2013-08-13 Eli Zaretskii <eliz@gnu.org>
305 * window.c (Fwindow_margins): Return nil when there's no marginal
306 area, as per the documented API.
308 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
309 Fmake_vector, as scroll bar's struct members are not all Lisp
310 objects now. This avoids crashes in GC.
312 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
313 bool, so its address could be taken.
315 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
317 * image.c (imagemagick_filename_hint): New function to possibly
318 apply `image-content-type-suffixes'.
319 (imagemagick_load_image): Use it.
321 2013-08-13 Eli Zaretskii <eliz@gnu.org>
323 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
324 if loading zlib failed.
326 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
328 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
329 2013-08-13 checkin below. Change bool to BOOL, rule is:
330 All Obj-C code uses BOOL, except for interfaces callable from C.
332 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
334 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
336 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
337 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
338 bool instead of BOOL.
339 * w32term.h (struct scroll_bar): Convert fringe_extended_p
340 from Lisp_Object to bitfield. Adjust comment.
341 * w32term.c (x_scroll_bar_create): Adjust user.
342 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
343 * xterm.c (XTset_vertical_scroll_bar): Likewise.
344 Use bool for boolean.
345 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
346 to `unsigned int' when defining a bitfield.
348 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
350 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
352 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
354 * window.h (struct window): Convert left_margin_cols and
355 right_margin_cols from Lisp_Objects to integers. Adjust comment.
356 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
357 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
359 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
361 (showing_window_margins_p, update_window_line, update_frame_1):
362 * fringe.c (draw_fringe_bitmap_1):
363 * xdisp.c (window_box_width): Adjust users.
364 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
365 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
366 Use direct assignment.
367 (Fset_window_configuration, save_window_save, Fwindow_margins):
368 Convert Lisp_Object to integer and back where appropriate.
369 (Fset_window_margins): Adjust user. Return t if any margin
370 was actually changed, and mention this in docstring.
372 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
374 * syntax.c (forward_word):
375 * cmds.c (forward_char, backward_char): Mention the optional argument.
377 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
379 * window.h (struct window): Convert left_fringe_width
380 and right_fringe_width from Lisp_Objects to integers.
382 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
383 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
384 * window.c (wset_left_fringe_width, wset_right_fringe_width):
386 (make_window): Initialize new integer fields to -1.
387 (Fsplit_window_internal): Use direct assignment.
388 (Fset_window_configuration, save_window_save): Convert
389 Lisp_Object to integer and back where appropriate.
390 (Fset_window_fringes): Adjust user. Return t if any fringe
391 was actually changed, and mention this in docstring.
393 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
395 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
396 * nsfns.m (x_set_cursor_type):
397 * w32fns.c (x_set_cursor_type):
398 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
399 * xdisp.c (set_frame_cursor_types): ...but in common code.
401 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
403 * font.c (clear_font_cache): New function, stripped from...
404 (Fclear_font_cache): ...here, which now uses the function
405 above. Adjust comment.
406 * font.h (clear_font_cache): Add prototype.
407 * xfaces.c (clear_face_cache): Use clear_font_cache.
409 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
411 * window.c (Fset_window_start): Compare `w', not `window' because
412 `w' might not be equal to `window' after call to decode_live_window.
414 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
416 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
417 This fixes a problem introduced by the Bug#15035 patch
418 when using GPG. Reported by Herbert J. Skuhra.
420 2013-08-12 Eli Zaretskii <eliz@gnu.org>
422 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
423 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
426 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
428 * decompress.c (Fzlib_decompress_region): Support zlib
429 decompression, too, and rename.
431 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
433 Minor zlib configuration tweaks.
434 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
435 Don't assume presence of fn_inflateInit2_ zlib internal function.
437 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
439 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
440 include the zlib prefix.
442 2013-08-12 Eli Zaretskii <eliz@gnu.org>
444 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
445 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
446 define static variables that are pointers to zlib functions to be
448 (init_zlib_functions) [WINDOWSNT]: New function.
449 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
451 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
452 macros instead of invoking the zlib functions directly.
453 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
456 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
458 Avoid looping over all frame windows to freeze and unfreeze.
459 * window.h (struct window): Drop frozen_window_start_p.
460 (freeze_window_starts): Drop prototype.
461 * frame.h (struct frame): New frozen_window_starts flag.
462 (FRAME_WINDOWS_FROZEN): New macro.
463 * window.c (freeze_window_start, freeze_window_starts):
465 (select_window, replace_window): Adjust users.
466 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
467 (window_frozen_p): New function.
468 (redisplay_window): Use it.
470 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
472 Fix some fd issues when running subprocesses (Bug#15035).
473 Fix bugs that can leak files or file descriptors on errors.
474 Don't unlink open temp files, as that's hard for users to diagnose
475 when things go awry (e.g., temp disk exhausted).
476 Don't bother to lock temp files. Check for invalid recursion.
477 * callproc.c (synch_process_fd): Remove. All uses removed.
478 (synch_process_tempfile): New var or macro.
479 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
481 (record_kill_process): New arg, the temp name. All callers changed.
482 (delete_temp_file): Now just a simple wrapper around unlink.
483 (call_process_kill): New arg, the call_process_fd array.
484 Close them all. Clear synch_process_pid. Remove the temp file,
485 or arrange for it to be removed.
486 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
487 that's been moved to synch_process_tempfile. Caller changed.
488 Do not remove the tempfile; that's now call_process_kill's
490 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
491 call_process_kill; the caller now does that.
492 (call_process_cleanup): Do not close the process fd; that's now
493 call_process_kill's responsibility.
494 (Fcall_process): Implement via new function call_process, which
495 has most of the old body of Fcall_process, but with a different API.
496 (call_process): New function that does not open or close filefd if
497 it is nonnegative. Record which fds need to be closed, and let
498 call_process_kill close (and remove the tempfile, on MSDOS) on error.
499 Signal an error if invoked recursively (could be done via a hook).
500 Simplify creation of the tempfile in the MSDOS case.
501 Don't create the output file until after checking for the executable.
502 Report any failure to open /dev/null.
503 Don't open /dev/null for writing twice; once is enough.
504 Don't create pipe if all output is being discarded or sent to file.
505 Don't worry about setting up the coding system or reading from the
506 pipe if all output is being discarded.
507 Hoist fd_error local into top level, to lessen block nesting.
508 Don't record deleted pid here; now done by Fcall_process_region.
509 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
510 and note its success in synch_process_tempfile.
511 Do not leak resources when child_setup fails.
512 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
513 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
514 (create_temp_file): Now returns open fd, with an additional
515 Lisp_Object * argument to return the name. All callers changed.
516 Do not close the file; rewind it instead, and leave it open for
517 the caller. Do not lock the temp file. Unwind-protect the file
518 and the file-descriptor.
519 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
520 If an asynchrounous process, record it here, not in call_process.
521 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
522 * eval.c (set_unwind_protect): New function.
523 * fileio.c (write_region): New function, generalized from the
524 old Fwrite_region. Do not lock temp files.
525 (Fwrite_region): Use it.
526 * lisp.h (set_unwind_protect, write_region): New decls.
527 * process.c: Include <verify.h>.
528 (make_process): Mark fds as initially closed.
529 (deleted_pid_list): Now a list of pid-filename pairs.
531 (close_process_fd): New function.
532 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
533 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
534 New constants. Verify that their number matches PROCESS_OPEN_FDS.
535 (create_process, create_pty, Fmake_serial_process)
536 (server_accept_connection): Record which fds need to be closed,
537 and let deactivate_process close them.
538 (Fmake_network_process): Do not discard the unwind-protect
539 until it's safe to do so.
540 (deactivate_process): Close the fds opened by create_process etc.
541 (Fprocess_send_eof): Adjust to new way of recording open fds.
542 Report an error if /dev/null can't be opened, instead of aborting.
543 * process.h (PROCESS_OPEN_FDS): New constant.
544 (struct Lisp_Process): New member open_fds.
545 (record_kill_process, record_deleted_pid): Adjust signatures.
546 (record_deleted_pid): Move decl here ...
547 * syswait.h (record_deleted_pid): ... from here.
549 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
551 * decompress.c: Fix bugs with large buffers and weird inputs.
552 Tune a bit. Reindent as per usual Emacs style.
553 (BUFFER_SIZE): Remove.
554 (Fdecompress_gzipped_region): Do not mishandle input buffers with
555 more than UINT_MAX bytes. Decompress into the gap instead of into
556 an auto buffer, as this should avoid copying. Return nil if
557 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
558 set immediate_quit; we shouldn't trust zlib code that much.
560 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
562 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
563 errors, and really move the gap to where we want it.
565 * lisp.h: Include decompress.c support.
567 * emacs.c (main): Include decompress.c support.
569 * Makefile.in: Include -lz if present.
571 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
573 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
574 (initWithTitle:): Initialize frame to 0.
575 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
576 (fillWithWidgetValue:frame:): Renamed from
577 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
579 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
580 fillWithWidgetValue:frame:
582 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
583 remove memory leak warnings.
585 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
586 (ns_check_menu_open): Handle menu == nil. Remove assignment to
589 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
590 (x_activate_menubar): Update the whole menu.
591 (trackingNotification:): Call ns_check_menu_open if tracking ends.
592 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
593 current event is not NSSystemDefined (Bug#15001).
594 Call ns_check_menu_open only if trackingMenu is 2.
595 (menuDidClose:): New method, decrease trackingMenu.
596 (fillWithWidgetValue:setDelegate:): New method.
597 (fillWithWidgetValue:): Call the above.
599 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
601 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
603 Omit some unnecessary casts.
604 Many of these go back to the old pre-C89 days, when they may have
605 been needed, but we've been assuming C89 or later for a while now.
606 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
607 (live_float_p, live_misc_p, live_vector_p):
608 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
609 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
611 * callint.c (Fcall_interactively):
612 * doc.c (Fsubstitute_command_keys):
613 * filelock.c (get_boot_time):
614 * frame.c (xrdb_get_resource):
615 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
616 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
617 (xg_get_file_name_from_selector, menuitem_destroy_callback)
618 (menuitem_highlight_callback, menu_destroy_callback)
619 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
620 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
621 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
622 (xg_tool_bar_help_callback, tb_size_cb):
623 * image.c (xpm_alloc_color, png_read_from_memory)
624 (png_read_from_file, png_load_body, our_memory_skip_input_data)
625 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
627 * keymap.c (describe_map):
628 * nsfns.m (Fns_display_monitor_attributes_list):
629 * nsmenu.m (process_dialog:):
630 * nsterm.m (hold_event):
631 * process.c (wait_reading_process_output):
632 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
633 * scroll.c (do_direct_scrolling, scrolling_1):
634 * termcap.c (tgetent):
635 * window.c (check_window_containing, add_window_to_list)
636 (freeze_window_starts):
637 * xdisp.c (compare_overlay_entries, vmessage):
638 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
639 (x_get_monitor_attributes_xrandr)
640 (Fx_display_monitor_attributes_list, x_display_info_for_name)
641 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
642 * xfont.c (xfont_match, xfont_open):
643 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
644 (menubar_selection_callback, menu_position_func)
645 (popup_selection_callback, create_and_show_popup_menu)
646 (dialog_selection_callback, create_and_show_dialog):
647 * xrdb.c (x_get_string_resource):
649 * xsmfns.c (x_session_check_input):
650 * xterm.c (x_draw_glyphless_glyph_string_foreground)
651 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
652 (xaw_jump_callback, xaw_scroll_callback):
653 Omit unnecessary casts.
655 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
657 Minor string-length refactoring.
658 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
659 * frame.c (make_monitor_attribute_list):
660 Prefer build_string to strlen + make_string.
662 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
664 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
665 don't check minor_code (Bug#14417).
667 2013-08-09 Eli Zaretskii <eliz@gnu.org>
669 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
670 vertical positions instead. This avoids calling MATRIX_ROW with
671 row numbers that are possibly beyond valid limits. (Bug#15064)
673 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
675 Use xstrdup and build_unibyte_string where applicable.
676 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
678 * xrdb.c (x_get_customization_string):
679 * xterm.c (xim_initialize):
680 * w32fns.c (w32_window): Use xstrdup.
681 (w32_display_monitor_attributes_list):
682 * emacs.c (init_cmdargs):
683 * keyboard.c (PUSH_C_STR):
684 * nsfont.m (nsfont_open):
685 * sysdep.c (system_process_attributes):
686 * w32.c (system_process_attributes):
687 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
689 2013-08-09 Eli Zaretskii <eliz@gnu.org>
691 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
692 variables of these types so that GDB would know about them, as aid
693 for debugging fatal exceptions. (Bug#15024) See also
694 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
697 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
699 * nsterm.m (ns_update_begin): Don't change clip path if it would be
700 larger than the NSWindow (Bug#14934).
702 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
704 Redesign redisplay interface to drop global variable updated_window.
705 Always pass currently updated window as a parameter to update routines.
706 * dispextern.h (updated_window): Remove declaration.
707 (struct redisplay_interface): Pass window parameter to
708 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
709 and after_update_window_hook.
710 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
712 * dispnew.c (updated_window): Remove.
713 (redraw_overlapped_rows, update_marginal_area, update_text_area)
714 (update_window_line): Adjust to match redisplay interface changes.
715 * nsterm.m (ns_update_window_begin, ns_update_window_end)
716 (ns_scroll_run, ns_after_update_window_line):
717 * w32term.c (x_update_window_begin, x_update_window_end)
718 (x_after_update_window_line, x_scroll_run):
719 * xterm.c (x_update_window_begin, x_update_window_end)
720 (x_after_update_window_line, x_scroll_run):
721 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
722 Likewise. Adjust comments where appropriate.
723 (x_cursor_to): Simplify because this is always called during window
724 update (but install debugging check anyway).
725 (expose_window): Check must_be_updated_p flag to see whether this
726 function is called during window update.
728 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
730 Do not reset window modification event counters excessively.
731 These leftovers and poor man's tricky methods to catch extra
732 redisplay's attention are no longer needed.
733 * frame.c (set_menu_bar_lines_1):
734 * minibuf.c (read_minibuf_unwind):
735 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
736 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
737 (window_scroll_line_based, Fset_window_configuration):
738 * xdisp.c (redisplay_window): Do not reset last_modified and
739 last_overlay_modified counters.
741 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
743 * xselect.c (x_send_client_event): Set send_event and serial, memset
744 data.l as it might be bigger than data.b. Use 24 bit mask to
745 XSendEvent (Bug#15034).
747 2013-08-07 Eli Zaretskii <eliz@gnu.org>
749 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
750 for TTY frames that are not the top frame on their console.
753 2013-08-07 Martin Rudalics <rudalics@gmx.at>
755 * w32term.c (w32fullscreen_hook): Really maximize frame when
756 asked for (Bug#14841).
758 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
760 Prefer selected_window to Fselected_window, likewise for frames.
761 * buffer.c (Fbuffer_swap_text):
762 * data.c (Fvariable_binding_locus):
763 * window.c (run_window_configuration_change_hook): Adjust users.
764 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
765 Use decode_live_frame.
767 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
769 Be more careful if selected window shows the buffer other than current,
770 use window_outdated only if this is not so. This change should also
771 address some weird issues discussed in Bug#13012.
772 * window.h (window_outdated): New prototype.
773 * window.c (window_outdated): Now here. Convert from static and
774 always assume window's buffer.
775 (Fwindow_end, Fwindow_line_height): Use it.
776 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
777 and always assume window's buffer.
778 (redisplay_window): Adjust user.
779 (redisplay_internal): Call to reconsider_clip_changes once and
780 check whether mode line should be updated only if selected window
781 shows current buffer.
782 (run_window_scroll_functions): Use eassert for debugging check.
783 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
785 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
787 * window.c (window_scroll, window_scroll_pixel_based)
788 (window_scroll_line_based): Use bool for booleans.
790 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
792 * process.c: Fix minor off-by-one issues in descriptor counts.
793 This shouldn't fix any real bugs, but it cleans up the code a bit.
794 (max_process_desc, max_input_desc): -1, not 0, means none.
796 (delete_input_desc): New function.
797 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
798 (deactivate_process): Scan backwards when recomuting max_process_desc;
799 that should be faster.
800 (init_process_emacs): Initialize max_input_desc.
802 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
804 Use region cache to speedup bidi_find_paragraph_start.
805 * buffer.h (struct buffer): New member bidi_paragraph_cache.
806 Rename cache_long_line_scans to cache_long_scans.
807 * buffer.c (bset_cache_long_line_scans): Rename to
808 bset_cache_long_scans.
809 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
810 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
812 (syms_of_buffer): Rename cache-long-line-scans to
813 cache-long-scans. Adjust docstring.
814 * search.c (newline_cache_on_off):
815 * indent.c (width_run_cache_on_off): Adjust users.
816 * bidi.c (bidi_paragraph_cache_on_off): New function.
817 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
818 * insdel.c (prepare_to_modify_buffer): Invalidate
819 bidi_paragraph_cache if enabled.
821 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
823 Invalidate region caches only if buffer text is going to be changed.
824 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
825 (modify_text): ...new prototype.
826 (prepare_to_modify_buffer_1): New prototype.
827 * textprop.c (modify_region): Rename to...
828 (modify_text_properties): ...new function.
829 (add_text_properties_1, set_text_properties, Fremove_text_properties)
830 (Fremove_list_of_text_properties): Adjust users.
831 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
832 (modify_text): ...new function.
833 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
834 (prepare_to_modify_buffer_1): ...new function.
835 * casefiddle.c (casify_region):
836 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
837 (Ftranspose_regions): Use modify_text.
839 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
841 * lisp.mk (lisp): Add nadvice.elc.
843 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
845 New macro to iterate over live buffers similar to frames.
846 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
847 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
848 Declare buffer-related variables here to offload lisp.h.
849 * buffer.c (Vbuffer_alist): Adjust comment.
850 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
851 (other_buffer_safely):
852 * data.c (store_symval_forwarding):
853 * dispnew.c (Fframe_or_buffer_changed_p):
854 * fileio.c (Fdo_auto_save):
855 * filelock.c (unlock_all_files):
856 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
858 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
860 Fix some minor races in hosts lacking mkostemp (Bug#15015).
861 * callproc.c (create_temp_file):
862 * filelock.c (create_lock_file):
863 Assume mkostemp, since it's now provided by Gnulib.
865 2013-08-04 Eli Zaretskii <eliz@gnu.org>
867 * w32.c (mkostemp): New function.
868 (mktemp): Remove, no longer used. Most of the code reused in
869 mkostemp. (Bug#15015)
870 (mktemp): Don't undef.
872 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
874 * dispnew.c (glyph_matrix_count, glyph_pool_count):
875 Move under GLYPH_DEBUG and ENABLE_CHECKING.
876 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
877 (free_glyph_pool, check_glyph_memory): Likewise for
878 all users. Adjust comments where appropriate.
880 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
882 * composite.h: Minor fixups.
883 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
884 to fix a misspelling, and change it to an inline function while
885 we're at it (it need not be a macro). All uses changed.
886 (composition_method, composition_valid_p):
887 Rewrite to avoid assignments in if-conditions.
889 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
891 Do not use global Lisp_Object in composition macros.
892 * composite.h (composition_temp): Remove declaration.
893 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
894 (composition_method, composition_valid_p): ...inline functions.
895 (compose_region): Remove the leftover.
896 * composite.c (composition_temp): Remove.
897 (run_composition_function, update_compositions)
898 (composition_compute_stop_pos, composition_adjust_point)
899 (Ffind_composition_internal):
900 * coding.c (handle_composition_annotation):
901 * xdisp.c (handle_composition_prop, check_point_in_composition):
902 Related users changed.
904 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
906 Drop FRAME_PTR typedef.
907 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
908 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
909 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
910 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
911 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
912 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
913 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
914 All related users changed.
916 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
918 * eval.c (default_toplevel_binding): New function.
920 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
921 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
922 (syms_of_eval): Export them.
923 * data.c (Fdefault_value): Micro cleanup.
924 * term.c (init_tty): Use "false".
926 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
928 Fix X GC leak in GTK and raw (no toolkit) X ports.
929 * xterm.c (x_free_frame_resources): If white and black relief
930 GCs are allocated, always free them here.
931 * xfns.c (x_make_gc): Omit redundant initialization.
932 * widget.c (create_frame_gcs): Remove the leftover.
933 (EmacsFrameDestroy): Do nothing because all GCs are now freed
934 in x_free_frame_resources.
936 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
938 * nsterm.m (windowWillResize:toSize:): Only change title if
939 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
941 (viewDidEndLiveResize): New method.
943 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
944 inside NS_IMPL_COCOA.
946 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
948 * insdel.c (adjust_after_replace, replace_range, del_range_2):
949 Do not check whether undo is enabled because record_insert and
950 record_delete does that themselves.
952 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
954 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
955 member which is not really used any more.
956 (FRAME_XIC_BASE_FONTNAME): Remove.
957 * xfns.c (xic_free_fontset): Adjust user.
958 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
959 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
960 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
961 (xdialog_show): Use eassert for debugging check.
962 * w32term.c (x_unfocus_frame): Remove unused dummy function.
964 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
966 * fileio.c, fns.c (merge): Move extern decl from here ...
967 * lisp.h (merge): ... to here.
969 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
971 Fix last font-related change.
972 * w32font.h (w32font_list_internal, w32font_match_internal):
974 * w32uniscribe.c (uniscribe_list, uniscribe_match):
975 (uniscribe_list_family): Adjust to match font API change.
976 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
977 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
979 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
981 * frame.h (FRAME_MOUSE_UPDATE):
982 * nsterm.m (ns_frame_up_to_date): Omit redundant check
983 whether hlinfo->mouse_face_mouse_frame is non-NULL.
985 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
987 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
988 * font.h (struct font_driver): Change list, match, and list_family
989 functions to accept struct frame * as first arg.
990 * font.c (font_score, font_compare, font_sort_entities): Remove
992 (font_sort_entities, font_list_entities, font_select_entity):
993 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
994 match font API change.
995 * xfont.c (xfont_list, xfont_match, xfont_list_family):
996 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
997 * ftxfont.c (ftxfont_list, ftxfont_match):
998 * xftfont.c (xftfont_list, xftfont_match):
999 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1000 * w32font.c (w32font_list, w32font_match, w32font_list):
1001 (w32font_list_internal, w32_font_match_internal): Likewise.
1002 * xfaces.c (Fx_family_fonts): Adjust user.
1004 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1006 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1007 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1008 only if HAVE_X_WINDOWS is in use.
1009 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1010 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1011 * w32term.c (x_wm_set_icon_position): Likewise.
1012 * w32fns.c (x_icon): Adjust user.
1014 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1016 * xterm.c (last_mouse_press_frame): Remove the
1017 leftover which is not really used any more.
1018 (handle_one_xevent, syms_of_xterm): Adjust users.
1019 (x_flush): Call XFlush once per each X display, not frame.
1020 This is better because this code always unconditionally skips
1021 non-X frames in Vframe_list and issues the only XFlush if we
1022 have more than one X frame on the same X display.
1023 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1024 Use bool for booleans.
1025 (x_draw_glyph_string_background, cvt_string_to_pixel):
1026 (cvt_pixel_dtor): Drop unnecessary prototypes.
1027 * xterm.h (x_display_ok): Adjust prototype.
1029 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1031 Drop unnecessary functions that deals with frame pixel size.
1032 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1033 (x_pixel_height): Drop prototypes.
1034 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1035 (x_pixel_height): Drop implementations.
1036 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1037 which should be always valid for window frame.
1038 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1039 * w32menu.c (Fx_popup_dialog):
1040 * xmenu.c (Fx_popup_dialog): Likewise for both.
1042 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1044 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1045 frame parameters and call to Fmodify_frame_parameters just once.
1046 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1047 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1048 and mention nil frame in docstring.
1050 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1052 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1053 (x_figure_window_size): Likewise. Adjust to return long.
1054 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1055 (toplevel): Move Qterminal_live_p to...
1056 * terminal.c (toplevel): ...here, make it static, and...
1057 (syms_of_terminal): ...DEFSYM here.
1058 * frame.h (Qterminal_live_p): Remove declaration.
1059 (make_frame, x_figure_window_size): Adjust prototype.
1060 * nsfns.m (Fx_create_frame): Use long for window flags.
1062 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1064 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1065 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1066 Do not assume that emacs_close (INT_MAX) is a no-op.
1068 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1070 * xfaces.c (make_face_cache): For struct face_cache, prefer
1071 xmalloc to xzalloc and so avoid redundant call to memset.
1072 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1074 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1076 * fringe.c (draw_window_fringes, update_window_fringes)
1077 (compute_fringe_widths):
1078 * w32term.c (x_draw_glyph_string):
1079 * window.c (candidate_window_p, Frecenter):
1080 * xfaces.c (realize_basic_faces, realize_default_face)
1081 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1082 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1083 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1084 * xmenu.c (Fx_menu_bar_open_internal):
1085 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1086 * xsettings.c (xft_settings_event):
1087 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1088 Use bool for booleans. Adjust style and comments where
1090 * dispextern.h (draw_window_fringes, update_window_fringes)
1091 (compute_fringe_widths):
1092 * xterm.h (x_had_errors_p): Adjust prototype.
1094 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1096 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1097 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1099 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1101 * fns.c (toplevel): Remove comment before Fsafe_length because
1104 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1106 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1108 2013-07-28 Eli Zaretskii <eliz@gnu.org>
1110 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1111 frame which got the message is still alive, before dereferencing
1112 its pointer. (Bug#14970)
1114 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1115 be a live window, before using it as such. (Bug#14970)
1117 2013-07-27 Eli Zaretskii <eliz@gnu.org>
1119 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1120 w32_detect_focus_change instead of doing part of its job by hand.
1121 This fixes the problem whereby FOCUS_OUT events were not sent to
1124 2013-07-26 Eli Zaretskii <eliz@gnu.org>
1126 * process.c (Fprocess_list): Doc fix.
1128 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1129 being re-exposed only if it didn't ask to become visible.
1130 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1131 was previously iconified. (Bug#14841)
1132 (x_iconify_frame): Mark the frame iconified.
1134 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1136 Fix minor problems found by static checking.
1137 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1138 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1140 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1142 * eval.c (set_specpdl_old_value): New function.
1143 (unbind_to): Minor simplification.
1144 (get_backtrace_frame): New function.
1145 (Fbacktrace_frame): Use it. Add `base' argument.
1146 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1147 (syms_of_eval): Export backtrace-eval.
1148 * xterm.c (x_focus_changed): Simplify.
1150 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1152 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1154 2013-07-24 Eli Zaretskii <eliz@gnu.org>
1156 * xdisp.c (redisplay_window): Instead of moving point out of
1157 scroll margin, reject the force_start method, and try scrolling
1158 instead. (Bug#14780)
1160 2013-07-24 Ken Brown <kbrown@cornell.edu>
1162 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1165 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1167 * eval.c (Fprogn): Do not check that BODY is a proper list.
1168 This undoes the previous change. The check slows down the
1169 interpreter, and is not needed to prevent a crash. See
1170 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1172 2013-07-23 Glenn Morris <rgm@gnu.org>
1174 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1176 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1178 Port to GNU/Linux systems with tinfo but not ncurses.
1179 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1180 to decide whether ncurses is being used. Without this change,
1181 GCC complains about tgetent not being declared, on a system
1182 that has tinfo installed but ncurses not installed.
1184 * eval.c (Fprogn): Check that BODY is a proper list.
1186 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1187 * data.c (Fsetq_default):
1188 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1189 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1191 Tune by taking advantage of the fact that ARGS is always a list
1192 when a function is declared to have UNEVALLED args.
1194 * emacsgtkfixed.c: Port to GCC 4.6.
1195 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1197 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
1199 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1200 here to silence compiler warnings.
1202 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1204 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1205 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1206 from messing up Emacs's 'struct frame' (Bug#14923).
1208 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1210 * alloc.c (make_save_ptr_ptr): Define this function.
1211 It was inadvertently omitted. It's needed only if
1212 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1214 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1216 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1217 frame have focus (Bug#14895).
1219 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1221 Avoid vfork-related deadlock more cleanly.
1222 * callproc.c (child_setup): When the child's exec fails, output
1223 the program name, as that's more useful. Use O_NONBLOCK to avoid
1225 * process.c (create_process_1): Remove; no longer needed.
1226 (create_process): Remove timer hack; no longer needed, now that
1227 the child avoids deadlock.
1229 2013-07-20 Glenn Morris <rgm@gnu.org>
1231 * image.c (Fimage_flush): Fix doc typo.
1233 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1235 Fix array bounds violation when pty allocation fails.
1236 * process.c (PTY_NAME_SIZE): New constant.
1237 (pty_name): Remove static variable; it's now auto.
1238 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1239 Take pty_name as an arg rather than using a static variable.
1240 All callers changed.
1241 (create_process): Recover pty_flag from process, not from volatile local.
1242 (create_pty): Stay inside array even when pty allocation fails.
1243 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1245 * lread.c (Fload): Avoid initialization only when lint checking.
1246 Mention that it's needed only for older GCCs.
1248 2013-07-20 Kenichi Handa <handa@gnu.org>
1250 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1251 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1253 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1255 * lread.c (Fload): Avoid uninitialized warning.
1257 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1259 Fix some minor file descriptor leaks and related glitches.
1260 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1261 (create_lock_file): Use write, not emacs_write.
1262 * image.c (slurp_file, png_load_body):
1263 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1264 (server_accept_connection):
1265 Don't leak an fd on memory allocation failure.
1266 * image.c (slurp_file): Add a cheap heuristic for growing files.
1267 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1268 as that's what the other routines do. Maybe input need not be
1269 blocked at all, but it's better to be consistent.
1270 Avoid undefined behavior when strlen is zero.
1272 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1273 (NSTATICS): Now a constant; doesn't need to be a macro.
1275 2013-07-19 Richard Stallman <rms@gnu.org>
1277 * coding.c (decode_coding_utf_8): Add simple loop for fast
1278 processing of ASCII characters.
1280 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1282 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1284 2013-07-19 Eli Zaretskii <eliz@gnu.org>
1286 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1287 unportable 'struct x_display_info'.
1288 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1291 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1293 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1294 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1296 (system_process_attributes): Prefer plain char to unsigned char
1297 when either will do. Clean up properly if interrupted or if
1298 memory allocations fail. Don't assume sscanf succeeds. Remove
1299 no-longer-needed workaround to stop GCC from whining. Read
1300 command-line once, instead of multiple times. Check read status a
1303 Fix obscure porting bug with varargs functions.
1304 The code assumed that int is treated like ptrdiff_t in a vararg
1305 function, which is not a portable assumption. There was a similar
1306 -- though these days less likely -- porting problem with various
1307 assumptions that pointers of different types all smell the same as
1308 far as vararg functions is conserved. To make this problem less
1309 likely in the future, redo the API to use varargs functions.
1310 * alloc.c (make_save_value): Remove this vararg function.
1311 All uses changed to ...
1312 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1313 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1315 (make_save_ptr): Rename from make_save_pointer, for consistency with
1316 the above. Define only on platforms that need it. All uses changed.
1318 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1320 * keyboard.c: Try to fix typos in previous change.
1321 (DISPLAY_LIST_INFO): New macro.
1322 (kbd_buffer_get_event): Do not access members that are not present
1323 in X11. Revert inadvertent change of "!=" to "=".
1325 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1327 * keyboard.c (kbd_buffer_get_event):
1328 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1329 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1331 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1333 * filelock.c: Fix unlikely file descriptor leaks.
1334 (get_boot_time_1): Rework to avoid using emacs_open.
1335 This doesn't actually fix a leak, but is better anyway.
1336 (read_lock_data): Use read, not emacs_read.
1338 * doc.c: Fix minor memory and file descriptor leaks.
1339 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1340 (get_doc_string, Fsnarf_documentation):
1341 Fix file descriptor leak on error.
1343 * term.c: Fix minor fdopen-related file descriptor leaks.
1344 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1345 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1347 * charset.c: Fix file descriptor leaks and errno issues.
1349 (load_charset_map_from_file): Don't leak file descriptor on error.
1350 Use plain record_xmalloc since the allocation is larger than
1351 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1353 * eval.c (record_unwind_protect_nothing):
1354 * fileio.c (fclose_unwind):
1356 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1357 The replacement doesn't block input, but that no longer seems
1360 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1362 * lread.c: Fix file descriptor leaks and errno issues.
1363 (Fload): Close some races that leaked fds or streams when 'load'
1365 (Fload, openp): Report error number of last nontrivial failure to open.
1366 ENOENT counts as trivial.
1367 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1369 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1370 now that the function is always called with a nonnegative arg.
1371 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1372 All uses replaced with ...
1373 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1375 A few more minor file errno-reporting bugs.
1376 * callproc.c (Fcall_process):
1377 * doc.c (Fsnarf_documentation):
1378 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1379 * process.c (set_socket_option):
1380 Don't let a constructor trash errno.
1381 * doc.c: Include <errno.h>.
1383 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1385 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1387 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1389 Fix w32 bug with call-process-region (Bug#14885).
1390 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1391 to Fcall_process when the input is empty. This simplifies the
1392 code a bit. It makes no difference on POSIXish platforms but
1393 apparently it fixes a bug on w32.
1395 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1396 * fileio.c (close_file_unwind): Don't close if FD is negative;
1397 this can happen when unwinding a zapped file descriptor.
1398 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1399 in case Emacs runs out of memory between the two unwind-protects.
1400 Don't trash errno when closing FD.
1401 Zap the FD in the specpdl when closing it, instead of deferring
1402 the removal of the unwind-protect; this fixes a bug where a child
1403 function unwinds the stack past us.
1405 New unwind-protect flavors to better type-check C callbacks.
1406 This also lessens the need to write wrappers for callbacks,
1407 and the need for make_save_pointer.
1408 * alloca.c (free_save_value):
1409 * atimer.c (run_all_atimers):
1411 * alloc.c (safe_alloca_unwind):
1412 * atimer.c (unwind_stop_other_atimers):
1413 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1414 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1415 * minibuf.c (choose_minibuf_frame_1):
1416 * process.c (make_serial_process_unwind):
1417 * xdisp.h (pop_message_unwind):
1418 * xselect.c (queue_selection_requests_unwind):
1419 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1420 * alloca.c (record_xmalloc):
1421 Prefer record_unwind_protect_ptr to record_unwind_protect with
1423 * alloca.c (Fgarbage_collect):
1424 Prefer record_unwind_protect_void to passing a dummy.
1425 * buffer.c (restore_buffer):
1426 * window.c (restore_window_configuration):
1427 * xfns.c, w32fns.c (do_unwind_create_frame)
1428 New wrapper. All record-unwind uses of wrappee changed.
1429 * buffer.c (set_buffer_if_live):
1430 * callproc.c (call_process_cleanup, delete_temp_file):
1431 * coding.c (code_conversion_restore):
1432 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1433 * editfns.c (save_excursion_restore)
1434 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1435 (save_restriction_restore):
1436 * eval.c (restore_stack_limits, un_autoload):
1437 * fns.c (require_unwind):
1438 * keyboard.c (recursive_edit_unwind, tracking_off):
1439 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1440 * macros.c (pop_kbd_macro, restore_menu_items):
1441 * nsfns.m (unwind_create_frame):
1442 * print.c (print_unwind):
1443 * process.c (start_process_unwind):
1444 * search.c (unwind_set_match_data):
1445 * window.c (select_window_norecord, select_frame_norecord):
1446 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1447 (fast_set_selected_frame):
1448 * xfns.c, w32fns.c (unwind_create_tip_frame):
1449 Return void, not a dummy Lisp_Object. All uses changed.
1450 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1451 * callproc.c (call_process_kill):
1452 * fileio.c (restore_point_unwind, decide_coding_unwind)
1453 (build_annotations_unwind):
1454 * insdel.c (Fcombine_after_change_execute_1):
1455 * keyboard.c (read_char_help_form_unwind):
1456 * menu.c (unuse_menu_items):
1457 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1458 * sound.c (sound_cleanup):
1459 * xdisp.c (unwind_redisplay):
1460 * xfns.c (clean_up_dialog):
1461 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1462 Accept no args and return void, instead of accepting and returning
1463 a dummy Lisp_Object. All uses changed.
1464 * cygw32.c (fchdir_unwind):
1465 * fileio.c (close_file_unwind):
1466 * keyboard.c (restore_kboard_configuration):
1467 * lread.c (readevalllop_1):
1468 * process.c (wait_reading_process_output_unwind):
1469 Accept int and return void, rather than accepting an Emacs integer
1470 and returning a dummy object. In some cases this fixes an
1471 unlikely bug when the corresponding int is outside Emacs integer
1472 range. All uses changed.
1473 * dired.c (directory_files_internal_unwind):
1474 * fileio.c (do_auto_save_unwind):
1475 * gtkutil.c (pop_down_dialog):
1476 * insdel.c (reset_var_on_error):
1477 * lread.c (load_unwind):
1478 * xfns.c (clean_up_file_dialog):
1479 * xmenu.c, nsmenu.m (pop_down_menu):
1480 * xmenu.c (cleanup_widget_value_tree):
1481 * xselect.c (wait_for_property_change_unwind):
1482 Accept pointer and return void, rather than accepting an Emacs
1483 save value encapsulating the pointer and returning a dummy object.
1485 * editfns.c (Fformat): Update the saved pointer directly via
1486 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1487 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1488 (unwind_body): New function.
1489 (record_unwind_protect): First arg is now a function returning void,
1490 not a dummy Lisp_Object.
1491 (record_unwind_protect_ptr, record_unwind_protect_int)
1492 (record_unwind_protect_void): New functions.
1493 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1494 * fileio.c (struct auto_save_unwind): New type.
1495 (do_auto_save_unwind): Use it.
1496 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1497 * insdel.c (struct rvoe_arg): New type.
1498 (reset_var_on_error): Use it.
1499 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1501 (specbinding_func): Remove; there are now several such functions.
1502 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1503 (set_unwind_protect_ptr): New function.
1504 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1506 Be simpler and more consistent about reporting I/O errors.
1507 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1508 Say "Read error" and "Write error", rather than "I/O error", or
1509 "IO error reading", or "IO error writing", when a read or write
1511 * process.c (Fmake_network_process, wait_reading_process_output)
1512 (send_process, Fprocess_send_eof, wait_reading_process_output):
1513 Capitalize diagnostics consistently. Put "failed foo" at the
1514 start of the diagnostic, so that we don't capitalize the
1515 function name "foo". Consistently say "failed" for such
1517 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1518 All callers changed. This is so it can use report_file_error.
1519 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1520 diagnostics consistently as above.
1522 * fileio.c (report_file_errno): Fix errno reporting bug.
1523 If the file name is neither null nor a pair, package it up as a
1524 singleton list. All callers changed, both to this function and to
1525 report_file_error. This fixes a bug where the memory allocator
1526 invoked by list1 set errno so that the immediately following
1527 report_file_error reported the wrong errno value.
1529 Fix minor problems found by --enable-gcc-warnings.
1530 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1531 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1533 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1535 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1536 Set event->arg to Qt if switch-event shall be generated.
1537 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1539 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1541 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1544 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1545 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1546 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1547 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1548 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1549 and there is a focused frame.
1550 (head_table): Add focus-in and focus-out.
1551 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1552 bind to handle-focus-in/out.
1554 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1555 (Fhandle_switch_frame): Call Fhandle_focus_in.
1556 (syms_of_frame): defsubr handle-focus-in/out.
1558 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1560 Fix porting bug to older POSIXish platforms (Bug#14862).
1561 * sysdep.c (emacs_pipe): New function, that implements
1562 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1563 This should port better to CentOS 5 and to Mac OS X 10.6.
1564 All calls to pipe2 changed.
1566 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1567 This makes the code easier to read and the executable a bit smaller.
1568 Do not replace all calls to Fcons that happen to create lists,
1569 just calls that are intended to create lists. For example, when
1570 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1571 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1572 Similarly for list2 through list5.
1573 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1574 * bytecode.c (exec_byte_code):
1575 * callint.c (quotify_arg, Fcall_interactively):
1576 * callproc.c (Fcall_process, create_temp_file):
1577 * charset.c (load_charset_map_from_file)
1578 (Fdefine_charset_internal, init_charset):
1579 * coding.c (get_translation_table, detect_coding_system)
1580 (Fcheck_coding_systems_region)
1581 (Fset_terminal_coding_system_internal)
1582 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1583 * composite.c (update_compositions, Ffind_composition_internal):
1584 * dired.c (directory_files_internal, file_name_completion)
1586 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1587 * doc.c (Fsnarf_documentation):
1588 * editfns.c (Fmessage_box):
1590 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1591 (Feval, eval_sub, Ffuncall, apply_lambda):
1592 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1593 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1594 (Fset_file_times, Finsert_file_contents)
1595 (Fchoose_write_coding_system, Fwrite_region):
1596 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1597 * font.c (font_registry_charsets, font_parse_fcname)
1598 (font_prepare_cache, font_update_drivers, Flist_fonts):
1599 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1600 * frame.c (make_frame, Fmake_terminal_frame)
1601 (x_set_frame_parameters, x_report_frame_params)
1602 (x_default_parameter, Fx_parse_geometry):
1603 * ftfont.c (syms_of_ftfont):
1604 * image.c (gif_load):
1605 * keyboard.c (command_loop_1):
1606 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1607 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1608 (Fminor_mode_key_binding, accessible_keymaps_1)
1609 (Faccessible_keymaps, Fwhere_is_internal):
1610 * lread.c (read_emacs_mule_char):
1611 * menu.c (find_and_return_menu_selection):
1612 * minibuf.c (get_minibuffer):
1613 * nsfns.m (Fns_perform_service):
1614 * nsfont.m (ns_script_to_charset):
1615 * nsmenu.m (ns_popup_dialog):
1616 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1617 (Fx_own_selection_internal):
1618 * nsterm.m (append2):
1619 * print.c (Fredirect_debugging_output)
1620 (print_prune_string_charset):
1621 * process.c (Fdelete_process, Fprocess_contact)
1622 (Fformat_network_address, set_socket_option)
1623 (read_and_dispose_of_process_output, write_queue_push)
1624 (send_process, exec_sentinel):
1625 * sound.c (Fplay_sound_internal):
1626 * textprop.c (validate_plist, add_properties)
1627 (Fput_text_property, Fadd_face_text_property)
1628 (copy_text_properties, text_property_list, syms_of_textprop):
1629 * unexaix.c (report_error):
1630 * unexcoff.c (report_error):
1631 * unexsol.c (unexec):
1632 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1633 (Fformat_mode_line, syms_of_xdisp):
1634 * xfaces.c (set_font_frame_param)
1635 (Finternal_lisp_face_attribute_values)
1636 (Finternal_merge_in_global_face, syms_of_xfaces):
1637 * xfns.c (x_default_scroll_bar_color_parameter)
1638 (x_default_font_parameter, x_create_tip_frame):
1639 * xfont.c (xfont_supported_scripts):
1640 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1641 (menu_help_callback, xmenu_show):
1643 * xterm.c (set_wm_state):
1644 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1645 and similarly for list2 through list5.
1647 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1649 * callproc.c (Fcall_process_region): Fix minor race and tune.
1650 (create_temp_file): New function, with the temp-file-creation part
1651 of the old Fcall_process_region. Use Fcopy_sequence to create the
1652 temp file name, rather than alloca + build_string, for simplicity.
1653 Don't bother to block input around the temp file creation;
1654 shouldn't be needed. Simplify use of mktemp. Use
1655 record_unwind_protect immediately after creating the temp file;
1656 this closes an unlikely race where the temp file was not removed.
1657 Use memcpy rather than an open-coded loop.
1658 (Fcall_process_region): Use the new function. If the input is
1659 empty, redirect from /dev/null rather than from a newly created
1660 empty temp file; this avoids unnecessary file system traffic.
1662 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1664 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1665 Simplify by making this case like the other two. This is a bit
1666 slower on obsolete hosts, but the extra complexity isn't worth it.
1668 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1669 * process.c (create_process) [!DOS_NT]:
1670 Remove now-unnecessary calls to emacs_close.
1672 2013-07-13 Eli Zaretskii <eliz@gnu.org>
1674 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1675 returning early. (Bug#14850)
1677 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1678 and inhibit-iso-escape-detection attributes of 'undecided'.
1681 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1683 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1684 Reported by Herbert J. Skuhra in
1685 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1687 Don't lose top specpdl entry when memory is exhausted.
1688 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1689 specpdl overflow here, to simplify callers; all callers changed.
1690 Always reserve an unused entry at the stack top; this avoids
1691 losing the top entry's information when memory is exhausted.
1693 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1695 Clean up errno reporting and fix some errno-reporting bugs.
1696 * callproc.c (Fcall_process):
1697 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1698 * process.c (create_process, Fmake_network_process):
1699 * unexaix.c (report_error):
1700 * unexcoff.c (report_error):
1701 Be more careful about reporting the errno of failed operations.
1702 The code previously reported the wrong errno sometimes.
1703 Also, prefer report_file_errno to setting errno + report_file_error.
1704 (Fcall_process): Look at openp return value rather than at path,
1705 as that's a bit faster and clearer when there's a numeric predicate.
1706 * fileio.c (report_file_errno): New function, with most of the
1707 old contents of report_file_error.
1708 (report_file_error): Use it.
1709 (Ffile_exists_p, Ffile_accessible_directory_p):
1710 Set errno to 0 when it is junk.
1711 * fileio.c (Faccess_file):
1712 * image.c (x_create_bitmap_from_file):
1713 Use faccessat rather than opening the file, to avoid the hassle of
1714 having a file descriptor open.
1715 * lisp.h (report_file_errno): New decl.
1716 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1719 * process.c (create_process, wait_reading_process_output) [AIX]:
1720 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1721 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1722 a multithreaded environment anyway).
1723 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1725 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1727 * image.c (x_find_image_file): Don't close a remote file handle.
1729 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1731 Fix races with threads and file descriptors.
1732 * callproc.c (Fcall_process_region):
1733 * dired.c (open_directory):
1734 * emacs.c (main, Fdaemon_initialized):
1735 * image.c (x_find_image_file):
1736 * inotify.c (Finotify_rm_watch):
1737 * lread.c (Flocate_file_internal):
1738 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1739 * term.c (term_mouse_moveto, init_tty):
1740 * termcap.c (tgetent):
1741 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1742 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1743 * unexhp9k800.c, unexmacosx.c (unexec):
1744 * callproc.c (Fcall_process_region):
1745 Use emacs_close, not close.
1746 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1747 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1748 and posix_close function on current platforms (which all lack them).
1749 (emacs_close): Use it. This should fix the races on GNU/Linux and
1750 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1751 and it should avoid closing random victim file descriptors on
1754 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1756 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1757 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1760 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1761 This is for .gdbinit xbacktrace.
1763 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1764 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1765 (emacs_set_tty): Now static.
1766 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1767 * term.c (tty_capable_p, tty_default_color_capabilities)
1768 (get_tty_terminal, term_mouse_movement)
1769 (handle_one_term_event, init_tty, maybe_fatal):
1770 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1771 (tgetent, scan_file, name_match, compare_contin):
1772 * terminal.c (get_terminal):
1773 Use bool for boolean.
1774 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1775 Prefer char to unsigned char if either will do.
1776 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1777 (tty_write_glyphs): Prefer int to unsigned.
1778 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1779 All callers changed.
1780 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1782 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1785 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1786 (B__dummy__): New dummy symbol, to pacify C89.
1787 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1788 they can't grok varargs macros.
1789 * dispnew.c (add_window_display_history)
1790 (add_frame_display_history):
1791 * print.c (print_object):
1792 * xdisp.c (debug_method_add):
1793 Use %p printf format only for void pointers.
1794 * emacs.c (usage_message): New constant, replacing ...
1795 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1796 (main): Adjust to usage reorg.
1797 * fns.c (syms_of_fns):
1798 * profiler.c (syms_of_profiler):
1799 Don't use non-constant struct initializers.
1800 * gnutls.h (gnutls_initstage_t):
1801 * lisp.h (enum Lisp_Fwd_Type):
1802 * lread.c (lisp_file_lexically_bound_p):
1803 * xsettings.c (anonymous enum):
1804 Remove trailing comma.
1805 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1806 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1807 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1809 * regex.c (const_re_char): New type, to pacify strict C89.
1810 All uses of 'const re_char' replaced to use it.
1811 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1812 with glibc when strict C89. This change is imported from gnulib.
1814 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1815 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1816 Omit GNU_LINUX implementation, since it requires long long.
1817 * xterm.c (x_draw_underwave):
1818 Do not assume the traditional order of struct's members.
1819 (x_term_init): Rewrite to avoid the need for non-constant structure
1822 Syntax cleanup, mostly replacing macros with functions.
1823 This removes the need for the syntax_temp hack.
1824 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1825 * syntax.c (SYNTAX_INLINE): New macro.
1826 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1827 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1828 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1829 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1830 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1831 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1832 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1833 Now constants, not macros.
1834 (syntax_temp) [!__GNUC__]: Remove.
1835 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1836 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1837 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1838 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1839 Move here from syntax.h; now functions, not macros. Except for the
1840 last function, these are static since only syntax.c uses them.
1841 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1842 All uses changed. Now a function, not a macro; use this fact
1843 to simplify the code.
1844 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1845 compiler bugs; no longer relevant.
1846 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1847 (SYNTAX_INLINE): New macro.
1848 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1849 for the new functions. Use bool for boolean member.
1850 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1851 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1852 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1853 (SETUP_BUFFER_SYNTAX_TABLE):
1854 Now extern inline functions, not macros.
1855 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1856 Remove; all uses replaced by implementation.
1857 (syntax_temp) [!__GNUC__]: Remove decl.
1858 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1860 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1862 * emacs.c (main): Fix syntax error.
1864 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1866 Timestamp fixes for undo (Bug#14824).
1867 * atimer.c (schedule_atimer):
1868 * fileio.c (Ffile_newer_than_file_p):
1869 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1870 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1871 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1872 (syms_of_fileio): Remove Sclear_visited_file_name.
1873 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1874 file doesn't exist; this avoids an ambiguity with negative timestamps.
1875 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1876 * systime.h (make_emacs_time, invalid_emacs_time):
1877 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1878 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1879 * undo.c (record_first_change): Push (visited-file-modtime) onto
1880 undo list rather than reimplementing it by hand, incorrectly.
1882 2013-07-09 Ken Brown <kbrown@cornell.edu>
1884 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1886 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
1888 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1890 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1892 Handle errno and exit status a bit more carefully.
1893 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1894 number into an exit status. Instead, use EXIT_CANCELED.
1895 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1896 * callproc.c (relocate_fd):
1897 * emacs.c (close_output_streams, main):
1898 * process.c (create_process):
1899 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1900 Use emacs_perror for simplicity.
1901 * callproc.c (relocate_fd, main):
1902 * sysdep.c (sys_subshell):
1903 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1904 (shut_down_emacs): Use emacs_write, not write.
1905 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1906 * fileio.c (Fcopy_file, e_write):
1907 * nsterm.m (ns_select):
1908 * process.c (send_process):
1909 * sound.c (vox_write):
1910 Use emacs_write_sig, not emacs_write.
1911 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1912 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1914 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1916 (emacs_full_write): New function.
1917 (emacs_write): Rewrite to use it.
1918 (emacswrite_sig, emacs_perror): New functions.
1919 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1921 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
1923 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1924 on NS even if it is present. Pixmap on NS is a void*.
1926 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1928 Port to Ubuntu 10 (Bug#14803).
1929 Problem reported by T.V. Raman.
1930 * process.c (close_on_exec, accept4, process_socket):
1931 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1933 2013-07-07 Eli Zaretskii <eliz@gnu.org>
1935 * w32.c (sys_dup): Declare prototype.
1939 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1941 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1943 Make file descriptors close-on-exec when possible (Bug#14803).
1944 This simplifies Emacs a bit, since it no longer needs to worry
1945 about closing file descriptors by hand in some cases.
1946 It also fixes some unlikely races. Not all such races, as
1947 libraries often open files internally without setting
1948 close-on-exec, but it's an improvement.
1949 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1950 * callproc.c (Fcall_process) [!MSDOS]:
1951 * emacs.c (main) [!DOS_NT]:
1952 * nsterm.m (ns_term_init):
1953 * process.c (create_process):
1954 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1955 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1956 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1957 Prefer mkostemp with O_CLOEXEC to mkstemp.
1958 * callproc.c (relocate_fd) [!WINDOWSNT]:
1959 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1960 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1962 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1963 Make the resulting file descriptor close-on-exec.
1964 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1965 * lread.c (load_descriptor_list, load_descriptor_unwind):
1966 Remove; no longer needed. All uses removed.
1967 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1968 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1970 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1971 (Fmake_network_process, Fnetwork_interface_list):
1972 (Fnetwork_interface_info, server_accept_connection):
1973 Make newly-created socket close-on-exec.
1974 * sysdep.c (emacs_open, emacs_fopen):
1975 Make new-created descriptor close-on-exec.
1976 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1977 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1979 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1981 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1982 for NS_IMPL_GNUSTEP.
1984 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1986 Fix openp errno handling.
1987 * callproc.c (Fcall_process): Preserve openp errno around close.
1988 * lread.c (openp): Set errno when returning -1, as some callers
1991 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1993 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1995 * nsterm.h (NSSavePanel): Update comment.
1996 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1997 (ns_run_file_dialog): Declare.
1999 * nsfns.m: Remove panelOK.
2001 (ns_run_file_dialog): New function.
2002 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2003 event loop, so file dialog is popped up by ns_run_file_dialog, called
2004 by sendEvent (Bug#14578).
2005 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2007 2013-07-06 Eli Zaretskii <eliz@gnu.org>
2009 * xdisp.c (default_line_pixel_height): New function.
2010 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2011 (try_cursor_movement, redisplay_window, try_window)
2012 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2014 * window.c (window_scroll_pixel_based): use
2015 default_line_pixel_height.
2017 * dispextern.h (default_line_pixel_height): Add prototype.
2019 * frame.c (x_set_line_spacing): Accept a float value for
2020 line-spacing parameter, per the documentation.
2022 * data.c (Fmultibyte_string_p): Doc fix.
2024 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2026 Use emacs_open more consistently when opening files.
2027 This handles EINTR more consistently now, and makes it easier
2028 to introduce other uniform changes to file descriptor handling.
2029 * src/systdio.h: New file.
2030 * src/buffer.c (mmap_init):
2031 * cygw32.c (chdir_to_default_directory):
2032 * dispnew.c (Fopen_termscript):
2033 * emacs.c (Fdaemon_initialized):
2034 * fileio.c (Fdo_auto_save):
2035 * image.c (slurp_file, png_load_body, jpeg_load_body):
2036 * keyboard.c (Fopen_dribble_file):
2038 * print.c (Fredirect_debugging_output):
2039 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2040 * termcap.c (tgetent):
2041 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2042 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2043 * w32term.c (w32_initialize) [CYGWIN]:
2044 * xfaces.c (Fx_load_color_file):
2045 Use emacs_open instead of plain open, and emacs_fopen instead of
2047 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2048 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2049 * callproc.c (default_output_mode): New constant.
2050 (Fcall_process): Use it to call emacs_open instead of plain creat.
2051 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2052 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2053 (emacs_fopen): New function.
2054 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2055 Include <lisp.h>, for emacs_open.
2056 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2058 Remove duplicate #include directives.
2059 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2061 Don't include stdio.h twice.
2062 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2063 Don't include sys/types.h or stdio.h twice.
2064 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2065 * lread.c: Don't include coding.h twice.
2066 * nsfont.m: Don't include frame.h twice.
2067 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2068 * ralloc.c: Don't include <unistd.h> twice.
2069 * xdisp.c: Don't include font.h twice.
2070 * xterm.c: Don't include fontset.h twice.
2071 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2073 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2075 Scale ImageMagick images more carefully.
2076 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2077 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2078 Be more careful about avoiding undefined behavior after
2079 integer overflow and division by zero.
2081 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2083 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2084 (syms_of_w32fns): DEFSYM them.
2085 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2086 (CCHDEVICENAME): Define macros if not defined.
2087 (struct MONITOR_INFO_EX): New struct.
2088 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2089 (enum_display_monitors_fn): New variable.
2090 (globals_of_w32fns): Initialize it.
2091 (Fx_display_pixel_width, Fx_display_pixel_height)
2092 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2093 multi-monitor setups in docstrings.
2094 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2095 screen size by primary monitor's millimeter per pixel.
2096 (w32_monitor_enum, w32_display_monitor_attributes_list)
2097 (w32_display_monitor_attributes_list_fallback)
2098 (Fw32_display_monitor_attributes_list): New functions.
2099 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2101 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2103 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2105 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
2107 * fileio.c (Qfile_notify_error): New error symbol.
2109 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2110 * inotify.c (inotify_callback, symbol_to_inotifymask)
2111 (Finotify_add_watch, Finotify_rm_watch): Use it.
2112 (inotifyevent_to_event): Exchange order of cookie and file name.
2113 (Finotify_add_watch): Adapt docstring.
2115 * lisp.h (Qfile_notify_error): Declare.
2117 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2119 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2120 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2121 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2122 which did not work (see <http://bugs.gnu.org/14569#307>).
2123 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2124 && (!noninteractive || initialized)). This attempts to thread
2125 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2127 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
2129 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2130 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2132 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2134 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2135 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2136 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2137 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2139 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2141 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2142 Define to __sys_siglist.
2144 2013-07-02 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2147 word-wrap, so that overflow-newline-into-fringe would work in
2148 visual-line-mode. (Bug#2749)
2149 (move_it_in_display_line_to): When the last scanned display
2150 element fits exactly on the display line, and
2151 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2152 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2153 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2154 finding buffer position that corresponds to pixel coordinates,
2155 e.g. in buffer_posn_from_coords.
2157 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2159 * process.c (handle_child_signal): Call catch_child_signal if
2162 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2164 Don't convert function pointers to void * and back.
2165 It isn't portable C, and it's easy enough to avoid.
2166 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2167 (make_save_value): Add support for SAVE_FUNCPOINTER.
2168 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2169 * print.c (print_object):
2170 Distinguish function from object pointers.
2171 * lisp.h (SAVE_FUNCPOINTER): New constant.
2172 (SAVE_SLOT_BITS): Adjust to it.
2173 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2174 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2175 (voidfuncptr): New typedef.
2176 (struct Lisp_Save_Value): New member data[0].funcpointer.
2177 (XSAVE_FUNCPOINTER): New function.
2179 Simplify buildobj processing.
2180 * Makefile.in (buildobj.h): Make it a sequence of strings each
2181 followed by comma, rather than a single string. Put it into a
2182 .tmp file in case there's an error while generating it.
2183 (gl-stamp): Use .tmp for temp files.
2184 (mostlyclean): Clean .tmp files.
2185 * doc.c (buildobj): Move to just the routine that needs it.
2186 It's now an array of strings, so processing is simpler.
2188 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2190 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2191 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2192 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2193 Invoke malloc_enable_thread even when not interactive.
2194 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2195 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2196 in this case, since the underlying bug has now been fixed.
2198 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
2200 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2201 unlinking it (bug#14691).
2203 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
2205 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2206 before checking whether buffer is modified. This lets
2207 `kill-buffer-query-functions' cancel killing of the buffer or save
2208 its content before `kill-buffer' asks user the "Buffer %s
2209 modified; kill anyway?" question.
2211 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2213 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2214 Let the super performKeyEquivalent deal with them (Bug#14747).
2216 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2218 * widget.c (resize_cb): Remove unused local.
2220 Do not use GTK 3 if it exists but cannot be compiled.
2221 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2222 * xterm.c (x_error_handler) [!USE_GTK]:
2225 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2227 2013-06-30 Eli Zaretskii <eliz@gnu.org>
2229 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2230 to the valid range of values. (Bug#14753)
2232 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2233 when moving point by using the current glyph matrix. This avoids
2234 the need to force redisplay when this function is called in a
2237 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2239 Fix minor problems found by static checking.
2240 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2241 Redo the latter's body to sidestep GCC parenthesization warnings.
2242 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2243 * coding.c (detect_coding, detect_coding_system):
2244 * coding.h (struct undecided_spec):
2245 Use bool for boolean.
2246 * image.c (QCmax_width, QCmax_height): Now static.
2247 * xdisp.c (Fmove_point_visually): Remove unused local.
2249 2013-06-29 Eli Zaretskii <eliz@gnu.org>
2251 * xdisp.c (Fmove_point_visually): New function.
2253 2013-06-28 Kenichi Handa <handa@gnu.org>
2255 * coding.h (define_coding_undecided_arg_index): New enum.
2256 (coding_attr_index): New members
2257 coding_attr_undecided_inhibit_null_byte_detection,
2258 coding_attr_undecided_inhibit_iso_escape_detection,
2259 coding_attr_undecided_prefer_utf_8.
2260 (undecided_spec): New struct.
2261 (struct coding_system): New member `undecided' of the member
2264 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2265 (detect_coding): Likewise.
2266 (detect_coding_system): Likewise.
2267 (Fdefine_coding_system_internal): New coding system properties
2268 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2270 (syms_of_coding): Adjust for coding_arg_undecided_max.
2272 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2274 * image.c (x_from_xcolors): Remove unused local.
2276 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2278 Defer image data transfer between X client and server until actual
2281 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2284 * image.c (Destroy_Image): Remove.
2285 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2286 `mask_p', and `colors_p'. All uses changed.
2287 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
2288 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2289 New macros for `flags' arg to x_clear_image_1.
2290 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2291 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2292 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2293 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2294 (image_get_x_image, image_unget_x_image): New functions or macros.
2295 (image_background, image_background_transparent, x_to_xcolors)
2296 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2297 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2298 instead of Destroy_Image.
2299 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2300 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2301 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2302 (imagemagick_load_image, svg_load_image): Use them instead of
2303 x_create_x_image_and_pixmap, and x_put_x_image followed by
2304 x_destroy_x_image, respectively.
2305 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2306 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2307 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2308 background_transparent fields.
2309 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2310 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2312 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2314 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2315 This mostly consists of undoing recent changes.
2316 * callproc.c (Fcall_process):
2317 * process.c (create_process):
2318 Do not worry about catching SIGCHLD here, undoing previous change.
2319 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2320 * process.c, process.h (catch_child_signal):
2321 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2322 * process.c (catch_child_handler): Don't worry about being called
2323 lazily and do not assume caller has blocked SIGCHLD, undoing
2324 previous change. Move first-time stuff back to
2325 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2326 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2327 set lib_child_handler if it's already initialized, which may
2328 help avoid problems on GNUStep.
2330 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2332 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2333 * callproc.c (Fcall_process):
2334 * process.c (create_process):
2335 Make sure SIGCHLD is caught before we fork,
2336 since Emacs startup no arranges to catch SIGCHLD.
2337 * process.c (lib_child_handler): Initialize to null, not to
2339 (catch_child_signal): Allow self to be called lazily.
2340 Do nothing if it's already been called.
2341 Assume caller has blocked SIGCHLD (all callers do now).
2342 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2343 just before it's really needed.
2344 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2345 since it hasn't been caught yet.
2347 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2349 * image.c (compute_image_size): New function to implement
2350 :max-width and :max-height.
2351 (imagemagick_load_image): Use it.
2353 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2355 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2356 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2358 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2359 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2360 the SIGCHLD handler, since the code is not atomic and (due to glib)
2361 signals may be arriving now.
2362 * sysdep.c (init_signals): Do not catch child signals here;
2363 'main' now does that later, at a safer time.
2365 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2367 Clean up SIGCHLD handling a bit (Bug#14569).
2368 * process.c, process.h (catch_child_signal):
2369 Now always extern, even if !NS_IMPL_GNUSTEP.
2370 * process.c (catch_child_signal): Move glib tickler here from
2371 init_process_emacs, so that it's done earlier in Emacs
2372 initialization. Also move the noninteractive && !initialized
2373 check here from init_process_emacs. This is all a bit cleaner for
2374 GNUish platforms, and I hope it works around the Cygwin bug.
2375 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2376 that glib signal handling is tickled before glib creates threads.
2378 * process.c (wait_reading_process_output): Avoid int overflow
2379 when reading more than 2 GiB total from a process.
2381 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2383 * process.c (create_process): Handle a couple more cases,
2384 i.e., work even if new_argv and wait_child_setup[i] are cached.
2385 Use Fcall_process's style for volatile vars.
2387 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2389 * process.c (create_process): Mark PROCESS volatile.
2391 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2393 Use C99-style flexible array members if available.
2394 This avoids some subtle aliasing issues, which typically
2395 aren't a problem with GCC but may be a problem elsewhere.
2396 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2397 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2398 In either case, it uses a flexible array member rather than
2399 the old struct hack. All uses changed.
2400 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2401 Adjust to sdata reorganization.
2402 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2403 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2404 that ports better to pre-C99 non-GCC.
2405 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2406 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2407 as the latter has changed.
2408 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2409 and port better to pre-C99 GCC.
2410 * image.c (struct xpm_cached_color):
2411 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2412 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2413 Use FLEXIBLE_ARRAY_MEMBER.
2414 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2415 Move decl to top level so it gets checked against implementation.
2416 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2417 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2419 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2421 * syntax.c: Integer cleanups.
2422 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2423 All uses that need 0-or-2 changed to:
2424 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2425 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2426 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2427 (char_quoted, prev_char_comend_first, back_comment)
2428 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2429 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2430 Use bool for boolean.
2431 (update_syntax_table, skip_chars, skip_syntaxes):
2432 Prefer int to unsigned when either will do.
2433 (back_comment): Return boolean success flag, like forw_comment,
2434 instead of positive-or-minus-1 (which might have overflowed int anyway).
2435 Don't stuff ptrdiff_t into int.
2436 (syntax_spec_code, syntax_code_spec): Now const.
2437 (Fmatching_paren, scan_lists, scan_sexps_forward):
2438 Use enum syntaxcode for syntax code.
2439 (Fmatching_paren): Check that arg is a character, not just an integer.
2440 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2441 (Finternal_describe_syntax_value): Omit no-longer-needed
2443 (skip_chars): Use char, not unsigned char, when the distinction
2445 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2446 * bytecode.c (exec_byte_code):
2447 * syntax.c (syntax_spec_code, Fchar_syntax)
2448 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2450 * syntax.h (SYNTAX_WITH_FLAGS):
2451 Omit unnecessary casts.
2453 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2455 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2456 line dimensions here, to avoid race conditions with the main
2457 thread. (Bug#14062, bug#14630, bug#14669)
2459 * w32term.c (w32_draw_window_cursor): Compute the header line and
2460 mode line dimensions here.
2461 <w32_system_caret_window, w32_system_caret_hdr_height>:
2462 <w32_system_caret_mode_height>: New variables.
2464 * w32term.h: Declare them.
2466 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2468 * alloc.c (die): Move "assertion failed" string here ...
2469 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2470 COND when SUPPRESS_CHECKING. This shrinks the executable text
2471 size by 0.8% to 2.2% when configured with --enable-checking,
2472 depending on optimization flags (GCC 4.8.1 x86-64).
2474 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2476 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2478 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2479 base is 2; this is more accurate.
2481 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2483 * sound.c (string_default): Move to !WINDOWSNT section.
2484 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2486 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2488 * sound.c: Integer cleanups.
2489 Remove unnecessary forward decls.
2490 (struct sound_device): The 'file' member is now a Lisp_Object, not
2491 a char *, so that we needn't invoke alloca on a huge size.
2492 (Fplay_sound_internal): Adjust to this.
2493 (string_default): New function.
2494 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2495 Use it to adjust to the struct sound_device change.
2496 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2497 (be2hs) [0]: Remove.
2499 * syntax.c (skip_chars): Don't use uninitialized storage
2500 when searching a multibyte buffer for characters that are not in a
2501 unibyte string that contains non-ASCII characters.
2503 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2505 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2506 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2508 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2510 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2512 2013-06-18 Kenichi Handa <handa@gnu.org>
2514 * font.c (Ffont_spec): Signal an error for an invalid font name
2517 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2519 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2520 In particular this ports to 32-bit sparc Sun cc.
2521 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2522 array with a dummy element at specpdl[-1], so that its address can
2524 (unbind_to): Do not copy the binding; not needed, now that we
2525 copy old_value in the one place where the copy is needed.
2526 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2527 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2528 (union specbinding): Rename from struct specbinding. Redo layout
2529 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2530 which is not portable. With Sun C 5.12 32-bit sparc, the
2531 declaration causes nargs to be an unsigned bitfield, a behavior
2532 that the C standard allows; but Emacs wants nargs to be signed.
2533 The overall type is now a union of structures rather than a
2534 structure of union of structures, and the 'kind' member is now a
2535 bitfield, so that the overall type doesn't grow. All uses changed.
2536 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2538 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2540 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2541 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2543 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2545 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2547 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2548 unless we know that the window w's frame is a frame object.
2549 Another attempt at solving bug#14062 and bug#14630.
2551 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2553 * textprop.c (property_set_type): New enum.
2554 (add_properties): Allow appending/prepending text properties.
2555 (add_text_properties_1): Factored out of Fadd_text_properties.
2556 (Fadd_text_properties): Move all the code into
2557 add_text_properties_1.
2558 (Fadd_face_text_property): New function that calls
2559 add_text_properties_1.
2561 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2563 Move functions from lisp.h to individual modules when possible.
2564 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2565 * alloc.c (XFLOAT_INIT, set_symbol_name):
2566 * buffer.c (CHECK_OVERLAY):
2567 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2568 (set_char_table_parent):
2569 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2570 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2571 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2572 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2574 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2575 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2576 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2577 (backtrace_args, backtrace_debug_on_exit):
2578 * floatfns.c (CHECK_FLOAT):
2579 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2580 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2581 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2582 (set_hash_index_slot):
2583 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2584 * marker.c (CHECK_MARKER):
2585 * textprop.c (CHECK_STRING_OR_BUFFER):
2586 * window.c (CHECK_WINDOW_CONFIGURATION):
2587 Move here from lisp.h, and make these functions static rather than
2589 * buffer.c (Qoverlayp):
2591 * fns.c (Qhash_table_p):
2592 * window.c (Qwindow_configuration_p):
2594 * lisp.h: Remove the abovementioned defns and decls.
2596 Use functions, not macros, for XINT etc (Bug#11935).
2597 In lisp.h, prefer functions to function-like macros, and
2598 constants to object-like macros, when either will do. This:
2599 . simplifies use, as there's no more need to worry about
2600 arguments' side effects being evaluated multiple times.
2601 . makes the code easier to debug on some platforms.
2602 However, when using gcc -O0, keep using function-like macros
2603 for a few critical operations, for performance reasons.
2604 This sort of thing isn't needed with gcc -Og, but -Og
2605 is a GCC 4.8 feature and isn't widely-enough available yet.
2606 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2607 Remove enum lsb_bits; no longer needed.
2608 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2609 * buffer.c (Qoverlap):
2611 * fns.c (Qhash_table_p):
2612 Now extern, so lisp.h can use these symbols.
2613 * dispextern.h: Include character.h, for MAX_CHAR etc.
2614 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2615 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2616 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2617 (GLYPH_CODE_P): Move here from lisp.h.
2618 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2619 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2620 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2621 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2622 XUNTAG now returns void *.
2623 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2624 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2625 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2626 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2627 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2628 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2629 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2630 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2631 New macros, renamed from their sans-lisp_h_ counterparts.
2632 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2633 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2634 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2635 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2636 If compiling via GCC without optimization, define these as macros
2637 in addition to inline functions.
2638 To disable this, compile with -DINLINING=0.
2639 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2640 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2641 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2642 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2643 (INTMASK, VALMASK): Now macros, since static values cannot be
2644 accessed from extern inline functions.
2645 (VALMASK): Also a constant, for benefit of old GDB.
2646 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2647 is INTEGERP, which can fold it in.
2648 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
2649 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2650 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2651 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2652 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2653 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2654 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2655 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2656 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2657 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2658 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2659 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2660 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2661 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2662 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2663 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2664 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2665 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2666 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2667 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2668 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2669 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2670 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2671 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2672 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2673 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2674 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2675 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2676 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2677 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2678 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2679 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2680 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2682 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2683 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2684 (VALMASK): Define in one place rather than in two, merging the
2685 USE_LSB_TAG parts; this is simpler.
2686 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2687 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2688 Move up, to avoid use before definition.
2689 Also include "globals.h" earlier, for the same reason.
2690 (make_natnum): New function.
2691 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2692 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2693 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2694 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2695 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2696 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2697 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2698 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2699 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2700 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2701 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2702 (Qwindow_configuration_p, Qimage): New forward declarations.
2703 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2704 (STRING_COPYIN): Remove; unused.
2705 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2706 (xcar_addr, xcdr_addr): New functions. All uses changed.
2707 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2708 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2709 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2710 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2711 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2712 (TYPE_RANGED_INTEGERP): Simplify.
2713 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2714 (setlocale, fixup_locale, synchronize_system_messages_locale)
2715 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2716 Now empty functions, not macros.
2717 (functionp): Return bool, not int.
2718 * window.c (Qwindow_configuration_p): Now extern,
2719 so window.h can use it.
2720 * window.h (Qwindowp): Move decl back to lisp.h.
2722 2013-06-15 Eli Zaretskii <eliz@gnu.org>
2724 * xdisp.c (Fline_pixel_height): New function, required for solving
2727 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2729 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2731 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2733 * lread.c (syms_of_lread):
2734 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2736 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2738 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2740 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2742 * fileio.c (expand_file_name): Doc fix.
2744 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2746 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2747 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2748 Wait for self, not for 0. This can't hurt on GNU or similar
2749 system, and may help with Cygwin.
2751 * keyboard.c: Don't use PROP (...) as an lvalue.
2752 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2753 Use set_prop (A, B), not PROP (A) = B.
2755 2013-06-10 Eli Zaretskii <eliz@gnu.org>
2757 * xdisp.c (get_it_property): Use it->window instead of generating
2758 a Lisp object from it->w.
2760 2013-06-09 Eli Zaretskii <eliz@gnu.org>
2762 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2763 get-char-property the window that is being rendered, instead of
2764 the buffer, to support window-specific overlays. (Bug#14575)
2765 (compute_display_string_pos): When W is NULL, use the current
2766 buffer as the object to pass to get-char-property.
2767 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2768 pointer member of the bidi iterator, since no window is pertinent
2771 2013-06-08 Eli Zaretskii <eliz@gnu.org>
2773 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2774 being displayed, and pass it to compute_display_string_pos.
2775 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2776 (bidi_paragraph_init): All callers changed.
2778 * xdisp.c (init_from_display_pos, init_iterator)
2779 (handle_single_display_spec, next_overlay_string)
2780 (get_overlay_strings_1, reseat_1, reseat_to_string)
2781 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2782 Set bidi_it.w member from it->w.
2783 (compute_display_string_pos): Accept additional argument, the
2784 window being displayed, and pass it to Fget_char_property.
2787 * dispextern.h (struct bidi_it): New member w, the window being
2789 (compute_display_string_pos): Adjust prototype.
2791 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2793 * xgselect.c: Remove unneeded include xterm.h.
2795 * process.c (wait_reading_process_output): Check for NS before GLIB.
2796 GLIB may be linked in due to rsvg, but ns_select must be called.
2798 * xgselect.c (xg_select): Remove call to window_system_available
2799 and g_main_context_pending at the top, so Gdk events (i.e. file
2800 notify) are processed when Emacs is started with -nw.
2802 2013-06-07 Eli Zaretskii <eliz@gnu.org>
2804 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2805 (ctagsfiles3): New variable, includes only *.m files.
2806 (TAGS): Use an explicit language name in the regular expressions,
2807 to avoid transformation of '/SOMETHING' by MSYS to
2808 'c:\MSYS\SOMETHING'.
2810 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2812 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2814 2013-06-06 Eli Zaretskii <eliz@gnu.org>
2816 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2817 still need to set the mouse pointer shape and activate help-echo.
2820 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2822 A few porting etc. fixes for the new file monitor code.
2823 See the thread containing
2824 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2825 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2826 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2827 (dir_monitor_callback, Fgfile_rm_watch):
2828 Use assq_no_quit instead of Fassoc, for speed.
2829 (dir_monitor_callback, Fgfile_rm_watch):
2830 eassert that the monitor is a fixnum.
2831 (dir_monitor_callback): No need for CDR_SAFE.
2832 Simplify building of lisp with alternative tails.
2833 (Fgfile_add_watch, Fgfile_rm_watch):
2834 Do not assume glib functions set errno reliably on failure.
2835 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2836 and signal an error otherwise.
2837 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2838 Use Fdelq instead of Fdelete, for speed.
2840 2013-06-05 Eli Zaretskii <eliz@gnu.org>
2842 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2843 don't insist on being invoked on a highlighted tool-bar button.
2844 Avoids losing tool-bar functionality when mouse-highlight is nil.
2845 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2846 Don't highlight when mouse-highlight is nil.
2847 (note_mouse_highlight): When mouse-highlight is nil, don't return
2848 right away; instead, run tool-bar and mode-line highlight
2849 subroutine, clear any existing highlight, and revert the mouse
2850 pointer to its default shape. (Bug#14558)
2852 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2854 * lisp.mk (lisp): Add prog-mode.el.
2856 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2858 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2859 * process.c (dummy_handler): New function.
2860 (lib_child_handler): New static var.
2861 (handle_child_signal): Invoke it.
2862 (catch_child_signal): If a library has set up a signal handler,
2863 save it into lib_child_handler.
2864 (init_process_emacs): If using glib and not on Windows, tickle glib's
2865 child-handling code so that it initializes its private SIGCHLD handler.
2866 * syssignal.h (SA_SIGINFO): Default to 0.
2867 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2868 31; it should no longer be needed now.
2870 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
2872 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2874 * gfilenotify.c (globals_of_gfilenotify): New function.
2875 (syms_of_gfilenotify): Move global initialization there.
2877 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2879 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2881 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2882 * keyboard.c (menu_bar_items, tool_bar_items):
2883 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2884 not override local keymaps any more.
2886 2013-06-04 Eli Zaretskii <eliz@gnu.org>
2888 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2890 2013-06-03 Eli Zaretskii <eliz@gnu.org>
2892 * w32console.c (initialize_w32_display): Return the dimensions of
2893 the console window via 2 additional arguments, not via the current
2894 frame. This avoids crashes due to overrunning the bounds of
2895 frame's decode_mode_spec_buffer, which is not resized following
2896 the change of the frame dimensions from the initial 10x10.
2898 * w32term.h (w32_initialize_display_info): Adjust prototype.
2900 * term.c (init_tty): Take dimensions of the frame from the values
2901 returned by initialize_w32_display.
2903 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2904 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2905 (LIBES): Add $(GFILENOTIFY_LIBS).
2907 * w32inevt.c (handle_file_notifications): Add dummy implementation
2908 for !HAVE_W32NOTIFY.
2910 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2912 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2914 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2916 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2918 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2920 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2922 Fix minor problems found by static checking.
2923 * data.c (pure_write_error):
2924 Use xsignal2, not Fsignal, as Fsignal might return.
2925 * eval.c (set_backtrace_debug_on_exit): Now static.
2926 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2927 No longer inline. EXTERN_INLINE is needed only for functions
2928 defined in .h files. Reindent function header as per GNU style.
2929 (backtrace_p, backtrace_top, backtrace_next):
2930 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2931 compiler or linker. Add extern decls to pacify gcc -Wall.
2932 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2934 * frame.c (free_monitors): Define only on platforms that need it.
2935 * nsterm.m (ns_term_init):
2936 * process.c (catch_child_signal):
2937 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2938 defined on all porting targets these days.
2939 * process.c, process.h (catch_child_signal):
2940 Make it extern only if NS_IMPL_GNUSTEP is defined.
2942 2013-06-03 Eli Zaretskii <eliz@gnu.org>
2944 * w32.c (gettimeofday): Make the signature identical to prototype
2945 in nt/inc/sys/time.h.
2947 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2949 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2952 * keyboard.c (safe_run_hooks_error): Improve error message.
2954 * data.c (pure_write_error): Add `object' argument.
2955 * puresize.h (CHECK_IMPURE): Use it.
2957 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
2959 * Makefile.in (NOTIFY_OBJ): New variable.
2960 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2962 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2963 Call syms_of_gfilenotify.
2965 * gfilenotify.c: New file.
2967 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2968 and Qfile_w32notify.
2969 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2970 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2972 * lisp.h: Declare syms_of_gfilenotify.
2974 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2976 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2978 Merge the specpdl and backtrace stacks. Make the structure of the
2979 specpdl entries more obvious via a tagged union of structs.
2980 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2981 (enum specbind_tag): New enum.
2982 (struct specbinding): Make it a tagged union of structs.
2983 Add a case for backtrace records.
2984 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2985 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2986 (backtrace_debug_on_exit): New accessors.
2987 (struct backtrace): Remove.
2988 (struct catchtag): Remove backlist field.
2989 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2991 (Flocal_variable_p): Speed up the common case where the binding is
2993 * eval.c (backtrace_list): Remove.
2994 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2995 (set_backtrace_args, set_backtrace_nargs)
2996 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2997 (backtrace_next): New functions.
2998 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2999 (unwind_to_catch, internal_lisp_condition_case)
3000 (internal_condition_case, internal_condition_case_1)
3001 (internal_condition_case_2, internal_condition_case_n): Don't bother
3002 with backtrace_list any more.
3003 (Fsignal): Adjust to new backtrace format.
3004 (grow_specpdl): Move up.
3005 (record_in_backtrace): New function.
3006 (eval_sub, Ffuncall): Use it.
3007 (apply_lambda): Adjust to new backtrace format.
3008 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3010 (specbind): Adjust to new specpdl format. Simplify.
3011 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3012 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3014 (mark_backtrace): Remove.
3015 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3016 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3017 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3019 * profiler.c (record_backtrace): Use get_backtrace.
3020 (handle_profiler_signal): Use backtrace_top_function.
3021 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3024 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3026 * process.h (catch_child_signal): Declare.
3028 * process.c (catch_child_signal): New function.
3029 (init_process_emacs): Call it.
3031 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3032 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3034 (x_set_cursor_type): Remove declaration.
3035 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3036 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3037 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3038 (ns_get_color): Use F suffix on float.
3039 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3040 (ns_get_rgb_color): Remove.
3041 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3042 (note_mouse_movement): x and y are CGFloat.
3043 (ns_draw_fringe_bitmap): Remove unused rowY.
3044 Change #if to COCOA && >= 10_6.
3045 (ns_draw_window_cursor): Remove unused overspill.
3046 (ns_draw_underwave): width and x are EamcsCGFloat.
3047 (ns_draw_box): thickness is CGFloat.
3048 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3049 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3050 if not in main thread.
3051 (ns_get_pending_menu_title, ns_check_menu_open)
3052 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3053 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3054 (sendFromMainThread:): New method.
3055 (changeFont:): size is CGFloat.
3056 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3057 Disable warning about permanent text.
3058 (characterIndexForPoint:): Adjust return type depending on GNUStep
3060 (mouseDown:): delta is CGFloat.
3061 (updateFrameSize): Remove unised variable f.
3062 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3063 Cast float to EmacsCGFloat.
3064 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3065 also to -1 when restoring.
3066 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3067 inside NS_IMPL_COCOA.
3068 (toggleFullScreen:): Put call to toggleFullScreen inside
3069 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3070 (setPosition:portion:whole:): por is CGFloat.
3071 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3072 (mouseDown:): Use CGFloat.
3073 (mouseDragged:): Remove unised variable edge.
3074 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3076 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3078 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3079 when NS_IMPL_GNUSTEP.
3080 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3081 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3082 (EmacsToolbar): Add clearAll. Add tag argument to
3083 addDisplayItemWithImage.
3084 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3086 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3088 * nsmenu.m (ns_update_menubar): Make static.
3089 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3090 (fillWithWidgetValue:): Add cast to SEL for setAction.
3091 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3092 (update_frame_tool_bar): Update code for GNUStep.
3093 (clearAll): New method.
3094 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3095 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3096 Move identifierToItem setObject and activeIdentifiers addObject before
3097 call to insertItemWithItemIdentifier.
3098 (validateVisibleItems): Fix indentation.
3099 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3100 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3101 UtilityWindow to aStyle, remove call to setStyleMask.
3103 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3105 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3106 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3107 Use F suffix on floats.
3108 (ns_char_width): Returns CGFloat.
3109 (ns_ascii_average_width): w is CGFloat instead of float.
3110 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3112 (ns_glyph_metrics): CGFloat instead of float.
3114 * nsfns.m (x_set_foreground_color, x_set_background_color):
3116 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3117 remove unused variables.
3118 (Fns_read_file_name): Keep track if panel is for save.
3119 Use ns_filename_from_panel/ns_directory_from_panel.
3120 (Fns_list_services): delegate only used for COCOA.
3121 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3122 Just return the input if GNUStep.
3123 (x_screen_planes): Remove.
3124 (Fxw_color_values): Use EmacsCGFloat
3125 (Fns_display_monitor_attributes_list): Only get screen number for
3127 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3129 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3130 ns_directory_from_panel.
3132 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3134 * process.c (handle_child_signal): Also use WCONTINUED.
3135 This is so that list-processes doesn't mistakenly list the process
3136 as stopped, when the process has actually been continued and is
3139 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3141 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3142 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3143 not already configured.
3145 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3147 2013-05-29 Eli Zaretskii <eliz@gnu.org>
3149 * Makefile.in (mostlyclean): Remove *.res files.
3151 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3154 a buffer (bug#8447).
3156 2013-05-27 Eli Zaretskii <eliz@gnu.org>
3158 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3159 display vector, and we backtrack, handle the case that the
3160 previous character position is also displayed from a display
3161 vector or covered by a display string or image. (Bug#14476)
3163 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3165 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3166 (struct MonitorInfo, free_monitors): Remove.
3167 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3168 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3169 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3172 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3173 (struct MonitorInfo, free_monitors): Remove.
3174 (ns_screen_name): Make static.
3175 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3176 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3179 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3180 (struct MonitorInfo): New struct.
3181 (free_monitors, make_monitor_attribute_list): Declare.
3183 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3185 (free_monitors, make_monitor_attribute_list): New functions.
3186 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3189 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3191 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3193 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3195 * keyboard.c: Apply keyboard decoding only to events that come directly
3196 from the tty, not from unread-command-events (bug#14368).
3197 (read_event_from_main_queue): New function, extracted from read_char).
3198 (read_decoded_char): Remove.
3199 (read_decoded_event_from_main_queue): New function to replace it.
3200 (read_char): Use it.
3201 (read_key_sequence): Use read_char rather than read_decoded_char.
3203 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3205 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3207 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3209 2013-05-22 Kenichi Handa <handa@gnu.org>
3211 The following changes are to fix the setting of
3212 buffer-file-coding-system on, for instance, C-x RET c unix RET
3213 _FILE_OF_DOS_EOL_TYPE_ RET.
3215 * coding.h (struct coding_system): New member detected_utf8_chars.
3217 * coding.c (detect_coding_utf_8): Count characters and check EOL
3218 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3220 (setup_coding_system): Do not initialize coding->head_ascii.
3221 (check_ascii): Do not set coding->eol_seen but update it. Do not
3222 call adjust_coding_eol_type here.
3223 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3224 If the eol-type of CODING is already specified, adjust the eol type
3225 of the found coding-system.
3226 (decode_coding_gap): Cancel previous change. Utilize the
3227 character numbers counted by detect_coding_utf_8. Fix detection
3230 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3232 * search.c (looking_at_1): Only set last_thing_searched if the match
3233 changed the match-data (bug#14281).
3235 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3237 * xdisp.c (reseat_at_previous_visible_line_start):
3238 Already declared in dispextern.h, so remove it here.
3239 (move_it_vertically_backward): Likewise.
3241 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3243 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3244 (Fx_display_pixel_width, Fx_display_pixel_height)
3245 (Fx_display_mm_width, Fx_display_mm_height):
3246 Mention `display-monitor-attributes-list' in docstrings.
3248 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3249 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3250 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3251 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3252 (Fx_display_backing_store, Fx_display_visual_class)
3253 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3254 (Fx_display_grayscale_p, Fx_display_pixel_width)
3255 (Fx_display_pixel_height, Fx_display_planes)
3256 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3257 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3258 (Fx_display_mm_width, Fx_display_mm_height)
3259 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3260 height for all physical monitors as in X11.
3262 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3263 Return pixel width or height for all physical monitors as in X11.
3265 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3267 Port --enable-gcc-warnings to clang.
3268 * bytecode.c (exec_byte_code):
3270 Redo diagnostic pragmas to pacify clang, too.
3271 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3272 * editfns.c (Fencode_time):
3273 * fileio.c (file_accessible_directory_p):
3274 * font.c (font_unparse_xlfd):
3275 Use '&"string"[index]' instead of '"string" + (index)'.
3276 * undo.c (user_error): Remove; unused.
3278 2013-05-16 Eli Zaretskii <eliz@gnu.org>
3280 * insdel.c (insert_1_both): Document the arguments, instead of
3281 referring to insert_1, which no longer exists.
3283 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3284 some window, increment windows_or_buffers_changed, so that
3285 *Messages* display in that window is updated. (Bug#14408)
3287 * w32.c: Include epaths.h.
3288 (init_environment): Use cmdproxy.exe without leading directories.
3289 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3291 (gettimeofday): Adjust signature and return value to Posix
3294 * unexw32.c (open_output_file): Delete the existing emacs.exe
3295 before creating it, to break the hard link to the versioned
3298 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3299 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3300 (FIRSTFILE_OBJ): New variables.
3301 (W32_RES): Rename to EMACSRES. All users changed.
3302 (base_obj): Use $(CM_OBJ).
3303 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3304 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3305 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3306 $(W32_RES_LINK) before $(LIBES).
3307 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3309 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3311 * makefile.w32-in (DOC): Use just "DOC".
3313 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3315 * process.c: Export default filters and sentinels to Elisp.
3316 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3318 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3319 (Fset_process_sentinel, Fformat_network_address):
3320 Default to them instead of nil.
3321 (server_accept_connection): Sentinels can't be nil any more.
3322 (read_and_dispose_of_process_output): New function, extracted from
3323 read_process_output.
3324 (read_process_output): Use it; filters can't be nil.
3325 (Finternal_default_process_filter): New function, extracted from
3326 read_process_output.
3327 (exec_sentinel_unwind): Remove function.
3328 (exec_sentinel): Don't zilch sentinel while running.
3329 (status_notify): Sentinels can't be nil.
3330 (Finternal_default_process_sentinel): New function extracted from
3332 (setup_process_coding_systems): Default filter is not nil any more.
3333 (syms_of_process): Export new Elisp functions and initialize
3335 * lisp.h (make_lisp_proc): New function.
3337 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3339 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3341 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3343 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3344 unless we know that the window w is a leaf window.
3345 Another attempt at solving bug#14062.
3347 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3349 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3352 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3354 * image.c (gif_load): Check that subimages fit (Bug#14345).
3356 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3358 * lread.c (skip_dyn_eof): New function.
3359 (read1): Use it to skip the end of a file in response to #@00.
3361 * doc.c (get_doc_string): Slightly relax the sanity checking.
3363 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3365 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3366 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3367 (MonitorInfo): New struct.
3368 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3369 (Fns_display_monitor_attributes_list): New functions.
3370 (display-usable-bounds): Remove.
3371 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3374 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3376 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3377 (GTK_CHECK_VERSION): New macro, if not already defined.
3378 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3379 replaced by GTK_CHECK_VERSION.
3381 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3383 * xterm.h (GTK_PREREQ): New macro.
3384 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3385 to use this macro instead, for consistency and clarity.
3387 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3389 * xdisp.c (row_for_charpos_p): New function, with code of
3390 cursor_row_p, but accepts an additional argument CHARPOS instead
3391 of using a hardcoded PT.
3392 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3393 (row_containing_pos): Call row_for_charpos_p instead of partially
3394 doing the same. Fixes cursor positioning under longlines-mode
3395 when longlines-show-effect includes more than one newline, when
3396 moving the cursor vertically up.
3398 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3400 * makefile.w32-in (ACL_H): New macro.
3401 ($(BLD)/fileio.$(O)): Update dependencies.
3403 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3405 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3406 * Makefile.in (LIB_ACL): New macro.
3407 (LIBACL_LIBS): Remove.
3408 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3409 * fileio.c: Include <acl.h>.
3410 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3411 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3413 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3416 * unexelf.c: Don't assume ElfW (Half) fits in int.
3417 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3418 when dealing with ElfW (Half) values, since they can exceed 2**31
3419 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3420 (entry_address): Omit unused NUM arg. All uses changed.
3422 2013-05-07 Juri Linkov <juri@jurta.org>
3424 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3425 to the string converted from number with `Fnumber_to_string'.
3428 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3430 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3431 This fixes a problem introduced by my previous change.
3433 2013-05-07 Glenn Morris <rgm@gnu.org>
3435 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3437 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3439 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3441 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3443 Static checking by GCC 4.8.0.
3444 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3445 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3446 (x_get_monitor_attributes_fallback)
3447 (x_get_monitor_attributes_xinerama)
3448 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3449 Define only if USE_GTK.
3450 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3451 (x_get_monitor_attributes_fallback): Omit unused locals.
3452 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3453 Use double, not float, to avoid mixed-mode floating point arithmetic.
3455 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3456 Jan Djärv <jan.h.d@swipnet.se>
3458 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3459 (XINERAMA_CFLAGS): New macros.
3460 (ALL_CFLAGS, LIBES): Use them.
3462 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3463 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3464 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3465 (syms_of_xfns): DEFSYM them.
3466 (struct MonitorInfo): New struct.
3467 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3468 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3469 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3470 (x_get_monitor_attributes_xinerama): New functions.
3471 (Fx_display_monitor_attributes_list): New primitive.
3472 (syms_of_xfns): Defsubr it.
3474 * xterm.h (x_display_info): Add Xatom_net_workarea and
3475 Xatom_net_current_desktop.
3477 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3478 and dpyinfo->Xatom_net_current_desktop.
3480 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3482 * xdisp.c (pos_visible_p): Use the special code for finding the
3483 beginning of a display property or overlay for any "replacing"
3484 display property, not just for display strings. This solves
3485 incorrect reporting of position by posn-at-point. (Bug#14241)
3487 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3489 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3490 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3491 Verify that ElfW (Half) fits in int.
3492 (fatal): Use same signature as lisp.h.
3493 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3494 configure and build with -DUNEXELF_DEBUG without worrying about
3495 other modules that use DEBUG.
3496 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3497 possibly-wide integers now uses it instead of plain fprintf.
3498 (entry_address): New function, which avoids problems with 32-bit
3499 overflow on 64-bit hosts.
3500 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3501 (round_up): Don't assume the remainder fits in int.
3502 (find_section): Use bool for boolean. Simplify debug code.
3503 (unexec): Don't assume file sizes fit in int or size_t.
3504 Omit unnecessary trailing newline in 'fatal' format.
3505 Use strerror rather than outputting decimal error number.
3506 Remove unused code when emacs is not defined;
3507 this file relies on Emacs now.
3508 Don't assume e_phnum and e_shnum are positive.
3510 * regex.c: Fix problems when DEBUG is defined.
3511 (extract_number, extract_number_and_incr): Define regardless of
3512 whether DEBUG is defined; that's simpler and makes the code less
3513 likely to go stale in the normal case when DEBUG is not defined.
3514 Return int rather than taking an int * arg. All callers changed.
3515 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3516 Remove, replacing with ...
3517 (DEBUG_PRINT): New macro. All callers changed.
3518 (DEBUG_COMPILES_ARGUMENTS): New macro.
3519 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3520 (print_compiled_pattern, print_double_string) [DEBUG]:
3521 Use prototype rather than old-style definition.
3522 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3523 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3524 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3525 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3526 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3527 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3528 This matters only when DEBUG is defined.
3530 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3532 * xdisp.c (set_iterator_to_next): Set the
3533 ignore_overlay_strings_at_pos_p flag only if we are _really_
3534 iterating over an overlay string, as indicated by the
3535 current.overlay_string_index member. (Bug#14306)
3537 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3539 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3540 to where it is used, to avoid autorelease issues (Bug#14050).
3542 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3544 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3545 * fileio.c (syms_of_fileio): Implement this.
3546 * filelock.c (create_lock_file): If symbolic links don't work, so
3547 we use a regular file as a lock file, do not fsync the lock file;
3550 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3552 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3553 (syms_of_minibuf): Adjust accodingly.
3555 * callint.c (Fcall_interactively): Adjust calls accordingly.
3557 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3559 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3560 w->contents is a buffer before computing everything else.
3561 Use parentheses to disambiguate last part of the condition.
3563 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3564 assertion violations. (Bug#14062)
3566 2013-05-01 David Reitter <david.reitter@gmail.com>
3568 * nsfns.m (ns_tooltip): Initialize.
3570 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3572 * coding.c (decode_coding_gap): Don't remove the character before
3573 a newline unless it's a CR character. (Bug#14287)
3575 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3577 * dispextern.h (struct face): Move enum face_underline_type
3578 earlier so that bitfields can be in the same word.
3580 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3582 * nsfns.m (handlePanelKeys): New function.
3583 (EmacsOpenPanel:performKeyEquivalent:)
3584 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3585 arrows/function/control and copy/paste keys (Bug#14296).
3587 2013-04-27 Juri Linkov <juri@jurta.org>
3589 * callint.c (Fcall_interactively): Call `Qread_number' for
3590 interactive code letter `n' instead of using duplicate code.
3593 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3595 * systime.h (make_timeval): Declare as 'const'.
3597 2013-04-27 Kenichi Handa <handa@gnu.org>
3599 * font.c (font_open_entity): Always open a font of manageable
3602 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3604 Port better to AIX (Bug#14258).
3605 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3608 2013-04-24 Kenichi Handa <handa@gnu.org>
3610 * coding.c (decode_coding_iso_2022): When an invalid escape
3611 sequence is encountered, reset the invocation and designation
3612 status to the safest one.
3614 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3616 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3617 Without this fix, "make distclean" leaves stamp-h1 behind.
3619 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3621 * w32fns.c (w32_fullscreen_rect): New function to compute the
3622 window rectangle for the given fullscreen mode.
3623 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3624 longer tunes the window size. This keeps the window's edges flush
3625 with the screen and allows the taskbar to hide itself in fullboth.
3627 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3628 window decorations and uses the entire screen.
3630 * w32term.h (w32_fullscreen_rect) Add prototype.
3631 (struct w32_output): Replace normal_width, normal_height,
3632 normal_top, and normal_left members with a single normal_placement
3634 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3636 (FRAME_NORMAL_PLACEMENT): New macro.
3638 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
3640 * minibuf.c (Ftest_completion): Silence compiler warning.
3642 2013-04-15 Eli Zaretskii <eliz@gnu.org>
3644 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
3647 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3650 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3651 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3652 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3653 parentheses where appropriate.
3655 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3657 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3659 2013-04-14 Eli Zaretskii <eliz@gnu.org>
3661 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3662 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3663 Mention in the doc string that setting these variables takes
3664 effect only after a call to set-window-buffer. (Bug#14200)
3666 2013-04-13 Eli Zaretskii <eliz@gnu.org>
3668 * indent.c (Fvertical_motion): Don't consider display strings on
3669 overlay strings as display strings on the buffer position we
3670 started from. This prevents vertical cursor motion from jumping
3671 more than one line when there's an overlay string with a display
3672 property at end of line.
3673 Reported by Karl Chen <Karl.Chen@quarl.org> in
3674 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3676 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3678 * window.c (select_window): `record_buffer' even if window is
3679 already selected (bug#14191).
3681 2013-04-11 Eli Zaretskii <eliz@gnu.org>
3683 * window.c (Fwindow_end): Test more flags, including the buffer's
3684 last_overlay_modified flag, to determine whether the window's
3685 display is really up-to-date. Prevents the function from
3686 returning a stale value. (Bug#14170)
3687 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3690 2013-04-10 Eli Zaretskii <eliz@gnu.org>
3692 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
3693 garbaged only if it is not already the top frame on its TTY.
3694 This prevents flickering due to constant redrawing of TTY frames when
3695 there are GUI frames open in the same session. (Bug#13864)
3697 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3699 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3700 of marking the idle timers directly.
3702 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3704 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3707 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3709 * window.c (select_window): Don't record_buffer while the invariant is
3710 temporarily broken (bug#14161).
3712 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3714 2013-04-07 Eli Zaretskii <eliz@gnu.org>
3716 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3718 2013-04-07 Romain Francoise <romain@orebokech.com>
3720 Ignore additional platform-specific ACL errors (Bug#13702).
3721 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3722 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3724 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3726 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3729 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3731 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3732 This bug was introduced by my 2013-02-25 change that simplified
3733 data_start configuration. Without this change, on GNU/Linux
3734 an Emacs configured with --enable-profiling fails immediately
3735 due to a profiler signal.
3736 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3737 with these flags. On platforms where special flags are needed
3738 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3739 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3740 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3742 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3744 Get rid of some platform-specific functions examining window
3745 system and its capabilities. This is a partial rework of the
3747 * lisp.h (have_menus_p): Remove prototype. This function is
3748 replaced with platform-independent window_system_available.
3749 (check_window_system): Move to...
3750 * frame.h (decode_window_system_frame, window_system_available):
3751 ...here, add new prototypes.
3752 * frame.c (window_system_available, decode_window_system_frame):
3754 (check_window_system): Platform-independent now.
3755 * xterm.h (x_in_use): Remove declaration.
3757 * w32term.h (check_x_frame):
3758 * nsterm.h (check_x_frame): Remove prototypes. This function
3759 is replaced with platform-independent decode_window_system_frame.
3760 * msdos.c (have_menus_p): Remove.
3761 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3762 Remove platform-specific functions. Use check_window_system,
3763 decode_window_system_frame and check_ns_display_info where
3764 appropriate. Minor style and comment tweaks.
3765 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3766 (check_x_frame): Likewise.
3767 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3769 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3770 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3771 * xmenu.c, xselect.c: All related users changed.
3773 2013-04-03 Kenichi Handa <handa@gnu.org>
3775 The following changes is to optimize the code for reading UTF-8
3778 * coding.c (check_ascii): Rename from detect_ascii. Return value
3779 changed. Check EOL format. Do not call adjust_coding_eol_type
3781 (check_utf_8): New function.
3782 (adjust_coding_eol_type): Do nothing if already adjusted.
3783 (detect_coding): Compare the return value of check_ascii with
3784 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3785 (decode_coding_gap): Optimize for valid UTF-8.
3787 2013-03-21 Kenichi Handa <handa@gnu.org>
3789 * coding.c (syms_of_coding): Cancel previous change.
3791 * insdel.c (insert_from_gap): Fix previous change.
3793 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3795 Consistently use platform-specific function to detect window system.
3796 * lisp.h (check_window_system): New prototype. This function is
3797 going to replace check_x, check_w32 and check_ns.
3798 (have_menus_p): Mention msdos.c in comment.
3799 * fontset.c (check_window_system_func): Remove. Adjust all users.
3800 * fontset.h (check_window_system_func): Remove prototype.
3801 * nsterm.h (check_ns):
3802 * xterm.h (check_x):
3803 * w32term.h (check_w32): Likewise.
3804 * menu.c (Fx_popup_menu): Use check_window_system.
3805 * msdos.c (check_window_system): Define for MS-DOS.
3806 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3807 * w32fns.c (check_window_system): Likewise for MS-Windows.
3808 * xfns.c (check_window_system): Likewise for X.
3809 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3810 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3812 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3814 Prefer < to > in range checks such as 0 <= i && i < N.
3815 This makes it easier to visualize quantities on a number line.
3816 This patch doesn't apply to all such range checks,
3817 only to the range checks affected by the 2013-03-24 change.
3818 This patch reverts most of the 2013-03-24 change.
3819 * alloc.c (xpalloc, Fgarbage_collect):
3820 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3821 * character.c (string_escape_byte8):
3822 * charset.c (read_hex):
3823 * data.c (cons_to_unsigned):
3824 * dispnew.c (update_frame_1):
3825 * doc.c (Fsubstitute_command_keys):
3826 * doprnt.c (doprnt):
3827 * editfns.c (hi_time, decode_time_components):
3828 * fileio.c (file_offset):
3829 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3830 * font.c (font_intern_prop):
3831 * frame.c (x_set_alpha):
3832 * gtkutil.c (get_utf8_string):
3833 * indent.c (check_display_width):
3834 * keymap.c (Fkey_description):
3835 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3837 * minibuf.c (read_minibuf_noninteractive):
3838 * process.c (wait_reading_process_output):
3839 * search.c (Freplace_match):
3840 * window.c (get_phys_cursor_glyph):
3841 * xdisp.c (redisplay_internal):
3842 * xsmfns.c (smc_save_yourself_CB):
3843 Prefer < to > for range checks.
3844 * dispnew.c (sit_for): Don't mishandle NaNs.
3845 This fixes a bug introduced in the 2013-03-24 change.
3846 * editfns.c (decode_time_components): Don't hoist comparison.
3847 This fixes another bug introduced in the 2013-03-24 change.
3849 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3851 * frame.h (struct frame): Drop scroll_bottom_vpos
3852 member becaue all real users are dead long ago.
3853 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3854 * xdisp.c (redisplay_internal): Adjust user.
3856 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3858 * nsmenu.m (showAtX:Y:for:): setLevel to
3859 NSPopUpMenuWindowLevel (Bug#13998).
3861 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3863 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3864 (ns_check_pending_open_menu): Declare.
3866 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3867 (x_activate_menubar): Update the menu with title that matches
3868 ns_get_pending_menu_title, and call
3869 ns_check_pending_openmenu (Bug#12698).
3870 (menuWillOpen:): New method.
3871 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3873 * nsterm.m (menu_will_open_state, menu_mouse_point)
3874 (menu_pending_title): New varaibles.
3875 (ns_get_pending_menu_title, ns_check_menu_open)
3876 (ns_check_pending_open_menu): New functions.
3878 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3880 * indent.c (current_column_bol_cache): Remove leftover which is not
3881 used in Fmove_to_column any more.
3882 (current_column, scan_for_column): Adjust users.
3883 * keyboard.c (last_point_position_buffer, last_point_position_window):
3884 Remove leftovers which are not used for recording undo any more.
3885 (command_loop_1, syms_of_keyboard): Adjust users.
3886 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3887 redisplay_window any more.
3888 (move_it_to): Adjust user.
3890 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
3892 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3893 Update dependencies.
3895 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3897 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3898 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3901 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3903 * window.h (struct window): Replace hchild, vchild and buffer slots
3904 with the only contents slot. This is possible because each valid
3905 window may have either the child window (in vertical or horizontal
3906 combination) or buffer to display (for the leaf window). Using that,
3907 a lof of operations to traverse and/or change window hierarchies may
3908 be simplified. New member horizontal is used to distinguish between
3909 horizontal and vertical combinations of internal windows.
3910 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3911 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3912 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3913 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3914 Use contents slot, not buffer, where appropriate.
3915 (wset_combination): New function.
3916 (wset_buffer): Add eassert.
3917 (Fframe_first_window): Simplify the loop reaching first window.
3918 (Fwindow_buffer): Use WINDOW_LEAF_P.
3919 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3920 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3921 (unshow_buffer): Convert initial debugging check to eassert.
3922 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3923 (make_parent_window, window_resize_check, window_resize_apply)
3924 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3925 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3926 Adjust to match struct window changes.
3927 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3928 (mark_window_cursors_off, count_windows, get_leaf_windows)
3929 (foreach_window_1): Simplify the loop.
3930 * alloc.c (mark_object): Do not check for the leaf window because
3931 internal windows has no glyph matrices anyway.
3932 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3933 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3934 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3935 (build_frame_matrix_from_window_tree, mirror_make_current)
3936 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3937 (update_window_tree, set_window_update_flags): Simplify the loop.
3938 (sync_window_with_frame_matrix_rows): Enforce live window.
3939 Use contents slot, not buffer, where appropriate.
3940 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3941 and WINDOW_HORIZONTAL_COMBINATION_P.
3942 (make_frame_visible_1): Simplify the loop.
3943 Use contents slot, not buffer, where appropriate.
3944 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3945 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3946 (expose_window_tree): Likewise.
3947 Use contents slot, not buffer, where appropriate.
3948 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3949 to avoid deleted windows. Use contents slot instead of buffer.
3950 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3951 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3952 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3953 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3955 2013-03-28 Eli Zaretskii <eliz@gnu.org>
3957 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3958 identify the reasons for assertion violations in bug#14062 and
3960 (Fx_show_tip): Fix compilation error under
3961 "--enable-check-lisp-object-type". (Bug#14073)
3963 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3964 Reported by <rzl24ozi@gmail.com>.
3966 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3968 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3970 (unwind_with_echo_area_buffer): ...to restore it here.
3971 This is needed to ensure that...
3972 (redisplay_window): ...both window markers are valid here,
3973 which is verified by eassert.
3974 * editfns.c (save_excursion_save): Do not assume that
3975 selected_window always displays the buffer.
3976 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3979 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3981 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3984 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3986 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3988 2013-03-27 Eli Zaretskii <eliz@gnu.org>
3990 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3991 since MinGW's w32api headers do. This avoids compiler warnings.
3993 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3996 2013-03-26 Eli Zaretskii <eliz@gnu.org>
3998 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4000 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4002 * gtkutil.c (style_changed_cb): Check if frame is live and an
4003 X frame (Bug#14038).
4005 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4007 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4008 Define only for _WIN32_WINNT less than 0x0500.
4009 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4011 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4012 see its own definitions of 'struct timeval' and 'struct timezone'.
4014 Fix incompatibilities between MinGW.org and MinGW64 headers.
4015 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4017 * w32.c (REPARSE_DATA_BUFFER): Guard with
4018 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4020 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4022 * xterm.c: Include X11/XKBlib.h
4023 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4025 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4027 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4029 * blockinput.h (input_blocked_p): Likewise.
4030 * bytecode.c (exec_byte_code): Likewise.
4031 * callproc.c (call_process_kill, call_process_cleanup)
4032 (Fcall_process): Likewise.
4033 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4034 (Fccl_execute_on_string): Likewise.
4035 * character.c (string_escape_byte8): Likewise.
4036 * charset.c (read_hex): Likewise.
4037 * cm.c (calccost): Likewise.
4038 * data.c (cons_to_unsigned): Likewise.
4039 * dired.c (directory_files_internal, file_name_completion):
4041 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4042 (sit_for): Likewise.
4043 * doc.c (Fsubstitute_command_keys): Likewise.
4044 * doprnt.c (doprnt): Likewise.
4045 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4046 * emacsgtkfixed.c: Likewise.
4047 * fileio.c (file_offset, Fwrite_region): Likewise.
4048 * floatfns.c (Fexpt, fmod_float): Likewise.
4049 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4051 * font.c (font_intern_prop): Likewise.
4052 * frame.c (x_set_alpha): Likewise.
4053 * gtkutil.c (get_utf8_string): Likewise.
4054 * indent.c (check_display_width): Likewise.
4055 * intervals.c (create_root_interval, rotate_right, rotate_left)
4056 (split_interval_right, split_interval_left)
4057 (adjust_intervals_for_insertion, delete_node)
4058 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4059 (merge_interval_right, merge_interval_left, copy_intervals)
4060 (set_intervals_multibyte_1): Likewise.
4061 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4062 * keymap.c (Fkey_description): Likewise.
4063 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4064 * lread.c (openp, read_integer, read1, string_to_number):
4066 * menu.c (ensure_menu_items): Likewise.
4067 * minibuf.c (read_minibuf_noninteractive): Likewise.
4068 * print.c (printchar, strout): Likewise.
4069 * process.c (create_process, Faccept_process_output)
4070 (wait_reading_process_output, read_process_output, send_process)
4071 (wait_reading_process_output): Likewise.
4072 * profiler.c (make_log, handle_profiler_signal): Likewise.
4073 * regex.c (re_exec): Likewise.
4074 * regex.h: Likewise.
4075 * search.c (looking_at_1, Freplace_match): Likewise.
4076 * sysdep.c (get_child_status, procfs_ttyname)
4077 (procfs_get_total_memory): Likewise.
4078 * systime.h (EMACS_TIME_VALID_P): Likewise.
4079 * term.c (dissociate_if_controlling_tty): Likewise.
4080 * window.c (get_phys_cursor_glyph): Likewise.
4081 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4082 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4084 * xfns.c (Fx_window_property): Likewise.
4085 * xmenu.c (set_frame_menubar): Likewise.
4086 * xselect.c (x_get_window_property, x_handle_dnd_message):
4088 * xsmfns.c (smc_save_yourself_CB): Likewise.
4089 * xterm.c (x_scroll_bar_set_handle): Likewise.
4091 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4093 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4094 to be optional or nil. Adjust comment and convert it to docstring.
4095 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4096 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4098 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4100 Static checking by GCC 4.8-20130319.
4101 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4102 * process.c (Fset_process_datagram_address)
4103 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4104 * xdisp.c (get_char_face_and_encoding):
4105 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4106 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4107 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4109 2013-03-24 Ken Brown <kbrown@cornell.edu>
4111 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4112 fix compilation on 64-bit Cygwin, where underscores are not
4113 automatically prepended.
4115 * w32term.c (w32_initialize): Silence compiler warning.
4117 2013-03-23 Eli Zaretskii <eliz@gnu.org>
4119 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4120 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4121 variables, to save and restore frame dimensions.
4122 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4123 after returning from a 'fullscreen' configuration.
4124 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4125 to avoid races between the main thread and the input thread.
4127 * w32term.h (struct w32_output): New members normal_width,
4128 normal_height, normal_top, normal_left, and prev_fsmode.
4129 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4130 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4133 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4134 'fullscreen' parameter. Always record previous width and height
4135 of the frame, except when switching out of maximized modes, so
4136 that they could be restored correctly, instead of resetting to the
4137 default frame dimensions. Send SC_RESTORE command to the frame,
4138 unless we are going to send SC_MAXIMIZE, to restore the frame
4139 resize hints in the mouse pointer shown by the window manager.
4142 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4144 * lisp.h (get_frame_param): Adjust conditions for prototype
4147 2013-03-22 Ken Brown <kbrown@cornell.edu>
4149 * unexcw.c: Drop unneeded inclusion of w32common.h.
4150 (report_sheap_usage): Declare.
4151 (read_exe_header): Add magic numbers for x86_64.
4152 (fixup_executable): Fix printf format specifier for unsigned long
4155 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4157 * frame.h (struct frame): Put menu_bar_window under #ifdef
4158 because this member is not needed when X toolkit is in use.
4159 (fset_menu_bar_window):
4160 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4161 (free_glyphs, update_frame):
4162 * xdisp.c (expose_frame): Likewise.
4163 (display_menu_bar): Likewise. Remove redundant eassert.
4164 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4167 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4169 Use functions and constants to manipulate Lisp_Save_Value objects.
4170 This replaces code that used macros and strings and token-pasting.
4171 The change makes the C source a bit easier to follow,
4172 and shrinks the Emacs executable a bit.
4173 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4174 (make_save_value): Change 1st arg from string to enum. All callers
4177 (mark_object): Use if, not #if, for GC_MARK_STACK.
4178 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4179 (XSAVE_OBJECT): Now functions, not macros.
4180 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4181 the constant was never used.
4182 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4183 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4184 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4185 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4187 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4188 type3 with a single member save_type. All uses changed.
4189 (save_type, set_save_pointer, set_save_integer): New functions.
4190 * print.c (PRINTX): Remove.
4192 * alloc.c: Remove redundant static declarations.
4194 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4196 * window.h (struct window): Convert left_col, top_line, total_lines
4197 and total_cols from Lisp_Objects to integers. Adjust comments.
4198 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4200 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4201 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4202 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4203 Adjust users where appropriate.
4205 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4207 * frame.h (struct frame): Drop resx and resy because the same data is
4208 available from window system-specific output context. Adjust users.
4209 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4210 New functions to provide defaults when no window system available.
4211 (FRAME_RES_X, FRAME_RES_Y): New macros.
4212 (NUMVAL): Move from xdisp.c.
4213 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4214 (Ffont_face_attributes, Fopen_font):
4215 * image.c (gs_load):
4216 * w32font.c (fill_in_logfont):
4217 * xdisp.c (calc_pixel_width_or_height):
4218 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4219 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4221 2013-03-20 Kenichi Handa <handa@gnu.org>
4223 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4224 to 1 (temporary workaround until a bug related to ASCII
4225 optimization is fixed).
4227 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4229 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4230 Signal error if window is not internal. Adjust docstring.
4231 (delete_all_child_windows): Use combination_limit to save the buffer.
4232 (Fset_window_configuration): Adjust accordingly.
4233 * print.c (syms_of_print): Initialize debugging output not here...
4234 (init_print_once): ...but in a new function here.
4235 * lisp.h (init_print_once): Add prototype.
4236 * emacs.c (main): Add call to init_print_once. Adjust comments.
4238 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4240 * window.c (window_resize_check, window_resize_apply)
4241 (window_from_coordinates, recombine_windows, set_window_buffer)
4242 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4243 (Fsplit_window_internal, Fdelete_window_internal)
4244 (freeze_window_starts): Use bool for booleans.
4245 * window.h (window_frame_coordinates, resize_frame_windows)
4246 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4248 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4250 * dispnew.c (bitch_at_user): Use `user-error'.
4252 2013-03-17 Ken Brown <kbrown@cornell.edu>
4254 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4255 as return type of image_background. (Bug#13981)
4256 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4258 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4260 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4261 (ns_select): Don't return with result uninitialized.
4263 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4266 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4268 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4269 directories. If filename is nil, get directory name (Bug#13932).
4270 Use getFilename and getDirectory.
4271 (getFilename, getDirectory): New methods for EmacsSavePanel and
4273 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4275 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4277 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4279 2013-03-15 Kenichi Handa <handa@gnu.org>
4281 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4282 (adjust_after_replace): Make it back to static. Delete the third
4283 arg text_at_gap_tail. Cancel the code for handling it.
4285 * coding.h (struct coding_system): New member eol_seen.
4287 * coding.c (detect_ascii): New function.
4288 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4289 when the source bytes are actually scanned. On detecting for
4290 coding_category_utf_8_auto, call detect_ascii instead of scanning
4291 source bytes directly.
4292 (produce_chars): Call insert_from_gap with the new arg 0.
4293 (encode_coding): Likewise.
4294 (decode_coding_gap): Control ASCII optimization by the variable
4295 disable_ascii_optimization instead of #ifndef .. #endif.
4296 Deccode EOL format according to coding->eol_seen.
4297 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4300 * lisp.h (adjust_after_replace): Cancel externing it.
4301 (insert_from_gap): Adjust prototype.
4303 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4305 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4306 FULLSCREEN_MAXIMIZED. (Bug#13935)
4308 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4310 * region-cache.c (find_cache_boundary, move_cache_gap)
4311 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4312 Simplify debugging check and convert to eassert. Adjust comment.
4313 (pp_cache): Put under ENABLE_CHECKING.
4315 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4317 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4318 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4320 (w32fullscreen_hook): If the frame is visible, reset
4321 f->want_fullscreen flag after changing the frame size. If the
4322 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4325 2013-03-13 Daniel Colascione <dancol@dancol.org>
4327 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4328 too so that these builds can use Cygwin's file conversion
4329 functions. (We've been building and linking cygw32.o all along
4330 and just not using it.)
4332 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4334 File synchronization fixes (Bug#13944).
4335 * Makefile.in (LIB_FDATASYNC): New macro.
4337 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4338 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4339 Don't worry about HAVE_FSYNC, since a substitute fsync is
4340 available if the system lacks one.
4341 (Fwrite_regin): Retry fsync if interrupted.
4343 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4345 * w32term.c (w32_read_socket): If the Emacs frame is being
4346 activated, call w32fullscreen_hook, to make sure the new frame
4347 dimensions are in effect. (Bug#13937)
4349 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4351 * xdisp.c (init_iterator): Simplify because both character and byte
4352 positions are either specified or -1. Add eassert. Adjust comment.
4353 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4354 character and byte positions can be obtained from marker.
4356 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4358 Static checking by Sun C 5.12.
4359 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4360 * bytecode.c (exec_byte_code):
4361 * dispnew.c (init_display):
4363 * fileio.c (Fsubstitute_in_file_name):
4364 * keyboard.c (Fevent_convert_list):
4365 * keymap.c (Fsingle_key_description):
4366 * term.c (maybe_fatal, fatal):
4367 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4368 * xsmfns.c (Fhandle_save_session):
4369 Omit unreachable code.
4370 * keymap.c (map_keymap_char_table_item): Cast void * to
4371 a function pointer type; the C Standard requires this.
4373 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4374 Include <sys/param.h> unconditionally, as that works elsewhere and
4375 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4376 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4379 See ChangeLog.12 for earlier changes.
4385 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4387 This file is part of GNU Emacs.
4389 GNU Emacs is free software: you can redistribute it and/or modify
4390 it under the terms of the GNU General Public License as published by
4391 the Free Software Foundation, either version 3 of the License, or
4392 (at your option) any later version.
4394 GNU Emacs is distributed in the hope that it will be useful,
4395 but WITHOUT ANY WARRANTY; without even the implied warranty of
4396 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4397 GNU General Public License for more details.
4399 You should have received a copy of the GNU General Public License
4400 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.