| blob | 226ee17ce518e09f9241d01bc5ddf89136cbcc83 |
1 ;;; checkdoc.el --- check documentation strings for style requirements
3 ;; Copyright (C) 1997, 1998, 2001, 2002, 2003, 2004,
4 ;; 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
6 ;; Author: Eric M. Ludlam <zappo@gnu.org>
7 ;; Version: 0.6.2
8 ;; Keywords: docs, maint, lisp
10 ;; This file is part of GNU Emacs.
12 ;; GNU Emacs is free software: you can redistribute it and/or modify
13 ;; it under the terms of the GNU General Public License as published by
14 ;; the Free Software Foundation, either version 3 of the License, or
15 ;; (at your option) any later version.
17 ;; GNU Emacs is distributed in the hope that it will be useful,
18 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
19 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20 ;; GNU General Public License for more details.
22 ;; You should have received a copy of the GNU General Public License
23 ;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
25 ;;; Commentary:
26 ;;
27 ;; The Emacs Lisp manual has a nice chapter on how to write
28 ;; documentation strings. Many stylistic suggestions are fairly
29 ;; deterministic and easy to check for syntactically, but also easy
30 ;; to forget. The main checkdoc engine will perform the stylistic
31 ;; checks needed to make sure these styles are remembered.
32 ;;
33 ;; There are two ways to use checkdoc:
34 ;; 1) Periodically use `checkdoc' or `checkdoc-current-buffer'.
35 ;; `checkdoc' is a more interactive version of
36 ;; `checkdoc-current-buffer'
37 ;; 2) Use `checkdoc-minor-mode' to automatically check your
38 ;; documentation whenever you evaluate Lisp code with C-M-x
39 ;; or [menu-bar emacs-lisp eval-buffer]. Additional key-bindings
40 ;; are also provided under C-c ? KEY
41 ;; (require 'checkdoc)
42 ;; (add-hook 'emacs-lisp-mode-hook
43 ;; '(lambda () (checkdoc-minor-mode 1)))
44 ;;
45 ;; Using `checkdoc':
46 ;;
47 ;; The commands `checkdoc' and `checkdoc-ispell' are the top-level
48 ;; entry points to all of the different checks that are available. It
49 ;; breaks examination of your Lisp file into four sections (comments,
50 ;; documentation, messages, and spacing) and indicates its current
51 ;; state in a status buffer.
52 ;;
53 ;; The Comments check examines your headers, footers, and
54 ;; various tags (such as "Code:") to make sure that your code is ready
55 ;; for easy integration into existing systems.
56 ;;
57 ;; The Documentation check deals with documentation strings
58 ;; and their elements that help make Emacs easier to use.
59 ;;
60 ;; The Messages check ensures that the strings displayed in the
61 ;; minibuffer by some commands (such as `error' and `y-or-n-p')
62 ;; are consistent with the Emacs environment.
63 ;;
64 ;; The Spacing check cleans up white-space at the end of lines.
65 ;;
66 ;; The interface while working with documentation and messages is
67 ;; slightly different when being run in the interactive mode. The
68 ;; interface offers several options, including the ability to skip to
69 ;; the next error, or back up to previous errors. Auto-fixing is
70 ;; turned off at this stage, but you can use the `f' or `F' key to fix
71 ;; a given error (if the fix is available.)
72 ;;
73 ;; Auto-fixing:
74 ;;
75 ;; There are four classifications of style errors in terms of how
76 ;; easy they are to fix. They are simple, complex, really complex,
77 ;; and impossible. (Impossible really means that checkdoc does not
78 ;; have a fixing routine yet.) Typically white-space errors are
79 ;; classified as simple, and are auto-fixed by default. Typographic
80 ;; changes are considered complex, and the user is asked if they want
81 ;; the problem fixed before checkdoc makes the change. These changes
82 ;; can be done without asking if `checkdoc-autofix-flag' is properly
83 ;; set. Potentially redundant changes are considered really complex,
84 ;; and the user is always asked before a change is inserted. The
85 ;; variable `checkdoc-autofix-flag' controls how these types of errors
86 ;; are fixed.
87 ;;
88 ;; Spell checking text:
89 ;;
90 ;; The variable `checkdoc-spellcheck-documentation-flag' can be set
91 ;; to customize how spell checking is to be done. Since spell
92 ;; checking can be quite slow, you can optimize how best you want your
93 ;; checking done. The default is `defun', which spell checks each time
94 ;; `checkdoc-defun' or `checkdoc-eval-defun' is used. Setting to nil
95 ;; prevents spell checking during normal usage.
96 ;; Setting this variable to nil does not mean you cannot take
97 ;; advantage of the spell checking. You can instead use the
98 ;; interactive functions `checkdoc-ispell-*' to check the spelling of
99 ;; your documentation.
100 ;; There is a list of Lisp-specific words which checkdoc will
101 ;; install into Ispell on the fly, but only if Ispell is not already
102 ;; running. Use `ispell-kill-ispell' to make checkdoc restart it with
103 ;; these words enabled.
104 ;;
105 ;; Checking parameters:
106 ;;
107 ;; You might not always want a function to have its parameters listed
108 ;; in order. When this is the case, put the following comment just in
109 ;; front of the documentation string: "; checkdoc-order: nil" This
110 ;; overrides the value of `checkdoc-arguments-in-order-flag'.
111 ;;
112 ;; If you specifically wish to avoid mentioning a parameter of a
113 ;; function in the doc string (such as a hidden parameter, or a
114 ;; parameter which is very obvious like events), you can have checkdoc
115 ;; skip looking for it by putting the following comment just in front
116 ;; of the documentation string: "; checkdoc-params: (args go here)"
117 ;;
118 ;; Checking message strings:
119 ;;
120 ;; The text that follows the `error' and `y-or-n-p' commands is
121 ;; also checked. The documentation for `error' clearly states some
122 ;; simple style rules to follow which checkdoc will auto-fix for you.
123 ;; `y-or-n-p' also states that it should end in a space. I added that
124 ;; it should end in "? " since that is almost always used.
125 ;;
126 ;; Adding your own checks:
127 ;;
128 ;; You can experiment with adding your own checks by setting the
129 ;; hooks `checkdoc-style-hooks' and `checkdoc-comment-style-hooks'.
130 ;; Return a string which is the error you wish to report. The cursor
131 ;; position should be preserved.
132 ;;
133 ;; Error errors:
134 ;;
135 ;; Checkdoc does not always flag errors correctly. There are a
136 ;; couple ways you can coax your file into passing all of checkdoc's
137 ;; tests through buffer local variables.
138 ;;
139 ;; The variable `checkdoc-verb-check-experimental-flag' can be used
140 ;; to turn off the check for verb-voice in case you use words that are
141 ;; not semantically verbs, but are still in the incomplete list.
142 ;;
143 ;; The variable `checkdoc-symbol-words' can be a list of words that
144 ;; happen to also be symbols. This is not a problem for one-word
145 ;; symbols, but if you use a hyphenated word that is also a symbol,
146 ;; then you may need this.
147 ;;
148 ;; The symbol `checkdoc-force-docstrings-flag' can be set to nil if
149 ;; you have many undocumented functions you don't wish to document.
150 ;;
151 ;; See the above section "Checking Parameters" for details about
152 ;; parameter checking.
153 ;;
154 ;; Dependencies:
155 ;;
156 ;; This file requires lisp-mnt (Lisp maintenance routines) for the
157 ;; comment checkers.
158 ;;
159 ;; Requires custom for Emacs v20.
161 ;;; TO DO:
162 ;; Hook into the byte compiler on a defun/defvar level to generate
163 ;; warnings in the byte-compiler's warning/error buffer.
164 ;; Better ways to override more typical `eval' functions. Advice
165 ;; might be good but hard to turn on/off as a minor mode.
166 ;;
167 ;;; Maybe Do:
168 ;; Code sweep checks for "forbidden functions", proper use of hooks,
169 ;; proper keybindings, and other items from the manual that are
170 ;; not specifically docstring related. Would this even be useful?
172 ;;; Code:
180 "Support for doc string checking in Emacs Lisp."
186 "String to display in mode line when Checkdoc mode is enabled; nil for none."
192 "Non-nil means attempt auto-fixing of doc strings.
193 If this value is the symbol `query', then the user is queried before
194 any change is made. If the value is `automatic', then all changes are
195 made without asking unless the change is very-complex. If the value
196 is `semiautomatic' or any other value, then simple fixes are made
197 without asking, and complex changes are made by asking the user first.
198 The value `never' is the same as nil, never ask or change anything."
207 Setting this to nil will silently make fixes that require no user
208 interaction. See `checkdoc-autofix-flag' for auto-fixing details."
213 "Non-nil means that all checkable definitions should have documentation.
214 Style guide dictates that interactive functions MUST have documentation,
215 and that it's good but not required practice to make non user visible items
216 have doc strings."
219 ;;;###autoload(put 'checkdoc-force-docstrings-flag 'safe-local-variable 'booleanp)
222 "Non-nil means that files should have a History section or ChangeLog file.
223 This helps document the evolution of, and recent changes to, the package."
226 ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp)
229 "Non-nil means the first line of a docstring may end with a comma.
230 Ordinarily, a full sentence is required. This may be misleading when
231 there is a substantial caveat to the one-line description -- the comma
232 should be used when the first part could stand alone as a sentence, but
233 it indicates that a modifying clause follows."
236 ;;;###autoload(put 'checkdoc-permit-comma-termination-flag 'safe-local-variable 'booleanp)
239 "Non-nil means run Ispell on text based on value.
240 This is automatically set to nil if Ispell does not exist on your
241 system. Possible values are:
243 nil - Don't spell-check during basic style checks.
244 defun - Spell-check when style checking a single defun
245 buffer - Spell-check when style checking the whole buffer
246 interactive - Spell-check during any interactive check.
247 t - Always spell-check"
261 Any more than this and a warning is generated suggesting that the construct
267 "Non-nil means warn if arguments appear out of order.
268 Setting this to nil will mean only checking that all the arguments
269 appear in the proper form in the documentation, not that they are in
270 the same order as they appear in the argument list. No mention is
271 made in the style guide relating to order."
274 ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp)
277 "Hooks called after the standard style check is completed.
278 All hooks must return nil or a string representing the error found.
279 Useful for adding new user implemented commands.
281 Each hook is called with two parameters, (DEFUNINFO ENDPOINT).
282 DEFUNINFO is the return value of `checkdoc-defun-info'. ENDPOINT is the
286 "Hooks called after the standard comment style check is completed.
287 Must return nil if no errors are found, or a string describing the
296 "Regular expression used to identify a defun.
300 "Non-nil means to attempt to check the voice of the doc string.
301 This check keys off some words which are commonly misused. See the
302 variable `checkdoc-common-verbs-wrong-voice' if you wish to add your own."
307 "Non-nil means generate warnings in a buffer for browsing.
308 Do not set this by hand, use a function like `checkdoc-current-buffer'
312 "A list of symbol names (strings) which also happen to make good words.
313 These words are ignored when unquoted symbols are searched for.
314 This should be set in an Emacs Lisp file's local variables."
317 ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p)
319 ;;;###autoload
321 ;; this is a function so it might be shared by checkdoc-proper-noun-list
322 ;; and/or checkdoc-ispell-lisp-words in the future
422 )
423 "Alist of common words in the wrong voice and what should be used instead.
424 Set `checkdoc-verb-check-experimental-flag' to nil to avoid this costly
425 and experimental check. Do not modify this list without setting
426 the value of `checkdoc-common-verbs-regexp' to nil which cause it to
433 nil
435 ;; When dealing with syntax in doc strings, make sure that - are encompassed
436 ;; in words so we can use cheap \\> to get the end of a symbol, not the
437 ;; end of a word in a conglomerate.
439 )
442 ;;; Compatibility
443 ;;
459 ;;; User level commands
460 ;;
461 ;;;###autoload
463 "Interactively check the entire buffer for style errors.
464 The current status of the check will be displayed in a buffer which
465 the users will view as each check is completed."
471 ;; if the user set autofix to never, then that breaks the
472 ;; obviously requested asking implied by using this function.
473 ;; Set it to paranoia level.
476 'query
477 checkdoc-autofix-flag))
478 tmp)
480 ;; check the comments
488 ;; Check the documentation
495 ;; Check the message text
501 ;; Rogue spacing
510 "Display and update the status buffer for the current checkdoc mode.
511 CHECK is a list of four strings stating the current status of each
512 test; the nth string describes the status of the nth test."
520 )))
526 ;;;###autoload
528 "Interactively check the current buffer for doc string errors.
529 Prefix argument START-HERE will start the checking from the current
530 point, otherwise the check starts at the beginning of the current
531 buffer. Allows navigation forward and backwards through document
532 errors. Does not check for comment or space warnings.
533 Optional argument SHOWSTATUS indicates that we should update the
534 checkdoc status window instead of the usual behavior."
540 ;; Due to a design flaw, this will never spell check
541 ;; docstrings.
544 ;; This is a workaround to perform spell checking.
547 ;;;###autoload
549 "Interactively check the current buffer for message string errors.
550 Prefix argument START-HERE will start the checking from the current
551 point, otherwise the check starts at the beginning of the current
552 buffer. Allows navigation forward and backwards through document
553 errors. Does not check for comment or space warnings.
554 Optional argument SHOWSTATUS indicates that we should update the
555 checkdoc status window instead of the usual behavior."
561 ;; Due to a design flaw, this will never spell check messages.
564 ;; This is a workaround to perform spell checking.
568 "Interactively loop over all errors that can be found by a given method.
570 If START-HERE is nil, searching starts at the beginning of the current
571 buffer, otherwise searching starts at START-HERE. SHOWSTATUS
572 expresses the verbosity of the search, and whether ending the search
573 will auto-exit this function.
575 FINDFUNC is a symbol representing a function that will position the
576 cursor, and return error message text to present to the user. It is
577 assumed that the cursor will stop just before a major sexp, which will
578 be highlighted to present the user with feedback as to the offending
579 style."
580 ;; Determine where to start the test
583 ;; Assign a flag to spellcheck flag
587 ;; Fetch the error list
591 c)
594 ;; Include whatever function point is in for good measure.
598 ;; The cursor should be just in front of the offending doc string
609 ;; Make sure the whole doc string is visible if possible.
633 ;; Exit condition
635 ;; Request an auto-fix
640 ;; `automatic-then-never' tells the autofix function
641 ;; to only allow one fix to be automatic. The autofix
642 ;; function will then set the flag to 'never, allowing
643 ;; the checker to return a different error.
665 ;; Move to the next error (if available)
671 err-list nil)
677 ;; Go backwards in the list of errors
686 ;; Edit the buffer recursively.
697 err-list nil)
701 ;; Quit checkdoc
704 err-list nil
706 ;; Goofy stuff
716 ""
718 "f, y - auto Fix this warning without asking (if\
721 )
733 returnme))
736 "Interactively spell check doc strings in the current buffer.
737 If START-HERE is nil, searching starts at the beginning of the current
738 buffer, otherwise searching starts at START-HERE."
741 ;; Move point to where we need to start.
743 ;; Include whatever function point is in for good measure.
746 ;; Loop over docstrings.
756 "Interactively spell check messages in the current buffer.
757 If START-HERE is nil, searching starts at the beginning of the current
758 buffer, otherwise searching starts at START-HERE."
761 ;; Move point to where we need to start.
763 ;; Include whatever function point is in for good measure.
766 ;; Loop over message strings.
777 "Find and return the next checkdoc error list, or nil.
778 Only documentation strings are checked.
779 An error list is of the form (WARNING . POSITION) where WARNING is the
780 warning text, and POSITION is the point in the buffer where the error
781 was found. We can use points and not markers because we promise not
782 to edit the buffer before point without re-executing this check.
783 Argument ENABLE-FIX will enable auto-fixing while looking for the next
784 error. This argument assumes that the cursor is already positioned to
785 perform the fix."
796 ;; Quit.. restore position, Other errors, leave alone
798 msg)))
801 "Find and return the next checkdoc message related error list, or nil.
802 Only text for error and `y-or-n-p' strings are checked. See
803 `checkdoc-next-error' for details on the return value.
804 Argument ENABLE-FIX turns on the auto-fix feature. This argument
805 assumes that the cursor is already positioned to perform the fix."
818 ;; Quit.. restore position, Other errors, leave alone
820 msg)))
823 "Enter recursive edit to permit a user to fix some error checkdoc has found.
824 MSG is the error that was found, which is displayed in a help buffer."
839 ;;;###autoload
841 "Evaluate and check documentation for the current buffer.
842 Evaluation is done first because good documentation for something that
843 doesn't work is just not useful. Comments, doc strings, and rogue
844 spacing are all verified."
849 ;;;###autoload
851 "Check current buffer for document, comment, error style, and rogue spaces.
852 With a prefix argument (in Lisp, the argument TAKE-NOTES),
853 store all errors found in a warnings buffer,
854 otherwise stop after the first error."
858 ;; Assign a flag to spellcheck flag
863 checkdoc-autofix-flag))
868 ;; every test is responsible for returning the cursor.
878 ;;;###autoload
880 "Start scanning the current buffer for documentation string style errors.
881 Only documentation strings are checked.
882 Use `checkdoc-continue' to continue checking if an error cannot be fixed.
883 Prefix argument TAKE-NOTES means to collect all the warning messages into
884 a separate buffer."
891 ;; Go back since we can't be here without success above.
893 nil))
895 ;;;###autoload
897 "Find the next doc string in the current buffer which has a style error.
898 Prefix argument TAKE-NOTES means to continue through the whole buffer and
899 save warnings in a separate buffer. Second optional argument START-POINT
900 is the starting location. If this is nil, `point-min' is used instead."
903 ;; Assign a flag to spellcheck flag
908 checkdoc-autofix-flag))
912 ;; If we are taking notes, encompass the whole buffer, otherwise
913 ;; the user is navigating down through the buffer.
915 ;; OK, let's look at the doc string.
928 "Move to the next doc string after point, and return t.
929 Return nil if there are no more doc strings."
931 nil
932 ;; search drops us after the identifier. The next sexp is either
933 ;; the argument list or the value of the variable. skip it.
936 t))
938 ;;;###autoload
940 "Find missing comment sections in the current Emacs Lisp file.
941 Prefix argument TAKE-NOTES non-nil means to save warnings in a
942 separate buffer. Otherwise print a message. This returns the error
943 if there is one."
957 e))
959 ;;;###autoload
961 "Find extra spaces at the end of lines in the current file.
962 Prefix argument TAKE-NOTES non-nil means to save warnings in a
963 separate buffer. Otherwise print a message. This returns the error
964 if there is one.
965 Optional argument INTERACT permits more interactive fixing."
973 e
979 ;;;###autoload
981 "Scan the buffer for occurrences of the error function, and verify text.
982 Optional argument TAKE-NOTES causes all errors to be logged."
991 e
999 ;;;###autoload
1001 "Evaluate the current form with `eval-defun' and check its documentation.
1002 Evaluation is done first so the form will be read before the
1003 documentation is checked. If there is a documentation error, then the display
1004 of what was evaluated will be overwritten by the diagnostic message."
1009 ;;;###autoload
1011 "Examine the doc string of the function or variable under point.
1012 Call `error' if the doc string has problems. If NO-ERROR is
1013 non-nil, then do not call error, but call `message' instead.
1014 If the doc string passes the test, then check the function for rogue white
1015 space at the end of each line."
1020 ;; I found this more annoying than useful.
1021 ;;(if (not no-error)
1022 ;; (message "Cannot check this sexp's doc string."))
1023 nil
1024 ;; search drops us after the identifier. The next sexp is either
1025 ;; the argument list or the value of the variable. skip it.
1049 ;;; Ispell interface for forcing a spell check
1050 ;;
1052 ;;;###autoload
1054 "Check the style and spelling of everything interactively.
1055 Calls `checkdoc' with spell-checking turned on.
1056 Prefix argument TAKE-NOTES is the same as for `checkdoc'"
1061 ;;;###autoload
1063 "Check the style and spelling of the current buffer.
1064 Calls `checkdoc-current-buffer' with spell-checking turned on.
1065 Prefix argument TAKE-NOTES is the same as for `checkdoc-current-buffer'"
1070 ;;;###autoload
1072 "Check the style and spelling of the current buffer interactively.
1073 Calls `checkdoc-interactive' with spell-checking turned on.
1074 Prefix argument TAKE-NOTES is the same as for `checkdoc-interactive'"
1079 ;;;###autoload
1081 "Check the style and spelling of message text interactively.
1082 Calls `checkdoc-message-interactive' with spell-checking turned on.
1083 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-interactive'"
1088 ;;;###autoload
1090 "Check the style and spelling of message text interactively.
1091 Calls `checkdoc-message-text' with spell-checking turned on.
1092 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-text'"
1097 ;;;###autoload
1099 "Check the style and spelling of the current buffer.
1100 Calls `checkdoc-start' with spell-checking turned on.
1101 Prefix argument TAKE-NOTES is the same as for `checkdoc-start'"
1106 ;;;###autoload
1108 "Check the style and spelling of the current buffer after point.
1109 Calls `checkdoc-continue' with spell-checking turned on.
1110 Prefix argument TAKE-NOTES is the same as for `checkdoc-continue'"
1115 ;;;###autoload
1117 "Check the style and spelling of the current buffer's comments.
1118 Calls `checkdoc-comments' with spell-checking turned on.
1119 Prefix argument TAKE-NOTES is the same as for `checkdoc-comments'"
1124 ;;;###autoload
1126 "Check the style and spelling of the current defun with Ispell.
1127 Calls `checkdoc-defun' with spell-checking turned on.
1128 Prefix argument TAKE-NOTES is the same as for `checkdoc-defun'"
1133 ;;; Error Management
1134 ;;
1135 ;; Errors returned from checkdoc functions can have various
1136 ;; features and behaviors, so we need some ways of specifying
1137 ;; them, and making them easier to use in the wacked-out interfaces
1138 ;; people are requesting
1140 "Used to create the return error text returned from all engines.
1141 TEXT is the descriptive text of the error. START and END define the region
1142 it is sensible to highlight when describing the problem.
1143 Optional argument UNFIXABLE means that the error has no auto-fix available.
1145 A list of the form (TEXT START END UNFIXABLE) is returned if we are not
1146 generating a buffered list of errors."
1149 nil)
1153 "Return the text specified in the checkdoc ERR."
1154 ;; string-p part is for backwards compatibility
1158 "Return the start point specified in the checkdoc ERR."
1159 ;; string-p part is for backwards compatibility
1163 "Return the end point specified in the checkdoc ERR."
1164 ;; string-p part is for backwards compatibility
1168 "Return the t if we cannot autofix the error specified in the checkdoc ERR."
1169 ;; string-p part is for backwards compatibility
1172 ;;; Minor Mode specification
1173 ;;
1178 ;; Override some bindings
1184 ;; Add some new bindings under C-c ?
1202 ;; bind our submap into map
1204 map)
1210 ;; Add in a menubar with easy-menu
1213 nil checkdoc-minor-mode-map "Checkdoc Minor Mode Menu"
1219 "---"
1228 checkdoc-ispell-message-interactive t]
1233 buffer-file-name]
1235 "---"
1240 ))
1241 ;; XEmacs requires some weird stuff to add this menu in a minor mode.
1242 ;; What is it?
1244 ;;;###autoload
1246 "Toggle Checkdoc minor mode, a mode for checking Lisp doc strings.
1247 With prefix ARG, turn Checkdoc minor mode on if ARG is positive, otherwise
1248 turn it off.
1250 In Checkdoc minor mode, the usual bindings for `eval-defun' which is
1251 bound to \\<checkdoc-minor-mode-map>\\[checkdoc-eval-defun] and `checkdoc-eval-current-buffer' are overridden to include
1252 checking of documentation strings.
1255 nil checkdoc-minor-mode-string nil
1258 ;;; Subst utils
1259 ;;
1261 "Run hooks in HOOKVAR with ARGS."
1264 ;; This method was similar to above. We ignore the warning
1265 ;; since we will use the above for future Emacs versions
1269 "Rebuild the contents of `checkdoc-common-verbs-regexp'."
1277 ;; Profiler says this is not yet faster than just calling assoc
1278 ;;(defun checkdoc-word-in-alist-vector (word vector)
1279 ;; "Check to see if WORD is in the car of an element of VECTOR.
1280 ;;VECTOR must be sorted. The CDR should be a replacement. Since the
1281 ;;word list is getting bigger, it is time for a quick bisecting search."
1282 ;; (let ((max (length vector)) (min 0) i
1283 ;; (found nil) (fw nil))
1284 ;; (setq i (/ max 2))
1285 ;; (while (and (not found) (/= min max))
1286 ;; (setq fw (car (aref vector i)))
1287 ;; (cond ((string= word fw) (setq found (cdr (aref vector i))))
1288 ;; ((string< word fw) (setq max i))
1289 ;; (t (setq min i)))
1290 ;; (setq i (/ (+ max min) 2))
1291 ;; )
1292 ;; found))
1294 ;;; Checking engines
1295 ;;
1297 "Return a message string if the current doc string is invalid.
1298 Check for style only, such as the first line always being a complete
1299 sentence, whitespace restrictions, and making sure there are no
1300 hard-coded key-codes such as C-[char] or mouse-[number] in the comment.
1301 See the style guide in the Emacs Lisp manual for more details."
1303 ;; Jump over comments between the last object and the doc string
1312 err
1313 ;; * Every command, function, or variable intended for users to know
1314 ;; about should have a documentation string.
1315 ;;
1316 ;; * An internal variable or subroutine of a Lisp program might as well
1317 ;; have a documentation string. In earlier Emacs versions, you could
1318 ;; save space by using a comment instead of a documentation string,
1319 ;; but that is no longer the case.
1324 ;; Sometimes old code has comments where the documentation should
1325 ;; be. Let's see if we can find the comment, and offer to turn it
1326 ;; into documentation for them.
1342 ;; Our point is at the beginning of the comment!
1343 ;; Insert a quote, then remove the comment chars.
1362 ;; quote any double-quote characters in the comment.
1368 "You should convert this comment to documentation"
1372 "All interactive functions should have documentation"
1373 "All variables and subroutines might as well have a \
1383 err)))
1386 "Return an error list or string if the current doc string is invalid.
1387 Depends on `checkdoc-this-string-valid' to reset the syntax table so that
1388 regexp short cuts work. FP is the function defun information."
1390 ;; Use a marker so if an early check modifies the text,
1391 ;; we won't accidentally loose our place. This could cause
1392 ;; end-of doc string whitespace to also delete the " char.
1398 ;; * *Do not* indent subsequent lines of a documentation string so that
1399 ;; the text is lined up in the source code with the text of the first
1400 ;; line. This looks nice in the source code, but looks bizarre when
1401 ;; users view the documentation. Remember that the indentation
1402 ;; before the starting double-quote is not part of the string!
1410 "Remove this whitespace? "
1412 nil
1414 "Second line should not have indentation"
1417 ;; * Check for '(' in column 0.
1422 "Escape this '('? "
1424 nil
1426 "Open parenthesis in column 0 should be escaped"
1428 ;; * Do not start or end a documentation string with whitespace.
1441 nil
1443 "Documentation strings should not start or end with whitespace"
1444 start end))))
1445 ;; * The first line of the documentation string should consist of one
1446 ;; or two complete sentences that stand on their own as a summary.
1447 ;; `M-x apropos' displays just the first line, and if it doesn't
1448 ;; stand on its own, the result looks bad. In particular, start the
1449 ;; first line with a capital letter and end with a period.
1457 ;; A backslashed double quote at the end of a sentence
1459 ;; We might have to add a period in this case
1462 nil
1467 nil
1469 "First sentence should end with punctuation"
1472 ;; These are ok
1473 nil)
1475 nil)
1477 ;; If it is not a complete sentence, let's see if we can
1478 ;; predict a clever way to make it one.
1483 ;; Here we have found a complete sentence, but no break.
1486 "First line not a complete sentence. Add RET here? "
1499 ;; We can merge these lines! Replace this CR
1500 ;; with a space.
1503 ;; Let's see if there is enough room to draw the next
1504 ;; line's sentence up here. I often get hit w/
1505 ;; auto-fill moving my words around.
1514 t)
1518 "1st line not a complete sentence. Join these lines? "
1521 ;; They said yes. We have more fill work to do...
1531 nil) ))))
1532 ;; Continuation of above. Make sure our sentence is capitalized.
1539 t)
1540 nil
1542 "First line should be capitalized"
1544 nil))
1545 ;; * Don't write key sequences directly in documentation strings.
1546 ;; Instead, use the `\\[...]' construct to stand for them.
1551 ;; Find the first key sequence not in a sample
1561 ;; It is not practical to use `\\[...]' very many times, because
1562 ;; display of the documentation string will become slow. So use this
1563 ;; to describe the most important commands in your major mode, and
1564 ;; then use `\\{...}' to display the rest of the mode's keymap.
1572 ;; Ambiguous quoted symbol. When a symbol is both bound and fbound,
1573 ;; and is referred to in documentation, it should be prefixed with
1574 ;; something to disambiguate it. This check must be before the
1575 ;; 80 column check because it will probably break that.
1593 ;; We didn't actually replace anything. Here we find
1594 ;; out what special word form they wish to use as
1595 ;; a prefix.
1598 "Disambiguating Keyword (default variable): "
1610 nil)))
1611 ;; * Format the documentation string so that it fits in an
1612 ;; Emacs window on an 80-column screen. It is a good idea
1613 ;; for most lines to be no wider than 60 characters. The
1614 ;; first line can be wider if necessary to fit the
1615 ;; information that ought to be there.
1624 eol t))
1630 "Some lines are over 80 columns wide"
1632 ;; Here we deviate to tests based on a variable or function.
1633 ;; We must do this before checking for symbols in quotes because there
1634 ;; is a chance that just such a symbol might really be an argument.
1636 ;; This is if we are in a variable
1638 ;; * The documentation string for a variable that is a
1639 ;; yes-or-no flag should start with words such as Non-nil
1640 ;; means..., to make it clear that all non-`nil' values are
1641 ;; equivalent and indicate explicitly what `nil' and non-`nil'
1642 ;; mean.
1643 ;; * If a user option variable records a true-or-false
1644 ;; condition, give it a name that ends in `-flag'.
1646 ;; If the variable has -flag in the name, make sure
1650 "Flag variable doc strings should usually start: Non-nil means"
1652 ;; Don't rename variable to "foo-flag". This is unnecessary
1653 ;; and such names often end up inconvenient when the variable
1654 ;; is later expanded to non-boolean values. --Stef
1655 ;; If the doc string starts with "Non-nil means"
1656 ;; (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
1657 ;; (not (string-match "-flag$" (car fp))))
1658 ;; (let ((newname
1659 ;; (if (string-match "-p$" (car fp))
1660 ;; (concat (substring (car fp) 0 -2) "-flag")
1661 ;; (concat (car fp) "-flag"))))
1662 ;; (if (checkdoc-y-or-n-p
1663 ;; (format
1664 ;; "Rename to %s and Query-Replace all occurrences? "
1665 ;; newname))
1666 ;; (progn
1667 ;; (beginning-of-defun)
1668 ;; (query-replace-regexp
1669 ;; (concat "\\<" (regexp-quote (car fp)) "\\>")
1670 ;; newname))
1671 ;; (checkdoc-create-error
1672 ;; "Flag variable names should normally end in `-flag'" s
1673 ;; (marker-position e)))))
1674 ;; Done with variables
1675 ))
1677 ;; This if we are in a function definition
1679 ;; * When a function's documentation string mentions the value
1680 ;; of an argument of the function, use the argument name in
1681 ;; capital letters as if it were a name for that value. Thus,
1682 ;; the documentation string of the function `/' refers to its
1683 ;; second argument as `DIVISOR', because the actual argument
1684 ;; name is `divisor'.
1686 ;; Addendum: Make sure they appear in the doc in the same
1687 ;; order that they are found in the arg list.
1697 inopts t)
1702 ;; Require whitespace OR
1703 ;; ITEMth<space> OR
1704 ;; ITEMs<space>
1706 e t)))
1709 ;; If the symbol was not found, let's see if we
1710 ;; can find it with a different capitalization
1711 ;; and see if the user wants to capitalize it.
1715 ;; Require whitespace OR
1716 ;; ITEMth<space> OR
1717 ;; ITEMs<space>
1719 e t))
1723 "If this is the argument `%s', it should appear as %s. Fix? "
1729 ;; It wasn't found at all! Offer to attach this new symbol
1730 ;; to the end of the documentation string.
1733 "Add %s documentation to end of doc string? "
1735 ;; Now do some magic and invent a doc string.
1746 nil)
1749 "Argument `%s' should appear (as %s) in the doc string"
1756 "Arguments occur in the doc string out of order"
1758 ;; * For consistency, phrase the verb in the first sentence of a
1759 ;; documentation string for functions as an imperative.
1760 ;; For instance, use `Return the cons of A and
1761 ;; B.' in preference to `Returns the cons of A and B.'
1762 ;; Usually it looks good to do likewise for the rest of the
1763 ;; first paragraph. Subsequent paragraphs usually look better
1764 ;; if they have proper subjects.
1765 ;;
1766 ;; This is the least important of the above tests. Make sure
1767 ;; it occurs last.
1770 ;; Maybe rebuild the monster-regexp
1774 ;; check string-continuation
1782 checkdoc-common-verbs-regexp
1783 lim t))
1787 checkdoc-common-verbs-wrong-voice))
1797 replace t)
1800 ;; there was a match, but no replace
1804 original replace)
1806 ;; Done with functions
1807 )))
1808 ;;* When a documentation string refers to a Lisp symbol, write it as
1809 ;; it would be printed (which usually means in lower case), with
1810 ;; single-quotes around it. For example: `lambda'. There are two
1811 ;; exceptions: write t and nil without single-quotes. (In this
1812 ;; manual, we normally do use single-quotes for those symbols.)
1818 e t))
1820 ;; A . is a \s_ char, so we must remove periods from
1821 ;; sentences more carefully.
1831 ms))
1839 ms))))))
1844 nil)))
1845 ;; t and nil case
1853 nil
1855 "Symbols t and nil should not appear in `...' quotes"
1857 ;; Here is some basic sentence formatting
1859 ;; Here are common proper nouns that should always appear capitalized.
1861 ;; Make sure the doc string has correctly spelled English words
1862 ;; in it. This function is extracted due to its complexity,
1863 ;; and reliance on the Ispell program.
1865 ;; User supplied checks
1867 ;; Done!
1868 )))
1871 "Return a list of details about the current sexp.
1872 It is a list of the form:
1873 (NAME VARIABLE INTERACTIVE NODOCPARAMS PARAMETERS ...)
1874 where NAME is the name, VARIABLE is t if this is a `defvar',
1875 INTERACTIVE is nil if this is not an interactive function, otherwise
1876 it is the position of the `interactive' call, and PARAMETERS is a
1877 string which is the name of each variable in the function's argument
1878 list. The NODOCPARAMS is a sublist of parameters specified by a checkdoc
1879 comment for a given defun. If the first element is not a string, then
1880 the token checkdoc-order: <TOKEN> exists, and TOKEN is a symbol read
1881 from the comment."
1897 ;; The variable spot
1899 ;; Interactive
1904 t)
1905 ret)))
1909 ;; Overload th main obarray so read doesn't intern the
1910 ;; local symbols of the function we are checking.
1911 ;; Without this we end up cluttering the symbol space w/
1912 ;; useless symbols.
1914 ;; Ok, check for checkdoc parameter comment here
1922 t)
1928 t)
1942 sl1)
1943 ret)))
1944 ;; Read the list of parameters, but do not put the symbols in
1945 ;; the standard obarray.
1947 ;; This is because read will intern nil if it doesn't into the
1948 ;; new obarray.
1957 "Return non-nil if the current point is in a code fragment.
1958 A code fragment is identified by an open parenthesis followed by a
1959 symbol which is a valid function or a word in all CAPS, or a parenthesis
1960 that is quoted with the ' character. Only the region from START to LIMIT
1961 is is allowed while searching for the bounding parenthesis."
1972 ;; if this string is function bound, we are in
1973 ;; sample code. If it has a - or : character in
1974 ;; the name, then it is probably supposed to be bound
1975 ;; but isn't yet.
1984 The text checked is between START and LIMIT."
1995 "Check all text between BEGIN and END for lower case proper nouns.
1996 These are Emacs centric proper nouns which should be capitalized for
1997 consistency. Return an error list if any are not fixed, but
1998 internally skip over no answers.
1999 If the offending word is in a piece of quoted text, then it is skipped."
2016 ;; surrounded by /, as in a URL or filename: /emacs/
2022 text)
2024 nil
2026 ;; If there is already an error, then generate
2027 ;; the warning output if applicable
2031 "Name %s should appear capitalized as %s"
2033 b e))
2036 "Name %s should appear capitalized as %s"
2038 bb b be e)))))))
2043 "Make sure all sentences have double spaces between BEGIN and END."
2063 ;; piece of an abbreviation
2068 b e
2069 "There should be two spaces after a period. Fix? "
2071 nil
2073 ;; If there is already an error, then generate
2074 ;; the warning output if applicable
2077 "There should be two spaces after a period"
2078 b e))
2080 "There should be two spaces after a period"
2081 bb b be e)))))))
2085 ;;; Ispell engine
2086 ;;
2090 "Initialize Ispell process (default version) with Lisp words.
2091 The words used are from `checkdoc-ispell-lisp-words'. If `ispell'
2092 cannot be loaded, then set `checkdoc-spellcheck-documentation-flag' to
2093 nil."
2099 ;; This code copied in part from ispell.el Emacs 19.34
2103 ;; Silence byte compiler
2110 "Run the Ispell tools on the doc string between point and END.
2111 Since Ispell isn't Lisp-smart, we must pre-process the doc string
2112 before using the Ispell engine on it."
2114 ;; If the user wants no questions or fixing, then we must
2115 ;; disable spell checking as not useful.
2118 nil
2125 ;; Skip lists describing meta-syntax, or bound variables
2133 ;; This is probably repetitive in most cases, but not always.
2134 nil
2135 ;; Find out how we spell-check this word.
2137 ;; All caps w/ option th, or s tacked on the end
2138 ;; for pluralization or numberthness.
2141 )
2142 nil
2151 ;; Nothing here.
2152 )))))
2154 err))))
2156 ;;; Rogue space checking engine
2157 ;;
2159 "Return a message list if there is a line with white space at the end.
2160 If `checkdoc-autofix-flag' permits, delete that whitespace instead.
2161 If optional arguments START and END are non-nil, bound the check to
2162 this region.
2163 Optional argument INTERACT may permit the user to fix problems on the fly."
2167 ;; If end is nil, it means end of buffer to search anyway
2169 ;; Check for an error if `? ' or `?\ ' is used at the end of a line.
2170 ;; (It's dangerous)
2175 "Don't use `? ' at the end of a line. \
2176 News agents may remove it"
2178 ;; If interactive is passed down, give them a chance to fix things.
2185 ;; Check for, and potentially remove whitespace appearing at the
2186 ;; end of different lines.
2189 ;; There is no documentation in the Emacs Lisp manual about this check,
2190 ;; it is intended to help clean up messy code and reduce the file size.
2192 ;; This is not a complex activity
2196 nil
2199 ;; Return an error and leave the cursor at that spot, or restore
2200 ;; the cursor.
2204 nil)))
2206 ;;; Comment checking engine
2207 ;;
2209 ;; We must load this to:
2210 ;; a) get symbols for compile and
2211 ;; b) determine if we have lm-history symbol which doesn't always exist
2215 "Return a message list if this file does not match the Emacs standard.
2216 This checks for style only, such as the first line, Commentary:,
2217 Code:, and others referenced in the style guide."
2219 nil
2221 ;; Old XEmacs don't have `lm-commentary-mark'
2230 ;; This file has been set up where ERR is a variable. Each check is
2231 ;; asked, and the function will make sure that if the user does not
2232 ;; auto-fix some error, that we still move on to the next auto-fix,
2233 ;; AND we remember the past errors.
2235 err
2236 ;; Lisp Maintenance checks first
2237 ;; Was: (lm-verify) -> not flexible enough for some people
2238 ;; * Summary at the beginning of the file:
2240 ;; This certifies as very complex so always ask unless
2241 ;; it's set to never
2250 nil))
2252 err
2254 ;; * Commentary Section
2261 nil t)
2274 nil nil t)))
2275 nil)
2276 err))
2278 err
2280 ;; * History section. Say nothing if there is a file ChangeLog
2286 nil
2292 nil t)
2304 err))
2306 err
2308 ;; * Code section
2319 nil)
2323 nil)
2324 err))
2326 err
2328 ;; * A footer. Not compartmentalized from lm-verify: too bad.
2329 ;; The following is partially clipped from lm-verify
2337 nil t))
2344 fn fn fe)
2346 err))
2347 ;; The below checks will not return errors if the user says NO
2349 ;; Let's spellcheck the commentary section. This is the only
2350 ;; section that is easy to pick out, and it is also the most
2351 ;; visible section (with the finder).
2357 ;; Since the comments talk about Lisp, use the
2358 ;; specialized spell-checker we also used for doc
2359 ;; strings.
2364 err
2366 ;; Generic Full-file checks (should be comment related)
2368 err))
2369 ;; Done with full file comment checks
2370 err)))
2373 "Return t if point is outside the bounds of a valid sexp."
2380 ;;; `error' and `message' text verifier.
2381 ;;
2383 "Search between BEG and END for a style error with message text.
2384 Optional arguments BEG and END represent the boundary of the check.
2385 The default boundary is the entire buffer."
2392 e))
2395 "Move cursor to the next checkable message string after point.
2396 Return the message classification.
2397 Argument END is the maximum bounds to search in."
2416 nil
2418 return))
2421 "Return or fix errors found in strings passed to a message display function.
2422 According to the documentation for the function `error', the error list
2423 should not end with a period, and should start with a capital letter.
2424 The function `y-or-n-p' has similar constraints.
2425 Argument TYPE specifies the type of question, such as `error or `y-or-n-p."
2426 ;; If type is nil, then attempt to derive it.
2438 ;; From the documentation of the symbol `error':
2439 ;; In Emacs, the convention is that error messages start with a capital
2440 ;; letter but *do not* end with a period. Please follow this convention
2441 ;; for the sake of consistency.
2446 "Capitalize your message text? "
2448 t)))
2450 "Messages should start with a capital letter"
2452 nil)
2453 ;; In general, sentences should have two spaces after the period.
2457 ;; Look for proper nouns in this region too.
2461 ;; Here are message type specific questions.
2468 "Remove period from error? "
2469 ""
2470 t)))
2472 "Error messages should *not* end with a period"
2474 nil)
2475 ;; `y-or-n-p' documentation explicitly says:
2476 ;; It should end in a space; `y-or-n-p' adds `(y or n) ' to it.
2477 ;; I added the ? requirement. Without it, it is unclear that we
2478 ;; ask a question and it appears to be an undocumented style.
2483 nil
2487 ;; If we see a ?, then replace with "? ".
2492 nil
2503 nil
2515 nil
2519 ;; Now, let's just run the spell checker on this guy.
2522 )))
2524 ;;; Auto-fix helper functions
2525 ;;
2527 "Like `y-or-n-p', but pays attention to `checkdoc-autofix-flag'.
2528 Argument QUESTION is the prompt passed to `y-or-n-p'."
2532 nil
2539 "Highlight between START and END and queries the user with QUESTION.
2540 If the user says yes, or if `checkdoc-autofix-flag' permits, replace
2541 the region marked by START and END with REPLACEWITH. If optional flag
2542 COMPLEX is non-nil, then we may ask the user a question. See the
2543 documentation for `checkdoc-autofix-flag' for details.
2545 If a section is auto-replaced without asking the user, this function
2546 will pause near the fixed code so the user will briefly see what
2547 happened.
2549 This function returns non-nil if the text was replaced.
2551 This function will not modify `match-data'."
2568 ;; On the off chance this is automatic, display
2569 ;; the question anyway so the user knows what's
2570 ;; going on.
2582 ret)))
2584 ;;; Warning management
2585 ;;
2599 "Set up the major mode for the buffer containing the list of errors."
2601 checkdoc-output-error-regex-alist)
2603 checkdoc-output-font-lock-keywords))
2606 "The name to use for a checkdoc buffer in the error list."
2612 "Initialize the checkdoc diagnostic buffer for a pass.
2613 Create the header so that the string CHECK-TYPE is displayed as the
2614 function called to create the messages."
2626 "Store POINT and MSG as errors in the checkdoc diagnostic buffer."
2638 "Display the checkdoc diagnostic buffer in a temporary window."
2649 nil)))
2662 ;; arch-tag: c49a7ec8-3bb7-46f2-bfbc-d5f26e033b26
2663 ;;; checkdoc.el ends here