1 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
3 * process.c (make_process): Initialize write_queue.
4 (write_queue_push, write_queue_pop): New functions.
5 (send_process): Use them to maintain correct ordering of process
8 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
10 * lisp.h (eassert): Assume C89 or later.
11 This removes the need for CHECK.
12 (CHECK): Remove. Its comments about always evaluating its
13 argument were confusing, as 'eassert' typically does not evaluate
16 * coding.c (produce_chars): Use ptrdiff_t, not int.
18 * xterm.c (x_draw_underwave): Check for integer overflow.
19 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
21 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
23 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
24 referenced (Bug#11583).
26 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
28 Implement wave-style variant of underlining.
29 * dispextern.h (face_underline_type): New enum.
30 (face): Add field for underline type.
31 * nsterm.m (ns_draw_underwave): New function.
32 (ns_draw_text_decoration): Use it.
33 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
35 (x_draw_glyph_string): Use them.
36 * xfaces.c (Qline, Qwave): New Lisp objects.
37 (check_lface_attrs, merge_face_ref)
38 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
39 wave-style underline face attributes.
40 * xterm.c (x_draw_underwave): New function.
41 (x_draw_glyph_string): Use it.
43 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
45 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
46 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
47 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
48 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
49 ($(BLD)/w32select.$(O)): Update dependencies.
51 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
53 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
54 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
55 * character.c (_fetch_multibyte_char_p): Remove.
56 * alloc.c: Include "character.h" before "buffer.h".
59 * bytecode.c: Likewise.
60 * callint.c: Likewise.
61 * callproc.c: Likewise.
62 * casefiddle.c: Likewise.
63 * casetab.c: Likewise.
64 * category.c: Likewise.
67 * composite.c: Likewise.
69 * dispnew.c: Likewise.
72 * editfns.c: Likewise.
75 * filelock.c: Likewise.
77 * fontset.c: Likewise.
81 * intervals.c: Likewise.
82 * keyboard.c: Likewise.
87 * minibuf.c: Likewise.
91 * process.c: Likewise.
93 * region-cache.c: Likewise.
97 * textprop.c: Likewise.
99 * unexsol.c: Likewise.
100 * w16select.c: Likewise.
101 * w32fns.c: Likewise.
102 * w32menu.c: Likewise.
103 * window.c: Likewise.
108 * xselect.c: Likewise.
110 2012-06-16 Eli Zaretskii <eliz@gnu.org>
112 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
113 all the glyphs of the glyph row came from strings, and we have no
114 cursor positioning clues, put the cursor on the first glyph of the
116 (handle_face_prop): Use chunk-relative overlay string index when
117 indexing into it->string_overlays array. (Bug#11653)
118 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
119 the rightmost. (Bug#11720)
121 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
123 * category.h (CHAR_HAS_CATEGORY): Define as inline.
124 (CATEGORY_MEMBER): Enforce 1/0 value.
125 * category.c (_temp_category_set): Remove.
127 2012-06-16 Eli Zaretskii <eliz@gnu.org>
129 * window.c (Fdelete_other_windows_internal)
130 (Fdelete_window_internal): Don't access frame's mouse highlight
131 info of the initial frame. (Bug#11677)
133 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
135 * .gdbinit (xgetint): Fix recently-introduced paren typo.
136 Assume USE_2_TAGS_FOR_INTS.
137 (xreload): Adjust $tagmask width to match recent lisp.h change.
139 Simplify lisp.h in minor ways that should not affect code.
140 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
141 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
142 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
143 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
144 (INTTYPEBITS): New macro, for clarity.
145 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
146 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
147 now that USE_LSB_TAG is always defined.
148 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
149 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
151 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
153 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
155 2012-06-13 Glenn Morris <rgm@gnu.org>
157 * s/bsd-common.h (BSD4_3):
158 * s/usg5-4-common.h (USG5_4): No longer define; unused.
160 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
162 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
165 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
167 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
168 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
169 * alloc.c (widen_to_Lisp_Object): Removed.
170 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
171 * frame.c (delete_frame): Remove outdated comment.
172 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
174 (Fw32_unregister_hot_key): Likewise.
175 (Fw32_toggle_lock_key): Likewise.
176 * w32menu.c (add_menu_item): Likewise.
177 (w32_menu_display_help): Use XIL instead of checking
179 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
180 (init_heap): Likewise.
181 * w32term.c (w32_read_socket): Update comment.
183 2012-06-13 Glenn Morris <rgm@gnu.org>
185 * s/usg5-4-common.h, src/s/unixware.h:
186 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
188 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
190 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
192 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
193 * alloc.c (make_number) [!defined make_number]:
194 Remove, as lisp.h always defines this now.
195 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
196 (roundup_size): Verify that it is a power of 2.
197 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
198 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
199 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
200 -DUSE_LSB_TAG=0, to override the automatically-selected default.
201 USE_LSB_TAG now is always defined to be either 0 or 1.
203 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
204 code works fine either way, and efficiency is not a concern here,
205 as the union type is for debugging, not for production.
206 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
207 Use an inline function on all platforms when using the union type,
208 since this is simpler and 'static inline' can be used portably
210 (LISP_INITIALLY_ZERO): New macro.
211 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
212 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
214 2012-06-12 Glenn Morris <rgm@gnu.org>
216 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
218 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
220 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
221 Move BROKEN_SIGIO to configure.
223 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
224 Move NO_TERMIO to configure.
226 2012-06-12 Chong Yidong <cyd@gnu.org>
228 * image.c (imagemagick_load_image): Use MagickFlattenImage if
229 MagickMergeImageLayers is undefined. Use pixel pusher loop if
230 MagickExportImagePixels is undefined.
232 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
234 * image.c (imagemagick_load_image): Remove unused label.
236 2012-06-11 Glenn Morris <rgm@gnu.org>
238 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
239 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
240 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
241 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
243 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
245 * alloc.c (make_byte_code): New function.
246 (Fmake_byte_code): Use it. Don't purify here.
247 * lread.c (read1): Use it as well to avoid extra allocation.
249 2012-06-11 Chong Yidong <cyd@gnu.org>
251 * image.c (imagemagick_load_image): Implement transparency.
253 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
255 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
256 account for preceding backslashes. (Bug#11663)
258 2012-06-09 Chong Yidong <cyd@gnu.org>
260 * term.c: Support italics in capable terminals (Bug#9652).
261 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
262 (turn_on_face): Output using TS_enter_italic_mode if available.
263 Don't handle unused blinking and alt-charset cases.
264 (turn_off_face): Handle italic case; discard unused tty_blinking_p
265 and tty_alt_charset_p cases.
266 (tty_capable_p, init_tty): Support italics.
268 * termchar.h (struct tty_display_info): Add field for italics.
269 Remove unused blink field.
271 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
274 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
275 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
276 tty_alt_charset_p. Add tty_italic_p.
278 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
280 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
281 dbus_type_is_basic if available.
282 (xd_extract_signed, xd_extract_unsigned): Rename from
283 extract_signed and extract_unsigned, respectively. Adapt callers.
285 2012-06-09 Chong Yidong <cyd@gnu.org>
287 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
289 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
292 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
294 * xdisp.c (vmessage): Treat frame message as multibyte.
295 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
296 would generate the diagnostic "Making \302\247 buffer-local while
299 2012-06-08 Eli Zaretskii <eliz@gnu.org>
301 * dispnew.c (showing_window_margins_p): Undo last change, which
302 was done due to an inadvertent commit.
303 (adjust_frame_glyphs_for_frame_redisplay): Do call
304 showing_window_margins_p.
306 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
308 * eval.c (Fmake_var_non_special): New primitive.
309 (syms_of_eval): Defsubr it.
310 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
312 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
314 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
315 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
317 2012-06-08 Eli Zaretskii <eliz@gnu.org>
319 * alloc.c (allocate_vectorlike): Fix last change.
321 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
323 Block-based vector allocation of small vectors.
324 * lisp.h (struct vectorlike_header): New field `nbytes',
325 adjust comment accordingly.
326 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
327 to denote vector blocks. Adjust users (live_vector_p,
328 mark_maybe_pointer, valid_lisp_object_p) accordingly.
329 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
330 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
331 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
332 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
333 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
334 (roundup_size): New constant.
335 (struct vector_block): New data type.
336 (vector_blocks, vector_free_lists, zero_vector): New variables.
337 (all_vectors): Rename to `large_vectors'.
338 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
339 (sweep_vectors): New functions.
340 (allocate_vectorlike): Return `zero_vector' as the only vector of
341 0 items. Allocate new vector from block if vector size is less than
342 or equal to VBLOCK_BYTES_MAX.
343 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
344 (init_alloc_once): Add call to init_vectors.
346 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
348 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
350 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
352 * doprnt.c (doprnt): Truncate multibyte char correctly.
353 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
354 would mishandle a string argument "Xc" if X was a multibyte
355 character of length 2: it would truncate after X's first byte
356 rather than including all of X.
358 2012-06-06 Chong Yidong <cyd@gnu.org>
360 * buffer.c (word_wrap): Doc fix.
362 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
364 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
366 2012-06-03 Glenn Morris <rgm@gnu.org>
368 * xdisp.c (tool-bar-style): Doc fix.
370 2012-06-03 Ulrich Müller <ulm@gentoo.org>
372 * Makefile.in (PAXCTL): Define.
373 (temacs$(EXEEXT)): Disable memory randomization for the temacs
374 binary via PaX flags if the paxctl utility is available.
375 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
376 Restore PaX flags to their default. (Bug#11398)
378 2012-06-03 Chong Yidong <cyd@gnu.org>
380 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
383 2012-06-03 Chong Yidong <cyd@gnu.org>
385 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
386 (note_mode_line_or_margin_highlight): If there is no help echo,
387 use mode-line-default-help-echo. Handle the case where the mouse
388 position is past the end of the mode line string.
390 * buffer.c (buffer_local_value_1): New function, split from
391 Fbuffer_local_value; can return Qunbound.
392 (Fbuffer_local_value): Use it.
393 (Vmode_line_format): Docstring tweaks.
395 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
397 * sysdep.c (system_process_attributes): Improve comment.
399 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
401 * keyboard.c: Export real-this-command to Elisp.
402 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
403 and DEFVAR it. Update all users.
405 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
407 * minibuf.c (Fassoc_string): Remove duplicate declaration.
409 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
410 Convert pctcpu and pctmem to Lisp float properly.
411 Let the compiler fold better, as 100.0/0x8000 is exact.
413 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
415 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
418 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
420 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
422 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
424 For a 'struct window', replace some Lisp_Object fields to
425 bitfields where appropriate, remove unused fields.
426 * window.h (struct window): Remove unused 'last_mark_x' and
427 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
428 change it's type from Lisp_Object to bitfield.
429 Change type of 'force_start', 'optional_new_start',
430 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
431 fields from Lisp_Object to bitfield. Adjust users accordingly.
433 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
435 Pacify gcc -Wdouble-precision when using Xaw.
436 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
437 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
438 Use 'float' consistently, rather than 'float' in most places
439 and 'double' in a couple of places.
441 2012-05-31 Eli Zaretskii <eliz@gnu.org>
443 * xdisp.c (handle_stop): Detect whether we have overlay strings
444 loaded by testing it->current.overlay_string_index to be
445 non-negative, instead of checking whether n_overlay_strings is
446 positive. (Bug#11587)
448 2012-05-31 Chong Yidong <cyd@gnu.org>
450 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
452 * doc.c (Fsubstitute_command_keys): Doc fix.
454 2012-05-31 Eli Zaretskii <eliz@gnu.org>
456 * search.c (search_buffer): Remove calls to
457 r_alloc_inhibit_buffer_relocation, as it is now called by
458 maybe_unify_char, which was the cause of relocation of buffer text
461 2012-05-31 Eli Zaretskii <eliz@gnu.org>
463 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
464 for the duration of call to load_charset, to avoid problems with
465 callers of maybe_unify_char that access buffer text through C
468 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
469 decrement the inhibition flag, instead of just setting or
472 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
474 Remove obsolete '#define static' cruft.
475 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
476 This #undef was "temporary" in 2000; it is no longer needed
477 now that '#define static' has gone away.
478 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
479 (gray_bitmap_bits): Remove; no longer needed.
480 All uses replaced with definiens.
481 * xterm.c: Include "bitmaps/gray.xbm".
483 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
485 Clean up __executable_start, monstartup when --enable-profiling.
486 The following changes affect the code only when profiling.
487 * dispnew.c (__executable_start): Rename from safe_bcopy.
488 Define only on platforms that need it.
489 * emacs.c: Include <sys/gmon.h> when profiling.
490 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
491 (__executable_start): Remove decl, since lisp.h does it now.
492 (safe_bcopy): Remove decl; no longer has that name.
493 (main): Coalesce #if into single bit of code, for simplicity.
494 Cast pointers to uintptr_t, since standard libraries want integers
496 * lisp.h (__executable_start): New decl.
498 2012-05-31 Glenn Morris <rgm@gnu.org>
500 * image.c (Fimagemagick_types): Doc fix.
502 2012-05-30 Jim Meyering <meyering@redhat.com>
504 * callproc.c (Fcall_process_region): Include directory component
505 in mkstemp error message (Bug#11586).
507 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
509 * alloc.c, lisp.h (make_pure_vector): Now static.
511 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
513 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
515 (Fautoload): Do the hash-doc more carefully.
516 * data.c (Fdefalias): Purify definition, except for keymaps.
517 (Qdefun): Move from eval.c.
518 * lisp.h (Qdefun): Remove.
519 * lread.c (read1): Tiny simplification.
521 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
523 Do not create empty overlays with the evaporate property (Bug#9642).
524 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
525 Bug#9642, but explicitly check that the buffer the overlay would
526 be moved to is live and rearrange lines to make sure that errors
527 will not put the overlay in an inconsistent state.
528 (Fdelete_overlay): Cosmetics.
530 2012-05-28 Eli Zaretskii <eliz@gnu.org>
532 * w32term.c (my_bring_window_to_top): New function.
533 (x_raise_frame): Use handle returned by DeferWindowPos, which
534 could be different from the original one.
535 Call my_bring_window_to_top instead of my_set_foreground_window.
538 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
539 by calling BringWindowToTop.
541 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
542 (WM_EMACS_END): Increase by one.
544 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
546 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
547 This avoids undefined behavior that might cause the eassert
548 to not catch an out-of-range value.
550 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
552 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
555 2012-05-27 Eli Zaretskii <eliz@gnu.org>
557 * bidi.c (bidi_mirror_char): Fix last change.
559 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
561 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
562 when referring to sectname field in printf format.
564 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
566 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
567 Only r_alloc_inhibit_buffer_relocation needed to be added;
568 the others were already declared.
570 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
571 before checking whether it's out of range. Put the check inside
573 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
575 2012-05-27 Ken Brown <kbrown@cornell.edu>
577 * callproc.c (Fcall_process): Restore a line that was accidentally
578 commented out in the 2011-02-13 change (bug#11547).
580 2012-05-27 Eli Zaretskii <eliz@gnu.org>
582 * lisp.h [REL_ALLOC]: Add prototypes for external functions
585 * buffer.c [REL_ALLOC]: Remove prototypes of
586 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
587 they are now on lisp.h.
589 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
591 * search.c (search_buffer): Use it to inhibit relocation of buffer
592 text while re_search_2 is doing its job, because re_search_2 is
593 passed C pointers to buffer text. (Bug#11519)
595 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
598 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
599 state after an additional call to move_it_in_display_line_to, keep
600 the values of it->max_ascent and it->max_descent found for the
602 (pos_visible_p): Revert the comparison against bottom_y to what it
603 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
606 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
608 Fix coding-related core dumps with gcc -ftrapv.
609 The code was computing A - B, where A and B are pointers, and B is
610 random garbage. This can lead to core dumps on platforms that
611 have special pointer registers, and it also leads to core dumps on
612 x86-64 when compiled with gcc -ftrapv. The fix is to compute
613 A - B only when B is initialized properly.
614 * coding.c (coding_set_source, coding_set_destination): Return void.
615 (coding_change_source, coding_change_destinations): New functions,
616 with the old behaviors of coding_set_source and coding_set_destination.
617 All callers that need an offset changed to use these new functions.
619 2012-05-26 Glenn Morris <rgm@gnu.org>
621 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
623 2012-05-26 Eli Zaretskii <eliz@gnu.org>
625 Extend mouse support on W32 text-mode console.
626 * xdisp.c (draw_row_with_mouse_face):
627 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
629 * w32console.c: Include window.h.
630 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
632 (initialize_w32_display): Initialize mouse-highlight data.
634 * w32inevt.c: Include termchar.h and window.h.
635 (do_mouse_event): Support mouse-autoselect-window. When the mouse
636 moves, call note_mouse_highlight. If help_echo changed, call
637 gen_help_event to produce help-echo message in the echo area.
638 Call clear_mouse_face if mouse_face_hidden is set in the mouse
641 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
643 * lread.c (read1): Simplify slightly to avoid an overflow warning
644 with GCC 4.7.0 on x86-64.
646 2012-05-26 Eli Zaretskii <eliz@gnu.org>
648 * bidi.c (bidi_mirror_char): Revert last change: an int is
649 definitely wide enough here.
651 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
653 Fix integer width and related bugs (Bug#9874).
654 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
655 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
656 (string_bytes, check_sblock, allocate_string_data):
657 (compact_small_strings, Fmake_bool_vector, make_string)
658 (make_unibyte_string, make_multibyte_string)
659 (make_string_from_bytes, make_specified_string)
660 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
661 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (allocate_pseudovector):
665 Use int, not EMACS_INT, where int is wide enough.
666 (inhibit_garbage_collection, Fgarbage_collect):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
669 int might not be wide enough.
670 (bidi_cache_search, bidi_cache_find, bidi_init_it)
671 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
672 (bidi_at_paragraph_end, bidi_find_paragraph_start)
673 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
674 (bidi_level_of_next_char, bidi_move_to_visually_next):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
677 (Fkill_buffer, Fset_buffer_major_mode)
678 (advance_to_char_boundary, Fbuffer_swap_text)
679 (Fset_buffer_multibyte, overlays_at, overlays_in)
680 (overlay_touches_p, struct sortvec, record_overlay_string)
681 (overlay_strings, recenter_overlay_lists)
682 (adjust_overlays_for_insert, adjust_overlays_for_delete)
683 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
684 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
685 (Foverlay_recenter, last_overlay_modification_hooks_used)
686 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 (validate_region): Omit unnecessary test for b <= e,
689 since that's guaranteed by the previous test.
690 (adjust_overlays_for_delete): Avoid pos + length overflow.
691 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
692 (report_overlay_modification):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
695 Omit pointer cast, which isn't needed anyway, and doesn't work
696 after the EMACS_INT -> ptrdiff_t change.
697 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
698 * buffer.h: Adjust decls to match defn changes elsewhere.
699 (struct buffer_text, struct buffer):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 Use EMACS_INT, not int, where int might not be wide enough.
702 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
703 not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (exec_byte_code): Use tighter memory-full test, one that checks
705 for alloca overflow. Don't compute the address of the object just
706 before an array, as that's not portable. Use EMACS_INT, not
707 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
708 * callint.c (Fcall_interactively):
709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
710 * callproc.c (call_process_kill, Fcall_process):
711 Don't assume pid_t fits into an Emacs fixnum.
712 (call_process_cleanup, Fcall_process, child_setup):
713 Don't assume pid_t fits into int.
714 (call_process_cleanup, Fcall_process, delete_temp_file)
715 (Fcall_process_region):
716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
717 (Fcall_process): Simplify handling of volatile integers.
718 Use int, not EMACS_INT, where int will do.
719 * casefiddle.c (casify_object, casify_region, operate_on_word)
720 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (casify_object): Avoid integer overflow when overallocating buffer.
723 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
724 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
725 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
726 * category.h (CATEGORYP): Don't assume arg is nonnegative.
727 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
728 integers are now checked earlier. All uses replaced with XINT.
730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
731 For CCL_MapSingle, check that content and value are in int range.
732 (ccl_driver, Fregister_code_conversion_map):
733 Check that Vcode_version_map_vector is a vector.
734 (resolve_symbol_ccl_program): Check that vector header is in range.
735 Always copy the vector, so that we can check its contents reliably
736 now rather than having to recheck each instruction as it's being
737 executed. Check that vector words fit in 'int'.
738 (ccl_get_compiled_code, Fregister_ccl_program)
739 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
740 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
741 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
742 contents are in range.
743 (Fccl_execute_on_string): Check that status is in range.
744 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
745 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
746 Accept and return EMACS_INT, not int, because callers can pass values
748 (c_string_width, strwidth, lisp_string_width, chars_in_text)
749 (multibyte_chars_in_text, parse_str_as_multibyte)
750 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
751 (str_as_unibyte, str_to_unibyte, string_count_byte8)
752 (string_escape_byte8, Fget_byte):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
755 avoid mishandling large integers.
756 * character.h: Adjust decls to match defn changes elsewhere.
757 * charset.c (load_charset_map_from_file, find_charsets_in_text)
758 (Ffind_charset_region):
759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
760 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
761 (load_charset_map_from_vector, Fdefine_charset_internal):
762 Don't assume fixnum fits in int.
763 (load_charset_map_from_vector, Fmap_charset_chars):
764 Remove now-unnecessary CHECK_NATNUMs.
765 (Fdefine_charset_internal): Check ranges here, more carefully.
766 Don't rely on undefined behavior with signed left shift overflow.
767 Don't assume unsigned int fits into fixnum, or that fixnum fits
768 into unsigned int. Don't require max_code to be a valid fixnum;
769 that's not true for gb10830 4-byte on a 32-bit host. Allow
770 invalid_code to be a cons, for the same reason. Require code_offset
771 to be a character. Avoid int overflow if max_char is close
773 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
774 this is intended anyway and avoids some undefined behavior.
775 (load_charset_map): Pass unsigned, not int, as 2nd arg of
776 INDEX_TO_CODE_POINT, as that's what it expects.
777 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
778 * charset.h (DECODE_CHAR): Return int, not unsigned;
779 this is what was intended anyway, and it avoids undefined behavior.
780 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
781 integer-overflow issues.
782 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
783 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
784 where the argument is EMACS_INT, and this behavior is not intended.
785 * chartab.c (Fmake_char_table, Fset_char_table_range)
786 (uniprop_get_decoder, uniprop_get_encoder):
787 Don't assume fixnum fits in int.
788 * cmds.c (move_point): New function, that does the gist of
789 Fforward_char and Fbackward_char, but does so while checking
790 for integer overflow more accurately.
791 (Fforward_char, Fbackward_char): Use it.
792 (Fforward_line, Fend_of_line, internal_self_insert)
793 (internal_self_insert):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 Fix a FIXME, by checking for integer overflow when calculating
796 target_clm and actual_clm.
797 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
798 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
799 (ASSURE_DESTINATION, coding_alloc_by_realloc)
800 (coding_alloc_by_making_gap, alloc_destination)
801 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
802 (encode_coding_utf_16, detect_coding_emacs_mule)
803 (decode_coding_emacs_mule, encode_coding_emacs_mule)
804 (detect_coding_iso_2022, decode_coding_iso_2022)
805 (encode_invocation_designation, encode_designation_at_bol)
806 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
807 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
808 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
809 (encode_coding_ccl, encode_coding_raw_text)
810 (detect_coding_charset, decode_coding_charset)
811 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
812 (produce_composition, produce_charset, produce_annotation)
813 (decode_coding, handle_composition_annotation)
814 (handle_charset_annotation, consume_chars, decode_coding_gap)
815 (decode_coding_object, encode_coding_object, detect_coding_system)
816 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
817 (code_convert_region, code_convert_string)
818 (Fdefine_coding_system_internal)
819 (coding_set_source, coding_set_destination):
820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
821 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
822 (Fdefine_coding_system_internal):
823 Don't assume fixnums fit in int.
824 (decode_coding_gap, decode_coding_object, encode_coding_object)
825 (Fread_coding_system, Fdetect_coding_region)
826 (Funencodable_char_position, Fcheck_coding_systems_region)
827 (get_translation, handle_composition_annotation, consume_chars):
828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
829 (consume_chars): Rewrite to not calculate an address outside buffer.
830 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
831 Don't access memory outside of the args array.
832 (Fdefine_coding_system_internal): Check for charset-id overflow.
833 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
834 result of ENCODE_CHAR.
835 * coding.h: Adjust decls to match defn changes elsewhere.
836 (struct coding_system):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 * composite.c (get_composition_id, find_composition)
839 (run_composition_function, update_compositions)
840 (compose_text, composition_gstring_put_cache)
841 (composition_gstring_p, composition_gstring_width)
842 (fill_gstring_header, fill_gstring_body, autocmp_chars)
843 (composition_compute_stop_pos, composition_reseat_it)
844 (composition_update_it, struct position_record)
845 (find_automatic_composition, composition_adjust_point)
846 (Fcomposition_get_gstring, Ffind_composition_internal):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (update_compositions):
849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
850 * composite.h: Adjust decls to match defn changes elsewhere.
851 (struct composition):
852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
853 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
854 Do not attempt to compute the address of the object just before a
855 buffer; this is not portable.
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 (Faset): Use int, not EMACS_INT, where int is wide enough.
859 (Fstring_to_number): Don't assume fixnums fit in int.
860 (Frem): Don't assume arg is nonnegative.
861 * dbusbind.c (xd_append_arg): Check for integers out of range.
862 (Fdbus_call_method): Don't overflow the timeout int.
863 (extract_signed, extract_unsigned): New functions.
864 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
865 (xd_get_connection_references): Return ptrdiff_t, not int.
867 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
869 Use int, not unsigned, where the dbus API uses int.
870 (Fdbus_message_internal): Don't overflow mtype.
871 (syms_of_dbusbind): Allocate right-sized buffer for integers.
872 * dired.c (directory_files_internal, file_name_completion, scmp)
873 (file_name_completion_stat):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (file_name_completion): Don't overflow matchcount.
876 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
877 * dispextern.h: Adjust decls to match defn changes elsewhere.
878 (struct text_pos, struct glyph, struct bidi_saved_info)
879 (struct bidi_string_data, struct bidi_it, struct composition_it)
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (struct display_pos, struct composition_it, struct it):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 * dispnew.c (increment_matrix_positions)
885 (increment_row_positions, mode_line_string)
886 (marginal_area_string):
887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
888 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
890 (duration_to_sec_usec): New function, to check for overflow better.
891 (Fsleep_for, sit_for): Use it.
892 * doc.c (get_doc_string, store_function_docstring):
893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
894 (get_doc_string, Fsnarf_documentation):
895 Use int, not EMACS_INT, where int is wide enough.
897 Use SAFE_ALLOCA, not alloca.
898 Check for overflow when converting EMACS_INT to off_t.
900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
901 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
902 Don't assume uid_t fits into fixnum.
903 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
904 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
905 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
906 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
907 (general_insert_function)
908 (Finsert_char, make_buffer_string, make_buffer_string_both)
909 (update_buffer_properties, Fbuffer_substring)
910 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
911 (Fsubst_char_in_region, check_translation)
912 (Ftranslate_region_internal, save_restriction_restore, Fformat)
913 (transpose_markers, Ftranspose_regions):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 (clip_to_bounds): Move to lisp.h as an inline function).
916 (Fconstrain_to_field): Don't assume integers are nonnegative.
917 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
918 (Fsubst_char_in_region, Fsave_restriction):
919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
920 (Femacs_pid): Don't assume pid_t fits into fixnum.
921 (lo_time): Use int, not EMACS_INT, when int suffices.
922 (lisp_time_argument): Check for usec out of range.
923 (Fencode_time): Don't assume fixnum fits in int.
924 (Fuser_login_name, Fuser_full_name): Signal an error
925 if a uid argument is out of range, rather than relying on
927 (Fformat_time_string): Remove now-unnecessary check.
928 lisp_time_argument checks for out-of-range usec now.
929 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
930 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
931 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
932 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
933 (init_cmdargs, Fdump_emacs):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
936 the bottom (typically) 32 bits of the fixnum.
937 * eval.c (specpdl_size, call_debugger):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 (when_entered_debugger, Fbacktrace_debug):
940 Don't assume fixnum can fit in int.
941 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
942 the object just before a buffer; this is not portable.
943 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
944 (grow_specpdl, unbind_to):
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
947 (grow_specpdl): Simplify allocation by using xpalloc.
948 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
949 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
950 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
952 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
955 (Fcopy_file, non_regular_nbytes, read_non_regular)
956 (Finsert_file_contents):
957 Use int, not EMACS_INT, where int is wide enough.
958 (READ_BUF_SIZE): Verify that it fits in int.
959 (Finsert_file_contents): Check that counts are in proper range,
960 rather than assuming fixnums fit into ptrdiff_t etc.
961 Don't assume fixnums fit into int.
962 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
963 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
964 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
965 (string_char_to_byte, string_byte_to_char)
966 (string_make_multibyte, string_to_multibyte)
967 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
968 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
969 (substring_both, Fdelete, internal_equal, Ffillarray)
970 (Fclear_string, mapcar1)
971 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
972 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
973 (larger_vector, make_hash_table, maybe_resize_hash_table)
974 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
975 (Fmaphash, secure_hash):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (concat): Check for string index and length overflow.
978 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (larger_vector): New API (vec, incr_min, size_max) replaces old
982 one (vec, new_size, init). This catches size overflow.
983 INIT was removed because it was always Qnil.
985 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
986 the upper bound on a hash table index size.
987 (make_hash_table, maybe_resize_hash_table): Use it.
988 (secure_hash): Computer start_byte and end_byte only after
989 they're known to be in ptrdiff_t range.
990 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
991 (Ffont_get_glyphs, Ffont_at):
992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
993 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
994 (Flist_fonts, Fopen_font):
995 Don't assume fixnum can fit in int.
996 (check_gstring): Don't assume index can fit in int.
997 (font_match_p): Check that fixnum is a character, not a nonnegative
998 fixnum, since the later code needs to stuff it into an int.
999 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1000 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1001 conversion overflow issues.
1002 (Fopen_font): Check for integer out of range.
1003 (Ffont_get_glyphs): Don't assume index can fit in int.
1004 * font.h: Adjust decls to match defn changes elsewhere.
1005 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1007 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1008 printmax_t, where ptrdiff_t is wide enough.
1009 (Finternal_char_font):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1012 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1013 (Fset_frame_position, x_set_frame_parameters)
1014 (x_set_line_spacing, x_set_border_width)
1015 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1016 Check that fixnums are in proper range for system types.
1017 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1019 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1020 Use SAFE_ALLOCA_LISP, not alloca.
1021 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1022 intptr_t is wide enough.
1023 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1024 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1025 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1026 Check for fixnum out of range.
1027 * ftfont.c (ftfont_list): Don't assume index fits in int.
1028 Check that fixnums are in proper range for system types.
1029 (ftfont_shape_by_flt):
1030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1031 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1033 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1034 Check that fixnums are in proper range for system types.
1035 * gnutls.h: Adjust decls to match defn changes elsewhere.
1036 * gtkutil.c (xg_dialog_run):
1037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1038 (update_frame_tool_bar):
1039 Check that fixnums are in proper range for system types.
1040 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1041 (lookup_image): Check that fixnums are in range for system types.
1042 * indent.c (last_known_column, last_known_column_point):
1043 (current_column_bol_cache):
1044 (skip_invisible, current_column, check_display_width):
1045 (check_display_width, scan_for_column, current_column_1)
1046 (Findent_to, Fcurrent_indentation, position_indentation)
1047 (indented_beyond_p, Fmove_to_column, compute_motion):
1048 (Fcompute_motion, Fvertical_motion):
1049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1050 (last_known_column_modified): Use EMACS_INT, not int.
1051 (check_display_width):
1053 Check that fixnums and floats are in proper range for system types.
1054 (compute_motion): Don't assume index or fixnum fits in int.
1055 (compute_motion, Fcompute_motion):
1056 Use int, not EMACS_INT, when it is wide enough.
1057 (vmotion): Omit local var start_hpos that is always 0; that way
1058 we don't need to worry about overflow in expressions involving it.
1059 * indent.h: Adjust decls to match defn changes elsewhere.
1061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1062 Use int, not EMACS_INT, where int is wide enough.
1063 Remove unused members ovstring_chars_done and tab_offset;
1065 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1066 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1067 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1068 (make_gap, copy_text, insert, insert_and_inherit)
1069 (insert_before_markers, insert_before_markers_and_inherit)
1070 (insert_1, count_combining_before, count_combining_after)
1071 (insert_1_both, insert_from_string)
1072 (insert_from_string_before_markers, insert_from_string_1)
1073 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1074 (adjust_after_replace, adjust_after_insert, replace_range)
1075 (replace_range_2, del_range, del_range_1, del_range_byte)
1076 (del_range_both, del_range_2, modify_region)
1077 (prepare_to_modify_buffer, signal_before_change)
1078 (signal_after_change, Fcombine_after_change_execute):
1079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1080 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1081 (balance_an_interval, split_interval_right, split_interval_left)
1082 (find_interval, next_interval, update_interval)
1083 (adjust_intervals_for_insertion, delete_node, delete_interval)
1084 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1085 (static_offset_intervals, offset_intervals)
1086 (merge_interval_right, merge_interval_left, make_new_interval)
1087 (graft_intervals_into_buffer, temp_set_point_both)
1088 (temp_set_point, set_point, adjust_for_invis_intang)
1089 (set_point_both, move_if_not_intangible, get_property_and_range)
1090 (get_local_map, copy_intervals, copy_intervals_to_string)
1091 (compare_string_intervals, set_intervals_multibyte_1):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1093 * intervals.h: Adjust decls to match defn changes elsewhere.
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 * keyboard.c (this_command_key_count, this_single_command_key_start)
1097 (before_command_key_count, before_command_echo_length, echo_now)
1098 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1099 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1100 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1101 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1103 (last_non_minibuf_size, last_point_position, echo_truncate)
1104 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1105 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1106 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1107 (stuff_buffered_input):
1108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1109 (last_auto_save, command_loop_1, read_char):
1110 Use EMACS_INT, not int, to avoid integer overflow.
1111 (record_char): Avoid overflow in total_keys computation.
1112 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1113 * keyboard.h: Adjust decls to match defn changes elsewhere.
1114 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1115 (Fkey_description, Fdescribe_vector, Flookup_key):
1116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1117 (click_position): New function, to check that positions are in range.
1118 (Fcurrent_active_maps):
1120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1121 (Faccessible_keymaps, Fkey_description):
1122 (preferred_sequence_p):
1123 Don't assume fixnum can fit into int.
1124 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1125 Check for integer overflow in size calculations.
1126 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1127 avoid mishandling large integers.
1128 * lisp.h: Adjust decls to match defn changes elsewhere.
1129 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1130 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1131 (struct Lisp_Marker):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1134 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1135 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1136 All callers changed.
1137 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1138 Assume the arg has valid form, since it always does.
1139 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1140 unsigned integer system type.
1141 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1142 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1145 (duration_to_sec_usec): New decl.
1146 * lread.c (read_from_string_index, read_from_string_index_byte)
1147 (read_from_string_limit, readchar, unreadchar, openp)
1148 (read_internal_start, read1, oblookup):
1149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1150 (Fload, readevalloop, Feval_buffer, Feval_region):
1151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1152 (openp): Check for out-of-range argument to 'access'.
1153 (read1): Use int, not EMACS_INT, where int is wide enough.
1154 Don't assume fixnum fits into int.
1155 Fix off-by-one error that can read outside a buffer.
1156 (read_filtered_event): Use duration_to_sec_usec
1157 to do proper overflow checking on durations.
1158 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1159 in size calculation.
1160 (Fexecute_kbd_macro):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1163 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1164 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1165 (set_marker_both, set_marker_restricted_both, marker_position)
1166 (marker_byte_position, Fbuffer_has_markers_at):
1167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1168 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1169 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1170 It now merely ensures that the menu is large enough, without
1171 necessarily growing it, as this avoids some integer overflow issues.
1172 All callers changed.
1173 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1176 Use SAFE_ALLOCA_LISP, not alloca.
1177 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1178 to EMACS_INT. Check that fixnums are in proper range for system types.
1179 * minibuf.c (minibuf_prompt_width, string_to_object)
1180 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1181 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1183 (get_minibuffer, read_minibuf_unwind):
1184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1185 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1186 this simplifies overflow checking. All callers changed.
1187 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1191 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1192 Check that fixnums are in proper range for system types.
1193 (Fx_create_frame, Fx_show_tip):
1194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1195 * nsfont.m (ns_findfonts, nsfont_list_family):
1196 Don't assume fixnum fits in long.
1197 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1199 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1201 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1203 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1204 (PRINTDECLARE, PRINTPREPARE):
1205 (strout, print_string):
1206 (print, print_preprocess, print_check_string_charset_prop)
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1210 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1212 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1213 (printchar, strout): Use xpalloc to catch size calculation overflow.
1214 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1215 (print_error_message): Use SAFE_ALLOCA, not alloca.
1216 (print_object): Use int, not EMACS_INT, where int is wide enough.
1217 (print_depth, new_backquote_output, print_number_index):
1218 Use ptrdiff_t, not int, where int might not be wide enough.
1219 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1220 (Fset_process_window_size, Fformat_network_address)
1221 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1223 Check that fixnums are in proper range for system types.
1224 (Fsignal_process): Simplify by avoiding a goto.
1225 Check for process-ids out of pid_t range rather than relying on
1227 (process_tick, update_tick): Use EMACS_INT, not int.
1228 (Fformat_network_address, read_process_output, send_process)
1229 (Fprocess_send_region, status_notify):
1230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1231 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1232 (wait_reading_process_output, read_process_output, exec_sentinel):
1233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1234 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1235 (Faccept_process_output): Use duration_to_sec_usec to do proper
1236 overflow checking on durations.
1237 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1238 Don't assume pid_t fits in int.
1239 * process.h (struct Lisp_Process): Members tick and update_tick
1240 are now of type EMACS_INT, not int.
1241 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1242 configured --with-wide-int.
1243 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1244 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1245 * search.c (looking_at_1, string_match_1):
1246 (fast_string_match, fast_c_string_match_ignore_case)
1247 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1248 (scan_newline, find_before_next_newline, search_command)
1249 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1250 (set_search_regs, wordify):
1253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1254 (string_match_1, search_buffer, set_search_regs):
1256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1257 (wordify): Check for overflow in size calculation.
1258 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1259 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1260 Check that fixnums are in proper range for system types.
1261 * sound.c (struct sound_device)
1262 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 (Fplay_sound_internal):
1265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1266 * syntax.c (struct lisp_parse_state, find_start_modiff)
1267 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1268 (Fparse_partial_sexp):
1269 Don't assume fixnums can fit in int.
1270 (struct lisp_parse_state, find_start_pos, find_start_value)
1271 (find_start_value_byte, find_start_begv)
1272 (update_syntax_table, char_quoted, dec_bytepos)
1273 (find_defun_start, prev_char_comend_first, back_comment):
1274 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1275 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1277 (Finternal_describe_syntax_value): Check that match_lisp is a
1278 character, not an integer, since the code stuffs it into int.
1279 (scan_words, scan_sexps_forward):
1280 Check that fixnums are in proper range for system types.
1282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1283 (scan_sexps_forward):
1284 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1285 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1286 * syntax.h: Adjust decls to match defn changes elsewhere.
1287 (struct gl_state_s):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1290 MOST_POSITIVE_FIXNUM.
1291 * sysdep.c (wait_for_termination_1, wait_for_termination)
1292 (interruptible_wait_for_termination, mkdir):
1293 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1294 (emacs_read, emacs_write):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1296 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1297 and double all fit in int.
1298 * term.c (set_tty_color_mode):
1299 Check that fixnums are in proper range for system types.
1300 * termhooks.h (struct input_event):
1301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1302 * textprop.c (validate_interval_range, interval_of)
1303 (Fadd_text_properties, set_text_properties_1)
1304 (Fremove_text_properties, Fremove_list_of_text_properties)
1305 (Ftext_property_any, Ftext_property_not_all)
1306 (copy_text_properties, text_property_list, extend_property_ranges)
1307 (verify_interval_modification):
1308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1309 (Fnext_single_char_property_change)
1310 (Fprevious_single_char_property_change):
1311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1312 (copy_text_properties):
1313 Check for integer overflow in index calculation.
1314 * undo.c (last_boundary_position, record_point, record_insert)
1315 (record_delete, record_marker_adjustment, record_change)
1316 (record_property_change):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1321 (Fx_hide_tip, Fx_file_dialog):
1322 * w32menu.c (set_frame_menubar):
1323 Use ptrdiff_t, not int, for consistency with rest of code.
1324 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1325 (select_window, Fdelete_other_windows_internal)
1326 (window_scroll_pixel_based, window_scroll_line_based)
1327 (Frecenter, Fset_window_configuration):
1328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1329 (Fset_window_hscroll, run_window_configuration_change_hook)
1330 (set_window_buffer, temp_output_buffer_show, scroll_command)
1331 (Fscroll_other_window, Frecenter):
1332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1333 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1334 Don't assume fixnum fits in int.
1335 (Fset_window_scroll_bars):
1336 Check that fixnums are in proper range for system types.
1337 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1338 (string_pos, c_string_pos, number_of_chars, init_iterator)
1339 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1340 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1341 (compute_display_string_end, handle_face_prop)
1342 (face_before_or_after_it_pos, handle_invisible_prop)
1343 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1344 (display_prop_intangible_p, string_buffer_position_lim)
1345 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1346 (get_overlay_strings_1, get_overlay_strings)
1347 (iterate_out_of_display_property, forward_to_next_line_start)
1348 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1349 (get_next_display_element, set_iterator_to_next)
1350 (get_visually_first_element, compute_stop_pos_backwards)
1351 (handle_stop_backwards, next_element_from_buffer)
1352 (move_it_in_display_line_to, move_it_in_display_line)
1353 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1354 (add_to_log, message_dolog, message_log_check_duplicate)
1355 (message2, message2_nolog, message3, message3_nolog
1356 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1357 (current_message_1, truncate_echo_area, truncate_message_1)
1358 (set_message, set_message_1, store_mode_line_noprop)
1359 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1360 (text_outside_line_unchanged_p, check_point_in_composition)
1361 (reconsider_clip_changes)
1362 (redisplay_internal, set_cursor_from_row, try_scrolling)
1363 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1364 (redisplay_window, find_last_unchanged_at_beg_row)
1365 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1366 (trailing_whitespace_p, find_row_edges, display_line)
1367 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1368 (display_mode_element, store_mode_line_string)
1369 (pint2str, pint2hrstr, decode_mode_spec)
1370 (display_count_lines, display_string, draw_glyphs)
1371 (x_produce_glyphs, x_insert_glyphs)
1372 (rows_from_pos_range, mouse_face_from_buffer_pos)
1373 (fast_find_string_pos, mouse_face_from_string_pos)
1374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 (safe_call, init_from_display_pos, handle_fontified_prop)
1377 (handle_single_display_spec, load_overlay_strings)
1378 (with_echo_area_buffer, setup_echo_area_for_printing)
1379 (display_echo_area, echo_area_display)
1380 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1381 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1382 (redisplay_window, dump_glyph_row, display_mode_line)
1383 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1384 (handle_display_spec, display_prop_string_p):
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (handle_single_display_spec, build_desired_tool_bar_string)
1387 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1388 (get_specified_cursor_type):
1389 Check that fixnums are in proper range for system types.
1390 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1391 (Flookup_image_map):
1392 Don't assume fixnums fit in int.
1393 (compare_overlay_entries):
1394 Avoid mishandling comparisons due to subtraction overflow.
1395 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1396 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1397 (handle_tool_bar_click):
1398 Use int, not unsigned, since we prefer signed and the signedness
1399 doesn't matter here.
1400 (get_next_display_element, next_element_from_display_vector):
1401 Use int, not EMACS_INT, when int is wide enough.
1402 (start_hourglass): Use duration_to_sec_usec to do proper
1403 overflow checking on durations.
1404 * xfaces.c (Fbitmap_spec_p):
1405 Check that fixnums are in proper range for system types.
1406 (compare_fonts_by_sort_order):
1407 Avoid mishandling comparisons due to subtraction overflow.
1408 (Fx_family_fonts, realize_basic_faces):
1409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1411 Don't assume fixnum fits in int.
1412 Use SAFE_ALLOCA_LISP, not alloca.
1413 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1414 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1415 (face_at_buffer_position, face_for_overlay_string)
1416 (face_at_string_position):
1417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1418 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1421 Check that fixnums are in proper range for system types.
1422 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1423 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1425 (Fx_change_window_property): Don't assume fixnums fit in int.
1426 * xfont.c (xfont_chars_supported):
1427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1428 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1429 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1431 * xml.c (parse_region):
1432 * xrdb.c (magic_file_p):
1433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1434 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1435 (x_get_local_selection, x_reply_selection_request)
1436 (x_handle_selection_request, wait_for_property_change):
1437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1438 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1439 short is wide enough.
1440 (x_send_client_event): Don't assume fixnum fits in int.
1441 * xterm.c (x_x_to_emacs_modifiers):
1442 Don't assume EMACS_INT overflows nicely into int.
1443 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1445 (handle_one_xevent): NATNUMP can eval its arg twice.
1446 (x_connection_closed):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 * xterm.h: Adjust decls to match defn changes elsewhere.
1449 (struct scroll_bar): Use struct vectorlike_header
1450 rather than rolling our own approximation.
1451 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1453 2012-05-25 Glenn Morris <rgm@gnu.org>
1455 * lisp.mk (lisp): Update for more files being compiled now.
1457 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1459 * lread.c: Remove `read_pure' which makes no difference.
1460 (read_pure): Remove var.
1461 (unreadpure): Remove function.
1462 (readevalloop): Don't call read_list with -1 flag.
1463 (read1, read_vector): Don't test read_pure any more.
1464 (read_list): Simplify.
1466 * fileio.c, character.h: Minor style tweaks.
1468 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1470 * window.h (clip_changed): Remove useless declaration.
1472 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1474 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1475 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1477 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1480 This directory predates autoconf and is no longer needed nowadays.
1481 Move its few remaining bits of functionality to where they're needed.
1482 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1483 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1484 * m/template.h: Remove.
1485 * Makefile.in (M_FILE): Remove. All uses removed.
1486 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1487 * lisp.h (USE_LSB_TAG):
1488 * mem-limits.h (EXCEEDS_LISP_PTR):
1489 Use VAL_MAX, not VALBITS, in #if.
1490 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1491 (EMACS_UINT): Define unconditionally now.
1492 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1493 (BITS_PER_EMACS_INT): New constants, replacing
1494 what used to be in config.h, but not useful in #if.
1495 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1496 define them any more.
1497 (VAL_MAX): New macro.
1499 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1500 BITS_PER_EMACS_INT, in #if.
1501 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1502 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1503 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1504 * s/ms-w32.h (DATA_START):
1505 Move here from removed file m/intel386.h.
1506 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1507 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1509 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1511 Assume C89 or later.
1512 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1513 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1515 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1516 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1517 * textprop.c, tparam.c (NULL): Remove.
1518 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1519 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1520 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1521 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1522 * xterm.c (input_signal_count): Assume volatile works.
1524 2012-05-21 Ken Brown <kbrown@cornell.edu>
1526 * xgselect.c (xg_select): Fix first argument in call to 'select'
1529 2012-05-20 Ken Brown <kbrown@cornell.edu>
1531 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1532 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1534 2012-05-19 Ken Brown <kbrown@cornell.edu>
1536 * xfns.c (x_in_use): Remove `static' qualifier.
1537 * xterm.h (x_in_use): Declare.
1538 * xgselect.c: Include xterm.h.
1539 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1540 and `display_arg' (bug#9754).
1542 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1544 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1546 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1547 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1549 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1551 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1553 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1554 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1556 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1557 reference to image_cache->refcount.
1558 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1560 2012-05-17 Juri Linkov <juri@jurta.org>
1562 * search.c (Fword_search_regexp, Fword_search_backward)
1563 (Fword_search_forward, Fword_search_backward_lax)
1564 (Fword_search_forward_lax): Move functions to isearch.el
1565 (bug#10145, bug#11381).
1567 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1569 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1571 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * lread.c (init_obarray): Declare Qt and Qnil as special.
1575 2012-05-14 Glenn Morris <rgm@gnu.org>
1577 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1578 Put "libexec" before "bin", for the sake of init_callproc_1.
1580 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1582 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1584 * unexaix.c: Port to more-recent AIX compilers.
1585 (report_error, report_error_1, make_hdr, copy_sym)
1586 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1587 Make arguments const char *, not char *, to avoid violations of C
1588 standard and to fix some AIX warnings reported by Gilles Pion.
1590 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1592 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1593 already have overlays loaded.
1594 (handle_single_display_spec): Before returning without displaying
1595 fringe bitmap, synchronize the bidi iterator with the main display
1596 iterator, by calling iterate_out_of_display_property.
1597 (iterate_out_of_display_property): Detect buffer iteration by
1598 testing that it->string is a Lisp string.
1599 (get_next_display_element): When the current object is exhausted,
1600 and there's something on it->stack, call set_iterator_to_next to
1601 proceed with what's on the stack, instead of returning zero.
1602 (set_iterator_to_next): If called at the end of a Lisp string,
1603 proceed to consider_string_end without incrementing string
1604 position. Don't increment display vector index past the end of
1605 the display vector. (Bug#11417)
1606 (pos_visible_p): Don't report a position visible when move_it_to
1607 stopped at the last line of window, which happens to be scanned
1608 backwards by the bidi iteration. (Bug#11464)
1610 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1612 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1613 and right-margin display specs even if the spec is invalid or we
1614 are on a TTY, and thus unable to display on the fringes.
1615 That's because the text with the property will not be displayed anyway,
1616 so we need to signal to the caller that this is a "replacing"
1617 display spec. This fixes display when the spec is invalid or we
1620 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1622 * unexaix.c (make_hdr): Fix typo in prototype.
1623 This bug broke the build on AIX. Problem reported by Gilles Pion.
1625 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1627 * keyboard.c (kbd_buffer_get_event): Read special events also in
1628 batch mode. (Bug#11415)
1630 2012-05-12 Glenn Morris <rgm@gnu.org>
1632 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1634 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1636 * lisp.mk (lisp): Add newcomment.elc.
1638 2012-05-12 Glenn Morris <rgm@gnu.org>
1640 * Makefile.in (MKDIR_P): New, set by configure.
1641 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1643 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1645 Remove unused function hourglass_started.
1646 * dispextern.h (hourglass_started):
1647 * w32fns.c (hourglass_started):
1648 * xdisp.c (hourglass_started): Remove.
1650 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1652 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1653 Update dependencies.
1655 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1657 * xgselect.c (xg_select): Put maxfds+1 into a var.
1658 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1660 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1662 2012-05-10 Dave Abrahams <dave@boostpro.com>
1664 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1665 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1667 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1669 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1670 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1671 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1672 Initialize xd_registered_buses.
1674 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1676 Untag more efficiently if USE_LSB_TAG.
1677 This is based on a proposal by YAMAMOTO Mitsuharu in
1678 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1679 For an admittedly artificial (nth 8000 longlist) benchmark on
1680 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1681 Emacs's overall text size by 1%.
1682 * lisp.h (XUNTAG): New macro.
1683 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1684 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1685 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1686 * eval.c (Fautoload):
1687 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1688 * frame.h (XFRAME): Use XUNTAG.
1690 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1691 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1692 Remove unportable assumptions about print widths of types like
1694 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1695 intptr_t when converting between pointer and integer, to avoid GCC
1696 warnings about wrong width.
1698 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1700 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1701 stack for each reader_thread, instead of defaulting to 8MB
1702 determined by the linker. This avoids failures in creating
1703 subprocesses on Windows 7, see the discussion in this thread:
1704 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1706 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1708 Fix up display of the *Minibuf-0* buffer in the mini window.
1709 * keyboard.c (read_char): Don't clear the echo area if there's no
1711 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1712 contents of *Minibuf-0*) if there's no message displayed in its stead.
1714 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1716 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1719 2012-05-06 Chong Yidong <cyd@gnu.org>
1721 * lisp.mk (lisp): Update.
1723 2012-05-05 Jim Meyering <meyering@redhat.com>
1725 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1727 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1729 * data.c (PUT_ERROR): New macro.
1730 (syms_of_data): Use it. Add new error type `user-error'.
1731 * undo.c (user_error): New function.
1732 (Fprimitive_undo): Use it.
1733 * print.c (print_error_message): Adjust print style for `user-error'.
1734 * keyboard.c (user_error): New function.
1735 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1737 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1739 Do not limit current-time-string to years 1000..9999.
1740 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1741 (Fcurrent_time_string): Support any year that is supported by the
1742 underlying localtime representation. Don't use asctime, as it
1743 has undefined behavior for years outside the range -999..9999.
1745 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1747 Fix race conditions involving setenv, gmtime, localtime, asctime.
1748 Without this fix, interrupts could mess up code that uses these
1749 nonreentrant functions, since setting TZ invalidates existing
1750 tm_zone or tzname values, and since most of these functions return
1751 pointers to static storage.
1752 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1753 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1754 Grow the critical sections to include not just invoking
1755 localtime/gmtime, but also accessing these functions' results
1756 including their tm_zone values if any, and any related TZ setting.
1757 (format_time_string): Last arg is now struct tm *, not struct tm **,
1758 so that the struct tm is saved in the critical section.
1759 All callers changed. Simplify allocation of initial buffer, partly
1760 motivated by the fact that memory allocation needs to be outside
1761 the critical section.
1763 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1765 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1766 with RESET_INTERVAL.
1768 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1769 Remove duplicated buffer name initialization.
1771 2012-05-02 Jim Meyering <jim@meyering.net>
1773 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1775 * xfns.c (x_window): Use xstrdup (Bug#11375).
1777 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1779 * xdisp.c (pos_visible_p): If already at a newline from the
1780 display string before the 'while' loop, don't walk back the glyphs
1781 from it3.glyph_row. Solves assertion violation when the display
1782 string begins with a newline (egg.el). (Bug#11367)
1784 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1786 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1789 2012-05-01 Glenn Morris <rgm@gnu.org>
1791 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1792 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1793 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1794 All were removed before 23.1.
1796 * dispnew.c: Remove HAVE_LIBNCURSES test;
1797 it is always true on relevant platforms.
1799 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1800 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1802 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1804 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1806 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1807 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1810 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1812 Do not avoid creating empty evaporating overlays (Bug#9642).
1813 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1814 That is, do not delete an evaporating overlay if it becomes
1815 empty after its bounds are adjusted to fit within its buffer.
1816 This fix caused other problems, and I'm reverting it until we get
1817 to the bottom of them.
1819 2012-04-27 Chong Yidong <cyd@gnu.org>
1821 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1823 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (pos_visible_p): If the window start position is beyond
1826 ZV, start the display from buffer beginning. Prevents assertion
1827 violation in init_iterator when the minibuffer window is scrolled
1830 * window.c (window_scroll_pixel_based): Likewise.
1832 2012-04-27 Chong Yidong <cyd@gnu.org>
1834 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1836 2012-04-27 Glenn Morris <rgm@gnu.org>
1838 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1839 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1841 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1843 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1844 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1846 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1848 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1849 display element, check also the underlying string or buffer
1850 character. (Bug#11341)
1852 * w32menu.c: Include w32heap.h.
1853 (add_menu_item): If the call to AppendMenuW (via
1854 unicode_append_menu) fails, disable Unicode menus only if we are
1855 running on Windows 9X/Me.
1857 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1859 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1860 (xgetint): Add missing shift for LSB tags.
1862 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1864 * keyboard.c (read_char): Don't wipe echo area for select window
1865 events: These might get delayed via `mouse-autoselect-window'
1868 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1870 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1871 manipulation of :loaded-from data.
1873 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1875 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1876 now a cons (bug#11311).
1878 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1880 Do not create empty overlays with the evaporate property (Bug#9642).
1881 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1882 if it becomes empty after its bounds are adjusted to fit within
1883 its buffer. Without this fix, in a nonempty buffer (let ((o
1884 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1885 yields an empty overlay that has the evaporate property, which is
1886 not supposed to happen.
1888 Fix minor GTK3 problems found by static checking.
1889 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1890 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1891 (struct _EmacsFixedClass, emacs_fixed_get_type):
1892 Move decls here from emacsgtkfixed.h, since they needn't be public.
1893 (emacs_fixed_get_type): Now static.
1894 (emacs_fixed_class_init): Omit unused local.
1895 (emacs_fixed_child_type): Remove; unused.
1896 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1897 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1898 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1899 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1900 (EMACS_FIXED_GET_CLASS): Remove; unused.
1901 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1903 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1904 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1906 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1908 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1909 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1910 (__malloc_size_t, __malloc_ptrdiff_t):
1911 Remove. All uses removed, replaced by the definiens if needed,
1912 since we can assume C89 or better now.
1913 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1914 (protect_malloc_state, align, get_contiguous_space)
1915 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1916 (malloc_atfork_handler_child, malloc_enable_thread)
1917 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1918 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1919 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1920 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1921 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1922 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1923 Define using prototypes, not old style.
1924 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1925 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1926 (align): Don't assume that signed integer overflow wraps around.
1927 Omit unused local var.
1928 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1929 (_free_internal_nolock, memalign, mallochook, reallochook):
1930 Omit no-longer-needed casts.
1931 (valloc): Use getpagesize, not __getpagesize.
1932 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1933 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1935 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1937 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1939 Move functions from C to Lisp. Make non-blocking method calls
1940 the default. Implement further D-Bus standard interfaces.
1942 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1943 (QCdbus_request_name_allow_replacement)
1944 (QCdbus_request_name_replace_existing)
1945 (QCdbus_request_name_do_not_queue)
1946 (QCdbus_request_name_reply_primary_owner)
1947 (QCdbus_request_name_reply_in_queue)
1948 (QCdbus_request_name_reply_exists)
1949 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1950 (QCdbus_registered_serial, QCdbus_registered_method)
1951 (QCdbus_registered_signal): New Lisp objects.
1952 (XD_DEBUG_MESSAGE): Use sizeof.
1953 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1954 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1955 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1956 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1957 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1958 (xd_signature, xd_append_arg): Allow float for integer types.
1959 (xd_get_connection_references): New function.
1960 (xd_get_connection_address): Rename from xd_initialize.
1961 Return cached address.
1962 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1963 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1965 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1966 Return number of refcounts.
1967 (Fdbus_get_unique_name): Make stronger parameter check.
1968 (Fdbus_message_internal): New defun.
1969 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1970 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1971 (Fdbus_send_signal, Fdbus_register_service)
1972 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1973 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1974 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1975 (Vdbus_compiled_version, Vdbus_runtime_version)
1976 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1977 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1978 (Vdbus_message_type_signal): New defvars.
1979 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1982 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1984 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1985 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1986 Do not assume ptrdiff_t is the same width as 'int'.
1988 * alloc.c: Handle unusual debugging option combinations.
1989 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1990 since the two debugging options are incompatible.
1991 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1993 (mem_init, mem_insert, mem_insert_fixup):
1994 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1995 (NEED_MEM_INSERT): Remove; no longer needed.
1997 2012-04-22 Leo Liu <sdl.web@gmail.com>
1999 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2001 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2003 * sysdep.c [__FreeBSD__]: Minor cleanups.
2004 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2005 Use Emacs indenting style more consistently. Avoid some casts.
2006 Use 'double' consistently rather than mixing 'float' and 'double'.
2008 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2010 * sysdep.c (list_system_processes, system_process_attributes):
2011 Add implementation for FreeBSD (Bug#5243).
2013 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2015 * lisp.mk (lisp): Update.
2017 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2019 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2020 It is never used otherwise.
2022 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2024 * print.c (print_preprocess): Only check print_depth if print-circle
2026 (print_object): Check for cycles even when print-circle is nil and
2027 print-gensym is t, but only check print_depth if print-circle is nil.
2029 2012-04-20 Chong Yidong <cyd@gnu.org>
2031 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2032 set the status to "failed" and ensure that sentinel is run.
2034 2012-04-20 Glenn Morris <rgm@gnu.org>
2036 * process.c (Fset_process_inherit_coding_system_flag)
2037 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2038 (Fmake_network_process, Fmake_serial_process): Doc fix.
2040 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (string_buffer_position_lim): Limit starting position to
2044 (set_cursor_from_row): If called for a mode-line or header-line
2045 row, return zero immediately.
2046 (try_cursor_movement): If inside continuation line, don't back up
2047 farther than the first row after the header line, if any.
2048 Don't consider the header-line row as "partially visible", even if
2049 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2051 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2053 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2056 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2057 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2059 configure: new option --enable-gcc-warnings (Bug#11207)
2060 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2061 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2062 (ALL_CFLAGS): Use new macros rather than old.
2063 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2064 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2065 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2066 -Wunused-result, -Wunused-variable. This should go away once
2067 the Emacs and Gnulib regex code is merged.
2068 (xmalloc, xrealloc): Now static.
2070 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2072 * dired.c (Fsystem_groups): Remove unused local.
2074 2012-04-17 Glenn Morris <rgm@gnu.org>
2076 * dired.c (Fsystem_users): Doc fix.
2078 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2080 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2081 (syms_of_dired): Add them.
2083 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2085 Fix minor alloc.c problems found by static checking.
2086 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2087 New extern decls, to avoid calling undeclared functions.
2088 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2089 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2090 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2091 (NEED_MEM_INSERT): New macro.
2092 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2093 Remove one incorrect comment and fix another.
2095 Fix minor ralloc.c problems found by static checking.
2096 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2097 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2098 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2099 (r_alloc_sbrk): Now static.
2101 Improve ralloc.c interface checking.
2102 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2103 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2104 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2105 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2106 [REL_ALLOC]: ... to here, to check interface.
2107 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2108 Remove decls. This fixes an "It stinks!".
2110 * alloc.c (which_symbols): Fix alignment issue / type clash.
2112 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2114 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2115 (struct Lisp_Misc_Any): Likewise.
2116 (struct Lisp_Free): Likewise.
2117 * alloc.c (union aligned_Lisp_Symbol): Define.
2118 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2119 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2120 (union aligned_Lisp_Misc): Define.
2121 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2122 aligned_Lisp_Misc instead of union Lisp_Misc.
2123 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2125 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2127 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2128 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2129 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2130 * s/netbsd.h, s/sol2-6.h:
2131 Remove definition of GC_MARK_STACK, since the default now works.
2132 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2133 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2134 no longer the default.
2135 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2137 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2139 * lread.c (lisp_file_lexically_bound_p):
2140 Fix hang at ";-*-\n" (bug#11238).
2142 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2147 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2149 * nsterm.m (constrainFrameRect): Always constrain when there is only
2150 one screen (Bug#10962).
2152 2012-04-13 Ken Brown <kbrown@cornell.edu>
2154 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2156 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2158 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2160 2012-04-11 Daniel Colascione <dancol@dancol.org>
2162 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2163 against is gone. It's better to use vfork now so that when Cygwin
2164 gains a new, working vfork, we use it automatically (bug#10398).
2166 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2168 * window.c (save_window_save): Obey window-point-insertion-type.
2170 2012-04-11 Glenn Morris <rgm@gnu.org>
2172 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2174 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2176 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2178 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2180 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2181 (force_quit_count): New var.
2182 (handle_interrupt): Use it.
2184 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2186 * w32.c (w32_delayed_load): Record the full path of the library
2187 being loaded (bug#10424).
2189 2012-04-09 Glenn Morris <rgm@gnu.org>
2191 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2192 not just in the obarray, before snarfing them. (Bug#11036)
2194 * Makefile.in ($(leimdir)/leim-list.el):
2195 Pass EMACS rather than BUILT_EMACS.
2197 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2199 * process.c (make_process):
2200 * process.h: Add integer `gnutls_handshakes_tried' member to
2203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2204 Add convenience `GNUTLS_LOG2i' macro.
2206 * gnutls.c (gnutls_log_function2i): Convenience log function.
2207 (emacs_gnutls_read): Use new log functions,
2208 `gnutls_handshakes_tried' process member, and
2209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2210 attempts per process (connection).
2212 2012-04-09 Chong Yidong <cyd@gnu.org>
2214 * eval.c (Fuser_variable_p, user_variable_p_eh)
2215 (lisp_indirect_variable): Functions deleted.
2216 (Fdefvar): Caller changed.
2218 * callint.c (Finteractive, Fcall_interactively):
2219 * minibuf.c (Fread_variable): Callers changed.
2221 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2223 * xdisp.c (set_cursor_from_row): If the display string appears in
2224 the buffer at position that is closer to point than the position
2225 after the display string, display the cursor on the first glyph of
2226 the display string. Fixes cursor display when a 'display' text
2227 property immediately follows invisible text. (Bug#11094)
2229 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2231 composite.c: use 'double' consistently
2232 * composite.c (get_composition_id): Use 'double' consistently
2233 instead of converting 'float' to 'double' and vice versa; this is
2234 easier to understand and avoids a GCC warning.
2236 2012-04-09 Glenn Morris <rgm@gnu.org>
2238 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2239 preparation for dumping it with emacs. (Bug#4789)
2240 (leimdir): New variable.
2241 ($(leimdir)/leim-list.el): New rule.
2242 (emacs$(EXEEXT)): Depend on leim-list.el.
2244 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2245 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2246 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2248 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2250 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2253 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2255 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2256 Remove unused local variable.
2258 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2260 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2262 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2263 objects, as mark_maybe_pointer will catch them otherwise.
2264 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2265 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2267 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2269 Fix typo that broke non-Windows builds.
2270 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2272 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2274 Support building on MS-Windows with libxml2.
2276 * makefile.w32-in (OBJ2): Add xml.$(O).
2277 (GLOBAL_SOURCES): Add xml.c.
2278 ($(BLD)/xml.$(O)): New dependency list.
2280 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2281 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2282 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2283 [!WINDOWSNT]: New macros.
2284 (init_libxml2_functions, libxml2_loaded_p): New functions.
2285 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2286 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2287 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2288 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2290 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2291 Call init_libxml2_functions before calling libxml2 functions.
2292 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2294 * emacs.c: Don't include libxml/parser.h.
2295 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2296 xmlCleanupParser directly.
2298 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2300 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2302 * indent.c (Fvertical_motion): If there is a display string at
2303 point, use it.vpos to compute how many lines to backtrack after
2304 move_it_to point. (Bug#11133)
2306 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2308 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2309 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2310 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2311 macros related to unification of CJK characters. For the details,
2312 see the discussion following the message here:
2313 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2315 2012-04-04 Chong Yidong <cyd@gnu.org>
2317 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2319 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2321 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2322 instead of alloca. (Bug#11138)
2324 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2326 * w32menu.c (is_simple_dialog): Properly check lisp types.
2329 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2331 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2332 position we get to after a call to move_it_to fails the
2333 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2334 only if we wind up in a string from display property. (Bug#11063)
2336 * window.c (Fdelete_other_windows_internal): Invalidate the row
2337 and column information about mouse highlight, so that redisplay
2338 restores it after reallocating the glyph matrices. (Bug#7464)
2340 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2341 string comes from a `display' text property, use the buffer
2342 position of that property as if we actually saw that position in
2344 (move_it_by_lines): Remove the assertion that
2345 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2346 violated when there's a before-string at the beginning of a line.
2349 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2351 * xdisp.c (append_space_for_newline): If the default face was
2352 remapped, use the remapped face for the appended newline.
2353 (extend_face_to_end_of_line): Use the remapped default face for
2354 extending the face to the end of the line.
2355 (display_line): Call extend_face_to_end_of_line when the default
2356 face was remapped. (Bug#11068)
2358 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2360 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2362 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2364 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2366 2012-03-27 Glenn Morris <rgm@gnu.org>
2368 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2371 2012-03-26 Kenichi Handa <handa@m17n.org>
2373 * dispextern.h (struct glyph): Fix previous change. Change the
2374 bit length of glyphless.ch to 25 (Bug#11082).
2376 2012-03-26 Chong Yidong <cyd@gnu.org>
2378 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2379 (command_loop_1): Use it; inhibit selection update for
2380 handle-select-window too (Bug#8996).
2382 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2384 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2386 2012-03-25 Kenichi Handa <handa@m17n.org>
2388 * dispextern.h (struct glyph): Change the bit length of
2389 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2391 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2393 * s/ms-w32.h (tzname): Include time.h before redirecting to
2394 _tzname. Fixes the MSVC build. (Bug#9960)
2396 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2398 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2401 * xterm.c (XTread_socket): Only modify handling_signal if
2402 !SYNC_INPUT. (Bug#11080)
2404 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2406 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2407 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2408 when fetching a multibyte character consumes more bytes than
2409 CHAR_BYTES returns, due to unification of CJK characters in
2410 string_char. (Bug#11073)
2412 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2414 * process.c (wait_reading_process_output): Handle pty disconnect
2415 by refraining from sending oneself a SIGCHLD (bug#10933).
2417 2012-03-22 Chong Yidong <cyd@gnu.org>
2419 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2421 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2422 Mark string as coming from a prefix property.
2423 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2424 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2426 2012-03-21 Chong Yidong <cyd@gnu.org>
2428 * xfaces.c (Vface_remapping_alist): Doc fix.
2430 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2432 * w32proc.c (Fw32_set_console_codepage)
2433 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2436 2012-03-20 Chong Yidong <cyd@gnu.org>
2438 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2439 to reflect default non-nil value of redisplay-dont-pause.
2441 2012-03-19 Kenichi Handa <handa@m17n.org>
2443 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2444 it fit in a valid range (Bug#11003).
2446 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2448 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2449 that is not from display property, accept the row as a "cursor
2450 row" if one of the string's character has a non-nil `cursor'
2451 property. Fixes cursor positioning when there are newlines in
2452 overlay strings, e.g. in icomplete.el. (Bug#11035)
2454 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2456 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2458 2012-03-12 Chong Yidong <cyd@gnu.org>
2460 * eval.c (inhibit_lisp_code): Rename from
2461 inhibit_window_configuration_change_hook; move from window.c.
2463 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2464 * window.c (run_window_configuration_change_hook)
2465 (syms_of_window): Callers changed.
2467 2012-03-11 Chong Yidong <cyd@gnu.org>
2469 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2471 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2473 2012-03-10 Chong Yidong <cyd@gnu.org>
2475 * frame.c (other_visible_frames): Don't assume the selected frame
2476 is visible (Bug#10955).
2478 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2480 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2482 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2484 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2485 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2488 2012-03-03 Glenn Morris <rgm@gnu.org>
2490 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2492 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2494 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2495 position past the first glyph_row that ends at ZV. (Bug#10902)
2496 (redisplay_window, next_element_from_string): Fix typos in
2498 (redisplay_window): Pass to move_it_vertically the margin in
2499 pixels, not in screen lines.
2501 2012-03-02 Glenn Morris <rgm@gnu.org>
2503 * buffer.c (buffer-list-update-hook): Doc fix.
2505 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2508 push_it before setting up the iterator for the first overlay
2509 string, even if we have an empty string loaded.
2510 (next_overlay_string): If there's an empty string on the iterator
2511 stack, pop the stack. (Bug#10903)
2513 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2515 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2516 Suggested by Stefan Monnier in
2517 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2518 * alloc.c (widen_to_Lisp_Object): New static function.
2519 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2520 and widening them to Lisp_Objects. This would work even if
2521 USE_LSB_TAG is defined and wide integers are used, which might
2522 happen in a future version of Emacs.
2524 2012-02-25 Chong Yidong <cyd@gnu.org>
2526 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2529 * xselect.c (Fx_selection_exists_p): Doc fix.
2530 (x_clipboard_manager_save_all): Print an informative message
2531 before saving to clipboard manager.
2533 2012-02-24 Chong Yidong <cyd@gnu.org>
2535 * keyboard.c (process_special_events): Handle all X selection
2536 requests in kbd_buffer, not just the next one (Bug#8869).
2538 2012-02-23 Chong Yidong <cyd@gnu.org>
2540 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2541 call when setting menu-bar-lines and tool-bar-lines parameters.
2542 (unwind_create_frame_1): New helper function.
2544 * window.c (inhibit_window_configuration_change_hook): New var.
2545 (run_window_configuration_change_hook): Obey it.
2546 (syms_of_window): Initialize it.
2548 2012-02-22 Chong Yidong <cyd@gnu.org>
2550 * xterm.c (x_draw_image_relief): Add missing type check for
2551 Vtool_bar_button_margin (Bug#10743).
2553 2012-02-21 Chong Yidong <cyd@gnu.org>
2555 * fileio.c (Vfile_name_handler_alist): Doc fix.
2557 * buffer.c (Fget_file_buffer): Protect against invalid file
2558 handler return value.
2560 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2562 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2563 when computing $valmask.
2565 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2566 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2567 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2568 It's useless in that case, and it can cause problems on hosts
2569 that allocate halves of EMACS_INT values separately.
2570 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2572 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2573 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2574 it avoids undefined behavior on hosts where shifting right by more
2575 than the word width has undefined behavior.
2577 2012-02-19 Chong Yidong <cyd@gnu.org>
2579 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2580 (Funhandled_file_name_directory, Ffile_name_as_directory)
2581 (Fdirectory_file_name, Fexpand_file_name)
2582 (Fsubstitute_in_file_name): Protect against invalid file handler
2583 return values (Bug#10845).
2585 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2587 * .gdbinit (pitx): Fix incorrect references to fields of the
2590 2012-02-17 Chong Yidong <cyd@gnu.org>
2592 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2594 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2596 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2597 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2599 2012-02-15 Chong Yidong <cyd@gnu.org>
2601 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2602 marked as special. Also, starting docstrings with * is obsolete.
2604 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2606 * gnutls.c (emacs_gnutls_write): Fix last change.
2608 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2610 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2613 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2615 * keymap.c (Fsingle_key_description): Handle char ranges.
2617 2012-02-12 Chong Yidong <cyd@gnu.org>
2619 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2620 as that creates a dangerous corner case.
2622 * window.c (Fdelete_window_internal): Invalidate the mouse
2623 highlight (Bug#9904).
2625 2012-02-12 Glenn Morris <rgm@gnu.org>
2627 * xselect.c (Fx_own_selection_internal)
2628 (Fx_get_selection_internal, Fx_disown_selection_internal)
2629 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2630 * nsselect.m (Fx_own_selection_internal)
2631 (Fx_disown_selection_internal, Fx_selection_exists_p)
2632 (Fx_selection_owner_p, Fx_get_selection_internal):
2633 Sync docs and argument specs with the xselect.c versions.
2635 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2637 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2639 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2641 * w32select.c (Fx_selection_exists_p): Sync doc string and
2642 argument list with xselect.c. (Bug#10783)
2644 * w16select.c (Fx_selection_exists_p): Sync doc string and
2645 argument list with xselect.c. (Bug#10783)
2647 2012-02-10 Glenn Morris <rgm@gnu.org>
2649 * fns.c (Fsecure_hash): Doc fix.
2651 2012-02-09 Kenichi Handa <handa@m17n.org>
2653 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2655 2012-02-07 Chong Yidong <cyd@gnu.org>
2657 * buffer.c (Fbuffer_local_variables)
2658 (buffer_lisp_local_variables): Handle unbound vars correctly;
2659 don't let Qunbound leak into Lisp.
2661 2012-02-07 Glenn Morris <rgm@gnu.org>
2663 * image.c (Fimagemagick_types): Doc fix.
2665 * image.c (imagemagick-render-type): Change it from a lisp object
2666 to an integer. Move the doc here from the lisp manual.
2667 Treat all values not equal to 0 the same.
2669 2012-02-06 Chong Yidong <cyd@gnu.org>
2671 * doc.c (store_function_docstring): Avoid applying docstring of
2672 alias to base function (Bug#2603).
2674 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2676 * .gdbinit (pp1, pv1): Remove redundant defines.
2679 2012-02-04 Chong Yidong <cyd@gnu.org>
2681 * nsterm.m: Declare a global (Bug#10694).
2683 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2685 * w32.c (get_emacs_configuration_options):
2686 Include --enable-checking, if specified, in the return value.
2688 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2690 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2691 after rounding frame sizes. (Bug#9723)
2693 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2695 * keyboard.c (adjust_point_for_property): Don't position point
2696 before BEGV. (Bug#10696)
2698 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2700 Handle overflow when computing char display width (Bug#9496).
2701 * character.c (char_width): Return EMACS_INT, not int.
2702 (char_width, c_string_width): Check for overflow when
2703 computing the width; this is possible now that individual
2704 characters can have unbounded width. Problem introduced
2705 by merge from Emacs 23 on 2012-01-19.
2707 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2709 * dbusbind.c (Fdbus_register_method): Mention the return value
2710 :ignore in the docstring.
2712 2012-02-02 Glenn Morris <rgm@gnu.org>
2714 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2716 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2717 Unconditionally set to t. (Bug#10673)
2718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2719 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2720 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2722 2012-02-02 Kenichi Handa <handa@m17n.org>
2724 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2725 0, do not call append_composite_glyph.
2727 2012-02-02 Kenichi Handa <handa@m17n.org>
2729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2731 (x_produce_glyphs): If the component of a composition is a null
2732 string, set it->pixel_width to 1 to avoid zero-width glyph.
2734 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2736 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2737 first 2 arguments are identical. This makes inserting large
2738 output from a subprocess an order of magnitude faster on
2739 MS-Windows, where all sbrk'ed memory is always contiguous.
2741 2012-01-31 Glenn Morris <rgm@gnu.org>
2743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2747 2012-01-29 Glenn Morris <rgm@gnu.org>
2749 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2751 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2753 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2755 2012-01-28 Chong Yidong <cyd@gnu.org>
2757 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2759 2012-01-26 Chong Yidong <cyd@gnu.org>
2761 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2763 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2764 repeat counts (Bug#10507).
2766 2012-01-26 Glenn Morris <rgm@gnu.org>
2768 * lread.c (syms_of_lread): Doc fix.
2770 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2772 * coding.c (encode_designation_at_bol): Change return value to
2775 2012-01-25 Chong Yidong <cyd@gnu.org>
2777 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2779 2012-01-21 Chong Yidong <cyd@gnu.org>
2781 * floatfns.c (Fcopysign): Make the second argument non-optional,
2782 since nil is not allowed anyway.
2784 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2786 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2787 (send_process): Likewise.
2789 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2791 * window.c (save_window_save, Fcurrent_window_configuration)
2792 (Vwindow_persistent_parameters): Do not use Qstate.
2793 Rewrite doc-strings.
2795 2012-01-19 Kenichi Handa <handa@m17n.org>
2797 * character.c (char_width): New function.
2798 (Fchar_width, c_string_width, lisp_string_width):
2799 Use char_width (Bug#9496).
2801 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2803 * window.c (Vwindow_persistent_parameters): New variable.
2804 (Fset_window_configuration, save_window_save): Handle persistent
2807 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2809 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2810 thrashing the stack of the thread. (Bug#9087)
2812 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2814 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2816 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2818 * xdisp.c (rows_from_pos_range): Handle the case where the
2819 highlight ends on a newline. (Bug#10464)
2820 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2821 he end column for display of highlight that ends on a newline
2824 2012-01-11 Glenn Morris <rgm@gnu.org>
2826 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2827 from load-path also when installation-directory is nil. (Bug#10208)
2829 2012-01-10 Glenn Morris <rgm@gnu.org>
2831 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2833 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2834 Update template values to be closer to their typical values these days.
2836 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2838 * xdisp.c (rows_from_pos_range): Accept additional argument
2839 DISP_STRING, and accept any glyph in a row whose object is that
2840 string as eligible for mouse highlight. Fixes mouse highlight of
2841 display strings from overlays. (Bug#10464)
2843 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2845 emacs: fix an auto-save permissions race condition (Bug#10400)
2846 * fileio.c (auto_saving_dir_umask): New static var.
2847 (Fmake_directory_internal): Use it.
2848 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2849 creating the directory. The old code temporarily assigns
2850 too-generous permissions to the directory.
2851 (do_auto_save_eh): Clear it.
2852 (Fdo_auto_save): Catch all errors, not just file errors, so
2853 that the var is always cleared.
2855 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2857 * search.c (scan_buffer): Pass character positions to
2858 know_region_cache, not byte positions. (Bug#6540)
2860 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2862 * w32.c (sys_rename): Report EXDEV when rename of a directory
2863 fails because the target is on another logical disk. (Bug#10284)
2865 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2867 * xterm.c (x_embed_request_focus): New function.
2869 * xterm.h: Add prototype.
2871 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2873 2012-01-05 Glenn Morris <rgm@gnu.org>
2875 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2877 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2879 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2880 Load gnutls_transport_set_lowat only if GnuTLS version is below
2882 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2883 GnuTLS versions below 2.11.1.
2885 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2887 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2888 to the doc string advising against its use for altering the way
2889 windows are scrolled.
2891 2011-12-28 Kenichi Handa <handa@m17n.org>
2893 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2894 coding-system ASCII compatible only when it does not produce BOM
2895 on encoding (Bug#10383).
2897 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2899 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2901 (create_and_show_popup_menu): Always use menu_position_func for
2904 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2906 * callint.c (Fcall_interactively): Don't truncate prompt string.
2908 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2910 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2911 property that ends at ZV, so that the bidi iteration could be
2912 resumed from there (after widening). (Bug#10360)
2914 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2916 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2918 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2920 * nsterm.m (x_free_frame_resources):
2921 Release f->output_data.ns->miniimage.
2922 (ns_index_color): Fix indentation. Do not retain
2923 color_table->colors[i].
2925 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2928 * nsfns.m (x_set_background_color): Assign return value from
2929 ns_index_color to face-background instead of NSColor*.
2930 (ns_implicitly_set_icon_type): Fix indentation.
2931 Change assignment in for loop to comparison.
2933 * emacs.c (ns_pool): New variable.
2934 (main): Assign ns_pool.
2935 (Fkill_emacs): Call ns_release_autorelease_pool.
2937 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2938 autorelease fdesc, release fdAttrs and tdict.
2939 (ns_get_covering_families): Release charset.
2940 (ns_findfonts): Release NSFontDescriptor created with new.
2941 (ns_uni_to_glyphs): Fix indentation.
2942 (setString): Release attrStr before assigning new value.
2944 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2946 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2948 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2949 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2951 2011-12-18 David Reitter <reitter@cmu.edu>
2953 * nsterm.m (ns_term_init): Subscribe for notifications
2954 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2955 to method trackingNotification in EmacsMenu.
2957 * nsmenu.m (trackingMenu): New variable.
2958 (trackingNotification): New method (from Aquamacs).
2959 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2960 from Aquamacs (Bug#7030).
2962 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2964 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2965 (symbol_to_nsstring): Fix indentation.
2966 (ns_symbol_to_pb): New function.
2967 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2968 (Fns_rotate_cut_buffers_internal): Remove.
2969 (Fns_store_selection_internal): Rename from
2970 Fns_store_cut_buffer_internal.
2971 (ns_get_foreign_selection, Fx_own_selection_internal)
2972 (Fx_disown_selection_internal, Fx_selection_exists_p)
2973 (Fns_get_selection_internal, Fns_store_selection_internal):
2974 Use ns_symbol_to_pb and check if return value is nil.
2975 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2976 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2977 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2978 renamed to Sns_store_selection_internal.
2979 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2980 and remove this function.
2981 (ns_handle_selection_clear): Remove, never used.
2982 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2985 2011-12-17 Ken Brown <kbrown@cornell.edu>
2987 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2988 GID is unknown (Bug#10257).
2990 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2992 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2993 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2994 which caused a build failure on GNU/Linux IA-64. This problem was
2995 introduced by my 2011-10-07 patch.
2997 2011-12-15 Juri Linkov <juri@jurta.org>
2999 * image.c (imagemagick_error): New function. (Bug#10112)
3000 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3001 Use `imagemagick_error' where ImageMagick functions return
3003 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3006 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3008 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3009 fill background (Bug#8992).
3011 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3013 * window.c (Vwindow_combination_resize)
3014 (Vwindow_combination_limit): Use t instead of non-nil in
3016 (Vrecenter_redisplay): Add first sentence of doc-string on
3018 (Frecenter): Fix doc-string typo.
3020 2011-12-11 Kenichi Handa <handa@m17n.org>
3022 * coding.c (Funencodable_char_position): Pay attention to the
3023 buffer text relocation (Bug#9389).
3025 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3027 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3028 gtk_init (Bug#10100).
3030 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3032 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3033 IT->string is nil. (Bug#10263)
3035 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3037 * nsterm.h (x_free_frame_resources): Declare.
3039 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3040 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3042 * nsterm.h (ns_get_defaults_value): Declare.
3044 * nsterm.m (ns_default): Call ns_get_defaults_value.
3046 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3048 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3051 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3053 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3054 that where the value of an _OBJC_* symbol points to is in the .bss
3055 section (Bug#10240).
3057 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3059 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3060 after the loop to call ccl_driver at least once (Bug#8619).
3062 2011-12-08 Kenichi Handa <handa@m17n.org>
3064 * ftfont.c (get_adstyle_property): Fix previous change
3067 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3069 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3070 dirs from the default value of EMACSLOADPATH (bug#10208).
3072 2011-12-07 Glenn Morris <rgm@gnu.org>
3074 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3075 installation and source directories as well. (Bug#10208)
3077 2011-12-06 Chong Yidong <cyd@gnu.org>
3079 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3081 2011-12-06 Glenn Morris <rgm@gnu.org>
3083 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3084 as an error, not just -1. (Bug#10217)
3086 2011-12-05 Chong Yidong <cyd@gnu.org>
3088 * keyboard.c (process_special_events): New function.
3089 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3091 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3093 * coding.c (encode_designation_at_bol): Don't use uninitialized
3094 local variable (Bug#9318).
3096 2011-12-05 Kenichi Handa <handa@m17n.org>
3098 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3099 return Qnil (Bug#8046, Bug#10193).
3101 2011-12-05 Kenichi Handa <handa@m17n.org>
3103 * coding.c (encode_designation_at_bol): New args charbuf_end and
3104 dst. Return the number of produced bytes. Callers changed.
3105 (coding_set_source): Return how many bytes coding->source was
3107 (coding_set_destination): Return how many bytes
3108 coding->destination was relocated.
3109 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3110 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3112 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3114 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3115 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3118 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3120 The following changes are to fix Bug#9318.
3122 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3123 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3124 (encode_coding_iso_2022, encode_coding_sjis)
3125 (encode_coding_big5, encode_coding_charset): Use the above macros.
3127 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3129 * lisp.h (process_quit_flag): Fix external declaration.
3131 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3133 Don't macro-inline non-performance-critical code.
3134 * eval.c (process_quit_flag): New function.
3135 * lisp.h (QUIT): Use it.
3137 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3139 * nsfns.m (get_geometry_from_preferences): New function.
3140 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3142 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3144 * emacs.c (Qkill_emacs): Define.
3145 (syms_of_emacs): Initialize it.
3146 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3147 Qquit_flag to `kill-emacs' instead.
3148 (quit_throw_to_read_char): Add parameter `from_signal'.
3149 All callers changed. Call Fkill_emacs if requested and safe.
3150 * lisp.h (QUIT): Call Fkill_emacs if requested.
3152 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3154 * widget.c (update_wm_hints): Return if wmshell is null.
3155 (widget_update_wm_size_hints): New function.
3157 * widget.h (widget_update_wm_size_hints): Declare.
3159 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3160 widget_update_wm_size_hints (Bug#10104).
3162 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3164 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3165 before a newline, prepare the bidi iterator for consuming the
3166 newline, and keep the current paragraph direction. (Bug#10183)
3167 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3169 2011-12-02 Juri Linkov <juri@jurta.org>
3171 * search.c (Fword_search_regexp): New Lisp function created from
3172 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3173 (Fword_search_backward, Fword_search_forward)
3174 (Fword_search_backward_lax, Fword_search_forward_lax):
3175 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3176 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3178 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3180 * fileio.c (Finsert_file_contents): Move after-change-function call
3181 to before the "handled:" label, since all "goto handled" appear in
3182 cases where the *-change-functions have already been properly called
3185 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3187 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3188 waiting for input. (Bug#10169)
3190 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3192 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3193 verifies glyph row's hash code--we have just reallocated the
3194 glyphs, so their contents can be complete garbage. (Bug#10164)
3196 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3200 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3203 attributes are tested _before_ calling verify_row_hash, to protect
3204 against GCC re-ordering of the tests. (Bug#10164)
3206 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3208 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3210 * xterm.c (handle_one_xevent): Only set async_visible and friends
3211 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3212 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3213 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3215 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3217 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3218 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3219 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3221 All uses changed to use GCPRO1 etc.
3222 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3223 Revert to old implementation (i.e., before 2011-03-11).
3225 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3227 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3228 of scroll runs so as to avoid assigning disabled bogus rows and
3229 unnecessary graphics copy operations.
3231 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3233 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3234 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3235 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3236 (malloc, free, realloc, calloc): Redirect to e_* only when
3239 * lisp.h (GCTYPEBITS): Move before first use.
3240 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3241 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3242 this macro definition.
3244 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3247 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3249 * gtkutil.c (xg_create_frame_widgets):
3250 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3251 present with Gtk+ 2.0.
3253 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3255 * fileio.c (Finsert_file_contents): Undo previous change; see
3256 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3258 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3260 Rename locals to avoid shadowing.
3261 * fileio.c (Finsert_file_contents):
3262 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3263 * process.c (wait_reading_process_output):
3264 Rename inner 'proc' to 'p' to avoid shadowing.
3265 Indent for consistency with usual Emacs style.
3267 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3269 * xdisp.c (redisplay_window): If cursor row is not fully visible
3270 after recentering, and scroll-conservatively is set to a large
3271 number, scroll window by a few more lines to make the cursor fully
3272 visible and out of scroll-margin. (Bug#10105)
3273 (start_display): Don't move to the next line if the display should
3274 start at a newline that is part of a display vector or an overlay
3277 2011-11-24 Juri Linkov <juri@jurta.org>
3279 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3280 after the `MagickPingImage' call. (Bug#10112)
3282 2011-11-23 Chong Yidong <cyd@gnu.org>
3284 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3286 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3288 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3289 making another buffer current. (Bug#10114)
3291 2011-11-23 Glenn Morris <rgm@gnu.org>
3293 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3295 2011-11-23 Chong Yidong <cyd@gnu.org>
3297 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3298 using it (Bug#5984).
3300 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3302 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3303 and header-lines, as they don't have one computed for them.
3306 * .gdbinit (prow): Make displayed values more self-explaining.
3307 Add row's hash code.
3309 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3311 * process.c (wait_reading_process_output): Fix asynchrounous
3312 GnuTLS socket handling on some versions of the GnuTLS library.
3313 (wait_reading_process_output): Add comment and URL.
3315 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3317 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3319 2011-11-21 Chong Yidong <cyd@gnu.org>
3321 * window.c (Fnext_window, Fprevious_window): Doc fix.
3323 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3325 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3327 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3329 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3331 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3333 * window.c (Fset_window_combination_limit): Rename argument
3335 (Vwindow_combination_limit): Remove "status" from doc-string.
3337 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3339 * m/ibms390.h: Remove.
3340 * m/ibms390x.h: Don't include "ibms390.h".
3342 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3344 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3345 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3347 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3349 * casetab.c (Fset_case_table):
3350 * charset.c (Fcharset_after): Fix typos.
3352 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3354 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3355 Otherwise, valgrind does not work on some platforms.
3356 Problem reported by Andreas Schwab in
3357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3358 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3359 is set, removing the need for VIRT_ADDRESS_VARIES.
3360 (PURE_P): Use a more-efficient implementation that needs just one
3361 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3362 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3363 to 4 (xorl, subq, cmpq, setbe).
3364 * alloc.c (pure): Always extern now, since that's the
3365 VIRT_ADDR_VARIES behavior.
3366 (PURE_POINTER_P): Use a single comparison, not two, for
3367 consistency with the new puresize.h.
3368 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3369 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3370 Remove VIRT_ADDR_VARIES no longer needed.
3372 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3374 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3375 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3376 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3377 behave as if the cursor position were at the window margin.
3379 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3380 and the cursor position is out of bounds, behave as if the cursor
3381 position were at the window margin. (Bug#10075)
3383 2011-11-18 Chong Yidong <cyd@gnu.org>
3385 * window.c (Fwindow_combination_limit): Make first argument
3386 non-optional, since it is meaningless for live windows like the
3389 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3391 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3393 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3395 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3396 (graft_intervals_into_buffer): Simplify.
3398 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3400 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3401 hash values of the two rows.
3402 (copy_row_except_pointers): Preserve the used[] arrays and the
3403 hash values of the two rows. (Bug#10035)
3404 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3406 * xdisp.c (row_hash): New function, body extracted from
3407 compute_line_metrics.
3408 (compute_line_metrics): Call row_hash, instead of computing the
3411 * dispnew.c (verify_row_hash): Call row_hash for computing the
3412 hash code of a row, instead of duplicating code from xdisp.c.
3414 * dispextern.h (row_hash): Add prototype.
3416 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3418 * frame.c (delete_frame): Don't delete the terminal when the last
3419 X frame is closed if emacs is built with GTK toolkit.
3421 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3423 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3425 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3427 * window.c (Vwindow_splits): Rename to
3428 Vwindow_combination_resize. Suggested by Juri Linkov.
3429 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3432 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3434 * nsfns.m (Fns_font_name):
3435 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3437 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3439 * window.h (window): Rename slot "nest" to "combination_limit".
3440 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3441 (Fset_window_nest): Rename to Fset_window_combination_limit.
3442 (Vwindow_nest): Rename to Vwindow_combination_limit.
3443 (recombine_windows, make_parent_window, make_window)
3444 (Fsplit_window_internal, saved_window)
3445 (Fset_window_configuration, save_window_save): Rename all
3446 occurrences of window_nest to window_combination_limit.
3448 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3450 * image.c (imagemagick_load_image): Fix typo.
3452 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3454 * xdisp.c (display_line): Move the call to
3455 highlight_trailing_whitespace before the call to
3456 compute_line_metrics, since the latter needs to see the final
3457 faces of all the glyphs to compute ROW's hash value.
3458 Fixes assertion violations in row_equal_p. (Bug#10035)
3460 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3462 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3463 just return (bug#10044).
3465 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3467 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3468 with user-defined heap size. Bump the default size of the temacs
3469 heap to 27MB, to avoid memory warning when running temacs.
3470 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3472 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3473 current_matrix and desired_matrix. (Bug#9990)
3474 (verify_row_hash) [XASSERTS]: New function.
3475 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3476 that the hash value of glyph rows is correct.
3478 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3480 * window.h (window): Remove splits slot.
3481 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3482 (Fdelete_other_windows_internal, make_parent_window)
3483 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3484 (Fset_window_configuration, save_window_save): Don't deal with
3485 split status of windows.
3486 (saved_window): Remove splits slot.
3487 (Vwindow_splits): Rewrite doc-string.
3489 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3491 * xfns.c (unwind_create_frame):
3492 * nsfns.m (unwind_create_frame):
3493 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3494 Vframe_list (Bug#9999).
3496 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3498 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3500 2011-11-11 Kenichi Handa <handa@m17n.org>
3502 * callproc.c (Fcall_process): Set the member dst_multibyte of
3505 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3507 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3508 avoid a crash (bug#9496).
3510 2011-11-09 Chong Yidong <cyd@gnu.org>
3512 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3513 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3515 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3517 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3519 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3521 Avoid some portability problems by eschewing 'extern inline' functions.
3522 The trivial performance wins aren't worth the portability hassles; see
3523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3526 (window_box_width, window_box_left, window_box_left_offset)
3527 (window_box_right, window_box_right_offset): Undo previous change,
3528 by removing the "extern"s.
3529 * intervals.c (adjust_intervals_for_insertion)
3530 (adjust_intervals_for_deletion): Undo previous change,
3531 making these static again.
3532 (offset_intervals, temp_set_point_both, temp_set_point)
3533 (copy_intervals_to_string): No longer inline.
3534 * xdisp.c (window_text_bottom_y, window_box_width)
3535 (window_box_height, window_box_left_offset)
3536 (window_box_right_offset, window_box_left, window_box_right)
3537 (window_box): No longer inline.
3539 2011-11-08 Chong Yidong <cyd@gnu.org>
3541 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3542 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3543 Signal an error if not a live window.
3544 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3545 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3547 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3549 * lisp.h (syms_of_abbrev): Remove declaration.
3550 Reported by CHENG Gao <chenggao@royau.me>.
3552 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3554 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3555 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3556 of temacs in GUI mode.
3558 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3560 * window.h: Declare delete_all_child_windows instead of
3561 delete_all_subwindows.
3562 * window.c (Fwindow_nest, Fset_window_nest)
3563 (Fset_window_new_total, Fset_window_new_normal)
3564 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3565 (delete_all_subwindows): Rename to delete_all_child_windows.
3566 (Fdelete_other_windows_internal, Fset_window_configuration):
3567 Call delete_all_child_windows instead of delete_all_subwindows.
3568 * frame.c (delete_frame): Call delete_all_child_windows instead
3569 of delete_all_subwindows.
3571 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3573 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3574 This is also needed for porting to any host where GC_MARK_STACK is
3575 not GC_MAKE_GCPROS_NOOPS.
3576 (which_symbols): Use it.
3578 2011-11-07 Kenichi Handa <handa@m17n.org>
3580 * coding.c (coding_set_destination): Check coding->src_pos only
3581 when coding->src_object is a buffer (bug#9910).
3583 * process.c (send_process): Set the member src_multibyte of coding
3584 to 0 (bug#9911) when sending a unibyte text.
3586 * callproc.c (Fcall_process): Set the member src_multibyte of
3587 process_coding to 0 (bug#9912).
3589 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3591 * xmenu.c (cleanup_widget_value_tree): New function.
3592 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3593 calling free_menubar_widget_value_tree directly (Bug#9830).
3595 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3597 Fix some portability problems with 'inline'.
3598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3599 (window_box_width, window_box_left, window_box_left_offset)
3600 (window_box_right, window_box_right_offset): Declare extern.
3601 Otherwise, these inline functions do not conform to C99 and
3602 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3603 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3604 * intervals.c (adjust_intervals_for_insertion)
3605 (adjust_intervals_for_deletion): Now extern, because otherwise the
3606 extern inline functions 'offset_intervals' couldn't refer to it.
3607 (static_offset_intervals): Remove.
3608 (offset_intervals): Rewrite using the old contents of
3609 static_offset_intervals. The old version didn't conform to C99
3610 because an extern inline function contained a reference to an
3611 identifier with static linkage.
3613 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3615 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3618 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3620 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3621 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3622 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3623 return Qleft_to_right.
3625 2011-11-06 Chong Yidong <cyd@gnu.org>
3627 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3628 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3629 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3630 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3631 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3632 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3633 (Fwindow_vscroll): Doc fix.
3634 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3635 argument, since it makes no sense to pass a live window and for
3636 consistency with window-child.
3638 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3640 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3643 2011-11-05 Jason Rumney <jasonr@gnu.org>
3645 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3646 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3648 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3649 bitwise arithmetic preventing use of unicode-sip and non-truetype
3652 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3654 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3657 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3658 initialization code to keep similarity to xfns.c after changes
3661 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3663 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3664 (unwind_create_frame): New function (Bug#9943).
3665 (Fx_create_frame): Restructure code to be more similar to the one in
3666 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3667 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3668 Move terminal->reference_count++ just before making the frame official
3671 * nsterm.m (x_free_frame_resources): New function.
3672 (x_destroy_window): Move code to x_free_frame_resources.
3674 * xfns.c (unwind_create_frame): Fix comment.
3675 (Fx_create_frame, x_create_tip_frame):
3676 Move terminal->reference_count++ just before making the frame
3677 official. Move initialization of image_cache_refcount and
3678 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3680 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3682 Support MSVC build with newer versions of Visual Studio.
3683 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3684 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3687 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3688 which are not supported by MSVC.
3689 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3690 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3692 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3694 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3696 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3698 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3700 Support MSVC build with newer versions of Visual Studio.
3701 * w32.c: Don't include w32api.h for MSVC.
3702 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3704 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3705 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3706 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3707 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3709 (alloca) [_MSC_VER]: Define to _alloca.
3711 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3713 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3715 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3717 * xdisp.c (note_mouse_highlight): If either of
3718 previous/next-single-property-change returns nil, treat that as
3719 the beginning or the end of the buffer. (Bug#9955)
3721 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3723 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3724 label is not null (Bug#9951).
3725 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3728 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3730 * window.c (Fwindow_body_size): Mention in the doc string that the
3731 return value is in frame's canonical units. (Bug#9949)
3733 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3735 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3737 * w32fns.c (unwind_create_frame): If needed, free the glyph
3738 matrices of the partially constructed frame. (Bug#9943)
3739 * xfns.c (unwind_create_frame): Likewise.
3741 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3743 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3744 Don't stop backward scan on the continuation glyph, even though
3745 its CHARPOS is positive.
3746 (mouse_face_from_buffer_pos, note_mouse_highlight):
3747 Rename cover_string to disp_string.
3749 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3751 * window.c (temp_output_buffer_show): Don't use
3752 Vtemp_buffer_show_specifiers.
3753 (Vtemp_buffer_show_specifiers): Remove unused variable.
3755 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3757 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3758 past the beginning of the current glyph matrix.
3760 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3762 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3763 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3764 HAVE_GTK3 (Bug#9869).
3766 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3767 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3769 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3771 * xterm.c: Declare x_handle_net_wm_state to return int.
3772 (handle_one_xevent): Check if we are iconified but don't have
3773 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3774 (get_current_wm_state): Return non-zero if not hidden,
3775 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3776 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3777 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3778 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3780 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3782 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3783 so that this new function doesn't get optimized away by a
3784 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3786 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3788 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3790 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3792 Fix the `xbytecode' command.
3793 * .gdbinit (xprintbytestr): New command.
3794 (xwhichsymbols): Rename from `which'; all callers changed.
3795 (xbytecode): Print the byte-code string as well.
3797 2011-10-29 Kim Storm <storm@cua.dk>
3799 * alloc.c (which_symbols): New function.
3801 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3803 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3806 2011-10-29 Glenn Morris <rgm@gnu.org>
3808 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3809 Not clear what it was for, and it causes various bugs. (Bug#9839)
3811 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3813 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3814 possible random value that matches one of those tested as
3815 condition to clear the mouse face.
3817 2011-10-28 Chong Yidong <cyd@gnu.org>
3819 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3821 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3823 * window.c (make_window): Initialize phys_cursor_on_p.
3825 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3827 * lisp.h (struct Lisp_Symbol): Update comments.
3829 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3831 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3833 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3835 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3836 <oslsachem@gmail.com> for helping to debug this.
3838 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3839 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3840 (g_b_init_get_glyph_outline_w): New static variables.
3841 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3842 (GetGlyphOutlineW_Proc): New typedefs.
3843 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3844 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3846 (w32font_open_internal, compute_metrics):
3847 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3848 instead of calling the "wide" APIs directly.
3850 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3852 * w32.h (syms_of_w32font): Add prototype.
3854 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3856 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3857 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3858 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3859 (Fmove_to_window_line): Doc fix.
3861 2011-10-27 Chong Yidong <cyd@gnu.org>
3863 * process.c (make_process): Set gnutls_state to NULL.
3865 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3866 non-NULL, regardless of GNUTLS_INITSTAGE.
3867 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3868 an error. Set process slots as soon as we allocate them.
3870 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3872 2011-10-27 Chong Yidong <cyd@gnu.org>
3874 * gnutls.c (emacs_gnutls_deinit): New function.
3875 Deallocate credentials structures as well as calling gnutls_deinit.
3876 (Fgnutls_deinit, Fgnutls_boot): Use it.
3878 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3879 (deactivate_process): Call emacs_gnutls_deinit.
3881 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3883 * image.c (x_create_x_image_and_pixmap):
3884 * w32.c (sys_rename, w32_delayed_load):
3885 * w32font.c (fill_in_logfont):
3886 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3888 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3890 * w32fns.c (w32_default_color_map): New function,
3891 extracted from Fw32_default_color_map.
3892 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3894 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3896 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3898 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3900 * keyboard.c (test_undefined): New function (bug#9751).
3901 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3903 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3905 * sysdep.c (init_sys_modes): Fix the check for the controlling
3906 terminal (Bug#6649).
3908 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3910 * dispextern.h (struct bidi_it): New member next_en_type.
3912 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3913 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3914 current character, check also for next_en_type being WEAK_EN.
3915 (bidi_resolve_weak): Don't enter the expensive loop if the current
3916 position is before next_en_pos. Record the bidi type of the first
3917 non-ET, non-BN character we find, in addition to its position.
3918 (bidi_level_of_next_char): Invalidate next_en_type when
3919 next_en_pos is over-stepped.
3921 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3923 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3924 * editfns.c: Rewrite current-time-zone so that it invokes
3925 the equivalent of (format-time-string "%Z") to get the time zone name.
3926 This fixes a bug when the time zone name contains characters that
3927 need converting from the system time locale to Emacs internal format.
3928 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3929 that patch fixed format-time-string to do the conversion, but
3930 I forgot to fix current-time-zone.
3931 (format_time_string): New function, containing most of
3932 what Fformat_time_string used to contain.
3933 (Fformat_time_string): Rewrite in terms of format_time_string.
3934 This doesn't change this function's behavior.
3935 (current-time-zone): Rewrite to use format_time_string.
3936 This fixes the bug reported by Michael Schierl in
3937 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3938 Jason Rumney's 2007-06-07 change worked around this bug, but
3940 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3942 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3944 * xdisp.c (start_display): If the character at POS is displayed
3945 via a display vector, reset IT->current.dpvec_index to zero.
3946 (try_window_reusing_current_matrix): If a line ends in a display
3947 vector or the next line starts in a display vector, continue
3948 redrawing the window even though the character position of
3949 start_row was reached.
3952 2011-10-18 Chong Yidong <cyd@gnu.org>
3954 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3955 with nobreak-char-display too.
3957 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3959 Fix part 3 of bug#9771.
3960 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3961 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3962 non-neutral characters if the current character is a paragraph
3963 separator (a.k.a. Newline). This avoids running the same
3964 expensive loop twice, once when we consume the preceding newline
3965 and the other time when the line actually needs to be displayed.
3966 Avoid the loop when we see neutrals on the base embedding level
3967 following a character whose directionality is the same as the
3968 paragraph's. This avoids running the expensive loop when a line
3969 ends in a long sequence of neutrals, like control characters.
3970 Add assertion against STRONG_AL type. Slightly rearrange code
3971 that determines the type of a neutral given the first non-neutral
3973 (bidi_level_of_next_char): Set next_en_pos to zero when
3974 invalidating its info.
3976 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3978 * xdisp.c (push_display_prop): Determine whether to record string
3979 or buffer position by IT->string, not by IT->method. Allow
3980 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3981 (move_it_vertically_backward): Don't look for character position
3982 immediately after the newline when in a continuation line.
3985 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3987 * window.c (coordinates_in_window): Rewrite and delabelize
3988 vertical border check. (Bug#5357) (Bug#9618)
3990 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3992 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3993 errors in XSetWindowBorder (bug#9310).
3995 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3997 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3998 avoid crash when xmalloc overrun checking is enabled.
4000 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4002 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4003 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4004 cursor motion with <left> and <right> arrow keys.
4006 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4007 some callers set that themselves.
4009 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4011 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4012 display string and the previous row comes from the same string and
4013 is empty. (Bug#9739) (Bug#9738)
4015 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4017 * doc.c (get_doc_string): Encode file name (bug#9735).
4019 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4021 * bidi.c (bidi_level_of_next_char):
4022 * xdisp.c (get_visually_first_element): Remove old incorrect
4023 comments regarding the Unicode Line Separator character.
4025 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4027 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4029 * alloc.c (Fgc_status): Do not access beyond zombies array
4030 boundary if nzombies > MAX_ZOMBIES.
4031 * alloc.c (dump_zombies): Add missing format specifier.
4033 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4035 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4036 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4038 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4039 Some packages use them to denote characters with modifiers.
4041 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4044 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4045 matching a pp-number. Rename parameter var to var1.
4047 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4049 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4051 2011-10-08 Glenn Morris <rgm@gnu.org>
4053 * callint.c (Fcall_interactively): Give a more explicit error for the
4054 'c' case with a non-character input. (Bug#8479)
4056 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4058 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4060 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4061 lines that are hscrolled on the left.
4063 * dispnew.c (buffer_posn_from_coords): Account for a possible
4064 presence of header-line. (Bug#4426)
4066 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4068 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4069 Don't advertise functionality which we discourage or doesn't work.
4071 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4073 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4074 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4075 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4076 this makes Emacs dump core during garbage collection on rare
4077 occasions. sizeof is obviously inferior to offsetof here, so
4078 stick with offsetof.
4079 (GC_POINTER_ALIGNMENT): New macro.
4080 (mark_memory): Omit 3rd (offset) arg; caller changed.
4081 Don't assume EMACS_INT alignment is the same as pointer alignment.
4083 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4085 * keyboard.c (read_key_sequence_remapped): New var.
4086 (read_key_sequence): Compute remapping in the right buffer.
4087 (command_loop_1): Use read_key_sequence's remapping directly.
4089 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4091 * dired.c (file_name_completion): Don't expand file name.
4092 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4093 before checking file name handler.
4095 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4096 they've been requested explicitly (bug#9591).
4098 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4100 * keymap.c (Fsingle_key_description): Use make_specified_string
4101 instead of build_string to build string from push_key_description.
4104 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4106 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4107 This fixes a Y2038 bug on 64-bit hosts.
4108 * buffer.c (reset_buffer):
4109 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4110 (Fclear_buffer_auto_save_failure):
4111 Use 0, not -1, to represent an unset failure time, since time_t
4112 might not be signed.
4114 Remove dependency on glibc malloc internals.
4115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4116 Move back here from lisp.h, but with their new implementations.
4117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4118 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4119 * charset.c (charset_table_init): New static var.
4120 (syms_of_charset): Use it instead of xmalloc. This removes a
4121 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4122 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4123 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4124 Move back to alloc.c.
4125 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4126 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4128 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4130 * nsterm.m (windowDidResize): Call x_set_window_size only when
4131 ns_in_resize is true. Otherwise set pixelwidth/height and
4132 call change_frame_size (Bug#9628).
4134 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4136 Port --enable-checking=all to Fedora 14 x86-64.
4137 * charset.c (syms_of_charset): Also account for glibc malloc's
4138 internal overhead when calculating the initial malloc maximum.
4140 Port --enable-checking=all to Fedora 14 x86.
4141 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4143 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4144 (overrun_check_realloc, overrun_check_free):
4145 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4146 That way, xmalloc returns a properly-aligned pointer even if
4147 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4148 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4149 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4150 into account when calculating the initial malloc maximum.
4151 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4152 Move here from alloc.c, so that charset.c can use it too.
4153 Properly align; the old code wasn't right for common 32-bit hosts
4154 when configured with --enable-checking=all.
4155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4156 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4158 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4160 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4163 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4165 * xdisp.c (compute_display_string_end): If there's no display
4166 string at CHARPOS, return -1.
4168 * bidi.c (bidi_fetch_char): When compute_display_string_end
4169 returns a negative value, treat the character as a normal
4170 character not covered by a display string. (Bug#9624)
4172 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4174 * lread.c (Fread_from_string): Fix typo in docstring.
4176 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4178 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4179 newline, reseat the iterator instead of bidi-iterating there one
4180 character at a time. (Bug#9610)
4181 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4182 TO_CHARPOS if the bidi iterator is at base embedding level.
4184 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4186 * lread.c (readevalloop): Use correct code for NBSP.
4187 (read1): Likewise. (Bug#9608)
4189 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4191 * dbusbind.c (Fdbus_register_signal): When service is not
4192 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4194 2011-09-25 Glenn Morris <rgm@gnu.org>
4196 * buffer.c (truncate-lines): Doc fix.
4198 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4200 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4201 (Fset_window_next_buffers): Doc fix.
4203 2011-09-24 Glenn Morris <rgm@gnu.org>
4205 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4207 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4209 Fix minor problems found by static checking.
4210 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4211 * indent.c (Fvertical_motion): Fix == vs = typo.
4213 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4215 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4216 Default value is now t. Doc fix.
4218 * indent.c (Fvertical_motion): Compute and apply the overshoot
4219 logic when moving up, not only when moving down. Fix the
4220 confusing name and values of the it_overshoot_expected variable;
4221 logic changes accordingly. (Bug#9254) (Bug#9549)
4223 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4224 CHARPOS is covered by a display string which includes newlines.
4225 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4226 is covered by a display string with embedded newlines.
4228 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4230 * dbusbind.c (Fdbus_register_signal): Add match rule to
4231 Vdbus_registered_objects_table. (Bug#9581)
4232 (Fdbus_register_method, Vdbus_registered_objects_table):
4235 2011-09-24 Jim Meyering <meyering@redhat.com>
4237 do not ignore write error for any output size
4238 The previous change was incomplete.
4239 While it makes emacs --batch detect the vast majority of stdout
4240 write failures, errors were still ignored whenever the output size is
4241 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4242 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4243 && echo FAIL: ignored write error
4244 FAIL: ignored write error
4245 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4246 && echo FAIL: ignored write error
4247 FAIL: ignored write error
4248 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4250 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4252 * emacs.c (Fkill_emacs): In noninteractive mode exit
4253 non-successfully if a write error occurred on stdout. (Bug#9574)
4255 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4257 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4260 * dispextern.h (struct it): Update the comment documenting what
4263 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4266 a display string, extend search for cursor position to end of row.
4267 (find_row_edges): If the row ends in a newline from a display
4268 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4269 Handle the case of a display string with multiple newlines.
4270 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4271 non-empty line. Fixes confusing cursor motion with arrow keys at
4272 the beginning of a line that starts with whitespace.
4274 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4279 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4281 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4284 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4286 * xdisp.c (display_line): Record maximum and minimum buffer
4287 positions even if no glyphs were produced (e.g., by a zero-width
4288 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4289 buffer positions that will be removed from the glyph row because
4291 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4292 column is beyond frame width: don't subtract 1 "pixel" when
4293 computing width of the stretch.
4294 (reseat_at_next_visible_line_start): Undo the change made on
4295 2011-09-17 that saved paragraph information and restored it after
4296 the call to `reseat'. (Bug#9545)
4298 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4300 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4301 and turn window cursor on if cleared (Bug#9415).
4303 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4305 * search.c (boyer_moore): Take unibyte characters from pattern
4306 literally. (Bug#9458)
4308 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4310 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4312 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4314 Fix minor problem found by static checking.
4315 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4316 initialized, to pacify gcc -Wuninitialized.
4318 * fileio.c: Report proper errno when syscall falls.
4319 (Finsert_file_contents): Save and restore errno,
4320 so that report_file_error outputs the correct diagnostic.
4321 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4323 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4325 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4327 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4329 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4332 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4334 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4335 about the current paragraph and restore it after the call to reseat.
4337 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4338 (bidi_find_paragraph_start): Search back for paragraph beginning
4339 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4340 (bidi_move_to_visually_next): Only trigger paragraph-related
4341 computations when the last character is a newline or at EOB, not
4342 just any NEUTRAL_B. (Bug#9470)
4344 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4345 truncated lines if point is covered by a display string. (Bug#9524)
4347 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4349 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4350 (cons_to_x_long): New function.
4351 (lisp_data_to_selection_data): Use it. Correct the test for
4352 short-versus-long data; it was negated. Break out of vector
4353 loop, for efficiency, when a long datum is discovered.
4355 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4357 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4359 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4361 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4362 GCC PR/17406) by declaring this function with external scope.
4364 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4366 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4367 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4369 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4371 * editfns.c (Fformat): Correctly handle text properties on "%%".
4373 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4375 * xterm.c (x_draw_composite_glyph_string_foreground):
4376 * w32term.c (x_draw_composite_glyph_string_foreground):
4377 * term.c (encode_terminal_code):
4378 * composite.c (composition_update_it, get_composition_id):
4379 * xdisp.c (get_next_display_element)
4380 (fill_composite_glyph_string): Add comments about special meaning
4381 of TAB characters in a composition.
4383 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4385 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4386 This occurs when processing a multibyte format.
4387 Problem reported by Wolfgang Jenker.
4389 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4391 * xdisp.c (try_cursor_movement): Only check for exact match if
4392 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4394 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4396 Remove unused external symbols.
4397 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4398 * xdisp.c (calc_pixel_width_or_height): Now static.
4399 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4400 * indent.c (check_display_width):
4401 * w32term.c: Fix comment to match code.
4402 * xterm.c, xterm.h (x_catching_errors): Remove.
4404 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4406 * xselect.c: Use signed conversions more consistently (Bug#9498).
4407 (selection_data_to_lisp_data): Assume incoming selection data are
4408 signed integers, not unsigned. This is to be consistent with
4409 outgoing selection data, which was modified to use signed integers
4410 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4411 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4412 expects long, not unsigned long.
4414 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4416 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4417 computation of loop end. Reported by Johan Bockgård
4420 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4422 * frame.c (Fother_visible_frames_p): Function deleted.
4424 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4426 * indent.c (compute_motion): Process display vector front to back
4427 rather than the other way around. (Bug#2496)
4429 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4431 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4433 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4435 * minibuf.c (Fread_from_minibuffer): Doc fix.
4437 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4439 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4442 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4444 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4445 value for non-existent files.
4447 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4449 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4450 set its "size" to -1. This will set the modtime_size field of
4451 the corresponding buffer to -1, which is what
4452 verify-visited-file-modtime expects for files that do not exist.
4455 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4457 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4459 * lisp.h: ... from here. push_key_description is no longer
4460 defined in keyboard.c, so its declaration should not be in
4461 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4462 logically belongs with push_key_description.
4464 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4466 * buffer.h: Include <sys/types.h> instead of <time.h>.
4467 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4468 Problem reported by Herbert J. Skuhra.
4470 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4472 * xml.c (parse_region): Make the parsing work for
4473 non-comment-starting XML files again (bug#9144).
4475 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4477 * image.c (gif_load): Fix calculation of bottom and right corner.
4480 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4482 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4483 redisplay in small windows.
4485 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4487 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4489 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4491 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4492 Operate on live windows only.
4494 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4496 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4498 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4500 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4501 only under bidi iteration.
4503 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4505 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4507 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4509 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4510 Without this fix, the command to link temacs failed due to an
4511 undefined symbol __builtin_isnan. This is because
4512 /usr/include/iso/math_c99.h #defines isnan(x) to
4513 __builtin_isnan(x), but the bundled gcc, which identifies itself
4514 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4516 * floatfns.c (isnan): #undef, and then #define to a clone of
4518 (Fisnan): Always define, since it's always available now.
4519 (syms_of_floatfns): Always define isnan at the Lisp level.
4521 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4523 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4525 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4527 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4528 The previous code assumed that file offsets (off_t values) fit in
4529 EMACS_INT variables, which is not true on typical 32-bit hosts.
4530 The code messed up by falsely reporting buffer overflow in cases
4531 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4532 when "big" contains more than 2**29 bytes, even though this
4533 inserts just one byte and does not overflow the buffer.
4534 (Finsert_file_contents): Store file offsets as off_t
4535 values, not as EMACS_INT values. Check for overflow when
4536 converting between EMACS_INT and off_t. When checking for
4537 buffer overflow or for overlap, take the offsets into account.
4538 Don't use EMACS_INT for small values where int suffices.
4539 When checking for overlap, fix a typo: ZV was used where
4540 ZV_BYTE was intended.
4541 (Fwrite_region): Don't assume off_t fits into 'long'.
4542 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4544 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4546 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4548 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4550 sprintf-related integer and memory overflow issues (Bug#9412).
4552 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4553 (esprintf, exprintf, evxprintf): New functions.
4554 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4555 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4556 (modify_event_symbol): Do not assume that the length of
4557 name_alist_or_stem is safe to alloca and fits in int.
4558 (Fexecute_extended_command): Likewise for function name and binding.
4559 (Frecursion_depth): Wrap around reliably on integer overflow.
4560 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4561 since some callers pass EMACS_INT values.
4562 (Fsingle_key_description): Don't crash if symbol name contains more
4563 than MAX_ALLOCA bytes.
4564 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4565 (get_minibuffer): Arg is now EMACS_INT, not int.
4566 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4567 (esprintf, exprintf, evxprintf): New decls.
4568 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4570 * dbusbind.c (signature_cat): New function.
4571 (xd_signature, Fdbus_register_signal):
4572 Do not overrun buffer; instead, report string overflow.
4574 * dispnew.c (add_window_display_history): Don't overrun buffer.
4575 Truncate instead; this is OK since it's just a log.
4577 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4578 even if the time zone offset is outlandishly large.
4579 Don't mishandle offset == INT_MIN.
4581 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4582 when creating daemon; the previous buffer-overflow check was incorrect.
4584 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4585 which has the guts of the old verror function.
4587 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4588 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4590 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4591 (font_unparse_xlfd): Don't blindly alloca long strings.
4592 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4593 fits in int, when using sprintf. Use single snprintf to count
4594 length of string rather than counting it via multiple sprintfs;
4595 that's simpler and more reliable.
4596 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4597 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4598 sprintf, in case result does not fit in int.
4600 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4601 (fontset_from_font): Print it.
4603 * frame.c (tty_frame_count): Now printmax_t, not int.
4604 (make_terminal_frame, set_term_frame_name): Print it.
4605 (x_report_frame_params): In X, window IDs are unsigned long,
4606 not signed long, so print them as unsigned.
4607 (validate_x_resource_name): Check for implausibly long names,
4608 and don't assume name length fits in 'int'.
4609 (x_get_resource_string): Don't blindly alloca invocation name;
4610 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4613 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4614 (xg_check_special_colors, xg_set_geometry):
4615 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4617 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4618 Use esprintf, not sprintf, in case result does not fit in int.
4620 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4621 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4622 it as a large positive number.
4623 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4624 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4626 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4627 in case result does not fit in int.
4629 * print.c (float_to_string): Detect width overflow more reliably.
4630 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4631 buffer overrun. Don't assume list length fits in 'int'. Treat
4632 print length of 0 as 0, not as infinity; to be consistent with other
4633 uses of print length in this function. Don't overflow print length
4634 index. Don't assume hash table size fits in 'long', or that
4635 vectorlike size fits in 'unsigned long'.
4637 * process.c (make_process): Use printmax_t, not int, to format
4638 process-name gensyms.
4640 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4642 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4643 to avoid potential buffer overrun.
4645 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4646 if X resource line is longer than 512 bytes.
4648 * xfns.c (x_window): Make sprintf buffer a bit bigger
4649 to avoid potential buffer overrun.
4651 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4653 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4655 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4657 Integer overflow fixes for scrolling, etc.
4658 Without these, Emacs silently mishandles large integers sometimes.
4659 For example, "C-u 4294967297 M-x recenter" was treated as if
4660 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4662 * xdisp.c (try_window_id): Check Emacs fixnum range before
4663 converting to 'int'.
4665 * window.c (window_scroll_line_based, Frecenter):
4666 Check that an Emacs fixnum is in range before assigning it to 'int'.
4667 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4668 values converted from Emacs fixnums.
4669 (Frecenter): Don't wrap around a line count if it is out of 'int'
4670 range; instead, treat it as an extreme value.
4671 (Fset_window_configuration, compare_window_configurations):
4672 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4674 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4675 that can exceed INT_MAX. Check that EMACS_INT value is in range
4676 before assigning it to the (possibly-narrower) index.
4677 (match_limit): Don't assume that a fixnum can fit in 'int'.
4679 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4682 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4683 (Fvertical_motion): Don't wrap around LINES values that don't fit
4684 in 'int'. Instead, treat them as extreme values. This is good
4685 enough for windows, which can't have more than INT_MAX lines anyway.
4687 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4689 * Require libxml/parser.h to avoid compilation warning.
4691 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4693 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4694 since this reportedly can destroy thread storage.
4696 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4698 * syntax.c (find_defun_start): Update all cache variables if
4699 exiting early (Bug#9401).
4701 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4703 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4705 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4706 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4707 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4709 * term.c (tty_append_glyph): New function.
4710 (produce_stretch_glyph): Static function and its prototype deleted.
4712 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4715 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4717 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4718 when checking :margin (Bug#9390).
4719 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4720 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4721 so that the name doesn't mislead. All uses changed.
4723 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4725 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4728 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4730 * xdisp.c (move_it_to): Don't bail out early when reaching
4731 position beyond to_charpos, if we are scanning backwards.
4732 (move_it_vertically_backward): When DY == 0, make sure we get to
4733 the first character in the line after the newline.
4735 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4737 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4738 (ccl_driver): Do not generate an out-of-range pointer.
4739 (Fccl_execute_on_string): Remove unnecessary check for
4740 integer overflow, noted by Stefan Monnier in
4741 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4742 Remove a FIXME that didn't need fixing.
4743 Simplify the newly-introduced buffer reallocation code.
4745 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4747 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4749 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4751 Integer and memory overflow issues (Bug#9196).
4753 * doc.c (get_doc_string): Rework so that
4754 get_doc_string_buffer_size is the actual buffer size, rather than
4755 being 1 less than the actual buffer size; this makes xpalloc more
4758 * image.c (x_allocate_bitmap_record, cache_image):
4759 * xselect.c (Fx_register_dnd_atom):
4760 Simplify previous changes by using xpalloc.
4762 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4763 since either will do and ptrdiff_t is convenient with xpalloc.
4765 * charset.c (charset_table_size)
4766 (struct charset_sort_data.priority): Now ptrdiff_t.
4767 (charset_compare): Don't overflow if priorities differ greatly.
4768 (Fsort_charsets): Don't assume list length fits in int.
4769 Check for size-calculation overflow when allocating sort data.
4770 (syms_of_charset): Allocate an initial charset table that is
4771 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4773 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4775 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4776 The actual value is always <= INT_MAX, and leaving it unsigned made
4777 overflow checking harder.
4779 * dispextern.h (struct glyph_matrix.rows_allocated)
4780 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4781 with xpalloc. The values are still always <= INT_MAX.
4783 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4785 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4786 (SAFE_NALLOCA): New macro.
4788 * region-cache.c (struct boundary.pos, find_cache_boundary)
4789 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4790 (set_cache_region, invalidate_region_cache)
4791 (revalidate_region_cache, know_region_cache, region_cache_forward)
4792 (region_cache_backward, pp_cache):
4793 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4794 so that ptrdiff_t * can be passed to xpalloc.
4795 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4796 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4797 (pp_cache): Don't assume cache_len fits in int.
4798 * region-cache.h: Adjust extern decls to match.
4800 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4801 EMACS_INT, since either will do, for xpalloc.
4803 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4804 (xnmalloc, xnrealloc, xpalloc): New functions.
4806 * bidi.c (bidi_shelve_header_size): New constant.
4807 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4808 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4810 * bidi.c (bidi_cache_shrink):
4811 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4813 Don't update size of array until after memory allocation succeeds,
4814 because xmalloc/xrealloc may not return.
4815 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4816 now that we have proper integer overflow checking.
4817 (record_overlay_string, overlay_strings): Catch overflows when
4818 calculating size of overlay_str_buf.
4820 * callproc.c (Fcall_process): Check for size overflow when
4821 calculating size of args2.
4822 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4823 Normally we prefer signed values, but sticking with ptrdiff_t would
4824 require adding more-complicated checks.
4826 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4827 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4828 Redo buffer-overflow calculations to avoid integer overflow.
4829 Add a FIXME comment where memory seems to be over-allocated.
4831 * character.c (Fstring): Check for size-calculation overflow.
4833 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4834 unnecessary integer overflow. Check for size overflow.
4835 (encode_coding_object): Don't update size until xmalloc succeeds.
4837 * composite.c (get_composition_id): Check for overflow in glyph
4838 length calculations.
4840 Integer and memory overflow fixes for display code.
4841 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4842 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4843 (scrolling_window): Check for overflow in size calculations.
4844 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4845 Don't assume glyph table len fits in int.
4846 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4847 (row_table_size): Now ptrdiff_t, not int.
4848 (scrolling_window): Avoid overflow in size calculations.
4849 Don't update size until allocation succeeds.
4850 * fns.c (concat): Check for overflow in size calculations.
4851 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4852 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4853 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4855 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4856 (get_doc_string): Check for size calculation overflow.
4857 Don't update size until allocation succeeds.
4858 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4859 EMACS_INT, where ptrdiff_t will do.
4860 (Fsubstitute_command_keys): Check for string overflow.
4862 * editfns.c (set_time_zone_rule): Don't assume environment length
4864 (message_length): Now ptrdiff_t, not int.
4865 (Fmessage_box): Don't update size until allocation succeeds.
4866 Don't assume message length fits in int.
4867 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4869 * emacs.c (main): Do not reallocate argv, since there is a null at
4870 the end that can be overwritten, and this way there's no need to
4871 worry about size-calculation overflow.
4872 (sort_args): Check for size-calculation overflow.
4874 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4876 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4878 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4879 (x_set_scroll_bar_width, x_figure_window_size):
4880 Check for integer overflow.
4881 (x_set_alpha): Do not assume XINT fits in int.
4883 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4884 This is for the members text_lines, text_cols, total_lines, total_cols,
4885 where the system imposes an 'int' limit.
4887 * fringe.c (Fdefine_fringe_bitmap):
4888 Don't update size until alloc works.
4890 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4891 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4893 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4894 Check for size-calculation overflow.
4895 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4896 do, as we prefer signed integers.
4897 (id_to_widget.max_size, id_to_widget.used)
4898 (xg_store_widget_in_map, xg_remove_widget_from_map)
4899 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4900 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4901 Use and return ptrdiff_t, not int.
4902 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4903 * gtkutil.h: Change prototypes to match the above.
4905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4906 are duplicate now that they've been promoted to lisp.h.
4907 (x_allocate_bitmap_record, x_alloc_image_color)
4908 (make_image_cache, cache_image, xpm_load):
4909 Don't update size until alloc is done.
4910 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4912 Check for size calculation overflow.
4913 (ct_colors_allocated_max): New constant.
4914 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4917 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4918 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4919 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4920 Use ptrdiff_t, not int, to count maps.
4921 (read_char_minibuf_menu_prompt): Check for overflow in size
4922 calculations. Don't update size until allocation succeeds.
4923 Redo calculations to avoid overflow.
4924 * keyboard.h: Change prototypes to match the above.
4926 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4928 (current_minor_maps): Check for size calculation overflow.
4929 * keymap.h: Change prototypes to match the above.
4931 * lread.c (read1, init_obarray): Don't update size until alloc done.
4933 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4934 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4936 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4937 Now ptrdiff_t, not int.
4938 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4939 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4941 * process.c (Fnetwork_interface_list): Check for overflow
4942 in size calculation.
4944 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4946 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4947 overflow. Don't bother calling xmalloc when xrealloc will do.
4949 * search.c (Freplace_match): Check for size calculation overflow.
4950 (Fset_match_data): Don't assume list lengths fit in 'int'.
4952 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4953 for command line length. Do not attempt to address one before the
4954 beginning of an array, as that's not portable.
4956 * term.c (max_frame_lines): Remove; unused.
4957 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4959 (encode_terminal_code, calculate_costs): Check for size
4960 calculation overflow.
4961 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4962 table lengths and related sizes. Don't update size until alloc
4963 done. Redo calculations to avoid overflow.
4964 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4966 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4967 subtracting pointers.
4968 (gobble_line): Check for overflow more carefully. Don't update size
4971 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4972 Don't update size until alloc done.
4973 Redo size calculations to avoid overflow.
4974 Check for size calculation overflow.
4975 (main) [DEBUG]: Fix typo in invoking tparam1.
4977 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4978 Use ptrdiff_t, not int, for sizes.
4979 (store_mode_line_noprop_char): Don't update size until alloc done.
4981 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4982 Use ptrdiff_t, not int, for sizes.
4983 (Finternal_make_lisp_face, cache_face):
4984 Check for size calculation overflow.
4985 (cache_face): Treat size calculation overflows as if they were
4986 memory exhaustion (the usual treatment), rather than aborting.
4988 * xfns.c (x_encode_text, x_set_name_internal)
4989 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4990 sizes, since they can exceed INT_MAX in size. Check for size
4991 calculation overflow.
4993 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4994 (xg_select): Check for size calculation overflow.
4995 Don't update size until alloc done.
4997 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4998 as sprintf is limited to int lengths.
5000 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5001 (X_LONG_MIN): New macros.
5002 Use them to make the following changes clearer.
5003 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5004 This change doesn't affect the value now, but it may help remind
5005 future maintainers not to raise the value too much later.
5006 (SELECTION_QUANTUM): Remove, replacing with ...
5007 (selection_quantum): ... new function, which avoids overflow.
5009 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5010 assumption that selection length fits in 'int'.
5011 (x_reply_selection_request, x_handle_selection_request)
5012 (x_get_window_property, receive_incremental_selection)
5013 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5014 (lisp_data_to_selection_data, clean_local_selection_data):
5015 Use ptrdiff_t, not int, to record length of selection.
5016 (x_reply_selection_request, x_get_window_property)
5017 (receive_incremental_selection, x_property_data_to_lisp):
5018 Redo calculations to avoid overflow.
5019 (x_reply_selection_request): When sending hint, ceiling it at
5020 X_LONG_MAX rather than relying on wraparound overflow to send
5022 (x_get_window_property, receive_incremental_selection)
5023 (lisp_data_to_selection_data, x_property_data_to_lisp):
5024 Check for size-calculation overflow.
5025 (x_get_window_property, receive_incremental_selection)
5026 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5027 Don't store size until memory allocation succeeds.
5028 (x_get_window_property): Plug memory leak on memory exhaustion.
5029 Don't double-block input; malloc is safe here. Don't assume 2**34
5030 - 4 fits in unsigned long. Add an xassert to check
5031 XGetWindowProperty overflow. Be more careful about overflow
5032 calculations, and distinguish size from memory overflow better.
5033 (receive_incremental_selection): When tracing, don't assume
5034 unsigned int is less than INT_MAX.
5035 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5036 harmful) conversions of unsigned short to int.
5037 (lisp_data_to_selection_data): Don't assume that integers
5038 in the range -65535 through -1 fit in an X unsigned short.
5039 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5040 result parameters unless successful. Rely on cons_to_unsigned
5041 to report problems with elements; the old code wasn't right anyway.
5042 (x_check_property_data): Check for int overflow; we cannot use
5043 a wider type due to X limits.
5044 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5046 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5048 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5049 (x_term_init): Check for size calculation overflow.
5050 (x_color_cells): Don't store size until memory allocation succeeds.
5051 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5052 Don't assume alloca size is less than MAX_ALLOCA.
5053 (x_term_init): Don't assume length fits in int (sprintf is limited
5056 Use ptrdiff_t for composition IDs.
5057 * character.c (lisp_string_width):
5058 * composite.c (composition_table_size, n_compositions)
5059 (get_composition_id, composition_gstring_from_id):
5060 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5062 * window.c (Frecenter):
5063 Use ptrdiff_t, not int, for composition IDs.
5064 * composite.c (get_composition_id): Check for integer overflow.
5065 * composite.h: Adjust prototypes to match the above changes.
5067 Use ptrdiff_t for hash table indexes.
5068 * category.c (hash_get_category_set):
5069 * ccl.c (ccl_driver):
5070 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5071 * coding.c (coding_system_charset_list, detect_coding_system):
5072 * coding.h (struct coding_system.id):
5073 * composite.c (get_composition_id, gstring_lookup_cache):
5074 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5075 * image.c (xpm_get_color_table_h):
5076 * lisp.h (hash_lookup, hash_put):
5077 * minibuf.c (Ftest_completion):
5078 Use ptrdiff_t for hash table indexes, not int (which is too
5079 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5080 32-bit --with-wide-int hosts).
5082 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5083 Add a FIXME comment about memory leaks.
5084 (syms_of_charset): Don't assume xmalloc returns.
5086 Don't assume that stated character widths fit in int.
5087 * character.c (Fchar_width, c_string_width, lisp_string_width):
5088 * character.h (CHAR_WIDTH):
5089 * indent.c (MULTIBYTE_BYTES_WIDTH):
5090 Use sanitize_char_width to avoid undefined and/or bad behavior
5091 with outlandish widths.
5092 * character.h (sanitize_tab_width): Rename from sanitize_width,
5093 now that we have two such functions. All uses changed.
5094 (sanitize_char_width): New inline function.
5096 Don't assume that tab-width fits in int.
5097 * character.h (sanitize_width): New inline function.
5098 (SANE_TAB_WIDTH): New macro.
5099 (ASCII_CHAR_WIDTH): Use it.
5100 * indent.c (sane_tab_width): Remove. All uses replaced by
5101 SANE_TAB_WIDTH (current_buffer).
5102 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5104 * fileio.c: Integer overflow issues with file modes.
5105 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5107 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5108 Remove unreachable code.
5109 (read_hex, load_charset_map_from_file): Check for integer overflow.
5111 * xterm.c: Don't go over XClientMessageEvent limit.
5112 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5113 (x_send_scroll_bar_event): Likewise. Check that the size does not
5114 exceed limits imposed by XClientMessageEvent, as well as the usual
5115 ptrdiff_t and size_t limits.
5117 * keyboard.c: Overflow, signedness and related fixes.
5118 (make_lispy_movement): Use same integer type in forward decl
5119 that is used in the definition.
5120 (read_key_sequence, keyremap_step):
5121 Change bufsize argument back to int, undoing my 2011-03-30 change.
5122 We prefer signed types, and int is wide enough here.
5123 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5124 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5125 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5126 length, not size_t. Use ptrdiff_t for index, not int.
5127 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5128 possibility of integer overflow.
5130 Overflow, signedness and related fixes for images.
5132 * dispextern.h (struct it.stack[0].u.image.image_id)
5133 (struct_it.image_id, struct image.id, struct image_cache.size)
5134 (struct image_cache.used, struct image_cache.ref_count):
5135 * gtkutil.c (update_frame_tool_bar):
5136 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5137 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5138 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5139 * nsmenu.m (update_frame_tool_bar):
5140 * xdisp.c (calc_pixel_width_or_height):
5141 * xfns.c (image_cache_refcount):
5142 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5143 on typical 64-bit hosts.
5145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5146 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5147 Omit unnecessary casts to int.
5148 (parse_image_spec): Check that integers fall into 'int' range
5149 when the callers expect that.
5150 (image_ascent): Redo ascent calculation to avoid int overflow.
5151 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5152 (lookup_image): Remove unnecessary tests.
5153 (xbm_image_p): Locals are now of int, not EMACS_INT,
5154 since parse_image_check makes sure they fit into int.
5155 (png_load, gif_load, svg_load_image):
5156 Prefer int to unsigned where either will do.
5157 (tiff_handler): New function, combining the cores of the
5158 old tiff_error_handler and tiff_warning_handler.
5159 This function is rewritten to use vsnprintf and thereby avoid
5160 stack buffer overflows. It uses only the features of vsnprintf
5161 that are common to both POSIX and native Microsoft.
5162 (tiff_error_handler, tiff_warning_handler): Use it.
5163 (tiff_load, gif_load, imagemagick_load_image):
5164 Don't assume :index value fits in 'int'.
5165 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5166 (imagemagick_load_image): Check that crop parameters fit into
5167 the integer types that MagickCropImage accepts. Don't assume
5168 Vimagemagick_render_type has a nonnegative value. Don't assume
5169 size_t fits in 'long'.
5170 (gs_load): Use printmax_t to print the widest integers possible.
5171 Check for integer overflow when computing image height and width.
5173 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5175 * xdisp.c (redisplay_window): Don't force window start if point
5176 will be invisible in the resulting window. (Bug#9324)
5178 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5180 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5181 the display spec is of the form `(space ...)'.
5182 (handle_display_spec): Return the value returned by
5183 handle_single_display_spec, not just 1 or zero.
5184 (handle_single_display_spec): If the display spec is of the form
5185 `(space ...)', and specifies display in the text area, return 2
5187 (try_cursor_movement): Check for the need to scroll more
5188 accurately, and prefer exact match for point under bidi.
5189 Don't advance `row' beyond the last row of the window.
5191 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5192 into disp_prop; all users changed.
5194 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5195 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5196 for the text covered by the display property.
5198 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5200 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5201 Change return value to nil.
5202 (Frecord_buffer): Delete unused function.
5204 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5206 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5207 buffers, return left-to-right.
5208 (set_cursor_from_row): Consider candidate row a win if its glyph
5209 represents a newline and point is on that newline. Fixes cursor
5210 positioning on the newline at EOL of R2L text within L2R
5211 paragraph, and vice versa.
5212 (try_cursor_movement): Check continued rows, in addition to
5213 continuation rows. Fixes unwarranted scroll when point enters a
5214 continued line of R2L text within an L2R paragraph, or vice versa.
5215 (cursor_row_p): Consider the case of point being equal to
5216 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5217 from the end of a short line to the beginning of a continued line
5218 of R2L text within L2R paragraph.
5219 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5220 composed characters.
5222 * bidi.c (bidi_check_type): Use xassert.
5223 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5226 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5228 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5231 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5233 * nsfont.m (ns_otf_to_script): Fix typo.
5235 2011-08-22 Kenichi Handa <handa@m17n.org>
5237 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5238 extra slot even if the purpose is char-code-property-table.
5240 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5242 * xdisp.c (redisplay_window): When computing centering_position,
5243 account for the height of the header line. (Bug#8874)
5245 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5246 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5247 candidate is selected by the mouse, and that candidate has a
5248 composed character under the mouse.
5250 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5251 coordinates reported by pos-visible-in-window-p for a composed
5252 character in column zero.
5254 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5256 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5258 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5260 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5261 consider it a hit if to_charpos is anywhere in the range of the
5262 composed buffer positions.
5264 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5266 * image.c (gif_load): Don't assume that each subimage has the same
5267 dimensions as the base image. Handle disposal method that is
5268 "undefined" by the gif spec (Bug#9335).
5270 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5272 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5273 (Fcondition_case): Document `debug' symbol in error handler.
5275 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5277 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5278 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5279 from an Org mode buffer to a Speedbar frame.
5281 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5282 a composition, take its buffer position from IT->cmp_it.charpos.
5283 Fixes cursor positioning at the beginning of a line that begins
5284 with a composed character.
5286 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5288 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5289 character bidirectional type, use STRONG_L instead. Fixes crashes
5290 in a buffer produced by `describe-categories'.
5292 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5293 members before the level stack, so they would be saved and
5294 restored when copying iterator state. Fixes incorrect reordering
5295 around TABs covered by display properties.
5297 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5299 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5301 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5303 * eval.c (internal_condition_case, internal_condition_case_1)
5304 (internal_condition_case_2, internal_condition_case_n):
5305 Remove unnecessary aborts (Bug#9081).
5307 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5309 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5310 has no `load' handler, try opening the file locally. (Bug#9311)
5312 2011-08-16 Ken Brown <kbrown@cornell.edu>
5314 * gmalloc.c: Expand comment.
5316 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5318 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5319 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5321 2011-08-16 Ken Brown <kbrown@cornell.edu>
5323 Fix memory allocation problems in Cygwin build (Bug#9273).
5325 * unexcw.c ( __malloc_initialized): Declare external variable.
5326 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5328 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5330 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5332 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5334 [CYGWIN] (special_realloc): New function.
5335 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5336 requests to realloc storage in the static heap.
5338 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5340 * bidi.c (bidi_initialize): Remove unused local.
5342 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5345 * biditype.h: Remove file.
5346 * makefile.w32-in ($(BLD)/bidi.$(O)):
5347 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5349 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5351 * chartab.c: Improve commentary for the uniprop_table API.
5353 * bidi.c (bidi_paragraph_init): Support zero value of
5354 bidi_ignore_explicit_marks_for_paragraph_level.
5355 (bidi_initialize): Use uniprop_table instead of including
5356 biditype.h and bidimirror.h.
5358 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5359 coordinates of the iterator when restoring from ppos_it.
5362 2011-08-14 Kenichi Handa <handa@m17n.org>
5364 * process.c (create_process): Call setup_process_coding_systems
5365 after the pid of the process is set to -1 (Bug#8162).
5367 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5369 * xdisp.c (move_it_in_display_line_to): Don't invoke
5370 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5371 ppos_it. Fixes vertical cursor motion when line beginning is
5372 covered by an image. (Bug#9296)
5374 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5376 * nsterm.h (ns_run_ascript): Declare.
5377 (NSAPP_DATA2_RUNASSCRIPT): Define.
5379 * nsfns.m (as_script, as_result, as_status): New static variables.
5380 (ns_run_ascript): New function.
5381 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5382 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5383 the event loop. Get status from as_status (Bug#7276).
5385 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5386 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5387 the event loop (Bug#7276).
5389 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5391 * gnutls.c (QCgnutls_bootprop_priority)
5392 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5393 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5394 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5395 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5396 (QCgnutls_bootprop_verify_hostname_error)
5397 (QCgnutls_bootprop_callbacks_verify): Rename from
5398 Qgnutls_bootprop_..., all uses changed.
5400 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5403 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5405 * xfaces.c (Qframe_set_background_mode): Now static.
5406 * dispextern.h (Qframe_set_background_mode): Remove decl.
5408 * process.c (Fnetwork_interface_info): Declare local only if needed.
5410 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5412 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5413 (Fnetwork_interface_list): Allocate in increments of bytes instead
5414 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5415 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5417 (struct ifflag_def): notrailers is smart on OSX.
5418 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5419 Get hardware address with getifaddrs if available.
5421 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5423 * xdisp.c (iterate_out_of_display_property): xassert that
5424 IT->position is set to within IT->object's boundaries. Break from
5425 the loop as soon as EOB is reached; avoids infloops in redisplay
5426 when IT->position is set up wrongly due to some bug.
5427 Set IT->current to match the bidi iterator unconditionally.
5428 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5429 entry. Force push_it to save on the stack the current
5430 buffer/string position, to be restored by pop_it. Fix flags in
5431 the iterator structure wrt the object coming from a display
5432 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5433 properties. (Bug#9284)
5435 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5437 * fontset.c (fontset_get_font_group): Add proper type checks.
5440 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5442 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5443 and LC_VERSION_MIN_MACOSX.
5444 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5445 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5447 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5449 * xdisp.c (forward_to_next_line_start): Allow to use the
5450 no-display-properties-and-no-overlays under bidi display.
5451 Set disp_pos in the bidi iterator to avoid searches for display
5452 properties and overlays.
5454 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5456 * editfns.c (Fset_time_zone_rule): Document relationship with the
5459 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5460 the font entity extracted from the cache (Bug#8109).
5462 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5464 * composite.c (autocmp_chars): Don't reset point. That is done by
5465 restore_point_unwind (Bug#5984).
5467 2011-08-07 Juri Linkov <juri@jurta.org>
5469 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5470 to show the arg `TIME' instead of `TIMEVAL'.
5472 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5474 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5475 display property strides EOL and includes a newline, as in
5476 longlines-mode. (Bug#9254)
5477 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5478 word-wrap under bidirectional display. (Bug#9224)
5480 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5481 is non-zero, even if the data buffer is NULL. Fixes a crash in
5482 vertical-motion with longlines-mode. (Bug#9254)
5484 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5486 * bidi.c <bidi_cache_total_alloc>: Now static.
5487 (bidi_initialize): Initialize bidi_cache_total_alloc.
5489 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5492 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5493 amount allocated this far in `bidi_cache_total_alloc'.
5494 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5495 non-zero, only free the data buffer without restoring the cache
5496 contents. All callers changed.
5498 * dispextern.h (bidi_unshelve_cache): Update prototype.
5500 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5501 (move_it_in_display_line, move_it_to)
5502 (move_it_vertically_backward, move_it_by_lines): Replace the call
5503 to xfree to an equivalent call to bidi_unshelve_cache.
5504 (move_it_in_display_line_to): Fix logic of returning
5505 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5507 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5509 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5510 came from a string character with a `cursor' property. (Bug#9229)
5512 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5514 * Makefile.in (LIB_PTHREAD): New variable.
5515 (LIBES): Add LIB_PTHREAD (Bug#9216).
5517 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5518 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5520 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5522 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5524 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5526 * xterm.c (x_find_topmost_parent): New function.
5527 (x_set_frame_alpha): Find topmost parent window with
5528 x_find_topmost_parent and set the property there also (bug#9181).
5529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5531 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5533 * callproc.c (Fcall_process): Avoid vfork clobbering
5534 the local vars buffer, coding_systems, current_dir.
5536 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5540 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5543 so that it is not optimized away.
5545 * xdisp.c (compute_display_string_pos): Remove unused local.
5547 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5549 Fix slow cursor motion and scrolling in large buffers with
5550 selective display, like Org Mode buffers. (Bug#9218)
5552 * dispextern.h (struct bidi_it): New member disp_prop_p.
5554 * xdisp.c: Remove one-slot cache of display string positions.
5555 (compute_display_string_pos): Accept an additional argument
5556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5557 for a display string or property. If found, set DISP_PROP_P
5560 * bidi.c (bidi_fetch_char): Accept an additional argument
5561 DISP_PROP_P, and pass it to compute_display_string_pos.
5562 Only handle text covered by a display string if DISP_PROP_P is returned
5563 non-zero. All callers of bidi_fetch_char changed.
5565 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5569 2010-12-03 Don March <don@ohspite.net>
5571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5572 last character M-[char] is translated to ESC [char] (bug#7541).
5574 2011-08-02 Kenichi Handa <handa@m17n.org>
5576 * lisp.h (uniprop_table): Extern it.
5578 * chartab.c (uniprop_table): Make it non-static.
5580 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5582 * xdisp.c (forward_to_next_line_start): Accept additional argument
5583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5585 (reseat_at_next_visible_line_start): Use the bidi iterator state
5586 returned by forward_to_next_line_start to restore the state of
5587 it->bidi_it after backing up to previous newline. (Bug#9212)
5589 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5591 * regex.c (re_comp): Protoize.
5592 (re_exec): Fix return type.
5593 (regexec): Fix type of `ret'. (Bug#9203)
5595 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5598 This is needed if max-image-size is a floating-point number.
5600 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5602 * print.c (print_object): Print empty symbol as ##.
5604 * lread.c (read1): Read ## as empty symbol.
5606 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5609 setting frame foreground color (Bug#9175).
5610 (x_set_background_color): Likewise.
5612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5613 contents (Bug#9176).
5614 (EmacsTooltip -init): Remove bezels and add shadows to
5617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5618 or scroll bar (Bug#8470).
5620 * nsfont.m (nsfont_open): Remove assignment to voffset and
5621 unnecessary vars hshink, expand, hd, full_height, min_height.
5622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5624 * nsterm.h (nsfont_info): Remove voffset field.
5626 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5628 Implement strike-through and overline on NextStep (Bug#8863).
5630 * nsfont.m (nsfont_open): Use underline position provided by font,
5631 instead of hard-coded value of 2.
5632 (nsfont_draw): Call ns_draw_text_decoration instead.
5634 * nsterm.h: Add declaration for ns_draw_text_decoration.
5636 * nsterm.m (ns_draw_text_decoration): New function for drawing
5637 underline, overline, and strike-through.
5638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5639 ns_draw_text_decoration. Change treatment of cursor drawing to
5640 accommodate underlining, etc.
5642 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5647 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5650 Without this fix, if a signal arrives just after memory fills up,
5651 'malloc' might be invoked reentrantly.
5653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5654 In other words, assume that every image size is allowed, on non-X
5655 hosts. This assumption is probably wrong, but it lets Emacs compile.
5657 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5659 * regex.c (re_iswctype): Convert return values to boolean.
5661 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5663 * xdisp.c (compute_display_string_pos): Don't use cached display
5664 string position if the buffer had its restriction changed.
5667 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5671 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5673 Integer signedness and overflow and related fixes. (Bug#9079)
5675 * bidi.c: Integer size and overflow fixes.
5676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5680 (bidi_find_other_level_edge):
5681 Use ptrdiff_t instead of EMACS_INT where either will do.
5682 This works better on 32-bit hosts configured --with-wide-int.
5683 (bidi_cache_ensure_space): Check for size-calculation overflow.
5684 Use % rather than repeated addition, for better worst-case speed.
5685 Don't set bidi_cache_size until after xrealloc returns, because it
5687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5688 (bidi_cache_ensure_space): Also check that the bidi cache size
5689 does not exceed that of the largest Lisp string or buffer. See Eli
5690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5692 * alloc.c (__malloc_size_t): Remove.
5693 All uses replaced by size_t. See Andreas Schwab's note
5694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5696 * image.c: Improve checking for integer overflow.
5697 (check_image_size): Assume that f is nonnull, since
5698 it is always nonnull in practice. This is one less thing to
5699 worry about when checking for integer overflow later.
5700 (x_check_image_size): New function, which checks for integer
5701 overflow issues inside X.
5702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5703 This removes the need for a memory_full check.
5704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5706 (xbm_read_bitmap_data): Change locals back to 'int', since
5707 their values must fit in 'int'.
5708 (xpm_load_image, png_load, tiff_load):
5709 Invoke x_create_x_image_and_pixmap earlier,
5710 to avoid much needless work if the image is too large.
5711 (tiff_load): Treat overly large images as if
5712 x_create_x_image_and_pixmap failed, not as malloc failures.
5713 (gs_load): Use x_check_image_size.
5715 * gtkutil.c: Omit integer casts.
5716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5723 would wrongly return t on a 64-bit host.
5725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5728 and therefore cause GCC to emit a bogus diagnostic in some cases.
5730 * image.c: Integer signedness and overflow and related fixes.
5731 This is not an exhaustive set of fixes, but it's time to
5732 record what I've got.
5733 (lookup_pixel_color, check_image_size): Remove redundant decls.
5734 (check_image_size): Don't assume that arbitrary EMACS_INT values
5735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5737 (tiff_load, imagemagick_load_image):
5738 Check for overflow in size calculations.
5739 (x_create_x_image_and_pixmap): Remove unnecessary test for
5740 xmalloc returning NULL; that can't happen.
5741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5742 (xpm_color_bucket): Use better integer hashing function.
5743 (xpm_cache_color): Don't possibly over-allocate memory.
5744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5745 (gif_memory_source):
5746 Use ptrdiff_t, not int or size_t, to record sizes.
5747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5749 either works, as we prefer signed integers.
5750 (tiff_read_from_memory, tiff_write_from_memory):
5751 Return tsize_t, not size_t, since that's what the TIFF API wants.
5752 (tiff_read_from_memory): Don't fail simply because the read would
5753 go past EOF; instead, return a short read.
5754 (tiff_load): Omit no-longer-needed casts.
5755 (Fimagemagick_types): Don't assume size fits into 'int'.
5757 Improve hashing quality when configured --with-wide-int.
5758 * fns.c (hash_string): New function, taken from sxhash_string.
5759 Do not discard information about ASCII character case; this
5760 discarding is no longer needed.
5761 (sxhash-string): Use it. Change sig to match it. Caller changed.
5762 * lisp.h: Declare it.
5763 * lread.c (hash_string): Remove, since we now use fns.c's version.
5764 The fns.c version returns a wider integer if --with-wide-int is
5765 specified, so this should help the quality of the hashing a bit.
5767 * emacs.c: Integer overflow minor fix.
5768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5769 Define only if GNU_LINUX.
5770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5772 * dispnew.c: Integer signedness and overflow fixes.
5773 Remove unnecessary forward decls, that were a maintenance hassle.
5774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5778 (prepare_desired_row, line_draw_cost):
5779 Use int, not unsigned, where either works.
5780 (save_current_matrix, restore_current_matrix):
5781 Use ptrdiff_t, not size_t, where either works.
5782 (init_display): Check for overflow more accurately, and without
5783 relying on undefined behavior.
5785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5786 Remove, replacing with the new symbols in lisp.h. All uses changed.
5787 * fileio.c (make_temp_name):
5788 * filelock.c (lock_file_1, lock_file):
5789 * xdisp.c (message_dolog):
5790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5791 Use pMd etc. instead.
5792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5793 replacing the pWIDE etc. symbols removed from editfns.c.
5795 * keyboard.h (num_input_events): Now uintmax_t.
5796 This is (very slightly) less likely to mess up due to wraparound.
5799 * buffer.c: Integer signedness fixes.
5800 (alloc_buffer_text, enlarge_buffer_text):
5801 Use ptrdiff_t rather than size_t when either will do, as we prefer
5804 * alloc.c: Integer signedness and overflow fixes.
5805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5806 (__malloc_size_t): Default to size_t, not to int.
5807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5809 Prefer ptrdiff_t to size_t when either would do, as we prefer
5811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5813 Now const. Initialize with values that are in range even if char
5815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5817 These functions do the right thing with sizes > 2**32.
5818 (check_depth): Now ptrdiff_t, not int.
5819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5820 Adjust to new way of storing sizes. Check for size overflow bugs
5822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5823 slightly wrong anyway, as it missed one instance of
5824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5825 (refill_memory_reserve): Omit needless cast to size_t.
5826 (mark_object_loop_halt): Mark as externally visible.
5828 * xselect.c: Integer signedness and overflow fixes.
5829 (Fx_register_dnd_atom, x_handle_dnd_message):
5830 Use ptrdiff_t, not size_t, since we prefer signed.
5831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5833 x_dnd_atoms_size and x_dnd_atoms_length.
5835 * doprnt.c: Prefer signed to unsigned when either works.
5837 * doprnt.c (doprnt):
5839 * xdisp.c (vmessage):
5840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5842 prefer signed arithmetic to avoid comparison confusion.
5843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5844 but is a bit tricky.
5846 Assume freestanding C89 headers, string.h, stdlib.h.
5847 * data.c, doprnt.c, floatfns.c, print.c:
5848 Include float.h unconditionally.
5849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5851 * regex.c: Likewise for stddef.h, string.h.
5852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5855 (STDC_HEADERS): Remove obsolete defines.
5856 * sysdep.c: Include limits.h unconditionally.
5858 Assume support for memcmp, memcpy, memmove, memset.
5859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5860 * regex.c (memcmp, memcpy):
5861 Remove; we assume C89 now.
5863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5864 (__malloc_safe_bcopy): Remove; no longer needed.
5866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5868 well either way, and we prefer signed to unsigned.
5870 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5873 closes the connection while we're reading (bug#9182).
5875 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5878 are specified (Bug#9168).
5880 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5883 Found by GCC static checking and --with-wide-int on a 32-bit host.
5885 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5887 * xdisp.c (compute_display_string_pos): Fix logic of caching
5888 previous display string position. Initialize cached_prev_pos to
5889 -1. Fixes slow-down at the beginning of a buffer.
5891 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5894 for attrs[LFACE_FONTSET_INDEX].
5896 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5898 * xml.c (parse_region): Remove unused local
5899 that was recently introduced.
5901 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5906 * xdisp.c (move_it_in_display_line_to): Record the best matching
5907 position for TO_CHARPOS while scanning the line, and restore it on
5908 exit if none of the characters scanned was an exact match.
5909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5910 when exact match is impossible due to invisible text, and the
5911 lines are truncated.
5913 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5918 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5920 Fix a significant slow-down of cursor motion with C-n, C-p,
5921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5922 auto-repeat under bidi redisplay in fontified buffers.
5923 * xdisp.c (compute_stop_pos_backwards): New function.
5924 (next_element_from_buffer): Call compute_stop_pos_backwards to
5925 find a suitable prev_stop when we find ourselves before
5927 (reseat): Don't look for prev_stop, as that could mean a very long
5929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5930 <cached_disp_overlay_modiff>: Cache for last found display string
5932 (compute_display_string_pos): Return the cached position if asked
5933 about the same buffer in the same area of character positions, and
5934 the buffer wasn't changed since the time the display string
5935 position was cached.
5937 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5940 is an integer, which is important for empty lines. (Bug#9149)
5942 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5944 * frame.c (Fmodify_frame_parameters): In tty case, update the
5945 default face if necessary (Bug#4238).
5947 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5949 * editfns.c (Fstring_to_char): No need to explain what a character
5950 is in the docstring (Bug#6576).
5952 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5954 * xml.c (parse_region): Make sure we always return a tree.
5956 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5958 * xml.c (parse_region): If a document contains only comments,
5961 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5963 * xml.c (make_dom): Return comments, too.
5965 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5969 and the surrounding thread.
5970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5974 * s/openbsd.h (BROKEN_SIGIO): Define.
5975 * unexelf.c (unexec) [__OpenBSD__]:
5976 Don't update the .mdebug section of the Alpha COFF symbol table.
5978 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5983 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5986 This fixes some race conditions on the permissions of any newly
5989 * alloc.c (valid_pointer_p): Use pipe, not open.
5990 This fixes some permissions issues when debugging.
5992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5993 If fchown fails to set both uid and gid, try to set just gid,
5994 as that is sometimes allowed. Adjust the file's mode to eliminate
5995 setuid or setgid bits that are inappropriate if fchown fails.
5997 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6000 to compare Lisp_Objects.
6001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6005 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6007 * lread.c (read_integer): Unread even EOF character.
6008 (read1): Likewise. Properly record start position of symbol.
6010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6011 symbol character follows.
6013 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6016 This works around a problem with the previous change to Fcopy_file.
6017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6018 and without this change, GCC might complain about discarding
6019 fchown's return value.
6021 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6025 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6029 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6032 it's used from the C level.
6034 * process.c: Use the same condition for POLL_FOR_INPUT in both
6035 keyboard.c and process.c (bug#1858).
6037 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6040 (Fgnutls_boot): Use it.
6042 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6044 * doc.c (Fsubstitute_command_keys): Revert last change.
6046 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6049 quotes the next character, and doesn't affect other longer
6050 sequences (bug#8935).
6052 * lread.c (syms_of_lread): Clarify that is isn't only
6053 `eval-buffer' and `eval-defun' that's affected by
6054 `lexical-binding' (bug#8460).
6056 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6059 bidi redisplay when a line includes both an image and is truncated.
6061 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6063 Fix minor problems found by static checking.
6064 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6065 (elsz): Now a signed constant, not a size_t var. We prefer signed
6066 types to unsigned, to avoid integer comparison confusion. Without
6067 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6068 "cannot optimize loop, the loop counter may overflow", a symptom
6070 * indent.c (Fvertical_motion): Mark locals as initialized.
6071 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6073 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6075 * search.c (Fre_search_backward): Mention `case-fold-search' in
6076 all the re_search_* functions (bug#8138).
6078 * keyboard.c (Fopen_dribble_file): Document when the file is
6081 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6083 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6086 Support bidi reordering of display and overlay strings.
6087 * xdisp.c (compute_display_string_pos)
6088 (compute_display_string_end): Accept additional argument STRING.
6089 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6090 (reseat_to_string): Initialize bidi_it->string.s and
6091 bidi_it->string.schars.
6092 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6093 NULL (avoids a crash in bidi_paragraph_init).
6094 Initialize itb.string.lstring.
6095 (init_iterator): Call bidi_init_it only of a valid
6096 buffer position was specified. Initialize paragraph_embedding to
6098 (reseat_to_string): Initialize the bidi iterator.
6099 (display_string): If we need to ignore text properties of
6100 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6101 original value of -1 will not work with bidi.)
6102 (compute_display_string_pos): First arg is now struct
6103 `text_pos *'; all callers changed. Support display properties on
6105 (compute_display_string_end): Support display properties on Lisp
6107 (init_iterator, reseat_1, reseat_to_string): Initialize the
6108 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6109 when iterating on a string not from display properties).
6110 (compute_display_string_pos, compute_display_string_end):
6111 Fix calculation of the object to scan. Fixes an error when using
6113 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6114 base_level_stop; instead, set base_level_stop to BEGV.
6115 Fixes crashes in vertical-motion.
6116 (next_element_from_buffer): Improve commentary for when
6117 the iterator is before prev_stop.
6118 (init_iterator): Initialize bidi_p from the default value of
6119 bidi-display-reordering, not from buffer-local value. Use the
6120 buffer-local value only if initializing for buffer iteration.
6121 (handle_invisible_prop): Support invisible properties on strings
6122 that are being bidi-reordered.
6123 (set_iterator_to_next): Support bidi reordering of C strings and
6125 (next_element_from_string): Support bidi reordering of Lisp
6127 (handle_stop_backwards): Support Lisp strings as well.
6128 (display_string): Support display of R2L glyph rows.
6129 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6130 (init_iterator): Don't initialize it->bidi_p for strings
6132 (reseat_to_string): Initialize it->bidi_p for strings here.
6133 (next_element_from_string, next_element_from_c_string)
6134 (next_element_from_buffer): Add xassert's for correspondence
6135 between IT's object being iterated and it->bidi_it.string
6137 (face_before_or_after_it_pos): Support bidi iteration.
6138 (next_element_from_c_string): Handle the case of the first string
6139 character that is not the first one in the visual order.
6140 (get_visually_first_element): New function, refactored from common
6141 parts of next_element_from_buffer, next_element_from_string, and
6142 next_element_from_c_string.
6143 (tool_bar_lines_needed, redisplay_tool_bar)
6144 (display_menu_bar): Force left-to-right direction. Add a FIXME
6145 comment for making that be controlled by a user option.
6146 (push_it, pop_it): Save and restore the state of the
6147 bidi iterator. Save and restore the bidi_p flag.
6148 (pop_it): Iterate out of display property for string iteration as
6150 (iterate_out_of_display_property): Support iteration over strings.
6151 (handle_single_display_spec): Set up it->bidi_it for iteration
6152 over a display string, and call bidi_init_it.
6153 (handle_single_display_spec, next_overlay_string)
6154 (get_overlay_strings_1, push_display_prop): Set up the bidi
6155 iterator for displaying display or overlay strings.
6156 (forward_to_next_line_start): Don't use the shortcut if
6158 (back_to_previous_visible_line_start): If handle_display_prop
6159 pushed the iterator stack, restore the internal state of the bidi
6160 iterator by calling bidi_pop_it same number of times.
6161 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6162 and we are bidi-iterating, don't decrement the iterator position;
6163 instead, set the first_elt flag in the bidi iterator, to produce
6165 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6166 (push_display_prop): xassert that we are iterating a buffer.
6167 (push_it, pop_it): Save and restore paragraph_embedding member.
6168 (handle_single_display_spec, next_overlay_string)
6169 (get_overlay_strings_1, reseat_1, reseat_to_string)
6170 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6171 correctly. Don't assume unibyte strings are not bidi-reordered.
6172 (compute_display_string_pos)
6173 (compute_display_string_end): Fix handling the case of C string.
6174 (push_it, pop_it): Save and restore from_disp_prop_p.
6175 (handle_single_display_spec, push_display_prop): Set the
6176 from_disp_prop_p flag.
6177 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6178 (pop_it): Call iterate_out_of_display_property only if we are
6179 popping after iteration over a string that came from a display
6180 property. Fix a typo in popping stretch info. Add an assertion
6181 for verifying that the iterator position is in sync with the bidi
6183 (handle_single_display_spec, get_overlay_strings_1)
6184 (push_display_prop): Fix initialization of paragraph direction for
6185 string when that of the parent object is not yet determined.
6186 (reseat_1): Call bidi_init_it to resync the bidi
6187 iterator with IT's position. (Bug#7616)
6188 (find_row_edges): If ROW->start.pos gives position
6189 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6190 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6191 Reset the from_disp_prop_p flag.
6192 (SAVE_IT, RESTORE_IT): New macros.
6193 (pos_visible_p, face_before_or_after_it_pos)
6194 (back_to_previous_visible_line_start)
6195 (move_it_in_display_line_to, move_it_in_display_line)
6196 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6197 (try_scrolling, redisplay_window, display_line): Use them when
6198 saving a temporary copy of the iterator and restoring it back.
6199 (back_to_previous_visible_line_start, reseat_1)
6200 (init_iterator): Empty the bidi cache "stack".
6201 (move_it_in_display_line_to): If iterator ended up at
6202 EOL, but we never saw any buffer positions smaller than
6203 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6204 motion in bidi-reordered lines.
6205 (move_it_in_display_line_to): Record prev_method and prev_pos
6206 immediately before the call to set_iterator_to_next. Fixes cursor
6207 motion in bidi-reordered lines with stretch glyphs and strings
6208 displayed in margins. (Bug#8133) (Bug#8867)
6209 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6211 (pos_visible_p): Support positions in bidi-reordered lines.
6212 Save and restore bidi cache.
6214 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6215 (bidi_paragraph_info): Delete unused struct.
6216 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6217 (bidi_cache_start): New variable.
6218 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6220 (bidi_cache_fetch_state, bidi_cache_search)
6221 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6222 (bidi_cache_find, bidi_peek_at_next_level)
6223 (bidi_level_of_next_char, bidi_find_other_level_edge)
6224 (bidi_move_to_visually_next): Compare cache index with
6225 bidi_cache_start rather than with zero.
6226 (bidi_fetch_char): Accept new argument STRING; all callers
6227 changed. Support iteration over a string. Support strings with
6228 display properties. Support unibyte strings. Fix the type of
6229 `len' according to what STRING_CHAR_AND_LENGTH expects.
6230 (bidi_paragraph_init, bidi_resolve_explicit_1)
6231 (bidi_resolve_explicit, bidi_resolve_weak)
6232 (bidi_level_of_next_char, bidi_move_to_visually_next):
6233 Support iteration over a string.
6234 (bidi_set_sor_type, bidi_resolve_explicit_1)
6235 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6236 can now be zero (for strings); special values 0 and -1 were
6237 changed to -1 and -2, respectively.
6238 (bidi_char_at_pos): New function.
6239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6240 Call it instead of FETCH_MULTIBYTE_CHAR.
6241 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6242 initialized to valid values.
6243 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6245 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6246 the test for valid cached positions. Fix the logic for looking up
6247 the sentinel state in the cache. GCPRO the Lisp string we are
6249 (bidi_push_it, bidi_pop_it): New functions.
6250 (bidi_initialize): Initialize the bidi cache start stack pointer.
6251 (bidi_cache_ensure_space): New function, refactored from part of
6252 bidi_cache_iterator_state. Don't assume the required size is just
6253 one BIDI_CACHE_CHUNK away.
6254 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6255 (bidi_count_bytes, bidi_char_at_pos): New functions.
6256 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6257 always valid if bidi_cache_idx is valid.
6258 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6259 is valid if it's going to be used.
6260 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6261 (bidi_cache_fetch_state, bidi_cache_search)
6262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6263 (bidi_cache_iterator_state, bidi_cache_find)
6264 (bidi_find_other_level_edge, bidi_cache_start_stack):
6265 All variables related to cache indices are now EMACS_INT.
6267 * dispextern.h (struct bidi_string_data): New structure.
6268 (struct bidi_it): New member `string'. Make flag members be 1-bit
6269 fields, and put them last in the struct.
6270 (compute_display_string_pos, compute_display_string_end):
6272 (bidi_push_it, bidi_pop_it): Add prototypes.
6273 (struct iterator_stack_entry): New members bidi_p,
6274 paragraph_embedding, and from_disp_prop_p.
6275 (struct it): Member bidi_p is now a bit field 1 bit wide.
6276 (bidi_shelve_cache, bidi_unshelve_cache):
6279 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6280 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6281 and vector-like objects.
6283 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6284 cache around display iteration.
6286 * window.c (Fwindow_end, window_scroll_pixel_based)
6287 (displayed_window_lines, Frecenter): Save and restore the bidi
6288 cache around display iteration.
6290 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6292 * editfns.c (Fdelete_region): Clarify the use of the named
6293 parameters (bug#6788).
6295 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6297 * indent.c (Fvertical_motion): Set and restore w->pointm when
6298 saving and restoring the window's buffer (Bug#9006).
6300 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6302 * editfns.c (Fstring_to_char): Clarify just what is returned
6303 (bug#6576). Text by Eli Zaretskii.
6305 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6307 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6309 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6311 * buffer.c (mmap_find): Fix a typo.
6313 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6315 Fix execution of x selection hooks.
6316 * xselect.c (Qx_lost_selection_functions)
6317 (Qx_sent_selection_functions): New vars.
6318 (syms_of_xselect): DEFSYM them.
6319 (x_handle_selection_request): Pass Qx_sent_selection_functions
6320 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6321 (x_handle_selection_clear,x_clear_frame_selections):
6322 Pass Qx_lost_selection_functions rather than
6323 Vx_lost_selection_functions to Frun_hook_with_args.
6325 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6327 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6328 The old code sometimes used this field without initializing it.
6330 * alloc.c (gc_sweep): Don't read past end of array.
6331 In theory, the old code could also have corrupted Emacs internals,
6332 though it'd be very unlikely.
6334 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6336 * character.c (Fcharacterp): Don't advertise optional ignored
6337 argument. (Bug#4026)
6339 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6341 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6344 * window.c (Fset_window_start): Doc fix (bug#4199).
6345 (Fset_window_hscroll): Ditto.
6347 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6349 Fix minor new problems caught by GCC 4.6.1.
6350 * term.c (init_tty): Remove unused local.
6351 * xsettings.c (store_monospaced_changed): Define this function only
6352 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6355 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6357 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6359 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6361 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6362 are the mini-buffer and the echo area (bug#3320).
6364 * term.c (init_tty): Remove support for supdup, c10 and perq
6365 terminals, which are no longer supported (bug#1482).
6367 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6369 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6371 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6373 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6374 for non-popups (Bug#3642).
6376 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6378 * alloc.c (reset_malloc_hooks): Protoize.
6379 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6380 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6381 * cm.c (losecursor): Likewise.
6382 * data.c (fmod): Likewise.
6383 * dispnew.c (swap_glyphs_in_rows): Likewise.
6384 * emacs.c (memory_warning_signal): Likewise.
6385 * floatfns.c (float_error): Likewise.
6386 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6387 (otf_open, font_otf_capability, generate_otf_features)
6388 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6390 * image.c (pbm_read_file): Likewise.
6391 * indent.c (string_display_width): Likewise.
6392 * intervals.c (check_for_interval, search_for_interval)
6393 (inc_interval_count, count_intervals, root_interval)
6394 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6395 * lread.c (defalias): Likewise.
6396 * ralloc.c (r_alloc_check): Likewise.
6397 * regex.c (set_image_of_range_1, set_image_of_range)
6398 (regex_grow_registers): Likewise.
6399 * sysdep.c (strerror): Likewise.
6400 * termcap.c (valid_filename_p, tprint, main): Likewise.
6401 * tparam.c (main): Likewise.
6402 * unexhp9k800.c (run_time_remap, save_data_space)
6403 (update_file_ptrs, read_header, write_header, calculate_checksum)
6404 (copy_file, copy_rest, display_header): Likewise.
6405 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6407 * xdisp.c (check_it): Likewise.
6408 * xfaces.c (register_color, unregister_color, unregister_colors):
6410 * xfns.c (print_fontset_result): Likewise.
6411 * xrdb.c (member, fatal, main): Likewise.
6413 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6415 Fix minor problems found by static checking (Bug#9031).
6416 * chartab.c (char_table_set_range, map_sub_char_table):
6417 Remove unused locals.
6418 (uniprop_table): Now static.
6419 * composite.c (_work_char): Remove unused static var.
6421 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6423 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6425 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6427 * gtkutil.c (qttip_cb): Remove code without function.
6429 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6431 * w32.c (pthread_sigmask): New stub.
6433 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6435 Use pthread_sigmask, not sigprocmask (Bug#9010).
6436 sigprocmask is portable only for single-threaded applications, and
6437 Emacs can be multi-threaded when it uses GTK.
6438 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6440 * callproc.c (Fcall_process):
6441 * process.c (create_process):
6442 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6443 Use pthread_sigmask, not sigprocmask.
6445 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6447 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6448 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6451 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6453 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6454 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6455 (xg_hide_tooltip): Fix comment.
6457 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6458 in registerServicesMenuSendTypes.
6459 (validRequestorForSendType): Don't check ns_return_types.
6461 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6464 2011-07-08 Jason Rumney <jasonr@gnu.org>
6466 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6467 SH_SHOW for hidden windows (Bug#5482).
6469 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6470 frame struct members of non-existent frames (Bug#6284).
6472 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6474 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6475 variable firstTime not needed on OSX >= 10.6.
6476 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6477 >= 10.5. Use setKnobProportion, setDoubleValue.
6479 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6480 (MAC_OS_X_VERSION_10_5): Define if not defined.
6481 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6482 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6483 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6485 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6486 cString and lossyCString on OSX >= 10.4
6488 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6489 sizeToFit on OSX >= 10.2.
6491 * nsimage.m (allocInitFromFile): Don't use deprecated method
6492 bestRepresentationForDevice on OSX >= 10.6.
6494 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6497 * emacs.c: Declare unexec_init_emacs_zone.
6499 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6501 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6503 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6504 on svcsMenu (Bug#8842).
6506 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6508 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6510 * nsterm.m (QUTF8_STRING): Declare.
6511 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6512 (validRequestorForSendType): Return type is (id).
6513 Change indexOfObjectIdenticalTo to indexOfObject.
6514 Check if we have local selection before returning self (Bug#8842).
6515 (writeSelectionToPasteboard): Put local selection into paste board
6516 if we have a local selection (Bug#8842).
6517 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6519 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6520 (ns_get_local_selection): Declare.
6522 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6524 * keymap.c (describe_map_tree): Don't insert a double newline at
6525 the end of the buffer (bug#1169) and return whether we inserted
6528 * callint.c (Fcall_interactively): Change "reading args" to
6529 "providing args" to try to clarify what it does (bug#1010).
6531 2011-07-07 Kenichi Handa <handa@m17n.org>
6533 * composite.c (composition_compute_stop_pos): Ignore a static
6534 composition starting before CHARPOS (Bug#8915).
6536 * xdisp.c (handle_composition_prop): Likewise.
6538 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6540 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6543 2011-07-07 Kenichi Handa <handa@m17n.org>
6545 * character.h (unicode_category_t): New enum type.
6547 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6548 (Qchar_code_property_table): New variable.
6549 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6550 (UNIPROP_COMPRESSED_FORM_P): New macros.
6551 (char_table_ascii): Uncompress the compressed values.
6552 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6553 Uncompress the compressed values.
6554 (sub_char_table_ref_and_range): Likewise.
6555 (char_table_ref_and_range): Uncompress the compressed values.
6556 (sub_char_table_set): New arg is_uniprop. Callers changed.
6557 Uncompress the compressed values.
6558 (sub_char_table_set_range): Args changed. Callers changed.
6559 (char_table_set_range): Adjuted for the above change.
6560 (map_sub_char_table): Delete args default_val and parent. Add arg
6561 top. Give decoded values to a Lisp function.
6562 (map_char_table): Adjust for the above change. Give decoded
6563 values to a Lisp function. Gcpro more variables.
6564 (uniprop_table_uncompress)
6565 (uniprop_decode_value_run_length): New functions.
6566 (uniprop_decoder, uniprop_decoder_count): New variables.
6567 (uniprop_get_decoder, uniprop_encode_value_character)
6568 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6570 (uniprop_encoder, uniprop_encoder_count): New variables.
6571 (uniprop_get_encoder, uniprop_table)
6572 (Funicode_property_table_internal, Fget_unicode_property_internal)
6573 (Fput_unicode_property_internal): New functions.
6574 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6575 Sunicode_property_table_internal, Sget_unicode_property_internal,
6576 and Sput_unicode_property_internal. Defvar_lisp
6577 char-code-property-alist.
6579 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6580 Vunicode_category_table.
6582 * font.c (font_range): Adjust for the change of
6583 Vunicode_category_table.
6585 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6587 * m/iris4d.h: Remove file, move contents ...
6588 * s/irix6-5.h: ... here.
6590 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6592 Remove unportable assumption about struct layout (Bug#8884).
6593 * alloc.c (mark_buffer):
6594 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6595 (clone_per_buffer_values): Don't assume that
6596 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6597 This isn't true in general, and it's particularly not true
6598 if Emacs is configured with --with-wide-int.
6599 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6600 New macros, used in the buffer.c change.
6602 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6604 * xsettings.c: Use both GConf and GSettings if both are available.
6605 (store_config_changed_event): Add comment.
6606 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6607 (store_tool_bar_style_changed): New functions.
6608 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6609 (struct xsettings): Move font inside HAVE_XFT.
6610 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6611 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6612 Move inside HAVE_XFT.
6613 (something_changed_gsettingsCB): Rename from something_changedCB.
6614 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6616 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6617 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6618 (something_changed_gconfCB): Rename from something_changedCB.
6619 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6620 (parse_settings): Move check for font inside HAVE_XFT.
6621 (read_settings, apply_xft_settings): Add comment.
6622 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6623 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6624 call store_font_name_changed.
6625 (xft_settings_event): Add comment.
6626 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6627 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6628 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6629 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6630 (xsettings_initialize): Call init_gsettings last.
6631 (xsettings_get_system_font, xsettings_get_system_normal_font):
6634 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6636 Random fixes. E.g., (random) never returned negative values.
6637 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6638 subseconds part to the entropy, as that's a bit more random.
6639 Prefer signed to unsigned, since the signedness doesn't matter and
6640 in general we prefer signed. When given a limit, use a
6641 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6642 latter isn't right if USE_2_TAGS_FOR_INTS.
6643 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6644 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6646 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6648 * textprop.c (text_property_stickiness):
6649 Obey Vtext_property_default_nonsticky.
6650 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6651 * w32fns.c (syms_of_w32fns):
6652 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6654 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6656 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6657 This is more efficient than Ffile_directory_p and avoids a minor race.
6659 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6661 * buffer.c (Foverlay_put): Say what the return value is
6664 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6665 is a directory before asking whether to use the file name
6667 (barf_or_query_if_file_exists): Make the "File is a directory"
6668 error be more correct.
6670 * fns.c (Frequire): Remove the mention of the .gz files, since
6671 that's installation-specific, but keep the mention of
6672 `get-load-suffixes'.
6674 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6676 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6677 Report string overflow if the output is too long.
6679 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6681 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6682 (syms_of_gnutls): Remove duplicate DEFSYM for
6683 Qgnutls_bootprop_verify_hostname_error, an error for
6684 Qgnutls_bootprop_verify_error (which is no longer used).
6686 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6687 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6688 Also (re)move comments that are misplaced or no longer relevant.
6690 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6692 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6694 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6696 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6697 and background color parameters if they have been changed.
6699 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6701 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6703 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6705 * xsettings.c (SYSTEM_FONT): Define only when used.
6706 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6708 * keymap.c (access_keymap_1): Now static.
6710 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6712 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6713 leave any prefix arg for the up event (Bug#1586).
6715 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6717 * lread.c (syms_of_lread): Mention single symbols defined by
6718 `defvar' or `defconst' (bug#7154).
6720 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6721 (Frequire): Mention get-load-suffixes.
6723 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6725 * window.h (window): Remove clone_number slot.
6726 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6728 (make_parent_window, make_window, saved_window)
6729 (Fset_window_configuration, save_window_save): Don't deal with
6731 * buffer.c (Qclone_number): Remove declaration.
6732 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6734 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6736 Add multiple inheritance to keymaps.
6737 * keymap.c (Fmake_composed_keymap): New function.
6738 (Fset_keymap_parent): Simplify.
6739 (fix_submap_inheritance): Remove.
6740 (access_keymap_1): New function extracted from access_keymap to handle
6741 embedded parents and handle lists of maps.
6742 (access_keymap): Use it.
6743 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6744 (Fcopy_keymap): Handle embedded parents.
6745 (Fcommand_remapping, define_as_prefix): Simplify.
6746 (Fkey_binding): Simplify.
6747 (syms_of_keymap): Move minibuffer-local-completion-map,
6748 minibuffer-local-filename-completion-map,
6749 minibuffer-local-must-match-map, and
6750 minibuffer-local-filename-must-match-map to Elisp.
6751 (syms_of_keymap): Defsubr make-composed-keymap.
6752 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6753 (parse_menu_item): Trivial simplification.
6755 2011-07-01 Glenn Morris <rgm@gnu.org>
6757 * Makefile.in (SETTINGS_LIBS): Fix typo.
6759 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6761 * coding.c (Fencode_coding_string): Record the last coding system
6762 used, as the function doc string says (bug#8738).
6764 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6766 * xsettings.c (store_monospaced_changed): Take new font as arg and
6767 check for change against current_mono_font.
6768 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6769 (emacs_settings_constructor, emacs_settings_get_property)
6770 (emacs_settings_set_property, emacs_settings_class_init)
6771 (emacs_settings_init, gsettings_obj): Remove.
6772 (something_changedCB): New function for HAVE_GSETTINGS.
6773 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6774 with value as argument.
6775 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6776 g_settings_new (Bug#8967). Do not create gsettings_obj.
6777 Remove calls to g_settings_bind. Connect something_changedCB to
6780 * xgselect.c: Add defined (HAVE_GSETTINGS).
6781 (xgselect_initialize): Ditto.
6783 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6784 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6787 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6789 * eval.c (struct backtrace): Simplify and port the data structure.
6790 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6791 signed bit field, as this assumption is not portable and it makes
6792 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6793 "char debug_on_exit : 1" as this is not portable either; instead,
6794 use the portable "unsigned int debug_on_exit : 1". Remove unused
6795 member evalargs. Remove obsolete comments about cc bombing out.
6797 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6799 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6800 Let HAVE_GSETTINGS override HAVE_GCONF.
6801 (store_monospaced_changed): New function.
6802 (EMACS_SETTINGS): A new type derived from GObject to handle
6803 GSettings notifications.
6804 (emacs_settings_constructor, emacs_settings_get_property)
6805 (emacs_settings_set_property, emacs_settings_class_init):
6807 (gsettings_client, gsettings_obj): New variables.
6808 (GSETTINGS_SCHEMA): New define.
6809 (something_changedCB): Call store_monospaced_changed.
6810 (init_gsettings): New function.
6811 (xsettings_initialize): Call init_gsettings.
6812 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6815 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6818 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6820 * window.c (resize_root_window, grow_mini_window)
6821 (shrink_mini_window): Rename Qresize_root_window to
6822 Qwindow_resize_root_window and Qresize_root_window_vertically to
6823 Qwindow_resize_root_window_vertically.
6825 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6827 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6829 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6831 * makefile.w32-in: Redesign dependencies so they reflect more
6832 clearly which files are directly included by each source file,
6833 and not through other includes.
6835 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6837 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6838 (sort_overlays, overlay_strings): When an overlay's clone number
6839 matches the window's clone number process the overlay even if
6840 the overlay's window property doesn't match the current window.
6842 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6843 (Fwindow_hchild): Rename to Fwindow_left_child.
6844 (Fwindow_next): Rename to Fwindow_next_sibling.
6845 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6846 (resize_window_check): Rename to window_resize_check.
6847 (resize_window_apply): Rename to window_resize_apply.
6848 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6849 (Fdelete_other_windows_internal, resize_frame_windows)
6850 (Fsplit_window_internal, Fdelete_window_internal)
6851 (grow_mini_window, shrink_mini_window)
6852 (Fresize_mini_window_internal): Fix callers accordingly.
6854 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6856 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6857 (emacs_fixed_set_min_size): Remove.
6858 (emacs_fixed_new): Take frame as argument.
6860 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6861 (_EmacsFixedPrivate): Remove minwidth/height.
6862 Add struct frame *f.
6863 (emacs_fixed_init): Initialize priv->f.
6864 (get_parent_class, emacs_fixed_set_min_size): Remove.
6865 (emacs_fixed_new): Set priv->f to argument.
6866 (emacs_fixed_get_preferred_width)
6867 (emacs_fixed_get_preferred_height): Use min_width/height from
6868 frames size_hint to set minimum and natural (Bug#8919).
6869 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6870 and use min_width/height from frames size_hint to set
6871 min_width/height (Bug#8919).
6873 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6874 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6877 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6879 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6880 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6883 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6885 * process.c (wait_reading_process_output): Bypass select if
6886 waiting for a cell while ignoring keyboard input, and input is
6887 pending. Suggested by Jan Djärv (Bug#8869).
6889 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6891 Use gnulib's dup2 module instead of rolling our own.
6892 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6894 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6896 * dispnew.c (scrolling_window): Before scrolling, turn off a
6897 mouse-highlight in the window being scrolled.
6899 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6901 Move DEFSYM to lisp.h and use everywhere.
6903 * character.h (DEFSYM): Move declaration...
6904 * lisp.h (DEFSYM): ...here.
6910 * w32select.c: Don't include character.h.
6912 * alloc.c (syms_of_alloc):
6913 * buffer.c (syms_of_buffer):
6914 * bytecode.c (syms_of_bytecode):
6915 * callint.c (syms_of_callint):
6916 * casefiddle.c (syms_of_casefiddle):
6917 * casetab.c (init_casetab_once):
6918 * category.c (init_category_once, syms_of_category):
6919 * ccl.c (syms_of_ccl):
6920 * cmds.c (syms_of_cmds):
6921 * composite.c (syms_of_composite):
6922 * dbusbind.c (syms_of_dbusbind):
6923 * dired.c (syms_of_dired):
6924 * dispnew.c (syms_of_display):
6925 * doc.c (syms_of_doc):
6926 * editfns.c (syms_of_editfns):
6927 * emacs.c (syms_of_emacs):
6928 * eval.c (syms_of_eval):
6929 * fileio.c (syms_of_fileio):
6930 * fns.c (syms_of_fns):
6931 * frame.c (syms_of_frame):
6932 * fringe.c (syms_of_fringe):
6933 * insdel.c (syms_of_insdel):
6934 * keymap.c (syms_of_keymap):
6935 * lread.c (init_obarray, syms_of_lread):
6936 * macros.c (syms_of_macros):
6937 * msdos.c (syms_of_msdos):
6938 * print.c (syms_of_print):
6939 * process.c (syms_of_process):
6940 * search.c (syms_of_search):
6941 * sound.c (syms_of_sound):
6942 * syntax.c (init_syntax_once, syms_of_syntax):
6943 * terminal.c (syms_of_terminal):
6944 * textprop.c (syms_of_textprop):
6945 * undo.c (syms_of_undo):
6946 * w32.c (globals_of_w32):
6947 * window.c (syms_of_window):
6948 * xdisp.c (syms_of_xdisp):
6949 * xfaces.c (syms_of_xfaces):
6950 * xfns.c (syms_of_xfns):
6951 * xmenu.c (syms_of_xmenu):
6952 * xsettings.c (syms_of_xsettings):
6953 * xterm.c (syms_of_xterm): Use DEFSYM.
6955 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6957 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6959 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6961 Integer and buffer overflow fixes (Bug#8873).
6963 * print.c (printchar, strout): Check for string overflow.
6964 (PRINTPREPARE, printchar, strout):
6965 Don't set size unless allocation succeeds.
6967 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6968 for sizes. Check for string overflow more accurately.
6969 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6971 * macros.c: Integer and buffer overflow fixes.
6972 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6973 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6974 Use ptrdiff_t, not int, for sizes.
6975 Don't increment bufsize until after realloc succeeds.
6976 Check for size-calculation overflow.
6977 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6979 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6981 * lread.c: Integer overflow fixes.
6982 (read_integer): Radix is now EMACS_INT, not int,
6983 to improve quality of diagnostics for out-of-range radices.
6984 Calculate buffer size correctly for out-of-range radices.
6985 (read1): Check for integer overflow in radices, and in
6986 read-circle numbers.
6987 (read_escape): Avoid int overflow.
6988 (Fload, openp, read_buffer_size, read1)
6989 (substitute_object_recurse, read_vector, read_list, map_obarray):
6990 Use ptrdiff_t, not int, for sizes.
6991 (read1): Use EMACS_INT, not int, for sizes.
6992 Check for size overflow.
6994 * image.c (cache_image): Check for size arithmetic overflow.
6996 * lread.c: Integer overflow issues.
6997 (saved_doc_string_size, saved_doc_string_length)
6998 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6999 Now ptrdiff_t, not int.
7000 (read1): Don't assume doc string length fits in int. Check for
7001 out-of-range doc string lengths.
7002 (read_list): Don't assume file position fits in int.
7003 (read_escape): Check for hex character overflow.
7005 2011-06-22 Leo Liu <sdl.web@gmail.com>
7007 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7008 Move to minibuffer.el.
7010 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7012 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7013 The following patches are for when GLYPH_DEBUG && !XASSERT.
7014 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7015 * dispnew.c (flush_stdout):
7016 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7017 Mark as externally visible.
7018 * dispnew.c (check_window_matrix_pointers): Now static.
7019 * dispnew.c (window_to_frame_vpos):
7020 * xfns.c (unwind_create_frame):
7021 * xterm.c (x_check_font): Remove unused local.
7022 * scroll.c (CHECK_BOUNDS):
7023 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7024 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7025 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7026 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7027 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7029 (debug_method_add): Use va_list and vsprintf rather than relying
7030 on undefined behavior with wrong number of arguments.
7031 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7032 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7033 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7034 since we're not interested in debugging glyphs with old libraries.
7035 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7036 GCC 4.6.0's static checking.
7038 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7040 Integer overflow and signedness fixes (Bug#8873).
7041 A few related buffer overrun fixes, too.
7043 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7045 * dispextern.h (struct face.stipple):
7046 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7047 (x_bitmap_mask, x_allocate_bitmap_record)
7048 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7049 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7050 (x_create_bitmap_from_xpm_data):
7051 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7052 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7054 * xfaces.c (load_pixmap):
7055 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7056 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7057 (.bitmaps_last, struct x_output.icon_bitmap):
7058 Use ptrdiff_t, not int, for bitmap indexes.
7059 (x_allocate_bitmap_record): Check for size overflow.
7060 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7062 Use ptrdiff_t, not int, for overlay counts.
7063 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7064 * editfns.c (overlays_around, get_pos_property):
7065 * textprop.c (get_char_property_and_overlay):
7066 * xdisp.c (next_overlay_change, note_mouse_highlight):
7067 * xfaces.c (face_at_buffer_position):
7068 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7069 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7070 (Fnext_overlay_change, Fprevious_overlay_change)
7071 (mouse_face_overlay_overlaps, Foverlays_in):
7072 Use ptrdiff_t, not int, for sizes.
7073 (overlays_at, overlays_in): Check for size-calculation overflow.
7075 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7077 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7078 (x_session_initialize): Do not assume string length fits in int.
7080 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7081 This is unlikely, but can occur if DPI is outlandish.
7083 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7084 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7086 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7087 * xrdb.c (magic_file_p, search_magic_path):
7088 Omit last arg SUFFIX; it was always 0. All callers changed.
7089 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7091 * xfont.c (xfont_match): Avoid need for strlen.
7093 * xfns.c: Don't assume strlen fits in int.
7094 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7096 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7097 not unsigned long, as we prefer signed integers. All callers changed.
7098 Detect integer overflow in repeat count.
7099 (message_dolog): Don't assume print length fits in 39 bytes.
7100 (display_mode_element): Don't assume strlen fits in int.
7102 * termcap.c: Don't assume sizes fit in int and never overflow.
7103 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7104 (gobble_line): Check for size-calculation overflow.
7106 * minibuf.c (Fread_buffer):
7107 * lread.c (intern, intern_c_string):
7108 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7109 Don't assume string length fits in int.
7111 * keyboard.c (parse_tool_bar_item):
7112 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7114 * font.c: Don't assume string length fits in int.
7115 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7116 Use ptrdiff_t, not int.
7117 (font_intern_prop): Don't assume string length fits in int.
7118 Don't assume integer property fits in fixnum.
7119 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7121 * filelock.c: Fix some buffer overrun and integer overflow issues.
7122 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7123 Reformulate so as not to need the command string.
7124 Invoke gzip -cd rather than gunzip, as it's more portable.
7125 (lock_info_type, lock_file_1, lock_file):
7126 Don't assume pid_t and time_t fit in unsigned long.
7127 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7128 (current_lock_owner): Prefer signed type for sizes.
7129 Use memcpy, not strncpy, where memcpy is what is really wanted.
7130 Don't assume (via atoi) that time_t and pid_t fit in int.
7131 Check for time_t and/or pid_t out of range, e.g., via a network share.
7132 Don't alloca where an auto var works fine.
7134 * fileio.c: Fix some integer overflow issues.
7135 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7136 Don't assume string length fits in int.
7137 (directory_file_name): Don't assume string length fits in long.
7138 (make_temp_name): Don't assume pid fits in int, or that its print
7139 length is less than 20.
7141 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7143 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7145 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7147 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7148 We prefer signed integers, even for size calculations.
7150 * emacs.c: Don't assume string length fits in 'int'.
7151 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7152 (main): Don't invoke strlen when not needed.
7154 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7155 (XD_DEBUG_MESSAGE): Don't waste a byte.
7157 * callproc.c (getenv_internal_1, getenv_internal)
7159 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7161 * lread.c (invalid_syntax): Omit length argument.
7162 All uses changed. This doesn't fix a bug, but it simplifies the
7163 code away from its former Hollerith-constant appearance, and it's
7164 one less 'int' to worry about when looking at integer-overflow issues.
7165 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7167 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7168 This didn't break anything, but it didn't help either.
7169 It's confusing to put a bogus integer in a place where the actual
7170 value does not matter.
7171 (LIST_END_P): Remove unused macro and its bogus comment.
7172 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7174 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7175 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7177 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7178 We prefer signed types, and the value cannot exceed the EMACS_INT
7179 range anyway (because otherwise the length would not be representable).
7180 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7181 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7182 This avoids a GCC warning when WIDE_EMACS_INT.
7184 * indent.c (sane_tab_width): New function.
7185 (current_column, scan_for_column, Findent_to, position_indentation)
7186 (compute_motion): Use it. This is just for clarity.
7187 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7189 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7191 * lisp.h (lint_assume): New macro.
7192 * composite.c (composition_gstring_put_cache):
7193 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7195 * editfns.c, insdel.c:
7196 Omit unnecessary forward decls, to simplify future changes.
7198 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7200 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7202 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7203 Use much-faster test for byte-length change.
7204 Don't assume string byte-length fits in 'int'.
7205 Check that character arg fits in 'int'.
7206 (mapcar1): Declare byte as byte, for clarity.
7208 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7210 * fns.c (concat): Catch string overflow earlier.
7211 Do not rely on integer wraparound.
7213 * dispextern.h (struct it.overlay_strings_charpos)
7214 (struct it.selective): Now EMACS_INT, not int.
7215 * xdisp.c (forward_to_next_line_start)
7216 (back_to_previous_visible_line_start)
7217 (reseat_at_next_visible_line_start, next_element_from_buffer):
7218 Don't arbitrarily truncate the value of 'selective' to int.
7220 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7222 * composite.c: Don't truncate sizes to 'int'.
7223 (composition_gstring_p, composition_reseat_it)
7224 (composition_adjust_point): Use EMACS_INT, not int.
7225 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7226 not EMACS_UINT, for indexes.
7228 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7230 * buffer.c: Include <verify.h>.
7231 (struct sortvec.priority, struct sortstr.priority):
7232 Now EMACS_INT, not int.
7233 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7234 (struct sortstr.size, record_overlay_string)
7235 (struct sortstrlist.size, struct sortlist.used):
7236 Don't truncate size to int.
7237 (record_overlay_string): Check for size-calculation overflow.
7238 (init_buffer_once): Check at compile-time, not run-time.
7240 2011-06-22 Jim Meyering <meyering@redhat.com>
7242 Don't leak an XBM-image-sized buffer
7243 * image.c (xbm_load): Free the image buffer after using it.
7245 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7248 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7249 that Sun C diagnosed.
7250 * fns.c (secure_hash): Fix pointer signedness issue.
7251 * intervals.c (static_offset_intervals): New function.
7252 (offset_intervals): Use it.
7254 2011-06-21 Leo Liu <sdl.web@gmail.com>
7257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7260 * fns.c (secure_hash): Rename from crypto_hash_function and change
7261 the first arg to accept symbols.
7262 (Fsecure_hash): New primitive.
7263 (syms_of_fns): New symbols.
7265 2011-06-20 Deniz Dogan <deniz@dogan.se>
7267 * process.c (Fset_process_buffer): Clarify return value in
7270 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7272 * dispnew.c (add_window_display_history): Use BVAR.
7274 * xdisp.c (debug_method_add): Use BVAR.
7275 (check_window_end, dump_glyph_matrix, dump_glyph)
7276 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7278 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7281 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7282 check till after the cache is created in init_frame_faces.
7284 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7286 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7288 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7290 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7291 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7292 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7294 Improve buffer-overflow checking (Bug#8873).
7295 * fileio.c (Finsert_file_contents):
7296 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7297 Remove the old (too-loose) buffer overflow checks.
7298 They weren't needed, since make_gap checks for buffer overflow.
7299 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7300 The old code merely checked for Emacs fixnum overflow, and relied
7301 on undefined (wraparound) behavior. The new code avoids undefined
7302 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7304 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7305 Tune. Don't use wider integers than needed. Don't use alloca.
7306 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7308 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7310 * insdel.c, lisp.h (buffer_overflow): New function.
7311 (insert_from_buffer_1, replace_range, replace_range_2):
7312 * insdel.c (make_gap_larger):
7313 * editfns.c (Finsert_char):
7314 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7316 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7318 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7320 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7322 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7323 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7325 * fileio.c: Don't assume EMACS_INT fits in off_t.
7326 (emacs_lseek): New static function.
7327 (Finsert_file_contents, Fwrite_region): Use it.
7328 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7330 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7332 * fns.c: Don't overflow int when computing a list length.
7333 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7334 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7335 truncation on 64-bit hosts. Check for QUIT every
7336 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7337 faster and is responsive enough.
7338 (Flength): Report an error instead of overflowing an integer.
7339 (Fsafe_length): Return a float if the value is not representable
7340 as a fixnum. This shouldn't happen except in contrived situations.
7341 (Fnthcdr, Fsort): Don't assume list length fits in int.
7342 (Fcopy_sequence): Don't assume vector length fits in int.
7344 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7345 (header_size, word_size): New constants.
7346 (allocate_vectorlike): Don't check size overflow here.
7347 (allocate_vector): Check it here instead, since this is the only
7348 caller of allocate_vectorlike that could cause overflow.
7349 Check that the new vector's length is representable as a fixnum.
7351 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7352 The previous code was bogus. For example, next_almost_prime (32)
7353 returned 39, which is undesirable as it is a multiple of 3; and
7354 next_almost_prime (24) returned 25, which is a multiple of 5 so
7355 why was the code bothering to check for multiples of 7?
7357 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7359 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7361 Variadic C functions now count arguments with ptrdiff_t.
7362 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7363 Back then I didn't know that the Emacs coding style prefers signed int.
7364 Also, in the meantime I found a few more instances where arguments
7365 were being counted with int, which may truncate counts on 64-bit
7366 machines, or EMACS_INT, which may be unnecessarily wide.
7367 * lisp.h (struct Lisp_Subr.function.aMANY)
7368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7369 Arg counts are now ptrdiff_t, not size_t.
7370 All variadic functions and their callers changed accordingly.
7371 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7372 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7373 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7374 * callint.c (Fcall_interactively): Check arg count for overflow,
7375 to avoid potential buffer overrun. Use signed char, not 'int',
7376 for 'varies' array, so that we needn't bother to check its size
7377 calculation for overflow.
7378 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7379 * eval.c (apply_lambda):
7380 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7381 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7382 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7384 * callint.c (Fcall_interactively): Don't use index var as event count.
7386 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7387 * mem-limits.h (SIZE): Remove; no longer used.
7389 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7391 Remove unnecessary casts.
7392 * xterm.c (x_term_init):
7393 * xfns.c (x_set_border_pixel):
7394 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7395 These aren't needed now that we assume ANSI C.
7397 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7398 It's more likely to cause problems (due to unsigned overflow)
7401 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7403 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7405 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7407 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7409 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7411 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7413 GLYPH_CODE_FACE returns EMACS_INT, not int.
7414 * dispextern.h (merge_faces):
7415 * xfaces.c (merge_faces):
7416 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7417 Don't assume EMACS_INT fits in int.
7419 * character.h (CHAR_VALID_P): Remove unused parameter.
7420 * fontset.c, lisp.h, xdisp.c: All uses changed.
7422 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7424 * fns.c (concat): Minor tuning based on overflow analysis.
7425 This doesn't fix any bugs. Use int to hold character, instead
7426 of constantly refetching from Emacs object. Use XFASTINT, not
7427 XINT, for value known to be a character. Don't bother comparing
7428 a single byte to 0400, as it's always less.
7430 * floatfns.c (Fexpt):
7431 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7433 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7436 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7438 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7439 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7440 incorrectly succeed when S was a string, because 4294967386 was
7441 truncated before it was used.
7443 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7444 Otherwise, an out-of-range integer could cause undefined behavior
7447 * composite.c: Use int, not EMACS_INT, for characters.
7448 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7449 EMACS_INT, for values that are known to be in character range.
7450 This doesn't fix any bugs but is the usual style inside Emacs and
7451 may generate better code on 32-bit machines.
7453 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7454 This is for reasons similar to the recent CHAR_STRING fix.
7455 * charset.c (Fencode_char): Check that character arg is actually
7456 a character. Pass an int to ENCODE_CHAR.
7457 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7458 wider than 'int', as a compile-time check to prevent future regressions
7461 * character.c (char_string): Remove unnecessary casts.
7463 Make sure a 64-bit char is never passed to CHAR_STRING.
7464 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7465 by silently ignoring the top 32 bits, allowing some values
7466 that were far too large to be valid characters.
7467 * character.h: Include <verify.h>.
7468 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7469 arguments are no wider than unsigned, as a compile-time check
7470 to prevent future regressions in this area.
7472 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7473 (Fsubst_char_in_region):
7475 * xdisp.c (decode_mode_spec_coding):
7476 Adjust to CHAR_STRING's new requirement.
7477 * editfns.c (Finsert_char, Fsubst_char_in_region):
7478 * fns.c (concat): Check that character args are actually
7479 characters. Without this test, these functions did the wrong
7480 thing with wildly out-of-range values on 64-bit hosts.
7482 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7483 These casts should not be needed on 32-bit hosts, either.
7484 * keyboard.c (read_char):
7485 * lread.c (Fload): Remove casts to unsigned.
7487 * lisp.h (UNSIGNED_CMP): New macro.
7488 This fixes comparison bugs on 64-bit hosts.
7489 (ASCII_CHAR_P): Use it.
7490 * casefiddle.c (casify_object):
7491 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7492 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7493 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7494 * dispextern.h (FACE_FROM_ID):
7495 * keyboard.c (read_char): Use UNSIGNED_CMP.
7497 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7498 not to EMACS_INT, to avoid GCC warning.
7500 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7502 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7503 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7504 isn't needed on 32-bit machines.
7506 * buffer.c (Fgenerate_new_buffer_name):
7507 Use EMACS_INT for count, not int.
7508 (advance_to_char_boundary): Return EMACS_INT, not int.
7510 * data.c (Qcompiled_function): Now static.
7512 * window.c (window_body_lines): Now static.
7514 * image.c (gif_load): Rename local to avoid shadowing.
7516 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7517 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7518 * alloc.c (make_save_value): Integer argument is now of type
7520 (mark_object): Use ptrdiff_t, not int.
7521 * lisp.h (pD): New macro.
7522 * print.c (print_object): Use it.
7524 * alloc.c: Use EMACS_INT, not int, to count objects.
7525 (total_conses, total_markers, total_symbols, total_vector_size)
7526 (total_free_conses, total_free_markers, total_free_symbols)
7527 (total_free_floats, total_floats, total_free_intervals)
7528 (total_intervals, total_strings, total_free_strings):
7529 Now EMACS_INT, not int. All uses changed.
7530 (Fgarbage_collect): Compute overall total using a double, so that
7531 integer overflow is less likely to be a problem. Check for overflow
7532 when converting back to an integer.
7533 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7534 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7535 These were 'int' variables that could overflow on 64-bit hosts;
7536 they were never used, so remove them instead of repairing them.
7537 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7538 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7539 Previously, this ceilinged at INT_MAX, but that doesn't work on
7541 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7543 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7544 (allocate_vectorlike): Check for ptrdiff_t overflow.
7545 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7546 when a (possibly-narrower) signed value would do just as well.
7547 We prefer using signed arithmetic, to avoid comparison confusion.
7549 * alloc.c: Catch some string size overflows that we were missing.
7550 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7551 for convenience in STRING_BYTES_MAX.
7552 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7553 The definition here is exact; the one in lisp.h was approximate.
7554 (allocate_string_data): Check for string overflow. This catches
7555 some instances we weren't catching before. Also, it catches
7556 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7557 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7558 and ptrdiff_t and EMACS_INT are both 64 bits.
7560 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7561 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7562 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7564 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7566 * alloc.c (Fmake_string): Check for out-of-range init.
7568 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7570 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7572 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7574 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7575 xg_get_default_scrollbar_width.
7577 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7578 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7579 (style_changed_cb): Call update_theme_scrollbar_width and call
7580 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7581 all frames (Bug#8505).
7582 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7583 Call gtk_window_set_resizable if HAVE_GTK3.
7584 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7585 and height if HAVE_GTK3 (Bug#8505).
7586 (scroll_bar_width_for_theme): New variable.
7587 (update_theme_scrollbar_width): New function.
7588 (xg_get_default_scrollbar_width): Move code to
7589 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7590 (xg_initialize): Call update_theme_scrollbar_width.
7592 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7594 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7596 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7598 * frame.c (make_frame): Call other_buffer_safely instead of
7601 * window.c (temp_output_buffer_show): Call display_buffer with
7602 second argument Vtemp_buffer_show_specifiers and reset latter
7603 immediately after the call.
7604 (Vtemp_buffer_show_specifiers): New variable.
7605 (auto_window_vscroll_p, next_screen_context_lines)
7606 (Vscroll_preserve_screen_position): Remove leading asterisks from
7609 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7611 Fix minor problems found by GCC 4.6.0 static checking.
7612 * buffer.c (Qclone_number): Remove for now, as it's unused.
7613 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7614 (record_buffer): Remove unused local.
7615 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7616 (set_frame_buffer_list): Remove; unused.
7617 * frame.h (other_visible_frames): Remove decl.
7618 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7619 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7620 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7622 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7623 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7624 Define only if HAVE_GPM.
7625 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7626 (update_hints_inhibit): Remove; never set. All uses removed.
7627 * widgetprv.h (emacsFrameClassRec): Remove decl.
7628 * window.c (delete_deletable_window): Now returns void, since it
7629 wasn't returning anything.
7630 (compare_window_configurations): Remove unused locals.
7631 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7632 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7633 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7634 the same widths as pointers. This follows up on the 2011-05-06 patch.
7635 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7636 * xterm.h: Likewise.
7637 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7639 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7641 * makefile.w32-in: Update dependencies.
7642 (LISP_H): Add lib/intprops.h.
7644 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7646 * image.c (gif_load): Add animation frame delay to the metadata.
7647 (syms_of_image): Use DEFSYM. New symbol `delay'.
7649 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7651 * window.c (delete_deletable_window): Re-add.
7652 (Fset_window_configuration): Rewrite to handle dead buffers and
7653 consequently deletable windows.
7654 (window_tree, Fwindow_tree): Remove. Supply functionality in
7656 (compare_window_configurations): Simplify code.
7658 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7660 * image.c (imagemagick_load_image): Fix type mismatch.
7661 (Fimagemagick_types): Likewise.
7663 * window.h (replace_buffer_in_windows): Declare.
7665 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7667 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7668 Qclone_number. Remove external declaration of Qdelete_window.
7669 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7671 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7672 Run Qbuffer_list_update_hook if allowed.
7673 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7674 buffer list implementation.
7675 (other_buffer_safely): New function.
7676 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7677 calls to replace_buffer_in_windows and
7678 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7680 (record_buffer): Inhibit quitting and rewrite using quittable
7681 functions. Run Qbuffer_list_update_hook if allowed.
7682 (Frecord_buffer, Funrecord_buffer): New functions.
7683 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7684 Move switch-to-buffer to window.el.
7685 (bury-buffer): Move to window.el.
7686 (Vbuffer_list_update_hook): New variable.
7688 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7691 * window.h (resize_frame_windows): Move up in code.
7692 (Fwindow_frame): Remove EXFUN.
7693 (replace_buffer_in_all_windows): Remove prototype.
7694 (replace_buffer_in_windows_safely): Add prototype.
7696 * window.c: Declare Qdelete_window static again. Move down
7697 declaration of select_count.
7698 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7699 (Fother_window): Move to window.el.
7700 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7701 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7702 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7704 (replace_buffer_in_windows): Implement by calling
7705 Qreplace_buffer_in_windows.
7706 (replace_buffer_in_all_windows): Remove with some functionality
7707 moved into replace_buffer_in_windows_safely.
7708 (replace_buffer_in_windows_safely): New function.
7709 (select_window_norecord, select_frame_norecord): Move in front
7710 of run_window_configuration_change_hook. Remove now obsolete
7712 (Fset_window_buffer): Rewrite doc-string.
7713 Call Qrecord_window_buffer.
7714 (keys_of_window): Move binding for other-window to window.el.
7716 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7718 * dispextern.h (struct image): Replace data member, whose int_val
7719 and ptr_val fields were not used by anything, with a single
7722 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7723 (gif_clear_image, gif_load, imagemagick_load_image)
7724 (gs_clear_image, gs_load): Callers changed.
7726 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7728 * buffer.h: Include <time.h>, for time_t.
7729 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7731 Fix minor problems found by static checking.
7733 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7735 Make identifiers static if they are not used in other modules.
7736 * data.c (Qcompiled_function, Qframe, Qvector):
7737 * image.c (QimageMagick, Qsvg):
7738 * minibuf.c (Qmetadata):
7739 * window.c (resize_window_check, resize_root_window): Now static.
7740 * window.h (resize_window_check, resize_root_window): Remove decls.
7742 * window.c (window_deletion_count, delete_deletable_window):
7744 (window_body_lines): Now static.
7745 (Fdelete_other_windows_internal): Mark vars as initialized.
7746 Make sure 'resize_failed' is initialized.
7747 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7748 (resize_window_apply): Remove unused local.
7749 * window.h (delete_deletable_window): Remove decl.
7751 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7752 (imagemagick_load_image): Fix pointer signedness problem by changing
7753 last arg from unsigned char * to char *. All uses changed.
7754 Also, fix a local for similar reasons.
7755 Remove unused locals. Remove locals to avoid shadowing.
7756 (fn_rsvg_handle_free): Remove; unused.
7757 (svg_load, svg_load_image): Fix pointer signedness problem.
7758 (imagemagick_load_image): Don't use garbage pointer image_wand.
7760 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7762 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7764 * image.c (gif_load): Fix omitted cast error introduced by
7767 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7769 * window.h (resize_proportionally, orig_total_lines)
7770 (orig_top_line): Remove from window structure.
7771 (set_window_height, set_window_width, change_window_heights)
7772 (Fdelete_window): Remove prototypes.
7773 (resize_frame_windows): Remove duplicate declaration.
7775 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7777 * window.h (resize_frame_windows, resize_window_check)
7778 (delete_deletable_window, resize_root_window)
7779 (resize_frame_windows): Declare prototypes.
7781 * window.c (resize_window_apply): Make definition be "static" to
7782 match the prototype.
7784 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7786 * window.c: Remove declarations of Qwindow_size_fixed,
7787 window_min_size_1, window_min_size_2, window_min_size,
7788 size_window, window_fixed_size_p, enlarge_window, delete_window.
7789 Remove static from declaration of Qdelete_window, it's
7790 temporarily needed by Fbury_buffer.
7791 (replace_window): Don't assign orig_top_line and
7793 (Fdelete_window, delete_window): Remove. Window deletion is
7794 handled by window.el.
7795 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7796 Replace Fdelete_window calls with calls to Qdelete_window.
7797 (Fdelete_other_windows): Remove. Deleting other windows is
7798 handled by window.el.
7799 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7800 handled in window.el.
7801 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7802 Window minimum sizes are handled in window.el.
7803 (shrink_windows, size_window, set_window_height)
7804 (set_window_width, change_window_heights, window_height)
7805 (window_width, CURBEG, CURSIZE, enlarge_window)
7806 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7807 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7808 handled in window.el.
7809 (make_dummy_parent): Rename to make_parent_window and give it a
7810 second argument horflag.
7811 (make_window): Don't set resize_proportionally any more.
7812 (Fsplit_window): Remove. Windows are split in window.el.
7813 (save_restore_action, save_restore_orig_size)
7814 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7815 Resize mini windows in window.el.
7816 (grow_mini_window, shrink_mini_window): Implement by calling
7817 Qresize_root_window_vertically, resize_window_check and
7818 resize_window_apply.
7819 (saved_window, Fset_window_configuration, save_window_save):
7820 Do not handle orig_top_line, orig_total_lines, and
7821 resize_proportionally.
7822 (window_min_height, window_min_width): Move to window.el.
7823 (keys_of_window): Move bindings for delete-other-windows,
7824 split-window, delete-window and enlarge-window to window.el.
7826 * buffer.c: Temporarily extern Qdelete_window.
7827 (Fbury_buffer): Temporarily call Qdelete_window instead of
7828 Fdelete_window (Fbury_buffer will move to window.el soon).
7830 * frame.c (set_menu_bar_lines_1): Remove code handling
7831 orig_top_line and orig_total_lines.
7833 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7834 set_window_height but set heights directly.
7835 (change_frame_size_1): Use resize_frame_windows.
7837 * xdisp.c (init_xdisp): Don't use set_window_height but set
7840 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7841 Use resize_frame_windows instead of change_window_heights and run
7842 run_window_configuration_change_hook.
7844 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7845 instead of change_window_heights and run
7846 run_window_configuration_change_hook.
7848 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7850 * window.c (replace_window): Rename second argument REPLACEMENT to
7851 NEW. New third argument SETFLAG. Rewrite.
7852 (delete_window, make_dummy_parent): Call replace_window with
7854 (window_list_1): Move down in code.
7855 (run_window_configuration_change_hook): Move set_buffer part
7856 before select_frame_norecord part in order to unwind correctly.
7857 Rename count1 to count.
7858 (recombine_windows, delete_deletable_window, resize_root_window)
7859 (Fdelete_other_windows_internal)
7860 (Frun_window_configuration_change_hook, make_parent_window)
7861 (resize_window_check, resize_window_apply, Fresize_window_apply)
7862 (resize_frame_windows, Fsplit_window_internal)
7863 (Fdelete_window_internal, Fresize_mini_window_internal):
7865 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7867 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7869 * window.h (window): Add some new members to window structure -
7870 normal_lines, normal_cols, new_total, new_normal, clone_number,
7871 splits, nest, prev_buffers, next_buffers.
7872 (WINDOW_TOTAL_SIZE): Move here from window.c.
7873 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7875 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7877 (make_dummy_parent): Set new members of windows structure.
7878 (make_window): Move down in code. Handle new members of window
7880 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7881 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7882 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7883 (Fset_window_prev_buffers, Fwindow_next_buffers)
7884 (Fset_window_next_buffers, Fset_window_clone_number):
7886 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7887 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7889 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7890 Argument WINDOW can be now internal window too.
7891 (Fwindow_use_time): Move up in code.
7892 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7894 (Fset_window_configuration, saved_window)
7895 (Fcurrent_window_configuration, save_window_save): Handle new
7896 members of window structure.
7897 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7898 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7899 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7900 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7901 Qget_mru_window, Qresize_root_window,
7902 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7903 Qauto_buffer_name; staticpro them.
7905 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7907 * window.c (Fwindow_total_size, Fwindow_left_column)
7908 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7909 (Fwindow_list_1): New functions.
7910 (window_box_text_cols): Replace with window_body_cols.
7911 (Fwindow_width, Fscroll_left, Fscroll_right):
7912 Use window_body_cols instead of window_box_text_cols.
7913 (delete_window, Fset_window_configuration):
7914 Call delete_all_subwindows with window as argument.
7915 (delete_all_subwindows): Take a window as argument and not a
7917 (window_loop): Remove handling of GET_LRU_WINDOW and
7919 (Fget_lru_window, Fget_largest_window): Move to window.el.
7921 * window.h: Extern window_body_cols instead of
7922 window_box_text_cols. delete_all_subwindows now takes a
7923 Lisp_Object as argument.
7925 * indent.c (compute_motion, Fcompute_motion):
7926 Use window_body_cols instead of window_box_text_cols.
7928 * frame.c (delete_frame): Call delete_all_subwindows with root
7931 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7933 * fns.c (Fputhash): Document return value.
7935 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7937 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7939 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7941 Cons<->int and similar integer overflow fixes (Bug#8794).
7943 Check for overflow when converting integer to cons and back.
7944 * charset.c (Fdefine_charset_internal, Fdecode_char):
7945 Use cons_to_unsigned to catch overflow.
7946 (Fencode_char): Use INTEGER_TO_CONS.
7947 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7948 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7949 * data.c (long_to_cons, cons_to_long): Remove.
7950 (cons_to_unsigned, cons_to_signed): New functions.
7951 These signal an error for invalid or out-of-range values.
7952 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7953 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7954 * font.c (Ffont_variation_glyphs):
7955 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7956 * lisp.h: Include <intprops.h>.
7957 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7958 (cons_to_signed, cons_to_unsigned): New decls.
7959 (long_to_cons, cons_to_long): Remove decls.
7960 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7961 (Fprimitive_undo): Use CONS_TO_INTEGER.
7962 * xfns.c (Fx_window_property): Likewise.
7963 * xselect.c: Include <limits.h>.
7964 (x_own_selection, selection_data_to_lisp_data):
7965 Use INTEGER_TO_CONS.
7966 (x_handle_selection_request, x_handle_selection_clear)
7967 (x_get_foreign_selection, Fx_disown_selection_internal)
7968 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7969 (lisp_data_to_selection_data): Use cons_to_unsigned.
7970 (x_fill_property_data): Use cons_to_signed.
7971 Report values out of range.
7973 Check for buffer and string overflow more precisely.
7974 * buffer.h (BUF_BYTES_MAX): New macro.
7975 * lisp.h (STRING_BYTES_MAX): New macro.
7976 * alloc.c (Fmake_string):
7977 * character.c (string_escape_byte8):
7978 * coding.c (coding_alloc_by_realloc):
7979 * doprnt.c (doprnt):
7980 * editfns.c (Fformat):
7982 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7983 since they may not be the same number.
7984 * editfns.c (Finsert_char):
7985 * fileio.c (Finsert_file_contents):
7986 Likewise for BUF_BYTES_MAX.
7988 * image.c: Use ptrdiff_t, not int, for sizes.
7989 (slurp_file): Switch from int to ptrdiff_t.
7991 (slurp_file): Check that file size fits in both size_t (for
7992 malloc) and ptrdiff_t (for sanity and safety).
7994 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7995 if b->modtime has its maximal value.
7997 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7999 Don't assume time_t can fit into int.
8000 * buffer.h (struct buffer.modtime): Now time_t, not int.
8001 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8002 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8004 Minor fixes for signed vs unsigned integers.
8005 * character.h (MAYBE_UNIFY_CHAR):
8006 * charset.c (maybe_unify_char):
8007 * keyboard.c (read_char, reorder_modifiers):
8008 XINT -> XFASTINT, since the integer must be nonnegative.
8009 * ftfont.c (ftfont_spec_pattern):
8010 * keymap.c (access_keymap, silly_event_symbol_error):
8011 XUINT -> XFASTINT, since the integer must be nonnegative.
8012 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8013 since it makes no difference and we prefer signed.
8014 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8015 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8018 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8020 * window.h (Fwindow_frame): Declare.
8022 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8024 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8025 (SPARE_MEMORY): Always define.
8026 (LARGE_REQUEST): Remove.
8027 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8029 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8031 * lisp.h: Move EXFUNS for Fframe_root_window,
8032 Fframe_first_window and Fset_frame_selected_window to window.h.
8034 * window.h: Move EXFUNS for Fframe_root_window,
8035 Fframe_first_window and Fset_frame_selected_window here from
8038 * frame.c (Fwindow_frame, Fframe_first_window)
8039 (Fframe_root_window, Fframe_selected_window)
8040 (Fset_frame_selected_window): Move to window.c.
8041 (Factive_minibuffer_window): Move to minibuf.c.
8042 (Fother_visible_frames_p): New function.
8044 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8046 * window.c (decode_window, decode_any_window): Move up in code.
8047 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8048 (inhibit_frame_unsplittable): Remove unused variable.
8049 (Fwindow_buffer): Move up and rewrite doc-string.
8050 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8051 (Fwindow_prev): New functions.
8052 (Fwindow_frame): Move here from frame.c. Accept any window as
8054 (Fframe_root_window, Fframe_first_window)
8055 (Fframe_selected_window): Move here from frame.c. Accept frame
8056 or arbitrary window as argument. Update doc-strings.
8057 (Fminibuffer_window): Move up in code.
8058 (Fwindow_minibuffer_p): Move up in code and simplify.
8059 (Fset_frame_selected_window): Move here from frame.c.
8061 (Fselected_window, select_window, Fselect_window): Move up in
8062 code. Minor doc-string fixes.
8064 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8066 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8067 Do not assume that spare memory exists; that assumption is valid
8068 only if SYSTEM_MALLOC.
8069 (LARGE_REQUEST): New macro, so that the issue of large requests
8070 is separated from the issue of spare memory.
8072 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8074 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8077 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8079 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8082 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8084 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8086 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8088 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8089 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8091 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8093 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8095 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8097 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8098 (x_clipboard_manager_save): Add return value.
8099 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8101 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8102 Obey Vx_select_enable_clipboard_manager. Catch errors in
8103 x_clipboard_manager_save (Bug#8779).
8104 (Vx_select_enable_clipboard_manager): New variable.
8105 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8107 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8109 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8111 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8113 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8114 in the current matrix if keep_current_p is non-zero.
8116 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8118 * bidi.c (bidi_level_of_next_char): Fix last change.
8120 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8122 Support bidi reordering of text covered by display properties.
8124 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8125 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8126 (bidi_cache_search, bidi_cache_iterator_state)
8127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8128 (bidi_level_of_next_char, bidi_move_to_visually_next):
8129 Support character positions inside a run of characters covered by a
8131 (bidi_paragraph_init, bidi_resolve_explicit_1)
8132 (bidi_level_of_next_char): Call bidi_fetch_char and
8133 bidi_fetch_char_advance instead of FETCH_CHAR and
8135 (bidi_init_it): Initialize new members.
8136 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8138 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8139 instead of using explicit *_CHAR codes.
8140 (bidi_resolve_explicit, bidi_resolve_weak):
8141 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8142 bidirectional text is supported only in multibyte buffers.
8143 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8144 it to initialize the frame_window_p member of struct bidi_it.
8145 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8146 (bidi_resolve_explicit, bidi_resolve_weak)
8147 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8148 bidi_it->nchars is non-positive.
8149 (bidi_level_of_next_char): Don't try to lookup the cache for the
8150 next/previous character if nothing is cached there yet, or if we
8151 were just reseat()'ed to a new position.
8153 * xdisp.c (set_cursor_from_row): Set start and stop points
8154 according to the row's direction when priming the loop that looks
8155 for the glyph on which to display cursor.
8156 (single_display_spec_intangible_p): Function deleted.
8157 (display_prop_intangible_p): Reimplement to call
8158 handle_display_spec instead of single_display_spec_intangible_p.
8159 Accept 3 additional arguments needed by handle_display_spec.
8160 This fixes incorrect cursor motion across display property with complex
8161 values: lists, `(when COND...)' forms, etc.
8162 (single_display_spec_string_p): Support property values that are
8163 lists with the argument STRING its top-level element.
8164 (display_prop_string_p): Fix the condition for processing a
8165 property that is a list to be consistent with handle_display_spec.
8166 (handle_display_spec): New function, refactored from the
8167 last portion of handle_display_prop.
8168 (compute_display_string_pos): Accept additional argument
8169 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8170 value of a `display' property is a "replacing spec".
8171 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8172 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8173 the display property, but just return a value indicating whether
8174 the display property will replace the characters it covers.
8175 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8176 frame_window_p members of struct bidi_it.
8177 (compute_display_string_pos, compute_display_string_end):
8179 (push_it): Accept second argument POSITION, where pop_it should
8180 jump to continue iteration.
8181 (reseat_1): Initialize bidi_it.disp_pos.
8183 * keyboard.c (adjust_point_for_property): Adjust the call to
8184 display_prop_intangible_p to its new signature.
8186 * dispextern.h (struct bidi_it): New member frame_window_p.
8187 (bidi_init_it): Update prototypes.
8188 (display_prop_intangible_p): Update prototype.
8189 (compute_display_string_pos, compute_display_string_end):
8191 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8194 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8196 Malloc failure behavior now depends on size of allocation.
8197 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8198 * lisp.h: Change signatures accordingly.
8199 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8200 All callers changed. (Bug#8762)
8202 * gnutls.c: Use Emacs's memory allocators.
8203 Without this change, the gnutls library would invoke malloc etc.
8204 directly, which causes problems on non-SYNC_INPUT hosts, and which
8205 runs afoul of improving memory_full behavior. (Bug#8761)
8206 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8207 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8208 xfree instead of the default malloc, realloc, free.
8209 (Fgnutls_boot): No need to check for memory allocation failure,
8210 since xmalloc does that for us.
8212 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8213 * category.c (hash_get_category_set):
8214 * ccl.c (ccl_driver):
8215 * charset.c (Fdefine_charset_internal):
8216 * charset.h (struct charset.hash_index):
8217 * composite.c (get_composition_id, gstring_lookup_cache)
8218 (composition_gstring_put_cache):
8219 * composite.h (struct composition.hash_index):
8220 * dispextern.h (struct image.hash):
8221 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8222 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8223 (hashfn_equal, hashfn_user_defined, make_hash_table)
8224 (maybe_resize_hash_table, hash_lookup, hash_put)
8225 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8227 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8228 * image.c (make_image, search_image_cache, lookup_image)
8229 (xpm_put_color_table_h):
8230 * lisp.h (struct Lisp_Hash_Table):
8231 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8232 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8233 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8234 * alloc.c (allocate_vectorlike):
8235 Check for overflow in vector size calculations.
8236 * ccl.c (ccl_driver):
8237 Check for overflow when converting EMACS_INT to int.
8238 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8239 need to be updated by these changes.
8240 * fns.c (make_hash_table, maybe_resize_hash_table):
8241 Check for integer overflow with large hash tables.
8242 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8243 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8244 (SXHASH_REDUCE): New macro.
8245 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8246 Use it instead of discarding useful hash info with large hash values.
8247 (sxhash_float): New function.
8248 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8249 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8250 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8251 Rewrite to use FIXNUM_BITS, as this simplifies things.
8252 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8253 Adjust signatures to match updated version of code.
8254 (consing_since_gc): Now EMACS_INT, since a single hash table can
8255 use more than INT_MAX bytes.
8257 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8259 Make it possible to build with GCC-4.6+ -O2 -flto.
8261 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8263 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8265 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8266 Call minibuffer-inactive-mode.
8268 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8270 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8271 Update dependencies.
8273 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8275 * data.c (init_data): Remove code for UTS, this system is not
8278 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8280 Don't force ./temacs to start in terminal mode.
8282 * frame.c (make_initial_frame): Initialize faces in all cases, not
8283 only when CANNOT_DUMP is defined.
8284 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8286 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8288 * dispnew.c (add_window_display_history): Use const for the string
8289 pointer. Remove declaration, not needed.
8291 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8293 Use 'inline', not 'INLINE'.
8294 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8295 * alloc.c, fontset.c (INLINE): Remove.
8296 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8297 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8298 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8299 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8300 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8302 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8304 Make it possible to run ./temacs.
8306 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8307 syms_of_callproc does the same thing. Remove test for
8308 "initialized", do it in the caller.
8309 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8311 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8313 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8314 (read_minibuf): Use get_minibuffer.
8315 (syms_of_minibuf): Use DEFSYM.
8316 (Qmetadata): New var.
8317 * data.c (Qbuffer): Don't make it static.
8318 (syms_of_data): Use DEFSYM.
8320 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8322 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8323 (CCL_CODE_MIN): New macro.
8325 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8327 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8329 * eval.c (Qdebug): Now static.
8330 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8331 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8332 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8334 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8336 * image.c: Various fixes to ImageMagick code comments.
8337 (Fimagemagick_types): Doc fix.
8339 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8341 Minor fixes prompted by GCC 4.6.0 warnings.
8343 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8345 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8346 (x_clipboard_manager_save_all): Move extern decl to ...
8347 * xterm.h: ... here, so that it can be checked for consistency.
8349 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8351 * xselect.c (x_clipboard_manager_save_frame)
8352 (x_clipboard_manager_save_all): New functions.
8353 (Fx_clipboard_manager_save): Lisp function deleted.
8355 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8356 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8358 * xterm.h: Update prototype.
8360 2011-05-28 William Xu <william.xwl@gmail.com>
8362 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8365 2011-05-28 Jim Meyering <meyering@redhat.com>
8367 Avoid a sign-extension bug in crypto_hash_function.
8368 * fns.c (to_uchar): Define.
8369 (crypto_hash_function): Use it to convert some newly-signed
8370 variables to unsigned, to avoid sign-extension bugs. For example,
8371 without this change, (md5 "truc") would evaluate to
8372 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8373 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8374 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8376 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8378 Integer overflow fixes.
8380 * dbusbind.c: Serial number integer overflow fixes.
8381 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8382 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8383 to hold a serial number that is too large for a fixnum.
8384 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8385 Check for serial numbers out of range. Decode any serial number
8386 that was so large that it became a float. (Bug#8722)
8388 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8389 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8390 Use XFASTINT rather than XUINT when numbers are nonnegative.
8391 (xd_append_arg, Fdbus_method_return_internal):
8392 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8393 arguments, check that Lisp number is nonnegative, rather than
8394 silently wrapping negative numbers around. (Bug#8722)
8395 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8398 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8400 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8402 ccl: Add integer overflow checks.
8403 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8404 (IN_INT_RANGE): New macros.
8405 (ccl_driver): Use them to check for integer overflow when
8406 decoding a CCL program. Many of the new checks are whether XINT (x)
8407 fits in int; it doesn't always, on 64-bit hosts. The new version
8408 doesn't catch all possible integer overflows, but it's an
8409 improvement. (Bug#8719)
8411 * alloc.c (make_event_array): Use XINT, not XUINT.
8412 There's no need for unsigned here.
8414 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8415 This follows up to the 2011-05-06 change that substituted uintptr_t
8416 for EMACS_INT. This case wasn't caught back then.
8418 Rework Fformat to avoid integer overflow issues.
8419 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8420 now (part of C89). Include <verify.h>.
8421 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8422 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8423 (Fformat): Avoid the prepass trying to compute sizes; it was only
8424 approximate and thus did not catch overflow reliably. Instead, walk
8425 through the format just once, formatting and computing sizes as we go,
8426 checking for integer overflow at every step, and allocating a larger
8427 buffer as needed. Keep track separately whether the format is
8428 multibyte. Keep only the most-recently calculated precision, rather
8429 than them all. Record whether each argument has been converted to
8430 string. Use EMACS_INT, not int, for byte and char and arg counts.
8431 Support field widths and precisions larger than INT_MAX. Avoid
8432 sprintf's undefined behavior with conversion specifications such as %#d
8433 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8434 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8435 formatting out-of-range floating point numbers with int
8438 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8440 * data.c: Avoid integer truncation in expressions involving floats.
8441 * data.c: Include <intprops.h>.
8442 (arith_driver): When there's an integer overflow in an expression
8443 involving floating point, convert the integers to floating point
8444 so that the resulting value does not suffer from catastrophic
8445 integer truncation. For example, on a 64-bit host (* 4
8446 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8447 Do not rely on undefined behavior after integer overflow.
8449 merge count_size_as_multibyte, parse_str_to_multibyte
8450 * character.c, character.h (count_size_as_multibyte):
8451 Rename from parse_str_to_multibyte; all uses changed.
8452 Check for integer overflow.
8453 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8454 since it's now a duplicate of the other. This is more of
8455 a character than a buffer op, so better that it's in character.c.
8456 * fns.c, print.c: Adjust to above changes.
8458 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8460 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8462 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8464 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8465 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8466 (x_clipboard_manager_save): Now static.
8467 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8469 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8470 (crypto_hash_function): Now static.
8471 Fix pointer signedness problems. Avoid unnecessary initializations.
8473 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8475 * termhooks.h (Vselection_alist): Make it terminal-local.
8477 * terminal.c (create_terminal): Initialize it.
8479 * xselect.c: Support for clipboard managers.
8480 (Vselection_alist): Move to termhooks.h as terminal-local var.
8481 (LOCAL_SELECTION): New macro.
8482 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8483 (symbol_to_x_atom): Remove gratuitous arg.
8484 (x_handle_selection_request, lisp_data_to_selection_data)
8485 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8486 (x_own_selection, x_get_local_selection, x_convert_selection):
8487 New arg, specifying work frame. Use terminal-local Vselection_alist.
8488 (some_frame_on_display): Delete unused function.
8489 (Fx_own_selection_internal, Fx_get_selection_internal)
8490 (Fx_disown_selection_internal, Fx_selection_owner_p)
8491 (Fx_selection_exists_p): New optional frame arg.
8492 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8493 (x_handle_selection_clear): Don't treat other terminals with the
8494 same keyboard specially. Use the terminal-local Vselection_alist.
8495 (x_clear_frame_selections): Use Frun_hook_with_args.
8497 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8499 * xterm.h: Add support for those atoms.
8501 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8503 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8504 (converted_selections, conversion_fail_tag): New global variables.
8505 (x_selection_request_lisp_error): Free the above.
8506 (x_get_local_selection): Remove unnecessary code.
8507 (x_reply_selection_request): Args changed; handle arbitrary array
8508 of converted selections stored in converted_selections.
8509 Separate the XChangeProperty and SelectionNotify steps.
8510 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8511 (x_convert_selection): New function.
8512 (x_handle_selection_event): Simplify.
8513 (x_get_foreign_selection): Don't ignore incoming requests while
8514 waiting for an answer; this will fail when we implement
8515 SAVE_TARGETS, and seems unnecessary anyway.
8516 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8517 (Vx_sent_selection_functions): Doc fix.
8519 2011-05-26 Leo Liu <sdl.web@gmail.com>
8521 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8523 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8525 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8527 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8528 for fringe update if it has periodic bitmap.
8529 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8530 and fringe_bitmap_periodic_p.
8532 * fringe.c (get_fringe_bitmap_data): New function.
8533 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8534 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8535 row. Mark glyph row for fringe update if periodicity changed.
8537 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8538 for fringe update unless it has periodic bitmap.
8540 2011-05-25 Kenichi Handa <handa@m17n.org>
8542 * xdisp.c (get_next_display_element): Set correct it->face_id for
8543 a static composition.
8545 2011-05-24 Leo Liu <sdl.web@gmail.com>
8548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8550 * fns.c (crypto_hash_function, Fsha1): New function.
8551 (Fmd5): Use crypto_hash_function.
8552 (syms_of_fns): Add Ssha1.
8554 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8556 * gnutls.c: Remove unused macros.
8557 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8558 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8559 Remove macros that are defined and never used.
8560 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8562 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8564 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8565 (Fx_get_selection_internal): Minor cleanup.
8566 (Fx_own_selection_internal): Rename arguments for consistency with
8569 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8571 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8573 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8575 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8577 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8579 * dispnew.c (scrolling_window): Don't exclude the case that the
8580 last enabled row in the desired matrix touches the bottom boundary.
8582 2011-05-21 Glenn Morris <rgm@gnu.org>
8584 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8585 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8586 and add some more files.
8588 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8590 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8591 report_file_error introduced by the change from 2011-05-07.
8593 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8595 * systime.h (Time): Define only if emacs is defined.
8596 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8597 where the include path doesn't have X11/X.h by default. See
8598 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8600 2011-05-20 Kenichi Handa <handa@m17n.org>
8602 * composite.c (find_automatic_composition): Fix previous change.
8604 2011-05-20 Glenn Morris <rgm@gnu.org>
8606 * lisp.mk: New file, split from Makefile.in.
8607 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8608 (shortlisp): Remove.
8609 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8611 2011-05-19 Glenn Morris <rgm@gnu.org>
8613 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8614 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8615 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8616 (lisp): Set the order to that of loadup.el.
8617 (shortlisp): Make it a copy of $lisp.
8618 (SOME_MACHINE_LISP): Remove.
8619 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8620 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8622 2011-05-18 Kenichi Handa <handa@m17n.org>
8624 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8625 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8626 (find_automatic_composition): Mostly rewrite for efficiency.
8628 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8630 * makefile.w32-in: Update dependencies.
8632 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8634 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8635 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8637 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8639 Fix some integer overflow issues, such as string length overflow.
8641 * insdel.c (count_size_as_multibyte): Check for string overflow.
8643 * character.c (lisp_string_width): Check for string overflow.
8644 Use EMACS_INT, not int, for string indexes and lengths; in
8645 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8646 the resulting string length overflows an EMACS_INT; instead,
8647 report a string overflow if no precision given. When checking for
8648 precision exhaustion, use a check that cannot possibly have
8649 integer overflow. (Bug#8675)
8650 * character.h (lisp_string_width): Adjust to new signature.
8652 * alloc.c (string_overflow): New function.
8653 (Fmake_string): Use it. This doesn't change behavior, but saves
8654 a few bytes and will simplify future changes.
8655 * character.c (string_escape_byte8): Likewise.
8656 * lisp.h (string_overflow): New decl.
8658 Fixups, following up to the user-interface timestamp change.
8659 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8660 for UI timestamps, instead of unsigned long.
8661 * msdos.c (mouse_get_pos): Likewise.
8662 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8663 * w32gui.h (Time): Define by including "systime.h" rather than by
8664 declaring it ourselves. (Bug#8664)
8666 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8667 * image.c (clear_image_cache): Likewise.
8669 * term.c (term_mouse_position): Don't assume time_t wraparound.
8671 Be more systematic about user-interface timestamps.
8672 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8673 and sometimes 'EMACS_UINT', to represent these timestamps.
8674 This change causes it to use 'Time' uniformly, as that's what X uses.
8675 This makes the code easier to follow, and makes it easier to catch
8676 integer overflow bugs such as Bug#8664.
8677 * frame.c (Fmouse_position, Fmouse_pixel_position):
8678 Use Time, not unsigned long, for user-interface timestamps.
8679 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8680 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8681 * keyboard.h (last_event_timestamp): Likewise.
8682 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8683 * menu.h (xmenu_show): Likewise.
8684 * term.c (term_mouse_position): Likewise.
8685 * termhooks.h (struct input_event.timestamp): Likewise.
8686 (struct terminal.mouse_position_hook): Likewise.
8687 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8688 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8689 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8690 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8692 * menu.h, termhooks.h: Include "systime.h", for Time.
8694 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8695 Don't assume that the difference between two unsigned long values
8696 can fit into an integer. At this point, we know button_down_time
8697 <= event->timestamp, so the difference must be nonnegative, so
8698 there's no need to cast the result if double-click-time is
8699 nonnegative, as it should be; check that it's nonnegative, just in
8700 case. This bug is triggered when events are more than 2**31 ms
8701 apart (about 25 days). (Bug#8664)
8703 * xselect.c (last_event_timestamp): Remove duplicate decl.
8704 (x_own_selection): Remove needless cast to unsigned long.
8706 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8707 that always fit in int. Use a sentinel instead of a counter, to
8708 avoid a temp and to allay GCC's concerns about possible int overflow.
8709 * frame.h (struct frame): Use int for menu_bar_items_used
8710 instead of EMACS_INT, since it always fits in int.
8712 * menu.c (grow_menu_items): Check for int overflow.
8714 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8716 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8717 Before, the code was not consistent. These values cannot exceed
8718 2**31 - 1 so there's no need to make them unsigned.
8719 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8720 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8721 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8723 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8725 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8726 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8727 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8728 presumably because the widths might not match.
8730 * window.c (size_window): Avoid needless test at loop start.
8732 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8734 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8736 2011-05-12 Drew Adams <drew.adams@oracle.com>
8738 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8740 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8742 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8743 `width' to `bar_area_x' and `bar_area_width', respectively.
8744 (x_scroll_run): Take account of fringe background extension.
8746 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8747 Rename local vars `left' and `width' to `bar_area_x' and
8748 `bar_area_width', respectively.
8749 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8750 background extension.
8752 2011-05-10 Jim Meyering <meyering@redhat.com>
8754 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8756 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8758 * image.c (Finit_image_library): Return t for built-in image types,
8759 like pbm and xbm. (Bug#8640)
8761 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8763 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8765 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8767 * w32console.c (Fset_screen_color): Doc fix.
8768 (Fget_screen_color): New function.
8769 (syms_of_ntterm): Defsubr it.
8771 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8772 unlink the temporary file if Fcall_process didn't create it in the
8774 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8775 child process will be redirected to a file specified with `:file'.
8776 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8777 cue to call_process_cleanup not to close that handle.
8779 2011-05-07 Ben Key <bkey76@gmail.com>
8781 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8782 one of two shell specific rules, either bootstrap-temacs-CMD or
8783 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8784 to the previous implementation of the bootstrap-temacs rule.
8785 The bootstrap-temacs-CMD rule is similar to the previous
8786 implementation of the bootstrap-temacs rule except that it
8787 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8790 These changes, along with some changes to nt/configure.bat,
8791 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8792 earlier fix to add support for --cflags and --ldflags options
8793 that include quotes so that it works whether make uses cmd or
8796 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8798 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8799 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8801 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8802 a string. Handle both cases.
8803 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8804 (Fdbus_register_method): Use Qinvalid_function.
8806 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8808 * makefile.w32-in: Update dependencies.
8809 (LISP_H): Add inttypes.h and stdin.h.
8810 (PROCESS_H): Add unistd.h.
8812 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8814 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8815 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8817 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8819 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8821 * term.c (vfatal): Remove stray call to va_end.
8822 It's not needed and the C Standard doesn't allow it here anyway.
8824 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8825 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8827 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8830 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8834 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8836 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8838 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8840 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8841 * charset.c (Fdefine_charset_internal): Don't initialize
8842 charset.code_space[15]. The value was garbage, on hosts with
8843 32-bit int (Bug#8600).
8845 * lread.c (read_integer): Be more consistent with string-to-number.
8846 Use string_to_number to do the actual conversion; this avoids
8847 rounding errors and fixes some other screwups. Without this fix,
8848 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8849 (digit_to_number): Move earlier, for benefit of read_integer.
8850 Return -1 if the digit is out of range for the base, -2 if it is
8851 not a digit in any supported base. (Bug#8602)
8853 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8855 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8856 to match comment at start of function. This also removes a
8857 GCC warning about overflow in a 32+64-bit port.
8859 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8861 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8862 Reported by Stefan Monnier in
8863 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8864 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8865 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8867 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8868 (EMACS_UINTPTR): Likewise, with uintptr_t.
8870 * lisp.h: Prefer 64-bit EMACS_INT if available.
8871 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8872 on 32-bit hosts that have 64-bit int, so that they can access
8874 However, temporarily disable this change unless the temporary
8875 symbol WIDE_EMACS_INT is defined.
8877 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8879 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8880 This removes an assumption that EMACS_INT and long are the same
8881 width as pointers. The assumption is true for Emacs porting targets
8882 now, but we want to make other targets possible.
8883 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8884 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8885 In the rest of the code, change types of integers that hold casted
8886 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8887 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8888 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8889 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8890 No need to cast type when ORing.
8891 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8892 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8893 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8894 assume EMACS_INT is the same width as char *.
8895 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8896 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8897 Remove no-longer-needed casts.
8898 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8899 (xg_tool_bar_help_callback, xg_make_tool_item):
8900 Use EMACS_INTPTR to hold an integer
8901 that will be cast to void *; this can avoid a GCC warning
8902 if EMACS_INT is not the same width as void *.
8903 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8904 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8905 (current_message_1, set_message_1):
8906 Use a local to convert to proper width without a cast.
8907 * xmenu.c (dialog_selection_callback): Likewise.
8909 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8910 Also, don't assume VALBITS / RAND_BITS is less than 5,
8911 and don't rely on undefined behavior when shifting a 1 left into
8913 * lisp.h (get_random): Change signature to match.
8915 * lread.c (hash_string): Use size_t, not int, for hash computation.
8916 Normally we prefer signed values; but hashing is special, because
8917 it's better to use unsigned division on hash table sizes so that
8918 the remainder is nonnegative. Also, size_t is the natural width
8919 for hashing into memory. The previous code used 'int', which doesn't
8920 retain enough info to hash well into very large tables.
8921 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8923 * dbusbind.c: Don't possibly lose pointer info when converting.
8924 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8925 Use XPNTR rather than XHASH, so that the high-order bits of
8926 the pointer aren't lost when converting through void *.
8928 * eval.c (Fautoload): Don't double-shift a pointer.
8930 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8932 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8934 * gnutls.c (DEF_GNUTLS_FN):
8935 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8937 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8939 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8942 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8944 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8945 New version that can reserve upto 2GB of heap space.
8947 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8949 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8951 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8953 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8954 `gnutls_certificate_set_x509_key_file'.
8956 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8958 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8959 Update dependencies.
8961 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8963 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8964 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8965 Remove unused parameter `fildes'.
8966 * process.c (read_process_output, send_process): Don't pass it.
8968 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8970 Fix previous change: the library cache is defined in w32.c.
8971 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8972 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8974 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8976 Implement dynamic loading of GnuTLS on Windows.
8978 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8979 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8983 * gnutls.c (Qgnutls_dll): Define.
8984 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8985 (gnutls_*): Declare function pointers.
8986 (init_gnutls_functions): New function to initialize function pointers.
8987 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8988 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8990 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8991 (emacs_gnutls_write, emacs_gnutls_read)
8992 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8993 (Fgnutls_available_p): New function.
8994 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8995 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8996 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8998 * image.c: Include w32.h.
8999 (Vimage_type_cache): Delete.
9000 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9001 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9002 (w32_delayed_load): Move to w32.c.
9004 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9006 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9007 (w32_delayed_load): Move from image.c. When loading a library, record
9008 its filename in the :loaded-from property of the library id.
9009 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9010 Initialize and staticpro them.
9011 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9013 * process.c: Include lisp.h before w32.h, not after.
9014 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9015 instead of gnutls_record_check_pending.
9017 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9019 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9021 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9022 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9025 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9027 * xterm.c (x_set_frame_alpha): Do not set property on anything
9028 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9030 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9032 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9034 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9036 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9037 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9038 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9039 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9040 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9041 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9042 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9043 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9044 (Qgnutls_bootprop_callbacks_verify): Make static.
9046 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9048 * callproc.c: Indentation fixup.
9050 * sysdep.c (wait_for_termination_1): Make static.
9051 (wait_for_termination, interruptible_wait_for_termination):
9052 Move after wait_for_termination_1.
9054 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9056 * sysdep.c (interruptible_wait_for_termination): New function
9057 which is like wait_for_termination, but allows keyboard
9060 * callproc.c (Fcall_process): Add (:file "file") as an option for
9062 (Fcall_process_region): Ditto.
9064 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9066 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9067 rather than `XVECTOR (FOO)->size'.
9069 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9070 inttypes.h, as a gnulib replacement is used if it not available in
9073 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9075 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9076 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9077 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9079 * coding.c (coding_alloc_by_realloc): Error out if destination
9080 will grow beyond MOST_POSITIVE_FIXNUM.
9081 (decode_coding_emacs_mule): Abort if there isn't enough place in
9082 charbuf for the composition carryover bytes. Reserve an extra
9083 space for up to 2 characters produced in a loop.
9084 (decode_coding_iso_2022): Abort if there isn't enough place in
9085 charbuf for the composition carryover bytes.
9087 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9089 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9090 aborting when %lld or %lll format is passed.
9091 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9092 %llo or %llx format is passed. (Bug#8545)
9094 * window.c (window_scroll_line_based): Use a marker instead of
9095 simple variables to record original value of point. (Bug#7952)
9097 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9098 produced by %s or %c overflows available buffer space. (Bug#8545)
9100 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9102 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9103 (SIZE_MAX): Move defn after all includes, as they might #define it.
9105 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9107 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9109 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9111 * keyboard.c (Qdelayed_warnings_hook): Define.
9112 (command_loop_1): Run `delayed-warnings-hook'
9113 if Vdelayed_warnings_list is non-nil.
9114 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9115 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9117 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9119 * doprnt.c (doprnt): Don't return value smaller than the buffer
9120 size if the message was truncated. (Bug#8545).
9122 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9124 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9125 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9127 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9129 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9131 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9133 * makefile.w32-in: Update dependencies.
9135 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9137 Improve `doprnt' and its usage. (Bug#8545)
9138 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9139 `format_end'. Remove support for %l as a conversion specifier.
9140 Don't use xrealloc. Improve diagnostics when the %l size modifier
9141 is used. Update the commentary.
9143 * eval.c (verror): Simplify calculation of size_t.
9145 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9148 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9150 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9153 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9155 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9156 This makes this file independent of the recent pseudovector change.
9158 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9160 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9162 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9163 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9164 Remove unused local.
9165 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9167 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9168 GCC 4.6.0 optimizes based on type-based alias analysis.
9169 For example, if b is of type struct buffer * and v of type struct
9170 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9171 != &v->size, and therefore "v->size = 1; b->size = 2; return
9172 v->size;" must therefore return 1. This assumption is incorrect
9173 for Emacs, since it type-puns struct Lisp_Vector * with many other
9174 types. To fix this problem, this patch adds a new type struct
9175 vectorlike_header that documents the constraints on layout of vectors
9176 and pseudovectors, and helps optimizing compilers not get fooled
9177 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9178 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9179 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9181 (XSETPVECTYPE): Rewrite in terms of new macro.
9182 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9183 This is a bit clearer, and further avoids the possibility of
9184 undesirable aliasing.
9185 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9186 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9187 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9188 since Lisp_Subr is a special case (no "next" field).
9189 (ASIZE): Now uses header.size rather than size.
9190 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9191 to avoid the hassle of writing XVECTOR (foo)->header.size.
9192 (struct vectorlike_header): New type.
9193 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9194 object, to help avoid aliasing.
9195 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9196 (SUBRP): Likewise, since Lisp_Subr is a special case.
9197 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9198 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9199 (struct Lisp_Hash_Table): Combine first two members into a single
9200 struct vectorlike_header member. All uses of "size" and "next" members
9201 changed to be "header.size" and "header.next".
9202 * buffer.h (struct buffer): Likewise.
9203 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9204 * frame.h (struct frame): Likewise.
9205 * process.h (struct Lisp_Process): Likewise.
9206 * termhooks.h (struct terminal): Likewise.
9207 * window.c (struct save_window_data, struct saved_window): Likewise.
9208 * window.h (struct window): Likewise.
9209 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9210 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9211 * buffer.c (init_buffer_once): Likewise.
9212 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9214 * process.c (Fformat_network_address): Use local var for size,
9217 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9219 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9220 * data.c (atof): Remove decl; no longer used or needed.
9221 (digit_to_number): Move to lread.c.
9222 (Fstring_to_number): Use new string_to_number function, to be
9223 consistent with how the Lisp reader treats infinities and NaNs.
9224 Do not assume that floating-point numbers represent EMACS_INT
9225 without losing information; this is not true on most 64-bit hosts.
9226 Avoid double-rounding errors, by insisting on integers when
9227 parsing non-base-10 numbers, as the documentation specifies.
9228 * lisp.h (string_to_number): New decl, replacing ...
9229 (isfloat_string): Remove.
9230 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9231 (read1): Do not accept +. and -. as integers; this
9232 appears to have been a coding error. Similarly, do not accept
9233 strings like +-1e0 as floating point numbers. Do not report
9234 overflow for integer overflows unless the base is not 10 which
9235 means we have no simple and reliable way to continue.
9236 Break out the floating-point parsing into a new
9237 function string_to_number, so that Fstring_to_number parses
9238 floating point numbers consistently with the Lisp reader.
9239 (digit_to_number): Move here from data.c. Make it static inline.
9240 (E_CHAR, EXP_INT): Remove, replacing with ...
9241 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9242 (string_to_number): New function, replacing isfloat_string.
9243 This function checks for valid syntax and produces the resulting
9244 Lisp float number too. Rework it so that string-to-number
9245 no longer mishandles examples like "1.0e+". Use strtoumax,
9246 so that overflow for non-base-10 numbers is reported only when
9247 there's no portable and simple way to convert to floating point.
9249 * textprop.c (set_text_properties_1): Rewrite for clarity,
9250 and to avoid GCC warning about integer overflow.
9252 * intervals.h (struct interval): Use EMACS_INT for members
9253 where EMACS_UINT might cause problems. See
9254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9255 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9256 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9258 (offset_intervals): Tell GCC not to worry about length overflow
9259 when negating a negative length.
9261 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9262 (overrun_check_free): Likewise.
9264 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9265 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9268 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9269 (gnutls_make_error): Rename local to avoid shadowing.
9270 (gnutls_emacs_global_deinit): ifdef out; not used.
9271 (Fgnutls_boot): Use const for pointer to readonly storage.
9272 Comment out unused local. Fix pointer signedness problems.
9274 * lread.c (openp): Don't stuff size_t into an 'int'.
9275 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9276 about possible signed overflow.
9278 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9279 (GDK_KEY_g): Don't define if already defined.
9280 (xg_prepare_tooltip): Avoid pointer signedness problem.
9281 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9283 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9284 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9286 * xfns.c (Fx_window_property): Simplify a bit,
9287 to make a bit faster and to avoid GCC 4.6.0 warning.
9288 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9290 * fns.c (internal_equal): Don't assume size_t fits in int.
9292 * alloc.c (compact_small_strings): Tighten assertion a little.
9294 Replace pEd with more-general pI, and fix some printf arg casts.
9295 * lisp.h (pI): New macro, generalizing old pEd macro to other
9296 conversion specifiers. For example, use "...%"pI"d..." rather
9297 than "...%"pEd"...".
9298 (pEd): Remove. All uses replaced with similar uses of pI.
9299 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9300 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9301 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9302 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9303 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9304 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9305 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9307 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9308 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9309 * print.c (safe_debug_print, print_object): Likewise.
9310 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9312 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9313 avoiding the 0 flag, which is not portable.
9314 * process.c (Fmake_network_process): Use pI to avoid cast.
9315 * region-cache.c (pp_cache): Likewise.
9316 * xdisp.c (decode_mode_spec): Likewise.
9317 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9318 behavior on 64-bit hosts with printf arg.
9319 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9320 (x_stop_queuing_selection_requests): Likewise.
9321 (x_get_window_property): Don't truncate byte count to an 'int'
9324 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9325 here, since it parses constructs like leading '-' and spaces,
9326 which are not wanted; and it overflows with large numbers.
9327 Instead, simply match F[0-9]+, which is what is wanted anyway.
9329 * alloc.c: Remove unportable assumptions about struct layout.
9330 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9331 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9332 (allocate_vectorlike, make_pure_vector): Use the new macros,
9333 plus offsetof, to remove unportable assumptions about struct layout.
9334 These assumptions hold on all porting targets that I know of, but
9335 they are not guaranteed, they're easy to remove, and removing them
9336 makes further changes easier.
9338 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9339 This doesn't fix a bug but makes the code clearer.
9340 (string_overrun_cookie): Now const. Use initializers that
9341 don't formally overflow signed char, to avoid warnings.
9342 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9343 can cause Emacs to crash when string overrun checking is enabled.
9344 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9345 multiple of sizeof (EMACS_INT); it need not be, if
9346 alignof(EMACS_INT) < sizeof (EMACS_INT).
9347 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9349 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9351 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9353 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9355 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9356 supposed to be handshaking. (Bug#8556)
9357 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9359 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9361 * lisp.h (Qdebug): List symbol.
9362 * eval.c (Qdebug): Restore global linkage.
9363 * keyboard.c (debug-on-event): New variable.
9364 (handle_user_signal): Break into debugger when debug-on-event
9365 matches the current signal symbol.
9367 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9369 * alloc.c (check_sblock, check_string_bytes)
9370 (check_string_free_list): Convert to standard C.
9372 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9374 * w32.c (emacs_gnutls_push): Fix typo.
9376 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9378 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9379 "cast to pointer from integer of different size".
9381 Improve doprnt and its use in verror. (Bug#8545)
9382 * doprnt.c (doprnt): Document the set of format control sequences
9383 supported by the function. Use SAFE_ALLOCA instead of always
9386 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9387 is one byte too soon. Don't use xrealloc; instead xfree and
9390 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9392 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9395 * gnutls.c: Renamed global_initialized to
9396 gnutls_global_initialized. Added internals for the
9397 :verify-hostname-error, :verify-error, and :verify-flags
9398 parameters of `gnutls-boot' and documented those parameters in the
9399 docstring. Start callback support.
9400 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9401 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9402 on error. Return error code.
9403 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9404 (emacs_gnutls_read): Likewise.
9405 (Fgnutls_boot): Return handshake error code.
9406 (emacs_gnutls_handle_error): New function.
9407 (wsaerror_to_errno): Likewise.
9409 * w32.h (emacs_gnutls_pull): Add prototype.
9410 (emacs_gnutls_push): Likewise.
9412 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9413 (emacs_gnutls_push): Likewise.
9415 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9417 * process.c (wait_reading_process_output): Check if GnuTLS
9418 buffered some data internally if no FDs are set for TLS
9421 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9422 (LIBS): Link to USER_LIBS.
9423 ($(BLD)/gnutls.$(0)): New target.
9425 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9427 * xdisp.c (handle_single_display_spec): Rename the
9428 display_replaced_before_p argument into display_replaced_p, to
9429 make it consistent with the commentary. Fix typos in the
9432 * textprop.c (syms_of_textprop): Remove dead code.
9433 (copy_text_properties): Delete obsolete commentary about an
9434 interface that was deleted long ago. Fix typos in the description
9437 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9438 to changes in oldXMenu/XMenu.h from 2011-04-16.
9439 <menu_help_message, prev_menu_help_message>: Constify.
9440 (IT_menu_make_room): menu->help_text is now `const char **';
9443 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9444 to changes in oldXMenu/XMenu.h from 2011-04-16.
9445 (struct XMenu): Declare `help_text' `const char **'.
9447 * xfaces.c <Qunspecified>: Make extern again.
9449 * syntax.c: Include sys/types.h before including regex.h, as
9452 * doc.c (get_doc_string): Improve the format passed to `error'.
9454 * doprnt.c (doprnt): Improve commentary.
9456 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9458 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9461 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9462 changes in globals.h immediately force recompilation.
9463 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9464 $(CURDIR)/s/ms-w32.h.
9465 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9467 * character.c (Fchar_direction): Function deleted.
9468 (syms_of_character): Don't defsubr it.
9469 <char-direction-table>: Deleted.
9471 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9473 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9474 * doprnt.c: Include limits.h.
9475 (SIZE_MAX): New macro.
9476 (doprnt): Return a size_t value. 2nd arg is now size_t.
9477 Many local variables are now size_t instead of int or unsigned.
9478 Improve overflow protection. Support `l' modifier for integer
9479 conversions. Support %l conversion. Don't assume an EMACS_INT
9480 argument for integer conversions and for %c.
9482 * lisp.h (doprnt): Restore prototype.
9484 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9487 * Makefile.in (base_obj): Add back doprnt.o.
9489 * deps.mk (doprnt.o): Add back prerequisites.
9490 (callint.o): Depend on character.h.
9492 * eval.c (internal_lisp_condition_case): Include the handler
9493 representation in the error message.
9494 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9495 when breaking from the loop.
9497 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9499 * callint.c (Fcall_interactively): When displaying error message
9500 about invalid control letter, pass the character's codepoint, not
9501 a pointer to its multibyte form. Improve display of the character
9502 in octal and display also its hex code.
9504 * character.c (char_string): Use %x to display the (unsigned)
9505 codepoint of an invalid character, to avoid displaying a bogus
9508 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9509 `error', not SYMBOL_NAME itself.
9511 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9512 character arguments to `error'.
9514 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9515 to `error' in error message about FINAL_CHAR argument. Make sure
9516 FINAL_CHAR is a character, and use %c when it is passed as
9517 argument to `error'.
9519 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9521 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9523 * w32.c: Include <time.h>.
9524 (sys_localtime): New function.
9526 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9528 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9530 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9532 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9534 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9537 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9539 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9540 gl_state.e_property when gl_state.object is Qt.
9542 * insdel.c (make_gap_larger): Remove limitation of buffer size
9545 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9547 * xdisp.c (lookup_glyphless_char_display)
9548 (produce_glyphless_glyph): Handle cons cell entry in
9549 glyphless-char-display.
9550 (Vglyphless_char_display): Document it.
9552 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9553 glyphless-char-display.
9555 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9557 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9559 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9562 definition for no-X builds.
9564 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9566 Static checks with GCC 4.6.0 and non-default toolkits.
9568 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9570 * process.c (keyboard_bit_set): Define only if SIGIO.
9571 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9572 (send_process): Repair possible setjmp clobbering.
9574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9576 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9578 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9580 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9581 Define only if needed.
9583 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9584 by pacifying GCC about it. Maybe it's time to retire it?
9585 * xfaces.c (USG, __TIMEVAL__): Likewise.
9587 * dispextern.h (struct redisplay_interface): Rename param
9589 * termhooks.h (struct terminal): Likewise.
9590 * xterm.c (xembed_send_message): Likewise.
9592 * insdel.c (make_gap_smaller): Define only if
9593 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9595 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9598 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9599 so that we aren't warned about unused symbols.
9601 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9603 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9605 * xfns.c (x_real_positions): Mark locals as initialized.
9607 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9609 * xterm.c: Fix problems found by static analysis with other toolkits.
9610 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9611 (x_dispatch_event): Declare static if USE_GTK, and
9612 define if USE_GTK || USE_X_TOOLKIT.
9613 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9614 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9615 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9616 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9618 * xmenu.c (menu_help_callback): Pointer type fixes.
9619 Use const pointers when pointing at readonly data. Avoid pointer
9621 (FALSE): Remove unused macro.
9622 (update_frame_menubar): Remove unused decl.
9624 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9626 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9627 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9628 (single_menu_item): Rename local to avoid shadowing.
9630 * keyboard.c (make_lispy_event): Remove unused local var.
9632 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9633 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9635 * bitmaps: Change bitmaps from unsigned char back to the X11
9636 compatible char. Avoid the old compiler warnings about
9637 out-of-range initializers by using, for example, '\xab' rather
9640 * xgselect.c (xgselect_initialize): Check vs interface
9641 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9643 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9645 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9646 to read-only memory.
9648 * fns.c (vector): Remove; this old hack is no longer needed.
9650 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9652 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9654 * xrdb.c (x_load_resources): Omit unused local.
9656 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9657 (x_window): Rename locals to avoid shadowing.
9658 (USG): Use the kludged USG macro, to pacify gcc.
9660 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9661 (x_term_init): Remove local to avoid shadowing.
9663 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9665 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9666 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9668 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9670 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9672 Fix regex.c, syntax.c and friends for buffers > 2GB.
9673 * syntax.h (struct gl_state_s): Declare character position members
9676 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9678 * textprop.c (verify_interval_modification, interval_of):
9679 Declare arguments EMACS_INT.
9681 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9684 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9686 * indent.c (Fvertical_motion): Local variable it_start is now
9689 * regex.c (re_match, re_match_2, re_match_2_internal)
9690 (bcmp_translate, regcomp, regexec, print_double_string)
9691 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9692 (re_compile_pattern, re_exec): Declare arguments and local
9693 variables `size_t' and `ssize_t' and return values `regoff_t', as
9695 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9696 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9697 <compile_stack_type>: `size' and `avail' are now `size_t'.
9699 * regex.h <regoff_t>: Use ssize_t, not int.
9700 (re_search, re_search_2, re_match, re_match_2): Arguments that
9701 specify buffer/string position and length are now ssize_t and
9702 size_t. Return type is regoff_t.
9704 2011-04-16 Ben Key <bkey76@gmail.com>
9706 * nsfont.m: Fixed bugs in ns_get_family and
9707 ns_descriptor_to_entity that were caused by using free to
9708 deallocate memory blocks that were allocated by xmalloc (via
9709 xstrdup). This caused Emacs to crash when compiled with
9710 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9711 --enable-checking=xmallocoverrun). xfree is now used to
9712 deallocate these memory blocks.
9714 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9716 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9718 emacs_write: Accept and return EMACS_INT for sizes.
9719 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9721 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9722 Accept and return EMACS_INT.
9723 (emacs_gnutls_write): Return the number of bytes written on
9725 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9726 (emacs_read, emacs_write): Remove check for negative size, as the
9727 Emacs source code has been audited now.
9728 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9729 (emacs_read, emacs_write): Use it.
9730 * process.c (send_process): Adjust to the new signatures of
9731 emacs_write and emacs_gnutls_write. Do not attempt to store
9732 a byte offset into an 'int'; it might overflow.
9733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9735 * sound.c: Don't assume sizes fit in 'int'.
9736 (struct sound_device.period_size, alsa_period_size):
9737 Return EMACS_INT, not int.
9738 (struct sound_device.write, vox_write, alsa_write):
9739 Accept EMACS_INT, not int.
9740 (wav_play, au_play): Use EMACS_INT to store sizes and to
9741 record read return values.
9743 2011-04-15 Ben Key <bkey76@gmail.com>
9745 * keyboard.c (Qundefined): Don't declare static since it is used
9747 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9748 static since they are used in nsfont.m.
9750 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9752 * process.c (Qprocessp): Don't declare static.
9753 * lisp.h (Qprocessp): Declare again.
9755 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9757 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9759 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9761 Improve C-level modularity by making more things 'static'.
9763 Don't publish debugger-only interfaces to other modules.
9764 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9765 (verify_bytepos, count_markers): Move decls to the only modules
9767 * region-cache.h (pp_cache): Likewise.
9768 * window.h (check_all_windows): Likewise.
9769 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9771 * sysdep.c (croak): Now static, if
9772 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9773 * syssignal.h (croak): Declare only if not static.
9775 * alloc.c (refill_memory_reserve): Now static if
9776 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9777 * lisp.h (refill_memory_reserve): Declare only if not static.
9779 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9780 Define only if USE_LUCID.
9782 * xrdb.c (x_customization_string, x_rm_string): Now static.
9784 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9785 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9787 * xdisp.c (draw_row_with_mouse_face): Now static.
9788 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9790 * window.h (check_all_windows): Mark externally visible.
9792 * window.c (window_deletion_count): Now static.
9794 * undo.c: Make symbols static if they're not exported.
9795 (last_undo_buffer, last_boundary_position, pending_boundary):
9798 * textprop.c (interval_insert_behind_hooks): Now static.
9799 (interval_insert_in_front_hooks): Likewise.
9801 * term.c: Make symbols static if they're not exported.
9802 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9803 (max_frame_lines, tty_set_terminal_modes):
9804 (tty_reset_terminal_modes, tty_turn_off_highlight):
9805 (get_tty_terminal): Now static.
9806 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9807 * termhooks.h (term_mouse_moveto): Do not declare if
9809 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9810 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9812 * sysdep.c: Make symbols static if they're not exported.
9813 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9815 (sigprocmask_set, full_mask): Remove; unused.
9816 (wait_debugging): Mark as visible.
9817 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9818 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9820 * syntax.c (syntax_temp): Define only if !__GNUC__.
9822 * sound.c (current_sound_device, current_sound): Now static.
9824 * search.c (searchbufs, searchbuf_head): Now static.
9826 * scroll.c (scroll_cost): Remove; unused.
9827 * dispextern.h (scroll_cost): Remove decl.
9829 * region-cache.h (pp_cache): Mark as externally visible.
9831 * process.c: Make symbols static if they're not exported.
9832 (process_tick, update_tick, create_process, chan_process):
9833 (Vprocess_alist, proc_buffered_char, datagram_access):
9834 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9835 (deactivate_process): Mark defn as static, as well as decl.
9836 * lisp.h (create_process): Remove decl.
9837 * process.h (chan_process, Vprocess_alist): Remove decls.
9839 * print.c: Make symbols static if they're not exported.
9840 (print_depth, new_backquote_output, being_printed, print_buffer):
9841 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9842 (print_interval, print_number_index, initial_stderr_stream):
9844 * lisp.h (Fprinc): Remove decl.
9845 (debug_output_compilation_hack): Mark as externally visible.
9847 * sysdep.c (croak): Move decl from here to syssignal.h.
9848 * syssignal.h (croak): Put it here, so the API can be checked when
9849 'croak' is called from dissociate_if_controlling_tty.
9851 * minibuf.c: Make symbols static if they're not exported.
9852 (minibuf_save_list, choose_minibuf_frame): Now static.
9853 * lisp.h (choose_minibuf_frame): Remove decl.
9855 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9857 * lread.c: Make symbols static if they're not exported.
9858 (read_objects, initial_obarray, oblookup_last_bucket_number):
9860 (make_symbol): Remove; unused.
9861 * lisp.h (initial_obarray, make_symbol): Remove decls.
9863 * keyboard.c: Make symbols static if they're not exported.
9864 (single_kboard, recent_keys_index, total_keys, recent_keys):
9865 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9866 (this_single_command_key_start, echoing, last_auto_save):
9867 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9868 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9869 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9870 (Vlispy_mouse_stem, double_click_count):
9872 (force_auto_save_soon): Define only if SIGDANGER.
9873 (ignore_mouse_drag_p): Now static if
9874 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9875 (print_help): Remove; unused.
9876 (stop_character, last_timer_event): Mark as externally visible.
9877 * keyboard.h (ignore_mouse_drag_p): Declare only if
9878 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9879 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9880 * lisp.h (echoing): Remove decl.
9881 (force_auto_save_soon): Declare only if SIGDANGER.
9882 * xdisp.c (redisplay_window): Simplify code, to make it more
9883 obvious that ignore_mouse_drag_p is not accessed if !defined
9884 USE_GTK && !defined HAVE_NS.
9886 * intervals.c: Make symbols static if they're not exported.
9887 (merge_properties_sticky, merge_interval_right, delete_interval):
9889 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9891 * insdel.c: Make symbols static if they're not exported.
9892 However, leave prepare_to_modify_buffer alone. It's never
9893 called from outside this function, but that appears to be a bug.
9894 (combine_after_change_list, combine_after_change_buffer):
9895 (adjust_after_replace, signal_before_change): Now static.
9896 (adjust_after_replace_noundo): Remove; unused.
9897 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9898 (signal_before_change): Remove decls.
9900 * indent.c (val_compute_motion, val_vmotion): Now static.
9902 * image.c: Make symbols static if they're not exported.
9903 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9905 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9906 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9908 * fringe.c (standard_bitmaps): Now static.
9909 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9911 * frame.c: Make symbols static if they're not exported.
9912 (x_report_frame_params, make_terminal_frame): Now static.
9913 (get_frame_param): Now static, unless HAVE_NS.
9914 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9915 (x_get_resource_string): Remove; not used.
9916 * frame.h (make_terminal_frame, x_report_frame_params):
9917 (x_get_resource_string); Remove decls.
9918 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9919 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9921 * font.c, fontset.c: Make symbols static if they're not exported.
9922 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9923 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9924 * font.c (font_close_object): Now static.
9925 * font.h (font_close_object): Remove.
9926 * fontset.c (FONTSET_OBJLIST): Remove.
9927 (free_realized_fontset) #if-0 the body, which does nothing.
9928 (face_suitable_for_char_p): #if-0, as it's never called.
9929 * fontset.h (face_suitable_for_char_p): Remove decl.
9930 * xfaces.c (face_at_string_position):
9931 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9932 since 0 is always ASCII.
9934 * fns.c (weak_hash_tables): Now static.
9936 * fileio.c: Make symbols static if they're not exported.
9937 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9938 (Vwrite_region_annotation_buffers): Now static.
9940 * eval.c: Make symbols static if they're not exported.
9941 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9942 * lisp.h (backtrace_list): Remove decl.
9944 * emacs.c: Make symbols static if they're not exported.
9945 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9946 (fatal_error_code, fatal_error_signal_hook, standard_args):
9948 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9949 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9950 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9951 * lisp.h (fatal_error_signal_hook): Remove decl.
9952 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9954 * editfns.c: Move a (normally-unused) function to its only use.
9955 * editfns.c, lisp.h (get_operating_system_release): Remove.
9956 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9957 worth the hassle of breaking this out.
9959 * xterm.c: Make symbols static if they're not exported.
9960 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9961 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9962 (x_destroy_window, x_delete_display):
9964 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9965 (x_mouse_leave): Remove; unused.
9966 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9967 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9968 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9970 (x_mouse_leave): Declare only if WINDOWSNT.
9971 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9972 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9975 * ftxfont.c: Make symbols static if they're not exported.
9976 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9978 * font.h (ftxfont_driver): Likewise.
9980 * xfns.c: Make symbols static if they're not exported.
9981 (x_last_font_name, x_display_info_for_name):
9982 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9983 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9984 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9985 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9986 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9987 (last_show_tip_args): Now static.
9988 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9989 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9990 (x_screen_planes): Remove; unused.
9991 * dispextern.h (x_screen_planes): Remove decl.
9993 * dispnew.c: Make symbols static if they're not exported.
9994 * dispextern.h (redraw_garbaged_frames, scrolling):
9995 (increment_row_positions): Remove.
9996 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9997 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9999 (redraw_garbaged_frames): Remove; unused.
10001 * xfaces.c: Make symbols static if they're not exported.
10002 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10004 * xterm.h (defined_color): Remove decls.
10005 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10006 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10007 (menu_face_changed_default, defined_color, free_realized_face):
10008 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10009 (ascii_face_of_lisp_face): Remove; unused.
10011 * xdisp.c: Make symbols static if they're not exported.
10012 * dispextern.h (scratch_glyph_row, window_box_edges):
10013 (glyph_to_pixel_coords, set_cursor_from_row):
10014 (get_next_display_element, set_iterator_to_next):
10015 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10016 (show_mouse_face): Remove decls
10017 * frame.h (message_buf_print): Likewise.
10018 * lisp.h (pop_message, set_message, check_point_in_composition):
10020 * xterm.h (set_vertical_scroll_bar): Likewise.
10021 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10022 (message_buf_print, scratch_glyph_row, displayed_buffer):
10023 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10024 (get_next_display_element, show_mouse_face, window_box_edges):
10025 (frame_to_window_pixel_xy, check_point_in_composition):
10026 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10027 (glyph_to_pixel_coords): Remove; unused.
10029 * dired.c (file_name_completion): Now static.
10031 * dbusbind.c (xd_in_read_queued_messages): Now static.
10033 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10034 * data.c (circular_list_error): Remove.
10036 * commands.h (last_point_position, last_point_position_buffer):
10037 (last_point_position_window): Remove decls.
10038 * keyboard.c: Make these variables static.
10040 * coding.h (coding, code_convert_region, encode_coding_gap):
10042 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10043 (iso_code_class, detect_coding, code_convert_region): Now static.
10044 (encode_coding_gap): Remove; unused.
10046 * chartab.c (chartab_chars, chartab_bits): Now static.
10048 * charset.h (charset_iso_8859_1): Remove decl.
10049 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10052 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10053 * ccl.c (Vccl_program_table): Now static.
10054 (check_ccl_update): Remove; unused.
10056 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10057 * category.h: ... from here.
10058 * category.c (check_category_table, set_category_set): Now static.
10060 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10061 * lisp.h: Remove these decls.
10063 * buffer.c (buffer_count): Remove unused var.
10065 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10066 so that it's not optimized away.
10067 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10068 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10069 exported only to the debugger.
10071 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10072 * atimer.h (run_all_atimers): Remove; not exported.
10074 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10075 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10076 was inaccessible from Lisp.
10077 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10078 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10080 alloc.c: Import and export fewer symbols, and remove unused items.
10081 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10083 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10084 it's not optimized away by whole-program optimization.
10085 (message_enable_multibyte, free_misc): Remove.
10086 (catchlist, handlerlist, mark_backtrace):
10087 Declare only if BYTE_MARK_STACK.
10088 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10089 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10090 (message_enable_multibyte): Remove decl.
10091 (free_misc, interval_free_list, float_block, float_block_index):
10092 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10093 (cons_free_list, last_marked_index):
10095 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10096 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10097 (mark_backtrace): Define only if BYTE_MARK_STACK.
10098 * xdisp.c (message_enable_multibyte): Now static.
10100 Declare Lisp_Object Q* variables to be 'static' if not exported.
10101 This makes it easier for human readers (and static analyzers)
10102 to see whether these variables are used from other modules.
10103 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10104 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10105 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10106 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10107 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10108 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10109 * xmenu.c, xselect.c:
10110 Declare Q* vars static if they are not used in other modules.
10111 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10112 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10113 Remove decls of unexported vars.
10114 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10116 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10118 Make Emacs functions such as Fatom 'static' by default.
10119 This makes it easier for human readers (and static analyzers)
10120 to see whether these functions can be called from other modules.
10121 DEFUN now defines a static function. To make the function external
10122 so that it can be used in other C modules, use the new macro DEFUE.
10123 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10124 (Finit_image_library):
10125 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10126 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10127 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10128 Remove decls, since these functions are now static.
10129 (Funintern, Fget_internal_run_time): New decls, since these functions
10130 were already external.
10132 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10133 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10134 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10135 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10136 * keyboard.c, keymap.c, lread.c:
10137 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10138 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10139 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10140 Mark functions with DEFUE instead of DEFUN,
10141 if they are used in other modules.
10142 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10143 decls for now-static functions.
10144 * buffer.h (Fdelete_overlay): Remove decl.
10145 * callproc.c (Fgetenv_internal): Mark as internal.
10146 * composite.c (Fremove_list_of_text_properties): Remove decl.
10147 (Fcomposition_get_gstring): New forward static decl.
10148 * composite.h (Fcomposite_get_gstring): Remove decl.
10149 * dired.c (Ffile_attributes): New forward static decl.
10150 * doc.c (Fdocumntation_property): New forward static decl.
10151 * eval.c (Ffetch_bytecode): New forward static decl.
10152 (Funintern): Remove extern decl; now in .h file where it belongs.
10153 * fileio.c (Fmake_symbolic_link): New forward static decl.
10154 * image.c (Finit_image_library): New forward static decl.
10155 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10156 * intervals.h (Fprevious_property_change):
10157 (Fremove_list_of_text_properties): Remove decls.
10158 * keyboard.c (Fthis_command_keys): Remove decl.
10159 (Fcommand_execute): New forward static decl.
10160 * keymap.c (Flookup_key): New forward static decl.
10161 (Fcopy_keymap): Now static.
10162 * keymap.h (Flookup_key): Remove decl.
10163 * process.c (Fget_process): New forward static decl.
10164 (Fprocess_datagram_address): Mark as internal.
10165 * syntax.c (Fsyntax_table_p): New forward static decl.
10166 (skip_chars): Remove duplicate decl.
10167 * textprop.c (Fprevious_property_change): New forward static decl.
10168 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10170 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10171 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10173 * editfns.c (Fformat): Remove unreachable code.
10175 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10177 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10180 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10182 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10183 when at ZV. (Bug#8487)
10185 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10187 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10189 * keyboard.c (parse_tool_bar_item): Likewise.
10190 * sound.c (sound_cleanup, alsa_close): Likewise.
10191 * termcap.c (tgetent): Likewise.
10192 * xfns.c (x_default_font_parameter): Likewise.
10193 * xsettings.c (read_and_apply_settings): Likewise.
10195 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10196 (overrun_check_free): Protoize.
10198 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10200 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10201 since callers should never pass a negative size.
10202 Change the signature to match that of plain 'read' and 'write'; see
10203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10204 * lisp.h: Update prototypes of emacs_write and emacs_read.
10206 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10208 * xdisp.c (redisplay_window): Don't try to determine the character
10209 position of the scroll margin if the window start point w->startp
10210 is outside the buffer's accessible region. (Bug#8468)
10212 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10214 Fix write-region and its subroutines for buffers > 2GB.
10215 * fileio.c (a_write, e_write): Modify declaration of arguments and
10216 local variables to support buffers larger than 2GB.
10217 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10219 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10220 argument, local variables, and return value.
10222 * lisp.h: Update prototypes of emacs_write and emacs_read.
10224 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10226 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10228 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10230 Fix more problems found by GCC 4.6.0's static checks.
10232 * xdisp.c (vmessage): Use a better test for character truncation.
10234 * charset.c (load_charset_map): <, not <=, for optimization,
10235 and to avoid potential problems with integer overflow.
10236 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10237 * casetab.c (set_identity, shuffle): Likewise.
10238 * editfns.c (Fformat): Likewise.
10239 * syntax.c (skip_chars): Likewise.
10241 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10242 This also lets GCC 4.6.0 generate slightly better loop code.
10244 * callint.c (Fcall_interactively): <, not <=, for optimization.
10245 (Fcall_interactively): Count the number of arguments produced,
10246 not the number of arguments given. This is simpler and lets GCC
10247 4.6.0 generate slightly better code.
10249 * ftfont.c: Distingish more carefully between FcChar8 and char.
10250 The previous code passed unsigned char * to a functions like
10251 strlen and xstrcasecmp that expect char *, which does not
10252 conform to the C standard.
10253 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10254 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10255 char * when the C standard requires it.
10257 * keyboard.c (read_char): Remove unused var.
10259 * eval.c: Port to Windows vsnprintf (Bug#8435).
10260 Include <limits.h>.
10261 (SIZE_MAX): Define if the headers do not.
10262 (verror): Do not give up if vsnprintf returns a negative count.
10263 Instead, grow the buffer. This ports to Windows vsnprintf, which
10264 does not conform to C99. Problem reported by Eli Zaretskii.
10265 Also, simplify the allocation scheme, by avoiding the need for
10266 calling realloc, and removing the ALLOCATED variable.
10268 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10270 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10271 But keep the doprint source code for now, as we might revamp it
10272 and use it again (Bug#8435).
10273 * lisp.h (doprnt): Remove.
10274 * Makefile.in (base_obj): Remove doprnt.o.
10275 * deps.mk (doprnt.o): Remove.
10277 error: Print 32- and 64-bit integers portably (Bug#8435).
10278 Without this change, on typical 64-bit hosts error ("...%d...", N)
10279 was used to print both 32- and 64-bit integers N, which relied on
10280 undefined behavior.
10281 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10282 * lisp.h (error, verror): Mark as printf-like functions.
10283 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10284 Report overflow in size calculations when allocating printf buffer.
10285 Do not truncate output string at its first null byte.
10286 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10287 Truncate the output at a character boundary, since vsnprintf does not
10289 * charset.c (check_iso_charset_parameter): Convert internal
10290 character to string before calling 'error', since %c now has the
10292 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10293 overflow when computing char to be passed to 'error'. Do not
10294 pass Lisp_Object to 'error'; pass the integer instead.
10295 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10296 formatted with plain %d.
10298 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10300 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10302 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10304 * xterm.c (x_catch_errors): Remove duplicate declaration.
10306 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10308 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10310 2011-04-10 Jim Meyering <meyering@redhat.com>
10312 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10313 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10314 return ssize_t not "int", and use size_t as the buffer length.
10315 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10316 * gnutls.h: Update declarations.
10317 * process.c (read_process_output): Use ssize_t, to match.
10318 (send_process): Likewise.
10320 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10322 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10324 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10326 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10327 Use unsigned char, to match FcChar8 type definition.
10329 * xterm.c (handle_one_xevent):
10330 * xmenu.c (create_and_show_popup_menu):
10331 * xselect.c (x_decline_selection_request)
10332 (x_reply_selection_request): Avoid type-punned deref of X events.
10334 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10336 Fix some uses of `int' instead of EMACS_INT.
10337 * search.c (string_match_1, fast_string_match)
10338 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10339 (scan_buffer, find_next_newline_no_quit)
10340 (find_before_next_newline, search_command, Freplace_match)
10341 (Fmatch_data): Make some `int' variables be EMACS_INT.
10343 * xdisp.c (display_count_lines): 3rd argument and return value now
10344 EMACS_INT. All callers changed.
10345 (pint2hrstr): Last argument is now EMACS_INT.
10347 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10348 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10349 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10350 (decode_coding_utf_16, decode_coding_emacs_mule)
10351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10352 (decode_coding_ccl, decode_coding_charset)
10353 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10354 (decode_coding_iso_2022, decode_coding_emacs_mule)
10355 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10356 <char_offset, last_offset>: Declare EMACS_INT.
10357 (encode_coding_utf_8, encode_coding_utf_16)
10358 (encode_coding_emacs_mule, encode_invocation_designation)
10359 (encode_designation_at_bol, encode_coding_iso_2022)
10360 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10361 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10363 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10364 (encode_invocation_designation): Last argument P_NCHARS is now
10366 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10367 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10369 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10372 * ccl.c (Fccl_execute_on_string): Declare some variables
10375 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10377 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10379 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10381 * process.c (Fformat_network_address): Doc fix.
10383 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10385 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10387 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10389 * keyboard.c (read_char): Call Lisp function help-form-show,
10390 instead of using internal_with_output_to_temp_buffer.
10391 (Qhelp_form_show): New var.
10392 (syms_of_keyboard): Use DEFSYM macro.
10394 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10396 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10398 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10400 * process.c (Flist_processes): Remove to Lisp.
10401 (list_processes_1): Delete.
10403 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10405 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10407 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10409 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10411 Fix more problems found by GCC 4.6.0's static checks.
10413 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10415 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10417 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10419 * xdisp.c (vmessage): Mark as a printf-like function.
10421 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10423 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10425 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10426 printf-like functions.
10427 (tiff_load): Add casts to remove these marks before passing them
10428 to system-supplied API.
10430 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10432 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10433 This avoids several warnings with gcc -Wstrict-overflow.
10434 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10435 directly, rather than having caller test rule sign. This avoids
10436 some unnecessary tests.
10437 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10438 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10439 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10441 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10442 (xfont_open): Avoid unnecessary tests.
10444 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10446 * composite.h, composite.c (composition_gstring_put_cache):
10447 Use EMACS_INT, not int, for length.
10449 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10450 breaking out part of COMPOSITION_DECODE_RULE.
10451 (COMPOSITION_DECODE_RULE): Use it.
10452 * composite.c (get_composition_id): Remove unused local vars,
10453 by using the new macro.
10455 * textprop.c (set_text_properties_1): Change while to do-while,
10456 since the condition is always true at first.
10458 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10459 (interval_deletion_adjustment): Return unsigned value.
10462 * process.c (list_processes_1, create_pty, read_process_output):
10463 (exec_sentinel): Remove vars that were set but not used.
10464 (create_pty): Remove unnecessary "volatile"s.
10465 (Fnetwork_interface_info): Avoid possibility of int overflow.
10466 (read_process_output): Do adaptive read buffering even if carryover.
10467 (read_process_output): Simplify nbytes computation if buffered.
10469 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10471 * syntax.c (scan_words): Remove var that was set but not used.
10472 (update_syntax_table): Use unsigned instead of int.
10474 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10475 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10476 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10478 * print.c (print_error_message): Avoid int overflow.
10480 * font.c (font_list_entities): Redo for clarity,
10481 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10483 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10484 (font_score): Avoid potential overflow in diff calculation.
10486 * fns.c (substring_both): Remove var that is set but not used.
10487 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10489 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10491 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10492 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10493 can always succeed if overflow has undefined behavior.
10495 * search.c (boyer_moore, wordify): Remove vars set but not used.
10496 (wordify): Omit three unnecessary tests.
10498 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10499 All callers changed. This avoids the need for an unused var.
10501 * casefiddle.c (casify_region): Remove var that is set but not used.
10503 * dired.c (file_name_completion): Remove var that is set but not used.
10505 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10507 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10508 (Finsert_file_contents): Remove unnecessary code checking fd.
10510 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10511 Check for integer overflow on size calculations.
10513 * buffer.c (Fprevious_overlay_change): Remove var that is set
10516 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10517 Remove vars that are set but not used.
10518 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10519 (timer_check_2): Mark vars as initialized.
10521 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10523 * image.c (lookup_image): Remove var that is set but not used.
10524 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10526 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10527 that are set but not used.
10529 * xfns.c (make_invisible_cursor): Don't return garbage
10530 if XCreateBitmapFromData fails (Bug#8410).
10532 * xselect.c (x_get_local_selection, x_handle_property_notify):
10533 Remove vars that are set but not used.
10535 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10536 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10538 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10539 Remove var that is set but not used.
10540 (scroll_bar_windows_size): Now size_t, not int.
10541 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10542 Check for overflow.
10544 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10545 (map_tty_color) [!defined MSDOS]: Likewise.
10547 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10549 * coding.c: Remove vars that are set but not used.
10550 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10551 All callers changed.
10552 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10553 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10554 (decode_coding_charset): Remove vars that are set but not used.
10556 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10557 that is set but not used.
10559 * print.c (print_object): Remove var that is set but not used.
10561 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10562 The gnulib version avoids calling malloc in the usual case,
10563 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10564 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10565 * filelock.c (current_lock_owner): Likewise.
10566 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10567 * sysdep.c: Include allocator.h, careadlinkat.h.
10568 (emacs_no_realloc_allocator): New static constant.
10569 (emacs_readlink): New function.
10570 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10571 ../lib/careadlinkat.h.
10573 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10575 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10576 first non-nil return value).
10578 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10580 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10581 if not defined (Bug#8403).
10583 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10585 * xdisp.c (display_count_lines): Remove parameter `start',
10586 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10587 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10588 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10589 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10590 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10591 and thereabouts. All callers changed.
10592 (get_per_char_metric): Remove parameter `f', unused since
10593 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10595 2011-04-02 Jim Meyering <meyering@redhat.com>
10597 do not dereference NULL upon failed strdup
10598 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10599 (ns_get_family): Likewise.
10601 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10603 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10605 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10607 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10610 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10612 Add lexical binding.
10614 * window.c (Ftemp_output_buffer_show): New fun.
10615 (Fsave_window_excursion):
10616 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10618 * lread.c (lisp_file_lexically_bound_p): New function.
10619 (Fload): Bind Qlexical_binding.
10620 (readevalloop): Remove `evalfun' arg.
10621 Bind Qinternal_interpreter_environment.
10622 (Feval_buffer): Bind Qlexical_binding.
10623 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10625 (syms_of_lread): Declare `lexical-binding'.
10627 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10629 * keyboard.c (eval_dyn): New fun.
10630 (menu_item_eval_property): Use it.
10632 * image.c (parse_image_spec): Use Ffunctionp.
10634 * fns.c (concat, mapcar1): Accept byte-code-functions.
10636 * eval.c (Fsetq): Handle lexical vars.
10637 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10638 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10639 (FletX, Flet): Obey lexical binding.
10640 (Fcommandp): Handle closures.
10641 (Feval): New `lexical' arg.
10642 (eval_sub): New function extracted from Feval. Use it almost
10643 everywhere where Feval was used. Look up vars in lexical env.
10645 (Ffunctionp): Move from subr.el.
10646 (Ffuncall): Handle closures.
10647 (apply_lambda): Remove `eval_flags'.
10648 (funcall_lambda): Handle closures and new byte-code-functions.
10649 (Fspecial_variable_p): New function.
10650 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10651 but without exporting it to Lisp.
10653 * doc.c (Fdocumentation, store_function_docstring):
10654 * data.c (Finteractive_form): Handle closures.
10656 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10659 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10661 (exec_byte_code): New function extracted from Fbyte_code to handle new
10662 calling convention for byte-code-functions. Add new byte-codes.
10664 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10666 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10668 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10670 * xdisp.c (redisplay_internal): Fix prototype.
10672 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10674 * xdisp.c (SCROLL_LIMIT): New macro.
10675 (try_scrolling): Use it when setting scroll_limit.
10676 Limit scrolling to 100 screen lines.
10677 (redisplay_window): Even when falling back on "recentering",
10678 position point in the window according to scroll-conservatively,
10679 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10681 (try_scrolling): When point is above the window, allow searching
10682 as far as scroll_max, or one screenful, to compute vertical
10683 distance from PT to the scroll margin position. This prevents
10684 try_scrolling from unnecessarily failing when
10685 scroll-conservatively is set to a value slightly larger than the
10686 window height. Clean up the case of PT below the margin at bottom
10687 of window: scroll_max can no longer be INT_MAX. When aggressive
10688 scrolling is in use, don't let point enter the opposite scroll
10689 margin as result of the scroll.
10690 (syms_of_xdisp) <scroll-conservatively>: Document the
10691 threshold of 100 lines for never-recentering scrolling.
10693 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10695 * dispextern.h (move_it_by_lines):
10696 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10697 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10698 (message_log_check_duplicate): Remove parameters `prev_bol' and
10699 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10700 (redisplay_internal): Remove parameter `preserve_echo_area',
10701 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10703 * indent.c (Fvertical_motion):
10704 * window.c (window_scroll_pixel_based, Frecenter):
10705 Don't pass `need_y_p' to `move_it_by_lines'.
10707 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10709 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10710 steal a few bits to be more compact.
10711 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10712 Remove unneeded casts.
10714 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10716 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10718 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10719 binding" message (bug#7967).
10721 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10723 Fix more problems found by GCC 4.6.0's static checks.
10725 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10726 Remove unused local var.
10728 * editfns.c (Fmessage_box): Remove unused local var.
10730 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10731 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10732 Omit unused local vars.
10733 * window.c (shrink_windows): Omit unused local var.
10734 * menu.c (digest_single_submenu): Omit unused local var.
10735 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10736 Omit unused local var.
10738 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10739 Don't assume string length fits in int.
10740 (keyremap_step, read_key_sequence): Use size_t for sizes.
10741 (read_key_sequence): Don't check last_real_key_start redundantly.
10743 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10744 instead of alloca (Bug#8344).
10746 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10747 (Fbacktrace_frame): Don't assume nframes fits in int.
10749 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10751 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10754 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10756 * cm.c (calccost): Turn while-do into do-while, for clarity.
10758 * keyboard.c (syms_of_keyboard): Use the same style as later
10759 in this function when indexing through an array. This also
10760 works around GCC bug 48267.
10762 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10764 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10766 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10767 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10769 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10770 This avoids undefined behavior on integer overflow, and is a bit
10771 more convenient anyway since it is compared to a size_t variable.
10773 Variadic C functions now count arguments with size_t, not int.
10774 This avoids an unnecessary limitation on 64-bit machines, which
10775 caused (substring ...) to crash on large vectors (Bug#8344).
10776 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10777 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10778 All variadic functions and their callers changed accordingly.
10779 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10780 * data.c (arith_driver, float_arith_driver): Likewise.
10781 * editfns.c (general_insert_function): Likewise.
10782 * eval.c (struct backtrace.nargs, interactive_p)
10783 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10784 (funcall_lambda, mark_backtrace): Likewise.
10785 * fns.c (concat): Likewise.
10786 * frame.c (x_set_frame_parameters): Likewise.
10787 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10788 0 if not found, not -1. All callers changed.
10790 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10791 (stack_copy_size): Now size_t, not int.
10792 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10794 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10796 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10797 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10798 All callers changed.
10800 * lisp.h (multibyte_char_to_unibyte):
10801 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10802 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10803 * character.h (CHAR_TO_BYTE8):
10804 * cmds.c (internal_self_insert):
10805 * editfns.c (general_insert_function):
10806 * keymap.c (push_key_description):
10807 * search.c (Freplace_match):
10808 * xdisp.c (message_dolog, set_message_1): All callers changed.
10810 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10812 * keyboard.c (safe_run_hook_funcall): New function.
10813 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10814 don't set the hook to nil, but remove the offending function instead.
10815 (Qcommand_hook_internal): Remove, unused.
10816 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10817 Vcommand_hook_internal.
10819 * eval.c (enum run_hooks_condition): Remove.
10820 (funcall_nil, funcall_not): New functions.
10821 (run_hook_with_args): Call each function through a `funcall' argument.
10822 Remove `cond' argument, now redundant.
10823 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10824 (Frun_hook_with_args_until_failure): Adjust accordingly.
10825 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10827 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10829 * dispextern.h (string_buffer_position): Remove declaration.
10831 * print.c (strout): Remove parameter `multibyte', unused since
10832 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10834 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10835 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10836 All callers changed.
10838 * w32.c (_wsa_errlist): Use braces for struct initializers.
10840 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10841 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10842 All callers changed.
10843 (string_buffer_position): Likewise. Also, make static (it's never
10844 used outside xdisp.c).
10845 (cursor_row_p): Remove parameter `w', unused since
10846 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10847 (decode_mode_spec): Remove parameter `precision', introduced during
10848 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10849 All callers changed.
10851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10853 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10855 2011-03-27 Anders Lindgren <andlind@gmail.com>
10857 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10858 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10859 (ns_update_auto_hide_menu_bar): New functions.
10860 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10861 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10862 ns_constrain_all_frames.
10863 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10864 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10866 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10868 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10870 2011-03-27 Glenn Morris <rgm@gnu.org>
10872 * syssignal.h: Replace RETSIGTYPE with void.
10873 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10874 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10875 Replace SIGTYPE with void everywhere.
10876 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10877 * s/template.h (SIGTYPE): Remove commented out definition.
10879 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10881 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10882 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10884 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10886 * w32.c (read_unc_volume): Use parameter `henum', instead of
10887 global variable `wget_enum_handle'.
10889 * keymap.c (describe_vector): Remove parameters `indices' and
10890 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10891 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10893 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10895 * keyboard.c (timer_check): Remove parameter `do_it_now',
10896 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10897 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10898 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10900 * keyboard.c (read_char):
10901 * w32menu.c (w32_menu_display_help):
10902 * xmenu.c (show_help_event, menu_help_callback):
10903 Adjust calls to `show_help_echo'.
10905 * gtkutil.c (xg_maybe_add_timer):
10906 * keyboard.c (readable_events):
10907 * process.c (wait_reading_process_output):
10908 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10910 * insdel.c (adjust_markers_gap_motion):
10911 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10912 (gap_left, gap_right): Don't call it.
10914 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10916 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10917 incurred during fontification.
10919 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10921 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10922 (DEFVAR_PER_BUFFER): Don't pass it.
10924 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10925 (scrolling_window): Don't pass it.
10927 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10929 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10931 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10933 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10934 of variables specific to SELinux and computation of `encoded_absname'.
10936 * image.c (XPutPixel): Remove unused variable `height'.
10938 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10940 * unexw32.c (get_section_info): Remove unused variable `section'.
10942 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10943 (system_process_attributes): Remove unused variable `sess'.
10944 (sys_read): Remove unused variable `err'.
10946 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10947 (w32_wnd_proc): Remove unused variable `isdead'.
10948 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10949 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10950 (x_create_tip_frame): Remove unused variable `tem'.
10952 * w32inevt.c (w32_console_read_socket):
10953 Remove unused variable `no_events'.
10955 * w32term.c (x_draw_composite_glyph_string_foreground):
10956 Remove unused variable `width'.
10958 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10960 * w32term.c (x_set_glyph_string_clipping):
10961 Don't pass uninitialized region to CombineRgn.
10963 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10965 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10966 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10967 (Fx_close_connection): Remove unused variable `i'.
10969 * w32font.c (w32font_draw): Return number of glyphs.
10970 (w32font_open_internal): Remove unused variable `i'.
10971 (w32font_driver): Add missing initializer.
10973 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10974 (fill_in_menu): Remove unused variable `items_added'.
10976 * w32term.c (last_mouse_press_frame): Remove static global variable.
10977 (w32_clip_to_row): Remove unused variable `f'.
10978 (x_delete_terminal): Remove unused variable `i'.
10980 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10981 (NOTHING): Remove unused static global variable.
10982 (uniscribe_check_otf): Remove unused variable `table'.
10983 (uniscribe_font_driver): Add missing initializers.
10985 2011-03-23 Julien Danjou <julien@danjou.info>
10987 * term.c (Fsuspend_tty, Fresume_tty):
10988 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10989 * window.c (temp_output_buffer_show):
10990 * insdel.c (signal_before_change):
10991 * frame.c (Fhandle_switch_frame):
10992 * fileio.c (Fdo_auto_save):
10993 * emacs.c (Fkill_emacs):
10994 * editfns.c (save_excursion_restore):
10995 * cmds.c (internal_self_insert):
10996 * callint.c (Fcall_interactively):
10997 * buffer.c (Fkill_all_local_variables):
10998 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11000 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11001 unconditionally since it does the check itself.
11003 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11005 Fix more problems found by GCC 4.5.2's static checks.
11007 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11008 the first time through the loop, since we know p0 < p1 then.
11009 This also avoids a gcc -Wstrict-overflow warning.
11011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11012 leading to a memory leak, possible in functions like
11013 load_charset_map_from_file that can allocate an unbounded number
11014 of objects (Bug#8318).
11016 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11017 that could (at least in theory) be that large.
11019 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11020 This is less likely to overflow, and avoids undefined behavior if
11021 overflow does occur. All callers changed. Use strtoul to scan
11022 for the unsigned long integer.
11023 (pint2hrstr): Simplify and tune code slightly.
11024 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11026 * scroll.c (do_scrolling): Work around GCC bug 48228.
11027 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11029 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11030 This also avoids a warning with gcc -Wstrict-overflow.
11031 (validate_x_resource_name): Simplify count usage.
11032 This also avoids a warning with gcc -Wstrict-overflow.
11034 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11037 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11039 * process.c (Fmake_network_process): Use socklen_t, not int,
11040 where POSIX says socklen_t is required in portable programs.
11041 This fixes a porting bug on hosts like 64-bit HP-UX, where
11042 socklen_t is wider than int (Bug#8277).
11043 (Fmake_network_process, server_accept_connection):
11044 (wait_reading_process_output, read_process_output):
11047 * process.c: Rename or move locals to avoid shadowing.
11048 (list_processes_1, Fmake_network_process):
11049 (read_process_output_error_handler, exec_sentinel_error_handler):
11050 Rename or move locals.
11051 (Fmake_network_process): Define label "retry_connect" only if needed.
11052 (Fnetwork_interface_info): Fix pointer signedness.
11053 (process_send_signal): Add cast to avoid pointer signedness problem.
11054 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11055 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11057 Make tparam.h and terminfo.c consistent.
11058 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11059 Include tparam.h instead, since it declares them.
11060 * cm.h (PC): Remove extern decl; tparam.h now does this.
11061 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11062 * terminfo.c: Include tparam.h, to check interfaces.
11063 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11064 (tparam): Adjust signature to match interface in tparam.h;
11065 this removes some undefined behavior. Check that outstring and len
11066 are zero, which they always are with Emacs.
11067 * tparam.h (PC, BC, UP): New extern decls.
11069 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11070 (xftfont_open): Rename locals to avoid shadowing.
11072 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11073 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11074 (OTF_TAG_SYM): Omit macro if not needed.
11075 (ftfont_list): Remove unused local.
11076 (get_adstyle_property, ftfont_pattern_entity):
11077 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11078 Rename locals to avoid shadowing.
11080 * xfont.c (xfont_list_family): Mark var as initialized.
11082 * xml.c (make_dom): Now static.
11084 * composite.c (composition_compute_stop_pos): Rename local to
11086 (composition_reseat_it): Remove unused locals.
11087 (find_automatic_composition, composition_adjust_point): Likewise.
11088 (composition_update_it): Mark var as initialized.
11089 (find_automatic_composition): Mark vars as initialized,
11090 with a FIXME (Bug#8290).
11092 character.h: Rename locals to avoid shadowing.
11093 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11094 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11095 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11096 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11097 to avoid shadowing.
11099 * textprop.c (property_change_between_p): Remove; unused.
11101 * intervals.c (interval_start_pos): Now static.
11103 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11105 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11106 Rename locals to avoid shadowing.
11108 * sound.c (wav_play, au_play, Fplay_sound_internal):
11109 Fix pointer signedness.
11110 (alsa_choose_format): Remove unused local var.
11111 (wav_play): Initialize a variable to 0, to prevent undefined
11112 behavior (Bug#8278).
11114 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11116 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11119 clobbering (Bug#8298).
11120 * sysdep.c (sys_subshell): Likewise.
11121 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11123 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11124 This should get cleaned up, so that child_setup has the
11125 same signature on all platforms.
11127 * callproc.c (call_process_cleanup): Now static.
11128 (relocate_fd): Rename locals to avoid shadowing.
11130 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11132 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11133 not to be necessary, and produces flickering.
11135 2011-03-20 Glenn Morris <rgm@gnu.org>
11137 * config.in: Remove file.
11139 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11141 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11142 are now in src/globals.h.
11143 (syms_of_minibuf): Remove spurious & from previous change.
11145 2011-03-20 Leo Liu <sdl.web@gmail.com>
11147 * minibuf.c (completing-read-function): New variable.
11148 (completing-read-default): Rename from completing-read.
11149 (completing-read): Call completing-read-function.
11151 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11153 * xfaces.c (Fx_load_color_file):
11154 Read color file from absolute filename (bug#8250).
11156 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11158 * makefile.w32-in: Update dependencies.
11160 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11162 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11164 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11166 Fix more problems found by GCC 4.5.2's static checks.
11168 * process.c (make_serial_process_unwind, send_process_trap):
11169 (sigchld_handler): Now static.
11171 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11172 That way, the code declares only the vars that it needs.
11173 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11174 * s/cygwin.h (PTY_ITERATION): Likewise.
11175 * s/darwin.h (PTY_ITERATION): Likewise.
11176 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11178 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11179 * process.c (allocate_pty): Don't declare stb unless it's needed.
11181 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11182 (CONSTANTLIM): Remove; unused.
11183 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11184 Define only if needed.
11186 * unexelf.c (unexec): Name an expression,
11187 to avoid gcc -Wbad-function-cast warning.
11188 Use a different way to cause a compilation error if anyone uses
11189 n rather than nn, a way that does not involve shadowing.
11190 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11192 * deps.mk (unexalpha.o): Remove; unused.
11194 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11195 * unexec.h: New file.
11196 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11197 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11198 Depend on unexec.h.
11199 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11200 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11201 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11202 Change as necessary to match prototype in unexec.h.
11204 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11206 (back_comment, skip_chars): Mark vars as initialized.
11208 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11209 Rename locals to avoid shadowing.
11211 * lread.c (read1): Rewrite so as not to use empty "else".
11212 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11214 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11216 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11217 warning when compiling print.c.
11219 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11220 instead of using an uninitialized var.
11221 (font_sort_entities): Mark var as initialized.
11223 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11225 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11226 pointers to constants.
11227 (font_parse_fcname): Remove unused vars.
11228 (font_delete_unmatched): Now static.
11229 (font_get_spec): Remove; unused.
11230 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11231 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11232 Rename or move locals to avoid shadowing.
11234 * fns.c (require_nesting_list, require_unwind): Now static.
11235 (Ffillarray): Rename locals to avoid shadowing.
11237 * floatfns.c (domain_error2): Define only if needed.
11238 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11240 * alloc.c (mark_backtrace): Move decl from here ...
11241 * lisp.h: ... to here, so that it can be checked.
11243 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11244 (Fdefvar): Rewrite so as not to use empty "else".
11245 (lisp_indirect_variable): Name an expression,
11246 to avoid gcc -Wbad-function-cast warning.
11247 (Fdefvar): Rename locals to avoid shadowing.
11249 * callint.c (quotify_arg, quotify_args): Now static.
11250 (Fcall_interactively): Rename locals to avoid shadowing.
11251 Use const pointer when appropriate.
11253 * lisp.h (get_system_name, get_operating_system_release):
11254 Move decls here, to check interfaces.
11255 * process.c (get_operating_system_release): Move decl to lisp.h.
11256 * xrdb.c (get_system_name): Likewise.
11257 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11258 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11259 some of which prompt warnings from gcc -Wbad-function-cast.
11260 (Fformat_time_string, Fencode_time, Finsert_char):
11261 (Ftranslate_region_internal, Fformat):
11262 Rename or remove local vars to avoid shadowing.
11263 (Ftranslate_region_internal): Mark var as initialized.
11265 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11268 * lisp.h (eassert): Check that the argument compiles, even if
11269 ENABLE_CHECKING is not defined.
11271 * data.c (Findirect_variable): Name an expression, to avoid
11272 gcc -Wbad-function-cast warning.
11273 (default_value, arithcompare, arith_driver, arith_error): Now static.
11274 (store_symval_forwarding): Rename local to avoid shadowing.
11275 (Fmake_variable_buffer_local, Fmake_local_variable):
11276 Mark variables as initialized.
11277 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11279 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11280 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11281 Rename locals to avoid shadowing.
11282 (mark_stack): Move local variables into the #ifdef region where
11284 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11285 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11287 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11288 (GC_STRING_CHARS): Remove; not used.
11289 (Fmemory_limit): Cast sbrk's returned value to char *.
11291 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11292 avoids undefined behavior in theory.
11294 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11296 Use functions, not macros, for up- and down-casing (Bug#8254).
11297 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11298 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11299 to use the following functions instead of these macros.
11300 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11301 EMACS_INT, since callers assume the returned value fits in int.
11302 (upcase1): Likewise, for UPCASE_TABLE.
11303 (uppercasep, lowercasep, upcase): New static inline functions.
11304 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11305 the race-condition problem in the old DOWNCASE.
11307 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11308 Rename locals to avoid shadowing.
11309 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11310 (regex_compile, re_search_2, re_match_2_internal):
11311 Remove unused local vars.
11312 (FREE_VAR): Rewrite so as not to use empty "else",
11313 which gcc can warn about.
11314 (regex_compile, re_match_2_internal): Mark locals as initialized.
11315 (RETALLOC_IF): Define only if needed.
11316 (WORDCHAR_P): Likewise. This one is never needed, but is used
11317 only in a comment talking about a compiler bug, so put inside
11318 the #if 0 of that comment.
11319 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11320 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11323 * search.c (boyer_moore): Rename locals to avoid shadowing.
11324 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11325 (PREV_CHAR_BOUNDARY): Likewise.
11327 * search.c (simple_search): Remove unused var.
11329 * dired.c (compile_pattern): Move decl from here ...
11330 * lisp.h: ... to here, so that it can be checked.
11331 (struct re_registers): New forward decl.
11333 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11335 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11337 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11338 Rename locals to avoid shadowing.
11339 (Fvertical_motion): Mark locals as initialized.
11341 * casefiddle.c (casify_object, casify_region): Now static.
11342 (casify_region): Mark local as initialized.
11344 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11346 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11347 New macros, so that the caller can use some names other than
11348 gcpro1, gcpro2, etc.
11349 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11351 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11352 argument, for consistency with GCPRO2_VAR, etc: it is now the
11353 prefix of the variable, not the variable itself. All uses
11355 * dired.c (directory_files_internal, file_name_completion):
11356 Rename locals to avoid shadowing.
11358 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11359 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11360 dired.c's scmp function, had undefined behavior.
11361 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11363 * buffer.h: ... to here, because these macros use current_buffer,
11364 and the new implementation with inline functions needs to have
11365 current_buffer in scope now, rather than later when the macros
11367 (downcase, upcase1): New static inline functions.
11368 (DOWNCASE, UPCASE1): Reimplement using these functions.
11369 This avoids undefined behavior in expressions like
11370 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11371 from race conditions in accessing the global variables
11372 case_temp1 and case_temp2.
11373 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11374 * lisp.h (case_temp1, case_temp2): Remove their decls.
11375 * character.h (ASCII_CHAR_P): Move from here ...
11376 * lisp.h: ... to here, so that the inline functions mentioned
11377 above can use them.
11379 * dired.c (directory_files_internal_unwind): Now static.
11381 * fileio.c (file_name_as_directory, directory_file_name):
11382 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11384 (file_name_as_directory): Use const pointers when appropriate.
11385 (Fexpand_file_name): Likewise. In particular, newdir might
11386 point at constant storage, so make it a const pointer.
11387 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11388 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11390 (Fset_file_times, Finsert_file_contents, auto_save_error):
11391 Rename locals to avoid shadowing.
11393 * minibuf.c (choose_minibuf_frame_1): Now static.
11394 (Ftry_completion, Fall_completions): Rename or remove locals
11395 to avoid shadowing.
11397 * marker.c (bytepos_to_charpos): Remove; unused.
11399 * lisp.h (verify_bytepos, count_markers): New decls,
11400 so that gcc does not warn that these functions aren't declared.
11402 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11403 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11404 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11405 (copy_text): Remove unused local var.
11407 * filelock.c (within_one_second): Now static.
11408 (lock_file_1): Rename local to avoid shadowing.
11410 * buffer.c (fix_overlays_before): Mark locals as initialized.
11411 (fix_start_end_in_overlays): Likewise. This function should be
11412 simplified by using pointers-to-pointers, but that's a different
11414 (switch_to_buffer_1): Now static.
11415 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11416 (report_overlay_modification): Rename locals to avoid shadowing.
11418 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11419 Fix pointer signedness issue.
11420 (sys_subshell): Mark local as volatile if checking for lint,
11421 to suppress a gcc -Wclobbered warning that does not seem to be right.
11422 (MAXPATHLEN): Define only if needed.
11424 * process.c (serial_open, serial_configure): Move decls from here ...
11425 * systty.h: ... to here, so that they can be checked.
11427 * fns.c (get_random, seed_random): Move extern decls from here ...
11428 * lisp.h: ... to here, so that they can be checked.
11430 * sysdep.c (reset_io): Now static.
11431 (wait_for_termination_signal): Remove; unused.
11433 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11434 (copy_keymap_item, append_key, push_text_char_description):
11436 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11437 (DENSE_TABLE_SIZE): Remove; unused.
11438 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11439 (describe_map_tree):
11440 Rename locals to avoid shadowing.
11442 * keyboard.c: Declare functions static if they are not used elsewhere.
11443 (echo_char, echo_dash, cmd_error, top_level_2):
11444 (poll_for_input, handle_async_input): Now static.
11445 (read_char, kbd_buffer_get_event, make_lispy_position):
11446 (make_lispy_event, make_lispy_movement, apply_modifiers):
11447 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11448 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11449 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11450 (read_key_sequence, read_char): Mark locals as initialized.
11451 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11453 * keyboard.h (make_ctrl_char): New decl.
11454 (mark_kboards): Move decl here ...
11455 * alloc.c (mark_kboards): ... from here.
11457 * lisp.h (force_auto_save_soon): New decl.
11459 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11460 (DEFINE_DUMMY_FUNCTION): New macro.
11461 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11463 (main): Add casts to avoid warnings
11464 if GCC considers string literals to be constants.
11466 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11468 * dbusbind.c: Pointer signedness fixes.
11469 (xd_signature, xd_append_arg, xd_initialize):
11470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11472 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11473 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11475 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11476 if GCC considers string literals to be constants.
11477 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11479 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11481 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11482 (print_preprocess, print_object): New macro to fix last change.
11484 * print.c (print_preprocess): Don't forget font objects.
11486 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11488 * emacs.c (USAGE3): Doc fixes.
11490 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11492 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11495 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11497 * lisp.h (VWindow_system, Qfile_name_history):
11498 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11499 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11500 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11502 * w32select.c: Don't #include "keyboard.h".
11503 (run_protected): Add extern declaration for waiting_for_input.
11505 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11506 * w32console.c (detect_input_pending, read_input_pending)
11507 (encode_terminal_code):
11508 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11509 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11510 (w32_system_caret_y, Qfile_name_history):
11511 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11512 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11513 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11514 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11515 * w32proc.c (Qlocal, report_file_error):
11516 * w32term.c (Vwindow_system, updating_frame):
11517 * w32uniscribe.c (initialized, uniscribe_font_driver):
11518 Remove unneeded extern declarations.
11520 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11522 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11524 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11526 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11527 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11528 These macros can no longer be used for assignment.
11530 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11531 Assign struct members directly, instead of using BUF_BEGV etc.
11532 (record_buffer_markers, fetch_buffer_markers): New functions for
11533 recording and fetching special buffer markers.
11534 (set_buffer_internal_1, set_buffer_temp): Use them.
11536 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11538 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11540 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11541 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11543 * xdisp.c (hscroll_window_tree):
11544 (reconsider_clip_changes): Use PT instead of BUF_PT.
11546 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11548 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11549 $(EMACS_ROOT)/lib/intprops.h.
11551 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11553 Fix more problems found by GCC 4.5.2's static checks.
11555 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11556 to unsigned char * to avoid compiler diagnostic.
11557 (xg_free_frame_widgets): Make it clear that a local variable is
11558 needed only if USE_GTK_TOOLTIP.
11559 (gdk_window_get_screen): Make it clear that this macro is needed
11560 only if USE_GTK_TOOLTIP.
11561 (int_gtk_range_get_value): New function, which avoids a diagnostic
11562 from gcc -Wbad-function-cast.
11563 (xg_set_toolkit_scroll_bar_thumb): Use it.
11564 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11565 diagnostic from gcc -Wbad-function-cast.
11566 (get_utf8_string, xg_get_file_with_chooser):
11567 Rename locals to avoid shadowing.
11568 (create_dialog): Move locals to avoid shadowing.
11570 * xgselect.c (xg_select): Remove unused var.
11572 * image.c (four_corners_best): Mark locals as initialized.
11573 (gif_load): Initialize transparent_p to zero (Bug#8238).
11574 Mark another local as initialized.
11575 (my_png_error, my_error_exit): Mark with NO_RETURN.
11577 * image.c (clear_image_cache): Now static.
11578 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11579 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11580 (x_edge_detection): Remove unnecessary cast that
11581 gcc -Wbad-function-cast diagnoses.
11582 (gif_load): Fix pointer signedness.
11583 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11584 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11586 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11588 Improve quality of tests for time stamp overflow.
11589 For example, without this patch (encode-time 0 0 0 1 1
11590 1152921504606846976) returns the obviously-bogus value (-948597
11591 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11592 reports time overflow. See
11593 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11594 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11595 * editfns.c: Include limits.h and intprops.h.
11596 (TIME_T_MIN, TIME_T_MAX): New macros.
11597 (time_overflow): Move earlier, to before first use.
11598 (hi_time, lo_time): New functions, for an accurate test for
11599 out-of-range times.
11600 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11601 (Fget_internal_run_time): Don't assume time_t fits in int.
11602 (make_time): Use list2 instead of Fcons twice.
11603 (Fdecode_time): More accurate test for out-of-range times.
11604 (check_tm_member): New function.
11605 (Fencode_time): Use it, to test for out-of-range times.
11606 (lisp_time_argument): Don't rely on undefined left-shift and
11607 right-shift behavior when checking for time stamp overflow.
11609 * editfns.c (time_overflow): New function, refactoring common code.
11610 (Fformat_time_string, Fdecode_time, Fencode_time):
11611 (Fcurrent_time_string): Use it.
11613 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11614 * dired.c (make_time): Move to ...
11615 * editfns.c (make_time): ... here.
11616 * systime.h: Note the move.
11618 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11620 * fringe.c (update_window_fringes): Remove unused variables.
11622 * unexmacosx.c (copy_data_segment): Also copy __got section.
11625 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11627 * termcap.c [MSDOS]: Include "msdos.h".
11628 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11629 Constify `char *' arguments and their references according to
11630 prototypes in tparam.h.
11632 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11634 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11635 Adapt all references accordingly.
11637 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11639 2011-03-11 Tom Tromey <tromey@redhat.com>
11641 * buffer.c (syms_of_buffer): Remove obsolete comment.
11643 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11645 * termhooks.h (encode_terminal_code): Declare prototype.
11647 * msdos.c (encode_terminal_code): Don't declare prototype.
11649 * term.c (encode_terminal_code): Now external again, used by
11650 w32console.c and msdos.c.
11652 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11653 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11655 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11657 Fix some minor problems found by GCC 4.5.2's static checks.
11659 * fringe.c (update_window_fringes): Mark locals as initialized
11661 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11663 * alloc.c (mark_fringe_data): Move decl from here ...
11664 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11665 to check its interface.
11666 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11668 * fontset.c (free_realized_fontset): Now static.
11669 (Fset_fontset_font): Rename local to avoid shadowing.
11670 (fontset_font): Mark local as initialized.
11671 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11673 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11675 * xselect.c (x_disown_buffer_selections): Remove; not used.
11676 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11677 (x_own_selection, Fx_disown_selection_internal): Rename locals
11678 to avoid shadowing.
11679 (x_handle_dnd_message): Remove local to avoid shadowing.
11681 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11682 so that the caller can use some name other than gcpro1.
11683 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11684 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11685 (Fx_backspace_delete_keys_p):
11686 Use them to avoid shadowing, and rename vars to avoid shadowing.
11687 (x_decode_color, x_set_name, x_window): Now static.
11688 (Fx_create_frame): Add braces to silence GCC warning.
11689 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11690 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11691 Remove unused locals.
11692 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11693 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11694 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11697 * xterm.h (x_mouse_leave): New decl.
11699 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11700 Remove unused functions.
11701 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11702 (x_calc_absolute_position): Now static.
11703 (XTread_socket): Don't define label "out" unless it's used.
11704 Don't declare local "event" unless it's used.
11705 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11706 unless they are used.
11707 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11708 (x_fatal_error_signal): Remove; not used.
11709 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11710 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11711 (x_error_catcher, x_connection_closed, x_error_handler):
11712 (x_error_quitter, xembed_send_message, x_iconify_frame):
11713 (my_log_handler): Rename locals to avoid shadowing.
11714 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11715 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11717 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11718 Rename or move locals to avoid shadowing.
11719 (tty_defined_color, merge_face_heights): Now static.
11720 (free_realized_faces_for_fontset): Remove; not used.
11721 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11722 does not deduce is never used uninitialized.
11723 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11724 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11726 * terminal.c (store_terminal_param): Now static.
11728 * xmenu.c (menu_highlight_callback): Now static.
11729 (set_frame_menubar): Remove unused local.
11730 (xmenu_show): Rename parameter to avoid shadowing.
11731 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11732 since they might point to immutable storage.
11733 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11734 since it's unused otherwise.
11736 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11737 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11738 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11739 avoids a gcc -Wuninitialized diagnostic.
11740 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11741 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11742 does not deduce are never used uninitialized.
11744 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11746 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11747 * window.c (window_loop, size_window):
11748 (run_window_configuration_change_hook, enlarge_window): Likewise.
11750 * window.c (display_buffer): Now static.
11751 (size_window): Mark variables that gcc -Wuninitialized
11752 does not deduce are never used uninitialized.
11753 * window.h (check_all_windows): New decl, to forestall
11754 gcc -Wmissing-prototypes diagnostic.
11755 * dispextern.h (bidi_dump_cached_states): Likewise.
11757 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11759 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11760 Include <limits.h>.
11761 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11762 and to avoid gcc -Wuninitialized warning.
11763 (load_charset_map): Mark variables that gcc -Wuninitialized
11764 does not deduce are never used uninitialized.
11765 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11767 * coding.c (coding_set_source, coding_set_destination):
11768 Use "else { /* comment */ }" rather than "else /* comment */;"
11769 for clarity, and to avoid gcc -Wempty-body warning.
11770 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11771 a block, when the outer 'i' will do.
11772 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11773 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11775 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11776 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11777 Rename locals to avoid shadowing.
11778 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11779 * coding.c (emacs_mule_char, encode_invocation_designation):
11780 Now static, since they're not used elsewhere.
11781 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11782 (decode_coding_object, encode_coding_object, detect_coding_system):
11783 (decode_coding_emacs_mule): Mark variables that gcc
11784 -Wuninitialized does not deduce are never used uninitialized.
11785 (detect_coding_iso_2022): Initialize a local variable that might
11786 be used uninitialized. Leave a FIXME because it's not clear that
11787 this initialization is needed. (Bug#8211)
11788 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11789 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11790 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11791 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11792 Remove unused macros.
11794 * category.c (hash_get_category_set): Remove unused local var.
11795 (copy_category_table): Now static, since it's not used elsewhere.
11796 * character.c (string_count_byte8): Likewise.
11798 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11799 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11801 * chartab.c (copy_sub_char_table): Now static, since it's not used
11803 (sub_char_table_ref_and_range, char_table_ref_and_range):
11804 Rename locals to avoid shadowing.
11805 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11807 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11808 (BIDI_BOB): Remove unused macro.
11810 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11811 deduce are never used uninitialized.
11812 * term.c (encode_terminal_code): Likewise.
11814 * term.c (encode_terminal_code): Now static. Remove unused local.
11816 * tparam.h: New file.
11817 * term.c, tparam.h: Include it.
11818 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11819 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11820 Move these decls to tparam.h, and make them agree with what
11821 is actually in tparam.c. The previous trick of using incompatible
11822 decls in different modules does not conform to the C standard.
11823 All callers of tparam changed to use tparam's actual API.
11824 * tparam.c (tparam1, tparam, tgoto):
11825 Use const pointers where appropriate.
11827 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11828 * cm.h (struct cm): Likewise.
11829 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11830 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11831 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11832 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11833 (turn_on_face, init_tty): Likewise.
11834 * termchar.h (struct tty_display_info): Likewise.
11836 * term.c (term_mouse_position): Rename local to avoid shadowing.
11838 * alloc.c (mark_ttys): Move decl from here ...
11839 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11841 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11843 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11845 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11847 * search.c (compile_pattern_1): Remove argument regp, unused since
11848 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11849 (compile_pattern): Don't pass it.
11851 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11853 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11854 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11856 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11858 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11860 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11861 gdk_window_get_screen, gdk_window_get_geometry,
11862 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11863 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11864 (xg_get_pixbuf_from_pixmap): New function.
11865 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11866 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11867 Call xg_get_pixbuf_from_pixmap instead of
11868 gdk_pixbuf_get_from_drawable.
11869 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11870 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11871 (xg_check_special_colors): Use GtkStyleContext and its functions
11873 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11874 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11875 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11876 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11877 Call gtk_widget_get_preferred_size.
11878 (xg_frame_resized): gdk_window_get_geometry only takes 5
11880 (xg_win_to_widget, xg_event_is_for_menubar):
11881 Call gdk_x11_window_lookup_for_display.
11882 (xg_set_widget_bg): New function.
11883 (delete_cb): New function.
11884 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11885 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11886 (xg_set_background_color): Call xg_set_widget_bg.
11887 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11888 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11889 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11890 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11892 (update_frame_tool_bar): Call gtk_widget_hide.
11893 (xg_initialize): Use GDK_KEY_g.
11895 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11897 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11899 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11900 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11901 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11903 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11905 * w32xfns.c (select_palette): Check success of RealizePalette against
11906 GDI_ERROR, not zero.
11908 See ChangeLog.11 for earlier changes.
11910 ;; Local Variables:
11914 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11916 This file is part of GNU Emacs.
11918 GNU Emacs is free software: you can redistribute it and/or modify
11919 it under the terms of the GNU General Public License as published by
11920 the Free Software Foundation, either version 3 of the License, or
11921 (at your option) any later version.
11923 GNU Emacs is distributed in the hope that it will be useful,
11924 but WITHOUT ANY WARRANTY; without even the implied warranty of
11925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11926 GNU General Public License for more details.
11928 You should have received a copy of the GNU General Public License
11929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.